Timeline
Jan 3, 2009:
- 10:19 PM Changeset in webkit [39577] by
-
- 3 edits in trunk/JavaScriptCore
2009-01-03 Sam Weinig <sam@webkit.org>
Reviewed by Oliver Hunt.
Change the pcVector from storing native code pointers to storing offsets
from the base pointer. This will allow us to generate the pcVector on demand
for exceptions.
- bytecode/CodeBlock.h: (JSC::PC::PC): (JSC::getNativePCOffset): (JSC::CodeBlock::getBytecodeIndex):
- jit/JIT.cpp: (JSC::JIT::privateCompile):
- 7:22 PM Changeset in webkit [39576] by
-
- 7 edits in trunk
Bug 23091: Some webarchive http tests intermittently fail due to Connection/Keep-Alive header differences
Reviewed by Darin Adler.
WebKitTools:
- DumpRenderTree/mac/DumpRenderTree.mm: (normalizeHTTPResponseHeaderFields): Remove Keep-Alive and Connection headers from webarchive results.
LayoutTests:
Updated test results after removing Keep-Alive and Connection
headers from webarchive tests.
- http/tests/webarchive/test-css-url-encoding-expected.webarchive:
- http/tests/webarchive/test-css-url-encoding-shift-jis-expected.webarchive:
- http/tests/webarchive/test-css-url-encoding-utf-8-expected.webarchive:
- http/tests/webarchive/test-preload-resources-expected.webarchive:
- 12:00 PM Applications using WebKit edited by
- formatting correction (diff)
- 11:59 AM Applications using WebKit edited by
- Added Google Chrome (diff)
- 11:52 AM Changeset in webkit [39575] by
-
- 7 edits in trunk/WebKit/gtk
[GTK] Fix the reference counting of WebKitWebFrames
The ownership is the following: WebKitWebView owns a WebCore::Page.
WebKitWebView is creating one WebKitWebFrame which will be the
mainFrame of the WebCore::Page (having the reference on the Frame).
The FrameLoaderClient has the reference of the WebKitWebFrame for
the main frame and also any other frame. This means when the
WebCore::Frame goes away the FrameLoaderClient will go away which
will normally remove the last reference of the WebKitWebFrame. Because
an API user might have g_object_ref'ed the WebKitWebFrame null
checks had to be added to WebKitWebFrame.
For WebCore::Frames created by the FrameLoaderClient the ownership
will be passed down to the FrameTree, the WebKitWebFrame is not holding
a reference to the WebCore::Frame.
Do not g_object_unref the mainFrame in the destructor of the
WebKitWebFrame as this will happen from within the WebCore::Page
destruction. Do not hold a reference to the WebCore::Frame (circle) in
WebKitWebFrame, add null checks as the WebCore::Frame might have gone
away. Do not keep track of the FrameLoaderClient in the private
structures as it was mostly unusued.
- 8:48 AM Changeset in webkit [39574] by
-
- 4 edits4 adds in trunk
Reviewed by Darin.
https://bugs.webkit.org/show_bug.cgi?id=22660
SVG elements that are moved are nor fully invalidated/earsed
Mark the SVG root as needing a layout when its position changes.
Tests: svg/custom/circle-move-invalidation.svg
- 12:21 AM Changeset in webkit [39573] by
-
- 2 edits in trunk/WebCore
Build fix.
- loader/FrameLoader.h:
Jan 2, 2009:
- 9:23 PM Changeset in webkit [39572] by
-
- 2 edits in trunk/JavaScriptCore
Build fix.
- 8:36 PM Changeset in webkit [39571] by
-
- 7 edits3 adds in trunk
Build fix. Include FrameState.h
- 7:08 PM Changeset in webkit [39570] by
-
- 2 edits in trunk/WebKit/gtk
Build fix. Include FrameState.h
- 6:35 PM Changeset in webkit [39569] by
-
- 2 edits in trunk/WebCore
2009-01-02 Cary Clark <caryclark@google.com>
Reviewed and landed by Darin Adler.
Bug 22963: write icons before reading them
https://bugs.webkit.org/show_bug.cgi?id=22963
Reverse the order in the icon database main thread loop to
write the pending icons to the database before trying
to read any requested icons. This ensures that a requested icon
has the correct data when read.
- loader/icon/IconDatabase.cpp: (WebCore::IconDatabase::syncThreadMainLoop):
- 6:33 PM Changeset in webkit [39568] by
-
- 2 edits in trunk/WebCore
2009-01-02 Darin Adler <Darin Adler>
- loader/FrameLoader.cpp: (WebCore::FrameLoader::loadItem): One small thing I forgot in my last check-in. This cuts down on the number of hash table operations during loading.
- 6:27 PM Changeset in webkit [39567] by
-
- 3 edits in trunk/WebCore
2009-01-02 Dmitry Titov <dimich@chromium.org>
Reviewed and landed by Darin.
https://bugs.webkit.org/show_bug.cgi?id=23025
DOMTimer lifetime cleanup: timeoutMap methods on Document now do not delete the timer.
Instead, all 3 places that delete timers do it directly calling 'delete' and then timer's dtor removes the ID from the timeoutMap.
Note that in case the context is destroyed and timers are deleted at once, the check in ~DOMTimer() prevents
unnecessary HashMap remove in case the Document is being destroyed.
- bindings/js/DOMTimer.cpp: (WebCore::DOMTimer::~DOMTimer): removes the id from the timeoutMap. (WebCore::DOMTimer::install): (WebCore::DOMTimer::removeById): simply uses 'delete this'. (WebCore::DOMTimer::fired): same. (WebCore::DOMTimer::contextDestroyed): same.
- dom/Document.cpp: (WebCore::Document::removeTimeout): now it only removes the id from the map, does not delete the timer.
- 6:04 PM Changeset in webkit [39566] by
-
- 10 edits in trunk
WebCore:
2009-01-02 Darin Adler <Darin Adler>
Reviewed by Sam Weinig.
Bug 23072: REGRESSION (r37371): In the Dictionary application, scroll bar appears
inside its web view when resizing its window
https://bugs.webkit.org/show_bug.cgi?id=23072
rdar://problem/6368028
The first attempt at fixing this did not work.
This time I was able to reproduce the bug and test the fix.
Bug 11212: REGRESSION: Activity window doesn't always list all files until refresh
https://bugs.webkit.org/show_bug.cgi?id=11212
rdar://problem/4959702
I had to fix this second bug because otherwise the WebKit code to trigger the first
fix didn't run.
Also fixes memory use that kept growing as we maintained a set of all URLs loaded in
a particular frame. Bad idea! It's bad enough that we do it for each document, but
the old version kept the set around forever as you moved from one document to the next.
- html/HTMLFrameElementBase.cpp: (WebCore::HTMLFrameElementBase::parseMappedAttribute): Change this so that we allow turning off scrolling when the quirk is enabled. We just don't allow turning it on. This fixes one of the two problems with the initial patch; the other fix is in WebKit.
- loader/DocumentLoader.h: Moved didTellClientAboutLoad and haveToldClientAboutLoad here from FrameLoader. The old way meant that a given frame would forever remember the URL of any resources loaded in that frame and never send any "loaded from cache" client calls about those URLs.
- loader/FrameLoader.cpp: (WebCore::FrameLoader::loadResourceSynchronously): Removed call to didTellCientAboutLoad. This is now handled by dispatchWillSendRequest, which is safer since that's the actual function that tells the client about the load. (WebCore::FrameLoader::loadedResourceFromMemoryCache): Changed calls to haveToldClientAboutLoad and didTellClientAboutLoad to call the document loader. Also removed the call in the case where we don't load from the cache, since dispatchWillSendRequest now takes care of it. (WebCore::FrameLoader::dispatchWillSendRequest): Put calls to didTellClientAboutLoad here. Call it both on the URL we pass in and the URL the client returns; we won't tell the client about either if it's loaded from the memory cache.
- loader/FrameLoader.h: Removed didTellClientAboutLoad, haveToldClientAboutLoad, and m_urlsClientKnowsAbout.
- loader/SubresourceLoader.cpp: Removed unneeded load function that called didTellClientAboutLoad. That's now taken care of in dispatchWillSendRequest.
- loader/SubresourceLoader.h: Removed load function. Also made all members private except for create and clearClient.
WebKit/mac:
2009-01-02 Darin Adler <Darin Adler>
Reviewed by Sam Weinig.
Bug 23072: REGRESSION (r37371): In the Dictionary application, scroll bar appears
inside its web view when resizing its window
https://bugs.webkit.org/show_bug.cgi?id=23072
rdar://problem/6368028
The first attempt at fixing this did not work.
This time I was able to reproduce the bug and test the fix.
- WebCoreSupport/WebFrameLoaderClient.mm: (applyAppleDictionaryApplicationQuirkNonInlinePart): Changed the arguments and function names around a bit to make even less code at the call site. (applyAppleDictionaryApplicationQuirk): Put the check for whether this is the Dictionary application in here. (WebFrameLoaderClient::dispatchDidLoadResourceFromMemoryCache): Put a call to applyAppleDictionaryApplicationQuirk here. This was a case I had missed before, when the script is cached. This fixes one of the two problems with the initial patch; the other fix is in WebCore. (WebFrameLoaderClient::dispatchWillSendRequest): Changed the applyAppleDictionaryApplicationQuirk call here to work the new simpler way.
- WebView/WebView.mm: Had to add an include due to changes in WebCore header includes.
- 5:13 PM Changeset in webkit [39565] by
-
- 7 edits in trunk/LayoutTests/platform/mac/fast
Set the svn:mime-type property of recently-added PNG files to image/png.
- 5:06 PM Changeset in webkit [39564] by
-
- 3 edits5 adds in trunk
2009-01-02 Simon Fraser <Simon Fraser>
Reviewed by Darin Adler
Fix GIF animation by ensuring that the signature of
startAnimation() in the base class matches the method in BitmapImage.
Test: fast/backgrounds/animated-gif-as-background.html
- platform/graphics/Image.h: (WebCore::Image::startAnimation):
- 4:25 PM Changeset in webkit [39563] by
-
- 14 edits2 adds in trunk
2009-01-02 David Smith <catfish.man@gmail.com>
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=22699
Enable NodeList caching for getElementsByTagName
- wtf/HashFunctions.h: Moved the definition of PHI here and renamed to stringHashingStartValue
WebCore:
2009-01-02 David Smith <catfish.man@gmail.com>
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=22699
Enable NodeList caching for getElementsByTagName
test: fast/dom/getelementsbytagnamens-mixed-namespaces.html
- dom/Document.cpp: (WebCore::FormElementKeyHash::hash): Use WTF::stringHashingStartValue
- dom/Node.cpp: (WebCore::Node::getElementsByTagNameNS): Ensure rare data and add a node list cache (WebCore::NodeListsNodeData::invalidateCaches): Invalidate the tag name node list cache as well as the others (WebCore::NodeListsNodeData::isEmpty): Check the tag name node list cache as well as the others
- dom/NodeRareData.h: Add m_tagNodeListCaches
- dom/QualifiedName.cpp:
- dom/QualifiedName.h: Move QNameHash to the header, make it work on QualifiedNames, and rename to QualifiedNameHash
- dom/StyledElement.cpp: (WebCore::MappedAttributeHash::hash): Use WTF::stringHashingStartValue
- dom/TagNodeList.cpp: (WebCore::TagNodeList::TagNodeList): Add a NodeList cache argument
- dom/TagNodeList.h: (WebCore::TagNodeList::create): Add a NodeList cache argument
- platform/text/StringHash.h: (WebCore::CaseFoldingHash::hash): Use WTF::stringHashingStartValue
- platform/text/TextEncodingRegistry.cpp: (WebCore::TextEncodingNameHash::hash): Use WTF::stringHashingStartValue
LayoutTests:
2009-01-02 David Smith <catfish.man@gmail.com>
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=22699
Enable NodeList caching for getElementsByTagName
- fast/dom/getelementsbytagnamens-mixed-namespaces-expected.txt: Added.
- fast/dom/getelementsbytagnamens-mixed-namespaces.html: Added.
- 4:02 PM Changeset in webkit [39562] by
-
- 3 edits2 adds in trunk
2009-01-02 Eric Carlson <eric.carlson@apple.com>
Reviewed by Darin Adler
Fix for https://bugs.webkit.org/show_bug.cgi?id=23066 & <rdar://problem/6028417>
Full Page Zoom: a <video> element that doesn't include width/height attribute does not scale
- rendering/RenderVideo.cpp: (WebCore::RenderVideo::calcReplacedWidth): Multiply aspect ratio width by style()->effectiveZoom() (WebCore::RenderVideo::calcReplacedHeight): Multiply aspect ratio height by style()->effectiveZoom()
2009-01-02 Eric Carlson <eric.carlson@apple.com>
Reviewed by Darin Adler
https://bugs.webkit.org/show_bug.cgi?id=23066 & <rdar://problem/6028417>
Full Page Zoom: a <video> element that doesn't include width/height attribute does not scale
Add test for <video> zoom with and without width/height attributes
- media/video-zoom.html: Added.
- platform/mac/media/video-zoom-expected.txt: Added.
- 2:19 PM Changeset in webkit [39561] by
-
- 4 edits in trunk/WebCore
BUILD FIX (r39552): Add mediaControls.css to other build files
- GNUmakefile.am:
- WebCore.pro:
- WebCore.vcproj/WebCore.vcproj:
- 1:52 PM Changeset in webkit [39560] by
-
- 2 edits in trunk/WebCore
Try to fix Wx build after r39427
- platform/graphics/wx/PathWx.cpp: (WebCore::Path::strokeBoundingRect): Added stub.
- 1:47 PM Changeset in webkit [39559] by
-
- 2 edits in trunk/WebCore
Reviewed by Adele Peterson.
<rdar://problem/6471356> Failed assertion on quit
- platform/ThreadGlobalData.cpp: (WebCore::ThreadGlobalData::~ThreadGlobalData): Only assert that empty string are all removed on secondary threads.
- 1:25 PM Changeset in webkit [39558] by
-
- 2 edits in trunk/JavaScriptCore
Attempt to fix Qt Linux build after r39553
- wtf/RandomNumberSeed.h: Include <sys/time.h> for gettimeofday(). Include <sys/types.h> and <unistd.h> for getpid().
- 1:22 PM Changeset in webkit [39557] by
-
- 3 edits in trunk/WebCore
2009-01-02 Simon Fraser <Simon Fraser>
Reviewed by Darin Adler
Use an OwnPtr for m_chromeClient.
- svg/graphics/SVGImage.cpp: (WebCore::SVGImage::~SVGImage): (WebCore::SVGImage::dataChanged):
- svg/graphics/SVGImage.h:
- 1:10 PM Changeset in webkit [39556] by
-
- 21 edits in trunk
Bug 23081: These files are no longer part of the KDE libraries
Reviewed by Darin Adler.
Removed "This file is part of the KDE libraries" comment from
source files. Added or updated Apple copyrights as well.
- parser/Lexer.h:
- wtf/HashCountedSet.h:
- wtf/RetainPtr.h:
- wtf/VectorTraits.h:
WebCore:
No tests since there are only changes to comments.
- bridge/testbindings.cpp:
- html/HTMLEntityNames.gperf:
- loader/Cache.h:
- loader/CachedCSSStyleSheet.h:
- loader/CachedResourceClient.h:
- loader/CachedResourceClientWalker.cpp:
- loader/CachedResourceClientWalker.h:
- loader/CachedScript.cpp:
- loader/CachedScript.h:
- loader/CachedXBLDocument.cpp:
- loader/CachedXBLDocument.h:
- loader/CachedXSLStyleSheet.cpp:
- loader/CachedXSLStyleSheet.h:
- rendering/GapRects.h:
- xml/XMLSerializer.cpp:
- 1:04 PM Changeset in webkit [39555] by
-
- 30 edits24 adds in trunk
2009-01-02 Simon Fraser <Simon Fraser>
Reviewed by Darin Adler
Repaints inside of an SVGImage were thrown on the floor,
which broke incremental painting due to loading, or SVG animation.
Fix this by assigning the SVGImage a ChromeClient subclass that passes
along repaints via a new method on ImageObserver, which also takes
a rect parameter for the changed rect, allowing incremental repaints.
Fix RenderImage::imageChanged to take advantage of this changedRect to
only repaint the changed parts of the image.
This also enables incremental painting for canvas-as-image, so
add tests for that too.
Tests: fast/backgrounds/animated-svg-as-background.html
fast/backgrounds/animated-svg-as-mask.html
fast/canvas/canvas-as-image-incremental-repaint.html
fast/canvas/canvas-as-image.html
fast/images/animated-svg-as-image.html
- 12:59 PM Changeset in webkit [39554] by
-
- 38 edits in trunk/JavaScriptCore
Bug 23080: Remove last vestiges of KJS references
Reviewed by Darin Adler.
Also updated Apple copyright statements.
- DerivedSources.make: Changed bison "kjsyy" prefix to "jscyy".
- GNUmakefile.am: Ditto.
- JavaScriptCore.pri: Ditto. Also changed KJSBISON to JSCBISON and kjsbison to jscbison.
- JavaScriptCoreSources.bkl: Changed JSCORE_KJS_SOURCES to JSCORE_JSC_SOURCES.
- jscore.bkl: Ditto.
- create_hash_table: Updated copyright and removed old comment.
- parser/Grammar.y: Changed "kjsyy" prefix to "jscyy" prefix.
- parser/Lexer.cpp: Ditto. Also changed KJS_DEBUG_LEX to JSC_DEBUG_LEX. (jscyylex): (JSC::Lexer::lex):
- parser/Parser.cpp: Ditto. (JSC::Parser::parse):
- pcre/dftables: Changed "kjs_pcre_" prefix to "jsc_pcre_".
- pcre/pcre_compile.cpp: Ditto. (getOthercaseRange): (encodeUTF8): (compileBranch): (calculateCompiledPatternLength):
- pcre/pcre_exec.cpp: Ditto. (matchRef): (getUTF8CharAndIncrementLength): (match):
- pcre/pcre_internal.h: Ditto. (toLowerCase): (flipCase): (classBitmapForChar): (charTypeForChar):
- pcre/pcre_tables.cpp: Ditto.
- pcre/pcre_ucp_searchfuncs.cpp: Ditto. (jsc_pcre_ucp_othercase):
- pcre/pcre_xclass.cpp: Ditto. (getUTF8CharAndAdvancePointer): (jsc_pcre_xclass):
- runtime/Collector.h: Updated header guards using the clean-header-guards script.
- runtime/CollectorHeapIterator.h: Added missing header guard.
- runtime/Identifier.h: Updated header guards.
- runtime/JSFunction.h: Fixed end-of-namespace comment.
- runtime/JSGlobalObject.cpp: (JSC::JSGlobalObject::reset): Renamed "kjsprint" debug function to "jscprint". Changed implementation method from globalFuncKJSPrint() to globalFuncJSCPrint().
- runtime/JSGlobalObjectFunctions.cpp: (JSC::globalFuncJSCPrint): Renamed from globalFuncKJSPrint().
- runtime/JSGlobalObjectFunctions.h: Ditto.
- runtime/JSImmediate.h: Updated header guards.
- runtime/JSLock.h: Ditto.
- runtime/JSType.h: Ditto.
- runtime/JSWrapperObject.h: Ditto.
- runtime/Lookup.h: Ditto.
- runtime/Operations.h: Ditto.
- runtime/Protect.h: Ditto.
- runtime/RegExp.h: Ditto.
- runtime/UString.h: Ditto.
- tests/mozilla/js1_5/Array/regress-157652.js: Changed "KJS" reference in comment to "JSC".
- wrec/CharacterClassConstructor.cpp: Change "kjs_pcre_" function prefixes to "jsc_pcre_". (JSC::WREC::CharacterClassConstructor::put): (JSC::WREC::CharacterClassConstructor::flush):
- wtf/unicode/Unicode.h: Change "KJS_" header guard to "WTF_".
- wtf/unicode/icu/UnicodeIcu.h: Ditto.
- wtf/unicode/qt4/UnicodeQt4.h: Ditto.
- 12:17 PM Changeset in webkit [39553] by
-
- 3 edits in trunk/JavaScriptCore
Make randomNumber generate 253 values instead of 232 (or 231 for rand() platforms)
Reviewed by Maciej Stachowiak
- 10:33 AM Changeset in webkit [39552] by
-
- 5 edits1 add in trunk/WebCore
2009-01-02 Eric Carlson <eric.carlson@apple.com>
Reviewed by Darin Adler
Pull media controls css out of html4.css into separate file. Don't generate
wml, svg, or media css globals unless the feature is enabled.
- DerivedSources.make:
Don't include css for unused features.
- WebCore.xcodeproj/project.pbxproj:
include mediaControls.css
- css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::styleForElement):
don't parse or add media css unless VIDEO feature is enabled and the target
element is video or audio
- css/html4.css:
moved media controls css to mediaControls.css
- css/mediaControls.css: Added.
- 10:11 AM Changeset in webkit [39551] by
-
- 2 edits in trunk/JavaScriptCore
Remove declaration for JSC::Identifier::initializeIdentifierThreading()
Reviewed by Alexey Proskuryakov.
- runtime/Identifier.h: (JSC::Identifier::initializeIdentifierThreading): Removed declaration since the implementation was removed in r34412.
- 9:44 AM Changeset in webkit [39550] by
-
- 2 edits6 adds in trunk/LayoutTests
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=23076
Add tests for application cache manifest parse failures
- http/tests/appcache/resources/.htaccess:
- http/tests/appcache/resources/wrong-content-type.manifest: Added.
- http/tests/appcache/resources/wrong-signature.manifest: Added.
- http/tests/appcache/wrong-content-type-expected.txt: Added.
- http/tests/appcache/wrong-content-type.html: Added.
- http/tests/appcache/wrong-signature-expected.txt: Added.
- http/tests/appcache/wrong-signature.html: Added.
- 7:18 AM Changeset in webkit [39549] by
-
- 2 edits in trunk/WebKit/mac
2009-01-02 Cameron Zwarich <cwzwarich@uwaterloo.ca>
Reviewed by Darin Adler.
Bug 23060: REGRESSION (r38629): Cannot scroll a WebHTMLView using Home/End/Page up/Page down
<https://bugs.webkit.org/show_bug.cgi?id=23060>
<rdar://problem/6467830>
After r38629, all keyboard events get sent by Editor to the EditorClient, even
if the selection is not editable. If the event's command is unsupported by
WebHTMLView, WebHTMLView mistakenly thinks that the event was handled when it
was not. When using the page up / page down keys, the events generated are of
the form scrollPageUp rather than movePageUp, so they are unsupported by
WebHTMLView and cause this bug to occur.
- WebView/WebHTMLView.mm: (-[WebHTMLView doCommandBySelector:]):
- 3:12 AM Changeset in webkit [39548] by
-
- 8 edits4 adds in trunk
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=23022
Fix multiple issues with appcache online whitelist handling
Test: http/tests/appcache/online-whitelist.html
- loader/appcache/ApplicationCache.cpp: (WebCore::ApplicationCache::isURLInOnlineWhitelist): Test whitelist entries as prefixes, making it possible to use them for CGI invocation (as required by HTML5).
- loader/DocumentLoader.cpp: (WebCore::DocumentLoader::shouldLoadResourceFromApplicationCache): Re-ordered checks, so that resources that are cached, but are also listed in online whitelist are loaded from the cache. This is required by HTML5, although Firefox doesn't match.
- loader/appcache/ManifestParser.cpp: (WebCore::parseManifest):
- loader/appcache/ManifestParser.h:
- loader/appcache/ApplicationCache.h: (WebCore::ApplicationCache::onlineWhitelist):
- loader/appcache/ApplicationCacheStorage.cpp: (WebCore::ApplicationCacheStorage::store): (WebCore::ApplicationCacheStorage::loadCache): Changed online whitelist to be a vector of URLs, which is better suited for the new algorithm.
- 1:27 AM Changeset in webkit [39547] by
-
- 10 edits in trunk
WebCore:
2009-01-02 Darin Adler <Darin Adler>
Reviewed by Oliver Hunt.
Bug 23072: REGRESSION (r37371): In the Dictionary application, scroll bar appears inside its web view when resizing its window
https://bugs.webkit.org/show_bug.cgi?id=23072
rdar://problem/6368028
- WebCore.base.exp: Updated.
- WebCore.xcodeproj/project.pbxproj: Mark HTMLHeadElement.h Private so it can be used in WebKit.
- dom/Document.cpp: (WebCore::Document::Document): Initialize m_frameElementsShouldIgnoreScrolling to false.
- dom/Document.h: Added setFrameElementsShouldIgnoreScrolling, frameElementsShouldIgnoreScrolling, and m_frameElementsShouldIgnoreScrolling.
- html/HTMLFrameElementBase.cpp: (WebCore::HTMLFrameElementBase::parseMappedAttribute): Don't allow changes to the scrolling attribute to affect the scrolling mode if frameElementsShouldIgnoreScrolling() returns true. This is only triggered on Mac OS X when running the Dictionary application.
WebKit:
2009-01-02 Darin Adler <Darin Adler>
- StringsNotToBeLocalized.txt: Updated.
WebKit/mac:
2009-01-02 Darin Adler <Darin Adler>
Reviewed by Oliver Hunt.
Bug 23072: REGRESSION (r37371): In the Dictionary application, scroll bar appears inside its web view when resizing its window
https://bugs.webkit.org/show_bug.cgi?id=23072
rdar://problem/6368028
- WebCoreSupport/WebFrameLoaderClient.mm: (isAppleDictionaryApplication): Added. (applyAppleDictionaryApplicationQuirk): Added. Under the right conditions, sets a flag to ask HTMLFrameElementBase to ignore the scrolling attribute. (WebFrameLoaderClient::dispatchWillSendRequest): Call the two functions above to apply the quirk when the relevant script is loaded.
- 1:25 AM Changeset in webkit [39546] by
-
- 17 edits4 adds in trunk
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=23036
<rdar://problem/6451666> Implement AppCache fallback entries (23036)
Test: http/tests/appcache/fallback.html
- loader/FrameLoader.cpp: (WebCore::FrameLoader::loadResourceSynchronously): Use fallback entries if normal loading fails.
- loader/DocumentLoader.cpp: (WebCore::DocumentLoader::shouldLoadResourceFromApplicationCache): Do not prevent normal loading for resources that match fallback namespaces - they are only loaded from the cache if that fails. (WebCore::DocumentLoader::getApplicationCacheFallbackResource): Get a fallback entry for resource from associated appcache, or from passed in one, if any. (WebCore::DocumentLoader::scheduleLoadFallbackResourceFromApplicationCache): If a fallback entry for resourse exists, add it to pending substitute loads.
- loader/DocumentLoader.h: Added new functions for loading fallback data for resources.
- loader/ResourceLoader.h:
- loader/ResourceLoader.cpp: (WebCore::ResourceLoader::scheduleLoadFallbackResourceFromApplicationCache): This function is called when normal loading fails (which includes network failures, 4xx and 5xx responses, and cross-origin redirects) to load appcache fallback data instead. It can use either the cache that is associated with the browsing context, or a custom one if association is yet to take place. (WebCore::ResourceLoader::willSendRequest): Try using fallback data. (WebCore::ResourceLoader::didReceiveResponse): Ditto. (WebCore::ResourceLoader::didFail): Ditto.
- loader/MainResourceLoader.cpp: (WebCore::MainResourceLoader::didReceiveResponse): Locate an appropriate cache and load fallback data from it if loading fails. The browsing context may still be associated with its previous document here, so the cache to load from must be passed explicitly. (WebCore::MainResourceLoader::didFail): Ditto. (WebCore::MainResourceLoader::load): Remove unnecessary check and FIXME.
- loader/appcache/ApplicationCache.cpp: (WebCore::ApplicationCache::setFallbackURLs): (WebCore::ApplicationCache::urlMatchesFallbackNamespace):
- loader/appcache/ApplicationCache.h: (WebCore::ApplicationCache::fallbackURLs):
- loader/appcache/ApplicationCacheStorage.cpp: (WebCore::ApplicationCacheStorage::cacheGroupForURL): (WebCore::ApplicationCacheStorage::fallbackCacheGroupForURL): (WebCore::ApplicationCacheStorage::store): (WebCore::ApplicationCacheStorage::loadCache): (WebCore::ApplicationCacheStorage::storeCopyOfCache):
- loader/appcache/ApplicationCacheStorage.h:
- loader/appcache/ApplicationCacheGroup.cpp: (WebCore::ApplicationCacheGroup::fallbackCacheForMainRequest): (WebCore::ApplicationCacheGroup::didFinishLoadingManifest):
- loader/appcache/ApplicationCacheGroup.h: Implement fallback map saving and loading, pass it to the cache.
- loader/appcache/ManifestParser.h: Use a correct data structure for fallback map - keys are matched by prefix, so HAshMap cannot be used.
- loader/appcache/ManifestParser.cpp: (WebCore::parseManifest): Fix bugs in fallback section parsing.
