Timeline
Jan 4, 2009:
- 11:25 PM Changeset in webkit [39595] by
-
- 4 edits3 adds in trunk
WebCore:
2009-01-04 Darin Adler <Darin Adler>
Reviewed by Oliver Hunt.
Bug 23105: canvas setFillColor function ignores alpha argument
https://bugs.webkit.org/show_bug.cgi?id=23105
Test: fast/canvas/set-colors.html
- html/CanvasRenderingContext2D.cpp: (WebCore::CanvasRenderingContext2D::setFillColor): Pass alpha value through instead of ignoring it and always passing 1.
- html/CanvasStyle.cpp: (WebCore::CanvasStyle::applyStrokeColor): Fix spelling of transparent in comments. (WebCore::CanvasStyle::applyFillColor): Ditto.
LayoutTests:
2009-01-04 Darin Adler <Darin Adler>
Reviewed by Oliver Hunt.
Bug 23105: canvas setFillColor function ignores alpha argument
https://bugs.webkit.org/show_bug.cgi?id=23105
- fast/canvas/resources/set-colors.js: Added.
- fast/canvas/set-colors-expected.txt: Added.
- fast/canvas/set-colors.html: Added.
- 9:41 PM Changeset in webkit [39594] by
-
- 2 edits in trunk/WebCore
2009-01-04 Darin Adler <Darin Adler>
Bug 23086: REGRESSION(r39540/r39541): Windows build fails due to ICU errors
https://bugs.webkit.org/show_bug.cgi?id=23086
- editing/TextIterator.cpp: Check UCONFIG_NO_COLLATION and don't compile in the new search path if it's 0.
- 4:18 PM Changeset in webkit [39593] by
-
- 3 edits in trunk/JavaScriptCore
2009-01-04 Alice Liu <alice.liu@apple.com>
<rdar://problem/6341776> Merge m_transitionCount and m_offset in Structure.
Reviewed by Darin Adler.
- runtime/Structure.cpp: (JSC::Structure::Structure): Remove m_transitionCount (JSC::Structure::addPropertyTransitionToExistingStructure): No need to wait until after the assignment to offset to assert if it's notFound; move it up. (JSC::Structure::addPropertyTransition): Use method for transitionCount instead of m_transitionCount. Remove line that maintains the m_transitionCount. (JSC::Structure::changePrototypeTransition): Remove line that maintains the m_transitionCount. (JSC::Structure::getterSetterTransition): Remove line that maintains the m_transitionCount.
- runtime/Structure.h: Changed s_maxTransitionLength and m_offset from size_t to signed char. m_offset will never become greater than 64 because the structure transitions to a dictionary at that time. (JSC::Structure::transitionCount): method to replace the data member
- 1:09 PM Changeset in webkit [39592] by
-
- 4 edits4 adds in trunk
Don't install internal headers in WebKit framework
Reviewed by Darin Adler.
WebKit:
- WebKit.xcodeproj/project.pbxproj: Remove roles from internal headers so they're not installed.
WebKitTools:
Since WebHTMLRepresentationInternal.h and WebTypesInternal.h are
no longer installed in WebKit.framework/PrivateHeaders, use the
special relationship of DumpRenderTree within the WebKit source
tree to include the internal headers through relative paths.
Created the concept of mac/InternalHeaders to hide the ugly
paths.
- DumpRenderTree/mac/Configurations/Base.xcconfig: Added mac/InternalHeaders to HEADER_SEARCH_PATHS.
- DumpRenderTree/mac/InternalHeaders/WebKit/WebHTMLRepresentationInternal.h: Added.
- DumpRenderTree/mac/InternalHeaders/WebKit/WebTypesInternal.h: Added.
- 12:14 PM Changeset in webkit [39591] by
-
- 4 edits in trunk
Fixed change log entry dates.
- 11:57 AM Changeset in webkit [39590] by
-
- 2 edits in trunk/WebCore
Don't install *.idl and *.in files as resources
Reviewed by Oliver Hunt.
Don't install these files as resources in the WebCore framework:
- WMLAttributeNames.in
- WMLTagNames.in
- WorkerContext.idl
- WorkerLocation.idl
- WorkerNavigator.idl
- WebCore.xcodeproj/project.pbxproj: Removed resources.
- 11:10 AM Changeset in webkit [39589] by
-
- 3 edits in trunk/LayoutTests
2009-01-04 Simon Fraser <Simon Fraser>
Fix the expected image to account for a typo fix done on 2008-12-23.
- platform/mac/fast/transforms/identity-matrix-expected.checksum:
- platform/mac/fast/transforms/identity-matrix-expected.png:
- 10:38 AM Changeset in webkit [39588] by
-
- 3 edits4 adds in trunk
2009-01-04 Simon Fraser <Simon Fraser>
Reviewed by Darin Adler
If an object gets a Layout hint, and the style change will result in
the creation of a RenderLayer, then we need to repaint the old position
of the object. This was done for transform, but we have to test opacity too.
Test: fast/repaint/create-layer-repaint.html
- rendering/RenderObject.cpp: (WebCore::RenderObject::styleWillChange):
- 10:24 AM Changeset in webkit [39587] by
-
- 2 edits in trunk/WebCore
2009-01-04 Darin Adler <Darin Adler>
Reviewed by Dan Bernstein.
Bug 23103: Safari's auto-fill no longer works for <select> elements
https://bugs.webkit.org/show_bug.cgi?id=23103
rdar://problem/6472061
- bindings/objc/DOMHTML.mm: (-[DOMHTMLSelectElement _activateItemAtIndex:]): Implemented this.
- 10:23 AM Changeset in webkit [39586] by
-
- 4 edits in trunk
Fixed change log entry dates.
- 10:00 AM Changeset in webkit [39585] by
-
- 2 edits in trunk/JavaScriptCore
2009-01-04 Darin Adler <Darin Adler>
Reviewed by David Kilzer.
Bug 15114: Provide compile-time assertions for sizeof(UChar), sizeof(DeprecatedChar), etc.
https://bugs.webkit.org/show_bug.cgi?id=15114
- wtf/unicode/Unicode.h: Assert size of UChar. There is no DeprecatedChar any more.
- 9:39 AM Changeset in webkit [39584] by
-
- 4 edits in trunk/WebKit/qt
Add new API to QWebHitTestResult to return a rect for the smallest enclosing
block element of the hit test
- 9:28 AM Changeset in webkit [39583] by
-
- 2 edits in trunk/WebKit/win
Make the apple windows port build with the new fixedLayoutSize feature
- 9:26 AM Changeset in webkit [39582] by
-
- 2 edits in trunk/WebKit/gtk
Make the gtk port build with the new fixedLayoutSize feature
- 9:25 AM Changeset in webkit [39581] by
-
- 9 edits3 adds in trunk
Make the qt port build and work with the new fixedLayoutSize feature
- 9:25 AM Changeset in webkit [39580] by
-
- 10 edits in trunk/WebCore
Add fixedLayoutSize feature to ScrollView to allow for controlling the
layout beyond the constraint of the current viewports dynamic size
- 6:26 AM Changeset in webkit [39579] by
-
- 2 edits in trunk/LayoutTests
2009-01-04 Darin Adler <Darin Adler>
Suggested by Dan Bernstein.
- platform/mac/editing/selection/move-left-right-expected.txt: Remove WARNING lines that are no longer showing up. Dan said he didn't know why we were seeing those before and why they're gone now, but it's good that they're gone.
- 6:12 AM Changeset in webkit [39578] by
-
- 2 edits in trunk/LayoutTests
2009-01-03 Darin Adler <Darin Adler>
Reviewed by Dan Bernstein.
Bug 23095: REGRESSION: fast/text/find-case-folding.html regression test failing when ICU used for text search
https://bugs.webkit.org/show_bug.cgi?id=23095
- fast/text/find-case-folding.html: Work around this ICU bug in the test for now. Later we might want to work around it in our search code instead, or in addition, if we can figure out how to do that.
Jan 3, 2009:
- 10:19 PM Changeset in webkit [39577] by
-
- 3 edits in trunk/JavaScriptCore
2009-01-03 Sam Weinig <sam@webkit.org>
Reviewed by Oliver Hunt.
Change the pcVector from storing native code pointers to storing offsets
from the base pointer. This will allow us to generate the pcVector on demand
for exceptions.
- bytecode/CodeBlock.h: (JSC::PC::PC): (JSC::getNativePCOffset): (JSC::CodeBlock::getBytecodeIndex):
- jit/JIT.cpp: (JSC::JIT::privateCompile):
- 7:22 PM Changeset in webkit [39576] by
-
- 7 edits in trunk
Bug 23091: Some webarchive http tests intermittently fail due to Connection/Keep-Alive header differences
Reviewed by Darin Adler.
WebKitTools:
- DumpRenderTree/mac/DumpRenderTree.mm: (normalizeHTTPResponseHeaderFields): Remove Keep-Alive and Connection headers from webarchive results.
LayoutTests:
Updated test results after removing Keep-Alive and Connection
headers from webarchive tests.
- http/tests/webarchive/test-css-url-encoding-expected.webarchive:
- http/tests/webarchive/test-css-url-encoding-shift-jis-expected.webarchive:
- http/tests/webarchive/test-css-url-encoding-utf-8-expected.webarchive:
- http/tests/webarchive/test-preload-resources-expected.webarchive:
- 12:00 PM Applications using WebKit edited by
- formatting correction (diff)
- 11:59 AM Applications using WebKit edited by
- Added Google Chrome (diff)
- 11:52 AM Changeset in webkit [39575] by
-
- 7 edits in trunk/WebKit/gtk
[GTK] Fix the reference counting of WebKitWebFrames
The ownership is the following: WebKitWebView owns a WebCore::Page.
WebKitWebView is creating one WebKitWebFrame which will be the
mainFrame of the WebCore::Page (having the reference on the Frame).
The FrameLoaderClient has the reference of the WebKitWebFrame for
the main frame and also any other frame. This means when the
WebCore::Frame goes away the FrameLoaderClient will go away which
will normally remove the last reference of the WebKitWebFrame. Because
an API user might have g_object_ref'ed the WebKitWebFrame null
checks had to be added to WebKitWebFrame.
For WebCore::Frames created by the FrameLoaderClient the ownership
will be passed down to the FrameTree, the WebKitWebFrame is not holding
a reference to the WebCore::Frame.
Do not g_object_unref the mainFrame in the destructor of the
WebKitWebFrame as this will happen from within the WebCore::Page
destruction. Do not hold a reference to the WebCore::Frame (circle) in
WebKitWebFrame, add null checks as the WebCore::Frame might have gone
away. Do not keep track of the FrameLoaderClient in the private
structures as it was mostly unusued.
- 8:48 AM Changeset in webkit [39574] by
-
- 4 edits4 adds in trunk
Reviewed by Darin.
https://bugs.webkit.org/show_bug.cgi?id=22660
SVG elements that are moved are nor fully invalidated/earsed
Mark the SVG root as needing a layout when its position changes.
Tests: svg/custom/circle-move-invalidation.svg
- 12:21 AM Changeset in webkit [39573] by
-
- 2 edits in trunk/WebCore
Build fix.
- loader/FrameLoader.h:
