⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Jan 5, 2009:

11:39 PM Changeset in webkit [39642] by dsmith@webkit.org
  • 3 edits in trunk/WebCore

2009-01-05 David Smith <​catfish.man@gmail.com>

Reviewed by Oliver Hunt.

​https://bugs.webkit.org/show_bug.cgi?id=23084
Avoid redundant AtomicString conversions

  • dom/Node.cpp: Create an AtomicString early to avoid converting twice (WebCore::Node::getElementsByTagNameNS):
  • dom/QualifiedName.h: Use the appropriate AtomicString constructor instead of converting from a String
10:13 PM Changeset in webkit [39641] by ddkilzer@apple.com
  • 8 edits in trunk/WebKit

WebKit/mac:

2009-01-05 David Kilzer <​ddkilzer@apple.com>

Add SPI to enable, disable and check state of WebIconDatabase

Reviewed by Darin Adler & Timothy Hatcher.

Add -[WebIconDatabase isEnabled] and -[WebIconDatabase setEnabled:]
SPI to make it possible to enable, disable and check the state of
the icon database.

  • Misc/WebIconDatabase.mm: (-[WebIconDatabase init]): Extracted code into -_startUpIconDatabase. (-[WebIconDatabase iconForURL:withSize:cache:]): Switched to use -isEnabled instead of -_isEnabled. (-[WebIconDatabase iconURLForURL:]): Ditto. (-[WebIconDatabase retainIconForURL:]): Ditto. (-[WebIconDatabase releaseIconForURL:]): Ditto. (-[WebIconDatabase isEnabled]): Renamed from -_isEnabled in WebInternal category. (-[WebIconDatabase setEnabled:]): Added. Takes care of changing the enabled/disabled state of the icon database. (-[WebIconDatabase removeAllIcons]): Switched to use -isEnabled instead of -_isEnabled. (-[WebIconDatabase _startUpIconDatabase]): Added. Extrated from -init. (-[WebIconDatabase _shutDownIconDatabase]): Added. Remove observers when the icon database is disabled.
  • Misc/WebIconDatabaseInternal.h: Added declarations for -_startUpIconDatabase and -_shutDownIconDatabase.
  • Misc/WebIconDatabasePrivate.h: Added declarations for -isEnabled and -setEnabled:.

WebKit/win:

2009-01-05 David Kilzer <​ddkilzer@apple.com>

Add API to enable, disable and check state of WebIconDatabase

Reviewed by Darin Adler & Timothy Hatcher.

Add WebIconDatabase::isEnabled() and WebIconDatabase::setEnabled()
API to make it possible to enable, disable and check the state of
the icon database.

  • Interfaces/IWebIconDatabase.idl: Declared isEnabled() and setEnabled() methods.
  • WebIconDatabase.cpp: (WebIconDatabase::init): Extracted code into startUpIconDatabase(). (WebIconDatabase::startUpIconDatabase): Added. Extracted from init(). (WebIconDatabase::shutDownIconDatabase): Added. Method is empty since there is nothing to do yet on Windows. (isEnabled): Added. (setEnabled): Added.
  • WebIconDatabase.h: Added method declarations.
9:37 PM Changeset in webkit [39640] by Simon Fraser
  • 4 edits in trunk/WebCore

2009-01-05 Simon Fraser <Simon Fraser>

Reviewed by Dave Hyatt

​https://bugs.webkit.org/show_bug.cgi?id=22985

Add an assertion that clip rects are being used when painting with the same
rootLayer that they were computed with.

Fix two issues detected by the assertion:

RenderLayer::updateClipRects() should not unconditionally update the clip rects
on its parent, but stop when reaching rootLayer (just like calculateClipRects()).

We need to pass the temporaryClipRects flag down through reflection painting
to handle the case of nested reflections.

Also use temporary clip rects in RenderTreeAsText, since that code does not
reset the painting root for transformed layers, so cached clip rects will not
match those used for painting.

  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::RenderLayer): (WebCore::RenderLayer::paintLayer): (WebCore::RenderLayer::updateClipRects): (WebCore::RenderLayer::clearClipRects):
  • rendering/RenderLayer.h:
  • rendering/RenderTreeAsText.cpp: (WebCore::writeLayers):
9:15 PM Changeset in webkit [39639] by treat@webkit.org
  • 2 edits in trunk/WebCore

Fix the Qt build

9:12 PM Changeset in webkit [39638] by mrowe@apple.com
  • 2 edits in trunk/WebCore

Fix the build some more.

  • platform/graphics/cairo/AffineTransformCairo.cpp:

(WebCore::TransformationMatrix::TransformationMatrix):

8:20 PM Changeset in webkit [39637] by oliver@apple.com
  • 2 edits in trunk/WebCore

Fix gtk build

8:08 PM Changeset in webkit [39636] by beidson@apple.com
  • 3 edits in trunk/WebKit/mac

2009-01-05 Brady Eidson <​beidson@apple.com>

Reviewed by Jon Honeycutt

Expose setting the last-visit-was-failure flag on a history items in preparation for <rdar://problem/6173319>

  • History/WebHistoryItem.mm: (-[WebHistoryItem _setLastVisitWasFailure:]):
  • History/WebHistoryItemPrivate.h:
7:00 PM Changeset in webkit [39635] by dino@apple.com
  • 141 edits
    2 moves in trunk/WebCore

2009-01-05 Dean Jackson <​dino@apple.com>

Reviewed by Darin Adler.

Rename AffineTransform to TransformationMatrix in
preparation for future enhancements (non-affine matrices)

​https://bugs.webkit.org/show_bug.cgi?id=22943

  • GNUmakefile.am:
  • WebCore.pro:
  • WebCore.scons:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • WebCoreSources.bkl:
  • platform/graphics/transforms/AffineTransform.cpp: Removed.
  • platform/graphics/transforms/AffineTransform.h: Removed.
  • platform/graphics/transforms/TransformationMatrix.cpp: Copied from WebCore/platform/graphics/transforms/AffineTransform.cpp.
  • platform/graphics/transforms/TransformationMatrix.h: Copied from WebCore/platform/graphics/transforms/AffineTransform.h.
  • lots of other files with s/AffineTransform/TransformationMatrix/g
6:35 PM Changeset in webkit [39634] by dino@apple.com
  • 43 edits
    5 adds in trunk

2008-01-05 Dean Jackson <​dino@apple.com>

Reviewed by David Hyatt.

Implement 'pointer-events' for HTML content. This involved
adding a new value 'auto' which behaves as 'visiblePainted'
in SVG content.

Moved the property out of the SVG CSS code and into
the general CSS (both parsing and RenderStyle).

Changes to the hit testing functionality of the Render tree,
specifically the nodeAtPoint methods. Where they used to
test for visibility, they now use a helper function defined
on base classes (RenderObject and InlineBox) that checks both
visibility and pointer-events.

​https://bugs.webkit.org/show_bug.cgi?id=11395

Tests: fast/events/pointer-events-2.html

fast/events/pointer-events.html

  • css/CSSComputedStyleDeclaration.cpp: (WebCore::): (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
  • css/CSSParser.cpp: (WebCore::CSSParser::parseValue):
  • css/CSSPrimitiveValueMappings.h: (WebCore::CSSPrimitiveValue::CSSPrimitiveValue): (WebCore::CSSPrimitiveValue::operator EPointerEvents):
  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::applyProperty):
  • css/SVGCSSComputedStyleDeclaration.cpp: (WebCore::CSSComputedStyleDeclaration::getSVGPropertyCSSValue):
  • css/SVGCSSStyleSelector.cpp: (WebCore::CSSStyleSelector::applySVGProperty):
  • manual-tests/pointer-events.html: Added.
  • rendering/EllipsisBox.cpp: (WebCore::EllipsisBox::nodeAtPoint):
  • rendering/InlineBox.h: (WebCore::InlineBox::visibleToHitTesting):
  • rendering/InlineFlowBox.cpp: (WebCore::InlineFlowBox::nodeAtPoint):
  • rendering/InlineTextBox.cpp: (WebCore::InlineTextBox::nodeAtPoint):
  • rendering/PointerEventsHitRules.cpp: (WebCore::PointerEventsHitRules::PointerEventsHitRules):
  • rendering/PointerEventsHitRules.h: (WebCore::PointerEventsHitRules::):
  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::nodeAtPoint):
  • rendering/RenderBox.cpp: (WebCore::RenderBox::nodeAtPoint):
  • rendering/RenderObject.h: (WebCore::RenderObject::visibleToHitTesting):
  • rendering/RenderPath.cpp: (WebCore::RenderPath::nodeAtPoint):
  • rendering/RenderSVGImage.cpp: (WebCore::RenderSVGImage::nodeAtPoint):
  • rendering/RenderSVGText.cpp: (WebCore::RenderSVGText::nodeAtPoint):
  • rendering/RootInlineBox.cpp: (WebCore::RootInlineBox::nodeAtPoint):
  • rendering/TextControlInnerElements.cpp: (WebCore::SearchFieldCancelButtonElement::defaultEventHandler):
  • rendering/style/RenderStyle.h: (WebCore::): (WebCore::InheritedFlags::setBitDefaults): (WebCore::InheritedFlags::pointerEvents): (WebCore::InheritedFlags::setPointerEvents): (WebCore::InheritedFlags::initialPointerEvents):
  • rendering/style/RenderStyleConstants.h: (WebCore::):
  • rendering/style/SVGRenderStyle.h: (WebCore::SVGRenderStyle::InheritedFlags::operator==): (WebCore::SVGRenderStyle::setBitDefaults):
  • rendering/style/SVGRenderStyleDefs.h:
  • css/CSSValueKeywords.in:
  • css/SVGCSSValueKeywords.in:
5:50 PM Changeset in webkit [39633] by alice.liu@apple.com
  • 1 edit in trunk/WebCore/DerivedSources.cpp

Build fix from 39625

5:37 PM Changeset in webkit [39632] by oliver@apple.com
  • 2 edits in trunk/JavaScriptCore

Fix Wx build.

5:34 PM Changeset in webkit [39631] by alice.liu@apple.com
  • 4 edits in trunk/JavaScriptCore

2009-01-05 Oliver Hunt <​oliver@apple.com>

Windows build fixes

Rubber-stamped by Alice Liu.

  • interpreter/Interpreter.cpp: (JSC::Interpreter::Interpreter):
  • runtime/ByteArray.cpp: (JSC::ByteArray::create):
  • runtime/ByteArray.h:
5:27 PM Changeset in webkit [39630] by andersca@apple.com
  • 3 edits in trunk/WebKit/win

2009-01-05 Anders Carlsson <​andersca@apple.com>

Reviewed by Jon Honeycutt.

Pass more information in the property bag passed to embeddedViewWithArguments.


  • Interfaces/IWebUIDelegatePrivate.idl: Declare new keys.


  • WebCoreSupport/WebFrameLoaderClient.cpp: (WebFrameLoaderClient::createPlugin): Pass the base URL, MIME type and the containing element to embeddedViewWithArguments.
5:16 PM Changeset in webkit [39629] by andersca@apple.com
  • 2 edits in trunk/WebKit/win

2009-01-05 Anders Carlsson <​andersca@apple.com>

Reviewed by Darin Adler, Jon Honeycutt.

Add a templatized COMVariant constructor so we can make COMVariants out of
everything that has a COMVariantSetter specialization.


Add a COMVariantSetter specialization for COMVariant.


  • COMVariantSetter.h: (COMVariant::COMVariant):
5:04 PM Changeset in webkit [39628] by pewtermoose@webkit.org
  • 2 edits
    2 adds in trunk/WebKit/win

2009-01-05 Brent Fulgham <​bfulgham@gmail.com>

Reviewed by Oliver Hunt.

Fixes: ​https://bugs.webkit.org/show_bug.cgi?id=23027

Removes the WebKitGraphics files from the Cairo build, as well
as excluding their link definitions. These are not used outside
of Safari, and should not be part of the 'Redistributable API.'

  • WebKit.vcproj/WebKit.vcproj: Update *_Cairo targets to exclude the WebKitGraphics.cpp/.h files.
  • WebKit.vcproj/WebKit_Cairo.def: Added. File without Safari link definitions.
  • WebKit.vcproj/WebKit_Cairo_debug.def: Added. File without Safari link definitions.
4:19 PM Changeset in webkit [39627] by andersca@apple.com
  • 2 edits in trunk/WebKit/win

2009-01-05 Anders Carlsson <​andersca@apple.com>

Reviewed by Jon Honeycutt.

Add a simple, memory managed, wrapper around a VARIANT struuct.


  • COMVariantSetter.h: (COMVariant::COMVariant): (COMVariant::~COMVariant): (COMVariant::operator=): (COMVariant::copyTo): (COMVariant::variantType):
4:06 PM Changeset in webkit [39626] by oliver@apple.com
  • 2 edits in trunk/WebCore

Fix Cairo/Gtk build

3:57 PM Changeset in webkit [39625] by oliver@apple.com
  • 23 edits
    1 copy
    1 move
    4 adds
    3 deletes in trunk

CanvasPixelArray performance is too slow
<​https://bugs.webkit.org/show_bug.cgi?id=23123>

Reviewed by Gavin Barraclough

JavaScriptCore:
The fix to this is to devirtualise get and put in a manner similar to
JSString and JSArray. To do this I've added a ByteArray implementation
and JSByteArray wrapper to JSC. We can then do vptr comparisons to
devirtualise the calls.

This devirtualisation improves performance by 1.5-2x in my somewhat ad
hoc tests.

WebCore:
Remove the WebCore CanvasPixelArray implementation and replace
CPA usage with JSC::ByteArray. Replace the JSCanvasPixelArray
wrapper with an explicitly instantiated JSByteArray put on the
JSImageData object as an ordinary ReadOnly, DontDelete property.

3:36 PM Changeset in webkit [39624] by adele@apple.com
  • 2 edits in trunk/WebKit/win

2009-01-05 Adele Peterson <​adele@apple.com>

Windows build fix.

  • WebCoreSupport/WebChromeClient.cpp:
3:32 PM Changeset in webkit [39623] by andersca@apple.com
  • 3 edits in trunk/WebKit/win

2009-01-05 Anders Carlsson <​andersca@apple.com>

Reviewed by Adam Roben.

Make it possible to have per value variant types.


  • COMPropertyBag.h: (::Read): Call variantType here, passing in the value.


(::GetPropertyInfo):
Ditto.


  • COMVariantSetter.h: (COMVariantSetterBase::variantType): Add COMVariantSetterBase, whose variantType implementation just returns the VariantType variable. Make all existing classes inherit from COMVariantSetterBase.
3:31 PM Changeset in webkit [39622] by treat@webkit.org
  • 2 edits in trunk/WebKit/mac

Another blind mac build fix

3:18 PM Changeset in webkit [39621] by treat@webkit.org
  • 2 edits in trunk/WebKit/mac

Blind mac build fix

3:11 PM Changeset in webkit [39620] by treat@webkit.org
  • 2 edits in trunk/WebKit/mac

Fix mac build

3:09 PM Changeset in webkit [39619] by treat@webkit.org
  • 2 edits in trunk/WebKit/win

Fix win build

3:08 PM Changeset in webkit [39618] by treat@webkit.org
  • 2 edits in trunk/WebKit/gtk

Fix build

2:53 PM Changeset in webkit [39617] by treat@webkit.org
  • 26 edits in trunk

Add new API for contentsSizeChanged which Qt will introduce

2:27 PM Changeset in webkit [39616] by andersca@apple.com
  • 2 edits in trunk/WebCore

2009-01-05 Anders Carlsson <​andersca@apple.com>

Build fix.


  • plugins/PluginView.h: (WebCore::PluginManualLoader::~PluginManualLoader):
2:25 PM Changeset in webkit [39615] by treat@webkit.org
  • 4 edits in trunk

Fix ChangeLogs to reflect work done by Torchmobile

2:02 PM Changeset in webkit [39614] by andersca@apple.com
  • 3 edits in trunk/WebKit/win

2009-01-05 Anders Carlsson <​andersca@apple.com>

Reviewed by Kevin Decker.

Use the ManualLoader class instead of assuming that the manual loader
is a plug-in view.


  • WebCoreSupport/WebFrameLoaderClient.cpp: (WebFrameLoaderClient::WebFrameLoaderClient): (WebFrameLoaderClient::setMainDocumentError): (WebFrameLoaderClient::committedLoad): (WebFrameLoaderClient::finishedLoading): (WebFrameLoaderClient::redirectDataToPlugin):
  • WebCoreSupport/WebFrameLoaderClient.h:
1:46 PM Changeset in webkit [39613] by andersca@apple.com
  • 3 edits in trunk/WebCore

2009-01-05 Anders Carlsson <​andersca@apple.com>

Reviewed by Kevin Decker.


Add an abstract PluginManualLoader class and make PluginView inherit from it.


Add some error checking that currently exists in WebKit (but not for long!)


  • plugins/PluginView.cpp: (WebCore::PluginView::didReceiveResponse): (WebCore::PluginView::didReceiveData): (WebCore::PluginView::didFinishLoading): (WebCore::PluginView::didFail):
  • plugins/PluginView.h:
1:33 PM Changeset in webkit [39612] by Darin Adler
  • 3 edits in trunk/LayoutTests

2009-01-05 Darin Adler <Darin Adler>

Reviewed by Oliver Hunt.

Fix failing set-colors test.

  • fast/canvas/resources/set-colors.js: Change the CMYK test cases to use the black channel only.
  • fast/canvas/set-colors-expected.txt: Updated. The old version I checked in accidentally expected failure for the bug I fixed. Also need new results for the CMYK test cases.
1:14 PM Changeset in webkit [39611] by treat@webkit.org
  • 8 edits in trunk

Fixes QWebFrame::setScrollBarPolicy(..) to actually work. Also happens
to fix 192 layout tests that were previously failing for Qt.

11:53 AM Changeset in webkit [39610] by ap@webkit.org
  • 2 edits in trunk/WebCore

Reviewed by Sam Weinig.

Fix platforms that don't have Workers enabled.

  • platform/ThreadGlobalData.cpp: (WebCore::threadGlobalData): Create ThreadGlobalData in two stages, so that EventNames constructor can access the just-created atomic string table. This matches what happens in ThreadSpecific case.
11:50 AM Changeset in webkit [39609] by Darin Adler
  • 3 edits
    1 copy
    3 adds in trunk

WebCore:

2009-01-05 Darin Adler <Darin Adler>

Reviewed by Dan Bernstein.

Bug 23109: REGRESSION: Backwards search in a long document matches incorrectly
​https://bugs.webkit.org/show_bug.cgi?id=23109

Test: fast/text/find-backwards.html

  • editing/TextIterator.cpp: (WebCore::SearchBuffer::append): Fix incorrect size passed to memcpy. (WebCore::SearchBuffer::search): Handle case where we have an empty buffer but we're at a break; must not try to search because ICU will give us an error. Fix incorrect size passed to memcpy and memmove. (WebCore::findPlainText): Fix case where we found a match and need to search again because we want to find the last match. We need to try again without adding any more text or handling the break before moving on.

LayoutTests:

2009-01-05 Darin Adler <Darin Adler>

Reviewed by Dan Bernstein.

Bug 23109: REGRESSION: Backwards search in a long document matches incorrectly
​https://bugs.webkit.org/show_bug.cgi?id=23109

  • fast/text/find-backwards-expected.txt: Added.
  • fast/text/find-backwards.html: Added.
  • fast/text/resources/TEMPLATE.html: Copied from fast/js/resources/TEMPLATE.html.
  • fast/text/resources/find-backwards.js: Added.
11:45 AM Changeset in webkit [39608] by treat@webkit.org
  • 2 edits in trunk/WebCore

Fix the Qt build

11:13 AM Changeset in webkit [39607] by ap@webkit.org
  • 2 edits in trunk/WebCore

Suggested by Dave Levin.

Mac release build fix.

  • WebCore.base.exp: Remove ThreadGlobalData::eventNames(), which is now inline.
10:24 AM Changeset in webkit [39606] by Darin Adler
  • 2 edits in trunk/WebCore

2009-01-05 Darin Adler <Darin Adler>

  • dom/Document.cpp: Fix build. Oops again.
10:19 AM Changeset in webkit [39605] by Darin Adler
  • 2 edits in trunk/WebCore

2009-01-05 Darin Adler <Darin Adler>

Reviewed by Anders Carlsson.

Fix hang whenever following an anchor.

  • dom/Document.cpp: (WebCore::Document::findAnchor): Oops!
10:13 AM Changeset in webkit [39604] by ap@webkit.org
  • 6 edits in trunk

Reviewed by Darin Adler.

​https://bugs.webkit.org/show_bug.cgi?id=23073
<rdar://problem/6471129> Workers crash on Windows Release builds

JavaScriptCore:

  • wtf/ThreadSpecific.h: (WTF::ThreadSpecific::destroy): Changed to clear the pointer only after data object destruction is finished - otherwise, WebCore::ThreadGlobalData destructor was re-creating the object in order to access atomic string table. (WTF::ThreadSpecific::operator T*): Symmetrically, set up the per-thread pointer before data constructor is called.
  • wtf/ThreadingWin.cpp: (WTF::wtfThreadEntryPoint): Remove a Windows-only hack to finalize a thread - pthreadVC2 is a DLL, so it gets thread detached messages, and cleans up thread specific data automatically. Besides, this code wasn't even compiled in for some time now.

WebCore:

  • platform/ThreadGlobalData.cpp: (WebCore::ThreadGlobalData::ThreadGlobalData):
  • platform/ThreadGlobalData.h: (WebCore::ThreadGlobalData::eventNames): Now that ThreadSpecific sets up the pointer before invoking data constructor, we can initialize EventNames right away.
9:32 AM Changeset in webkit [39603] by Darin Adler
  • 13 edits in trunk/WebCore

2009-01-05 Darin Adler <Darin Adler>

Reviewed by Anders Carlsson.

Bug 23106: HTMLFormCollection::namedItem ignores caseSensitive argument
​https://bugs.webkit.org/show_bug.cgi?id=23106

This led me to a bunch of dead code. It turns out that HTML collections
were carrying the case-insensitive code just so they could be used to
find anchors, something we can do more simply and efficiently without
creating a DOM HTMLCollection object.

No behavior change. Just adding a new function findAnchor function and
removing some dead code.

  • dom/Document.cpp: (WebCore::Document::findAnchor): Added.
  • dom/Document.h: Ditto.
  • html/HTMLAnchorElement.cpp: (WebCore::HTMLAnchorElement::accessKey): Take and return AtomicString references for better efficiency. (WebCore::HTMLAnchorElement::setAccessKey): Ditto. (WebCore::HTMLAnchorElement::charset): Ditto. (WebCore::HTMLAnchorElement::setCharset): Ditto. (WebCore::HTMLAnchorElement::coords): Ditto. (WebCore::HTMLAnchorElement::setCoords): Ditto. (WebCore::HTMLAnchorElement::setHref): Ditto. (WebCore::HTMLAnchorElement::hreflang): Ditto. (WebCore::HTMLAnchorElement::setHreflang): Ditto. (WebCore::HTMLAnchorElement::name): Ditto. (WebCore::HTMLAnchorElement::setName): Ditto. (WebCore::HTMLAnchorElement::rel): Ditto. (WebCore::HTMLAnchorElement::setRel): Ditto. (WebCore::HTMLAnchorElement::rev): Ditto. (WebCore::HTMLAnchorElement::setRev): Ditto. (WebCore::HTMLAnchorElement::shape): Ditto. (WebCore::HTMLAnchorElement::setShape): Ditto. (WebCore::HTMLAnchorElement::setTarget): Ditto. (WebCore::HTMLAnchorElement::type): Ditto. (WebCore::HTMLAnchorElement::setType): Ditto.
  • html/HTMLAnchorElement.h: Ditto.
  • html/HTMLCollection.cpp: (WebCore::HTMLCollection::checkForNameMatch): Changed argument to an AtomicString and removed the caseSensitive boolean, since we're now always case sensitive. (WebCore::HTMLCollection::namedItem): Ditto. (WebCore::HTMLCollection::nextNamedItem): Ditto.
  • html/HTMLCollection.h: Ditto.
  • html/HTMLFormCollection.cpp: (WebCore::HTMLFormCollection::getNamedItem): Ditto. (WebCore::HTMLFormCollection::getNamedFormItem): Ditto. (WebCore::HTMLFormCollection::nextNamedItemInternal): Ditto. (WebCore::HTMLFormCollection::namedItem): Ditto. (WebCore::HTMLFormCollection::nextNamedItem): Ditto.
  • html/HTMLFormCollection.h: Ditto.
  • html/HTMLSelectElement.cpp: (WebCore::HTMLSelectElement::namedItem): Ditto.
  • html/HTMLSelectElement.h: Ditto.
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::gotoAnchor): Use the new findAnchor function.
  • page/AccessibilityRenderObject.cpp: (WebCore::AccessibilityRenderObject::internalLinkElement): Ditto.
9:29 AM Changeset in webkit [39602] by Darin Adler
  • 7 edits
    3 adds in trunk

WebCore:

2009-01-05 Darin Adler <Darin Adler>

Reviewed by Anders Carlsson.

Bug 23104: minor mistakes in init functions for animation and transition events
​https://bugs.webkit.org/show_bug.cgi?id=23104

Test: fast/events/init-events.html

Also fixed two StorageEvent problems the test case uncovered:

Made document.createEvent("StorageEvent") work.
Allow null values for StorageEvent.oldValue and StorageEvent.newValue.

  • dom/Document.cpp: (WebCore::Document::createEvent): Sorted alphabetically by the name of the event class. Added StorageEvent.
  • dom/UIEvent.idl: Fixed typo in a comment.
  • dom/WebKitAnimationEvent.cpp: (WebCore::WebKitAnimationEvent::initWebKitAnimationEvent): Use all the arguments.
  • dom/WebKitTransitionEvent.cpp: (WebCore::WebKitTransitionEvent::initWebKitTransitionEvent): Ditto.
  • storage/StorageEvent.idl: Use the ConvertNullToNullString keyword on the arguments to initStorageEvent so it can create events with null values for the oldValue and newValue, just like the real storage events. Note that the properties already had ConvertNullStringTo=Null, so this is just the other half of that.

LayoutTests:

2009-01-05 Darin Adler <Darin Adler>

Reviewed by Anders Carlsson.

Bug 23104: minor mistakes in init functions for animation and transition events
​https://bugs.webkit.org/show_bug.cgi?id=23104

  • fast/events/init-events-expected.txt: Added.
  • fast/events/init-events.html: Added.
  • fast/events/resources/init-events.js: Added.
9:26 AM Changeset in webkit [39601] by Darin Adler
  • 192 edits in trunk/WebCore

2009-01-05 Darin Adler <Darin Adler>

Reviewed by Alexey Proskuryakov.

Bug 23102: turn on unused parameter warnings in WebCore
​https://bugs.webkit.org/show_bug.cgi?id=23102

First step: Fix the simple cases where we can just remove an argument name.
Also made a few more things protected and private.

  • many files
9:21 AM Changeset in webkit [39600] by ap@webkit.org
  • 8 edits in trunk

Reviewed by Darin Adler.

​https://bugs.webkit.org/show_bug.cgi?id=23115
Create a version of ASSERT for use with otherwise unused variables

JavaScriptCore:

  • wtf/Assertions.h: Added ASSERT_UNUSED.
  • jit/ExecutableAllocatorPosix.cpp: (JSC::ExecutablePool::systemRelease):
  • runtime/Collector.cpp: (JSC::Heap::destroy): (JSC::Heap::heapAllocate):
  • runtime/JSNotAnObject.cpp: (JSC::JSNotAnObject::toPrimitive): (JSC::JSNotAnObject::getPrimitiveNumber): (JSC::JSNotAnObject::toBoolean): (JSC::JSNotAnObject::toNumber): (JSC::JSNotAnObject::toString): (JSC::JSNotAnObject::getOwnPropertySlot): (JSC::JSNotAnObject::put): (JSC::JSNotAnObject::deleteProperty): (JSC::JSNotAnObject::getPropertyNames):
  • wtf/TCSystemAlloc.cpp: (TCMalloc_SystemRelease): Use it in some places that used other idioms for this purpose.

WebCore:

  • loader/appcache/ApplicationCacheStorage.cpp: (WebCore::ApplicationCacheStorage::verifySchemaVersion): Use the new ASSERT_UNUSED macro.
9:18 AM Changeset in webkit [39599] by ap@webkit.org
  • 2 edits in trunk/WebCore

Non-Mac build fix.

  • loader/appcache/ApplicationCacheStorage.cpp: Include wtf/StringExtras.h for snprintf.
9:15 AM Changeset in webkit [39598] by treat@webkit.org
  • 2 edits in trunk/WebCore

Remove unnecessary methods from EmptyFrameLoaderClient

12:55 AM Changeset in webkit [39597] by ap@webkit.org
  • 3 edits in trunk/WebCore

Reviewed by Darin Adler.

​https://bugs.webkit.org/show_bug.cgi?id=23077
Make application cache use SQLite built-in user_version

  • loader/appcache/ApplicationCacheStorage.cpp: (WebCore::ApplicationCacheStorage::verifySchemaVersion): Changed to track versions with PRAGMA user_version.
  • loader/appcache/ApplicationCacheResource.h: (WebCore::ApplicationCacheResource::): Used the occasion to get rid of the hole in bitmask that was a leftover from opportunistic cache entries.
12:39 AM Changeset in webkit [39596] by dsmith@webkit.org
  • 3 edits in trunk/WebCore

2009-01-04 David Smith <​catfish.man@gmail.com>

Reviewed by Oliver Hunt.

Avoid redundant AtomicString conversions

  • dom/Node.cpp: (WebCore::Node::getElementsByTagName): Pass starAtom instead of "*" (WebCore::Node::getElementsByTagNameNS): Take an AtomicString for the namespace URI (WebCore::Node::isDefaultNamespace): Ditto (WebCore::Node::lookupPrefix): Ditto (WebCore::Node::lookupNamespacePrefix): Ditto
  • dom/Node.h: Ditto

Jan 4, 2009:

11:25 PM Changeset in webkit [39595] by Darin Adler
  • 4 edits
    3 adds in trunk

WebCore:

2009-01-04 Darin Adler <Darin Adler>

Reviewed by Oliver Hunt.

Bug 23105: canvas setFillColor function ignores alpha argument
​https://bugs.webkit.org/show_bug.cgi?id=23105

Test: fast/canvas/set-colors.html

  • html/CanvasRenderingContext2D.cpp: (WebCore::CanvasRenderingContext2D::setFillColor): Pass alpha value through instead of ignoring it and always passing 1.
  • html/CanvasStyle.cpp: (WebCore::CanvasStyle::applyStrokeColor): Fix spelling of transparent in comments. (WebCore::CanvasStyle::applyFillColor): Ditto.

LayoutTests:

2009-01-04 Darin Adler <Darin Adler>

Reviewed by Oliver Hunt.

Bug 23105: canvas setFillColor function ignores alpha argument
​https://bugs.webkit.org/show_bug.cgi?id=23105

  • fast/canvas/resources/set-colors.js: Added.
  • fast/canvas/set-colors-expected.txt: Added.
  • fast/canvas/set-colors.html: Added.
9:41 PM Changeset in webkit [39594] by Darin Adler
  • 2 edits in trunk/WebCore

2009-01-04 Darin Adler <Darin Adler>

Bug 23086: REGRESSION(r39540/r39541): Windows build fails due to ICU errors
​https://bugs.webkit.org/show_bug.cgi?id=23086

  • editing/TextIterator.cpp: Check UCONFIG_NO_COLLATION and don't compile in the new search path if it's 0.
4:18 PM Changeset in webkit [39593] by alice.liu@apple.com
  • 3 edits in trunk/JavaScriptCore

2009-01-04 Alice Liu <​alice.liu@apple.com>

<rdar://problem/6341776> Merge m_transitionCount and m_offset in Structure.

Reviewed by Darin Adler.

  • runtime/Structure.cpp: (JSC::Structure::Structure): Remove m_transitionCount (JSC::Structure::addPropertyTransitionToExistingStructure): No need to wait until after the assignment to offset to assert if it's notFound; move it up. (JSC::Structure::addPropertyTransition): Use method for transitionCount instead of m_transitionCount. Remove line that maintains the m_transitionCount. (JSC::Structure::changePrototypeTransition): Remove line that maintains the m_transitionCount. (JSC::Structure::getterSetterTransition): Remove line that maintains the m_transitionCount.
  • runtime/Structure.h: Changed s_maxTransitionLength and m_offset from size_t to signed char. m_offset will never become greater than 64 because the structure transitions to a dictionary at that time. (JSC::Structure::transitionCount): method to replace the data member
1:09 PM Changeset in webkit [39592] by ddkilzer@apple.com
  • 4 edits
    4 adds in trunk

Don't install internal headers in WebKit framework

Reviewed by Darin Adler.

WebKit:

  • WebKit.xcodeproj/project.pbxproj: Remove roles from internal headers so they're not installed.

WebKitTools:

Since WebHTMLRepresentationInternal.h and WebTypesInternal.h are
no longer installed in WebKit.framework/PrivateHeaders, use the
special relationship of DumpRenderTree within the WebKit source
tree to include the internal headers through relative paths.
Created the concept of mac/InternalHeaders to hide the ugly
paths.

  • DumpRenderTree/mac/Configurations/Base.xcconfig: Added mac/InternalHeaders to HEADER_SEARCH_PATHS.
  • DumpRenderTree/mac/InternalHeaders/WebKit/WebHTMLRepresentationInternal.h: Added.
  • DumpRenderTree/mac/InternalHeaders/WebKit/WebTypesInternal.h: Added.
12:14 PM Changeset in webkit [39591] by mitz@apple.com
  • 4 edits in trunk

Fixed change log entry dates.

11:57 AM Changeset in webkit [39590] by ddkilzer@apple.com
  • 2 edits in trunk/WebCore

Don't install *.idl and *.in files as resources

Reviewed by Oliver Hunt.

Don't install these files as resources in the WebCore framework:

  • WMLAttributeNames.in
  • WMLTagNames.in
  • WorkerContext.idl
  • WorkerLocation.idl
  • WorkerNavigator.idl
  • WebCore.xcodeproj/project.pbxproj: Removed resources.
11:10 AM Changeset in webkit [39589] by Simon Fraser
  • 3 edits in trunk/LayoutTests

2009-01-04 Simon Fraser <Simon Fraser>

Fix the expected image to account for a typo fix done on 2008-12-23.

  • platform/mac/fast/transforms/identity-matrix-expected.checksum:
  • platform/mac/fast/transforms/identity-matrix-expected.png:
10:38 AM Changeset in webkit [39588] by Simon Fraser
  • 3 edits
    4 adds in trunk

2009-01-04 Simon Fraser <Simon Fraser>

Reviewed by Darin Adler

​https://bugs.webkit.org/show_bug.cgi?id=23090

If an object gets a Layout hint, and the style change will result in
the creation of a RenderLayer, then we need to repaint the old position
of the object. This was done for transform, but we have to test opacity too.

Test: fast/repaint/create-layer-repaint.html

  • rendering/RenderObject.cpp: (WebCore::RenderObject::styleWillChange):
10:24 AM Changeset in webkit [39587] by Darin Adler
  • 2 edits in trunk/WebCore

2009-01-04 Darin Adler <Darin Adler>

Reviewed by Dan Bernstein.

Bug 23103: Safari's auto-fill no longer works for <select> elements
​https://bugs.webkit.org/show_bug.cgi?id=23103
rdar://problem/6472061

  • bindings/objc/DOMHTML.mm: (-[DOMHTMLSelectElement _activateItemAtIndex:]): Implemented this.
10:23 AM Changeset in webkit [39586] by Darin Adler
  • 4 edits in trunk

Fixed change log entry dates.

10:00 AM Changeset in webkit [39585] by Darin Adler
  • 2 edits in trunk/JavaScriptCore

2009-01-04 Darin Adler <Darin Adler>

Reviewed by David Kilzer.

Bug 15114: Provide compile-time assertions for sizeof(UChar), sizeof(DeprecatedChar), etc.
​https://bugs.webkit.org/show_bug.cgi?id=15114

  • wtf/unicode/Unicode.h: Assert size of UChar. There is no DeprecatedChar any more.
9:39 AM Changeset in webkit [39584] by treat@webkit.org
  • 4 edits in trunk/WebKit/qt

Add new API to QWebHitTestResult to return a rect for the smallest enclosing
block element of the hit test

9:28 AM Changeset in webkit [39583] by treat@webkit.org
  • 2 edits in trunk/WebKit/win

Make the apple windows port build with the new fixedLayoutSize feature

9:26 AM Changeset in webkit [39582] by treat@webkit.org
  • 2 edits in trunk/WebKit/gtk

Make the gtk port build with the new fixedLayoutSize feature

9:25 AM Changeset in webkit [39581] by treat@webkit.org
  • 9 edits
    3 adds in trunk

Make the qt port build and work with the new fixedLayoutSize feature

9:25 AM Changeset in webkit [39580] by treat@webkit.org
  • 10 edits in trunk/WebCore

Add fixedLayoutSize feature to ScrollView to allow for controlling the
layout beyond the constraint of the current viewports dynamic size

6:26 AM Changeset in webkit [39579] by Darin Adler
  • 2 edits in trunk/LayoutTests

2009-01-04 Darin Adler <Darin Adler>

Suggested by Dan Bernstein.

  • platform/mac/editing/selection/move-left-right-expected.txt: Remove WARNING lines that are no longer showing up. Dan said he didn't know why we were seeing those before and why they're gone now, but it's good that they're gone.
6:12 AM Changeset in webkit [39578] by Darin Adler
  • 2 edits in trunk/LayoutTests

2009-01-03 Darin Adler <Darin Adler>

Reviewed by Dan Bernstein.

Bug 23095: REGRESSION: fast/text/find-case-folding.html regression test failing when ICU used for text search
​https://bugs.webkit.org/show_bug.cgi?id=23095

  • fast/text/find-case-folding.html: Work around this ICU bug in the test for now. Later we might want to work around it in our search code instead, or in addition, if we can figure out how to do that.
Note: See TracTimeline for information about the timeline view.