⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Jan 8, 2009:

9:41 PM Changeset in webkit [39737] by weinig@apple.com
  • 10 edits in trunk/JavaScriptCore

2009-01-08 Sam Weinig <​sam@webkit.org>

Revert r39720. It broke Interpreted mode.

7:45 PM Changeset in webkit [39736] by mitz@apple.com
  • 13 edits in trunk

WebCore:

Reviewed by Adam Roben.

  • use native glyph support in Core Graphics when available
  • platform/graphics/win/FontCGWin.cpp: (WebCore::Font::drawGlyphs): Changed to use drawGDIGlyphs() only if native glyph support is not available or stroking is required. Changed to pass the font's useGDI() flag to wkSetCGContextFontRenderingStyle to request the use of native glyphs.
  • platform/graphics/win/FontCustomPlatformData.cpp: (WebCore::FontCustomPlatformData::fontPlatformData): Added a call to wkSetFontPlatformInfo to attach the LOGFONT to the CGFont.
  • platform/graphics/win/FontPlatformDataCGWin.cpp: (WebCore::FontPlatformData::platformDataInit): Ditto.

WebKit/win:

Reviewed by Adam Roben.

  • WebPreferences changes to support Core Graphics native glyph drawing
  • Interfaces/IWebPreferencesPrivate.idl: Added font smoothing contrast getter and setter.
  • WebPreferenceKeysPrivate.h: Added WebKitFontSmoothingContrastPreferenceKey.
  • WebPreferences.cpp: (WebPreferences::initializeDefaultSettings): Initialized WebKitFontSmoothingContrastPreferenceKey to 2. (WebPreferences::setFloatValue): Added. (WebPreferences::setFontSmoothing): Changed to map FontSmoothingTypeWindows to FontSmoothingTypeMedium. (WebPreferences::fontSmoothingContrast): Added. (WebPreferences::setFontSmoothingContrast): Added. Calls wkSetFontSmoothingContrast().
  • WebPreferences.h:

WebKitLibraries:

Reviewed by Adam Roben.

  • WebKitSystemInterface changes to support Core Graphics native glyph drawing
  • win/include/WebKitSystemInterface/WebKitSystemInterface.h:
  • win/lib/WebKitSystemInterface.lib:
  • win/lib/WebKitSystemInterface_debug.lib:
7:12 PM Changeset in webkit [39735] by sfalken@apple.com
  • 2 edits in trunk/WebKit/win

<rdar://problem/6474244> REGRESSION(39561-39603): Heap corruption when saving passwords?


Reviewed by Adam Roben.

  • WebView.cpp: (WebViewWndProc): Hold a ref to the WebView inside the WNDPROC, since it could go away in an event handler.
5:51 PM Changeset in webkit [39734] by pkasting@chromium.org
  • 2 edits in trunk/WebCore

2009-01-08 Peter Kasting <​pkasting@google.com>

Reviewed by Sam Weinig.

​https://bugs.webkit.org/show_bug.cgi?id=22929
Fix memory regression when decoding large animated GIFs.

  • platform/graphics/cg/ImageSourceCG.cpp: (WebCore::ImageSource::clear):
5:41 PM Changeset in webkit [39733] by andersca@apple.com
  • 3 edits in trunk/WebKit/mac

2009-01-08 Anders Carlsson <​andersca@apple.com>

Reviewed by Sam Weinig.

Add and implement WKPCGetStringIdentifier.


  • Plugins/Hosted/NetscapePluginHostProxy.mm: (WKPCGetStringIdentifier):
  • Plugins/Hosted/WebKitPluginClient.defs:
5:36 PM Changeset in webkit [39732] by eric@webkit.org
  • 1 edit in trunk/WebCore/ChangeLog

Correct my changelog error.

2009-01-08 Scott Violet <​sky@chromium.org>

Reviewed by Eric Seidel (and Adam Barth).

Fix Images to return their file extension
​http://code.google.com/p/chromium/issues/detail?id=5827

  • platform/graphics/skia/ImageSourceSkia.cpp: (WebCore::ImageSource::filenameExtension):
5:22 PM Changeset in webkit [39731] by eric@webkit.org
  • 2 edits in trunk/WebCore

2009-01-08 Berend-Jan Wever <​sky@chromium.org>

Reviewed by Adam Barth.

Fix Images to return their file extension
​http://code.google.com/p/chromium/issues/detail?id=5827

  • platform/graphics/skia/ImageSourceSkia.cpp: (WebCore::ImageSource::filenameExtension):
5:18 PM Changeset in webkit [39730] by eric@webkit.org
  • 1 edit
    2 adds in trunk/WebCore

2009-01-08 Dimitri Glazkov <Dimitri Glazkov>

Reviewed by Eric Seidel.

Add PathSkia and PatternSkia implementations to WebCore
​https://bugs.webkit.org/show_bug.cgi?id=23200

  • platform/graphics/skia/PathSkia.cpp: Added. (WebCore::Path::Path): (WebCore::Path::~Path): (WebCore::Path::operator=): (WebCore::Path::isEmpty): (WebCore::Path::contains): (WebCore::Path::translate): (WebCore::Path::boundingRect): (WebCore::Path::moveTo): (WebCore::Path::addLineTo): (WebCore::Path::addQuadCurveTo): (WebCore::Path::addBezierCurveTo): (WebCore::Path::addArcTo): (WebCore::Path::closeSubpath): (WebCore::Path::addArc): (WebCore::Path::addRect): (WebCore::Path::addEllipse): (WebCore::Path::clear): (WebCore::convertPathPoints): (WebCore::Path::apply): (WebCore::Path::transform): (WebCore::Path::debugString): (WebCore::boundingBoxForCurrentStroke): (WebCore::Path::strokeBoundingRect):
  • platform/graphics/skia/PatternSkia.cpp: Added. (WebCore::shaderRule): (WebCore::Pattern::createPlatformPattern):
5:06 PM Changeset in webkit [39729] by eric@webkit.org
  • 2 edits
    2 adds in trunk/WebCore

2009-01-08 Dimitri Glazkov <Dimitri Glazkov>

Reviewed by Eric Seidel.

Add ImageSourceSkia to platform/graphics/skia
​https://bugs.webkit.org/show_bug.cgi?id=23200

ImageSourceSkia is mostly a hack to support our
ICO decoder model. See ImageSourceSkia.h for more
explanation. Eventually we'd like to make our ICO
decoder lazy.

  • platform/graphics/ImageSource.h: mark m_decoder as protected
  • platform/graphics/skia/ImageSourceSkia.cpp: Added. (WebCore::createDecoder): (WebCore::ImageSource::ImageSource): (WebCore::ImageSource::~ImageSource): (WebCore::ImageSource::clear): (WebCore::ImageSource::initialized): (WebCore::ImageSource::setData): (WebCore::ImageSource::isSizeAvailable): (WebCore::ImageSource::size): (WebCore::ImageSource::frameSizeAtIndex): (WebCore::ImageSource::repetitionCount): (WebCore::ImageSource::frameCount): (WebCore::ImageSource::createFrameAtIndex): (WebCore::ImageSource::frameIsCompleteAtIndex): (WebCore::ImageSource::frameDurationAtIndex): (WebCore::ImageSource::frameHasAlphaAtIndex): (WebCore::ImageSourceSkia::setData): (WebCore::ImageSource::filenameExtension):
  • platform/graphics/skia/ImageSourceSkia.h: Added.
4:54 PM Changeset in webkit [39728] by eric@webkit.org
  • 1 edit
    2 adds in trunk/WebCore

2009-01-08 Dimitri Glazkov <Dimitri Glazkov>

Reviewed by Eric Seidel.

Add NativeImageSkia (PlatformImagePtr) to platform/graphics/skia
​https://bugs.webkit.org/show_bug.cgi?id=23200

  • platform/graphics/skia/NativeImageSkia.cpp: Added. (NativeImageSkia::NativeImageSkia): (NativeImageSkia::decodedSize): (NativeImageSkia::hasResizedBitmap): (NativeImageSkia::resizedBitmap): (NativeImageSkia::shouldCacheResampling):
  • platform/graphics/skia/NativeImageSkia.h: Added. (NativeImageSkia::setDataComplete): (NativeImageSkia::isDataComplete):
4:41 PM Changeset in webkit [39727] by eric@webkit.org
  • 1 edit
    2 adds in trunk/WebCore

2009-01-08 Dimitri Glazkov <Dimitri Glazkov>

Reviewed by Eric Seidel.

Add ImageBufferSkia and ImageSkia files.
​https://bugs.webkit.org/show_bug.cgi?id=23200
For now we've left BitmapImage and BitmapImageSingleFrameSkia
implementations in the ImageSkia file (like ImageCG has), but
we intend to break them out into their own files.

  • platform/graphics/skia/ImageBufferSkia.cpp: Added. (WebCore::ImageBufferData::ImageBufferData): (WebCore::ImageBuffer::ImageBuffer): (WebCore::ImageBuffer::~ImageBuffer): (WebCore::ImageBuffer::context): (WebCore::ImageBuffer::image): (WebCore::ImageBuffer::getImageData): (WebCore::ImageBuffer::putImageData): (WebCore::ImageBuffer::toDataURL):
  • platform/graphics/skia/ImageSkia.cpp: Added. (WebCore::): (WebCore::FrameData::clear): (WebCore::Image::loadPlatformResource): (WebCore::Image::drawPattern): (WebCore::BitmapImage::initPlatformData): (WebCore::BitmapImage::invalidatePlatformData): (WebCore::BitmapImage::checkForSolidColor): (WebCore::BitmapImage::draw): (WebCore::BitmapImageSingleFrameSkia::draw): (WebCore::BitmapImageSingleFrameSkia::create):
4:30 PM Changeset in webkit [39726] by pam@chromium.org
  • 2 edits in trunk/WebCore

2009-01-08 James Robinson <​jamesr@google.com>

Reviewed by Mark Rowe.
Landed by Pamela Greene.

WebCore::Event::timeStamp() is a simple accessor and should be const

​https://bugs.webkit.org/show_bug.cgi?id=23176

  • dom/Event.h: (WebCore::Event::timeStamp):
3:44 PM Changeset in webkit [39725] by Antti Koivisto
  • 6 edits in trunk/WebCore

2009-01-08 Antti Koivisto <Antti Koivisto>

Reviewed by Oliver Hunt.

Fix <rdar://problem/6467206>
Resources loaded from the memory cache do not get correctly inserted into the DocLoader resource map (22994)


Use CachedResourceHandle in document resource map so resources get updated correctly when using
using cache validation conditionals.

  • loader/Cache.cpp: (WebCore::Cache::evict):
  • loader/DocLoader.cpp: (WebCore::DocLoader::~DocLoader): (WebCore::DocLoader::requestResource): (WebCore::DocLoader::setAutoLoadImages): (WebCore::DocLoader::removeCachedResource):
  • loader/DocLoader.h: (WebCore::DocLoader::cachedResource): (WebCore::DocLoader::allCachedResources):
  • loader/DocumentLoader.cpp: (WebCore::DocumentLoader::getSubresources):
  • loader/ImageLoader.cpp: (WebCore::ImageLoader::updateFromElement):
3:36 PM Changeset in webkit [39724] by mrowe@apple.com
  • 4 edits in trunk

Versioning.

3:35 PM Changeset in webkit [39723] by mrowe@apple.com
  • 1 copy in tags/Safari-6528.9

New tag.

3:07 PM Changeset in webkit [39722] by Stephanie Lewis
  • 2 edits in trunk/WebKit/mac

2009-01-08 Stephanie Lewis <​slewis@gmail.com>

Fix Tiger build.

  • WebView/WebTextIterator.mm:
3:00 PM Changeset in webkit [39721] by andersca@apple.com
  • 6 edits in trunk/WebKit/mac

2009-01-08 Anders Carlsson <​andersca@apple.com>

Reviewed by Sam Weinig.

Add basic support for evaluating scripts.


  • Plugins/Hosted/NetscapePluginHostProxy.mm: (WebKit::fromUTF8WithLatin1Fallback): (WebKit::NetscapePluginHostProxy::~NetscapePluginHostProxy): (WKPCReleaseObject): (marshalValue): (WKPCEvaluate):
  • Plugins/Hosted/NetscapePluginInstanceProxy.h:
  • Plugins/Hosted/NetscapePluginInstanceProxy.mm: (WebKit::NetscapePluginInstanceProxy::releaseObject): (WebKit::NetscapePluginInstanceProxy::evaluate):
  • Plugins/Hosted/WebKitPluginClient.defs:
  • Plugins/Hosted/WebKitPluginHostTypes.h:
2:51 PM Changeset in webkit [39720] by weinig@apple.com
  • 10 edits in trunk/JavaScriptCore

2009-01-08 Sam Weinig <​sam@webkit.org>

Reviewed by Oliver Hunt.

Fix for ​https://bugs.webkit.org/show_bug.cgi?id=23197
Delay creating the PCVector until an exception is thrown
Part of <rdar://problem/6469060>
Don't store exception information for a CodeBlock until first exception is thrown

  • Change the process for re-parsing/re-generating bytecode for exception information to use data from the original CodeBlock (offsets of GlobalResolve instructions) to aid in creating an identical instruction stream on re-parse, instead of padding interchangeable opcodes, which would result in different JITed code.
  • Fix bug where the wrong ScopeChainNode was used when re-parsing/regenerating from within some odd modified scope chains.
  • Lazily create the pcVector by re-JITing the regenerated CodeBlock and stealing the the pcVector from it.

Saves ~2MB on Membuster head.

  • bytecode/CodeBlock.cpp: (JSC::CodeBlock::dump): (JSC::CodeBlock::reparseForExceptionInfoIfNecessary): (JSC::CodeBlock::hasGlobalResolveInstructionAtBytecodeOffset): (JSC::CodeBlock::hasGlobalResolveInfoAtBytecodeOffset):
  • bytecode/CodeBlock.h: (JSC::JITCodeRef::JITCodeRef): (JSC::GlobalResolveInfo::GlobalResolveInfo): (JSC::CodeBlock::getBytecodeIndex): (JSC::CodeBlock::addGlobalResolveInstruction): (JSC::CodeBlock::addGlobalResolveInfo): (JSC::CodeBlock::addFunctionRegisterInfo): (JSC::CodeBlock::hasExceptionInfo): (JSC::CodeBlock::pcVector): (JSC::EvalCodeBlock::EvalCodeBlock): (JSC::EvalCodeBlock::baseScopeDepth):
  • bytecode/Opcode.h:
  • bytecompiler/BytecodeGenerator.cpp: (JSC::BytecodeGenerator::BytecodeGenerator): (JSC::BytecodeGenerator::emitResolve): (JSC::BytecodeGenerator::emitGetScopedVar):
  • bytecompiler/BytecodeGenerator.h: (JSC::BytecodeGenerator::setRegeneratingForExceptionInfo):
  • interpreter/Interpreter.cpp: (JSC::bytecodeOffsetForPC): (JSC::Interpreter::unwindCallFrame): (JSC::Interpreter::privateExecute): (JSC::Interpreter::retrieveLastCaller): (JSC::Interpreter::cti_op_instanceof): (JSC::Interpreter::cti_op_call_NotJSFunction): (JSC::Interpreter::cti_op_resolve): (JSC::Interpreter::cti_op_construct_NotJSConstruct): (JSC::Interpreter::cti_op_resolve_func): (JSC::Interpreter::cti_op_resolve_skip): (JSC::Interpreter::cti_op_resolve_global): (JSC::Interpreter::cti_op_resolve_with_base): (JSC::Interpreter::cti_op_throw): (JSC::Interpreter::cti_op_in): (JSC::Interpreter::cti_vm_throw):
  • jit/JIT.cpp: (JSC::JIT::privateCompile):
  • parser/Nodes.cpp: (JSC::EvalNode::generateBytecode): (JSC::EvalNode::bytecodeForExceptionInfoReparse): (JSC::FunctionBodyNode::bytecodeForExceptionInfoReparse):
  • parser/Nodes.h:
2:06 PM Changeset in webkit [39719] by eric@webkit.org
  • 1 edit
    1 add in trunk/WebCore

2009-01-08 Dimitri Glazkov <Dimitri Glazkov>

Reviewed by Eric Seidel.

Add a cleaned-up GraphicsContextSkia implementation to WebKit.
​https://bugs.webkit.org/show_bug.cgi?id=23191

  • platform/graphics/skia/GraphicsContextSkia.cpp: Added. (WebCore::): (WebCore::GraphicsContext::GraphicsContext): (WebCore::GraphicsContext::~GraphicsContext): (WebCore::GraphicsContext::platformContext): (WebCore::GraphicsContext::savePlatformState): (WebCore::GraphicsContext::restorePlatformState): (WebCore::GraphicsContext::beginTransparencyLayer): (WebCore::GraphicsContext::endTransparencyLayer): (WebCore::GraphicsContext::addInnerRoundedRectClip): (WebCore::GraphicsContext::addPath): (WebCore::GraphicsContext::beginPath): (WebCore::GraphicsContext::clearPlatformShadow): (WebCore::GraphicsContext::clearRect): (WebCore::GraphicsContext::clip): (WebCore::GraphicsContext::clipOut): (WebCore::GraphicsContext::clipOutEllipseInRect): (WebCore::GraphicsContext::clipPath): (WebCore::GraphicsContext::clipToImageBuffer): (WebCore::GraphicsContext::concatCTM): (WebCore::GraphicsContext::drawConvexPolygon): (WebCore::GraphicsContext::drawEllipse): (WebCore::GraphicsContext::drawFocusRing): (WebCore::GraphicsContext::drawLine): (WebCore::GraphicsContext::drawLineForMisspellingOrBadGrammar): (WebCore::GraphicsContext::drawLineForText): (WebCore::GraphicsContext::drawRect): (WebCore::GraphicsContext::fillPath): (WebCore::GraphicsContext::fillRect): (WebCore::GraphicsContext::fillRoundedRect): (WebCore::GraphicsContext::getCTM): (WebCore::GraphicsContext::roundToDevicePixels): (WebCore::GraphicsContext::scale): (WebCore::GraphicsContext::setAlpha): (WebCore::GraphicsContext::setCompositeOperation): (WebCore::GraphicsContext::setImageInterpolationQuality): (WebCore::GraphicsContext::setLineCap): (WebCore::GraphicsContext::setLineDash): (WebCore::GraphicsContext::setLineJoin): (WebCore::GraphicsContext::setMiterLimit): (WebCore::GraphicsContext::setPlatformFillColor): (WebCore::GraphicsContext::setPlatformShadow): (WebCore::GraphicsContext::setPlatformStrokeColor): (WebCore::GraphicsContext::setPlatformStrokeStyle): (WebCore::GraphicsContext::setPlatformStrokeThickness): (WebCore::GraphicsContext::setPlatformTextDrawingMode): (WebCore::GraphicsContext::setURLForRect): (WebCore::GraphicsContext::setUseAntialiasing): (WebCore::GraphicsContext::strokeArc): (WebCore::GraphicsContext::strokePath): (WebCore::GraphicsContext::strokeRect): (WebCore::GraphicsContext::rotate): (WebCore::GraphicsContext::translate):
1:51 PM Changeset in webkit [39718] by eric@webkit.org
  • 1 edit
    2 adds in trunk/WebCore

2009-01-08 Dimitri Glazkov <Dimitri Glazkov>

Reviewed by Eric Seidel.

Add two more files for platform/graphics/skia.
​https://bugs.webkit.org/show_bug.cgi?id=23191

  • platform/graphics/skia/GradientSkia.cpp: Added. (WebCore::Gradient::platformDestroy): (WebCore::F2B): (WebCore::makeSkColor): (WebCore::totalStopsNeeded): (WebCore::fillStops): (WebCore::compareStops): (WebCore::Gradient::platformGradient): (WebCore::Gradient::fill):
  • platform/graphics/skia/GraphicsContextPlatformPrivate.h: Copied from WebCore/bindings/js/ScriptValue.h. (WebCore::GraphicsContextPlatformPrivate::GraphicsContextPlatformPrivate): (WebCore::GraphicsContextPlatformPrivate::context):
1:27 PM Changeset in webkit [39717] by hyatt@apple.com
  • 10 edits in trunk

WebCore:

2009-01-08 David Hyatt <​hyatt@apple.com>

Fix for <rdar://problem/6465682> REGRESSION: In Mail, can't force a message to auto scroll.

Make scrollRectIntoViewRecursively call out to the HostWindow to continue the recursive scroll for
any scrollable views that may contain a WebView. Does nothing on platforms other than the Mac, but
might eventually be of interest to other platforms.

Reviewed by Oliver Hunt

  • WebCore.base.exp:
  • page/Chrome.cpp: (WebCore::Chrome::scrollRectIntoView):
  • page/Chrome.h:
  • page/ChromeClient.h: (WebCore::ChromeClient::scrollRectIntoView):
  • platform/HostWindow.h:
  • platform/ScrollView.cpp: (WebCore::ScrollView::scrollRectIntoViewRecursively):

WebKit/mac:

2009-01-08 David Hyatt <​hyatt@apple.com>

Fix for <rdar://problem/6465682> REGRESSION: In Mail, can't force a message to auto scroll

Add a new ChromeClient method for handling exposure of scrolled rects.

Reviewed by Oliver Hunt

  • WebCoreSupport/WebChromeClient.h:
  • WebCoreSupport/WebChromeClient.mm: (WebChromeClient::scrollRectIntoView):
1:12 PM Changeset in webkit [39716] by treat@webkit.org
  • 4 edits in trunk/WebCore

No need to make this part of HostWindow and moreover HostWindow should
not have any reference to non-platform parts of WebCore.

12:59 PM Changeset in webkit [39715] by Darin Adler
  • 3 edits in trunk/WebKit/mac

2009-01-08 Darin Adler <Darin Adler>

Reviewed by Tim Hatcher.

Bug 23185: add a currentRange method to the WebTextIterator SPI
​https://bugs.webkit.org/show_bug.cgi?id=23185
rdar://problem/6455834

I also noticed a garbage-collection-related threading issue that I fixed, and
that the SPI for getting text was unnecessarily inefficient, so I fixed that too.

  • WebView/WebTextIterator.h: Moved currentNode and currentText into a "deprecated" category. Added currentTextPointer and currentTextLength.
  • WebView/WebTextIterator.mm: Changed m_textIterator into an OwnPtr, and also used _textIterator to be consistent with ObjC rather than C++ naming. (+[WebTextIteratorPrivate initialize]): Added. Calls WebCoreObjCFinalizeOnMainThread, since the finalize method here works with main-thread only WebCore objects. (-[WebTextIterator initWithRange:]): Changed since _textIterator is an OwnPtr now. (-[WebTextIterator advance]): Changed name of m_textIterator. Removed null assertion, since I don't think it provides much value. (-[WebTextIterator atEnd]): Ditto. (-[WebTextIterator currentRange]): Added. (-[WebTextIterator currentTextPointer]): Added. (-[WebTextIterator currentTextLength]): Added. (-[WebTextIterator currentNode]): Did same as above, but also put into new category. (-[WebTextIterator currentText]): Ditto.
12:19 PM Changeset in webkit [39714] by eric.carlson@apple.com
  • 11 edits in trunk

2009-01-08 Eric Carlson <​eric.carlson@apple.com>

Reviewed by Adele Peterson.

Simplify Mac interfaces for drawing media controller elements

<rdar://problem/6293969>

  • WebCore.base.exp: update for changed WebKitSystemInterface media controller functions
  • platform/mac/WebCoreSystemInterface.h: Ditto
  • platform/mac/WebCoreSystemInterface.mm: Ditto
  • rendering/MediaControlElements.h: (WebCore::): Add MediaControlElements enum
  • rendering/RenderThemeMac.mm: (WebCore::RenderThemeMac::paintMediaFullscreenButton): update for changed WebKitSystemInterface media controller functions (WebCore::RenderThemeMac::paintMediaMuteButton): Ditto (WebCore::RenderThemeMac::paintMediaPlayButton): Ditto (WebCore::RenderThemeMac::paintMediaSeekBackButton): Ditto (WebCore::RenderThemeMac::paintMediaSeekForwardButton): Ditto (WebCore::RenderThemeMac::paintMediaSliderTrack): Ditto (WebCore::RenderThemeMac::paintMediaSliderThumb): Ditto

2009-01-08 Eric Carlson <​eric.carlson@apple.com>

Reviewed by Adele Peterson.

Simplify Mac interfaces for drawing media controller elements

<rdar://problem/6293969>

  • WebCoreSupport/WebSystemInterface.m: (InitWebCoreSystemInterface): Update for changes to media controller functions
11:45 AM Changeset in webkit [39713] by eric@webkit.org
  • 8 edits in trunk/WebCore

2009-01-08 Dimitri Glazkov <Dimitri Glazkov>

Reviewed by Eric Seidel.

Commit the right files this time! (Instead of the ugly unfixed ones.)
​https://bugs.webkit.org/show_bug.cgi?id=23191

  • platform/graphics/skia/BitmapImageSingleFrameSkia.h:
  • platform/graphics/skia/FloatPointSkia.cpp:
  • platform/graphics/skia/FloatRectSkia.cpp:
  • platform/graphics/skia/IntPointSkia.cpp:
  • platform/graphics/skia/IntRectSkia.cpp: (WebCore::IntRect::operator SkRect):
  • platform/graphics/skia/SkiaUtils.cpp: (WebCore::): (WebCore::WebCoreCompositeToSkiaComposite): (WebCore::SkPMColorToWebCoreColor): (WebCore::IntersectRectAndRegion): (WebCore::ClipRectToCanvas): (WebCore::SkPathContainsPoint): (WebCore::scratchContext):
  • platform/graphics/skia/SkiaUtils.h: (WebCore::WebCoreFloatToSkScalar): (WebCore::WebCoreDoubleToSkScalar):
10:58 AM Changeset in webkit [39712] by eric@webkit.org
  • 1 edit
    8 adds in trunk/WebCore

2009-01-08 Dimitri Glazkov <Dimitri Glazkov>

Reviewed by Eric Seidel.

Add the first few files from platform/graphics/skia
​https://bugs.webkit.org/show_bug.cgi?id=23191

These are all pretty simple.
Eventually BitmapImageSingleFrameSkia might grow a .cpp file, for now it's just a header.
SkiaUtils needs to die, but that can come later, no need to block up-streaming now.

  • platform/graphics/skia/BitmapImageSingleFrameSkia.h: Added. (WebCore::BitmapImageSingleFrameSkia::isBitmapImage): (WebCore::BitmapImageSingleFrameSkia::size): (WebCore::BitmapImageSingleFrameSkia::destroyDecodedData): (WebCore::BitmapImageSingleFrameSkia::decodedSize): (WebCore::BitmapImageSingleFrameSkia::nativeImageForCurrentFrame): (WebCore::BitmapImageSingleFrameSkia::BitmapImageSingleFrameSkia):
  • platform/graphics/skia/FloatPointSkia.cpp: Copied from WebCore/platform/graphics/mac/FloatPointMac.mm. (WebCore::FloatPoint::FloatPoint): (WebCore::FloatPoint::operator SkPoint):
  • platform/graphics/skia/FloatRectSkia.cpp: Copied from WebCore/platform/graphics/qt/IntRectQt.cpp. (WebCore::FloatRect::FloatRect): (WebCore::FloatRect::operator SkRect):
  • platform/graphics/skia/IntPointSkia.cpp: Copied from WebCore/platform/graphics/win/IntPointWin.cpp. (WebCore::IntPoint::IntPoint): (WebCore::IntPoint::operator SkIPoint): (WebCore::IntPoint::operator SkPoint):
  • platform/graphics/skia/IntRectSkia.cpp: Copied from WebCore/platform/graphics/qt/IntRectQt.cpp. (WebCore::IntRect::operator SkIRect): (WebCore::IntRect::operator SkRect): (WebCore::IntRect::IntRect):
  • platform/graphics/skia/SkiaUtils.cpp: Added. (WebCore::WebCorePointToSkiaPoint): (WebCore::WebCoreRectToSkiaRect): (WebCore::): (WebCore::WebCoreCompositeToSkiaComposite): (WebCore::InvScaleByte): (WebCore::SkPMColorToColor): (WebCore::SkPMColorToWebCoreColor): (WebCore::IntersectRectAndRegion): (WebCore::ClipRectToCanvas): (WebCore::SkPathContainsPoint): (WebCore::scratchContext):
  • platform/graphics/skia/SkiaUtils.h: Added. (WebCore::WebCoreFloatToSkScalar): (WebCore::WebCoreDoubleToSkScalar):
10:24 AM Changeset in webkit [39711] by pol@apple.com
  • 8 edits
    4 adds in trunk

2009-01-08 Pierre-Olivier Latour <​pol@apple.com>

Reviewed by Dan Bernstein.

Fixed CSS Transitions with zero-duration but non-zero-delay not starting or ending properly.

Also updated AnimationController::numberOfActiveAnimations() which now returns the number of "active" animations,
instead of simply the "running" ones.

​https://bugs.webkit.org/show_bug.cgi?id=23177

Tests: transitions/zero-duration-with-non-zero-delay-end.html

transitions/zero-duration-with-non-zero-delay-start.html

  • page/animation/AnimationBase.cpp: (WebCore::AnimationBase::fireAnimationEventsIfNeeded):
  • page/animation/AnimationController.cpp: (WebCore::AnimationControllerPrivate::animationTimerFired):
  • page/animation/CompositeAnimation.cpp: (WebCore::CompositeAnimationPrivate::numberOfActiveAnimations):

Added layout tests for CSS Transitions with zero-duration but non-zero-delay.

Also updated the layout test for DRT API numberOfActiveAnimations() which now returns the number of "active" animations,
instead of simply the running ones.

​https://bugs.webkit.org/show_bug.cgi?id=23177

  • animations/animation-controller-drt-api-expected.txt:
  • animations/animation-controller-drt-api.html:
  • platform/win/Skipped:
  • transitions/zero-duration-with-non-zero-delay-end-expected.txt: Added.
  • transitions/zero-duration-with-non-zero-delay-end.html: Added.
  • transitions/zero-duration-with-non-zero-delay-start-expected.txt: Added.
  • transitions/zero-duration-with-non-zero-delay-start.html: Added.
9:50 AM Changeset in webkit [39710] by pam@chromium.org
  • 2 edits in trunk/WebKitSite

2009-01-08 Brent Fulgham <​bfulgham@gmail.com>

Reviewed by Adele Petersen.
Landed by Pamela Greene.

Fixes: ​http://bugs.webkit.org/show_bug.cgi?id=23139
Remove links to no-longer-existing Drosera project.
Also, clean up references to wiki in the nav.inc file.

  • nav.inc: Correct paths to wiki, swap Drosera for Web Inspector.
9:05 AM Changeset in webkit [39709] by ap@webkit.org
  • 2 edits in trunk/WebCore

Reviewed by Oliver Hunt.

<rdar://problem/6477501> Repro crash loading HTML5 AppCache manifest directly

The crash happened whenever a cached resource was downloaded, as opposed to used directly.

No test, as downloading cannot be tested automatically.

  • loader/MainResourceLoader.cpp: (WebCore::MainResourceLoader::continueAfterContentPolicy): Cancel downloads that do not have an associated ResourceHandle, such as downloads from the application cache. Activity window shows "The URL can't be shown", and the frame remains empty.
8:47 AM Changeset in webkit [39708] by ap@webkit.org
  • 4 edits
    1 add in trunk/JavaScriptCore

2009-01-08 Jian Li <​jianli@chromium.org>

Reviewed by Alexey Proskuryakov.

Add Win32 implementation of ThreadSpecific.
​https://bugs.webkit.org/show_bug.cgi?id=22614

  • JavaScriptCore.vcproj/WTF/WTF.vcproj:
  • wtf/ThreadSpecific.h: (WTF::ThreadSpecific::ThreadSpecific): (WTF::ThreadSpecific::~ThreadSpecific): (WTF::ThreadSpecific::get): (WTF::ThreadSpecific::set): (WTF::ThreadSpecific::destroy):
  • wtf/ThreadSpecificWin.cpp: Added. (WTF::ThreadSpecificThreadExit):
  • wtf/ThreadingWin.cpp: (WTF::wtfThreadEntryPoint):
7:58 AM Changeset in webkit [39707] by Simon Hausmann
  • 3 edits in trunk/JavaScriptCore

2009-01-08 Justin McPherson <​justin.mcpherson@nokia.com>

Reviewed by Simon Hausmann.

Fix compilation with Qt on NetBSD.

7:51 AM Changeset in webkit [39706] by treat@webkit.org
  • 4 edits in trunk

Don't set the minimumFontSize and minimumLogicalFontSize as these are
just for accessibility and should be left up to the client application.

7:50 AM Changeset in webkit [39705] by Simon Hausmann
  • 2 edits in trunk/WebCore

2009-01-08 Justin McPherson <​justin.mcpherson@nokia.com>

Reviewed by Simon Hausmann.

Fix the Qt build on older X11 systems with special X paths
needed for NPAPI.

7:21 AM Changeset in webkit [39704] by Simon Hausmann
  • 4 edits in trunk/WebKit/qt

2009-01-08 Kavindra Palaraja <​kdpalara@trolltech.com>

Reviewed by Simon Hausmann.

Small fixes to the API documentation, missing 4.5 tags and
undocumented parameters.

7:04 AM Changeset in webkit [39703] by Adam Roben
  • 2 edits in trunk/WebCore

Windows build fix after r39699

  • DerivedSources.cpp: Added JSDOMStringList.cpp.
5:47 AM Changeset in webkit [39702] by Simon Hausmann
  • 2 edits in trunk/WebCore

2009-01-08 Kent Hansen <​khansen@trolltech.com>

Reviewed by Simon Hausmann.

Fix copy & paste of images in the Qt port.

Store the QPixmap itself in the mimedata, not a QPixmap* converted to bool.

4:33 AM Changeset in webkit [39701] by zecke@webkit.org
  • 2 edits in trunk/WebCore

2009-01-08 Hiroyuki Ikezoe <​poincare@ikezoe.net>

Reviewed by Holger Freyther.

​https://bugs.webkit.org/show_bug.cgi?id=23127

Invoke pango_coverage_get with each Unicode character.

  • platform/graphics/gtk/SimpleFontDataPango.cpp: (WebCore::SimpleFontData::containsCharacters):
4:32 AM Changeset in webkit [39700] by zecke@webkit.org
  • 3 edits in trunk/WebKit/gtk

Add webkit_web_view_reload_bypass_cache.

3:54 AM Changeset in webkit [39699] by ap@webkit.org
  • 15 edits
    8 adds in trunk

Reviewed by Darin Adler.

Part one of
​https://bugs.webkit.org/show_bug.cgi?id=23165
Add support for application cache dynamic entries

Test: http/tests/appcache/dynamic-entries-no-cache.html

  • DerivedSources.make:
  • GNUmakefile.am:
  • WebCore.pro:
  • WebCore.scons:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • WebCoreSources.bkl: Added new files.
  • bindings/js/JSDOMApplicationCacheCustom.cpp: (WebCore::JSDOMApplicationCache::hasItem): Added binding for hasItem(). Like other DOMApplicationCache methods, it needs to be custom to resolve relative URLs correctly.
  • bindings/js/JSDOMStringListCustom.cpp: Added.
  • dom/DOMStringList.cpp: Added.
  • dom/DOMStringList.h: Added.
  • dom/DOMStringList.idl: Added. Added an implementation of DOM 3 Core DOMStringList interface, which is returned by DOMApplicationCache items attribute.
  • dom/StaticStringList.cpp: Added.
  • dom/StaticStringList.h: Added. An implementation of DOMStringList that makes a snapshot (for DOMApplicationCache, this matches Firefox, as the spec doesn't say whether the returned list should be live or not).
  • loader/appcache/ApplicationCache.h: Added a list of pending dynamic entry actions, to be used in the near future.
  • loader/appcache/DOMApplicationCache.idl: Updated for spec changes. Instead of length attribute and item(), we now have an items attribute that returns a DOMStringList, and a hasItem convenience method.
  • loader/appcache/DOMApplicationCache.cpp: (WebCore::DOMApplicationCache::items): (WebCore::DOMApplicationCache::hasItem):
  • loader/appcache/DOMApplicationCache.h: Added implementations of items attribute and hasItem() (note that underlying ApplicationCache methods are still unimplemented though).
  • page/DOMWindow.idl: Expose a DOMStringList global constructor.

Jan 7, 2009:

10:15 PM Changeset in webkit [39698] by jhoneycutt@apple.com
  • 2 edits in trunk/WebKit/win

2009-01-07 Jon Honeycutt <​jhoneycutt@apple.com>

Fix a crash with querying a WebView for its global history item when
its associated Page has no global history item.

Reviewed by Dan Bernstein.

  • WebView.cpp: (WebView::globalHistoryItem): If the Page has no global history item, report 0.
5:46 PM Changeset in webkit [39697] by weinig@apple.com
  • 14 edits in trunk/JavaScriptCore

2009-01-07 Sam Weinig <​sam@webkit.org>

Reviewed by Geoffrey Garen.

<rdar://problem/6469060> Don't store exception information for a CodeBlock until first exception is thrown

Don't initially store exception information (lineNumber/expressionRange/getByIdExcecptionInfo)
in CodeBlocks blocks. Instead, re-parse for the data on demand and cache it then.

One important change that was needed to make this work was to pad op_get_global_var with nops to
be the same length as op_resolve_global, since one could be replaced for the other on re-parsing,
and we want to keep the offsets bytecode offsets the same.

1.3MB improvement on Membuster head.

  • bytecode/CodeBlock.cpp: (JSC::CodeBlock::dump): Update op_get_global_var to account for the padding. (JSC::CodeBlock::dumpStatistics): Add more statistic dumping. (JSC::CodeBlock::CodeBlock): Initialize m_exceptionInfo. (JSC::CodeBlock::reparseForExceptionInfoIfNecessary): Re-parses the CodeBlocks associated SourceCode and steals the ExceptionInfo from it. (JSC::CodeBlock::lineNumberForBytecodeOffset): Creates the exception info on demand. (JSC::CodeBlock::expressionRangeForBytecodeOffset): Ditto. (JSC::CodeBlock::getByIdExceptionInfoForBytecodeOffset): Ditto.
  • bytecode/CodeBlock.h: (JSC::CodeBlock::numberOfExceptionHandlers): Updated to account for m_exceptionInfo indirection. (JSC::CodeBlock::addExceptionHandler): Ditto. (JSC::CodeBlock::exceptionHandler): Ditto. (JSC::CodeBlock::clearExceptionInfo): Ditto. (JSC::CodeBlock::addExpressionInfo): Ditto. (JSC::CodeBlock::addGetByIdExceptionInfo): Ditto. (JSC::CodeBlock::numberOfLineInfos): Ditto. (JSC::CodeBlock::addLineInfo): Ditto. (JSC::CodeBlock::lastLineInfo): Ditto.
  • bytecode/Opcode.h: Change length of op_get_global_var to match op_resolve_global.
  • bytecode/SamplingTool.cpp: (JSC::SamplingTool::dump): Add comment indicating why it is okay not to pass a CallFrame.
  • bytecompiler/BytecodeGenerator.cpp: (JSC::BytecodeGenerator::generate): Clear the exception info after generation for Function and Eval Code when not in regenerate for exception info mode. (JSC::BytecodeGenerator::BytecodeGenerator): Initialize m_regeneratingForExceptionInfo to false. (JSC::BytecodeGenerator::emitGetScopedVar): Pad op_get_global_var with 2 nops.
  • bytecompiler/BytecodeGenerator.h: (JSC::BytecodeGenerator::setRegeneratingForExcpeptionInfo): Added.
  • interpreter/Interpreter.cpp: (JSC::Interpreter::throwException): Pass the CallFrame to exception info accessors. (JSC::Interpreter::privateExecute): Ditto. (JSC::Interpreter::retrieveLastCaller): Ditto. (JSC::Interpreter::cti_op_new_error): Ditto.
  • jit/JIT.cpp: (JSC::JIT::privateCompileMainPass): Pass the current bytecode offset instead of hard coding the line number, the stub will do the accessing if it gets called.
  • parser/Nodes.cpp: (JSC::ProgramNode::emitBytecode): Moved. (JSC::ProgramNode::generateBytecode): Moved. (JSC::EvalNode::create): Moved. (JSC::EvalNode::bytecodeForExceptionInfoReparse): Added. (JSC::FunctionBodyNode::generateBytecode): Rename reparse to reparseInPlace. (JSC::FunctionBodyNode::bytecodeForExceptionInfoReparse): Addded.
  • parser/Nodes.h: (JSC::ScopeNode::features): Added getter.
  • parser/Parser.cpp: (JSC::Parser::reparseInPlace): Renamed from reparse.
  • parser/Parser.h: (JSC::Parser::reparse): Added. Re-parses the passed in Node into a new Node.
  • runtime/ExceptionHelpers.cpp: (JSC::createUndefinedVariableError): Pass along CallFrame. (JSC::createInvalidParamError): Ditto. (JSC::createNotAConstructorError): Ditto. (JSC::createNotAFunctionError): Ditto. (JSC::createNotAnObjectError): Ditto.
5:37 PM Changeset in webkit [39696] by cmarrin@apple.com
  • 7 edits in trunk/WebCore

​https://bugs.webkit.org/show_bug.cgi?id=23122

This completes the removal of dependencies on WebKit from the platform code

5:28 PM Changeset in webkit [39695] by eric@webkit.org
  • 2 edits in trunk/WebKitTools

2009-01-07 Glenn Wilson <​gwilson@chromium.org>

Reviewed by Eric Seidel.

Changed DumpRenderTree to re-enable Javascript in web preferences on every test.
This fixes the case when a user mistakenly disables Javascript, and all layout tests crash.

  • DumpRenderTree/mac/DumpRenderTree.mm: (testStringByEvaluatingJavaScriptFromString): (setDefaultsToConsistentValuesForTesting):
4:27 PM Changeset in webkit [39694] by pkasting@chromium.org
  • 7 edits in trunk/WebCore

2008-01-07 Peter Kasting <​pkasting@google.com>

Reviewed by Sam Weinig.

​https://bugs.webkit.org/show_bug.cgi?id=22929

Fix errors while decoding GIFs by not calling setData() repeatedly
when it's not necessary. Pushes the responsibility for calling
setData() after clear() into the ImageSource which presumably knows
better than BitmapImage what needs to be done.

NOTE: The above bug is mainly about a memory regression, which this
patch does not fix.

  • platform/graphics/BitmapImage.cpp: (WebCore::BitmapImage::destroyDecodedData):
  • platform/graphics/ImageSource.h:
  • platform/graphics/cairo/ImageSourceCairo.cpp: (WebCore::ImageSource::clear):
  • platform/graphics/cg/ImageSourceCG.cpp: (WebCore::ImageSource::clear):
  • platform/graphics/qt/ImageSourceQt.cpp: (WebCore::ImageSource::~ImageSource): (WebCore::ImageSource::clear):
  • platform/graphics/wx/ImageSourceWx.cpp: (WebCore::ImageSource::~ImageSource): (WebCore::ImageSource::clear):
4:23 PM Changeset in webkit [39693] by justin.garcia@apple.com
  • 3 edits
    2 adds in trunk

WebCore:

2009-01-07 Justin Garcia <​justin.garcia@apple.com>

Reviewed by Darin Adler.

<rdar://problem/6355786> Find fails for queries that contain a line break

  • editing/TextIterator.cpp: (WebCore::findPlainText): Allow find with queries that contain newlines.

LayoutTests:

2009-01-07 Justin Garcia <​justin.garcia@apple.com>

Reviewed by Darin Adler.


<rdar://problem/6355786> Find fails for queries that contain a line break

  • editing/execCommand/6355786-expected.txt: Added.
  • editing/execCommand/6355786.html: Added.
4:00 PM Changeset in webkit [39692] by dino@apple.com
  • 1 edit in trunk/WebCore/ChangeLog

2009-01-07 Dean Jackson <​dino@apple.com>

Typo in ChangeLog. Don't want to offend mitz.

3:56 PM Changeset in webkit [39691] by dino@apple.com
  • 3 edits
    2 adds in trunk

2009-01-07 Dean Jackson <​dino@apple.com>

Reviewed by Dan Berstein.

Allow removal of inline shorthand properties for
animation, transition and transform origin. Also
add getter for shorthand animation property.

​https://bugs.webkit.org/show_bug.cgi?id=22605

Test: fast/css/transform-inline-style-remove.html

  • css/CSSMutableStyleDeclaration.cpp: (WebCore::CSSMutableStyleDeclaration::getPropertyValue):

Getter for animation property shorthand

(WebCore::initShorthandMap):

Adds initialisation for transform-origin, animation and transition

3:43 PM Changeset in webkit [39690] by zecke@webkit.org
  • 3 edits in trunk/WebCore

2009-01-07 Benjamin Otte <​otte@gnome.org>

Reviewed by Holger Freyther.

  • platform/network/ResourceHandleInternal.h: (WebCore::ResourceHandleInternal::ResourceHandleInternal):
  • platform/network/soup/ResourceHandleSoup.cpp: (WebCore::ResourceHandleInternal::~ResourceHandleInternal): (WebCore::parseDataUrl): (WebCore::ResourceHandle::startData): keep track of the idle handler we add and remove it in the destructor
3:24 PM Changeset in webkit [39689] by zecke@webkit.org
  • 5 edits in trunk

Implement LayoutTestController::numberOfActiveAnimations for Gtk+.

Add private API to WebKitWebFrame to get the information. The
implementation is coming from WebFrame.mm.

3:02 PM Changeset in webkit [39688] by dino@apple.com
  • 9 edits
    4 moves in trunk/WebCore

2009-01-07 Dean Jackson <​dino@apple.com>

Reviewed by Darin Adler.

Finish renaming of AffineTransform to TransformationMatrix, this
time ensuring that the platform implementations get the correct
name. Also, clean up some whitespace cruft in old content.

​https://bugs.webkit.org/show_bug.cgi?id=23151

  • GNUmakefile.am:
  • WebCore.pro:
  • WebCore.scons:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • platform/graphics/cairo/AffineTransformCairo.cpp: Removed.
  • platform/graphics/cairo/TransformationMatrixCairo.cpp: Copied from WebCore/platform/graphics/cairo/AffineTransformCairo.cpp.
  • platform/graphics/cg/AffineTransformCG.cpp: Removed.
  • platform/graphics/cg/TransformationMatrixCG.cpp: Copied from WebCore/platform/graphics/cg/AffineTransformCG.cpp.
  • platform/graphics/qt/AffineTransformQt.cpp: Removed.
  • platform/graphics/qt/TransformationMatrixQt.cpp: Copied from WebCore/platform/graphics/qt/AffineTransformQt.cpp.
  • platform/graphics/transforms/TransformationMatrix.cpp:
  • platform/graphics/transforms/TransformationMatrix.h:
  • platform/graphics/wx/AffineTransformWx.cpp: Removed.
  • platform/graphics/wx/TransformationMatrixWx.cpp: Copied from WebCore/platform/graphics/wx/AffineTransformWx.cpp.
  • webcore-wx.bkl:
2:57 PM Changeset in webkit [39687] by pol@apple.com
  • 3 edits in trunk/LayoutTests

2009-01-07 Pierre-Olivier Latour <​pol@apple.com>

Improve DRT API existence test in animation-test-helpers.js & transition-test-helpers.js.

​https://bugs.webkit.org/show_bug.cgi?id=23168

  • animations/animation-test-helpers.js:
  • transitions/transition-test-helpers.js:
2:33 PM Changeset in webkit [39686] by andersca@apple.com
  • 2 edits in trunk/WebCore

2009-01-07 Anders Carlsson <​andersca@apple.com>

Another build fix.


  • WebCore.LP64.exp:
2:30 PM Changeset in webkit [39685] by andersca@apple.com
  • 3 edits in trunk/WebKit/mac

2009-01-07 Anders Carlsson <​andersca@apple.com>

Reviewed by Dan Bernstein.

Fix build.


  • Plugins/Hosted/NetscapePluginInstanceProxy.h:
  • Plugins/Hosted/NetscapePluginInstanceProxy.mm: (WebKit::NetscapePluginInstanceProxy::idForObject):
2:03 PM Changeset in webkit [39684] by andersca@apple.com
  • 5 edits in trunk/WebKit/mac

2009-01-07 Anders Carlsson <​andersca@apple.com>

Reviewed by Dan Bernstein.

Add a way for a plug-in to get a reference to the Window JS object.

  • Plugins/Hosted/NetscapePluginHostProxy.mm: (WKPCGetWindowNPObject): Call the appropriate instance.


  • Plugins/Hosted/NetscapePluginInstanceProxy.h: Add object ID counter.


  • Plugins/Hosted/NetscapePluginInstanceProxy.mm: (WebKit::NetscapePluginInstanceProxy::destroy): Clear the object ID map.


(WebKit::NetscapePluginInstanceProxy::idForObject):
New method that returns a unique ID for a given JS object.


(WebKit::NetscapePluginInstanceProxy::getWindowNPObject):
Return the object ID for the window JS object.


  • Plugins/Hosted/WebKitPluginClient.defs: Add GetWindowNPObject.
12:24 PM Changeset in webkit [39683] by hyatt@apple.com
  • 4 edits in trunk/WebCore

2008-12-16 David Hyatt <​hyatt@apple.com>

Make Safari RSS behave nicely with full page zoom. Need to add a new value to enable resetting of zoom
back to the document-level default.

Reviewed by Darin Adler

  • css/CSSParser.cpp: (WebCore::CSSParser::parseValue):
  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::applyProperty):
  • css/CSSValueKeywords.in:
7:58 AM Changeset in webkit [39682] by Adam Roben
  • 3 edits in trunk/WebKit/win

Fix Bug 22262: Clicking close ("X") button in docked Web Inspector clears Web Inspector but doesn't close it

<​https://bugs.webkit.org/show_bug.cgi?id=22262>
<rdar://problem/6371873>

Reviewed by Darin Adler.

  • WebCoreSupport/WebInspectorClient.cpp: (WebInspectorClient::WebInspectorClient): Initialize new member. (WebInspectorClient::showWindow): Moved code from here to showWindowWithoutNotifications. (WebInspectorClient::closeWindow): Moved code from here to closeWindowWithoutNotifications.

(WebInspectorClient::attachWindow):
(WebInspectorClient::detachWindow):
Record whether or not we should be attached, then close and reopen the
window without notifying the InspectorController. Code that was in
these functions moved to showWindowWithoutNotifications and
closeWindowWithoutNotifications, respectively.

(WebInspectorClient::closeWindowWithoutNotifications): Added. Code
came from closeWindow and detachWindow.
(WebInspectorClient::showWindowWithoutNotifications): Added. Code came
from showWindow and attachWindow.

  • WebCoreSupport/WebInspectorClient.h: Added {close,show}WindowWithoutNotifications and m_shouldAttachWhenShown.
7:40 AM Changeset in webkit [39681] by Darin Adler
  • 12 edits in trunk

WebCore:

2009-01-07 Darin Adler <Darin Adler>

Reviewed by Oliver Hunt.

Bug 23160: add setMemoryCacheClientCallsEnabled SPI so Safari can be faster with activity window closed
​https://bugs.webkit.org/show_bug.cgi?id=23160

  • WebCore.base.exp: Added Page::setMemoryCacheClientCallsEnabled.
  • inspector/InspectorController.cpp: (WebCore::InspectorController::didLoadResourceFromMemoryCache): Updated to take a CachedResource so that there's no extra work the caller has to do when the inspector is disabled.
  • inspector/InspectorController.h: Ditto.
  • loader/DocumentLoader.h: Added recordMemoryCacheLoadForFutureClientNotification, takeMemoryCacheLoadsForClientNotification, and m_resourcesLoadedFromMemoryCacheForClientNotification.
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::loadedResourceFromMemoryCache): Streamlined code so less work is done when there's no inspector or client call needed. Added code to check areMemoryCacheClientCallsEnabled and if it's false, use recordMemoryCacheLoadForFutureClientNotification. (WebCore::FrameLoader::tellClientAboutPastMemoryCacheLoads): Added.
  • loader/FrameLoader.h: Ditto.
  • page/Page.cpp: (WebCore::Page::Page): Initialize m_areMemoryCacheClientCallsEnabled to be compatible with old behavior. (WebCore::Page::setMemoryCacheClientCallsEnabled): Added.
  • page/Page.h: Added setMemoryCacheClientCallsEnabled, areMemoryCacheClientCallsEnabled, and m_areMemoryCacheClientCallsEnabled.

WebKit/mac:

2009-01-07 Darin Adler <Darin Adler>

Reviewed by Oliver Hunt.

Bug 23160: add setMemoryCacheClientCallsEnabled SPI so Safari can be faster with activity window closed
​https://bugs.webkit.org/show_bug.cgi?id=23160

  • WebView/WebView.mm: (-[WebView setMemoryCacheDelegateCallsEnabled:]): Added. (-[WebView areMemoryCacheDelegateCallsEnabled]): Added
  • WebView/WebViewPrivate.h: Ditto.
7:35 AM Changeset in webkit [39680] by treat@webkit.org
  • 4 edits in trunk/WebKit/qt

Add Qt API to QWebHitTestResult::isScrollBar method

7:35 AM Changeset in webkit [39679] by treat@webkit.org
  • 3 edits in trunk/WebKit/qt

Add Qt API for QWebFrame::scrollBarGeometry method

7:24 AM Changeset in webkit [39678] by treat@webkit.org
  • 7 edits in trunk

Fix unused variable warnings

7:15 AM Changeset in webkit [39677] by Simon Hausmann
  • 9 edits in trunk

2009-01-07 Ariya Hidayat <​ariya.hidayat@trolltech.com>

Rubber-stamped by Simon Hausmann.

Qt build fix after r39670.

  • bridge/qt/qt_class.cpp: (JSC::Bindings::QtClass::fallbackObject):
  • bridge/qt/qt_class.h:
  • bridge/qt/qt_instance.cpp: (JSC::Bindings::QtInstance::mark): (JSC::Bindings::QtInstance::invokeMethod): (JSC::Bindings::QtInstance::defaultValue): (JSC::Bindings::QtInstance::stringValue): (JSC::Bindings::QtInstance::numberValue): (JSC::Bindings::QtInstance::booleanValue): (JSC::Bindings::QtInstance::valueOf): (JSC::Bindings::QtField::valueFromInstance): (JSC::Bindings::QtField::setValueToInstance):
  • bridge/qt/qt_instance.h:
  • bridge/qt/qt_runtime.cpp: (JSC::Bindings::valueRealType): (JSC::Bindings::convertValueToQVariant): (JSC::Bindings::convertQVariantToValue): (JSC::Bindings::findMethodIndex): (JSC::Bindings::QtRuntimeMetaMethod::call): (JSC::Bindings::QtRuntimeMetaMethod::lengthGetter): (JSC::Bindings::QtRuntimeMetaMethod::connectGetter): (JSC::Bindings::QtRuntimeMetaMethod::disconnectGetter): (JSC::Bindings::QtRuntimeConnectionMethod::call): (JSC::Bindings::QtRuntimeConnectionMethod::lengthGetter): (JSC::Bindings::::setValueAt): (JSC::Bindings::::valueAt):
  • bridge/qt/qt_runtime.h: (JSC::Bindings::QtRuntimeMethod::createStructure):

2009-01-07 Ariya Hidayat <​ariya.hidayat@trolltech.com>

Rubber-stamped by Simon Hausmann.

Qt build fix after r39670.

  • Api/qwebframe.cpp: (QWebFrame::evaluateJavaScript):
2:01 AM QtWebKitJournal edited by ariya.hidayat@trolltech.com
(diff)
2:01 AM QtWebKitJournal edited by ariya.hidayat@trolltech.com
(diff)
2:00 AM QtWebKitJournal edited by ariya.hidayat@trolltech.com
(diff)
2:00 AM QtWebKitJournal edited by ariya.hidayat@trolltech.com
(diff)
12:45 AM Changeset in webkit [39676] by Simon Hausmann
  • 2 edits in trunk/WebKit/qt

2009-01-06 Ariya Hidayat <​ariya.hidayat@trolltech.com>

Reviewed by Holger Freyther.

Allow building QtWebKit statically (within Qt).

​http://trolltech.com/developer/task-tracker/index_html?id=211273&method=entry

  • Api/qwebkitglobal.h:
12:16 AM Changeset in webkit [39675] by barraclough@apple.com
  • 2 edits in trunk/JavaScriptCore

2009-01-06 Gavin Barraclough <​baraclough@apple.com>

Reviewed by Maciej Stachowiak.

Replace accidentally removed references in BytecodeGenerator, deleting these
will be hindering the sharing of constant numbers and strings.

The code to add a new constant (either number or string) to their respective
map works by attempting to add a null entry, then checking the result of the
add for null. The first time, this should return the null (or noValue).
The code checks for null (to see if this is the initial add), and then allocates
a new number / string object. This code relies on the result returned from
the add to the map being stored as a reference, such that the allocated object
will be stored in the map, and will be resused if the same constant is encountered
again. By failing to use a reference we will be leaking GC object for each
additional entry added to the map. As GC objects they should be clollected,
be we should no be allocatin them in the first place.

​https://bugs.webkit.org/show_bug.cgi?id=23158

  • bytecompiler/BytecodeGenerator.cpp: (JSC::BytecodeGenerator::emitLoad):
12:07 AM Changeset in webkit [39674] by justin.garcia@apple.com
  • 2 edits in trunk/WebCore

2009-01-06 Justin Garcia <​justin.garcia@apple.com>

Reviewed by Oliver Hunt.

<rdar://problem/6391734> SnowLeopard: Crash doing Copy Image from context menu


Can't create an automated test case for specific contextual menu items yet and
a normal Copy doesn't cause a crash.

  • platform/mac/PasteboardMac.mm: (WebCore::fileWrapperForImage): The SharedBuffer may not have platform data. It may, for example, have a purgeable or regular buffer.
Note: See TracTimeline for information about the timeline view.