Timeline
Jan 10, 2009:
- 11:45 PM Changeset in webkit [39782] by
-
- 7 edits in trunk/WebCore
2009-01-10 Eric Carlson <eric.carlson@apple.com>
Reviewed by Eric Seidel.
https://bugs.webkit.org/show_bug.cgi?id=23210
Make it easier for ports to define custom UI for media controls
- css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::styleForElement): call theme()->styleSheetForMediaControls to get the media controller style sheet
- rendering/MediaControlElements.cpp: (WebCore::MediaControlInputElement::hitTest): Added
- rendering/MediaControlElements.h: Updated
- rendering/RenderMedia.cpp: (WebCore::RenderMedia::forwardEvent): Call element hitTest() method instead of local function so control elements don't necessarily have to be rectangular
- rendering/RenderTheme.cpp: (WebCore::RenderTheme::styleSheetForMediaControls): Added (WebCore::RenderTheme::hitTestMediaControlPart): Added
- rendering/RenderTheme.h: Updated
- 6:47 PM Changeset in webkit [39781] by
-
- 4 edits4 adds in trunk
2009-01-10 Simon Fraser <Simon Fraser>
Reviewed by Dan Bernstein
We need to disable LayoutState when an object has transforms,
because LayoutState is not transform-aware and therefore
repaint rects can be computed incorrectly.
Test: fast/repaint/transform-disable-layoutstate.html
- rendering/RenderBlock.cpp: (WebCore::RenderBlock::layoutBlock): (WebCore::RenderBlock::layoutOnlyPositionedObjects):
- rendering/RenderFlexibleBox.cpp: (WebCore::RenderFlexibleBox::layoutBlock):
- 4:05 PM Changeset in webkit [39780] by
-
- 7 edits5 deletes in trunk
Revert 39779.
- 3:16 PM Changeset in webkit [39779] by
-
- 7 edits5 adds in trunk
WebCore:
2009-01-10 Adam Barth <abarth@webkit.org>
Reviewed by Darin Adler.
We shouldn't update the document pointer of inactive windows. This
behavior differs slightly from Firefox, I'd argue that this behavior is
more correct (we both differ from IE). The HTML 5 spec is a bit in flux
on this point.
Test: http/tests/security/xss-inactive-closure.html
- bindings/js/JSDOMWindowBase.cpp: (WebCore::JSDOMWindowBase::~JSDOMWindowBase):
- bindings/js/ScriptController.cpp: (WebCore::ScriptController::clearWindowShell): (WebCore::ScriptController::updateDocument):
- bindings/js/ScriptController.h:
LayoutTests:
2009-01-10 Adam Barth <abarth@webkit.org>
Reviewed by Darin Adler.
Test that we don't do goofy things with the document pointer after
navigation.
- fast/dom/Window/dom-access-from-closure-iframe-expected.txt:
- fast/dom/Window/dom-access-from-closure-window-expected.txt:
- http/tests/security/resources/childWithButton.html: Added.
- http/tests/security/resources/xss-inactive-closure-child-2.html: Added.
- http/tests/security/resources/xss-inactive-closure-child.html: Added.
- http/tests/security/xss-inactive-closure-expected.txt: Added.
- http/tests/security/xss-inactive-closure.html: Added.
- 2:03 PM Changeset in webkit [39778] by
-
- 2 edits in trunk/WebKit/mac
2009-01-10 Darin Adler <Darin Adler>
Reviewed by Sam Weinig.
<rdar://problem/5845089> REGRESSION (r30044): Mail custom stationery missing images
because of change to -[HTMLObjectElement data]
- WebView/WebView.mm: (-[WebView _commonInitializationWithFrameName:groupName:usesDocumentViews:]): Added a thread violation check because I saw this being done off the main thread while testing Mail, and it caused problems. Put all the one time initialization under a single guard to make things just a little faster other times, and to make it clearer which things are one-time. Added a call to the new patchMailRemoveAttributesMethod function. (-[WebView initWithFrame:frameName:groupName:]): Added a thread violation check here too, because I assumed it would be slightly better to have a public method name in the violation message. This calls commonInitialization later, so it will hit that one eventually. (objectElementDataAttribute): Added. Just returns the value of the "data" attribute. (recursivelyRemoveMailAttributes): Added. Patch to an internal Mail method that in turn patches a WebKit method and removes the patch again on the way out. (patchMailRemoveAttributesMethod): Added. On Leopard only, checks the Mail version, and then applies the patch that fixes this bug.
Jan 9, 2009:
- 7:46 PM Changeset in webkit [39777] by
-
- 3 edits1 delete in trunk/WebCore
[QT] Make SharedTimer use QBasicTimer
Kill the SharedTimerQt.h and the usage of signal and slots
by using QBasicTimer.
- 7:46 PM Changeset in webkit [39776] by
-
- 2 edits in trunk/WebKit/gtk
2009-01-09 Benjamin Otte <otte@gnome.org>
Reviewed by Holger Freyther.
make the finalize function the dispose function. Not releasing held
objects in dispose can cause crashers later.
- webkit/webkitwebview.cpp:
- 7:46 PM Changeset in webkit [39775] by
-
- 2 edits in trunk/WebKit/gtk
2009-01-09 Benjamin Otte <otte@gnome.org>
Reviewed by Holger Freyther.
Remove broken code that uses a fallback. The previous code did 2
policy decisions which caused crashes.
Download is still notImplemented();
- webkit/webkitwebpolicydecision.cpp: (_WebKitWebPolicyDecisionPrivate::webkit_web_policy_decision_download):
- 7:46 PM Changeset in webkit [39774] by
-
- 2 edits in trunk/WebCore
2009-01-09 Adam Bergkvist <adam.bergkvist@ericsson.com>
Reviewed by Holger Freyther.
[CURL] POST without body becomes GET
https://bugs.webkit.org/show_bug.cgi?id=23182
Make sure that method is always set to POST even when the body is
empty. Cleaned up httpBody null check.
- platform/network/curl/ResourceHandleManager.cpp: (WebCore::ResourceHandleManager::setupPOST):
- 6:00 PM Changeset in webkit [39773] by
-
- 2 edits in trunk/WebCore
Build fix.
- 5:12 PM Changeset in webkit [39772] by
-
- 2 edits in trunk/WebCore
2009-01-09 Adele Peterson <adele@apple.com>
Reviewed by Darin Adler.
Fix infinite recursion in clientPaddingLeft and clientPaddingRight. This changes the code back to
how it was before RenderTextControlSingleLine was split out from RenderTextControl.
No test added since this code is only exercised when trying to place a search field's recent searches popup menu.
- rendering/RenderTextControlSingleLine.cpp: (WebCore::RenderTextControlSingleLine::clientPaddingLeft): (WebCore::RenderTextControlSingleLine::clientPaddingRight):
- 4:41 PM Changeset in webkit [39771] by
-
- 6 edits in trunk
WebCore:
2009-01-09 Darin Adler <Darin Adler>
Reviewed by Jon Honeycutt.
Bug 22913: REGRESSION: Space bar doesn't scroll on windows
https://bugs.webkit.org/show_bug.cgi?id=22913
rdar://problem/6479834
- page/EventHandler.cpp: (WebCore::EventHandler::defaultKeyboardEventHandler): Added code to call defaultSpaceEventHandler. (WebCore::EventHandler::defaultSpaceEventHandler): Added. Scrolls down or up based on the shift key.
- page/EventHandler.h: Added defaultSpaceEventHandler.
- platform/mac/ScrollViewMac.mm: (WebCore::ScrollView::platformScroll): Return false, because this function does not scroll. In an earlier version of this patch, I used this to prevent the patch from affecting the Mac, but I decided to use #if instead.
WebKit/win:
2009-01-09 Darin Adler <Darin Adler>
Reviewed by Jon Honeycutt.
Bug 22913: REGRESSION: Space bar doesn't scroll on windows
https://bugs.webkit.org/show_bug.cgi?id=22913
rdar://problem/6479834
- WebView.cpp: (WebView::keyPress): Removed code to handle space bar here; put it in WebCore instead.
- 4:38 PM Changeset in webkit [39770] by
-
- 2 edits in trunk/LayoutTests
2009-01-09 Sam Weinig <sam@webkit.org>
Check in correct results for failing test.
- fast/dom/Window/window-properties-expected.txt:
- 4:14 PM Changeset in webkit [39769] by
-
- 13 edits in trunk
2009-01-09 Gavin Barraclough <barraclough@apple.com>
Reviewed by Oliver Hunt.
Stage two of converting JSValue from a pointer to a class type.
Remove the class JSValue. The functionallity has been transitioned
into the wrapper class type JSValuePtr.
The last stage will be to rename JSValuePtr to JSValue, remove the
overloaded -> operator, and switch operations on JSValuePtrs from
using '->' to use '.' instead.
- API/APICast.h:
- JavaScriptCore.exp:
- runtime/JSCell.h: (JSC::asCell): (JSC::JSValuePtr::asCell): (JSC::JSValuePtr::isNumber): (JSC::JSValuePtr::isString): (JSC::JSValuePtr::isGetterSetter): (JSC::JSValuePtr::isObject): (JSC::JSValuePtr::getNumber): (JSC::JSValuePtr::getString): (JSC::JSValuePtr::getObject): (JSC::JSValuePtr::getCallData): (JSC::JSValuePtr::getConstructData): (JSC::JSValuePtr::getUInt32): (JSC::JSValuePtr::getTruncatedInt32): (JSC::JSValuePtr::getTruncatedUInt32): (JSC::JSValuePtr::mark): (JSC::JSValuePtr::marked): (JSC::JSValuePtr::toPrimitive): (JSC::JSValuePtr::getPrimitiveNumber): (JSC::JSValuePtr::toBoolean): (JSC::JSValuePtr::toNumber): (JSC::JSValuePtr::toString): (JSC::JSValuePtr::toObject): (JSC::JSValuePtr::toThisObject): (JSC::JSValuePtr::needsThisConversion): (JSC::JSValuePtr::toThisString): (JSC::JSValuePtr::getJSNumber):
- runtime/JSImmediate.h: (JSC::JSValuePtr::isUndefined): (JSC::JSValuePtr::isNull): (JSC::JSValuePtr::isUndefinedOrNull): (JSC::JSValuePtr::isBoolean): (JSC::JSValuePtr::getBoolean): (JSC::JSValuePtr::toInt32): (JSC::JSValuePtr::toUInt32):
- runtime/JSNumberCell.h: (JSC::JSValuePtr::uncheckedGetNumber): (JSC::JSValuePtr::toJSNumber):
- runtime/JSObject.h: (JSC::JSValuePtr::isObject): (JSC::JSValuePtr::get): (JSC::JSValuePtr::put):
- runtime/JSString.h: (JSC::JSValuePtr::toThisJSString):
- runtime/JSValue.cpp: (JSC::JSValuePtr::toInteger): (JSC::JSValuePtr::toIntegerPreserveNaN): (JSC::JSValuePtr::toInt32SlowCase): (JSC::JSValuePtr::toUInt32SlowCase):
- runtime/JSValue.h: (JSC::JSValuePtr::makeImmediate): (JSC::JSValuePtr::immediateValue): (JSC::JSValuePtr::JSValuePtr): (JSC::JSValuePtr::operator->): (JSC::JSValuePtr::operator bool): (JSC::JSValuePtr::operator==): (JSC::JSValuePtr::operator!=): (JSC::JSValuePtr::encode): (JSC::JSValuePtr::decode): (JSC::JSValuePtr::toFloat): (JSC::JSValuePtr::asValue): (JSC::operator==): (JSC::operator!=):
WebCore:
2009-01-09 Gavin Barraclough <barraclough@apple.com>
Reviewed by Oliver Hunt.
Delete references to JSValue, removing this class.
- bindings/js/JSWorkerContextCustom.cpp: (WebCore::JSWorkerContext::self):
- bindings/js/ScriptCallStack.h:
- 3:42 PM Changeset in webkit [39768] by
-
- 1 edit6 adds in trunk/WebCore
2009-01-09 Dimitri Glazkov <Dimitri Glazkov>
Reviewed by Eric Seidel.
Add svg/graphics/skia files.
https://bugs.webkit.org/show_bug.cgi?id=23147
- svg/graphics/skia/RenderPathSkia.cpp: Added. (WebCore::RenderPath::strokeContains):
- svg/graphics/skia/SVGPaintServerPatternSkia.cpp: Added. (WebCore::SVGPaintServerPattern::setup):
- svg/graphics/skia/SVGPaintServerSkia.cpp: Added. (WebCore::SVGPaintServer::draw): (WebCore::SVGPaintServer::teardown): (WebCore::SVGPaintServer::renderPath):
- svg/graphics/skia/SVGResourceFilterSkia.cpp: Added. (WebCore::SVGResourceFilter::createPlatformData): (WebCore::SVGResourceFilter::prepareFilter): (WebCore::SVGResourceFilter::applyFilter):
- svg/graphics/skia/SVGResourceMaskerSkia.cpp: Added. (WebCore::SVGResourceMasker::applyMask):
- 3:04 PM Changeset in webkit [39767] by
-
- 1 edit2 adds in trunk/WebCore
2009-01-09 Dimitri Glazkov <Dimitri Glazkov>
Reviewed by Eric Seidel.
Add SkiaFontWin to platform/graphics/chromium
https://bugs.webkit.org/show_bug.cgi?id=23215
- platform/graphics/skia/SkiaFontWin.cpp: Added. (WebCore::CachedOutlineKey::CachedOutlineKey): (WebCore::operator==): (WebCore::CachedOutlineKeyHash::hash): (WebCore::CachedOutlineKeyHash::equal): (WebCore::FIXEDToSkScalar): (WebCore::deleteOutline): (WebCore::addPolyCurveToPath): (WebCore::getPathForGlyph): (WebCore::SkiaWinOutlineCache::lookupOrCreatePathForGlyph): (WebCore::SkiaWinOutlineCache::removePathsForFont):
- platform/graphics/skia/SkiaFontWin.h: Added.
- 2:55 PM Changeset in webkit [39766] by
-
- 1 edit3 adds in trunk/WebCore
2009-01-09 Dimitri Glazkov <Dimitri Glazkov>
Reviewed by Eric Seidel.
Add PlatformContextSkia and PlatformGraphics.h to platform/graphics/skia
https://bugs.webkit.org/show_bug.cgi?id=23215
- platform/graphics/skia/PlatformContextSkia.cpp: Added. (PlatformContextSkia::State::State): (PlatformContextSkia::State::~State): (PlatformContextSkia::State::applyAlpha): (PlatformContextSkia::PlatformContextSkia): (PlatformContextSkia::~PlatformContextSkia): (PlatformContextSkia::setCanvas): (PlatformContextSkia::save): (PlatformContextSkia::restore): (PlatformContextSkia::drawRect): (PlatformContextSkia::setupPaintCommon): (PlatformContextSkia::setupPaintForFilling): (PlatformContextSkia::setupPaintForStroking): (PlatformContextSkia::setDrawLooper): (PlatformContextSkia::setMiterLimit): (PlatformContextSkia::setAlpha): (PlatformContextSkia::setLineCap): (PlatformContextSkia::setLineJoin): (PlatformContextSkia::setPorterDuffMode): (PlatformContextSkia::setFillColor): (PlatformContextSkia::getDrawLooper): (PlatformContextSkia::getStrokeStyle): (PlatformContextSkia::setStrokeStyle): (PlatformContextSkia::setStrokeColor): (PlatformContextSkia::getStrokeThickness): (PlatformContextSkia::setStrokeThickness): (PlatformContextSkia::getTextDrawingMode): (PlatformContextSkia::setTextDrawingMode): (PlatformContextSkia::setUseAntialiasing): (PlatformContextSkia::fillColor): (PlatformContextSkia::beginPath): (PlatformContextSkia::addPath): (PlatformContextSkia::setFillRule): (PlatformContextSkia::setGradient): (PlatformContextSkia::setPattern): (PlatformContextSkia::setDashPathEffect): (PlatformContextSkia::paintSkPaint): (PlatformContextSkia::bitmap): (PlatformContextSkia::isPrinting):
- platform/graphics/skia/PlatformContextSkia.h: Added. (PlatformContextSkia::currentPath): (PlatformContextSkia::canvas): (PlatformContextSkia::gdk_skia):
- platform/graphics/skia/PlatformGraphics.h: Added.
- 2:35 PM Changeset in webkit [39765] by
-
- 2 edits in trunk/WebCore
2009-01-09 Anders Carlsson <andersca@apple.com>
Fix build.
- WebCore.LP64.exp:
- 2:34 PM Changeset in webkit [39764] by
-
- 1 edit1 add in trunk/WebCore
2009-01-09 Dimitri Glazkov <Dimitri Glazkov>
Reviewed by Eric Seidel.
Add TransformationMatrixSkia to platform/graphics/skia
https://bugs.webkit.org/show_bug.cgi?id=23215
- platform/graphics/skia/TransformationMatrixSkia.cpp: Added. (WebCore::TransformationMatrix::TransformationMatrix): (WebCore::TransformationMatrix::setMatrix): (WebCore::TransformationMatrix::map): (WebCore::TransformationMatrix::mapRect): (WebCore::TransformationMatrix::isIdentity): (WebCore::TransformationMatrix::reset): (WebCore::TransformationMatrix::scale): (WebCore::TransformationMatrix::rotate): (WebCore::TransformationMatrix::translate): (WebCore::TransformationMatrix::shear): (WebCore::TransformationMatrix::det): (WebCore::TransformationMatrix::inverse): (WebCore::TransformationMatrix::operator SkMatrix): (WebCore::TransformationMatrix::operator==): (WebCore::TransformationMatrix::operator*=): (WebCore::TransformationMatrix::operator*): (WebCore::TransformationMatrix::a): (WebCore::TransformationMatrix::setA): (WebCore::TransformationMatrix::b): (WebCore::TransformationMatrix::setB): (WebCore::TransformationMatrix::c): (WebCore::TransformationMatrix::setC): (WebCore::TransformationMatrix::d): (WebCore::TransformationMatrix::setD): (WebCore::TransformationMatrix::e): (WebCore::TransformationMatrix::setE): (WebCore::TransformationMatrix::f): (WebCore::TransformationMatrix::setF):
- 2:33 PM Changeset in webkit [39763] by
-
- 10 edits3 copies3 adds in trunk/WebKit/win
2009-01-09 Brent Fulgham <bfulgham@gmail.com>
Reviewed by Adam Roben.
Fixes: http://bugs.webkit.org/show_bug.cgi?id=23092
Separate CFNetwork-specific code in WebKit.dll into separate
implementation files. Create cURL stub files to be populated
with new implementation in a future bug report.
- WebCookieManager.cpp: Move CFNetwork-specific routines to the new WebCookieManagerCFNet.cpp file. (WebCookieManager::Release):
- WebCookieManagerCFNet.cpp: Copied from WebCookieManager.cpp. (WebCookieManager::cookieStorage):
- WebCookieManagerCurl.cpp: Added. (WebCookieManager::cookieStorage): (WebCookieManager::setCookieStorage):
- WebCoreSupport/WebFrameLoaderClient.cpp: Conditionalize two methods in this file. (WebFrameLoaderClient::dispatchDidReceiveAuthenticationChallenge): (WebFrameLoaderClient::savePlatformDataToCachedPage):
- WebDownload.cpp: Move CFNetwork-specific logic to the new WebDownloadCFNet.cpp (WebDownload::bundleExtension): (WebDownload::bundleMagicNumber): (WebDownload::bundlePathForTargetPath): (WebDownload::extractResumeDataFromBundle): Made static class method so it could be used in WebDownload.cpp and WebDownloadCFNet.cpp (WebDownload::appendResumeDataToBundle): Made static class method so it could be used in WebDownload.cpp and WebDownloadCFNet.cpp
- WebDownload.h:
- WebDownloadCFNet.cpp: Copied from WebDownload.cpp. (WebDownload::initToResumeWithBundle): (WebDownload::setDestination): (didFailCallback):
- WebDownloadCurl.cpp: Added. (WebDownload::init): (WebDownload::initWithRequest): (WebDownload::initToResumeWithBundle): (WebDownload::start): (WebDownload::cancel): (WebDownload::cancelForResume): (WebDownload::deletesFileUponFailure): (WebDownload::setDeletesFileUponFailure): (WebDownload::setDestination): (WebDownload::cancelAuthenticationChallenge): (WebDownload::continueWithoutCredentialForAuthenticationChallenge): (WebDownload::useCredential):
- WebKit.vcproj/WebKit.vcproj: Modify Apple targets to exclude the new cURL files. Modify Cairo targets to exclude CFNet files.
- WebMutableURLRequest.cpp: Conditionalize the single method with a CFNetwork-speicic call. (WebMutableURLRequest::mutableCopy):
- WebURLAuthenticationChallenge.cpp: Conditionalize one line that causes build problems for cURL. This will be removed later. (WebURLAuthenticationChallenge::initWithProtectionSpace):
- WebURLAuthenticationChallengeSender.cpp:
- WebURLAuthenticationChallengeSenderCFNet.cpp: Copied from WebURLAuthenticationChallengeSender.cpp. (WebURLAuthenticationChallengeSender::useCredential):
- WebURLAuthenticationChallengeSenderCurl.cpp: Added. (WebURLAuthenticationChallengeSender::cancelAuthenticationChallenge): (WebURLAuthenticationChallengeSender::continueWithoutCredentialForAuthenticationChallenge): (WebURLAuthenticationChallengeSender::useCredential):
- WebURLResponse.cpp: Exclude WebKitSystemInterface when compiling for the cURL target.
- 2:21 PM Changeset in webkit [39762] by
-
- 3 edits4 adds in trunk
Reviewed by Darin Adler.
<rdar://problem/6477502> Repro crash reloading page using HTML5 AppCache on Windows
Test: http/tests/appcache/reload.html
On Windows, reloading resulted in the following sequence of events:
1) A new main resource loader was created and associated with the cache. Its document loader
was not associated with the cache yet.
2) The old document loader was destroyed, and since it was the last one, ApplicationCacheGroup
teardown started, with newestCache being zeroed out.
3) The new document loader was associated with the cache group, and cache update started.
4) Since newestCache was null, this caused many problems.
- loader/appcache/ApplicationCacheGroup.cpp: (WebCore::ApplicationCacheGroup::documentLoaderDestroyed): Improve comments and assertions, no functional changes. (WebCore::ApplicationCacheGroup::associateDocumentLoaderWithCache): Revive the cache group if its newest cache pointer is already saved for teardown. Note that the cache pointer validity is ensured by MainResourceLoader that holds a reference to it.
- 2:20 PM Changeset in webkit [39761] by
-
- 2 edits in trunk/WebKit/win
Reviewed by Darin Adler.
Fix many appcache tests on Windows by making synchronous XMLHttpRequest throw on cache miss.
- WebFrame.cpp: (WebFrame::cannotShowURLError): Implement, so that synchronous XHR can raise exceptions, as needed for AppCache tests. I do not know why this error was not implemented.
- 2:12 PM Changeset in webkit [39760] by
-
- 2 edits8 adds in trunk/WebCore
2009-01-09 Darin Fisher <darin@chromium.org>
Reviewed by Eric Seidel.
https://bugs.webkit.org/show_bug.cgi?id=23214
Upstream platform/network/chromium/
- platform/network/chromium/AuthenticationChallenge.h: Added. (WebCore::AuthenticationChallenge::AuthenticationChallenge): (WebCore::AuthenticationChallenge::sourceHandle):
- platform/network/chromium/AuthenticationChallengeChromium.cpp: Added. (WebCore::AuthenticationChallenge::platformCompare):
- platform/network/chromium/CookieJarChromium.cpp: Added. (WebCore::setCookies): (WebCore::cookies): (WebCore::cookiesEnabled):
- platform/network/chromium/DNSChromium.cpp: Added. (WebCore::prefetchDNS):
- platform/network/chromium/NetworkStateNotifierChromium.cpp: Added. (WebCore::NetworkStateNotifier::updateState): (WebCore::NetworkStateNotifier::NetworkStateNotifier):
- platform/network/chromium/NetworkStateNotifierPrivate.h: Added.
- platform/network/chromium/ResourceError.h: Added. (WebCore::ResourceError::ResourceError):
- platform/network/chromium/ResourceRequest.h: Added. (WebCore::ResourceRequest::): (WebCore::ResourceRequest::ResourceRequest): (WebCore::ResourceRequest::frame): (WebCore::ResourceRequest::setFrame): (WebCore::ResourceRequest::setTargetType): (WebCore::ResourceRequest::targetType): (WebCore::ResourceRequest::originPid): (WebCore::ResourceRequest::setOriginPid): (WebCore::ResourceRequest::securityInfo): (WebCore::ResourceRequest::setSecurityInfo): (WebCore::ResourceRequest::doUpdatePlatformRequest): (WebCore::ResourceRequest::doUpdateResourceRequest):
- platform/network/chromium/ResourceResponse.h: (WebCore::ResourceResponse::ResourceResponse): (WebCore::ResourceResponse::getSecurityInfo): (WebCore::ResourceResponse::setSecurityInfo): (WebCore::ResourceResponse::isContentFiltered): (WebCore::ResourceResponse::setIsContentFiltered): (WebCore::ResourceResponse::doUpdateResourceResponse):
- 1:44 PM Changeset in webkit [39759] by
-
- 1 edit in trunk/JavaScriptCore/ChangeLog
fix tyop in Changelog
- 1:42 PM Changeset in webkit [39758] by
-
- 3 edits in trunk/WebKit/mac
Reviewed by Darin Adler.
- fixed <rdar://problem/6234347> Add/change conditional key bindings for changing paragraph- and character-level writing direction (to match NSTextView)
- WebView/WebHTMLView.mm: (-[WebHTMLView validateUserInterfaceItemWithoutDelegate:]): Added code to validate makeBaseWritingDirectionLeftToRight: and makeBaseWritingDirectionRightToLeft:. (writingDirectionKeyBindingsEnabled): Changed this function to always return YES, except on Tiger and Leopard. (-[WebHTMLView makeBaseWritingDirectionLeftToRight:]): Renamed changeBaseWritingDirectionToLTR: to this. (-[WebHTMLView makeBaseWritingDirectionRightToLeft:]): Renamed changeBaseWritingDirectionToRTL: to this. (-[WebHTMLView changeBaseWritingDirectionToLTR:]): Now calls makeBaseWritingDirectionLeftToRight:. (-[WebHTMLView changeBaseWritingDirectionToRTL:]): Now calls makeBaseWritingDirectionRightToLeft:.
- WebView/WebView.mm: Added makeBaseWritingDirectionLeftToRight and makeBaseWritingDirectionRightToLeft to FOR_EACH_RESPONDER_SELECTOR.
- 1:01 PM Changeset in webkit [39757] by
-
- 4 edits in trunk/WebKit/win
2009-01-09 Darin Adler <Darin Adler>
Reviewed and landed by Adele Peterson.
Bug 23160: add setMemoryCacheClientCallsEnabled SPI so Safari can be faster with activity window closed
https://bugs.webkit.org/show_bug.cgi?id=23160
- Interfaces/IWebViewPrivate.idl: Added setMemoryCacheDelegateCallsEnabled.
- WebView.cpp: (WebView::setMemoryCacheDelegateCallsEnabled): Ditto.
- WebView.h: Ditto.
- 12:53 PM Changeset in webkit [39756] by
-
- 19 edits in trunk/WebKitSite
2009-01-09 William Siegrist <wsiegrist@apple.com>
Reviewed by David Kilzer
Update URLs which go through redirects by changing bugs.webkit.org URLs to use https and removing /projects/webkit from Trac URLs.
Replace tabs in bugpriorities.html with spaces.
- 12:17 PM Changeset in webkit [39755] by
-
- 3 edits in trunk/JavaScriptCore
2009-01-09 David Levin <levin@chromium.org>
Reviewed by Oliver Hunt.
Adjustment to previous patch. Remove call to initilizeThreading from JSGlobalCreate
and fix jsc.cpp instead.
- 11:42 AM Changeset in webkit [39754] by
-
- 2 edits in trunk/LayoutTests
2009-01-09 Joel Weinberger <jww@cs.berkeley.edu>
Reviewed by Darin Adler.
Landed by Adam Barth.
The test intended to test reload, but reference reload in one place and
replace in another. This makes them consistent.
- http/tests/security/resources/xss-DENIED-assign-location-reload-attacker.html:
- 11:12 AM Changeset in webkit [39753] by
-
- 3 edits in trunk/WebKit/qt
2009-01-09 Simon Hausmann <simon.hausmann@nokia.com>
Rubber-stamped by Tor Arne Vestbø.
Documentation fixes, remove duplicated docs, document missing
parameters and return values.
- 10:47 AM Changeset in webkit [39752] by
-
- 10 edits in trunk/JavaScriptCore
2009-01-09 Sam Weinig <sam@webkit.org>
Roll r39720 back in with a working interpreted mode.
- 10:46 AM Changeset in webkit [39751] by
-
- 7 edits in trunk/WebCore
2009-01-09 Peter Kasting <pkasting@google.com>
Reviewed by David Hyatt.
https://bugs.webkit.org/show_bug.cgi?id=22995
Fix flaky image animation by resetting the metadata for a frame when
we get new data for that frame. This fixes animations that halted
when the next frame of the animation wasn't complete by the time the
current frame's duration expired.
- platform/graphics/BitmapImage.cpp: (WebCore::BitmapImage::destroyDecodedData): (WebCore::BitmapImage::dataChanged):
- platform/graphics/BitmapImage.h: (WebCore::FrameData::~FrameData):
- platform/graphics/cairo/ImageCairo.cpp: (WebCore::FrameData::clear):
- platform/graphics/cg/ImageCG.cpp: (WebCore::FrameData::clear):
- platform/graphics/qt/ImageQt.cpp: (WebCore::FrameData::clear):
- platform/graphics/wx/ImageWx.cpp: (WebCore::FrameData::clear):
- 10:28 AM Changeset in webkit [39750] by
-
- 1 add in trunk/JavaScriptCore/wtf/PtrAndFlags.h
Whoops, include actual file the the forwarding headers point to.
- 9:58 AM Changeset in webkit [39749] by
-
- 2 edits in trunk/WebCore
2009-01-09 Simon Hausmann <simon.hausmann@nokia.com>
Rubber-stamped by Tor Arne Vestbø.
Swap the .h and the .cpp output in the Qt build for the
UserAgentStyleSheetData files, to put the definition in the .cpp file
and the declaration in the header file.
- 9:54 AM Changeset in webkit [39748] by
-
- 2 adds in trunk
include files missed in last commit.
- 9:53 AM Changeset in webkit [39747] by
-
- 13 edits in trunk
2009-01-09 David Levin <levin@chromium.org>
Reviewed by Oliver Hunt.
Added a template to make the pointer and flags combination
in UString more readable and less error prone.
- 9:47 AM Changeset in webkit [39746] by
-
- 2 edits in trunk/WebKit/qt
2009-01-09 Simon Hausmann <simon.hausmann@nokia.com>
Reviewed by Tor Arne Vestbø.
Fix linking against QtWebKit on Windows, by defining the EXPORT macros
_exactly_ the same way as in qglobal.h, depending on QT_NODLL,
QT_MAKEDLL and QT_SHARED.
- 8:51 AM Changeset in webkit [39745] by
-
- 2 edits in trunk/WebCore
2009-01-09 Tor Arne Vestbø <tavestbo@trolltech.com>
Reviewed by Simon Hausmann.
Prevent qmake from generating duplicate rules for embedded stylesheets
The STYLESHEETS_EMBED variable used to contain only one file name, but
now that it is a list of files we need to change it to be a dependency
for the stylesheet generator instead of the input.
- 5:03 AM Changeset in webkit [39744] by
-
- 4 edits in trunk
WebCore:
2009-01-09 Simon Hausmann <simon.hausmann@nokia.com>
Reviewed by Tor Arne Vestbø.
Fix qmake warning about missing test function, a contains() call was
missing.
WebKit/qt:
2009-01-09 Simon Hausmann <simon.hausmann@nokia.com>
Reviewed by Tor Arne Vestbø.
Remove qwebnetworkinterface.h from WEBKIT_API_HEADERS as it's not
public Qt 4.4/4.5 API.
- 4:32 AM Changeset in webkit [39743] by
-
- 2 edits in trunk/LayoutTests
- fast/dom/Window/window-properties-expected.txt: Forgot to commit this with r39699, too.
- 4:16 AM Changeset in webkit [39742] by
-
- 2 edits in trunk/WebKit/qt
2009-01-09 Simon Hausmann <simon.hausmann@nokia.com>
Unreviewed Qt build fix, remove qcookiejar.h from the API headers and
therefore HEADERS. It's not part of the API and it moc shouldn't be
called on it.
- 3:10 AM Changeset in webkit [39741] by
-
- 4 edits in trunk
2009-01-09 Simon Hausmann <simon.hausmann@nokia.com>
Rubber-stamped by Tor Arne Vestbø.
Add the Qt API headers to HEADERS, too, for improved completion in IDEs.
- 1:42 AM Changeset in webkit [39740] by
-
- 3 edits in trunk/WebCore
2009-01-09 David Levin <levin@chromium.org>
Reviewed by Alexey Proskuryakov.
Fix deref's of string happening on two different threads.
No observable change in behavior, so no test. However, there are asserts
being added for https://bugs.webkit.org/show_bug.cgi?id=23175 which
will detect this issue while running the normal worker tests.
- dom/WorkerThread.cpp: (WebCore::WorkerThreadStartupData::create): (WebCore::WorkerThreadStartupData::WorkerThreadStartupData): (WebCore::WorkerThread::WorkerThread): (WebCore::WorkerThread::workerThread):
- dom/WorkerThread.h:
- 12:12 AM Changeset in webkit [39739] by
-
- 2 edits in trunk/LayoutTests
2009-01-08 Gavin Barraclough <barraclough@apple.com>
RS by Oliver Hunt.
Looks like this should have been updated with r39699.
- fast/js/global-constructors-expected.txt:
- 12:11 AM Changeset in webkit [39738] by
-
- 11 edits in trunk/JavaScriptCore
2009-01-08 Gavin Barraclough <barraclough@apple.com>
Reviewed by Oliver Hunt.
Encode immediates in the low word of JSValuePtrs, on x86-64.
On 32-bit platforms a JSValuePtr may represent a 31-bit signed integer.
On 64-bit platforms, if USE(ALTERNATE_JSIMMEDIATE) is defined, a full
32-bit integer may be stored in an immediate.
Presently USE(ALTERNATE_JSIMMEDIATE) uses the same encoding as the default
immediate format - the value is left shifted by one, so a one bit tag can
be added to indicate the value is an immediate. However this means that
values must be commonly be detagged (by right shifting by one) before
arithmetic operations can be performed on immediates. This patch modifies
the formattting so the the high bits of the immediate mark values as being
integer.
- assembler/MacroAssembler.h: (JSC::MacroAssembler::not32): (JSC::MacroAssembler::orPtr): (JSC::MacroAssembler::zeroExtend32ToPtr): (JSC::MacroAssembler::jaePtr): (JSC::MacroAssembler::jbPtr): (JSC::MacroAssembler::jnzPtr): (JSC::MacroAssembler::jzPtr):
- assembler/X86Assembler.h: (JSC::X86Assembler::): (JSC::X86Assembler::notl_r): (JSC::X86Assembler::testq_i32r):
- jit/JIT.cpp: (JSC::JIT::privateCompileMainPass): (JSC::JIT::privateCompileSlowCases): (JSC::JIT::privateCompileCTIMachineTrampolines):
- jit/JIT.h:
- jit/JITArithmetic.cpp: (JSC::JIT::compileFastArith_op_lshift): (JSC::JIT::compileFastArith_op_rshift): (JSC::JIT::compileFastArith_op_bitand): (JSC::JIT::compileFastArithSlow_op_bitand): (JSC::JIT::compileFastArith_op_mod): (JSC::JIT::compileFastArithSlow_op_mod): (JSC::JIT::compileFastArith_op_add): (JSC::JIT::compileFastArith_op_mul): (JSC::JIT::compileFastArith_op_post_inc): (JSC::JIT::compileFastArith_op_post_dec): (JSC::JIT::compileFastArith_op_pre_inc): (JSC::JIT::compileFastArith_op_pre_dec): (JSC::JIT::putDoubleResultToJSNumberCellOrJSImmediate): (JSC::JIT::compileBinaryArithOp):
- jit/JITCall.cpp: (JSC::JIT::compileOpCallSlowCase):
- jit/JITInlineMethods.h: (JSC::JIT::emitJumpIfJSCell): (JSC::JIT::emitJumpIfNotJSCell): (JSC::JIT::emitJumpIfImmNum): (JSC::JIT::emitJumpSlowCaseIfNotImmNum): (JSC::JIT::emitJumpSlowCaseIfNotImmNums): (JSC::JIT::emitFastArithDeTagImmediate): (JSC::JIT::emitFastArithDeTagImmediateJumpIfZero): (JSC::JIT::emitFastArithReTagImmediate): (JSC::JIT::emitFastArithImmToInt): (JSC::JIT::emitFastArithIntToImmNoCheck): (JSC::JIT::emitTagAsBoolImmediate):
- jit/JITPropertyAccess.cpp: (JSC::resizePropertyStorage): (JSC::JIT::privateCompilePutByIdTransition): (JSC::JIT::privateCompilePatchGetArrayLength): (JSC::JIT::privateCompileGetByIdSelf): (JSC::JIT::privateCompileGetByIdProto): (JSC::JIT::privateCompileGetByIdChain): (JSC::JIT::privateCompilePutByIdReplace):
- runtime/JSImmediate.h: (JSC::JSImmediate::isNumber): (JSC::JSImmediate::isPositiveNumber): (JSC::JSImmediate::areBothImmediateNumbers): (JSC::JSImmediate::xorImmediateNumbers): (JSC::JSImmediate::rightShiftImmediateNumbers): (JSC::JSImmediate::canDoFastAdditiveOperations): (JSC::JSImmediate::addImmediateNumbers): (JSC::JSImmediate::subImmediateNumbers): (JSC::JSImmediate::makeInt): (JSC::JSImmediate::toBoolean):
- wtf/Platform.h:
