⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Jan 12, 2009:

11:54 PM Changeset in webkit [39852] by mrowe@apple.com
  • 6 edits in trunk/WebKitTools

Use the modern spelling of WebKit.

  • Scripts/find-extra-includes:
  • Scripts/report-include-statistics:
  • Scripts/run-webkit-app:
  • Scripts/svn-unapply:
  • Scripts/update-webkit:
8:51 PM Changeset in webkit [39851] by barraclough@apple.com
  • 38 edits in trunk

JavaScriptCore:

2009-01-12 Gavin Barraclough <​barraclough@apple.com>

Reviewed by Oliver Hunt.

Make the JSImmediate interface private.

All manipulation of JS values should be through the JSValuePtr class, not by using JSImmediate
directly. The key missing methods on JSValuePtr are:

  • isCell() - check for values that are JSCell*s, and as such where asCell() may be used.
  • isInt32Fast() getInt32Fast() - fast check/access for integer immediates.
  • isUInt32Fast() getUInt32Fast() - ditto for unsigned integer immediates.

The JIT is allowed full access to JSImmediate, since it needs to be able to directly
manipulate JSValuePtrs. The Interpreter is provided access to perform operations directly
on JSValuePtrs through the new JSFastMath interface.

No performance impact.

  • API/JSCallbackObjectFunctions.h: (JSC::::toNumber):
  • API/JSValueRef.cpp: (JSValueIsEqual): (JSValueIsStrictEqual):
  • JavaScriptCore.exp:
  • bytecode/CodeBlock.h: (JSC::CodeBlock::isKnownNotImmediate):
  • bytecompiler/BytecodeGenerator.cpp: (JSC::keyForImmediateSwitch):
  • bytecompiler/BytecodeGenerator.h: (JSC::BytecodeGenerator::JSValueHashTraits::constructDeletedValue): (JSC::BytecodeGenerator::JSValueHashTraits::isDeletedValue):
  • interpreter/Interpreter.cpp: (JSC::jsLess): (JSC::jsLessEq): (JSC::jsAdd): (JSC::jsIsObjectType): (JSC::cachePrototypeChain): (JSC::Interpreter::tryCachePutByID): (JSC::Interpreter::tryCacheGetByID): (JSC::Interpreter::privateExecute): (JSC::Interpreter::tryCTICachePutByID): (JSC::Interpreter::tryCTICacheGetByID): (JSC::Interpreter::cti_op_add): (JSC::Interpreter::cti_op_get_by_id_self_fail): (JSC::Interpreter::cti_op_get_by_id_proto_list): (JSC::Interpreter::cti_op_instanceof): (JSC::Interpreter::cti_op_mul): (JSC::Interpreter::cti_op_get_by_val): (JSC::Interpreter::cti_op_get_by_val_byte_array): (JSC::Interpreter::cti_op_sub): (JSC::Interpreter::cti_op_put_by_val): (JSC::Interpreter::cti_op_put_by_val_array): (JSC::Interpreter::cti_op_put_by_val_byte_array): (JSC::Interpreter::cti_op_negate): (JSC::Interpreter::cti_op_div): (JSC::Interpreter::cti_op_eq): (JSC::Interpreter::cti_op_lshift): (JSC::Interpreter::cti_op_bitand): (JSC::Interpreter::cti_op_rshift): (JSC::Interpreter::cti_op_bitnot): (JSC::Interpreter::cti_op_neq): (JSC::Interpreter::cti_op_urshift): (JSC::Interpreter::cti_op_call_eval): (JSC::Interpreter::cti_op_throw): (JSC::Interpreter::cti_op_is_undefined): (JSC::Interpreter::cti_op_stricteq): (JSC::Interpreter::cti_op_nstricteq): (JSC::Interpreter::cti_op_switch_imm): (JSC::Interpreter::cti_vm_throw):
  • interpreter/Interpreter.h: (JSC::Interpreter::isJSArray): (JSC::Interpreter::isJSString): (JSC::Interpreter::isJSByteArray):
  • jit/JIT.cpp: (JSC::JIT::compileOpStrictEq): (JSC::JIT::privateCompileMainPass):
  • jit/JIT.h: (JSC::JIT::isStrictEqCaseHandledInJITCode):
  • jit/JITArithmetic.cpp: (JSC::JIT::compileFastArith_op_rshift): (JSC::JIT::compileFastArith_op_bitand): (JSC::JIT::compileFastArith_op_mod):
  • jit/JITCall.cpp: (JSC::JIT::unlinkCall): (JSC::JIT::compileOpCall):
  • jit/JITInlineMethods.h: (JSC::JIT::getConstantOperandImmediateInt): (JSC::JIT::isOperandConstantImmediateInt):
  • parser/Nodes.cpp: (JSC::processClauseList):
  • runtime/ArrayPrototype.cpp: (JSC::arrayProtoFuncIndexOf): (JSC::arrayProtoFuncLastIndexOf):
  • runtime/BooleanPrototype.cpp: (JSC::booleanProtoFuncValueOf):
  • runtime/Collector.cpp: (JSC::Heap::protect): (JSC::Heap::unprotect): (JSC::Heap::heap):
  • runtime/JSByteArray.cpp: (JSC::JSByteArray::getOwnPropertySlot):
  • runtime/JSByteArray.h: (JSC::JSByteArray::getIndex):
  • runtime/JSCell.cpp:
  • runtime/JSCell.h: (JSC::JSValuePtr::isNumberCell): (JSC::JSValuePtr::asCell): (JSC::JSValuePtr::isNumber):
  • runtime/JSGlobalObjectFunctions.cpp: (JSC::globalFuncParseInt):
  • runtime/JSImmediate.h: (JSC::js0): (JSC::jsImpossibleValue): (JSC::JSValuePtr::toInt32): (JSC::JSValuePtr::toUInt32): (JSC::JSValuePtr::isCell): (JSC::JSValuePtr::isInt32Fast): (JSC::JSValuePtr::getInt32Fast): (JSC::JSValuePtr::isUInt32Fast): (JSC::JSValuePtr::getUInt32Fast): (JSC::JSValuePtr::makeInt32Fast): (JSC::JSValuePtr::areBothInt32Fast): (JSC::JSFastMath::canDoFastBitwiseOperations): (JSC::JSFastMath::equal): (JSC::JSFastMath::notEqual): (JSC::JSFastMath::andImmediateNumbers): (JSC::JSFastMath::xorImmediateNumbers): (JSC::JSFastMath::orImmediateNumbers): (JSC::JSFastMath::canDoFastRshift): (JSC::JSFastMath::canDoFastUrshift): (JSC::JSFastMath::rightShiftImmediateNumbers): (JSC::JSFastMath::canDoFastAdditiveOperations): (JSC::JSFastMath::addImmediateNumbers): (JSC::JSFastMath::subImmediateNumbers): (JSC::JSFastMath::incImmediateNumber): (JSC::JSFastMath::decImmediateNumber):
  • runtime/JSNumberCell.h: (JSC::JSValuePtr::asNumberCell): (JSC::jsNumber): (JSC::JSValuePtr::uncheckedGetNumber): (JSC::JSNumberCell::toInt32): (JSC::JSNumberCell::toUInt32): (JSC::JSValuePtr::toJSNumber): (JSC::JSValuePtr::getNumber): (JSC::JSValuePtr::numberToInt32): (JSC::JSValuePtr::numberToUInt32):
  • runtime/JSObject.h: (JSC::JSValuePtr::isObject): (JSC::JSValuePtr::get): (JSC::JSValuePtr::put):
  • runtime/JSValue.cpp: (JSC::JSValuePtr::toInteger): (JSC::JSValuePtr::toIntegerPreserveNaN):
  • runtime/JSValue.h:
  • runtime/Operations.cpp: (JSC::JSValuePtr::equalSlowCase): (JSC::JSValuePtr::strictEqualSlowCase):
  • runtime/Operations.h: (JSC::JSValuePtr::equal): (JSC::JSValuePtr::equalSlowCaseInline): (JSC::JSValuePtr::strictEqual): (JSC::JSValuePtr::strictEqualSlowCaseInline):
  • runtime/Protect.h: (JSC::gcProtect): (JSC::gcUnprotect):
  • runtime/StringPrototype.cpp: (JSC::stringProtoFuncCharAt): (JSC::stringProtoFuncCharCodeAt):
  • runtime/Structure.cpp: (JSC::Structure::createCachedPrototypeChain):

WebCore:

2009-01-12 Gavin Barraclough <​barraclough@apple.com>

Reviewed by Oliver Hunt.

Deprecate JSValuePtr::getNumber() - two ways to get a number should be enough.

  • bindings/js/JSSQLTransactionCustom.cpp: (WebCore::JSSQLTransaction::executeSql):
  • bindings/objc/WebScriptObject.mm: (+[WebScriptObject _convertValueToObjcValue:originRootObject:rootObject:]):

WebKit/mac:

2009-01-12 Gavin Barraclough <​barraclough@apple.com>

Reviewed by Oliver Hunt.

Deprecate JSValuePtr::getNumber() - two ways to get a number should be enough.

  • WebView/WebView.mm: (aeDescFromJSValue):
6:33 PM Changeset in webkit [39850] by beidson@apple.com
  • 2 edits in trunk/WebKit/win

2009-01-12 Brady Eidson <​beidson@apple.com>

Reviewed by NOBODY (OOPS!).


<rdar://problem/6490446> - Crash when going back to a cached page

  • WebCoreSupport/WebFrameLoaderClient.cpp: (WebFrameLoaderClient::savePlatformDataToCachedPage): ENABLE(CFNETWORK) needed to be USE(CFNETWORK)
5:09 PM Changeset in webkit [39849] by cmarrin@apple.com
  • 4 edits in trunk/WebCore

Fixed ​https://bugs.webkit.org/show_bug.cgi?id=22919

I added a common getElapsedTime() function to AnimationBase which uses a combination of
the techniques from KeyframeAnimation and AnimationBase to compute elapsedTime in all
states.

  • page/animation/AnimationBase.cpp: (WebCore::AnimationBase::progress): (WebCore::AnimationBase::getElapsedTime):
  • page/animation/AnimationBase.h:
  • page/animation/KeyframeAnimation.cpp: (WebCore::KeyframeAnimation::animate):
4:22 PM Changeset in webkit [39848] by bfulgham@webkit.org
  • 3 edits
    2 adds in trunk

Correct scrolldelay units (s -> ms)

4:20 PM Changeset in webkit [39847] by Simon Fraser
  • 2 edits in trunk/WebCore

2009-01-12 Simon Fraser <Simon Fraser>

Reviewed by Dan Bernstein

​https://bugs.webkit.org/show_bug.cgi?id=23273

In RenderBox::repaintLayerRectsForImage(), the repaint rect does not have
to be computed in absolute coordintes. Instead, we compute a repaintRect
relative to the RenderObject, which can repaint itself.

  • rendering/RenderBox.cpp: (WebCore::RenderBox::repaintLayerRectsForImage):
4:15 PM Changeset in webkit [39846] by hyatt@apple.com
  • 2 edits in trunk/WebCore

2009-01-12 David Hyatt <​hyatt@apple.com>

Apply the same idea as the previous fix but for matched declarations.

Reviewed by Dan Bernstein

  • css/CSSStyleSelector.h:
4:15 PM Changeset in webkit [39845] by beidson@apple.com
  • 17 edits in trunk

WebCore:

2009-01-12 Brady Eidson <​beidson@apple.com>

Reviewed by Darin Adler

<rdar://problem/6468274> - Track Non-get requests in global history

  • WebCore.base.exp:
  • history/HistoryItem.cpp: (WebCore::HistoryItem::HistoryItem):
  • history/HistoryItem.h: (WebCore::HistoryItem::lastVisitWasHTTPNonGet): (WebCore::HistoryItem::setLastVisitWasHTTPNonGet):

WebKit/mac:

2009-01-12 Brady Eidson <​beidson@apple.com>

Reviewed by Darin Adler

<rdar://problem/6468274> - Track Non-get requests in global history

  • History/WebHistory.mm: (-[WebHistory _visitedURL:withTitle:method:wasFailure:]):
  • History/WebHistoryInternal.h:
  • History/WebHistoryItem.mm: (-[WebHistoryItem initFromDictionaryRepresentation:]): (-[WebHistoryItem dictionaryRepresentation]): (-[WebHistoryItem _lastVisitWasHTTPNonGet]):
  • History/WebHistoryItemPrivate.h:
  • WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::updateGlobalHistory): Only pass the method through if it was an HTTP load

WebKit/win:

2009-01-12 Brady Eidson <​beidson@apple.com>

Reviewed by Darin Adler

<rdar://problem/6468274> - Track Non-get requests in global history

  • WebCoreSupport/WebFrameLoaderClient.cpp: (WebFrameLoaderClient::updateGlobalHistory):
  • WebHistory.cpp: (WebHistory::addItem):
  • WebHistory.h:
  • Interfaces/IWebHistoryItemPrivate.idl:
  • WebHistoryItem.cpp: (WebHistoryItem::initFromDictionaryRepresentation): (WebHistoryItem::dictionaryRepresentation): (WebHistoryItem::lastVisitWasHTTPNonGet): (WebHistoryItem::setLastVisitWasHTTPNonGet):
  • WebHistoryItem.h:
3:49 PM Changeset in webkit [39844] by kevino@webkit.org
  • 2 edits in trunk/WebKit/wx

wx build fix. JSValue* -> JSValuePtr.

3:47 PM Changeset in webkit [39843] by kevino@webkit.org
  • 5 edits in trunk/WebCore

!ENABLE(SVG_FONTS) build fix. Move defaultUnitsPerEm into a non-SVG header so it can be used by all builds.

3:41 PM Changeset in webkit [39842] by kevino@webkit.org
  • 2 edits in trunk/WebCore

wx build typo fix.

3:39 PM Changeset in webkit [39841] by kevino@webkit.org
  • 2 edits in trunk/JavaScriptCore

Since platform date time functions have moved to JSC, now the wx port JSC needs to depend on wx.

3:18 PM Changeset in webkit [39840] by andersca@apple.com
  • 5 edits in trunk/WebKit/mac

2009-01-12 Anders Carlsson <​andersca@apple.com>

Reviewed by Sam Weinig.

Move marshalling into NetscapePluginInstanceProxy.


Add support for marshallin strings.


  • Plugins/Hosted/NetscapePluginHostProxy.mm: (WKPCEvaluate): (WKPCInvoke):
  • Plugins/Hosted/NetscapePluginInstanceProxy.h:
  • Plugins/Hosted/NetscapePluginInstanceProxy.mm: (WebKit::NetscapePluginInstanceProxy::evaluate): (WebKit::NetscapePluginInstanceProxy::invoke): (WebKit::NetscapePluginInstanceProxy::marshalValue):
  • Plugins/Hosted/WebKitPluginHostTypes.h:
3:01 PM Changeset in webkit [39839] by hyatt@apple.com
  • 2 edits in trunk/WebCore

2009-01-12 David Hyatt <​hyatt@apple.com>

Make sure the set of matched rules has a reserved capacity of 32. This prevents remalloc thrash as
elements are matched, since the Vector is shrinking and growing over and over. 1% PLT speedup.

Reviewed by Oliver Hunt

  • css/CSSStyleSelector.h:
2:37 PM Changeset in webkit [39838] by hyatt@apple.com
  • 2 edits in trunk/WebCore

2009-01-12 David Hyatt <​hyatt@apple.com>

Optimize Element::attributeChanged to just check if accessibility is enabled up front before looking at the
two accessibility-related attributes. This avoids the rest of the code for all attributes on the PLT.
Tiny speedup.

Reviewed by Oliver Hunt

  • dom/Element.cpp: (WebCore::Element::attributeChanged):
2:34 PM Changeset in webkit [39837] by hyatt@apple.com
  • 2 edits in trunk/WebCore

2009-01-12 David Hyatt <​hyatt@apple.com>

Optimize the retrieval of line height. If the document is not using any first-line rules, just immediately
default to the normal case. Tiny speedup on PLT.

Reviewed by Oliver Hunt

  • rendering/RenderFlow.cpp: (WebCore::RenderFlow::lineHeight):
2:25 PM Changeset in webkit [39836] by andersca@apple.com
  • 5 edits in trunk/WebKit/mac

2009-01-12 Anders Carlsson <​andersca@apple.com>

Reviewed by Sam Weinig.

Implement WKPCInvoke.


  • Plugins/Hosted/NetscapePluginHostProxy.mm: (WKPCEvaluate): (WKPCInvoke):
  • Plugins/Hosted/NetscapePluginInstanceProxy.h:
  • Plugins/Hosted/NetscapePluginInstanceProxy.mm: (WebKit::NetscapePluginInstanceProxy::idForObject): (WebKit::NetscapePluginInstanceProxy::invoke):
  • Plugins/Hosted/WebKitPluginClient.defs:
2:15 PM QtWebKitTodo edited by Simon Hausmann
(diff)
2:15 PM Changeset in webkit [39835] by hyatt@apple.com
  • 2 edits in trunk/WebCore

2009-01-12 David Hyatt <​hyatt@apple.com>

Fix 0.6% regression in PLT. Make sure not to waste time updating NSScrollView's can blit on scroll state
in the ScrollView constructor, since this is always going to be properly updated by FrameView anyway.

Reviewed by Oliver Hunt

  • platform/ScrollView.cpp: (WebCore::ScrollView::ScrollView):
1:42 PM Changeset in webkit [39834] by Simon Fraser
  • 12 edits in trunk/WebCore

2009-01-12 Simon Fraser <Simon Fraser>

Reviewed by Dan Bernstein

​https://bugs.webkit.org/show_bug.cgi?id=23220

Merge layoutDelta into LayoutState. This requires that we
push even when layoutState is disabled, so that layoutDelta
can still be stored.

1:38 PM Changeset in webkit [39833] by andersca@apple.com
  • 5 edits in trunk/WebKit/mac

2009-01-12 Anders Carlsson <​andersca@apple.com>

Reviewed by Sam Weinig.

Move marshalling code to NetscapePluginInstanceProxy. Add support for marshalling JS objects.


  • Plugins/Hosted/NetscapePluginHostProxy.mm: (WKPCEvaluate):
  • Plugins/Hosted/NetscapePluginInstanceProxy.h:
  • Plugins/Hosted/NetscapePluginInstanceProxy.mm: (WebKit::NetscapePluginInstanceProxy::marshalValue):
  • Plugins/Hosted/WebKitPluginHostTypes.h:
1:31 PM Changeset in webkit [39832] by jchaffraix@webkit.org
  • 2 edits in trunk/WebCore

2009-01-12 Julien Chaffraix <​jchaffraix@pleyo.com>

Reviewed by Holger Freyther.

[Qt] Build fix after turning the fontCache to a singleton
​https://bugs.webkit.org/show_bug.cgi?id=23253

Add a stub implementation for WebCore::fontCache() and FontCache::FontCache().

  • platform/graphics/qt/FontCacheQt.cpp: (WebCore::fontCache): (WebCore::FontCache::FontCache):
1:07 PM Changeset in webkit [39831] by Dimitri Glazkov
  • 5 edits
    2 adds in trunk

2009-01-12 Eric Roman <​eroman@chromium.org>

Reviewed by Darin Adler.


Fix some bugs with Selection::appendTrailingWhitespace().
​https://bugs.webkit.org/show_bug.cgi?id=23232


Test: editing/selection/doubleclick-whitespace-crash.html


  • editing/Selection.cpp: (WebCore::makeSearchRange): (WebCore::Selection::appendTrailingWhitespace):

2009-01-12 Eric Roman <​eroman@chromium.org>

Reviewed by Darin Adler.
​https://bugs.webkit.org/show_bug.cgi?id=23232

  • editing/selection/doubleclick-whitespace-crash-expected.txt: Added.
  • editing/selection/doubleclick-whitespace-crash.html: Added.
  • editing/selection/doubleclick-whitespace-expected.txt:
  • editing/selection/doubleclick-whitespace.html:
12:26 PM Changeset in webkit [39830] by eric@webkit.org
  • 1 edit
    5 adds in trunk/WebCore

2009-01-12 Dimitri Glazkov <Dimitri Glazkov>

Reviewed by Eric Seidel.

Add the first pieces of platform/graphics/chromium
​https://bugs.webkit.org/show_bug.cgi?id=23257

  • platform/graphics/chromium/ColorChromium.cpp: Added. (WebCore::focusRingColor):
  • platform/graphics/chromium/FontCacheChromiumWin.cpp: Added. (WebCore::FontCache::platformInit): (WebCore::isStringASCII): (WebCore::LookupAltName): (WebCore::FontCodepage::): (WebCore::FontCodepage::if): (WebCore::createFontIndirectAndGetWinName): (WebCore::fontContainsCharacter): (WebCore::FontCache::getFontDataForCharacters): (WebCore::FontCache::alternateFamilyName): (WebCore::FontCache::getSimilarFontPlatformData): (WebCore::FontCache::getLastResortFallbackFont): (WebCore::toGDIFontWeight): (WebCore::FontCache::getGenericFontForScript): (WebCore::FillLogFont): (WebCore::FontCache::fontExists): (WebCore::TraitsInFamilyProcData::TraitsInFamilyProcData): (WebCore::traitsInFamilyEnumProc): (WebCore::FontCache::getTraitsInFamily): (WebCore::FontCache::createFontPlatformData):
  • platform/graphics/chromium/FontCacheLinux.cpp: Added. (WebCore::FontCache::platformInit): (WebCore::FontCache::getFontDataForCharacters): (WebCore::FontCache::alternateFamilyName): (WebCore::FontCache::getSimilarFontPlatformData): (WebCore::FontCache::getLastResortFallbackFont): (WebCore::FontCache::getTraitsInFamily): (WebCore::FontCache::createFontPlatformData): (WebCore::FontCache::getGenericFontForScript):
  • platform/graphics/chromium/FontChromiumWin.cpp: Added. (WebCore::windowsCanHandleTextDrawing): (WebCore::skiaDrawText): (WebCore::PaintSkiaText): (WebCore::Font::drawGlyphs): (WebCore::Font::selectionRectForComplexText): (WebCore::Font::drawComplexText): (WebCore::Font::floatWidthForComplexText): (WebCore::Font::offsetForPositionForComplexText):
11:25 AM Changeset in webkit [39829] by darin@chromium.org
  • 3 edits
    6 adds in trunk/WebCore

2009-01-12 Darin Fisher <​darin@chromium.org>

Reviewed by Eric Seidel.

​https://bugs.webkit.org/show_bug.cgi?id=23254
Upstream page/chromium/

  • page/chromium/AXObjectCacheChromium.cpp: Added. (WebCore::AXObjectCache::detachWrapper): (WebCore::AXObjectCache::attachWrapper): (WebCore::AXObjectCache::postNotification): (WebCore::AXObjectCache::postNotificationToElement): (WebCore::AXObjectCache::handleFocusedUIElementChanged):
  • page/chromium/AccessibilityObjectChromium.cpp:
  • page/chromium/AccessibilityObjectWrapper.h:
  • page/chromium/ChromeClientChromium.h: Added.
  • page/chromium/DragControllerChromium.cpp: Added. (WebCore::DragController::dragOperation): (WebCore::DragController::isCopyKeyDown): (WebCore::DragController::maxDragImageSize): (WebCore::DragController::cleanupAfterSystemDrag):
  • page/chromium/EventHandlerChromium.cpp: Added. (WebCore::EventHandler::passMousePressEventToSubframe): (WebCore::EventHandler::passMouseMoveEventToSubframe): (WebCore::EventHandler::passMouseReleaseEventToSubframe): (WebCore::EventHandler::passWheelEventToWidget): (WebCore::EventHandler::passWidgetMouseDownEventToWidget): (WebCore::EventHandler::passMouseDownEventToWidget): (WebCore::EventHandler::tabsToAllControls): (WebCore::EventHandler::eventActivatedView): (WebCore::EventHandler::createDraggingClipboard): (WebCore::EventHandler::focusDocumentView): (WebCore::EventHandler::accessKeyModifiers):
  • page/chromium/FrameChromium.cpp: Added. (WebCore::computePageRectsForFrame): (WebCore::Frame::dragImageForSelection):
  • page/chromium/FrameChromium.h: Added.
11:10 AM Changeset in webkit [39828] by Dimitri Glazkov
  • 4 edits in trunk/WebCore

2008-01-12 Dimitri Glazkov <Dimitri Glazkov>

Reviewed by Darin Adler.

​https://bugs.webkit.org/show_bug.cgi?id=22936
Fix uninitialized memory read error, reported by Purify.

  • platform/graphics/SimpleFontData.cpp: (WebCore::SimpleFontData::SimpleFontData): Added initializer for

m_unitsPerEm using cDefaultUnitsPerEm constant.

  • svg/SVGFontFaceElement.cpp: (WebCore::SVGFontFaceElement::unitsPerEm): Replaced literal value with

the constant.

  • svg/SVGFontFaceElement.h: Added cDefaultUnitsPerEm constant.
7:50 AM Changeset in webkit [39827] by treat@webkit.org
  • 2 edits in trunk/WebCore

Do not set fixedLayoutSize for anything other than the mainframe during
the transition as this is a page level state like the viewportSize.

5:03 AM Changeset in webkit [39826] by vestbo@webkit.org
  • 2 edits in trunk/WebKit/qt

2009-01-12 Tor Arne Vestbø <​tavestbo@trolltech.com>

Reviewed by Simon Hausmann.

[Qt] Ensure that we're always notified of navigation actions for local anchors

FrameLoader::checkNavigationPolicy() does not notify us if the request has
been checked before (which happens for local anchors), but in the case of
our clients not accepting the navigation request we do want to be notified
again later on, so we clear the lastCheckedRequest flag.

4:51 AM Changeset in webkit [39825] by vestbo@webkit.org
  • 2 edits in trunk/WebKit/qt

2009-01-12 Ariya Hidayat <​ariya.hidayat@trolltech.com>

Rubber-stamped by Tor Arne Vestbø.

Build fix: use qobject_cast which does not rely on RTTI. This fixes the
unit test when building it with a version of Qt (e.g. Qt/Embedded)
configured without RTTI.

  • tests/qwebframe/tst_qwebframe.cpp:
3:10 AM Changeset in webkit [39824] by ap@webkit.org
  • 2 edits in trunk/LayoutTests

Update test results.

  • fast/dom/Window/window-properties-expected.txt: Remove appcache dynamic entries methods.
2:46 AM Changeset in webkit [39823] by jchaffraix@webkit.org
  • 18 edits in trunk

WebCore:

2009-01-12 Julien Chaffraix <​jchaffraix@pleyo.com>

Reviewed by Darin Adler.

Bug 22861: Turn the FontCache into a singleton
​https://bugs.webkit.org/show_bug.cgi?id=22861

  • Added fontCache() to get the global FontCache.
  • Made all the methods in FontCache instance method.
  • Changed FontCache:: to fontCache()-> in WebCore.
  • WebCore.base.exp: Now export fontCache().
  • css/CSSFontFaceSource.cpp: (WebCore::CSSFontFaceSource::getFontData):
  • css/CSSFontSelector.cpp: (WebCore::CSSFontSelector::CSSFontSelector): (WebCore::CSSFontSelector::~CSSFontSelector): (WebCore::CSSFontSelector::addFontFaceRule): (WebCore::fontDataForGenericFamily):
  • platform/graphics/Font.cpp: (WebCore::Font::glyphDataForCharacter):
  • platform/graphics/FontCache.cpp: (WebCore::fontCache): (WebCore::FontCache::FontCache):
  • platform/graphics/FontCache.h:
  • platform/graphics/FontFallbackList.cpp: (WebCore::FontFallbackList::FontFallbackList): (WebCore::FontFallbackList::invalidate): (WebCore::FontFallbackList::releaseFontData): (WebCore::FontFallbackList::fontDataAt): (WebCore::FontFallbackList::fontDataForCharacters): (WebCore::FontFallbackList::setPlatformFont):
  • platform/graphics/SimpleFontData.cpp: (WebCore::SimpleFontData::~SimpleFontData):
  • platform/graphics/mac/FontCacheMac.mm: (WebCore::fontCacheATSNotificationCallback):
  • platform/graphics/mac/SimpleFontDataMac.mm: (WebCore::SimpleFontData::smallCapsFontData):
  • platform/graphics/win/FontCacheWin.cpp: (WebCore::getCJKCodePageMasks):
  • platform/graphics/win/SimpleFontDataWin.cpp: (WebCore::SimpleFontData::containsCharacters):

WebKit/mac:

2009-01-12 Julien Chaffraix <​jchaffraix@pleyo.com>

Reviewed by Darin Adler.

Bug 22861: Turn the FontCache into a singleton
​https://bugs.webkit.org/show_bug.cgi?id=22861

  • Misc/WebCoreStatistics.mm: (+[WebCoreStatistics cachedFontDataCount]): (+[WebCoreStatistics cachedFontDataInactiveCount]): (+[WebCoreStatistics purgeInactiveFontData]): Redirected all the static calls to the global FontCache instance.

WebKit/win:

2009-01-12 Julien Chaffraix <​jchaffraix@pleyo.com>

Reviewed by Darin Adler.

Bug 22861: Turn the FontCache into a singleton
​https://bugs.webkit.org/show_bug.cgi?id=22861

  • WebCoreStatistics.cpp: (WebCoreStatistics::cachedFontDataCount): (WebCoreStatistics::cachedFontDataInactiveCount): (WebCoreStatistics::purgeInactiveFontData): Redirected all the static calls to the global FontCache instance.
1:58 AM QtWebKitJournal edited by Simon Hausmann
(diff)
1:41 AM Changeset in webkit [39822] by Simon Hausmann
  • 2 edits in trunk/WebKit/qt

2009-01-12 Simon Hausmann <​simon.hausmann@nokia.com>

Rubber-stamped by Tor Arne Vestbø.

When the QWebView is disabled context menus implemented in JavaScript should not pop up.

Just like in QWidget::event() we have to check for the disabled state and
ignore context menu events.

1:36 AM Changeset in webkit [39821] by Simon Hausmann
  • 2 edits in trunk/WebKit/qt

2009-01-12 Simon Hausmann <​simon.hausmann@nokia.com

Reviewed by Tor Arne Vestbø.

Fix QWebView appearance when showed uninitialized without page.

Only set WA_OpaquePaintEvent if we have a page set that will actually
paint the entire contents, otherwise the optimization does not apply
as we do not have a paintEvent() implementation and Qt has to fill the
view with its default background instead.

1:12 AM Changeset in webkit [39820] by vestbo@webkit.org
  • 2 edits in trunk/WebKit/qt

2009-01-11 Ariya Hidayat <​ariya.hidayat@trolltech.com>

Rubber-stamped by Tor Arne Vestbø.

Do not create a QVariant from QObject* directly, use the
template-specialized function.

  • tests/qwebframe/tst_qwebframe.cpp: (MyQObject::myOverloadedSlot):

Jan 11, 2009:

11:48 PM Changeset in webkit [39819] by Darin Adler
  • 10 edits
    3 copies
    4 adds in trunk

WebCore:

2009-01-11 Darin Adler <Darin Adler>

Reviewed by Dan Bernstein.

Bug 23247: createSVGPathSegCurvetoCubicSmoothAbs doesn't set y2 correctly
​https://bugs.webkit.org/show_bug.cgi?id=23247

Also fix problems where partially parsed paths will still have an effect
rather than failing parsing and being ignored.

Test: dom/path-segments.html

  • platform/graphics/Path.h: (WebCore::Path::swap): Added.
  • svg/SVGParserUtilities.cpp: (WebCore::SVGPathParser::parseSVG): Removed unneeded special case for empty string. (WebCore::PathBuilder::build): Changed to not modify the path if parsing fails. (WebCore::SVGPathSegListBuilder::build): Changed to not modify the segment list if parsing fails. (WebCore::SVGPathSegListBuilder::svgMoveTo): Put the path element into the vector, not directly into the segment list. (WebCore::SVGPathSegListBuilder::svgLineTo): Ditto. (WebCore::SVGPathSegListBuilder::svgLineToHorizontal): Ditto. (WebCore::SVGPathSegListBuilder::svgLineToVertical): Ditto. (WebCore::SVGPathSegListBuilder::svgCurveToCubic): Ditto. (WebCore::SVGPathSegListBuilder::svgCurveToCubicSmooth): Ditto. (WebCore::SVGPathSegListBuilder::svgCurveToQuadratic): Ditto. (WebCore::SVGPathSegListBuilder::svgCurveToQuadraticSmooth): Ditto. (WebCore::SVGPathSegListBuilder::svgArcTo): Ditto. (WebCore::SVGPathSegListBuilder::svgClosePath): Ditto.
  • svg/SVGPathSegCurvetoCubicSmooth.h: (WebCore::SVGPathSegCurvetoCubicSmooth::SVGPathSegCurvetoCubicSmooth): Set y2 to y2, not to y.

WebKitTools:

2009-01-11 Darin Adler <Darin Adler>

  • Scripts/make-js-test-wrappers: Updated so it won't overwrite tests in the svg/dom directory that aren't using standard wrappers.

LayoutTests:

2009-01-11 Darin Adler <Darin Adler>

Reviewed by Dan Bernstein.

Bug 23247: createSVGPathSegCurvetoCubicSmoothAbs doesn't set y2 correctly
​https://bugs.webkit.org/show_bug.cgi?id=23247

Also fix problems where partially parsed paths will still have an effect
rather than failing parsing and being ignored.

Renamed the path-parser.html test to fuzz-path-parser.html, since it's a fuzz test,
to make room for a non-fuzz test of the path parser.

  • platform/mac/svg/custom/path-bad-data-expected.txt: Updated results, since the old ones were based on incorrect path parsing behavior.
  • svg/dom/fuzz-path-parser-expected.txt: Copied from svg/dom/path-parser-expected.txt. Also updated because the parser no longer tolerates extra characters at the end of the string, which it was doing by accident.
  • svg/dom/fuzz-path-parser.html: Copied from svg/dom/path-parser.html.
  • svg/dom/path-parser-expected.txt: Replaced fuzz test results with new test results.
  • svg/dom/path-parser.html: Replaced fuzz test with a new test.
  • svg/dom/path-segments-expected.txt: Added.
  • svg/dom/path-segments.html: Added.
  • svg/dom/resources/TEMPLATE.html: Copied from fast/js/resources/TEMPLATE.html.
  • svg/dom/resources/path-parser.js: Added. Mostly, this test shows that we are processing the path while parsing it, which is a bug. This test would be much more useful if that was fixed. But it also shows that we were incorrectly tolerating extra characters after the path, which is now fixed.
  • svg/dom/resources/path-segments.js: Added.
11:44 PM Changeset in webkit [39818] by Darin Adler
  • 41 edits in trunk/WebCore

2009-01-11 Darin Adler <Darin Adler>

Reviewed by Oliver Hunt.

Bug 23102: turn on unused parameter warnings in WebCore
​https://bugs.webkit.org/show_bug.cgi?id=23102

Fourth step: Remove arguments entirely in the many cases where they are not
needed at all. This step is a little less mechanical than the earlier ones.

  • dom/DOMImplementation.cpp: (WebCore::DOMImplementation::isXMLMIMEType): Pass TextCaseSensitive when creating the regular expression, since we already specify a-zA-Z in our expression.
  • dom/Document.cpp: (WebCore::Document::databaseThread): Don't pass in the document when creating a DatabaseThread.
  • dom/Element.cpp: (WebCore::Element::createRareData): Don't pass the element when creating an ElementRareData. (WebCore::Element::detach): Don't pass the element when calling resetComputedStyle. (WebCore::Element::recalcStyle): Ditto.
  • dom/ElementRareData.h: Remove the unused Element* from the constructor and the resetComputedStyle function.
  • dom/EventTargetNode.cpp: (WebCore::EventTargetNode::dispatchEvent): Don't pass ec to dispatchGenericEvent. (WebCore::EventTargetNode::dispatchGenericEvent): Remove the unused ec argument. (WebCore::EventTargetNode::dispatchWindowEvent): Don't pass ec to dispatchGenericEvent.
  • dom/EventTargetNode.h: Remove the ExceptionCode& argument form disaptchGenericEvent.
  • editing/ApplyStyleCommand.cpp: Remove the empty removeBlockStyle function. (WebCore::ApplyStyleCommand::pushDownTextDecorationStyleAroundNode): Remove the unused start and end arguments. (WebCore::ApplyStyleCommand::pushDownTextDecorationStyleAtBoundaries): Don't pass start and end to pushDownTextDecorationStyleAroundNode.
  • editing/ApplyStyleCommand.h: Remove the empty removeBlockStyle function. Removed the unused start and end arguments from pushDownTextDecorationStyleAroundNode.
  • editing/htmlediting.cpp: Removed include of unused RegularExpression.h header.
  • html/HTMLTokenizer.cpp: (WebCore::Token::addAttribute): Removed unused Document* argument. (WebCore::HTMLTokenizer::parseTag): Don't pass document to addAttribute.
  • html/HTMLTokenizer.h: Removed unused Document* argument to to addAttribute.
  • page/DOMWindow.cpp: (WebCore::DOMWindow::localStorage): Don't pass the frame to storageArea.
  • page/DragController.cpp: (WebCore::DragController::dragIsMove): Removed unused DragData argument. (WebCore::DragController::performDrag): Call concludeEditDrag rather than concludeDrag. (WebCore::DragController::tryDocumentDrag): Don't pass dragData to dragIsMove. (WebCore::DragController::concludeEditDrag): Renamed to make it clear this should only be called for edit drags. Removed the action mask argument. Also changed dragIsMove call sites to not pass dragData.
  • page/DragController.h: Updated for above changes and tweaked comment format.
  • page/Frame.cpp: (WebCore::createRegExpForLabels): Pass TextCaseSensitive and TextCaseInsensitive when creating regular expressions for clarity. Call match instead of search, since both do the same thing except for with negative start offsets, and none used here are negative. (WebCore::Frame::matchLabelsAgainstElement): Ditto.
  • page/Page.h: Moved TextCaseSensitivity from here to StringImpl.h in platform.
  • page/mac/AccessibilityObjectWrapper.mm: (AXAttributeStringSetHeadingLevel): Removed unused object argument. (AXAttributedStringAppendText): Ditto. (-[AccessibilityObjectWrapper doAXAttributedStringForTextMarkerRange:]): Ditto.
  • page/mac/FrameMac.mm: (WebCore::regExpForLabels): Pass TextCaseSensitive and TextCaseInsensitive when creating regular expressions for clarity. Call match instead of search, since both do the same thing except for with negative start offsets, and none used here are negative. (WebCore::Frame::matchLabelsAgainstElement): Ditto.
  • platform/graphics/SegmentedFontData.cpp: (WebCore::SegmentedFontData::containsCharacter): Added. (WebCore::SegmentedFontData::containsCharacters): Updated to check all characters instead of just the first one, using containsCharacter.
  • platform/graphics/SegmentedFontData.h: Made more members private. Added containsCharacter function member.
  • platform/mac/DragImageMac.mm: (WebCore::dragImageSize): Changed to use RetainPtr<NSImage> directly instead of DragImageRef for clarity, since this is platform-specific code. (WebCore::deleteDragImage): Ditto. Also remove argument name to get rid of unused variable warning. (WebCore::scaleDragImage): Ditto. (WebCore::dissolveDragImageToFraction): Ditto. (WebCore::createDragImageFromImage): Ditto. (WebCore::createDragImageIconForCachedImage): Ditto.
  • platform/mac/WebFontCache.mm: (acceptableChoice): Removed the unused weight-related arguments. (betterChoice): Ditto. (+[WebFontCache internalFontWithFamily:traits:weight:size:]): Ditto.
  • platform/posix/FileSystemPOSIX.cpp: Removed the implementation of listDirectory because we'd rather get a link error rather than a runtime error if we use it for anything, and right now it's not used.
  • platform/text/RegularExpression.cpp: Removed unused private data, including pattern, lastMatchString, lastMatchOffsets, lastMatchCount, and lastMatchPos. Made the RegularExpression::Private::regex be private and use an accessor function to get at it. (WebCore::RegularExpression::RegularExpression): Removed the const char* version of the constructor because it's not any more efficient. Changed the boolean constructor argument to use TextCaseSensitivity instead to make it less likely we'll use it wrong. (WebCore::RegularExpression::operator=): Since the only member is a single RefPtr, just use plain old assignment on it. The only reason we do this instead of using the compiler generated assignment operator is that we want the Private structure to be internal to the .cpp file. (WebCore::RegularExpression::match): Added a null check so we won't crash if we fail to compile the regular expression. Removed the code to handle multiple match strings, since that was unused.
  • platform/text/RegularExpression.h: Changed the case sensitivity argument to use TextCaseSensitivity and not have a default value. Removed the default constructor, and the pattern, match, and pos functions.
  • platform/text/StringImpl.h: Moved the TextCaseSensitivity enum here from Page.h, because we should eventually use it in all the places where we have an argument to control case sensitivity, starting with the functions in this class.
  • platform/text/mac/ShapeArabic.c: (shapeUnicode): Removed the unused options and pErrorCode arguments. Even though this is code borrowed from ICU, this seems like a simple safe change to make. (shapeArabic): Don't pass options or pErrorCode in to shapeUnicode.
  • rendering/RenderPath.cpp: (WebCore::RenderPath::RenderPath): Removed the unused style argument. Also removed the type check. The argument already has the correct type, so it's not helpful to upcast it and then check its type again, unless we have some reason to believe the type is not reliable. And we don't.
  • rendering/RenderPath.h: Removed the RenderStyle* argument to the constructor. Also removed the explicit declaration of the destructor. It's not helpful or needed.
  • rendering/RenderSVGInlineText.cpp: (WebCore::RenderSVGInlineText::localCaretRect): Updated the comment here to make it clear that just returning an empty rect is not a good implementation. Removed the argument names to get rid of the warning.
  • rendering/RenderTreeAsText.cpp: (WebCore::printBorderStyle): Removed the unused RenderObject argument. (WebCore::operator<<): Updated for the change to printBorderStyle function.
  • storage/DatabaseThread.cpp: (WebCore::DatabaseThread::DatabaseThread): Removed the unused document argument.
  • storage/DatabaseThread.h: Ditto.
  • storage/LocalStorage.cpp: (WebCore::LocalStorage::storageArea): Removed the unused Frame* argument.
  • storage/LocalStorage.h: Ditto.
  • svg/SVGElement.cpp: (WebCore::SVGElement::sendSVGLoadEventIfPossible): Don't pass an exception code location to dispatchGenericEvent.
  • svg/SVGElementInstance.cpp: (WebCore::SVGElementInstance::dispatchEvent): Ditto.
  • svg/SVGStyledTransformableElement.cpp: Removed include of unused RegularExpression.h. (WebCore::SVGStyledTransformableElement::createRenderer): Don't pass style in to the RenderPath constructor.
  • svg/SVGTransformable.cpp: Removed include of unused RegularExpression.h.
  • xml/XSLTProcessor.cpp: (WebCore::createFragmentFromSource): Removed unused sourceNode argument. (WebCore::XSLTProcessor::transformToFragment): Don't pass sourceNode to createFragmentFromSource.
11:34 PM Changeset in webkit [39817] by ap@webkit.org
  • 5 edits in trunk/JavaScriptCore

2009-01-11 David Levin <​levin@chromium.org>

Reviewed by Darin Adler.

​https://bugs.webkit.org/show_bug.cgi?id=23245

Add initializeThreading to key places in JS API to ensure that
UString is properly initialized.

  • API/JSContextRef.cpp: (JSContextGroupCreate): (JSGlobalContextCreate):
  • API/JSObjectRef.cpp: (JSClassCreate):
  • API/JSStringRef.cpp: (JSStringCreateWithCharacters): (JSStringCreateWithUTF8CString):
  • API/JSStringRefCF.cpp: (JSStringCreateWithCFString):
11:21 PM Changeset in webkit [39816] by ap@webkit.org
  • 4 edits
    1 move in trunk

Reviewed by Darin Adler.

​https://bugs.webkit.org/show_bug.cgi?id=23165
Disable application cache dynamic entries support.

7:19 PM Changeset in webkit [39815] by Darin Adler
  • 5 edits in trunk/JavaScriptCore

2009-01-11 David Levin <​levin@chromium.org>

Reviewed by Darin Adler.

​https://bugs.webkit.org/show_bug.cgi?id=23175

Separate out BaseString information from UString::Rep and make all baseString access go through
a member function, so that it may be used for something else (in the future) in the BaseString
case.

  • runtime/SmallStrings.cpp: (JSC::SmallStringsStorage::rep): (JSC::SmallStringsStorage::SmallStringsStorage): (JSC::SmallStrings::SmallStrings): (JSC::SmallStrings::mark): Adjust to account for the changes in UString and put the UString in place in SmallStringsStorage to aid in locality of reference among the UChar[] and UString::Rep's.
  • runtime/SmallStrings.h:
  • runtime/UString.cpp: (JSC::initializeStaticBaseString): (JSC::initializeUString): (JSC::UString::Rep::create): (JSC::UString::Rep::destroy): (JSC::UString::Rep::checkConsistency): (JSC::expandCapacity): (JSC::UString::expandPreCapacity): (JSC::concatenate): (JSC::UString::append): (JSC::UString::operator=):
  • runtime/UString.h: (JSC::UString::Rep::baseIsSelf): (JSC::UString::Rep::setBaseString): (JSC::UString::Rep::baseString): (JSC::UString::Rep::): (JSC::UString::Rep::null): (JSC::UString::Rep::empty): (JSC::UString::Rep::data): (JSC::UString::cost): Separate out the items out used by base strings from those used in Rep's that only point to base strings. (This potentially saves 24 bytes per Rep.)
7:17 PM Changeset in webkit [39814] by Darin Adler
  • 2 edits in trunk/LayoutTests

2009-01-11 Darin Adler <Darin Adler>

  • fast/frames/frame-deep-nested-resize-expected.txt: This time for sure.
6:07 PM Changeset in webkit [39813] by Darin Adler
  • 2 edits in trunk/LayoutTests

2009-01-11 Darin Adler <Darin Adler>

Fix failure of new test seen on buildbots.

  • fast/frames/frame-deep-nested-resize-expected.txt: Updated newlines to match what DumpRenderTree generates on Mac. I believe Adam generated his results under Qt DumpRenderTree. If so, then the Qt version will need to change to match the Mac version, since all the expected results were generated on Mac.
4:54 PM Changeset in webkit [39812] by treat@webkit.org
  • 3 edits
    2 adds in trunk

Correct coordinate transformation for deeply nested frames on resizing. This
fixes ​https://bugs.webkit.org/show_bug.cgi?id=20766.

3:55 PM Changeset in webkit [39811] by mrowe@apple.com
  • 2 edits in trunk/WebCore

Tiger build fix. The connection parameter is still used on Tiger in this method.

  • platform/network/mac/ResourceHandleMac.mm:

(-[WebCoreResourceHandleAsDelegate connection:willCacheResponse:]):

2:01 PM Changeset in webkit [39810] by Darin Adler
  • 14 edits in trunk/WebCore

2009-01-11 Darin Adler <Darin Adler>

Reviewed by Dan Bernstein.

Bug 23102: turn on unused parameter warnings in WebCore
​https://bugs.webkit.org/show_bug.cgi?id=23102

Third step: Deal with cases of arguments used only in assertions.

  • dom/MessagePort.cpp: (WebCore::MessagePortCloseEventTask::performTask): Use ASSERT_UNUSED.
  • dom/Worker.cpp: (WebCore::Worker::notifyFinished): Ditto.
  • dom/XMLTokenizer.cpp: (WebCore::XMLTokenizer::notifyFinished): Ditto.
  • loader/appcache/ApplicationCacheGroup.cpp: (WebCore::ApplicationCacheGroup::failedLoadingMainResource): Ditto.
  • loader/appcache/ApplicationCacheStorage.cpp: (WebCore::ApplicationCacheStorage::verifySchemaVersion): Ditto.
  • loader/icon/IconLoader.cpp: (WebCore::IconLoader::didReceiveData): Since loader and size are only used when logging, use UNUSED_PARAM when logging is disabled.
  • platform/mac/WidgetMac.mm: (WebCore::Widget::beforeMouseDown): Use ASSERT_UNUSED.
  • platform/network/mac/ResourceHandleMac.mm: (WebCore::ResourceHandle::didCancelAuthenticationChallenge): Use the argument since it's probably a tiny bit more efficient and gets rid of the unused argument warning.
  • rendering/RenderListMarker.cpp: (WebCore::RenderListMarker::createInlineBox): Use ASSERT_UNUSED.
  • rendering/RenderObject.cpp: (WebCore::RenderObject::createInlineBox): Ditto.
  • rendering/RenderSVGInline.cpp: (WebCore::RenderSVGInline::createInlineBox): Use UNUSED_PARAM. I couldn't use ASSERT_UNUSED because it's a single assertion, but it's the only use for two different arguments.
  • rendering/RenderText.cpp: (WebCore::RenderText::createInlineBox): Use ASSERT_UNUSED.
  • rendering/RenderThemeMac.mm: (-[WebCoreRenderThemeNotificationObserver systemColorsDidChange:]): Ditto.
1:58 PM Changeset in webkit [39809] by Darin Adler
  • 5 edits in trunk/JavaScriptCore

2009-01-11 Darin Adler <Darin Adler>

Reviewed by Dan Bernstein.

Bug 23239: improve handling of unused arguments in JavaScriptCore
​https://bugs.webkit.org/show_bug.cgi?id=23239

  • runtime/DatePrototype.cpp: Moved LocaleDateTimeFormat enum outside #if so we can use this on all platforms. Changed valueOf to share the same function with getTime, since the contents of the two are identical. Removed a FIXME since the idea isn't really specific enough or helpful enough to need to sit here in the source code. (JSC::formatLocaleDate): Changed the Mac version of this function to take the same arguments as the non-Mac version so the caller doesn't have to special-case the two platforms. Also made the formatString array be const; before the characters were, but the array was a modifiable global variable. (JSC::dateProtoFuncToLocaleString): Changed to call the new unified version of formatLocaleDate and remove the ifdef. (JSC::dateProtoFuncToLocaleDateString): Ditto. (JSC::dateProtoFuncToLocaleTimeString): Ditto.
  • runtime/JSNotAnObject.cpp: (JSC::JSNotAnObject::toObject): Use the new ASSERT_UNUSED instead of the old UNUSED_PARAM.
  • runtime/RegExp.cpp: (JSC::RegExp::RegExp): Changed to only use UNUSED_PARAM when the parameter is actually unused.
  • wtf/TCSystemAlloc.cpp: (TCMalloc_SystemRelease): Changed to only use UNUSED_PARAM when the parameter is actually unused. (TCMalloc_SystemCommit): Changed to omit the argument names instead of using UNUSED_PARAM.
1:42 PM Changeset in webkit [39808] by mitz@apple.com
  • 4 edits in trunk/LayoutTests/platform/mac

Set the svn:mime-type property of recently-added PNG files to image/png.

1:22 PM Changeset in webkit [39807] by Simon Fraser
  • 5 edits
    4 adds in trunk

2009-01-11 Simon Fraser <Simon Fraser>

Reviewed by Oliver Hunt

​https://bugs.webkit.org/show_bug.cgi?id=23242

Fix CanvasRenderingContext2D::transform to do a pre-multiply,
rather than a post-multiply into m_transform. This bug did not affect
drawing, but did cause m_transform to be incorrect, which impacted
willDraw(), and isPointInPath.

Test: fast/canvas/canvas-incremental-repaint-2.html

  • html/CanvasRenderingContext2D.cpp: (WebCore::CanvasRenderingContext2D::transform):
12:05 PM Changeset in webkit [39806] by Darin Adler
  • 9 edits in trunk/WebCore

2009-01-11 Darin Adler <Darin Adler>

Reviewed by Dan Bernstein.

Bug 23102: turn on unused parameter warnings in WebCore
​https://bugs.webkit.org/show_bug.cgi?id=23102

Second step: Fix simple Objective-C cases where we need to use UNUSED_PARAM.
That's because you can't omit an argument name in Objective-C methods.

  • bindings/objc/DOMObject.mm: (-[DOMObject copyWithZone:]): Use UNUSED_PARAM. Also rename argument to include the word "unused" so we don't just start using it without removing the macro.
  • bindings/objc/WebScriptObject.mm: (+[WebUndefined allocWithZone:]): Ditto. (-[WebUndefined initWithCoder:]): Ditto. (-[WebUndefined encodeWithCoder:]): Ditto. (-[WebUndefined copyWithZone:]): Ditto.
  • page/mac/WebDashboardRegion.m: (-[WebDashboardRegion copyWithZone:]): Ditto.
  • platform/graphics/mac/MediaPlayerPrivateQTKit.mm: (WebCore::mainThreadSetNeedsDisplay): Omit argument name. (-[WebCoreMovieObserver loadStateChanged:]): Use UNUSED_PARAM as above. (-[WebCoreMovieObserver rateChanged:]): Ditto. (-[WebCoreMovieObserver sizeChanged:]): Ditto. (-[WebCoreMovieObserver timeChanged:]): Ditto. (-[WebCoreMovieObserver didEnd:]): Ditto. (-[WebCoreMovieObserver newImageAvailable:]): Ditto.
  • platform/mac/ScrollbarThemeMac.mm: (+[ScrollbarPrefsObserver appearancePrefsChanged:]): Ditto. (+[ScrollbarPrefsObserver behaviorPrefsChanged:]): Ditto.
  • platform/mac/SharedTimerMac.mm: (-[WebCorePowerNotifier didWake:]): Ditto.
  • platform/mac/WebCoreKeyGenerator.m: (-[WebCoreKeyGenerator signedPublicKeyAndChallengeStringWithStrengthIndex:challenge:pageURL:]): Ditto.
  • platform/network/mac/ResourceHandleMac.mm: (-[WebCoreResourceHandleAsDelegate connection:willSendRequest:redirectResponse:]): Ditto. (-[WebCoreResourceHandleAsDelegate connectionShouldUseCredentialStorage:]): Ditto. (-[WebCoreResourceHandleAsDelegate connection:didReceiveAuthenticationChallenge:]): Ditto. (-[WebCoreResourceHandleAsDelegate connection:didCancelAuthenticationChallenge:]): Ditto. (-[WebCoreResourceHandleAsDelegate connection:didReceiveResponse:]): Ditto. (-[WebCoreResourceHandleAsDelegate connection:didReceiveData:lengthReceived:]): Ditto. (-[WebCoreResourceHandleAsDelegate connection:willStopBufferingData:]): Ditto. (-[WebCoreResourceHandleAsDelegate connection:didSendBodyData:totalBytesWritten:totalBytesExpectedToWrite:]): Ditto. (-[WebCoreResourceHandleAsDelegate connectionDidFinishLoading:]): Ditto. (-[WebCoreResourceHandleAsDelegate connection:didFailWithError:]): Ditto. (-[WebCoreResourceHandleAsDelegate connection:willCacheResponse:]): Ditto. (-[WebCoreSynchronousLoader connection:willSendRequest:redirectResponse:]): Ditto. (-[WebCoreSynchronousLoader connection:didReceiveAuthenticationChallenge:]): Ditto. (-[WebCoreSynchronousLoader connection:didReceiveResponse:]): Ditto. (-[WebCoreSynchronousLoader connection:didReceiveData:]): Ditto. (-[WebCoreSynchronousLoader connectionDidFinishLoading:]): Ditto. (-[WebCoreSynchronousLoader connection:didFailWithError:]): Ditto.
11:59 AM Changeset in webkit [39805] by krit@webkit.org
  • 12 edits
    5 deletes in trunk/WebCore

2009-01-11 Dirk Schulze <​krit@webkit.org>

Reviewed by Darin Adler.

Move platform dependent strokeContains back to RenderPath, Path and delete
unneeded Code in svg.

RenderPath clean-up for strokeContains
​https://bugs.webkit.org/show_bug.cgi?id=22957

  • GNUmakefile.am:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • platform/graphics/Path.h:
  • platform/graphics/cairo/PathCairo.cpp: (WebCore::Path::strokeContains):
  • platform/graphics/cg/PathCG.cpp: (WebCore::Path::strokeContains):
  • platform/graphics/qt/PathQt.cpp: (WebCore::Path::strokeContains):
  • rendering/RenderPath.cpp: (WebCore::RenderPath::strokeContains):
  • svg/graphics/cairo/RenderPathCairo.cpp: Removed.
  • svg/graphics/cg/CgSupport.cpp: Removed.
  • svg/graphics/cg/CgSupport.h: Removed.
  • svg/graphics/cg/RenderPathCg.cpp: Removed.
  • svg/graphics/cg/SVGPaintServerPatternCg.cpp:
  • svg/graphics/cg/SVGResourceMaskerCg.mm:
  • svg/graphics/qt/RenderPathQt.cpp: Removed.
11:59 AM Changeset in webkit [39804] by zecke@webkit.org
  • 2 edits in trunk

2009-01-11 Xan Lopez <​xan@gnome.org>

Reviewed by Holger Freyther.

Bump version to 1.1.0 since we are breaking ABI and adding new
major features.

  • configure.ac:
11:57 AM Changeset in webkit [39803] by zecke@webkit.org
  • 2 edits in trunk/WebKit/gtk

2009-01-11 Xan Lopez <​xan@gnome.org>

Reviewed by Holger Freyther.

Use NULL instead of 0 when dealing with pointers, as agreed for
the coding style of the WebKit GTK port for its GTK+ specific
files.

  • webkit/webkitwebview.cpp:
11:55 AM Changeset in webkit [39802] by zecke@webkit.org
  • 7 edits in trunk/WebKit/gtk

2009-01-11 Xan Lopez <​xan@gnome.org>

Reviewed by Holger Freyther.

Add padding to the class structs to avoid breaking ABI each time
we add stuff there.

  • webkit/webkitnetworkrequest.h:
  • webkit/webkitwebbackforwardlist.h:
  • webkit/webkitwebhistoryitem.h:
  • webkit/webkitwebnavigationaction.h:
  • webkit/webkitwebpolicydecision.h:
  • webkit/webkitwebview.h:
11:47 AM Changeset in webkit [39801] by zecke@webkit.org
  • 2 edits in trunk/WebCore

[GTK] make distcheck complains that distclean is not deleting JSWorkerContextBase.lut.h

make distcheck pass by adding JSWorkerContextBase.lut.h to the
CLEANFILES that will be cleaned on a make distclean.

11:47 AM Changeset in webkit [39800] by oliver@apple.com
  • 2 edits in trunk/JavaScriptCore

build fix

11:12 AM Changeset in webkit [39799] by oliver@apple.com
  • 2 edits in trunk/JavaScriptCore

Bug 23128: get/put_by_val need to respecialise in the face of ByteArray

Reviewed by Darin Adler and Anders Carlsson

Restructure the code slightly, and add comments per Darin's suggestions

10:56 AM Changeset in webkit [39798] by oliver@apple.com
  • 2 edits in trunk/JavaScriptCore

Fix exception check for string indexing

Reviewed by Anders Carlsson.

Whoops, I accidentally removed an exception check from fast the
fast path for string indexing when i originally landed the
byte array logic.

8:54 AM Changeset in webkit [39797] by oliver@apple.com
  • 1 edit in trunk/WebKit/win/WebDownloadCFNet.cpp

attempt to fix win build

8:48 AM Changeset in webkit [39796] by oliver@apple.com
  • 3 edits in trunk/JavaScriptCore

Bug 23128: get/put_by_val need to respecialise in the face of ByteArray
<​https://bugs.webkit.org/show_bug.cgi?id=23128>

Reviewed by Anders Carlsson.

Fairly simple patch, add specialised versions of cti_op_get/put_by_val
that assume ByteArray, thus avoiding a few branches in the case of bytearray
manipulation.

No effect on SunSpider. 15% win on the original testcase.

3:06 AM Changeset in webkit [39795] by ap@webkit.org
  • 3 edits in trunk/WebCore

2009-01-11 Zalan Bujtas <​zbujtas@gmail.com>

Reviewed by Alexey Proskuryakov.

​https://bugs.webkit.org/show_bug.cgi?id=23235
Build fix for non-VIDEO builds.

  • rendering/RenderTheme.cpp:
  • rendering/RenderTheme.h:
3:03 AM Changeset in webkit [39794] by ap@webkit.org
  • 2 edits in trunk/JavaScriptCore

Try to fix Windows build.

  • wtf/CurrentTime.cpp: Added a definition of msPerSecond (previously, this code was in DateMath.cpp, with constant definition in DateTime.h)
2:36 AM Changeset in webkit [39793] by ap@webkit.org
  • 2 edits in trunk/JavaScriptCore

2009-01-11 Alexey Proskuryakov <​ap@webkit.org>

Try to fix Windows build.

  • wtf/CurrentTime.cpp: Include <sys/types.h> and <sys/timeb.h>, as MSDN says to.
2:27 AM Changeset in webkit [39792] by ap@webkit.org
  • 2 edits in trunk/WebCore

2009-01-11 Gabriella Toth <​gtoth@inf.u-szeged.hu>

Reviewed by Darin Adler.

​https://bugs.webkit.org/show_bug.cgi?id=19287
return value of malloc() is not checked in npruntime.cpp

Checking whether malloc can allocate memory or not. If it can't, CRASH macro is invoked
(like in fastMalloc).


  • bridge/npruntime.cpp: (_NPN_GetStringIdentifier): (_NPN_GetIntIdentifier): (NPN_InitializeVariantWithStringCopy): (_NPN_CreateObject):
2:24 AM Changeset in webkit [39791] by ap@webkit.org
  • 7 edits in trunk

2009-01-11 Glenn Wilson <​gwilson@google.com>

Reviewed by Darin Adler.

Changes radio buttons so they can be 'checked' even if they
don't have the name attribute set.

See ​https://bugs.webkit.org/show_bug.cgi?id=21534

Test: fast/html/select-unnamed-radio.html

  • html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::preDispatchEventHandler):
1:48 AM Changeset in webkit [39790] by ap@webkit.org
  • 3 edits in trunk/LayoutTests

2009-01-11 tony chang <​tony@chromium.org>

Reviewed by Darin Adler.

Remove svn:eol-style native from some utf16 files so
windows-svn doesn't alter them on checkout.

  • fast/xsl/xslt-enc16.xml: remove svn:eol-style
  • fast/xsl/xslt-enc16to16.xml: remove svn:eol-style
1:44 AM Changeset in webkit [39789] by ap@webkit.org
  • 1 edit in trunk/WebCore/ChangeLog

Fix ChangeLog date.

1:43 AM Changeset in webkit [39788] by ap@webkit.org
  • 2 edits in trunk/WebKitTools

2009-01-11 Robert Blaut <​webkit@blaut.biz>

Reviewed by Eric Seidel.


<​https://bugs.webkit.org/show_bug.cgi?id=23134>
Update bisect-builds for Safari 3.2 to prevent crashes

  • Scripts/bisect-builds: Added Safari 3.2 and the corresponding minimal revision, r37348.
1:40 AM Changeset in webkit [39787] by ap@webkit.org
  • 3 edits
    4 adds in trunk/LayoutTests

2009-01-11 Jungshik Shin <​jshin@chromium.org>

Reviewed by Alexey Proskuryakov

  • Make fast/encoding/char-encoding test work with Chromium by replacing 'data:' with 'file:' pointing to resources/dummy.html (an empty file).
  • Put old Mac encodings in a separate char-encoding-mac.html to make it possible to to skip it.
  • Factor out common functions in char-encoding.html and char-encoding-mac.html and put them in char-encoding-utils.js

See: ​https://bugs.webkit.org/show_bug.cgi?id=22882

  • fast/encoding/char-encoding-mac-expected.txt: Added.
  • fast/encoding/char-encoding-mac.html: Added.
  • fast/encoding/char-encoding.html:
  • fast/encoding/resources/char-encoding-utils.js: Added.
  • fast/encoding/resources/dummy.html: Added.
1:36 AM Changeset in webkit [39786] by ap@webkit.org
  • 2 edits in trunk/WebCore

2008-12-18 Bernhard Rosenkraenzer <​bero@arklinux.ch>

Reviewed by Darin Adler.

​https://bugs.webkit.org/show_bug.cgi?id=22205
Fix compatibility with bison 2.4, partially based on older patch by
Priit Laes <​amd@store20.com>

  • WebCore/css/CSSGrammar.y: Made compatible with bison 2.4
1:18 AM Changeset in webkit [39785] by ap@webkit.org
  • 3 edits
    3 adds in trunk

2009-01-11 Jeremy Moskovich <​jeremy@chromium.org>

Reviewed by Darin Adler.

​https://bugs.webkit.org/show_bug.cgi?id=16001
Incorrect assumption that selection is always contiguous LTR.

Test: editing/selection/extend-selection-bidi.html

  • rendering/RootInlineBox.cpp: (WebCore::RootInlineBox::fillLineSelectionGap): Make this function not assume a contiguous visual LTR selection range.
12:14 AM Changeset in webkit [39784] by ap@webkit.org
  • 57 edits
    3 adds
    4 deletes in trunk

Reviewed by Darin Adler.

​https://bugs.webkit.org/show_bug.cgi?id=23207
Moved currentTime() to from WebCore to WTF.

12:06 AM Changeset in webkit [39783] by ap@webkit.org
  • 3 edits in trunk/WebCore

2009-01-11 Dmitry Titov <​dimich@chromium.org>

Reviewed by Darin Adler.

Make ScheduledAction (Timeout callback) able to execute the callback under WorkerContext.
Part of 'Timers in Workers' work.
​https://bugs.webkit.org/show_bug.cgi?id=23223

  • bindings/js/ScheduledAction.cpp: (WebCore::ScheduledAction::execute): new method that takes WorkerContext. (WebCore::ScheduledAction::executeFunctionInContext): Executes a JSFunction in proper context with 'this' object.
  • bindings/js/ScheduledAction.h:
Note: See TracTimeline for information about the timeline view.