Timeline
Jan 13, 2009:
- 11:17 PM Changeset in webkit [39884] by
-
- 7 edits5 adds in trunk
Reviewed by Anders Carlsson.
Test: http/tests/appcache/xhr-foreign-resource.html
https://bugs.webkit.org/show_bug.cgi?id=23256
Implement application cache foreign entries
- loader/DocumentLoader.cpp: (WebCore::DocumentLoader::shouldLoadResourceFromApplicationCache): Removed a misplaced check for foreign resources that prevented them from being loaded altogether.
- loader/appcache/ApplicationCacheGroup.cpp: (WebCore::ApplicationCacheGroup::selectCache): If a document that was loaded from appcache should be associated with a different cache, mark the resource as foreign in the original cache and start over.
- loader/appcache/ApplicationCacheResource.cpp: (WebCore::ApplicationCacheResource::addType): This function can now be called after a cache is stored, so it no longer asserts the opposite.
- loader/appcache/ApplicationCacheStorage.cpp: (WebCore::ApplicationCacheStorage::cacheGroupForURL): Fix database pass to correctly ignore in-memory caches that were already rejected. (WebCore::ApplicationCacheStorage::fallbackCacheGroupForURL): Ditto. (WebCore::ApplicationCacheStorage::storeUpdatedType): Added a function that updates type of an already stored cached resource.
- loader/appcache/ApplicationCacheStorage.h: Added storeUpdatedType().
- 11:14 PM Changeset in webkit [39883] by
-
- 1 edit7 adds in trunk/LayoutTests
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=23286
Add a test for non-ASCII URIs in application cache
- http/tests/appcache/cyrillic-uri-expected.txt: Added.
- http/tests/appcache/cyrillic-uri.html: Added.
- http/tests/appcache/resources/cyrillic-uri-form.html: Added.
- http/tests/appcache/resources/cyrillic-uri.manifest: Added.
- http/tests/appcache/resources/intercept: Added.
- http/tests/appcache/resources/intercept/.htaccess: Added.
- http/tests/appcache/resources/print-uri.php: Added.
- 5:44 PM Changeset in webkit [39882] by
-
- 5 edits in trunk
2009-01-13 Beth Dakin <Beth Dakin>
Reviewed by Darin Adler and Oliver Hunt.
<rdar://problem/6489314> REGRESSION: Business widget's front side
fails to render correctly when flipping widget
The problem here is that parseInt was parsing NaN as 0. This patch
corrects that by parsing NaN as NaN. This matches our old behavior
and Firefox.
- runtime/JSGlobalObjectFunctions.cpp: (JSC::globalFuncParseInt):
LayoutTests:
2009-01-13 Beth Dakin <Beth Dakin>
Reviewed by Darin Adler and Oliver Hunt.
Updated test and results for <rdar://problem/6489314> REGRESSION:
Business widget's front side fails to render correctly when
flipping widget
parseInt(NaN) should be NaN.
- fast/js/numeric-conversion-expected.txt:
- fast/js/resources/numeric-conversion.js:
- 5:24 PM Changeset in webkit [39881] by
-
- 6 edits in trunk/WebCore
Fix the Tiger WebCore build after r39880.
- editing/Editor.cpp:
(WebCore::Editor::markBadGrammar):
- loader/mac/DocumentLoaderMac.cpp:
(WebCore::DocumentLoader::schedule):
(WebCore::DocumentLoader::unschedule):
- platform/mac/PasteboardMac.mm:
(WebCore::Pasteboard::writeSelection):
- platform/mac/WebCoreObjCExtras.mm:
(WebCoreObjCFinalizeOnMainThread):
- platform/network/mac/ResourceHandleMac.mm:
(WebCore::ResourceHandle::schedule):
(WebCore::ResourceHandle::unschedule):
- 4:16 PM Changeset in webkit [39880] by
-
- 17 edits in trunk/WebCore
2009-01-13 Darin Adler <Darin Adler>
Reviewed by Sam Weinig.
Bug 23102: turn on unused parameter warnings in WebCore
https://bugs.webkit.org/show_bug.cgi?id=23102
Last step: Turn on the warning and fix the last few instances.
- Configurations/Base.xcconfig: Removed -Wno-unused-parameter from WARNING_CFLAGS_BASE, so the unused parameter warning will fire.
- bindings/js/JSDOMWindowBase.cpp: (jsDOMWindowBaseMessageChannel): Separate the version for use when CHANNEL_MESSAGING is turned off, so we can omit the argument names. It would be better to not even have this property in that case, rather than having the function return undefined, but I don't know how to do that with the bindings script.
- bindings/scripts/CodeGeneratorJS.pm: Leave out argument names in functions where they're not used (the SVG context, and the property name in the index getter). Use UNUSED_PARAM where arguments are sometimes not used.
- bridge/runtime_object.cpp: (JSC::RuntimeObjectImp::put): Use UNUSED_PARAM for non-QT.
- css/MediaQueryEvaluator.cpp: (WebCore::animationMediaFeatureEval): Omit argument names for style and frame. (WebCore::transitionMediaFeatureEval): Ditto. (WebCore::transform_2dMediaFeatureEval): Ditto. (WebCore::transform_3dMediaFeatureEval): Ditto.
- dom/make_names.pl: Leave out the createdByParser property name in cases where it's not used.
- inspector/JavaScriptDebugServer.cpp: (WebCore::JavaScriptDebugServer::setJavaScriptPaused): Separate the version for the Mac platform so we can omit the argument names.
- loader/EmptyClients.h: (WebCore::EmptyChromeClient::contentsSizeChanged): Removed argument name.
- loader/FrameLoaderClient.h: (WebCore::FrameLoaderClient::shouldUsePluginDocument): Commented out argument name.
- loader/icon/IconFetcher.cpp: (WebCore::IconFetcher::didReceiveResponse): Use ASSERT_UNUSED. (WebCore::IconFetcher::didReceiveData): Ditto. (WebCore::IconFetcher::didFinishLoading): Ditto. (WebCore::IconFetcher::didFail): Ditto.
- platform/KURL.cpp: (WebCore::assertProtocolIsGood): Separate out the NDEBUG version so we can omit the argument names.
- platform/Timer.cpp: (WebCore::TimerHeapIterator::checkConsistency): Use ASSERT_UNUSED.
- platform/graphics/GlyphBuffer.h: (WebCore::GlyphBuffer::offsetAt): Use UNUSED_PARAM in the non-WIN case. (WebCore::GlyphBuffer::add): Use UNUSED_PARAM in the non-CAIRO case.
- platform/graphics/cg/ImageSourceCG.cpp: (WebCore::ImageSource::clear): Removed argument name.
- rendering/SVGRenderSupport.cpp: (WebCore::prepareToRenderSVGContent): Use UNUSED_PARAM when SVG_FILTERS is not enabled. (WebCore::finishRenderSVGContent): Ditto.
- 4:15 PM Changeset in webkit [39879] by
-
- 2 edits in trunk/JavaScriptCore
2009-01-13 Gavin Barraclough <barraclough@apple.com>
Reviewed by Oliver Hunt.
Implementation of two argument canDoFastAdditiveOperations does not correlate well with reality.
- runtime/JSImmediate.h: (JSC::JSFastMath::canDoFastAdditiveOperations):
- 3:40 PM ApplicationsGtk edited by
- fixed Empathy's link label (diff)
- 2:47 PM Changeset in webkit [39878] by
-
- 2 edits in trunk/WebCore
Implemented https://bugs.webkit.org/show_bug.cgi?id=23298
Simple fix to convertToLength to catch style==null cases
- css/CSSStyleSelector.cpp: (WebCore::convertToLength):
- 2:36 PM Changeset in webkit [39877] by
-
- 5 edits2 adds in trunk
WebKitTools:
2009-01-13 Anders Carlsson <andersca@apple.com>
Reviewed by Sam Weinig.
Add NPRuntime test.
- DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp: (testNPRuntime):
- DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.h:
- DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp: (NPP_New): (NPP_GetValue):
LayoutTests:
2009-01-13 Anders Carlsson <andersca@apple.com>
Reviewed by Sam Weinig.
Add NPRuntime test.
- plugins/npruntime-expected.txt: Added.
- plugins/npruntime.html: Added.
- 1:15 PM Changeset in webkit [39876] by
-
- 2 edits in trunk/WebCore
Reviewed by Mark Rowe.
Speculative fix for an Uninitialized Memory Read (UMR)
seen by purify in chormium's equivalent V8 file.
- bindings/js/JSSVGPODTypeWrapper.h: (WebCore::PODTypeWrapperCacheInfo::PODTypeWrapperCacheInfo):
- 12:55 PM Changeset in webkit [39875] by
-
- 1 edit4 adds in trunk/WebCore
2009-01-13 Dimitri Glazkov <Dimitri Glazkov>
Reviewed by Eric Seidel.
Land portions of platform/graphics/chromium.
https://bugs.webkit.org/show_bug.cgi?id=23297
- platform/graphics/chromium/FontCustomPlatformData.cpp: Added. (WebCore::FontCustomPlatformData::~FontCustomPlatformData): (WebCore::FontCustomPlatformData::fontPlatformData): (WebCore::EOTStream::EOTStream): (WebCore::EOTStream::read): (WebCore::readEmbedProc): (WebCore::createUniqueFontName): (WebCore::createFontCustomPlatformData):
- platform/graphics/chromium/FontCustomPlatformData.h: Added. (WebCore::FontCustomPlatformData::FontCustomPlatformData):
- platform/graphics/chromium/FontLinux.cpp: Added. (WebCore::Font::drawGlyphs): (WebCore::Font::drawComplexText): (WebCore::Font::floatWidthForComplexText): (WebCore::Font::offsetForPositionForComplexText): (WebCore::Font::selectionRectForComplexText):
- platform/graphics/chromium/FontPlatformData.h: Added.
- 12:44 PM Changeset in webkit [39874] by
-
- 2 edits in trunk/WebKit/qt
2009-01-08 Yongjun Zhang <yongjun.zhang@nokia.com>
Reviewed by Simon Hausmann.
Update webview with the intersected rect.
In ChromeClientQt::repaint, view should be updated with the
intersected rect, not the whole windowRect;
This generally is not a problem for normal viewport setup where
viewport size is the same as the qwebview widget size. However, if we
set the viewport size smaller than qwebkit widget, we will see
unwanted painting outside the viewport.
- 12:43 PM Changeset in webkit [39873] by
-
- 2 edits in trunk/WebKit/qt
2009-01-13 Ariya Hidayat <ariya.hidayat@trolltech.com>
Rubber-stamped by Tor Arne Vestbø.
[Qt] Missing piece from my previous commit:
Disable and enable the cursor navigation actions when contentEditable
is changed.
- Api/qwebpage.cpp: (QWebPagePrivate::updateEditorActions):
- 12:24 PM Changeset in webkit [39872] by
-
- 2 edits in trunk/WebCore
Don't copy DOMStringList.idl into the framework bundle.
Rubber-stamped by Oliver Hunt.
- WebCore.xcodeproj/project.pbxproj:
- 12:22 PM WebKit Team edited by
- (diff)
- 12:07 PM Changeset in webkit [39871] by
-
- 2 edits in trunk/JavaScriptCore
https://bugs.webkit.org/show_bug.cgi?id=23290
Fix JSImmediate::isImmediate(src) to !src->isCell()
Reviewed by Darin Adler.
- interpreter/Interpreter.cpp:
(JSC::Interpreter::privateExecute):
- 12:07 PM Changeset in webkit [39870] by
-
- 2 edits in trunk/WebKit/qt
2009-01-13 Ariya Hidayat <ariya.hidayat@trolltech.com>
Reviewed by Tor Arne Vestbø.
[Qt] Create actions for cursor navigation for QWebPage.
Also properly disable and enable them when contentEditable is toggled.
- Api/qwebpage.cpp: (QWebPagePrivate::updateAction): (QWebPage::action):
- 11:26 AM Changeset in webkit [39869] by
-
- 5 edits in trunk/WebKit/mac
2009-01-12 Anders Carlsson <andersca@apple.com>
Reviewed by Darin Adler.
Add a bunch of methods to WebKitPluginClient.defs, and implement them.
- Plugins/Hosted/NetscapePluginHostProxy.mm: (WebKit::fromUTF8WithLatin1Fallback): If the length isn't specified, get it by calling strlen.
(WKPCEvaluate):
Evaluate doesn't take any arguments.
(WKPCGetIntIdentifier):
Call _NPN_GetIntIdentifier.
(identifierFromServerIdentifier):
New helper function that returns a JSC Identifier from an NPIdentifier.
(WKPCInvoke):
Call identifierFromServerIdentifier.
(WKPCRemoveProperty):
(WKPCHasProperty):
(WKPCHasMethod):
Call NetscapePluginInstanceProxy.
- Plugins/Hosted/NetscapePluginInstanceProxy.h:
- Plugins/Hosted/NetscapePluginInstanceProxy.mm: (WebKit::NetscapePluginInstanceProxy::removeProperty): (WebKit::NetscapePluginInstanceProxy::hasProperty): (WebKit::NetscapePluginInstanceProxy::hasMethod):
- Plugins/Hosted/WebKitPluginClient.defs: Add new definitions.
- 11:25 AM Changeset in webkit [39868] by
-
- 2 edits in trunk/WebCore
2009-01-13 Christian Dywan <christian@twotoasts.de>
Build fix, StorageEvent is only defined if we have DOM_STORAGE
- dom/Document.cpp: (WebCore::Document::createEvent): Conditionalize StorageEvent
- 11:17 AM Changeset in webkit [39867] by
-
- 2 edits in trunk/WebKit/mac
2009-01-13 Anders Carlsson <andersca@apple.com>
Fix build.
- WebView/WebView.mm: (-[WebView _initWithArguments:]):
- 11:13 AM Changeset in webkit [39866] by
-
- 2 edits in trunk/JavaScriptCore
2009-01-13 Dmitry Titov <dimich@chromium.org>
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=23281
Fix the Chromium Win build.
Need to use PLATFORM(WIN_OS) instead of PLATFORM(WIN).
Moved GTK and WX up in #if sequence because they could come with WIN_OS too,
while they have their own implementation even on Windows.
- wtf/CurrentTime.cpp: (WTF::currentTime):
- 10:12 AM Changeset in webkit [39865] by
-
- 7 edits in trunk/WebKit
Adds a workaround for the flip4mac installer plugin decoding a WebView from a NIB on a secondary thread.
<rdar://problem/6489788> New WebKit thread checks break installation of flip4mac (thread violation)
Reviewed by Darin Adler.
- Misc/WebKitVersionChecks.h: Add WEBKIT_FIRST_VERSION_WITHOUT_WEBVIEW_INIT_THREAD_WORKAROUND.
- Misc/WebNSObjectExtras.h: Add _webkit_performSelectorOnMainThread:withObject:.
- Misc/WebNSObjectExtras.mm: (-[NSObject _webkit_performSelectorWithArguments:]): Renamed from _webkit_getPropertyWithArguments. Passes the optional object to the selector. (-[NSObject _webkit_performSelectorOnMainThread:withObject:]): Renamed from _webkit_getPropertyOnMainThread:. Put the optional object into the arguments dictionary. (-[NSObject _webkit_getPropertyOnMainThread:]): Call _webkit_performSelectorOnMainThread with a nil object.
- WebView/WebResource.mm: (-[WebResource _ignoreWhenUnarchiving]): Use _cmd instead of making the selector again. (-[WebResource _initWithData:URL:MIMEType:textEncodingName:frameName:response:copyData:]): Use the new _webkit_performSelectorOnMainThread:withObject: method instead of performSelectorOnMainThread.
- WebView/WebView.mm: (-[WebView _initWithArguments:]): Added. Pulls arguments out of the dictionary and calls the right init method. (needsWebViewInitThreadWorkaround): Checks if the thead is not the main thread and if we are in the Installer bundle. (-[WebView initWithFrame:frameName:groupName:]): Call needsWebViewInitThreadWorkaround and use _webkit_performSelectorOnMainThread to call _initWithArguments: passing the frame, frameName and groupName. (-[WebView initWithCoder:]): Ditto, except pass the coder to _initWithArguments:.
- 9:59 AM Changeset in webkit [39864] by
-
- 2 edits in trunk/WebCore
2009-01-13 Darin Adler <Darin Adler>
Reviewed by Adele Peterson.
Bug 23277: space bar scrolls the page when typed in any text field
https://bugs.webkit.org/show_bug.cgi?id=23277
rdar://problem/6490249
There's already a regression test for this, since bug 16421 was the same problem, but on
Mac. The regression test is fast/events/space-scroll-event.html, so I won't write a new one.
This bug doesn't affect Mac because the canEdit check in -[WebHTMLView insertText:] prevents
a text input event from being generated at all. That difference may in itself be a bug, but
the only symptom is that you get text input events in more cases on platforms other than Mac.
- page/EventHandler.cpp: (WebCore::EventHandler::handleTextInputEvent): Return whether the event's default was handled, not the result of the dispatchEvent function, which indicates only whether the default behavior was prevented, not if the default behavior did some insertion. This fix makes it so the keyboard event handler can detect that no space was inserted and know that the space bar keypress event can be treated as a scrolling command. (WebCore::EventHandler::defaultKeyboardEventHandler): Handle the keypress event, not the keydown event. Without the change above, making this change would have restored the old behavior, reintroducing bug 22913 where the space bar doesn't scroll at all on Windows.
- 9:58 AM Changeset in webkit [39863] by
-
- 6 edits in trunk/WebKit/qt
2009-01-13 Simon Hausmann <simon.hausmann@nokia.com>
Reviewed by Tor Arne Vestbø.
Based on patch by Yael Aharon <yael.aharon@nokia.com>
Make the QWebSettings functions for setting the path for the local
storage database private QtWebkit API, including the ability to
associated a QWebPage with a named page group.
- 9:24 AM Changeset in webkit [39862] by
-
- 2 edits in trunk/WebCore
2009-01-13 Tor Arne Vestbø <tavestbo@trolltech.com>
Reviewed by Simon Hausmann.
[Qt] Make sure media elements dispatch the 'loaded' event
We assume that when Phonon goes into paused state that we have the
complete media file. Once we do media loading ourselves we can
distinguish between loading the first frame and the complete media.
- 8:48 AM Changeset in webkit [39861] by
-
- 1 edit27 adds in trunk/WebCore
2009-01-13 Darin Fisher <darin@chromium.org>
Reviewed by Eric Seidel.
Landing portions of platform/chromium/, taken from here:
http://src.chromium.org/viewvc/chrome/trunk/deps/third_party/WebKit/WebCore/platform/chromium/
- platform/chromium/ChromiumBridge.h: Added.
- platform/chromium/ChromiumDataObject.cpp: Added. (WebCore::ChromiumDataObject::clear): (WebCore::ChromiumDataObject::hasData):
- platform/chromium/ChromiumDataObject.h: Added. (WebCore::ChromiumDataObject::create): (WebCore::ChromiumDataObject::ChromiumDataObject):
- platform/chromium/ClipboardChromium.cpp: Added. (WebCore::): (WebCore::clipboardTypeFromMIMEType): (WebCore::ClipboardChromium::ClipboardChromium): (WebCore::ClipboardChromium::create): (WebCore::ClipboardChromium::clearData): (WebCore::ClipboardChromium::clearAllData): (WebCore::ClipboardChromium::getData): (WebCore::ClipboardChromium::setData): (WebCore::ClipboardChromium::types): (WebCore::ClipboardChromium::setDragImage): (WebCore::ClipboardChromium::setDragImageElement): (WebCore::ClipboardChromium::createDragImage): (WebCore::imageToMarkup): (WebCore::getCachedImage): (WebCore::writeImageToDataObject): (WebCore::ClipboardChromium::declareAndWriteDragImage): (WebCore::ClipboardChromium::writeURL): (WebCore::ClipboardChromium::writeRange): (WebCore::ClipboardChromium::hasData):
- platform/chromium/ClipboardChromium.h: Added. (WebCore::ClipboardChromium::~ClipboardChromium): (WebCore::ClipboardChromium::dataObject):
- platform/chromium/ClipboardUtilitiesChromium.cpp: Added. (WebCore::replaceNewlinesWithWindowsStyleNewlines): (WebCore::replaceNBSPWithSpace): (WebCore::urlToMarkup):
- platform/chromium/ClipboardUtilitiesChromium.h: Added.
- platform/chromium/ContextMenuChromium.cpp: Added. (WebCore::ContextMenu::ContextMenu): (WebCore::ContextMenu::~ContextMenu): (WebCore::ContextMenu::itemCount): (WebCore::ContextMenu::insertItem): (WebCore::ContextMenu::appendItem): (WebCore::ContextMenu::itemWithAction): (WebCore::ContextMenu::itemAtIndex): (WebCore::ContextMenu::setPlatformDescription): (WebCore::ContextMenu::platformDescription): (WebCore::ContextMenu::releasePlatformDescription):
- platform/chromium/ContextMenuItemChromium.cpp: Added. (WebCore::ContextMenuItem::ContextMenuItem): (WebCore::ContextMenuItem::~ContextMenuItem): (WebCore::ContextMenuItem::releasePlatformDescription): (WebCore::ContextMenuItem::type): (WebCore::ContextMenuItem::action): (WebCore::ContextMenuItem::title): (WebCore::ContextMenuItem::platformSubMenu): (WebCore::ContextMenuItem::setType): (WebCore::ContextMenuItem::setAction): (WebCore::ContextMenuItem::setTitle): (WebCore::ContextMenuItem::setSubMenu): (WebCore::ContextMenuItem::setChecked): (WebCore::ContextMenuItem::setEnabled): (WebCore::ContextMenuItem::enabled):
- platform/chromium/CursorChromium.cpp: Added. (WebCore::Cursor::Cursor): (WebCore::Cursor::~Cursor): (WebCore::Cursor::operator=): (WebCore::pointerCursor): (WebCore::crossCursor): (WebCore::handCursor): (WebCore::iBeamCursor): (WebCore::waitCursor): (WebCore::helpCursor): (WebCore::eastResizeCursor): (WebCore::northResizeCursor): (WebCore::northEastResizeCursor): (WebCore::northWestResizeCursor): (WebCore::southResizeCursor): (WebCore::southEastResizeCursor): (WebCore::southWestResizeCursor): (WebCore::westResizeCursor): (WebCore::northSouthResizeCursor): (WebCore::eastWestResizeCursor): (WebCore::northEastSouthWestResizeCursor): (WebCore::northWestSouthEastResizeCursor): (WebCore::columnResizeCursor): (WebCore::rowResizeCursor): (WebCore::middlePanningCursor): (WebCore::eastPanningCursor): (WebCore::northPanningCursor): (WebCore::northEastPanningCursor): (WebCore::northWestPanningCursor): (WebCore::southPanningCursor): (WebCore::southEastPanningCursor): (WebCore::southWestPanningCursor): (WebCore::westPanningCursor): (WebCore::moveCursor): (WebCore::verticalTextCursor): (WebCore::cellCursor): (WebCore::contextMenuCursor): (WebCore::aliasCursor): (WebCore::progressCursor): (WebCore::noDropCursor): (WebCore::copyCursor): (WebCore::noneCursor): (WebCore::notAllowedCursor): (WebCore::zoomInCursor): (WebCore::zoomOutCursor): (WebCore::grabCursor): (WebCore::grabbingCursor):
- platform/chromium/DragDataChromium.cpp: Added. (WebCore::containsHTML): (WebCore::DragData::createClipboard): (WebCore::DragData::containsURL): (WebCore::DragData::asURL): (WebCore::DragData::containsFiles): (WebCore::DragData::asFilenames): (WebCore::DragData::containsPlainText): (WebCore::DragData::asPlainText): (WebCore::DragData::containsColor): (WebCore::DragData::canSmartReplace): (WebCore::DragData::containsCompatibleContent): (WebCore::DragData::asFragment): (WebCore::DragData::asColor):
- platform/chromium/EditorChromium.cpp: Added. (WebCore::Editor::newGeneralClipboard):
- platform/chromium/FileChooserChromium.cpp: Added. (WebCore::FileChooser::basenameForWidth):
- platform/chromium/FileSystemChromium.cpp: Added. (WebCore::deleteFile): (WebCore::deleteEmptyDirectory): (WebCore::getFileSize): (WebCore::getFileModificationTime): (WebCore::directoryName): (WebCore::pathByAppendingComponent): (WebCore::makeAllDirectories): (WebCore::fileExists):
- platform/chromium/FileSystemChromiumLinux.cpp: Added. (WebCore::pathGetFileName):
- platform/chromium/FileSystemChromiumMac.mm: Added. (WebCore::pathGetFileName):
- platform/chromium/FileSystemChromiumWin.cpp: Added. (WebCore::pathGetFileName):
- platform/chromium/FramelessScrollView.cpp: Added. (WebCore::FramelessScrollView::~FramelessScrollView): (WebCore::FramelessScrollView::invalidateScrollbarRect): (WebCore::FramelessScrollView::isActive): (WebCore::FramelessScrollView::invalidateRect): (WebCore::FramelessScrollView::hostWindow): (WebCore::FramelessScrollView::windowClipRect): (WebCore::FramelessScrollView::paintContents): (WebCore::FramelessScrollView::contentsResized): (WebCore::FramelessScrollView::visibleContentsResized):
- platform/chromium/FramelessScrollView.h: Added. (WebCore::FramelessScrollView::FramelessScrollView): (WebCore::FramelessScrollView::client): (WebCore::FramelessScrollView::setClient):
- platform/chromium/FramelessScrollViewClient.h: Added.
- platform/chromium/ScrollbarThemeChromiumWin.cpp: Added. (WebCore::): (WebCore::ScrollbarThemeChromium::scrollbarThickness): (WebCore::ScrollbarThemeChromium::invalidateOnMouseEnterExit): (WebCore::ScrollbarThemeChromium::paintTrackPiece): (WebCore::ScrollbarThemeChromium::paintButton): (WebCore::ScrollbarThemeChromium::paintThumb): (WebCore::ScrollbarThemeChromium::getThemeState): (WebCore::ScrollbarThemeChromium::getThemeArrowState): (WebCore::ScrollbarThemeChromium::getClassicThemeState):
- platform/chromium/SoundChromiumPosix.cpp: Added. (WebCore::systemBeep):
- platform/chromium/SoundChromiumWin.cpp: Added. (WebCore::systemBeep):
- platform/chromium/SystemTimeChromium.cpp: Added. (WebCore::currentTime): (WebCore::userIdleTime):
- platform/chromium/WidgetChromium.cpp: Added. (WebCore::Widget::Widget): (WebCore::Widget::~Widget): (WebCore::Widget::show): (WebCore::Widget::hide): (WebCore::Widget::setCursor): (WebCore::Widget::paint): (WebCore::Widget::setFocus): (WebCore::Widget::setIsSelected): (WebCore::Widget::frameRect): (WebCore::Widget::setFrameRect):
- platform/chromium/WindowsVersion.cpp: Added. (WebCore::isVistaOrNewer):
- platform/chromium/WindowsVersion.h: Added.
- 8:38 AM Changeset in webkit [39860] by
-
- 2 edits in trunk/WebCore
2009-01-13 Tor Arne Vestbø <tavestbo@trolltech.com>
Reviewed by Simon Hausmann.
[Qt] Add more verbose error output when loading NPAPI plugins
- 8:17 AM Changeset in webkit [39859] by
-
- 2 edits in trunk/WebCore
2009-01-13 Simon Hausmann <simon.hausmann@nokia.com>
Reviewed by Tor Arne Vestbø.
Fix crash in the Qt port when deleting a popup from within a
JavaScript onchange handler.
- 6:58 AM Changeset in webkit [39858] by
-
- 2 edits in trunk/WebCore
[GIO] Make sure to untef the GFile and the GInputStream on destruction
Make sure to call cleanupGioOperation from the ResourceHandleInternal
d'tor. Change the signature of cleanupGioOperation so we can do the
cleanup of GIO next to the cleanup of SOUP.
- 6:58 AM Changeset in webkit [39857] by
-
- 2 edits in trunk/WebCore
[GIO] Attach the ResourceHandle to the GObject and get it from the GObject
https://bugs.webkit.org/show_bug.cgi?id=23116 discussed with Benjamin Otte
Sometimes it is not possible to cancel a pending GIO operation and the
callback might be invoked with a pointer to an already destructed
ResourceHandle. To avoid this issue we will attach the ResourceHandle
to the GObject* and in the callback attempt to get the ResourceHandle
from the GObject*. If no ResourceHandle is attached we silently fail
as the cleanup has been already done.
- 6:58 AM Changeset in webkit [39856] by
-
- 2 edits in trunk/WebCore
[GIO] Invoke cleanupGioOperation before calling didFail to avoid crashes
https://bugs.webkit.org/show_bug.cgi?id=23116
The ResourceHandle becomes invalid (e.g. got destructed) from within
the invocation of didFail. Avoid this by cleaning up everything before
calling didFail and simply return afterwards.
This is happening with many tests from dom/html/level2/html e.g.
LayoutTests/dom/html/level2/html/HTMLBodyElement07.html.
- 6:57 AM Changeset in webkit [39855] by
-
- 2 edits in trunk/WebKit/gtk
2009-01-13 Alexander V. Butenko <alex@digiqube.com>
Reviewed by Holger Freyther.
Fix crash on WebView dispose stage.
Add null checks to webkit_web_view_set_scroll_adjustments and
webkit_web_view_get_accessible as they get called from within
the dispose.
- webkit/webkitwebview.cpp:
- 6:51 AM Changeset in webkit [39854] by
-
- 7 edits1 move2 adds2 deletes in trunk/WebCore
2009-01-13 Tor Arne Vestbø <tavestbo@trolltech.com>
Reviewed by Simon Hausmann.
Change how themes adjust mediaControls.css to match html4/quicks.css
Instead of providing the full style sheet, the themes provide extra
overrides to the default style defined in UserAgentStyleSheetsData.
Also, merge WebKitResources.qrc and WebCoreResources.qrc to speed up
build time for the Qt port.
- 12:11 AM Changeset in webkit [39853] by
-
- 2 edits in trunk/WebKit/win
Build fix.
- WebScriptCallFrame.cpp: (WebScriptCallFrame::jsValueToString):
Jan 12, 2009:
- 11:54 PM Changeset in webkit [39852] by
-
- 6 edits in trunk/WebKitTools
Use the modern spelling of WebKit.
- Scripts/find-extra-includes:
- Scripts/report-include-statistics:
- Scripts/run-webkit-app:
- Scripts/svn-unapply:
- Scripts/update-webkit:
- 8:51 PM Changeset in webkit [39851] by
-
- 38 edits in trunk
2009-01-12 Gavin Barraclough <barraclough@apple.com>
Reviewed by Oliver Hunt.
Make the JSImmediate interface private.
All manipulation of JS values should be through the JSValuePtr class, not by using JSImmediate
directly. The key missing methods on JSValuePtr are:
- isCell() - check for values that are JSCell*s, and as such where asCell() may be used.
- isInt32Fast() getInt32Fast() - fast check/access for integer immediates.
- isUInt32Fast() getUInt32Fast() - ditto for unsigned integer immediates.
The JIT is allowed full access to JSImmediate, since it needs to be able to directly
manipulate JSValuePtrs. The Interpreter is provided access to perform operations directly
on JSValuePtrs through the new JSFastMath interface.
No performance impact.
- API/JSCallbackObjectFunctions.h: (JSC::::toNumber):
- API/JSValueRef.cpp: (JSValueIsEqual): (JSValueIsStrictEqual):
- JavaScriptCore.exp:
- bytecode/CodeBlock.h: (JSC::CodeBlock::isKnownNotImmediate):
- bytecompiler/BytecodeGenerator.cpp: (JSC::keyForImmediateSwitch):
- bytecompiler/BytecodeGenerator.h: (JSC::BytecodeGenerator::JSValueHashTraits::constructDeletedValue): (JSC::BytecodeGenerator::JSValueHashTraits::isDeletedValue):
- interpreter/Interpreter.cpp: (JSC::jsLess): (JSC::jsLessEq): (JSC::jsAdd): (JSC::jsIsObjectType): (JSC::cachePrototypeChain): (JSC::Interpreter::tryCachePutByID): (JSC::Interpreter::tryCacheGetByID): (JSC::Interpreter::privateExecute): (JSC::Interpreter::tryCTICachePutByID): (JSC::Interpreter::tryCTICacheGetByID): (JSC::Interpreter::cti_op_add): (JSC::Interpreter::cti_op_get_by_id_self_fail): (JSC::Interpreter::cti_op_get_by_id_proto_list): (JSC::Interpreter::cti_op_instanceof): (JSC::Interpreter::cti_op_mul): (JSC::Interpreter::cti_op_get_by_val): (JSC::Interpreter::cti_op_get_by_val_byte_array): (JSC::Interpreter::cti_op_sub): (JSC::Interpreter::cti_op_put_by_val): (JSC::Interpreter::cti_op_put_by_val_array): (JSC::Interpreter::cti_op_put_by_val_byte_array): (JSC::Interpreter::cti_op_negate): (JSC::Interpreter::cti_op_div): (JSC::Interpreter::cti_op_eq): (JSC::Interpreter::cti_op_lshift): (JSC::Interpreter::cti_op_bitand): (JSC::Interpreter::cti_op_rshift): (JSC::Interpreter::cti_op_bitnot): (JSC::Interpreter::cti_op_neq): (JSC::Interpreter::cti_op_urshift): (JSC::Interpreter::cti_op_call_eval): (JSC::Interpreter::cti_op_throw): (JSC::Interpreter::cti_op_is_undefined): (JSC::Interpreter::cti_op_stricteq): (JSC::Interpreter::cti_op_nstricteq): (JSC::Interpreter::cti_op_switch_imm): (JSC::Interpreter::cti_vm_throw):
- interpreter/Interpreter.h: (JSC::Interpreter::isJSArray): (JSC::Interpreter::isJSString): (JSC::Interpreter::isJSByteArray):
- jit/JIT.cpp: (JSC::JIT::compileOpStrictEq): (JSC::JIT::privateCompileMainPass):
- jit/JIT.h: (JSC::JIT::isStrictEqCaseHandledInJITCode):
- jit/JITArithmetic.cpp: (JSC::JIT::compileFastArith_op_rshift): (JSC::JIT::compileFastArith_op_bitand): (JSC::JIT::compileFastArith_op_mod):
- jit/JITCall.cpp: (JSC::JIT::unlinkCall): (JSC::JIT::compileOpCall):
- jit/JITInlineMethods.h: (JSC::JIT::getConstantOperandImmediateInt): (JSC::JIT::isOperandConstantImmediateInt):
- parser/Nodes.cpp: (JSC::processClauseList):
- runtime/ArrayPrototype.cpp: (JSC::arrayProtoFuncIndexOf): (JSC::arrayProtoFuncLastIndexOf):
- runtime/BooleanPrototype.cpp: (JSC::booleanProtoFuncValueOf):
- runtime/Collector.cpp: (JSC::Heap::protect): (JSC::Heap::unprotect): (JSC::Heap::heap):
- runtime/JSByteArray.cpp: (JSC::JSByteArray::getOwnPropertySlot):
- runtime/JSByteArray.h: (JSC::JSByteArray::getIndex):
- runtime/JSCell.cpp:
- runtime/JSCell.h: (JSC::JSValuePtr::isNumberCell): (JSC::JSValuePtr::asCell): (JSC::JSValuePtr::isNumber):
- runtime/JSGlobalObjectFunctions.cpp: (JSC::globalFuncParseInt):
- runtime/JSImmediate.h: (JSC::js0): (JSC::jsImpossibleValue): (JSC::JSValuePtr::toInt32): (JSC::JSValuePtr::toUInt32): (JSC::JSValuePtr::isCell): (JSC::JSValuePtr::isInt32Fast): (JSC::JSValuePtr::getInt32Fast): (JSC::JSValuePtr::isUInt32Fast): (JSC::JSValuePtr::getUInt32Fast): (JSC::JSValuePtr::makeInt32Fast): (JSC::JSValuePtr::areBothInt32Fast): (JSC::JSFastMath::canDoFastBitwiseOperations): (JSC::JSFastMath::equal): (JSC::JSFastMath::notEqual): (JSC::JSFastMath::andImmediateNumbers): (JSC::JSFastMath::xorImmediateNumbers): (JSC::JSFastMath::orImmediateNumbers): (JSC::JSFastMath::canDoFastRshift): (JSC::JSFastMath::canDoFastUrshift): (JSC::JSFastMath::rightShiftImmediateNumbers): (JSC::JSFastMath::canDoFastAdditiveOperations): (JSC::JSFastMath::addImmediateNumbers): (JSC::JSFastMath::subImmediateNumbers): (JSC::JSFastMath::incImmediateNumber): (JSC::JSFastMath::decImmediateNumber):
- runtime/JSNumberCell.h: (JSC::JSValuePtr::asNumberCell): (JSC::jsNumber): (JSC::JSValuePtr::uncheckedGetNumber): (JSC::JSNumberCell::toInt32): (JSC::JSNumberCell::toUInt32): (JSC::JSValuePtr::toJSNumber): (JSC::JSValuePtr::getNumber): (JSC::JSValuePtr::numberToInt32): (JSC::JSValuePtr::numberToUInt32):
- runtime/JSObject.h: (JSC::JSValuePtr::isObject): (JSC::JSValuePtr::get): (JSC::JSValuePtr::put):
- runtime/JSValue.cpp: (JSC::JSValuePtr::toInteger): (JSC::JSValuePtr::toIntegerPreserveNaN):
- runtime/JSValue.h:
- runtime/Operations.cpp: (JSC::JSValuePtr::equalSlowCase): (JSC::JSValuePtr::strictEqualSlowCase):
- runtime/Operations.h: (JSC::JSValuePtr::equal): (JSC::JSValuePtr::equalSlowCaseInline): (JSC::JSValuePtr::strictEqual): (JSC::JSValuePtr::strictEqualSlowCaseInline):
- runtime/Protect.h: (JSC::gcProtect): (JSC::gcUnprotect):
- runtime/StringPrototype.cpp: (JSC::stringProtoFuncCharAt): (JSC::stringProtoFuncCharCodeAt):
- runtime/Structure.cpp: (JSC::Structure::createCachedPrototypeChain):
WebCore:
2009-01-12 Gavin Barraclough <barraclough@apple.com>
Reviewed by Oliver Hunt.
Deprecate JSValuePtr::getNumber() - two ways to get a number should be enough.
- bindings/js/JSSQLTransactionCustom.cpp: (WebCore::JSSQLTransaction::executeSql):
- bindings/objc/WebScriptObject.mm: (+[WebScriptObject _convertValueToObjcValue:originRootObject:rootObject:]):
WebKit/mac:
2009-01-12 Gavin Barraclough <barraclough@apple.com>
Reviewed by Oliver Hunt.
Deprecate JSValuePtr::getNumber() - two ways to get a number should be enough.
- WebView/WebView.mm: (aeDescFromJSValue):
- 6:33 PM Changeset in webkit [39850] by
-
- 2 edits in trunk/WebKit/win
2009-01-12 Brady Eidson <beidson@apple.com>
Reviewed by NOBODY (OOPS!).
<rdar://problem/6490446> - Crash when going back to a cached page
- WebCoreSupport/WebFrameLoaderClient.cpp: (WebFrameLoaderClient::savePlatformDataToCachedPage): ENABLE(CFNETWORK) needed to be USE(CFNETWORK)
- 5:09 PM Changeset in webkit [39849] by
-
- 4 edits in trunk/WebCore
I added a common getElapsedTime() function to AnimationBase which uses a combination of
the techniques from KeyframeAnimation and AnimationBase to compute elapsedTime in all
states.
- page/animation/AnimationBase.cpp: (WebCore::AnimationBase::progress): (WebCore::AnimationBase::getElapsedTime):
- page/animation/AnimationBase.h:
- page/animation/KeyframeAnimation.cpp: (WebCore::KeyframeAnimation::animate):
- 4:22 PM Changeset in webkit [39848] by
-
- 3 edits2 adds in trunk
Correct scrolldelay units (s -> ms)
- 4:20 PM Changeset in webkit [39847] by
-
- 2 edits in trunk/WebCore
2009-01-12 Simon Fraser <Simon Fraser>
Reviewed by Dan Bernstein
In RenderBox::repaintLayerRectsForImage(), the repaint rect does not have
to be computed in absolute coordintes. Instead, we compute a repaintRect
relative to the RenderObject, which can repaint itself.
- rendering/RenderBox.cpp: (WebCore::RenderBox::repaintLayerRectsForImage):
- 4:15 PM Changeset in webkit [39846] by
-
- 2 edits in trunk/WebCore
2009-01-12 David Hyatt <hyatt@apple.com>
Apply the same idea as the previous fix but for matched declarations.
Reviewed by Dan Bernstein
- css/CSSStyleSelector.h:
- 4:15 PM Changeset in webkit [39845] by
-
- 17 edits in trunk
WebCore:
2009-01-12 Brady Eidson <beidson@apple.com>
Reviewed by Darin Adler
<rdar://problem/6468274> - Track Non-get requests in global history
- WebCore.base.exp:
- history/HistoryItem.cpp: (WebCore::HistoryItem::HistoryItem):
- history/HistoryItem.h: (WebCore::HistoryItem::lastVisitWasHTTPNonGet): (WebCore::HistoryItem::setLastVisitWasHTTPNonGet):
WebKit/mac:
2009-01-12 Brady Eidson <beidson@apple.com>
Reviewed by Darin Adler
<rdar://problem/6468274> - Track Non-get requests in global history
- History/WebHistory.mm: (-[WebHistory _visitedURL:withTitle:method:wasFailure:]):
- History/WebHistoryInternal.h:
- History/WebHistoryItem.mm: (-[WebHistoryItem initFromDictionaryRepresentation:]): (-[WebHistoryItem dictionaryRepresentation]): (-[WebHistoryItem _lastVisitWasHTTPNonGet]):
- History/WebHistoryItemPrivate.h:
- WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::updateGlobalHistory): Only pass the method through if it was an HTTP load
WebKit/win:
2009-01-12 Brady Eidson <beidson@apple.com>
Reviewed by Darin Adler
<rdar://problem/6468274> - Track Non-get requests in global history
- WebCoreSupport/WebFrameLoaderClient.cpp: (WebFrameLoaderClient::updateGlobalHistory):
- WebHistory.cpp: (WebHistory::addItem):
- WebHistory.h:
- Interfaces/IWebHistoryItemPrivate.idl:
- WebHistoryItem.cpp: (WebHistoryItem::initFromDictionaryRepresentation): (WebHistoryItem::dictionaryRepresentation): (WebHistoryItem::lastVisitWasHTTPNonGet): (WebHistoryItem::setLastVisitWasHTTPNonGet):
- WebHistoryItem.h:
- 3:49 PM Changeset in webkit [39844] by
-
- 2 edits in trunk/WebKit/wx
wx build fix. JSValue* -> JSValuePtr.
- 3:47 PM Changeset in webkit [39843] by
-
- 5 edits in trunk/WebCore
!ENABLE(SVG_FONTS) build fix. Move defaultUnitsPerEm into a non-SVG header so it can be used by all builds.
- 3:41 PM Changeset in webkit [39842] by
-
- 2 edits in trunk/WebCore
wx build typo fix.
- 3:39 PM Changeset in webkit [39841] by
-
- 2 edits in trunk/JavaScriptCore
Since platform date time functions have moved to JSC, now the wx port JSC needs to depend on wx.
- 3:18 PM Changeset in webkit [39840] by
-
- 5 edits in trunk/WebKit/mac
2009-01-12 Anders Carlsson <andersca@apple.com>
Reviewed by Sam Weinig.
Move marshalling into NetscapePluginInstanceProxy.
Add support for marshallin strings.
- Plugins/Hosted/NetscapePluginHostProxy.mm: (WKPCEvaluate): (WKPCInvoke):
- Plugins/Hosted/NetscapePluginInstanceProxy.h:
- Plugins/Hosted/NetscapePluginInstanceProxy.mm: (WebKit::NetscapePluginInstanceProxy::evaluate): (WebKit::NetscapePluginInstanceProxy::invoke): (WebKit::NetscapePluginInstanceProxy::marshalValue):
- Plugins/Hosted/WebKitPluginHostTypes.h:
- 3:01 PM Changeset in webkit [39839] by
-
- 2 edits in trunk/WebCore
2009-01-12 David Hyatt <hyatt@apple.com>
Make sure the set of matched rules has a reserved capacity of 32. This prevents remalloc thrash as
elements are matched, since the Vector is shrinking and growing over and over. 1% PLT speedup.
Reviewed by Oliver Hunt
- css/CSSStyleSelector.h:
- 2:37 PM Changeset in webkit [39838] by
-
- 2 edits in trunk/WebCore
2009-01-12 David Hyatt <hyatt@apple.com>
Optimize Element::attributeChanged to just check if accessibility is enabled up front before looking at the
two accessibility-related attributes. This avoids the rest of the code for all attributes on the PLT.
Tiny speedup.
Reviewed by Oliver Hunt
- dom/Element.cpp: (WebCore::Element::attributeChanged):
- 2:34 PM Changeset in webkit [39837] by
-
- 2 edits in trunk/WebCore
2009-01-12 David Hyatt <hyatt@apple.com>
Optimize the retrieval of line height. If the document is not using any first-line rules, just immediately
default to the normal case. Tiny speedup on PLT.
Reviewed by Oliver Hunt
- rendering/RenderFlow.cpp: (WebCore::RenderFlow::lineHeight):
- 2:25 PM Changeset in webkit [39836] by
-
- 5 edits in trunk/WebKit/mac
2009-01-12 Anders Carlsson <andersca@apple.com>
Reviewed by Sam Weinig.
Implement WKPCInvoke.
- Plugins/Hosted/NetscapePluginHostProxy.mm: (WKPCEvaluate): (WKPCInvoke):
- Plugins/Hosted/NetscapePluginInstanceProxy.h:
- Plugins/Hosted/NetscapePluginInstanceProxy.mm: (WebKit::NetscapePluginInstanceProxy::idForObject): (WebKit::NetscapePluginInstanceProxy::invoke):
- Plugins/Hosted/WebKitPluginClient.defs:
- 2:15 PM QtWebKitTodo edited by
- (diff)
- 2:15 PM Changeset in webkit [39835] by
-
- 2 edits in trunk/WebCore
2009-01-12 David Hyatt <hyatt@apple.com>
Fix 0.6% regression in PLT. Make sure not to waste time updating NSScrollView's can blit on scroll state
in the ScrollView constructor, since this is always going to be properly updated by FrameView anyway.
Reviewed by Oliver Hunt
- platform/ScrollView.cpp: (WebCore::ScrollView::ScrollView):
- 1:42 PM Changeset in webkit [39834] by
-
- 12 edits in trunk/WebCore
2009-01-12 Simon Fraser <Simon Fraser>
Reviewed by Dan Bernstein
Merge layoutDelta into LayoutState. This requires that we
push even when layoutState is disabled, so that layoutDelta
can still be stored.
- 1:38 PM Changeset in webkit [39833] by
-
- 5 edits in trunk/WebKit/mac
2009-01-12 Anders Carlsson <andersca@apple.com>
Reviewed by Sam Weinig.
Move marshalling code to NetscapePluginInstanceProxy. Add support for marshalling JS objects.
- Plugins/Hosted/NetscapePluginHostProxy.mm: (WKPCEvaluate):
- Plugins/Hosted/NetscapePluginInstanceProxy.h:
- Plugins/Hosted/NetscapePluginInstanceProxy.mm: (WebKit::NetscapePluginInstanceProxy::marshalValue):
- Plugins/Hosted/WebKitPluginHostTypes.h:
- 1:31 PM Changeset in webkit [39832] by
-
- 2 edits in trunk/WebCore
2009-01-12 Julien Chaffraix <jchaffraix@pleyo.com>
Reviewed by Holger Freyther.
[Qt] Build fix after turning the fontCache to a singleton
https://bugs.webkit.org/show_bug.cgi?id=23253
Add a stub implementation for WebCore::fontCache() and FontCache::FontCache().
- platform/graphics/qt/FontCacheQt.cpp: (WebCore::fontCache): (WebCore::FontCache::FontCache):
- 1:07 PM Changeset in webkit [39831] by
-
- 5 edits2 adds in trunk
2009-01-12 Eric Roman <eroman@chromium.org>
Reviewed by Darin Adler.
Fix some bugs with Selection::appendTrailingWhitespace().
https://bugs.webkit.org/show_bug.cgi?id=23232
Test: editing/selection/doubleclick-whitespace-crash.html
- editing/Selection.cpp: (WebCore::makeSearchRange): (WebCore::Selection::appendTrailingWhitespace):
2009-01-12 Eric Roman <eroman@chromium.org>
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=23232
- editing/selection/doubleclick-whitespace-crash-expected.txt: Added.
- editing/selection/doubleclick-whitespace-crash.html: Added.
- editing/selection/doubleclick-whitespace-expected.txt:
- editing/selection/doubleclick-whitespace.html:
- 12:26 PM Changeset in webkit [39830] by
-
- 1 edit5 adds in trunk/WebCore
2009-01-12 Dimitri Glazkov <Dimitri Glazkov>
Reviewed by Eric Seidel.
Add the first pieces of platform/graphics/chromium
https://bugs.webkit.org/show_bug.cgi?id=23257
- platform/graphics/chromium/ColorChromium.cpp: Added. (WebCore::focusRingColor):
- platform/graphics/chromium/FontCacheChromiumWin.cpp: Added. (WebCore::FontCache::platformInit): (WebCore::isStringASCII): (WebCore::LookupAltName): (WebCore::FontCodepage::): (WebCore::FontCodepage::if): (WebCore::createFontIndirectAndGetWinName): (WebCore::fontContainsCharacter): (WebCore::FontCache::getFontDataForCharacters): (WebCore::FontCache::alternateFamilyName): (WebCore::FontCache::getSimilarFontPlatformData): (WebCore::FontCache::getLastResortFallbackFont): (WebCore::toGDIFontWeight): (WebCore::FontCache::getGenericFontForScript): (WebCore::FillLogFont): (WebCore::FontCache::fontExists): (WebCore::TraitsInFamilyProcData::TraitsInFamilyProcData): (WebCore::traitsInFamilyEnumProc): (WebCore::FontCache::getTraitsInFamily): (WebCore::FontCache::createFontPlatformData):
- platform/graphics/chromium/FontCacheLinux.cpp: Added. (WebCore::FontCache::platformInit): (WebCore::FontCache::getFontDataForCharacters): (WebCore::FontCache::alternateFamilyName): (WebCore::FontCache::getSimilarFontPlatformData): (WebCore::FontCache::getLastResortFallbackFont): (WebCore::FontCache::getTraitsInFamily): (WebCore::FontCache::createFontPlatformData): (WebCore::FontCache::getGenericFontForScript):
- platform/graphics/chromium/FontChromiumWin.cpp: Added. (WebCore::windowsCanHandleTextDrawing): (WebCore::skiaDrawText): (WebCore::PaintSkiaText): (WebCore::Font::drawGlyphs): (WebCore::Font::selectionRectForComplexText): (WebCore::Font::drawComplexText): (WebCore::Font::floatWidthForComplexText): (WebCore::Font::offsetForPositionForComplexText):
- 11:25 AM Changeset in webkit [39829] by
-
- 3 edits6 adds in trunk/WebCore
2009-01-12 Darin Fisher <darin@chromium.org>
Reviewed by Eric Seidel.
https://bugs.webkit.org/show_bug.cgi?id=23254
Upstream page/chromium/
- page/chromium/AXObjectCacheChromium.cpp: Added. (WebCore::AXObjectCache::detachWrapper): (WebCore::AXObjectCache::attachWrapper): (WebCore::AXObjectCache::postNotification): (WebCore::AXObjectCache::postNotificationToElement): (WebCore::AXObjectCache::handleFocusedUIElementChanged):
- page/chromium/AccessibilityObjectChromium.cpp:
- page/chromium/AccessibilityObjectWrapper.h:
- page/chromium/ChromeClientChromium.h: Added.
- page/chromium/DragControllerChromium.cpp: Added. (WebCore::DragController::dragOperation): (WebCore::DragController::isCopyKeyDown): (WebCore::DragController::maxDragImageSize): (WebCore::DragController::cleanupAfterSystemDrag):
- page/chromium/EventHandlerChromium.cpp: Added. (WebCore::EventHandler::passMousePressEventToSubframe): (WebCore::EventHandler::passMouseMoveEventToSubframe): (WebCore::EventHandler::passMouseReleaseEventToSubframe): (WebCore::EventHandler::passWheelEventToWidget): (WebCore::EventHandler::passWidgetMouseDownEventToWidget): (WebCore::EventHandler::passMouseDownEventToWidget): (WebCore::EventHandler::tabsToAllControls): (WebCore::EventHandler::eventActivatedView): (WebCore::EventHandler::createDraggingClipboard): (WebCore::EventHandler::focusDocumentView): (WebCore::EventHandler::accessKeyModifiers):
- page/chromium/FrameChromium.cpp: Added. (WebCore::computePageRectsForFrame): (WebCore::Frame::dragImageForSelection):
- page/chromium/FrameChromium.h: Added.
- 11:10 AM Changeset in webkit [39828] by
-
- 4 edits in trunk/WebCore
2008-01-12 Dimitri Glazkov <Dimitri Glazkov>
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=22936
Fix uninitialized memory read error, reported by Purify.
- platform/graphics/SimpleFontData.cpp: (WebCore::SimpleFontData::SimpleFontData): Added initializer for
m_unitsPerEm using cDefaultUnitsPerEm constant.
- svg/SVGFontFaceElement.cpp: (WebCore::SVGFontFaceElement::unitsPerEm): Replaced literal value with
the constant.
- svg/SVGFontFaceElement.h: Added cDefaultUnitsPerEm constant.
- 7:50 AM Changeset in webkit [39827] by
-
- 2 edits in trunk/WebCore
Do not set fixedLayoutSize for anything other than the mainframe during
the transition as this is a page level state like the viewportSize.
- 5:03 AM Changeset in webkit [39826] by
-
- 2 edits in trunk/WebKit/qt
2009-01-12 Tor Arne Vestbø <tavestbo@trolltech.com>
Reviewed by Simon Hausmann.
[Qt] Ensure that we're always notified of navigation actions for local anchors
FrameLoader::checkNavigationPolicy() does not notify us if the request has
been checked before (which happens for local anchors), but in the case of
our clients not accepting the navigation request we do want to be notified
again later on, so we clear the lastCheckedRequest flag.
- 4:51 AM Changeset in webkit [39825] by
-
- 2 edits in trunk/WebKit/qt
2009-01-12 Ariya Hidayat <ariya.hidayat@trolltech.com>
Rubber-stamped by Tor Arne Vestbø.
Build fix: use qobject_cast which does not rely on RTTI. This fixes the
unit test when building it with a version of Qt (e.g. Qt/Embedded)
configured without RTTI.
- tests/qwebframe/tst_qwebframe.cpp:
- 3:10 AM Changeset in webkit [39824] by
-
- 2 edits in trunk/LayoutTests
Update test results.
- fast/dom/Window/window-properties-expected.txt: Remove appcache dynamic entries methods.
- 2:46 AM Changeset in webkit [39823] by
-
- 18 edits in trunk
WebCore:
2009-01-12 Julien Chaffraix <jchaffraix@pleyo.com>
Reviewed by Darin Adler.
Bug 22861: Turn the FontCache into a singleton
https://bugs.webkit.org/show_bug.cgi?id=22861
- Added fontCache() to get the global FontCache.
- Made all the methods in FontCache instance method.
- Changed FontCache:: to fontCache()-> in WebCore.
- WebCore.base.exp: Now export fontCache().
- css/CSSFontFaceSource.cpp: (WebCore::CSSFontFaceSource::getFontData):
- css/CSSFontSelector.cpp: (WebCore::CSSFontSelector::CSSFontSelector): (WebCore::CSSFontSelector::~CSSFontSelector): (WebCore::CSSFontSelector::addFontFaceRule): (WebCore::fontDataForGenericFamily):
- platform/graphics/Font.cpp: (WebCore::Font::glyphDataForCharacter):
- platform/graphics/FontCache.cpp: (WebCore::fontCache): (WebCore::FontCache::FontCache):
- platform/graphics/FontCache.h:
- platform/graphics/FontFallbackList.cpp: (WebCore::FontFallbackList::FontFallbackList): (WebCore::FontFallbackList::invalidate): (WebCore::FontFallbackList::releaseFontData): (WebCore::FontFallbackList::fontDataAt): (WebCore::FontFallbackList::fontDataForCharacters): (WebCore::FontFallbackList::setPlatformFont):
- platform/graphics/SimpleFontData.cpp: (WebCore::SimpleFontData::~SimpleFontData):
- platform/graphics/mac/FontCacheMac.mm: (WebCore::fontCacheATSNotificationCallback):
- platform/graphics/mac/SimpleFontDataMac.mm: (WebCore::SimpleFontData::smallCapsFontData):
- platform/graphics/win/FontCacheWin.cpp: (WebCore::getCJKCodePageMasks):
- platform/graphics/win/SimpleFontDataWin.cpp: (WebCore::SimpleFontData::containsCharacters):
WebKit/mac:
2009-01-12 Julien Chaffraix <jchaffraix@pleyo.com>
Reviewed by Darin Adler.
Bug 22861: Turn the FontCache into a singleton
https://bugs.webkit.org/show_bug.cgi?id=22861
- Misc/WebCoreStatistics.mm: (+[WebCoreStatistics cachedFontDataCount]): (+[WebCoreStatistics cachedFontDataInactiveCount]): (+[WebCoreStatistics purgeInactiveFontData]): Redirected all the static calls to the global FontCache instance.
WebKit/win:
2009-01-12 Julien Chaffraix <jchaffraix@pleyo.com>
Reviewed by Darin Adler.
Bug 22861: Turn the FontCache into a singleton
https://bugs.webkit.org/show_bug.cgi?id=22861
- WebCoreStatistics.cpp: (WebCoreStatistics::cachedFontDataCount): (WebCoreStatistics::cachedFontDataInactiveCount): (WebCoreStatistics::purgeInactiveFontData): Redirected all the static calls to the global FontCache instance.
- 1:58 AM QtWebKitJournal edited by
- (diff)
- 1:41 AM Changeset in webkit [39822] by
-
- 2 edits in trunk/WebKit/qt
2009-01-12 Simon Hausmann <simon.hausmann@nokia.com>
Rubber-stamped by Tor Arne Vestbø.
When the QWebView is disabled context menus implemented in JavaScript should not pop up.
Just like in QWidget::event() we have to check for the disabled state and
ignore context menu events.
- 1:36 AM Changeset in webkit [39821] by
-
- 2 edits in trunk/WebKit/qt
2009-01-12 Simon Hausmann <simon.hausmann@nokia.com
Reviewed by Tor Arne Vestbø.
Fix QWebView appearance when showed uninitialized without page.
Only set WA_OpaquePaintEvent if we have a page set that will actually
paint the entire contents, otherwise the optimization does not apply
as we do not have a paintEvent() implementation and Qt has to fill the
view with its default background instead.
- 1:12 AM Changeset in webkit [39820] by
-
- 2 edits in trunk/WebKit/qt
2009-01-11 Ariya Hidayat <ariya.hidayat@trolltech.com>
Rubber-stamped by Tor Arne Vestbø.
Do not create a QVariant from QObject* directly, use the
template-specialized function.
- tests/qwebframe/tst_qwebframe.cpp: (MyQObject::myOverloadedSlot):
