⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Jan 14, 2009:

9:46 PM Changeset in webkit [39932] by ddkilzer@apple.com
  • 2 edits in trunk/WebCore

Bug 23338: Make "Streamline Inspector Source" build script check for a directory before using it

<​https://bugs.webkit.org/show_bug.cgi?id=23338>

Reviewed by Timothy Hatcher.

  • WebCore.xcodeproj/project.pbxproj: Check to see if "${TARGET_BUILD_DIR}/${UNLOCALIZED_RESOURCES_FOLDER_PATH}/inspector" exists before trying to change directories into it and then deleting, modifying and adding files to it.
9:40 PM Changeset in webkit [39931] by ddkilzer@apple.com
  • 4 edits in trunk/JavaScriptCore

Bug 23153: JSC build always touches JavaScriptCore/docs/bytecode.html

<​https://bugs.webkit.org/show_bug.cgi?id=23153>

Reviewed by Darin Adler.

Instead of building bytecode.html into ${SRCROOT}/docs/bytecode.html, build it
into ${BUILT_PRODUCTS_DIR}/DerivedSources/JavaScriptCore/docs/bytecode.html.

Also fixes make-bytecode-docs.pl to actually generate documentation.

  • DerivedSources.make: Changed bytecode.html to be built into local docs directory in ${BUILT_PRODUCTS_DIR}/DerivedSources/JavaScriptCore.
  • JavaScriptCore.xcodeproj/project.pbxproj: Added "/docs" to the end of the "mkdir -p" command so that the docs subdirectory is automatically created.
  • docs/make-bytecode-docs.pl: Changed BEGIN_OPCODE to DEFINE_OPCODE so that documentation is actually generated.
9:24 PM Changeset in webkit [39930] by kevino@webkit.org
  • 10 edits in trunk

Reviewed by Kevin Ollivier.

Fixing wx compilation for wx 2.9/trunk.

9:05 PM Changeset in webkit [39929] by kevino@webkit.org
  • 2 edits in trunk/WebCore

wx build fix. Adding WebKitCSSMatrix.

7:27 PM Changeset in webkit [39928] by treat@webkit.org
  • 2 edits in trunk/WebCore

Prospective build fix for Qt following r39922.

6:52 PM Changeset in webkit [39927] by ddkilzer@apple.com
  • 3 edits in trunk/LayoutTests

Updated layout test results after adding WebKitCSSMatrix (r39922)

  • fast/dom/Window/window-properties-expected.txt:
  • fast/js/global-constructors-expected.txt:
6:30 PM Changeset in webkit [39926] by Darin Adler
  • 2 edits in trunk/WebCore

2009-01-14 Darin Adler <Darin Adler>

Fix debug build.

  • bindings/js/JSWebKitCSSMatrixConstructor.cpp: (WebCore::JSWebKitCSSMatrixConstructor::JSWebKitCSSMatrixConstructor): Use ASSERT_UNUSED.
6:16 PM Changeset in webkit [39925] by pol@apple.com
  • 1 edit
    36 adds in trunk/LayoutTests

2009-01-14 Pierre-Olivier Latour <​pol@apple.com>

Added missing reference images for pixel tests (generated on iMac Intel with 10.5.5 + QT 7.5.5).

  • platform/mac/editing/pasteboard/dataTransfer-set-data-file-url-expected.checksum: Added.
  • platform/mac/editing/pasteboard/dataTransfer-set-data-file-url-expected.png: Added.
  • platform/mac/fast/events/pointer-events-2-expected.checksum: Added.
  • platform/mac/fast/events/pointer-events-2-expected.png: Added.
  • platform/mac/fast/events/pointer-events-expected.checksum: Added.
  • platform/mac/fast/events/pointer-events-expected.png: Added.
  • platform/mac/fast/media/mq-animation-expected.checksum: Added.
  • platform/mac/fast/media/mq-animation-expected.png: Added.
  • platform/mac/fast/media/mq-transform-01-expected.checksum: Added.
  • platform/mac/fast/media/mq-transform-01-expected.png: Added.
  • platform/mac/fast/media/mq-transform-02-expected.checksum: Added.
  • platform/mac/fast/media/mq-transform-02-expected.png: Added.
  • platform/mac/fast/media/mq-transform-03-expected.checksum: Added.
  • platform/mac/fast/media/mq-transform-03-expected.png: Added.
  • platform/mac/fast/media/mq-transform-04-expected.checksum: Added.
  • platform/mac/fast/media/mq-transform-04-expected.png: Added.
  • platform/mac/fast/media/mq-transition-expected.checksum: Added.
  • platform/mac/fast/media/mq-transition-expected.png: Added.
  • platform/mac/http/tests/security: Added.
  • platform/mac/http/tests/security/dataTransfer-set-data-file-url-expected.checksum: Added.
  • platform/mac/http/tests/security/dataTransfer-set-data-file-url-expected.png: Added.
  • platform/mac/http/tests/webarchive: Added.
  • platform/mac/http/tests/webarchive/test-css-url-encoding-expected.checksum: Added.
  • platform/mac/http/tests/webarchive/test-css-url-encoding-expected.png: Added.
  • platform/mac/http/tests/webarchive/test-css-url-encoding-shift-jis-expected.checksum: Added.
  • platform/mac/http/tests/webarchive/test-css-url-encoding-shift-jis-expected.png: Added.
  • platform/mac/http/tests/webarchive/test-css-url-encoding-utf-8-expected.checksum: Added.
  • platform/mac/http/tests/webarchive/test-css-url-encoding-utf-8-expected.png: Added.
  • platform/mac/http/tests/webarchive/test-preload-resources-expected.checksum: Added.
  • platform/mac/http/tests/webarchive/test-preload-resources-expected.png: Added.
  • platform/mac/media/video-zoom-expected.checksum: Added.
  • platform/mac/media/video-zoom-expected.png: Added.
  • platform/mac/webarchive/test-css-url-resources-in-stylesheets-expected.checksum: Added.
  • platform/mac/webarchive/test-css-url-resources-in-stylesheets-expected.png: Added.
  • platform/mac/webarchive/test-css-url-resources-inline-styles-expected.checksum: Added.
  • platform/mac/webarchive/test-css-url-resources-inline-styles-expected.png: Added.
6:05 PM Changeset in webkit [39924] by adele@apple.com
  • 9 edits
    4 adds in trunk

WebCore:

2009-01-14 Adele Peterson <​adele@apple.com>

Reviewed by Darin Adler.

Fix for ​https://bugs.webkit.org/show_bug.cgi?id=23335
<rdar://problem/6247650> Update <input type="search"> for RenderThemeWin

No new tests added. In the future, we need to update DumpRenderTree to be able to run with different RenderThemes and
we'll need a separate set of results for different themes.


  • css/themeWin.css: Renable search fields. Added new rules for sub-element placement.


  • rendering/RenderTextControlSingleLine.cpp: (WebCore::RenderTextControlSingleLine::textBlockWidth): Consider margin set on the sub-elements when computing the desired width for the text block.


  • rendering/RenderThemeWin.cpp: (WebCore::RenderThemeWin::supportsFocus): Treat SearchFieldPart the same as TextFieldPart. (WebCore::RenderThemeWin::determineState): ditto. (WebCore::RenderThemeWin::getClassicThemeData): ditto. (WebCore::RenderThemeWin::getThemeData): ditto. (WebCore::RenderThemeWin::paintSearchFieldCancelButton): Draw a scaled, vertically centered, version of the new artwork. (WebCore::RenderThemeWin::paintSearchFieldResultsDecoration): ditto. (WebCore::RenderThemeWin::paintSearchFieldResultsButton): ditto. (WebCore::RenderThemeWin::adjustSearchFieldCancelButtonStyle): Set the scaled width and height. (WebCore::RenderThemeWin::adjustSearchFieldResultsDecorationStyle): ditto. (WebCore::RenderThemeWin::adjustSearchFieldResultsButtonStyle): ditto.

WebKit/win:

2009-01-14 Adele Peterson <​adele@apple.com>

Reviewed by Darin Adler.

Fix for ​https://bugs.webkit.org/show_bug.cgi?id=23335
<rdar://problem/6247650> Update <input type="search"> for RenderThemeWin


Added artwork.


  • WebKit.vcproj/WebKit.rc:
  • WebKit.vcproj/WebKit.vcproj:
  • WebKit.vcproj/resource.h:
  • WebKit.vcproj/searchCancel.png: Added.
  • WebKit.vcproj/searchCancelPressed.png: Added.
  • WebKit.vcproj/searchMagnifier.png: Added.
  • WebKit.vcproj/searchMagnifierResults.png: Added.
  • WebKitDLL.cpp:(loadResourceIntoBuffer):
5:53 PM Changeset in webkit [39923] by alp@webkit.org
  • 2 edits in trunk/WebCore

2009-01-14 Alp Toker <​alp@nuanti.com>

GTK+ build fix following r39922.
Add WebKitCSSMatrix to the build system.

  • GNUmakefile.am:
5:29 PM Changeset in webkit [39922] by cmarrin@apple.com
  • 8 edits
    7 adds in trunk

Implemented 2D WebKitCSSMatrix
​https://bugs.webkit.org/show_bug.cgi?id=21421

4:55 PM Changeset in webkit [39921] by eric@webkit.org
  • 2 edits in trunk/WebCore

2009-01-14 Michael Moss <​mmoss@chromium.org>

Reviewed by Eric Seidel.

Workaround a skia limitation on repeated patterns, and remove extra
transformations applied to pattern.
​https://bugs.webkit.org/show_bug.cgi?id=23332

Fixes:
LayoutTests/fast/canvas/patternfill-repeat.html
LayoutTests/svg/W3C-SVG-1.1/pservers-grad-06-b.svg

  • platform/graphics/skia/PatternSkia.cpp: (WebCore::Pattern::createPlatformPattern):
4:31 PM Changeset in webkit [39920] by andersca@apple.com
  • 5 edits in trunk/WebKit/mac

2009-01-14 Anders Carlsson <​andersca@apple.com>

Reviewed by Sam Weinig.

Implement InvokeDefault, Construct, GetProperty and SetProperty.


Fully implement marshalValue.


  • Plugins/Hosted/NetscapePluginHostProxy.mm: (WKPCInvokeDefault): (WKPCConstruct): (WKPCGetProperty): (WKPCSetProperty):
  • Plugins/Hosted/NetscapePluginInstanceProxy.h:
  • Plugins/Hosted/NetscapePluginInstanceProxy.mm: (WebKit::NetscapePluginInstanceProxy::evaluate): (WebKit::NetscapePluginInstanceProxy::invoke): (WebKit::NetscapePluginInstanceProxy::invokeDefault): (WebKit::NetscapePluginInstanceProxy::construct): (WebKit::NetscapePluginInstanceProxy::getProperty): (WebKit::NetscapePluginInstanceProxy::setProperty): (WebKit::NetscapePluginInstanceProxy::marshalValue): (WebKit::NetscapePluginInstanceProxy::demarshalValue):
  • Plugins/Hosted/WebKitPluginClient.defs:
4:26 PM Changeset in webkit [39919] by mrowe@apple.com
  • 2 edits in trunk/WebCore

Fix ​https://bugs.webkit.org/show_bug.cgi?id=23334
Bug 23334: Compile failure in XMLTokenizerLibxml2.cpp

Include wtf/UnusedParam.h to get UNUSED_PARAM.

  • dom/XMLTokenizerLibxml2.cpp:

(WebCore::hackAroundLibXMLEntityBug):

3:50 PM Changeset in webkit [39918] by Dimitri Glazkov
  • 4 edits
    1 delete in trunk/WebCore

2009-01-14 David Levin <​levin@chromium.org>

Reviewed by Darin Adler.

​https://bugs.webkit.org/show_bug.cgi?id=23333
Platform code fixes. These compensate for changes in platform
callbacks from WebKit and minor API tweaks.

I enumerated a few below.

  • platform/graphics/chromium/FontCacheChromiumWin.cpp: fontExists has been gone since r34794.
  • platform/graphics/skia/ImageSkia.cpp: (WebCore::paintSkBitmap):

(WebCore::FrameData::clear):
r39751 changes this api to take and return a bool.

(WebCore::Image::drawPattern):

  • platform/graphics/skia/PathSkia.cpp: (WebCore::Path::apply): (WebCore::boundingBoxForCurrentStroke): (WebCore::Path::strokeContains):
  • svg/graphics/skia/RenderPathSkia.cpp: Removed due to r39805.
3:40 PM Changeset in webkit [39917] by treat@webkit.org
  • 2 edits in trunk/JavaScriptCore

Build fix for Qt from Dmitry Titov.

3:37 PM Changeset in webkit [39916] by andersca@apple.com
  • 4 edits in trunk/WebKit/mac

2009-01-14 Anders Carlsson <​andersca@apple.com>

Reviewed by Sam Weinig.

Demarshal arguments and pass them to the JS call.


  • Plugins/Hosted/NetscapePluginHostProxy.mm: (WKPCInvoke):
  • Plugins/Hosted/NetscapePluginInstanceProxy.h:
  • Plugins/Hosted/NetscapePluginInstanceProxy.mm: (WebKit::NetscapePluginInstanceProxy::invoke): (WebKit::NetscapePluginInstanceProxy::demarshalValueFromArray): (WebKit::NetscapePluginInstanceProxy::demarshalValues):
3:22 PM Changeset in webkit [39915] by Darin Adler
  • 1 edit
    1 copy
    1 move
    3 adds in trunk/LayoutTests

2009-01-14 Darin Adler <Darin Adler>

Reviewed by Beth Dakin.

Try to fix regression test failures seen on Leopard; possibly new to 10.5.6.

  • http/tests/misc/willCacheResponse-delegate-callback-expected.txt: Removed. This test has enough Mac specifics in it that I don't think it makes sense to have cross-platform results.
  • platform/mac-tiger/http/tests/misc/willCacheResponse-delegate-callback-expected.txt: Copied from http/tests/misc/willCacheResponse-delegate-callback-expected.txt.
  • platform/mac/http/tests/misc/willCacheResponse-delegate-callback-expected.txt: Copied from http/tests/misc/willCacheResponse-delegate-callback-expected.txt. Updated with non-Tiger results. The order of delegate calls has changed.
3:19 PM Changeset in webkit [39914] by ddkilzer@apple.com
  • 2 edits in trunk/WebKitTools

BUILD FIX: Use COM API on Windows in LayoutTestController::setIconDatabaseEnabled()

Rubber-stamped by Alice Liu.

  • DumpRenderTree/win/LayoutTestControllerWin.cpp: (LayoutTestController::setIconDatabaseEnabled): Use COM API to get the shared WebIconDatabase.
2:26 PM Changeset in webkit [39913] by mrowe@apple.com
  • 3 edits in trunk/WebKit/mac

<rdar://problem/6496520> REGRESSION: In Mail, a crash occurs when attempting to display a mail message

Move WebArchive and WebResource to use the same approach for initializing themselves on the main thread
that WebView uses.

Reviewed by Timothy Hatcher.

  • WebView/WebArchive.mm:

(-[WebArchive initWithMainResource:subresources:subframeArchives:]): Use _webkit_performSelectorOnMainThread:withObject:.
(-[WebArchive _initWithArguments:]):

  • WebView/WebResource.mm:

(-[WebResource _initWithArguments:]): Unbox the BOOL argument.

2:22 PM Changeset in webkit [39912] by eric@webkit.org
  • 8 edits
    2 adds in trunk

2009-01-14 Jeremy Moskovich <​jeremy@chromium.org>

Reviewed by Eric Seidel.

<​https://bugs.webkit.org/show_bug.cgi?id=16829>
Implement NPN_SetException()

This mirrors the implementation in the obj-c bindings.

Test: plugins/netscape-throw-exception.html

  • bridge/NP_jsobject.cpp: (_NPN_SetException):
  • bridge/c/c_instance.cpp: (JSC::Bindings::getExceptionString): (JSC::Bindings::CInstance::setGlobalException): (JSC::Bindings::CInstance::moveGlobalExceptionToExecState): (JSC::Bindings::CInstance::invokeMethod): (JSC::Bindings::CInstance::invokeDefaultMethod): (JSC::Bindings::CInstance::invokeConstruct): (JSC::Bindings::CInstance::getPropertyNames):
  • bridge/c/c_instance.h:
2:18 PM Changeset in webkit [39911] by ddkilzer@apple.com
  • 1 edit
    1 move in trunk/LayoutTests

Disabling webarchive/test-link-rel-icon.html due to various buildbot failures

Bug 23331: LayoutTests/webarchive/test-link-rel-icon.html fails in different ways on buildbots
<​https://bugs.webkit.org/show_bug.cgi?id=23331>

  • webarchive/test-link-rel-icon.html: Removed.
  • webarchive/test-link-rel-icon.html-disabled: Renamed from LayoutTests/webarchive/test-link-rel-icon.html.
2:14 PM Changeset in webkit [39910] by oliver@apple.com
  • 7 edits
    3 adds in trunk

Bug 22903: REGRESSION (r36267): visiting this site reliably crashes WebKit nightly

Reviewed by Cameron Zwarich

EvalCodeBlock's do not reference the functions that are declared inside the eval
code, this means that simply marking the EvalCodeBlock through the global object
is insufficient to mark the declared functions. This patch corrects this by
explicitly marking the CodeBlocks of all the functions declared in the cached
EvalNode.

1:58 PM Changeset in webkit [39909] by pol@apple.com
  • 2 edits in trunk/WebCore

2009-01-14 Pierre-Olivier Latour <​pol@apple.com>

Fixed build warning when LIBXML_VERSION >= 20627.

  • dom/XMLTokenizerLibxml2.cpp: (WebCore::hackAroundLibXMLEntityBug):
1:57 PM Changeset in webkit [39908] by ap@webkit.org
  • 8 edits in trunk/JavaScriptCore

2009-01-14 Dmitry Titov <​dimich@chromium.org>

Reviewed by Alexey Proskuryakov.

​https://bugs.webkit.org/show_bug.cgi?id=23312
Implement MessageQueue::waitForMessageTimed()
Also fixed ThreadCondition::timedWait() to take absolute time, as discussed on webkit-dev.
Win32 version of timedWait still has to be implemented.

  • wtf/MessageQueue.h: (WTF::MessageQueueWaitResult: new enum for the result of MessageQueue::waitForMessageTimed. (WTF::MessageQueue::waitForMessage): (WTF::MessageQueue::waitForMessageTimed): New method.
  • wtf/Threading.h:
  • wtf/ThreadingGtk.cpp: (WTF::ThreadCondition::timedWait): changed to use absolute time instead of interval.
  • wtf/ThreadingNone.cpp: (WTF::ThreadCondition::timedWait): ditto.
  • wtf/ThreadingPthreads.cpp: (WTF::ThreadCondition::timedWait): ditto.
  • wtf/ThreadingQt.cpp: (WTF::ThreadCondition::timedWait): ditto.
  • wtf/ThreadingWin.cpp: (WTF::ThreadCondition::timedWait): ditto. The actual Win32 code is still to be implemented.
1:48 PM Changeset in webkit [39907] by ddkilzer@apple.com
  • 2 edits in trunk/WebKitTools

2009-01-13 Dmitry Titov <​dimich@chromium.org>

Reviewed by David Kilzer.

​https://bugs.webkit.org/show_bug.cgi?id=23304
Fix svn-apply to match svn-unapply to recognize added files in 'git diff' patches.

  • Scripts/svn-apply: Added a check (similar to svn-unapply) to recognize added files.
1:24 PM Changeset in webkit [39906] by ddkilzer@apple.com
  • 3 edits in trunk/WebKitTools

BUILD FIX: Implement LayoutTestController::setIconDatabaseEnabled(bool) for GTK

  • DumpRenderTree/gtk/DumpRenderTree.cpp: (runTest): Added call to reset the icon database to match Mac and Windows ports.
  • DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: (LayoutTestController::setIconDatabaseEnabled): Implemented stub method.
1:13 PM Changeset in webkit [39905] by ap@webkit.org
  • 2 edits in trunk/WebCore

Reviewed by Anders Carlsson.

​https://bugs.webkit.org/show_bug.cgi?id=23326
Resources are never deleted from application cache disk database

  • loader/appcache/ApplicationCacheStorage.cpp: (WebCore::ApplicationCacheStorage::openDatabase): Create a trigger that deletes resources when a cache is deleted. Note that this change doesn't require bumping schema version. We should consider switching to foreign keys and cascade delete instead of triggers in the future. (WebCore::ApplicationCacheStorage::remove): Added a comment explaining why it's sufficient to only remove the cache itself. (WebCore::ApplicationCacheStorage::empty): Don't delete from CacheResources, now that this is done automatically when a cache is deleted.
1:08 PM Changeset in webkit [39904] by ddkilzer@apple.com
  • 12 edits
    3 adds in trunk

Bug 22795: favicons should be saved to webarchives

<​https://bugs.webkit.org/show_bug.cgi?id=22795>

Reviewed by Darin Adler.

WebCore:

Test: webarchive/test-link-rel-icon.html

  • html/HTMLLinkElement.cpp: (WebCore::HTMLLinkElement::addSubresourceAttributeURLs): Do not add favicon URLs to the list since no ArchiveResource or CachedResource is ever created for them.
  • loader/archive/cf/LegacyWebArchive.cpp: (WebCore::LegacyWebArchive::create): Handle favicons as a special case for all main resources.
  • loader/icon/IconDatabase.cpp: (WebCore::IconDatabase::close): Actually close the SQLite database so that isOpen() returns false when called. Added an ASSERT() for good measure.

WebKitTools:

  • DumpRenderTree/LayoutTestController.cpp: (setIconDatabaseEnabledCallback): Added. (setJavaScriptProfilingEnabledCallback): Realphabetized. (LayoutTestController::staticFunctions): Added entry for calling LayoutTestController.setIconDatabaseEnabled(bool) from JavaScript.
  • DumpRenderTree/LayoutTestController.h: (setIconDatabaseEnabledCallback): Added declaration. (setJavaScriptProfilingEnabledCallback): Realphabetized.
  • DumpRenderTree/mac/DumpRenderTree.mm: (runTest): Disable the icon database before each test.
  • DumpRenderTree/mac/LayoutTestControllerMac.mm: (LayoutTestController::setIconDatabaseEnabled): Added. (LayoutTestController::setJavaScriptProfilingEnabled): Realphabetized.
  • DumpRenderTree/win/DumpRenderTree.cpp: (runTest): Disable the icon database before each test.
  • DumpRenderTree/win/LayoutTestControllerWin.cpp: (LayoutTestController::setIconDatabaseEnabled): Added.

LayoutTests:

Note that this test case contains a workaround for Bug 21026 and
<rdar://problem/6240826> which may be removed once that is fixed.

  • webarchive/resources/favicon.ico: Copied from LayoutTests/fast/images/resources/favicon.ico.
  • webarchive/test-link-rel-icon-expected.webarchive: Added.
  • webarchive/test-link-rel-icon.html: Added.
11:52 AM Changeset in webkit [39903] by darin@chromium.org
  • 8 edits
    24 adds in trunk/WebCore

2009-01-14 Darin Fisher <​darin@chromium.org>

Reviewed by Eric Seidel.

​https://bugs.webkit.org/show_bug.cgi?id=23328
Upstream remaining files from platform/chromium/

  • platform/chromium/CursorChromium.cpp: (WebCore::pointerCursor): (WebCore::crossCursor): (WebCore::handCursor): (WebCore::iBeamCursor): (WebCore::waitCursor): (WebCore::helpCursor): (WebCore::eastResizeCursor): (WebCore::northResizeCursor): (WebCore::northEastResizeCursor): (WebCore::northWestResizeCursor): (WebCore::southResizeCursor): (WebCore::southEastResizeCursor): (WebCore::southWestResizeCursor): (WebCore::westResizeCursor): (WebCore::northSouthResizeCursor): (WebCore::eastWestResizeCursor): (WebCore::northEastSouthWestResizeCursor): (WebCore::northWestSouthEastResizeCursor): (WebCore::columnResizeCursor): (WebCore::rowResizeCursor): (WebCore::middlePanningCursor): (WebCore::eastPanningCursor): (WebCore::northPanningCursor): (WebCore::northEastPanningCursor): (WebCore::northWestPanningCursor): (WebCore::southPanningCursor): (WebCore::southEastPanningCursor): (WebCore::southWestPanningCursor): (WebCore::westPanningCursor): (WebCore::moveCursor): (WebCore::verticalTextCursor): (WebCore::cellCursor): (WebCore::contextMenuCursor): (WebCore::aliasCursor): (WebCore::progressCursor): (WebCore::noDropCursor): (WebCore::copyCursor): (WebCore::noneCursor): (WebCore::notAllowedCursor): (WebCore::zoomInCursor): (WebCore::zoomOutCursor):
  • platform/chromium/DragDataRef.h: Added.
  • platform/chromium/DragImageChromium.cpp: Added. (WebCore::dragImageSize): (WebCore::deleteDragImage): (WebCore::scaleDragImage): (WebCore::dissolveDragImageToFraction): (WebCore::createDragImageFromImage): (WebCore::createDragImageIconForCachedImage):
  • platform/chromium/DragImageRef.h:
  • platform/chromium/KeyCodeConversion.h: Added.
  • platform/chromium/KeyCodeConversionGtk.cpp: Added. (WebCore::windowsKeyCodeForKeyEvent):
  • platform/chromium/KeyboardCodes.h: Added.
  • platform/chromium/KeyboardCodesPosix.h: Added. (WebCore::):
  • platform/chromium/KeyboardCodesWin.h: Added. (WebCore::):
  • platform/chromium/Language.cpp: Added. (WebCore::defaultLanguage):
  • platform/chromium/LinkHashChromium.cpp: Added. (WebCore::visitedLinkHash):
  • platform/chromium/MimeTypeRegistryChromium.cpp: Added. (WebCore::MIMETypeRegistry::getMIMETypeForExtension): (WebCore::MIMETypeRegistry::getPreferredExtensionForMIMEType): (WebCore::MIMETypeRegistry::getMIMETypeForPath): (WebCore::MIMETypeRegistry::isSupportedImageMIMEType): (WebCore::MIMETypeRegistry::isSupportedImageResourceMIMEType): (WebCore::MIMETypeRegistry::isSupportedImageMIMETypeForEncoding): (WebCore::MIMETypeRegistry::isSupportedJavaScriptMIMEType): (WebCore::MIMETypeRegistry::isSupportedNonImageMIMEType): (WebCore::MIMETypeRegistry::isSupportedMediaMIMEType): (WebCore::MIMETypeRegistry::isJavaAppletMIMEType): (WebCore::dummyHashSet): (WebCore::MIMETypeRegistry::getSupportedImageMIMETypes): (WebCore::MIMETypeRegistry::getSupportedImageResourceMIMETypes): (WebCore::MIMETypeRegistry::getSupportedImageMIMETypesForEncoding): (WebCore::MIMETypeRegistry::getSupportedNonImageMIMETypes): (WebCore::MIMETypeRegistry::getSupportedMediaMIMETypes):
  • platform/chromium/PasteboardChromium.cpp: Added. (WebCore::Pasteboard::generalPasteboard): (WebCore::Pasteboard::Pasteboard): (WebCore::Pasteboard::clear): (WebCore::Pasteboard::writeSelection): (WebCore::Pasteboard::writeURL): (WebCore::Pasteboard::writeImage): (WebCore::Pasteboard::canSmartReplace): (WebCore::Pasteboard::plainText): (WebCore::Pasteboard::documentFragment):
  • platform/chromium/PasteboardPrivate.h:
  • platform/chromium/PlatformCursor.h: Added. (WebCore::PlatformCursor::): (WebCore::PlatformCursor::PlatformCursor): (WebCore::PlatformCursor::customImage): (WebCore::PlatformCursor::hotSpot): (WebCore::PlatformCursor::type):
  • platform/chromium/PlatformKeyboardEventChromium.cpp: Added. (WebCore::PlatformKeyboardEvent::disambiguateKeyDownEvent): (WebCore::PlatformKeyboardEvent::currentCapsLockState):
  • platform/chromium/PlatformScreenChromium.cpp: Added. (WebCore::screenDepth): (WebCore::screenDepthPerComponent): (WebCore::screenIsMonochrome): (WebCore::screenRect): (WebCore::screenAvailableRect):
  • platform/chromium/PlatformWidget.h:
  • platform/chromium/PopupMenuChromium.cpp: Added. (WebCore::PopupListBox::selectedIndex): (WebCore::PopupListBox::numItems): (WebCore::PopupListBox::setBaseWidth): (WebCore::PopupListBox::setTextOnIndexChange): (WebCore::PopupListBox::setAcceptOnAbandon): (WebCore::PopupListBox::): (WebCore::PopupListBox::ListItem::ListItem): (WebCore::PopupListBox::PopupListBox): (WebCore::PopupListBox::~PopupListBox): (WebCore::PopupListBox::disconnectClient): (WebCore::PopupListBox::scrollToRevealSelection): (WebCore::constructRelativeMouseEvent): (WebCore::constructRelativeWheelEvent): (WebCore::PopupContainer::create): (WebCore::PopupContainer::PopupContainer): (WebCore::PopupContainer::~PopupContainer): (WebCore::PopupContainer::showPopup): (WebCore::PopupContainer::hidePopup): (WebCore::PopupContainer::layout): (WebCore::PopupContainer::handleMouseDownEvent): (WebCore::PopupContainer::handleMouseMoveEvent): (WebCore::PopupContainer::handleMouseReleaseEvent): (WebCore::PopupContainer::handleWheelEvent): (WebCore::PopupContainer::handleKeyEvent): (WebCore::PopupContainer::hide): (WebCore::PopupContainer::paint): (WebCore::PopupContainer::paintBorder): (WebCore::PopupContainer::isInterestedInEventForKey): (WebCore::PopupContainer::show): (WebCore::PopupContainer::setTextOnIndexChange): (WebCore::PopupContainer::setAcceptOnAbandon): (WebCore::PopupContainer::refresh): (WebCore::PopupListBox::handleMouseDownEvent): (WebCore::PopupListBox::handleMouseMoveEvent): (WebCore::PopupListBox::handleMouseReleaseEvent): (WebCore::PopupListBox::handleWheelEvent): (WebCore::PopupListBox::isInterestedInEventForKey): (WebCore::PopupListBox::handleKeyEvent): (WebCore::PopupListBox::hostWindow): (WebCore::PopupListBox::invalidateRect): (WebCore::stripLeadingWhiteSpace): (WebCore::PopupListBox::typeAheadFind): (WebCore::PopupListBox::paint): (WebCore::PopupListBox::paintRow): (WebCore::PopupListBox::getRowFont): (WebCore::PopupListBox::abandon): (WebCore::PopupListBox::pointToRowIndex): (WebCore::PopupListBox::acceptIndex): (WebCore::PopupListBox::selectIndex): (WebCore::PopupListBox::setOriginalIndex): (WebCore::PopupListBox::getRowHeight): (WebCore::PopupListBox::getRowBounds): (WebCore::PopupListBox::invalidateRow): (WebCore::PopupListBox::scrollToRevealRow): (WebCore::PopupListBox::isSelectableItem): (WebCore::PopupListBox::adjustSelectedIndex): (WebCore::PopupListBox::updateFromElement): (WebCore::PopupListBox::layout): (WebCore::PopupListBox::clear): (WebCore::PopupListBox::isPointInBounds): (WebCore::PopupMenu::PopupMenu): (WebCore::PopupMenu::~PopupMenu): (WebCore::PopupMenu::show): (WebCore::PopupMenu::hide): (WebCore::PopupMenu::updateFromElement): (WebCore::PopupMenu::itemWritingDirectionIsNatural):
  • platform/chromium/PopupMenuChromium.h: Added. (WebCore::PopupContainer::listBox):
  • platform/chromium/PopupMenuPrivate.h: Added.
  • platform/chromium/SSLKeyGeneratorChromium.cpp: Added. (WebCore::supportedKeySizes):
  • platform/chromium/ScrollbarThemeChromium.cpp: Added. (WebCore::ScrollbarTheme::nativeTheme): (WebCore::ScrollbarThemeChromium::ScrollbarThemeChromium): (WebCore::ScrollbarThemeChromium::~ScrollbarThemeChromium): (WebCore::ScrollbarThemeChromium::themeChanged): (WebCore::ScrollbarThemeChromium::hasThumb): (WebCore::ScrollbarThemeChromium::backButtonRect): (WebCore::ScrollbarThemeChromium::forwardButtonRect): (WebCore::ScrollbarThemeChromium::trackRect): (WebCore::ScrollbarThemeChromium::paintTrackBackground): (WebCore::ScrollbarThemeChromium::paintTickmarks): (WebCore::ScrollbarThemeChromium::paintScrollCorner): (WebCore::ScrollbarThemeChromium::shouldCenterOnThumb): (WebCore::ScrollbarThemeChromium::buttonSize):
  • platform/chromium/ScrollbarThemeChromium.h: Added. (WebCore::ScrollbarThemeChromium::hasButtons):
  • platform/chromium/ScrollbarThemeChromiumLinux.cpp: Added. (WebCore::ScrollbarThemeChromium::scrollbarThickness): (WebCore::ScrollbarThemeChromium::invalidateOnMouseEnterExit): (WebCore::initMozState): (WebCore::paintScrollbarWidget): (WebCore::ScrollbarThemeChromium::paintTrackPiece): (WebCore::ScrollbarThemeChromium::paintButton): (WebCore::ScrollbarThemeChromium::paintThumb):
  • platform/chromium/ScrollbarThemeChromiumWin.cpp:
  • platform/chromium/SearchPopupMenuChromium.cpp: Added. (WebCore::SearchPopupMenu::SearchPopupMenu): (WebCore::SearchPopupMenu::enabled): (WebCore::SearchPopupMenu::saveRecentSearches): (WebCore::SearchPopupMenu::loadRecentSearches):
  • platform/chromium/SharedTimerChromium.cpp: Added. (WebCore::setSharedTimerFiredFunction): (WebCore::setSharedTimerFireTime): (WebCore::stopSharedTimer):
  • platform/chromium/TemporaryLinkStubs.cpp: Added. (WebCore::signedPublicKeyAndChallengeString): (WebCore::getSupportedKeySizes): (WebCore::KURL::fileSystemPath): (WebCore::SharedBuffer::createWithContentsOfFile): (WTF::scheduleDispatchFunctionsOnMainThread):
11:40 AM Changeset in webkit [39902] by Dimitri Glazkov
  • 1 edit
    6 adds in trunk/WebCore

2009-01-14 Dimitri Glazkov <Dimitri Glazkov>

Reviewed by Eric Seidel.

​https://bugs.webkit.org/show_bug.cgi?id=23321
Upstream more bits of graphics/chromium.

  • platform/graphics/chromium/FontPlatformDataChromiumWin.cpp: Added. (WebCore::FontPlatformData::FontPlatformData): (WebCore::FontPlatformData::operator=): (WebCore::FontPlatformData::~FontPlatformData): (WebCore::FontPlatformData::RefCountedHFONT::~RefCountedHFONT): (WebCore::FontPlatformData::hashTableDeletedFontValue): (WebCore::FontPlatformData::scriptFontProperties):
  • platform/graphics/chromium/FontPlatformDataChromiumWin.h: Added. (WebCore::FontPlatformData::isHashTableDeletedValue): (WebCore::FontPlatformData::hfont): (WebCore::FontPlatformData::size): (WebCore::FontPlatformData::hash): (WebCore::FontPlatformData::operator==): (WebCore::FontPlatformData::scriptCache): (WebCore::FontPlatformData::RefCountedHFONT::create): (WebCore::FontPlatformData::RefCountedHFONT::hfont): (WebCore::FontPlatformData::RefCountedHFONT::hash): (WebCore::FontPlatformData::RefCountedHFONT::operator==): (WebCore::FontPlatformData::RefCountedHFONT::RefCountedHFONT):
  • platform/graphics/chromium/FontPlatformDataLinux.cpp: Added. (WebCore::FontPlatformData::FontPlatformData): (WebCore::FontPlatformData::~FontPlatformData): (WebCore::FontPlatformData::operator=): (WebCore::FontPlatformData::setupPaint): (WebCore::FontPlatformData::operator==): (WebCore::FontPlatformData::hash): (WebCore::FontPlatformData::isFixedPitch):
  • platform/graphics/chromium/FontPlatformDataLinux.h: Added. (WebCore::FontPlatformData::FontPlatformData): (WebCore::FontPlatformData::size): (WebCore::FontPlatformData::isHashTableDeletedValue): (WebCore::FontPlatformData::hashTableDeletedFontValue):
  • platform/graphics/chromium/FontUtilsChromiumWin.cpp: Added. (WebCore::): (WebCore::FontMap::getAscent): (WebCore::FontMap::FontData::FontData): (WebCore::getFontFamilyForScript): (WebCore::getFallbackFamily): (WebCore::getDerivedFontData): (WebCore::getStyleFromLogfont):
  • platform/graphics/chromium/FontUtilsChromiumWin.h: Added. (WebCore::):
11:37 AM Changeset in webkit [39901] by Darin Adler
  • 2 edits in trunk/WebKit/mac

2009-01-14 Darin Adler <Darin Adler>

Reviewed by Oliver Hunt.

Fix crash I ran into while printing. I was unable to reproduce it, but also,
it's clear there's no guarantee that the frame will be non-zero in this case,
so it seems fine to check it.

  • WebView/WebHTMLView.mm: (-[WebHTMLView reapplyStyles]): Check frame for zero and don't do anything with it if it's zero.
11:25 AM Changeset in webkit [39900] by Dimitri Glazkov
  • 1 edit in trunk/WebCore/ChangeLog

Remove errant WARNING from WebCore/ChangeLog.

11:23 AM Changeset in webkit [39899] by Dimitri Glazkov
  • 1 edit
    9 adds in trunk/WebCore

2009-01-14 Dimitri Glazkov <Dimitri Glazkov>

Reviewed by Eric Seidel.

​https://bugs.webkit.org/show_bug.cgi?id=23325
Upstream even more graphics/chromium bits.

WARNING: NO TEST CASES ADDED OR CHANGED

  • platform/graphics/chromium/GlyphPageTreeNodeChromiumWin.cpp: Added. (WebCore::fillEmptyGlyphs): (WebCore::initSpaceGlyph): (WebCore::fillBMPGlyphs): (WebCore::fillNonBMPGlyphs): (WebCore::GlyphPage::fill):
  • platform/graphics/chromium/GlyphPageTreeNodeLinux.cpp: Added. (WebCore::GlyphPage::fill):
  • platform/graphics/chromium/IconChromiumLinux.cpp: Added. (WebCore::Icon::Icon): (WebCore::Icon::~Icon): (WebCore::Icon::createIconForFile): (WebCore::Icon::createIconForFiles): (WebCore::Icon::paint):
  • platform/graphics/chromium/IconChromiumMac.cpp: Added. (WebCore::Icon::createIconForFile): (WebCore::Icon::createIconForFiles): (WebCore::Icon::~Icon): (WebCore::Icon::paint):
  • platform/graphics/chromium/IconChromiumWin.cpp: Added. (WebCore::Icon::Icon): (WebCore::Icon::~Icon): (WebCore::Icon::createIconForFile): (WebCore::Icon::createIconForFiles): (WebCore::Icon::paint):
  • platform/graphics/chromium/ImageBufferData.h: Added.
  • platform/graphics/chromium/ImageChromiumMac.mm: Added. (WebCore::Image::loadPlatformResource): (WebCore::BitmapImage::initPlatformData): (WebCore::BitmapImage::invalidatePlatformData):
  • platform/graphics/chromium/MediaPlayerPrivateChromium.h: Added.
  • platform/graphics/chromium/PlatformIcon.h: Added.
11:11 AM Changeset in webkit [39898] by darin@chromium.org
  • 1 edit
    2 adds in trunk/WebCore

2009-01-14 Darin Fisher <​darin@chromium.org>

Reviewed by Eric Seidel.

​https://bugs.webkit.org/show_bug.cgi?id=23323
Upstream platform/text/chromium/

  • platform/text/chromium: Added.
  • platform/text/chromium/TextBreakIteratorInternalICUChromium.cpp: Added. (WebCore::currentTextBreakLocaleID):
11:07 AM Changeset in webkit [39897] by oliver@apple.com
  • 2 edits in trunk/JavaScriptCore

2009-01-14 Dean McNamee <​deanm@chromium.org>

Reviewed by Darin Adler and Oliver hunt.

Correctly match allocation functions by implementing a custom deref().

​https://bugs.webkit.org/show_bug.cgi?id=23315

  • runtime/ByteArray.h: (JSC::ByteArray::deref): (JSC::ByteArray::ByteArray):
11:02 AM Changeset in webkit [39896] by darin@chromium.org
  • 1 edit
    1 move
    1 add in trunk/WebCore

2009-01-14 Darin Fisher <​darin@chromium.org>

Reviewed by Darin Adler.

​https://bugs.webkit.org/show_bug.cgi?id=23324
Move platform/chromium/EditorChromium.cpp into editing/chromium/

  • editing/chromium: Added.
  • editing/chromium/EditorChromium.cpp: Copied from platform/chromium/EditorChromium.cpp.
  • platform/chromium/EditorChromium.cpp: Removed.
10:56 AM Changeset in webkit [39895] by sfalken@apple.com
  • 4 edits in trunk

Update copyright year in version resources.

10:34 AM Changeset in webkit [39894] by darin@chromium.org
  • 2 edits in trunk/WebCore

2009-01-14 Darin Fisher <​darin@chromium.org>

Reviewed by Darin Adler.

​https://bugs.webkit.org/show_bug.cgi?id=23320
Make it possible to use notImplemented outside of the WebCore namespace

  • platform/NotImplemented.h:
10:23 AM Changeset in webkit [39893] by Darin Adler
  • 3 edits
    4 adds in trunk

WebCore:

2009-01-14 Nigel Tao <​nigel.tao.gnome@gmail.com>

Reviewed by Darin Adler.

Tests: http/tests/security/dataTransfer-set-data-file-url.html

platform/mac/editing/pasteboard/dataTransfer-set-data-file-url.html

  • platform/mac/ClipboardMac.mm: (WebCore::ClipboardMac::setData):

LayoutTests:

2009-01-14 Nigel Tao <​nigel.tao.gnome@gmail.com>

Reviewed by Darin Adler.

  • http/tests/security/dataTransfer-set-data-file-url-expected.txt: Added.
  • http/tests/security/dataTransfer-set-data-file-url.html: Added.
  • platform/mac/editing/pasteboard/dataTransfer-set-data-file-url-expected.txt: Added.
  • platform/mac/editing/pasteboard/dataTransfer-set-data-file-url.html: Added.
10:18 AM Changeset in webkit [39892] by mitz@apple.com
  • 14 edits in trunk

JavaScriptCore:

Reviewed by John Sullivan.

  • update copyright
  • Info.plist:

JavaScriptGlue:

Reviewed by John Sullivan.

  • update copyright
  • Info.plist:

WebCore:

Reviewed by John Sullivan.

  • update copyright
  • Info.plist:

WebKit/mac:

Reviewed by John Sullivan.

  • update copyright
  • Info.plist:

WebKit/win:

Reviewed by John Sullivan.

  • update copyright
  • WebKit.resources/Info.plist:
  • WebKit.vcproj/WebKit.rc:

WebKitTools:

Reviewed by John Sullivan.

  • update copyright
  • DumpRenderTree/TestNetscapePlugIn.subproj/Info.plist:
  • WebKitLauncher/Info.plist:
9:58 AM Changeset in webkit [39891] by ap@webkit.org
  • 3 edits
    3 adds in trunk

Reviewed by Darin Adler.

​https://bugs.webkit.org/show_bug.cgi?id=23316
Application cache updating always fails with an assertion

Test: http/tests/appcache/update-cache.html

  • loader/appcache/ApplicationCacheGroup.cpp: (WebCore::ApplicationCacheGroup::documentLoaderDestroyed): Correctly handle the case where multiple caches survive the last DocumentLoader destruction, preventing a crash in release builds. (WebCore::ApplicationCacheGroup::setNewestCache): Removed a bogus assertion.
9:19 AM Changeset in webkit [39890] by ap@webkit.org
  • 4 edits in trunk/LayoutTests

Reviewed by Darin Adler.

​https://bugs.webkit.org/show_bug.cgi?id=23313
appcache/offline-access.html fails frequently

  • http/tests/appcache/resources/offline-access-frame.html: Make sure that the test runs, even if the cache update finishes before we install event listeners.
  • http/tests/appcache/offline-access-expected.txt:
  • http/tests/appcache/offline-access.html: Don't dump frame content, as it is timing dependent.
5:56 AM Changeset in webkit [39889] by ariya@webkit.org
  • 2 edits in trunk/WebKit/qt

2009-01-14 Ariya Hidayat <​ariya.hidayat@trolltech.com>

Reviewed by Tor Arne Vestbø.

[Qt] Unit tests for text selection and editing actions of QWebPage.
The following are tested:

  • the actions are not NULL
  • the actions are disabled when contentEditable is false
  • the actions are enabled when contentEditable is true
5:48 AM Changeset in webkit [39888] by Simon Hausmann
  • 2 edits in trunk/WebKit/qt

2009-01-14 Simon Hausmann <​simon.hausmann@nokia.com>

Reviewed by Tor Arne Vestbø.

Fix failing assertion when pressing an extra mouse button on a
QWebView.

Mice with more than three buttons - for example with a dedicated
"back" button - can generate Qt::XButton1 or Button2.
WebCore::MouseButton contains only Left, Middle and Right, so in
Qt's PlatformMouseEvent we map to NoButton, resulting in a mouse
press or release even with no button set. That triggers an assertion
in EventTargetNode::dispatchMouseEvent requiring that either a button
is set or it is just a mouse move event, which is correct.

In QWebPage decide not to dispatch such mouse events where we cannot
map the mouse button to a WebCore::MouseButton.

5:34 AM Changeset in webkit [39887] by ariya@webkit.org
  • 2 edits in trunk/WebKit/qt

2009-01-14 Ariya Hidayat <​ariya.hidayat@trolltech.com>

Reviewed by Simon Hausmann.

​http://www.qtsoftware.com/developer/task-tracker/index_html?id=241144&method=entry

[Qt] Create actions for text selection and editing for QWebPage.
Also properly disable and enable them when contentEditable is toggled.

  • Api/qwebpage.cpp: (QWebPagePrivate::updateAction): (QWebPagePrivate::updateEditorActions): (QWebPage::action):
4:39 AM Changeset in webkit [39886] by ariya@webkit.org
  • 2 edits in trunk/WebKit/qt

2009-01-14 Ariya Hidayat <​ariya.hidayat@trolltech.com>

Reviewed by Simon Hausmann.

[Qt] Unit tests for cursor movements. The following are tested:

  • the actions are not NULL
  • the actions are disabled when contentEditable is false
  • the actions are enabled when contentEditable is true
  • the cursor moves properly when the actions are triggered
  • tests/qwebpage/tst_qwebpage.cpp: (CursorTrackedPage::CursorTrackedPage): (CursorTrackedPage::selectedText): (CursorTrackedPage::selectionStartOffset): (CursorTrackedPage::selectionEndOffset): (CursorTrackedPage::isSelectionCollapsed): (tst_QWebPage::cursorMovements):
1:02 AM Changeset in webkit [39885] by ap@webkit.org
  • 2 edits in trunk/WebCore

Release build fix.

  • loader/appcache/ApplicationCacheStorage.cpp: (WebCore::ApplicationCacheStorage::storeUpdatedType): Use ASSERT_UNUSED.

Jan 13, 2009:

11:17 PM Changeset in webkit [39884] by ap@webkit.org
  • 7 edits
    5 adds in trunk

Reviewed by Anders Carlsson.

Test: http/tests/appcache/xhr-foreign-resource.html

​https://bugs.webkit.org/show_bug.cgi?id=23256
Implement application cache foreign entries

  • loader/DocumentLoader.cpp: (WebCore::DocumentLoader::shouldLoadResourceFromApplicationCache): Removed a misplaced check for foreign resources that prevented them from being loaded altogether.
  • loader/appcache/ApplicationCacheGroup.cpp: (WebCore::ApplicationCacheGroup::selectCache): If a document that was loaded from appcache should be associated with a different cache, mark the resource as foreign in the original cache and start over.
  • loader/appcache/ApplicationCacheResource.cpp: (WebCore::ApplicationCacheResource::addType): This function can now be called after a cache is stored, so it no longer asserts the opposite.
  • loader/appcache/ApplicationCacheStorage.cpp: (WebCore::ApplicationCacheStorage::cacheGroupForURL): Fix database pass to correctly ignore in-memory caches that were already rejected. (WebCore::ApplicationCacheStorage::fallbackCacheGroupForURL): Ditto. (WebCore::ApplicationCacheStorage::storeUpdatedType): Added a function that updates type of an already stored cached resource.
  • loader/appcache/ApplicationCacheStorage.h: Added storeUpdatedType().
11:14 PM Changeset in webkit [39883] by ap@webkit.org
  • 1 edit
    7 adds in trunk/LayoutTests

Reviewed by Darin Adler.

​https://bugs.webkit.org/show_bug.cgi?id=23286
Add a test for non-ASCII URIs in application cache

  • http/tests/appcache/cyrillic-uri-expected.txt: Added.
  • http/tests/appcache/cyrillic-uri.html: Added.
  • http/tests/appcache/resources/cyrillic-uri-form.html: Added.
  • http/tests/appcache/resources/cyrillic-uri.manifest: Added.
  • http/tests/appcache/resources/intercept: Added.
  • http/tests/appcache/resources/intercept/.htaccess: Added.
  • http/tests/appcache/resources/print-uri.php: Added.
5:44 PM Changeset in webkit [39882] by Beth Dakin
  • 5 edits in trunk

JavaScriptCore:

2009-01-13 Beth Dakin <Beth Dakin>

Reviewed by Darin Adler and Oliver Hunt.

<rdar://problem/6489314> REGRESSION: Business widget's front side
fails to render correctly when flipping widget

The problem here is that parseInt was parsing NaN as 0. This patch
corrects that by parsing NaN as NaN. This matches our old behavior
and Firefox.

  • runtime/JSGlobalObjectFunctions.cpp: (JSC::globalFuncParseInt):

LayoutTests:

2009-01-13 Beth Dakin <Beth Dakin>

Reviewed by Darin Adler and Oliver Hunt.

Updated test and results for <rdar://problem/6489314> REGRESSION:
Business widget's front side fails to render correctly when
flipping widget

parseInt(NaN) should be NaN.

  • fast/js/numeric-conversion-expected.txt:
  • fast/js/resources/numeric-conversion.js:
5:24 PM Changeset in webkit [39881] by mrowe@apple.com
  • 6 edits in trunk/WebCore

Fix the Tiger WebCore build after r39880.

  • editing/Editor.cpp:

(WebCore::Editor::markBadGrammar):

  • loader/mac/DocumentLoaderMac.cpp:

(WebCore::DocumentLoader::schedule):
(WebCore::DocumentLoader::unschedule):

  • platform/mac/PasteboardMac.mm:

(WebCore::Pasteboard::writeSelection):

  • platform/mac/WebCoreObjCExtras.mm:

(WebCoreObjCFinalizeOnMainThread):

  • platform/network/mac/ResourceHandleMac.mm:

(WebCore::ResourceHandle::schedule):
(WebCore::ResourceHandle::unschedule):

4:16 PM Changeset in webkit [39880] by Darin Adler
  • 17 edits in trunk/WebCore

2009-01-13 Darin Adler <Darin Adler>

Reviewed by Sam Weinig.

Bug 23102: turn on unused parameter warnings in WebCore
​https://bugs.webkit.org/show_bug.cgi?id=23102

Last step: Turn on the warning and fix the last few instances.

  • Configurations/Base.xcconfig: Removed -Wno-unused-parameter from WARNING_CFLAGS_BASE, so the unused parameter warning will fire.
  • bindings/js/JSDOMWindowBase.cpp: (jsDOMWindowBaseMessageChannel): Separate the version for use when CHANNEL_MESSAGING is turned off, so we can omit the argument names. It would be better to not even have this property in that case, rather than having the function return undefined, but I don't know how to do that with the bindings script.
  • bindings/scripts/CodeGeneratorJS.pm: Leave out argument names in functions where they're not used (the SVG context, and the property name in the index getter). Use UNUSED_PARAM where arguments are sometimes not used.
  • bridge/runtime_object.cpp: (JSC::RuntimeObjectImp::put): Use UNUSED_PARAM for non-QT.
  • css/MediaQueryEvaluator.cpp: (WebCore::animationMediaFeatureEval): Omit argument names for style and frame. (WebCore::transitionMediaFeatureEval): Ditto. (WebCore::transform_2dMediaFeatureEval): Ditto. (WebCore::transform_3dMediaFeatureEval): Ditto.
  • dom/make_names.pl: Leave out the createdByParser property name in cases where it's not used.
  • inspector/JavaScriptDebugServer.cpp: (WebCore::JavaScriptDebugServer::setJavaScriptPaused): Separate the version for the Mac platform so we can omit the argument names.
  • loader/EmptyClients.h: (WebCore::EmptyChromeClient::contentsSizeChanged): Removed argument name.
  • loader/FrameLoaderClient.h: (WebCore::FrameLoaderClient::shouldUsePluginDocument): Commented out argument name.
  • loader/icon/IconFetcher.cpp: (WebCore::IconFetcher::didReceiveResponse): Use ASSERT_UNUSED. (WebCore::IconFetcher::didReceiveData): Ditto. (WebCore::IconFetcher::didFinishLoading): Ditto. (WebCore::IconFetcher::didFail): Ditto.
  • platform/KURL.cpp: (WebCore::assertProtocolIsGood): Separate out the NDEBUG version so we can omit the argument names.
  • platform/Timer.cpp: (WebCore::TimerHeapIterator::checkConsistency): Use ASSERT_UNUSED.
  • platform/graphics/GlyphBuffer.h: (WebCore::GlyphBuffer::offsetAt): Use UNUSED_PARAM in the non-WIN case. (WebCore::GlyphBuffer::add): Use UNUSED_PARAM in the non-CAIRO case.
  • platform/graphics/cg/ImageSourceCG.cpp: (WebCore::ImageSource::clear): Removed argument name.
  • rendering/SVGRenderSupport.cpp: (WebCore::prepareToRenderSVGContent): Use UNUSED_PARAM when SVG_FILTERS is not enabled. (WebCore::finishRenderSVGContent): Ditto.
4:15 PM Changeset in webkit [39879] by barraclough@apple.com
  • 2 edits in trunk/JavaScriptCore

2009-01-13 Gavin Barraclough <​barraclough@apple.com>

Reviewed by Oliver Hunt.

Fix for: ​https://bugs.webkit.org/show_bug.cgi?id=23292

Implementation of two argument canDoFastAdditiveOperations does not correlate well with reality.

  • runtime/JSImmediate.h: (JSC::JSFastMath::canDoFastAdditiveOperations):
3:40 PM ApplicationsGtk edited by greut.lists@dosimple.ch
fixed Empathy's link label (diff)
2:47 PM Changeset in webkit [39878] by cmarrin@apple.com
  • 2 edits in trunk/WebCore

Implemented ​https://bugs.webkit.org/show_bug.cgi?id=23298
Simple fix to convertToLength to catch style==null cases

  • css/CSSStyleSelector.cpp: (WebCore::convertToLength):
2:36 PM Changeset in webkit [39877] by andersca@apple.com
  • 5 edits
    2 adds in trunk

WebKitTools:

2009-01-13 Anders Carlsson <​andersca@apple.com>

Reviewed by Sam Weinig.

Add NPRuntime test.

  • DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp: (testNPRuntime):
  • DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.h:
  • DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp: (NPP_New): (NPP_GetValue):

LayoutTests:

2009-01-13 Anders Carlsson <​andersca@apple.com>

Reviewed by Sam Weinig.

Add NPRuntime test.


  • plugins/npruntime-expected.txt: Added.
  • plugins/npruntime.html: Added.
1:15 PM Changeset in webkit [39876] by eric@webkit.org
  • 2 edits in trunk/WebCore

Reviewed by Mark Rowe.

Speculative fix for an Uninitialized Memory Read (UMR)
seen by purify in chormium's equivalent V8 file.

  • bindings/js/JSSVGPODTypeWrapper.h: (WebCore::PODTypeWrapperCacheInfo::PODTypeWrapperCacheInfo):
12:55 PM Changeset in webkit [39875] by Dimitri Glazkov
  • 1 edit
    4 adds in trunk/WebCore

2009-01-13 Dimitri Glazkov <Dimitri Glazkov>

Reviewed by Eric Seidel.

Land portions of platform/graphics/chromium.
​https://bugs.webkit.org/show_bug.cgi?id=23297

  • platform/graphics/chromium/FontCustomPlatformData.cpp: Added. (WebCore::FontCustomPlatformData::~FontCustomPlatformData): (WebCore::FontCustomPlatformData::fontPlatformData): (WebCore::EOTStream::EOTStream): (WebCore::EOTStream::read): (WebCore::readEmbedProc): (WebCore::createUniqueFontName): (WebCore::createFontCustomPlatformData):
  • platform/graphics/chromium/FontCustomPlatformData.h: Added. (WebCore::FontCustomPlatformData::FontCustomPlatformData):
  • platform/graphics/chromium/FontLinux.cpp: Added. (WebCore::Font::drawGlyphs): (WebCore::Font::drawComplexText): (WebCore::Font::floatWidthForComplexText): (WebCore::Font::offsetForPositionForComplexText): (WebCore::Font::selectionRectForComplexText):
  • platform/graphics/chromium/FontPlatformData.h: Added.
12:44 PM Changeset in webkit [39874] by Simon Hausmann
  • 2 edits in trunk/WebKit/qt

2009-01-08 Yongjun Zhang <​yongjun.zhang@nokia.com>

Reviewed by Simon Hausmann.

​https://bugs.webkit.org/show_bug.cgi?id=23187

Update webview with the intersected rect.

In ChromeClientQt::repaint, view should be updated with the
intersected rect, not the whole windowRect;

This generally is not a problem for normal viewport setup where
viewport size is the same as the qwebview widget size. However, if we
set the viewport size smaller than qwebkit widget, we will see
unwanted painting outside the viewport.

12:43 PM Changeset in webkit [39873] by ariya@webkit.org
  • 2 edits in trunk/WebKit/qt

2009-01-13 Ariya Hidayat <​ariya.hidayat@trolltech.com>

Rubber-stamped by Tor Arne Vestbø.

[Qt] Missing piece from my previous commit:
Disable and enable the cursor navigation actions when contentEditable
is changed.

  • Api/qwebpage.cpp: (QWebPagePrivate::updateEditorActions):
12:24 PM Changeset in webkit [39872] by mrowe@apple.com
  • 2 edits in trunk/WebCore

Don't copy DOMStringList.idl into the framework bundle.

Rubber-stamped by Oliver Hunt.

  • WebCore.xcodeproj/project.pbxproj:
12:22 PM WebKit Team edited by vestbo@webkit.org
(diff)
12:07 PM Changeset in webkit [39871] by mrowe@apple.com
  • 2 edits in trunk/JavaScriptCore

​https://bugs.webkit.org/show_bug.cgi?id=23290
Fix JSImmediate::isImmediate(src) to !src->isCell()

Reviewed by Darin Adler.

  • interpreter/Interpreter.cpp:

(JSC::Interpreter::privateExecute):

12:07 PM Changeset in webkit [39870] by ariya@webkit.org
  • 2 edits in trunk/WebKit/qt

2009-01-13 Ariya Hidayat <​ariya.hidayat@trolltech.com>

Reviewed by Tor Arne Vestbø.

[Qt] Create actions for cursor navigation for QWebPage.
Also properly disable and enable them when contentEditable is toggled.

  • Api/qwebpage.cpp: (QWebPagePrivate::updateAction): (QWebPage::action):
11:26 AM Changeset in webkit [39869] by andersca@apple.com
  • 5 edits in trunk/WebKit/mac

2009-01-12 Anders Carlsson <​andersca@apple.com>

Reviewed by Darin Adler.

Add a bunch of methods to WebKitPluginClient.defs, and implement them.


  • Plugins/Hosted/NetscapePluginHostProxy.mm: (WebKit::fromUTF8WithLatin1Fallback): If the length isn't specified, get it by calling strlen.


(WKPCEvaluate):
Evaluate doesn't take any arguments.


(WKPCGetIntIdentifier):
Call _NPN_GetIntIdentifier.


(identifierFromServerIdentifier):
New helper function that returns a JSC Identifier from an NPIdentifier.


(WKPCInvoke):
Call identifierFromServerIdentifier.


(WKPCRemoveProperty):
(WKPCHasProperty):
(WKPCHasMethod):
Call NetscapePluginInstanceProxy.

  • Plugins/Hosted/NetscapePluginInstanceProxy.h:
  • Plugins/Hosted/NetscapePluginInstanceProxy.mm: (WebKit::NetscapePluginInstanceProxy::removeProperty): (WebKit::NetscapePluginInstanceProxy::hasProperty): (WebKit::NetscapePluginInstanceProxy::hasMethod):
  • Plugins/Hosted/WebKitPluginClient.defs: Add new definitions.
11:25 AM Changeset in webkit [39868] by christian@webkit.org
  • 2 edits in trunk/WebCore

2009-01-13 Christian Dywan <​christian@twotoasts.de>

Build fix, StorageEvent is only defined if we have DOM_STORAGE

  • dom/Document.cpp: (WebCore::Document::createEvent): Conditionalize StorageEvent
11:17 AM Changeset in webkit [39867] by andersca@apple.com
  • 2 edits in trunk/WebKit/mac

2009-01-13 Anders Carlsson <​andersca@apple.com>

Fix build.

  • WebView/WebView.mm: (-[WebView _initWithArguments:]):
11:13 AM Changeset in webkit [39866] by Dimitri Glazkov
  • 2 edits in trunk/JavaScriptCore

2009-01-13 Dmitry Titov <​dimich@chromium.org>

Reviewed by Darin Adler.

​https://bugs.webkit.org/show_bug.cgi?id=23281
Fix the Chromium Win build.
Need to use PLATFORM(WIN_OS) instead of PLATFORM(WIN).
Moved GTK and WX up in #if sequence because they could come with WIN_OS too,
while they have their own implementation even on Windows.

  • wtf/CurrentTime.cpp: (WTF::currentTime):
10:12 AM Changeset in webkit [39865] by timothy@apple.com
  • 7 edits in trunk/WebKit

Adds a workaround for the flip4mac installer plugin decoding a WebView from a NIB on a secondary thread.

<rdar://problem/6489788> New WebKit thread checks break installation of flip4mac (thread violation)

Reviewed by Darin Adler.

  • Misc/WebKitVersionChecks.h: Add WEBKIT_FIRST_VERSION_WITHOUT_WEBVIEW_INIT_THREAD_WORKAROUND.
  • Misc/WebNSObjectExtras.h: Add _webkit_performSelectorOnMainThread:withObject:.
  • Misc/WebNSObjectExtras.mm: (-[NSObject _webkit_performSelectorWithArguments:]): Renamed from _webkit_getPropertyWithArguments. Passes the optional object to the selector. (-[NSObject _webkit_performSelectorOnMainThread:withObject:]): Renamed from _webkit_getPropertyOnMainThread:. Put the optional object into the arguments dictionary. (-[NSObject _webkit_getPropertyOnMainThread:]): Call _webkit_performSelectorOnMainThread with a nil object.
  • WebView/WebResource.mm: (-[WebResource _ignoreWhenUnarchiving]): Use _cmd instead of making the selector again. (-[WebResource _initWithData:URL:MIMEType:textEncodingName:frameName:response:copyData:]): Use the new _webkit_performSelectorOnMainThread:withObject: method instead of performSelectorOnMainThread.
  • WebView/WebView.mm: (-[WebView _initWithArguments:]): Added. Pulls arguments out of the dictionary and calls the right init method. (needsWebViewInitThreadWorkaround): Checks if the thead is not the main thread and if we are in the Installer bundle. (-[WebView initWithFrame:frameName:groupName:]): Call needsWebViewInitThreadWorkaround and use _webkit_performSelectorOnMainThread to call _initWithArguments: passing the frame, frameName and groupName. (-[WebView initWithCoder:]): Ditto, except pass the coder to _initWithArguments:.
9:59 AM Changeset in webkit [39864] by Darin Adler
  • 2 edits in trunk/WebCore

2009-01-13 Darin Adler <Darin Adler>

Reviewed by Adele Peterson.

Bug 23277: space bar scrolls the page when typed in any text field
​https://bugs.webkit.org/show_bug.cgi?id=23277
rdar://problem/6490249

There's already a regression test for this, since bug 16421 was the same problem, but on
Mac. The regression test is fast/events/space-scroll-event.html, so I won't write a new one.

This bug doesn't affect Mac because the canEdit check in -[WebHTMLView insertText:] prevents
a text input event from being generated at all. That difference may in itself be a bug, but
the only symptom is that you get text input events in more cases on platforms other than Mac.

  • page/EventHandler.cpp: (WebCore::EventHandler::handleTextInputEvent): Return whether the event's default was handled, not the result of the dispatchEvent function, which indicates only whether the default behavior was prevented, not if the default behavior did some insertion. This fix makes it so the keyboard event handler can detect that no space was inserted and know that the space bar keypress event can be treated as a scrolling command. (WebCore::EventHandler::defaultKeyboardEventHandler): Handle the keypress event, not the keydown event. Without the change above, making this change would have restored the old behavior, reintroducing bug 22913 where the space bar doesn't scroll at all on Windows.
9:58 AM Changeset in webkit [39863] by Simon Hausmann
  • 6 edits in trunk/WebKit/qt

2009-01-13 Simon Hausmann <​simon.hausmann@nokia.com>

Reviewed by Tor Arne Vestbø.

​https://bugs.webkit.org/show_bug.cgi?id=23171

Based on patch by Yael Aharon <​yael.aharon@nokia.com>

Make the QWebSettings functions for setting the path for the local
storage database private QtWebkit API, including the ability to
associated a QWebPage with a named page group.

9:24 AM Changeset in webkit [39862] by vestbo@webkit.org
  • 2 edits in trunk/WebCore

2009-01-13 Tor Arne Vestbø <​tavestbo@trolltech.com>

Reviewed by Simon Hausmann.

[Qt] Make sure media elements dispatch the 'loaded' event

We assume that when Phonon goes into paused state that we have the
complete media file. Once we do media loading ourselves we can
distinguish between loading the first frame and the complete media.

8:48 AM Changeset in webkit [39861] by darin@chromium.org
  • 1 edit
    27 adds in trunk/WebCore

2009-01-13 Darin Fisher <​darin@chromium.org>

Reviewed by Eric Seidel.

Landing portions of platform/chromium/, taken from here:
​http://src.chromium.org/viewvc/chrome/trunk/deps/third_party/WebKit/WebCore/platform/chromium/

  • platform/chromium/ChromiumBridge.h: Added.
  • platform/chromium/ChromiumDataObject.cpp: Added. (WebCore::ChromiumDataObject::clear): (WebCore::ChromiumDataObject::hasData):
  • platform/chromium/ChromiumDataObject.h: Added. (WebCore::ChromiumDataObject::create): (WebCore::ChromiumDataObject::ChromiumDataObject):
  • platform/chromium/ClipboardChromium.cpp: Added. (WebCore::): (WebCore::clipboardTypeFromMIMEType): (WebCore::ClipboardChromium::ClipboardChromium): (WebCore::ClipboardChromium::create): (WebCore::ClipboardChromium::clearData): (WebCore::ClipboardChromium::clearAllData): (WebCore::ClipboardChromium::getData): (WebCore::ClipboardChromium::setData): (WebCore::ClipboardChromium::types): (WebCore::ClipboardChromium::setDragImage): (WebCore::ClipboardChromium::setDragImageElement): (WebCore::ClipboardChromium::createDragImage): (WebCore::imageToMarkup): (WebCore::getCachedImage): (WebCore::writeImageToDataObject): (WebCore::ClipboardChromium::declareAndWriteDragImage): (WebCore::ClipboardChromium::writeURL): (WebCore::ClipboardChromium::writeRange): (WebCore::ClipboardChromium::hasData):
  • platform/chromium/ClipboardChromium.h: Added. (WebCore::ClipboardChromium::~ClipboardChromium): (WebCore::ClipboardChromium::dataObject):
  • platform/chromium/ClipboardUtilitiesChromium.cpp: Added. (WebCore::replaceNewlinesWithWindowsStyleNewlines): (WebCore::replaceNBSPWithSpace): (WebCore::urlToMarkup):
  • platform/chromium/ClipboardUtilitiesChromium.h: Added.
  • platform/chromium/ContextMenuChromium.cpp: Added. (WebCore::ContextMenu::ContextMenu): (WebCore::ContextMenu::~ContextMenu): (WebCore::ContextMenu::itemCount): (WebCore::ContextMenu::insertItem): (WebCore::ContextMenu::appendItem): (WebCore::ContextMenu::itemWithAction): (WebCore::ContextMenu::itemAtIndex): (WebCore::ContextMenu::setPlatformDescription): (WebCore::ContextMenu::platformDescription): (WebCore::ContextMenu::releasePlatformDescription):
  • platform/chromium/ContextMenuItemChromium.cpp: Added. (WebCore::ContextMenuItem::ContextMenuItem): (WebCore::ContextMenuItem::~ContextMenuItem): (WebCore::ContextMenuItem::releasePlatformDescription): (WebCore::ContextMenuItem::type): (WebCore::ContextMenuItem::action): (WebCore::ContextMenuItem::title): (WebCore::ContextMenuItem::platformSubMenu): (WebCore::ContextMenuItem::setType): (WebCore::ContextMenuItem::setAction): (WebCore::ContextMenuItem::setTitle): (WebCore::ContextMenuItem::setSubMenu): (WebCore::ContextMenuItem::setChecked): (WebCore::ContextMenuItem::setEnabled): (WebCore::ContextMenuItem::enabled):
  • platform/chromium/CursorChromium.cpp: Added. (WebCore::Cursor::Cursor): (WebCore::Cursor::~Cursor): (WebCore::Cursor::operator=): (WebCore::pointerCursor): (WebCore::crossCursor): (WebCore::handCursor): (WebCore::iBeamCursor): (WebCore::waitCursor): (WebCore::helpCursor): (WebCore::eastResizeCursor): (WebCore::northResizeCursor): (WebCore::northEastResizeCursor): (WebCore::northWestResizeCursor): (WebCore::southResizeCursor): (WebCore::southEastResizeCursor): (WebCore::southWestResizeCursor): (WebCore::westResizeCursor): (WebCore::northSouthResizeCursor): (WebCore::eastWestResizeCursor): (WebCore::northEastSouthWestResizeCursor): (WebCore::northWestSouthEastResizeCursor): (WebCore::columnResizeCursor): (WebCore::rowResizeCursor): (WebCore::middlePanningCursor): (WebCore::eastPanningCursor): (WebCore::northPanningCursor): (WebCore::northEastPanningCursor): (WebCore::northWestPanningCursor): (WebCore::southPanningCursor): (WebCore::southEastPanningCursor): (WebCore::southWestPanningCursor): (WebCore::westPanningCursor): (WebCore::moveCursor): (WebCore::verticalTextCursor): (WebCore::cellCursor): (WebCore::contextMenuCursor): (WebCore::aliasCursor): (WebCore::progressCursor): (WebCore::noDropCursor): (WebCore::copyCursor): (WebCore::noneCursor): (WebCore::notAllowedCursor): (WebCore::zoomInCursor): (WebCore::zoomOutCursor): (WebCore::grabCursor): (WebCore::grabbingCursor):
  • platform/chromium/DragDataChromium.cpp: Added. (WebCore::containsHTML): (WebCore::DragData::createClipboard): (WebCore::DragData::containsURL): (WebCore::DragData::asURL): (WebCore::DragData::containsFiles): (WebCore::DragData::asFilenames): (WebCore::DragData::containsPlainText): (WebCore::DragData::asPlainText): (WebCore::DragData::containsColor): (WebCore::DragData::canSmartReplace): (WebCore::DragData::containsCompatibleContent): (WebCore::DragData::asFragment): (WebCore::DragData::asColor):
  • platform/chromium/EditorChromium.cpp: Added. (WebCore::Editor::newGeneralClipboard):
  • platform/chromium/FileChooserChromium.cpp: Added. (WebCore::FileChooser::basenameForWidth):
  • platform/chromium/FileSystemChromium.cpp: Added. (WebCore::deleteFile): (WebCore::deleteEmptyDirectory): (WebCore::getFileSize): (WebCore::getFileModificationTime): (WebCore::directoryName): (WebCore::pathByAppendingComponent): (WebCore::makeAllDirectories): (WebCore::fileExists):
  • platform/chromium/FileSystemChromiumLinux.cpp: Added. (WebCore::pathGetFileName):
  • platform/chromium/FileSystemChromiumMac.mm: Added. (WebCore::pathGetFileName):
  • platform/chromium/FileSystemChromiumWin.cpp: Added. (WebCore::pathGetFileName):
  • platform/chromium/FramelessScrollView.cpp: Added. (WebCore::FramelessScrollView::~FramelessScrollView): (WebCore::FramelessScrollView::invalidateScrollbarRect): (WebCore::FramelessScrollView::isActive): (WebCore::FramelessScrollView::invalidateRect): (WebCore::FramelessScrollView::hostWindow): (WebCore::FramelessScrollView::windowClipRect): (WebCore::FramelessScrollView::paintContents): (WebCore::FramelessScrollView::contentsResized): (WebCore::FramelessScrollView::visibleContentsResized):
  • platform/chromium/FramelessScrollView.h: Added. (WebCore::FramelessScrollView::FramelessScrollView): (WebCore::FramelessScrollView::client): (WebCore::FramelessScrollView::setClient):
  • platform/chromium/FramelessScrollViewClient.h: Added.
  • platform/chromium/ScrollbarThemeChromiumWin.cpp: Added. (WebCore::): (WebCore::ScrollbarThemeChromium::scrollbarThickness): (WebCore::ScrollbarThemeChromium::invalidateOnMouseEnterExit): (WebCore::ScrollbarThemeChromium::paintTrackPiece): (WebCore::ScrollbarThemeChromium::paintButton): (WebCore::ScrollbarThemeChromium::paintThumb): (WebCore::ScrollbarThemeChromium::getThemeState): (WebCore::ScrollbarThemeChromium::getThemeArrowState): (WebCore::ScrollbarThemeChromium::getClassicThemeState):
  • platform/chromium/SoundChromiumPosix.cpp: Added. (WebCore::systemBeep):
  • platform/chromium/SoundChromiumWin.cpp: Added. (WebCore::systemBeep):
  • platform/chromium/SystemTimeChromium.cpp: Added. (WebCore::currentTime): (WebCore::userIdleTime):
  • platform/chromium/WidgetChromium.cpp: Added. (WebCore::Widget::Widget): (WebCore::Widget::~Widget): (WebCore::Widget::show): (WebCore::Widget::hide): (WebCore::Widget::setCursor): (WebCore::Widget::paint): (WebCore::Widget::setFocus): (WebCore::Widget::setIsSelected): (WebCore::Widget::frameRect): (WebCore::Widget::setFrameRect):
  • platform/chromium/WindowsVersion.cpp: Added. (WebCore::isVistaOrNewer):
  • platform/chromium/WindowsVersion.h: Added.
8:38 AM Changeset in webkit [39860] by vestbo@webkit.org
  • 2 edits in trunk/WebCore

2009-01-13 Tor Arne Vestbø <​tavestbo@trolltech.com>

Reviewed by Simon Hausmann.

[Qt] Add more verbose error output when loading NPAPI plugins

8:17 AM Changeset in webkit [39859] by Simon Hausmann
  • 2 edits in trunk/WebCore

2009-01-13 Simon Hausmann <​simon.hausmann@nokia.com>

Reviewed by Tor Arne Vestbø.

Fix crash in the Qt port when deleting a popup from within a
JavaScript onchange handler.

6:58 AM Changeset in webkit [39858] by zecke@webkit.org
  • 2 edits in trunk/WebCore

[GIO] Make sure to untef the GFile and the GInputStream on destruction

Make sure to call cleanupGioOperation from the ResourceHandleInternal
d'tor. Change the signature of cleanupGioOperation so we can do the
cleanup of GIO next to the cleanup of SOUP.

6:58 AM Changeset in webkit [39857] by zecke@webkit.org
  • 2 edits in trunk/WebCore

[GIO] Attach the ResourceHandle to the GObject and get it from the GObject

​https://bugs.webkit.org/show_bug.cgi?id=23116 discussed with Benjamin Otte

Sometimes it is not possible to cancel a pending GIO operation and the
callback might be invoked with a pointer to an already destructed
ResourceHandle. To avoid this issue we will attach the ResourceHandle
to the GObject* and in the callback attempt to get the ResourceHandle
from the GObject*. If no ResourceHandle is attached we silently fail
as the cleanup has been already done.

6:58 AM Changeset in webkit [39856] by zecke@webkit.org
  • 2 edits in trunk/WebCore

[GIO] Invoke cleanupGioOperation before calling didFail to avoid crashes

​https://bugs.webkit.org/show_bug.cgi?id=23116

The ResourceHandle becomes invalid (e.g. got destructed) from within
the invocation of didFail. Avoid this by cleaning up everything before
calling didFail and simply return afterwards.

This is happening with many tests from dom/html/level2/html e.g.
LayoutTests/dom/html/level2/html/HTMLBodyElement07.html.

6:57 AM Changeset in webkit [39855] by zecke@webkit.org
  • 2 edits in trunk/WebKit/gtk

2009-01-13 Alexander V. Butenko <​alex@digiqube.com>

Reviewed by Holger Freyther.

​https://bugs.webkit.org/show_bug.cgi?id=23279

Fix crash on WebView dispose stage.

Add null checks to webkit_web_view_set_scroll_adjustments and
webkit_web_view_get_accessible as they get called from within
the dispose.

  • webkit/webkitwebview.cpp:
6:51 AM Changeset in webkit [39854] by vestbo@webkit.org
  • 7 edits
    1 move
    2 adds
    2 deletes in trunk/WebCore

2009-01-13 Tor Arne Vestbø <​tavestbo@trolltech.com>

Reviewed by Simon Hausmann.

Change how themes adjust mediaControls.css to match html4/quicks.css

Instead of providing the full style sheet, the themes provide extra
overrides to the default style defined in UserAgentStyleSheetsData.

​https://bugs.webkit.org/show_bug.cgi?id=23210

Also, merge WebKitResources.qrc and WebCoreResources.qrc to speed up
build time for the Qt port.

12:11 AM Changeset in webkit [39853] by sfalken@apple.com
  • 2 edits in trunk/WebKit/win

Build fix.

  • WebScriptCallFrame.cpp: (WebScriptCallFrame::jsValueToString):
Note: See TracTimeline for information about the timeline view.