⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Jan 18, 2009:

11:15 PM Changeset in webkit [40024] by weinig@apple.com
  • 13 edits
    1 delete in trunk/WebCore

2009-01-18 Sam Weinig <​sam@webkit.org>

Reviewed by Cameron Zwarich.

Fix for ​https://bugs.webkit.org/show_bug.cgi?id=23415
Remove FramePrivate

Minor PLT speedup.

  • WebCore.base.exp:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • loader/FrameLoader.cpp:
  • page/Frame.cpp: (WebCore::Frame::Frame): (WebCore::Frame::~Frame): (WebCore::Frame::init): (WebCore::Frame::loader): (WebCore::Frame::view): (WebCore::Frame::setView): (WebCore::Frame::script): (WebCore::Frame::document): (WebCore::Frame::setDocument): (WebCore::Frame::settings): (WebCore::Frame::selection): (WebCore::Frame::editor): (WebCore::Frame::selectionGranularity): (WebCore::Frame::setSelectionGranularity): (WebCore::Frame::dragCaretController): (WebCore::Frame::animation): (WebCore::Frame::mark): (WebCore::Frame::setMark): (WebCore::Frame::setCaretVisible): (WebCore::Frame::clearCaretRectIfNeeded): (WebCore::Frame::selectionLayoutChanged): (WebCore::Frame::caretBlinkTimerFired): (WebCore::Frame::paintCaret): (WebCore::Frame::paintDragCaret): (WebCore::Frame::zoomFactor): (WebCore::Frame::isZoomFactorTextOnly): (WebCore::Frame::shouldApplyTextZoom): (WebCore::Frame::shouldApplyPageZoom): (WebCore::Frame::setZoomFactor): (WebCore::Frame::setPrinting): (WebCore::Frame::setJSStatusBarText): (WebCore::Frame::setJSDefaultStatusBarText): (WebCore::Frame::jsStatusBarText): (WebCore::Frame::jsDefaultStatusBarText): (WebCore::Frame::setNeedsReapplyStyles): (WebCore::Frame::needsReapplyStyles): (WebCore::Frame::reapplyStyles): (WebCore::Frame::isContentEditable): (WebCore::Frame::updateSecureKeyboardEntryIfActive): (WebCore::Frame::typingStyle): (WebCore::Frame::setTypingStyle): (WebCore::Frame::clearTypingStyle): (WebCore::Frame::computeAndSetTypingStyle): (WebCore::Frame::selectionComputedStyle): (WebCore::Frame::applyEditingStyleToBodyElement): (WebCore::Frame::removeEditingStyleFromBodyElement): (WebCore::Frame::keepAlive): (WebCore::Frame::cancelAllKeepAlive): (WebCore::Frame::clearDOMWindow): (WebCore::Frame::ownerElement): (WebCore::Frame::ownerRenderer): (WebCore::Frame::isDisconnected): (WebCore::Frame::setIsDisconnected): (WebCore::Frame::excludeFromTextSearch): (WebCore::Frame::setExcludeFromTextSearch): (WebCore::Frame::selectionBounds): (WebCore::Frame::selectionTextRects): (WebCore::Frame::isFrameSet): (WebCore::Frame::currentForm): (WebCore::Frame::forceLayout): (WebCore::Frame::sendScrollEvent): (WebCore::Frame::clearTimers): (WebCore::Frame::styleForSelectionStart): (WebCore::Frame::inViewSourceMode): (WebCore::Frame::setInViewSourceMode): (WebCore::Frame::markAllMatchesForText): (WebCore::Frame::markedTextMatchesAreHighlighted): (WebCore::Frame::setMarkedTextMatchesAreHighlighted): (WebCore::Frame::tree): (WebCore::Frame::setDOMWindow): (WebCore::Frame::domWindow): (WebCore::Frame::clearFormerDOMWindow): (WebCore::Frame::page): (WebCore::Frame::eventHandler): (WebCore::Frame::pageDestroyed): (WebCore::Frame::disconnectOwnerElement): (WebCore::Frame::documentAtPoint):
  • page/Frame.h:
  • page/FramePrivate.h: Removed.
  • page/FrameTree.h:
  • page/chromium/FrameChromium.cpp:
  • page/mac/FrameMac.mm: (WebCore::Frame::imageFromRect): (WebCore::Frame::selectionImage): (WebCore::Frame::snapshotDragImage): (WebCore::Frame::nodeImage): (WebCore::Frame::setUserStyleSheetLocation): (WebCore::Frame::setUserStyleSheet):
  • page/qt/FrameQt.cpp: (WebCore::Frame::setUserStyleSheetLocation): (WebCore::Frame::setUserStyleSheet):
  • page/win/FrameCGWin.cpp: (WebCore::Frame::nodeImage):
  • page/win/FrameWin.cpp:
6:31 PM Changeset in webkit [40023] by mrowe@apple.com
  • 2 edits in trunk/WebKit/mac

Fix <​https://bugs.webkit.org/show_bug.cgi?id=23414>.
Bug 23414: Reproducible crash accessing View menu with plugins disabled

Reviewed by Anders Carlsson.

  • WebView/WebFrame.mm:

(-[WebFrame _canProvideDocumentSource]): Null-check the PluginData before using it.

9:14 AM Changeset in webkit [40022] by eric.carlson@apple.com
  • 2 edits in trunk/WebCore

2009-01-17 Eric Carlson <​eric.carlson@apple.com>

Build fix for !ENABLE(VIDEO) following r40016.

  • rendering/RenderSlider.cpp: (WebCore::RenderSlider::mouseEventIsInThumb):

Jan 17, 2009:

8:30 PM Changeset in webkit [40021] by sfalken@apple.com
  • 2 edits in trunk/WebKit/win

Build fix.

  • WebCoreSupport/WebDragClient.cpp: (WebDragClient::createDragImageForLink):
8:15 PM Changeset in webkit [40020] by sfalken@apple.com
  • 3 edits in trunk/WebCore

Build fix.

7:08 PM Changeset in webkit [40019] by hyatt@apple.com
  • 9 edits in trunk/WebCore

2009-01-17 David Hyatt <​hyatt@apple.com>

Optimize isTextNode() the same way isElementNode() was optimized in an earlier checkin. isTextNode()
on Node is now non-virtual and just checks a bit that is set at construction time by Text.

Reviewed by Sam Weinig

  • dom/CharacterData.cpp: (WebCore::CharacterData::CharacterData):
  • dom/CharacterData.h:
  • dom/EventTargetNode.cpp: (WebCore::EventTargetNode::EventTargetNode):
  • dom/EventTargetNode.h:
  • dom/Node.cpp: (WebCore::Node::Node):
  • dom/Node.h: (WebCore::Node::isTextNode): (WebCore::Node::isAttributeNode):
  • dom/Text.cpp: (WebCore::Text::Text):
  • dom/Text.h:
2:20 PM Changeset in webkit [40018] by hyatt@apple.com
  • 2 edits in trunk/LayoutTests/fast/dom

Fix failing CSS Selector layout test. Don't test first-letter in a text test, since that causes some of the selector text to be lost.

1:38 PM Changeset in webkit [40017] by hyatt@apple.com
  • 27 edits in trunk

WebCore:

2009-01-17 David Hyatt <​hyatt@apple.com>

Change how backslashAsCurrencySymbol() works. Instead of forcing call sites to do the direct
replacement themselves, the exact transformation is instead done by the encoding (indirectly through
a method on Document).

These changes allow the fast case (where no replacement is needed) checks to be completely inlined for
a slight speedup, and also allow encodings to do future alterations to displayed string content without
having to patch call sites again.

Reviewed by Oliver Hunt

  • WebCore.base.exp:
  • dom/Document.cpp:
  • dom/Document.h: (WebCore::Document::displayStringModifiedByEncoding): (WebCore::Document::displayBufferModifiedByEncoding):
  • editing/Editor.cpp: (WebCore::Editor::addToKillRing):
  • editing/TextIterator.cpp: (WebCore::plainTextToMallocAllocatedBuffer): (WebCore::plainText):
  • editing/TextIterator.h:
  • html/HTMLOptGroupElement.cpp: (WebCore::HTMLOptGroupElement::groupLabelText):
  • html/HTMLOptionElement.cpp: (WebCore::HTMLOptionElement::text):
  • loader/DocumentLoader.cpp: (WebCore::canonicalizedTitle):
  • page/Chrome.cpp: (WebCore::displayString): (WebCore::Chrome::runJavaScriptAlert): (WebCore::Chrome::runJavaScriptConfirm): (WebCore::Chrome::runJavaScriptPrompt): (WebCore::Chrome::setStatusbarText):
  • page/Frame.cpp: (WebCore::Frame::shouldClose):
  • page/Frame.h:
  • platform/mac/PasteboardMac.mm: (WebCore::Pasteboard::writeSelection):
  • platform/text/TextCodecICU.cpp: (WebCore::TextCodecICU::encode):
  • platform/text/TextEncoding.cpp: (WebCore::TextEncoding::TextEncoding):
  • platform/text/TextEncoding.h: (WebCore::TextEncoding::displayString): (WebCore::TextEncoding::displayBuffer):
  • rendering/HitTestResult.cpp: (WebCore::displayString):
  • rendering/RenderImage.cpp: (WebCore::RenderImage::paintReplaced):
  • rendering/RenderObject.cpp:
  • rendering/RenderObject.h:
  • rendering/RenderText.cpp: (WebCore::RenderText::RenderText): (WebCore::RenderText::setTextInternal):
  • rendering/RenderTextControl.cpp: (WebCore::RenderTextControl::setInnerTextValue): (WebCore::RenderTextControl::finishText):

WebKit/mac:

2009-01-17 David Hyatt <​hyatt@apple.com>

Eliminate dependencies on "backslashAsCurrencySymbol()" from WebKit, and make sure these alterations
are done in WebCore instead.

Reviewed by Oliver Hunt

  • WebView/WebFrame.mm: (-[WebFrame _selectedString]): (-[WebFrame _stringForRange:]):

WebKit/win:

2009-01-17 David Hyatt <​hyatt@apple.com>

Eliminate dependencies on backslashAsCurrencySymbol from WebKit.

Reviewed by Oliver Hunt

  • WebFrame.cpp: (WebFrame::selectedString):
9:18 AM Changeset in webkit [40016] by eric.carlson@apple.com
  • 33 edits
    1 add in trunk

2009-01-17 Eric Carlson <​eric.carlson@apple.com>

Reviewed by Adele Peterson

Complete <rdar://problem/6293969>

  • DerivedSources.make: include mediaControlsQT.css for Mac build.
  • WebCore.xcodeproj/project.pbxproj: add mediaControlsQT.css
  • css/CSSPrimitiveValueMappings.h: (WebCore::CSSPrimitiveValue::CSSPrimitiveValue): add MediaTimelineContainerPart, CSSValueMediaCurrentTimeDisplay, and CSSValueMediaTimeRemainingDisplay
  • css/CSSSelector.cpp: (WebCore::CSSSelector::extractPseudoType): include new media controller element styles
  • css/CSSSelector.h: (WebCore::CSSSelector::): Ditto.
  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::SelectorChecker::checkOneSelector): include new media controller element styles
  • css/CSSValueKeywords.in: add keywords for new media time display controls
  • css/mediaControls.css: adjust css for new control elements
  • css/mediaControlsQT.css: Added.
  • platform/ThemeTypes.h: (WebCore::): add media time display controls to ControlPart
  • platform/mac/WebCoreSystemInterface.h:
  • platform/mac/WebCoreSystemInterface.mm: pass controller style to WKSI functions
  • rendering/MediaControlElements.cpp: (WebCore::MediaTextDisplayElement::MediaTextDisplayElement): Added (WebCore::MediaTextDisplayElement::attachToParent): Added (WebCore::MediaTextDisplayElement::update): Added (WebCore::MediaTimeDisplayElement::MediaTimeDisplayElement): Added (WebCore::MediaControlInputElement::MediaControlInputElement): Added (WebCore::MediaControlInputElement::hitTest): Added (WebCore::MediaControlTimelineElement::defaultEventHandler): Update the time display when dragging the thumb
  • rendering/MediaControlElements.h: (WebCore::): Add MediaTextDisplayElement
  • rendering/RenderMedia.cpp: (WebCore::RenderMedia::createTimelineContainer): Added (WebCore::RenderMedia::createTimeline): Parent is now the timeline container (WebCore::RenderMedia::createCurrentTimeDisplay): Added (WebCore::RenderMedia::createTimeRemainingDisplay): Added (WebCore::RenderMedia::updateControls): Create new elements. Don't ever start the time update timer when the time display elements are not visible (WebCore::RenderMedia::formatTime): Handle negative times. Don't display 0 hours or minutes (WebCore::RenderMedia::updateTimeDisplay): Do nothing when the time display elements are not visible. Display time remaining as well as current time. (WebCore::RenderMedia::updateControlVisibility): Don't assume opacity should be set to 0 when visibility changes (WebCore::RenderMedia::forwardEvent): Call element hitTest() method instead of local function as we can't assume that all controls are rectangular
  • rendering/RenderMedia.h: Updated
  • rendering/RenderSlider.cpp: (WebCore::RenderSlider::mouseEventIsInThumb): When slider is media timeline control, call element hitTest() method instead of assuming it is rectangular
  • rendering/RenderSlider.h: make mouseEventIsInThumb virtual
  • rendering/RenderTheme.cpp: (WebCore::RenderTheme::paint): Deal with time display and timeline container
  • rendering/RenderTheme.h: (WebCore::RenderTheme::paintMediaTimelineContainer): Updated (WebCore::RenderTheme::paintMediaCurrentTime): Added (WebCore::RenderTheme::paintMediaTimeRemaining): Added
  • rendering/RenderThemeMac.h: Updated
  • rendering/RenderThemeMac.mm: (WebCore::): (WebCore::mediaControllerTheme): (WebCore::RenderThemeMac::adjustSliderThumbSize): Call WebKitSystemInterface to get the thumb size when appropriate (WebCore::RenderThemeMac::paintMediaFullscreenButton): pass controller style to render function (WebCore::RenderThemeMac::paintMediaMuteButton): Ditto (WebCore::RenderThemeMac::paintMediaPlayButton): Ditto (WebCore::RenderThemeMac::paintMediaSeekBackButton): Ditto (WebCore::RenderThemeMac::paintMediaSeekForwardButton): Ditto (WebCore::RenderThemeMac::paintMediaSliderTrack): Ditto (WebCore::RenderThemeMac::paintMediaSliderThumb): Ditto (WebCore::RenderThemeMac::paintMediaTimelineContainer): Added (WebCore::RenderThemeMac::paintMediaCurrentTime): Added (WebCore::RenderThemeMac::paintMediaTimeRemaining): Added (WebCore::RenderThemeMac::extraMediaControlsStyleSheet): Added (WebCore::RenderThemeMac::hitTestMediaControlPart): Added
  • rendering/style/RenderStyle.h: Updated (WebCore::):

2009-01-17 Eric Carlson <​eric.carlson@apple.com>

Reviewed by Adele Peterson

Complete <rdar://problem/6293969>

  • WebCoreSupport/WebSystemInterface.m: (InitWebCoreSystemInterface): Remove UseSharedMediaUI

2009-01-17 Eric Carlson <​eric.carlson@apple.com>

Reviewed by Adele Peterson

<rdar://problem/6293969>
Update media controls rendering results for new controls CSS.

  • platform/mac/media/audio-controls-rendering-expected.txt:
  • platform/mac/media/video-controls-rendering-expected.txt:
  • platform/mac/media/video-display-toggle-expected.txt:
1:36 AM Changeset in webkit [40015] by hyatt@apple.com
  • 3 edits in trunk/WebCore

2009-01-17 David Hyatt <​hyatt@apple.com>

Inline a few methods in FrameView for speed.

Reviewed by Oliver Hunt

  • page/FrameView.cpp:
  • page/FrameView.h: (WebCore::FrameView::layoutCount): (WebCore::FrameView::needsFullRepaint):
1:27 AM Changeset in webkit [40014] by hyatt@apple.com
  • 4 edits in trunk/WebCore

2009-01-17 David Hyatt <​hyatt@apple.com>

Inline Document::documentElement(), since it is used by the (very hot) RenderObject::isRoot(). Split off
the code that fetches and caches the document element into a separate function and inline the part that
does the null check and the return of the already-cached element.

Reviewed by Oliver Hunt

  • dom/Document.cpp: (WebCore::Document::cacheDocumentElement):
  • dom/Document.h: (WebCore::Document::documentElement):
1:11 AM Changeset in webkit [40013] by hyatt@apple.com
  • 2 edits in trunk/WebCore

2009-01-17 David Hyatt <​hyatt@apple.com>

Minor tweaks to RenderBox::styleChange to speed it up.

Reviewed by Oliver Hunt

  • rendering/RenderBox.cpp: (WebCore::RenderBox::styleDidChange):
12:41 AM Changeset in webkit [40012] by hyatt@apple.com
  • 4 edits in trunk/WebCore

2009-01-17 David Hyatt <​hyatt@apple.com>

Inline FrameLoader::client().

Reviewed by Oliver Hunt

  • WebCore.base.exp:
  • loader/FrameLoader.cpp:
  • loader/FrameLoader.h: (WebCore::FrameLoader::client):
12:30 AM Changeset in webkit [40011] by hyatt@apple.com
  • 1 edit in trunk/WebCore/platform/graphics/Image.h

isNull() should be size().isEmpty(). Duh.

12:27 AM Changeset in webkit [40010] by hyatt@apple.com
  • 4 edits in trunk/WebCore

2009-01-17 David Hyatt <​hyatt@apple.com>

Inline some Image methods for speed. Fix CachedImage's addClient method to just use isNull rather
than needlessly creating a rect.

Reviewed by Oliver Hunt

  • loader/CachedImage.cpp: (WebCore::CachedImage::addClient):
  • platform/graphics/Image.cpp:
  • platform/graphics/Image.h: (WebCore::Image::isNull): (WebCore::Image::rect): (WebCore::Image::width): (WebCore::Image::height):
12:17 AM Changeset in webkit [40009] by hyatt@apple.com
  • 2 edits in trunk/WebCore

2009-01-17 David Hyatt <​hyatt@apple.com>

Avoid using the non-inlined isVariable() when adding parsed values during CSS parsing.

Reviewed by Oliver Hunt

  • css/CSSParserValues.cpp: (WebCore::CSSParserValueList::addValue):
12:04 AM Changeset in webkit [40008] by hyatt@apple.com
  • 3 edits in trunk/WebCore

2009-01-17 David Hyatt <​hyatt@apple.com>

Inline Document::inPageCache(), since - because of animation code - it is now called every time
styles change on any element and so is now super-hot.

Reviewed by Oliver Hunt

  • dom/Document.cpp:
  • dom/Document.h: (WebCore::Document::inPageCache):
Note: See TracTimeline for information about the timeline view.