Context Navigation

← Previous Period
Next Period →

Timeline

Jan 21, 2009:

11:54 PM Changeset in webkit [40118] by hyatt@apple.com

5 edits in trunk/WebCore

2009-01-21 David Hyatt <hyatt@apple.com>

Back out a portion of my patch that I did not mean to land. Revert paintOutline back to the way it
was before my landing. Fixes failing SVG focus ring tests.

rendering/RenderObject.cpp: (WebCore::RenderObject::paintOutline):
rendering/RenderObject.h:
rendering/RenderPath.cpp: (WebCore::RenderPath::paint):
rendering/RenderSVGContainer.cpp: (WebCore::RenderSVGContainer::paint):

11:19 PM Changeset in webkit [40117] by hyatt@apple.com

2 edits in trunk/WebCore

2009-01-21 David Hyatt <hyatt@apple.com>

Fix Node's renderBox() method on Windows.

dom/Node.cpp: (WebCore::Node::renderBox):

11:05 PM Changeset in webkit [40116] by hyatt@apple.com

2 edits in trunk/WebCore

2009-01-21 David Hyatt <hyatt@apple.com>

Fix RenderThemeSafari bustage on Win32.

rendering/RenderThemeSafari.cpp: (WebCore::RenderThemeSafari::baselinePosition):

10:58 PM Changeset in webkit [40115] by hyatt@apple.com

2 edits in trunk/WebCore

2009-01-21 David Hyatt <hyatt@apple.com>

Fix bustage in RenderThemeWin. It's actually terrible that RenderThemeWin is using absoluteContentBox,
but that's a problem for another day.

rendering/RenderThemeWin.cpp: (WebCore::RenderThemeWin::paintSearchFieldCancelButton): (WebCore::RenderThemeWin::paintSearchFieldResultsDecoration): (WebCore::RenderThemeWin::paintSearchFieldResultsButton):

9:59 PM Changeset in webkit [40114] by barraclough@apple.com

1 edit in trunk/LayoutTests/ChangeLog

Because bdash hates freedom (tyop fix).

9:57 PM Changeset in webkit [40113] by barraclough@apple.com

1 edit
2 copies in trunk/LayoutTests

2009-01-21 Gavin Barraclough <barraclough@apple.com>

Rubber stamped by Geoff "Cameron Zwarich" Garen.

Add pre & post standalone driver stcripts to assist running the javascript layout tests
on jsc, rather than a full webkit build.

fast/js/resources/standalone-post.js: Copied from fast/js/resources/js-test-post.js.
fast/js/resources/standalone-pre.js: Copied from fast/js/resources/js-test-pre.js. (description): (debug): (escapeString): (testPassed): (testFailed):

9:48 PM Changeset in webkit [40112] by oliver@apple.com

2 edits in trunk/WebCore

Bug 23470: Crash when page load occurs while processing scroll event with MallocScribble enabled
<https://bugs.webkit.org/show_bug.cgi?id=23470>

Reviewed by Dave Hyatt

Add a RefPtr protector to handleWheelEvent to guard against destruction
while processing the scroll event. Alas the absurd set of circumstances
required to trigger this do not appear to be reproducible in DRT.

8:28 PM Changeset in webkit [40111] by barraclough@apple.com

5 edits in trunk

JavaScriptCore:

2009-01-21 Gavin Barraclough <barraclough@apple.com>

Reviewed by Oliver Hunt.

Fix for https://bugs.webkit.org/show_bug.cgi?id=23469.

We need to check all numbers in integer switches, not just those
represented as integer JSImmediates.

interpreter/Interpreter.cpp: (JSC::Interpreter::privateExecute): (JSC::Interpreter::cti_op_switch_imm):

LayoutTests:

2009-01-21 Gavin Barraclough <barraclough@apple.com>

Reviewed by Oliver Hunt.

Add layout test for switch (-0).

fast/js/resources/switch-behaviour.js:
fast/js/switch-behaviour-expected.txt:

7:48 PM Changeset in webkit [40110] by mrowe@apple.com

4 edits in branches/Safari-3-2-branch

Versioning.

7:44 PM Changeset in webkit [40109] by mrowe@apple.com

4 edits in branches/Safari-3-2-branch

Versioning.

7:35 PM Changeset in webkit [40108] by barraclough@apple.com

2 edits in trunk/JavaScriptCore

2009-01-21 Gavin Barraclough <barraclough@apple.com>

Reviewed by Geoff Garen.

Fix for https://bugs.webkit.org/show_bug.cgi?id=23468.

interpreter/Interpreter.cpp: (JSC::Interpreter::privateExecute):

6:31 PM Changeset in webkit [40107] by hyatt@apple.com

101 edits in trunk

WebCore:

2009-01-21 David Hyatt <hyatt@apple.com>

Fix for https://bugs.webkit.org/show_bug.cgi?id=23453

Devirtualize the width/height/x/y methods of the render tree. The methods are now non-virtual on RenderBox.
Many functions that were previously in RenderObject.cpp are now in RenderBox.cpp.

Reviewed by Eric Seidel and Darin Adler

WebCore.base.exp:
css/CSSComputedStyleDeclaration.cpp: (WebCore::sizingBox):
dom/ContainerNode.cpp: (WebCore::ContainerNode::getUpperLeftCorner): (WebCore::ContainerNode::getLowerRightCorner):
dom/Element.cpp: (WebCore::Element::offsetLeft): (WebCore::Element::offsetTop): (WebCore::Element::offsetWidth): (WebCore::Element::offsetHeight): (WebCore::Element::offsetParent): (WebCore::Element::clientLeft): (WebCore::Element::clientTop): (WebCore::Element::clientWidth): (WebCore::Element::clientHeight): (WebCore::Element::scrollLeft): (WebCore::Element::scrollTop): (WebCore::Element::setScrollLeft): (WebCore::Element::setScrollTop): (WebCore::Element::scrollWidth): (WebCore::Element::scrollHeight):
dom/Node.cpp: (WebCore::Node::renderBox): (WebCore::Node::getRect):
dom/Node.h:
dom/Position.cpp: (WebCore::endsOfNodeAreVisuallyDistinctPositions): (WebCore::Position::hasRenderedNonAnonymousDescendantsWithHeight): (WebCore::Position::isCandidate):
dom/PositionIterator.cpp: (WebCore::PositionIterator::isCandidate):
editing/CompositeEditCommand.cpp: (WebCore::CompositeEditCommand::addBlockPlaceholderIfNeeded):
editing/DeleteButtonController.cpp: (WebCore::isDeletableElement):
editing/DeleteSelectionCommand.cpp: (WebCore::DeleteSelectionCommand::removeNode):
editing/Editor.cpp: (WebCore::Editor::insideVisibleArea):
editing/EditorCommand.cpp: (WebCore::verticalScrollDistance):
html/HTMLAnchorElement.cpp: (WebCore::HTMLAnchorElement::isKeyboardFocusable):
html/HTMLCanvasElement.cpp: (WebCore::HTMLCanvasElement::willDraw):
html/HTMLFormControlElement.cpp: (WebCore::HTMLFormControlElement::isFocusable):
html/HTMLFrameElementBase.cpp: (WebCore::HTMLFrameElementBase::width): (WebCore::HTMLFrameElementBase::height):
html/HTMLImageElement.cpp: (WebCore::HTMLImageElement::width): (WebCore::HTMLImageElement::height):
inspector/InspectorController.cpp: (WebCore::InspectorController::drawNodeHighlight):
page/AccessibilityRenderObject.cpp: (WebCore::AccessibilityRenderObject::accessibilityIsIgnored):
page/FrameView.cpp: (WebCore::FrameView::createScrollbar): (WebCore::FrameView::updateDashboardRegions):
page/animation/AnimationBase.cpp: (WebCore::blendFunc):
rendering/HitTestResult.cpp: (WebCore::HitTestResult::imageRect):
rendering/InlineBox.cpp: (WebCore::InlineBox::renderBox): (WebCore::InlineBox::adjustPosition):
rendering/InlineBox.h:
rendering/InlineFlowBox.cpp: (WebCore::InlineFlowBox::placeBoxesHorizontally): (WebCore::InlineFlowBox::verticallyAlignBoxes): (WebCore::InlineFlowBox::placeBoxesVertically):
rendering/InlineFlowBox.h:
rendering/RenderApplet.cpp: (WebCore::RenderApplet::createWidgetIfNecessary):
rendering/RenderBlock.cpp: (WebCore::RenderBlock::overflowHeight): (WebCore::RenderBlock::overflowWidth): (WebCore::RenderBlock::overflowRect): (WebCore::RenderBlock::isSelfCollapsingBlock): (WebCore::RenderBlock::layout): (WebCore::RenderBlock::layoutBlock): (WebCore::RenderBlock::adjustPositionedBlock): (WebCore::RenderBlock::adjustFloatingBlock): (WebCore::RenderBlock::handleSpecialChild): (WebCore::RenderBlock::handlePositionedChild): (WebCore::RenderBlock::handleFloatingChild): (WebCore::RenderBlock::handleCompactChild): (WebCore::RenderBlock::insertCompactIfNeeded): (WebCore::RenderBlock::handleRunInChild): (WebCore::RenderBlock::collapseMargins): (WebCore::RenderBlock::clearFloatsIfNeeded): (WebCore::RenderBlock::estimateVerticalPosition): (WebCore::RenderBlock::determineHorizontalPosition): (WebCore::RenderBlock::handleBottomOfBlock): (WebCore::RenderBlock::layoutBlockChildren): (WebCore::RenderBlock::layoutOnlyPositionedObjects): (WebCore::RenderBlock::layoutPositionedObjects): (WebCore::RenderBlock::markPositionedObjectsForLayout): (WebCore::RenderBlock::repaintOverhangingFloats): (WebCore::RenderBlock::paint): (WebCore::RenderBlock::paintChildren): (WebCore::RenderBlock::paintObject): (WebCore::RenderBlock::paintFloats): (WebCore::RenderBlock::paintContinuationOutlines): (WebCore::clipOutPositionedObjects): (WebCore::RenderBlock::fillSelectionGaps): (WebCore::RenderBlock::fillBlockSelectionGaps): (WebCore::RenderBlock::leftSelectionOffset): (WebCore::RenderBlock::rightSelectionOffset): (WebCore::RenderBlock::insertPositionedObject): (WebCore::RenderBlock::removePositionedObject): (WebCore::RenderBlock::removePositionedObjects): (WebCore::RenderBlock::insertFloatingObject): (WebCore::RenderBlock::removeFloatingObject): (WebCore::RenderBlock::positionNewFloats): (WebCore::RenderBlock::newLine): (WebCore::RenderBlock::lowestPosition): (WebCore::RenderBlock::rightmostPosition): (WebCore::RenderBlock::leftmostPosition): (WebCore::RenderBlock::clearFloats): (WebCore::RenderBlock::addOverhangingFloats): (WebCore::RenderBlock::markAllDescendantsWithFloatsForLayout): (WebCore::RenderBlock::getClearDelta): (WebCore::RenderBlock::nodeAtPoint): (WebCore::RenderBlock::positionForCoordinates): (WebCore::RenderBlock::layoutColumns): (WebCore::RenderBlock::getBaselineOfFirstLineBox): (WebCore::RenderBlock::getBaselineOfLastLineBox): (WebCore::getHeightForLineCount): (WebCore::RenderBlock::adjustForBorderFit):
rendering/RenderBlock.h: (WebCore::RenderBlock::FloatWithRect::FloatWithRect): (WebCore::RenderBlock::hasOverhangingFloats): (WebCore::RenderBlock::CompactInfo::compact): (WebCore::RenderBlock::CompactInfo::set):
rendering/RenderBox.cpp: (WebCore::RenderBox::RenderBox): (WebCore::RenderBox::offsetLeft): (WebCore::RenderBox::offsetTop): (WebCore::RenderBox::offsetParent): (WebCore::RenderBox::clientWidth): (WebCore::RenderBox::clientHeight): (WebCore::RenderBox::scrollWidth): (WebCore::RenderBox::scrollHeight): (WebCore::RenderBox::scrollLeft): (WebCore::RenderBox::scrollTop): (WebCore::RenderBox::setScrollLeft): (WebCore::RenderBox::setScrollTop): (WebCore::RenderBox::absoluteRects): (WebCore::RenderBox::absoluteQuads): (WebCore::RenderBox::absoluteContentBox): (WebCore::RenderBox::absoluteContentQuad): (WebCore::RenderBox::absoluteOutlineBounds): (WebCore::RenderBox::addFocusRingRects): (WebCore::RenderBox::reflectionBox): (WebCore::RenderBox::reflectionOffset): (WebCore::RenderBox::reflectedRect): (WebCore::RenderBox::overrideWidth): (WebCore::RenderBox::overrideHeight): (WebCore::RenderBox::nodeAtPoint): (WebCore::RenderBox::paint): (WebCore::RenderBox::maskClipRect): (WebCore::RenderBox::repaintLayerRectsForImage): (WebCore::RenderBox::paintCustomHighlight): (WebCore::RenderBox::getOverflowClipRect): (WebCore::RenderBox::getClipRect): (WebCore::RenderBox::containingBlockWidth): (WebCore::RenderBox::localToAbsolute): (WebCore::RenderBox::offsetFromContainer): (WebCore::RenderBox::position): (WebCore::RenderBox::computeAbsoluteRepaintRect): (WebCore::RenderBox::repaintDuringLayoutIfMoved): (WebCore::RenderBox::calcWidth): (WebCore::RenderBox::calcWidthUsing): (WebCore::RenderBox::calcHorizontalMargins): (WebCore::RenderBox::calcHeight): (WebCore::RenderBox::calcPercentageHeight): (WebCore::RenderBox::calcReplacedHeightUsing): (WebCore::RenderBox::containingBlockWidthForPositioned): (WebCore::RenderBox::containingBlockHeightForPositioned): (WebCore::RenderBox::calcAbsoluteHorizontal): (WebCore::RenderBox::calcAbsoluteVertical): (WebCore::RenderBox::calcAbsoluteVerticalValues): (WebCore::RenderBox::calcAbsoluteHorizontalReplaced): (WebCore::RenderBox::calcAbsoluteVerticalReplaced): (WebCore::RenderBox::localCaretRect): (WebCore::RenderBox::lowestPosition): (WebCore::RenderBox::rightmostPosition): (WebCore::RenderBox::leftmostPosition): (WebCore::RenderBox::localTransform):
rendering/RenderBox.h: (WebCore::): (WebCore::RenderBox::x): (WebCore::RenderBox::y): (WebCore::RenderBox::width): (WebCore::RenderBox::height): (WebCore::RenderBox::setX): (WebCore::RenderBox::setY): (WebCore::RenderBox::setWidth): (WebCore::RenderBox::setHeight): (WebCore::RenderBox::location): (WebCore::RenderBox::size): (WebCore::RenderBox::setLocation): (WebCore::RenderBox::setSize): (WebCore::RenderBox::move): (WebCore::RenderBox::frameRect): (WebCore::RenderBox::setFrameRect): (WebCore::RenderBox::borderBoxRect): (WebCore::RenderBox::contentBoxRect): (WebCore::RenderBox::previousSiblingBox): (WebCore::RenderBox::nextSiblingBox): (WebCore::RenderBox::parentBox): (WebCore::RenderBox::overflowHeight): (WebCore::RenderBox::overflowWidth): (WebCore::RenderBox::setOverflowHeight): (WebCore::RenderBox::setOverflowWidth): (WebCore::RenderBox::overflowLeft): (WebCore::RenderBox::overflowTop): (WebCore::RenderBox::overflowRect): (WebCore::RenderBox::contentWidth): (WebCore::RenderBox::contentHeight): (WebCore::RenderBox::offsetWidth): (WebCore::RenderBox::offsetHeight): (WebCore::RenderBox::clientLeft): (WebCore::RenderBox::clientTop): (WebCore::RenderBox::availableWidth): (WebCore::RenderBox::tryLayoutDoingPositionedMovementOnly):
rendering/RenderButton.cpp: (WebCore::RenderButton::controlClipRect):
rendering/RenderContainer.cpp: (WebCore::RenderContainer::layout): (WebCore::RenderContainer::positionForCoordinates):
rendering/RenderContainer.h: (WebCore::RenderContainer::firstChildBox): (WebCore::RenderContainer::lastChildBox):
rendering/RenderFieldset.cpp: (WebCore::RenderFieldset::calcPrefWidths): (WebCore::RenderFieldset::layoutLegend): (WebCore::RenderFieldset::findLegend): (WebCore::RenderFieldset::paintBoxDecorations): (WebCore::RenderFieldset::paintMask):
rendering/RenderFieldset.h:
rendering/RenderFileUploadControl.cpp: (WebCore::RenderFileUploadControl::maxFilenameWidth): (WebCore::RenderFileUploadControl::paintObject):
rendering/RenderFlexibleBox.cpp: (WebCore::FlexBoxIterator::FlexBoxIterator): (WebCore::FlexBoxIterator::first): (WebCore::FlexBoxIterator::next): (WebCore::RenderFlexibleBox::calcHorizontalPrefWidths): (WebCore::RenderFlexibleBox::calcVerticalPrefWidths): (WebCore::RenderFlexibleBox::layoutBlock): (WebCore::RenderFlexibleBox::layoutHorizontalBox): (WebCore::RenderFlexibleBox::layoutVerticalBox): (WebCore::RenderFlexibleBox::placeChild): (WebCore::RenderFlexibleBox::allowedChildFlex):
rendering/RenderFlexibleBox.h:
rendering/RenderFlow.cpp: (WebCore::RenderFlow::absoluteClippedOverflowRect): (WebCore::RenderFlow::lowestPosition): (WebCore::RenderFlow::rightmostPosition): (WebCore::RenderFlow::leftmostPosition): (WebCore::RenderFlow::localCaretRect): (WebCore::RenderFlow::addFocusRingRects):
rendering/RenderFrameSet.cpp: (WebCore::RenderFrameSet::paint): (WebCore::RenderFrameSet::layout): (WebCore::RenderFrameSet::positionFrames):
rendering/RenderHTMLCanvas.cpp: (WebCore::RenderHTMLCanvas::paintReplaced): (WebCore::RenderHTMLCanvas::canvasSizeChanged):
rendering/RenderImage.cpp: (WebCore::RenderImage::imageChanged): (WebCore::RenderImage::paintReplaced): (WebCore::RenderImage::nodeAtPoint): (WebCore::RenderImage::calcReplacedWidth):
rendering/RenderInline.cpp: (WebCore::RenderInline::absoluteRects): (WebCore::RenderInline::boundingBoxWidth): (WebCore::RenderInline::boundingBoxHeight): (WebCore::RenderInline::positionForCoordinates):
rendering/RenderInline.h: (WebCore::RenderInline::offsetWidth): (WebCore::RenderInline::offsetHeight):
rendering/RenderLayer.cpp: (WebCore::RenderLayer::updateTransform): (WebCore::RenderLayer::updateLayerPosition): (WebCore::RenderLayer::scrollbarCornerPresent): (WebCore::RenderLayer::createScrollbar): (WebCore::RenderLayer::positionOverflowControls): (WebCore::RenderLayer::paintScrollCorner): (WebCore::RenderLayer::paintResizer): (WebCore::RenderLayer::paintLayer): (WebCore::RenderLayer::hitTestLayer): (WebCore::RenderLayer::calculateRects): (WebCore::RenderLayer::boundingBox):
rendering/RenderListBox.cpp: (WebCore::RenderListBox::calcHeight): (WebCore::RenderListBox::controlClipRect):
rendering/RenderListItem.cpp: (WebCore::RenderListItem::positionListMarker): (WebCore::RenderListItem::paint):
rendering/RenderListMarker.cpp: (WebCore::RenderListMarker::paint): (WebCore::RenderListMarker::layout): (WebCore::RenderListMarker::imageChanged): (WebCore::RenderListMarker::getRelativeMarkerRect): (WebCore::RenderListMarker::selectionRect):
rendering/RenderMarquee.cpp: (WebCore::RenderMarquee::computePosition):
rendering/RenderMedia.cpp: (WebCore::RenderMedia::layout): (WebCore::RenderMedia::lowestPosition): (WebCore::RenderMedia::rightmostPosition): (WebCore::RenderMedia::leftmostPosition):
rendering/RenderMenuList.cpp: (WebCore::RenderMenuList::controlClipRect):
rendering/RenderObject.cpp: (WebCore::RenderObject::RenderObject): (WebCore::RenderObject::markAllDescendantsWithFloatsForLayout): (WebCore::RenderObject::paintOutline): (WebCore::RenderObject::addLineBoxRects): (WebCore::RenderObject::absoluteBoundingBoxRect): (WebCore::RenderObject::addAbsoluteRectForLayer): (WebCore::RenderObject::paintingRootRect): (WebCore::RenderObject::container): (WebCore::RenderObject::removeFromObjectLists): (WebCore::RenderObject::updateHitTestResult): (WebCore::RenderObject::addDashboardRegions): (WebCore::RenderObject::localTransform):
rendering/RenderObject.h: (WebCore::RenderObject::isBox): (WebCore::RenderObject::hasMask): (WebCore::RenderObject::setIsText): (WebCore::RenderObject::setIsBox): (WebCore::RenderObject::borderTop): (WebCore::RenderObject::borderBottom): (WebCore::RenderObject::absoluteRects): (WebCore::RenderObject::collectAbsoluteLineBoxQuads): (WebCore::RenderObject::absoluteQuads): (WebCore::RenderObject::hasReflection): (WebCore::RenderObject::addFocusRingRects): (WebCore::RenderObject::absoluteOutlineBounds):
rendering/RenderPart.cpp: (WebCore::RenderPart::updateWidgetPosition):
rendering/RenderPath.cpp: (WebCore::RenderPath::layout): (WebCore::RenderPath::paint): (WebCore::RenderPath::absoluteOutlineBounds):
rendering/RenderPath.h:
rendering/RenderReplaced.cpp: (WebCore::RenderReplaced::layout): (WebCore::RenderReplaced::paint): (WebCore::RenderReplaced::shouldPaint): (WebCore::RenderReplaced::positionForCoordinates): (WebCore::RenderReplaced::localSelectionRect): (WebCore::RenderReplaced::adjustOverflowForBoxShadow): (WebCore::RenderReplaced::overflowRect):
rendering/RenderReplica.cpp: (WebCore::RenderReplica::layout): (WebCore::RenderReplica::calcPrefWidths): (WebCore::RenderReplica::paint):
rendering/RenderSVGContainer.cpp: (WebCore::RenderSVGContainer::paint): (WebCore::RenderSVGContainer::absoluteOutlineBounds):
rendering/RenderSVGContainer.h: (WebCore::RenderSVGContainer::width): (WebCore::RenderSVGContainer::height):
rendering/RenderSVGImage.cpp: (WebCore::RenderSVGImage::layout):
rendering/RenderSVGInlineText.cpp: (WebCore::RenderSVGInlineText::computeAbsoluteRectForRange): (WebCore::RenderSVGInlineText::positionForCoordinates):
rendering/RenderSVGRoot.cpp: (WebCore::RenderSVGRoot::layout): (WebCore::RenderSVGRoot::applyContentTransforms): (WebCore::RenderSVGRoot::paint): (WebCore::RenderSVGRoot::absoluteTransform): (WebCore::RenderSVGRoot::nodeAtPoint):
rendering/RenderSVGTSpan.cpp: (WebCore::RenderSVGTSpan::absoluteRects): (WebCore::RenderSVGTSpan::absoluteQuads):
rendering/RenderSVGText.cpp: (WebCore::RenderSVGText::layout): (WebCore::RenderSVGText::relativeBBox):
rendering/RenderSVGTextPath.cpp: (WebCore::RenderSVGTextPath::absoluteRects): (WebCore::RenderSVGTextPath::absoluteQuads):
rendering/RenderSVGViewportContainer.cpp: (WebCore::RenderSVGViewportContainer::nodeAtPoint):
rendering/RenderScrollbar.cpp: (WebCore::RenderScrollbar::createCustomScrollbar): (WebCore::RenderScrollbar::RenderScrollbar): (WebCore::RenderScrollbar::setParent):
rendering/RenderScrollbar.h: (WebCore::RenderScrollbar::owningRenderer):
rendering/RenderScrollbarPart.cpp: (WebCore::RenderScrollbarPart::layout): (WebCore::RenderScrollbarPart::layoutHorizontalPart): (WebCore::RenderScrollbarPart::layoutVerticalPart): (WebCore::RenderScrollbarPart::computeScrollbarWidth): (WebCore::RenderScrollbarPart::computeScrollbarHeight): (WebCore::RenderScrollbarPart::paintIntoRect):
rendering/RenderSlider.cpp: (WebCore::HTMLSliderThumbElement::defaultEventHandler): (WebCore::RenderSlider::layout): (WebCore::RenderSlider::mouseEventIsInThumb): (WebCore::RenderSlider::positionForOffset): (WebCore::RenderSlider::trackSize):
rendering/RenderTable.cpp: (WebCore::RenderTable::calcWidth): (WebCore::RenderTable::layout): (WebCore::RenderTable::paint): (WebCore::RenderTable::getBaselineOfFirstLineBox):
rendering/RenderTableCell.cpp: (WebCore::RenderTableCell::updateWidth): (WebCore::RenderTableCell::computeAbsoluteRepaintRect): (WebCore::RenderTableCell::localToAbsolute): (WebCore::RenderTableCell::absoluteToLocal): (WebCore::RenderTableCell::localToAbsoluteQuad): (WebCore::RenderTableCell::paint): (WebCore::RenderTableCell::paintBackgroundsBehindCell):
rendering/RenderTableCell.h:
rendering/RenderTableSection.cpp: (WebCore::RenderTableSection::addChild): (WebCore::RenderTableSection::addCell): (WebCore::RenderTableSection::setCellWidths): (WebCore::RenderTableSection::calcRowHeight): (WebCore::RenderTableSection::layoutRows): (WebCore::RenderTableSection::lowestPosition): (WebCore::RenderTableSection::rightmostPosition): (WebCore::RenderTableSection::leftmostPosition): (WebCore::RenderTableSection::getBaselineOfFirstLineBox): (WebCore::RenderTableSection::paint): (WebCore::RenderTableSection::recalcCells): (WebCore::RenderTableSection::nodeAtPoint):
rendering/RenderTableSection.h: (WebCore::RenderTableSection::overflowWidth): (WebCore::RenderTableSection::overflowHeight):
rendering/RenderText.cpp: (WebCore::RenderText::RenderText): (WebCore::RenderText::boundingBoxX): (WebCore::RenderText::boundingBoxY): (WebCore::RenderText::firstRunX): (WebCore::RenderText::firstRunY): (WebCore::RenderText::boundingBoxHeight): (WebCore::RenderText::boundingBoxWidth):
rendering/RenderText.h:
rendering/RenderTextControl.cpp: (WebCore::RenderTextControl::textBlockHeight): (WebCore::RenderTextControl::textBlockWidth): (WebCore::RenderTextControl::setSelectionRange): (WebCore::RenderTextControl::calcHeight): (WebCore::RenderTextControl::hitInnerTextBlock): (WebCore::RenderTextControl::controlClipRect):
rendering/RenderTextControlMultiLine.cpp: (WebCore::RenderTextControlMultiLine::layout): (WebCore::RenderTextControlMultiLine::adjustControlHeightBasedOnLineHeight):
rendering/RenderTextControlSingleLine.cpp: (WebCore::RenderTextControlSingleLine::paint): (WebCore::RenderTextControlSingleLine::layout): (WebCore::RenderTextControlSingleLine::nodeAtPoint): (WebCore::RenderTextControlSingleLine::forwardEvent): (WebCore::RenderTextControlSingleLine::textBlockWidth): (WebCore::RenderTextControlSingleLine::adjustControlHeightBasedOnLineHeight): (WebCore::RenderTextControlSingleLine::clientPaddingLeft): (WebCore::RenderTextControlSingleLine::clientPaddingRight):
rendering/RenderTheme.cpp: (WebCore::RenderTheme::hitTestMediaControlPart): (WebCore::RenderTheme::baselinePosition):
rendering/RenderThemeMac.mm: (WebCore::RenderThemeMac::paintSearchFieldCancelButton): (WebCore::RenderThemeMac::paintSearchFieldResultsDecoration): (WebCore::RenderThemeMac::paintSearchFieldResultsButton): (WebCore::RenderThemeMac::hitTestMediaControlPart):
rendering/RenderTreeAsText.cpp: (WebCore::operator<<):
rendering/RenderVideo.cpp: (WebCore::RenderVideo::videoBox):
rendering/RenderView.cpp: (WebCore::RenderView::RenderView): (WebCore::RenderView::calcHeight): (WebCore::RenderView::calcWidth): (WebCore::RenderView::layout): (WebCore::RenderView::viewRect): (WebCore::RenderView::docHeight): (WebCore::RenderView::docWidth): (WebCore::RenderView::setBestTruncatedAt):
rendering/RenderView.h:
rendering/RenderWidget.cpp: (WebCore::RenderWidget::paint): (WebCore::RenderWidget::updateWidgetPosition): (WebCore::RenderWidget::nodeAtPoint):
rendering/RootInlineBox.h: (WebCore::RootInlineBox::floats): (WebCore::RootInlineBox::floatsPtr):
rendering/SVGInlineFlowBox.cpp: (WebCore::SVGInlineFlowBox::verticallyAlignBoxes):
rendering/SVGInlineFlowBox.h:
rendering/SVGRenderTreeAsText.cpp: (WebCore::operator<<): (WebCore::write):
rendering/SVGRootInlineBox.cpp: (WebCore::SVGRootInlineBox::verticallyAlignBoxes): (WebCore::SVGRootInlineBox::computePerCharacterLayoutInformation): (WebCore::SVGRootInlineBox::layoutInlineBoxes):
rendering/SVGRootInlineBox.h:
rendering/bidi.cpp: (WebCore::RenderBlock::computeHorizontalPositionsForLine): (WebCore::RenderBlock::computeVerticalPositionsForLine): (WebCore::RenderBlock::layoutInlineChildren): (WebCore::RenderBlock::determineStartPosition): (WebCore::RenderBlock::matchedEndLine): (WebCore::RenderBlock::skipTrailingWhitespace): (WebCore::RenderBlock::skipLeadingWhitespace): (WebCore::RenderBlock::fitBelowFloats): (WebCore::RenderBlock::findNextLineBreak): (WebCore::RenderBlock::checkLinesForOverflow):
svg/SVGLength.cpp: (WebCore::SVGLength::PercentageOfViewport):

WebKit/mac:

2009-01-21 David Hyatt <hyatt@apple.com>

Devirtualize width/height/x/y on RenderObject and move the methods to RenderBox.

Reviewed by Eric Seidel and Darin Adler

WebView/WebRenderNode.mm: (copyRenderNode):

5:39 PM Changeset in webkit [40106] by andersca@apple.com

8 edits in trunk/WebKit/mac

2009-01-21 Anders Carlsson <andersca@apple.com>

Reviewed by Sam Weinig.

More browser->plug-in scripting support.

Plugins/Hosted/NetscapePluginHostProxy.mm: (WKPCNPObjectHasPropertyReply): (WKPCNPObjectHasMethodReply): (WKPCNPObjectInvokeReply): MIG reply functions.

(WKPCIdentifierInfo):
Return information about an identifier given its 64-bit value.

Plugins/Hosted/NetscapePluginInstanceProxy.h: Add new reply structs.

Plugins/Hosted/NetscapePluginInstanceProxy.mm: (WebKit::NetscapePluginInstanceProxy::addValueToArray): Split out code that adds values to the arrays from marshalValue.

(WebKit::NetscapePluginInstanceProxy::marshalValue):
Call addValueToArray.

(WebKit::NetscapePluginInstanceProxy::marshalValues):
Marshal a list of values.

(WebKit::NetscapePluginInstanceProxy::createBindingsInstance):
Actually create a proxy instance.

Plugins/Hosted/ProxyInstance.h:
Plugins/Hosted/ProxyInstance.mm: (WebKit::ProxyClass::methodsNamed): (WebKit::ProxyClass::fieldNamed): Add a proxy ProxyClass class that just forwards everything to the ProxyInstance class.

(WebKit::proxyClass):
Shared proxyClass getter.

(WebKit::ProxyField::ProxyField):
(WebKit::ProxyField::valueFromInstance):
(WebKit::ProxyField::setValueToInstance):
Add a proxy ProxyField class that just forwards everything to the ProxyInstance class.

(WebKit::ProxyMethod::ProxyMethod):
(WebKit::ProxyMethod::serverIdentifier):
(WebKit::ProxyMethod::numParameters):
Add a dummy ProxyMethod class.

(WebKit::ProxyInstance::invokeMethod):
Call _WKPHNPObjectInvoke.

(WebKit::ProxyInstance::defaultValue):
(WebKit::ProxyInstance::stringValue):
(WebKit::ProxyInstance::numberValue):
(WebKit::ProxyInstance::booleanValue):
(WebKit::ProxyInstance::valueOf):
Add dummy implementations (taken from CInstance).

(WebKit::ProxyInstance::methodsNamed):
Call _WKPHNPObjectHasMethod to determine whether a method with the given name exists.

(WebKit::ProxyInstance::fieldNamed):
Call _WKPHNPObjectHasProperty to determine whether a property with the given name exists.

Plugins/Hosted/WebKitPluginClient.defs:
Plugins/Hosted/WebKitPluginHost.defs: Add new MIG definitions.

5:39 PM Changeset in webkit [40105] by pol@apple.com

2 edits in trunk/WebKitTools

2009-01-21 Pierre-Olivier Latour <pol@apple.com>

Tweaked earlier fix to only print a warning when Perian is installed,
and fail completely only if attempting to generate new pixel test results.

https://bugs.webkit.org/show_bug.cgi?id=23392

Scripts/run-webkit-tests:

4:50 PM Changeset in webkit [40104] by andersca@apple.com

3 edits in trunk/WebCore

2009-01-21 Anders Carlsson <andersca@apple.com>

Reviewed by Sam Weinig.

WebCore.LP64.exp: Add some bridge related symbols.

WebCore.xcodeproj/project.pbxproj: Make runtime_object.h a private header.

4:22 PM Changeset in webkit [40103] by oliver@apple.com

10 edits
5 adds in trunk/WebCore

Bug 22720: Make XMLHttpRequest work in Workers
<https://bugs.webkit.org/show_bug.cgi?id=22720>

Contributed by David Levin.

Reviewed by Alexey Proskuryakov

More removal of document usage from XMLHttpRequest.

Abstracted away the sync and async requests behind the ThreadableLoader class, which will get an implementation for Workers. It follows the same model as SubresourceLoader, since it is a thin wrapper around it.
Consolidated dashboard compatibility checks into usesDashboardBackwardCompatibilityMode which handles workers.

No observable change in behavior, so no test.

4:13 PM Changeset in webkit [40102] by cmarrin@apple.com

6 edits
2 adds in trunk

Fix for https://bugs.webkit.org/show_bug.cgi?id=23317

The high CPU usage was really from repeatedly firing transitions caused
by a bug in the way we handle background-color animations. If animating
from a valid background color to no background color, we sometimes left
(based on timing) the background color as transparent black, but valid
rather than invalid, which it should be. Fixing that got rid of the
repeated firing.

But we really were doing more expensive iteration of all objects with
animations or transitions on them (running or not). So I added two
optimizations to quickly short circuit when an object had no running
animations or transitions. Things are now as zippy as ever.

3:37 PM Changeset in webkit [40101] by eric@webkit.org

5 edits in trunk

Reviewed by Justin Garcia.

Remove the style= turds left by some editing commands
https://bugs.webkit.org/show_bug.cgi?id=23463

Test: editing/execCommand/toggle-styles.html

editing/ApplyStyleCommand.cpp: (WebCore::ApplyStyleCommand::removeCSSStyle): check if we just removed the last CSS property and remove the style attribute as well
editing/CompositeEditCommand.cpp: (WebCore::CompositeEditCommand::removeNodeAttribute): remove extra ;

3:25 PM Changeset in webkit [40100] by mrowe@apple.com

6 edits in trunk/WebKit/mac

Clean up how we force invocations of API that happened on background threads over to the main thread.

This was previously accomplished in a somewhat ad-hoc manner using a mutable dictionary to pass arguments
and return values back from the function. The new approach is to use a proxy object that forwards an
NSInvocation over to the main thread and applies it to the target object, which leads to a much cleaner
call site.

Reviewed by Tim Hatcher.

Misc/WebNSObjectExtras.h:
Misc/WebNSObjectExtras.mm:

(-[WebMainThreadInvoker initWithTarget:]):
(-[WebMainThreadInvoker forwardInvocation:]):
(-[WebMainThreadInvoker methodSignatureForSelector:]):
(-[WebMainThreadInvoker handleException:]):
(-[NSInvocation _webkit_invokeAndHandleException:]): Execute the invocation and forward any exception that was
raised back to the WebMainThreadInvoker.
(-[NSObject _webkit_invokeOnMainThread]):

The following methods are updated to use the proxy object to forward methods to the main thread:

WebView/WebArchive.mm:

(-[WebArchive initWithMainResource:subresources:subframeArchives:]):
(-[WebArchive mainResource]):
(-[WebArchive subresources]):
(-[WebArchive subframeArchives]):

WebView/WebResource.mm:

(-[WebResource data]):
(-[WebResource URL]):
(-[WebResource MIMEType]):
(-[WebResource textEncodingName]):
(-[WebResource frameName]):
(-[WebResource _ignoreWhenUnarchiving]):
(-[WebResource _initWithData:URL:MIMEType:textEncodingName:frameName:response:copyData:]):
(-[WebResource _initWithData:URL:response:]):
(-[WebResource _suggestedFilename]):
(-[WebResource _response]):
(-[WebResource _stringValue]):

WebView/WebView.mm:

(-[WebView initWithFrame:frameName:groupName:]):
(-[WebView initWithCoder:]):

3:20 PM Changeset in webkit [40099] by eric@webkit.org

2 edits in trunk/WebCore

No review, build fix.

Fix release-only build failure (and do a tiny code-cleanup).

editing/ApplyStyleCommand.cpp: (WebCore::createFontElement): (WebCore::createStyleSpanElement): (WebCore::ApplyStyleCommand::addInlineStyleIfNeeded):

2:55 PM Changeset in webkit [40098] by Chris Fleizach

10 edits
2 adds in trunk

Bug 23443: Table accessibility should be re-enabled after fixing crash that occurs at WebCore::AccessibilityTable::isTableExposableThroughAccessibility() when attempting to create a link in a rich text message
https://bugs.webkit.org/show_bug.cgi?id=23443

Re-enable Accessibility tables and make sure accessibility code does not interrogate the render tree
during render tree updates

2:16 PM Changeset in webkit [40097] by eric@webkit.org

8 edits in trunk

Reviewed by Justin Garcia.

Fix execCommand() 'super' and 'sub' commands to add <sup> and <sub> in quirks mode, and to toggle when called twice
https://bugs.webkit.org/show_bug.cgi?id=17733

Test changed: editing/execCommand/toggle-styles-expected.txt

editing/ApplyStyleCommand.cpp: (WebCore::StyleChange::applySubscript): (WebCore::StyleChange::applySuperscript): (WebCore::StyleChange::StyleChange): (WebCore::StyleChange::init): (WebCore::StyleChange::checkForLegacyHTMLStyleChange): (WebCore::ApplyStyleCommand::isHTMLStyleNode): (WebCore::ApplyStyleCommand::addInlineStyleIfNeeded):
editing/EditorCommand.cpp: (WebCore::executeSubscript): (WebCore::executeSuperscript):
editing/htmlediting.cpp: (WebCore::createHTMLElement):
editing/htmlediting.h:

1:52 PM Changeset in webkit [40096] by andersca@apple.com

2 edits in trunk/WebCore

2009-01-21 Anders Carlsson <andersca@apple.com>

Fix 64-bit build.

WebCore.LP64.exp:

1:34 PM Changeset in webkit [40095] by mrowe@apple.com

1 copy in tags/Safari-5525.28

New tag.

1:32 PM Changeset in webkit [40094] by mrowe@apple.com

4 edits in branches/Safari-3-2-branch

Versioning.

1:25 PM Changeset in webkit [40093] by mrowe@apple.com

1 edit in branches/Safari-3-2-branch/WebKitLibraries/win/tools/scripts/PRODUCTVERSION

Bump version number.

1:25 PM Changeset in webkit [40092] by mrowe@apple.com

9 edits
5 adds in branches/Safari-3-2-branch

Merge r33579.

1:25 PM Changeset in webkit [40091] by mrowe@apple.com

2 edits in branches/Safari-3-2-branch/WebCore

Merge r33993.

1:24 PM Changeset in webkit [40090] by mrowe@apple.com

2 edits in branches/Safari-3-2-branch/WebCore

Merge r39247.

1:05 PM Changeset in webkit [40089] by oliver@apple.com

13 edits
3 copies in trunk/WebCore

Bug 23458: Reintroduce CanvasPixelArray in ImageData.idl
<https://bugs.webkit.org/show_bug.cgi?id=23458>

Reviewed by Alexey Proskuryakov.

Return CanvasPixelArray, et al -- the only difference between this
and the original CPA implementation is that it now uses a ByteArray
rather than a vector. JSC still uses a custom wrapper, but this allows
ObjC, COM, and V8 bindings to be autogenerated again.

12:07 PM Changeset in webkit [40088] by krit@webkit.org

13 edits
4 deletes in trunk/WebCore

2009-01-21 Dirk Schulze <krit@webkit.org>

Reviewed by Nikolas Zimmermann.

Remove last relics of platform dependent PaintServer in SVG.
We draw everything with the help of GraphicsContext.

Remove SVGPaintServerPlatform's
https://bugs.webkit.org/show_bug.cgi?id=23439

GNUmakefile.am:
WebCore.pro:
WebCore.vcproj/WebCore.vcproj:
WebCore.xcodeproj/project.pbxproj:
svg/graphics/SVGPaintServer.cpp: (WebCore::SVGPaintServer::draw): (WebCore::SVGPaintServer::renderPath): (WebCore::SVGPaintServer::teardown):
svg/graphics/SVGPaintServer.h:
svg/graphics/SVGPaintServerGradient.cpp:
svg/graphics/SVGPaintServerGradient.h:
svg/graphics/SVGPaintServerPattern.cpp:
svg/graphics/SVGPaintServerPattern.h:
svg/graphics/SVGPaintServerSolid.cpp:
svg/graphics/SVGPaintServerSolid.h:
svg/graphics/cairo/SVGPaintServerCairo.cpp: Removed.
svg/graphics/cg/SVGPaintServerCg.cpp: Removed.
svg/graphics/qt/SVGPaintServerQt.cpp: Removed.
svg/graphics/skia/SVGPaintServerSkia.cpp: Removed.

11:49 AM Changeset in webkit [40087] by Nikolas Zimmermann

7 edits in trunk/WebCore

Reviewed by Alexey Proskuryakov.

Move "Element -> ScriptElement" casting functionality into ScriptElement.h
to be consistent with FormControlElement/InputElement/OptionElement/OptionGroupElement.

It was living in XMLTokenizer before, which is not an obvious place for this.
TODO: Rename 'formControlElementForElement' to 'toFormControlElement' (analogous changes for InputElement etc.)

as suggested by Alexey, it really reads better this way.

10:09 AM Changeset in webkit [40086] by ap@webkit.org

2 edits in trunk/JavaScriptCore

Suggested by Oliver Hunt. Reviewed by Oliver Hunt.

https://bugs.webkit.org/show_bug.cgi?id=23456
Function argument names leak

parser/Nodes.cpp: (JSC::FunctionBodyNode::~FunctionBodyNode): Destruct parameter names.

8:44 AM Changeset in webkit [40085] by Nikolas Zimmermann

12 edits
4 adds in trunk/WebCore

Reviewed by George Staikos.

Fixes: https://bugs.webkit.org/show_bug.cgi?id=23444

Refactor some functionality from HTMLOption/OptGroupElement needed by RenderListBox/RenderMenuList
in two abstract base classes: OptionElement & OptionGroupElement living in dom/ - just like it
has been done before for FormControlElement and RenderTextControl.

This is needed to prepare the addtion of WMLOption/OptGroupElement.

7:22 AM QtWebKitJournal edited by Simon Hausmann

(diff)

7:22 AM QtWebKitJournal edited by Simon Hausmann

(diff)

Jan 20, 2009:

11:39 PM Changeset in webkit [40084] by Darin Adler

2 edits in trunk/WebCore

2009-01-20 Darin Adler <Darin Adler>

Reviewed by Alexey Proskuryakov.

Bug 23448: memory leak in Mac version of preferredExtensionForImageSourceType
https://bugs.webkit.org/show_bug.cgi?id=23448

platform/graphics/cg/ImageSourceCGMac.mm: (WebCore::preferredExtensionForImageSourceType): Use RetainPtr to avoid the leak.

11:25 PM Changeset in webkit [40083] by Darin Adler

2 edits in trunk/WebKitTools

2009-01-20 Darin Adler <Darin Adler>

Reviewed by Alexey Proskuryakov.

Bug 23450: string leaks seen in DumpRenderTree accessibility test code
https://bugs.webkit.org/show_bug.cgi?id=23450

DumpRenderTree/AccessibilityUIElement.cpp: (isAttributeSettableCallback): Add the missing JSStringRelease call. (attributeValueCallback): Ditto.

10:38 PM Changeset in webkit [40082] by Darin Adler

2 edits in trunk/WebCore

2009-01-20 Darin Adler <Darin Adler>

Try to fix Wx build.

platform/wx/PasteboardWx.cpp: (WebCore::Pasteboard::writeSelection): Removed code that replaces backslash with backslashAsCurrencySymbol. I'm pretty sure this is not needed when writing to the clipboard. Other platforms don't do it. If it was needed, the new function to use would be displayStringModifiedByEncoding.

9:28 PM Changeset in webkit [40081] by bfulgham@webkit.org

2 edits in trunk/WebCore

Teach Cairo post-build stage to copy animation headers.

8:49 PM Changeset in webkit [40080] by alp@webkit.org

3 edits in trunk/WebCore

2009-01-20 Dmitry Titov <dimich@chromium.org>

Reviewed by Alexey Proskuryakov.

https://bugs.webkit.org/show_bug.cgi?id=23413
Remove unused WebCore::setDeferringTimers()

platform/Timer.cpp: (WebCore::updateSharedTimer):
platform/Timer.h:

7:51 PM Changeset in webkit [40079] by oliver@apple.com

2 edits in trunk/JavaScriptCore

Windows build fix

7:19 PM Changeset in webkit [40078] by hyatt@apple.com

3 edits in trunk/WebCore

2009-01-20 David Hyatt <hyatt@apple.com>

Tighten up the type of RenderObject owned by RenderLayer to be a RenderBox. Rename m_object to
m_renderer to be consistent with the corresponding member function.

Reviewed by Jon Honeycutt

rendering/RenderLayer.cpp: (WebCore::RenderLayer::RenderLayer): (WebCore::RenderLayer::updateLayerPositions): (WebCore::RenderLayer::updateVisibilityStatus): (WebCore::RenderLayer::updateLayerPosition): (WebCore::RenderLayer::stackingContext): (WebCore::RenderLayer::enclosingPositionedAncestor): (WebCore::RenderLayer::enclosingTransformedAncestor): (WebCore::RenderLayer::isTransparent): (WebCore::RenderLayer::convertToLayerCoords): (WebCore::RenderLayer::scrollByRecursively): (WebCore::RenderLayer::scrollToOffset): (WebCore::RenderLayer::scrollRectToVisible): (WebCore::RenderLayer::resize): (WebCore::RenderLayer::scrollbarCornerPresent): (WebCore::RenderLayer::createScrollbar): (WebCore::RenderLayer::setHasHorizontalScrollbar): (WebCore::RenderLayer::setHasVerticalScrollbar): (WebCore::RenderLayer::positionOverflowControls): (WebCore::RenderLayer::computeScrollDimensions): (WebCore::RenderLayer::updateOverflowStatus): (WebCore::RenderLayer::updateScrollInfoAfterLayout): (WebCore::RenderLayer::paintOverflowControls): (WebCore::RenderLayer::paintScrollCorner): (WebCore::RenderLayer::paintResizer): (WebCore::RenderLayer::isPointInResizeControl): (WebCore::RenderLayer::paintLayer): (WebCore::RenderLayer::hitTestLayer): (WebCore::RenderLayer::updateClipRects): (WebCore::RenderLayer::calculateClipRects): (WebCore::RenderLayer::calculateRects): (WebCore::RenderLayer::clearClipRects): (WebCore::RenderLayer::repaintIncludingDescendants): (WebCore::RenderLayer::styleChanged): (WebCore::RenderLayer::updateScrollCornerStyle): (WebCore::RenderLayer::updateResizerStyle):
rendering/RenderLayer.h: (WebCore::RenderLayer::renderer): (WebCore::RenderLayer::hasReflection): (WebCore::RenderLayer::hasTransform):

5:59 PM Changeset in webkit [40077] by hyatt@apple.com

2 edits in trunk/WebCore

2009-01-20 David Hyatt <hyatt@apple.com>

Fix Mac build bustage from my selection changes. I forgot to implement the functions on RenderThemeMac
for returning the appropriate listbox selection colors.

Reviewed by Adele

rendering/RenderThemeMac.mm: (WebCore::RenderThemeMac::platformActiveListBoxSelectionForegroundColor): (WebCore::RenderThemeMac::platformInactiveListBoxSelectionForegroundColor): (WebCore::RenderThemeMac::platformInactiveListBoxSelectionBackgroundColor):

5:53 PM Changeset in webkit [40076] by barraclough@apple.com

2 edits in trunk/JavaScriptCore

2009-01-20 Gavin Barraclough <barraclough@apple.com>

Reviewed by Mark Rowe.

Structure property table deleted offset maps are being leaked.
Probably shouldn't be doing that.

https://bugs.webkit.org/show_bug.cgi?id=23442

runtime/Structure.cpp: (JSC::Structure::~Structure):

4:30 PM Changeset in webkit [40075] by pol@apple.com

3 edits in trunk/WebKitTools

2009-01-20 Pierre-Olivier Latour <pol@apple.com>

Reviewed by Darin Adler.

Print warning regarding display color profile change in run-webkit-tests instead of DRT.

https://bugs.webkit.org/show_bug.cgi?id=23392

DumpRenderTree/mac/PixelDumpSupportMac.mm: (setupMainDisplayColorProfile):
Scripts/run-webkit-tests:

3:31 PM Changeset in webkit [40074] by hyatt@apple.com

8 edits in trunk/WebCore

Fix selection colors and focus rings on Windows.

3:25 PM Changeset in webkit [40073] by pol@apple.com

3 edits in trunk/WebKitTools

2009-01-20 Pierre-Olivier Latour <pol@apple.com>

Reviewed by Darin Adler.

Changed run-webkit-tests to abort on the Mac if pixel tests are enabled and Perian is installed,
in order to avoid result differences in some media tests.

https://bugs.webkit.org/show_bug.cgi?id=22615

Scripts/run-webkit-tests:
Scripts/webkitdirs.pm:

2:35 PM Changeset in webkit [40072] by oliver@apple.com

2 edits in trunk/JavaScriptCore

Attempt to fix gtk build

2:29 PM Changeset in webkit [40071] by Nikolas Zimmermann

12 edits
6 adds in trunk

Reviewed by George Staikos.

Fixes: https://bugs.webkit.org/show_bug.cgi?id=23434

Add WML <input> element support - it required a lot of changes to the RenderText*/HTMLInput* code.
Now any language can provide <input>-style elements, without having to inherit from HTML* classes.

No WML specific features/attributes are handled so far. A follow-up patch will provide those bits.
Added very simple fast/wml/input.wml, just checking that input elements can be rendered properly now.
Detailed testcases will follow in conjunction with the WML specific attribute support.

1:54 PM Changeset in webkit [40070] by Darin Adler

2 edits in trunk/WebCore

2009-01-20 Darin Adler <Darin Adler>

Reviewed by John Sullivan.

Remove a little dead code left over after the fix for
https://bugs.webkit.org/show_bug.cgi?id=11395, which
moved pointer-events from SVG to be shared with HTML.

css/SVGCSSParser.cpp: (WebCore::CSSParser::parseSVGValue): Remove SVG's parsing of this property since it's handled in the non-SVG function now so we'll never get here.

1:54 PM Changeset in webkit [40069] by jchaffraix@webkit.org

8 edits in trunk/WebCore

009-01-20 Julien Chaffraix <jchaffraix@webkit.org>

Reviewed by Darin Adler.

Bug 23438: Provide a default value to the .in file parser

Added the default value 1 as it simplifies some of
the format by removing some "=1" that were awkward.

This was suggested by Darin Adler as par of a previous
review.

bindings/scripts/InFilesParser.pm: When no value was entered (the second part of the split is undef), provide the default value.

html/HTMLAttributeNames.in: Removed unnecessary "=1".
html/HTMLTagNames.in: Ditto.
svg/svgattrs.in: Ditto.
svg/svgtags.in: Ditto.
svg/xlinkattrs.in: Ditto.
wml/WMLAttributeNames.in: Ditto.

1:41 PM Changeset in webkit [40068] by andersca@apple.com

11 edits in trunk/WebCore

2009-01-20 Anders Carlsson <andersca@apple.com>

Reviewed by Darin Adler.

bridge/c/c_class.cpp:
bridge/c/c_class.h: Get rid of CClass::name().

bridge/jni/jni_class.h: Get rid of JavaClass::name().

bridge/objc/objc_class.h:
bridge/objc/objc_class.mm: Get rid of ObjcClass::name().

bridge/objc/objc_instance.h: Get rid of supportsSetValueOfUndefinedField.

bridge/objc/objc_instance.mm: (ObjcInstance::setValueOfUndefinedField): Fold supportsSetValueOfUndefinedField into setValueOfUndefinedField.

bridge/runtime.cpp: Get rid of getValueOfField and setValueOfField.

bridge/runtime.h: (JSC::Bindings::Instance::setValueOfUndefinedField): Have this return a bool and get rid of supportsSetValueOfUndefinedField

bridge/runtime_object.cpp: (JSC::RuntimeObjectImp::fieldGetter): Call Field::valueFromInstance on the field.

(JSC::RuntimeObjectImp::put):
Call Field::setValueToInstance on the field.

1:29 PM Changeset in webkit [40067] by Nikolas Zimmermann

6 edits in trunk/WebCore

Not reviewed. Forgot to land build changes for non-mac platforms.
Add InputElement.cpp & FormControlElement.cpp to build.

1:18 PM Changeset in webkit [40066] by Nikolas Zimmermann

2 edits in trunk/WebCore

Reviewed by Adam Roben.

Fix last-minute regression, introduced by simplifying max length determination - by
clamping using min/max, negative maxLength values got broken.

1:02 PM Changeset in webkit [40065] by Nikolas Zimmermann

9 edits
3 adds in trunk/WebCore

Reviewed by Adam Roben.

Fixes: https://bugs.webkit.org/show_bug.cgi?id=23433

Add InputElement abstraction, similar to the FormControlElement refactorization
done a month ago. The goal is to share as much code as possible between HTML/WMLInputElement.
In a previous patch the RenderTextControl class has been split-up in RenderTextControlSingle/MultiLine,
RenderTextControl itself only depends on FormControlElement, RenderTextControlSingleLine still
depends on HTMLInputElement directly -> change that and make it use the new InputElement abstraction.

A lot of code from HTMLInputElement now lives in InputElement, as static member functions - the
InputElement class itself is an abstract virtual class, just like ScriptElement. HTML/WMLInputElement
derive from InputElement, and hold a InputElementData member variable, that they pass to the
static functions in InputElement. The abstraction is equal to the one chosen for HTML/SVGScriptElement.

12:54 PM Changeset in webkit [40064] by pol@apple.com

3 edits in trunk/LayoutTests

2009-01-20 Pierre-Olivier Latour <pol@apple.com>

Previously uploaded reference images were generated with Perian installed, which affected them
as explained in https://bugs.webkit.org/show_bug.cgi?id=22615.

platform/mac/media/video-zoom-expected.checksum:
platform/mac/media/video-zoom-expected.png:

11:52 AM Changeset in webkit [40063] by krit@webkit.org

14 edits
4 deletes in trunk

2009-01-20 Dirk Schulze <krit@webkit.org>

Reviewed by Nikolas Zimmermann.

Make SVG pattern platform independent and remove platform code.

Make SVGPattern platform independent
https://bugs.webkit.org/show_bug.cgi?id=21205

GNUmakefile.am:
WebCore.pro:
WebCore.vcproj/WebCore.vcproj:
WebCore.xcodeproj/project.pbxproj:
platform/graphics/GraphicsContext.h:
platform/graphics/cg/GraphicsContextCG.cpp: (WebCore::GraphicsContext::applyStrokePattern): (WebCore::GraphicsContext::applyFillPattern): (WebCore::GraphicsContext::drawPath): (WebCore::GraphicsContext::fillPath): (WebCore::GraphicsContext::strokePath): (WebCore::GraphicsContext::fillRect): (WebCore::GraphicsContext::strokeRect):
svg/graphics/SVGPaintServerPattern.cpp: (WebCore::SVGPaintServerPattern::SVGPaintServerPattern): (WebCore::SVGPaintServerPattern::~SVGPaintServerPattern): (WebCore::SVGPaintServerPattern::setup): (WebCore::SVGPaintServerPattern::renderPath): (WebCore::SVGPaintServerPattern::teardown):
svg/graphics/SVGPaintServerPattern.h:
svg/graphics/cairo/SVGPaintServerPatternCairo.cpp: Removed.
svg/graphics/cg/SVGPaintServerPatternCg.cpp: Removed.
svg/graphics/qt/SVGPaintServerPatternQt.cpp: Removed.
svg/graphics/skia/SVGPaintServerPatternSkia.cpp: Removed.

LayoutTests:

stroke-pattern is wrong and coords-units-01-b match the behavior of
batik and Firefox.

platform/mac/svg/W3C-SVG-1.1/coords-units-01-b-expected.checksum:
platform/mac/svg/W3C-SVG-1.1/coords-units-01-b-expected.png:
platform/mac/svg/custom/stroked-pattern-expected.checksum:
platform/mac/svg/custom/stroked-pattern-expected.png:

11:39 AM Changeset in webkit [40062] by darin@chromium.org

1 edit
6 adds in trunk/WebCore

2009-01-20 Darin Fisher <darin@chromium.org>

Reviewed by Eric Seidel.

https://bugs.webkit.org/show_bug.cgi?id=23436
Upstream rendering/RenderThemeChromium*

rendering/RenderThemeChromiumGtk.cpp: Added.
rendering/RenderThemeChromiumGtk.h: Added.
rendering/RenderThemeChromiumMac.h: Added.
rendering/RenderThemeChromiumMac.mm: Added.
rendering/RenderThemeChromiumWin.cpp: Added.
rendering/RenderThemeChromiumWin.h: Added.

11:33 AM Changeset in webkit [40061] by andersca@apple.com

9 edits
2 adds in trunk/WebKit

WebKit:

2009-01-20 Anders Carlsson <andersca@apple.com>

Reviewed by Sam Weinig.

Add ProxyInstance files.

WebKit.xcodeproj/project.pbxproj:

WebKit/mac:

2009-01-19 Anders Carlsson <andersca@apple.com>

Reviewed by Sam Weinig.

Add and implement GetScriptableNPObject.

Plugins/Hosted/NetscapePluginHostProxy.mm: (WKPCGetScriptableNPObjectReply): Create a new reply struct and set it as the current reply.

(WKPCEvaluate):
Get rid of an unused variable.

Plugins/Hosted/NetscapePluginInstanceProxy.h: (WebKit::NetscapePluginInstanceProxy::Reply::): (WebKit::NetscapePluginInstanceProxy::GetScriptableNPObjectReply::GetScriptableNPObjectReply):
Plugins/Hosted/NetscapePluginInstanceProxy.mm: (WebKit::NetscapePluginInstanceProxy::createBindingsInstance): Call _WKPHGetScriptableNPObject and wait for a reply.

Plugins/Hosted/ProxyInstance.h: Added.
Plugins/Hosted/ProxyInstance.mm: Added. Add empty files.

Plugins/Hosted/WebHostedNetscapePluginView.mm: (-[WebHostedNetscapePluginView JSC::Bindings::createPluginBindingsInstance:JSC::Bindings::]): Call NetscapePluginInstanceProxy::createBindingsInstance.

Plugins/Hosted/WebKitPluginClient.defs:
Plugins/Hosted/WebKitPluginHost.defs: Add new declarations.

10:38 AM Changeset in webkit [40060] by Darin Adler

2 edits in trunk/JavaScriptCore

2009-01-20 Darin Adler <Darin Adler>

runtime/StringPrototype.cpp: (JSC::substituteBackreferences): Add back the initialization to fix the build.

10:25 AM Changeset in webkit [40059] by Darin Adler

15 edits in trunk

JavaScriptCore:

2009-01-20 Darin Adler <Darin Adler>

Reviewed by Mark Rowe.

Bug 23352: Turn on more compiler warnings in the Mac build
https://bugs.webkit.org/show_bug.cgi?id=23352

First patch: Fix some simple cases of various warnings.

pcre/pcre_compile.cpp: (jsRegExpCompile): Use const_cast to change const-ness.

runtime/StringPrototype.cpp: (JSC::substituteBackreferences): Remove unneeded initialization and use UChar instead of unsigned short for UTF-16 values.

wtf/dtoa.cpp: (WTF::strtod): Use const_cast to change const-ness.

WebCore:

2009-01-20 Darin Adler <Darin Adler>

Reviewed by Mark Rowe.

Bug 23352: Turn on more compiler warnings in the Mac build
https://bugs.webkit.org/show_bug.cgi?id=23352

First patch: Fix some simple cases of various warnings.

platform/DeprecatedPtrListImpl.cpp: (WebCore::DeprecatedPtrListImpl::insert): Use const_cast to change const-ness.
platform/graphics/mac/SimpleFontDataMac.mm: (WebCore::SimpleFontData::containsCharacters): Ditto.

platform/text/PlatformString.h: Overload for short and unsigned short to avoid ambiguity leading to warnings.
platform/text/String.cpp: (WebCore::String::number): Implemented overloads.

platform/text/TextStream.cpp: (WebCore::TextStream::operator<<): Overload for bool to avoid ambiguity leading to warnings.
platform/text/TextStream.h: Ditto.

rendering/InlineFlowBox.h: Fix declaration that was specifying the wrong type.

svg/graphics/filters/cg/WKLinearTransferFilter.m: Fix stray characters after #endif that should be a comment instead.
svg/graphics/filters/cg/WKSpecularLightingFilter.h: Ditto.