Timeline
Jan 22, 2009:
- 11:19 PM Changeset in webkit [40154] by
-
- 3 edits in trunk/LayoutTests/platform/mac/fast/forms
Land updated layout tests (progressions) after border/padding move.
- 11:14 PM Changeset in webkit [40153] by
-
- 15 edits in trunk/WebCore
2009-01-22 David Hyatt <hyatt@apple.com>
Move the border and padding methods from RenderObject to RenderBox.
Reviewed by Oliver Hunt
- css/CSSComputedStyleDeclaration.cpp: (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
- editing/DeleteButtonController.cpp: (WebCore::DeleteButtonController::createDeletionUI):
- page/EventHandler.cpp: (WebCore::EventHandler::hitTestResultAtPoint):
- rendering/InlineFlowBox.cpp: (WebCore::InlineFlowBox::placeBoxesVertically):
- rendering/InlineFlowBox.h: (WebCore::InlineFlowBox::borderLeft): (WebCore::InlineFlowBox::borderRight): (WebCore::InlineFlowBox::paddingLeft): (WebCore::InlineFlowBox::paddingRight):
- rendering/RenderBlock.cpp: (WebCore::RenderBlock::clearFloats):
- rendering/RenderBox.cpp: (WebCore::RenderBox::paddingTop): (WebCore::RenderBox::paddingBottom): (WebCore::RenderBox::paddingLeft): (WebCore::RenderBox::paddingRight): (WebCore::RenderBox::calcHeight): (WebCore::RenderBox::containingBlockWidthForPositioned): (WebCore::RenderBox::containingBlockHeightForPositioned): (WebCore::RenderBox::calcAbsoluteHorizontal): (WebCore::RenderBox::calcAbsoluteHorizontalValues): (WebCore::RenderBox::calcAbsoluteVertical): (WebCore::RenderBox::calcAbsoluteVerticalValues): (WebCore::RenderBox::calcAbsoluteHorizontalReplaced): (WebCore::RenderBox::calcAbsoluteVerticalReplaced):
- rendering/RenderBox.h: (WebCore::RenderBox::borderTop): (WebCore::RenderBox::borderBottom): (WebCore::RenderBox::borderLeft): (WebCore::RenderBox::borderRight):
- rendering/RenderObject.cpp: (WebCore::RenderObject::repaintAfterLayoutIfNeeded):
- rendering/RenderObject.h:
- rendering/RenderTextControl.cpp: (WebCore::RenderTextControl::textBlockWidth): (WebCore::RenderTextControl::calcHeight): (WebCore::RenderTextControl::calcPrefWidths):
- rendering/RenderTextControlSingleLine.cpp: (WebCore::RenderTextControlSingleLine::preferredContentWidth):
- rendering/RenderTreeAsText.cpp: (WebCore::operator<<):
- rendering/RenderView.cpp: (WebCore::RenderView::repaintViewRectangle):
- 9:13 PM Changeset in webkit [40152] by
-
- 16 edits in trunk/WebCore
2009-01-22 David Hyatt <hyatt@apple.com>
Devirtualize the marginTop/Right/Left/Bottom functions and move them to RenderBox (along with some of the
other margin functions that have to come along for the ride).
Reviewed by Oliver Hunt
- css/CSSComputedStyleDeclaration.cpp: (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
- editing/TextIterator.cpp: (WebCore::shouldEmitExtraNewlineForNode):
- rendering/InlineBox.cpp:
- rendering/InlineBox.h: (WebCore::InlineBox::renderBox):
- rendering/InlineFlowBox.cpp: (WebCore::InlineFlowBox::marginLeft): (WebCore::InlineFlowBox::marginRight): (WebCore::InlineFlowBox::placeBoxesHorizontally): (WebCore::InlineFlowBox::computeLogicalBoxHeights): (WebCore::InlineFlowBox::placeBoxesVertically): (WebCore::InlineFlowBox::shrinkBoxesWithNoTextChildren):
- rendering/RenderBlock.cpp: (WebCore::RenderBlock::isSelfCollapsingBlock): (WebCore::RenderBlock::adjustPositionedBlock): (WebCore::RenderBlock::handleCompactChild): (WebCore::RenderBlock::estimateVerticalPosition): (WebCore::getBorderPaddingMargin): (WebCore::RenderBlock::calcInlinePrefWidths):
- rendering/RenderBlock.h:
- rendering/RenderBox.cpp: (WebCore::RenderBox::calcHeight):
- rendering/RenderBox.h: (WebCore::RenderBox::hasHorizontalBordersPaddingOrMargin): (WebCore::RenderBox::hasHorizontalBordersOrPadding): (WebCore::RenderBox::marginTop): (WebCore::RenderBox::marginBottom): (WebCore::RenderBox::marginLeft): (WebCore::RenderBox::marginRight): (WebCore::RenderBox::isSelfCollapsingBlock): (WebCore::RenderBox::collapsedMarginTop): (WebCore::RenderBox::collapsedMarginBottom): (WebCore::RenderBox::isTopMarginQuirk): (WebCore::RenderBox::isBottomMarginQuirk): (WebCore::RenderBox::maxTopMargin): (WebCore::RenderBox::maxBottomMargin):
- rendering/RenderObject.cpp: (WebCore::RenderObject::getAbsoluteRepaintRectWithOutline):
- rendering/RenderObject.h:
- rendering/RenderSVGContainer.cpp: (WebCore::RenderSVGContainer::lineHeight): (WebCore::RenderSVGContainer::baselinePosition):
- rendering/RenderTextControl.cpp: (WebCore::RenderTextControl::calcHeight):
- rendering/RenderTheme.cpp: (WebCore::RenderTheme::baselinePosition):
- rendering/bidi.cpp: (WebCore::getBorderPaddingMargin): (WebCore::inlineWidth): (WebCore::RenderBlock::computeHorizontalPositionsForLine): (WebCore::inlineFlowRequiresLineBox): (WebCore::requiresLineBox): (WebCore::RenderBlock::findNextLineBreak):
- 8:57 PM Changeset in webkit [40151] by
-
- 8 edits in trunk
Disable GCC_WARN_ABOUT_MISSING_PROTOTYPES temporarily.
Rubber-stamped by Anders Carlsson.
Current versions of Xcode only respect it for C and Objective-C files,
and our code doesn't currently compile if it is applied to C++ and
Objective-C++ files.
- 8:30 PM Changeset in webkit [40150] by
-
- 1 edit in trunk/WebCore/rendering/RenderTableSection.cpp
Fix build bustage on Gtk.
- 8:07 PM Changeset in webkit [40149] by
-
- 4 edits in trunk/WebCore
2009-01-22 David Hyatt <hyatt@apple.com>
Move the m_widthChanged bit on RenderTableCell into RenderFlow's set of bits. Let intrinsicPaddingTop and
intrinsicPaddingBottom just be normal non-bitfield values.
Reviewed by Oliver Hunt
- rendering/RenderFlow.h: (WebCore::RenderFlow::RenderFlow):
- rendering/RenderTableCell.cpp: (WebCore::RenderTableCell::RenderTableCell): (WebCore::RenderTableCell::updateWidth): (WebCore::RenderTableCell::layout):
- rendering/RenderTableCell.h:
- 8:06 PM Changeset in webkit [40148] by
-
- 2 edits in trunk/LayoutTests/platform/mac/tables/mozilla/bugs
Update layout tests for table cell changes.
- 8:05 PM Changeset in webkit [40147] by
-
- 2 edits in trunk/LayoutTests/platform/mac/http/tests/misc
Update layout tests for table cell changes.
- 8:04 PM Changeset in webkit [40146] by
-
- 2 edits in trunk/LayoutTests/platform/mac/fast/table
Update layout tests for table cell changes.
- 8:03 PM Changeset in webkit [40145] by
-
- 1 edit in trunk/LayoutTests/platform/mac/fast/dynamic/insert-before-table-part-in-continuation-expected.txt
Update layout tests for table cell changes.
- 8:03 PM Changeset in webkit [40144] by
-
- 2 edits in trunk/LayoutTests/platform/mac/fast/css
Update layout tests for table cell changes.
- 7:55 PM Changeset in webkit [40143] by
-
- 16 edits in trunk/WebCore
2009-01-22 David Hyatt <hyatt@apple.com>
Properly encapsulate m_frameRect.y() behind the RenderBox::y() method now that they are the same thing.
Make m_frameRect private.
Reviewed by Oliver Hunt
- rendering/RenderBlock.cpp: (WebCore::RenderBlock::paint): (WebCore::RenderBlock::clearFloats):
- rendering/RenderBox.cpp: (WebCore::RenderBox::offsetTop): (WebCore::RenderBox::nodeAtPoint): (WebCore::RenderBox::paint): (WebCore::RenderBox::paintCustomHighlight): (WebCore::RenderBox::containingBlockWidth): (WebCore::RenderBox::localToAbsolute): (WebCore::RenderBox::offsetFromContainer): (WebCore::RenderBox::computeAbsoluteRepaintRect): (WebCore::RenderBox::repaintDuringLayoutIfMoved):
- rendering/RenderContainer.cpp: (WebCore::RenderContainer::layout):
- rendering/RenderFlexibleBox.cpp: (WebCore::RenderFlexibleBox::layoutBlock):
- rendering/RenderFrameSet.cpp: (WebCore::RenderFrameSet::paint):
- rendering/RenderImage.cpp: (WebCore::RenderImage::paintReplaced): (WebCore::RenderImage::nodeAtPoint):
- rendering/RenderListMarker.cpp: (WebCore::RenderListMarker::paint): (WebCore::RenderListMarker::getRelativeMarkerRect):
- rendering/RenderReplaced.cpp: (WebCore::RenderReplaced::paint): (WebCore::RenderReplaced::shouldPaint):
- rendering/RenderReplica.cpp: (WebCore::RenderReplica::paint):
- rendering/RenderSVGRoot.cpp: (WebCore::RenderSVGRoot::applyContentTransforms): (WebCore::RenderSVGRoot::paint): (WebCore::RenderSVGRoot::absoluteTransform): (WebCore::RenderSVGRoot::nodeAtPoint):
- rendering/RenderTable.cpp: (WebCore::RenderTable::calcWidth): (WebCore::RenderTable::layout):
- rendering/RenderTableCell.cpp: (WebCore::RenderTableCell::paint): (WebCore::RenderTableCell::paintBackgroundsBehindCell):
- rendering/RenderTableSection.cpp: (WebCore::RenderTableSection::setCellWidths): (WebCore::RenderTableSection::calcRowHeight): (WebCore::RenderTableSection::layoutRows): (WebCore::RenderTableSection::paint): (WebCore::RenderTableSection::nodeAtPoint):
- rendering/RenderWidget.cpp: (WebCore::RenderWidget::paint):
- 7:42 PM Changeset in webkit [40142] by
-
- 23 edits in trunk/WebCore
2009-01-22 David Hyatt <hyatt@apple.com>
This patch completely reworks vertical alignment of table cells. The current system uses methods called borderTopExtra() and borderBottomExtra() to
add extra space above and below the content of a cell. This system was not confined to the table code and spilled out into all the other RenderObjects.
The y-position of the table cell box was set to the outer edge of the cell, but the y() method of RenderBox lied and added in borderTopExtra(). height()
also excluded the extra space, so did not accurately reflect the true size of the cell.
With the new system, the table cell box is completely accurate. The extra space becomes part of the padding of the cell. Padding has been reworked so that
additional intrinsic padding can be added on to the specified padding from style. Only the table code has to deal with the extra cell padding.
localToAbsoluteForContent has now been removed, since there no longer has to be a special hacked content box.
A number of table layout tests progress with this change, since the new layout system actually fixes existing bugs in baseline alignment of cells.
Reviewed by Oliver Hunt
- css/CSSComputedStyleDeclaration.cpp: (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue): Make CSSComputedStyleDeclaration ask for padding values that exclude the built-in intrinsic padding. This ensures that getComputedStyle continues to give the right answer.
- dom/ContainerNode.cpp: (WebCore::ContainerNode::getLowerRightCorner):
- editing/visible_units.cpp: (WebCore::previousLinePosition): (WebCore::nextLinePosition):
- rendering/LayoutState.cpp: (WebCore::LayoutState::LayoutState): Remove borderTopExtra()/borderBottomExtra() hacks and localToAbsoluteForContent calls.
- rendering/RenderBlock.cpp: (WebCore::RenderBlock::overflowRect): Remove borderTopExtra()/borderBottomExtra() hacks and localToAbsoluteForContent calls.
(WebCore::RenderBlock::layoutBlock):
(WebCore::RenderBlock::expandsToEncloseOverhangingFloats):
The expandsToEncloseOverhangingFloats logic has been reworked. Table cells and fieldsets did not properly handle floats that spilled into the bottom padding. The
resulting box needed to not only expand to encompass the float, but also needed to place the full bottom padding after the float. The switch to make the extra table cell
space into padding exposed this issue. No extra layout test is required, since an existing table layout test exposes this issue and progresses to match Firefox with
this change.
(WebCore::RenderBlock::selectionGapRects):
(WebCore::RenderBlock::paintSelection):
(WebCore::RenderBlock::fillSelectionGaps):
(WebCore::RenderBlock::nodeAtPoint):
(WebCore::RenderBlock::positionForCoordinates):
(WebCore::RenderBlock::offsetForContents):
Remove borderTopExtra()/borderBottomExtra() hacks and localToAbsoluteForContent calls.
- rendering/RenderBlock.h: Add the new simplified method for expanding to encompass overhanging floats. The method has been devirtualized and made to include all of the cases (and not just a subset).
- rendering/RenderBox.cpp: (WebCore::RenderBox::absoluteRects): (WebCore::RenderBox::absoluteQuads): (WebCore::RenderBox::absoluteContentBox): (WebCore::RenderBox::paintBoxDecorations): (WebCore::RenderBox::paintMask): (WebCore::RenderBox::getOverflowClipRect): (WebCore::RenderBox::localToAbsolute): (WebCore::RenderBox::absoluteToLocal): (WebCore::RenderBox::localToAbsoluteQuad): Remove borderTopExtra()/borderBottomExtra() hacks and localToAbsoluteForContent calls.
- rendering/RenderBox.h: (WebCore::RenderBox::y): (WebCore::RenderBox::location): (WebCore::RenderBox::borderBoxRect): (WebCore::RenderBox::offsetHeight): Remove borderTopExtra()/borderBottomExtra() hacks and localToAbsoluteForContent calls.
- rendering/RenderContainer.cpp: (WebCore::RenderContainer::addLineBoxRects):
- rendering/RenderFieldset.cpp: (WebCore::RenderFieldset::paintBoxDecorations): (WebCore::RenderFieldset::paintMask):
- rendering/RenderFieldset.h: (WebCore::RenderFieldset::avoidsFloats):
- rendering/RenderFlow.cpp: (WebCore::RenderFlow::localCaretRect):
- rendering/RenderLayer.cpp: (WebCore::RenderLayer::updateLayerPosition): (WebCore::RenderLayer::paintLayer): (WebCore::RenderLayer::hitTestLayer): (WebCore::RenderLayer::boundingBox):
- rendering/RenderListBox.cpp: (WebCore::RenderListBox::isPointInOverflowControl):
- rendering/RenderObject.cpp: (WebCore::RenderObject::localToAbsolute): (WebCore::RenderObject::absoluteToLocal): (WebCore::RenderObject::localToAbsoluteQuad): (WebCore::RenderObject::offsetFromContainer): (WebCore::RenderObject::paddingTop): (WebCore::RenderObject::paddingBottom): (WebCore::RenderObject::paddingLeft): (WebCore::RenderObject::paddingRight):
- rendering/RenderObject.h: (WebCore::RenderObject::hasOverhangingFloats):
- rendering/RenderReplaced.cpp: (WebCore::RenderReplaced::selectionRect): (WebCore::RenderReplaced::localSelectionRect): Remove borderTopExtra()/borderBottomExtra() hacks and localToAbsoluteForContent calls. Also modifed paddingLeft/Top/Right/Bottom to take an argument indicating whether or not the intrinsic padding of an object should be included (by default it is). getComputedStyle needs to exclude it, which is why this argument is necessary.
- rendering/RenderTableCell.cpp: (WebCore::RenderTableCell::RenderTableCell): (WebCore::RenderTableCell::paddingTop): (WebCore::RenderTableCell::paddingBottom): The new paddingTop() and paddingBottom() methods on table cells include the extra intrinsic padding.
(WebCore::RenderTableCell::setOverrideSize):
When a table's override size gets altered, the intrinsic padding needs to be cleared.
(WebCore::RenderTableCell::absoluteClippedOverflowRect):
(WebCore::RenderTableCell::computeAbsoluteRepaintRect):
(WebCore::RenderTableCell::baselinePosition):
(WebCore::RenderTableCell::paint):
(WebCore::RenderTableCell::paintBackgroundsBehindCell):
(WebCore::RenderTableCell::paintBoxDecorations):
(WebCore::RenderTableCell::paintMask):
Remove borderTopExtra()/borderBottomExtra() hacks and localToAbsoluteForContent calls.
- rendering/RenderTableCell.h: (WebCore::RenderTableCell::setIntrinsicPaddingTop): (WebCore::RenderTableCell::setIntrinsicPaddingBottom): (WebCore::RenderTableCell::setIntrinsicPadding): (WebCore::RenderTableCell::clearIntrinsicPadding): (WebCore::RenderTableCell::intrinsicPaddingTop): (WebCore::RenderTableCell::intrinsicPaddingBottom): Add new helper methods for getting/setting a cell's intrinsic padding.
- rendering/RenderTableSection.cpp: (WebCore::RenderTableSection::calcRowHeight): calcRowHeight has been modified to exclude the intrinsic padding when calculating the base height of rows prior to flexing. Because a cell now includes that extra space, it has to be subtracted out in this method.
(WebCore::RenderTableSection::layoutRows):
Modify the code that sets up the intrinsic padding so that it does a relayout if the intrinsic padding changes. There was also an error where the baseline
position mismatched leading to negative intrinsic padding being added in (this error exists in ToT). The code now properly ignores cells that don't establish
a baseline. A number of tests progress with this change.
- rendering/RenderText.cpp: (WebCore::RenderText::addLineBoxRects): Remove borderTopExtra()/borderBottomExtra() hacks and localToAbsoluteForContent calls.
- rendering/RenderTreeAsText.cpp: (WebCore::operator<<): (WebCore::writeTextRun): Modify the render tree dumping code to continue to produce the same results as before. This is really a hack, since we're now capable of indicating the correct position for the descendants of cells with intrinsic padding (and also indicating what the correct cell box is). A future patch can remove these hacks so that the layout test results can all be regenerated.
- 6:30 PM Changeset in webkit [40141] by
-
- 2 edits in trunk/JavaScriptCore
Return currentTime() in correct units for the two early return cases.
Reviewed by Mark Rowe.
- wtf/CurrentTime.cpp: (WTF::currentTime):
- 5:01 PM Changeset in webkit [40140] by
-
- 9 edits in trunk/WebKit/mac
2009-01-22 Anders Carlsson <andersca@apple.com>
Reviewed by Sam Weinig.
Add support for Invoke and InvokeDefault. Clean up code.
- Plugins/Hosted/NetscapePluginHostProxy.mm: (WKPCBooleanReply):
- Plugins/Hosted/NetscapePluginInstanceProxy.h: (WebKit::NetscapePluginInstanceProxy::Reply::): (WebKit::NetscapePluginInstanceProxy::BooleanReply::BooleanReply):
- Plugins/Hosted/NetscapePluginInstanceProxy.mm: (WebKit::NetscapePluginInstanceProxy::demarshalValueFromArray):
- Plugins/Hosted/ProxyInstance.h:
- Plugins/Hosted/ProxyInstance.mm: (WebKit::ProxyInstance::invoke): (WebKit::ProxyInstance::invokeMethod): (WebKit::ProxyInstance::supportsInvokeDefaultMethod): (WebKit::ProxyInstance::invokeDefaultMethod): (WebKit::ProxyInstance::methodsNamed): (WebKit::ProxyInstance::fieldNamed):
- Plugins/Hosted/WebKitPluginClient.defs:
- Plugins/Hosted/WebKitPluginHost.defs:
- Plugins/Hosted/WebKitPluginHostTypes.h:
- 4:46 PM Changeset in webkit [40139] by
-
- 4 edits3 adds in trunk
Reviewed by Justin Garcia.
Remove <span> turds left by editing commands
https://bugs.webkit.org/show_bug.cgi?id=23466
Tests:
- editing/execCommand/empty-span-removal.html
- editing/execCommand/toggle-styles.html
- editing/ApplyStyleCommand.cpp: (WebCore::styleSpanClassString): (WebCore::isStyleSpan): (WebCore::isUnstyledStyleSpan): (WebCore::isSpanWithoutAttributesOrUnstyleStyleSpan): (WebCore::ApplyStyleCommand::applyRelativeFontStyleChange): (WebCore::ApplyStyleCommand::removeEmbeddingUpToEnclosingBlock): (WebCore::ApplyStyleCommand::removeHTMLBidiEmbeddingStyle): (WebCore::ApplyStyleCommand::removeCSSStyle):
- 3:24 PM Changeset in webkit [40138] by
-
- 2 edits in trunk/WebKitTools
2009-01-22 Anders Carlsson <andersca@apple.com>
Fix Windows build.
- DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.h:
- 2:53 PM Changeset in webkit [40137] by
-
- 13 edits in trunk/WebCore
Reviewed by Eric Seidel.
Rename some of the casting functions in dom/*Element.cpp:
formControlElementForElement -> toFormControlElement
inputElementForElement -> toInputElement
optionElementForElement -> toOptionElement
optionGroupElementForElement -> toOptionGroupElement
Suggested by Alexey, while refactoring the Element*->ScriptElement* code.
The Element*->ScriptElement* helper function is already named 'toScriptElement'.
- 2:48 PM Changeset in webkit [40136] by
-
- 2 edits in trunk/JavaScriptCore
2009-01-22 Sam Weinig <sam@webkit.org>
Reviewed by Mark Rowe.
Fix for <rdar://problem/6439247>
FastMalloc allocating an extra 4MB of meta-data on 64-bit
Rely on the fact that on all known x86-64 platforms only use 48 bits of
address space to shrink the initial size of the PageMap from ~4MB to 120K.
For 64-bit we still use a 3-level radix tree, but now each level is only 12
bits wide.
No performance change.
- wtf/FastMalloc.cpp: (WTF::MapSelector): Add specialization for 64 bit that takes into account the 16 bits of unused address space on x86-64.
- 2:24 PM Changeset in webkit [40135] by
-
- 3 edits in trunk/WebCore
Rubber-stamped by George Staikos.
Forgot to include in my last commit: Activate code depending on WMLOptionElement/WMLOptGroupElement.
- 2:04 PM Changeset in webkit [40134] by
-
- 6 edits4 adds in trunk/WebCore
Reviewed by George Staikos.
Fixes: https://bugs.webkit.org/show_bug.cgi?id=23454
Add WML <option>/<optgroup> element support.
Currently the implementation is stubbed, all relevant parts can be enabled
once WMLSelectElement/SelectElement has been created.
- 1:51 PM Changeset in webkit [40133] by
-
- 5 edits in trunk
2009-01-22 Beth Dakin <Beth Dakin>
Reviewed by Sam Weinig.
Fix for https://bugs.webkit.org/show_bug.cgi?id=23461 LayoutTests/
fast/js/numeric-conversion.html is broken, and corresponding
<rdar://problem/6514842>
The basic problem here is that parseInt(Infinity) should be NaN,
but we were returning 0. NaN matches Safari 3.2.1 and Firefox.
- runtime/JSGlobalObjectFunctions.cpp: (JSC::globalFuncParseInt):
LayoutTests:
2009-01-22 Beth Dakin <Beth Dakin>
Reviewed by Sam Weinig.
Fix for https://bugs.webkit.org/show_bug.cgi?id=23461 LayoutTests/
fast/js/numeric-conversion.html is broken, and corresponding
<rdar://problem/6514842>
The basic problem here is that parseInt(Infinity) should be NaN,
but we were returning 0. NaN matches Safari 3.2.1 and Firefox.
- fast/js/numeric-conversion-expected.txt:
- fast/js/resources/numeric-conversion.js:
- 1:16 PM Changeset in webkit [40132] by
-
- 11 edits3 adds in trunk
WebCore:
2009-01-22 Eric Roman <eroman@chromium.org>
Reviewed by Eric Seidel.
https://bugs.webkit.org/show_bug.cgi?id=20806
Send referrer for history navigations.
Test: http/tests/navigation/back-send-referrer.html
Consolidates HistoryItem::rssFeedReferrer and HistoryItem::formReferrer into a single HistoryItem::referrer property.
- history/HistoryItem.cpp: (WebCore::HistoryItem::HistoryItem): (WebCore::HistoryItem::referrer): (WebCore::HistoryItem::setReferrer): (WebCore::HistoryItem::formReferrer): (WebCore::HistoryItem::rssFeedReferrer): (WebCore::HistoryItem::setRSSFeedReferrer): (WebCore::HistoryItem::setFormInfoFromRequest):
- history/HistoryItem.h:
- loader/FrameLoader.cpp: (WebCore::FrameLoader::loadItem):
WebKit/win:
2009-01-22 Eric Roman <eroman@chromium.org>
Reviewed by Eric Seidel.
https://bugs.webkit.org/show_bug.cgi?id=20806
Deprecate RSSFeedReferrer() and setRSSFeedReferrer().
- WebHistoryItem.cpp: (WebHistoryItem::RSSFeedReferrer): (WebHistoryItem::setRSSFeedReferrer):
WebKit/mac:
2009-01-22 Eric Roman <eroman@chromium.og>
Reviewed by Eric Seidel.
https://bugs.webkit.org/show_bug.cgi?id=20806
Deprecate RSSFeedReferrer() and setRSSFeedReferrer().
- History/WebHistoryItem.mm: (-[WebHistoryItem RSSFeedReferrer]): (-[WebHistoryItem setRSSFeedReferrer:]):
LayoutTests:
2009-01-22 Eric Roman <eroman@chromium.org>
Reviewed by Eric Seidel.
https://bugs.webkit.org/show_bug.cgi?id=20806
"Referer" header not sent for history navigation.
- http/tests/navigation/back-send-referrer-expected.txt: Added.
- http/tests/navigation/back-send-referrer.html: Added.
- http/tests/navigation/resources/back-send-referrer-helper.php: Added.
- 1:07 PM Changeset in webkit [40131] by
-
- 7 edits in trunk
<rdar://problem/6516853> (r39682-r39736) JSFunFuzz: crash on "(function(){({ x2: x }), })()"
<https://bugs.webkit.org/show_bug.cgi?id=23479>
Reviewed by Geoff Garen.
Automatic semicolon insertion was resulting in this being accepted in the initial
nodeless parsing, but subsequent reparsing for code generation would fail, leading
to a crash. The solution is to ensure that reparsing a function performs parsing
in the same state as the initial parse. We do this by modifying the saved source
ranges to include rather than exclude the opening and closing braces.
- 12:40 PM Changeset in webkit [40130] by
-
- 8 edits in trunk/WebCore
Reviewed by Eric Seidel.
Fixes: https://bugs.webkit.org/show_bug.cgi?id=23465
Further enhancments to share code between HTMLOptionElement and the upcoming WMLOptionElement.
Rename optionText() to textIndentedToRespectGroupLabel() in (HTML)OptionElement, as it fits better.
optionText() returns the options text prefixed with some spaces, in case it got an optgroup parent.
Add two more pure-virtual functions to OptionElement: setSelectedState(bool) & value().
These aren't used outside of html/ at the moment (unlike the other pure-virtual functions
used by RenderMenuList/RenderListBox) - but they will be used by SelectElement, once it exists.
- 12:30 PM Changeset in webkit [40129] by
-
- 2 edits in trunk/WebCore
2009-01-22 Chris Fleizach <Chris Fleizach>
Reviewed by Justin Garcia.
Bug 23464: Infinite recursion at SelectionController::setSelection
https://bugs.webkit.org/show_bug.cgi?id=23464
Check for conditions leading to infinite recursion.
- editing/SelectionController.cpp: (WebCore::SelectionController::setSelection):
- 12:12 PM Changeset in webkit [40128] by
-
- 3 edits in trunk/WebKitTools
2009-01-22 Anders Carlsson <andersca@apple.com>
Reviewed by Sam Weinig.
Clean up the test plug-in code. We now always use the CG drawing model and the
Cocoa event model. It is however possible to revert to the old Carbon event model by
specifying forcecarbon=true in the embed/object tag.
- DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.h:
- DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp: (NPP_New): (handleEventCarbon): (handleEventCocoa): (NPP_HandleEvent):
- 11:06 AM Changeset in webkit [40127] by
-
- 3 edits in trunk/WebKit/mac
2009-01-22 Anders Carlsson <andersca@apple.com>
Reviewed by Kevin Decker.
Don't crash or hang when we fail to instantiate a plug-in.
- Plugins/Hosted/NetscapePluginHostManager.mm: (WebKit::NetscapePluginHostManager::instantiatePlugin): Return 0 on failure.
- Plugins/Hosted/WebHostedNetscapePluginView.mm: (-[WebHostedNetscapePluginView JSC::Bindings::createPluginBindingsInstance:JSC::Bindings::]): Null check for the proxy member.
- 10:55 AM Changeset in webkit [40126] by
-
- 2 edits in trunk/WebCore
Not reviewed. Fix WML build problem in RenderBox.cpp, WMLNames is undefined.
- 7:29 AM Changeset in webkit [40125] by
-
- 2 edits in trunk/WebCore
Fix the Qt build after RenderBox changes.
- 1:41 AM Changeset in webkit [40124] by
-
- 3 edits in trunk/WebCore
2009-01-22 David Hyatt <hyatt@apple.com>
Fix regressions in list box selection on Mac. The wrong color was being used for the list box
background, and list box colors actually weren't even being properly fetched because of a bug in
the RenderTheme base class. Existing pixel tests cover the bug fix.
Reviewed by Jon Honeycutt
- rendering/RenderTheme.cpp: (WebCore::RenderTheme::activeListBoxSelectionBackgroundColor): (WebCore::RenderTheme::inactiveListBoxSelectionBackgroundColor): (WebCore::RenderTheme::activeListBoxSelectionForegroundColor): (WebCore::RenderTheme::inactiveListBoxSelectionForegroundColor):
- rendering/RenderThemeMac.mm: (WebCore::RenderThemeMac::platformInactiveListBoxSelectionBackgroundColor):
- 12:58 AM Changeset in webkit [40123] by
-
- 8 edits1 add in trunk/WebCore
2009-01-22 David Levin <levin@chromium.org>
Reviewed by Alexey Proskuryakov.
Bug 22720: Make XMLHttpRequest work in Workers
<https://bugs.webkit.org/show_bug.cgi?id=22720>
Add copy/adopt for HTTPHeaderMap to allow the data to be passed across threads.
No observable change in behavior, so no test.
- GNUmakefile.am:
- WebCore.pro:
- WebCore.scons:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- WebCoreSources.bkl:
- platform/network/HTTPHeaderMap.cpp: Added. (WebCore::HTTPHeaderMap::copyData): (WebCore::HTTPHeaderMap::adopt):
- platform/network/HTTPHeaderMap.h:
- 12:32 AM Changeset in webkit [40122] by
-
- 3 edits1 add in trunk/JavaScriptCore
2009-01-22 Dmitry Titov <dimich@chromium.org>
Reviewed by Alexey Proskuryakov.
Implement ThreadCondition::timedWait().
Since we borrow the code for condition variables from other sources,
I did the same for timedWait(). See comments in ThreadingWin.cpp for
rationale and more info.
- wtf/CONTRIBUTORS.pthreads-win32: Added. A list of Pthreads-win32 contributors mentioned in their license. The license itself is included into wtf/ThreadingWin32.cpp.
- wtf/Threading.h:
- wtf/ThreadingWin.cpp: Additional info and Pthreads-win32 license at the beginning. (WTF::PlatformCondition::timedWait): new method, derived from Pthreads-win32. (WTF::PlatformCondition::signal): same (WTF::ThreadCondition::ThreadCondition): (WTF::ThreadCondition::~ThreadCondition): (WTF::ThreadCondition::wait): this now calls PlatformCondition::timedWait. (WTF::ThreadCondition::timedWait): same (WTF::ThreadCondition::signal): this now calls PlatformCondition::signal. (WTF::ThreadCondition::broadcast): same
- 12:15 AM Changeset in webkit [40121] by
-
- 2 edits in trunk/WebCore/wml
Fix build bustage in WML from RenderBox changes.
- 12:12 AM Changeset in webkit [40120] by
-
- 1 edit in trunk/WebCore/platform/gtk/RenderThemeGtk.cpp
Fix Gtk build bustage.
- 12:11 AM Changeset in webkit [40119] by
-
- 1 edit in trunk/WebCore/platform/qt/RenderThemeQt.cpp
Fix Qt build bustage.
Jan 21, 2009:
- 11:54 PM Changeset in webkit [40118] by
-
- 5 edits in trunk/WebCore
2009-01-21 David Hyatt <hyatt@apple.com>
Back out a portion of my patch that I did not mean to land. Revert paintOutline back to the way it
was before my landing. Fixes failing SVG focus ring tests.
- rendering/RenderObject.cpp: (WebCore::RenderObject::paintOutline):
- rendering/RenderObject.h:
- rendering/RenderPath.cpp: (WebCore::RenderPath::paint):
- rendering/RenderSVGContainer.cpp: (WebCore::RenderSVGContainer::paint):
- 11:19 PM Changeset in webkit [40117] by
-
- 2 edits in trunk/WebCore
2009-01-21 David Hyatt <hyatt@apple.com>
Fix Node's renderBox() method on Windows.
- dom/Node.cpp: (WebCore::Node::renderBox):
- 11:05 PM Changeset in webkit [40116] by
-
- 2 edits in trunk/WebCore
2009-01-21 David Hyatt <hyatt@apple.com>
Fix RenderThemeSafari bustage on Win32.
- rendering/RenderThemeSafari.cpp: (WebCore::RenderThemeSafari::baselinePosition):
- 10:58 PM Changeset in webkit [40115] by
-
- 2 edits in trunk/WebCore
2009-01-21 David Hyatt <hyatt@apple.com>
Fix bustage in RenderThemeWin. It's actually terrible that RenderThemeWin is using absoluteContentBox,
but that's a problem for another day.
- rendering/RenderThemeWin.cpp: (WebCore::RenderThemeWin::paintSearchFieldCancelButton): (WebCore::RenderThemeWin::paintSearchFieldResultsDecoration): (WebCore::RenderThemeWin::paintSearchFieldResultsButton):
- 9:59 PM Changeset in webkit [40114] by
-
- 1 edit in trunk/LayoutTests/ChangeLog
Because bdash hates freedom (tyop fix).
- 9:57 PM Changeset in webkit [40113] by
-
- 1 edit2 copies in trunk/LayoutTests
2009-01-21 Gavin Barraclough <barraclough@apple.com>
Rubber stamped by Geoff "Cameron Zwarich" Garen.
Add pre & post standalone driver stcripts to assist running the javascript layout tests
on jsc, rather than a full webkit build.
- fast/js/resources/standalone-post.js: Copied from fast/js/resources/js-test-post.js.
- fast/js/resources/standalone-pre.js: Copied from fast/js/resources/js-test-pre.js. (description): (debug): (escapeString): (testPassed): (testFailed):
- 9:48 PM Changeset in webkit [40112] by
-
- 2 edits in trunk/WebCore
Bug 23470: Crash when page load occurs while processing scroll event with MallocScribble enabled
<https://bugs.webkit.org/show_bug.cgi?id=23470>
Reviewed by Dave Hyatt
Add a RefPtr protector to handleWheelEvent to guard against destruction
while processing the scroll event. Alas the absurd set of circumstances
required to trigger this do not appear to be reproducible in DRT.
- 8:28 PM Changeset in webkit [40111] by
-
- 5 edits in trunk
2009-01-21 Gavin Barraclough <barraclough@apple.com>
Reviewed by Oliver Hunt.
We need to check all numbers in integer switches, not just those
represented as integer JSImmediates.
- interpreter/Interpreter.cpp: (JSC::Interpreter::privateExecute): (JSC::Interpreter::cti_op_switch_imm):
LayoutTests:
2009-01-21 Gavin Barraclough <barraclough@apple.com>
Reviewed by Oliver Hunt.
Add layout test for switch (-0).
- fast/js/resources/switch-behaviour.js:
- fast/js/switch-behaviour-expected.txt:
- 7:48 PM Changeset in webkit [40110] by
-
- 4 edits in branches/Safari-3-2-branch
Versioning.
- 7:44 PM Changeset in webkit [40109] by
-
- 4 edits in branches/Safari-3-2-branch
Versioning.
- 7:35 PM Changeset in webkit [40108] by
-
- 2 edits in trunk/JavaScriptCore
2009-01-21 Gavin Barraclough <barraclough@apple.com>
Reviewed by Geoff Garen.
- interpreter/Interpreter.cpp: (JSC::Interpreter::privateExecute):
- 6:31 PM Changeset in webkit [40107] by
-
- 101 edits in trunk
WebCore:
2009-01-21 David Hyatt <hyatt@apple.com>
Devirtualize the width/height/x/y methods of the render tree. The methods are now non-virtual on RenderBox.
Many functions that were previously in RenderObject.cpp are now in RenderBox.cpp.
Reviewed by Eric Seidel and Darin Adler
- WebCore.base.exp:
- css/CSSComputedStyleDeclaration.cpp: (WebCore::sizingBox):
- dom/ContainerNode.cpp: (WebCore::ContainerNode::getUpperLeftCorner): (WebCore::ContainerNode::getLowerRightCorner):
- dom/Element.cpp: (WebCore::Element::offsetLeft): (WebCore::Element::offsetTop): (WebCore::Element::offsetWidth): (WebCore::Element::offsetHeight): (WebCore::Element::offsetParent): (WebCore::Element::clientLeft): (WebCore::Element::clientTop): (WebCore::Element::clientWidth): (WebCore::Element::clientHeight): (WebCore::Element::scrollLeft): (WebCore::Element::scrollTop): (WebCore::Element::setScrollLeft): (WebCore::Element::setScrollTop): (WebCore::Element::scrollWidth): (WebCore::Element::scrollHeight):
- dom/Node.cpp: (WebCore::Node::renderBox): (WebCore::Node::getRect):
- dom/Node.h:
- dom/Position.cpp: (WebCore::endsOfNodeAreVisuallyDistinctPositions): (WebCore::Position::hasRenderedNonAnonymousDescendantsWithHeight): (WebCore::Position::isCandidate):
- dom/PositionIterator.cpp: (WebCore::PositionIterator::isCandidate):
- editing/CompositeEditCommand.cpp: (WebCore::CompositeEditCommand::addBlockPlaceholderIfNeeded):
- editing/DeleteButtonController.cpp: (WebCore::isDeletableElement):
- editing/DeleteSelectionCommand.cpp: (WebCore::DeleteSelectionCommand::removeNode):
- editing/Editor.cpp: (WebCore::Editor::insideVisibleArea):
- editing/EditorCommand.cpp: (WebCore::verticalScrollDistance):
- html/HTMLAnchorElement.cpp: (WebCore::HTMLAnchorElement::isKeyboardFocusable):
- html/HTMLCanvasElement.cpp: (WebCore::HTMLCanvasElement::willDraw):
- html/HTMLFormControlElement.cpp: (WebCore::HTMLFormControlElement::isFocusable):
- html/HTMLFrameElementBase.cpp: (WebCore::HTMLFrameElementBase::width): (WebCore::HTMLFrameElementBase::height):
- html/HTMLImageElement.cpp: (WebCore::HTMLImageElement::width): (WebCore::HTMLImageElement::height):
- inspector/InspectorController.cpp: (WebCore::InspectorController::drawNodeHighlight):
- page/AccessibilityRenderObject.cpp: (WebCore::AccessibilityRenderObject::accessibilityIsIgnored):
- page/FrameView.cpp: (WebCore::FrameView::createScrollbar): (WebCore::FrameView::updateDashboardRegions):
- page/animation/AnimationBase.cpp: (WebCore::blendFunc):
- rendering/HitTestResult.cpp: (WebCore::HitTestResult::imageRect):
- rendering/InlineBox.cpp: (WebCore::InlineBox::renderBox): (WebCore::InlineBox::adjustPosition):
- rendering/InlineBox.h:
- rendering/InlineFlowBox.cpp: (WebCore::InlineFlowBox::placeBoxesHorizontally): (WebCore::InlineFlowBox::verticallyAlignBoxes): (WebCore::InlineFlowBox::placeBoxesVertically):
- rendering/InlineFlowBox.h:
- rendering/RenderApplet.cpp: (WebCore::RenderApplet::createWidgetIfNecessary):
- rendering/RenderBlock.cpp: (WebCore::RenderBlock::overflowHeight): (WebCore::RenderBlock::overflowWidth): (WebCore::RenderBlock::overflowRect): (WebCore::RenderBlock::isSelfCollapsingBlock): (WebCore::RenderBlock::layout): (WebCore::RenderBlock::layoutBlock): (WebCore::RenderBlock::adjustPositionedBlock): (WebCore::RenderBlock::adjustFloatingBlock): (WebCore::RenderBlock::handleSpecialChild): (WebCore::RenderBlock::handlePositionedChild): (WebCore::RenderBlock::handleFloatingChild): (WebCore::RenderBlock::handleCompactChild): (WebCore::RenderBlock::insertCompactIfNeeded): (WebCore::RenderBlock::handleRunInChild): (WebCore::RenderBlock::collapseMargins): (WebCore::RenderBlock::clearFloatsIfNeeded): (WebCore::RenderBlock::estimateVerticalPosition): (WebCore::RenderBlock::determineHorizontalPosition): (WebCore::RenderBlock::handleBottomOfBlock): (WebCore::RenderBlock::layoutBlockChildren): (WebCore::RenderBlock::layoutOnlyPositionedObjects): (WebCore::RenderBlock::layoutPositionedObjects): (WebCore::RenderBlock::markPositionedObjectsForLayout): (WebCore::RenderBlock::repaintOverhangingFloats): (WebCore::RenderBlock::paint): (WebCore::RenderBlock::paintChildren): (WebCore::RenderBlock::paintObject): (WebCore::RenderBlock::paintFloats): (WebCore::RenderBlock::paintContinuationOutlines): (WebCore::clipOutPositionedObjects): (WebCore::RenderBlock::fillSelectionGaps): (WebCore::RenderBlock::fillBlockSelectionGaps): (WebCore::RenderBlock::leftSelectionOffset): (WebCore::RenderBlock::rightSelectionOffset): (WebCore::RenderBlock::insertPositionedObject): (WebCore::RenderBlock::removePositionedObject): (WebCore::RenderBlock::removePositionedObjects): (WebCore::RenderBlock::insertFloatingObject): (WebCore::RenderBlock::removeFloatingObject): (WebCore::RenderBlock::positionNewFloats): (WebCore::RenderBlock::newLine): (WebCore::RenderBlock::lowestPosition): (WebCore::RenderBlock::rightmostPosition): (WebCore::RenderBlock::leftmostPosition): (WebCore::RenderBlock::clearFloats): (WebCore::RenderBlock::addOverhangingFloats): (WebCore::RenderBlock::markAllDescendantsWithFloatsForLayout): (WebCore::RenderBlock::getClearDelta): (WebCore::RenderBlock::nodeAtPoint): (WebCore::RenderBlock::positionForCoordinates): (WebCore::RenderBlock::layoutColumns): (WebCore::RenderBlock::getBaselineOfFirstLineBox): (WebCore::RenderBlock::getBaselineOfLastLineBox): (WebCore::getHeightForLineCount): (WebCore::RenderBlock::adjustForBorderFit):
- rendering/RenderBlock.h: (WebCore::RenderBlock::FloatWithRect::FloatWithRect): (WebCore::RenderBlock::hasOverhangingFloats): (WebCore::RenderBlock::CompactInfo::compact): (WebCore::RenderBlock::CompactInfo::set):
- rendering/RenderBox.cpp: (WebCore::RenderBox::RenderBox): (WebCore::RenderBox::offsetLeft): (WebCore::RenderBox::offsetTop): (WebCore::RenderBox::offsetParent): (WebCore::RenderBox::clientWidth): (WebCore::RenderBox::clientHeight): (WebCore::RenderBox::scrollWidth): (WebCore::RenderBox::scrollHeight): (WebCore::RenderBox::scrollLeft): (WebCore::RenderBox::scrollTop): (WebCore::RenderBox::setScrollLeft): (WebCore::RenderBox::setScrollTop): (WebCore::RenderBox::absoluteRects): (WebCore::RenderBox::absoluteQuads): (WebCore::RenderBox::absoluteContentBox): (WebCore::RenderBox::absoluteContentQuad): (WebCore::RenderBox::absoluteOutlineBounds): (WebCore::RenderBox::addFocusRingRects): (WebCore::RenderBox::reflectionBox): (WebCore::RenderBox::reflectionOffset): (WebCore::RenderBox::reflectedRect): (WebCore::RenderBox::overrideWidth): (WebCore::RenderBox::overrideHeight): (WebCore::RenderBox::nodeAtPoint): (WebCore::RenderBox::paint): (WebCore::RenderBox::maskClipRect): (WebCore::RenderBox::repaintLayerRectsForImage): (WebCore::RenderBox::paintCustomHighlight): (WebCore::RenderBox::getOverflowClipRect): (WebCore::RenderBox::getClipRect): (WebCore::RenderBox::containingBlockWidth): (WebCore::RenderBox::localToAbsolute): (WebCore::RenderBox::offsetFromContainer): (WebCore::RenderBox::position): (WebCore::RenderBox::computeAbsoluteRepaintRect): (WebCore::RenderBox::repaintDuringLayoutIfMoved): (WebCore::RenderBox::calcWidth): (WebCore::RenderBox::calcWidthUsing): (WebCore::RenderBox::calcHorizontalMargins): (WebCore::RenderBox::calcHeight): (WebCore::RenderBox::calcPercentageHeight): (WebCore::RenderBox::calcReplacedHeightUsing): (WebCore::RenderBox::containingBlockWidthForPositioned): (WebCore::RenderBox::containingBlockHeightForPositioned): (WebCore::RenderBox::calcAbsoluteHorizontal): (WebCore::RenderBox::calcAbsoluteVertical): (WebCore::RenderBox::calcAbsoluteVerticalValues): (WebCore::RenderBox::calcAbsoluteHorizontalReplaced): (WebCore::RenderBox::calcAbsoluteVerticalReplaced): (WebCore::RenderBox::localCaretRect): (WebCore::RenderBox::lowestPosition): (WebCore::RenderBox::rightmostPosition): (WebCore::RenderBox::leftmostPosition): (WebCore::RenderBox::localTransform):
- rendering/RenderBox.h: (WebCore::): (WebCore::RenderBox::x): (WebCore::RenderBox::y): (WebCore::RenderBox::width): (WebCore::RenderBox::height): (WebCore::RenderBox::setX): (WebCore::RenderBox::setY): (WebCore::RenderBox::setWidth): (WebCore::RenderBox::setHeight): (WebCore::RenderBox::location): (WebCore::RenderBox::size): (WebCore::RenderBox::setLocation): (WebCore::RenderBox::setSize): (WebCore::RenderBox::move): (WebCore::RenderBox::frameRect): (WebCore::RenderBox::setFrameRect): (WebCore::RenderBox::borderBoxRect): (WebCore::RenderBox::contentBoxRect): (WebCore::RenderBox::previousSiblingBox): (WebCore::RenderBox::nextSiblingBox): (WebCore::RenderBox::parentBox): (WebCore::RenderBox::overflowHeight): (WebCore::RenderBox::overflowWidth): (WebCore::RenderBox::setOverflowHeight): (WebCore::RenderBox::setOverflowWidth): (WebCore::RenderBox::overflowLeft): (WebCore::RenderBox::overflowTop): (WebCore::RenderBox::overflowRect): (WebCore::RenderBox::contentWidth): (WebCore::RenderBox::contentHeight): (WebCore::RenderBox::offsetWidth): (WebCore::RenderBox::offsetHeight): (WebCore::RenderBox::clientLeft): (WebCore::RenderBox::clientTop): (WebCore::RenderBox::availableWidth): (WebCore::RenderBox::tryLayoutDoingPositionedMovementOnly):
- rendering/RenderButton.cpp: (WebCore::RenderButton::controlClipRect):
- rendering/RenderContainer.cpp: (WebCore::RenderContainer::layout): (WebCore::RenderContainer::positionForCoordinates):
- rendering/RenderContainer.h: (WebCore::RenderContainer::firstChildBox): (WebCore::RenderContainer::lastChildBox):
- rendering/RenderFieldset.cpp: (WebCore::RenderFieldset::calcPrefWidths): (WebCore::RenderFieldset::layoutLegend): (WebCore::RenderFieldset::findLegend): (WebCore::RenderFieldset::paintBoxDecorations): (WebCore::RenderFieldset::paintMask):
- rendering/RenderFieldset.h:
- rendering/RenderFileUploadControl.cpp: (WebCore::RenderFileUploadControl::maxFilenameWidth): (WebCore::RenderFileUploadControl::paintObject):
- rendering/RenderFlexibleBox.cpp: (WebCore::FlexBoxIterator::FlexBoxIterator): (WebCore::FlexBoxIterator::first): (WebCore::FlexBoxIterator::next): (WebCore::RenderFlexibleBox::calcHorizontalPrefWidths): (WebCore::RenderFlexibleBox::calcVerticalPrefWidths): (WebCore::RenderFlexibleBox::layoutBlock): (WebCore::RenderFlexibleBox::layoutHorizontalBox): (WebCore::RenderFlexibleBox::layoutVerticalBox): (WebCore::RenderFlexibleBox::placeChild): (WebCore::RenderFlexibleBox::allowedChildFlex):
- rendering/RenderFlexibleBox.h:
- rendering/RenderFlow.cpp: (WebCore::RenderFlow::absoluteClippedOverflowRect): (WebCore::RenderFlow::lowestPosition): (WebCore::RenderFlow::rightmostPosition): (WebCore::RenderFlow::leftmostPosition): (WebCore::RenderFlow::localCaretRect): (WebCore::RenderFlow::addFocusRingRects):
- rendering/RenderFrameSet.cpp: (WebCore::RenderFrameSet::paint): (WebCore::RenderFrameSet::layout): (WebCore::RenderFrameSet::positionFrames):
- rendering/RenderHTMLCanvas.cpp: (WebCore::RenderHTMLCanvas::paintReplaced): (WebCore::RenderHTMLCanvas::canvasSizeChanged):
- rendering/RenderImage.cpp: (WebCore::RenderImage::imageChanged): (WebCore::RenderImage::paintReplaced): (WebCore::RenderImage::nodeAtPoint): (WebCore::RenderImage::calcReplacedWidth):
- rendering/RenderInline.cpp: (WebCore::RenderInline::absoluteRects): (WebCore::RenderInline::boundingBoxWidth): (WebCore::RenderInline::boundingBoxHeight): (WebCore::RenderInline::positionForCoordinates):
- rendering/RenderInline.h: (WebCore::RenderInline::offsetWidth): (WebCore::RenderInline::offsetHeight):
- rendering/RenderLayer.cpp: (WebCore::RenderLayer::updateTransform): (WebCore::RenderLayer::updateLayerPosition): (WebCore::RenderLayer::scrollbarCornerPresent): (WebCore::RenderLayer::createScrollbar): (WebCore::RenderLayer::positionOverflowControls): (WebCore::RenderLayer::paintScrollCorner): (WebCore::RenderLayer::paintResizer): (WebCore::RenderLayer::paintLayer): (WebCore::RenderLayer::hitTestLayer): (WebCore::RenderLayer::calculateRects): (WebCore::RenderLayer::boundingBox):
- rendering/RenderListBox.cpp: (WebCore::RenderListBox::calcHeight): (WebCore::RenderListBox::controlClipRect):
- rendering/RenderListItem.cpp: (WebCore::RenderListItem::positionListMarker): (WebCore::RenderListItem::paint):
- rendering/RenderListMarker.cpp: (WebCore::RenderListMarker::paint): (WebCore::RenderListMarker::layout): (WebCore::RenderListMarker::imageChanged): (WebCore::RenderListMarker::getRelativeMarkerRect): (WebCore::RenderListMarker::selectionRect):
- rendering/RenderMarquee.cpp: (WebCore::RenderMarquee::computePosition):
- rendering/RenderMedia.cpp: (WebCore::RenderMedia::layout): (WebCore::RenderMedia::lowestPosition): (WebCore::RenderMedia::rightmostPosition): (WebCore::RenderMedia::leftmostPosition):
- rendering/RenderMenuList.cpp: (WebCore::RenderMenuList::controlClipRect):
- rendering/RenderObject.cpp: (WebCore::RenderObject::RenderObject): (WebCore::RenderObject::markAllDescendantsWithFloatsForLayout): (WebCore::RenderObject::paintOutline): (WebCore::RenderObject::addLineBoxRects): (WebCore::RenderObject::absoluteBoundingBoxRect): (WebCore::RenderObject::addAbsoluteRectForLayer): (WebCore::RenderObject::paintingRootRect): (WebCore::RenderObject::container): (WebCore::RenderObject::removeFromObjectLists): (WebCore::RenderObject::updateHitTestResult): (WebCore::RenderObject::addDashboardRegions): (WebCore::RenderObject::localTransform):
- rendering/RenderObject.h: (WebCore::RenderObject::isBox): (WebCore::RenderObject::hasMask): (WebCore::RenderObject::setIsText): (WebCore::RenderObject::setIsBox): (WebCore::RenderObject::borderTop): (WebCore::RenderObject::borderBottom): (WebCore::RenderObject::absoluteRects): (WebCore::RenderObject::collectAbsoluteLineBoxQuads): (WebCore::RenderObject::absoluteQuads): (WebCore::RenderObject::hasReflection): (WebCore::RenderObject::addFocusRingRects): (WebCore::RenderObject::absoluteOutlineBounds):
- rendering/RenderPart.cpp: (WebCore::RenderPart::updateWidgetPosition):
- rendering/RenderPath.cpp: (WebCore::RenderPath::layout): (WebCore::RenderPath::paint): (WebCore::RenderPath::absoluteOutlineBounds):
- rendering/RenderPath.h:
- rendering/RenderReplaced.cpp: (WebCore::RenderReplaced::layout): (WebCore::RenderReplaced::paint): (WebCore::RenderReplaced::shouldPaint): (WebCore::RenderReplaced::positionForCoordinates): (WebCore::RenderReplaced::localSelectionRect): (WebCore::RenderReplaced::adjustOverflowForBoxShadow): (WebCore::RenderReplaced::overflowRect):
- rendering/RenderReplica.cpp: (WebCore::RenderReplica::layout): (WebCore::RenderReplica::calcPrefWidths): (WebCore::RenderReplica::paint):
- rendering/RenderSVGContainer.cpp: (WebCore::RenderSVGContainer::paint): (WebCore::RenderSVGContainer::absoluteOutlineBounds):
- rendering/RenderSVGContainer.h: (WebCore::RenderSVGContainer::width): (WebCore::RenderSVGContainer::height):
- rendering/RenderSVGImage.cpp: (WebCore::RenderSVGImage::layout):
- rendering/RenderSVGInlineText.cpp: (WebCore::RenderSVGInlineText::computeAbsoluteRectForRange): (WebCore::RenderSVGInlineText::positionForCoordinates):
- rendering/RenderSVGRoot.cpp: (WebCore::RenderSVGRoot::layout): (WebCore::RenderSVGRoot::applyContentTransforms): (WebCore::RenderSVGRoot::paint): (WebCore::RenderSVGRoot::absoluteTransform): (WebCore::RenderSVGRoot::nodeAtPoint):
- rendering/RenderSVGTSpan.cpp: (WebCore::RenderSVGTSpan::absoluteRects): (WebCore::RenderSVGTSpan::absoluteQuads):
- rendering/RenderSVGText.cpp: (WebCore::RenderSVGText::layout): (WebCore::RenderSVGText::relativeBBox):
- rendering/RenderSVGTextPath.cpp: (WebCore::RenderSVGTextPath::absoluteRects): (WebCore::RenderSVGTextPath::absoluteQuads):
- rendering/RenderSVGViewportContainer.cpp: (WebCore::RenderSVGViewportContainer::nodeAtPoint):
- rendering/RenderScrollbar.cpp: (WebCore::RenderScrollbar::createCustomScrollbar): (WebCore::RenderScrollbar::RenderScrollbar): (WebCore::RenderScrollbar::setParent):
- rendering/RenderScrollbar.h: (WebCore::RenderScrollbar::owningRenderer):
- rendering/RenderScrollbarPart.cpp: (WebCore::RenderScrollbarPart::layout): (WebCore::RenderScrollbarPart::layoutHorizontalPart): (WebCore::RenderScrollbarPart::layoutVerticalPart): (WebCore::RenderScrollbarPart::computeScrollbarWidth): (WebCore::RenderScrollbarPart::computeScrollbarHeight): (WebCore::RenderScrollbarPart::paintIntoRect):
- rendering/RenderSlider.cpp: (WebCore::HTMLSliderThumbElement::defaultEventHandler): (WebCore::RenderSlider::layout): (WebCore::RenderSlider::mouseEventIsInThumb): (WebCore::RenderSlider::positionForOffset): (WebCore::RenderSlider::trackSize):
- rendering/RenderTable.cpp: (WebCore::RenderTable::calcWidth): (WebCore::RenderTable::layout): (WebCore::RenderTable::paint): (WebCore::RenderTable::getBaselineOfFirstLineBox):
- rendering/RenderTableCell.cpp: (WebCore::RenderTableCell::updateWidth): (WebCore::RenderTableCell::computeAbsoluteRepaintRect): (WebCore::RenderTableCell::localToAbsolute): (WebCore::RenderTableCell::absoluteToLocal): (WebCore::RenderTableCell::localToAbsoluteQuad): (WebCore::RenderTableCell::paint): (WebCore::RenderTableCell::paintBackgroundsBehindCell):
- rendering/RenderTableCell.h:
- rendering/RenderTableSection.cpp: (WebCore::RenderTableSection::addChild): (WebCore::RenderTableSection::addCell): (WebCore::RenderTableSection::setCellWidths): (WebCore::RenderTableSection::calcRowHeight): (WebCore::RenderTableSection::layoutRows): (WebCore::RenderTableSection::lowestPosition): (WebCore::RenderTableSection::rightmostPosition): (WebCore::RenderTableSection::leftmostPosition): (WebCore::RenderTableSection::getBaselineOfFirstLineBox): (WebCore::RenderTableSection::paint): (WebCore::RenderTableSection::recalcCells): (WebCore::RenderTableSection::nodeAtPoint):
- rendering/RenderTableSection.h: (WebCore::RenderTableSection::overflowWidth): (WebCore::RenderTableSection::overflowHeight):
- rendering/RenderText.cpp: (WebCore::RenderText::RenderText): (WebCore::RenderText::boundingBoxX): (WebCore::RenderText::boundingBoxY): (WebCore::RenderText::firstRunX): (WebCore::RenderText::firstRunY): (WebCore::RenderText::boundingBoxHeight): (WebCore::RenderText::boundingBoxWidth):
- rendering/RenderText.h:
- rendering/RenderTextControl.cpp: (WebCore::RenderTextControl::textBlockHeight): (WebCore::RenderTextControl::textBlockWidth): (WebCore::RenderTextControl::setSelectionRange): (WebCore::RenderTextControl::calcHeight): (WebCore::RenderTextControl::hitInnerTextBlock): (WebCore::RenderTextControl::controlClipRect):
- rendering/RenderTextControlMultiLine.cpp: (WebCore::RenderTextControlMultiLine::layout): (WebCore::RenderTextControlMultiLine::adjustControlHeightBasedOnLineHeight):
- rendering/RenderTextControlSingleLine.cpp: (WebCore::RenderTextControlSingleLine::paint): (WebCore::RenderTextControlSingleLine::layout): (WebCore::RenderTextControlSingleLine::nodeAtPoint): (WebCore::RenderTextControlSingleLine::forwardEvent): (WebCore::RenderTextControlSingleLine::textBlockWidth): (WebCore::RenderTextControlSingleLine::adjustControlHeightBasedOnLineHeight): (WebCore::RenderTextControlSingleLine::clientPaddingLeft): (WebCore::RenderTextControlSingleLine::clientPaddingRight):
- rendering/RenderTheme.cpp: (WebCore::RenderTheme::hitTestMediaControlPart): (WebCore::RenderTheme::baselinePosition):
- rendering/RenderThemeMac.mm: (WebCore::RenderThemeMac::paintSearchFieldCancelButton): (WebCore::RenderThemeMac::paintSearchFieldResultsDecoration): (WebCore::RenderThemeMac::paintSearchFieldResultsButton): (WebCore::RenderThemeMac::hitTestMediaControlPart):
- rendering/RenderTreeAsText.cpp: (WebCore::operator<<):
- rendering/RenderVideo.cpp: (WebCore::RenderVideo::videoBox):
- rendering/RenderView.cpp: (WebCore::RenderView::RenderView): (WebCore::RenderView::calcHeight): (WebCore::RenderView::calcWidth): (WebCore::RenderView::layout): (WebCore::RenderView::viewRect): (WebCore::RenderView::docHeight): (WebCore::RenderView::docWidth): (WebCore::RenderView::setBestTruncatedAt):
- rendering/RenderView.h:
- rendering/RenderWidget.cpp: (WebCore::RenderWidget::paint): (WebCore::RenderWidget::updateWidgetPosition): (WebCore::RenderWidget::nodeAtPoint):
- rendering/RootInlineBox.h: (WebCore::RootInlineBox::floats): (WebCore::RootInlineBox::floatsPtr):
- rendering/SVGInlineFlowBox.cpp: (WebCore::SVGInlineFlowBox::verticallyAlignBoxes):
- rendering/SVGInlineFlowBox.h:
- rendering/SVGRenderTreeAsText.cpp: (WebCore::operator<<): (WebCore::write):
- rendering/SVGRootInlineBox.cpp: (WebCore::SVGRootInlineBox::verticallyAlignBoxes): (WebCore::SVGRootInlineBox::computePerCharacterLayoutInformation): (WebCore::SVGRootInlineBox::layoutInlineBoxes):
- rendering/SVGRootInlineBox.h:
- rendering/bidi.cpp: (WebCore::RenderBlock::computeHorizontalPositionsForLine): (WebCore::RenderBlock::computeVerticalPositionsForLine): (WebCore::RenderBlock::layoutInlineChildren): (WebCore::RenderBlock::determineStartPosition): (WebCore::RenderBlock::matchedEndLine): (WebCore::RenderBlock::skipTrailingWhitespace): (WebCore::RenderBlock::skipLeadingWhitespace): (WebCore::RenderBlock::fitBelowFloats): (WebCore::RenderBlock::findNextLineBreak): (WebCore::RenderBlock::checkLinesForOverflow):
- svg/SVGLength.cpp: (WebCore::SVGLength::PercentageOfViewport):
WebKit/mac:
2009-01-21 David Hyatt <hyatt@apple.com>
Devirtualize width/height/x/y on RenderObject and move the methods to RenderBox.
Reviewed by Eric Seidel and Darin Adler
- WebView/WebRenderNode.mm: (copyRenderNode):
- 5:39 PM Changeset in webkit [40106] by
-
- 8 edits in trunk/WebKit/mac
2009-01-21 Anders Carlsson <andersca@apple.com>
Reviewed by Sam Weinig.
More browser->plug-in scripting support.
- Plugins/Hosted/NetscapePluginHostProxy.mm: (WKPCNPObjectHasPropertyReply): (WKPCNPObjectHasMethodReply): (WKPCNPObjectInvokeReply): MIG reply functions.
(WKPCIdentifierInfo):
Return information about an identifier given its 64-bit value.
- Plugins/Hosted/NetscapePluginInstanceProxy.h: Add new reply structs.
- Plugins/Hosted/NetscapePluginInstanceProxy.mm: (WebKit::NetscapePluginInstanceProxy::addValueToArray): Split out code that adds values to the arrays from marshalValue.
(WebKit::NetscapePluginInstanceProxy::marshalValue):
Call addValueToArray.
(WebKit::NetscapePluginInstanceProxy::marshalValues):
Marshal a list of values.
(WebKit::NetscapePluginInstanceProxy::createBindingsInstance):
Actually create a proxy instance.
- Plugins/Hosted/ProxyInstance.h:
- Plugins/Hosted/ProxyInstance.mm: (WebKit::ProxyClass::methodsNamed): (WebKit::ProxyClass::fieldNamed): Add a proxy ProxyClass class that just forwards everything to the ProxyInstance class.
(WebKit::proxyClass):
Shared proxyClass getter.
(WebKit::ProxyField::ProxyField):
(WebKit::ProxyField::valueFromInstance):
(WebKit::ProxyField::setValueToInstance):
Add a proxy ProxyField class that just forwards everything to the ProxyInstance class.
(WebKit::ProxyMethod::ProxyMethod):
(WebKit::ProxyMethod::serverIdentifier):
(WebKit::ProxyMethod::numParameters):
Add a dummy ProxyMethod class.
(WebKit::ProxyInstance::invokeMethod):
Call _WKPHNPObjectInvoke.
(WebKit::ProxyInstance::defaultValue):
(WebKit::ProxyInstance::stringValue):
(WebKit::ProxyInstance::numberValue):
(WebKit::ProxyInstance::booleanValue):
(WebKit::ProxyInstance::valueOf):
Add dummy implementations (taken from CInstance).
(WebKit::ProxyInstance::methodsNamed):
Call _WKPHNPObjectHasMethod to determine whether a method with the given name exists.
(WebKit::ProxyInstance::fieldNamed):
Call _WKPHNPObjectHasProperty to determine whether a property with the given name exists.
- Plugins/Hosted/WebKitPluginClient.defs:
- Plugins/Hosted/WebKitPluginHost.defs: Add new MIG definitions.
- 5:39 PM Changeset in webkit [40105] by
-
- 2 edits in trunk/WebKitTools
2009-01-21 Pierre-Olivier Latour <pol@apple.com>
Tweaked earlier fix to only print a warning when Perian is installed,
and fail completely only if attempting to generate new pixel test results.
- Scripts/run-webkit-tests:
- 4:50 PM Changeset in webkit [40104] by
-
- 3 edits in trunk/WebCore
2009-01-21 Anders Carlsson <andersca@apple.com>
Reviewed by Sam Weinig.
- WebCore.LP64.exp: Add some bridge related symbols.
- WebCore.xcodeproj/project.pbxproj: Make runtime_object.h a private header.
- 4:22 PM Changeset in webkit [40103] by
-
- 10 edits5 adds in trunk/WebCore
Bug 22720: Make XMLHttpRequest work in Workers
<https://bugs.webkit.org/show_bug.cgi?id=22720>
Contributed by David Levin.
Reviewed by Alexey Proskuryakov
More removal of document usage from XMLHttpRequest.
- Abstracted away the sync and async requests behind the ThreadableLoader class, which will get an implementation for Workers. It follows the same model as SubresourceLoader, since it is a thin wrapper around it.
- Consolidated dashboard compatibility checks into usesDashboardBackwardCompatibilityMode which handles workers.
No observable change in behavior, so no test.
- 4:13 PM Changeset in webkit [40102] by
-
- 6 edits2 adds in trunk
The high CPU usage was really from repeatedly firing transitions caused
by a bug in the way we handle background-color animations. If animating
from a valid background color to no background color, we sometimes left
(based on timing) the background color as transparent black, but valid
rather than invalid, which it should be. Fixing that got rid of the
repeated firing.
But we really were doing more expensive iteration of all objects with
animations or transitions on them (running or not). So I added two
optimizations to quickly short circuit when an object had no running
animations or transitions. Things are now as zippy as ever.
- 3:37 PM Changeset in webkit [40101] by
-
- 5 edits in trunk
Reviewed by Justin Garcia.
Remove the style= turds left by some editing commands
https://bugs.webkit.org/show_bug.cgi?id=23463
Test: editing/execCommand/toggle-styles.html
- editing/ApplyStyleCommand.cpp: (WebCore::ApplyStyleCommand::removeCSSStyle): check if we just removed the last CSS property and remove the style attribute as well
- editing/CompositeEditCommand.cpp: (WebCore::CompositeEditCommand::removeNodeAttribute): remove extra ;
- 3:25 PM Changeset in webkit [40100] by
-
- 6 edits in trunk/WebKit/mac
Clean up how we force invocations of API that happened on background threads over to the main thread.
This was previously accomplished in a somewhat ad-hoc manner using a mutable dictionary to pass arguments
and return values back from the function. The new approach is to use a proxy object that forwards an
NSInvocation over to the main thread and applies it to the target object, which leads to a much cleaner
call site.
Reviewed by Tim Hatcher.
- Misc/WebNSObjectExtras.h:
- Misc/WebNSObjectExtras.mm:
(-[WebMainThreadInvoker initWithTarget:]):
(-[WebMainThreadInvoker forwardInvocation:]):
(-[WebMainThreadInvoker methodSignatureForSelector:]):
(-[WebMainThreadInvoker handleException:]):
(-[NSInvocation _webkit_invokeAndHandleException:]): Execute the invocation and forward any exception that was
raised back to the WebMainThreadInvoker.
(-[NSObject _webkit_invokeOnMainThread]):
The following methods are updated to use the proxy object to forward methods to the main thread:
- WebView/WebArchive.mm:
(-[WebArchive initWithMainResource:subresources:subframeArchives:]):
(-[WebArchive mainResource]):
(-[WebArchive subresources]):
(-[WebArchive subframeArchives]):
- WebView/WebResource.mm:
(-[WebResource data]):
(-[WebResource URL]):
(-[WebResource MIMEType]):
(-[WebResource textEncodingName]):
(-[WebResource frameName]):
(-[WebResource _ignoreWhenUnarchiving]):
(-[WebResource _initWithData:URL:MIMEType:textEncodingName:frameName:response:copyData:]):
(-[WebResource _initWithData:URL:response:]):
(-[WebResource _suggestedFilename]):
(-[WebResource _response]):
(-[WebResource _stringValue]):
- WebView/WebView.mm:
(-[WebView initWithFrame:frameName:groupName:]):
(-[WebView initWithCoder:]):
- 3:20 PM Changeset in webkit [40099] by
-
- 2 edits in trunk/WebCore
No review, build fix.
Fix release-only build failure (and do a tiny code-cleanup).
- editing/ApplyStyleCommand.cpp: (WebCore::createFontElement): (WebCore::createStyleSpanElement): (WebCore::ApplyStyleCommand::addInlineStyleIfNeeded):
- 2:55 PM Changeset in webkit [40098] by
-
- 10 edits2 adds in trunk
Bug 23443: Table accessibility should be re-enabled after fixing crash that occurs at WebCore::AccessibilityTable::isTableExposableThroughAccessibility() when attempting to create a link in a rich text message
https://bugs.webkit.org/show_bug.cgi?id=23443
Re-enable Accessibility tables and make sure accessibility code does not interrogate the render tree
during render tree updates
- 2:16 PM Changeset in webkit [40097] by
-
- 8 edits in trunk
Reviewed by Justin Garcia.
Fix execCommand() 'super' and 'sub' commands to add <sup> and <sub> in quirks mode, and to toggle when called twice
https://bugs.webkit.org/show_bug.cgi?id=17733
Test changed: editing/execCommand/toggle-styles-expected.txt
- editing/ApplyStyleCommand.cpp: (WebCore::StyleChange::applySubscript): (WebCore::StyleChange::applySuperscript): (WebCore::StyleChange::StyleChange): (WebCore::StyleChange::init): (WebCore::StyleChange::checkForLegacyHTMLStyleChange): (WebCore::ApplyStyleCommand::isHTMLStyleNode): (WebCore::ApplyStyleCommand::addInlineStyleIfNeeded):
- editing/EditorCommand.cpp: (WebCore::executeSubscript): (WebCore::executeSuperscript):
- editing/htmlediting.cpp: (WebCore::createHTMLElement):
- editing/htmlediting.h:
- 1:52 PM Changeset in webkit [40096] by
-
- 2 edits in trunk/WebCore
2009-01-21 Anders Carlsson <andersca@apple.com>
Fix 64-bit build.
- WebCore.LP64.exp:
- 1:34 PM Changeset in webkit [40095] by
-
- 1 copy in tags/Safari-5525.28
New tag.
- 1:32 PM Changeset in webkit [40094] by
-
- 4 edits in branches/Safari-3-2-branch
Versioning.
- 1:25 PM Changeset in webkit [40093] by
-
- 1 edit in branches/Safari-3-2-branch/WebKitLibraries/win/tools/scripts/PRODUCTVERSION
Bump version number.
- 1:25 PM Changeset in webkit [40092] by
-
- 9 edits5 adds in branches/Safari-3-2-branch
Merge r33579.
- 1:25 PM Changeset in webkit [40091] by
-
- 2 edits in branches/Safari-3-2-branch/WebCore
Merge r33993.
- 1:24 PM Changeset in webkit [40090] by
-
- 2 edits in branches/Safari-3-2-branch/WebCore
Merge r39247.
- 1:05 PM Changeset in webkit [40089] by
-
- 13 edits3 copies in trunk/WebCore
Bug 23458: Reintroduce CanvasPixelArray in ImageData.idl
<https://bugs.webkit.org/show_bug.cgi?id=23458>
Reviewed by Alexey Proskuryakov.
Return CanvasPixelArray, et al -- the only difference between this
and the original CPA implementation is that it now uses a ByteArray
rather than a vector. JSC still uses a custom wrapper, but this allows
ObjC, COM, and V8 bindings to be autogenerated again.
- 12:07 PM Changeset in webkit [40088] by
-
- 13 edits4 deletes in trunk/WebCore
2009-01-21 Dirk Schulze <krit@webkit.org>
Reviewed by Nikolas Zimmermann.
Remove last relics of platform dependent PaintServer in SVG.
We draw everything with the help of GraphicsContext.
Remove SVGPaintServerPlatform's
https://bugs.webkit.org/show_bug.cgi?id=23439
- GNUmakefile.am:
- WebCore.pro:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- svg/graphics/SVGPaintServer.cpp: (WebCore::SVGPaintServer::draw): (WebCore::SVGPaintServer::renderPath): (WebCore::SVGPaintServer::teardown):
- svg/graphics/SVGPaintServer.h:
- svg/graphics/SVGPaintServerGradient.cpp:
- svg/graphics/SVGPaintServerGradient.h:
- svg/graphics/SVGPaintServerPattern.cpp:
- svg/graphics/SVGPaintServerPattern.h:
- svg/graphics/SVGPaintServerSolid.cpp:
- svg/graphics/SVGPaintServerSolid.h:
- svg/graphics/cairo/SVGPaintServerCairo.cpp: Removed.
- svg/graphics/cg/SVGPaintServerCg.cpp: Removed.
- svg/graphics/qt/SVGPaintServerQt.cpp: Removed.
- svg/graphics/skia/SVGPaintServerSkia.cpp: Removed.
- 11:49 AM Changeset in webkit [40087] by
-
- 7 edits in trunk/WebCore
Reviewed by Alexey Proskuryakov.
Move "Element -> ScriptElement" casting functionality into ScriptElement.h
to be consistent with FormControlElement/InputElement/OptionElement/OptionGroupElement.
It was living in XMLTokenizer before, which is not an obvious place for this.
TODO: Rename 'formControlElementForElement' to 'toFormControlElement' (analogous changes for InputElement etc.)
as suggested by Alexey, it really reads better this way.
- 10:09 AM Changeset in webkit [40086] by
-
- 2 edits in trunk/JavaScriptCore
Suggested by Oliver Hunt. Reviewed by Oliver Hunt.
https://bugs.webkit.org/show_bug.cgi?id=23456
Function argument names leak
- parser/Nodes.cpp: (JSC::FunctionBodyNode::~FunctionBodyNode): Destruct parameter names.
- 8:44 AM Changeset in webkit [40085] by
-
- 12 edits4 adds in trunk/WebCore
Reviewed by George Staikos.
Fixes: https://bugs.webkit.org/show_bug.cgi?id=23444
Refactor some functionality from HTMLOption/OptGroupElement needed by RenderListBox/RenderMenuList
in two abstract base classes: OptionElement & OptionGroupElement living in dom/ - just like it
has been done before for FormControlElement and RenderTextControl.
This is needed to prepare the addtion of WMLOption/OptGroupElement.
- 7:22 AM QtWebKitJournal edited by
- (diff)
- 7:22 AM QtWebKitJournal edited by
- (diff)
