⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Jan 28, 2009:

11:38 PM Changeset in webkit [40353] by ggaren@apple.com
  • 9 edits in trunk

WebCore:

2009-01-28 Geoffrey Garen <​ggaren@apple.com>

Reviewed by Sam Weinig.


Merged FrameLoadTypeReloadAllowingStaleData with FrameLoadTypeReload.


Technically, selecting View->Text Encoding->[Non-Default Encoding] on
a page with frames may now be slightly slower than it used to be. Oh well.

  • loader/FrameLoader.cpp: (WebCore::isBackForwardLoadType): (WebCore::FrameLoader::restoreDocumentState): Subbed in FrameLoadTypeReload.

(WebCore::FrameLoader::loadURLIntoChildFrame): No need to account for
non-back-forward navigations anymore.

(WebCore::FrameLoader::canCachePage):
(WebCore::FrameLoader::logCanCachePageDecision):
(WebCore::FrameLoader::reloadWithOverrideEncoding):
(WebCore::FrameLoader::transitionToCommitted):
(WebCore::FrameLoader::loadItem): Subbed in FrameLoadTypeReload.

  • loader/FrameLoader.h: Renamed reloadAllowingStaleData => reloadWithOverrideEncoding, since that's what it actually does.

WebKit/mac:

2009-01-28 Geoffrey Garen <​ggaren@apple.com>

Reviewed by Sam Weinig.

Updated for WebCore rename.


  • WebView/WebView.mm: (-[WebView setCustomTextEncodingName:]):

WebKit/win:

2009-01-28 Geoffrey Garen <​ggaren@apple.com>

Reviewed by Sam Weinig.

Updated for WebCore rename.


  • WebView.cpp: (WebView::setCustomTextEncodingName):
10:55 PM Changeset in webkit [40352] by hyatt@apple.com
  • 7 edits in trunk/WebCore

2009-01-28 David Hyatt <​hyatt@apple.com>

Move hit testing and painting of lines from RenderFlow into RenderLineBoxList.

Reviewed by Oliver Hunt

  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::paintContents): (WebCore::RenderBlock::hitTestContents):
  • rendering/RenderFlow.cpp:
  • rendering/RenderFlow.h:
  • rendering/RenderInline.cpp: (WebCore::RenderInline::paint): (WebCore::RenderInline::nodeAtPoint):
  • rendering/RenderLineBoxList.cpp: (WebCore::RenderLineBoxList::paint): (WebCore::RenderLineBoxList::hitTest):
  • rendering/RenderLineBoxList.h:
10:38 PM Changeset in webkit [40351] by mrowe@apple.com
  • 4 edits in trunk

Versioning.

10:24 PM Changeset in webkit [40350] by mrowe@apple.com
  • 1 copy in branches/Safari-6528

New branch.

9:59 PM Changeset in webkit [40349] by mrowe@apple.com
  • 4 edits in branches/Safari-3-2-branch

Versioning.

9:58 PM Changeset in webkit [40348] by mrowe@apple.com
  • 1 copy in tags/Safari-5525.28.2

New tag.

8:41 PM Changeset in webkit [40347] by hyatt@apple.com
  • 2 edits in trunk/WebCore

2009-01-28 David Hyatt <​hyatt@apple.com>

Fix SVG pixel test regressions. I wish I could say that I understand this fix, but I don't. For
some reason the original code returned 0 for RenderSVGInlineText::yPos() and somehow my literal
replacement of yPos() with the body of that method changed the results. I am completely baffled,
but all SVG pixel tests pass again when I just take the code out.

Reviewed by Oliver Hunt

  • rendering/RenderSVGInlineText.cpp: (WebCore::RenderSVGInlineText::computeAbsoluteRectForRange):
7:53 PM Changeset in webkit [40346] by ddkilzer@apple.com
  • 2 edits in trunk/WebKit/mac

Add missing declaration for -[NSURL(WebNSURLExtras) _webkit_isFileURL]

Reviewed by Dan Bernstein.

  • Misc/WebNSURLExtras.h: (-[NSURL(WebNSURLExtras) _webkit_isFileURL]): Added missing declaration after the implementation was added in r9258.
6:24 PM Changeset in webkit [40345] by weinig@apple.com
  • 4 edits in trunk

JavaScriptCore:

2009-01-28 Sam Weinig <​sam@webkit.org>

Reviewed by Gavin Barraclough.

Fix for <rdar://problem/6525537>
Hang occurs when closing Installer window (iTunes, Aperture)

JavaScriptGlue:

2009-01-28 Sam Weinig <​sam@webkit.org>

Reviewed by Gavin Barraclough.

Fix for <rdar://problem/6525537>
Hang occurs when closing Installer window (iTunes, Aperture)

  • JSUtils.cpp: (getThreadGlobalObject): Use the shared JSGlobalData instance.
6:11 PM Changeset in webkit [40344] by hyatt@apple.com
  • 9 edits in trunk/WebCore

2009-01-28 David Hyatt <​hyatt@apple.com>

Move dirtyLineBoxes from RenderFlow to RenderInline and RenderBlock.

Reviewed by Oliver Hunt

  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::dirtyLineBoxes):
  • rendering/RenderBlock.h:
  • rendering/RenderFlow.cpp:
  • rendering/RenderFlow.h:
  • rendering/RenderInline.cpp: (WebCore::RenderInline::dirtyLineBoxes):
  • rendering/RenderInline.h:
  • rendering/RenderLineBoxList.cpp: (WebCore::RenderLineBoxList::dirtyLineBoxes):
  • rendering/RenderLineBoxList.h:
5:50 PM Changeset in webkit [40343] by hyatt@apple.com
  • 2 edits in trunk/WebCore

2009-01-28 David Hyatt <​hyatt@apple.com>

Back out my change to scrollWidth/Height from an earlier checkin since it broke stuff. The current
behavior is not correct, but this will need to be investigated before being changed again.

  • rendering/RenderBox.cpp: (WebCore::RenderBox::scrollWidth): (WebCore::RenderBox::scrollHeight):
5:33 PM Changeset in webkit [40342] by hyatt@apple.com
  • 9 edits in trunk/WebCore

2009-01-28 David Hyatt <​hyatt@apple.com>

Move paintOutline and paintOutlineWithLine from RenderFlow to RenderInline, since they only apply to inlines. Tighten up all of the code that
called paintOutline to use RenderInline as the type instead of RenderFlow.

Reviewed by cpst

  • rendering/InlineFlowBox.cpp: (WebCore::InlineFlowBox::paint):
  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::paintObject): (WebCore::RenderBlock::addContinuationWithOutline): (WebCore::RenderBlock::paintContinuationOutlines):
  • rendering/RenderFlow.cpp: (WebCore::RenderFlow::paintLines):
  • rendering/RenderFlow.h:
  • rendering/RenderInline.cpp: (WebCore::RenderInline::paintOutline): (WebCore::RenderInline::paintOutlineForLine):
  • rendering/RenderInline.h:
  • rendering/RenderObject.cpp: (WebCore::RenderObject::paintOutline):
  • rendering/RenderObject.h: (WebCore::RenderObject::PaintInfo::PaintInfo):
4:49 PM Changeset in webkit [40341] by darin@chromium.org
  • 1 edit
    3 adds in trunk/LayoutTests

2009-01-28 Darin Fisher <​darin@chromium.org>

Fixing bustage.

​https://bugs.webkit.org/show_bug.cgi?id=18835
Add missing layout test results.

  • platform/mac/editing/spelling/spelling-linebreak-expected.checksum: Added.
  • platform/mac/editing/spelling/spelling-linebreak-expected.png: Added.
  • platform/mac/editing/spelling/spelling-linebreak-expected.txt: Added.
4:34 PM Changeset in webkit [40340] by mrowe@apple.com
  • 4 edits in trunk

Versioning.

4:26 PM Changeset in webkit [40339] by weinig@apple.com
  • 2 edits in trunk/JavaScriptCore

2009-01-28 Sam Weinig <​sam@webkit.org>

Reviewed by Geoff Garen.

Initial patch by Mark Rowe.

<rdar://problem/6519356>
REGRESSION (r36006): "out of memory" alert running dromaeo on Windows

Report the cost of the ArrayStorage vector more accurately/often.

  • runtime/JSArray.cpp: (JSC::JSArray::JSArray): Report the extra cost even for a filled array because JSString using the single character optimization and immediates wont increase the cost themselves. (JSC::JSArray::putSlowCase): Update the cost when increasing the size of the array. (JSC::JSArray::increaseVectorLength): Ditto.
4:11 PM Changeset in webkit [40338] by mrowe@apple.com
  • 1 copy in tags/Safari-6528.11

New tag.

4:01 PM Changeset in webkit [40337] by darin@chromium.org
  • 2 edits in trunk/WebCore

2009-01-28 Darin Fisher <​darin@chromium.org>

Reviewed by Eric Seidel.

​https://bugs.webkit.org/show_bug.cgi?id=23596
XMLHttpRequest.cpp no longer compiles without USE(JSC)

3:59 PM Changeset in webkit [40336] by darin@chromium.org
  • 2 edits in trunk/WebCore

2009-01-28 Darin Fisher <​darin@chromium.org>

Reviewed by Darin Adler.

​https://bugs.webkit.org/show_bug.cgi?id=23597
Make it possible to compile Database.cpp when USE(JSC) is not defined

  • storage/Database.cpp: (WebCore::Database::Database):
3:49 PM Changeset in webkit [40335] by mitz@apple.com
  • 2 edits in trunk/WebCore

Reviewed by Darin Adler.

  • fix <rdar://problem/6077047> REGRESSION (r34544): Custom icon does not appear in address field on first visit to any site
  • loader/icon/IconLoader.cpp: (WebCore::IconLoader::finishLoading): Changed to set the icon data only after establishing a mapping from the page URL(s) to the icon. Doing things the other way around resulted in the data not being cached in the icon-URL to IconRecord map (because there was no interested page at the time) and subsequently having to be fetched asynchronously from the database when the page-to-icon mapping was established.
3:44 PM Changeset in webkit [40334] by hyatt@apple.com
  • 7 edits in trunk/WebCore

2009-01-28 David Hyatt <​hyatt@apple.com>

Move addFocusRingRects from RenderFlow down into RenderBlock and RenderInline.

Reviewed by Oliver Hunt

  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::addFocusRingRects):
  • rendering/RenderBlock.h:
  • rendering/RenderFlow.cpp:
  • rendering/RenderFlow.h:
  • rendering/RenderInline.cpp: (WebCore::RenderInline::addFocusRingRects):
  • rendering/RenderInline.h:
3:18 PM Changeset in webkit [40333] by hyatt@apple.com
  • 5 edits in trunk/WebCore

2009-01-28 David Hyatt <​hyatt@apple.com>

Move localCaretRect from RenderFlow into RenderBlock, since it only applied to blocks anyway and
was misplaced from the start.

Reviewed by anttik

  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::localCaretRect):
  • rendering/RenderBlock.h:
  • rendering/RenderFlow.cpp:
  • rendering/RenderFlow.h:
2:54 PM Changeset in webkit [40332] by weinig@apple.com
  • 13 edits
    3 adds in trunk

JavaScriptCore:

2009-01-28 Sam Weinig <​sam@webkit.org>

Reviewed by Geoff Garen.

Fix for <rdar://problem/6129678>
REGRESSION (Safari 3-4): Local variable not accessible from Dashcode console or variables view

Iterating the properties of activation objects accessed through the WebKit debugging
APIs was broken by forced conversion of JSActivation to the global object. To fix this,
we use a proxy activation object that acts more like a normal JSObject.

  • debugger/DebuggerActivation.cpp: Added. (JSC::DebuggerActivation::DebuggerActivation): (JSC::DebuggerActivation::mark): (JSC::DebuggerActivation::className): (JSC::DebuggerActivation::getOwnPropertySlot): (JSC::DebuggerActivation::put): (JSC::DebuggerActivation::putWithAttributes): (JSC::DebuggerActivation::deleteProperty): (JSC::DebuggerActivation::getPropertyNames): (JSC::DebuggerActivation::getPropertyAttributes): (JSC::DebuggerActivation::defineGetter): (JSC::DebuggerActivation::defineSetter): (JSC::DebuggerActivation::lookupGetter): (JSC::DebuggerActivation::lookupSetter):
  • debugger/DebuggerActivation.h: Added. Proxy JSActivation object for Debugging.
  • runtime/JSActivation.h: (JSC::JSActivation::isActivationObject): Added.
  • runtime/JSObject.h: (JSC::JSObject::isActivationObject): Added.

WebCore:

2009-01-28 Sam Weinig <​sam@webkit.org>

Reviewed by Geoff Garen.

Add forwarding header.

  • ForwardingHeaders/debugger/DebuggerActivation.h: Added.

WebKit/mac:

2009-01-28 Sam Weinig <​sam@webkit.org>

Reviewed by Geoff Garen.

Fix for <rdar://problem/6129678>
REGRESSION (Safari 3-4): Local variable not accessible from Dashcode console or variables view

  • WebView/WebScriptDebugDelegate.mm: (-[WebScriptCallFrame scopeChain]): Wrap JSActivations in DebuggerActivations.
2:47 PM Changeset in webkit [40331] by ggaren@apple.com
  • 1 edit
    49 adds in trunk/LayoutTests

2009-01-28 Geoffrey Garen <​ggaren@apple.com>

Reviewed by Sam Weinig.


Added layout tests for how many history items are created during a
redirect. (Many of these results are expected failures for now.)

  • http/tests/history: Added.
  • http/tests/history/redirect-200-refresh-0-seconds-expected.txt: Added.
  • http/tests/history/redirect-200-refresh-0-seconds.pl: Added.
  • http/tests/history/redirect-200-refresh-2-seconds-expected.txt: Added.
  • http/tests/history/redirect-200-refresh-2-seconds.pl: Added.
  • http/tests/history/redirect-301-expected.txt: Added.
  • http/tests/history/redirect-301.pl: Added.
  • http/tests/history/redirect-302-expected.txt: Added.
  • http/tests/history/redirect-302.pl: Added.
  • http/tests/history/redirect-303-expected.txt: Added.
  • http/tests/history/redirect-303.pl: Added.
  • http/tests/history/redirect-307-expected.txt: Added.
  • http/tests/history/redirect-307.pl: Added.
  • http/tests/history/redirect-js-document-location-0-seconds-expected.txt: Added.
  • http/tests/history/redirect-js-document-location-0-seconds.html: Added.
  • http/tests/history/redirect-js-document-location-2-seconds-expected.txt: Added.
  • http/tests/history/redirect-js-document-location-2-seconds.html: Added.
  • http/tests/history/redirect-js-document-location-before-load-expected.txt: Added.
  • http/tests/history/redirect-js-document-location-before-load.html: Added.
  • http/tests/history/redirect-js-location-0-seconds-expected.txt: Added.
  • http/tests/history/redirect-js-location-0-seconds.html: Added.
  • http/tests/history/redirect-js-location-2-seconds-expected.txt: Added.
  • http/tests/history/redirect-js-location-2-seconds.html: Added.
  • http/tests/history/redirect-js-location-assign-0-seconds-expected.txt: Added.
  • http/tests/history/redirect-js-location-assign-0-seconds.html: Added.
  • http/tests/history/redirect-js-location-assign-2-seconds-expected.txt: Added.
  • http/tests/history/redirect-js-location-assign-2-seconds.html: Added.
  • http/tests/history/redirect-js-location-assign-before-load-expected.txt: Added.
  • http/tests/history/redirect-js-location-assign-before-load.html: Added.
  • http/tests/history/redirect-js-location-before-load-expected.txt: Added.
  • http/tests/history/redirect-js-location-before-load.html: Added.
  • http/tests/history/redirect-js-location-href-0-seconds-expected.txt: Added.
  • http/tests/history/redirect-js-location-href-0-seconds.html: Added.
  • http/tests/history/redirect-js-location-href-2-seconds-expected.txt: Added.
  • http/tests/history/redirect-js-location-href-2-seconds.html: Added.
  • http/tests/history/redirect-js-location-href-before-load-expected.txt: Added.
  • http/tests/history/redirect-js-location-href-before-load.html: Added.
  • http/tests/history/redirect-js-location-replace-0-seconds-expected.txt: Added.
  • http/tests/history/redirect-js-location-replace-0-seconds.html: Added.
  • http/tests/history/redirect-js-location-replace-2-seconds-expected.txt: Added.
  • http/tests/history/redirect-js-location-replace-2-seconds.html: Added.
  • http/tests/history/redirect-js-location-replace-before-load-expected.txt: Added.
  • http/tests/history/redirect-js-location-replace-before-load.html: Added.
  • http/tests/history/redirect-meta-refresh-0-seconds-expected.txt: Added.
  • http/tests/history/redirect-meta-refresh-0-seconds.html: Added.
  • http/tests/history/redirect-meta-refresh-2-seconds-expected.txt: Added.
  • http/tests/history/redirect-meta-refresh-2-seconds.html: Added.
  • http/tests/history/resources: Added.
  • http/tests/history/resources/redirect-target.html: Added.
2:43 PM Changeset in webkit [40330] by ggaren@apple.com
  • 2 edits in trunk/WebKitTools

2009-01-28 Geoffrey Garen <​ggaren@apple.com>

Build fix for GTK.

  • DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: (LayoutTestController::webHistoryItemCount):
2:36 PM Changeset in webkit [40329] by ggaren@apple.com
  • 5 edits in trunk/WebKitTools

2009-01-28 Geoffrey Garen <​ggaren@apple.com>

Reviewed by Sam Weinig.


Added support for querying how many history items were created during a
layout test.

  • DumpRenderTree/LayoutTestController.cpp: (getWebHistoryItemCountCallback): (LayoutTestController::staticValues):
  • DumpRenderTree/LayoutTestController.h:
  • DumpRenderTree/mac/LayoutTestControllerMac.mm: (LayoutTestController::webHistoryItemCount):
  • DumpRenderTree/win/LayoutTestControllerWin.cpp: (LayoutTestController::webHistoryItemCount):
2:35 PM Changeset in webkit [40328] by hyatt@apple.com
  • 1 edit in trunk/WebCore/WebCore.xcodeproj/project.pbxproj

Fix build bustage.

1:58 PM Changeset in webkit [40327] by hyatt@apple.com
  • 1 edit in trunk/WebCore/rendering/RenderLineBoxList.h

Fix build bustage in release builds.

1:48 PM Changeset in webkit [40326] by hyatt@apple.com
  • 8 edits in trunk/WebCore

2009-01-28 David Hyatt <​hyatt@apple.com>

Move createInlineBox out of RenderFlow and down into RenderInline and RenderBlock.

Reviewed by Beth Dakin

  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::createInlineBox):
  • rendering/RenderBlock.h:
  • rendering/RenderFlow.cpp:
  • rendering/RenderFlow.h:
  • rendering/RenderInline.cpp: (WebCore::RenderInline::createInlineBox):
  • rendering/RenderInline.h:
  • rendering/bidi.cpp:
1:18 PM Changeset in webkit [40325] by adachan@apple.com
  • 4 edits in branches/Safari-3-2-branch/WebCore

Merge the rest of r33579.

Reviewed by Steve Falkenburg.

  • platform/network/cf/ResourceHandleCFNet.cpp: (WebCore::makeFinalRequest):
  • platform/network/cf/ResourceRequestCFNet.cpp: (WebCore::ResourceRequest::doUpdatePlatformRequest):
  • platform/network/win/CookieJarWin.cpp: (WebCore::setCookies): (WebCore::cookies): (WebCore::cookiesEnabled):
12:56 PM Changeset in webkit [40324] by hyatt@apple.com
  • 5 edits in trunk/WebCore

2009-01-28 David Hyatt <​hyatt@apple.com>

Move calcMargins from RenderFlow to RenderInline, since it was only ever called on RenderInlines.

Reviewed by Oliver Hunt

  • rendering/RenderFlow.cpp:
  • rendering/RenderFlow.h:
  • rendering/RenderInline.h: (WebCore::RenderInline::calcMargins):
  • rendering/bidi.cpp: (WebCore::RenderBlock::layoutInlineChildren):
12:48 PM Changeset in webkit [40323] by hyatt@apple.com
  • 16 edits
    2 adds in trunk/WebCore

2009-01-28 David Hyatt <​hyatt@apple.com>

Refactor the first and last line box member variables from RenderFlow. Encapsulate them into a new class called RenderLineBoxList that manages all modifications to
the list. This change will make it easier to give RenderInline and RenderBlock separate versions of the line box list without having to duplicate very much code.

Reviewed by Oliver Hunt

  • GNUmakefile.am:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • WebCoreSources.bkl:
  • rendering/InlineFlowBox.cpp: (WebCore::InlineFlowBox::deleteLine): (WebCore::InlineFlowBox::removeLineBoxFromRenderObject): (WebCore::InlineFlowBox::extractLine): (WebCore::InlineFlowBox::extractLineBoxFromRenderObject): (WebCore::InlineFlowBox::attachLine): (WebCore::InlineFlowBox::attachLineBoxToRenderObject):
  • rendering/InlineFlowBox.h:
  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::deleteLineBoxTree):
  • rendering/RenderFlow.cpp: (WebCore::RenderFlow::destroy): (WebCore::RenderFlow::dirtyLineBoxes): (WebCore::RenderFlow::createInlineBox):
  • rendering/RenderFlow.h: (WebCore::RenderFlow::RenderFlow): (WebCore::RenderFlow::lineBoxes): (WebCore::RenderFlow::firstLineBox): (WebCore::RenderFlow::lastLineBox):
  • rendering/RenderLineBoxList.cpp: Added. (WebCore::RenderLineBoxList::~RenderLineBoxList): (WebCore::RenderLineBoxList::appendLineBox): (WebCore::RenderLineBoxList::deleteLineBoxTree): (WebCore::RenderLineBoxList::extractLineBox): (WebCore::RenderLineBoxList::attachLineBox): (WebCore::RenderLineBoxList::removeLineBox): (WebCore::RenderLineBoxList::deleteLineBoxes): (WebCore::RenderLineBoxList::checkConsistency):
  • rendering/RenderLineBoxList.h: Added. (WebCore::RenderLineBoxList::RenderLineBoxList): (WebCore::RenderLineBoxList::firstLineBox): (WebCore::RenderLineBoxList::lastLineBox): (WebCore::RenderLineBoxList::checkConsistency):
  • rendering/RenderSVGInline.cpp: (WebCore::RenderSVGInline::createInlineBox):
  • rendering/RenderSVGText.cpp: (WebCore::RenderSVGText::createInlineBox):
  • rendering/RootInlineBox.cpp: (WebCore::RootInlineBox::removeLineBoxFromRenderObject): (WebCore::RootInlineBox::extractLineBoxFromRenderObject): (WebCore::RootInlineBox::attachLineBoxToRenderObject):
  • rendering/RootInlineBox.h:
  • rendering/bidi.cpp: (WebCore::RenderBlock::layoutInlineChildren):
12:46 PM Changeset in webkit [40322] by ddkilzer@apple.com
  • 3 edits in trunk/WebCore

Clean up FontPlatformData constructor

Reviewed by David Hyatt.

  • platform/graphics/mac/FontPlatformData.h: Updated copyright. (WebCore::FontPlatformData::FontPlatformData): Provide readable names for constructor arguments and reformat member variables.
  • platform/graphics/mac/FontPlatformDataMac.mm: Updated copyright. (WebCore::FontPlatformData::FontPlatformData): Provide readable names for constructor arguments and reformat member variables.
12:37 PM Changeset in webkit [40321] by darin@chromium.org
  • 3 edits in trunk/WebCore

2009-01-28 Tony Chang <​tony@chromium.org>

Reviewed by David Hyatt.

​https://bugs.webkit.org/show_bug.cgi?id=23593
Compile fixes for RenderThemeChromiumMac and RenderThemeChromiumWin.
This is a follow up for hyatt's RenderBox changes.

  • rendering/RenderThemeChromiumMac.mm: (WebCore::RenderThemeChromiumMac::baselinePosition):
  • rendering/RenderThemeChromiumWin.cpp: (WebCore::RenderThemeChromiumWin::paintMenuList):
12:26 PM Changeset in webkit [40320] by ddkilzer@apple.com
  • 2 edits in trunk

Fixed ChangeLog dates.

12:07 PM Changeset in webkit [40319] by ddkilzer@apple.com
  • 6 edits in trunk

Bug 23490: Remove initialRefCount argument from RefCounted class

<​https://bugs.webkit.org/show_bug.cgi?id=23490>

Reviewed by Darin Adler.

JavaScriptCore:

RefCountedBase now always starts with a ref count of 1, so there
is no need to pass the initialRefCount into the class anymore.

  • wtf/ByteArray.h: (WTF::ByteArray::ByteArray): Removed call to RefCounted(1).
  • wtf/RefCounted.h: (WTF::RefCountedBase::RefCountedBase): Changed to start with a ref count of 1. (WTF::RefCounted::RefCounted): Removed initialRefCount argument and removed call to RefCounted(1).

WebKit/wx:

FrameLoaderClientWx is no longer a RefCounted class.

  • WebKitSupport/FrameLoaderClientWx.cpp: (WebCore::FrameLoaderClientWx::FrameLoaderClientWx): Removed call to the RefCounted<FrameLoaderClientWx>(0) super constructor.
  • WebKitSupport/FrameLoaderClientWx.h: Don't include RefCounted.h and stop inheriting from RefCounted<FrameLoaderClientWx>.
11:40 AM Changeset in webkit [40318] by Simon Fraser
  • 5 edits
    8 adds in trunk

2009-01-28 Simon Fraser <Simon Fraser>

Reviewed by Dave Hyatt

​https://bugs.webkit.org/show_bug.cgi?id=23582

Fix assertions when inline elements have both opacity (or something
else that creates a RenderLayer), and transform by ensuring that
setHasTransform() is only called for non-inline or replaced elements.
We also have to ensure that RenderReplicas will get transforms applied
to them by lying about them being replaced.

Tests: fast/transforms/transform-on-inline.html

fast/transforms/transform-table-row.html

  • rendering/RenderBox.cpp: (WebCore::RenderBox::styleDidChange):
  • rendering/RenderReplica.cpp: (WebCore::RenderReplica::RenderReplica):
  • rendering/RenderTableRow.h: (WebCore::RenderTableRow::requiresLayer):
11:38 AM Changeset in webkit [40317] by darin@chromium.org
  • 3 edits
    1 add in trunk

2009-01-28 Hironori Bono <​hbono@chromium.org>

Reviewed by Justin Garcia.

​https://bugs.webkit.org/show_bug.cgi?id=18835
Spelling underlines disappear when they shouldn't

The WebCore::InsertLineBreakCommand::doApply() function splits a text node
without copying existing markers. To fix this bug, change code which
manually splits a text node into a CompositeEditCommand::splitTextNode() call.

Test: editing/spelling/spelling-linebreak.html

  • editing/InsertLineBreakCommand.cpp: (WebCore::InsertLineBreakCommand::doApply):
11:31 AM Changeset in webkit [40316] by hyatt@apple.com
  • 9 edits in trunk/WebCore

2009-01-28 David Hyatt <​hyatt@apple.com>

Move the m_lineHeight member variable out of RenderFlow and down into RenderBlock and RenderInline. Shift the line height computation into RenderStyle so
that it isn't repeated in three places.

Reviewed by Sam Weinig

  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::RenderBlock): (WebCore::RenderBlock::lineHeight):
  • rendering/RenderBlock.h:
  • rendering/RenderFlow.cpp:
  • rendering/RenderFlow.h: (WebCore::RenderFlow::RenderFlow):
  • rendering/RenderInline.cpp: (WebCore::RenderInline::RenderInline): (WebCore::RenderInline::lineHeight):
  • rendering/RenderInline.h:
  • rendering/RenderObject.cpp: (WebCore::RenderObject::lineHeight):
  • rendering/style/RenderStyle.h: (WebCore::InheritedFlags::computedLineHeight):
11:19 AM Changeset in webkit [40315] by darin@chromium.org
  • 4 edits in trunk/WebCore

2009-01-28 Zachary Kuznia <​zork@chromiuum.org>

Reviewed by Sam Weinig.

​https://bugs.webkit.org/show_bug.cgi?id=22070
Add an option to allow scripts to close windows.

  • page/Settings.cpp: (WebCore::Settings::Settings): (WebCore::Settings::setAllowScriptsToCloseWindows):
  • page/Settings.h: (WebCore::Settings::allowScriptsToCloseWindows):
10:52 AM Changeset in webkit [40314] by darin@chromium.org
  • 2 edits in trunk/WebCore

2009-01-28 Adam Langley <​agl@google.com>

Reviewed by Sam Weinig.

​https://bugs.webkit.org/show_bug.cgi?id=23573
Make PlatformWidget on chromium an intptr_t to match changes made in Chromium

  • platform/chromium/PlatformWidget.h:
9:39 AM Changeset in webkit [40313] by hyatt@apple.com
  • 2 edits in trunk/WebCore

2009-01-28 David Hyatt <​hyatt@apple.com>

Fix for

<rdar://problem/6531287> REGRESSION: CrashTracer: [USER] 12 crashes in Safari at com.apple.WebCore • WebCore::RenderBlock::removeFloatingObject + 59

My tightening up of markAllDescendantsWithFloatsForLayout exposed a buggy check in that code that could
lead to a bad cast.

  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::markAllDescendantsWithFloatsForLayout):
9:30 AM Changeset in webkit [40312] by hyatt@apple.com
  • 29 edits in trunk/WebCore

2009-01-27 David Hyatt <​hyatt@apple.com>

​https://bugs.webkit.org/show_bug.cgi?id=23576

Work towards eliminating RenderFlow from the tree.


Move the m_continuation variable down from RenderFlow into RenderInline and RenderBlock. Since a block can only have an inline continuation following it, the type
of the member and methods reflect this (inlineContinuation() and m_inlineContinuation). Since an inline can have either a block or an inline continuation following it,
a base class of RenderBox* is used for the type of object returned (in anticipation of the removal of RenderFlow).


Since moving the continuation variable down into the subclasses increased the size of RenderInline and RenderBlock by 4 bytes, this patch also moves all of the bitfield
members of RenderFlow up to RenderObject. Since they fit within the available bits on RenderObject, this patch actually results in a net savings of 4 bytes on RenderInlines
and RenderBlocks!


One bitfield member was eliminated rather than moved: m_firstLine. This was really more of a state variable used during line layout only, so I removed it as a member
and just passed firstLine down to various methods as needed. Doing so uncovered some potential bugs where the first line state was not being respected when querying for
line offsets.

Continuations have been completely hidden from all files except for RenderFlow, RenderBlock and RenderInline. All of the code that referenced continuations directly
from base classes has been refactored to use virtual methods on RenderBlock and RenderInline instead.


RenderFlow still has a common addChildWithContinuation method that is used by both blocks and inlines. Since refactoring that method will be pretty tricky, I've held
off on that for a later patch.

Reviewed by Oliver Hunt

  • html/HTMLAnchorElement.cpp: (WebCore::HTMLAnchorElement::isKeyboardFocusable):
  • page/AccessibilityRenderObject.cpp: (WebCore::AccessibilityRenderObject::anchorElement): (WebCore::AccessibilityRenderObject::boundingBoxRect):
  • rendering/InlineFlowBox.cpp: (WebCore::InlineFlowBox::determineSpacingForFlowBoxes): (WebCore::InlineFlowBox::paint):
  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::RenderBlock): (WebCore::RenderBlock::~RenderBlock): (WebCore::RenderBlock::destroy): (WebCore::RenderBlock::addChildToFlow): (WebCore::RenderBlock::makeChildrenNonInline): (WebCore::RenderBlock::removeChild): (WebCore::RenderBlock::layoutBlock): (WebCore::RenderBlock::expandsToEncloseOverhangingFloats): (WebCore::RenderBlock::collapseMargins): (WebCore::RenderBlock::determineHorizontalPosition): (WebCore::RenderBlock::setCollapsedBottomMargin): (WebCore::RenderBlock::layoutOnlyPositionedObjects): (WebCore::RenderBlock::paintObject): (WebCore::RenderBlock::addContinuationWithOutline): (WebCore::RenderBlock::setSelectionState): (WebCore::RenderBlock::shouldPaintSelectionGaps): (WebCore::RenderBlock::fillSelectionGaps): (WebCore::RenderBlock::leftSelectionOffset): (WebCore::RenderBlock::rightSelectionOffset): (WebCore::RenderBlock::leftOffset): (WebCore::RenderBlock::leftRelOffset): (WebCore::RenderBlock::rightOffset): (WebCore::RenderBlock::rightRelOffset): (WebCore::RenderBlock::lineWidth): (WebCore::RenderBlock::lowestPosition): (WebCore::RenderBlock::rightmostPosition): (WebCore::RenderBlock::leftmostPosition): (WebCore::RenderBlock::getClearDelta): (WebCore::RenderBlock::nodeAtPoint): (WebCore::RenderBlock::offsetForContents): (WebCore::RenderBlock::availableWidth): (WebCore::RenderBlock::setDesiredColumnCountAndWidth): (WebCore::RenderBlock::desiredColumnWidth): (WebCore::RenderBlock::desiredColumnCount): (WebCore::RenderBlock::columnRects): (WebCore::RenderBlock::layoutColumns): (WebCore::RenderBlock::adjustPointToColumnContents): (WebCore::RenderBlock::adjustRectForColumns): (WebCore::RenderBlock::absoluteRects): (WebCore::RenderBlock::absoluteQuads): (WebCore::RenderBlock::rectWithOutlineForRepaint): (WebCore::RenderBlock::hoverAncestor): (WebCore::RenderBlock::updateDragState): (WebCore::RenderBlock::outlineStyleForRepaint): (WebCore::RenderBlock::childBecameNonInline): (WebCore::RenderBlock::updateHitTestResult):
  • rendering/RenderBlock.h: (WebCore::RenderBlock::rightOffset): (WebCore::RenderBlock::leftOffset): (WebCore::RenderBlock::inlineContinuation): (WebCore::RenderBlock::setInlineContinuation):
  • rendering/RenderBox.cpp: (WebCore::RenderBox::absoluteRects): (WebCore::RenderBox::absoluteQuads): (WebCore::RenderBox::addFocusRingRects): (WebCore::RenderBox::containingBlockWidth):
  • rendering/RenderBox.h: (WebCore::RenderBox::collapsedMarginBottom): (WebCore::RenderBox::childBecameNonInline):
  • rendering/RenderContainer.cpp: (WebCore::RenderContainer::updateBeforeAfterContentForContainer): (WebCore::RenderContainer::removeLeftoverAnonymousBlock):
  • rendering/RenderFlexibleBox.cpp: (WebCore::RenderFlexibleBox::layoutVerticalBox):
  • rendering/RenderFlow.cpp: (WebCore::nextContinuation): (WebCore::RenderFlow::continuationBefore): (WebCore::RenderFlow::addChildWithContinuation): (WebCore::RenderFlow::addChild): (WebCore::RenderFlow::destroy): (WebCore::RenderFlow::addFocusRingRects):
  • rendering/RenderFlow.h: (WebCore::RenderFlow::RenderFlow):
  • rendering/RenderInline.cpp: (WebCore::RenderInline::RenderInline): (WebCore::RenderInline::destroy): (WebCore::RenderInline::inlineContinuation): (WebCore::RenderInline::styleDidChange): (WebCore::RenderInline::addChildToFlow): (WebCore::RenderInline::cloneInline): (WebCore::RenderInline::splitInlines): (WebCore::RenderInline::splitFlow): (WebCore::RenderInline::positionForCoordinates): (WebCore::RenderInline::rectWithOutlineForRepaint): (WebCore::RenderInline::updateDragState): (WebCore::RenderInline::childBecameNonInline): (WebCore::RenderInline::updateHitTestResult):
  • rendering/RenderInline.h: (WebCore::RenderInline::isRenderInline): (WebCore::RenderInline::continuation): (WebCore::RenderInline::setContinuation):
  • rendering/RenderListItem.cpp: (WebCore::RenderListItem::positionListMarker):
  • rendering/RenderListMarker.cpp: (WebCore::RenderListMarker::RenderListMarker): (WebCore::RenderListMarker::setSelectionState):
  • rendering/RenderListMarker.h:
  • rendering/RenderObject.cpp: (WebCore::RenderObject::RenderObject): (WebCore::RenderObject::repaintAfterLayoutIfNeeded): (WebCore::RenderObject::rectWithOutlineForRepaint): (WebCore::RenderObject::handleDynamicFloatPositionChange): (WebCore::RenderObject::updateDragState): (WebCore::RenderObject::updateHitTestResult): (WebCore::RenderObject::getTextDecorationColors): (WebCore::RenderObject::adjustRectForOutlineAndShadow):
  • rendering/RenderObject.h: (WebCore::RenderObject::isInlineBlockOrInlineTable): (WebCore::RenderObject::childrenInline): (WebCore::RenderObject::setChildrenInline): (WebCore::RenderObject::hasColumns): (WebCore::RenderObject::setHasColumns): (WebCore::RenderObject::cellWidthChanged): (WebCore::RenderObject::setCellWidthChanged): (WebCore::RenderObject::isInlineContinuation): (WebCore::RenderObject::hoverAncestor): (WebCore::RenderObject::outlineStyleForRepaint): (WebCore::RenderObject::setHasMarkupTruncation): (WebCore::RenderObject::hasMarkupTruncation): (WebCore::RenderObject::selectionState): (WebCore::RenderObject::setSelectionState): (WebCore::RenderObject::hasSelectedChildren): (WebCore::RenderObject::isTopMarginQuirk): (WebCore::RenderObject::isBottomMarginQuirk): (WebCore::RenderObject::setTopMarginQuirk): (WebCore::RenderObject::setBottomMarginQuirk):
  • rendering/RenderReplaced.cpp: (WebCore::RenderReplaced::RenderReplaced): (WebCore::RenderReplaced::setSelectionState):
  • rendering/RenderReplaced.h: (WebCore::RenderReplaced::canBeSelectionLeaf):
  • rendering/RenderTable.cpp: (WebCore::RenderTable::calcWidth):
  • rendering/RenderTableCell.cpp: (WebCore::RenderTableCell::updateWidth): (WebCore::RenderTableCell::layout):
  • rendering/RenderText.cpp: (WebCore::RenderText::RenderText): (WebCore::RenderText::localCaretRect): (WebCore::RenderText::setSelectionState):
  • rendering/RenderText.h: (WebCore::RenderText::canBeSelectionLeaf):
  • rendering/RenderView.cpp: (WebCore::RenderView::updateHitTestResult):
  • rendering/RenderView.h:
  • rendering/RootInlineBox.cpp: (WebCore::RootInlineBox::selectionTop):
  • rendering/bidi.cpp: (WebCore::RenderBlock::createLineBoxes): (WebCore::RenderBlock::constructLine): (WebCore::RenderBlock::computeHorizontalPositionsForLine): (WebCore::RenderBlock::layoutInlineChildren): (WebCore::RenderBlock::determineStartPosition): (WebCore::RenderBlock::skipTrailingWhitespace): (WebCore::RenderBlock::skipLeadingWhitespace): (WebCore::RenderBlock::fitBelowFloats): (WebCore::RenderBlock::findNextLineBreak): (WebCore::RenderBlock::checkLinesForTextOverflow):
8:39 AM Changeset in webkit [40311] by treat@webkit.org
  • 9 edits in trunk

Reviewed by Nikolas Zimmermann and George Staikos.

​https://bugs.webkit.org/show_bug.cgi?id=23557
Allow option of hit testing frame content without clipping to the visible
viewport.

8:26 AM Changeset in webkit [40310] by Simon Hausmann
  • 2 edits in trunk/WebCore

2009-01-28 Simon Hausmann <​simon.hausmann@nokia.com>

Reviewed by Holger Freyther.

Fix the build with Qt on Windows.

Make sure that the QTWEBKIT_EXPORT macro becomes the Q_DECL_EXPORT macro
instead of the import macro when building the dll, by defining
QT_MAKEDLL.

SystemTimeWin.cpp is needed on Windows for userIdleTime(), which for the
other Qt platforms comes from TemporaryLinkStubs.cpp.

5:42 AM Changeset in webkit [40309] by ariya@webkit.org
  • 2 edits in trunk/WebKit/qt

2009-01-28 Ariya Hidayat <​ariya.hidayat@trolltech.com>

Rubber-stamped by Simon Hausmann.

Provide default implementations of JavaScript dialog boxes like in
most web browsers, i.e. indicate that is from JavaScript and show the
frame URL.

  • Api/qwebpage.cpp: (QWebPage::javaScriptAlert): (QWebPage::javaScriptConfirm): (QWebPage::javaScriptPrompt):
5:19 AM Changeset in webkit [40308] by ariya@webkit.org
  • 2 edits in trunk/WebCore

2009-01-28 Ariya Hidayat <​ariya.hidayat@trolltech.com>

Reviewed by Simon Hausmann.

[Qt] Speed-up clipping: avoid calling expensive QPainter::clipRegion().
Beside, the check is not necessary since QPainter::setClipRect() will
work just fine if there is no clip region yet.

  • platform/graphics/qt/GraphicsContextQt.cpp: (WebCore::GraphicsContext::clip):
12:19 AM Changeset in webkit [40307] by darin@chromium.org
  • 2 edits
    2 adds in trunk/WebCore

2009-01-28 Darin Fisher <​darin@chromium.org>

Reviewed by Darin Adler.

​https://bugs.webkit.org/show_bug.cgi?id=23546
Upstream GoogleURL implementation of KURL

  • platform/KURL.h:
  • platform/KURLGoogle.cpp: Added.
  • platform/KURLGooglePrivate.h: Added.

Jan 27, 2009:

8:08 PM Changeset in webkit [40306] by andersca@apple.com
  • 2 edits in trunk/WebKit/mac

2009-01-27 Anders Carlsson <​andersca@apple.com>

Reviewed by Oliver Hunt.

Fix two bugs with Core Animation based plug-ins.


  1. The plug-in view was marked as opaque even though it's not. (This would leave garbage in the plug-in view).
  2. The plug-in layer needs to have autoresizing turned on.


  • Plugins/WebNetscapePluginView.mm: (-[WebNetscapePluginView setLayer:]):
5:54 PM Changeset in webkit [40305] by Darin Adler
  • 2 edits in trunk/WebCore

2009-01-27 Darin Adler <Darin Adler>

Reviewed by Sam Weinig.

REGRESSION (r40234): Launching iTunes from a link displays a
"Safari can't find the Internet plug-in" sheet in Safari
rdar://problem/6533678

  • rendering/RenderPartObject.cpp: (WebCore::havePlugin): Put the check for empty string in here. (WebCore::serviceTypeForClassId): Only return activeXType() if we have a plug-in that can handle that type. While it might be logical to return an Active X type for any <object> with a classId in it, even if we don't have a plug-in that implements Active X, existing clients, such as Safari, don't expect that.
5:10 PM Changeset in webkit [40304] by mitz@apple.com
  • 2 edits in trunk/WebCore

Reviewed by Steve Falkenburg.

  • fix <rdar://problem/6524351> Text looks bad when font smoothing is forced off
  • platform/graphics/win/FontCGWin.cpp: (WebCore::Font::drawGlyphs): Changed to use GDI rather than Core Graphics if the client has turned font smoothing off.
3:05 PM Changeset in webkit [40303] by Simon Fraser
  • 17 edits in trunk/WebCore

2009-01-27 Simon Fraser <Simon Fraser>

Reviewed by Dave Hyatt

​https://bugs.webkit.org/show_bug.cgi?id=23360

Use the new container-relative repaint methods to compute
post-layout repaints, and repaints using RenderLayer's
cached repaintRect() relative to that container, rather than
using absolute coords.

Replaced lots of boilerplate old/new rect code in various
layout methods with a stack-based LayoutRepainter class, and
fixed a bug in RenderTable which set didFullRepaint to
'true' every time.

2:40 PM Changeset in webkit [40302] by beidson@apple.com
  • 6 edits in trunk/WebCore

2009-01-27 Brady Eidson <​beidson@apple.com>

Reviewed by Darin Adler

<rdar://problem/3541409> - More groundwork and cleanup for CachedFrames

  • history/CachedFrame.cpp: (WebCore::CachedFrame::CachedFrame): Make the savePlatformDataToCachedFrame() client call here, and add the code for caching subframes. (WebCore::CachedFrame::clear):
  • history/CachedFrame.h: Change to be RefCounted (WebCore::CachedFrame::create): (WebCore::CachedFrame::url):
  • history/CachedPage.cpp: (WebCore::CachedPage::CachedPage): (WebCore::CachedPage::restore):
  • history/CachedPage.h: (WebCore::CachedPage::document): (WebCore::CachedPage::documentLoader): (WebCore::CachedPage::view): (WebCore::CachedPage::url): (WebCore::CachedPage::domWindow): (WebCore::CachedPage::cachedMainFrame):
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::cachePageForHistoryItem): Move the platform data saving into the CachedFrame itself.
2:09 PM Changeset in webkit [40301] by zecke@webkit.org
  • 2 edits in trunk/LayoutTests

2009-01-27 Holger Hans Peter Freyther <​zecke@selfish.org>

Rubber stamped by Darin Adler.

Get the build bot green as discussed on the mailinglist. There is
only one crash after unloading a page with plugins. For the remaining
failing tests DumpRenderTree needs to be looked at.

  • platform/gtk/Skipped:
1:54 PM Changeset in webkit [40300] by Simon Fraser
  • 13 edits in trunk/WebCore

2009-01-27 Simon Fraser <Simon Fraser>

Reviewed by Dave Hyatt

Flip the arguments of computeRectForRepaint() from

computeRectForRepaint(IntRect&, RenderBox* repaintContainer, bool)

to

computeRectForRepaint(RenderBox* repaintContainer, IntRect&, bool)

1:44 PM Changeset in webkit [40299] by ddkilzer@apple.com
  • 2 edits in trunk/WebCore

Add missing header guards to AccessibilityObjectWrapper.h

Reviewed by Anders Carlsson.

  • page/mac/AccessibilityObjectWrapper.h: Added missing header guards.
1:28 PM Changeset in webkit [40298] by Simon Fraser
  • 5 edits in trunk/WebCore

2009-01-27 Simon Fraser <Simon Fraser>

Reviewed by Dave Hyatt

​https://bugs.webkit.org/show_bug.cgi?id=23567

Fix crash of svg/custom/stop-crash.svg testcase because of
infinite recursion, as I missed replacing absoluteClippedOverflowRect()
with clippedOverflowRectForRepaint() in RenderSVGGradientStop.

Also fix a missed conversion in RenderTableCol, and add a couple
of comments.

11:24 AM Changeset in webkit [40297] by adele@apple.com
  • 2 edits in trunk/WebCore

2009-01-27 Adele Peterson <​adele@apple.com>

RS by Dave Hyatt

Use the textfield appearance for search fields in themeWin.css so the border/background
styling will work correctly on these fields.

  • css/themeWin.css:
10:45 AM Changeset in webkit [40296] by mitz@apple.com
  • 2 edits in trunk/WebCore
  • build fix
  • bindings/js/JSHTMLInputElementCustom.cpp: (WebCore::JSHTMLInputElement::setSelectionStart): (WebCore::JSHTMLInputElement::setSelectionEnd): (WebCore::JSHTMLInputElement::setSelectionRange):
10:26 AM Changeset in webkit [40295] by mitz@apple.com
  • 2 edits in trunk/WebCore
  • build fix
  • platform/graphics/Gradient.cpp: (WebCore::Gradient::setSpreadMethod):
9:30 AM Changeset in webkit [40294] by Dimitri Glazkov
  • 4 edits in trunk/WebCore

2009-01-27 Paul Godavari <​paul@chromium.org>

Reviewed by Eric Seidel.

​https://bugs.webkit.org/show_bug.cgi?id=23561
Explicitly send the MIME type from an image dragged from a web
page to the desktop, to Chromium so that it can properly generate
a file name.

  • platform/chromium/ChromiumDataObject.cpp: (WebCore::ChromiumDataObject::clear): (WebCore::ChromiumDataObject::hasData):
  • platform/chromium/ChromiumDataObject.h:
  • platform/chromium/ClipboardChromium.cpp: (WebCore::writeImageToDataObject):
9:24 AM Changeset in webkit [40293] by Dimitri Glazkov
  • 6 edits in trunk

WebCore:

2009-01-27 Mads Ager <​ager@chromium.org>

Reviewed by Darin Adler.

​https://bugs.webkit.org/show_bug.cgi?id=23300
Follow Firefox in throwing exceptions when using selection
functions on HTMLInputElements that cannot have selection.

This requires custom setSelectionRange, setSelectionStart and
setSelectionEnd implementations, but it gets rid of the custom
getOwnPropertySlot.

  • bindings/js/JSHTMLInputElementCustom.cpp: (WebCore::JSHTMLInputElement::selectionStart): (WebCore::JSHTMLInputElement::selectionEnd): (WebCore::JSHTMLInputElement::setSelectionRange):
  • html/HTMLInputElement.idl:

LayoutTests:

2009-01-27 Mads Ager <​ager@chromium.org>

Reviewed by Darin Adler.

​https://bugs.webkit.org/show_bug.cgi?id=23300
Update test of selection functions on HTMLInputElements to expect
the selection functions to throw exceptions when used on buttons.
This is consistent with the Firefox behavior.

  • fast/forms/selection-functions-expected.txt:
  • fast/forms/selection-functions.html:
9:13 AM Changeset in webkit [40292] by Dimitri Glazkov
  • 16 edits in trunk/WebCore

2009-01-27 Evan Stade <​estade@chromium.org>

Reviewed by Nikolas Zimmermann.

​https://bugs.webkit.org/show_bug.cgi?id=23435
Make spreadMethod a member of Gradient rather than GraphicsContext.
Implement spreadMethod for Skia.

  • platform/graphics/Gradient.cpp: (WebCore::Gradient::Gradient):
  • platform/graphics/Gradient.h: (WebCore::Gradient::setSpreadMethod): (WebCore::Gradient::spreadMethod):
  • platform/graphics/GraphicsContext.cpp:
  • platform/graphics/GraphicsContext.h:
  • platform/graphics/GraphicsContextPrivate.h:
  • platform/graphics/GraphicsTypes.h: (WebCore::):
  • platform/graphics/cairo/GradientCairo.cpp: (WebCore::Gradient::platformGradient):
  • platform/graphics/cairo/GraphicsContextCairo.cpp: (WebCore::GraphicsContext::fillPath): (WebCore::GraphicsContext::strokePath):
  • platform/graphics/qt/GradientQt.cpp: (WebCore::Gradient::platformGradient):
  • platform/graphics/qt/GraphicsContextQt.cpp: (WebCore::GraphicsContext::fillPath): (WebCore::GraphicsContext::strokePath):
  • platform/graphics/skia/GradientSkia.cpp: (WebCore::Gradient::platformGradient):
  • svg/SVGLinearGradientElement.cpp: (WebCore::SVGLinearGradientElement::buildGradient):
  • svg/SVGRadialGradientElement.cpp: (WebCore::SVGRadialGradientElement::buildGradient):
  • svg/graphics/SVGPaintServerGradient.cpp: (WebCore::SVGPaintServerGradient::SVGPaintServerGradient): (WebCore::SVGPaintServerGradient::setup): (WebCore::SVGPaintServerGradient::externalRepresentation):
  • svg/graphics/SVGPaintServerGradient.h:
8:03 AM Changeset in webkit [40291] by ariya@webkit.org
  • 2 edits in trunk/WebCore

2009-01-27 Ariya Hidayat <​ariya.hidayat@trolltech.com>

Rubber-stamped by Simon Hausmann.

​http://www.qtsoftware.com/developer/task-tracker/index_html?id=238662&method=entry

[Qt] Map function keys F1 to F24.

  • platform/qt/PlatformKeyboardEventQt.cpp: (WebCore::windowsKeyCodeForKeyEvent):
7:26 AM Changeset in webkit [40290] by ariya@webkit.org
  • 2 edits in trunk/WebKit/qt

2009-01-27 Ariya Hidayat <​ariya.hidayat@trolltech.com>

Reviewed by Simon Hausmann.

​http://www.qtsoftware.com/developer/task-tracker/index_html?id=238391&method=entry

[Qt] If QPainter fails to start on a QPrinter instance, do not
continue printing.

  • Api/qwebframe.cpp: (QWebFrame::print):
12:05 AM Changeset in webkit [40289] by beidson@apple.com
  • 26 edits in trunk

WebCore:

2009-01-27 Brady Eidson <​beidson@apple.com>

Reviewed by Dan Bernstein

Rework FrameLoaderClient to work on a CachedFrame basis instead of CachedPage

  • WebCore.base.exp:
  • history/CachedPage.cpp:
  • history/CachedPage.h: (WebCore::CachedPage::cachedMainFrame):
  • loader/EmptyClients.h: (WebCore::EmptyFrameLoaderClient::savePlatformDataToCachedFrame): (WebCore::EmptyFrameLoaderClient::transitionToCommittedFromCachedFrame):
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::restoreDocumentState): (WebCore::FrameLoader::commitProvisionalLoad): (WebCore::FrameLoader::transitionToCommitted): (WebCore::FrameLoader::cachePageForHistoryItem):
  • loader/FrameLoaderClient.h:

WebKit/gtk:

2009-01-27 Brady Eidson <​beidson@apple.com>

Reviewed by Dan Bernstein

Rework FrameLoaderClient to work on a CachedFrame basis instead of CachedPage

  • WebCoreSupport/FrameLoaderClientGtk.cpp: (WebKit::FrameLoaderClient::savePlatformDataToCachedFrame): (WebKit::FrameLoaderClient::transitionToCommittedFromCachedFrame):
  • WebCoreSupport/FrameLoaderClientGtk.h:

WebKit/mac:

2009-01-27 Brady Eidson <​beidson@apple.com>

Reviewed by Dan Bernstein

Rework FrameLoaderClient to work on a CachedFrame basis instead of CachedPage

  • History/WebHistoryItem.mm:
  • WebCoreSupport/WebFrameLoaderClient.h:
  • WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::savePlatformDataToCachedFrame): (WebFrameLoaderClient::transitionToCommittedFromCachedFrame):
  • WebKit.order:

WebKit/qt:

2009-01-27 Brady Eidson <​beidson@apple.com>

Reviewed by Dan Bernstein

Rework FrameLoaderClient to work on a CachedFrame basis instead of CachedPage

  • WebCoreSupport/FrameLoaderClientQt.cpp: (WebCore::FrameLoaderClientQt::savePlatformDataToCachedFrame): (WebCore::FrameLoaderClientQt::transitionToCommittedFromCachedFrame):
  • WebCoreSupport/FrameLoaderClientQt.h:

WebKit/win:

2009-01-27 Brady Eidson <​beidson@apple.com>

Reviewed by Dan Bernstein

Rework FrameLoaderClient to work on a CachedFrame basis instead of CachedPage

  • WebCoreSupport/WebFrameLoaderClient.cpp: (WebFrameLoaderClient::savePlatformDataToCachedFrame): (WebFrameLoaderClient::transitionToCommittedFromCachedFrame):
  • WebCoreSupport/WebFrameLoaderClient.h:
  • WebFrame.cpp:
  • WebFrame.h:

WebKit/wx:

2009-01-27 Brady Eidson <​beidson@apple.com>

Reviewed by Dan Bernstein

Rework FrameLoaderClient to work on a CachedFrame basis instead of CachedPage

  • WebKitSupport/FrameLoaderClientWx.cpp: (WebCore::FrameLoaderClientWx::savePlatformDataToCachedFrame): (WebCore::FrameLoaderClientWx::transitionToCommittedFromCachedFrame):
  • WebKitSupport/FrameLoaderClientWx.h:
Note: See TracTimeline for information about the timeline view.