Context Navigation

← Previous Period
Next Period →

Timeline

Jan 31, 2009:

10:23 PM Changeset in webkit [40471] by mitz@apple.com

3 edits in trunk/WebCore

Reviewed by Oliver Hunt.

fix <rdar://problem/6546549> Eliminate some RenderText::width() overhead from findNextLineBreak()

On the PLT, this results in 0.36x the number of virtual function calls
to RenderText::width() and 0.69x the number of calls to
Font::isFixedPitch(), but makes 1.0004x the number of calls to
Font::width().

rendering/RenderText.cpp: (WebCore::RenderText::width): Replaced bounds checks on 'from' and 'len' with an assertion.
rendering/bidi.cpp: (WebCore::textWidth): Added this inlined helper function which calls Font::width() directly in the non-fixed-pitch, non-full-range case, and otherwise calls RenderText::width(). (WebCore::RenderBlock::findNextLineBreak): Cache whether the font has fixed pitch (in which case RenderText::width() will be called in order to take advantage of the widthFromCache() optimization for fixed-pitch fonts). Replaced all calls to RenderText::width() with calls to the textWidth() helper function.

9:07 PM Changeset in webkit [40470] by pewtermoose@webkit.org

4 edits in trunk/WebKit/win

2009-01-31 Matt Lilek <webkit@mattlilek.com>

Not reviewed, build fixes.

WebCoreSupport/WebContextMenuClient.cpp: (WebContextMenuClient::searchWithGoogle):
WebFrame.cpp: (WebFrame::setInPrintingMode): (WebFrame::isFrameSet):
WebView.cpp: (WebView::notifyPreferencesChanged):

5:30 PM Changeset in webkit [40469] by hyatt@apple.com

3 edits in trunk/WebCore

2009-01-31 David Hyatt <hyatt@apple.com>

Inline all of the setNeedsLayout method and its associated functions. Also inline setChildNeedsLayout
and setNeedsPositionedMovementLayout.

Reviewed by Dan Bernstein

rendering/RenderObject.cpp: (WebCore::RenderObject::setLayerNeedsFullRepaint):
rendering/RenderObject.h: (WebCore::RenderObject::setNeedsLayout): (WebCore::RenderObject::setChildNeedsLayout): (WebCore::RenderObject::setNeedsPositionedMovementLayout): (WebCore::objectIsRelayoutBoundary): (WebCore::RenderObject::markContainingBlocksForLayout):

4:59 PM Changeset in webkit [40468] by sullivan@apple.com

2 edits in trunk/WebKit/mac

2009-01-31 John Sullivan <sullivan@apple.com>

https://bugs.webkit.org/show_bug.cgi?id=23665

Cleaned up code to add/remove NSNotification observers, to avoid performance hit
of calling removeObserver with unspecified notifications, or calling removeObserver
multiple times for the same notification.

Reviewed by Darin Adler

WebView/WebHTMLView.mm: added observingMouseMovedNotifications, observingSuperviewNotifications, and observingWindowNotifications as BOOL ivars of _private object (-[WebHTMLView _removeMouseMovedObserverUnconditionally]): moved to file-internal section of file, added leading underscore, now bails out if we aren't observing the relevant notifications, now records that we are no longer observing the relevant notifications (-[WebHTMLView _removeSuperviewObservers]): ditto, also stores [NSNoticationCenter defaultCenter] in local var to avoid objc dispatch (-[WebHTMLView _removeWindowObservers]): ditto (-[WebHTMLView close]): replace general removeObserver: call with three specific calls for all the notifications that this class actually observes (-[WebHTMLView addMouseMovedObserver]): bail out if already observing relevant notifications, now records that we are observing the relevant notifications (-[WebHTMLView removeMouseMovedObserver]): updated for name change (-[WebHTMLView addSuperviewObservers]): bail out if already observing relevant notifications, now records that we are observing the relevant notifications; also stores [NSNoticationCenter defaultCenter] in local var to avoid objc dispatch (-[WebHTMLView addWindowObservers]): ditto (-[WebHTMLView viewWillMoveToSuperview:]): updated for name change (-[WebHTMLView viewWillMoveToWindow:]): updated for name changes

4:55 PM Changeset in webkit [40467] by Darin Adler

3 edits in trunk/WebCore

2009-01-31 Darin Adler <Darin Adler>

Fix Mac build.

loader/FrameLoader.cpp: Moved FrameLoaderClient::hasHTMLView in here. We need it to not be an inline. Sadly, FrameLoaderClient.cpp was prematurely deleted and I don't want to bring it back just to fix the build.

loader/FrameLoaderClient.h: Rearrange virtual functions and corrected a possibly-confusing comment.

4:52 PM Changeset in webkit [40466] by hyatt@apple.com

1 edit in trunk/WebCore/WebCore.vcproj/WebCore.vcproj

Fix WIndows bustage.

4:14 PM Changeset in webkit [40465] by Darin Adler

2 edits in trunk/WebKit/mac

2009-01-31 Darin Adler <Darin Adler>

Reviewed by Mark Rowe.

Fix code that assumes all command selectors end in colons.
rdar://problem/6545874

WebView/WebHTMLView.mm: (commandNameForSelector): Don't assert, just return a null string, when the selector doesn't end in a colon.

3:55 PM Changeset in webkit [40464] by treat@webkit.org

3 edits in trunk/WebCore

2009-01-31 Adam Treat <adam.treat@torchmobile.com>

Reviewed by David Hyatt.

https://bugs.webkit.org/show_bug.cgi?id=23664
Remove unused dead code from RenderTable class. The dead code includes
two enums and the associated member variables as well as one getter function.

rendering/RenderTable.cpp: (WebCore::RenderTable::RenderTable):
rendering/RenderTable.h:

2:03 PM Changeset in webkit [40463] by hyatt@apple.com

1 edit in trunk/LayoutTests/platform/mac/fast/invalid/table-residual-style-crash-expected.txt

Update layout test results for 11363.

1:40 PM Changeset in webkit [40462] by hyatt@apple.com

4 edits in trunk/WebCore

Add RenderObjectChildList.cpp to all projects.

1:38 PM Changeset in webkit [40461] by hyatt@apple.com

18 edits
1 add in trunk/WebCore

2009-01-31 David Hyatt <hyatt@apple.com>

More removal of code from RenderContainer. Move removeLeftoverAnonymousBlock down into RenderBlock.
Move destroyLeftoverChildren into the RenderObjectChildList. Convert all containers to use the
RenderObjectChildList.

Reviewed by Sam Weinig

WebCore.xcodeproj/project.pbxproj:
rendering/RenderBlock.cpp: (WebCore::RenderBlock::destroy): (WebCore::RenderBlock::addChild): (WebCore::RenderBlock::removeLeftoverAnonymousBlock): (WebCore::RenderBlock::layoutPositionedObjects): (WebCore::RenderBlock::childBecameNonInline):
rendering/RenderBlock.h:
rendering/RenderBox.cpp: (WebCore::RenderBox::layout):
rendering/RenderBox.h: (WebCore::RenderBox::firstChildBox): (WebCore::RenderBox::lastChildBox):
rendering/RenderContainer.cpp: (WebCore::RenderContainer::addChild): (WebCore::RenderContainer::removeChildNode): (WebCore::RenderContainer::updateBeforeAfterContentForContainer): (WebCore::RenderContainer::appendChildNode): (WebCore::RenderContainer::insertChildNode): (WebCore::RenderContainer::positionForCoordinates): (WebCore::RenderContainer::addLineBoxRects): (WebCore::RenderContainer::collectAbsoluteLineBoxQuads):
rendering/RenderContainer.h: (WebCore::RenderContainer::virtualChildren): (WebCore::RenderContainer::children):
rendering/RenderInline.cpp: (WebCore::RenderInline::destroy):
rendering/RenderInline.h: (WebCore::RenderInline::layout):
rendering/RenderMedia.cpp: (WebCore::RenderMedia::destroy): (WebCore::RenderMedia::children):
rendering/RenderMedia.h: (WebCore::RenderMedia::virtualChildren):
rendering/RenderObject.cpp: (WebCore::RenderObject::destroy): (WebCore::RenderObject::layout):
rendering/RenderObject.h: (WebCore::RenderObject::firstChild): (WebCore::RenderObject::lastChild): (WebCore::RenderObject::virtualChildren): (WebCore::RenderObject::canHaveChildren):
rendering/RenderObjectChildList.cpp: Added. (WebCore::RenderObjectChildList::destroyLeftoverChildren):
rendering/RenderObjectChildList.h:
rendering/RenderReplaced.h: (WebCore::RenderReplaced::canHaveChildren):
rendering/RenderSVGContainer.cpp: (WebCore::RenderSVGContainer::RenderSVGContainer): (WebCore::RenderSVGContainer::destroy): (WebCore::RenderSVGContainer::removeChildNode): (WebCore::RenderSVGContainer::appendChildNode): (WebCore::RenderSVGContainer::insertChildNode):
rendering/RenderSVGContainer.h: (WebCore::RenderSVGContainer::virtualChildren): (WebCore::RenderSVGContainer::children):

1:34 PM Changeset in webkit [40460] by hyatt@apple.com

1 edit in trunk/LayoutTests/platform/mac/tables/mozilla_expected_failures/other/test4-expected.txt

Update layout test results for 11363.

1:34 PM Changeset in webkit [40459] by hyatt@apple.com

1 edit in trunk/LayoutTests/platform/mac/tables/mozilla_expected_failures/bugs/bug1725-expected.txt

Update layout test results for 11363.

1:30 PM Changeset in webkit [40458] by hyatt@apple.com

2 edits in trunk/LayoutTests/platform/mac/tables/mozilla/bugs

Update layout test results for 11363.

1:28 PM Changeset in webkit [40457] by hyatt@apple.com

2 edits in trunk/LayoutTests/platform/mac/fast/table

Update layout test results for 11363.

1:28 PM Changeset in webkit [40456] by hyatt@apple.com

2 edits in trunk/LayoutTests/platform/mac/fast/table

Update layout test results for 11363.

1:26 PM Changeset in webkit [40455] by hyatt@apple.com

1 edit in trunk/LayoutTests/editing/deleting/5408255.html

Update layout test results for 11363.

1:23 PM Changeset in webkit [40454] by hyatt@apple.com

1 edit in trunk/LayoutTests/platform/mac/editing/deleting/deletionUI-single-instance-expected.txt

Update layout test results for 11363.

1:20 PM Changeset in webkit [40453] by hyatt@apple.com

5 edits in trunk/WebCore

2009-01-31 David Hyatt <hyatt@apple.com>

Fix for https://bugs.webkit.org/show_bug.cgi?id=11363

Remove the hacks in table code around the DeleteButtonController and fix tables so that positioned children don't get wrapped in anonymous objects.
With the removal of a non-positioned DeleteButtonController renderer, table layout can be tightened up to only lay out table sections. Table section
layout is tightened up to ignore non-table rows. When a table has multiple captions, only the real one will do a layout now. The other ones will
be properly ignored.

Reviewed by Oliver Hunt

editing/DeleteButtonController.cpp: (WebCore::DeleteButtonController::createDeletionUI):
rendering/RenderTable.cpp: (WebCore::RenderTable::addChild): (WebCore::RenderTable::layout):
rendering/RenderTableSection.cpp: (WebCore::RenderTableSection::layout):
rendering/RenderTableSection.h:

10:07 AM Changeset in webkit [40452] by treat@webkit.org

6 edits in trunk/WebCore

2009-01-31 Adam Treat <adam.treat@torchmobile.com>

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=23663
Add a void toRenderBox() method which catches unnecessary casts at compile
time and also fix the four cases where this was happening.

rendering/RenderBlock.cpp: (WebCore::RenderBlock::determineHorizontalPosition):
rendering/RenderBox.h:
rendering/RenderFlexibleBox.cpp: (WebCore::RenderFlexibleBox::layoutHorizontalBox):
rendering/RenderInline.cpp: (WebCore::RenderInline::updateHitTestResult):
rendering/RenderLayer.cpp: (WebCore::RenderLayer::updateLayerPosition):

8:02 AM Changeset in webkit [40451] by Darin Adler

2 edits in trunk/WebKit/wx

2009-01-31 Darin Adler <Darin Adler>

Build fix.

WebView.cpp: (wxWebView::OnSize): call sendResizeEvent on EventHandler.

1:36 AM Changeset in webkit [40450] by jmalonzo@webkit.org

4 edits
1 move
4 adds
1 delete in trunk

2009-01-30 Jan Michael Alonzo <jmalonzo@webkit.org>

Reviewed by Nikolas Zimmermann.

[Gtk] Refactor autoconf/configure.ac in preparation for jsc and webkit build splits
https://bugs.webkit.org/show_bug.cgi?id=22136

GNUmakefile.am:
acinclude.m4: Removed.
autogen.sh:
autotools/acinclude.m4: Added.
autotools/dolt.m4: Added.
autotools/symbols.filter: Renamed from symbols.filter.
autotools/webkit.m4: Added.
configure.ac:

12:42 AM Changeset in webkit [40449] by abarth@webkit.org

18 edits in trunk

WebCore:

2009-01-30 Adam Barth <abarth@webkit.org>

Reviewed by Sam Weinig.

Add a pref to disable web security.

WebCore.base.exp:
dom/Document.cpp: (WebCore::Document::initSecurityContext):
page/SecurityOrigin.cpp: (WebCore::SecurityOrigin::SecurityOrigin): (WebCore::SecurityOrigin::canAccess): (WebCore::SecurityOrigin::canRequest): (WebCore::SecurityOrigin::grantUniversalAccess):
page/SecurityOrigin.h:
page/Settings.cpp: (WebCore::Settings::Settings): (WebCore::Settings::setWebSecurityEnabled):
page/Settings.h: (WebCore::Settings::isWebSecurityEnabled):

WebKit/win:

2009-01-30 Adam Barth <abarth@webkit.org>

Reviewed by Sam Weinig.

Add a pref to disable web security.

Interfaces/IWebPreferencesPrivate.idl:
WebPreferenceKeysPrivate.h:
WebPreferences.cpp: (WebPreferences::initializeDefaultSettings): (WebPreferences::isWebSecurityEnabled): (WebPreferences::setWebSecurityEnabled):
WebPreferences.h:
WebView.cpp: (WebView::notifyPreferencesChanged):

WebKit/mac:

2009-01-30 Adam Barth <abarth@webkit.org>

Reviewed by Sam Weinig.

Add a pref to disable web security.

WebView/WebPreferenceKeysPrivate.h:
WebView/WebPreferencesPrivate.h:
WebView/WebPreferences.mm: (+[WebPreferences initialize]): (-[WebPreferences isWebSecurityEnabled]): (-[WebPreferences setWebSecurityEnabled:]):
WebView/WebView.mm: (-[WebView _preferencesChangedNotification:]):

Jan 30, 2009:

10:24 PM Changeset in webkit [40448] by mitz@apple.com

2 edits in trunk/WebKitLibraries

Reviewed by Timothy Hatcher.

<rdar://problem/6545912> expose the build number in autoversion.h

win/tools/scripts/auto-version.sh: Added a #define BUILD_NUMBER with the full build number.

9:12 PM Changeset in webkit [40447] by zecke@webkit.org

2 edits in trunk/WebCore

2009-01-30 Holger Hans Peter Freyther <zecke@selfish.org>

Build fix.

Move the inline virtual destructor after a non-inline virtual
function so that the symbol for the vtable is not marked as a
weakly exported symbol.

This trick was previously used at revision 36122 in JSObject.h

loader/FrameLoaderClient.h: (WebCore::FrameLoaderClient::~FrameLoaderClient):

8:43 PM Changeset in webkit [40446] by oliver@apple.com

3 edits in trunk/WebCore

Inline SimpleFontData::widthForGlyph for a minor page load improvement.

Reviewed by Stephanie Lewis

8:40 PM Changeset in webkit [40445] by zecke@webkit.org

3 edits in trunk/WebCore

Build fix for WX and maybe even Windows.

8:12 PM Changeset in webkit [40444] by zecke@webkit.org

9 edits in trunk

Move Frame::sendResizeEvent and Frame::sendScrollEvent to EventHandler

Carry out the move and catch up in two call sites.

7:51 PM Changeset in webkit [40443] by zecke@webkit.org

11 edits in trunk

Move Frame::isFrameSet to Document::isFrameSet

Changed the FrameLoader callsite. I assume that as this
point m_frame.document() might return a null pointer. Change
the condition to either not having a document or not having a
frame set. This should be semantically equivalent to the
old code.

Make Document::body() const to be able to call it from within
Document::isFrameSet. Leave the isHTMLDocument() check as this
is a stronger condition than simply having a HTMLElement in the
DOM.

7:51 PM Changeset in webkit [40442] by zecke@webkit.org

2 edits in trunk/WebCore

[GTK] Logic fixes and build fixes

https://bugs.webkit.org/show_bug.cgi?id=22022

Catch up with the internal GeoLocation API and fix the logic of
the previous version.

7:51 PM Changeset in webkit [40441] by zecke@webkit.org

6 edits in trunk

[GTK] Implement GeolocationService using the Geoclue library

https://bugs.webkit.org/show_bug.cgi?id=22022

Untested implementation of the GeolocationService using the geoclue
library. Velocity handling is completely missing and the accuracy
handling might be wrong.

7:48 PM Changeset in webkit [40440] by mrowe@apple.com

2 edits in trunk/WebCore

Build fix. Declare preferredSize as static.

platform/text/cf/StringImplCF.cpp:

(WebCore::StringWrapperCFAllocator::preferredSize):

7:11 PM Changeset in webkit [40439] by mrowe@apple.com

2 edits in trunk/JavaScriptCore

<rdar://problem/6391501> Enable the JIT on Mac OS X x86_64 as it passes all tests.

Rubber-stamped by Oliver Hunt.

wtf/Platform.h:

6:31 PM Changeset in webkit [40438] by Darin Adler

3 edits in trunk/WebCore

2009-01-30 Darin Adler <Darin Adler>

Reviewed by Mark Rowe.

Bug 23622: create CFString and NSString objects from WebCore::String without copying the characters
https://bugs.webkit.org/show_bug.cgi?id=23622

platform/text/cf/StringImplCF.cpp: (WebCore::StringWrapperCFAllocator::allocator): Added. Returns the allocator. (WebCore::StringWrapperCFAllocator::retain): Added. Callback for allocator. (WebCore::StringWrapperCFAllocator::release): Ditto. (WebCore::StringWrapperCFAllocator::copyDescription): Ditto. (WebCore::StringWrapperCFAllocator::allocate): Ditto. (WebCore::StringWrapperCFAllocator::reallocate): Ditto. (WebCore::StringWrapperCFAllocator::deallocate): Ditto. (WebCore::StringWrapperCFAllocator::preferredSize): Ditto. (WebCore::StringWrapperCFAllocator::create): Added. Creates the allocator, but returns 0 if garbage collection is enabled. (WebCore::StringImpl::createCFString): Use StringWrapperCFAllocator if possible.

platform/text/mac/StringImplMac.mm: (WebCore::StringImpl::operator NSString *): Use CFString and toll-free bridging, rather than using NSString directly. This lets NSString benefit from the above.

6:31 PM Changeset in webkit [40437] by Darin Adler

2 edits in trunk/WebCore

2009-01-30 Darin Adler <Darin Adler>

page/Frame.cpp: (WebCore::Frame::createView): Fix debug build by removing get() from assert.

6:13 PM Changeset in webkit [40436] by ggaren@apple.com

9 edits in trunk/WebKit

WebKit/gtk:

2009-01-30 Geoffrey Garen <ggaren@apple.com>

Build fix.

WebCoreSupport/FrameLoaderClientGtk.cpp: (WebKit::FrameLoaderClient::createFrame):

WebKit/mac:

2009-01-30 Geoffrey Garen <ggaren@apple.com>

Build fix.

WebView/WebFramePrivate.h:

WebKit/qt:

2009-01-30 Geoffrey Garen <ggaren@apple.com>

Build fix.

WebCoreSupport/FrameLoaderClientQt.cpp: (WebCore::FrameLoaderClientQt::createFrame):

WebKit/win:

2009-01-30 Geoffrey Garen <ggaren@apple.com>

Build fix.

Interfaces/IWebFramePrivate.idl:
WebCoreSupport/WebFrameLoaderClient.cpp: (WebFrameLoaderClient::loadURLIntoChild):

5:57 PM Changeset in webkit [40435] by zecke@webkit.org

14 edits
1 delete in trunk

Kill FrameLoaderClient.cpp, move the code over to Frame::createView

FrameLoaderClient is supposed to be an interface, move the
to be shared code to Frame which is a controller and is
allowed to create a FrameView.

5:47 PM Changeset in webkit [40434] by Simon Fraser

2 edits
4 adds in trunk/WebCore

2009-01-30 Simon Fraser <Simon Fraser>

Reviewed by Dave Hyatt

https://bugs.webkit.org/show_bug.cgi?id=23357

New files to support accelerated compositing at the RenderLayer
level.

WebCore.xcodeproj/project.pbxproj: New files added to project, and run through the sort script.

rendering/RenderLayerBacking.cpp: Added.
rendering/RenderLayerBacking.h: Added. New object to store compositing-related data for a single RenderLayer.

rendering/RenderLayerCompositor.cpp: Added.
rendering/RenderLayerCompositor.h: Added. Per-RenderView controller object for compositing hierarchy maintenance.

5:42 PM Changeset in webkit [40433] by Simon Fraser

2 edits
9 adds in trunk/WebCore

2009-01-30 Simon Fraser <Simon Fraser>

Reviewed by Dave Hyatt

https://bugs.webkit.org/show_bug.cgi?id=23356

Add new files related to accelerated compositing.

5:28 PM Changeset in webkit [40432] by ggaren@apple.com

16 edits in trunk

WebCore:

2009-01-30 Geoffrey Garen <ggaren@apple.com>

Reviewed by Sam Weinig.

Split "lockHistory" into "lockHistory" and "lockBackForwardList" in
preparation for setting them differently during a redirect.

WebCore.base.exp:
bindings/js/JSHTMLFormElementCustom.cpp: (WebCore::JSHTMLFormElement::submit):
bindings/js/JSLocationCustom.cpp: (WebCore::navigateIfAllowed): (WebCore::JSLocation::setHref): (WebCore::JSLocation::setProtocol): (WebCore::JSLocation::setHost): (WebCore::JSLocation::setHostname): (WebCore::JSLocation::setPort): (WebCore::JSLocation::setPathname): (WebCore::JSLocation::setSearch): (WebCore::JSLocation::setHash): (WebCore::JSLocation::replace): (WebCore::JSLocation::assign):
html/HTMLAnchorElement.cpp: (WebCore::HTMLAnchorElement::defaultEventHandler):
html/HTMLFormElement.cpp: (WebCore::HTMLFormElement::submit):
html/HTMLFormElement.h:
loader/FrameLoader.cpp: (WebCore::FormSubmission::FormSubmission): (WebCore::ScheduledRedirection::ScheduledRedirection): (WebCore::isBackForwardLoadType): (WebCore::FrameLoader::createWindow): (WebCore::FrameLoader::changeLocation): (WebCore::FrameLoader::urlSelected): (WebCore::FrameLoader::submitFormAgain): (WebCore::FrameLoader::submitForm): (WebCore::FrameLoader::restoreDocumentState): (WebCore::FrameLoader::scheduleHTTPRedirection): (WebCore::FrameLoader::scheduleLocationChange): (WebCore::FrameLoader::scheduleRefresh): (WebCore::FrameLoader::redirectionTimerFired): (WebCore::FrameLoader::loadURLIntoChildFrame): (WebCore::FrameLoader::startRedirectionTimer): (WebCore::FrameLoader::loadFrameRequestWithFormAndValues): (WebCore::FrameLoader::transitionToCommitted): (WebCore::FrameLoader::clientRedirected): (WebCore::FrameLoader::continueFragmentScrollAfterNavigationPolicy): (WebCore::FrameLoader::loadItem):
loader/FrameLoader.h:
loader/FrameLoaderTypes.h: (WebCore::):
page/ContextMenuController.cpp: (WebCore::ContextMenuController::contextMenuItemSelected):
svg/SVGAElement.cpp: (WebCore::SVGAElement::defaultEventHandler):

WebKit/mac:

2009-01-30 Geoffrey Garen <ggaren@apple.com>

Reviewed by Sam Weinig.

Split "lockHistory" into "lockHistory" and "lockBackForwardList" in
preparation for setting them differently during a redirect.

WebView/WebPDFView.mm: (-[WebPDFView PDFViewWillClickOnLink:withURL:]):

WebKit/qt:

2009-01-30 Geoffrey Garen <ggaren@apple.com>

Reviewed by Sam Weinig.

Split "lockHistory" into "lockHistory" and "lockBackForwardList" in
preparation for setting them differently during a redirect.

Api/qwebpage.cpp: (QWebPage::triggerAction):

4:42 PM Changeset in webkit [40431] by weinig@apple.com

3 edits
2 adds in trunk

WebCore:

2009-01-30 Sam Weinig <sam@webkit.org>

Reviewed by Dan Bernstein.

Fix for <rdar://problem/6545095>

ASSERTION FAILED: RenderBlock.h:519: !o

o->isRenderBlock()

Test: fast/block/float/crash-replaced-display-block.html

rendering/RenderBlock.cpp: (WebCore::RenderBlock::layoutBlockChildren): Move RenderBlock only code into isRenderBlock if-statement.

LayoutTests:

2009-01-30 Sam Weinig <sam@webkit.org>

Reviewed by Dan Bernstein.

Test for <rdar://problem/6545095>

ASSERTION FAILED: RenderBlock.h:519: !o

o->isRenderBlock()

fast/block/float/crash-replaced-display-block-expected.txt: Added.
fast/block/float/crash-replaced-display-block.html: Added.

3:46 PM Changeset in webkit [40430] by Chris Fleizach

6 edits in trunk

Bug 23656: AX hierarchy for iFrames is incorrect
https://bugs.webkit.org/show_bug.cgi?id=23656

The AX hierarchy when an iFrame was present was incorrect. A different scroll area was returned when going down compared to when going up.

3:43 PM Changeset in webkit [40429] by treat@webkit.org

2 edits in trunk/WebCore

2009-01-30 Adam Treat <adam.treat@torchmobile.com>

Fix Qt build to include new class IdentifierRep introduced in revision 40412.

WebCore.pro:

3:32 PM Changeset in webkit [40428] by andersca@apple.com

5 edits in trunk/WebKit/mac

2009-01-30 Anders Carlsson <andersca@apple.com>

Reviewed by Sam Weinig.

Fix <rdar://problem/6544048>

Have NetscapePluginInstanceProxy keep track of all the ProxyInstance objects associated.

When the plug-in instance is destroyed, invalidate all proxy instances.

Plugins/Hosted/NetscapePluginInstanceProxy.h:
Plugins/Hosted/NetscapePluginInstanceProxy.mm: (WebKit::NetscapePluginInstanceProxy::destroy): (WebKit::NetscapePluginInstanceProxy::addInstance): (WebKit::NetscapePluginInstanceProxy::removeInstance):
Plugins/Hosted/ProxyInstance.h:
Plugins/Hosted/ProxyInstance.mm: (WebKit::ProxyInstance::ProxyInstance): (WebKit::ProxyInstance::~ProxyInstance): (WebKit::ProxyInstance::invalidate):

3:16 PM Changeset in webkit [40427] by andersca@apple.com

3 edits in trunk/WebCore

2009-01-30 Anders Carlsson <andersca@apple.com>

Reviewed by Sam Weinig.

Make IdentifierRep.h a private header, and add symbols needed by WebKit to WebCore.LP64.exp.

WebCore.LP64.exp:
WebCore.xcodeproj/project.pbxproj:

3:13 PM Changeset in webkit [40426] by zecke@webkit.org

2 edits in trunk/WebCore

[Gtk+] Use AccessibilityObject::stringValue for the AtkObject name

https://bugs.webkit.org/show_bug.cgi?id=21546

The API documentation at http://library.gnome.org/devel/atk/stable/AtkText.html
states that: "AtkObjects whose text content is simple, unattributed, and very
brief may expose that content via atk_object_get_name instead"

As we are currently not able to always provide a AtkTextInterface
implementation this will make the whole content available to accerciser,
and other tools.

3:11 PM Changeset in webkit [40425] by weinig@apple.com

8 edits in trunk/WebCore

2009-01-30 Sam Weinig <sam@webkit.org>

Commit files I forgot to in the previous commit.

page/AccessibilityRenderObject.cpp: (WebCore::AccessibilityRenderObject::layoutCount):
page/Frame.cpp: (WebCore::Frame::contentRenderer): (WebCore::Frame::forceLayoutWithPageWidthRange):
page/FrameView.cpp: (WebCore::FrameView::layout):
rendering/RenderBlock.cpp: (WebCore::RenderBlock::nodeAtPoint):
rendering/RenderObject.cpp: (WebCore::RenderObject::repaintUsingContainer): (WebCore::RenderObject::repaint): (WebCore::RenderObject::repaintRectangle): (WebCore::RenderObject::view): (WebCore::RenderObject::scheduleRelayout): (WebCore::RenderObject::maximalOutlineSize):
rendering/SVGRenderSupport.cpp: (WebCore::clampImageBufferSizeToViewport):
svg/SVGLength.cpp: (WebCore::SVGLength::PercentageOfViewport):

3:09 PM Changeset in webkit [40424] by ggaren@apple.com

57 edits
6 adds in trunk

WebCore:

2009-01-30 Geoffrey Garen <ggaren@apple.com>

Reviewed by Darin Adler.

More scaffolding for redirect tracking. No behavior change yet.

bindings/js/JSHTMLFormElementCustom.cpp: (WebCore::JSHTMLFormElement::submit): Added scaffolding necessary for redirect checking in a form submission through JS. (Currently, we just specify "no redirect.")

bindings/js/ScriptController.h:
bindings/js/ScriptController.cpp: (WebCore::ScriptController::processingUserGesture): (WebCore::ScriptController::processingUserGestureEvent): (WebCore::ScriptController::isJavaScriptAnchorNavigation): Refactored user gesture check to make it more clear.

(WebCore::ScriptController::pageIsProcessingUserGesture): Added a helper
for checking if there's a user gesture in any frame on the page (a more
relaxed rule than our popup blocking rule, which requires the user
gesture to occur in the frame that's executing JavaScript.)

html/HTMLFormElement.h:
html/HTMLFormElement.cpp: (WebCore::HTMLFormElement::submit): Added scaffolding necessary for redirect checking in a form submission through the DOM. (Currently, we just specify "no redirect.")

html/HTMLFormElement.idl: Made submit custom so it can participate in redirect checking.

loader/FrameLoader.h:
loader/FrameLoader.cpp: (WebCore::FormSubmission::FormSubmission): Clarified some names, and added a "lockHistory" parameter to form submissions, to match other navigations.

(WebCore::FrameLoader::submitFormAgain):
(WebCore::FrameLoader::submitForm): Use the lockHistory parameter.

(WebCore::FrameLoader::userGestureHint): Refactored this function for
clarity, and added a FIXME for a change I was too scared to make myself.
(Really, we should just get rid of this function.)

(WebCore::FrameLoader::loadFrameRequestWithFormAndValues): Refactored
to pass a FrameLoadType to form posts, too, so they can participate in
redirect tracking.

(WebCore::FrameLoader::loadPostRequest):
(WebCore::FrameLoader::continueFragmentScrollAfterNavigationPolicy):
(WebCore::FrameLoader::loadItem): Use the lockHistory parameter.

LayoutTests:

2009-01-30 Geoffrey Garen <ggaren@apple.com>

Reviewed by Darin Adler.

More redirect layout test work.

Added tests (expected to fail) for form submission via JavaScript:

http/tests/history/redirect-js-form-submit-0-seconds-expected.txt: Added.
http/tests/history/redirect-js-form-submit-0-seconds.html: Added.
http/tests/history/redirect-js-form-submit-2-seconds-expected.txt: Added.
http/tests/history/redirect-js-form-submit-2-seconds.html: Added.
http/tests/history/redirect-js-form-submit-before-load-expected.txt: Added.
http/tests/history/redirect-js-form-submit-before-load.html: Added.

Updated these tests to dump their back/forward lists, to check for
back/forward regressions, and to use # instead of ? to communicate between
URLs, since, to my surprise, form submissions can't use query strings.

http/tests/history/redirect-200-refresh-0-seconds-expected.txt:
http/tests/history/redirect-200-refresh-0-seconds.pl:
http/tests/history/redirect-200-refresh-2-seconds-expected.txt:
http/tests/history/redirect-200-refresh-2-seconds.pl:
http/tests/history/redirect-301-expected.txt:
http/tests/history/redirect-301.pl:
http/tests/history/redirect-302-expected.txt:
http/tests/history/redirect-302.pl:
http/tests/history/redirect-303-expected.txt:
http/tests/history/redirect-303.pl:
http/tests/history/redirect-307-expected.txt:
http/tests/history/redirect-307.pl:
http/tests/history/redirect-js-document-location-0-seconds-expected.txt:
http/tests/history/redirect-js-document-location-0-seconds.html:
http/tests/history/redirect-js-document-location-2-seconds-expected.txt:
http/tests/history/redirect-js-document-location-2-seconds.html:
http/tests/history/redirect-js-document-location-before-load-expected.txt:
http/tests/history/redirect-js-document-location-before-load.html:
http/tests/history/redirect-js-location-0-seconds-expected.txt:
http/tests/history/redirect-js-location-0-seconds.html:
http/tests/history/redirect-js-location-2-seconds-expected.txt:
http/tests/history/redirect-js-location-2-seconds.html:
http/tests/history/redirect-js-location-assign-0-seconds-expected.txt:
http/tests/history/redirect-js-location-assign-0-seconds.html:
http/tests/history/redirect-js-location-assign-2-seconds-expected.txt:
http/tests/history/redirect-js-location-assign-2-seconds.html:
http/tests/history/redirect-js-location-assign-before-load-expected.txt:
http/tests/history/redirect-js-location-assign-before-load.html:
http/tests/history/redirect-js-location-before-load-expected.txt:
http/tests/history/redirect-js-location-before-load.html:
http/tests/history/redirect-js-location-href-0-seconds-expected.txt:
http/tests/history/redirect-js-location-href-0-seconds.html:
http/tests/history/redirect-js-location-href-2-seconds-expected.txt:
http/tests/history/redirect-js-location-href-2-seconds.html:
http/tests/history/redirect-js-location-href-before-load-expected.txt:
http/tests/history/redirect-js-location-href-before-load.html:
http/tests/history/redirect-js-location-replace-0-seconds-expected.txt:
http/tests/history/redirect-js-location-replace-0-seconds.html:
http/tests/history/redirect-js-location-replace-2-seconds-expected.txt:
http/tests/history/redirect-js-location-replace-2-seconds.html:
http/tests/history/redirect-js-location-replace-before-load-expected.txt:
http/tests/history/redirect-js-location-replace-before-load.html:
http/tests/history/redirect-meta-refresh-0-seconds-expected.txt:
http/tests/history/redirect-meta-refresh-0-seconds.html:
http/tests/history/redirect-meta-refresh-2-seconds-expected.txt:
http/tests/history/redirect-meta-refresh-2-seconds.html:
http/tests/history/resources/redirect-target.html:

3:00 PM Changeset in webkit [40423] by pol@apple.com

1 edit
13 adds in trunk/LayoutTests

2009-01-30 Pierre-Olivier Latour <pol@apple.com>

Updated the references images for the media layout tests on Tiger since they now differ from Leopard after installing QuickTime 7.6.

platform/mac-tiger/media: Added.
platform/mac-tiger/media/video-aspect-ratio-expected.checksum: Added.
platform/mac-tiger/media/video-aspect-ratio-expected.png: Added.
platform/mac-tiger/media/video-controls-rendering-expected.checksum: Added.
platform/mac-tiger/media/video-controls-rendering-expected.png: Added.
platform/mac-tiger/media/video-display-toggle-expected.checksum: Added.
platform/mac-tiger/media/video-display-toggle-expected.png: Added.
platform/mac-tiger/media/video-layer-crash-expected.checksum: Added.
platform/mac-tiger/media/video-layer-crash-expected.png: Added.
platform/mac-tiger/media/video-transformed-expected.checksum: Added.
platform/mac-tiger/media/video-transformed-expected.png: Added.
platform/mac-tiger/media/video-zoom-expected.checksum: Added.
platform/mac-tiger/media/video-zoom-expected.png: Added.

2:57 PM Changeset in webkit [40422] by andersca@apple.com

2 edits in trunk/WebKit/mac

2009-01-30 Anders Carlsson <andersca@apple.com>

Reviewed by Sam Weinig.

Fix <rdar://problem/6490778>.

Change the NPRuntime related functions to use IdentifierRep directly, and make sure to always
validate IdentifierReps before dereferencing them.

Plugins/Hosted/NetscapePluginHostProxy.mm: (WKPCEvaluate): (WKPCGetStringIdentifier): (WKPCGetIntIdentifier): (identifierFromIdentifierRep): (WKPCInvoke): (WKPCGetProperty): (WKPCSetProperty): (WKPCRemoveProperty): (WKPCHasProperty): (WKPCHasMethod): (WKPCIdentifierInfo):

2:42 PM Changeset in webkit [40421] by Dimitri Glazkov

1 edit
1 delete in trunk/LayoutTests

2009-01-30 Dimitri Glazkov <Dimitri Glazkov>

Reviewed by Eric Seidel.

Correct mis-applied http://trac.webkit.org/changeset/40413 by actually
removing the test file.

fast/dom/Window/timeout-released-on-close.html: Removed.

2:19 PM Changeset in webkit [40420] by zecke@webkit.org

2 edits in trunk/WebCore

Build fix for Gtk+

2:16 PM Changeset in webkit [40419] by oliver@apple.com

2 edits in trunk/JavaScriptCore

Finally fix load() to propagate exceptions correctly.

Reviewed by Mark Rowe and Sam Weinig.

2:02 PM Changeset in webkit [40418] by Dimitri Glazkov

2 edits in trunk/JavaScriptCore

2009-01-30 David Levin <levin@chromium.org>

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=23618
Templated worker tasks should be more error proof to use.
Fix Chromium build.

wtf/TypeTraits.h: (WTF::IsConvertibleToInteger::IsConvertibleToDouble): Avoid "possible loss of data" warning when using Microsoft's C++ compiler by avoiding an implicit conversion of int types to doubles.

1:57 PM Changeset in webkit [40417] by weinig@apple.com

6 edits in trunk/WebCore

2009-01-30 Sam Weinig <sam@webkit.org>

Reviewed by Dan Bernstein.

Add toRenderView methods for casting RenderObjects to RenderViews. The methods will assert if the object
is not a RenderView.

dom/Document.cpp: (WebCore::Document::renderView):
editing/SelectionController.cpp: (WebCore::SelectionController::nodeWillBeRemoved): (WebCore::SelectionController::recomputeCaretRect): (WebCore::SelectionController::invalidateCaretRect): (WebCore::SelectionController::focusedOrActiveStateChanged):
editing/mac/SelectionControllerMac.mm: (WebCore::SelectionController::notifyAccessibilityForSelectionChange):
rendering/RenderBox.cpp: (WebCore::RenderBox::styleDidChange): (WebCore::RenderBox::repaintLayerRectsForImage): (WebCore::RenderBox::availableHeightUsing):
rendering/RenderView.h: (WebCore::toRenderView):

1:48 PM Changeset in webkit [40416] by Simon Fraser

2 edits in trunk/WebCore

2009-01-30 Simon Fraser <Simon Fraser>

Reviewed by Dave Hyatt

https://bugs.webkit.org/show_bug.cgi?id=23360

Really use the container-relative repaint rect methods
for repaint during layout

rendering/RenderObject.h: (WebCore::RenderObject::LayoutRepainter::LayoutRepainter):

1:47 PM Changeset in webkit [40415] by andersca@apple.com

6 edits in trunk/WebCore

2009-01-30 Anders Carlsson <andersca@apple.com>

Reviewed by Darin Adler.

Get rid of PrivateIdentifier and use IdentifierRep instead.

bridge/NP_jsobject.cpp: (_NPN_Invoke): (_NPN_GetProperty): (_NPN_SetProperty): (_NPN_RemoveProperty): (_NPN_HasProperty): (_NPN_HasMethod):
bridge/c/c_instance.cpp: (JSC::Bindings::CInstance::getPropertyNames):
bridge/c/c_utility.cpp: (JSC::Bindings::convertNPStringToUTF16):
bridge/c/c_utility.h:
bridge/npruntime.cpp: (_NPN_GetStringIdentifier): (_NPN_GetStringIdentifiers): (_NPN_GetIntIdentifier): (_NPN_IdentifierIsString): (_NPN_UTF8FromIdentifier): (_NPN_IntFromIdentifier):

1:25 PM Changeset in webkit [40414] by andersca@apple.com

3 edits in trunk/WebCore

2009-01-30 Anders Carlsson <andersca@apple.com>

Reviewed by Sam Weinig and Darin Adler.

Make IdentifierRep a real class, add necessary class methods.

bridge/IdentifierRep.cpp: (WebCore::identifierSet): Returns a set of all identifiers.

(WebCore::IdentifierRep::isValid):
Return whether an identifier is valid, meaning that it's present in the
set of identifiers.

bridge/IdentifierRep.h: (WebCore::IdentifierRep::isString): (WebCore::IdentifierRep::number): (WebCore::IdentifierRep::string): (WebCore::IdentifierRep::IdentifierRep): (WebCore::IdentifierRep::):

12:17 PM Changeset in webkit [40413] by treat@webkit.org

2 edits
1 copy in trunk/LayoutTests

2009-01-30 Dmitry Titov <dimich@chromium.org>

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=23650
LayoutTests/fast/dom/Window/timeout-released-on-close.html fails intermittently.
Disable this test to keep buildbots green. Need more time to investigate the cause.

fast/dom/Window/timeout-released-on-close.html: Removed.
fast/dom/Window/timeout-released-on-close.html-disabled: Copied from LayoutTests/fast/dom/Window/timeout-released-on-close.html.

11:57 AM Changeset in webkit [40412] by andersca@apple.com

7 edits
2 adds in trunk/WebCore

2009-01-30 Anders Carlsson <andersca@apple.com>

Reviewed by Sam Weinig.

Add IdentifierRep which will be used by both plug-in implementations.

GNUmakefile.am:
WebCore.vcproj/WebCore.vcproj:
WebCore.xcodeproj/project.pbxproj:
bridge/IdentifierRep.cpp: Added. (WebCore::IdentifierRep::IdentifierRep): (WebCore::IdentifierRep::): (WebCore::intIdentifierMap): (WebCore::identifierRep): (WebCore::stringIdentifierMap):
bridge/IdentifierRep.h: Added.
bridge/c/c_utility.h:
platform/text/PlatformString.h:
platform/text/String.cpp: (WebCore::String::fromUTF8WithLatin1Fallback):

11:55 AM Changeset in webkit [40411] by weinig@apple.com

13 edits in trunk/WebCore

2009-01-30 Sam Weinig <sam@webkit.org>

Reviewed by David Hyatt.

Add toRenderInline methods for casting RenderObjects to RenderInlines. The methods will assert if the object
is not a RenderInline.

rendering/InlineFlowBox.cpp: (WebCore::InlineFlowBox::removeLineBoxFromRenderObject): (WebCore::InlineFlowBox::extractLineBoxFromRenderObject): (WebCore::InlineFlowBox::attachLineBoxToRenderObject): (WebCore::InlineFlowBox::rendererLineBoxes): (WebCore::InlineFlowBox::determineSpacingForFlowBoxes): (WebCore::InlineFlowBox::paint):
rendering/LayoutState.cpp: (WebCore::LayoutState::LayoutState):
rendering/RenderBlock.cpp: (WebCore::RenderBlock::paintObject): (WebCore::RenderBlock::addFocusRingRects):
rendering/RenderBox.cpp: (WebCore::RenderBox::offsetFromContainer): (WebCore::RenderBox::computeRectForRepaint): (WebCore::RenderBox::containingBlockWidthForPositioned): (WebCore::RenderBox::containingBlockHeightForPositioned): (WebCore::RenderBox::calcAbsoluteHorizontalValues): (WebCore::RenderBox::calcAbsoluteHorizontalReplaced):
rendering/RenderContainer.cpp: (WebCore::RenderContainer::updateBeforeAfterContentForContainer):
rendering/RenderInline.cpp: (WebCore::RenderInline::inlineContinuation): (WebCore::nextContinuation): (WebCore::RenderInline::splitInlines):
rendering/RenderInline.h: (WebCore::toRenderInline):
rendering/RenderLayer.cpp: (WebCore::RenderLayer::updateLayerPosition): (WebCore::RenderLayer::boundingBox):
rendering/RenderLineBoxList.cpp: (WebCore::RenderLineBoxList::dirtyLinesFromChangedChild):
rendering/RenderText.h:
rendering/RenderTreeAsText.cpp: (WebCore::operator<<):
rendering/bidi.cpp: (WebCore::RenderBlock::createLineBoxes): (WebCore::RenderBlock::layoutInlineChildren):

10:20 AM Changeset in webkit [40410] by darin@chromium.org

2 edits in trunk/WebCore

2009-01-30 Darin Fisher <darin@chromium.org>

Reviewed by Eric Seidel.

https://bugs.webkit.org/show_bug.cgi?id=23647
Fix PLATFORM(SKIA)'s ImageSource::clear method to match other ports

platform/graphics/skia/ImageSourceSkia.cpp: (WebCore::ImageSource::clear):

10:16 AM Changeset in webkit [40409] by hyatt@apple.com

18 edits in trunk/WebCore

2009-01-30 David Hyatt <hyatt@apple.com>

Add toRenderBlock methods for casting RenderObjects to RenderBlocks. The methods will assert if the object
is not a RenderBlock. Also add a toRenderBlock method that takes a RenderBlock but returns void and that
is unimplemented. This method will catch anyone trying to do a cast when the object is already a RenderBlock.

Making this change caught a bad cast in RenderBlock::layoutBlockChildren, so that is also fixed by this
patch with a containsFloats() check.

Reviewed by Darin Adler

dom/PositionIterator.cpp: (WebCore::PositionIterator::isCandidate):
editing/CompositeEditCommand.cpp: (WebCore::CompositeEditCommand::addBlockPlaceholderIfNeeded):
editing/Editor.cpp: (WebCore::Editor::hasBidiSelection):
page/AccessibilityRenderObject.cpp: (WebCore::AccessibilityRenderObject::anchorElement): (WebCore::AccessibilityRenderObject::accessibilityIsIgnored):
rendering/RenderBlock.cpp: (WebCore::RenderBlock::styleWillChange): (WebCore::RenderBlock::removeChild): (WebCore::RenderBlock::layoutBlock): (WebCore::RenderBlock::collapseMargins): (WebCore::RenderBlock::clearFloatsIfNeeded): (WebCore::RenderBlock::layoutBlockChildren): (WebCore::RenderBlock::fillBlockSelectionGaps): (WebCore::RenderBlock::markAllDescendantsWithFloatsForLayout): (WebCore::RenderBlock::firstLineBlock): (WebCore::getLineAtIndex): (WebCore::getHeightForLineCount): (WebCore::RenderBlock::lineCount): (WebCore::RenderBlock::adjustForBorderFit): (WebCore::RenderBlock::clearTruncation):
rendering/RenderBlock.h: (WebCore::toRenderBlock):
rendering/RenderBox.cpp: (WebCore::RenderBox::offsetFromContainer): (WebCore::RenderBox::computeRectForRepaint): (WebCore::RenderBox::calcReplacedHeightUsing):
rendering/RenderFlexibleBox.cpp: (WebCore::RenderFlexibleBox::layoutHorizontalBox): (WebCore::RenderFlexibleBox::layoutVerticalBox):
rendering/RenderInline.cpp: (WebCore::RenderInline::inlineContinuation): (WebCore::nextContinuation): (WebCore::RenderInline::positionForCoordinates):
rendering/RenderLayer.cpp: (WebCore::RenderLayer::updateScrollInfoAfterLayout):
rendering/RenderListItem.cpp: (WebCore::getParentOfFirstLineBox): (WebCore::RenderListItem::positionListMarker):
rendering/RenderObject.cpp: (WebCore::RenderObject::containingBlock): (WebCore::RenderObject::computeRectForRepaint): (WebCore::RenderObject::removeFromObjectLists): (WebCore::RenderObject::getTextDecorationColors):
rendering/RenderTable.cpp: (WebCore::RenderTable::addChild): (WebCore::RenderTable::recalcSections):
rendering/RenderTextControl.cpp: (WebCore::RenderTextControl::styleDidChange):
rendering/RenderTextControlSingleLine.cpp: (WebCore::RenderTextControlSingleLine::adjustControlHeightBasedOnLineHeight):
rendering/RootInlineBox.cpp: (WebCore::RootInlineBox::block):
rendering/bidi.cpp: (WebCore::RenderBlock::createLineBoxes):

9:30 AM Changeset in webkit [40408] by beidson@apple.com

10 edits in trunk

WebCore:

2009-01-30 Brady Eidson <beidson@apple.com>

Reviewed by Sam Weinig

Let CachedFrame handle the suspending/resuming of active DOM objects itself instead of relying on some outside force.
Clear the previous history item inside FrameLoader instead of relying on multiple FrameLoaderClients to do it.

history/CachedFrame.cpp: (WebCore::CachedFrame::CachedFrame): Suspend active DOM objects here. (WebCore::CachedFrame::restore): Resume those DOM objects here.
history/CachedFrame.h: (WebCore::CachedFrame::domWindow):

loader/FrameLoader.cpp: (WebCore::FrameLoader::commitProvisionalLoad): Let CachedFrame creation handle the suspending of active DOM objects. (WebCore::FrameLoader::open): Let CachedFrame::restore() handle resuming those DOM objects. (WebCore::FrameLoader::checkLoadCompleteForThisFrame): Call frameLoadCompleted() instead of performing a client call by itself. (WebCore::FrameLoader::frameLoadCompleted):

WebKit/mac:

2009-01-30 Brady Eidson <beidson@apple.com>

Reviewed by Sam Weinig

Remove FrameLoaderClient code that is now handled by FrameLoader itself

WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::frameLoadCompleted):

WebKit/qt:

2009-01-30 Brady Eidson <beidson@apple.com>

Reviewed by Sam Weinig

Remove FrameLoaderClient code that is now handled by FrameLoader itself

WebCoreSupport/FrameLoaderClientQt.cpp: (WebCore::FrameLoaderClientQt::frameLoadCompleted):

WebKit/win:

2009-01-30 Brady Eidson <beidson@apple.com>

Reviewed by Sam Weinig

Remove FrameLoaderClient code that is now handled by FrameLoader itself

WebFrame.cpp: (WebFrame::frameLoadCompleted):

9:13 AM Changeset in webkit [40407] by ap@webkit.org

1 edit
3 adds in trunk/LayoutTests

Reviewed by Darin Adler.

Test that documents loaded from application cache cannot load local resources.

http/tests/appcache/local-content-expected.txt: Added.
http/tests/appcache/local-content.html: Added.
http/tests/appcache/resources/local-content.manifest: Added.

9:11 AM Changeset in webkit [40406] by ap@webkit.org

4 edits in trunk/WebCore

Reviewed by Darin Adler.

<rdar://problem/6448823> Application Cache is kept after a private browsing session

loader/appcache/ApplicationCacheGroup.cpp: (WebCore::ApplicationCacheGroup::selectCache): (WebCore::ApplicationCacheGroup::update): Cache update will not be started if private browsing is enabled. Existing cache version from disk database will be used.

loader/appcache/ApplicationCacheGroup.h: Made postListenerTask() static, in order to call it when refusing to update from selectCache().

loader/appcache/ApplicationCache.cpp: (WebCore::ApplicationCache::addDynamicEntry): (WebCore::ApplicationCache::removeDynamicEntry): Added reminders about private browsing to unimplemented methods.

9:06 AM Changeset in webkit [40405] by darin@chromium.org

3 edits in trunk/LayoutTests

2009-01-30 Dmitry Titov <dimich@chromium.org>

Reviewed by Alexey Proskuryakov.

https://bugs.webkit.org/show_bug.cgi?id=23615
Try to make this test reliable on buildbots.

fast/dom/Window/resources/long_timeout.html: Allocate more objects to make detection more reliable.

fast/dom/Window/timeout-released-on-close.html: Use threshold to account for objects allocated by the running scripts. Add debug output in case of failure to help understand possible failures.

7:17 AM Changeset in webkit [40404] by Simon Hausmann