⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Feb 1, 2009:

12:30 PM Changeset in webkit [40472] by mitz@apple.com
  • 5 edits in trunk/WebCore

Reviewed by John Sullivan.

  • fix <rdar://problem/6546625> REGRESSION (r40432): iframes added to global history at haaretz.co.il

Fixes http/tests/navigation/multiple-back-forward-entries.html

r40432 added a parameter to FrameLoader::scheduleLocationChange() and
failed to update all call sites.

  • bindings/js/JSDOMWindowBase.cpp: (WebCore::createWindow): Pass the lockBackForwardHistory parameter, giving it the same value as the lockHistory parameter. (windowProtoFuncOpen): Ditto.
  • bindings/js/JSDOMWindowCustom.cpp: (WebCore::JSDOMWindow::setLocation): Ditto.
  • bindings/js/JSDocumentCustom.cpp: (WebCore::JSDocument::setLocation): Ditto.
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::requestFrame): Ditto.

Jan 31, 2009:

10:23 PM Changeset in webkit [40471] by mitz@apple.com
  • 3 edits in trunk/WebCore

Reviewed by Oliver Hunt.

  • fix <rdar://problem/6546549> Eliminate some RenderText::width() overhead from findNextLineBreak()

On the PLT, this results in 0.36x the number of virtual function calls
to RenderText::width() and 0.69x the number of calls to
Font::isFixedPitch(), but makes 1.0004x the number of calls to
Font::width().

  • rendering/RenderText.cpp: (WebCore::RenderText::width): Replaced bounds checks on 'from' and 'len' with an assertion.
  • rendering/bidi.cpp: (WebCore::textWidth): Added this inlined helper function which calls Font::width() directly in the non-fixed-pitch, non-full-range case, and otherwise calls RenderText::width(). (WebCore::RenderBlock::findNextLineBreak): Cache whether the font has fixed pitch (in which case RenderText::width() will be called in order to take advantage of the widthFromCache() optimization for fixed-pitch fonts). Replaced all calls to RenderText::width() with calls to the textWidth() helper function.
9:07 PM Changeset in webkit [40470] by pewtermoose@webkit.org
  • 4 edits in trunk/WebKit/win

2009-01-31 Matt Lilek <​webkit@mattlilek.com>

Not reviewed, build fixes.

  • WebCoreSupport/WebContextMenuClient.cpp: (WebContextMenuClient::searchWithGoogle):
  • WebFrame.cpp: (WebFrame::setInPrintingMode): (WebFrame::isFrameSet):
  • WebView.cpp: (WebView::notifyPreferencesChanged):
5:30 PM Changeset in webkit [40469] by hyatt@apple.com
  • 3 edits in trunk/WebCore

2009-01-31 David Hyatt <​hyatt@apple.com>

Inline all of the setNeedsLayout method and its associated functions. Also inline setChildNeedsLayout
and setNeedsPositionedMovementLayout.

Reviewed by Dan Bernstein

  • rendering/RenderObject.cpp: (WebCore::RenderObject::setLayerNeedsFullRepaint):
  • rendering/RenderObject.h: (WebCore::RenderObject::setNeedsLayout): (WebCore::RenderObject::setChildNeedsLayout): (WebCore::RenderObject::setNeedsPositionedMovementLayout): (WebCore::objectIsRelayoutBoundary): (WebCore::RenderObject::markContainingBlocksForLayout):
4:59 PM Changeset in webkit [40468] by sullivan@apple.com
  • 2 edits in trunk/WebKit/mac

2009-01-31 John Sullivan <​sullivan@apple.com>

​https://bugs.webkit.org/show_bug.cgi?id=23665

Cleaned up code to add/remove NSNotification observers, to avoid performance hit
of calling removeObserver with unspecified notifications, or calling removeObserver
multiple times for the same notification.

Reviewed by Darin Adler

  • WebView/WebHTMLView.mm: added observingMouseMovedNotifications, observingSuperviewNotifications, and observingWindowNotifications as BOOL ivars of _private object (-[WebHTMLView _removeMouseMovedObserverUnconditionally]): moved to file-internal section of file, added leading underscore, now bails out if we aren't observing the relevant notifications, now records that we are no longer observing the relevant notifications (-[WebHTMLView _removeSuperviewObservers]): ditto, also stores [NSNoticationCenter defaultCenter] in local var to avoid objc dispatch (-[WebHTMLView _removeWindowObservers]): ditto (-[WebHTMLView close]): replace general removeObserver: call with three specific calls for all the notifications that this class actually observes (-[WebHTMLView addMouseMovedObserver]): bail out if already observing relevant notifications, now records that we are observing the relevant notifications (-[WebHTMLView removeMouseMovedObserver]): updated for name change (-[WebHTMLView addSuperviewObservers]): bail out if already observing relevant notifications, now records that we are observing the relevant notifications; also stores [NSNoticationCenter defaultCenter] in local var to avoid objc dispatch (-[WebHTMLView addWindowObservers]): ditto (-[WebHTMLView viewWillMoveToSuperview:]): updated for name change (-[WebHTMLView viewWillMoveToWindow:]): updated for name changes
4:55 PM Changeset in webkit [40467] by Darin Adler
  • 3 edits in trunk/WebCore

2009-01-31 Darin Adler <Darin Adler>

Fix Mac build.

  • loader/FrameLoader.cpp: Moved FrameLoaderClient::hasHTMLView in here. We need it to not be an inline. Sadly, FrameLoaderClient.cpp was prematurely deleted and I don't want to bring it back just to fix the build.
  • loader/FrameLoaderClient.h: Rearrange virtual functions and corrected a possibly-confusing comment.
4:52 PM Changeset in webkit [40466] by hyatt@apple.com
  • 1 edit in trunk/WebCore/WebCore.vcproj/WebCore.vcproj

Fix WIndows bustage.

4:14 PM Changeset in webkit [40465] by Darin Adler
  • 2 edits in trunk/WebKit/mac

2009-01-31 Darin Adler <Darin Adler>

Reviewed by Mark Rowe.

Fix code that assumes all command selectors end in colons.
rdar://problem/6545874

  • WebView/WebHTMLView.mm: (commandNameForSelector): Don't assert, just return a null string, when the selector doesn't end in a colon.
3:55 PM Changeset in webkit [40464] by treat@webkit.org
  • 3 edits in trunk/WebCore

2009-01-31 Adam Treat <​adam.treat@torchmobile.com>

Reviewed by David Hyatt.

​https://bugs.webkit.org/show_bug.cgi?id=23664
Remove unused dead code from RenderTable class. The dead code includes
two enums and the associated member variables as well as one getter function.

  • rendering/RenderTable.cpp: (WebCore::RenderTable::RenderTable):
  • rendering/RenderTable.h:
2:03 PM Changeset in webkit [40463] by hyatt@apple.com
  • 1 edit in trunk/LayoutTests/platform/mac/fast/invalid/table-residual-style-crash-expected.txt

Update layout test results for 11363.

1:40 PM Changeset in webkit [40462] by hyatt@apple.com
  • 4 edits in trunk/WebCore

Add RenderObjectChildList.cpp to all projects.

1:38 PM Changeset in webkit [40461] by hyatt@apple.com
  • 18 edits
    1 add in trunk/WebCore

2009-01-31 David Hyatt <​hyatt@apple.com>

More removal of code from RenderContainer. Move removeLeftoverAnonymousBlock down into RenderBlock.
Move destroyLeftoverChildren into the RenderObjectChildList. Convert all containers to use the
RenderObjectChildList.

Reviewed by Sam Weinig

  • WebCore.xcodeproj/project.pbxproj:
  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::destroy): (WebCore::RenderBlock::addChild): (WebCore::RenderBlock::removeLeftoverAnonymousBlock): (WebCore::RenderBlock::layoutPositionedObjects): (WebCore::RenderBlock::childBecameNonInline):
  • rendering/RenderBlock.h:
  • rendering/RenderBox.cpp: (WebCore::RenderBox::layout):
  • rendering/RenderBox.h: (WebCore::RenderBox::firstChildBox): (WebCore::RenderBox::lastChildBox):
  • rendering/RenderContainer.cpp: (WebCore::RenderContainer::addChild): (WebCore::RenderContainer::removeChildNode): (WebCore::RenderContainer::updateBeforeAfterContentForContainer): (WebCore::RenderContainer::appendChildNode): (WebCore::RenderContainer::insertChildNode): (WebCore::RenderContainer::positionForCoordinates): (WebCore::RenderContainer::addLineBoxRects): (WebCore::RenderContainer::collectAbsoluteLineBoxQuads):
  • rendering/RenderContainer.h: (WebCore::RenderContainer::virtualChildren): (WebCore::RenderContainer::children):
  • rendering/RenderInline.cpp: (WebCore::RenderInline::destroy):
  • rendering/RenderInline.h: (WebCore::RenderInline::layout):
  • rendering/RenderMedia.cpp: (WebCore::RenderMedia::destroy): (WebCore::RenderMedia::children):
  • rendering/RenderMedia.h: (WebCore::RenderMedia::virtualChildren):
  • rendering/RenderObject.cpp: (WebCore::RenderObject::destroy): (WebCore::RenderObject::layout):
  • rendering/RenderObject.h: (WebCore::RenderObject::firstChild): (WebCore::RenderObject::lastChild): (WebCore::RenderObject::virtualChildren): (WebCore::RenderObject::canHaveChildren):
  • rendering/RenderObjectChildList.cpp: Added. (WebCore::RenderObjectChildList::destroyLeftoverChildren):
  • rendering/RenderObjectChildList.h:
  • rendering/RenderReplaced.h: (WebCore::RenderReplaced::canHaveChildren):
  • rendering/RenderSVGContainer.cpp: (WebCore::RenderSVGContainer::RenderSVGContainer): (WebCore::RenderSVGContainer::destroy): (WebCore::RenderSVGContainer::removeChildNode): (WebCore::RenderSVGContainer::appendChildNode): (WebCore::RenderSVGContainer::insertChildNode):
  • rendering/RenderSVGContainer.h: (WebCore::RenderSVGContainer::virtualChildren): (WebCore::RenderSVGContainer::children):
1:34 PM Changeset in webkit [40460] by hyatt@apple.com
  • 1 edit in trunk/LayoutTests/platform/mac/tables/mozilla_expected_failures/other/test4-expected.txt

Update layout test results for 11363.

1:34 PM Changeset in webkit [40459] by hyatt@apple.com
  • 1 edit in trunk/LayoutTests/platform/mac/tables/mozilla_expected_failures/bugs/bug1725-expected.txt

Update layout test results for 11363.

1:30 PM Changeset in webkit [40458] by hyatt@apple.com
  • 2 edits in trunk/LayoutTests/platform/mac/tables/mozilla/bugs

Update layout test results for 11363.

1:28 PM Changeset in webkit [40457] by hyatt@apple.com
  • 2 edits in trunk/LayoutTests/platform/mac/fast/table

Update layout test results for 11363.

1:28 PM Changeset in webkit [40456] by hyatt@apple.com
  • 2 edits in trunk/LayoutTests/platform/mac/fast/table

Update layout test results for 11363.

1:26 PM Changeset in webkit [40455] by hyatt@apple.com
  • 1 edit in trunk/LayoutTests/editing/deleting/5408255.html

Update layout test results for 11363.

1:23 PM Changeset in webkit [40454] by hyatt@apple.com
  • 1 edit in trunk/LayoutTests/platform/mac/editing/deleting/deletionUI-single-instance-expected.txt

Update layout test results for 11363.

1:20 PM Changeset in webkit [40453] by hyatt@apple.com
  • 5 edits in trunk/WebCore

2009-01-31 David Hyatt <​hyatt@apple.com>

Fix for ​https://bugs.webkit.org/show_bug.cgi?id=11363


Remove the hacks in table code around the DeleteButtonController and fix tables so that positioned children don't get wrapped in anonymous objects.
With the removal of a non-positioned DeleteButtonController renderer, table layout can be tightened up to only lay out table sections. Table section
layout is tightened up to ignore non-table rows. When a table has multiple captions, only the real one will do a layout now. The other ones will
be properly ignored.

Reviewed by Oliver Hunt

  • editing/DeleteButtonController.cpp: (WebCore::DeleteButtonController::createDeletionUI):
  • rendering/RenderTable.cpp: (WebCore::RenderTable::addChild): (WebCore::RenderTable::layout):
  • rendering/RenderTableSection.cpp: (WebCore::RenderTableSection::layout):
  • rendering/RenderTableSection.h:
10:07 AM Changeset in webkit [40452] by treat@webkit.org
  • 6 edits in trunk/WebCore

2009-01-31 Adam Treat <​adam.treat@torchmobile.com>

Reviewed by Darin Adler.

​https://bugs.webkit.org/show_bug.cgi?id=23663
Add a void toRenderBox() method which catches unnecessary casts at compile
time and also fix the four cases where this was happening.

  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::determineHorizontalPosition):
  • rendering/RenderBox.h:
  • rendering/RenderFlexibleBox.cpp: (WebCore::RenderFlexibleBox::layoutHorizontalBox):
  • rendering/RenderInline.cpp: (WebCore::RenderInline::updateHitTestResult):
  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::updateLayerPosition):
8:02 AM Changeset in webkit [40451] by Darin Adler
  • 2 edits in trunk/WebKit/wx

2009-01-31 Darin Adler <Darin Adler>

Build fix.

  • WebView.cpp: (wxWebView::OnSize): call sendResizeEvent on EventHandler.
1:36 AM Changeset in webkit [40450] by jmalonzo@webkit.org
  • 4 edits
    1 move
    4 adds
    1 delete in trunk

2009-01-30 Jan Michael Alonzo <​jmalonzo@webkit.org>

Reviewed by Nikolas Zimmermann.

[Gtk] Refactor autoconf/configure.ac in preparation for jsc and webkit build splits
​https://bugs.webkit.org/show_bug.cgi?id=22136

  • GNUmakefile.am:
  • acinclude.m4: Removed.
  • autogen.sh:
  • autotools/acinclude.m4: Added.
  • autotools/dolt.m4: Added.
  • autotools/symbols.filter: Renamed from symbols.filter.
  • autotools/webkit.m4: Added.
  • configure.ac:
12:42 AM Changeset in webkit [40449] by abarth@webkit.org
  • 18 edits in trunk

WebCore:

2009-01-30 Adam Barth <​abarth@webkit.org>

Reviewed by Sam Weinig.

Add a pref to disable web security.

  • WebCore.base.exp:
  • dom/Document.cpp: (WebCore::Document::initSecurityContext):
  • page/SecurityOrigin.cpp: (WebCore::SecurityOrigin::SecurityOrigin): (WebCore::SecurityOrigin::canAccess): (WebCore::SecurityOrigin::canRequest): (WebCore::SecurityOrigin::grantUniversalAccess):
  • page/SecurityOrigin.h:
  • page/Settings.cpp: (WebCore::Settings::Settings): (WebCore::Settings::setWebSecurityEnabled):
  • page/Settings.h: (WebCore::Settings::isWebSecurityEnabled):

WebKit/win:

2009-01-30 Adam Barth <​abarth@webkit.org>

Reviewed by Sam Weinig.

Add a pref to disable web security.

  • Interfaces/IWebPreferencesPrivate.idl:
  • WebPreferenceKeysPrivate.h:
  • WebPreferences.cpp: (WebPreferences::initializeDefaultSettings): (WebPreferences::isWebSecurityEnabled): (WebPreferences::setWebSecurityEnabled):
  • WebPreferences.h:
  • WebView.cpp: (WebView::notifyPreferencesChanged):

WebKit/mac:

2009-01-30 Adam Barth <​abarth@webkit.org>

Reviewed by Sam Weinig.

Add a pref to disable web security.

  • WebView/WebPreferenceKeysPrivate.h:
  • WebView/WebPreferencesPrivate.h:
  • WebView/WebPreferences.mm: (+[WebPreferences initialize]): (-[WebPreferences isWebSecurityEnabled]): (-[WebPreferences setWebSecurityEnabled:]):
  • WebView/WebView.mm: (-[WebView _preferencesChangedNotification:]):
Note: See TracTimeline for information about the timeline view.