Context Navigation

WebCore.xcodeproj/project.pbxproj:
dom/Worker.cpp:
dom/Worker.h:
dom/WorkerContext.cpp: (WebCore::WorkerContext::addMessage): (WebCore::WorkerContext::postTask): (WebCore::WorkerContext::postTaskToWorkerObject):
dom/WorkerContext.h:
dom/WorkerMessagingProxy.cpp: (WebCore::MessageWorkerContextTask::performTask): (WebCore::WorkerMessagingProxy::postMessageToWorkerContext): (WebCore::WorkerMessagingProxy::postTaskToWorkerContext): Expose postTaskToWorkerContext for use by the worker object thread.

(WebCore::WorkerMessagingProxy::postTaskToWorkerObject):
Change the name of postTaskToParentContext to postTaskToWorkerObject for consistency
with postMessageToWorkerObject.

dom/WorkerMessagingProxy.h:
dom/WorkerRunLoop.cpp: (WebCore::WorkerRunLoop::run): (WebCore::WorkerRunLoop::postTask):
dom/WorkerRunLoop.h:
dom/WorkerTask.cpp: Removed.
dom/WorkerTask.h: Removed. Removed WorkerTask and replaced with the existing ScriptExecutionContext::Task.

The resulted in the class going away along with an adapter that made
a ScriptExecutionContext::Task look like a WorkerTask.

dom/WorkerThread.cpp:
dom/WorkerThread.h:

11:36 PM Changeset in webkit [40525] by ap@webkit.org

10 edits
2 adds in trunk/WebCore

2009-02-02 David Levin <levin@chromium.org>

Reviewed by Alexey Proskuryakov.

Bug 23618: Templated worker tasks should be more error proof to use.
<https://bugs.webkit.org/show_bug.cgi?id=23618>

Add the generic worker tasks templates needed for the WorkerThreadableLoader.

No observable change in behavior, so no test.

GNUmakefile.am:
WebCore.pro:
WebCore.scons:
WebCore.vcproj/WebCore.vcproj:
WebCore.xcodeproj/project.pbxproj:
WebCoreSources.bkl:
dom/CrossThreadCopier.cpp: Added.
dom/CrossThreadCopier.h: Added. (WebCore::CrossThreadCopierPassThrough::copy):
dom/GenericWorkerTask.h: Stop doing the WorkerMessagingProxy::askedToTerminate call automatically in performTask because was not obvious that it would be done and not always needed.

(WebCore::GenericWorkerTask1::create):
(WebCore::GenericWorkerTask1::GenericWorkerTask1):
(WebCore::GenericWorkerTask1::performTask):
(WebCore::GenericWorkerTask2::create):
(WebCore::GenericWorkerTask2::GenericWorkerTask2):
(WebCore::GenericWorkerTask2::performTask):
(WebCore::GenericWorkerTask3::create):
(WebCore::GenericWorkerTask3::GenericWorkerTask3):
(WebCore::GenericWorkerTask3::performTask):
(WebCore::GenericWorkerTask4::create):
(WebCore::GenericWorkerTask4::GenericWorkerTask4):
(WebCore::GenericWorkerTask4::performTask):
(WebCore::GenericWorkerTask5::create):
(WebCore::GenericWorkerTask5::GenericWorkerTask5):
(WebCore::GenericWorkerTask5::performTask):
(WebCore::GenericWorkerTask6::create):
(WebCore::GenericWorkerTask6::GenericWorkerTask6):
(WebCore::GenericWorkerTask6::performTask):
(WebCore::GenericWorkerTask7::create):
(WebCore::GenericWorkerTask7::GenericWorkerTask7):
(WebCore::GenericWorkerTask7::performTask):
(WebCore::createCallbackTask):

dom/WorkerContext.cpp: (WebCore::addMessageTask): (WebCore::WorkerContext::addMessage):
dom/WorkerMessagingProxy.h: (WebCore::WorkerMessagingProxy::askedToTerminate):

10:45 PM Changeset in webkit [40524] by weinig@apple.com

15 edits in trunk/WebCore

2009-02-02 Sam Weinig <sam@webkit.org>

Reviewed by David "The Barnabas Jones" Hyatt.

Move removeChildNode, appendChildNode and insertChildNode from
RenderContainer into RenderObjectChildList. Make moveChildNode
static in RenderBlock, as that was the only user.

rendering/RenderBlock.cpp: (WebCore::moveChild): (WebCore::RenderBlock::makeChildrenNonInline): (WebCore::RenderBlock::removeChild): (WebCore::RenderBlock::handleRunInChild):
rendering/RenderContainer.cpp: (WebCore::RenderContainer::addChild): (WebCore::RenderContainer::removeChild):
rendering/RenderContainer.h:
rendering/RenderInline.cpp: (WebCore::RenderInline::splitInlines): (WebCore::RenderInline::splitFlow): (WebCore::RenderInline::childBecameNonInline):
rendering/RenderObject.cpp: (WebCore::RenderObject::handleDynamicFloatPositionChange):
rendering/RenderObject.h: (WebCore::RenderObject::createsAnonymousWrapper):
rendering/RenderObjectChildList.cpp: (WebCore::updateListMarkerNumbers): (WebCore::RenderObjectChildList::removeChildNode): (WebCore::RenderObjectChildList::appendChildNode): (WebCore::RenderObjectChildList::insertChildNode):
rendering/RenderObjectChildList.h:
rendering/RenderSVGContainer.cpp: (WebCore::RenderSVGContainer::addChild): (WebCore::RenderSVGContainer::removeChild):
rendering/RenderSVGContainer.h:
rendering/RenderTable.cpp: (WebCore::RenderTable::removeChild):
rendering/RenderTable.h:
rendering/RenderTableSection.cpp: (WebCore::RenderTableSection::removeChild):
rendering/RenderTableSection.h:

10:39 PM Changeset in webkit [40523] by ap@webkit.org

2 edits in trunk/WebCore

Reviewed by Darin Alder.

https://bugs.webkit.org/show_bug.cgi?id=23697
Leaks seen on Worker tests

dom/WorkerMessagingProxy.cpp: (WebCore::WorkerMessagingProxy::workerContextDestroyedInternal): Zero out m_workerThread, so that the proxy could be deleted once workerObjectDestroyed() is called.

10:08 PM Changeset in webkit [40522] by oliver@apple.com

3 edits
3 adds in trunk

<https://bugs.webkit.org/show_bug.cgi?id=21414> REGRESSION: Regular Expressions and character classes, shorthands and ranges
<rdar://problem/6543487>

Reviewed by Gavin Barraclough.

In certain circumstances when WREC::Generator::generateCharacterClassInvertedRange invokes
itself recursively, it will incorrectly emit (and thus consume) the next single character
match in the current character class. As WREC uses a binary search this out of sequence
codegen could result in a character match being missed and so cause the regex to produce
incorrect results.

9:26 PM Changeset in webkit [40521] by hyatt@apple.com

5 edits in trunk/WebCore

2009-02-02 David Hyatt <hyatt@apple.com>

Move positionForCoordinates up from RenderContainer into RenderBox.

Reviewed by Sam Weinig

rendering/RenderBox.cpp: (WebCore::RenderBox::positionForCoordinates):
rendering/RenderBox.h:
rendering/RenderContainer.cpp:
rendering/RenderContainer.h:

8:47 PM Changeset in webkit [40520] by bfulgham@webkit.org

4 edits in trunk

Incorrect handling of findstr results in *.vcproj.
Fixes https://bugs.webkit.org/show_bug.cgi?id=15813

8:46 PM Changeset in webkit [40519] by ggaren@apple.com

3 edits in trunk/WebKit/wx

2009-02-02 Geoffrey Garen <ggaren@apple.com>

Build fix.

WebKitSupport/FrameLoaderClientWx.cpp: (WebCore::FrameLoaderClientWx::updateGlobalHistoryForRedirectWithoutHistoryItem): (WebCore::FrameLoaderClientWx::createPlugin): (WebCore::FrameLoaderClientWx::createJavaAppletWidget):
WebKitSupport/FrameLoaderClientWx.h:

8:33 PM Changeset in webkit [40518] by hyatt@apple.com

13 edits in trunk/WebCore

2009-02-02 David Hyatt <hyatt@apple.com>

Refactor the handling of before/after content and generated content. Move most of the functions from
RenderContainer into RenderObjectChildList.

Reviewed by Sam Weinig

rendering/RenderBlock.cpp: (WebCore::RenderBlock::updateBeforeAfterContent):
rendering/RenderBlock.h:
rendering/RenderBox.cpp: (WebCore::RenderBox::isAfterContent):
rendering/RenderBox.h:
rendering/RenderButton.cpp: (WebCore::RenderButton::updateBeforeAfterContent):
rendering/RenderContainer.cpp:
rendering/RenderContainer.h:
rendering/RenderCounter.cpp: (WebCore::destroyCounterNodeChildren):
rendering/RenderInline.cpp: (WebCore::RenderInline::styleDidChange): (WebCore::RenderInline::addChildIgnoringContinuation): (WebCore::RenderInline::splitInlines):
rendering/RenderObject.h:
rendering/RenderObjectChildList.cpp: (WebCore::beforeAfterContainer): (WebCore::findBeforeAfterParent): (WebCore::invalidateCountersInContainer): (WebCore::RenderObjectChildList::invalidateCounters): (WebCore::RenderObjectChildList::updateBeforeAfterContent):
rendering/RenderObjectChildList.h:

8:23 PM Changeset in webkit [40517] by Dimitri Glazkov

3 edits in trunk/WebCore

2009-02-02 Dmitry Titov <dimich@chromium.org>

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=23661
Fix Chromium build.

history/HistoryItem.h: need to include <wtf/OwnPtr.h>

rendering/RenderThemeChromiumMac.mm: (WebCore::RenderThemeChromiumMac::adjustMenuListStyle): isEnabled() is now on FormControlElement.

7:08 PM Changeset in webkit [40516] by ggaren@apple.com

2 edits in trunk/WebCore

2009-02-02 Geoffrey Garen <ggaren@apple.com>

Build fix.

plugins/PluginView.cpp: (WebCore::PluginView::performRequest):

7:06 PM Changeset in webkit [40515] by ggaren@apple.com

4 edits in trunk/WebKit

WebKit/qt:

2009-02-02 Geoffrey Garen <ggaren@apple.com>

Build fix.

Api/qwebframe.cpp: (QWebFrame::QWebFrame): (QWebFrame::load): (QWebFrame::setHtml): (QWebFrame::setContent):

WebKit/wx:

2009-02-02 Geoffrey Garen <ggaren@apple.com>

Build fix.

WebFrame.cpp: (wxWebFrame::LoadURL):

7:03 PM Changeset in webkit [40514] by ggaren@apple.com

4 edits in trunk

WebCore:

2009-02-02 Geoffrey Garen <ggaren@apple.com>

Build fix.

WebCore.base.exp:

WebKit/mac:

2009-02-02 Geoffrey Garen <ggaren@apple.com>

Build fix.

Plugins/WebPluginController.mm: (-[WebPluginController webPlugInContainerLoadRequest:inFrame:]):

6:56 PM Changeset in webkit [40513] by ggaren@apple.com

2 edits in trunk/WebKit/gtk

2009-02-02 Geoffrey Garen <ggaren@apple.com>

Build fix.

webkit/webkitwebview.cpp:

6:54 PM Changeset in webkit [40512] by ggaren@apple.com

2 edits in trunk/WebKit/gtk

2009-02-02 Geoffrey Garen <ggaren@apple.com>

Build fix.

webkit/webkitwebframe.cpp:

6:52 PM Changeset in webkit [40511] by ggaren@apple.com

2 edits in trunk/WebKit/win

2009-02-02 Geoffrey Garen <ggaren@apple.com>

Build fix.

WebCoreSupport/WebFrameLoaderClient.cpp: (WebFrameLoaderClient::loadURLIntoChild):

6:52 PM Changeset in webkit [40510] by ggaren@apple.com

2 edits in trunk/WebKit/qt

2009-02-02 Geoffrey Garen <ggaren@apple.com>

Build fix.

WebCoreSupport/FrameLoaderClientQt.cpp: (WebCore::FrameLoaderClientQt::createFrame):

6:49 PM Changeset in webkit [40509] by ggaren@apple.com

2 edits in trunk/WebKit/gtk

2009-02-02 Geoffrey Garen <ggaren@apple.com>

Build fix.

WebCoreSupport/FrameLoaderClientGtk.cpp: (WebKit::FrameLoaderClient::createFrame):

6:31 PM Changeset in webkit [40508] by ggaren@apple.com

37 edits in trunk

WebCore:

2009-02-02 Geoffrey Garen <ggaren@apple.com>

Reviewed by Sam Weinig.

Track redirects in global history.

WebCore.base.exp: Renamed some exports.

bindings/js/JSDOMWindowBase.cpp: (WebCore::createWindow): (windowProtoFuncOpen):
bindings/js/JSDOMWindowCustom.cpp: (WebCore::JSDOMWindow::setLocation):
bindings/js/JSDocumentCustom.cpp: (WebCore::JSDocument::setLocation):
bindings/js/JSHTMLFormElementCustom.cpp: (WebCore::JSHTMLFormElement::submit):
bindings/js/JSLocationCustom.cpp: (WebCore::JSLocation::setHref): (WebCore::JSLocation::setProtocol): (WebCore::JSLocation::setHost): (WebCore::JSLocation::setHostname): (WebCore::JSLocation::setPort): (WebCore::JSLocation::setPathname): (WebCore::JSLocation::setSearch): (WebCore::JSLocation::setHash): (WebCore::JSLocation::assign): Treat any navigation that is not initiated by the user as a redirect from the perspective of global history.

history/HistoryItem.cpp: (WebCore::HistoryItem::addRedirectURL): Store the last URL in the redirect chain.

loader/DocumentLoader.cpp: (WebCore::DocumentLoader::DocumentLoader):
loader/DocumentLoader.h: (WebCore::DocumentLoader::urlForHistoryReflectsServerRedirect): (WebCore::DocumentLoader::urlForHistoryReflectsClientRedirect): (WebCore::DocumentLoader::setURLForHistoryReflectsClientRedirect): Sadly, added yet another way to track redirect state during loading, since none of the others did what I wanted, and I didn't want to cause behavior changes in existing code.

loader/EmptyClients.h: (WebCore::EmptyFrameLoaderClient::updateGlobalHistoryForRedirectWithoutHistoryItem): Stubbed out a client function to keep things building.

loader/FrameLoader.cpp: (WebCore::isBackForwardLoadType): (WebCore::FrameLoader::restoreDocumentState): Renamed FrameLoadTypeRedirect => FrameLoadTypeRedirectWithLockedBackForwardList, to distinguish from all the other meanings of "redirect" in the loading code.

(WebCore::FrameLoader::scheduleHTTPRedirection): Treat any HTTP refresh
redirect as a redirect from the perspective of global history.

(WebCore::FrameLoader::loadURLIntoChildFrame): Updated for rename and extra
parameter.

(WebCore::FrameLoader::startRedirectionTimer): Removed unused parameter.

(WebCore::FrameLoader::loadFrameRequestWithFormAndValues):
(WebCore::FrameLoader::loadURL):
(WebCore::FrameLoader::load): Updated for rename and extra parameter.

(WebCore::FrameLoader::loadWithNavigationAction): Track redirect status
in the DocumentLoader, so it's accessible to WebKit's global history code.

(WebCore::FrameLoader::clientRedirected): Ignore lockHistory, since it
only has meaning to global history, and m_quickRedirectComing pertains
to other kinds of history.

(WebCore::FrameLoader::loadPostRequest):
(WebCore::FrameLoader::loadEmptyDocumentSynchronously):
(WebCore::FrameLoader::continueFragmentScrollAfterNavigationPolicy):
(WebCore::FrameLoader::continueLoadAfterNewWindowPolicy):
(WebCore::FrameLoader::loadItem): Updated for extra parameter and rename.

(WebCore::FrameLoader::updateHistory*): Notify WebKit about redirect
navigations even if they don't create new history items, so we can track
the redirect in the existing history item.

loader/FrameLoader.h: See above.

loader/FrameLoaderClient.h: New client interface used by FrameLoader::updateHistory* to record a redirect even if it doesn't create a new history item of its own.

loader/FrameLoaderTypes.h: See above. (WebCore::):

page/DragController.cpp: (WebCore::DragController::performDrag):
svg/graphics/SVGImage.cpp: (WebCore::SVGImage::dataChanged): Updated for extra parameter.

WebKit/gtk:

2009-02-02 Geoffrey Garen <ggaren@apple.com>

Reviewed by Sam Weinig.

Track redirects in global history.

Keep GTK building.

WebCoreSupport/FrameLoaderClientGtk.cpp: (WebKit::FrameLoaderClient::createFrame): (WebKit::FrameLoaderClient::updateGlobalHistoryForRedirectWithoutHistoryItem):
WebCoreSupport/FrameLoaderClientGtk.h:

WebKit/mac:

2009-02-02 Geoffrey Garen <ggaren@apple.com>

Reviewed by Sam Weinig.

Track redirects in global history.

History/WebHistory.mm: (-[WebHistoryPrivate dealloc]): (-[WebHistoryPrivate lastVisitedEntry]): (-[WebHistoryPrivate setLastVisitedEntry:]): Remember the last global history entry in case we're asked to add redirect information to it later.

(-[WebHistory _visitedURL:withTitle:method:wasFailure:serverRedirectURL:isClientRedirect:]):
(-[WebHistory _visitedURLForRedirectWithoutHistoryItem:]): Record redirect
information in global history.

History/WebHistoryInternal.h:
WebCoreSupport/WebFrameLoaderClient.h: See above and below.

WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::updateGlobalHistory): (WebFrameLoaderClient::updateGlobalHistoryForRedirectWithoutHistoryItem): Record redirect information in global history.

WebView/WebFrame.mm: (-[WebFrame loadRequest:]): (-[WebFrame _loadData:MIMEType:textEncodingName:baseURL:unreachableURL:]):
WebView/WebFramePrivate.h: Updated for rename and extra parameter.

WebKit/qt:

2009-02-02 Geoffrey Garen <ggaren@apple.com>

Reviewed by Sam Weinig.

Track redirects in global history.

Keep Qt building.

WebCoreSupport/FrameLoaderClientQt.cpp: (WebCore::FrameLoaderClientQt::updateGlobalHistoryForRedirectWithoutHistoryItem): (WebCore::FrameLoaderClientQt::createFrame):
WebCoreSupport/FrameLoaderClientQt.h:

WebKit/win:

2009-02-02 Geoffrey Garen <ggaren@apple.com>

Reviewed by Sam Weinig.

Track redirects in global history.

Interfaces/IWebFramePrivate.idl: Updated for WebCore rename.

WebCoreSupport/WebFrameLoaderClient.cpp: (WebFrameLoaderClient::updateGlobalHistory): (WebFrameLoaderClient::updateGlobalHistoryForRedirectWithoutHistoryItem): Store redirect information in global history.

(WebFrameLoaderClient::loadURLIntoChild): Updated for extra parameter.

WebCoreSupport/WebFrameLoaderClient.h: See above.

WebFrame.cpp: (WebFrame::loadRequest): (WebFrame::loadData): Updated for extra parameter.

WebHistory.cpp: (WebHistory::visitedURL): (WebHistory::visitedURLForRedirectWithoutHistoryItem): Store redirect information in global history.

WebHistory.h: See above.

5:35 PM Changeset in webkit [40507] by andersca@apple.com

5 edits in trunk/WebKit/mac

2009-02-02 Anders Carlsson <andersca@apple.com>

Reviewed by Dan Bernstein.

Work around a limitation in MIG where two functions can't have the same name even if they're
not in the same subsystem.

Plugins/Hosted/NetscapePluginHostProxy.mm: (WebKit::NetscapePluginHostProxy::NetscapePluginHostProxy):
Plugins/Hosted/NetscapePluginInstanceProxy.mm: (WebKit::NetscapePluginInstanceProxy::processRequestsAndWaitForReply):
Plugins/Hosted/WebKitPluginClient.defs:
Plugins/Hosted/WebKitPluginHost.defs:

5:21 PM Changeset in webkit [40506] by hyatt@apple.com

4 edits in trunk/WebCore

2009-02-02 David Hyatt <hyatt@apple.com>

Make calcPrefWidths non-abstract on RenderBox and just give it RenderContainer's implementation.
Remove RenderSVGContainer's implementation, since it was never called.

Reviewed by Beth Dakin

rendering/RenderBox.cpp: (WebCore::RenderBox::minPrefWidth):
rendering/RenderBox.h: (WebCore::RenderBox::calcPrefWidths):
rendering/RenderContainer.h: (WebCore::RenderContainer::moveChildNode):
rendering/RenderSVGContainer.h:

4:59 PM Changeset in webkit [40505] by andersca@apple.com

11 edits in trunk

WebCore:

2009-02-02 Anders Carlsson <andersca@apple.com>

Reviewed by Sam Weinig.

Add jsObjectForPluginElement to ScriptController, and have createScriptObjectForPluginElement call it.

WebCore.LP64.exp:
bindings/js/ScriptController.cpp: (WebCore::ScriptController::createScriptObjectForPluginElement): (WebCore::ScriptController::jsObjectForPluginElement):
bindings/js/ScriptController.h:

WebKit/mac:

2009-02-02 Anders Carlsson <andersca@apple.com>

Reviewed by Sam Weinig.

Implement WKPCGetPluginElementObject.

Plugins/Hosted/NetscapePluginHostProxy.mm: (WKPCGetPluginElementNPObject):
Plugins/Hosted/NetscapePluginInstanceProxy.h:
Plugins/Hosted/NetscapePluginInstanceProxy.mm: (WebKit::NetscapePluginInstanceProxy::getPluginElementNPObject):
Plugins/Hosted/WebKitPluginClient.defs:
Plugins/WebBaseNetscapePluginView.h:
Plugins/WebBaseNetscapePluginView.mm: (-[WebBaseNetscapePluginView WebCore::]):

4:45 PM Changeset in webkit [40504] by darin@chromium.org

2 edits in trunk/WebCore

2009-02-02 Darin Fisher <darin@chromium.org>

Reviewed by Eric Seidel (and Ojan Vafai).

https://bugs.webkit.org/show_bug.cgi?id=23696
Select element doesn't show new value when focus is switched in
onchange event.

Fix PopupMenuChromium to hide itself before calling valueChanged. This
better matches the behavior of the other ports.

platform/chromium/PopupMenuChromium.cpp: (WebCore::PopupListBox::create): (WebCore::PopupContainer::PopupContainer): (WebCore::PopupContainer::showPopup): (WebCore::PopupContainer::hidePopup): (WebCore::PopupListBox::abandon): (WebCore::PopupListBox::acceptIndex): (WebCore::PopupMenu::show): (WebCore::PopupMenu::hide):

4:28 PM Changeset in webkit [40503] by beidson@apple.com

7 edits in trunk/WebKit/win

2009-02-02 Brady Eidson <beidson@apple.com>

Reviewed by Dan Bernstein

Transition Windows WebHistory to using the same "update already existing History Items" technique that Mac does.

Interfaces/IWebHistoryItemPrivate.idl:
WebCoreSupport/WebFrameLoaderClient.cpp: (WebFrameLoaderClient::updateGlobalHistory):

WebHistory.cpp: (WebHistory::visitedURL):
WebHistory.h:

WebHistoryItem.cpp: (WebHistoryItem::visitedWithTitle):
WebHistoryItem.h:

4:27 PM Changeset in webkit [40502] by hyatt@apple.com

2 edits in trunk/WebCore

2009-02-02 David Hyatt <hyatt@apple.com>

Make sure scrollWidth/Height just return 0 for inline flows.

Reviewed by Beth Dakin

rendering/RenderBox.cpp: (WebCore::RenderBox::scrollWidth): (WebCore::RenderBox::scrollHeight):

4:27 PM Changeset in webkit [40501] by Darin Adler

25 edits in trunk

JavaScriptCore:

2009-02-02 Darin Adler <Darin Adler>

Reviewed by Dave Hyatt.

Bug 23676: Speed up uses of reserveCapacity on new vectors by adding a new reserveInitialCapacity
https://bugs.webkit.org/show_bug.cgi?id=23676

API/JSObjectRef.cpp: (JSObjectCopyPropertyNames): Use reserveInitialCapacity.
parser/Lexer.cpp: (JSC::Lexer::Lexer): Ditto. (JSC::Lexer::clear): Ditto.

wtf/Vector.h: Added reserveInitialCapacity, a more efficient version of reserveCapacity for use when the vector is brand new (still size 0 with no capacity other than the inline capacity).

WebCore:

2009-02-02 Darin Adler <Darin Adler>

Reviewed by Dave Hyatt.

Bug 23676: Speed up uses of reserveCapacity on new vectors by adding a new reserveInitialCapacity
https://bugs.webkit.org/show_bug.cgi?id=23676

bindings/js/JSCSSStyleDeclarationCustom.cpp: (WebCore::cssPropertyName):
css/CSSMutableStyleDeclaration.cpp: (WebCore::CSSMutableStyleDeclaration::CSSMutableStyleDeclaration): (WebCore::CSSMutableStyleDeclaration::removePropertiesInSet):
css/CSSPrimitiveValue.cpp: (WebCore::CSSPrimitiveValue::cssText):
css/CSSStyleDeclaration.cpp: (WebCore::CSSStyleDeclaration::copyPropertiesInSet):
css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::sortMatchedRules):
dom/Document.cpp: (WebCore::Document::formElementsState):
dom/NamedAttrMap.h: (WebCore::NamedAttrMap::reserveInitialCapacity):
editing/TextIterator.cpp: (WebCore::CharacterIterator::string): (WebCore::SearchBuffer::SearchBuffer): (WebCore::plainTextToMallocAllocatedBuffer):
editing/markup.cpp: (WebCore::joinMarkups):
history/HistoryItem.cpp: (WebCore::HistoryItem::HistoryItem):
html/HTMLTokenizer.cpp: (WebCore::Token::addAttribute):
loader/appcache/DOMApplicationCache.cpp: (WebCore::DOMApplicationCache::items):
page/SecurityOrigin.cpp: (WebCore::SecurityOrigin::toString):
page/mac/AccessibilityObjectWrapper.mm: (convertToVector):
platform/graphics/FontCache.cpp: (WebCore::FontCache::purgeInactiveFontData): (WebCore::FontCache::invalidate):
platform/network/FormData.cpp: (WebCore::FormData::deepCopy):
platform/network/HTTPHeaderMap.cpp: (WebCore::HTTPHeaderMap::copyData):
platform/network/ResourceRequestBase.cpp: (WebCore::ResourceRequestBase::copyData):
platform/network/mac/FormDataStreamMac.mm: (WebCore::formCreate):
xml/XPathNodeSet.cpp: (WebCore::XPath::NodeSet::sort): Use reserveInitialCapacity instead of of reserveCapacity in all these call sites, which are working on new vectors that are guaranteed not to be empty.

4:22 PM Changeset in webkit [40500] by jhoneycutt@apple.com

7 edits in trunk/WebCore

2009-02-26 Jon Honeycutt <jhoneycutt@apple.com>

Build fix after r40486.

Rubber-stamped by Ada Chan.

dom/Document.h:
page/EventHandler.h:
rendering/EllipsisBox.h:
rendering/InlineBox.h:
rendering/InlineFlowBox.h:
rendering/RenderLayer.h:

4:07 PM Changeset in webkit [40499] by Darin Adler

4 edits in trunk/WebCore

2009-02-02 Darin Adler <Darin Adler>

Reviewed by Anders Carlsson.

Bug 23694: REGRESSION: Running svg/custom tests crashes, randomly, depending on the order of tests
https://bugs.webkit.org/show_bug.cgi?id=23694

dom/ContainerNode.cpp: (WebCore::ContainerNode::insertedIntoDocument): Added back the call through to EventTargetNode. (WebCore::ContainerNode::removedFromDocument): Ditto.
dom/EventTargetNode.cpp: (WebCore::EventTargetNode::insertedIntoDocument): Changed this to not call through to Node. (WebCore::EventTargetNode::removedFromDocument): Ditto.
dom/Node.cpp: (WebCore::Node::insertedIntoDocument): Updated comment. (WebCore::Node::removedFromDocument): Ditto.

3:57 PM Changeset in webkit [40498] by andersca@apple.com

2 edits in trunk/WebKit/mac

2009-02-02 Anders Carlsson <andersca@apple.com>

Build fix.

WebView/WebHTMLView.mm:

3:48 PM Changeset in webkit [40497] by andersca@apple.com

14 edits
2 deletes in trunk

WebCore:

2009-02-02 Anders Carlsson <andersca@apple.com>

Reviewed by Dan Bernstein.

More plug-in cleanup.

WebCore.NPAPI.exp: Add new symbols.

bindings/objc/DOM.mm:
bindings/objc/DOMPrivate.h: Remove methods that WebKit doesn't use anymore.

WebKit:

2009-02-02 Anders Carlsson <andersca@apple.com>

Reviewed by Dan Bernstein.

Remove WebKitPluginContainerView.{h|mm}, they aren't used anywhere.

WebKit.xcodeproj/project.pbxproj:

WebKit/mac:

2009-02-02 Anders Carlsson <andersca@apple.com>

Reviewed by Dan Bernstein.

Make WebBaseNetscapePluginView hold a reference to a HTMLPlugInElement instead of a DOMElement.

Plugins/Hosted/WebHostedNetscapePluginView.h:
Plugins/Hosted/WebHostedNetscapePluginView.mm: (-[WebHostedNetscapePluginView initWithFrame:pluginPackage:URL:baseURL:MIMEType:attributeKeys:attributeValues:loadManually:element:WebCore::]):
Plugins/WebBaseNetscapePluginView.h:
Plugins/WebBaseNetscapePluginView.mm: (-[WebBaseNetscapePluginView initWithFrame:pluginPackage:URL:baseURL:MIMEType:attributeKeys:attributeValues:loadManually:element:WebCore::]): (-[WebBaseNetscapePluginView _windowClipRect]): (-[WebBaseNetscapePluginView visibleRect]): (-[WebBaseNetscapePluginView dataSource]):
Plugins/WebKitPluginContainerView.h: Removed.
Plugins/WebKitPluginContainerView.mm: Removed.
Plugins/WebNetscapePluginView.h:
Plugins/WebNetscapePluginView.mm: (-[WebNetscapePluginView initWithFrame:pluginPackage:URL:baseURL:MIMEType:attributeKeys:attributeValues:loadManually:element:WebCore::]): (-[WebNetscapePluginView getVariable:value:]):
WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::createPlugin):

3:44 PM Changeset in webkit [40496] by andersca@apple.com

2 edits in trunk/WebKit/gtk

2009-02-02 Anders Carlsson <andersca@apple.com>

Build fix.

WebCoreSupport/FrameLoaderClientGtk.h:

3:30 PM Changeset in webkit [40495] by andersca@apple.com

3 edits in trunk/WebKit/win

2009-02-02 Anders Carlsson <andersca@apple.com>

Fix build.

WebCoreSupport/WebFrameLoaderClient.cpp: (WebFrameLoaderClient::createPlugin):
WebCoreSupport/WebFrameLoaderClient.h:

3:07 PM Changeset in webkit [40494] by eric@webkit.org

3 edits in trunk/WebCore

2009-02-02 Jay Campan <jcampan@chromium.org>

Reviewed by Eric Seidel.

Clean up PopupMenuChromium a little.
https://bugs.webkit.org/show_bug.cgi?id=23653

No functional changes, only code cleanup, thus no tests.

platform/chromium/PopupMenuChromium.cpp: (WebCore::): (WebCore::PopupListBox::PopupListBox): (WebCore::PopupContainer::create): (WebCore::PopupContainer::PopupContainer): (WebCore::PopupContainer::showPopup): (WebCore::PopupListBox::handleKeyEvent): (WebCore::PopupListBox::isSelectableItem): (WebCore::PopupListBox::selectNextRow): (WebCore::PopupListBox::selectPreviousRow): (WebCore::PopupMenu::show):
platform/chromium/PopupMenuChromium.h:

2:36 PM Changeset in webkit [40493] by andersca@apple.com

18 edits in trunk

WebCore:

2009-02-02 Anders Carlsson <andersca@apple.com>

Reviewed by Dan Bernstein.

Change createPlugin to take a HTMLPlugInElement, and createJavaAppletWidget to take a HTMLAppletElement.

WebCore.xcodeproj/project.pbxproj:
loader/EmptyClients.h: (WebCore::EmptyFrameLoaderClient::createPlugin): (WebCore::EmptyFrameLoaderClient::createJavaAppletWidget):
loader/FrameLoader.cpp: (WebCore::toPlugInElement): (WebCore::FrameLoader::loadPlugin): (WebCore::FrameLoader::loadItem):
loader/FrameLoader.h:
loader/FrameLoaderClient.h:

WebKit/gtk:

2009-02-02 Anders Carlsson <andersca@apple.com>

Reviewed by Dan Bernstein.

Update for changes to WebCore.

WebCoreSupport/FrameLoaderClientGtk.cpp: (WebKit::FrameLoaderClient::createPlugin): (WebKit::FrameLoaderClient::createJavaAppletWidget):
WebCoreSupport/FrameLoaderClientGtk.h:

WebKit/mac:

2009-02-02 Anders Carlsson <andersca@apple.com>

Reviewed by Dan Bernstein.

Update for changes to WebCore.

WebCoreSupport/WebFrameLoaderClient.h:
WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::createPlugin):

WebKit/qt:

2009-02-02 Anders Carlsson <andersca@apple.com>

Reviewed by Dan Bernstein.

Update for changes to WebCore.

WebCoreSupport/FrameLoaderClientQt.cpp: (WebCore::FrameLoaderClientQt::createPlugin): (WebCore::FrameLoaderClientQt::createJavaAppletWidget):
WebCoreSupport/FrameLoaderClientQt.h:

WebKit/win:

2009-02-02 Anders Carlsson <andersca@apple.com>

Reviewed by Dan Bernstein.

Update for changes to WebCore.

WebFrame.cpp: (WebFrame::createJavaAppletWidget):
WebFrame.h:

2:10 PM Changeset in webkit [40492] by ap@webkit.org

1 edit in trunk/WebCore/ChangeLog

Adding bug URL for a recent check-in.

1:48 PM Changeset in webkit [40491] by staikos@webkit.org

2 edits in trunk/WebCore

Fix shouldLoadAsEmptyDocument() to return a blank page for an empty
url or about:blank

Applies to Torch Mobile platform only right now, as per request.

1:35 PM Changeset in webkit [40490] by bfulgham@webkit.org

5 edits in trunk/WebCore

1:15 PM Changeset in webkit [40489] by christian@webkit.org

2 edits in trunk

2009-02-02 Christian Dywan <christian@twotoasts.de>

Rubber-stamped by Holger Freyther.

Don't require Geolocation by default.

configure.ac:

12:59 PM Changeset in webkit [40488] by Darin Adler

3 edits in trunk/WebCore

2009-02-02 Darin Adler <Darin Adler>

Try to fix Wx build, and maybe Chromium build too.

WebCore.scons: Added IdentifierRep.cpp.
WebCoreSources.bkl: Ditto.

12:55 PM Changeset in webkit [40487] by Darin Adler

2 edits in trunk/WebCore

2009-02-02 Darin Adler <Darin Adler>

Try to fix Wx build.

html/HTMLAreaElement.cpp: Added missing include of "Path.h".

12:46 PM Changeset in webkit [40486] by treat@webkit.org

11 edits in trunk

2009-02-02 Adam Treat <adam.treat@torchmobile.com>

Reviewed by Nikolas Zimmermann.

https://bugs.webkit.org/show_bug.cgi?id=23587
Refactor HitTestRequest to eliminate all the ugly boolean arguments and
use an enum bitflag instead. Cleanup all the code that constructs the
various HitTestRequests to make the code more readable.

dom/Document.cpp: (WebCore::Document::elementFromPoint): (WebCore::Document::prepareMouseEvent):
editing/SelectionController.cpp: (WebCore::SelectionController::contains):
page/AccessibilityRenderObject.cpp: (WebCore::AccessibilityRenderObject::visiblePositionForPoint): (WebCore::AccessibilityRenderObject::doAccessibilityHitTest):
page/EventHandler.cpp: (WebCore::EventHandler::eventMayStartDrag): (WebCore::EventHandler::updateSelectionForMouseDrag): (WebCore::EventHandler::hitTestResultAtPoint): (WebCore::EventHandler::handleMousePressEvent): (WebCore::EventHandler::handleMouseDoubleClickEvent): (WebCore::EventHandler::handleMouseMoveEvent): (WebCore::EventHandler::handleMouseReleaseEvent): (WebCore::EventHandler::updateDragAndDrop): (WebCore::EventHandler::handleWheelEvent): (WebCore::EventHandler::sendContextMenuEvent): (WebCore::EventHandler::hoverTimerFired): (WebCore::EventHandler::handleDrag):
page/EventHandler.h:
rendering/HitTestRequest.h: (WebCore::HitTestRequest::): (WebCore::HitTestRequest::HitTestRequest): (WebCore::HitTestRequest::readOnly): (WebCore::HitTestRequest::active): (WebCore::HitTestRequest::mouseMove): (WebCore::HitTestRequest::mouseUp): (WebCore::HitTestRequest::ignoreClipping):
rendering/RenderFrameSet.cpp: (WebCore::RenderFrameSet::nodeAtPoint):
rendering/RenderLayer.cpp: (WebCore::RenderLayer::hitTest): (WebCore::RenderLayer::hitTestLayer): (WebCore::RenderLayer::updateHoverActiveState):

12:41 PM Changeset in webkit [40485] by staikos@webkit.org

3 edits in trunk/WebCore

Fix the WML build by including the inlined renderStyle().

12:11 PM Changeset in webkit [40484] by Darin Adler

3 edits in trunk/WebCore

2009-02-02 Darin Adler <Darin Adler>

Reviewed by Niko Zimmermann.

Bug 23686: REGRESSION (r40475): Failure in fast/xpath/4XPath/Core/test_core_functions.html
https://bugs.webkit.org/show_bug.cgi?id=23686
rdar://problem/6547971

Also fix other XPath tests that are crashing.

xml/XPathFunctions.cpp: (WebCore::XPath::FunLang::evaluate): Fix order of arguments when creating QualifiedName.
xml/XPathStep.cpp: (WebCore::XPath::Step::nodesInAxis): Use createAttrIfNeeded() rather than attr() since we need to make Attr nodes here. Yuck!

11:53 AM Changeset in webkit [40483] by andersca@apple.com

3 edits in trunk/WebKit/mac

2009-02-02 Anders Carlsson <andersca@apple.com>

Reviewed by Oliver Hunt.

When a new Web View was not created, report back to the plug-in host.

Plugins/Hosted/NetscapePluginInstanceProxy.mm: (WebKit::NetscapePluginInstanceProxy::performRequest):
Plugins/Hosted/WebKitPluginHost.defs:

11:29 AM Changeset in webkit [40482] by staikos@webkit.org

4 edits
3 adds in trunk

Implement WML specific attributes of WMLInputElement.

11:14 AM Changeset in webkit [40481] by andersca@apple.com

2 edits in trunk/WebKit/mac

2009-02-02 Anders Carlsson <andersca@apple.com>

Reviewed by Kevin Decker.

Draw the regular missing plug-in icon instead of a red rect when a plug-in has crashed.

Plugins/Hosted/WebHostedNetscapePluginView.mm: (-[WebHostedNetscapePluginView drawRect:]):

11:12 AM Changeset in webkit [40480] by darin@chromium.org

3 edits in trunk/LayoutTests

2009-01-29 Scott Violet <sky@google.com>

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=23633
The test transitions/transition-end-event-nested.html occasionally fails

Ups the timeout of the test transitions/transition-end-event-nested.html
and makes the test exit as soon as all events received.

transitions/transition-end-event-helpers.js: (recordTransitionEndEvent): (runTransitionTest.startTest._endFunction): (runTransitionTest.startTest): (runTransitionTest):
transitions/transition-end-event-nested.html:

11:10 AM Changeset in webkit [40479] by Nikolas Zimmermann

1 edit in trunk/WebCore/ChangeLog

Forgot to update ChangeLog in my last commit.

11:03 AM Changeset in webkit [40478] by bfulgham@webkit.org

2 edits in trunk/WebCore

Correct build regression.

10:45 AM Changeset in webkit [40477] by Nikolas Zimmermann

1 edit in trunk/WebCore/wml/WMLAElement.cpp

Not reviewed. Fix WML enabled builds.
FrameLoader::urlSelected() got a new parameter: lockBackForwardList. Pass 'false', as HTMLAnchorElement does.

10:12 AM Changeset in webkit [40476] by ap@webkit.org

3 edits in trunk/WebCore

Reviewed by Darin Adler.

<rdar://problem/6451610> Reloading a AppCache page doesn't ever hit the server

Not easily testable.

loader/appcache/ApplicationCacheGroup.cpp: (WebCore::ApplicationCacheGroup::createResourceHandle): A new method that creates a resource handle in a manner that is closer to what CachedResource does. We now make conditional requests for better performance, and set max-age to ensure that stale responses are not used. (WebCore::ApplicationCacheGroup::update): Use the new createResourceHandle() method. (WebCore::ApplicationCacheGroup::didReceiveResponse): If the response code for the resource is 304, take it from the newest cache. (WebCore::ApplicationCacheGroup::didFail): Pre-compute request URL. (WebCore::ApplicationCacheGroup::didReceiveManifestResponse): Don't create a resource for the manifest if the response code was 304 - it won't be needed. (WebCore::ApplicationCacheGroup::didReceiveManifestData): Replaced an assertion that m_manifestResource is not null with a check. (WebCore::ApplicationCacheGroup::didFinishLoadingManifest): Treat null m_manifestResource as an indication that the response was 304. (WebCore::ApplicationCacheGroup::startLoadingEntry): Use createResourceHandle().

loader/appcache/ApplicationCacheGroup.h: Added createResourceHandle().

9:29 AM Changeset in webkit [40475] by Darin Adler

31 edits in trunk/WebCore

2009-02-01 Darin Adler <Darin Adler>

Reviewed by Dave Hyatt.

Bug 23674: Speed up some things based on profiling the page load test
https://bugs.webkit.org/show_bug.cgi?id=23674

css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::canShareStyleWithElement): Use the newly named cssTarget instead of the old name, getCSSTarget. (WebCore::CSSStyleSelector::SelectorChecker::checkOneSelector): Ditto.

dom/ContainerNode.cpp: (WebCore::ContainerNode::insertedIntoDocument): Moved code from Node in here rather than calling through to EventTargetNode::insertedIntoDocument. (WebCore::ContainerNode::removedFromDocument): Ditto. (WebCore::ContainerNode::insertedIntoTree): Tweaked a bit. (WebCore::ContainerNode::removedFromTree): Ditto.

dom/ContainerNode.h: Moved the constructor definition here and made it inline.

dom/Document.cpp: (WebCore::Document::removeAllEventListenersFromAllNodes): Iterate the document element and its contents only to avoid the document type node. This allows us to remove the virtual function call to isEventTargetNode from the loop. (WebCore::Document::setCSSTarget): Changed argument to be an Element rather than Node.

dom/Document.h: Changed CSS target to be an Element rather than a Node. Renamed getCSSTarget to cssTarget.

dom/EventTargetNode.cpp: (WebCore::EventTargetNode::removeAllEventListenersSlowCase): Renamed and turned the rare data check into an assertion.

dom/EventTargetNode.h: Made the fast case of removeAllEventListeners be inline. Also moved the constructor definition here and made it inline. And added toEventTargetNode, matching the design of the render tree checked casts. Later we can migrate all callers from EventTargetNodeCast to toEventTargetNode.

dom/NamedAttrMap.cpp: (WebCore::NamedAttrMap::detachAttributesFromElement): Added. Factored out from clearAttributes, so we could use this loop in cases where we're not clearing the attributes. (WebCore::NamedAttrMap::~NamedAttrMap): Call detachAttributesFromElement instead of clearAttributes here. (WebCore::NamedAttrMap::clearAttributes): Call detachAttributesFromElement here. (WebCore::NamedAttrMap::detachFromElement): Call detachAttributesFromElement instead of clearAttributes. We don't need to clear the attributes array just because the element is going away, so don't. (WebCore::NamedAttrMap::virtualLength): Added.

dom/NamedAttrMap.h: Made all the virtual functions inherited from NamedNodeMap be private. These are all unnecessarily inefficient for use outside the DOM. Changed length to be a non-virtual function. This was a fairly hot function.

dom/NamedMappedAttrMap.cpp: (WebCore::NamedMappedAttrMap::setClass): Changed to use element() function now that the m_element data member is private.

dom/NamedMappedAttrMap.h: Made a few functions private. Made the hasMappedAttributes function non-virtual.

dom/NamedNodeMap.h: Made length a non-virtual inline function that calls a virtual function, name virtualLength. This lets NamedAttrMap::length be a non-virtual function.

dom/Node.cpp: (WebCore::Node::insertedIntoDocument): Removed call to insertedIntoTree, since it's only non-empty in subclasses of ContainerNode. (WebCore::Node::removedFromDocument): Ditto. Also removed setCSSTarget. Since a CSS target has to be an Element, this can be moved down to ContainerNode (or it could be moved down to Element for that matter).

dom/QualifiedName.cpp: (WebCore::QualifiedName::QualifiedName): Removed double initialization of m_impl.

dom/QualifiedName.h: Moved the destructor, copy constructor, assignment operator, and setPrefix function definitions into the header and made them inline.

html/HTMLAreaElement.cpp: (WebCore::HTMLAreaElement::mapMouseEvent): Updated since the stored region is now an OwnPtr. (WebCore::HTMLAreaElement::accessKey): Use AtomicString. (WebCore::HTMLAreaElement::setAccessKey): Ditto. (WebCore::HTMLAreaElement::alt): Ditto. (WebCore::HTMLAreaElement::setAlt): Ditto. (WebCore::HTMLAreaElement::coords): Ditto. (WebCore::HTMLAreaElement::setCoords): Ditto. (WebCore::HTMLAreaElement::setHref): Ditto. (WebCore::HTMLAreaElement::shape): Ditto. (WebCore::HTMLAreaElement::setShape): Ditto. (WebCore::HTMLAreaElement::setTarget): Ditto.

html/HTMLAreaElement.h: Use AtomicString in the getter and setter DOM operations. Change the region data member to be an OwnPtr<Path> instead of a Path to optimize the common case where an area element is parsed but never hit-tested. This could also have been done by changing the Path class's null case to be more efficient, but this seems fine.

html/HTMLViewSourceDocument.cpp: (WebCore::HTMLViewSourceDocument::createContainingTable): Use addAttribute instead of insertAttribute. (WebCore::HTMLViewSourceDocument::addSpanWithClassName): Ditto. (WebCore::HTMLViewSourceDocument::addLine): Ditto. (WebCore::HTMLViewSourceDocument::addLink): Ditto.

loader/FrameLoader.cpp: (WebCore::FrameLoader::gotoAnchor): Use cssTarget under its new name instead of its old name getCSSTarget.

platform/graphics/GlyphWidthMap.cpp: (WebCore::GlyphWidthMap::locatePageSlowCase): Refactored from locatePage.

platform/graphics/GlyphWidthMap.h: Made most of this class inline. Changed m_pages to use OwnPtr.

platform/text/PlatformString.h: Remove include no longer needed since StringImpl.h includes it.

platform/text/StringImpl.cpp: (WebCore::StringImpl::createStrippingNullCharactersSlowCase): Refactored from createStrippingNullCharacters.
platform/text/StringImpl.h: Moved the definition of createStrippingNullCharacters here and made it inline.

rendering/RenderObject.cpp: (WebCore::RenderObject::firstLineStyleSlowCase): Refactored from firstLineStyle.

rendering/RenderObject.h: Moved the definition of the firstLineStyle function here and made it inline. Moved the definition of the documentBeingDestroyed function here and made it inline.

svg/SVGSVGElement.cpp: (WebCore::SVGSVGElement::getCTM): Use getAttributeItem instead of getNamedItem here since it accomplishes the same thing but is more efficient. (WebCore::SVGSVGElement::getScreenCTM): Ditto.
svg/SVGStyledElement.cpp: (WebCore::SVGStyledElement::getPresentationAttribute): Ditto.

xml/XPathFunctions.cpp: (WebCore::XPath::FunLang::evaluate): Use getAttributeItem instead of getNamedItemNS.

xml/XPathStep.cpp: (WebCore::XPath::Step::nodesInAxis): Use attributeItem instead of item here.

7:29 AM Changeset in webkit [40474] by treat@webkit.org

2 edits in trunk/WebKit/qt

2009-02-02 Adam Treat <adam.treat@torchmobile.com>

Fix the Qt build to call forceLayout on the view instead.

Api/qwebpage.cpp: (QWebPage::setFixedLayoutSize): (QWebPage::setUseFixedLayout):

5:16 AM Changeset in webkit [40473] by zecke@webkit.org

18 edits in trunk

Move Frame::forceLayout, Frame::adjustPageHeight and Frame::forceLayoutWithPageWidthRange to FrameView

https://bugs.webkit.org/show_bug.cgi?id=23428

FrameView::forceLayout could be killed but the comment might
contain a value over the the plain FrameView::layout...

Adjust the WebCore/WebKit consumers of these methods.

Feb 1, 2009:

12:30 PM Changeset in webkit [40472] by mitz@apple.com

5 edits in trunk/WebCore

Reviewed by John Sullivan.

fix <rdar://problem/6546625> REGRESSION (r40432): iframes added to global history at haaretz.co.il

Fixes http/tests/navigation/multiple-back-forward-entries.html

r40432 added a parameter to FrameLoader::scheduleLocationChange() and
failed to update all call sites.

bindings/js/JSDOMWindowBase.cpp: (WebCore::createWindow): Pass the lockBackForwardHistory parameter, giving it the same value as the lockHistory parameter. (windowProtoFuncOpen): Ditto.
bindings/js/JSDOMWindowCustom.cpp: (WebCore::JSDOMWindow::setLocation): Ditto.
bindings/js/JSDocumentCustom.cpp: (WebCore::JSDocument::setLocation): Ditto.
loader/FrameLoader.cpp: (WebCore::FrameLoader::requestFrame): Ditto.

Note: See TracTimeline for information about the timeline view.

Download in other formats:

RSS Feed