Timeline
Feb 9, 2009:
- 9:41 PM Changeset in webkit [40808] by
-
- 3 edits in trunk/WebCore
Reviewed by Dave Hyatt.
- fix <rdar://problem/6568942> REGRESSION: Font rendering in Wikipedia input field is incorrect (default GDI text mode)
- platform/graphics/win/SimpleFontDataWin.cpp: (WebCore::SimpleFontData::widthForGDIGlyph): Make sure that the DC is in the advanced graphics mode before calling GetCharWidthI(), because otherwise that function returns incorrect results for the default UI font at a certain size.
- 9:22 PM Changeset in webkit [40807] by
-
- 7 edits in trunk
2009-02-09 Chris Marrin <cmarrin@apple.com>
Reviewed by Simon Fraser
Added 3D functions to WebKitCSSMatrix. This depends on the 3D functions
added to TransformationMatrix in https://bugs.webkit.org/show_bug.cgi?id=6868
Test: transforms/3d/cssmatrix-3d-interface.xhtml
- 9:20 PM Changeset in webkit [40806] by
-
- 2 edits in trunk/WebKit/mac
Fix <https://bugs.webkit.org/show_bug.cgi?id=23863> / <rdar://problem/6571390>.
Bug 23863: Reproducible crash in Mail with TOT WebKit when creating a new message
Reviewed by Dan Bernstein.
- WebView/WebHTMLView.mm:
(-[WebHTMLView _removeMouseMovedObserverUnconditionally]): Nil-check _private as it may have not
yet been initialized if this WebHTMLView was loaded from a nib.
(-[WebHTMLView _removeSuperviewObservers]): Ditto.
- 7:13 PM Changeset in webkit [40805] by
-
- 3 edits in trunk/LayoutTests/platform/mac/fast/inline
Land updated layout tests after recent changes.
- 7:13 PM Changeset in webkit [40804] by
-
- 3 edits2 adds in trunk
Fix <https://bugs.webkit.org/show_bug.cgi?id=23858>
Bug 23858: Crash when removing a HTMLSelectElement from the document from inside its focus event handler
Reviewed by Darin Adler.
- html/HTMLSelectElement.cpp:
(WebCore::HTMLSelectElement::menuListDefaultEventHandler): Don't store the renderer in a local variable
as it can be invalidated by any of the calls to focus() within the function. Instead, retrieve it and
null-check it when it is needed.
Test for <https://bugs.webkit.org/show_bug.cgi?id=23858>
Bug 23858: Crash when removing a HTMLSelectElement from the document from inside its focus event handler
Reviewed by Sam Weinig.
- fast/dom/HTMLSelectElement/remove-element-from-within-focus-handler-crash-expected.txt: Added.
- fast/dom/HTMLSelectElement/remove-element-from-within-focus-handler-crash.html: Added.
- 7:00 PM Changeset in webkit [40803] by
-
- 2 edits in trunk/LayoutTests/platform/mac/svg/custom
Land updated svg layout tests after recent changes.
- 6:47 PM Changeset in webkit [40802] by
-
- 16 edits in trunk/WebCore
2009-02-09 David Hyatt <hyatt@apple.com>
Remove the m_height member from InlineBox. This shaves 4 bytes off of all inline boxes. Unfortunately SVG
sets heights that are independent of the renderer or of the font, and so all SVG boxes have to retain m_height
member variables.
height() on InlineBox is now a virtual function that does a dynamic computation (including shrinking boxes
with no text children). For SVG boxes there is also a non-virtual setHeight function for updating the
m_height member variable like before.
Reviewed by Darin Adler
- rendering/EllipsisBox.cpp: (WebCore::EllipsisBox::nodeAtPoint):
- rendering/EllipsisBox.h: (WebCore::EllipsisBox::EllipsisBox):
- rendering/InlineBox.cpp: (WebCore::InlineBox::height): (WebCore::InlineBox::root):
- rendering/InlineBox.h: (WebCore::InlineBox::InlineBox): (WebCore::InlineBox::isInlineFlowBox): (WebCore::InlineBox::isRootInlineBox): (WebCore::InlineBox::topOverflow): (WebCore::InlineBox::bottomOverflow): (WebCore::InlineBox::leftOverflow): (WebCore::InlineBox::rightOverflow):
- rendering/InlineFlowBox.cpp: (WebCore::InlineFlowBox::height): (WebCore::InlineFlowBox::adjustMaxAscentAndDescent): (WebCore::InlineFlowBox::computeLogicalBoxHeights): (WebCore::InlineFlowBox::placeBoxesVertically): (WebCore::InlineFlowBox::shrinkBoxesWithNoTextChildren): (WebCore::InlineFlowBox::nodeAtPoint):
- rendering/InlineFlowBox.h: (WebCore::InlineFlowBox::isInlineFlowBox):
- rendering/InlineTextBox.cpp: (WebCore::InlineTextBox::height): (WebCore::InlineTextBox::nodeAtPoint): (WebCore::InlineTextBox::paintSpellingOrGrammarMarker): (WebCore::InlineTextBox::paintCompositionUnderline):
- rendering/InlineTextBox.h:
- rendering/RootInlineBox.cpp: (WebCore::RootInlineBox::height): (WebCore::RootInlineBox::placeEllipsis): (WebCore::RootInlineBox::setVerticalOverflowPositions):
- rendering/RootInlineBox.h: (WebCore::RootInlineBox::isRootInlineBox): (WebCore::RootInlineBox::topOverflow): (WebCore::RootInlineBox::bottomOverflow): (WebCore::RootInlineBox::leftOverflow): (WebCore::RootInlineBox::rightOverflow): (WebCore::RootInlineBox::selectionBottom): (WebCore::RootInlineBox::Overflow::Overflow): (WebCore::RootInlineBox::setVerticalSelectionPositions):
- rendering/SVGInlineFlowBox.h: (WebCore::SVGInlineFlowBox::SVGInlineFlowBox): (WebCore::SVGInlineFlowBox::height): (WebCore::SVGInlineFlowBox::setHeight):
- rendering/SVGInlineTextBox.cpp: (WebCore::SVGInlineTextBox::SVGInlineTextBox):
- rendering/SVGInlineTextBox.h: (WebCore::SVGInlineTextBox::height): (WebCore::SVGInlineTextBox::setHeight):
- rendering/SVGRootInlineBox.cpp: (WebCore::SVGRootInlineBox::layoutInlineBoxes):
- rendering/SVGRootInlineBox.h: (WebCore::SVGRootInlineBox::SVGRootInlineBox): (WebCore::SVGRootInlineBox::height): (WebCore::SVGRootInlineBox::setHeight):
- 5:32 PM Changeset in webkit [40801] by
-
- 4 edits in trunk/WebCore
Reviewed by Sam Weinig.
Document our Selection DOM extensions
(in preparation for re-writing Selection to work with ranges)
- page/DOMSelection.cpp: (WebCore::DOMSelection::type):
- page/DOMSelection.h:
- page/DOMSelection.idl:
- 5:31 PM Changeset in webkit [40800] by
-
- 2 edits in trunk/JavaScriptCore
2009-02-09 Gavin Barraclough <barraclough@apple.com>
Reviewed by Oliver Hunt.
Minor bugfix, incorrect check meant that subtraction causing integer overflow
would be missed on x86-64 JIT.
- jit/JITArithmetic.cpp: (JSC::JIT::compileBinaryArithOp):
- 5:28 PM Changeset in webkit [40799] by
-
- 3 edits in trunk/JavaScriptCore
2009-02-09 Gavin Barraclough <barraclough@apple.com>
Reviewed by Oliver Hunt.
A more sensible register allocation for x86-64.
When WREC was ported to x86-64 it stuck with the same register allocation as x86.
This requires registers to be reordered on entry into WREC generated code, since
argument passing is different on x86-64 and x86 (regparm(3)). This patch switches
x86-64 to use a native register allocation, that does not require argument registers
to be reordered.
- wrec/WRECGenerator.cpp: (JSC::WREC::Generator::generateEnter): (JSC::WREC::Generator::generateReturnSuccess): (JSC::WREC::Generator::generateReturnFailure):
- wrec/WRECGenerator.h:
- 5:10 PM Changeset in webkit [40798] by
-
- 2 edits in trunk/WebCore
Attempt to fix wx build
- WebCoreSources.bkl: change Selection to VisibleSelection
- 2:32 PM Changeset in webkit [40797] by
-
- 4 edits in trunk/WebCore
2009-02-06 Darin Fisher <darin@chromium.org>
Reviewed by Eric Seidel.
https://bugs.webkit.org/show_bug.cgi?id=23809
Return CanvasRenderingContext2D instead of DOMObject in IDL to avoid V8 #ifdefs
- bindings/scripts/CodeGeneratorJS.pm:
- dom/Document.idl:
- html/HTMLCanvasElement.idl:
- 2:17 PM Changeset in webkit [40796] by
-
- 2 edits in trunk/WebCore
Fix the gtk build by adding VisibleSelection and removing Selection.
- GNUmakefile.am:
- 2:09 PM Changeset in webkit [40795] by
-
- 7 edits in trunk/WebCore
2009-02-09 Dirk Schulze <krit@webkit.org>
Reviewed by Eric Seidel.
Transform the gradient instead of the context for most platforms and
transform the context after CGContextReplacePathWithStrokedPath for CG.
REGRESSION: SVG gradient transformation/BoundingBox can cause ugly stroke thickness
https://bugs.webkit.org/show_bug.cgi?id=23547
- platform/graphics/Gradient.h: (WebCore::Gradient::setGradientSpaceTransform): (WebCore::Gradient::gradientSpaceTransform):
- platform/graphics/cairo/GradientCairo.cpp: (WebCore::Gradient::platformGradient):
- platform/graphics/cg/GraphicsContextCG.cpp: (WebCore::GraphicsContext::fillPath): (WebCore::GraphicsContext::strokePath): (WebCore::GraphicsContext::fillRect):
- platform/graphics/qt/GraphicsContextQt.cpp: (WebCore::GraphicsContext::fillPath): (WebCore::GraphicsContext::strokePath): (WebCore::GraphicsContext::fillRect):
- platform/graphics/skia/GradientSkia.cpp: (WebCore::Gradient::platformGradient):
- svg/graphics/SVGPaintServerGradient.cpp: (WebCore::SVGPaintServerGradient::SVGPaintServerGradient): (WebCore::clipToTextMask): (WebCore::SVGPaintServerGradient::setup): (WebCore::SVGPaintServerGradient::teardown):
- 2:05 PM Changeset in webkit [40794] by
-
- 2 edits in trunk/WebCore
2009-02-09 Sam Weinig <sam@webkit.org>
Reviewed by David Hyatt.
Fix the highlight when inspecting inline elements.
- inspector/InspectorController.cpp: (WebCore::drawHighlightForBox): (WebCore::drawHighlightForLineBoxes): (WebCore::InspectorController::drawNodeHighlight):
- 1:43 PM Changeset in webkit [40793] by
-
- 66 edits2 moves in trunk
First pass at s/Selection/VisibleSelection
- 1:07 PM Changeset in webkit [40792] by
-
- 3 edits2 adds in trunk
WebCore:
2009-02-09 Dimitri Glazkov <Dimitri Glazkov>
Reviewed by Dave Hyatt.
https://bugs.webkit.org/show_bug.cgi?id=23806
Fix a regression crash where an empty src value and a "text/html" type
on an EMBED element did not finish ResourceRequest initialization due to
an early return.
Test: fast/loader/empty-embed-src-attribute.html
- loader/FrameLoader.cpp: (WebCore::FrameLoader::addExtraFieldsToRequest):
LayoutTests:
2009-02-09 Dimitri Glazkov <Dimitri Glazkov>
Reviewed by Dave Hyatt.
https://bugs.webkit.org/show_bug.cgi?id=23806
New test for the crash with an embed element with an empty src and
"text/html" type.
- fast/loader/empty-embed-src-attribute-expected.txt: Added.
- fast/loader/empty-embed-src-attribute.html: Added.
- 12:55 PM Changeset in webkit [40791] by
-
- 2 edits in trunk/WebCore
Reviewed by Eric Seidel.
https://bugs.webkit.org/show_bug.cgi?id=23816
Clean up RenderSVGRoot.cpp
Clean up RenderSVGRoot.cpp.
- rendering/RenderSVGRoot.cpp: (WebCore::RenderSVGRoot::paint): (WebCore::RenderSVGRoot::calcViewport):
- 12:41 PM Changeset in webkit [40790] by
-
- 2 edits in trunk
2009-02-09 Calvin Walton <calvin.walton@gmail.com>
Reviewed by Holger Freyther.
[Gtk] Fix build with recent autotools
Current versions of automake/libtool don't assume you want C++ enabled
by default any more, so explicitly check for a C++ compiler.
- configure.ac: Add AC_PROG_CXX macro
- 11:48 AM Changeset in webkit [40789] by
-
- 6 edits in trunk/WebCore
2009-02-09 Eric Carlson <eric.carlson@apple.com>
Reviewed by Antti Koivisto
https://bugs.webkit.org/show_bug.cgi?id=23737
Make it possible to control media element playback without knowing so many
internal implementation details.
- html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::togglePlayState): New, toggle between playing and paused state. (WebCore::HTMLMediaElement::beginScrubbing): New, pause as necessary for scrubbing mode. (WebCore::HTMLMediaElement::endScrubbing): New, resume playback if paused for scrubbing mode.
- html/HTMLMediaElement.h:
(WebCore::HTMLMediaElement::hasVideo): New, added so clients don't need to access MediaPlayer directly.
- html/HTMLVideoElement.h:
(WebCore::HTMLVideoElement::hasVideo): New.
- rendering/MediaControlElements.cpp: (WebCore::MediaControlPlayButtonElement::defaultEventHandler): Use new media element togglePlayState method. (WebCore::MediaControlTimelineElement::defaultEventHandler): Tell media element when scrubbing begins and ends so it can deal with pausing logic. Don't call setCurrentTime unless the time will change.
- rendering/RenderMedia.cpp: (WebCore::RenderMedia::updateControls): Ask media element if it is able to play instead of including internal logic here. (WebCore::RenderMedia::updateControlVisibility): Ditto.
- 11:37 AM Changeset in webkit [40788] by
-
- 5 edits in trunk/WebCore
2009-02-09 Eric Carlson <eric.carlson@apple.com>
Reviewed by Antti Koivisto
Change RenderPart and RenderPartObject constructors to take a Node*
instead of a HTMLFrameOwnerElement* since that is all then need.
- rendering/RenderPart.cpp: (WebCore::RenderPart::RenderPart): take Node* instead of HTMLFrameOwnerElement*
- rendering/RenderPart.h:
- rendering/RenderPartObject.cpp: (WebCore::RenderPartObject::RenderPartObject): take Node* instead of HTMLFrameOwnerElement*
- rendering/RenderPartObject.h:
- 11:28 AM Changeset in webkit [40787] by
-
- 5 edits in trunk/WebCore
- fix -Wmissing-prototypes builds
- editing/ReplaceSelectionCommand.cpp: (WebCore::isHeaderElement): Marked this function static. (WebCore::haveSameTagName): Ditto.
- editing/markup.cpp: (WebCore::isSpecialAncestorBlock): Ditto.
- platform/graphics/transforms/TransformationMatrix.cpp: (WebCore::makeMapBetweenRects): Removed unused function.
- platform/graphics/transforms/TransformationMatrix.h: Removed unused declaration of private member makeMapBetweenRects().
- 11:21 AM Changeset in webkit [40786] by
-
- 2 edits in trunk/WebKit/mac
2009-02-06 Anders Carlsson <andersca@apple.com>
Reviewed by Kevin Decker.
Fix crash when plug-in host dies.
- Plugins/Hosted/HostedNetscapePluginStream.mm: (WebKit::HostedNetscapePluginStream::didFail):
- 11:03 AM Changeset in webkit [40785] by
-
- 3 edits in trunk/WebCore
2009-02-09 Adam Treat <adam.treat@torchmobile.com>
Reviewed by Sam Weinig.
https://bugs.webkit.org/show_bug.cgi?id=23850
Code cleanup of HTMLParser class which was using a mix of m_* and bare
class member variable names which helps to obfuscate the code. Also
changed a few of the static helper functions to take a const pointer type
as they should not be modifying the node.
- html/HTMLParser.cpp: (WebCore::HTMLParser::HTMLParser): (WebCore::HTMLParser::~HTMLParser): (WebCore::HTMLParser::reset): (WebCore::HTMLParser::setCurrent): (WebCore::HTMLParser::parseToken): (WebCore::HTMLParser::parseDoctypeToken): (WebCore::isTableSection): (WebCore::isTablePart): (WebCore::isTableRelated): (WebCore::HTMLParser::insertNode): (WebCore::HTMLParser::handleError): (WebCore::HTMLParser::textCreateErrorCheck): (WebCore::HTMLParser::commentCreateErrorCheck): (WebCore::HTMLParser::headCreateErrorCheck): (WebCore::HTMLParser::bodyCreateErrorCheck): (WebCore::HTMLParser::framesetCreateErrorCheck): (WebCore::HTMLParser::formCreateErrorCheck): (WebCore::HTMLParser::isindexCreateErrorCheck): (WebCore::HTMLParser::noscriptCreateErrorCheck): (WebCore::HTMLParser::pCloserStrictCreateErrorCheck): (WebCore::HTMLParser::mapCreateErrorCheck): (WebCore::HTMLParser::getNode): (WebCore::HTMLParser::allowNestedRedundantTag): (WebCore::HTMLParser::processCloseTag): (WebCore::HTMLParser::isInline): (WebCore::HTMLParser::handleResidualStyleCloseTagAcrossBlocks): (WebCore::HTMLParser::reopenResidualStyleTags): (WebCore::HTMLParser::pushBlock): (WebCore::HTMLParser::popBlock): (WebCore::HTMLParser::popOneBlockCommon): (WebCore::HTMLParser::popOneBlock): (WebCore::HTMLParser::moveOneBlockToStack): (WebCore::HTMLParser::checkIfHasPElementInScope): (WebCore::HTMLParser::popInlineBlocks): (WebCore::HTMLParser::freeBlock): (WebCore::HTMLParser::createHead): (WebCore::HTMLParser::handleIsindex): (WebCore::HTMLParser::startBody): (WebCore::HTMLParser::finished): (WebCore::HTMLParser::reportErrorToConsole):
- html/HTMLParser.h:
- 10:38 AM Changeset in webkit [40784] by
-
- 2 edits in trunk/WebCore
Applying review comment on a second location.
- rendering/RenderText.cpp: (WebCore::RenderText::nextOffset): Use "ifdef BUILDING_ON_TIGER".
- 10:35 AM Changeset in webkit [40783] by
-
- 2 edits in trunk/WebCore
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=23845
editing/deleting/backward-deletion.html fails on Tiger
- rendering/RenderText.cpp: (WebCore::RenderText::previousOffset): (WebCore::RenderText::nextOffset): Work around a bug in older ICU versions by hardcoding narrow voiced marks.
- 7:49 AM Changeset in webkit [40782] by
-
- 2 edits in trunk/WebCore
Windows build fix
- WebCore.vcproj/WebCore.vcproj: Fix the XML syntax.
- 2:13 AM Changeset in webkit [40781] by
-
- 6 edits in trunk/WebCore
2009-02-09 Jian Li <jianli@chromium.org>
Reviewed by Alexey Proskuryakov.
Make WorkerMessagingProxy derive from two base proxy classes.
https://bugs.webkit.org/show_bug.cgi?id=23777
- bindings/js/WorkerScriptController.cpp: (WebCore::WorkerScriptController::evaluate):
- dom/Worker.cpp: (WebCore::Worker::terminate): (WebCore::Worker::hasPendingActivity):
- dom/WorkerContext.cpp: (WebCore::WorkerContext::reportException):
- dom/WorkerMessagingProxy.cpp: (WebCore::WorkerThreadActivityReportTask::performTask): (WebCore::WorkerMessagingProxy::postExceptionToWorkerObject): (WebCore::WorkerMessagingProxy::workerObjectDestroyed): (WebCore::WorkerMessagingProxy::terminateWorkerContext): (WebCore::WorkerMessagingProxy::confirmWorkerThreadMessage): (WebCore::WorkerMessagingProxy::reportPendingActivity): (WebCore::WorkerMessagingProxy::reportPendingActivityInternal): (WebCore::WorkerMessagingProxy::hasPendingActivity):
- dom/WorkerMessagingProxy.h:
- 2:00 AM Changeset in webkit [40780] by
-
- 4 edits2 adds in trunk/WebCore
2009-02-09 Jian Li <jianli@chromium.org>
Reviewed by Alexey Proskuryakov.
Introduce 2 base classes to split WorkerMessagingProxy.
https://bugs.webkit.org/show_bug.cgi?id=23776
- GNUmakefile.am:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- dom/WorkerContextProxy.h: Added. (WebCore::WorkerContextProxy::~WorkerContextProxy):
- dom/WorkerObjectProxy.h: Added. (WebCore::WorkerObjectProxy::~WorkerObjectProxy):
- 1:32 AM Changeset in webkit [40779] by
-
- 1 edit1 add in trunk/LayoutTests
Land results for a recently added test (https://bugs.webkit.org/show_bug.cgi?id=23601).
- fast/dom/Selection/getRangeAt-expected.txt: Added.
Feb 8, 2009:
- 11:15 PM Changeset in webkit [40778] by
-
- 2 edits4 adds in trunk
2009-02-08 David Hyatt <hyatt@apple.com>
Make sure that generated content is properly handled when content is moved from a block run-in
to an inline run-in.
Reviewed by Sam Weinig
Added fast/runin/002.html
- rendering/RenderBlock.cpp: (WebCore::RenderBlock::handleRunInChild):
- 10:03 PM Changeset in webkit [40777] by
-
- 2 edits in trunk/WebCore
2009-02-08 David Hyatt <hyatt@apple.com>
Fix for https://bugs.webkit.org/show_bug.cgi?id=23832, crash when inspecting an image using the
Web inspector.
Reviewed by Mark Rowe
- rendering/RenderObject.cpp: (WebCore::RenderObject::absoluteRectsForRange): (WebCore::RenderObject::absoluteQuadsForRange):
- 12:44 PM Changeset in webkit [40776] by
-
- 2 edits in trunk/WebCore
2009-02-08 Dirk Schulze <krit@webkit.org>
Unreviewed Qt build fix.
TransformationMatrix changes in r40761 broke QT build.
- platform/graphics/qt/GraphicsContextQt.cpp: (WebCore::GraphicsContext::getCTM): (WebCore::GraphicsContext::scale):
- 12:03 PM Changeset in webkit [40775] by
-
- 2 edits in trunk/WebCore
2009-02-08 Dirk Schulze <krit@webkit.org>
Reviewed by Holger Freyther.
This is a follow up of the last commit. It cleans up TransformationMatrix.h
and convert to a series of #elif.
- platform/graphics/transforms/TransformationMatrix.h:
- 11:49 AM Changeset in webkit [40774] by
-
- 4 edits in trunk/WebCore
2009-02-08 Gustavo Noronha Silva <Gustavo Noronha Silva>
Reviewed by Simon Fraser.
[CAIRO] build broken by TransformationMatrix rework
https://bugs.webkit.org/show_bug.cgi?id=23831
Fixed cairo build after the TransformationMatrix rework done in
revision 40761.
- platform/graphics/cairo/GraphicsContextCairo.cpp: (WebCore::GraphicsContext::getCTM): (WebCore::GraphicsContext::concatCTM):
- platform/graphics/cairo/TransformationMatrixCairo.cpp: (WebCore::TransformationMatrix::operator cairo_matrix_t):
- platform/graphics/transforms/TransformationMatrix.h:
- 1:49 AM QtWebKitFeatures45 edited by
- (diff)
- 1:00 AM Changeset in webkit [40773] by
-
- 4 edits in branches/Safari-6528
Versioning.
- 12:59 AM Changeset in webkit [40772] by
-
- 1 copy in tags/Safari-6528.13
New tag.