⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Feb 16, 2009:

7:38 PM Changeset in webkit [41036] by oliver@apple.com
  • 2 edits in trunk/JavaScriptCore

Roll out r41022 as it breaks qt and gtk builds

7:38 PM Changeset in webkit [41035] by Beth Dakin
  • 3 edits in trunk/WebCore

2009-02-16 Beth Dakin <Beth Dakin>

Reviewed by Sam Weinig.

Fix for <rdar://problem/6386623>

I made m_numParsedProperties and m_maxParsedProperties unsigned
instead of int, and then added an early return from addPropery() if
m_maxParsedProperties exceeds the max value.

  • css/CSSParser.cpp: (WebCore::CSSParser::addProperty): (WebCore::CSSParser::rollbackLastProperties): (WebCore::CSSParser::clearProperties): (WebCore::CSSParser::createFontFaceRule): (WebCore::CSSParser::deleteFontFaceOnlyValues):
  • css/CSSParser.h:
7:36 PM Changeset in webkit [41034] by justin.garcia@apple.com
  • 7 edits
    1 add
    3 deletes in trunk

WebCore:

2009-02-16 Justin Garcia <justin.garcia@apple.com>

Reviewed by Mark Rowe.

https://bugs.webkit.org/show_bug.cgi?id=16309
HTML5: The third execCommand argument for insert{un}orderedlist should be ignored


When we originally implemented this command, MSDN documentation said that IE set the
id attribute of inserted lists to the third argument to execCommand, but IE doesn't
do this nor do any other browsers.

  • editing/EditorCommand.cpp: (WebCore::executeInsertOrderedList): (WebCore::executeInsertUnorderedList):
  • editing/IndentOutdentCommand.cpp: (WebCore::IndentOutdentCommand::outdentParagraph):
  • editing/InsertListCommand.cpp: (WebCore::InsertListCommand::insertList): (WebCore::InsertListCommand::InsertListCommand): (WebCore::InsertListCommand::doApply):
  • editing/InsertListCommand.h: (WebCore::InsertListCommand::create):

LayoutTests:

2009-02-16 Justin Garcia <justin.garcia@apple.com>

Reviewed by Mark Rowe.


https://bugs.webkit.org/show_bug.cgi?id=16309
HTML5: The third execCommand argument for insert{un}orderedlist should be ignored

  • editing/execCommand/insert-list-with-id-expected.txt: Added.
  • editing/execCommand/insert-list-with-id.html:
  • platform/mac/editing/execCommand/insert-list-with-id-expected.checksum: Removed.
  • platform/mac/editing/execCommand/insert-list-with-id-expected.png: Removed.
  • platform/mac/editing/execCommand/insert-list-with-id-expected.txt: Removed.
6:59 PM Changeset in webkit [41033] by kov@webkit.org
  • 2 edits in trunk/WebKitTools

2009-02-16 Gustavo Noronha Silva <Gustavo Noronha Silva>

Reviewed by Adam Roben

Actually use the installation prefix defined in WebKitInstallationPrefix,
in autotools builds.

  • Scripts/webkitdirs.pm:
6:00 PM Changeset in webkit [41032] by mrowe@apple.com
  • 4 edits in branches/Safari-6528

Versioning.

5:59 PM Changeset in webkit [41031] by mrowe@apple.com
  • 1 copy in tags/Safari-6528.15.1

New tag.

5:56 PM Changeset in webkit [41030] by mrowe@apple.com
  • 4 edits in branches/Safari-6528

Versioning.

5:56 PM Changeset in webkit [41029] by mrowe@apple.com
  • 3 edits
    4 adds in branches/Safari-6528

Merge r41027.

4:40 PM Changeset in webkit [41028] by weinig@apple.com
  • 5 edits in trunk

JavaScriptCore:

2009-02-16 Sam Weinig <sam@webkit.org>

Reviewed by Geoffrey Garen.

Fix for <rdar://problem/6468156>
REGRESSION (r36779): Adding link, images, flash in TinyMCE blocks entire page (21382)

No performance regression.

  • runtime/Arguments.cpp: (JSC::Arguments::fillArgList): Add codepath for when the "length" property has been overridden.

LayoutTests:

2009-02-16 Sam Weinig <sam@webkit.org>

Reviewed by Geoffrey Garen.

Add tests for <rdar://problem/6468156>
REGRESSION (r36779): Adding link, images, flash in TinyMCE blocks entire page (21382)

  • fast/js/function-apply-expected.txt:
  • fast/js/resources/function-apply.js: Add cases covering setting arugments.length and Array.length explicitly or implicitly using Array.prototype.unshift.
3:56 PM Changeset in webkit [41027] by mitz@apple.com
  • 3 edits
    1 copy
    3 adds in trunk

WebCore:

Reviewed by Geoffrey Garen.

  • fix <rdar://problem/6561077> REGRESSION (r39634): Unable to select an item in stocks widget with the mouse

Test: platform/mac/fast/events/pointer-events-dashboard.html

  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::applyProperty): Do not apply the pointer-events property in Dashboard backwards compatibility mode, in order to work around misuse of that property by the Stocks widget.

LayoutTests:

Reviewed by Geoffrey Garen.

  • test for <rdar://problem/6561077> REGRESSION (r39634): Unable to select an item in stocks widget with the mouse
  • platform/mac/fast/events/pointer-events-dashboard-expected.checksum: Added.
  • platform/mac/fast/events/pointer-events-dashboard-expected.png: Added.
  • platform/mac/fast/events/pointer-events-dashboard-expected.txt: Added.
  • platform/mac/fast/events/pointer-events-dashboard.html: Copied from LayoutTests/fast/events/pointer-events.html.
3:33 PM Changeset in webkit [41026] by justin.garcia@apple.com
  • 4 edits
    3 adds
    3 deletes in trunk

WebCore:

2009-02-16 Justin Garcia <justin.garcia@apple.com>

Reviewed by Eric Seidel.

https://bugs.webkit.org/show_bug.cgi?id=15381
execCommand justify modifies the contentEditable node

  • editing/CompositeEditCommand.cpp: (WebCore::CompositeEditCommand::moveParagraphContentsToNewBlockIfNecessary): Avoid modifying not just the body element, but any root editable element.

LayoutTests:

2009-02-16 Justin Garcia <justin.garcia@apple.com>

Reviewed by Eric Seidel.


https://bugs.webkit.org/show_bug.cgi?id=15381
execCommand justify modifies the contentEditable node

  • editing/execCommand/15381-expected.txt: Added.
  • editing/execCommand/15381.html: Added.


Made this test cross platform and changed it to reflect the fix:

  • editing/execCommand/5062376-expected.txt: Added.
  • editing/execCommand/5062376.html:
  • platform/mac/editing/execCommand/5062376-expected.checksum: Removed.
  • platform/mac/editing/execCommand/5062376-expected.png: Removed.
  • platform/mac/editing/execCommand/5062376-expected.txt: Removed.
3:19 PM Changeset in webkit [41025] by Chris Fleizach
  • 3 edits
    2 adds in trunk

Bug 23979: AX: alt tag not returned for <input type="image">
https://bugs.webkit.org/show_bug.cgi?id=23979

2:36 PM Changeset in webkit [41024] by mrowe@apple.com
  • 2 edits in tags/Safari-6530/JavaScriptCore

Merge r41023.

2:23 PM Changeset in webkit [41023] by mrowe@apple.com
  • 2 edits in trunk/JavaScriptCore

Build fix.

2:15 PM Changeset in webkit [41022] by oliver@apple.com
  • 2 edits in trunk/JavaScriptCore

Bug 23787: Allow JIT to generate SSE2 code if using GCC
<https://bugs.webkit.org/show_bug.cgi?id=23787>

Provided by Csaba Osztrogonac
Reviewed by Oliver Hunt

GCC version of the cpuid check.

2:06 PM Changeset in webkit [41021] by kevino@webkit.org
  • 2 edits in trunk/WebCore

Reviewed by Kevin Ollivier.

The ref data is not properly set unless we use the CreateMatrix function.

https://bugs.webkit.org/show_bug.cgi?id=23978

1:57 PM Changeset in webkit [41020] by mitz@apple.com
  • 4 edits in trunk/WebCore

Reviewed by John Sullivan.

  • fix <rdar://problem/6516829> FontPlatformData constructor passes NULL to CTFontCopyGraphicsFont and CTFontGetPlatformFont
  • platform/graphics/FontCache.cpp: (WebCore::FontDataCacheKeyTraits::emptyValue): Changed to use the FontPlatformData(float, bool, bool) constructor.
  • platform/graphics/mac/FontCacheMac.mm: (WebCore::FontCache::createFontPlatformData): Changed to pass a valid NSFont to the FontPlatformData constructor, instead of implicitly passing 0 and then calling setFont().
  • platform/graphics/mac/FontPlatformData.h: Made the NSFont parameter of the constructor mandatory.
2:57 AM Changeset in webkit [41019] by Simon Hausmann
  • 2 edits in trunk/WebKit/qt

2009-02-16 Simon Hausmann <simon.hausmann@nokia.com>

Reviewed by Tor Arne Vestbø.

Avoid loading plugins when they're disabled in the settings.

Feb 15, 2009:

1:39 PM Changeset in webkit [41018] by ddkilzer@apple.com
  • 5 edits in trunk/WebCore

Move duplicate caretWidth constants to RenderObject.h

Reviewed by Dan Bernstein.

No test since no change in behavior.

  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::localCaretRect): Removed caretWidth.
  • rendering/RenderBox.cpp: (WebCore::RenderBox::localCaretRect): Ditto.
  • rendering/RenderObject.h: Added caretWidth definition.
  • rendering/RenderText.cpp: (WebCore::RenderText::localCaretRect): Removed caretWidth.
Note: See TracTimeline for information about the timeline view.