Context Navigation

platform/graphics/chromium/UniscribeHelper.cpp: (WebCore::UniscribeHelper::adjustSpaceAdvances): Make the UniscribeHelper::adjustSpaceAdvances() function treat all characters in the treatAsSpace() function (e.g. U+0020, U+000A, U+000D, U+00A0) as whitespaces, so does when Chromium renders a simple text.

LayoutTests:
2009-02-21 Hironori Bono <hbono@chromium.org>

Reviewed by Alexey Proskuryakov.

https://bugs.webkit.org/show_bug.cgi?id=23786
[Chromium] line-break characters in a complex text are treated as zero-width spaces

Added tests which verifies line-break characters in a complex text are treated as defined in CSS 2.1.

fast/text/international/bidi-linebreak-001.html: Added.
fast/text/international/bidi-linebreak-002.html: Added.
fast/text/international/bidi-linebreak-003.html: Added.
platform/mac/fast/text/international/bidi-linebreak-001-expected.checksum: Added.
platform/mac/fast/text/international/bidi-linebreak-001-expected.png: Added.
platform/mac/fast/text/international/bidi-linebreak-001-expected.txt: Added.
platform/mac/fast/text/international/bidi-linebreak-002-expected.checksum: Added.
platform/mac/fast/text/international/bidi-linebreak-002-expected.png: Added.
platform/mac/fast/text/international/bidi-linebreak-002-expected.txt: Added.
platform/mac/fast/text/international/bidi-linebreak-003-expected.checksum: Added.
platform/mac/fast/text/international/bidi-linebreak-003-expected.png: Added.
platform/mac/fast/text/international/bidi-linebreak-003-expected.txt: Added.

Feb 20, 2009:

6:05 PM Changeset in webkit [41121] by kdecker@apple.com

2 edits in trunk/WebKit/mac

Reviewed by andersca.

<rdar://problem/6496140> Safari sometimes hangs in WKSetMetadataURL for several seconds after downloading a file

Spawn a background thread for WKSetMetadataURL because this function will not return until mds has journaled the data
we are trying to set. Depending on what other I/O is going on, it can take some time.

Misc/WebNSFileManagerExtras.m: Import pthread.h and FoundationExtras.h (setMetaData): Added. Calls WKSetMetadataURL(). (-[NSFileManager _webkit_setMetadataURL:referrer:atPath:]): Call setMetaData on a background thread

4:15 PM Changeset in webkit [41120] by jchaffraix@webkit.org

15 edits in trunk/WebCore

2009-02-20 Julien Chaffraix <jchaffraix@webkit.org>

Reviewed by Alexey Proskuryakov.

Bug 23940: Use Document::createElement(const QualifiedName&, bool) when creating a known element inside WebCore

Document::createElement(const QualifiedName&, bool) does not check for the prefix as opposed the the one taking an AtomicString
or Document::createElementNS. This is perfectly fine internally because we know the type of element created and the check is
unneeded.

It also removes the use of an ExceptionCode argument which was here only to check that the prefix check was fine. Finally it
enables us to use some generated QualifiedName.

bindings/js/JSOptionConstructor.cpp: (WebCore::constructHTMLOptionElement):
dom/Document.cpp: (WebCore::Document::setTitle):
dom/XMLTokenizer.cpp: (WebCore::createXHTMLParserErrorHeader): (WebCore::XMLTokenizer::insertErrorMessageBlock):
editing/CompositeEditCommand.cpp: (WebCore::createBlockPlaceholderElement):
editing/htmlediting.cpp: (WebCore::createTabSpanElement):
html/HTMLSelectElement.cpp: (WebCore::HTMLSelectElement::setLength):
loader/FTPDirectoryDocument.cpp: (WebCore::FTPDirectoryTokenizer::appendEntry): (WebCore::FTPDirectoryTokenizer::createTDForFilename): (WebCore::FTPDirectoryTokenizer::loadDocumentTemplate): (WebCore::FTPDirectoryTokenizer::createBasicDocument):
loader/ImageDocument.cpp: (WebCore::ImageDocument::createDocumentStructure):
loader/MediaDocument.cpp: (WebCore::MediaTokenizer::createDocumentStructure):
loader/PluginDocument.cpp: (WebCore::PluginTokenizer::createDocumentStructure):
loader/TextDocument.cpp: (WebCore::TextTokenizer::write):
page/Frame.cpp: (WebCore::Frame::selectionComputedStyle): (WebCore::Frame::styleForSelectionStart): Document::createElement(const AtomicString&, ...) to Document::createElement(const QualifiedName&, ...) switch.

xml/XPathFunctions.cpp: (WebCore::XPath::FunLang::evaluate): Re-use langAttr instead of creating a new attribute.
page/DragController.cpp: (WebCore::documentFragmentFromDragData): Use the HTMLAnchorElement directly to get rid of the static cast.

1:19 PM Changeset in webkit [41119] by Dimitri Glazkov

2 edits in trunk/WebCore

2009-02-19 Dimitri Glazkov <Dimitri Glazkov>

Reviewed by Eric Seidel.

https://bugs.webkit.org/show_bug.cgi?id=24060
Fix up to accommodate for CanvasPixelArray return.

platform/graphics/skia/ImageBufferSkia.cpp: (WebCore::ImageBuffer::getImageData): Added an extra data() to call. (WebCore::ImageBuffer::putImageData): Ditto.

1:12 PM Changeset in webkit [41118] by eric.carlson@apple.com

3 edits in trunk/WebCore

2009-02-19 Eric Carlson <eric.carlson@apple.com>

Simon Fraser

https://bugs.webkit.org/show_bug.cgi?id=24042
Bug 24042: MediaPlayer should cache plug-in proxy

The changes in https://bugs.webkit.org/show_bug.cgi?id=23917 assume that
MediaPlayer will always have created the private media player object before
the plug-in is instantiated and calls back with the proxy object. This is not
true on all platforms because of threading latency, so MediaPlayer should
cache the plug-in proxy so it can pass it to the media engine at a later time.

platform/graphics/MediaPlayer.cpp: (WebCore::NullMediaPlayerPrivate::setPoster): Null media engine implementation of proxy methods. (WebCore::NullMediaPlayerPrivate::deliverNotification): Ditto. (WebCore::NullMediaPlayerPrivate::setMediaPlayerProxy): Ditto. (WebCore::MediaPlayer::MediaPlayer): Initialize m_playerProxy. (WebCore::MediaPlayer::load): Pass m_playerProxy to newly created engine. (WebCore::MediaPlayer::setMediaPlayerProxy): Cache m_playerProxy.
platform/graphics/MediaPlayer.h: Declare m_playerProxy.

1:10 PM Changeset in webkit [41117] by eric.carlson@apple.com

3 edits in trunk/WebCore

2009-02-20 Eric Carlson <eric.carlson@apple.com>

Simon Fraser.

https://bugs.webkit.org/show_bug.cgi?id=24063
Make it possible for a port to require a user gesture to play/pause an <audio> or <video> element

html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::HTMLMediaElement): Rename m_loadRestrictions to m_Restrictions. Initialize m_internalCall. (WebCore::HTMLMediaElement::loadTimerFired): Increment m_internalCall around call to load(). (WebCore::HTMLMediaElement::load): Call loadInternal if restrictions check out. (WebCore::HTMLMediaElement::loadInternal): New, guts of old load() (WebCore::HTMLMediaElement::setNetworkState): Fix bug introduced in r40943 (WebCore::HTMLMediaElement::play): Call playInternal if restrictions check out. (WebCore::HTMLMediaElement::playInternal): New, guts of old play() (WebCore::HTMLMediaElement::pause): Call pauseInternal if restrictions check out. (WebCore::HTMLMediaElement::pauseInternal): New, guts of old pause() (WebCore::HTMLMediaElement::togglePlayState): Call playInternal/pauseInternal (WebCore::HTMLMediaElement::deliverNotification): Remove unnecessary white space.
html/HTMLMediaElement.h: Rename m_loadRestrictions to m_Restrictions, add m_internalCall, add RequireUserGestureRateChangeRestriction.

1:08 PM Changeset in webkit [41116] by darin@chromium.org

2 edits in trunk/WebCore

2009-02-20 Darin Fisher <darin@chromium.org>

Fix build bustage in FileSystemWin.cpp.

Need to return CString() instead of 0 since there are now two CString
constructors that take a pointer type.

platform/win/FileSystemWin.cpp: (WebCore::openTemporaryFile):

12:55 PM Changeset in webkit [41115] by Dimitri Glazkov

3 edits in trunk/WebCore

2009-02-20 Dimitri Glazkov <Dimitri Glazkov>

Reviewed by Sam Weinig.

https://bugs.webkit.org/show_bug.cgi?id=23999
Change license headers to accurately reflect code history.

platform/ContentType.cpp:
platform/ContentType.h:

12:52 PM Changeset in webkit [41114] by weinig@apple.com

2 edits in trunk/LayoutTests

2009-02-20 Sam Weinig <sam@webkit.org>

fast/dom/SelectorAPI/resig-SelectorsAPI-test-expected.txt: Update results.

12:36 PM Changeset in webkit [41113] by Dimitri Glazkov

13 edits
2 adds in trunk/WebCore

2009-02-18 Dimitri Glazkov <Dimitri Glazkov>

Reviewed by Antti Koivisto.

https://bugs.webkit.org/show_bug.cgi?id=23999
Split off MIME type parsing into its own class.

GNUmakefile.am: Added ContentType sources.
WebCore.pro: Ditto.
WebCore.scons: Ditto.
WebCore.vcproj/WebCore.vcproj: Ditto.
WebCore.xcodeproj/project.pbxproj: Ditto.
WebCoreSources.bkl: Ditto.
html/HTMLMediaElement.cpp: Changed to use ContentType. (WebCore::HTMLMediaElement::selectMediaURL):
platform/ContentType.cpp: Added. (WebCore::ContentType::ContentType): (WebCore::ContentType::parameter): (WebCore::ContentType::type):
platform/ContentType.h: Added. (WebCore::ContentType::raw):
platform/MIMETypeRegistry.cpp:
platform/MIMETypeRegistry.h:
platform/graphics/MediaPlayer.cpp: (WebCore::MediaPlayer::load):
rendering/style/ContentData.h: Renamed ContentType to StyleContentType.
rendering/style/RenderStyleConstants.h: Ditto. (WebCore::):

12:32 PM Changeset in webkit [41112] by zecke@webkit.org

3 edits in trunk/WebCore

2009-02-20 Holger Hans Peter Freyther <zecke@selfish.org>

Unreviewed build fix.

Use CString() instead of 0.

platform/gtk/FileSystemGtk.cpp: (WebCore::openTemporaryFile):
platform/qt/FileSystemQt.cpp: (WebCore::openTemporaryFile):

12:10 PM Changeset in webkit [41111] by kov@webkit.org

2 edits in trunk/WebCore

2009-02-20 Gustavo Noronha Silva <Gustavo Noronha Silva>

Reviewed by Holger Freyther.

When dealing with local files, use a path instead of an URI. GFile
has problems decoding URIs with percent signs on them.

platform/network/soup/ResourceHandleSoup.cpp: (WebCore::ResourceHandle::startGio):

11:41 AM Changeset in webkit [41110] by kov@webkit.org

2 edits in trunk/WebCore

2009-02-20 Gustavo Noronha Silva <Gustavo Noronha Silva>

Reviewed by Holger Freyther.

Protect the ResourceHandle instance from being destroyed by
didReceiveData inside the GIO readCallback call, so that
cancelling caused by scripts is handled correctly.

platform/network/soup/ResourceHandleSoup.cpp: (WebCore::readCallback):

11:27 AM Changeset in webkit [41109] by ddkilzer@apple.com

2 edits in trunk/WebCore

Make IconDatabaseNone.cpp compile with -Wunused and pass check-for-exit-time-destructors

Reviewed by Sam Weinig.

loader/icon/IconDatabaseNone.cpp: (WebCore::IconDatabase::defaultDatabaseFilename): Use DEFINE_STATIC_LOCAL(). (WebCore::IconDatabase::open): Commented out unused parameter. (WebCore::IconDatabase::setPrivateBrowsingEnabled): Ditto. (WebCore::IconDatabase::iconForPageURL): Ditto. (WebCore::IconDatabase::iconURLForPageURL): Ditto. (WebCore::IconDatabase::defaultIcon): Ditto. (WebCore::IconDatabase::retainIconForPageURL): Ditto. (WebCore::IconDatabase::releaseIconForPageURL): Ditto. (WebCore::IconDatabase::setIconDataForIconURL): Ditto. (WebCore::IconDatabase::setIconURLForPageURL): Ditto. (WebCore::IconDatabase::setEnabled): Ditto. (WebCore::IconDatabase::pageURLMappingCount): Added stub. (WebCore::IconDatabase::retainedPageURLCount): Ditto. (WebCore::IconDatabase::iconRecordCount): Ditto. (WebCore::IconDatabase::iconRecordCountWithData): Ditto.

8:27 AM Changeset in webkit [41108] by ddkilzer@apple.com

30 edits in trunk/WebKitSite

Bug 23983: Remove illegal HTML tags from Sunspider web pages

<https://bugs.webkit.org/show_bug.cgi?id=23983>

Reviewed by Alexey Proskuryakov.

perf/sunspider-0.9/3d-cube.html: Removed </link> tag.
perf/sunspider-0.9/3d-morph.html: Ditto.
perf/sunspider-0.9/3d-raytrace.html: Ditto.
perf/sunspider-0.9/access-binary-trees.html: Ditto.
perf/sunspider-0.9/access-fannkuch.html: Ditto.
perf/sunspider-0.9/access-nbody.html: Ditto.
perf/sunspider-0.9/access-nsieve.html: Ditto.
perf/sunspider-0.9/bitops-3bit-bits-in-byte.html: Ditto.
perf/sunspider-0.9/bitops-bits-in-byte.html: Ditto.
perf/sunspider-0.9/bitops-bitwise-and.html: Ditto.
perf/sunspider-0.9/bitops-nsieve-bits.html: Ditto.
perf/sunspider-0.9/controlflow-recursive.html: Ditto.
perf/sunspider-0.9/crypto-aes.html: Ditto.
perf/sunspider-0.9/crypto-md5.html: Ditto.
perf/sunspider-0.9/crypto-sha1.html: Ditto.
perf/sunspider-0.9/date-format-tofte.html: Ditto.
perf/sunspider-0.9/date-format-xparb.html: Ditto.
perf/sunspider-0.9/math-cordic.html: Ditto.
perf/sunspider-0.9/math-partial-sums.html: Ditto.
perf/sunspider-0.9/math-spectral-norm.html: Ditto.
perf/sunspider-0.9/regexp-dna.html: Ditto.
perf/sunspider-0.9/string-base64.html: Ditto.
perf/sunspider-0.9/string-fasta.html: Ditto.
perf/sunspider-0.9/string-tagcloud.html: Ditto.
perf/sunspider-0.9/string-unpack-code.html: Ditto.
perf/sunspider-0.9/string-validate-input.html: Ditto.
perf/sunspider-0.9/sunspider-driver.html: Ditto.
perf/sunspider-0.9/sunspider-results.html: Removed </link> and </input> tags.
perf/sunspider-0.9/sunspider.html: Removed </link> tag.

8:23 AM Changeset in webkit [41107] by ddkilzer@apple.com

2 edits in trunk/WebCore

Add comment to generated code when shadowing a built-in object

Reviewed by Sam Weinig.

bindings/scripts/CodeGeneratorJS.pm: Added comment to generated code output.

7:34 AM Changeset in webkit [41106] by darin@chromium.org

2 edits in trunk/WebCore

2009-02-20 Avi Drissman <avi@chromium.org>

Reviewed by Eric Seidel.

https://bugs.webkit.org/show_bug.cgi?id=24036
Keyboard events need disambiguation on the Linux platform too.

platform/chromium/PlatformKeyboardEventChromium.cpp: (WebCore::PlatformKeyboardEvent::disambiguateKeyDownEvent):

7:31 AM Changeset in webkit [41105] by darin@chromium.org

3 edits in trunk/WebCore

2009-02-19 Darin Fisher <darin@chromium.org>

Reviewed by Eric Seidel.

https://bugs.webkit.org/show_bug.cgi?id=24046

Several improvements to CString:
1- Make it possible to initialize a CString from a CStringBuffer
2- Make it possible to get a CStringBuffer from a CString
3- Change CStringBuffer::data() to return a const pointer to ward off mutation
4- Remove unused releaseBuffer() methods.
5- Make CStringBuffer::create() private to force consumers to get a CStringBuffer from a CString.

platform/text/CString.cpp: (WebCore::CString::init): (WebCore::CString::mutableData): (WebCore::CString::newUninitialized): (WebCore::CString::copyBufferIfNeeded):
platform/text/CString.h: (WebCore::CStringBuffer::data): (WebCore::CStringBuffer::length): (WebCore::CStringBuffer::create): (WebCore::CStringBuffer::mutableData): (WebCore::CString::CString): (WebCore::CString::buffer):

5:25 AM Changeset in webkit [41104] by kov@webkit.org

2 edits in trunk/JavaScriptCore

2009-02-20 Gustavo Noronha Silva <Gustavo Noronha Silva>

Unreviewed build fix after r41100.

GNUmakefile.am:

5:14 AM Changeset in webkit [41103] by oliver@apple.com

7 edits in trunk

<rdar://problem/6606660> 2==null returns true in 64bit jit

Reviewed by Mark Rowe

Code for op_eq_null and op_neq_null was incorrectly performing
a 32bit compare, which truncated the type tag from an integer
immediate, leading to incorrect behaviour.

Note: See TracTimeline for information about the timeline view.

Download in other formats:

RSS Feed