⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Feb 23, 2009:

11:47 PM Changeset in webkit [41170] by Antti Koivisto
  • 2 edits in trunk/WebCore

2009-02-23 Antti Koivisto <Antti Koivisto>

Reviewed by Oliver Hunt.

<rdar://problem/6613796> Extended text codecs registered on webview creation

Comparing a text encoding with string "GBK" ended up constructing
TextEncoding("GBK") which in turn initialized all extended
text codecs.

  • platform/text/TextCodecICU.cpp: (WebCore::TextCodecICU::decode):
8:29 PM Changeset in webkit [41169] by weinig@apple.com
  • 2 edits in trunk/WebCore

2009-02-23 Sam Weinig <​sam@webkit.org>

Fix Qt build.

  • bridge/qt/qt_runtime.cpp: (JSC::Bindings::valueRealType):
7:58 PM Changeset in webkit [41168] by ggaren@apple.com
  • 22 edits in trunk/JavaScriptCore

2009-02-23 Geoffrey Garen <​ggaren@apple.com>

Reviewed by Sam Weinig.

Next step in splitting JIT functionality out of the Interpreter class:
Moved vptr storage from Interpreter to JSGlobalData, so it could be shared
between Interpreter and JITStubs, and moved the *Trampoline JIT stubs
into the JITStubs class. Also added a VPtrSet class to encapsulate vptr
hacks during JSGlobalData initialization.


SunSpider says 0.4% faster. Meh.

  • JavaScriptCore.exp:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • interpreter/Interpreter.cpp: (JSC::Interpreter::Interpreter): (JSC::Interpreter::tryCacheGetByID): (JSC::Interpreter::privateExecute):
  • interpreter/Interpreter.h:
  • jit/JIT.cpp: (JSC::JIT::privateCompileMainPass): (JSC::JIT::privateCompile): (JSC::JIT::privateCompileCTIMachineTrampolines):
  • jit/JIT.h: (JSC::JIT::compileCTIMachineTrampolines):
  • jit/JITCall.cpp: (JSC::JIT::compileOpCall): (JSC::JIT::compileOpCallSlowCase):
  • jit/JITPropertyAccess.cpp: (JSC::JIT::privateCompilePatchGetArrayLength):
  • jit/JITStubs.cpp: (JSC::JITStubs::JITStubs): (JSC::JITStubs::tryCacheGetByID): (JSC::JITStubs::cti_vm_dontLazyLinkCall): (JSC::JITStubs::cti_op_get_by_val): (JSC::JITStubs::cti_op_get_by_val_byte_array): (JSC::JITStubs::cti_op_put_by_val): (JSC::JITStubs::cti_op_put_by_val_array): (JSC::JITStubs::cti_op_put_by_val_byte_array): (JSC::JITStubs::cti_op_is_string):
  • jit/JITStubs.h: (JSC::JITStubs::ctiArrayLengthTrampoline): (JSC::JITStubs::ctiStringLengthTrampoline): (JSC::JITStubs::ctiVirtualCallPreLink): (JSC::JITStubs::ctiVirtualCallLink): (JSC::JITStubs::ctiVirtualCall):
  • runtime/ArrayPrototype.cpp: (JSC::arrayProtoFuncPop): (JSC::arrayProtoFuncPush):
  • runtime/FunctionPrototype.cpp: (JSC::functionProtoFuncApply):
  • runtime/JSArray.h: (JSC::isJSArray):
  • runtime/JSByteArray.h: (JSC::asByteArray): (JSC::isJSByteArray):
  • runtime/JSCell.h:
  • runtime/JSFunction.h:
  • runtime/JSGlobalData.cpp: (JSC::VPtrSet::VPtrSet): (JSC::JSGlobalData::JSGlobalData): (JSC::JSGlobalData::create): (JSC::JSGlobalData::sharedInstance):
  • runtime/JSGlobalData.h:
  • runtime/JSString.h: (JSC::isJSString):
  • runtime/Operations.h: (JSC::jsLess): (JSC::jsLessEq):
  • wrec/WREC.cpp: (JSC::WREC::Generator::compileRegExp):
6:57 PM Changeset in webkit [41167] by mrowe@apple.com
  • 1 edit in tags/Safari-6530.1/WebCore/page/AccessibilityTable.cpp

Work around <rdar://problem/6610801>.

5:47 PM Changeset in webkit [41166] by mrowe@apple.com
  • 5 edits
    1 add in tags/Safari-6530.1/WebKit/mac

Merge r41148.

5:46 PM Changeset in webkit [41165] by mrowe@apple.com
  • 1 add in tags/Safari-6530.1/WebKit/mac/Plugins/Hosted/WebTextInputWindowController.m

Merge r41124.

5:46 PM Changeset in webkit [41164] by mrowe@apple.com
  • 1 edit in tags/Safari-6530.1/WebKit/mac/ChangeLog

Merge r41124.

5:45 PM Changeset in webkit [41163] by mrowe@apple.com
  • 3 edits in tags/Safari-6530.1/WebKit

Merge r41123.

5:21 PM Changeset in webkit [41162] by jchaffraix@webkit.org
  • 5 edits
    2 adds in trunk

WebCore:

2009-02-23 Julien Chaffraix <​jchaffraix@webkit.org>

Reviewed by Darin Adler.

Bug 23956: Safari crashes when cloneNode fails (cloning a XML element with an invalid nodeName)

The crash occurred because Document::cloneNode would call Document::createElementNS. Unfortunately
element created with createElement could have a wrong nodeName (createElement sets the string as the
localName without checking for a prefix).

The fix is to call Document::createElement(const QualifiedName&, bool) that will not do any checks on the QualifiedName
and will always succeed.
Also rolled-out the HTMLElement specialisation of clonedNode as it was equivalent to what is done now (added an ASSERT
to ensure that).

Test: fast/dom/cloneNode.html

  • dom/Element.cpp: (WebCore::Element::cloneNode): Call createElement(const QualifiedName&, bool) instead of createElementNS as it will always return an element.
  • html/HTMLElement.cpp:
  • html/HTMLElement.h: Removed HTMLElement::clonedNode as it is equivalent to what is now done.

LayoutTests:

2009-02-23 Julien Chaffraix <​jchaffraix@webkit.org>

Reviewed by Darin Adler.

Test for bug 23956: Safari crashes when cloneNode fails (cloning a XML element with an invalid nodeName)

  • fast/dom/cloneNode-expected.txt: Added.
  • fast/dom/cloneNode.html: Added.
4:53 PM Changeset in webkit [41161] by mrowe@apple.com
  • 1 copy in tags/Safari-6530.1

New tag.

4:29 PM Changeset in webkit [41160] by oliver@apple.com
  • 2 edits in trunk/JavaScriptCore

Bug 23787: Allow JIT to generate SSE2 code if using GCC
<​https://bugs.webkit.org/show_bug.cgi?id=23787>

Reviewed by Oliver Hunt
Contributed by Csaba Osztrogonac

GCC version of the cpuid check.

4:04 PM Changeset in webkit [41159] by Dimitri Glazkov
  • 1 edit
    12 adds in trunk/WebCore

2009-02-23 Dimitri Glazkov <Dimitri Glazkov>

Reviewed by Eric Seidel.

​https://bugs.webkit.org/show_bug.cgi?id=24109
Upstream V8 Script abstractions, all except ScriptController.

  • bindings/v8/ScriptCachedFrameData.h: Added. (WebCore::ScriptCachedFrameData::ScriptCachedFrameData): (WebCore::ScriptCachedFrameData::~ScriptCachedFrameData): (WebCore::ScriptCachedFrameData::restore): (WebCore::ScriptCachedFrameData::clear): (WebCore::ScriptCachedFrameData::domWindow):
  • bindings/v8/ScriptCallFrame.cpp: Added. (WebCore::ScriptCallFrame::ScriptCallFrame): (WebCore::ScriptCallFrame::~ScriptCallFrame): (WebCore::ScriptCallFrame::argumentAt):
  • bindings/v8/ScriptCallFrame.h: Added. (WebCore::ScriptCallFrame::functionName): (WebCore::ScriptCallFrame::sourceURL): (WebCore::ScriptCallFrame::lineNumber): (WebCore::ScriptCallFrame::argumentCount):
  • bindings/v8/ScriptCallStack.cpp: Added. (WebCore::ScriptCallStack::ScriptCallStack): (WebCore::ScriptCallStack::~ScriptCallStack): (WebCore::ScriptCallStack::at):
  • bindings/v8/ScriptCallStack.h: Added. (WebCore::ScriptCallStack::size):
  • bindings/v8/ScriptInstance.cpp: Added. (WebCore::V8ScriptInstance::V8ScriptInstance): (WebCore::V8ScriptInstance::~V8ScriptInstance): (WebCore::V8ScriptInstance::instance): (WebCore::V8ScriptInstance::clear): (WebCore::V8ScriptInstance::set):
  • bindings/v8/ScriptInstance.h: Added. (WebCore::V8ScriptInstance::create):
  • bindings/v8/ScriptSourceCode.h: Added. (WebCore::ScriptSourceCode::ScriptSourceCode): (WebCore::ScriptSourceCode::isEmpty): (WebCore::ScriptSourceCode::source): (WebCore::ScriptSourceCode::url): (WebCore::ScriptSourceCode::startLine):
  • bindings/v8/ScriptState.h: Added. (WebCore::ScriptState::hadException): (WebCore::ScriptState::setException): (WebCore::ScriptState::exception):
  • bindings/v8/ScriptString.h: Added. (WebCore::ScriptString::ScriptString): (WebCore::ScriptString::operator String): (WebCore::ScriptString::isNull): (WebCore::ScriptString::size): (WebCore::ScriptString::operator=): (WebCore::ScriptString::operator+=):
  • bindings/v8/ScriptValue.cpp: Added. (WebCore::ScriptValue::getString):
  • bindings/v8/ScriptValue.h: Added. (WebCore::ScriptValue::ScriptValue): (WebCore::ScriptValue::operator=): (WebCore::ScriptValue::operator==): (WebCore::ScriptValue::operator!=): (WebCore::ScriptValue::isNull): (WebCore::ScriptValue::isUndefined): (WebCore::ScriptValue::clear): (WebCore::ScriptValue::~ScriptValue): (WebCore::ScriptValue::v8Value):
3:20 PM Changeset in webkit [41158] by treat@webkit.org
  • 2 edits in trunk/WebCore

2009-02-23 Adam Treat <​adam.treat@torchmobile.com>

Reviewed by Timothy Hatcher.

​https://bugs.webkit.org/show_bug.cgi?id=24106
The Qt port is crashing on exit because the tear down procedure involves
the WebCore::InspectorController trying to access the JS execution context
for a page that is being deleted. This patch amends the inspector so
that it does not try and access the execution context of the WebCore::Page
in the midst of deletion.

  • inspector/InspectorController.cpp: (WebCore::InspectorController::inspectedPageDestroyed): (WebCore::InspectorController::stopUserInitiatedProfiling):
2:37 PM Changeset in webkit [41157] by levin@chromium.org
  • 8 edits in trunk/WebCore

2009-02-23 David Levin <​levin@chromium.org>

Reviewed by Alexey Proskuryakov.

Bug 24088: ThreadableLoaderClient::didFailWillSendRequestCheck isn't wired up completely for workers and could use a better name.
<​https://bugs.webkit.org/show_bug.cgi?id=24088>

No observable change in behavior, so no test.

  • loader/DocumentThreadableLoader.cpp: (WebCore::DocumentThreadableLoader::create):
  • loader/ThreadableLoaderClient.h: (WebCore::ThreadableLoaderClient::didFailRedirectCheck):
  • loader/ThreadableLoaderClientWrapper.h: (WebCore::ThreadableLoaderClientWrapper::didFailRedirectCheck):
  • loader/WorkerThreadableLoader.cpp: (WebCore::workerContextDidFailRedirectCheck): (WebCore::WorkerThreadableLoader::MainThreadBridge::didFailRedirectCheck):
  • loader/WorkerThreadableLoader.h:
  • xml/XMLHttpRequest.cpp: (WebCore::XMLHttpRequest::didFinishLoading):
  • xml/XMLHttpRequest.h:
2:37 PM Changeset in webkit [41156] by levin@chromium.org
  • 7 edits in trunk

JavaScriptCore:

2009-02-23 David Levin <​levin@chromium.org>

Reviewed by Alexey Proskuryakov.

Bug 24047: Need to simplify nested if's in WorkerRunLoop::runInMode
<​https://bugs.webkit.org/show_bug.cgi?id=24047>

  • wtf/MessageQueue.h: (WTF::MessageQueue::infiniteTime): Allows for one to call waitForMessageFilteredWithTimeout and wait forever.

(WTF::MessageQueue::alwaysTruePredicate):
(WTF::MessageQueue::waitForMessage):
Made waitForMessage call waitForMessageFilteredWithTimeout, so that there is less
duplicate code.

(WTF::MessageQueue::waitForMessageFilteredWithTimeout):

  • wtf/ThreadingQt.cpp: (WTF::ThreadCondition::timedWait):
  • wtf/ThreadingWin.cpp: (WTF::ThreadCondition::timedWait): Made these two implementations consistent with the pthread and gtk implementations. Currently, the time calculations would overflow when passed large values.

WebCore:

2009-02-23 David Levin <​levin@chromium.org>

Reviewed by Alexey Proskuryakov.

Bug 24047: Need to simplify nested if's in WorkerRunLoop::runInMode
<​https://bugs.webkit.org/show_bug.cgi?id=24047>

Made a nested if inside of WorkerRunLoop::runInMode a lot simpler by
using only MessageQueue::waitForMessageFilteredWithTimeout instead
of three different MessageQueue methods.

No observable change in behavior, so no test.

  • dom/WorkerRunLoop.cpp: (WebCore::ModePredicate::operator()): Minor clean-up to able to pass a const ref point for ModePredicate into runInMode. (WebCore::WorkerRunLoop::runInMode):
  • dom/WorkerRunLoop.h:
2:08 PM Changeset in webkit [41155] by andersca@apple.com
  • 2 edits in trunk/WebKit/mac

2009-02-23 Anders Carlsson <​andersca@apple.com>

Reviewed by Geoffrey Garen and Darin Adler.

WebKit side of <rdar://problem/6613151>.


Make sure to vm_deallocate all memory we get from MIG callbacks.


  • Plugins/Hosted/NetscapePluginHostProxy.mm: (DataDeallocator::DataDeallocator): (DataDeallocator::~DataDeallocator): Add a simple deallocator class.


(WKPCStatusText):
(WKPCLoadURL):
(WKPCBooleanAndDataReply):
(WKPCEvaluate):
(WKPCGetStringIdentifier):
(WKPCInvoke):
(WKPCInvokeDefault):
(WKPCConstruct):
(WKPCSetProperty):
Use the new deallocator class.

12:40 PM Changeset in webkit [41154] by hyatt@apple.com
  • 4 edits in trunk/WebCore

2009-02-23 David Hyatt <​hyatt@apple.com>

In preparation for making layers for multicol objects (so that they can properly split child layers
into multiple columns), rename all of the "overflowOnly" and "overflowList" members and functions
of RenderLayer to use the term "normal flow" instead.

Reviewed by Cameron Zwarich

  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::RenderLayer): (WebCore::RenderLayer::~RenderLayer): (WebCore::RenderLayer::setHasVisibleContent): (WebCore::RenderLayer::enclosingCompositingLayer): (WebCore::RenderLayer::addChild): (WebCore::RenderLayer::removeChild): (WebCore::RenderLayer::paintLayer): (WebCore::RenderLayer::hitTestLayer): (WebCore::RenderLayer::dirtyNormalFlowList): (WebCore::RenderLayer::updateNormalFlowList): (WebCore::RenderLayer::collectLayers): (WebCore::RenderLayer::updateLayerListsIfNeeded): (WebCore::RenderLayer::shouldBeNormalFlowOnly): (WebCore::RenderLayer::styleChanged):
  • rendering/RenderLayer.h: (WebCore::RenderLayer::isNormalFlowOnly): (WebCore::RenderLayer::normalFlowList):
  • rendering/RenderTreeAsText.cpp: (WebCore::writeLayers):
12:16 PM Changeset in webkit [41153] by hyatt@apple.com
  • 4 edits
    4 adds in trunk

WebCore:

2009-02-23 David Hyatt <​hyatt@apple.com>

Fix the stacking order for column rules in multi-column layout. Column rules should paint as part of the background of an element, just
after all other components of the background have been painted. This allows negative z-index children to still paint on top of the
column rules (rather than ending up above the background of the box but behind the column rules).

Reviewed by Eric Seidel

Added fast/multicol/column-rules-stacking.html

  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::paintColumnRules): (WebCore::RenderBlock::paintColumnContents): (WebCore::RenderBlock::paintObject):
  • rendering/RenderBlock.h:

LayoutTests:

2009-02-23 David Hyatt <​hyatt@apple.com>

Fix the stacking order for column rules in multi-column layout. Column rules should paint as part of the background of an element, just
after all other components of the background have been painted. This allows negative z-index children to still paint on top of the
column rules (rather than ending up above the background of the box but behind the column rules).

Reviewed by Eric Seidel

  • fast/multicol/column-rules-stacking.html: Added.
  • platform/mac/fast/multicol/column-rules-stacking-expected.checksum: Added.
  • platform/mac/fast/multicol/column-rules-stacking-expected.png: Added.
  • platform/mac/fast/multicol/column-rules-stacking-expected.txt: Added.
12:11 PM Changeset in webkit [41152] by treat@webkit.org
  • 3 edits in trunk/WebCore

2009-02-23 Adam Treat <​adam.treat@torchmobile.com>

Reviewed by David Hyatt.

No testcases have been added or modified since this patch should not result in
a behavior change for ports that have layout tests enabled.

Currently, the implementation of GraphicsContext::drawLineForText amongst
the various ports differ in that some of them are honoring the context's
strokeStyle when drawing a text-decoration and some of them are not.
For instance, Apple's Mac port *does not* honor the context's strokeStyle(),
but the Cairo implementation does and has an explicit workaround that
sets the strokeStyle() temporarily.

This patch fixes so that all ports are consistent by explicitly making sure
to set the GraphicsContext strokeStyle to SolidStroke whenever
painting the text-decoration of an InlineFlowBox or InlineTextBox as these
should always use a solid stroke.

This patch addresses these bugs:
​https://bugs.webkit.org/show_bug.cgi?id=19364
​https://bugs.webkit.org/show_bug.cgi?id=15659

  • rendering/InlineFlowBox.cpp: (WebCore::InlineFlowBox::paintTextDecorations):
  • rendering/InlineTextBox.cpp: (WebCore::InlineTextBox::paintDecoration):
11:52 AM Changeset in webkit [41151] by treat@webkit.org
  • 4 edits in trunk/WebKit/qt

2009-02-23 Adam Treat <​adam.treat@torchmobile.com>

Reviewed by Darin Adler.

​https://bugs.webkit.org/show_bug.cgi?id=24094
Make sure to empty the cache on exit to get rid of superfluous leak messages
for CachedResource's in order to keep the leak messages accurate. This
is analagous to what the Mac port is doing on application exit when all
WebView's have been closed.

  • Api/qwebpage.cpp: (QWebPagePrivate::_q_cleanupLeakMessages): (QWebPage::QWebPage):
  • Api/qwebpage.h:
  • Api/qwebpage_p.h:
11:35 AM Changeset in webkit [41150] by Dimitri Glazkov
  • 3 edits
    3 adds in trunk/WebCore

2009-02-23 Scott Violet <​sky@google.com>

Reviewed by Eric Seidel.

​https://bugs.webkit.org/show_bug.cgi?id=24098
Bugs in ClipboardChromium

Fixes the following bugs in ClipboardChromium:

  • It's possible for the extension to be empty, resulting in a bad file name, for example, 'foo.' or just '.'.
  • We weren't restricting the size of the file to MAX_PATH.
  • We weren't removing characters that are invalid for file system names.
  • platform/chromium/ClipboardChromium.cpp: (WebCore::writeImageToDataObject):
  • platform/chromium/ClipboardChromium.h:
  • platform/chromium/ClipboardChromiumLinux.cpp: Added. (WebCore::ClipboardChromium::validateFileName):
  • platform/chromium/ClipboardChromiumMac.cpp: Added. (WebCore::ClipboardChromium::validateFileName):
  • platform/chromium/ClipboardChromiumWin.cpp: Added. (WebCore::isInvalidFileCharacter): (WebCore::ClipboardChromium::validateFileName):
9:48 AM Changeset in webkit [41149] by Dimitri Glazkov
  • 2 edits in trunk/JavaScriptCore

2009-02-23 Jeremy Moskovich <​jeremy@chromium.org>

Reviewed by Adam Roben.

​https://bugs.webkit.org/show_bug.cgi?id=24096
PLATFORM(MAC)->PLATFORM(CF) since we want to use the CF functions in Chrome on OS X.

  • wtf/CurrentTime.cpp:
9:20 AM Changeset in webkit [41148] by andersca@apple.com
  • 5 edits in trunk/WebKit/mac

2009-02-23 Anders Carlsson <​andersca@apple.com>

Reviewed by Darin Adler.

Fix <rdar://problem/6450656>.


  • Plugins/Hosted/NetscapePluginInstanceProxy.h:
  • Plugins/Hosted/NetscapePluginInstanceProxy.mm: (WebKit::NetscapePluginInstanceProxy::insertText): Add insert text which just calls the new WKPH function.


  • Plugins/Hosted/WebHostedNetscapePluginView.mm: (-[WebHostedNetscapePluginView inputContext]): Get the input context from the shared input panel.


(-[WebHostedNetscapePluginView keyDown:]):
Let the shared input panel have a go at the event first.


  • Plugins/Hosted/WebKitPluginHost.defs: Add new InsertText function.
8:19 AM Changeset in webkit [41147] by Simon Hausmann
  • 4 edits in trunk

2009-02-23 Thiago Macieira <​thiago.macieira@nokia.com>

Reviewed by Simon Hausmann.

Fix the Copyright notices in a few files

7:08 AM Changeset in webkit [41146] by kov@webkit.org
  • 2 edits
    3 adds in trunk

2009-02-23 Gustavo Noronha Silva <Gustavo Noronha Silva>

Reviewed by Alexey Proskuryakov.

​https://bugs.webkit.org/show_bug.cgi?id=24011
KURL's setPort doesn't unset port if 0 is given

Adding regression tests for change done on KURL's setPort in
r41076. It is worth noting that Firefox doesn't render this test
correctly since it raises an exception when javascript tries to
change the iframe's contentWindow.location.port, though other
properties are modifiable.

  • fast/loader/location-port-expected.txt: Added.
  • fast/loader/location-port.html: Added.
  • fast/loader/resources/location-port-iframe.html: Added.

Also added bug URL to the WebCore entry for the r41076 change.

6:46 AM Changeset in webkit [41145] by ap@webkit.org
  • 708 edits in trunk/LayoutTests/dom/xhtml/level3/core

Rubber-stamped by Mark Rowe.

​https://bugs.webkit.org/show_bug.cgi?id=15690
Bug in layout test framework (setUpPage vs. setUpPageStatus)

  • (Many JS files in dom/): (setUpPage): Replaced setUpPage with setUpPageStatus where appropriate, downstreaming a W3C fix.

Committing dom/xhtml/level3.

6:23 AM Changeset in webkit [41144] by ap@webkit.org
  • 723 edits in trunk/LayoutTests/dom/xhtml/level2

Rubber-stamped by Mark Rowe.

​https://bugs.webkit.org/show_bug.cgi?id=15690
Bug in layout test framework (setUpPage vs. setUpPageStatus)

  • (Many JS files in dom/): (setUpPage): Replaced setUpPage with setUpPageStatus where appropriate, downstreaming a W3C fix.

Committing dom/xhtml/level2.

6:03 AM Changeset in webkit [41143] by ap@webkit.org
  • 238 edits in trunk/LayoutTests/dom/xhtml/level1/core

Rubber-stamped by Mark Rowe.

​https://bugs.webkit.org/show_bug.cgi?id=15690
Bug in layout test framework (setUpPage vs. setUpPageStatus)

  • (Many JS files in dom/): (setUpPage): Replaced setUpPage with setUpPageStatus where appropriate, downstreaming a W3C fix.

Committing dom/xhtml/level1.

5:56 AM Changeset in webkit [41142] by ap@webkit.org
  • 721 edits in trunk/LayoutTests/dom/html/level2

Rubber-stamped by Mark Rowe.

​https://bugs.webkit.org/show_bug.cgi?id=15690
Bug in layout test framework (setUpPage vs. setUpPageStatus)

  • (Many JS files in dom/): (setUpPage): Replaced setUpPage with setUpPageStatus where appropriate, downstreaming a W3C fix.

Committing dom/html/level2.

5:34 AM Changeset in webkit [41141] by ap@webkit.org
  • 238 edits in trunk/LayoutTests/dom/html/level1/core

Rubber-stamped by Mark Rowe.

​https://bugs.webkit.org/show_bug.cgi?id=15690
Bug in layout test framework (setUpPage vs. setUpPageStatus)

  • (Many JS files in dom/): (setUpPage): Replaced setUpPage with setUpPageStatus where appropriate, downstreaming a W3C fix.

Committing dom/html/level1.

5:27 AM Changeset in webkit [41140] by ap@webkit.org
  • 66 edits in trunk/LayoutTests

Rubber-stamped by Mark Rowe.

​https://bugs.webkit.org/show_bug.cgi?id=15690
Bug in layout test framework (setUpPage vs. setUpPageStatus)

  • (Many JS files in dom/): (setUpPage): Replaced setUpPage with setUpPageStatus where appropriate, downstreaming a W3C fix.

First part: dom/svg.

3:24 AM Changeset in webkit [41139] by christian@webkit.org
  • 8 edits in trunk

Allow retrieving the Soup session and modify the code to take
into account users changing features on it.

​https://bugs.webkit.org/show_bug.cgi?id=22624
[SOUP][GTK] Need API to get SoupSession from WebKit.

3:15 AM Changeset in webkit [41138] by christian@webkit.org
  • 9 edits in trunk

Remove CURL support in the Gtk port, the HTTP backend is SOUP now.

​https://bugs.webkit.org/show_bug.cgi?id=22624
[SOUP][GTK] Need API to get SoupSession from WebKit.

2:00 AM Changeset in webkit [41137] by jmalonzo@webkit.org
  • 3 edits in trunk/WebKit/gtk

2009-02-23 Jan Michael Alonzo <​jmalonzo@webkit.org>

Reviewed by Mark Rowe.

[GTK] Back / Forward history menus are flipped
​https://bugs.webkit.org/show_bug.cgi?id=22694

Don't call g_list_reverse when returning the back or forward list.

  • tests/main.c: (test_webkit_web_back_forward_list_order): (main):
  • webkit/webkitwebbackforwardlist.cpp: (_WebKitWebBackForwardListPrivate::webkit_web_back_forward_list_get_forward_list_with_limit): (_WebKitWebBackForwardListPrivate::webkit_web_back_forward_list_get_back_list_with_limit):
1:44 AM Changeset in webkit [41136] by ap@webkit.org
  • 6 edits
    2 adds in trunk

Reviewed by Mark Rowe.

Test: fast/dom/empty-hash-and-search.html

​https://bugs.webkit.org/show_bug.cgi?id=21147
hash property returns incorrect value for links w/o hash

Make hash() and search() behavior for empty and missing parts match IE and Firefox.

  • platform/KURL.cpp: (WebCore::KURL::query): Changed to return query without '?', as it is already done for ref(). (WebCore::KURL::prettyURL): Append the query with the question mark.
  • page/Location.cpp: (WebCore::Location::search): Return an empty string if query is empty or missing. (WebCore::Location::hash): Return an empty string for empty hashes, not only missing ones.
  • dom/WorkerLocation.cpp: (WebCore::WorkerLocation::search): (WebCore::WorkerLocation::hash): Match document.location fixes above.
  • html/HTMLAnchorElement.cpp: (WebCore::HTMLAnchorElement::hash): (WebCore::HTMLAnchorElement::search): Return an empty string for empty and missing parts.
1:21 AM Changeset in webkit [41135] by ap@webkit.org
  • 3 edits
    2 adds in trunk

Reviewed by Darin Adler.

​https://bugs.webkit.org/show_bug.cgi?id=20184
SELECT with no name generates invalid query string

Test: fast/forms/select-no-name.html

  • html/HTMLSelectElement.cpp: (WebCore::HTMLSelectElement::appendFormData): Added a check for empty name.
1:10 AM Changeset in webkit [41134] by ap@webkit.org
  • 2 edits in trunk/WebCore

Apply review comments for the previous check-in (forgot to save the file, oops).

  • dom/ContainerNode.cpp: (WebCore::ContainerNode::removeChildren):
1:03 AM Changeset in webkit [41133] by ap@webkit.org
  • 3 edits
    3 adds in trunk

Reviewed by Darin Adler.

​https://bugs.webkit.org/show_bug.cgi?id=15707
Crash when manipulating document from within an iframe onload function

Test: fast/dom/onload-open.html

  • dom/ContainerNode.cpp: (WebCore::ContainerNode::removeChildren): Protect the container and the current node, because anything can happen when dispatching events.
12:58 AM Changeset in webkit [41132] by mrowe@apple.com
  • 2 edits in trunk/WebKit/mac

Fix the build after r41126.

  • Plugins/Hosted/NetscapePluginInstanceProxy.mm:

(WebKit::NetscapePluginInstanceProxy::invoke):
(WebKit::NetscapePluginInstanceProxy::invokeDefault):
(WebKit::NetscapePluginInstanceProxy::construct):

12:52 AM Changeset in webkit [41131] by ap@webkit.org
  • 3 edits
    2 adds in trunk

Reviewed by Darin Adler.

​https://bugs.webkit.org/show_bug.cgi?id=18970
Numerically named input fields cause document.forms loop problems

Test: fast/forms/numeric-input-name.html

  • bindings/scripts/CodeGeneratorJS.pm: Try index getter before name getter, even if the latter overrides properties.
12:44 AM Changeset in webkit [41130] by ap@webkit.org
  • 11 edits in trunk/WebCore

Reviewed by Sam Weinig.

​https://bugs.webkit.org/show_bug.cgi?id=24059
Tokenizer::write() return value is never used

  • dom/Tokenizer.h:
  • dom/XMLTokenizer.cpp: (WebCore::XMLTokenizer::write):
  • dom/XMLTokenizer.h:
  • html/HTMLTokenizer.cpp: (WebCore::HTMLTokenizer::write):
  • html/HTMLTokenizer.h:
  • loader/FTPDirectoryDocument.cpp: (WebCore::FTPDirectoryTokenizer::write):
  • loader/ImageDocument.cpp: (WebCore::ImageTokenizer::write):
  • loader/MediaDocument.cpp: (WebCore::MediaTokenizer::write):
  • loader/PluginDocument.cpp: (WebCore::PluginTokenizer::write):
  • loader/TextDocument.cpp: (WebCore::TextTokenizer::write): Made write() return void, not bool.

Feb 22, 2009:

10:22 PM Changeset in webkit [41129] by mitz@apple.com
  • 2 edits in trunk/WebKit/mac

Reviewed by Darin Adler.

  • fix <rdar://problem/5966123> REGRESSION (r30741): Generic Sun Applet loading logo appears half off screen
  • WebCoreSupport/WebFrameLoaderClient.mm: Correct a copy & paste error in r30741, and assign the height value, rather than the width, to the "height" parameter.
4:53 PM Changeset in webkit [41128] by ggaren@apple.com
  • 2 edits in trunk/JavaScriptCore

2009-02-22 Geoffrey Garen <​ggaren@apple.com>

Build fix?

  • GNUmakefile.am:
4:34 PM Changeset in webkit [41127] by ggaren@apple.com
  • 2 edits in trunk/JavaScriptCore

2009-02-22 Geoffrey Garen <​ggaren@apple.com>

Build fix.

  • GNUmakefile.am:
3:26 PM Changeset in webkit [41126] by ggaren@apple.com
  • 40 edits
    2 copies in trunk

JavaScriptCore:

2009-02-22 Geoffrey Garen <​ggaren@apple.com>

Reviewed by Sam Weinig.

Next step in splitting JIT functionality out of the Interpreter class:
Created a JITStubs class and renamed Interpreter::cti_* to JITStubs::cti_*.


Also, moved timeout checking into its own class, located in JSGlobalData,
so both the Interpreter and the JIT could have access to it.

  • JavaScriptCore.exp:
  • JavaScriptCore.pri:
  • JavaScriptCore.scons:
  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • JavaScriptCoreSources.bkl:
  • interpreter/CallFrame.h:
  • interpreter/Interpreter.cpp: (JSC::Interpreter::Interpreter): (JSC::Interpreter::privateExecute):
  • interpreter/Interpreter.h:
  • interpreter/Register.h:
  • jit/JIT.cpp: (JSC::): (JSC::JIT::emitTimeoutCheck): (JSC::JIT::privateCompileMainPass): (JSC::JIT::privateCompileSlowCases): (JSC::JIT::privateCompile): (JSC::JIT::privateCompileCTIMachineTrampolines):
  • jit/JIT.h:
  • jit/JITArithmetic.cpp: (JSC::JIT::compileFastArithSlow_op_lshift): (JSC::JIT::compileFastArithSlow_op_rshift): (JSC::JIT::compileFastArithSlow_op_bitand): (JSC::JIT::compileFastArithSlow_op_mod): (JSC::JIT::compileFastArith_op_mod): (JSC::JIT::compileFastArithSlow_op_post_inc): (JSC::JIT::compileFastArithSlow_op_post_dec): (JSC::JIT::compileFastArithSlow_op_pre_inc): (JSC::JIT::compileFastArithSlow_op_pre_dec): (JSC::JIT::compileFastArith_op_add): (JSC::JIT::compileFastArith_op_mul): (JSC::JIT::compileFastArith_op_sub): (JSC::JIT::compileBinaryArithOpSlowCase): (JSC::JIT::compileFastArithSlow_op_add): (JSC::JIT::compileFastArithSlow_op_mul):
  • jit/JITCall.cpp: (JSC::JIT::compileOpCall): (JSC::JIT::compileOpCallSlowCase):
  • jit/JITPropertyAccess.cpp: (JSC::JIT::compileGetByIdHotPath): (JSC::JIT::compilePutByIdHotPath): (JSC::JIT::compileGetByIdSlowCase): (JSC::JIT::compilePutByIdSlowCase): (JSC::JIT::privateCompilePutByIdTransition): (JSC::JIT::patchGetByIdSelf): (JSC::JIT::patchPutByIdReplace): (JSC::JIT::privateCompilePatchGetArrayLength): (JSC::JIT::privateCompileGetByIdSelf): (JSC::JIT::privateCompileGetByIdProto): (JSC::JIT::privateCompileGetByIdChain): (JSC::JIT::privateCompilePutByIdReplace):
  • jit/JITStubs.cpp: (JSC::JITStubs::tryCachePutByID): (JSC::JITStubs::tryCacheGetByID): (JSC::JITStubs::cti_op_convert_this): (JSC::JITStubs::cti_op_end): (JSC::JITStubs::cti_op_add): (JSC::JITStubs::cti_op_pre_inc): (JSC::JITStubs::cti_timeout_check): (JSC::JITStubs::cti_register_file_check): (JSC::JITStubs::cti_op_loop_if_less): (JSC::JITStubs::cti_op_loop_if_lesseq): (JSC::JITStubs::cti_op_new_object): (JSC::JITStubs::cti_op_put_by_id_generic): (JSC::JITStubs::cti_op_get_by_id_generic): (JSC::JITStubs::cti_op_put_by_id): (JSC::JITStubs::cti_op_put_by_id_second): (JSC::JITStubs::cti_op_put_by_id_fail): (JSC::JITStubs::cti_op_get_by_id): (JSC::JITStubs::cti_op_get_by_id_second): (JSC::JITStubs::cti_op_get_by_id_self_fail): (JSC::JITStubs::cti_op_get_by_id_proto_list): (JSC::JITStubs::cti_op_get_by_id_proto_list_full): (JSC::JITStubs::cti_op_get_by_id_proto_fail): (JSC::JITStubs::cti_op_get_by_id_array_fail): (JSC::JITStubs::cti_op_get_by_id_string_fail): (JSC::JITStubs::cti_op_instanceof): (JSC::JITStubs::cti_op_del_by_id): (JSC::JITStubs::cti_op_mul): (JSC::JITStubs::cti_op_new_func): (JSC::JITStubs::cti_op_call_JSFunction): (JSC::JITStubs::cti_op_call_arityCheck): (JSC::JITStubs::cti_vm_dontLazyLinkCall): (JSC::JITStubs::cti_vm_lazyLinkCall): (JSC::JITStubs::cti_op_push_activation): (JSC::JITStubs::cti_op_call_NotJSFunction): (JSC::JITStubs::cti_op_create_arguments): (JSC::JITStubs::cti_op_create_arguments_no_params): (JSC::JITStubs::cti_op_tear_off_activation): (JSC::JITStubs::cti_op_tear_off_arguments): (JSC::JITStubs::cti_op_profile_will_call): (JSC::JITStubs::cti_op_profile_did_call): (JSC::JITStubs::cti_op_ret_scopeChain): (JSC::JITStubs::cti_op_new_array): (JSC::JITStubs::cti_op_resolve): (JSC::JITStubs::cti_op_construct_JSConstruct): (JSC::JITStubs::cti_op_construct_NotJSConstruct): (JSC::JITStubs::cti_op_get_by_val): (JSC::JITStubs::cti_op_get_by_val_byte_array): (JSC::JITStubs::cti_op_resolve_func): (JSC::JITStubs::cti_op_sub): (JSC::JITStubs::cti_op_put_by_val): (JSC::JITStubs::cti_op_put_by_val_array): (JSC::JITStubs::cti_op_put_by_val_byte_array): (JSC::JITStubs::cti_op_lesseq): (JSC::JITStubs::cti_op_loop_if_true): (JSC::JITStubs::cti_op_negate): (JSC::JITStubs::cti_op_resolve_base): (JSC::JITStubs::cti_op_resolve_skip): (JSC::JITStubs::cti_op_resolve_global): (JSC::JITStubs::cti_op_div): (JSC::JITStubs::cti_op_pre_dec): (JSC::JITStubs::cti_op_jless): (JSC::JITStubs::cti_op_not): (JSC::JITStubs::cti_op_jtrue): (JSC::JITStubs::cti_op_post_inc): (JSC::JITStubs::cti_op_eq): (JSC::JITStubs::cti_op_lshift): (JSC::JITStubs::cti_op_bitand): (JSC::JITStubs::cti_op_rshift): (JSC::JITStubs::cti_op_bitnot): (JSC::JITStubs::cti_op_resolve_with_base): (JSC::JITStubs::cti_op_new_func_exp): (JSC::JITStubs::cti_op_mod): (JSC::JITStubs::cti_op_less): (JSC::JITStubs::cti_op_neq): (JSC::JITStubs::cti_op_post_dec): (JSC::JITStubs::cti_op_urshift): (JSC::JITStubs::cti_op_bitxor): (JSC::JITStubs::cti_op_new_regexp): (JSC::JITStubs::cti_op_bitor): (JSC::JITStubs::cti_op_call_eval): (JSC::JITStubs::cti_op_throw): (JSC::JITStubs::cti_op_get_pnames): (JSC::JITStubs::cti_op_next_pname): (JSC::JITStubs::cti_op_push_scope): (JSC::JITStubs::cti_op_pop_scope): (JSC::JITStubs::cti_op_typeof): (JSC::JITStubs::cti_op_is_undefined): (JSC::JITStubs::cti_op_is_boolean): (JSC::JITStubs::cti_op_is_number): (JSC::JITStubs::cti_op_is_string): (JSC::JITStubs::cti_op_is_object): (JSC::JITStubs::cti_op_is_function): (JSC::JITStubs::cti_op_stricteq): (JSC::JITStubs::cti_op_nstricteq): (JSC::JITStubs::cti_op_to_jsnumber): (JSC::JITStubs::cti_op_in): (JSC::JITStubs::cti_op_push_new_scope): (JSC::JITStubs::cti_op_jmp_scopes): (JSC::JITStubs::cti_op_put_by_index): (JSC::JITStubs::cti_op_switch_imm): (JSC::JITStubs::cti_op_switch_char): (JSC::JITStubs::cti_op_switch_string): (JSC::JITStubs::cti_op_del_by_val): (JSC::JITStubs::cti_op_put_getter): (JSC::JITStubs::cti_op_put_setter): (JSC::JITStubs::cti_op_new_error): (JSC::JITStubs::cti_op_debug): (JSC::JITStubs::cti_vm_throw):
  • jit/JITStubs.h: (JSC::):
  • runtime/JSFunction.h:
  • runtime/JSGlobalData.cpp: (JSC::JSGlobalData::JSGlobalData):
  • runtime/JSGlobalData.h:
  • runtime/JSGlobalObject.cpp:
  • runtime/JSGlobalObject.h:
  • runtime/TimeoutChecker.cpp: Copied from interpreter/Interpreter.cpp. (JSC::TimeoutChecker::TimeoutChecker): (JSC::TimeoutChecker::reset): (JSC::TimeoutChecker::didTimeOut):
  • runtime/TimeoutChecker.h: Copied from interpreter/Interpreter.h. (JSC::TimeoutChecker::setTimeoutInterval): (JSC::TimeoutChecker::ticksUntilNextCheck): (JSC::TimeoutChecker::start): (JSC::TimeoutChecker::stop):

WebCore:

2009-02-20 Geoffrey Garen <​ggaren@apple.com>

Reviewed by Sam Weinig.

Updated for JavaScriptCore changes to timeout checking.

  • bindings/js/JSCustomPositionCallback.cpp: (WebCore::JSCustomPositionCallback::handleEvent):
  • bindings/js/JSCustomPositionErrorCallback.cpp: (WebCore::JSCustomPositionErrorCallback::handleEvent):
  • bindings/js/JSCustomSQLStatementCallback.cpp: (WebCore::JSCustomSQLStatementCallback::handleEvent):
  • bindings/js/JSCustomSQLStatementErrorCallback.cpp: (WebCore::JSCustomSQLStatementErrorCallback::handleEvent):
  • bindings/js/JSCustomSQLTransactionCallback.cpp: (WebCore::JSCustomSQLTransactionCallback::handleEvent):
  • bindings/js/JSCustomSQLTransactionErrorCallback.cpp: (WebCore::JSCustomSQLTransactionErrorCallback::handleEvent):
  • bindings/js/JSCustomVoidCallback.cpp: (WebCore::JSCustomVoidCallback::handleEvent):
  • bindings/js/JSCustomXPathNSResolver.cpp: (WebCore::JSCustomXPathNSResolver::lookupNamespaceURI):
  • bindings/js/JSDOMWindowBase.cpp: (WebCore::JSDOMWindowBase::JSDOMWindowBase): (WebCore::JSDOMWindowBase::commonJSGlobalData):
  • bindings/js/JSEventListener.cpp: (WebCore::JSAbstractEventListener::handleEvent):
  • bindings/js/ScheduledAction.cpp: (WebCore::ScheduledAction::executeFunctionInContext):
  • bindings/js/ScriptController.cpp: (WebCore::ScriptController::evaluate):
  • bindings/js/WorkerScriptController.cpp: (WebCore::WorkerScriptController::evaluate): (WebCore::WorkerScriptController::forbidExecution):
  • bindings/objc/WebScriptObject.mm: (-[WebScriptObject callWebScriptMethod:withArguments:]): (-[WebScriptObject evaluateWebScript:]):
  • bridge/NP_jsobject.cpp: (_NPN_InvokeDefault): (_NPN_Invoke): (_NPN_Evaluate): (_NPN_Construct):
  • bridge/jni/jni_jsobject.mm: (JavaJSObject::call): (JavaJSObject::eval):
2:37 AM Changeset in webkit [41125] by mrowe@apple.com
  • 2 edits in trunk/WebKitTools

Fix assertion failures in editing/pasteboard/paste-RTFD.html and editing/pasteboard/paste-TIFF.html in 64-bit.

Reviewed by Oliver Hunt.

  • DumpRenderTree/mac/DumpRenderTree.mm:

(swizzleAllMethods): When adding a new method to a class, use the implementation and type of the new method rather
than of an arbitrary existing method on the class.

Note: See TracTimeline for information about the timeline view.