⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Feb 27, 2009:

7:44 PM Changeset in webkit [41314] by kov@webkit.org
  • 2 edits in trunk

2009-02-27 Gustavo Noronha Silva <Gustavo Noronha Silva>

Unreviewed build fix. Adding the WebKit/gtk/webkitmarshal.list
file to EXTRA_DIST to fix make dist.

  • GNUmakefile.am:
6:21 PM Changeset in webkit [41313] by kov@webkit.org
  • 2 edits in trunk/WebKit/gtk

2009-02-27 Gustavo Noronha Silva <Gustavo Noronha Silva>

Reviewed by David Hyatt.

Automatically ignore empty requests to avoid crashing. This fixes
the crash in fast/loader/empty-embed-src-attribute.html.

  • WebCoreSupport/FrameLoaderClientGtk.cpp: (WebKit::FrameLoaderClient::dispatchDecidePolicyForMIMEType): (WebKit::FrameLoaderClient::dispatchDecidePolicyForNewWindowAction): (WebKit::FrameLoaderClient::dispatchDecidePolicyForNavigationAction):
5:28 PM Changeset in webkit [41312] by levin@chromium.org
  • 3 edits
    4 adds in trunk

WebCore:

2009-02-27 Matt Pennig <​pennig@apple.com>

Reviewed by David Hyatt.

Resolves: ​https://bugs.webkit.org/show_bug.cgi?id=24107
"Fixed elements have 0 as an offsetLeft property"


Code also brings offsetLeft/Top in full conformance with the spec.
Added two tests, one for fixed-position elements, and one for <html>.


Tests: fast/dom/Element/fixed-position-offset-parent.html

fast/dom/Element/offsetLeft-offsetTop-html.html

  • rendering/RenderBoxModelObject.cpp: (WebCore::RenderBoxModelObject::offsetLeft): (WebCore::RenderBoxModelObject::offsetTop):

LayoutTests:

2009-02-27 Matt Pennig <​pennig@apple.com>

Reviewed by David Hyatt.


Added two tests:

  1. Tests offsetParent, offsetLeft and offsetTop on fixed-position elements.
  2. Tests offsetLeft and offsetTop on static and positioned <html> elements.
  • fast/dom/Element/fixed-position-offset-parent-expected.txt: Added.
  • fast/dom/Element/fixed-position-offset-parent.html: Added.
  • fast/dom/Element/offsetLeft-offsetTop-html-expected.txt: Added.
  • fast/dom/Element/offsetLeft-offsetTop-html.html: Added.
5:13 PM Changeset in webkit [41311] by dino@apple.com
  • 1 edit
    2 adds in trunk/LayoutTests

2009-02-27 Dean Jackson <​dino@apple.com>

Reviewed by Simon Fraser

Pixel tests for previous commit
​https://bugs.webkit.org/show_bug.cgi?id=24252

  • platform/mac/transforms/no_transform_hit_testing-expected.checksum: Added.
  • platform/mac/transforms/no_transform_hit_testing-expected.png: Added.
5:07 PM Changeset in webkit [41310] by dino@apple.com
  • 1 add in trunk/LayoutTests/platform/mac/transforms/no_transform_hit_testing-expected.txt

Forgot -expected file from last commit :(

5:05 PM Changeset in webkit [41309] by dino@apple.com
  • 3 edits
    1 add in trunk

2009-02-27 Dean Jackson <​dino@apple.com>

Reviewed by Simon Fraser.

renderer()->hasTransform() returns true for elements
with perspective, but no transform, so test for transform
when hit testing. This fixes ASSERT from
​https://bugs.webkit.org/show_bug.cgi?id=24252

Test: transforms/no_transform_hit_testing.html

  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::hitTestLayer):
4:01 PM Changeset in webkit [41308] by Dimitri Glazkov
  • 2 edits in trunk/WebCore

2009-02-27 Dimitri Glazkov <Dimitri Glazkov>

Reviewed by Darin Fisher.

Fix scrubbing error -- a reversed condition.

  • bindings/v8/ScriptValue.h: (WebCore::ScriptValue::clear): Change early exit for empty value, not the opposite.
3:46 PM Changeset in webkit [41307] by mrowe@apple.com
  • 4 edits in branches/Safari-3-2-branch

Versioning.

3:39 PM Changeset in webkit [41306] by mrowe@apple.com
  • 1 copy in tags/Safari-5525.28.3

New tag.

3:29 PM Changeset in webkit [41305] by levin@chromium.org
  • 4 edits in trunk/WebCore

2009-02-27 Jian Li <​jianli@chromium.org>

Reviewed by Alexey Proskuryakov.

Add confirmMessageFromWorkerObject to WorkerObjectProxy.
​https://bugs.webkit.org/show_bug.cgi?id=24152

  • workers/WorkerMessagingProxy.cpp: (WebCore::MessageWorkerContextTask::performTask): (WebCore::WorkerMessagingProxy::confirmMessageFromWorkerObject):
  • workers/WorkerMessagingProxy.h:
  • workers/WorkerObjectProxy.h:
2:46 PM Changeset in webkit [41304] by andersca@apple.com
  • 9 edits in trunk/WebCore

2009-02-27 Anders Carlsson <​andersca@apple.com>

Reviewed by David Hyatt.

Revert r41295, the fix for ​https://bugs.webkit.org/show_bug.cgi?id=24227
because it leads to assertion failures in the Mac port.


  • platform/graphics/BitmapImage.cpp: (WebCore::BitmapImage::BitmapImage):
  • platform/graphics/BitmapImage.h: (WebCore::BitmapImage::mayFillWithSolidColor):
  • platform/graphics/Image.h: (WebCore::Image::mayFillWithSolidColor):
  • platform/graphics/cairo/ImageCairo.cpp: (WebCore::BitmapImage::BitmapImage):
  • platform/graphics/cg/ImageCG.cpp: (WebCore::BitmapImage::BitmapImage): (WebCore::BitmapImage::checkForSolidColor):
  • platform/graphics/qt/ImageQt.cpp: (WebCore::BitmapImage::checkForSolidColor):
  • platform/graphics/skia/ImageSkia.cpp: (WebCore::BitmapImage::checkForSolidColor):
  • platform/graphics/wx/ImageWx.cpp: (WebCore::BitmapImage::checkForSolidColor):
2:37 PM Changeset in webkit [41303] by andersca@apple.com
  • 2 edits in trunk/WebKit/mac

2009-02-27 Anders Carlsson <​andersca@apple.com>

Reviewed by Geoffrey Garen.

<rdar://problem/6631436>
CrashTracer: [USER] 1 crash in Safari at com.apple.WebKit • WebKit::NetscapePluginInstanceProxy::addValueToArray + 55


Port the NPN_Evaluate code over from WebCore instead of using the frame loader.


  • Plugins/Hosted/NetscapePluginInstanceProxy.mm: (WebKit::NetscapePluginInstanceProxy::evaluate):
2:24 PM Changeset in webkit [41302] by abarth@webkit.org
  • 1 edit in trunk/WebKit/win/WebPreferenceKeysPrivate.h

Remove mysterious @ sign to fix Windows build.

2:15 PM Changeset in webkit [41301] by abarth@webkit.org
  • 1 edit in trunk/WebKit/win/WebView.cpp

Attempt to fix Windows build.

1:58 PM Changeset in webkit [41300] by andersca@apple.com
  • 5 edits in trunk/WebKit/mac

2009-02-27 Anders Carlsson <​andersca@apple.com>

Reviewed by Geoffrey Garen.

WebKit side of <rdar://problem/6626814>.


  • Plugins/Hosted/NetscapePluginHostProxy.mm: (WKPCInvokeDefault): Make InvokeDefault async.


  • Plugins/Hosted/NetscapePluginInstanceProxy.mm: (WebKit::NetscapePluginInstanceProxy::addValueToArray): Handle passing NPObjects back to the plug-in host.


  • Plugins/Hosted/ProxyInstance.h: (WebKit::ProxyInstance::objectID): Add objectID getter.


  • Plugins/Hosted/WebKitPluginClient.defs: Make InvokeDefault a simpleroutine.
1:53 PM Changeset in webkit [41299] by timothy@apple.com
  • 2 edits in trunk/WebKit/mac

Fixes an exception by null checking the WebResource before adding it to
the subresources array.

<rdar://problem/5950769> Bug in [WebDataSource subresources] can throw an exception

Reviewed by Geoff Garen and Anders Carlsson.

  • WebView/WebDataSource.mm: (-[WebDataSource subresources]): Null check the WebResource before adding it.
1:01 PM Changeset in webkit [41298] by timothy@apple.com
  • 2 edits in trunk/WebKit/mac

Adds a workaround for Automator creating a WebView from a secondary thread.

<rdar://problem/6631951> REGRESSION (Safari 4 Beta): Automator crash on
secondary thread beneath -[WebView initWithFrame:frameName:groupName:]

Reviewed by Geoff Garen.

  • WebView/WebView.mm: (needsWebViewInitThreadWorkaround): Check for com.apple.Automator.
12:52 PM Changeset in webkit [41297] by abarth@webkit.org
  • 17 edits in trunk

WebCore:

2009-02-27 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

​https://bugs.webkit.org/show_bug.cgi?id=20249

Add a preference to allow universal access from local URLs to mitigate
some attacks. Some clients still want to allow this access, so we
expose this as a preference.

  • WebCore.base.exp:
  • dom/Document.cpp: (WebCore::Document::initSecurityContext):
  • page/SecurityOrigin.cpp: (WebCore::SecurityOrigin::SecurityOrigin):
  • page/Settings.cpp: (WebCore::Settings::Settings): (WebCore::Settings::setAllowUniversalAccessFromFileUrls):
  • page/Settings.h: (WebCore::Settings::allowUniversalAccessFromFileUrls):

WebKit/mac:

2009-02-27 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Add a preference to reduce the power of ​file:// URLs.

  • WebView/WebPreferenceKeysPrivate.h:
  • WebView/WebPreferences.mm: (+[WebPreferences initialize]): (-[WebPreferences allowUniversalAccessFromFileUrls]): (-[WebPreferences setAllowUniversalAccessFromFileUrls:]):
  • WebView/WebPreferencesPrivate.h:
  • WebView/WebView.mm: (-[WebView _preferencesChangedNotification:]):

WebKit/win:

2009-02-27 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Add a preference to reduce the power of ​file:// URLs.

  • Interfaces/IWebPreferencesPrivate.idl:
  • WebPreferenceKeysPrivate.h:
  • WebPreferences.cpp: (WebPreferences::initializeDefaultSettings): (WebPreferences::allowUniversalAccessFromFileUrls): (WebPreferences::setAllowUniversalAccessFromFileUrls):
  • WebPreferences.h:
  • WebView.cpp: (WebView::notifyPreferencesChanged):
12:47 PM Changeset in webkit [41296] by treat@webkit.org
  • 2 edits in trunk/WebCore

2009-02-27 Adam Treat <​adam.treat@torchmobile.com>

Reviewed by Eric Seidel.

​https://bugs.webkit.org/show_bug.cgi?id=24229
If an image has no alpha channel there is no reason to use SourceOver.

  • platform/graphics/qt/ImageQt.cpp: (WebCore::Image::drawPattern): (WebCore::BitmapImage::draw):
12:42 PM Changeset in webkit [41295] by treat@webkit.org
  • 9 edits in trunk/WebCore

2009-02-27 Adam Treat <​adam.treat@torchmobile.com>

Reviewed by Eric Seidel and Simon Fraser.

​https://bugs.webkit.org/show_bug.cgi?id=24227
Ensure that the checkForSolidColor() optimization is correctly triggered
for all cases of drawPattern. Currently, the optimization was not triggered
when the check had not been previously performed via a request for the
image's NativeImagePtr.

Implement the Qt version of the checkForSolidColor() method. Combined with
the bug fix this reduces the time it takes to draw a repeating background
of a 1x1 image from ~50msecs to ~0msecs on my machine.

  • platform/graphics/BitmapImage.cpp: (WebCore::BitmapImage::BitmapImage):
  • platform/graphics/BitmapImage.h: (WebCore::BitmapImage::mayFillWithSolidColor):
  • platform/graphics/Image.h: (WebCore::Image::mayFillWithSolidColor):
  • platform/graphics/cairo/ImageCairo.cpp: (WebCore::BitmapImage::BitmapImage):
  • platform/graphics/cg/ImageCG.cpp: (WebCore::BitmapImage::BitmapImage): (WebCore::BitmapImage::checkForSolidColor):
  • platform/graphics/qt/ImageQt.cpp: (WebCore::BitmapImage::checkForSolidColor):
  • platform/graphics/skia/ImageSkia.cpp: (WebCore::BitmapImage::checkForSolidColor):
  • platform/graphics/wx/ImageWx.cpp: (WebCore::BitmapImage::checkForSolidColor):
12:35 PM Changeset in webkit [41294] by krit@webkit.org
  • 2 edits in trunk/WebCore

2009-02-27 Dirk Schulze <​krit@webkit.org>

Reviewed by Zack Rusin.

Added support for gradients and pattern on Fonts for Qt.

[Qt] gradients and patterns for FontQt
​https://bugs.webkit.org/show_bug.cgi?id=24243

  • platform/graphics/qt/FontQt.cpp: (WebCore::Font::drawComplexText):
12:02 PM Changeset in webkit [41293] by Simon Fraser
  • 2 edits in trunk/WebKit/mac

2009-02-27 Simon Fraser <Simon Fraser>

Reviewed by Anders Carlsson

​https://bugs.webkit.org/show_bug.cgi?id=24242

setCursor(), and resetCursorRects() on Tiger, were using global, not local
coordinates for elementAtPoint:

  • WebView/WebHTMLView.mm: (resetCursorRects): (setCursor):
11:50 AM Changeset in webkit [41292] by levin@chromium.org
  • 3 edits in trunk/LayoutTests

2009-02-27 David Levin <​levin@chromium.org>

Reviewed by Alexey Proskuryakov.

Bug 24213: Web Worker: Worker4 test: onmessage will never be called
<​https://bugs.webkit.org/show_bug.cgi?id=24213>

  • fast/workers/worker-terminate-expected.txt:
  • fast/workers/worker-terminate.html: Added a log entry to the onmessage handler for worker4 to make it visible that the handler was called and removed the terminate call that happened outside of onmessage.
11:50 AM Changeset in webkit [41291] by levin@chromium.org
  • 2 edits in trunk/WebCore

2009-02-27 Jian Li <​jianli@chromium.org>

Reviewed by Alexey Proskuryakov.

WorkerContextProxy::create in WorkerMessagingProxy.cpp should only be provided for non-Chromium platform.
​https://bugs.webkit.org/show_bug.cgi?id=24113

  • workers/WorkerMessagingProxy.cpp:
11:29 AM Changeset in webkit [41290] by timothy@apple.com
  • 1 add in trunk/WebCore/inspector/front-end/DOMStorageDataGrid.js

Commit a missing file.

10:56 AM Changeset in webkit [41289] by timothy@apple.com
  • 5 edits in trunk/WebCore

Added a refresh button to storage views.

​https://bugs.webkit.org/show_bug.cgi?id=24040

Reviewed by Timothy Hatcher.

  • inspector/front-end/DOMStorageItemsView.js: (WebInspector.DOMStorageItemsView): (WebInspector.DOMStorageItemsView.prototype.get statusBarItems): (WebInspector.DOMStorageItemsView.prototype.update): (WebInspector.DOMStorageItemsView.prototype._refreshButtonClicked):
  • inspector/front-end/DatabaseTableView.js: (WebInspector.DatabaseTableView): (WebInspector.DatabaseTableView.prototype.get statusBarItems): (WebInspector.DatabaseTableView.prototype._refreshButtonClicked):
  • inspector/front-end/DatabasesPanel.js: (WebInspector.DatabasesPanel): (WebInspector.DatabasesPanel.prototype.get statusBarItems): (WebInspector.DatabasesPanel.prototype.reset): (WebInspector.DatabasesPanel.prototype.showDatabase): (WebInspector.DatabasesPanel.prototype.showDOMStorage): (WebInspector.DatabasesPanel.prototype._updateSidebarWidth):
  • inspector/front-end/inspector.css:
10:28 AM Changeset in webkit [41288] by timothy@apple.com
  • 7 edits in trunk/WebCore

Added support for editing/deleting localStorage and sessionStorage items
directly from Web Inspector.

​https://bugs.webkit.org/show_bug.cgi?id=23866.

Reviewed by Timothy Hatcher.

  • WebCore.vcproj/WebCore.vcproj:
  • inspector/front-end/DOMStorageDataGrid.js: Added. (WebInspector.DOMStorageDataGrid): (WebInspector.DOMStorageDataGrid.prototype._ondblclick): (WebInspector.DOMStorageDataGrid.prototype._startEditing): (WebInspector.DOMStorageDataGrid.prototype._editingCommitted): (WebInspector.DOMStorageDataGrid.prototype._editingCancelled): (WebInspector.DOMStorageDataGrid.prototype.deleteSelectedRow):
  • inspector/front-end/DOMStorageItemsView.js: (WebInspector.DOMStorageItemsView): (WebInspector.DOMStorageItemsView.prototype.get statusBarItems): (WebInspector.DOMStorageItemsView.prototype.hide): (WebInspector.DOMStorageItemsView.prototype.update): (WebInspector.DOMStorageItemsView.prototype._deleteButtonClicked):
  • inspector/front-end/DatabasesPanel.js: (WebInspector.DatabasesPanel): (WebInspector.DatabasesPanel.prototype.get statusBarItems): (WebInspector.DatabasesPanel.prototype.reset): (WebInspector.DatabasesPanel.prototype.showDOMStorage): (WebInspector.DatabasesPanel.prototype.dataGridForDOMStorage): (WebInspector.DatabasesPanel.prototype._updateSidebarWidth):
  • inspector/front-end/WebKit.qrc:
  • inspector/front-end/inspector.css:
  • inspector/front-end/inspector.html:
9:42 AM Changeset in webkit [41287] by brettw@chromium.org
  • 7 edits
    2 adds in trunk/WebCore

Fix Windows transparency for the Chromium port. Implement a helper
class for handling transparency on Windows. It allows semitransparent
ClearType and semitransparent form controls by making new layers in the
background.

It also replaces the "ThemeHelper" which allows better
scaling and transforms on Windows form controls. In addition to the
functionality that the ThemeHelper did, but additionally handles the
antialiasing properly so that the form controls aren't composited on a
white square.

​https://bugs.webkit.org/show_bug.cgi?id=24101

Reviewed by Eric Seidel.

8:23 AM Changeset in webkit [41286] by Dimitri Glazkov
  • 1 edit
    2 adds in trunk/WebCore

2009-02-27 Dimitri Glazkov <Dimitri Glazkov>

Reviewed by Eric Seidel.

​https://bugs.webkit.org/show_bug.cgi?id=24211
Add ScheduledAction for V8.

  • bindings/v8/ScheduledAction.cpp: Added. (WebCore::ScheduledAction::ScheduledAction): (WebCore::ScheduledAction::~ScheduledAction): (WebCore::ScheduledAction::execute):
  • bindings/v8/ScheduledAction.h: Added. (WebCore::ScheduledAction::ScheduledAction):
6:59 AM Changeset in webkit [41285] by treat@webkit.org
  • 2 edits in trunk/WebCore

2009-02-27 Zack Rusin <​zack@kde.org>

Reviewed by Nikolas Zimmermann.

Qt: be more reasonable about scrolled lines

cMouseWheelPixelsPerLineStep is currently a constant set to 13.3. it doesn't
match our metrics meaning that Qt scrolls by ~2 lines by default which is quite
irritating. so lets scroll vertically by the Qt set number of lines * Qt default
single step scroll

  • platform/qt/WheelEventQt.cpp:
3:30 AM Changeset in webkit [41284] by jmalonzo@webkit.org
  • 4 edits in trunk/WebKit/gtk

2009-02-27 Xan Lopez <​xan@gnome.org>

Reviewed by Alexey Proskuryakov.

​https://bugs.webkit.org/show_bug.cgi?id=24221
[GTK] Do not emit load-finished when being disposed

webkit_web_view_stop_load() is called from dispose() on
WebKitWebView. This eventually calls postProgressFinishedNotification
in FrameLoaderClientGtk, which emits load-finished. Add
a 'disposing' flag to WebView that we can check here, so
we avoid emitting signals on objects on their way to be
destroyed. This fixes a bunch of critical warnings when
closing a loading WebView.

  • WebCoreSupport/FrameLoaderClientGtk.cpp: (WebKit::FrameLoaderClient::postProgressFinishedNotification):
  • webkit/webkitprivate.h:
  • webkit/webkitwebview.cpp:
3:18 AM Changeset in webkit [41283] by jmalonzo@webkit.org
  • 10 edits in trunk

2009-02-27 Xan Lopez <​xan@gnome.org>

Rubber-stamped by Alexey Proskuryakov.

​https://bugs.webkit.org/show_bug.cgi?id=24222
[GTK] Remove checks for old glib versions

libsoup, which is a hard dependency, needs at least glib 2.15.3,
so remove all glib checks for versions older than that.

  • platform/gtk/ContextMenuGtk.cpp: (WebCore::ContextMenu::ContextMenu):
  • platform/gtk/ContextMenuItemGtk.cpp: (WebCore::ContextMenuItem::setSubMenu):
  • platform/gtk/PopupMenuGtk.cpp: (WebCore::PopupMenu::show):
  • platform/gtk/WidgetGtk.cpp: (WebCore::Widget::retainPlatformWidget):
  • platform/network/soup/ResourceHandleSoup.cpp:

WebKit/gtk:

2009-02-27 Xan Lopez <​xan@gnome.org>

Rubber-stamped by Alexey Proskuryakov.

​https://bugs.webkit.org/show_bug.cgi?id=24222
[GTK] Remove checks for old glib versions

libsoup, which is a hard dependency, needs at least glib 2.15.3,
so remove all glib checks for versions older than that.

  • webkit/webkitwebview.cpp:

WebKitTools:

2009-02-27 Xan Lopez <​xan@gnome.org>

Rubber-stamped by Alexey Proskuryakov.

​https://bugs.webkit.org/show_bug.cgi?id=24222
[GTK] Remove checks for old glib versions

libsoup, which is a hard dependency, needs at least glib 2.15.3,
so remove all glib checks for versions older than that.

  • DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: (LayoutTestController::setWaitToDump):
3:12 AM Changeset in webkit [41282] by mrowe@apple.com
  • 2 edits in branches/Safari-3-2-branch/WebKit/mac

Merge r41070.

3:12 AM Changeset in webkit [41281] by mrowe@apple.com
  • 13 edits in branches/Safari-3-2-branch

Merge r41190.

3:12 AM Changeset in webkit [41280] by mrowe@apple.com
  • 1 edit in branches/Safari-3-2-branch/WebKitLibraries/win/tools/scripts/PRODUCTVERSION

Bump version number.

12:20 AM Changeset in webkit [41279] by krit@webkit.org
  • 3 edits in trunk/WebCore

2009-02-26 Dirk Schulze <​krit@webkit.org>

Reviewed by Oliver Hunt.

Added support for Gradients and Patterns on filled or stroked Fonts
in Cairo. I also added support for globalAlpha on FontCairo.

[CAIRO] SVG/Canvas fonts miss gradients/pattern support
​https://bugs.webkit.org/show_bug.cgi?id=18617

  • html/CanvasRenderingContext2D.cpp: (WebCore::CanvasRenderingContext2D::drawTextInternal):
  • platform/graphics/cairo/FontCairo.cpp: (WebCore::Font::drawGlyphs):

Feb 26, 2009:

8:00 PM Changeset in webkit [41278] by adele@apple.com
  • 5 edits in trunk/LayoutTests

2009-02-26 Adele Peterson <​adele@apple.com>

Reviewed by Alice Liu.

Make the success/failure of this test more obvious.

  • editing/selection/designmode-no-caret.html:
  • platform/mac/editing/selection/designmode-no-caret-expected.checksum:
  • platform/mac/editing/selection/designmode-no-caret-expected.png:
  • platform/mac/editing/selection/designmode-no-caret-expected.txt:
7:32 PM Changeset in webkit [41277] by barraclough@apple.com
  • 6 edits in trunk

JavaScriptCore:

2009-02-26 Gavin Barraclough <​barraclough@apple.com>

Reviewed by Geoff Garen.

Fix bug #23614. Switches on double precision values were incorrectly
truncating the scrutinee value. E.g.:

switch (1.1) { case 1: print("FAIL"); }

Was resulting in FAIL.

  • interpreter/Interpreter.cpp: (JSC::Interpreter::privateExecute):
  • jit/JITStubs.cpp: (JSC::JITStubs::cti_op_switch_imm):

LayoutTests:

2009-02-26 Gavin Barraclough <​barraclough@apple.com>

Rubber stamped by Geoff Garen.

Layout test for bug #23614.

  • fast/js/resources/switch-behaviour.js:
  • fast/js/switch-behaviour-expected.txt:
5:15 PM Changeset in webkit [41276] by adele@apple.com
  • 8 edits in trunk

WebKit/mac:

2009-02-26 Adele Peterson <​adele@apple.com>

Reviewed by Geoff Garen.

Fix for <rdar://problem/6618166>
​https://bugs.webkit.org/show_bug.cgi?id=24216
(REGRESSION r36919) Safari 4 Beta causes MSN Messenger's text entry field to lose focus after entering a message

During a series of firstResponder changes, at some point while the WebHTMLView was losing first responder status,
we incorrectly marked the page as active, and then when the WebHTMLView became first responder again, setActive did nothing.
This change restores behavior from before r36919 to check if the WebHTMLView is in the middle of losing first responder when calling setActive.

In addition to updating editing/selection/designmode-no-caret.html results, I also made sure the test cases that were
fixed in r36919 and r38570 are still fixed.

  • WebView/WebHTMLView.mm: (-[WebHTMLView resignFirstResponder]): Keep track if we're in the process of resigning first responder. (-[WebHTMLView _isResigningFirstResponder]): Added.
  • WebView/WebHTMLViewInternal.h:
  • WebView/WebView.mm: (-[WebView _updateFocusedAndActiveStateForFrame:]): Don't set the page to be active if the document view is currently resigning first responder.

LayoutTests:

2009-02-26 Adele Peterson <​adele@apple.com>

Reviewed by Geoff Garen.

Updating results for <rdar://problem/6618166>
​https://bugs.webkit.org/show_bug.cgi?id=24216
(REGRESSION r36919) Safari 4 Beta causes MSN Messenger's text entry field to lose focus after entering a message

We changed these results shortly after r36919, but the original result is actually correct.
The test's text indicates that we expect a caret to be placed in this case.

  • platform/mac/editing/selection/designmode-no-caret-expected.checksum:
  • platform/mac/editing/selection/designmode-no-caret-expected.png:
  • platform/mac/editing/selection/designmode-no-caret-expected.txt:
5:09 PM Changeset in webkit [41275] by barraclough@apple.com
  • 4 edits in trunk/JavaScriptCore

2009-02-26 Gavin Barraclough <​barraclough@apple.com>

Reviewed by Oliver Hunt.

Integer Immediate representation need not be canonical in x86 JIT code.
On x86-64 we already have loosened the requirement that the int immediate
representation in canonical, we should bring x86 into line.

This patch is a minor (~0.5%) improvement on sunspider & v8-tests, and
should reduce memory footoprint (reduces JIT code size).

  • jit/JIT.cpp: (JSC::JIT::compileOpStrictEq): (JSC::JIT::privateCompileSlowCases):
  • jit/JIT.h: (JSC::JIT::emitJumpIfImmediateNumber): (JSC::JIT::emitJumpIfNotImmediateNumber):
  • jit/JITArithmetic.cpp: (JSC::JIT::putDoubleResultToJSNumberCellOrJSImmediate): (JSC::JIT::compileBinaryArithOp):
4:20 PM Changeset in webkit [41274] by darin@chromium.org
  • 7 edits in trunk/WebCore

2009-02-26 Stephen White <​senorblanco@chromium.org>

Reviewed by Eric Seidel.

​https://bugs.webkit.org/show_bug.cgi?id=23957

Fix for SVG gradient and pattern text for Chromium/skia.
Added accessors for the fill and stroke gradients to
GraphicsContext. Changed the paintSkiaText function to take a
GraphicsContext, so we can check for gradients/patterns.
Changed the skiaDrawText function to set the SkPaint shader
correctly, and to scale up the gradient shader matrix to
encompass the entire text string. Also offset each glyph
separately, rather than transforming the canvas, so that the
gradient/pattern stays fixed relative to the text origin.

  • platform/graphics/GraphicsContext.cpp: (WebCore::GraphicsContext::getFillGradient): (WebCore::GraphicsContext::getStrokeGradient): (WebCore::GraphicsContext::getFillPattern): (WebCore::GraphicsContext::getStrokePattern):
  • platform/graphics/GraphicsContext.h:
  • platform/graphics/chromium/FontChromiumWin.cpp: (WebCore::Font::drawGlyphs):
  • platform/graphics/chromium/UniscribeHelper.cpp: (WebCore::UniscribeHelper::draw):
  • platform/graphics/skia/SkiaFontWin.cpp: (WebCore::windowsCanHandleTextDrawing): (WebCore::skiaDrawText): (WebCore::paintSkiaText):
  • platform/graphics/skia/SkiaFontWin.h:
3:29 PM Changeset in webkit [41273] by Dimitri Glazkov
  • 1 edit in trunk/WebCore/ChangeLog

Fix ChangeLog entry

3:27 PM Changeset in webkit [41272] by Dimitri Glazkov
  • 1 edit
    4 adds in trunk/WebCore

2009-02-26 Dimitri Glazkov <Dimitri Glazkov>

Reviewed by Eric Seidel.

​http://codereview.chromium.org/27217
Add custom V8 bindings for Navigator, Clipboard, Document, and Node.

  • bindings/v8/custom/V8ClipboardCustom.cpp: Added. (WebCore::ACCESSOR_GETTER): (WebCore::CALLBACK_FUNC_DECL):
  • bindings/v8/custom/V8DocumentCustom.cpp: Added. (WebCore::CALLBACK_FUNC_DECL):
  • bindings/v8/custom/V8NavigatorCustom.cpp: Added. (WebCore::ACCESSOR_GETTER):
  • bindings/v8/custom/V8NodeCustom.cpp: Added. (WebCore::CALLBACK_FUNC_DECL):
3:00 PM Changeset in webkit [41271] by kov@webkit.org
  • 2 edits in trunk/WebCore

2009-02-26 Gustavo Noronha Silva <Gustavo Noronha Silva>

Unreviewed build fix for building with GNOME Keyring enabled.

  • platform/network/soup/webkit-soup-auth-dialog.c: (show_auth_dialog):
2:45 PM Changeset in webkit [41270] by kov@webkit.org
  • 7 edits
    2 adds in trunk

2009-02-26 Xan Lopez <​xan@gnome.org>

Reviewed by Holger Freyther.

​https://bugs.webkit.org/show_bug.cgi?id=16947
[GTK] Missing HTTP Auth challenge

Add HTTP authentication dialog with optional GNOME Keyring
storage.

  • GNUmakefile.am:
  • platform/network/ResourceHandleInternal.h: (WebCore::ResourceHandleInternal::ResourceHandleInternal):
  • platform/network/soup/ResourceHandleSoup.cpp: (WebCore::currentToplevelCallback): (WebCore::ResourceHandle::startHttp): (WebCore::ResourceHandle::start):
  • platform/network/soup/webkit-soup-auth-dialog.c: Added. (webkit_soup_auth_dialog_class_init): (webkit_soup_auth_dialog_init): (webkit_soup_auth_dialog_session_feature_init): (free_authData): (set_password_callback): (response_callback): (show_auth_dialog): (find_password_callback): (session_authenticate): (attach):
  • platform/network/soup/webkit-soup-auth-dialog.h: Added.
1:11 PM Changeset in webkit [41269] by eric@webkit.org
  • 3 edits in trunk/WebCore

2009-02-25 Ojan Vafai <​ojan@chromium.org> and Eric Seidel <​eric@webkit.org>

Reviewed by Dave Hyatt.

After Ojan's positionForCoordinates fix ​http://trac.webkit.org/changeset/41191
svg/custom/pointer-events-image.svg and svg/custom/pointer-events-text.svg
started failing because Ojan's new code was now *correctly* calling through to
SVG asking for the closest text offset in the last line box, instead of
just returning the offset at the end of the last line box when clicking below a box.

But! The SVG code was wrong, in that it returned the character offset of the last
character when you asked for a character offset after the end of the box, instead
it should return the offset *after* the last character. This patch fixes
that behavior by reordering the last two clauses in svgCharacterHitsPosition.

The SVG positionForCoordinates function is still wrong, and I've added some FIXMEs
to document what's wrong. I've also cleaned up the code a bit so it's clearer
what it is doing (which also makes more obvious what's wrong with it).

  • rendering/RenderSVGInlineText.cpp: (WebCore::RenderSVGInlineText::positionForCoordinates):
  • rendering/SVGInlineTextBox.cpp: (WebCore::SVGInlineTextBoxClosestCharacterToPositionWalker::SVGInlineTextBoxClosestCharacterToPositionWalker): (WebCore::SVGInlineTextBoxClosestCharacterToPositionWalker::chunkPortionCallback): (WebCore::SVGInlineTextBoxClosestCharacterToPositionWalker::offsetOfHitCharacter): (WebCore::SVGInlineTextBox::closestCharacterToPosition): (WebCore::SVGInlineTextBox::svgCharacterHitsPosition):
12:40 PM Changeset in webkit [41268] by darin@chromium.org
  • 3 edits in trunk/WebCore

2009-02-26 Darin Fisher <​darin@chromium.org>

Reviewed by Eric Seidel.

Minor cleanup of ChromiumBridge:
Removing unused matchesMIMEType method and s/Javascript/JavaScript/

  • platform/chromium/ChromiumBridge.h:
  • platform/chromium/MimeTypeRegistryChromium.cpp: (WebCore::MIMETypeRegistry::isSupportedImageMIMEType): (WebCore::MIMETypeRegistry::isSupportedJavaScriptMIMEType): (WebCore::MIMETypeRegistry::isSupportedNonImageMIMEType):
12:36 PM Changeset in webkit [41267] by hyatt@apple.com
  • 3 edits
    4 adds in trunk

WebCore:

2009-02-26 David Hyatt <​hyatt@apple.com>

Reviewed by Sam Weinig

Fix text-bottom vertical alignment. It was incorrectly aligning the bottom of the descent instead of including
the line-height below the descent.

Added fast/inline/vertical-align-text-bottom.html

  • rendering/RenderBoxModelObject.cpp: (WebCore::RenderBoxModelObject::verticalPosition):

LayoutTests:

2009-02-26 David Hyatt <​hyatt@apple.com>

Reviewed by Sam Weinig

Fix text-bottom vertical alignment. It was incorrectly aligning the bottom of the descent instead of including
the line-height below the descent.

  • fast/inline/vertical-align-text-bottom.html: Added.
  • platform/mac/fast/inline/vertical-align-text-bottom-expected.checksum: Added.
  • platform/mac/fast/inline/vertical-align-text-bottom-expected.png: Added.
  • platform/mac/fast/inline/vertical-align-text-bottom-expected.txt: Added.
12:11 PM Changeset in webkit [41266] by krit@webkit.org
  • 12 edits
    5 deletes in trunk

2009-02-26 Dirk Schulze <​krit@webkit.org>

Reviewed by Eric Seidel.

Make SVG Masking platform independet with the use of ImageBuffer::getImageData(),
ImageBuffer::putImageData() and GraphicsContext::clipToImageBuffer(). Every platform has
just to implement this three methods to support SVG Masking now.


Make SVG Masking platform aware
​https://bugs.webkit.org/show_bug.cgi?id=19243

  • GNUmakefile.am:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • svg/graphics/SVGResourceMasker.cpp: (WebCore::SVGResourceMasker::applyMask):
  • svg/graphics/cairo/SVGResourceMaskerCairo.cpp: Removed.
  • svg/graphics/cg/SVGResourceMaskerCg.cpp: Removed.
  • svg/graphics/cg/SVGResourceMaskerCg.mm: Removed.
  • svg/graphics/qt/SVGResourceMaskerQt.cpp: Removed.
  • svg/graphics/skia/SVGResourceMaskerSkia.cpp: Removed.

LayoutTests:
Corrected some tests after the new SVG Masking implementation for Mac.

Make SVG Masking platform aware
​https://bugs.webkit.org/show_bug.cgi?id=19243

  • platform/mac/svg/W3C-SVG-1.1/masking-mask-01-b-expected.checksum:
  • platform/mac/svg/W3C-SVG-1.1/masking-mask-01-b-expected.png:
  • platform/mac/svg/custom/grayscale-gradient-mask-expected.checksum:
  • platform/mac/svg/custom/grayscale-gradient-mask-expected.png:
  • svg/custom/mask-excessive-malloc.svg:
12:09 PM Changeset in webkit [41265] by treat@webkit.org
  • 5 edits
    3 adds in trunk

2009-02-26 Yong Li <​yong.li@torchmobile.com>

Reviewed by Darin Adler, Antti Koivisto and Alexey Proskuryakov.

Test: http/tests/misc/slow-preload-cancel.html

​https://bugs.webkit.org/show_bug.cgi?id=24133
Clear all pending preloads in the DocLoader object when we decide to
cancel its all requests.

  • loader/DocLoader.cpp: (WebCore::DocLoader::clearPendingPreloads):
  • loader/DocLoader.h:
  • loader/loader.cpp: (WebCore::Loader::cancelRequests):
12:07 PM Changeset in webkit [41264] by andersca@apple.com
  • 5 edits in trunk/WebKit/mac

2009-02-25 Anders Carlsson <​andersca@apple.com>

Reviewed by Kevin Decker.

Fix <rdar://problem/6623697>.


  • Plugins/Hosted/NetscapePluginInstanceProxy.h:
  • Plugins/Hosted/NetscapePluginInstanceProxy.mm: (WebKit::NetscapePluginInstanceProxy::print): Ask the plug-in host to print, create a CGImage of the returned bytes and draw the image into the passed in context.


  • Plugins/Hosted/WebHostedNetscapePluginView.mm: (-[WebHostedNetscapePluginView drawRect:]): When printing, call NetscapePluginInstanceProxy::print.


  • Plugins/Hosted/WebKitPluginHost.defs:
11:43 AM Changeset in webkit [41263] by Dimitri Glazkov
  • 1 edit
    3 adds in trunk/WebCore

2009-02-26 Dimitri Glazkov <Dimitri Glazkov>

Reviewed by Eric Seidel.

​https://bugs.webkit.org/show_bug.cgi?id=24182
Add NodeFilter, NodeIterator, and TreeWalker custom V8 bindings.

  • bindings/v8/custom/V8NodeFilterCustom.cpp: Added. (WebCore::CALLBACK_FUNC_DECL):
  • bindings/v8/custom/V8NodeIteratorCustom.cpp: Added. (WebCore::toV8): (WebCore::CALLBACK_FUNC_DECL):
  • bindings/v8/custom/V8TreeWalkerCustom.cpp: Added. (WebCore::toV8): (WebCore::CALLBACK_FUNC_DECL):
11:40 AM Changeset in webkit [41262] by ap@webkit.org
  • 4 edits in trunk

Reviewed by Darin Adler.

​https://bugs.webkit.org/show_bug.cgi?id=23500
KURL::parse() incorrectly compares its result to original string

  • platform/KURL.cpp: (WebCore::KURL::parse): Take string length into account.
11:35 AM Changeset in webkit [41261] by Dimitri Glazkov
  • 1 edit
    1 add in trunk/WebCore

2009-02-26 Ojan Vafai <​ojan@chromium.org>

Reviewed by Kevin McCullough.

Manual test for inspector node highlighting.

  • manual-tests/inspector/highlight-nodes.html: Added.
11:32 AM Changeset in webkit [41260] by darin@chromium.org
  • 2 edits in trunk/WebCore

2009-02-16 Anantanarayanan Iyengar <​ananta@chromium.org>

Reviewed by Darin Fisher.

​https://bugs.webkit.org/show_bug.cgi?id=23973
ScrollView::scrollContents can be invoked during view shutdown. In
this scenario the FrameView::hostWindow method can return NULL, which
indicates that the frame/page is being destroyed. This causes a crash
when we try to dereference a NULL hostWindow pointer. Fix is to add a
NULL check for this.

  • platform/ScrollView.cpp: (WebCore::ScrollView::scrollContents):
11:11 AM Changeset in webkit [41259] by Dimitri Glazkov
  • 3 edits
    2 adds in trunk

WebCore:

2009-02-26 Rahul Kuchhal <​kuchhal@chromium.org>

Reviewed by Dave Hyatt.

​https://bugs.webkit.org/show_bug.cgi?id=24003
Fix a crash caused by unsafe type conversion.

Test: fast/block/positioning/absolute-in-inline-rtl-4.html

  • rendering/RenderBox.cpp: (WebCore::RenderBox::calcAbsoluteHorizontalValues):

LayoutTests:

2009-02-26 Rahul Kuchhal <​kuchhal@chromium.org>

Reviewed by Dave Hyatt.

​https://bugs.webkit.org/show_bug.cgi?id=24003
Fix a crash caused by unsafe type conversion.

  • fast/block/positioning/absolute-in-inline-rtl-4-expected.txt: Added.
  • fast/block/positioning/absolute-in-inline-rtl-4.html: Added.
10:59 AM Changeset in webkit [41258] by Dimitri Glazkov
  • 2 edits in trunk/WebCore

2009-02-26 Ojan Vafai <​ojan@chromium.org>

Reviewed by Adam Roben.

​https://bugs.webkit.org/show_bug.cgi?id=24202
Have drawNodeHighlight clip instead of clearing. This makes it work for
both Safari and Chromium since Chromium draws the inspector highlighting
in the same buffer as the page.

  • inspector/InspectorController.cpp: (WebCore::quadToPath): (WebCore::drawOutlinedQuad): (WebCore::drawOutlinedQuadWithClip): (WebCore::drawHighlightForBox):
10:45 AM Changeset in webkit [41257] by hyatt@apple.com
  • 3 edits
    4 adds in trunk

WebCore:

2009-02-26 David Hyatt <​hyatt@apple.com>

Reviewed by Dan Bernstein & Darin Adler

Make sure the border/padding are properly omitted at the start of an inline that is a continuation.


Added fast/inline/inline-continuation-borders.html

  • rendering/InlineFlowBox.cpp: (WebCore::InlineFlowBox::determineSpacingForFlowBoxes):

LayoutTests:

2009-02-26 David Hyatt <​hyatt@apple.com>

Reviewed by Dan Bernstein & Darin Adler

Make sure the border/padding are properly omitted at the start of an inline that is a continuation.

  • fast/inline/inline-continuation-borders.html: Added.
  • platform/mac/fast/inline/inline-continuation-borders-expected.checksum: Added.
  • platform/mac/fast/inline/inline-continuation-borders-expected.png: Added.
  • platform/mac/fast/inline/inline-continuation-borders-expected.txt: Added.
10:30 AM Changeset in webkit [41256] by ap@webkit.org
  • 4 edits in trunk/WebKit

Reviewed by Darin Adler.

​https://bugs.webkit.org/show_bug.cgi?id=24024
REGRESSION (r39845): Assertion failure in -[WebHistoryItem dictionaryRepresentation] when
archiving a submission to about:blank

I don't know how to make an automated test for this bug.

  • History/WebHistory.mm: (-[WebHistory _visitedURL:withTitle:method:wasFailure:]):
  • WebHistory.cpp: (WebHistory::visitedURL): Account for the fact that HTTP method may be non-empty for non-HTTP requests.
10:21 AM Changeset in webkit [41255] by Simon Fraser
  • 2 edits in trunk/WebCore

2009-02-26 Simon Fraser <Simon Fraser>

Build fix, no review.

Try to fix the wx build after r41218.

  • WebCoreSources.bkl:
10:19 AM Changeset in webkit [41254] by pam@chromium.org
  • 1 edit
    2 adds in trunk/LayoutTests

2009-02-25 Pamela Greene <​pam@chromium.org>

Reviewed by Darin Fisher.

Add test that custom DOM properties survive garbage collection.
​https://bugs.webkit.org/show_bug.cgi?id=24142

  • fast/dom/Window/customized-property-survives-gc-expected.txt: Added.
  • fast/dom/Window/customized-property-survives-gc.html: Added.
10:17 AM Changeset in webkit [41253] by ap@webkit.org
  • 4 edits
    2 adds in trunk

Reviewed by Darin Adler.

​https://bugs.webkit.org/show_bug.cgi?id=19527
ASSERTION FAILED: containerA && containerB

Test: fast/dom/Range/bug-19527.html

  • dom/Range.cpp: (WebCore::Range::isPointInRange): (WebCore::Range::comparePoint): Bring the behavior in line with current Firefox, making it impossible for these methods to pass a null container to compareBoundaryPoints().
9:08 AM Changeset in webkit [41252] by zecke@webkit.org
  • 2 edits in trunk/JavaScriptCore

2009-02-26 Carol Szabo <​carol.szabo@nokia.com>

Reviewed by Darin Adler.

​https://bugs.webkit.org/show_bug.cgi?id=24099
ARM Compiler Warnings in pcre_exec.cpp

  • pcre/pcre_exec.cpp: (match):
8:48 AM Changeset in webkit [41251] by zecke@webkit.org
  • 3 edits
    1 add in trunk

2009-02-26 Xan Lopez <​xan@gnome.org>

Reviewed by Holger Freyther.

​https://bugs.webkit.org/show_bug.cgi?id=16947
[GTK] Missing HTTP Auth challenge

Take marshallers to be built from a manually maintained list
instead of grepping the sources.

It's much faster, especially so now that we want to add
marshallers from WebCore too. A system to only take into account
the modified files when generating the marshallers from sources
could be hacked, but I think it's overkill considering how rarely
a new marshaller is added.

8:40 AM Changeset in webkit [41250] by zecke@webkit.org
  • 1 edit in trunk/WebKit/gtk/ChangeLog

Fix the ChangeLog s/frame/content.

I should have read more about the bug history and should have
done the substitution before landing.

8:33 AM Changeset in webkit [41249] by zecke@webkit.org
  • 2 edits in trunk/WebKit/gtk

2009-02-26 Xan Lopez <​xan@gnome.org>

Reviewed by Alexey Proskuryakov.

​https://bugs.webkit.org/show_bug.cgi?id=24193
[GTK] Checkbuttons not activated with space

Do not swallow key events with GtkIMContext for non-editable
frames (FIXME: I don't think frame is the right name here).

  • WebCoreSupport/EditorClientGtk.cpp: (WebKit::EditorClient::handleInputMethodKeydown):
8:27 AM Changeset in webkit [41248] by zecke@webkit.org
  • 2 edits in trunk/WebKit/gtk

2009-02-26 Xan Lopez <​xan@gnome.org>

Reviewed by Alexey Proskuryakov.

​https://bugs.webkit.org/show_bug.cgi?id=24103
[GTK] Use correct return value for WebView button-release handler

We are returning whatever the core code tells us it did, but this
does not play well with the GTK+ model. GTK+ in general expects it
will see a button-release if it saw a button-press and no
motion/leave/etc events in between. EventHandler.cpp will, in some
cases, not handle press but handle release, confusing the parent
container of the WebView.

As a workaround return always FALSE for button-release (this is
the same than the Windows port does).

  • webkit/webkitwebview.cpp:
8:21 AM Changeset in webkit [41247] by zecke@webkit.org
  • 4 edits in trunk/WebKit/gtk

2009-02-26 Xan Lopez <​xan@gnome.org>

Reviewed by Holger Freyther.

​https://bugs.webkit.org/show_bug.cgi?id=17585
[gtk] get|set encoding api

Add functions to get and set a custom encoding an a view.

  • webkit/webkitprivate.h:
  • webkit/webkitwebview.cpp: (webkit_web_view_set_custom_encoding): (webkit_web_view_get_custom_encoding):
  • webkit/webkitwebview.h:
8:14 AM Changeset in webkit [41246] by zecke@webkit.org
  • 2 edits in trunk/WebCore

Make font-variant:small-caps work properly (bug #20358)

Set the computed size of the small caps font data rather than the specified size
so that the small-caps text is rendered smaller

6:13 AM Changeset in webkit [41245] by treat@webkit.org
  • 2 edits in trunk/WebCore

2009-02-26 Benjamin Meyer <​benjamin.meyer@torchmobile.com>

Reviewed by George Staikos.

​https://bugs.webkit.org/show_bug.cgi?id=24062
QNetworkCookieJar expects the url and not the policy url. Sending the
policy url will cause QNetworkCookieJar to behave incorrectly. One
example would be a cookie that does not have a path or domain.
QNetworkCookieJar will use the url it is given to fill in default values.
This allows setting cookies on the url of the main frame from an iFrame
when the cookie should be set on the url of the iFrame.

Originally noticed on ​http://writer.zoho.com/jsp/home.jsp?serviceurl=/index.do

  • platform/qt/CookieJarQt.cpp: (WebCore::setCookies):
3:09 AM Changeset in webkit [41244] by staikos@webkit.org
  • 3 edits in trunk/WebCore

2009-02-26 Charles Wei <​charles.wei@torchmobile.com.cn>

Reviewed by George Staikos.

make WebKit/Qt compile with SVG disabled

  • WebCore.pro:
  • platform/graphics/qt/FontPlatformDataQt.cpp:
Note: See TracTimeline for information about the timeline view.