⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Mar 3, 2009:

11:20 PM Changeset in webkit [41418] by darin@chromium.org
  • 2 edits in trunk/WebCore

2009-03-03 Mike Belshe <​mike@belshe.com>

Reviewed by Alexey Proskuryakov.

​https://bugs.webkit.org/show_bug.cgi?id=21939
Uninitialized ExceptionCode in DOMWindow::postMessage

  • dom/MessagePort.cpp: (WebCore::MessagePort::postMessage):
10:49 PM Changeset in webkit [41417] by ddkilzer@apple.com
  • 11 edits in trunk

<rdar://problem/6581203> WebCore and WebKit should install the same set of headers during installhdrs phase as build phase

Reviewed by Mark Rowe.

JavaScriptCore:

  • Configurations/Base.xcconfig: Defined REAL_PLATFORM_NAME based on PLATFORM_NAME to work around the missing definition on Tiger. Updated HAVE_DTRACE to use REAL_PLATFORM_NAME.

WebCore:

The fix is to add INSTALLHDRS_COPY_PHASE = YES and
INSTALLHDRS_SCRIPT_PHASE = YES to WebCore.xcconfig, then to make
sure various build phase scripts work with the installhdrs build
phase.

  • Configurations/Base.xcconfig: Defined REAL_PLATFORM_NAME based on PLATFORM_NAME to work around the missing definition on Tiger.
  • Configurations/WebCore.xcconfig: Added JAVASCRIPTCORE_PRIVATE_HEADERS_DIR variable to simplify logic in the "Generate Derived Sources" script. Added INSTALLHDRS_COPY_PHASE = YES and INSTALLHDRS_SCRIPT_PHASE = YES.
  • WebCore.xcodeproj/project.pbxproj:
  • Added shell code to prevent running "Check For Global Initializers", "Check For Exit Time Destructors" and "Check For Weak VTables" scripts during the installhdrs build phase.
  • Made "Generate Derived Sources" work for the installhdrs build phase. Also simplified setting of CREATE_HASH_TABLE by using JAVASCRIPTCORE_PRIVATE_HEADERS_DIR.

WebKit:

The fix is to add INSTALLHDRS_COPY_PHASE = YES and
INSTALLHDRS_SCRIPT_PHASE = YES to WebKit.xcconfig, then to
make sure various build phase scripts work with the installhdrs
build phase.

  • WebKit.xcodeproj/project.pbxproj:
  • Added shell code to prevent running "Check For Global Initializers", "Check For Exit Time Destructors" and "Check For Weak VTables" scripts during the installhdrs build phase.
  • Removed UMBRELLA_FRAMEWORKS_DIR from the Debug and Release targets since it's no longer needed after defining WEBCORE_PRIVATE_HEADERS_DIR in WebKit.xcconfig.

WebKit/mac:

The fix is to add INSTALLHDRS_COPY_PHASE = YES and
INSTALLHDRS_SCRIPT_PHASE = YES to WebKit.xcconfig, then to
make sure various build phase scripts work with the installhdrs
build phase.

  • Configurations/Base.xcconfig: Defined REAL_PLATFORM_NAME based on PLATFORM_NAME to work around the missing definition on Tiger.
  • Configurations/WebKit.xcconfig: Added WEBCORE_PRIVATE_HEADERS_DIR variable to remove definition of UMBRELLA_FRAMEWORKS_DIR for Debug and Release builds in the Xcode project file. Added INSTALLHDRS_COPY_PHASE = YES and INSTALLHDRS_SCRIPT_PHASE = YES.
10:09 PM Changeset in webkit [41416] by darin@chromium.org
  • 6 edits
    2 moves in trunk/WebCore

2009-03-02 Adam Langley <​agl@google.com>

Reviewed by Darin Fisher.

Chromium Linux: Switch to using Skia to render widgets.

In order to sandbox the Chromium renderer on Linux we need to remove
the X connection. GTK cannot render without an X connection so, for
now, we render widgets ourselves.

Previously didn't use anti-alias fonts in order to match Windows font
rendering exactly. This was helpful when bootstrapping our layout
tests. Now, however, we are ready to enable it.

​https://bugs.webkit.org/show_bug.cgi?id=24244

  • platform/chromium/ScrollbarThemeChromium.cpp: (WebCore::ScrollbarThemeChromium::buttonSize):
  • platform/chromium/ScrollbarThemeChromiumLinux.cpp: (WebCore::ScrollbarThemeChromium::scrollbarThickness): (WebCore::ScrollbarThemeChromium::paintTrackPiece): (WebCore::ScrollbarThemeChromium::paintButton): (WebCore::ScrollbarThemeChromium::paintThumb):
  • platform/graphics/chromium/FontPlatformDataLinux.cpp: (WebCore::FontPlatformData::setupPaint):
  • platform/graphics/skia/PlatformContextSkia.cpp: (PlatformContextSkia::PlatformContextSkia): (PlatformContextSkia::~PlatformContextSkia):
  • platform/graphics/skia/PlatformContextSkia.h:
  • rendering/RenderThemeChromiumGtk.cpp: Removed.
  • rendering/RenderThemeChromiumGtk.h: Removed.
  • rendering/RenderThemeChromiumLinux.cpp: Added.
  • rendering/RenderThemeChromiumLinux.h: Added.
9:39 PM Changeset in webkit [41415] by Dimitri Glazkov
  • 2 edits in trunk/WebCore

2009-03-03 Dimitri Glazkov <Dimitri Glazkov>

Reviewed by Darin Fisher.

​https://bugs.webkit.org/show_bug.cgi?id=24261
Fix return types.

Test: LayoutTests/dom/svg/level3/xpath/XPathEvaluator_evaluate_TYPE_ERR.svg

  • bindings/v8/V8Binding.h: (WebCore::toInt32): change return type to int (WebCore::toFloat): change return type to float.
5:10 PM Changeset in webkit [41414] by andersca@apple.com
  • 7 edits in trunk

WebCore:

2009-03-03 Anders Carlsson <​andersca@apple.com>

Reviewed by John Sullivan.

​https://bugs.webkit.org/show_bug.cgi?id=22884
<rdar://problem/6449783>
modified layout test crashes Safari

Null check NPStream before dereferencing it.


  • plugins/PluginView.cpp: (WebCore::PluginView::destroyStream):

WebKitTools:

2009-03-03 Anders Carlsson <​andersca@apple.com>

Reviewed by John Sullivan.

​https://bugs.webkit.org/show_bug.cgi?id=22884
<rdar://problem/6449783>
modified layout test crashes Safari

Add destroyNullStream test function to the test plug-in.


  • DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp: (destroyNullStream): (pluginInvoke):

LayoutTests:

2009-03-03 Anders Carlsson <​andersca@apple.com>

Reviewed by John Sullivan.

​https://bugs.webkit.org/show_bug.cgi?id=22884
<rdar://problem/6449783>
modified layout test crashes Safari


Update tests.

  • plugins/destroy-stream-twice-expected.txt:
  • plugins/destroy-stream-twice.html:
5:06 PM Changeset in webkit [41413] by eric.carlson@apple.com
  • 117 edits in trunk/LayoutTests

2009-03-03 Eric Carlson <​eric.carlson@apple.com>

Reviewed by Simon Fraser.


​https://bugs.webkit.org/show_bug.cgi?id=24294
Bug 24294: Improve media layout test logging


Make all media layout tests log the condition that is being tested,
success or failure, plus observed value when a test condition fails
so it is possible to see exactly what failed without having to hack
the test source. Consolidate some of the logic in the shared JavaScript file.

  • media/audio-constructor-expected.txt:
  • media/audio-constructor-src-expected.txt:
  • media/audio-constructor-src.html:
  • media/audio-constructor.html:
  • media/audio-mpeg-supported-expected.txt:
  • media/audio-mpeg-supported.html:
  • media/broken-video-expected.txt:
  • media/broken-video.html:
  • media/constructors-expected.txt:
  • media/constructors.html:
  • media/loopend-limits-expected.txt:
  • media/loopstart-limits-expected.txt:
  • media/progress-event-expected.txt:
  • media/progress-event-total-expected.txt:
  • media/progress-event-total.html:
  • media/progress-event.html:
  • media/remove-from-document-expected.txt:
  • media/remove-from-document-no-load-expected.txt:
  • media/remove-from-document-no-load.html:
  • media/remove-from-document.html:
  • media/unsupported-rtsp-expected.txt:
  • media/unsupported-rtsp.html:
  • media/unsupported-tracks-expected.txt:
  • media/unsupported-tracks.html:
  • media/video-append-source-expected.txt:
  • media/video-append-source.html:
  • media/video-autoplay-expected.txt:
  • media/video-autoplay.html:
  • media/video-buffered-expected.txt:
  • media/video-buffered.html:
  • media/video-controls-expected.txt:
  • media/video-controls-transformed-expected.txt:
  • media/video-controls-transformed.html:
  • media/video-controls.html:
  • media/video-currentTime-expected.txt:
  • media/video-currentTime-set.html:
  • media/video-currentTime-set2-expected.txt:
  • media/video-currentTime-set2.html:
  • media/video-currentTime.html:
  • media/video-dom-autoplay-expected.txt:
  • media/video-dom-autoplay.html:
  • media/video-dom-end-expected.txt:
  • media/video-dom-end.html:
  • media/video-dom-loopcount-expected.txt:
  • media/video-dom-loopcount.html:
  • media/video-dom-loopend-expected.txt:
  • media/video-dom-loopend.html:
  • media/video-dom-loopstart-expected.txt:
  • media/video-dom-loopstart.html:
  • media/video-dom-src-expected.txt:
  • media/video-dom-src.html:
  • media/video-dom-start-expected.txt:
  • media/video-dom-start.html:
  • media/video-end-expected.txt:
  • media/video-end.html:
  • media/video-error-abort-expected.txt:
  • media/video-error-abort.html:
  • media/video-error-does-not-exist-expected.txt:
  • media/video-error-does-not-exist.html:
  • media/video-load-networkState-expected.txt:
  • media/video-load-networkState.html:
  • media/video-load-readyState-expected.txt:
  • media/video-load-readyState.html:
  • media/video-loopcount-expected.txt:
  • media/video-loopcount.html:
  • media/video-loopend-expected.txt:
  • media/video-loopend.html:
  • media/video-loopstart-expected.txt:
  • media/video-loopstart.html:
  • media/video-muted-expected.txt:
  • media/video-muted.html:
  • media/video-no-autoplay-expected.txt:
  • media/video-no-autoplay.html:
  • media/video-pause-empty-events-expected.txt:
  • media/video-pause-empty-events.html:
  • media/video-play-empty-events-expected.txt:
  • media/video-play-empty-events.html:
  • media/video-play-pause-events-expected.txt:
  • media/video-play-pause-events.html:
  • media/video-poster-expected.txt:
  • media/video-poster.html:
  • media/video-seek-past-end-paused-expected.txt:
  • media/video-seek-past-end-paused.html:
  • media/video-seek-past-end-playing-expected.txt:
  • media/video-seek-past-end-playing.html:
  • media/video-seekable-expected.txt:
  • media/video-seekable.html:
  • media/video-seeking-expected.txt:
  • media/video-seeking.html:
  • media/video-size-expected.txt:
  • media/video-size.html:
  • media/video-source-expected.txt:
  • media/video-source-media-expected.txt:
  • media/video-source-media.html:
  • media/video-source-type-expected.txt:
  • media/video-source-type-params-expected.txt:
  • media/video-source-type-params.html:
  • media/video-source-type.html:
  • media/video-source.html:
  • media/video-src-change-expected.txt:
  • media/video-src-change.html:
  • media/video-src-expected.txt:
  • media/video-src-remove-expected.txt:
  • media/video-src-remove.html:
  • media/video-src-set-expected.txt:
  • media/video-src-set.html:
  • media/video-src-source-expected.txt:
  • media/video-src-source.html:
  • media/video-src.html:
  • media/video-start-expected.txt:
  • media/video-start.html:
  • media/video-test.js: (test): (testExpected): (waitForEvent._eventCallback): (waitForEvent): (waitForEventAndTest._eventCallback): (waitForEventAndTest): (testException): (logResult):
  • media/video-volume-expected.txt:
  • media/video-volume.html:
  • media/video-width-height-expected.txt:
  • media/video-width-height.html:
4:44 PM Changeset in webkit [41412] by eric.carlson@apple.com
  • 3 edits in trunk/WebCore

2009-03-03 Eric Carlson <​eric.carlson@apple.com>

Reviewed by Simon Fraser.

Fix for <rdar://problem/6641045>
Don't call QTKit to get movie properties until movie metadata has been loaded.

  • platform/graphics/mac/MediaPlayerPrivateQTKit.h: (WebCore::MediaPlayerPrivate::metaDataAvailable): defined
  • platform/graphics/mac/MediaPlayerPrivateQTKit.mm: (WebCore::MediaPlayerPrivate::createQTTime): return default if !metaDataAvailable. (WebCore::MediaPlayerPrivate::play): Ditto. (WebCore::MediaPlayerPrivate::pause): Ditto. (WebCore::MediaPlayerPrivate::duration): Ditto. (WebCore::MediaPlayerPrivate::currentTime): Ditto. (WebCore::MediaPlayerPrivate::seek): Ditto. (WebCore::MediaPlayerPrivate::seekTimerFired): Ditto. (WebCore::MediaPlayerPrivate::paused): Ditto. (WebCore::MediaPlayerPrivate::seeking): Ditto. (WebCore::MediaPlayerPrivate::naturalSize): Ditto. (WebCore::MediaPlayerPrivate::hasVideo): Ditto. (WebCore::MediaPlayerPrivate::setVolume): Ditto. (WebCore::MediaPlayerPrivate::setRate): Ditto. (WebCore::MediaPlayerPrivate::dataRate): Ditto. (WebCore::MediaPlayerPrivate::maxTimeLoaded): Ditto. (WebCore::MediaPlayerPrivate::totalBytes): Ditto.
4:38 PM Changeset in webkit [41411] by kmccullough@apple.com
  • 2 edits
    2 adds in trunk/LayoutTests

2009-03-03 Kevin McCullough <​kmccullough@apple.com>

Reviewed by Oliver Hunt.

<rdar://problem/6031674> JSProfiler: Multiple anonymous functions get
the same entry in profiler if called from same function

  • This no longer happens but I thought I'd make a test case anyway.
  • fast/profiler/multiple-anonymous-functions-called-from-the-same-function-expected.txt: Added.
  • fast/profiler/multiple-anonymous-functions-called-from-the-same-function.html: Added.
  • fast/profiler/resources/profiler-test-JS-resources.js: (anotherAnonymousFunction):
4:08 PM Changeset in webkit [41410] by kmccullough@apple.com
  • 2 edits in trunk/WebCore

2009-03-03 Kevin McCullough <​kmccullough@apple.com>

  • Spelling fix.
  • page/Console.cpp: (WebCore::Console::profile):
3:30 PM Changeset in webkit [41409] by ddkilzer@apple.com
  • 4 edits in trunk/WebKit

Remove last vestiges of JAVASCRIPTCORE_PRIVATE_HEADERS_DIR from WebKit

Reviewed by Adam Roben.

Use of JAVASCRIPTCORE_PRIVATE_HEADERS_DIR was removed in r37465
since NPAPI headers had migrated from JavaScriptCore to WebCore
before that.

WebKit:

  • WebKit.xcodeproj/project.pbxproj: Removed JAVASCRIPTCORE_PRIVATE_HEADERS_DIR build setting from from Debug and Release configurations.

WebKit/mac:

  • Configurations/WebKit.xcconfig: Removed definition of JAVASCRIPTCORE_PRIVATE_HEADERS_DIR used in Production builds.
2:57 PM Changeset in webkit [41408] by Dimitri Glazkov
  • 2 edits in trunk/WebCore

2009-03-03 Dimitri Glazkov <Dimitri Glazkov>

Reviewed by Darin Fisher.

​https://bugs.webkit.org/show_bug.cgi?id=23657
Remove Database API callback IDLs from the project.
They were removed in r40633.

  • WebCore.xcodeproj/project.pbxproj: Removed IDL files from the project.
2:47 PM Changeset in webkit [41407] by kmccullough@apple.com
  • 5 edits
    2 adds in trunk

JavaScriptCore:

2009-03-03 Kevin McCullough <​kmccullough@apple.com>

Reviewed by Oliver Hunt.

<rdar://problem/6639110> console.profile() doesn't work without a title

  • profiler/Profiler.cpp: (JSC::Profiler::startProfiling): assert if there is not title to ensure we don't start profiling without one.

WebCore:

2009-03-03 Kevin McCullough <​kmccullough@apple.com>

Reviewed by Oliver Hunt.

<rdar://problem/6639110> console.profile() doesn't work without a title

  • page/Console.cpp: (WebCore::Console::profile): If there is no title assume this is a user initiated profile and give it the next incremented title name.

LayoutTests:

2009-03-03 Kevin McCullough <​kmccullough@apple.com>

Reviewed by Oliver Hunt.

<rdar://problem/6639110> console.profile() doesn't work without a title

  • fast/profiler/profile-with-no-title-expected.txt: Added.
  • fast/profiler/profile-with-no-title.html: Added.
2:27 PM Changeset in webkit [41406] by timothy@apple.com
  • 1 edit in trunk/WebCore/ChangeLog

Add bug URLs for my last commit.

2:25 PM Changeset in webkit [41405] by pam@chromium.org
  • 1 edit
    6 deletes in trunk/LayoutTests

2009-03-03 Pamela Greene <​pam@chromium.org>

Remove junk files that must have been accidentally committed.
Submitted without review.

  • fast/block/float/t0905-c414-flt-fit-01-d-g.html.orig: Removed.
  • fast/block/float/t0905-c414-flt-fit-01-d-g.html.rej: Removed.
  • fast/block/float/t0905-c5525-fltblck-00-d-ag.html.orig: Removed.
  • fast/block/float/t0905-c5525-fltblck-00-d-ag.html.rej: Removed.
  • fast/block/float/t0905-c5526-flthw-00-c-g.html.orig: Removed.
  • fast/block/float/t0905-c5526-flthw-00-c-g.html.rej: Removed.
2:24 PM Changeset in webkit [41404] by timothy@apple.com
  • 8 edits
    1 add in trunk/WebCore

Fix a regression that broke dirxml and caused an ASSERT in debug builds. Also simplified
the console code and refactored things to have fewer code paths and duplication.

Reviewed by Kevin McCullough.

Test: manual-tests/inspector/console-dir.html

  • bindings/js/JSInspectedObjectWrapper.cpp: (WebCore::JSInspectedObjectWrapper::wrap): Use the lexicalGlobalObject instead of dynamicGlobalObject to fix an ASSERT about using a wrapper from the wrong ExecState.
  • bindings/js/JSQuarantinedObjectWrapper.cpp: (WebCore::JSQuarantinedObjectWrapper::JSQuarantinedObjectWrapper): Ditto. (WebCore::JSQuarantinedObjectWrapper::allowsUnwrappedAccessFrom): Ditto.
  • inspector/front-end/Console.js: (WebInspector.Console.prototype._format): Remove the inline argument and add forceObjectFormat. When forceObjectFormat is true, the only formatter used is _formatobject. (WebInspector.Console.prototype._formatvalue): Remove the inline argument. (WebInspector.Console.prototype._formatstring): Ditto. (WebInspector.Console.prototype._formatregexp): Ditto. (WebInspector.Console.prototype._formatarray): Ditto. (WebInspector.Console.prototype._formatnode): Remove the inline argument and make a DOM tree instead of an anchor. (WebInspector.Console.prototype._formatobject): Remove the inline argument and always make a property graph. (WebInspector.Console.prototype._formaterror): Remove the inline argument. (WebInspector.ConsoleMessage): Remove the case for MessageLevel.Node and simplify the case for MessageLevel.Object to use the normal _format code path with the %O formatter. (WebInspector.ConsoleMessage.prototype._format.formatForConsole): Don't pass an additional true argument for inline. (WebInspector.ConsoleMessage.prototype._format.formatAsObjectForConsole): Added. Pass a true argument for forceObjectFormat. (WebInspector.ConsoleMessage.prototype._format): Added support for the %O formatter. Use formatForConsole for all arguments. (WebInspector.ConsoleMessage.prototype.toString): Add the other message levels.
  • inspector/front-end/inspector.css: Tweak styles to look and work correctly.
  • inspector/front-end/utilities.js: (Object.type): Return "node" for Node objects. (Object.describe): Handle the "node" type.
  • page/Console.cpp: (WebCore::printMessageSourceAndLevelPrefix): Fix an assert by adding the other message level types. (WebCore::Console::dirxml): Use the standard log fuction since it prints a DOM tree for nodes by default.
  • page/Console.h: (WebCore::enum MessageLevel): Removed NodeMessageLevel. Added a FIXME.
1:07 PM Changeset in webkit [41403] by Dimitri Glazkov
  • 3 edits
    2 adds in trunk

WebCore:

2009-03-03 Scott Violet <​sky@google.com>

Reviewed by Eric Seidel.

​https://bugs.webkit.org/show_bug.cgi?id=24325
Crash on replacing document contents during drop.

Makes sure a node is in the document during a move before using it.

Test: fast/events/crash-on-mutate-during-drop.html

  • editing/MoveSelectionCommand.cpp: (WebCore::MoveSelectionCommand::doApply):

LayoutTests:

2009-03-03 Scott Violet <​sky@google.com>

Reviewed by Eric Seidel.

​https://bugs.webkit.org/show_bug.cgi?id=24325
Crash on replacing document contents during drop

Makes sure we don't crash during dnd with DOM mutation event listener
that mutates the document on drop.

  • fast/events/crash-on-mutate-during-drop-expected.txt: Added.
  • fast/events/crash-on-mutate-during-drop.html: Added.
11:53 AM Changeset in webkit [41402] by Dimitri Glazkov
  • 4 edits in trunk/WebCore

2009-03-03 Jungshik Shin <​jshin@chromium.org>

Reviewed by Eric Seidel.

​https://bugs.webkit.org/show_bug.cgi?id=23028
Enable dynamic web font support to Chromium on Windows.
Files that were omitted by mistake in the latest patch
that was landed.

  • loader/CachedFont.cpp: (WebCore::CachedFont::~CachedFont): (WebCore::CachedFont::ensureCustomFontData): (WebCore::CachedFont::platformDataFromCustomData): (WebCore::CachedFont::allClientsRemoved):
  • platform/graphics/chromium/FontCustomPlatformData.cpp: (WebCore::EOTStream::EOTStream): (WebCore::createFontCustomPlatformData):
  • platform/graphics/win/FontCustomPlatformData.cpp: (WebCore::EOTStream::EOTStream): (WebCore::createFontCustomPlatformData):
11:48 AM Changeset in webkit [41401] by kov@webkit.org
  • 12 edits
    2 adds in trunk

2009-03-03 Gustavo Noronha Silva <Gustavo Noronha Silva>

Reviewed by Alexey Proskuryakov.

​https://bugs.webkit.org/show_bug.cgi?id=16826
[Gtk] Implement WebKitDownload

Adding new files related to WebKitDownload to the GTK+ port.

  • GNUmakefile.am:

WebCore:

2009-03-03 Gustavo Noronha Silva <Gustavo Noronha Silva>

Reviewed by Alexey Proskuryakov.

​https://bugs.webkit.org/show_bug.cgi?id=16826
[Gtk] Implement WebKitDownload

Make the Soup backend able to handle requests without a frame,
since we may have such things now that we support downloads.

  • platform/network/ResourceHandleInternal.h:
  • platform/network/soup/ResourceHandleSoup.cpp: (WebCore::ResourceHandle::start):

WebKit/gtk:

2009-03-03 Gustavo Noronha Silva <Gustavo Noronha Silva>

Reviewed by Alexey Proskuryakov.

​https://bugs.webkit.org/show_bug.cgi?id=16826
[Gtk] Implement WebKitDownload

Implement download, and provide a nice object wrapping the
download process. Initial work done by Marco Barisione and
Pierre-Luc Beaudoin for Collabora.

  • WebCoreSupport/ContextMenuClientGtk.cpp: (WebKit::ContextMenuClient::downloadURL):
  • WebCoreSupport/FrameLoaderClientGtk.cpp: (WebKit::FrameLoaderClient::download): (WebKit::FrameLoaderClient::startDownload):
  • webkit/webkit.h:
  • webkit/webkitdefines.h:
  • webkit/webkitdownload.cpp: Added. (_WebKitDownloadPrivate::): (_WebKitDownloadPrivate::webkit_download_dispose): (_WebKitDownloadPrivate::webkit_download_finalize): (_WebKitDownloadPrivate::webkit_download_get_property): (_WebKitDownloadPrivate::webkit_download_set_property): (_WebKitDownloadPrivate::webkit_download_class_init): (_WebKitDownloadPrivate::webkit_download_init): (_WebKitDownloadPrivate::webkit_download_new): (_WebKitDownloadPrivate::webkit_download_open_stream_for_uri): (_WebKitDownloadPrivate::webkit_download_close_stream): (_WebKitDownloadPrivate::webkit_download_start): (_WebKitDownloadPrivate::webkit_download_cancel): (_WebKitDownloadPrivate::webkit_download_get_uri): (_WebKitDownloadPrivate::webkit_download_get_network_request): (_WebKitDownloadPrivate::webkit_download_set_response): (_WebKitDownloadPrivate::webkit_download_get_suggested_filename): (_WebKitDownloadPrivate::webkit_download_get_destination_uri): (_WebKitDownloadPrivate::webkit_download_set_destination_uri): (_WebKitDownloadPrivate::webkit_download_get_state): (_WebKitDownloadPrivate::webkit_download_get_total_size): (_WebKitDownloadPrivate::webkit_download_get_current_size): (_WebKitDownloadPrivate::webkit_download_get_progress): (_WebKitDownloadPrivate::webkit_download_get_elapsed_time): (_WebKitDownloadPrivate::webkit_download_received_data): (_WebKitDownloadPrivate::webkit_download_finished_loading): (_WebKitDownloadPrivate::webkit_download_error): (_WebKitDownloadPrivate::DownloadClient::DownloadClient): (_WebKitDownloadPrivate::DownloadClient::didReceiveResponse): (_WebKitDownloadPrivate::DownloadClient::didReceiveData): (_WebKitDownloadPrivate::DownloadClient::didFinishLoading): (_WebKitDownloadPrivate::DownloadClient::didFail): (_WebKitDownloadPrivate::DownloadClient::wasBlocked): (_WebKitDownloadPrivate::DownloadClient::cannotShowURL):
  • webkit/webkitdownload.h: Added.
  • webkit/webkitprivate.h:
  • webkit/webkitwebview.cpp:
  • webkitmarshal.list:
11:29 AM Changeset in webkit [41400] by andersca@apple.com
  • 3 edits in trunk/WebKit/mac

2009-03-03 Anders Carlsson <​andersca@apple.com>

Reviewed by Darin Adler.

Fix <rdar://problem/6633834>.


  • Plugins/Hosted/NetscapePluginHostManager.mm: (WebKit::NetscapePluginHostManager::instantiatePlugin): Create a new plug-in instance if the plug-in host has crashed.


  • Plugins/Hosted/NetscapePluginInstanceProxy.mm: (WebKit::NetscapePluginInstanceProxy::invalidate): Add a null check for the plug-in host proxy.
11:18 AM Changeset in webkit [41399] by Dimitri Glazkov
  • 2 edits
    4 copies
    1 add in trunk/WebCore

2009-03-03 Dimitri Glazkov <Dimitri Glazkov>

Reviewed by Eric Seidel.

​https://bugs.webkit.org/show_bug.cgi?id=24331
Add custom V8 bindings for Element, Attr, HTMLFrame, and HTMLIFrame.

  • bindings/v8/custom/V8AttrCustom.cpp: Added.
  • bindings/v8/custom/V8CustomBinding.cpp: Added.
  • bindings/v8/custom/V8CustomBinding.h: Added attribute-checking helpers.
  • bindings/v8/custom/V8ElementCustom.cpp: Added.
  • bindings/v8/custom/V8HTMLFrameElementCustom.cpp: Added.
  • bindings/v8/custom/V8HTMLIFrameElementCustom.cpp: Added.
11:08 AM Changeset in webkit [41398] by beidson@apple.com
  • 15 edits
    3 adds in trunk

WebCore:

2009-03-03 Brady Eidson <​beidson@apple.com>

Reviewed by Darin Adler

<rdar://problem/6616664> - Quick looks of various file types is broken

In ​http://trac.webkit.org/changeset/40553 there was an attempt to prevent NSURLRequest churn
for non-HTTP loads when the underlying ResourceRequest changed. Unfortunately it was a little
overzealous as the mainDocumentURL is relevant for all loads, not only HTTP/HTTPS loads.

Partially reverted behavior to always set the mainDocumentURL in situations when we would've
before that patch.

  • loader/FrameLoader.cpp: (WebCore::FrameLoader::addExtraFieldsToRequest):
  • platform/network/ResourceRequestBase.cpp: (WebCore::ResourceRequestBase::setMainDocumentURL):

WebKitTools:

2009-03-03 Brady Eidson <​beidson@apple.com>

Reviewed by Darin Adler

Support layout test covering <rdar://problem/6616664>

Change NSURLRequest/IWebURLRequest dumping to include the mainDocumentURL

  • DumpRenderTree/mac/ResourceLoadDelegate.mm: (-[NSURLRequest _drt_descriptionSuitableForTestResult]): Return both the request URL and the mainDocumentURL.


  • DumpRenderTree/win/ResourceLoadDelegate.cpp: (descriptionSuitableForTestResult): Return both the request URL and the mainDocumentURL.

LayoutTests:

2009-03-03 Brady Eidson <​beidson@apple.com>

Reviewed by Darin Adler

Layout test covering <rdar://problem/6616664> - Quick looks of various file types is broken

Added to test the changes:

  • fast/loader/main-document-url-for-non-http-loads-expected.txt: Added.
  • fast/loader/main-document-url-for-non-http-loads.html: Added.
  • fast/loader/resources/subframe-notify-done.html: Added.

Updated the following for the new info from dumpResourceLoadCallbacks():

  • http/tests/misc/window-dot-stop-expected.txt:
  • http/tests/xmlhttprequest/abort-should-cancel-load-expected.txt:
  • platform/mac-leopard/security/block-test-expected.txt:
  • platform/mac-tiger/http/tests/misc/willCacheResponse-delegate-callback-expected.txt:
  • platform/mac/http/tests/misc/willCacheResponse-delegate-callback-expected.txt:
  • platform/mac/webarchive/loading/cache-expired-subresource-expected.txt:
  • security/block-test-expected.txt:
  • webarchive/loading/test-loading-archive-expected.txt:
10:55 AM Changeset in webkit [41397] by cmarrin@apple.com
  • 2 edits in trunk/WebCore

Reviewed by Simon Fraser.

​https://bugs.webkit.org/show_bug.cgi?id=24256

Added a WebCoreForceSoftwareAnimation flag.

10:48 AM Changeset in webkit [41396] by cmarrin@apple.com
  • 11 edits
    2 adds in trunk

Reviewed by Sam Weinig.

​https://bugs.webkit.org/show_bug.cgi?id=24257

Added prototype properties for several classes with constructors that
were missing them, including the one mentioned in the bug.

10:46 AM Changeset in webkit [41395] by ariya@webkit.org
  • 3 edits in trunk/WebKit/qt

2009-03-03 Ariya Hidayat <​ariya.hidayat@trolltech.com>

Rubber-stamped by Simon Hausmann.

[Qt] Create and update the action for SelectAll.

  • Api/qwebpage.cpp: (QWebPagePrivate::updateAction): (QWebPagePrivate::updateEditorActions): (QWebPage::action):
  • tests/qwebpage/tst_qwebpage.cpp: (tst_QWebPage::textSelection):
10:38 AM Changeset in webkit [41394] by Dimitri Glazkov
  • 1 edit
    4 adds in trunk/WebCore

2009-03-03 Dimitri Glazkov <Dimitri Glazkov>

Reviewed by Darin Fisher.

​https://bugs.webkit.org/show_bug.cgi?id=24321
Add V8 bindings headers.

  • bindings/v8/V8Binding.h: Added.
  • bindings/v8/V8Proxy.h: Added.
  • bindings/v8/custom/V8CustomBinding.h: Added.
  • bindings/v8/custom/V8CustomEventListener.h: Added.
10:33 AM Changeset in webkit [41393] by Dimitri Glazkov
  • 1 edit
    20 adds in trunk/LayoutTests

2009-03-03 Jungshik Shin <​jshin@chromium.org>

Reviewed by Darin Adler.

​http://bugs.webkit.org/show_bug.cgi?id=23482
Add the following CSS 2.1 tests, with YinYang character (U+262F)
and SouthEast Arrow (U+2798) replaced by png images,
to fast/block/float. Leftward white arrow (U+21E6) is also
replaced by an ASCII-equivalent of '<-'.

css2.1/t0905-c414-flt-fit-01-d-g.html
css2.1/t0905-c5525-fltblck-00-d-ag.html
css2.1/t0905-c5526-flthw-00-c-g.html

On platforms where no font covers those characters (e.g. Windows),
the above tests can be skipped and the new tests can be used, instead.
They're equivalent in terms of what they test.

  • fast/block/float/resources/se_arrow.png: Added.
  • fast/block/float/resources/yinyang.png: Added.
  • fast/block/float/t0905-c414-flt-fit-01-d-g.html: Copied from LayoutTests/css2.1/t0905-c414-flt-fit-01-d-g.html.
  • fast/block/float/t0905-c5525-fltblck-00-d-ag.html: Copied from LayoutTests/css2.1/t0905-c5525-fltblck-00-d-ag.html.
  • fast/block/float/t0905-c5526-flthw-00-c-g.html: Copied from LayoutTests/css2.1/t0905-c5526-flthw-00-c-g.html.
  • platform/mac/fast/block/float/t0905-c414-flt-fit-01-d-g-expected.checksum: Added.
  • platform/mac/fast/block/float/t0905-c414-flt-fit-01-d-g-expected.png: Added.
  • platform/mac/fast/block/float/t0905-c414-flt-fit-01-d-g-expected.txt: Added.
  • platform/mac/fast/block/float/t0905-c5525-fltblck-00-d-ag-expected.checksum: Added.
  • platform/mac/fast/block/float/t0905-c5525-fltblck-00-d-ag-expected.png: Added.
  • platform/mac/fast/block/float/t0905-c5525-fltblck-00-d-ag-expected.txt: Added.
  • platform/mac/fast/block/float/t0905-c5526-flthw-00-c-g-expected.checksum: Added.
  • platform/mac/fast/block/float/t0905-c5526-flthw-00-c-g-expected.png: Added.
  • platform/mac/fast/block/float/t0905-c5526-flthw-00-c-g-expected.txt: Added.
10:21 AM Changeset in webkit [41392] by Dimitri Glazkov
  • 2 edits in trunk/WebCore

2009-03-03 Jungshik Shin <​jshin@chromium.org>

Reviewed by Eric Seidel.

​https://bugs.webkit.org/show_bug.cgi?id=23803
Fix an 'off-by-1' error in ChromiumWin's font fallback.

  • platform/graphics/chromium/FontCacheChromiumWin.cpp: (WebCore::FontCache::getFontDataForCharacters):
10:20 AM Changeset in webkit [41391] by Dimitri Glazkov
  • 1 edit in trunk/WebCore/ChangeLog

Fix ChangeLog dates.

10:18 AM Changeset in webkit [41390] by Dimitri Glazkov
  • 2 edits
    2 moves
    1 add in trunk/WebCore

2009-03-03 Jungshik Shin <​jshin@chromium.org>

Reviewed by Eric Seidel.

​http://bugs.webkit.org/show_bug.cgi?id=23028
Enable dynamic web font support to Chromium on Windows: Part 1

  • Move OpenTypeUtilities.{cpp,h} to platform/graphics/opentype from platform/graphics/win because both Windows port and Chromium Windows port will use them.
  • Adjust WebCore.vcproj accordingly.
  • WebCore.vcproj/WebCore.vcproj:
  • platform/graphics/opentype: Added.
  • platform/graphics/opentype/OpenTypeUtilities.cpp: Copied from WebCore/platform/graphics/win/OpenTypeUtilities.cpp.
  • platform/graphics/opentype/OpenTypeUtilities.h: Copied from WebCore/platform/graphics/win/OpenTypeUtilities.h.
  • platform/graphics/win/OpenTypeUtilities.cpp: Removed.
  • platform/graphics/win/OpenTypeUtilities.h: Removed.
10:10 AM Changeset in webkit [41389] by Simon Fraser
  • 6 edits in trunk/WebCore

2009-03-02 Simon Fraser <Simon Fraser>

Reviewed by Dave Hyatt

​https://bugs.webkit.org/show_bug.cgi?id=24312

Take 3D transforms into account when hit testing:

  1. Maintain a bit on each RenderLayer that is set when the layer has 3d descendants, so that we know when to fall into the slow hit testing path.
  1. Make a ref-counted HitTestingTransformState, which is used to store an accumulated transform, and the hit test point, and hitTestRect in the plane of the ancestor non-3d ('flattening') layer.

It's ref-counted so we can heap allocate it (to avoid stack bloat),
and avoid copying when hitTestLayer calls itself after applying the transform.

  1. Add logic to hitTestLayer to depth-test just direct descendants, if any have 3D transforms, or to do deep depth-testing when traversing a preserves-3d hierarchy. When hit, layers compute a z-offset from the ancestor flattening layer, which allows for correct depth testing.

The existing early-return codepath is unaffected when there are no 3d transforms
and no preserve-3d.

9:54 AM Changeset in webkit [41388] by brettw@chromium.org
  • 1 edit in trunk/WebCore/ChangeLog

Fix typo in ChangeLog from last commit.

9:52 AM Changeset in webkit [41387] by Simon Fraser
  • 4 edits in trunk/WebCore

2009-03-02 Simon Fraser <Simon Fraser>

Reviewed by Dave Hyatt

​https://bugs.webkit.org/show_bug.cgi?id=24312

Factor the code that compute a transform relative to the container
into RenderObject::transformFromContainer().

  • rendering/RenderBox.cpp: (WebCore::RenderBox::mapLocalToAbsolutePoint): (WebCore::RenderBox::mapAbsoluteToLocalPoint):
  • rendering/RenderObject.cpp: (WebCore::RenderObject::transformFromContainer):
  • rendering/RenderObject.h:
9:50 AM Changeset in webkit [41386] by brettw@chromium.org
  • 2 edits in trunk/WebCore

2009-03-02 Brett Wilson <​brettw@chromium.org>

Fix uninitialized memory reads in the Chromium Windows transparency
code that were identified by Purify,

Reviewed by Darin Disher.

  • platform/graphics/chromium/TransparencyWin.cpp: (WebCore::TransparencyWin::OwnedBuffers::OwnedBuffers): (WebCore::TransparencyWin::initializeNewContext):
9:43 AM Changeset in webkit [41385] by Simon Fraser
  • 2 edits in trunk/WebCore

2009-03-02 Simon Fraser <Simon Fraser>

Reviewed by Dave Hyatt

​https://bugs.webkit.org/show_bug.cgi?id=24317

Always return |true| from RenderTextControlMultiLine::nodeAtPoint() if
the superclass found a node, otherwise we set the innerNode of the
HitTestResult, but don't actually report that we found a hit.

  • rendering/RenderTextControlMultiLine.cpp: (WebCore::RenderTextControlMultiLine::nodeAtPoint):
9:31 AM Changeset in webkit [41384] by kov@webkit.org
  • 1 edit in trunk/WebCore/ChangeLog

Fixing bug number for last ChangeLog entry; thanks to Ariya for
catching this problem.

9:26 AM Changeset in webkit [41383] by kov@webkit.org
  • 3 edits
    1 add in trunk/WebCore

2009-03-03 Onne Gorter <​onne.gorter@avinity.net>

Reviewed by Anders Carlsson.

​https://bugs.webkit.org/show_bug.cgi?id=27385
resizing plugins does not work, because the plugin never gets informed

Make gtk plugins resize correctly, by sending them the setwindow event
correctly. Also ensure that all plugin eventing is done with correct
locking/calling. Mostly copied from mac implementation.

manual test: manual-tests/gtk/plugin-resize-scroll.html

  • plugins/PluginView.h:
  • plugins/gtk/PluginViewGtk.cpp: (WebCore::PluginView::dispatchNPEvent): ensure locking/calling for NPEvents (WebCore::PluginView::updatePluginWidget): if something changed, let setNPWindowIfNeeded handle it (WebCore::PluginView::paint): (WebCore::PluginView::handleKeyboardEvent): (WebCore::PluginView::handleMouseEvent): ensure calling conventions (WebCore::PluginView::setNPWindowRect): just pass control to setNPWindowIfNeeded (WebCore::PluginView::setNPWindowIfNeeded): event the plugin correctly of new window (WebCore::PluginView::init): init through the new setup
8:45 AM Changeset in webkit [41382] by ap@webkit.org
  • 1 edit
    2 adds in trunk/LayoutTests

Reviewed by Adam Roben.

​https://bugs.webkit.org/show_bug.cgi?id=4343
XMLHttpRequest doesn't work in a JavaScript-created window

The problem was fixed a while ago (r34506), just adding a test.

  • http/tests/xmlhttprequest/request-from-popup-expected.txt: Added.
  • http/tests/xmlhttprequest/request-from-popup.html: Added.
8:44 AM Changeset in webkit [41381] by ap@webkit.org
  • 1 edit in trunk/WebCore/ChangeLog

Adding bug URL and title to ChangeLog for a recent check-in.

8:06 AM Changeset in webkit [41380] by darin@chromium.org
  • 3 edits in trunk/WebCore

2009-03-03 Mike Belshe <​mike@belshe.com>

Reviewed by Darin Fisher.

  • dom/Document.idl:
  • html/HTMLCanvasElement.idl:

Mar 2, 2009:

10:15 PM Changeset in webkit [41379] by Simon Fraser
  • 3 edits
    2 adds in trunk

2009-03-02 Simon Fraser <Simon Fraser>

Reviewed by Adele Peterson

​https://bugs.webkit.org/show_bug.cgi?id=24313

If RenderTextControlSingleLine::nodeAtPoint() pokes a node into the
HitTestResult, then it had better well return |true|. And m_innerBlock
could never have been set as the hit node by the superclass, because
the superclass knows nothing about m_innerBlock.

Test: fast/forms/input-hit-test-border.html

  • rendering/RenderTextControlSingleLine.cpp: (WebCore::RenderTextControlSingleLine::nodeAtPoint):
6:24 PM Changeset in webkit [41378] by weinig@apple.com
  • 8 edits in trunk

JavaScriptCore:

2009-03-02 Sam Weinig <​sam@webkit.org>

Reviewed by Mark Rowe.

Enable Geolocation (except on Tiger and Leopard).

  • Configurations/JavaScriptCore.xcconfig:

WebCore:

2009-03-02 Sam Weinig <​sam@webkit.org>

Reviewed by Mark Rowe.

Enable Geolocation (except on Tiger and Leopard).

  • Configurations/WebCore.xcconfig:

WebKit/mac:

2009-03-02 Sam Weinig <​sam@webkit.org>

Reviewed by Mark Rowe.

Enable Geolocation (except on Tiger and Leopard).

  • Configurations/WebKit.xcconfig:

WebKitTools:

2009-03-02 Sam Weinig <​sam@webkit.org>

Reviewed by Mark Rowe.

Enable Geolocation (except on Tiger and Leopard).

  • Scripts/build-webkit:
6:12 PM Changeset in webkit [41377] by eric@webkit.org
  • 2 edits in trunk/WebCore

2009-03-02 Ojan Vafai <​ojan@chromium.org>

Reviewed by Adele Peterson.

Fix ​https://bugs.webkit.org/show_bug.cgi?id=24307
Null out m_highlightedNode on hideHighlight().
Ran WebCore/manual-tests/inspector/highlight-nodes.html.

  • inspector/InspectorController.cpp: (WebCore::InspectorController::hideHighlight):
5:51 PM Changeset in webkit [41376] by andersca@apple.com
  • 5 edits in trunk/WebKit/mac

2009-03-02 Anders Carlsson <​andersca@apple.com>

Reviewed by Dan Bernstein.

WebKit part of <rdar://problem/6638658>.


  • Plugins/Hosted/NetscapePluginHostManager.h:
  • Plugins/Hosted/NetscapePluginHostManager.mm: (WebKit::NetscapePluginHostManager::createPropertyListFile): Spawn the plug-in host and wait for it to create the property list.


  • Plugins/WebBasePluginPackage.mm: (-[WebBasePluginPackage createPropertyListFile]): Factor code out into a new method.


(-[WebBasePluginPackage pListForPath:createFile:]):
Call the newly added createPropertyListFile method.


  • Plugins/WebNetscapePluginPackage.mm: (-[WebNetscapePluginPackage createPropertyListFile]): Tell the plug-in host manager to create a property list file for us.
5:47 PM Changeset in webkit [41375] by weinig@apple.com
  • 13 edits
    2 adds in trunk

WebCore:

2009-03-02 Sam Weinig <​sam@webkit.org>

Reviewed by Geoffrey Garen.

Fix for <rdar://problem/6507404> Add Geolocation support.

This is not yet turned on for any Mac platform.

  • WebCore.xcodeproj/project.pbxproj:
  • page/Chrome.cpp: (WebCore::Chrome::shouldAllowGeolocationForFrame):
  • page/Chrome.h:
  • page/ChromeClient.h: (WebCore::ChromeClient::shouldAllowGeolocationForFrame):
  • page/Geolocation.cpp: (WebCore::Geolocation::Geolocation): (WebCore::Geolocation::disconnectFrame): Remove call to setUsingGeolocation as the document will not be alive at this point. (WebCore::Geolocation::getCurrentPosition): Check if the embedding app allows geolocation and return a PERMISSION_DENIED if not. (WebCore::Geolocation::watchPosition): Ditto. (WebCore::Geolocation::shouldAllowGeolocation): Perform request to embedding layer of whether to allow geolocation and cache the result.
  • page/Geolocation.h: (WebCore::Geolocation::):
  • platform/GeolocationService.cpp:
  • platform/GeolocationService.h: (WebCore::GeolocationService::~GeolocationService): (WebCore::GeolocationService::stopUpdating):
  • platform/mac/GeolocationServiceMac.h: Added. (WebCore::GeolocationServiceMac::lastPosition): (WebCore::GeolocationServiceMac::lastError):
  • platform/mac/GeolocationServiceMac.mm: Added. (WebCore::GeolocationService::create): (WebCore::GeolocationServiceMac::GeolocationServiceMac): (WebCore::GeolocationServiceMac::~GeolocationServiceMac): (WebCore::GeolocationServiceMac::startUpdating): (WebCore::GeolocationServiceMac::stopUpdating): (WebCore::GeolocationServiceMac::suspend): (WebCore::GeolocationServiceMac::resume): (WebCore::GeolocationServiceMac::positionChanged): (WebCore::GeolocationServiceMac::errorOccurred): (-[WebCoreCoreLocationObserver initWithCallback:]): (-[WebCoreCoreLocationObserver locationManager:didUpdateToLocation:fromLocation:]): (-[WebCoreCoreLocationObserver locationManager:didFailWithError:]):

WebKit/mac:

2009-03-02 Sam Weinig <​sam@webkit.org>

Reviewed by Geoffrey Garen.

Fix for <rdar://problem/6507404> Add Geolocation support.

This is not yet turned on for any Mac platform.

Add SPI to ask the embedding application whether to allow
Geolocation for an origin.

  • WebCoreSupport/WebChromeClient.h:
  • WebCoreSupport/WebChromeClient.mm: (WebChromeClient::shouldAllowGeolocationForFrame):
  • WebView/WebUIDelegatePrivate.h:
5:36 PM Changeset in webkit [41374] by andersca@apple.com
  • 2 edits in trunk/WebKit/mac

2009-03-02 Anders Carlsson <​andersca@apple.com>

Fix PowerPC build.

  • Plugins/WebNetscapePluginPackage.mm: (-[WebNetscapePluginPackage _tryLoad]):
5:36 PM UsingGitWithWebKit edited by ojan@chromium.org
(diff)
4:20 PM Changeset in webkit [41373] by andersca@apple.com
  • 1 edit in trunk/WebKit/mac/ChangeLog

Fix tyop

4:14 PM Changeset in webkit [41372] by andersca@apple.com
  • 2 edits in trunk/WebKit/mac

2009-03-02 Anders Carlsson <​andersca@apple.com>

Reviewed by John Sullivan, Ada Chan.

Factor loading code out into its own method and get rid of a bunch of goots.


  • Plugins/WebNetscapePluginPackage.mm: (-[WebNetscapePluginPackage _tryLoad]): (-[WebNetscapePluginPackage load]):
4:00 PM Changeset in webkit [41371] by andersca@apple.com
  • 2 edits in trunk/WebKit/mac

2009-03-02 Anders Carlsson <​andersca@apple.com>

Build fix.

  • Plugins/WebNetscapeDeprecatedFunctions.h:
3:58 PM Changeset in webkit [41370] by andersca@apple.com
  • 2 edits in trunk/WebKit

2009-03-02 Anders Carlsson <​andersca@apple.com>

WebNetscapePluginPackage.mm is an Objective-C++ file.

  • WebKit.xcodeproj/project.pbxproj:
3:53 PM Changeset in webkit [41369] by andersca@apple.com
  • 3 edits
    1 move in trunk/WebKit

WebKit:

2009-03-02 Anders Carlsson <​andersca@apple.com>

Reviewed by John Sullivan.

Rename WebNetscapePluginPackage.m to WebNetscapePluginPackage.mm


  • WebKit.xcodeproj/project.pbxproj:

WebKit/mac:

2009-03-02 Anders Carlsson <​andersca@apple.com>

Reviewed by John Sullivan.

Rename WebNetscapePluginPackage.m to WebNetscapePluginPackage.mm

  • Plugins/WebNetscapePluginPackage.m: Removed.
  • Plugins/WebNetscapePluginPackage.mm: Copied from mac/Plugins/WebNetscapePluginPackage.m.
3:29 PM Changeset in webkit [41368] by kevino@webkit.org
  • 11 edits in trunk

Build fixes for wxWidgets Mac trunk build.

3:25 PM Changeset in webkit [41367] by kevino@webkit.org
  • 2 edits in trunk/WebCore

wxGTK missing header build fix.

1:55 PM Changeset in webkit [41366] by mitz@apple.com
  • 2 edits in trunk/WebCore

Reviewed by Adam Roben.

  • platform/graphics/win/FontCacheWin.cpp: (WebCore::createGDIFont): Added back code to verify that the created HFONT has the requested face name.
1:38 PM Changeset in webkit [41365] by timothy@apple.com
  • 2 edits in trunk/WebCore

Fixes a regression caused by splitting the input and output of console commands.

​https://bugs.webkit.org/show_bug.cgi?id=24293

Reviewed by Kevin McCullough.

  • inspector/front-end/Console.js: (WebInspector.Console.prototype.addMessage): Don't treat ConsoleCommandResult as a normal ConsoleMessage when appending. This prevents resetting repeatCounts incorrectly.
1:38 PM Changeset in webkit [41364] by timothy@apple.com
  • 4 edits in trunk/WebCore

Make exception messages and logged Error objects display consistently.

​https://bugs.webkit.org/show_bug.cgi?id=18983

Reviewed by Adam Roben.

  • English.lproj/localizedStrings.js: Remove a string for line numbers.
  • inspector/front-end/Console.js: (WebInspector.Console.prototype._enterKeyPressed): Pass the exception boolean to the ConsoleCommandResult constructor and don't pass level. (WebInspector.Console.prototype._formatnode): Fix a className typo. (WebInspector.Console.prototype._formaterror): Add an error-message classed span around the message to show in red and remove the console-message-url class from the link so it doesn't float right. Instead enclose the link in parentheses and use displayNameForURL to shorten the URL in the link. (WebInspector.ConsoleMessage.prototype.toMessageElement): Simplify how line numbers are shown since link underlining a string with parentheses looks bad. (WebInspector.ConsoleCommandResult): Take an exception boolean flag instead of a level and get line and URL based on that flag.
  • inspector/front-end/inspector.css: Tweaks to the styles.
1:38 PM Changeset in webkit [41363] by timothy@apple.com
  • 2 edits in trunk/WebKitTools

Allow for multiline quoted text in JavaScript files when looking for function names.

​https://bugs.webkit.org/show_bug.cgi?id=24296

Reviewed by David Kilzer.

  • Scripts/prepare-ChangeLog:
11:16 AM Changeset in webkit [41362] by levin@chromium.org
  • 10 edits in trunk/WebCore

2009-03-02 Ojan Vafai <​ojan@chromium.org>

Reviewed by Adele Peterson.

Bug 24048: extra windows button padding doesn't apply when there's no appearance
<​https://bugs.webkit.org/show_bug.cgi?id=24048>

Replace adjustButtonInnerStyle with buttonInternalPaddingLeft/Right/Top/Bottom.

No tests added as existing tests already cover this behavior.

  • rendering/RenderButton.cpp: (WebCore::RenderButton::setupInnerStyle):
  • rendering/RenderTheme.cpp:
  • rendering/RenderTheme.h: (WebCore::RenderTheme::buttonInternalPaddingLeft): (WebCore::RenderTheme::buttonInternalPaddingRight): (WebCore::RenderTheme::buttonInternalPaddingTop):
  • rendering/RenderThemeChromiumGtk.cpp: (WebCore::RenderThemeWin::buttonInternalPaddingLeft): (WebCore::RenderThemeWin::buttonInternalPaddingRight): (WebCore::RenderThemeWin::buttonInternalPaddingTop): (WebCore::RenderThemeWin::buttonInternalPaddingBottom):
  • rendering/RenderThemeChromiumGtk.h:
  • rendering/RenderThemeChromiumWin.cpp: (WebCore::RenderThemeChromiumWin::buttonInternalPaddingLeft): (WebCore::RenderThemeChromiumWin::buttonInternalPaddingRight): (WebCore::RenderThemeChromiumWin::buttonInternalPaddingTop): (WebCore::RenderThemeChromiumWin::buttonInternalPaddingBottom):
  • rendering/RenderThemeChromiumWin.h:
  • rendering/RenderThemeWin.cpp: (WebCore::RenderThemeWin::buttonInternalPaddingLeft): (WebCore::RenderThemeWin::buttonInternalPaddingRight): (WebCore::RenderThemeWin::buttonInternalPaddingTop): (WebCore::RenderThemeWin::buttonInternalPaddingBottom):
  • rendering/RenderThemeWin.h:
10:26 AM Changeset in webkit [41361] by treat@webkit.org
  • 5 edits in trunk

2009-03-02 Adam Treat <​adam.treat@torchmobile.com>

Reviewed by Eric Seidel.

Add three new drt helper functions that enable all of the tests in
LayoutTests/animation/* and LayoutTests/transitions/* to now pass.

  • Api/qwebframe.cpp: (qt_drt_pauseAnimation): (qt_drt_pauseTransitionOfProperty): (qt_drt_numberOfActiveAnimations):
  • DumpRenderTree/qt/jsobjects.cpp: (LayoutTestController::pauseAnimationAtTimeOnElementWithId): (LayoutTestController::pauseTransitionAtTimeOnElementWithId): (LayoutTestController::numberOfActiveAnimations):
  • DumpRenderTree/qt/jsobjects.h:
8:55 AM Changeset in webkit [41360] by treat@webkit.org
  • 2 edits in trunk/WebKit/qt

2009-03-02 Benjamin C Meyer <​benjamin.meyer@torchmobile.com>

Reviewed by George Staikos.

​https://bugs.webkit.org/show_bug.cgi?id=21230
On X11 match the behavior of Firefox and also copy the url to the
clipboard selection when the action Copy Link Location is executed.

  • Api/qwebpage.cpp: (QWebPage::triggerAction):
8:30 AM Changeset in webkit [41359] by treat@webkit.org
  • 2 edits in trunk/WebCore

2009-03-02 Adam Treat <​adam.treat@torchmobile.com>

Build fix for Qt port. Remove unnecessary assert.

  • platform/graphics/qt/ImageBufferQt.cpp: (WebCore::ImageBuffer::putImageData):
7:37 AM Changeset in webkit [41358] by treat@webkit.org
  • 9 edits in trunk/WebCore

2009-03-02 Adam Treat <​adam.treat@torchmobile.com>

Reviewed by Adam Roben and previously by Eric Seidel and Simon Fraser.

​https://bugs.webkit.org/show_bug.cgi?id=24227
Ensure that the checkForSolidColor() optimization is correctly triggered
for all cases of drawPattern. Currently, the optimization was not triggered
when the check had not been previously performed via a request for the
image's NativeImagePtr.

Implement the Qt version of the checkForSolidColor() method. Combined with
the bug fix this reduces the time it takes to draw a repeating background
of a 1x1 image from ~50msecs to ~0msecs on my machine.

  • platform/graphics/BitmapImage.cpp: (WebCore::BitmapImage::BitmapImage):
  • platform/graphics/BitmapImage.h: (WebCore::BitmapImage::mayFillWithSolidColor):
  • platform/graphics/Image.h: (WebCore::Image::mayFillWithSolidColor):
  • platform/graphics/cairo/ImageCairo.cpp: (WebCore::BitmapImage::BitmapImage): (WebCore::BitmapImage::checkForSolidColor):
  • platform/graphics/cg/ImageCG.cpp: (WebCore::BitmapImage::BitmapImage): (WebCore::BitmapImage::checkForSolidColor):
  • platform/graphics/qt/ImageQt.cpp: (WebCore::BitmapImage::checkForSolidColor):
  • platform/graphics/skia/ImageSkia.cpp: (WebCore::BitmapImage::checkForSolidColor):
  • platform/graphics/wx/ImageWx.cpp: (WebCore::BitmapImage::checkForSolidColor):
6:56 AM Changeset in webkit [41357] by kov@webkit.org
  • 4 edits in trunk

2009-03-02 Gustavo Noronha Silva <Gustavo Noronha Silva>

Unreviewed build fix; adding missing files to EXTRA_DIST, so that
they show up in the tarball.

  • GNUmakefile.am:
6:38 AM QtWebKitTodo edited by Simon Hausmann
(diff)
6:38 AM Changeset in webkit [41356] by krit@webkit.org
  • 1 edit in trunk/WebCore/ChangeLog

2009-03-02 Dirk Schulze <​krit@webkit.org>

Just a correction of the ChangeLog. Removed Ariya Hidayat
from the reviewing process.

6:22 AM Changeset in webkit [41355] by krit@webkit.org
  • 2 edits in trunk/WebCore

2009-03-02 Dirk Schulze <​krit@webkit.org>

Reviewed by Holger Freyther, rubber-stamped by Ariya Hidayat.

Added putImageData to Qt.

[Qt] lacks putImageData support in Canvas
​https://bugs.webkit.org/show_bug.cgi?id=22186

  • platform/graphics/qt/ImageBufferQt.cpp: (WebCore::ImageBuffer::putImageData):
5:26 AM Changeset in webkit [41354] by Adam Roben
  • 2 edits in trunk/WebKitTools

Windows build fix after r41349

  • DumpRenderTree/win/AccessibilityUIElementWin.cpp: (AccessibilityUIElement::getChildrenWithRange):
12:22 AM Changeset in webkit [41353] by timothy@apple.com
  • 2 edits in trunk/WebCore

Show exception messages again when evaluating bad expressions in the
Web Inspector's console.

​https://bugs.webkit.org/show_bug.cgi?id=19890

Reviewed by Oliver Hunt.

  • bindings/js/JSQuarantinedObjectWrapper.cpp: (WebCore::JSQuarantinedObjectWrapper::transferExceptionToExecState): Fix the order in which the exception is set and cleared now that the exception is stored in the shared GlobalData, not per ExecState.
12:22 AM Changeset in webkit [41352] by timothy@apple.com
  • 3 edits
    1 add in trunk/WebCore

Make input in the Web Inspector console print before any output
that might be added by the called function.

​https://bugs.webkit.org/show_bug.cgi?id=19931

Reviewed by Oliver Hunt.

  • inspector/front-end/Console.js: (WebInspector.Console.prototype._enterKeyPressed): Add the command message before evaluating the result. Associate the originating command to the result, so if they are adjacent there is no divider. (WebInspector.ConsoleCommand): No longer take a result. (WebInspector.ConsoleCommand.prototype.toMessageElement): Result code removed since it isn't used now. (WebInspector.ConsoleCommandResult): Subclass ConsoleMessage. (WebInspector.ConsoleCommandResult.prototype.toMessageElement): Call the ConsoleMessage toMessageElement and add a style class.
  • inspector/front-end/inspector.css: Add a new style class for adjacent results to hide the divider. Also tweak the position of the disclosure triangle for objects to not use the left margin.
Note: See TracTimeline for information about the timeline view.