Context Navigation

← Previous Period
Next Period →

Timeline

Mar 4, 2009:

11:28 PM Changeset in webkit [41444] by mrowe@apple.com

2 edits in trunk/WebKit/mac

<rdar://problem/6206172> Adoption of new Cocoa API for dictionary contextual menu

Reviewed by Dan Bernstein.

WebView/WebHTMLView.mm:

(-[WebHTMLView _lookUpInDictionaryFromMenu:]):

10:04 PM Changeset in webkit [41443] by mrowe@apple.com

3 edits in trunk/JavaScriptCore

<rdar://problem/6354858> FastMallocZone's enumeration code reports fragmented administration space

Reviewed by Oliver Hunt.

The handling of MALLOC_ADMIN_REGION_RANGE_TYPE in FastMalloc's zone was incorrect. It was attempting
to record the memory containing and individual span as an administrative region, when all memory
allocated via MetaDataAlloc should in fact be recorded. This was causing memory regions allocated
via MetaDataAlloc to appear as "VM_ALLOCATE ?" in vmmap output. They are now correctly reported as
"MALLOC_OTHER" regions associated with the JavaScriptCore FastMalloc zone.

Memory is allocated via MetaDataAlloc from two locations: PageHeapAllocator, and TCMalloc_PageMap{2,3}.
These two cases are handled differently.

PageHeapAllocator is extended to keep a linked list of memory regions that it has allocated. The
first object in an allocated region contains the link to the previously allocated region. To record
the administrative regions of a PageHeapAllocator we can simply walk the linked list and record
each allocated region we encounter.

TCMalloc_PageMaps allocate memory via MetaDataAlloc to store each level of the radix tree. To record
the administrative regions of a TCMalloc_PageMap we walk the tree and record the storage used for nodes
at each position rather than the nodes themselves.

A small performance improvement is achieved by coalescing adjacent memory regions inside the PageMapMemoryUsageRecorder
so that fewer calls in to the range recorder are necessary. We further reduce the number of calls to the
range recorder by aggregating the in-use ranges of a given memory region into a local buffer before recording
them with a single call. A similar approach is also used by AdminRegionRecorder.

wtf/FastMalloc.cpp:

(WTF::PageHeapAllocator::Init):
(WTF::PageHeapAllocator::New):
(WTF::PageHeapAllocator::recordAdministrativeRegions):
(WTF::TCMallocStats::FreeObjectFinder::isFreeObject):
(WTF::TCMallocStats::PageMapMemoryUsageRecorder::~PageMapMemoryUsageRecorder):
(WTF::TCMallocStats::PageMapMemoryUsageRecorder::recordPendingRegions):
(WTF::TCMallocStats::PageMapMemoryUsageRecorder::visit):
(WTF::TCMallocStats::AdminRegionRecorder::AdminRegionRecorder):
(WTF::TCMallocStats::AdminRegionRecorder::recordRegion):
(WTF::TCMallocStats::AdminRegionRecorder::visit):
(WTF::TCMallocStats::AdminRegionRecorder::recordPendingRegions):
(WTF::TCMallocStats::AdminRegionRecorder::~AdminRegionRecorder):
(WTF::TCMallocStats::FastMallocZone::enumerate):
(WTF::TCMallocStats::FastMallocZone::FastMallocZone):
(WTF::TCMallocStats::FastMallocZone::init):

wtf/TCPageMap.h:

(TCMalloc_PageMap2::visitValues):
(TCMalloc_PageMap2::visitAllocations):
(TCMalloc_PageMap3::visitValues):
(TCMalloc_PageMap3::visitAllocations):

7:10 PM Changeset in webkit [41442] by oliver@apple.com

2 edits
2 adds in trunk/SunSpider

Added a few more tests to ubench

RS=Gavin Barraclough

Adding a couple of test to cover too few and too many arguments. This
is needed to prevent regressions in all call paths from my current refactoring.

6:36 PM Changeset in webkit [41441] by Simon Fraser

2 edits in trunk/WebCore

2009-03-04 Simon Fraser <Simon Fraser>

Reviewed by Eric Seidel

https://bugs.webkit.org/show_bug.cgi?id=24328

If an element has backface-visibility: hidden, hit testing should not
hit the back sides of elements. Test for that by inverting the accumulated
transform and looking at the z vector.

Tested by transforms/3d/hit-testing/backface-hit-test.html

rendering/RenderLayer.cpp: (WebCore::RenderLayer::hitTestLayer):

6:11 PM Changeset in webkit [41440] by Simon Fraser

1 edit
21 adds in trunk/LayoutTests

2009-03-04 Simon Fraser <Simon Fraser>

Rubber-stamped by Eric Seidel.

New layout tests for point mapping and hit testing through 3d transforms.
Not run by default yet.

platform/mac/transforms/3d/hit-testing/backface-hit-test-expected.txt: Added.
platform/mac/transforms/3d/point-mapping/3d-point-mapping-2-expected.txt: Added.
platform/mac/transforms/3d/point-mapping/3d-point-mapping-deep-expected.txt: Added.
platform/mac/transforms/3d/point-mapping/3d-point-mapping-expected.txt: Added.
platform/mac/transforms/3d/point-mapping/3d-point-mapping-origins-expected.txt: Added.
platform/mac/transforms/3d/point-mapping/3d-point-mapping-preserve-3d-expected.txt: Added.
transforms/3d/cssmatrix-3d-interface-expected.txt: Added.
transforms/3d/cssmatrix-3d-interface.xhtml: Added.
transforms/3d/hit-testing/backface-hit-test.html: Added.
transforms/3d/point-mapping/3d-point-mapping-2.html: Added.
transforms/3d/point-mapping/3d-point-mapping-deep.html: Added.
transforms/3d/point-mapping/3d-point-mapping-origins.html: Added.
transforms/3d/point-mapping/3d-point-mapping-preserve-3d.html: Added.
transforms/3d/point-mapping/3d-point-mapping.html: Added.
transforms/3d/point-mapping/point-mapping-helpers.js: Added. (mousemoved): (dispatchEvent): (clicked): (log): (runTest):

5:13 PM Changeset in webkit [41439] by eric.carlson@apple.com

2 edits in trunk/LayoutTests

2009-03-04 Eric Carlson <eric.carlson@apple.com>

Correct bogus result checked in as part of r41432.

media/video-can-play-type-expected.txt:

4:57 PM Changeset in webkit [41438] by eric@webkit.org

2 edits in trunk/WebCore

2009-03-04 Adam Langley <agl@google.com>

Reviewed by Darin Fisher.

r41362 mistakenly added functions "RenderThemeWin::" into
RenderThemeChromiumGtk.cpp. When correcting this, I somehow changed
them to void return types. This patch switches them back to ints.

https://bugs.webkit.org/show_bug.cgi?id=24360

rendering/RenderThemeChromiumLinux.cpp: (WebCore::RenderThemeChromiumLinux::buttonInternalPaddingLeft): (WebCore::RenderThemeChromiumLinux::buttonInternalPaddingRight): (WebCore::RenderThemeChromiumLinux::buttonInternalPaddingTop): (WebCore::RenderThemeChromiumLinux::buttonInternalPaddingBottom):

4:57 PM Changeset in webkit [41437] by eric@webkit.org

3 edits in trunk/WebCore

2009-03-04 Adam Langley <agl@google.com>

Reviewed by Darin Fisher.

Chromium Linux: change some metrics to better match Windows after
r41416. Aesthetically this may be worse, but web-compat is king.

Also, the previous code had an off by one error when drawing
scrollbars which caused the scrollbar to overflow it's bounds by 1px
at the right and bottom edges.

https://bugs.webkit.org/show_bug.cgi?id=24369

rendering/RenderThemeChromiumLinux.cpp: (WebCore::): (WebCore::RenderThemeChromiumLinux::systemFont):
platform/chromium/ScrollbarThemeChromiumLinux.cpp: (WebCore::ScrollbarThemeChromium::paintTrackPiece):

3:48 PM Changeset in webkit [41436] by pam@chromium.org

1 edit
2 adds in trunk/LayoutTests

2009-03-04 Pamela Greene <pam@chromium.org>

Reviewed by Darin Fisher.

Add test to ensure that window.frames is self-referential
https://bugs.webkit.org/show_bug.cgi?id=24341

fast/dom/Window/window-frames-self-referential-expected.txt: Added.
fast/dom/Window/window-frames-self-referential.html: Added.

2:58 PM Changeset in webkit [41435] by eric@webkit.org

2 edits in trunk/WebCore

Reviewed by Adam Roben.

Add an ASSERT to better demonstrate the cause of the crash in
https://bugs.webkit.org/show_bug.cgi?id=23736

loader/DocLoader.cpp: (WebCore::DocLoader::~DocLoader):

2:29 PM Changeset in webkit [41434] by levin@chromium.org

3 edits
5 adds in trunk

WebCore:

2009-03-04 David Levin <levin@chromium.org>

Reviewed by Alexey Proskuryakov.

Bug 24337: Assert when doing sync XHR in a worker for a cacheable response.
<https://bugs.webkit.org/show_bug.cgi?id=24337>

Tests: http/tests/xmlhttprequest/access-control-basic-denied-preflight-cache.html

http/tests/xmlhttprequest/workers/xmlhttprequest-file-not-found.html

loader/mac/ResourceLoaderMac.mm: (WebCore::ResourceLoader::willCacheResponse): An identifier is only asssigned if resource load callbacks are done. So don't send willCacheResponse which uses identifier if resource load callbacks aren't being sent.

LayoutTests:

2009-03-04 David Levin <levin@chromium.org>

Reviewed by Alexey Proskuryakov.

Bug 24337: Assert when doing sync XHR in a worker for a cacheable response.
<https://bugs.webkit.org/show_bug.cgi?id=24337>

http/tests/xmlhttprequest/access-control-basic-denied-preflight-cache-expected.txt: Added.
http/tests/xmlhttprequest/access-control-basic-denied-preflight-cache.html: Added.
http/tests/xmlhttprequest/workers/resources/xmlhttprequest-file-not-found.js: Added. (log): (done):
http/tests/xmlhttprequest/workers/xmlhttprequest-file-not-found-expected.txt: Added.
http/tests/xmlhttprequest/workers/xmlhttprequest-file-not-found.html: Added.

2:29 PM Changeset in webkit [41433] by levin@chromium.org

4 edits
4 adds in trunk

WebCore:

2009-03-04 David Levin <levin@chromium.org>

Reviewed by Alexey Proskuryakov.

Bug 24330: Sync xhr in workers should send an abort exception when the worker is terminated.
<https://bugs.webkit.org/show_bug.cgi?id=24330>

Test: http/tests/xmlhttprequest/workers/abort-exception-assert.html

dom/ExceptionCode.cpp: (WebCore::xmlHttpRequestExceptionNames): Added missing ABORT_ERR whose absence caused an assert.

loader/WorkerThreadableLoader.cpp: (WebCore::WorkerThreadableLoader::loadResourceSynchronously): (WebCore::WorkerThreadableLoader::MainThreadBridge::cancel): Add more logic to handle the termination case for sync xhr.

LayoutTests:

2009-03-04 David Levin <levin@chromium.org>

Reviewed by Alexey Proskuryakov.

Bug 24330: Sync xhr in workers should send an abort exception when the worker is terminated.
<https://bugs.webkit.org/show_bug.cgi?id=24330>

Added test to verify to terminate a worker while it is doing a synchronous xhr.
It does not verify that the exception is a ABORT_ERR because I couldn't figure out a way
to actually do this.

http/tests/xmlhttprequest/workers/abort-exception-assert-expected.txt: Added.
http/tests/xmlhttprequest/workers/abort-exception-assert.html: Added.
http/tests/xmlhttprequest/workers/resources/endless-response.php: Copied from LayoutTests/http/tests/xmlhttprequest/resources/endlessxml.php.
http/tests/xmlhttprequest/workers/resources/endless-sync-xhr.js: Added.

2:21 PM Changeset in webkit [41432] by eric.carlson@apple.com

8 edits
2 adds in trunk

2009-03-04 Eric Carlson <eric.carlson@apple.com>

Reviewed by Antti Koivisto.

https://bugs.webkit.org/show_bug.cgi?id=24364
Add support for HTMLMediaElement canPlayType method. Make
MediaPlayer::supportsType take a ContentType instead of a
separate mime type and codecs parameter.

Test: media/video-can-play-type.html

dom/DOMImplementation.cpp: (WebCore::DOMImplementation::createDocument):
html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::canPlayType): Add canPlayType method. (WebCore::HTMLMediaElement::loadInternal): selectMediaURL returns a ContentType. (WebCore::HTMLMediaElement::selectMediaURL): Return a ContentType instead of raw MIME type. (WebCore::HTMLMediaElement::initialURL): selectMediaURL returns a ContentType.
html/HTMLMediaElement.h: Add prototype.
html/HTMLMediaElement.idl: Ditto.
platform/graphics/MediaPlayer.cpp: (WebCore::MediaPlayer::load): Take a ContentType instead of raw MIME type. (WebCore::MediaPlayer::supportsType): Ditto.
platform/graphics/MediaPlayer.h:

2009-03-04 Eric Carlson <eric.carlson@apple.com>

Reviewed by Antti Koivisto.

https://bugs.webkit.org/show_bug.cgi?id=24364
Test HTMLMediaElement canPlayType method.

media/video-can-play-type-expected.txt: Added.
media/video-can-play-type.html: Added.

2:01 PM Changeset in webkit [41431] by Antti Koivisto

7 edits in trunk

JavaScriptCore:

2009-03-04 Antti Koivisto <Antti Koivisto>

Reviewed by Dave Hyatt.

https://bugs.webkit.org/show_bug.cgi?id=24359
Repaint throttling mechanism

Set ENABLE_REPAINT_THROTTLING to 0 by default.

wtf/Platform.h:

WebCore:

2009-03-04 Antti Koivisto <Antti Koivisto>

Reviewed by Dave Hyatt.

https://bugs.webkit.org/show_bug.cgi?id=24359
Repaint throttling mechanism

Excessive repainting can slow down page loadind. This implements a timer
based throttling mechanism. It is behind ENABLE(REPAINT_THROTTLING) and not
enabled by default.

loader/FrameLoader.cpp: (WebCore::FrameLoader::checkCompleted):
page/EventHandler.cpp: (WebCore::EventHandler::dispatchDragEvent): (WebCore::EventHandler::dispatchMouseEvent): (WebCore::EventHandler::keyEvent): (WebCore::EventHandler::handleTextInputEvent):
page/FrameView.cpp: (WebCore::FrameView::FrameView): (WebCore::FrameView::reset): (WebCore::FrameView::repaintContentRectangle): (WebCore::FrameView::beginDeferredRepaints): (WebCore::FrameView::endDeferredRepaints): (WebCore::FrameView::checkStopDelayingDeferredRepaints): (WebCore::FrameView::doDeferredRepaints): (WebCore::FrameView::updateDeferredRepaintDelay): (WebCore::FrameView::resetDeferredRepaintDelay): (WebCore::FrameView::adjustedDeferredRepaintDelay): (WebCore::FrameView::deferredRepaintTimerFired): (WebCore::FrameView::paintContents):
page/FrameView.h:

1:53 PM Changeset in webkit [41430] by weinig@apple.com

9 edits in trunk/WebCore

2009-03-04 Sam Weinig <sam@webkit.org>

Rubber-stamped by Antti Koivisto.

Remove LOW_BANDWIDTH_DISPLAY as it is not being used by any platforms.

dom/Document.cpp: (WebCore::Document::Document):
dom/Document.h: (WebCore::Document::haveStylesheetsLoaded):
html/HTMLTokenizer.cpp: (WebCore::HTMLTokenizer::scriptHandler):
loader/Cache.cpp: (WebCore::Cache::requestResource):
loader/CachedCSSStyleSheet.cpp: (WebCore::CachedCSSStyleSheet::checkNotify):
loader/DocLoader.h:
loader/FrameLoader.cpp: (WebCore::FrameLoader::FrameLoader): (WebCore::FrameLoader::requestFrame): (WebCore::FrameLoader::stopLoading): (WebCore::FrameLoader::begin): (WebCore::FrameLoader::write): (WebCore::FrameLoader::endIfNotLoadingMainResource): (WebCore::FrameLoader::checkCompleted): (WebCore::FrameLoader::requestObject): (WebCore::FrameLoader::loadItem):
loader/FrameLoader.h:

1:24 PM Changeset in webkit [41429] by kmccullough@apple.com

6 edits in trunk/LayoutTests

2009-03-04 Kevin McCullough <kmccullough@apple.com>

Build bot fix.

fast/profiler/many-calls-in-the-same-scope-expected.txt:
fast/profiler/multiple-and-different-scoped-anonymous-function-calls-expected.txt:
fast/profiler/multiple-and-different-scoped-function-calls-expected.txt:
fast/profiler/nested-start-and-stop-profiler-expected.txt:
fast/profiler/profile-calls-in-included-file-expected.txt:

12:57 PM Changeset in webkit [41428] by xan@webkit.org

8 edits
2 moves in trunk

2009-03-02 Xan Lopez <xan@gnome.org>

Reviewed by Mark Rowe.

https://bugs.webkit.org/show_bug.cgi?id=24287
[GTK] Move auth dialog feature to WebKit/

Add WebKitSoupAuthDialog files to build.

GNUmakefile.am:

WebCore:

2009-03-02 Xan Lopez <xan@gnome.org>

Reviewed by Mark Rowe.

https://bugs.webkit.org/show_bug.cgi?id=24287
[GTK] Move auth dialog feature to WebKit/

Remove WebKitSoupAuthDialog files from build and stop using it.

GNUmakefile.am:
platform/network/soup/ResourceHandleSoup.cpp: (WebCore::ensureSessionIsInitialized):
platform/network/soup/webkit-soup-auth-dialog.c: Removed.
platform/network/soup/webkit-soup-auth-dialog.h: Removed.

WebKit/gtk:

2009-03-02 Xan Lopez <xan@gnome.org>

Reviewed by Mark Rowe.

https://bugs.webkit.org/show_bug.cgi?id=24287
[GTK] Move auth dialog feature to WebKit/

Add WebKitSoupAuthDialog and add it to the session in webkit_init.

webkit/webkitprivate.cpp: (currentToplevelCallback): (webkit_init):
webkit/webkitsoupauthdialog.c: Added. (webkit_soup_auth_dialog_class_init): (webkit_soup_auth_dialog_init): (webkit_soup_auth_dialog_session_feature_init): (free_authData): (set_password_callback): (response_callback): (table_add_entry): (show_auth_dialog): (find_password_callback): (session_authenticate): (attach):
webkit/webkitsoupauthdialog.h: Added.

11:58 AM Changeset in webkit [41427] by Simon Fraser

3 edits
4 adds in trunk

2009-03-04 Simon Fraser <Simon Fraser>

Reviewed by Dave Hyatt

https://bugs.webkit.org/show_bug.cgi?id=24361

Reinstate code that sets result.innerNode when hitTest() returns true,
but never filled in the innerNode. Fixes hit testing of generated content.

Test: fast/css-generated-content/hit-test-generated-content.html

rendering/RenderLayer.cpp: (WebCore::RenderLayer::hitTestContents):

11:56 AM Changeset in webkit [41426] by abarth@webkit.org

18 edits in trunk

WebCore:

2009-03-04 Adam Barth <abath@webkit.org>

Reviewed by Alexey Proskuryakov.

https://bugs.webkit.org/show_bug.cgi?id=24356

Fix WebKit style for allowUniversalAccessFromFileURLs.

WebCore.base.exp:
dom/Document.cpp: (WebCore::Document::initSecurityContext):
page/Settings.cpp: (WebCore::Settings::Settings): (WebCore::Settings::setAllowUniversalAccessFromFileURLs):
page/Settings.h: (WebCore::Settings::allowUniversalAccessFromFileURLs):

WebKit/mac:

2009-03-04 Adam Barth <abath@webkit.org>

Reviewed by Alexey Proskuryakov.

https://bugs.webkit.org/show_bug.cgi?id=24356

Fix WebKit style for allowUniversalAccessFromFileURLs.

WebView/WebPreferenceKeysPrivate.h:
WebView/WebPreferences.mm: (+[WebPreferences initialize]): (-[WebPreferences allowUniversalAccessFromFileURLs]): (-[WebPreferences setAllowUniversalAccessFromFileURLs:]):
WebView/WebPreferencesPrivate.h:
WebView/WebView.mm: (-[WebView _preferencesChangedNotification:]):

WebKit/qt:

2009-03-04 Adam Barth <abath@webkit.org>

Reviewed by Alexey Proskuryakov.

https://bugs.webkit.org/show_bug.cgi?id=24356

Fix WebKit style for allowUniversalAccessFromFileURLs.

Api/qwebsettings.cpp: (QWebSettingsPrivate::apply):

WebKit/win:

2009-03-04 Adam Barth <abath@webkit.org>

Reviewed by Alexey Proskuryakov.

https://bugs.webkit.org/show_bug.cgi?id=24356

Fix WebKit style for allowUniversalAccessFromFileURLs.

Interfaces/IWebPreferencesPrivate.idl:
WebPreferenceKeysPrivate.h:
WebPreferences.cpp: (WebPreferences::initializeDefaultSettings): (WebPreferences::allowUniversalAccessFromFileURLs): (WebPreferences::setAllowUniversalAccessFromFileURLs):
WebPreferences.h:
WebView.cpp: (WebView::notifyPreferencesChanged):

10:25 AM Changeset in webkit [41425] by beidson@apple.com

2 edits in trunk/WebCore

2009-03-04 Brady Eidson <beidson@apple.com>

Reviewed by Darin Adler

<rdar://problem/6619630> Quick Look of vCards stuck on image of first card opened.

I narrowed this down to http://trac.webkit.org/changeset/39304 which, among other things,
consolidated some of the various decision making pieces of the Cache into the new method
FrameLoader::cachePolicy().

Before 39304, when deciding whether to use an existing CachedResource, we checked if the FrameLoader
is reloading. If it is, we'd evict any existing resource then recreate it. Quick looks uses the
same URL for this image every time and expects it to be reloaded with each new card.

The FrameLoader::isReloading() check did one thing - Ask the DocumentLoader if it's cache policy
is "ReloadIgnoringCacheData". This check was lost in the consolidation to the new method.

loader/FrameLoader.cpp: (WebCore::FrameLoader::cachePolicy): Restore the DocumentLoader's cachePolicy check as a possible condition for returning CachePolicyReload.

9:59 AM Changeset in webkit [41424] by timothy@apple.com

2 edits in trunk/WebCore

English.lproj/localizedStrings.js: Update strings to include "DATABASES", "LOCAL STORAGE" and "SESSION STORAGE".

9:59 AM Changeset in webkit [41423] by timothy@apple.com

2 edits in trunk/WebCore

Fix a regression where the Web Inspector console would not animate
in or out correctly.

Reviewed by Anders Carlsson.

inspector/front-end/inspector.css: Move a z-index to a child element to get the correct stacking order during the animation.

9:56 AM Changeset in webkit [41422] by hyatt@apple.com

5 edits
4 adds in trunk

WebCore:

2009-03-03 David Hyatt <hyatt@apple.com>

https://bugs.webkit.org/show_bug.cgi?id=24201, pathologically bad block layout.

Make sure to factor clear deltas into y position estimates. Also avoid doing the comparison of
the final position against the y position estimate until after the clear has happened. This gets rid
of some duplicated cut/pasted code and also ensures a layout delta only has to be put in once.

Reviewed by Dan Bernstein

Added fast/block/float/nested-clearance.html

rendering/RenderBlock.cpp: (WebCore::RenderBlock::collapseMargins): (WebCore::RenderBlock::clearFloatsIfNeeded): (WebCore::RenderBlock::estimateVerticalPosition): (WebCore::RenderBlock::layoutBlockChildren): (WebCore::RenderBlock::getClearDelta):
rendering/RenderBlock.h:

LayoutTests:

2009-03-03 David Hyatt <hyatt@apple.com>

Test case for https://bugs.webkit.org/show_bug.cgi?id=24201

Reviewed by Dan Bernstein

fast/block/float/nested-clearance.html: Added.
platform/mac/fast/block/float/nested-clearance-expected.checksum: Added.
platform/mac/fast/block/float/nested-clearance-expected.png: Added.
platform/mac/fast/block/float/nested-clearance-expected.txt: Added.

9:39 AM Changeset in webkit [41421] by abarth@webkit.org

3 edits in trunk/WebKit/qt

2009-03-03 Adam Barth <abarth@webkit.org>

Reviewed by Alexey Proskuryakov.

https://bugs.webkit.org/show_bug.cgi?id=24340

Expose AllowUniversalAccessFromFileUrls to Qt clients.

Api/qwebsettings.cpp: (QWebSettingsPrivate::apply): (QWebSettings::QWebSettings):
Api/qwebsettings.h:

6:42 AM Changeset in webkit [41420] by Simon Hausmann

8 edits in trunk/WebCore

2009-03-02 Kim Grönholm <kim.gronholm@nomovok.com>

Reviewed by Simon Hausmann.

Improvement to 3d transformations rendering in QtWebKit. QTransform is used
instead of QMatrix. This allows perspective transformations since QTransform is
a true 3x3 matrix.

6:21 AM Changeset in webkit [41419] by Simon Hausmann

3 edits in trunk/WebCore

2009-02-24 Laszlo Gombos <Laszlo Gombos>

Reviewed by Simon Hausmann.

https://bugs.webkit.org/show_bug.cgi?id=24151
Fix Qt/S60 build break

1:56 AM BuildingGtk edited by oszi@inf.u-szeged.hu

(diff)

1:54 AM QtWebKitTodo edited by Simon Hausmann

(diff)

Mar 3, 2009:

11:20 PM Changeset in webkit [41418] by darin@chromium.org

2 edits in trunk/WebCore

2009-03-03 Mike Belshe <mike@belshe.com>

Reviewed by Alexey Proskuryakov.

https://bugs.webkit.org/show_bug.cgi?id=21939
Uninitialized ExceptionCode in DOMWindow::postMessage

dom/MessagePort.cpp: (WebCore::MessagePort::postMessage):

10:49 PM Changeset in webkit [41417] by ddkilzer@apple.com

11 edits in trunk

<rdar://problem/6581203> WebCore and WebKit should install the same set of headers during installhdrs phase as build phase

Reviewed by Mark Rowe.

JavaScriptCore:

Configurations/Base.xcconfig: Defined REAL_PLATFORM_NAME based on PLATFORM_NAME to work around the missing definition on Tiger. Updated HAVE_DTRACE to use REAL_PLATFORM_NAME.

WebCore:

The fix is to add INSTALLHDRS_COPY_PHASE = YES and
INSTALLHDRS_SCRIPT_PHASE = YES to WebCore.xcconfig, then to make
sure various build phase scripts work with the installhdrs build
phase.

Configurations/Base.xcconfig: Defined REAL_PLATFORM_NAME based on PLATFORM_NAME to work around the missing definition on Tiger.
Configurations/WebCore.xcconfig: Added JAVASCRIPTCORE_PRIVATE_HEADERS_DIR variable to simplify logic in the "Generate Derived Sources" script. Added INSTALLHDRS_COPY_PHASE = YES and INSTALLHDRS_SCRIPT_PHASE = YES.

WebCore.xcodeproj/project.pbxproj:
Added shell code to prevent running "Check For Global Initializers", "Check For Exit Time Destructors" and "Check For Weak VTables" scripts during the installhdrs build phase.
Made "Generate Derived Sources" work for the installhdrs build phase. Also simplified setting of CREATE_HASH_TABLE by using JAVASCRIPTCORE_PRIVATE_HEADERS_DIR.

WebKit:

The fix is to add INSTALLHDRS_COPY_PHASE = YES and
INSTALLHDRS_SCRIPT_PHASE = YES to WebKit.xcconfig, then to
make sure various build phase scripts work with the installhdrs
build phase.

WebKit.xcodeproj/project.pbxproj:
Added shell code to prevent running "Check For Global Initializers", "Check For Exit Time Destructors" and "Check For Weak VTables" scripts during the installhdrs build phase.
Removed UMBRELLA_FRAMEWORKS_DIR from the Debug and Release targets since it's no longer needed after defining WEBCORE_PRIVATE_HEADERS_DIR in WebKit.xcconfig.

WebKit/mac:

The fix is to add INSTALLHDRS_COPY_PHASE = YES and
INSTALLHDRS_SCRIPT_PHASE = YES to WebKit.xcconfig, then to
make sure various build phase scripts work with the installhdrs
build phase.

Configurations/Base.xcconfig: Defined REAL_PLATFORM_NAME based on PLATFORM_NAME to work around the missing definition on Tiger.
Configurations/WebKit.xcconfig: Added WEBCORE_PRIVATE_HEADERS_DIR variable to remove definition of UMBRELLA_FRAMEWORKS_DIR for Debug and Release builds in the Xcode project file. Added INSTALLHDRS_COPY_PHASE = YES and INSTALLHDRS_SCRIPT_PHASE = YES.

10:09 PM Changeset in webkit [41416] by darin@chromium.org

6 edits
2 moves in trunk/WebCore

2009-03-02 Adam Langley <agl@google.com>

Reviewed by Darin Fisher.

Chromium Linux: Switch to using Skia to render widgets.

In order to sandbox the Chromium renderer on Linux we need to remove
the X connection. GTK cannot render without an X connection so, for
now, we render widgets ourselves.

Previously didn't use anti-alias fonts in order to match Windows font
rendering exactly. This was helpful when bootstrapping our layout
tests. Now, however, we are ready to enable it.

https://bugs.webkit.org/show_bug.cgi?id=24244

platform/chromium/ScrollbarThemeChromium.cpp: (WebCore::ScrollbarThemeChromium::buttonSize):
platform/chromium/ScrollbarThemeChromiumLinux.cpp: (WebCore::ScrollbarThemeChromium::scrollbarThickness): (WebCore::ScrollbarThemeChromium::paintTrackPiece): (WebCore::ScrollbarThemeChromium::paintButton): (WebCore::ScrollbarThemeChromium::paintThumb):
platform/graphics/chromium/FontPlatformDataLinux.cpp: (WebCore::FontPlatformData::setupPaint):
platform/graphics/skia/PlatformContextSkia.cpp: (PlatformContextSkia::PlatformContextSkia): (PlatformContextSkia::~PlatformContextSkia):
platform/graphics/skia/PlatformContextSkia.h:
rendering/RenderThemeChromiumGtk.cpp: Removed.
rendering/RenderThemeChromiumGtk.h: Removed.
rendering/RenderThemeChromiumLinux.cpp: Added.
rendering/RenderThemeChromiumLinux.h: Added.

9:39 PM Changeset in webkit [41415] by Dimitri Glazkov

2 edits in trunk/WebCore

2009-03-03 Dimitri Glazkov <Dimitri Glazkov>

Reviewed by Darin Fisher.

https://bugs.webkit.org/show_bug.cgi?id=24261
Fix return types.

Test: LayoutTests/dom/svg/level3/xpath/XPathEvaluator_evaluate_TYPE_ERR.svg

bindings/v8/V8Binding.h: (WebCore::toInt32): change return type to int (WebCore::toFloat): change return type to float.

5:10 PM Changeset in webkit [41414] by andersca@apple.com

7 edits in trunk

WebCore:

2009-03-03 Anders Carlsson <andersca@apple.com>

Reviewed by John Sullivan.

https://bugs.webkit.org/show_bug.cgi?id=22884
<rdar://problem/6449783>
modified layout test crashes Safari

Null check NPStream before dereferencing it.

plugins/PluginView.cpp: (WebCore::PluginView::destroyStream):

WebKitTools:

2009-03-03 Anders Carlsson <andersca@apple.com>

Reviewed by John Sullivan.

https://bugs.webkit.org/show_bug.cgi?id=22884
<rdar://problem/6449783>
modified layout test crashes Safari

Add destroyNullStream test function to the test plug-in.

DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp: (destroyNullStream): (pluginInvoke):

LayoutTests:

2009-03-03 Anders Carlsson <andersca@apple.com>

Reviewed by John Sullivan.

https://bugs.webkit.org/show_bug.cgi?id=22884
<rdar://problem/6449783>
modified layout test crashes Safari

Update tests.

plugins/destroy-stream-twice-expected.txt:
plugins/destroy-stream-twice.html:

5:06 PM Changeset in webkit [41413] by eric.carlson@apple.com

117 edits in trunk/LayoutTests

2009-03-03 Eric Carlson <eric.carlson@apple.com>

Reviewed by Simon Fraser.

https://bugs.webkit.org/show_bug.cgi?id=24294
Bug 24294: Improve media layout test logging

Make all media layout tests log the condition that is being tested,
success or failure, plus observed value when a test condition fails
so it is possible to see exactly what failed without having to hack
the test source. Consolidate some of the logic in the shared JavaScript file.

media/audio-constructor-expected.txt:
media/audio-constructor-src-expected.txt:
media/audio-constructor-src.html:
media/audio-constructor.html:
media/audio-mpeg-supported-expected.txt:
media/audio-mpeg-supported.html:
media/broken-video-expected.txt:
media/broken-video.html:
media/constructors-expected.txt:
media/constructors.html:
media/loopend-limits-expected.txt:
media/loopstart-limits-expected.txt:
media/progress-event-expected.txt:
media/progress-event-total-expected.txt:
media/progress-event-total.html:
media/progress-event.html:
media/remove-from-document-expected.txt:
media/remove-from-document-no-load-expected.txt:
media/remove-from-document-no-load.html:
media/remove-from-document.html:
media/unsupported-rtsp-expected.txt:
media/unsupported-rtsp.html:
media/unsupported-tracks-expected.txt:
media/unsupported-tracks.html:
media/video-append-source-expected.txt:
media/video-append-source.html:
media/video-autoplay-expected.txt:
media/video-autoplay.html:
media/video-buffered-expected.txt:
media/video-buffered.html:
media/video-controls-expected.txt:
media/video-controls-transformed-expected.txt:
media/video-controls-transformed.html:
media/video-controls.html:
media/video-currentTime-expected.txt:
media/video-currentTime-set.html:
media/video-currentTime-set2-expected.txt:
media/video-currentTime-set2.html:
media/video-currentTime.html:
media/video-dom-autoplay-expected.txt:
media/video-dom-autoplay.html:
media/video-dom-end-expected.txt:
media/video-dom-end.html:
media/video-dom-loopcount-expected.txt:
media/video-dom-loopcount.html:
media/video-dom-loopend-expected.txt:
media/video-dom-loopend.html:
media/video-dom-loopstart-expected.txt:
media/video-dom-loopstart.html:
media/video-dom-src-expected.txt:
media/video-dom-src.html:
media/video-dom-start-expected.txt:
media/video-dom-start.html:
media/video-end-expected.txt:
media/video-end.html:
media/video-error-abort-expected.txt:
media/video-error-abort.html:
media/video-error-does-not-exist-expected.txt:
media/video-error-does-not-exist.html:
media/video-load-networkState-expected.txt:
media/video-load-networkState.html:
media/video-load-readyState-expected.txt:
media/video-load-readyState.html:
media/video-loopcount-expected.txt:
media/video-loopcount.html:
media/video-loopend-expected.txt:
media/video-loopend.html:
media/video-loopstart-expected.txt:
media/video-loopstart.html:
media/video-muted-expected.txt:
media/video-muted.html:
media/video-no-autoplay-expected.txt:
media/video-no-autoplay.html:
media/video-pause-empty-events-expected.txt:
media/video-pause-empty-events.html:
media/video-play-empty-events-expected.txt:
media/video-play-empty-events.html:
media/video-play-pause-events-expected.txt:
media/video-play-pause-events.html:
media/video-poster-expected.txt:
media/video-poster.html:
media/video-seek-past-end-paused-expected.txt:
media/video-seek-past-end-paused.html:
media/video-seek-past-end-playing-expected.txt:
media/video-seek-past-end-playing.html:
media/video-seekable-expected.txt:
media/video-seekable.html:
media/video-seeking-expected.txt:
media/video-seeking.html:
media/video-size-expected.txt:
media/video-size.html:
media/video-source-expected.txt:
media/video-source-media-expected.txt:
media/video-source-media.html:
media/video-source-type-expected.txt:
media/video-source-type-params-expected.txt:
media/video-source-type-params.html:
media/video-source-type.html:
media/video-source.html:
media/video-src-change-expected.txt:
media/video-src-change.html:
media/video-src-expected.txt:
media/video-src-remove-expected.txt:
media/video-src-remove.html:
media/video-src-set-expected.txt:
media/video-src-set.html:
media/video-src-source-expected.txt:
media/video-src-source.html:
media/video-src.html:
media/video-start-expected.txt:
media/video-start.html:
media/video-test.js: (test): (testExpected): (waitForEvent._eventCallback): (waitForEvent): (waitForEventAndTest._eventCallback): (waitForEventAndTest): (testException): (logResult):
media/video-volume-expected.txt:
media/video-volume.html:
media/video-width-height-expected.txt:
media/video-width-height.html:

4:44 PM Changeset in webkit [41412] by eric.carlson@apple.com

3 edits in trunk/WebCore

2009-03-03 Eric Carlson <eric.carlson@apple.com>

Reviewed by Simon Fraser.

Fix for <rdar://problem/6641045>
Don't call QTKit to get movie properties until movie metadata has been loaded.

platform/graphics/mac/MediaPlayerPrivateQTKit.h: (WebCore::MediaPlayerPrivate::metaDataAvailable): defined
platform/graphics/mac/MediaPlayerPrivateQTKit.mm: (WebCore::MediaPlayerPrivate::createQTTime): return default if !metaDataAvailable. (WebCore::MediaPlayerPrivate::play): Ditto. (WebCore::MediaPlayerPrivate::pause): Ditto. (WebCore::MediaPlayerPrivate::duration): Ditto. (WebCore::MediaPlayerPrivate::currentTime): Ditto. (WebCore::MediaPlayerPrivate::seek): Ditto. (WebCore::MediaPlayerPrivate::seekTimerFired): Ditto. (WebCore::MediaPlayerPrivate::paused): Ditto. (WebCore::MediaPlayerPrivate::seeking): Ditto. (WebCore::MediaPlayerPrivate::naturalSize): Ditto. (WebCore::MediaPlayerPrivate::hasVideo): Ditto. (WebCore::MediaPlayerPrivate::setVolume): Ditto. (WebCore::MediaPlayerPrivate::setRate): Ditto. (WebCore::MediaPlayerPrivate::dataRate): Ditto. (WebCore::MediaPlayerPrivate::maxTimeLoaded): Ditto. (WebCore::MediaPlayerPrivate::totalBytes): Ditto.

4:38 PM Changeset in webkit [41411] by kmccullough@apple.com

2 edits
2 adds in trunk/LayoutTests

2009-03-03 Kevin McCullough <kmccullough@apple.com>

Reviewed by Oliver Hunt.

<rdar://problem/6031674> JSProfiler: Multiple anonymous functions get
the same entry in profiler if called from same function

This no longer happens but I thought I'd make a test case anyway.

fast/profiler/multiple-anonymous-functions-called-from-the-same-function-expected.txt: Added.
fast/profiler/multiple-anonymous-functions-called-from-the-same-function.html: Added.
fast/profiler/resources/profiler-test-JS-resources.js: (anotherAnonymousFunction):

4:08 PM Changeset in webkit [41410] by kmccullough@apple.com

2 edits in trunk/WebCore

2009-03-03 Kevin McCullough <kmccullough@apple.com>

Spelling fix.

page/Console.cpp: (WebCore::Console::profile):

3:30 PM Changeset in webkit [41409] by ddkilzer@apple.com

4 edits in trunk/WebKit

Remove last vestiges of JAVASCRIPTCORE_PRIVATE_HEADERS_DIR from WebKit

Reviewed by Adam Roben.

Use of JAVASCRIPTCORE_PRIVATE_HEADERS_DIR was removed in r37465
since NPAPI headers had migrated from JavaScriptCore to WebCore
before that.

WebKit:

WebKit.xcodeproj/project.pbxproj: Removed JAVASCRIPTCORE_PRIVATE_HEADERS_DIR build setting from from Debug and Release configurations.

WebKit/mac:

Configurations/WebKit.xcconfig: Removed definition of JAVASCRIPTCORE_PRIVATE_HEADERS_DIR used in Production builds.

2:57 PM Changeset in webkit [41408] by Dimitri Glazkov

2 edits in trunk/WebCore

2009-03-03 Dimitri Glazkov <Dimitri Glazkov>

Reviewed by Darin Fisher.

https://bugs.webkit.org/show_bug.cgi?id=23657
Remove Database API callback IDLs from the project.
They were removed in r40633.

WebCore.xcodeproj/project.pbxproj: Removed IDL files from the project.

2:47 PM Changeset in webkit [41407] by kmccullough@apple.com

5 edits
2 adds in trunk

JavaScriptCore:

2009-03-03 Kevin McCullough <kmccullough@apple.com>

Reviewed by Oliver Hunt.

<rdar://problem/6639110> console.profile() doesn't work without a title

profiler/Profiler.cpp: (JSC::Profiler::startProfiling): assert if there is not title to ensure we don't start profiling without one.

WebCore:

2009-03-03 Kevin McCullough <kmccullough@apple.com>

Reviewed by Oliver Hunt.

<rdar://problem/6639110> console.profile() doesn't work without a title

page/Console.cpp: (WebCore::Console::profile): If there is no title assume this is a user initiated profile and give it the next incremented title name.

LayoutTests:

2009-03-03 Kevin McCullough <kmccullough@apple.com>

Reviewed by Oliver Hunt.

<rdar://problem/6639110> console.profile() doesn't work without a title

fast/profiler/profile-with-no-title-expected.txt: Added.
fast/profiler/profile-with-no-title.html: Added.

2:27 PM Changeset in webkit [41406] by timothy@apple.com

1 edit in trunk/WebCore/ChangeLog

Add bug URLs for my last commit.

2:25 PM Changeset in webkit [41405] by pam@chromium.org

1 edit
6 deletes in trunk/LayoutTests

2009-03-03 Pamela Greene <pam@chromium.org>

Remove junk files that must have been accidentally committed.
Submitted without review.

fast/block/float/t0905-c414-flt-fit-01-d-g.html.orig: Removed.
fast/block/float/t0905-c414-flt-fit-01-d-g.html.rej: Removed.
fast/block/float/t0905-c5525-fltblck-00-d-ag.html.orig: Removed.
fast/block/float/t0905-c5525-fltblck-00-d-ag.html.rej: Removed.
fast/block/float/t0905-c5526-flthw-00-c-g.html.orig: Removed.
fast/block/float/t0905-c5526-flthw-00-c-g.html.rej: Removed.

2:24 PM Changeset in webkit [41404] by timothy@apple.com

8 edits
1 add in trunk/WebCore

Fix a regression that broke dirxml and caused an ASSERT in debug builds. Also simplified
the console code and refactored things to have fewer code paths and duplication.

Reviewed by Kevin McCullough.

Test: manual-tests/inspector/console-dir.html

bindings/js/JSInspectedObjectWrapper.cpp: (WebCore::JSInspectedObjectWrapper::wrap): Use the lexicalGlobalObject instead of dynamicGlobalObject to fix an ASSERT about using a wrapper from the wrong ExecState.
bindings/js/JSQuarantinedObjectWrapper.cpp: (WebCore::JSQuarantinedObjectWrapper::JSQuarantinedObjectWrapper): Ditto. (WebCore::JSQuarantinedObjectWrapper::allowsUnwrappedAccessFrom): Ditto.
inspector/front-end/Console.js: (WebInspector.Console.prototype._format): Remove the inline argument and add forceObjectFormat. When forceObjectFormat is true, the only formatter used is _formatobject. (WebInspector.Console.prototype._formatvalue): Remove the inline argument. (WebInspector.Console.prototype._formatstring): Ditto. (WebInspector.Console.prototype._formatregexp): Ditto. (WebInspector.Console.prototype._formatarray): Ditto. (WebInspector.Console.prototype._formatnode): Remove the inline argument and make a DOM tree instead of an anchor. (WebInspector.Console.prototype._formatobject): Remove the inline argument and always make a property graph. (WebInspector.Console.prototype._formaterror): Remove the inline argument. (WebInspector.ConsoleMessage): Remove the case for MessageLevel.Node and simplify the case for MessageLevel.Object to use the normal _format code path with the %O formatter. (WebInspector.ConsoleMessage.prototype._format.formatForConsole): Don't pass an additional true argument for inline. (WebInspector.ConsoleMessage.prototype._format.formatAsObjectForConsole): Added. Pass a true argument for forceObjectFormat. (WebInspector.ConsoleMessage.prototype._format): Added support for the %O formatter. Use formatForConsole for all arguments. (WebInspector.ConsoleMessage.prototype.toString): Add the other message levels.
inspector/front-end/inspector.css: Tweak styles to look and work correctly.
inspector/front-end/utilities.js: (Object.type): Return "node" for Node objects. (Object.describe): Handle the "node" type.
page/Console.cpp: (WebCore::printMessageSourceAndLevelPrefix): Fix an assert by adding the other message level types. (WebCore::Console::dirxml): Use the standard log fuction since it prints a DOM tree for nodes by default.
page/Console.h: (WebCore::enum MessageLevel): Removed NodeMessageLevel. Added a FIXME.

1:07 PM Changeset in webkit [41403] by Dimitri Glazkov

3 edits
2 adds in trunk

WebCore:

2009-03-03 Scott Violet <sky@google.com>

Reviewed by Eric Seidel.

https://bugs.webkit.org/show_bug.cgi?id=24325
Crash on replacing document contents during drop.

Makes sure a node is in the document during a move before using it.

Test: fast/events/crash-on-mutate-during-drop.html

editing/MoveSelectionCommand.cpp: (WebCore::MoveSelectionCommand::doApply):

LayoutTests:

2009-03-03 Scott Violet <sky@google.com>

Reviewed by Eric Seidel.

https://bugs.webkit.org/show_bug.cgi?id=24325
Crash on replacing document contents during drop

Makes sure we don't crash during dnd with DOM mutation event listener
that mutates the document on drop.

fast/events/crash-on-mutate-during-drop-expected.txt: Added.
fast/events/crash-on-mutate-during-drop.html: Added.

11:53 AM Changeset in webkit [41402] by Dimitri Glazkov

4 edits in trunk/WebCore

2009-03-03 Jungshik Shin <jshin@chromium.org>

Reviewed by Eric Seidel.

https://bugs.webkit.org/show_bug.cgi?id=23028
Enable dynamic web font support to Chromium on Windows.
Files that were omitted by mistake in the latest patch
that was landed.

loader/CachedFont.cpp: (WebCore::CachedFont::~CachedFont): (WebCore::CachedFont::ensureCustomFontData): (WebCore::CachedFont::platformDataFromCustomData): (WebCore::CachedFont::allClientsRemoved):
platform/graphics/chromium/FontCustomPlatformData.cpp: (WebCore::EOTStream::EOTStream): (WebCore::createFontCustomPlatformData):
platform/graphics/win/FontCustomPlatformData.cpp: (WebCore::EOTStream::EOTStream): (WebCore::createFontCustomPlatformData):

11:48 AM Changeset in webkit [41401] by kov@webkit.org

12 edits
2 adds in trunk

2009-03-03 Gustavo Noronha Silva <Gustavo Noronha Silva>

Reviewed by Alexey Proskuryakov.

https://bugs.webkit.org/show_bug.cgi?id=16826
[Gtk] Implement WebKitDownload

Adding new files related to WebKitDownload to the GTK+ port.

GNUmakefile.am:

WebCore:

2009-03-03 Gustavo Noronha Silva <Gustavo Noronha Silva>

Reviewed by Alexey Proskuryakov.

https://bugs.webkit.org/show_bug.cgi?id=16826
[Gtk] Implement WebKitDownload

Make the Soup backend able to handle requests without a frame,
since we may have such things now that we support downloads.

platform/network/ResourceHandleInternal.h:
platform/network/soup/ResourceHandleSoup.cpp: (WebCore::ResourceHandle::start):

WebKit/gtk:

2009-03-03 Gustavo Noronha Silva <Gustavo Noronha Silva>

Reviewed by Alexey Proskuryakov.

https://bugs.webkit.org/show_bug.cgi?id=16826
[Gtk] Implement WebKitDownload

Implement download, and provide a nice object wrapping the
download process. Initial work done by Marco Barisione and
Pierre-Luc Beaudoin for Collabora.

WebCoreSupport/ContextMenuClientGtk.cpp: (WebKit::ContextMenuClient::downloadURL):
WebCoreSupport/FrameLoaderClientGtk.cpp: (WebKit::FrameLoaderClient::download): (WebKit::FrameLoaderClient::startDownload):
webkit/webkit.h:
webkit/webkitdefines.h:
webkit/webkitdownload.cpp: Added. (_WebKitDownloadPrivate::): (_WebKitDownloadPrivate::webkit_download_dispose): (_WebKitDownloadPrivate::webkit_download_finalize): (_WebKitDownloadPrivate::webkit_download_get_property): (_WebKitDownloadPrivate::webkit_download_set_property): (_WebKitDownloadPrivate::webkit_download_class_init): (_WebKitDownloadPrivate::webkit_download_init): (_WebKitDownloadPrivate::webkit_download_new): (_WebKitDownloadPrivate::webkit_download_open_stream_for_uri): (_WebKitDownloadPrivate::webkit_download_close_stream): (_WebKitDownloadPrivate::webkit_download_start): (_WebKitDownloadPrivate::webkit_download_cancel): (_WebKitDownloadPrivate::webkit_download_get_uri): (_WebKitDownloadPrivate::webkit_download_get_network_request): (_WebKitDownloadPrivate::webkit_download_set_response): (_WebKitDownloadPrivate::webkit_download_get_suggested_filename): (_WebKitDownloadPrivate::webkit_download_get_destination_uri): (_WebKitDownloadPrivate::webkit_download_set_destination_uri): (_WebKitDownloadPrivate::webkit_download_get_state): (_WebKitDownloadPrivate::webkit_download_get_total_size): (_WebKitDownloadPrivate::webkit_download_get_current_size): (_WebKitDownloadPrivate::webkit_download_get_progress): (_WebKitDownloadPrivate::webkit_download_get_elapsed_time): (_WebKitDownloadPrivate::webkit_download_received_data): (_WebKitDownloadPrivate::webkit_download_finished_loading): (_WebKitDownloadPrivate::webkit_download_error): (_WebKitDownloadPrivate::DownloadClient::DownloadClient): (_WebKitDownloadPrivate::DownloadClient::didReceiveResponse): (_WebKitDownloadPrivate::DownloadClient::didReceiveData): (_WebKitDownloadPrivate::DownloadClient::didFinishLoading): (_WebKitDownloadPrivate::DownloadClient::didFail): (_WebKitDownloadPrivate::DownloadClient::wasBlocked): (_WebKitDownloadPrivate::DownloadClient::cannotShowURL):
webkit/webkitdownload.h: Added.
webkit/webkitprivate.h:
webkit/webkitwebview.cpp:
webkitmarshal.list:

11:29 AM Changeset in webkit [41400] by andersca@apple.com

3 edits in trunk/WebKit/mac

2009-03-03 Anders Carlsson <andersca@apple.com>

Reviewed by Darin Adler.

Fix <rdar://problem/6633834>.

Plugins/Hosted/NetscapePluginHostManager.mm: (WebKit::NetscapePluginHostManager::instantiatePlugin): Create a new plug-in instance if the plug-in host has crashed.

Plugins/Hosted/NetscapePluginInstanceProxy.mm: (WebKit::NetscapePluginInstanceProxy::invalidate): Add a null check for the plug-in host proxy.

11:18 AM Changeset in webkit [41399] by Dimitri Glazkov

2 edits
4 copies
1 add in trunk/WebCore

2009-03-03 Dimitri Glazkov <Dimitri Glazkov>

Reviewed by Eric Seidel.

https://bugs.webkit.org/show_bug.cgi?id=24331
Add custom V8 bindings for Element, Attr, HTMLFrame, and HTMLIFrame.

bindings/v8/custom/V8AttrCustom.cpp: Added.
bindings/v8/custom/V8CustomBinding.cpp: Added.
bindings/v8/custom/V8CustomBinding.h: Added attribute-checking helpers.
bindings/v8/custom/V8ElementCustom.cpp: Added.
bindings/v8/custom/V8HTMLFrameElementCustom.cpp: Added.
bindings/v8/custom/V8HTMLIFrameElementCustom.cpp: Added.

11:08 AM Changeset in webkit [41398] by beidson@apple.com

15 edits
3 adds in trunk

WebCore:

2009-03-03 Brady Eidson <beidson@apple.com>

Reviewed by Darin Adler

<rdar://problem/6616664> - Quick looks of various file types is broken

In http://trac.webkit.org/changeset/40553 there was an attempt to prevent NSURLRequest churn
for non-HTTP loads when the underlying ResourceRequest changed. Unfortunately it was a little
overzealous as the mainDocumentURL is relevant for all loads, not only HTTP/HTTPS loads.

Partially reverted behavior to always set the mainDocumentURL in situations when we would've
before that patch.

loader/FrameLoader.cpp: (WebCore::FrameLoader::addExtraFieldsToRequest):

platform/network/ResourceRequestBase.cpp: (WebCore::ResourceRequestBase::setMainDocumentURL):

WebKitTools:

2009-03-03 Brady Eidson <beidson@apple.com>

Reviewed by Darin Adler

Support layout test covering <rdar://problem/6616664>

Change NSURLRequest/IWebURLRequest dumping to include the mainDocumentURL

DumpRenderTree/mac/ResourceLoadDelegate.mm: (-[NSURLRequest _drt_descriptionSuitableForTestResult]): Return both the request URL and the mainDocumentURL.

DumpRenderTree/win/ResourceLoadDelegate.cpp: (descriptionSuitableForTestResult): Return both the request URL and the mainDocumentURL.

LayoutTests:

2009-03-03 Brady Eidson <beidson@apple.com>

Reviewed by Darin Adler

Layout test covering <rdar://problem/6616664> - Quick looks of various file types is broken

Added to test the changes:

fast/loader/main-document-url-for-non-http-loads-expected.txt: Added.
fast/loader/main-document-url-for-non-http-loads.html: Added.
fast/loader/resources/subframe-notify-done.html: Added.

Updated the following for the new info from dumpResourceLoadCallbacks():

http/tests/misc/window-dot-stop-expected.txt:
http/tests/xmlhttprequest/abort-should-cancel-load-expected.txt:
platform/mac-leopard/security/block-test-expected.txt:
platform/mac-tiger/http/tests/misc/willCacheResponse-delegate-callback-expected.txt:
platform/mac/http/tests/misc/willCacheResponse-delegate-callback-expected.txt:
platform/mac/webarchive/loading/cache-expired-subresource-expected.txt:
security/block-test-expected.txt:
webarchive/loading/test-loading-archive-expected.txt:

10:55 AM Changeset in webkit [41397] by cmarrin@apple.com

2 edits in trunk/WebCore

Reviewed by Simon Fraser.

https://bugs.webkit.org/show_bug.cgi?id=24256

Added a WebCoreForceSoftwareAnimation flag.

10:48 AM Changeset in webkit [41396] by cmarrin@apple.com

11 edits
2 adds in trunk

Reviewed by Sam Weinig.

https://bugs.webkit.org/show_bug.cgi?id=24257

Added prototype properties for several classes with constructors that
were missing them, including the one mentioned in the bug.

10:46 AM Changeset in webkit [41395] by ariya@webkit.org

3 edits in trunk/WebKit/qt

2009-03-03 Ariya Hidayat <ariya.hidayat@trolltech.com>

Rubber-stamped by Simon Hausmann.

[Qt] Create and update the action for SelectAll.

Api/qwebpage.cpp: (QWebPagePrivate::updateAction): (QWebPagePrivate::updateEditorActions): (QWebPage::action):
tests/qwebpage/tst_qwebpage.cpp: (tst_QWebPage::textSelection):

10:38 AM Changeset in webkit [41394] by Dimitri Glazkov

1 edit
4 adds in trunk/WebCore

2009-03-03 Dimitri Glazkov <Dimitri Glazkov>

Reviewed by Darin Fisher.

https://bugs.webkit.org/show_bug.cgi?id=24321
Add V8 bindings headers.

bindings/v8/V8Binding.h: Added.
bindings/v8/V8Proxy.h: Added.
bindings/v8/custom/V8CustomBinding.h: Added.
bindings/v8/custom/V8CustomEventListener.h: Added.

10:33 AM Changeset in webkit [41393] by Dimitri Glazkov

1 edit
20 adds in trunk/LayoutTests

2009-03-03 Jungshik Shin <jshin@chromium.org>

Reviewed by Darin Adler.

http://bugs.webkit.org/show_bug.cgi?id=23482
Add the following CSS 2.1 tests, with YinYang character (U+262F)
and SouthEast Arrow (U+2798) replaced by png images,
to fast/block/float. Leftward white arrow (U+21E6) is also
replaced by an ASCII-equivalent of '<-'.

css2.1/t0905-c414-flt-fit-01-d-g.html
css2.1/t0905-c5525-fltblck-00-d-ag.html
css2.1/t0905-c5526-flthw-00-c-g.html

On platforms where no font covers those characters (e.g. Windows),
the above tests can be skipped and the new tests can be used, instead.
They're equivalent in terms of what they test.

fast/block/float/resources/se_arrow.png: Added.
fast/block/float/resources/yinyang.png: Added.
fast/block/float/t0905-c414-flt-fit-01-d-g.html: Copied from LayoutTests/css2.1/t0905-c414-flt-fit-01-d-g.html.
fast/block/float/t0905-c5525-fltblck-00-d-ag.html: Copied from LayoutTests/css2.1/t0905-c5525-fltblck-00-d-ag.html.
fast/block/float/t0905-c5526-flthw-00-c-g.html: Copied from LayoutTests/css2.1/t0905-c5526-flthw-00-c-g.html.
platform/mac/fast/block/float/t0905-c414-flt-fit-01-d-g-expected.checksum: Added.
platform/mac/fast/block/float/t0905-c414-flt-fit-01-d-g-expected.png: Added.
platform/mac/fast/block/float/t0905-c414-flt-fit-01-d-g-expected.txt: Added.
platform/mac/fast/block/float/t0905-c5525-fltblck-00-d-ag-expected.checksum: Added.
platform/mac/fast/block/float/t0905-c5525-fltblck-00-d-ag-expected.png: Added.
platform/mac/fast/block/float/t0905-c5525-fltblck-00-d-ag-expected.txt: Added.
platform/mac/fast/block/float/t0905-c5526-flthw-00-c-g-expected.checksum: Added.
platform/mac/fast/block/float/t0905-c5526-flthw-00-c-g-expected.png: Added.
platform/mac/fast/block/float/t0905-c5526-flthw-00-c-g-expected.txt: Added.

10:21 AM Changeset in webkit [41392] by Dimitri Glazkov

2 edits in trunk/WebCore

2009-03-03 Jungshik Shin <jshin@chromium.org>

Reviewed by Eric Seidel.

https://bugs.webkit.org/show_bug.cgi?id=23803
Fix an 'off-by-1' error in ChromiumWin's font fallback.

platform/graphics/chromium/FontCacheChromiumWin.cpp: (WebCore::FontCache::getFontDataForCharacters):

10:20 AM Changeset in webkit [41391] by Dimitri Glazkov

1 edit in trunk/WebCore/ChangeLog

Fix ChangeLog dates.

10:18 AM Changeset in webkit [41390] by Dimitri Glazkov

2 edits
2 moves
1 add in trunk/WebCore

2009-03-03 Jungshik Shin <jshin@chromium.org>

Reviewed by Eric Seidel.

http://bugs.webkit.org/show_bug.cgi?id=23028
Enable dynamic web font support to Chromium on Windows: Part 1

Move OpenTypeUtilities.{cpp,h} to platform/graphics/opentype from platform/graphics/win because both Windows port and Chromium Windows port will use them.
Adjust WebCore.vcproj accordingly.

WebCore.vcproj/WebCore.vcproj:
platform/graphics/opentype: Added.
platform/graphics/opentype/OpenTypeUtilities.cpp: Copied from WebCore/platform/graphics/win/OpenTypeUtilities.cpp.
platform/graphics/opentype/OpenTypeUtilities.h: Copied from WebCore/platform/graphics/win/OpenTypeUtilities.h.
platform/graphics/win/OpenTypeUtilities.cpp: Removed.
platform/graphics/win/OpenTypeUtilities.h: Removed.

10:10 AM Changeset in webkit [41389] by Simon Fraser

6 edits in trunk/WebCore

2009-03-02 Simon Fraser <Simon Fraser>

Reviewed by Dave Hyatt

https://bugs.webkit.org/show_bug.cgi?id=24312

Take 3D transforms into account when hit testing:

Maintain a bit on each RenderLayer that is set when the layer has 3d descendants, so that we know when to fall into the slow hit testing path.

Make a ref-counted HitTestingTransformState, which is used to store an accumulated transform, and the hit test point, and hitTestRect in the plane of the ancestor non-3d ('flattening') layer.

It's ref-counted so we can heap allocate it (to avoid stack bloat),
and avoid copying when hitTestLayer calls itself after applying the transform.

Add logic to hitTestLayer to depth-test just direct descendants, if any have 3D transforms, or to do deep depth-testing when traversing a preserves-3d hierarchy. When hit, layers compute a z-offset from the ancestor flattening layer, which allows for correct depth testing.

The existing early-return codepath is unaffected when there are no 3d transforms
and no preserve-3d.

9:54 AM Changeset in webkit [41388] by brettw@chromium.org

1 edit in trunk/WebCore/ChangeLog

Fix typo in ChangeLog from last commit.

9:52 AM Changeset in webkit [41387] by Simon Fraser

4 edits in trunk/WebCore

2009-03-02 Simon Fraser <Simon Fraser>

Reviewed by Dave Hyatt

https://bugs.webkit.org/show_bug.cgi?id=24312

Factor the code that compute a transform relative to the container
into RenderObject::transformFromContainer().

rendering/RenderBox.cpp: (WebCore::RenderBox::mapLocalToAbsolutePoint): (WebCore::RenderBox::mapAbsoluteToLocalPoint):
rendering/RenderObject.cpp: (WebCore::RenderObject::transformFromContainer):
rendering/RenderObject.h:

9:50 AM Changeset in webkit [41386] by brettw@chromium.org

2 edits in trunk/WebCore

2009-03-02 Brett Wilson <brettw@chromium.org>

Fix uninitialized memory reads in the Chromium Windows transparency
code that were identified by Purify,

Reviewed by Darin Disher.

platform/graphics/chromium/TransparencyWin.cpp: (WebCore::TransparencyWin::OwnedBuffers::OwnedBuffers): (WebCore::TransparencyWin::initializeNewContext):

9:43 AM Changeset in webkit [41385] by Simon Fraser

2 edits in trunk/WebCore

2009-03-02 Simon Fraser <Simon Fraser>

Reviewed by Dave Hyatt

https://bugs.webkit.org/show_bug.cgi?id=24317

Always return |true| from RenderTextControlMultiLine::nodeAtPoint() if
the superclass found a node, otherwise we set the innerNode of the
HitTestResult, but don't actually report that we found a hit.

rendering/RenderTextControlMultiLine.cpp: (WebCore::RenderTextControlMultiLine::nodeAtPoint):

9:31 AM Changeset in webkit [41384] by kov@webkit.org

1 edit in trunk/WebCore/ChangeLog

Fixing bug number for last ChangeLog entry; thanks to Ariya for
catching this problem.

9:26 AM Changeset in webkit [41383] by kov@webkit.org

3 edits
1 add in trunk/WebCore

2009-03-03 Onne Gorter <onne.gorter@avinity.net>

Reviewed by Anders Carlsson.

https://bugs.webkit.org/show_bug.cgi?id=27385
resizing plugins does not work, because the plugin never gets informed

Make gtk plugins resize correctly, by sending them the setwindow event
correctly. Also ensure that all plugin eventing is done with correct
locking/calling. Mostly copied from mac implementation.

manual test: manual-tests/gtk/plugin-resize-scroll.html

plugins/PluginView.h:
plugins/gtk/PluginViewGtk.cpp: (WebCore::PluginView::dispatchNPEvent): ensure locking/calling for NPEvents (WebCore::PluginView::updatePluginWidget): if something changed, let setNPWindowIfNeeded handle it (WebCore::PluginView::paint): (WebCore::PluginView::handleKeyboardEvent): (WebCore::PluginView::handleMouseEvent): ensure calling conventions (WebCore::PluginView::setNPWindowRect): just pass control to setNPWindowIfNeeded (WebCore::PluginView::setNPWindowIfNeeded): event the plugin correctly of new window (WebCore::PluginView::init): init through the new setup

8:45 AM Changeset in webkit [41382] by ap@webkit.org