⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Mar 5, 2009:

11:28 PM Changeset in webkit [41476] by ap@webkit.org
  • 5 edits
    3 adds in trunk

Reviewed by Oliver Hunt.

<rdar://problem/6621701> Safari 4 Beta Breaks XMLHttpRequest Response Text With Special
Characters (a compatibility issue with widgets).

Test: http/tests/xmlhttprequest/broken-xml-encoding.html

Revert part of an Acid 3 fix - now we are no longer strict when decoding XMLHttpRequest XML
responses.

  • loader/TextResourceDecoder.cpp: (WebCore::TextResourceDecoder::TextResourceDecoder): (WebCore::TextResourceDecoder::decode): (WebCore::TextResourceDecoder::flush):
  • loader/TextResourceDecoder.h: (WebCore::TextResourceDecoder::useLenientXMLDecoding): Don't stop on XML decoding errors if useLenientXMLDecoding() was called.
  • xml/XMLHttpRequest.cpp: (WebCore::XMLHttpRequest::didReceiveData): Don't stop on XML decoding errors. This behavior is now limited to other kinds of XML content.
11:17 PM Changeset in webkit [41475] by ddkilzer@apple.com
  • 4 edits in trunk

JavaScriptCore:

2009-03-05 Simone Fiorentino <​simone.fiorentino@consulenti.fastweb.it>

Bug 24382: request to add SH4 platform

<​https://bugs.webkit.org/show_bug.cgi?id=24382>

Reviewed by David Kilzer.

  • wtf/Platform.h: Added support for SH4 platform.

WebCore:

2009-03-05 Simone Fiorentino <​simone.fiorentino@consulenti.fastweb.it>

Bug 24382: request to add SH4 platform

<​https://bugs.webkit.org/show_bug.cgi?id=24382>

Reviewed by David Kilzer.

  • platform/text/AtomicString.cpp: (WebCore::equal): Aligned memory access on SH4 platform.
11:02 PM Changeset in webkit [41474] by barraclough@apple.com
  • 4 edits in trunk/JavaScriptCore

2009-03-05 Gavin Barraclough <​barraclough@apple.com>

Reviewed by Oliver Hunt.

Writes of constant values to SF registers should be made with direct memory
writes where possible, rather than moving the value via a hardware register.

~3% win on SunSpider tests on x86, ~1.5% win on v8 tests on x86-64.

  • assembler/MacroAssemblerX86_64.h: (JSC::MacroAssemblerX86_64::storePtr):
  • assembler/X86Assembler.h: (JSC::X86Assembler::movq_i32m):
  • jit/JIT.cpp: (JSC::JIT::privateCompileMainPass):
9:15 PM Changeset in webkit [41473] by darin@chromium.org
  • 2 edits in trunk/WebCore

2009-03-05 Jeremy Moskovich <​jeremy@chromium.org>

Reviewed by Simon Fraser.

Fix for ​https://bugs.webkit.org/show_bug.cgi?id=24215

Gears expects an object tag with display:none to instantiate the plugin,
so we add a workaround to make this work and fix Gears on WebKit trunk.

  • html/HTMLObjectElement.cpp: (WebCore::HTMLObjectElement::rendererIsNeeded):
9:13 PM Changeset in webkit [41472] by darin@chromium.org
  • 2 edits in trunk/WebCore

2009-03-05 Avi Drissman <​avi@chromium.org>

Reviewed by Darin Fisher.

Need to have Chromium Mac match Safari Mac's accesskey handling
​https://bugs.webkit.org/show_bug.cgi?id=24404

  • page/chromium/EventHandlerChromium.cpp: (WebCore::EventHandler::accessKeyModifiers): Share access key modifiers with Mac Safari when building for the Mac.
8:12 PM Changeset in webkit [41471] by Simon Fraser
  • 3 edits
    2 adds in trunk

2009-03-05 Simon Fraser <Simon Fraser>

Reviewed by Dave Hyatt

​https://bugs.webkit.org/show_bug.cgi?id=24412

Fix crash when hit-testing elements with -webkit-transform-style: preserve-3d
but no transform. We need to make localTransformState if we see preserve-3d.
Also need to call update3DTransformedDescendantStatus() before we test
m_has3DTransformedDescendant.

Test: transforms/3d/hit-testing/hit-preserves-3d.html

  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::hitTestLayer):
8:12 PM Changeset in webkit [41470] by justin.garcia@apple.com
  • 1 edit in trunk/LayoutTests/platform/mac/editing/input/text-input-controller-expected.txt

When we replace a bit of selected text with a string of the same length, we now send a selection change notification. The selection endpoints aren't changing their positions in the DOM or their offsets in the document, but they're probably changing visually (unless the text is fixed width), so it seems right to send the notification.

On the other hand, this happens during a setMarkedText call, which shouldn't even touch the selection. But that's a different (and known) bug.

6:40 PM Changeset in webkit [41469] by eric@webkit.org
  • 8 edits in trunk/WebCore

Reviewed by David Hyatt.

Changes to RenderLayer destruction to hopefully help catch an elusive crasher
​https://bugs.webkit.org/show_bug.cgi?id=24409

Added a new RenderBoxModelObject::destroyLayer() call which is
now the only way which RenderLayers should ever be destroyed.
This ensures that the pointer to the layer is cleared in the
RenderObject after destruction, allowing us to ASSERT in the
RenderBoxModelObject destructor.

  • rendering/RenderBox.cpp: (WebCore::RenderBox::calcAbsoluteHorizontalReplaced):
  • rendering/RenderBoxModelObject.cpp: (WebCore::RenderBoxModelObject::~RenderBoxModelObject): (WebCore::RenderBoxModelObject::destroyLayer): (WebCore::RenderBoxModelObject::destroy): (WebCore::RenderBoxModelObject::styleDidChange):
  • rendering/RenderBoxModelObject.h:
  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::stackingContext): (WebCore::RenderLayer::destroy): (WebCore::RenderLayer::removeOnlyThisLayer):
  • rendering/RenderLayer.h:
  • rendering/RenderObject.cpp: (WebCore::RenderObject::destroy):
  • rendering/RenderWidget.cpp: (WebCore::RenderWidget::destroy):
6:35 PM Changeset in webkit [41468] by eric@webkit.org
  • 5 edits in trunk/WebCore

Reviewed by David Hyatt.

Remove old, unused IE 5.5 scrollbar-* CSS properties.
Sort the unimplemented getComputedStyle properties so it's
easier to see which ones actually need implementation.

  • css/CSSComputedStyleDeclaration.cpp: (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
  • css/CSSParser.cpp: (WebCore::CSSParser::parseValue):
  • css/CSSPropertyNames.in:
  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::applyProperty):
5:42 PM Changeset in webkit [41467] by adele@apple.com
  • 2 edits in trunk/WebKit/mac

2009-03-05 Adele Peterson <​adele@apple.com>

Reviewed by Darin Adler.

Fix for ​https://bugs.webkit.org/show_bug.cgi?id=24079
<rdar://problem/6611233> REGRESSION (r39549): Page loads cannot be interrupted with Command-. or Escape
<rdar://problem/6636563> Ctrl-tab shortcut doesn't switch tabs when focus is in text field


  • WebView/WebHTMLView.mm: (-[WebHTMLView doCommandBySelector:]): If WebKit does not support the command, we need to pass the selector to super. In this case, we'll consider the event not to be handled. This is not perfect because in theory, [super doCommandBySelector:] can do some action that would cause WebKit to need to consider the event handled. But in practice, I've found no example of that happening and causing broken behavior.
5:25 PM Changeset in webkit [41466] by justin.garcia@apple.com
  • 2 edits in trunk/WebCore/editing

Make changes to previous checkin from the code review.

5:00 PM Changeset in webkit [41465] by justin.garcia@apple.com
  • 49 edits in trunk

WebCore:

2009-03-05 Justin Garcia <​justin.garcia@apple.com>

Reviewed by Darin Adler.


WebViewDidChangeSelectionNotifications weren't being sent for commands that change the selection's position
within the document without changing its position in the DOM. For example, pressing return in (caret marked by ):
<div contentEditable="true"><div>Hello</div></div>
Undo was being enabled, shouldDeleteDOMRange called, etc. when doing no-op deletes (a delete in an empty document
for example).

Changes to layout tests demonstrate fix.


  • editing/EditCommand.cpp: (WebCore::EditCommand::apply): Don't call applyEditing for a TypingCommand. The TypingCommand knows whether or not it did work that needs to be applied.
  • editing/Editor.cpp: (WebCore::Editor::appliedEditing): Moved code (but did not alter) to changeSelectionAfterCommand. (WebCore::Editor::unappliedEditing): Ditto. (WebCore::Editor::reappliedEditing): Ditto. (WebCore::Editor::changeSelectionAfterCommand): Moved code from *appliedEditing into here. Also call out to EditorClient::respondToChangedSelection() for commands that changed the selection's position in the document even if they did not change it's position in the DOM. Any TypingCommand that gets this far changed it's position in the document.
  • editing/Editor.h:
  • editing/TypingCommand.cpp: (WebCore::TypingCommand::TypingCommand): Removed unused m_appliedEditing. (WebCore::TypingCommand::typingAddedToOpenCommand): Always apply editing. We won't get this far if we don't need to. (WebCore::TypingCommand::deleteKeyPressed): Don't do any of the things that only make sense for Range selections, like adding to the killring and responding to a change in selections if the delete was a no-op. (WebCore::TypingCommand::forwardDeleteKeyPressed): Ditto.
  • editing/TypingCommand.h:

LayoutTests:

2009-03-05 Justin Garcia <​justin.garcia@apple.com>

Reviewed by Darin Adler.


WebViewDidChangeSelectionNotification isn't always called.
Undo was enabled, shouldDeleteDOMRange was called, etc. for no-op backward and forward deletes.

  • platform/mac/editing/deleting/delete-4038408-fix-expected.txt:
  • platform/mac/editing/deleting/delete-at-start-or-end-expected.txt:
  • platform/mac/editing/deleting/delete-br-002-expected.txt:
  • platform/mac/editing/deleting/delete-br-004-expected.txt:
  • platform/mac/editing/deleting/delete-br-005-expected.txt:
  • platform/mac/editing/deleting/delete-br-006-expected.txt:
  • platform/mac/editing/deleting/delete-br-009-expected.txt:
  • platform/mac/editing/deleting/delete-br-010-expected.txt:
  • platform/mac/editing/deleting/delete-hr-expected.txt:
  • platform/mac/editing/deleting/delete-tab-004-expected.txt:
  • platform/mac/editing/deleting/forward-delete-expected.txt:
  • platform/mac/editing/deleting/merge-into-empty-block-1-expected.txt:
  • platform/mac/editing/deleting/merge-into-empty-block-2-expected.txt:
  • platform/mac/editing/inserting/editing-empty-divs-expected.txt:
  • platform/mac/editing/inserting/insert-3800346-fix-expected.txt:
  • platform/mac/editing/inserting/insert-br-004-expected.txt:
  • platform/mac/editing/inserting/insert-br-005-expected.txt:
  • platform/mac/editing/inserting/insert-br-006-expected.txt:
  • platform/mac/editing/inserting/insert-br-008-expected.txt:
  • platform/mac/editing/inserting/insert-div-006-expected.txt:
  • platform/mac/editing/inserting/insert-div-008-expected.txt:
  • platform/mac/editing/inserting/insert-div-010-expected.txt:
  • platform/mac/editing/inserting/insert-div-011-expected.txt:
  • platform/mac/editing/inserting/insert-div-013-expected.txt:
  • platform/mac/editing/inserting/insert-div-015-expected.txt:
  • platform/mac/editing/inserting/insert-div-019-expected.txt:
  • platform/mac/editing/inserting/insert-div-021-expected.txt:
  • platform/mac/editing/inserting/insert-paragraph-01-expected.txt:
  • platform/mac/editing/inserting/insert-paragraph-03-expected.txt:
  • platform/mac/editing/inserting/insert-paragraph-05-expected.txt:
  • platform/mac/editing/inserting/insert-tab-004-expected.txt:
  • platform/mac/editing/inserting/insert-text-with-newlines-expected.txt:
  • platform/mac/editing/inserting/line-break-expected.txt:
  • platform/mac/editing/pasteboard/3976872-expected.txt:
  • platform/mac/editing/pasteboard/emacs-ctrl-a-k-y-expected.txt:
  • platform/mac/editing/pasteboard/emacs-ctrl-k-y-001-expected.txt:
  • platform/mac/editing/pasteboard/paste-text-010-expected.txt:
  • platform/mac/editing/style/block-style-006-expected.txt:
  • platform/mac/editing/undo/undo-combined-delete-boundary-expected.txt:
  • platform/mac/editing/undo/undo-combined-delete-expected.txt:
  • platform/mac/editing/undo/undo-forward-delete-boundary-expected.txt:
  • platform/mac/editing/undo/undo-forward-delete-expected.txt:
4:35 PM Changeset in webkit [41464] by eric@webkit.org
  • 1 edit
    35 moves
    4 adds
    1 delete in trunk/LayoutTests

Rubber-stamped by Adam Roben.

Move all of the fast/css/*computed* tests into fast/css/getComputedStyle
in preparation for adding a bunch more getComputedStyle tests.

  • fast/css/getComputedStyle/computed-style-display-none-expected.txt: Renamed from LayoutTests/fast/css/computed-style-display-none-expected.txt.
  • fast/css/getComputedStyle/computed-style-display-none.html: Renamed from LayoutTests/fast/css/computed-style-display-none.html.
  • fast/css/getComputedStyle/computed-style-expected.txt: Renamed from LayoutTests/fast/css/computed-style-expected.txt.
  • fast/css/getComputedStyle/computed-style-negative-top-expected.txt: Renamed from LayoutTests/fast/css/computed-style-negative-top-expected.txt.
  • fast/css/getComputedStyle/computed-style-negative-top.html: Renamed from LayoutTests/fast/css/computed-style-negative-top.html.
  • fast/css/getComputedStyle/computed-style-without-renderer-expected.txt: Renamed from LayoutTests/fast/css/computed-style-without-renderer-expected.txt.
  • fast/css/getComputedStyle/computed-style-without-renderer.html: Renamed from LayoutTests/fast/css/computed-style-without-renderer.html.
  • fast/css/getComputedStyle/computed-style.html: Renamed from LayoutTests/fast/css/computed-style.html.
  • fast/css/getComputedStyle/getComputedStyle-background-position-expected.txt: Renamed from LayoutTests/fast/css/getComputedStyle-background-position-expected.txt.
  • fast/css/getComputedStyle/getComputedStyle-background-position.html: Renamed from LayoutTests/fast/css/getComputedStyle-background-position.html.
  • fast/css/getComputedStyle/getComputedStyle-background-size-expected.txt: Renamed from LayoutTests/fast/css/getComputedStyle-background-size-expected.txt.
  • fast/css/getComputedStyle/getComputedStyle-background-size.html: Renamed from LayoutTests/fast/css/getComputedStyle-background-size.html.
  • fast/css/getComputedStyle/getComputedStyle-border-box-expected.txt: Renamed from LayoutTests/fast/css/getComputedStyle-border-box-expected.txt.
  • fast/css/getComputedStyle/getComputedStyle-border-box.html: Renamed from LayoutTests/fast/css/getComputedStyle-border-box.html.
  • fast/css/getComputedStyle/getComputedStyle-border-image-expected.txt: Renamed from LayoutTests/fast/css/getComputedStyle-border-image-expected.txt.
  • fast/css/getComputedStyle/getComputedStyle-border-image.html: Renamed from LayoutTests/fast/css/getComputedStyle-border-image.html.
  • fast/css/getComputedStyle/getComputedStyle-border-spacing-expected.txt: Renamed from LayoutTests/fast/css/getComputedStyle-border-spacing-expected.txt.
  • fast/css/getComputedStyle/getComputedStyle-border-spacing.html: Renamed from LayoutTests/fast/css/getComputedStyle-border-spacing.html.
  • fast/css/getComputedStyle/getComputedStyle-borderRadius-expected.txt: Renamed from LayoutTests/fast/css/getComputedStyle-borderRadius-expected.txt.
  • fast/css/getComputedStyle/getComputedStyle-borderRadius.html: Renamed from LayoutTests/fast/css/getComputedStyle-borderRadius.html.
  • fast/css/getComputedStyle/getComputedStyle-relayout-expected.txt: Renamed from LayoutTests/fast/css/getComputedStyle-relayout-expected.txt.
  • fast/css/getComputedStyle/getComputedStyle-relayout.html: Renamed from LayoutTests/fast/css/getComputedStyle-relayout.html.
  • fast/css/getComputedStyle/getComputedStyle-transform-expected.txt: Renamed from LayoutTests/fast/css/getComputedStyle-transform-expected.txt.
  • fast/css/getComputedStyle/getComputedStyle-transform.html: Renamed from LayoutTests/fast/css/getComputedStyle-transform.html.
  • fast/css/getComputedStyle/getComputedStyle-zIndex-auto-expected.txt: Renamed from LayoutTests/fast/css/getComputedStyle-zIndex-auto-expected.txt.
  • fast/css/getComputedStyle/getComputedStyle-zIndex-auto.html: Renamed from LayoutTests/fast/css/getComputedStyle-zIndex-auto.html.
  • fast/css/marginComputedStyle.html: Removed.
  • platform/mac/fast/css/getComputedStyle/computed-style-expected.txt: Renamed from LayoutTests/platform/mac/fast/css/computed-style-expected.txt.
  • platform/mac/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt: Renamed from LayoutTests/platform/mac/fast/css/computed-style-without-renderer-expected.txt.
  • platform/mac/fast/css/getComputedStyle/marginComputedStyle-expected.checksum: Renamed from LayoutTests/platform/mac/fast/css/marginComputedStyle-expected.checksum.
  • platform/mac/fast/css/getComputedStyle/marginComputedStyle-expected.png: Renamed from LayoutTests/platform/mac/fast/css/marginComputedStyle-expected.png.
  • platform/mac/fast/css/getComputedStyle/marginComputedStyle-expected.txt: Renamed from LayoutTests/platform/mac/fast/css/marginComputedStyle-expected.txt.
  • platform/qt/fast/css/getComputedStyle/computed-style-expected.txt: Renamed from LayoutTests/platform/qt/fast/css/computed-style-expected.txt.
  • platform/qt/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt: Renamed from LayoutTests/platform/qt/fast/css/computed-style-without-renderer-expected.txt.
  • platform/win/fast/css/getComputedStyle/computed-style-expected.txt: Renamed from LayoutTests/platform/win/fast/css/computed-style-expected.txt.
  • platform/win/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt: Renamed from LayoutTests/platform/win/fast/css/computed-style-without-renderer-expected.txt.
3:18 PM Changeset in webkit [41463] by Dimitri Glazkov
  • 3 edits in trunk/WebCore

2009-03-05 Dimitri Glazkov <Dimitri Glazkov>

Reviewed by Adam Roben.

Eliminate a ref-counting leak in InspectorController.

  • inspector/InspectorController.h: Made constructor private, added static create method.
  • page/Page.cpp: (WebCore::Page::Page): Change initializer to use static create method.
2:58 PM Changeset in webkit [41462] by Dimitri Glazkov
  • 11 edits
    2 adds in trunk/WebCore

2009-03-05 Dimitri Glazkov <Dimitri Glazkov>

Reviewed by Timothy Hatcher.

​https://bugs.webkit.org/show_bug.cgi?id=24355
Add InspectorController.idl and convert InspectorController.cpp to use
JSC bindings.

  • DerivedSources.make: Added InspectorController.idl
  • WebCore.xcodeproj/project.pbxproj: Added idl, bindings files.
  • bindings/js/JSInspectorControllerCustom.cpp: Added.
  • bindings/scripts/CodeGeneratorJS.pm: Added Array to no-header types.
  • inspector/InspectorController.cpp: Removed hand-rolled bindings.
  • inspector/InspectorController.h: Added platform and addSourceToFrame methods.
  • inspector/InspectorController.idl: Added.
  • page/Page.h: Changed member to RefPtr since InspectorController is now ref-counted.
2:56 PM Changeset in webkit [41461] by eric.carlson@apple.com
  • 10 edits
    2 adds
    24 deletes in trunk

2009-03-05 Eric Carlson <​eric.carlson@apple.com>

Reviewed by Simon Fraser.

​https://bugs.webkit.org/show_bug.cgi?id=24400
Bug 24400: Remove "start", "end", "loopStart", "loopEnd", "currentLoop", and "playCount"
media element attributes

Test: media/video-loop.html

  • html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::HTMLMediaElement): (WebCore::HTMLMediaElement::loadInternal): (WebCore::HTMLMediaElement::setNetworkState): (WebCore::HTMLMediaElement::seek): (WebCore::HTMLMediaElement::playInternal): (WebCore::HTMLMediaElement::loop): (WebCore::HTMLMediaElement::setLoop): (WebCore::HTMLMediaElement::mediaPlayerTimeChanged): (WebCore::HTMLMediaElement::endedPlayback): (WebCore::HTMLMediaElement::updatePlayState):
  • html/HTMLMediaElement.h:
  • html/HTMLMediaElement.idl:

2009-03-05 Eric Carlson <​eric.carlson@apple.com>

Reviewed by Simon Fraser.

​https://bugs.webkit.org/show_bug.cgi?id=24400
Bug 24400: Remove "start", "end", "loopStart", "loopEnd", "currentLoop", and "playCount"
media element attributes

  • media/loopend-limits-expected.txt: Removed.
  • media/loopend-limits.html: Removed.
  • media/loopstart-limits-expected.txt: Removed.
  • media/loopstart-limits.html: Removed.
  • media/video-dom-end-expected.txt: Removed.
  • media/video-dom-end.html: Removed.
  • media/video-dom-loopcount-expected.txt: Removed.
  • media/video-dom-loopcount.html: Removed.
  • media/video-dom-loopend-expected.txt: Removed.
  • media/video-dom-loopend.html: Removed.
  • media/video-dom-loopstart-expected.txt: Removed.
  • media/video-dom-loopstart.html: Removed.
  • media/video-dom-start-expected.txt: Removed.
  • media/video-dom-start.html: Removed.
  • media/video-end-expected.txt: Removed.
  • media/video-end.html: Removed.
  • media/video-loop.html: Added, test for new "loop" attribute.
  • media/video-loopcount-expected.txt: Removed.
  • media/video-loopcount.html: Removed.
  • media/video-loopend-expected.txt: Removed.
  • media/video-loopend.html: Removed.
  • media/video-loopstart-expected.txt: Removed.
  • media/video-loopstart.html: Removed.
  • media/video-seek-past-end-paused-expected.txt: Updated for loop changes, add more tests.
  • media/video-seek-past-end-paused.html: Ditto.
  • media/video-seek-past-end-playing-expected.txt: Ditto.
  • media/video-seek-past-end-playing.html: Ditto.
  • media/video-start-expected.txt: Removed.
  • media/video-start.html: Removed.
2:16 PM Changeset in webkit [41460] by sfalken@apple.com
  • 2 edits in trunk/WebCore

<rdar://problem/6651112> Safari asks about re-posting a form even when page is cached


Reviewed by Ada Chan.

  • platform/network/cf/ResourceHandleCFNet.cpp: (WebCore::ResourceHandle::willLoadFromCache): Ported from Mac version.
2:11 PM Changeset in webkit [41459] by pam@chromium.org
  • 1 edit in trunk/LayoutTests/ChangeLog

2009-03-05 Pamela Greene <​pam@chromium.org>

Reviewed by Alexey Proskuryakov.

Add test for potential crash in window.frames.length
​https://bugs.webkit.org/show_bug.cgi?id=24339

  • fast/dom/Window/window-collection-length-no-crash-expected.txt: Added.
  • fast/dom/Window/window-collection-length-no-crash.html: Added.
12:37 PM Changeset in webkit [41458] by hyatt@apple.com
  • 3 edits in trunk/WebCore

2009-03-05 David Hyatt <​hyatt@apple.com>

Reviewed by Eric Seidel

​https://bugs.webkit.org/show_bug.cgi?id=24248

Make sure painting of overflow controls checks that visibility:visible is set on the block before
painting. Pixel tests caught this regression.

Make sure resizer painting pushes a clip of the corner rect. It was relying on the clip layers happened
to do to their bounds (which had nothing to do with overflow).

  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::paint):
  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::paintResizer):
11:58 AM Changeset in webkit [41457] by treat@webkit.org
  • 2 edits in trunk/WebCore

2009-03-05 Yong Li <​yong.li@torchmobile.com>

Reviewed by Simon Fraser.

​https://bugs.webkit.org/show_bug.cgi?id=24386
A faster implementation of extractMIMETypeFromMediaType.

  • platform/network/HTTPParsers.cpp: (WebCore::extractMIMETypeFromMediaType):
11:58 AM Changeset in webkit [41456] by treat@webkit.org
  • 2 edits in trunk/WebCore

2009-03-05 Yong Li <​yong.li@torchmobile.com>

Reviewed by Antti Koivisto.

​https://bugs.webkit.org/show_bug.cgi?id=24392
Do not get the current time for unless we're doing PRELOAD_DEBUG as this
can be unnecessarily expensive.

  • html/PreloadScanner.cpp: (WebCore::PreloadScanner::write):
11:39 AM Changeset in webkit [41455] by Simon Fraser
  • 4 edits in trunk/WebCore

2009-03-04 Simon Fraser <Simon Fraser>

Reviewed by Dave Hyatt

​https://bugs.webkit.org/show_bug.cgi?id=24327

When mapping points and hit testing through transforms, work
correctly when acclerated animations of transforms are running.

Tested by LayoutTests/animations/animation-hit-test-transform.html,
which only failed when ACCELERATED_COMPOSITING was turned on.

  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::currentTransform):
  • rendering/RenderLayer.h:
  • rendering/RenderObject.cpp: (WebCore::RenderObject::transformFromContainer):
11:17 AM Changeset in webkit [41454] by darin@chromium.org
  • 2 edits in trunk/WebCore

2009-03-05 Mike Belshe <​mike@belshe.com>

Reviewed by Darin Fisher.

​https://bugs.webkit.org/show_bug.cgi?id=24391
Frame.cpp uses JSC specific includes

  • page/Frame.cpp:
10:40 AM Changeset in webkit [41453] by kov@webkit.org
  • 2 edits in trunk/WebCore

2009-03-05 Gustavo Noronha Silva <Gustavo Noronha Silva>

Reviewed by Alexey Proskuryakov.

​https://bugs.webkit.org/show_bug.cgi?id=24389
WebKitGTK+ crashes when cancelling plugin loads

Remove bogus calls to the client's didFinishLoading method from
our ResourceHandle::cancel implementation. Calling
didFinishLoading here is mostly inoffensive for most loads, but
causes crashes when plugin loads are cancelled.

  • platform/network/soup/ResourceHandleSoup.cpp: (WebCore::ResourceHandle::cancel):
10:34 AM Changeset in webkit [41452] by sfalken@apple.com
  • 2 edits in trunk/WebCore

2009-03-05 Steve Falkenburg <​sfalken@apple.com>

Windows build fix.


  • WebCore.vcproj/QTMovieWin.vcproj:
10:16 AM Changeset in webkit [41451] by treat@webkit.org
  • 2 edits in trunk/WebCore

2009-03-05 Adam Treat <​adam.treat@torchmobile.com>

Build fix for when ENABLE_NETSCAPE_PLUGIN_API = 0. The method
ScriptController::jsObjectForPluginElement(HTMLPlugInElement*); is not
protected by an #if and uses HTMLPlugInElement so it must be included.

  • bindings/js/ScriptController.cpp:
9:34 AM Changeset in webkit [41450] by Dimitri Glazkov
  • 2 edits in trunk/WebCore

2009-03-05 Dimitri Glazkov <Dimitri Glazkov>

GTK Build fix.

  • inspector/ConsoleMessage.h: Use proper header.
9:14 AM Changeset in webkit [41449] by Dimitri Glazkov
  • 8 edits
    8 adds in trunk/WebCore

2009-03-05 Dimitri Glazkov <Dimitri Glazkov>

Reviewed by Timothy Hatcher.

​https://bugs.webkit.org/show_bug.cgi?id=24376
Split InspectorController.cpp file into separate classes.

  • GNUmakefile.am: Modified to include new files.
  • WebCore.pro: Ditto.
  • WebCore.scons: Ditto.
  • WebCore.vcproj/WebCore.vcproj: Ditto.
  • WebCore.xcodeproj/project.pbxproj: Ditto.
  • WebCoreSources.bkl: Ditto.
  • inspector/ConsoleMessage.cpp: Added.
  • inspector/ConsoleMessage.h: Added.
  • inspector/InspectorController.cpp:
  • inspector/InspectorDOMStorageResource.cpp: Added.
  • inspector/InspectorDOMStorageResource.h: Added.
  • inspector/InspectorDatabaseResource.cpp: Added.
  • inspector/InspectorDatabaseResource.h: Added.
  • inspector/InspectorResource.cpp: Added.
  • inspector/InspectorResource.h: Added.
9:12 AM Changeset in webkit [41448] by eric.carlson@apple.com
  • 4 edits in trunk/WebCore

2009-03-05 Eric Carlson <​eric.carlson@apple.com>

Reviewed by Darin Adler

​https://bugs.webkit.org/show_bug.cgi?id=24387
Remove media element bufferingRate attribute. No test necessary as there
were none for this attribute.

  • html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::HTMLMediaElement): Don't initialize m_bufferingRate. (WebCore::HTMLMediaElement::loadInternal): Ditto. (WebCore::HTMLMediaElement::setNetworkState): Ditto. (WebCore::HTMLMediaElement::progressEventTimerFired): Don't calculate m_bufferingRate.
  • html/HTMLMediaElement.h: Remove m_bufferingRate.
  • html/HTMLMediaElement.idl: Ditto.
4:47 AM Changeset in webkit [41447] by xan@webkit.org
  • 3 edits in trunk/WebCore

2009-03-05 Xan Lopez <​xan@gnome.org>

Reviewed by Mark Rowe.

​https://bugs.webkit.org/show_bug.cgi?id=24377
[GTK] Comply better with coding style guidelines in ResourceHandleSoup

Use C++ booleans, 0 instead of NULL, prefix boolean variables with
'is', do not use 'else if' if the previous if had a return, delete
trailing whitespace, etc.

  • platform/network/ResourceHandleInternal.h: (WebCore::ResourceHandleInternal::ResourceHandleInternal):
  • platform/network/soup/ResourceHandleSoup.cpp: (WebCore::WebCoreSynchronousLoader::WebCoreSynchronousLoader): (WebCore::fillResponseFromMessage): (WebCore::restartedCallback): (WebCore::finishedCallback): (WebCore::parseDataUrl): (WebCore::ensureSessionIsInitialized): (WebCore::ResourceHandle::startHttp): (WebCore::reportUnknownProtocolError): (WebCore::ResourceHandle::start): (WebCore::cleanupGioOperation): (WebCore::closeCallback): (WebCore::readCallback): (WebCore::openCallback): (WebCore::queryInfoCallback): (WebCore::ResourceHandle::startGio):
2:06 AM Changeset in webkit [41446] by ariya@webkit.org
  • 2 edits in trunk/WebKit/qt

2009-03-05 Ariya Hidayat <​ariya.hidayat@nokia.com>

Rubber-stamped by Simon Hausmann.

[Qt] NPAPI plugins are supported, adjust the API documentation.

  • Api/qwebsettings.cpp:
12:05 AM Changeset in webkit [41445] by mrowe@apple.com
  • 2 edits in trunk/JavaScriptCore

Fix the build.

Sprinkle "static" around NumberConstructor.cpp in order to please the compiler.

  • runtime/NumberConstructor.cpp:

(JSC::numberConstructorNaNValue):
(JSC::numberConstructorNegInfinity):
(JSC::numberConstructorPosInfinity):
(JSC::numberConstructorMaxValue):
(JSC::numberConstructorMinValue):

Mar 4, 2009:

11:28 PM Changeset in webkit [41444] by mrowe@apple.com
  • 2 edits in trunk/WebKit/mac

<rdar://problem/6206172> Adoption of new Cocoa API for dictionary contextual menu

Reviewed by Dan Bernstein.

  • WebView/WebHTMLView.mm:

(-[WebHTMLView _lookUpInDictionaryFromMenu:]):

10:04 PM Changeset in webkit [41443] by mrowe@apple.com
  • 3 edits in trunk/JavaScriptCore

<rdar://problem/6354858> FastMallocZone's enumeration code reports fragmented administration space

Reviewed by Oliver Hunt.

The handling of MALLOC_ADMIN_REGION_RANGE_TYPE in FastMalloc's zone was incorrect. It was attempting
to record the memory containing and individual span as an administrative region, when all memory
allocated via MetaDataAlloc should in fact be recorded. This was causing memory regions allocated
via MetaDataAlloc to appear as "VM_ALLOCATE ?" in vmmap output. They are now correctly reported as
"MALLOC_OTHER" regions associated with the JavaScriptCore FastMalloc zone.

Memory is allocated via MetaDataAlloc from two locations: PageHeapAllocator, and TCMalloc_PageMap{2,3}.
These two cases are handled differently.

PageHeapAllocator is extended to keep a linked list of memory regions that it has allocated. The
first object in an allocated region contains the link to the previously allocated region. To record
the administrative regions of a PageHeapAllocator we can simply walk the linked list and record
each allocated region we encounter.

TCMalloc_PageMaps allocate memory via MetaDataAlloc to store each level of the radix tree. To record
the administrative regions of a TCMalloc_PageMap we walk the tree and record the storage used for nodes
at each position rather than the nodes themselves.

A small performance improvement is achieved by coalescing adjacent memory regions inside the PageMapMemoryUsageRecorder
so that fewer calls in to the range recorder are necessary. We further reduce the number of calls to the
range recorder by aggregating the in-use ranges of a given memory region into a local buffer before recording
them with a single call. A similar approach is also used by AdminRegionRecorder.

  • wtf/FastMalloc.cpp:

(WTF::PageHeapAllocator::Init):
(WTF::PageHeapAllocator::New):
(WTF::PageHeapAllocator::recordAdministrativeRegions):
(WTF::TCMallocStats::FreeObjectFinder::isFreeObject):
(WTF::TCMallocStats::PageMapMemoryUsageRecorder::~PageMapMemoryUsageRecorder):
(WTF::TCMallocStats::PageMapMemoryUsageRecorder::recordPendingRegions):
(WTF::TCMallocStats::PageMapMemoryUsageRecorder::visit):
(WTF::TCMallocStats::AdminRegionRecorder::AdminRegionRecorder):
(WTF::TCMallocStats::AdminRegionRecorder::recordRegion):
(WTF::TCMallocStats::AdminRegionRecorder::visit):
(WTF::TCMallocStats::AdminRegionRecorder::recordPendingRegions):
(WTF::TCMallocStats::AdminRegionRecorder::~AdminRegionRecorder):
(WTF::TCMallocStats::FastMallocZone::enumerate):
(WTF::TCMallocStats::FastMallocZone::FastMallocZone):
(WTF::TCMallocStats::FastMallocZone::init):

  • wtf/TCPageMap.h:

(TCMalloc_PageMap2::visitValues):
(TCMalloc_PageMap2::visitAllocations):
(TCMalloc_PageMap3::visitValues):
(TCMalloc_PageMap3::visitAllocations):

7:10 PM Changeset in webkit [41442] by oliver@apple.com
  • 2 edits
    2 adds in trunk/SunSpider

Added a few more tests to ubench

RS=Gavin Barraclough

Adding a couple of test to cover too few and too many arguments. This
is needed to prevent regressions in all call paths from my current refactoring.

6:36 PM Changeset in webkit [41441] by Simon Fraser
  • 2 edits in trunk/WebCore

2009-03-04 Simon Fraser <Simon Fraser>

Reviewed by Eric Seidel

​https://bugs.webkit.org/show_bug.cgi?id=24328

If an element has backface-visibility: hidden, hit testing should not
hit the back sides of elements. Test for that by inverting the accumulated
transform and looking at the z vector.

Tested by transforms/3d/hit-testing/backface-hit-test.html

  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::hitTestLayer):
6:11 PM Changeset in webkit [41440] by Simon Fraser
  • 1 edit
    21 adds in trunk/LayoutTests

2009-03-04 Simon Fraser <Simon Fraser>

Rubber-stamped by Eric Seidel.

New layout tests for point mapping and hit testing through 3d transforms.
Not run by default yet.

  • platform/mac/transforms/3d/hit-testing/backface-hit-test-expected.txt: Added.
  • platform/mac/transforms/3d/point-mapping/3d-point-mapping-2-expected.txt: Added.
  • platform/mac/transforms/3d/point-mapping/3d-point-mapping-deep-expected.txt: Added.
  • platform/mac/transforms/3d/point-mapping/3d-point-mapping-expected.txt: Added.
  • platform/mac/transforms/3d/point-mapping/3d-point-mapping-origins-expected.txt: Added.
  • platform/mac/transforms/3d/point-mapping/3d-point-mapping-preserve-3d-expected.txt: Added.
  • transforms/3d/cssmatrix-3d-interface-expected.txt: Added.
  • transforms/3d/cssmatrix-3d-interface.xhtml: Added.
  • transforms/3d/hit-testing/backface-hit-test.html: Added.
  • transforms/3d/point-mapping/3d-point-mapping-2.html: Added.
  • transforms/3d/point-mapping/3d-point-mapping-deep.html: Added.
  • transforms/3d/point-mapping/3d-point-mapping-origins.html: Added.
  • transforms/3d/point-mapping/3d-point-mapping-preserve-3d.html: Added.
  • transforms/3d/point-mapping/3d-point-mapping.html: Added.
  • transforms/3d/point-mapping/point-mapping-helpers.js: Added. (mousemoved): (dispatchEvent): (clicked): (log): (runTest):
5:13 PM Changeset in webkit [41439] by eric.carlson@apple.com
  • 2 edits in trunk/LayoutTests

2009-03-04 Eric Carlson <​eric.carlson@apple.com>

  • Correct bogus result checked in as part of r41432.
  • media/video-can-play-type-expected.txt:
4:57 PM Changeset in webkit [41438] by eric@webkit.org
  • 2 edits in trunk/WebCore

2009-03-04 Adam Langley <​agl@google.com>

Reviewed by Darin Fisher.

r41362 mistakenly added functions "RenderThemeWin::" into
RenderThemeChromiumGtk.cpp. When correcting this, I somehow changed
them to void return types. This patch switches them back to ints.

​https://bugs.webkit.org/show_bug.cgi?id=24360

  • rendering/RenderThemeChromiumLinux.cpp: (WebCore::RenderThemeChromiumLinux::buttonInternalPaddingLeft): (WebCore::RenderThemeChromiumLinux::buttonInternalPaddingRight): (WebCore::RenderThemeChromiumLinux::buttonInternalPaddingTop): (WebCore::RenderThemeChromiumLinux::buttonInternalPaddingBottom):
4:57 PM Changeset in webkit [41437] by eric@webkit.org
  • 3 edits in trunk/WebCore

2009-03-04 Adam Langley <​agl@google.com>

Reviewed by Darin Fisher.

Chromium Linux: change some metrics to better match Windows after
r41416. Aesthetically this may be worse, but web-compat is king.

Also, the previous code had an off by one error when drawing
scrollbars which caused the scrollbar to overflow it's bounds by 1px
at the right and bottom edges.

​https://bugs.webkit.org/show_bug.cgi?id=24369

  • rendering/RenderThemeChromiumLinux.cpp: (WebCore::): (WebCore::RenderThemeChromiumLinux::systemFont):
  • platform/chromium/ScrollbarThemeChromiumLinux.cpp: (WebCore::ScrollbarThemeChromium::paintTrackPiece):
3:48 PM Changeset in webkit [41436] by pam@chromium.org
  • 1 edit
    2 adds in trunk/LayoutTests

2009-03-04 Pamela Greene <​pam@chromium.org>

Reviewed by Darin Fisher.

Add test to ensure that window.frames is self-referential
​https://bugs.webkit.org/show_bug.cgi?id=24341

  • fast/dom/Window/window-frames-self-referential-expected.txt: Added.
  • fast/dom/Window/window-frames-self-referential.html: Added.
2:58 PM Changeset in webkit [41435] by eric@webkit.org
  • 2 edits in trunk/WebCore

Reviewed by Adam Roben.

Add an ASSERT to better demonstrate the cause of the crash in
​https://bugs.webkit.org/show_bug.cgi?id=23736

  • loader/DocLoader.cpp: (WebCore::DocLoader::~DocLoader):
2:29 PM Changeset in webkit [41434] by levin@chromium.org
  • 3 edits
    5 adds in trunk

WebCore:

2009-03-04 David Levin <​levin@chromium.org>

Reviewed by Alexey Proskuryakov.

Bug 24337: Assert when doing sync XHR in a worker for a cacheable response.
<​https://bugs.webkit.org/show_bug.cgi?id=24337>

Tests: http/tests/xmlhttprequest/access-control-basic-denied-preflight-cache.html

http/tests/xmlhttprequest/workers/xmlhttprequest-file-not-found.html

  • loader/mac/ResourceLoaderMac.mm: (WebCore::ResourceLoader::willCacheResponse): An identifier is only asssigned if resource load callbacks are done. So don't send willCacheResponse which uses identifier if resource load callbacks aren't being sent.

LayoutTests:

2009-03-04 David Levin <​levin@chromium.org>

Reviewed by Alexey Proskuryakov.

Bug 24337: Assert when doing sync XHR in a worker for a cacheable response.
<​https://bugs.webkit.org/show_bug.cgi?id=24337>

  • http/tests/xmlhttprequest/access-control-basic-denied-preflight-cache-expected.txt: Added.
  • http/tests/xmlhttprequest/access-control-basic-denied-preflight-cache.html: Added.
  • http/tests/xmlhttprequest/workers/resources/xmlhttprequest-file-not-found.js: Added. (log): (done):
  • http/tests/xmlhttprequest/workers/xmlhttprequest-file-not-found-expected.txt: Added.
  • http/tests/xmlhttprequest/workers/xmlhttprequest-file-not-found.html: Added.
2:29 PM Changeset in webkit [41433] by levin@chromium.org
  • 4 edits
    4 adds in trunk

WebCore:

2009-03-04 David Levin <​levin@chromium.org>

Reviewed by Alexey Proskuryakov.

Bug 24330: Sync xhr in workers should send an abort exception when the worker is terminated.
<​https://bugs.webkit.org/show_bug.cgi?id=24330>

Test: http/tests/xmlhttprequest/workers/abort-exception-assert.html

  • dom/ExceptionCode.cpp: (WebCore::xmlHttpRequestExceptionNames): Added missing ABORT_ERR whose absence caused an assert.
  • loader/WorkerThreadableLoader.cpp: (WebCore::WorkerThreadableLoader::loadResourceSynchronously): (WebCore::WorkerThreadableLoader::MainThreadBridge::cancel): Add more logic to handle the termination case for sync xhr.

LayoutTests:

2009-03-04 David Levin <​levin@chromium.org>

Reviewed by Alexey Proskuryakov.

Bug 24330: Sync xhr in workers should send an abort exception when the worker is terminated.
<​https://bugs.webkit.org/show_bug.cgi?id=24330>

Added test to verify to terminate a worker while it is doing a synchronous xhr.
It does not verify that the exception is a ABORT_ERR because I couldn't figure out a way
to actually do this.

  • http/tests/xmlhttprequest/workers/abort-exception-assert-expected.txt: Added.
  • http/tests/xmlhttprequest/workers/abort-exception-assert.html: Added.
  • http/tests/xmlhttprequest/workers/resources/endless-response.php: Copied from LayoutTests/http/tests/xmlhttprequest/resources/endlessxml.php.
  • http/tests/xmlhttprequest/workers/resources/endless-sync-xhr.js: Added.
2:21 PM Changeset in webkit [41432] by eric.carlson@apple.com
  • 8 edits
    2 adds in trunk

2009-03-04 Eric Carlson <​eric.carlson@apple.com>

Reviewed by Antti Koivisto.

​https://bugs.webkit.org/show_bug.cgi?id=24364
Add support for HTMLMediaElement canPlayType method. Make
MediaPlayer::supportsType take a ContentType instead of a
separate mime type and codecs parameter.

Test: media/video-can-play-type.html

  • dom/DOMImplementation.cpp: (WebCore::DOMImplementation::createDocument):
  • html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::canPlayType): Add canPlayType method. (WebCore::HTMLMediaElement::loadInternal): selectMediaURL returns a ContentType. (WebCore::HTMLMediaElement::selectMediaURL): Return a ContentType instead of raw MIME type. (WebCore::HTMLMediaElement::initialURL): selectMediaURL returns a ContentType.
  • html/HTMLMediaElement.h: Add prototype.
  • html/HTMLMediaElement.idl: Ditto.
  • platform/graphics/MediaPlayer.cpp: (WebCore::MediaPlayer::load): Take a ContentType instead of raw MIME type. (WebCore::MediaPlayer::supportsType): Ditto.
  • platform/graphics/MediaPlayer.h:

2009-03-04 Eric Carlson <​eric.carlson@apple.com>

Reviewed by Antti Koivisto.

​https://bugs.webkit.org/show_bug.cgi?id=24364
Test HTMLMediaElement canPlayType method.

  • media/video-can-play-type-expected.txt: Added.
  • media/video-can-play-type.html: Added.
2:01 PM Changeset in webkit [41431] by Antti Koivisto
  • 7 edits in trunk

JavaScriptCore:

2009-03-04 Antti Koivisto <Antti Koivisto>

Reviewed by Dave Hyatt.

​https://bugs.webkit.org/show_bug.cgi?id=24359
Repaint throttling mechanism


Set ENABLE_REPAINT_THROTTLING to 0 by default.

  • wtf/Platform.h:

WebCore:

2009-03-04 Antti Koivisto <Antti Koivisto>

Reviewed by Dave Hyatt.

​https://bugs.webkit.org/show_bug.cgi?id=24359
Repaint throttling mechanism


Excessive repainting can slow down page loadind. This implements a timer
based throttling mechanism. It is behind ENABLE(REPAINT_THROTTLING) and not
enabled by default.

  • loader/FrameLoader.cpp: (WebCore::FrameLoader::checkCompleted):
  • page/EventHandler.cpp: (WebCore::EventHandler::dispatchDragEvent): (WebCore::EventHandler::dispatchMouseEvent): (WebCore::EventHandler::keyEvent): (WebCore::EventHandler::handleTextInputEvent):
  • page/FrameView.cpp: (WebCore::FrameView::FrameView): (WebCore::FrameView::reset): (WebCore::FrameView::repaintContentRectangle): (WebCore::FrameView::beginDeferredRepaints): (WebCore::FrameView::endDeferredRepaints): (WebCore::FrameView::checkStopDelayingDeferredRepaints): (WebCore::FrameView::doDeferredRepaints): (WebCore::FrameView::updateDeferredRepaintDelay): (WebCore::FrameView::resetDeferredRepaintDelay): (WebCore::FrameView::adjustedDeferredRepaintDelay): (WebCore::FrameView::deferredRepaintTimerFired): (WebCore::FrameView::paintContents):
  • page/FrameView.h:
1:53 PM Changeset in webkit [41430] by weinig@apple.com
  • 9 edits in trunk/WebCore

2009-03-04 Sam Weinig <​sam@webkit.org>

Rubber-stamped by Antti Koivisto.

Remove LOW_BANDWIDTH_DISPLAY as it is not being used by any platforms.

  • dom/Document.cpp: (WebCore::Document::Document):
  • dom/Document.h: (WebCore::Document::haveStylesheetsLoaded):
  • html/HTMLTokenizer.cpp: (WebCore::HTMLTokenizer::scriptHandler):
  • loader/Cache.cpp: (WebCore::Cache::requestResource):
  • loader/CachedCSSStyleSheet.cpp: (WebCore::CachedCSSStyleSheet::checkNotify):
  • loader/DocLoader.h:
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::FrameLoader): (WebCore::FrameLoader::requestFrame): (WebCore::FrameLoader::stopLoading): (WebCore::FrameLoader::begin): (WebCore::FrameLoader::write): (WebCore::FrameLoader::endIfNotLoadingMainResource): (WebCore::FrameLoader::checkCompleted): (WebCore::FrameLoader::requestObject): (WebCore::FrameLoader::loadItem):
  • loader/FrameLoader.h:
1:24 PM Changeset in webkit [41429] by kmccullough@apple.com
  • 6 edits in trunk/LayoutTests

2009-03-04 Kevin McCullough <​kmccullough@apple.com>

  • Build bot fix.
  • fast/profiler/many-calls-in-the-same-scope-expected.txt:
  • fast/profiler/multiple-and-different-scoped-anonymous-function-calls-expected.txt:
  • fast/profiler/multiple-and-different-scoped-function-calls-expected.txt:
  • fast/profiler/nested-start-and-stop-profiler-expected.txt:
  • fast/profiler/profile-calls-in-included-file-expected.txt:
12:57 PM Changeset in webkit [41428] by xan@webkit.org
  • 8 edits
    2 moves in trunk

2009-03-02 Xan Lopez <​xan@gnome.org>

Reviewed by Mark Rowe.

​https://bugs.webkit.org/show_bug.cgi?id=24287
[GTK] Move auth dialog feature to WebKit/

Add WebKitSoupAuthDialog files to build.

  • GNUmakefile.am:

WebCore:

2009-03-02 Xan Lopez <​xan@gnome.org>

Reviewed by Mark Rowe.

​https://bugs.webkit.org/show_bug.cgi?id=24287
[GTK] Move auth dialog feature to WebKit/

Remove WebKitSoupAuthDialog files from build and stop using it.

  • GNUmakefile.am:
  • platform/network/soup/ResourceHandleSoup.cpp: (WebCore::ensureSessionIsInitialized):
  • platform/network/soup/webkit-soup-auth-dialog.c: Removed.
  • platform/network/soup/webkit-soup-auth-dialog.h: Removed.

WebKit/gtk:

2009-03-02 Xan Lopez <​xan@gnome.org>

Reviewed by Mark Rowe.

​https://bugs.webkit.org/show_bug.cgi?id=24287
[GTK] Move auth dialog feature to WebKit/

Add WebKitSoupAuthDialog and add it to the session in webkit_init.

  • webkit/webkitprivate.cpp: (currentToplevelCallback): (webkit_init):
  • webkit/webkitsoupauthdialog.c: Added. (webkit_soup_auth_dialog_class_init): (webkit_soup_auth_dialog_init): (webkit_soup_auth_dialog_session_feature_init): (free_authData): (set_password_callback): (response_callback): (table_add_entry): (show_auth_dialog): (find_password_callback): (session_authenticate): (attach):
  • webkit/webkitsoupauthdialog.h: Added.
11:58 AM Changeset in webkit [41427] by Simon Fraser
  • 3 edits
    4 adds in trunk

2009-03-04 Simon Fraser <Simon Fraser>

Reviewed by Dave Hyatt

​https://bugs.webkit.org/show_bug.cgi?id=24361

Reinstate code that sets result.innerNode when hitTest() returns true,
but never filled in the innerNode. Fixes hit testing of generated content.

Test: fast/css-generated-content/hit-test-generated-content.html

  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::hitTestContents):
11:56 AM Changeset in webkit [41426] by abarth@webkit.org
  • 18 edits in trunk

WebCore:

2009-03-04 Adam Barth <​abath@webkit.org>

Reviewed by Alexey Proskuryakov.

​https://bugs.webkit.org/show_bug.cgi?id=24356

Fix WebKit style for allowUniversalAccessFromFileURLs.

  • WebCore.base.exp:
  • dom/Document.cpp: (WebCore::Document::initSecurityContext):
  • page/Settings.cpp: (WebCore::Settings::Settings): (WebCore::Settings::setAllowUniversalAccessFromFileURLs):
  • page/Settings.h: (WebCore::Settings::allowUniversalAccessFromFileURLs):

WebKit/mac:

2009-03-04 Adam Barth <​abath@webkit.org>

Reviewed by Alexey Proskuryakov.

​https://bugs.webkit.org/show_bug.cgi?id=24356

Fix WebKit style for allowUniversalAccessFromFileURLs.

  • WebView/WebPreferenceKeysPrivate.h:
  • WebView/WebPreferences.mm: (+[WebPreferences initialize]): (-[WebPreferences allowUniversalAccessFromFileURLs]): (-[WebPreferences setAllowUniversalAccessFromFileURLs:]):
  • WebView/WebPreferencesPrivate.h:
  • WebView/WebView.mm: (-[WebView _preferencesChangedNotification:]):

WebKit/qt:

2009-03-04 Adam Barth <​abath@webkit.org>

Reviewed by Alexey Proskuryakov.

​https://bugs.webkit.org/show_bug.cgi?id=24356

Fix WebKit style for allowUniversalAccessFromFileURLs.

  • Api/qwebsettings.cpp: (QWebSettingsPrivate::apply):

WebKit/win:

2009-03-04 Adam Barth <​abath@webkit.org>

Reviewed by Alexey Proskuryakov.

​https://bugs.webkit.org/show_bug.cgi?id=24356

Fix WebKit style for allowUniversalAccessFromFileURLs.

  • Interfaces/IWebPreferencesPrivate.idl:
  • WebPreferenceKeysPrivate.h:
  • WebPreferences.cpp: (WebPreferences::initializeDefaultSettings): (WebPreferences::allowUniversalAccessFromFileURLs): (WebPreferences::setAllowUniversalAccessFromFileURLs):
  • WebPreferences.h:
  • WebView.cpp: (WebView::notifyPreferencesChanged):
10:25 AM Changeset in webkit [41425] by beidson@apple.com
  • 2 edits in trunk/WebCore

2009-03-04 Brady Eidson <​beidson@apple.com>

Reviewed by Darin Adler

<rdar://problem/6619630> Quick Look of vCards stuck on image of first card opened.

I narrowed this down to ​http://trac.webkit.org/changeset/39304 which, among other things,
consolidated some of the various decision making pieces of the Cache into the new method
FrameLoader::cachePolicy().

Before 39304, when deciding whether to use an existing CachedResource, we checked if the FrameLoader
is reloading. If it is, we'd evict any existing resource then recreate it. Quick looks uses the
same URL for this image every time and expects it to be reloaded with each new card.

The FrameLoader::isReloading() check did one thing - Ask the DocumentLoader if it's cache policy
is "ReloadIgnoringCacheData". This check was lost in the consolidation to the new method.

  • loader/FrameLoader.cpp: (WebCore::FrameLoader::cachePolicy): Restore the DocumentLoader's cachePolicy check as a possible condition for returning CachePolicyReload.
9:59 AM Changeset in webkit [41424] by timothy@apple.com
  • 2 edits in trunk/WebCore
  • English.lproj/localizedStrings.js: Update strings to include "DATABASES", "LOCAL STORAGE" and "SESSION STORAGE".
9:59 AM Changeset in webkit [41423] by timothy@apple.com
  • 2 edits in trunk/WebCore

Fix a regression where the Web Inspector console would not animate
in or out correctly.

Reviewed by Anders Carlsson.

  • inspector/front-end/inspector.css: Move a z-index to a child element to get the correct stacking order during the animation.
9:56 AM Changeset in webkit [41422] by hyatt@apple.com
  • 5 edits
    4 adds in trunk

WebCore:

2009-03-03 David Hyatt <​hyatt@apple.com>

​https://bugs.webkit.org/show_bug.cgi?id=24201, pathologically bad block layout.

Make sure to factor clear deltas into y position estimates. Also avoid doing the comparison of
the final position against the y position estimate until after the clear has happened. This gets rid
of some duplicated cut/pasted code and also ensures a layout delta only has to be put in once.

Reviewed by Dan Bernstein

Added fast/block/float/nested-clearance.html

  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::collapseMargins): (WebCore::RenderBlock::clearFloatsIfNeeded): (WebCore::RenderBlock::estimateVerticalPosition): (WebCore::RenderBlock::layoutBlockChildren): (WebCore::RenderBlock::getClearDelta):
  • rendering/RenderBlock.h:

LayoutTests:

2009-03-03 David Hyatt <​hyatt@apple.com>

Test case for ​https://bugs.webkit.org/show_bug.cgi?id=24201

Reviewed by Dan Bernstein

  • fast/block/float/nested-clearance.html: Added.
  • platform/mac/fast/block/float/nested-clearance-expected.checksum: Added.
  • platform/mac/fast/block/float/nested-clearance-expected.png: Added.
  • platform/mac/fast/block/float/nested-clearance-expected.txt: Added.
9:39 AM Changeset in webkit [41421] by abarth@webkit.org
  • 3 edits in trunk/WebKit/qt

2009-03-03 Adam Barth <​abarth@webkit.org>

Reviewed by Alexey Proskuryakov.

​https://bugs.webkit.org/show_bug.cgi?id=24340

Expose AllowUniversalAccessFromFileUrls to Qt clients.

  • Api/qwebsettings.cpp: (QWebSettingsPrivate::apply): (QWebSettings::QWebSettings):
  • Api/qwebsettings.h:
6:42 AM Changeset in webkit [41420] by Simon Hausmann
  • 8 edits in trunk/WebCore

2009-03-02 Kim Grönholm <​kim.gronholm@nomovok.com>

Reviewed by Simon Hausmann.

Improvement to 3d transformations rendering in QtWebKit. QTransform is used
instead of QMatrix. This allows perspective transformations since QTransform is
a true 3x3 matrix.

6:21 AM Changeset in webkit [41419] by Simon Hausmann
  • 3 edits in trunk/WebCore

2009-02-24 Laszlo Gombos <Laszlo Gombos>

Reviewed by Simon Hausmann.

​https://bugs.webkit.org/show_bug.cgi?id=24151
Fix Qt/S60 build break

1:56 AM BuildingGtk edited by oszi@inf.u-szeged.hu
(diff)
1:54 AM QtWebKitTodo edited by Simon Hausmann
(diff)
Note: See TracTimeline for information about the timeline view.