Timeline
Mar 9, 2009:
- 10:50 PM Changeset in webkit [41545] by
-
- 3 edits4 adds in trunk
2009-03-09 Simon Fraser <Simon Fraser>
Reviewed by Dan Bernstein, Oliver Hunt
When repainting replaced elements, need to union the selection
and overflow rects because either may extend outside the other.
Test: fast/repaint/transform-replaced-shadows.html
- rendering/RenderReplaced.cpp: (WebCore::RenderReplaced::clippedOverflowRectForRepaint):
- 6:09 PM Changeset in webkit [41544] by
-
- 5 edits3 adds in trunk
Bug 24447: REGRESSION (r41508): Google Maps does not complete initialization
<rdar://problem/6657774>
Reviewed by Gavin Barraclough
r41508 actually exposed a pre-existing bug where we were not invalidating the result
register cache at jump targets. This causes problems when condition loads occur in an
expression -- namely through the ?: and operators. This patch corrects these issues by marking the target of all forward jumps as being a jump target, and then clears the
result register cache when ever it starts generating code for a targeted instruction.
I do not believe it is possible to cause this class of failure outside of a single
expression, and expressions only provide forward branches, so this should resolve this
entire class of bug. That said i've included a test case that gets as close as possible
to hitting this bug with a back branch, to hopefully prevent anyone from introducing the
problem in future.
- 5:38 PM Changeset in webkit [41543] by
-
- 2 edits in trunk/WebCore
2009-03-09 Stephanie Lewis <Stephanie Lewis>
Fix build.
- editing/Editor.cpp: (WebCore::Editor::advanceToNextMisspelling): (WebCore::markAllMisspellingsAndBadGrammarInRanges):
- 5:22 PM Changeset in webkit [41542] by
-
- 2 edits in trunk/WebCore
2009-03-09 Kim Christensen <kimworking@gmail.com>
Reviewed by Darin Fisher.
https://bugs.webkit.org/show_bug.cgi?id=24276
Dropdown / select boxes do not consider the windows task bar in Chromium.
- platform/chromium/PopupMenuChromium.cpp: (WebCore::PopupContainer::showPopup):
- 3:49 PM Changeset in webkit [41541] by
-
- 1 copy in releases/WebKitGTK/webkit-1.1.1
Tagging WebKitGTK+'s 1.1.1 release.
- 3:40 PM Changeset in webkit [41540] by
-
- 1 add in releases/WebKitGTK
Creating a place to tag WebKitGTK+ releases.
- 3:34 PM Changeset in webkit [41539] by
-
- 2 edits14 deletes in trunk/LayoutTests
2009-03-09 Sam Weinig <sam@webkit.org>
Roll out r41393. It has been causing failures on the bots for about a week.
- fast/block/float/resources/se_arrow.png: Removed.
- fast/block/float/resources/yinyang.png: Removed.
- fast/block/float/t0905-c414-flt-fit-01-d-g.html: Removed.
- fast/block/float/t0905-c5525-fltblck-00-d-ag.html: Removed.
- fast/block/float/t0905-c5526-flthw-00-c-g.html: Removed.
- platform/mac/fast/block/float/t0905-c414-flt-fit-01-d-g-expected.checksum: Removed.
- platform/mac/fast/block/float/t0905-c414-flt-fit-01-d-g-expected.png: Removed.
- platform/mac/fast/block/float/t0905-c414-flt-fit-01-d-g-expected.txt: Removed.
- platform/mac/fast/block/float/t0905-c5525-fltblck-00-d-ag-expected.checksum: Removed.
- platform/mac/fast/block/float/t0905-c5525-fltblck-00-d-ag-expected.png: Removed.
- platform/mac/fast/block/float/t0905-c5525-fltblck-00-d-ag-expected.txt: Removed.
- platform/mac/fast/block/float/t0905-c5526-flthw-00-c-g-expected.checksum: Removed.
- platform/mac/fast/block/float/t0905-c5526-flthw-00-c-g-expected.png: Removed.
- platform/mac/fast/block/float/t0905-c5526-flthw-00-c-g-expected.txt: Removed.
- 3:20 PM Changeset in webkit [41538] by
-
- 4 edits2 adds in trunk
WebCore:
Reviewed by Adele Peterson and Dave Hyatt.
- fix <rdar://problem/6654344> REGRESSION (r41041): Zillow.com has misaligned edit fields
Test: fast/forms/legend-display-none.html
- css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::adjustRenderStyle): Change the display property of legend elements to 'block' unless it is 'none'.
- css/html4.css: Do not force the display property of legend elements to 'block' using CSS, because that prevents style rules from setting it to 'none'.
LayoutTests:
Reviewed by Adele Peterson and Dave Hyatt.
- test for <rdar://problem/6654344> REGRESSION (r41041): Zillow.com has misaligned edit fields
- fast/forms/legend-display-none-expected.txt: Added.
- fast/forms/legend-display-none.html: Added.
- 2:01 PM Changeset in webkit [41537] by
-
- 3 edits2 adds in trunk
WebCore:
2009-03-09 Alpha Lam <hclam@chromium.org>
Reviewed by Dave Hyatt.
Fix an incorrect criteria in the if statement that leaves references to
deleted floating objects in RenderBlock.
Test: fast/block/float/crash-on-absolute-positioning.html
- rendering/RenderBlock.cpp: (WebCore::RenderBlock::markAllDescendantsWithFloatsForLayout):
LayoutTests:
2009-03-09 Alpha Lam <hclam@chromium.org>
Reviewed by Dave Hyatt.
Added regression test for a bug that causes crashes.
- fast/block/float/crash-on-absolute-positioning.html: Added.
- platform/mac/fast/block/float/crash-on-absolute-positioning-expected.txt: Added.
- 2:01 PM Changeset in webkit [41536] by
-
- 3 edits1 add in trunk/JavaScriptCore
2009-03-09 David Levin <levin@chromium.org>
Reviewed by Darin Adler.
Bug 23175: String and UString should be able to share a UChar* buffer.
<https://bugs.webkit.org/show_bug.cgi?id=23175>
Add CrossThreadRefCounted.
- wtf/CrossThreadRefCounted.h: Added. (WTF::CrossThreadRefCounted::create): (WTF::CrossThreadRefCounted::isShared): (WTF::CrossThreadRefCounted::dataAccessMustBeThreadSafe): (WTF::CrossThreadRefCounted::mayBePassedToAnotherThread): (WTF::CrossThreadRefCounted::CrossThreadRefCounted): (WTF::CrossThreadRefCounted::~CrossThreadRefCounted): (WTF::CrossThreadRefCounted::ref): (WTF::CrossThreadRefCounted::deref): (WTF::CrossThreadRefCounted::release): (WTF::CrossThreadRefCounted::copy): (WTF::CrossThreadRefCounted::threadSafeDeref):
- wtf/RefCounted.h:
- wtf/Threading.h: (WTF::ThreadSafeSharedBase::ThreadSafeSharedBase): (WTF::ThreadSafeSharedBase::derefBase): (WTF::ThreadSafeShared::ThreadSafeShared): (WTF::ThreadSafeShared::deref):
- 12:48 PM Changeset in webkit [41535] by
-
- 2 edits in trunk/WebCore
2009-03-09 Mike Belshe <mike@belshe.com>
Reviewed by Eric Seidel.
Unify JSC/V8 idl file.
https://bugs.webkit.org/show_bug.cgi?id=24424
- page/Location.idl:
- 12:48 PM Changeset in webkit [41534] by
-
- 2 edits in trunk/WebCore
2009-03-09 Mike Belshe <mike@belshe.com>
Reviewed by Eric Seidel.
Unify JSC/V8 for History.idl.
- page/History.idl:
- 12:48 PM Changeset in webkit [41533] by
-
- 2 edits in trunk/WebCore
2009-03-09 Mike Belshe <mike@belshe.com>
Reviewed by Eric Seidel.
Unify JSC/V8 implementations of DOMWindow.idl.
- page/DOMWindow.idl:
- 11:39 AM Changeset in webkit [41532] by
-
- 8 edits in trunk/WebKit/mac
2009-03-09 Anders Carlsson <andersca@apple.com>
Reviewed by Kevin Decker.
WebKit side of <rdar://problem/6530007>
- Plugins/Hosted/NetscapePluginHostProxy.mm: (WKPCEnumerate): Call NetscapePluginInstanceProxy::enumerate.
- Plugins/Hosted/NetscapePluginInstanceProxy.h:
- Plugins/Hosted/NetscapePluginInstanceProxy.mm: (WebKit::NetscapePluginInstanceProxy::enumerate): Enumerate the JS object and serialize its values.
- Plugins/Hosted/ProxyInstance.h:
- Plugins/Hosted/ProxyInstance.mm: (WebKit::ProxyInstance::getPropertyNames): Ask the plug-in host to get the property names and deserialize them.
- Plugins/Hosted/WebKitPluginClient.defs:
- Plugins/Hosted/WebKitPluginHost.defs:
- 11:06 AM Changeset in webkit [41531] by
-
- 16 edits in trunk/WebCore
2009-03-09 Simon Fraser <Simon Fraser>
Reviewed by Dave Hyatt
Implement mapping of FloatQuads through 3D transforms.
Removed the redundant localToContainerQuad() methods, which can now
shared code with the old mapLocalToAbsolutePoint(), which was
renamed to mapLocalToContainer(). This can now convert a point,
and optionally a FloatQuad, which are carried along in the TransformState.
Optimized TransformState to reduce to simple FloatPoint.move()
if there are no transforms, and to heap-allocate a transform only if
necessary to accumulate transforms (when using preserve-3d).
Tested by 3d point mapping tests, and the inspector highlight (which now shows
the correct quads for 3d-transformed elements).
- 10:01 AM Changeset in webkit [41530] by
-
- 3 edits2 adds in trunk
2009-03-09 Simon Fraser <Simon Fraser>
Reviewed by Dave Hyatt
During hit testing with transforms, if a layer has backface-visibility: hidden,
we need to check for it whether or not the layer has a transform, because it
might be an ancestor that is transformed.
Test: transforms/3d/hit-testing/backface-no-transform-hit-test.html
- rendering/RenderLayer.cpp: (WebCore::RenderLayer::hitTestLayer):
- 9:53 AM Changeset in webkit [41529] by
-
- 2 edits in trunk/WebKit/mac
2009-03-09 Simon Fraser <Simon Fraser>
Reviewed by Oliver Hunt and Cameron Zwarich
The sublayer added to WebHTMLView to host accelerated compositing layers needs to
be a subclass of NSView which allows context menu clicks through.
- WebView/WebHTMLView.mm: (-[WebLayerHostingView rightMouseDown:]): (-[WebHTMLView attachRootLayer:]):
- 9:37 AM Changeset in webkit [41528] by
-
- 4 edits in trunk
2009-03-09 Laszlo Gombos <Laszlo Gombos>
Reviewed by George Staikos.
https://bugs.webkit.org/show_bug.cgi?id=24353
Allow to overrule default build options for Qt build.
- WebCore.pro: Allow to overrule ENABLE_VIDEO and ENABLE_NETSCAPE_PLUGIN_API
- JavaScriptCore.pri: Allow to overrule ENABLE_JIT
- 9:32 AM Changeset in webkit [41527] by
-
- 2 edits in trunk/WebCore
2009-03-09 Adam Treat <adam.treat@torchmobile.com>
Reviewed by George Staikos.
https://bugs.webkit.org/show_bug.cgi?id=24463
WebCore::qstring is detaching and copying twice for every single
WebCore::TextRun that is processed and drawn. This elevates this method
to one of the top-ten most expensive methods in all of QtWebKit according
to profiling. This changes the method so that QString only detaches
when absolutely necessary.
- platform/graphics/qt/FontQt.cpp: (WebCore::qstring): (WebCore::fixSpacing): (WebCore::Font::drawComplexText): (WebCore::Font::floatWidthForComplexText): (WebCore::Font::offsetForPositionForComplexText): (WebCore::Font::selectionRectForComplexText):
Mar 7, 2009:
- 11:29 PM Changeset in webkit [41526] by
-
- 2 edits in trunk/LayoutTests
2009-03-08 Holger Hans Peter Freyther <zecke@selfish.org>
Rubber-stamped by Mark Rowe.
[Gtk] Skip failing tests that require the eventSender.
The Gtk+ platform is lacking an implementation of the
eventSender. We will enable the tests once there is an
implementation of that class.
- platform/gtk/Skipped:
- 10:36 PM Changeset in webkit [41525] by
-
- 33 edits2 adds in trunk
Split ScrollAlignment and ScrollBehavior out of RenderLayer.h so that
Frame.h no longer needs to include it. This cuts the size of the symbols
for a debug build by around 3%.
Reviewed by Oliver Hunt.
- dom/Element.cpp:
(WebCore::Element::scrollIntoView):
(WebCore::Element::scrollIntoViewIfNeeded):
- editing/Editor.cpp:
(WebCore::Editor::insertTextWithoutSendingTextEvent):
(WebCore::Editor::revealSelectionAfterEditingOperation):
- editing/SelectionController.cpp:
(WebCore::SelectionController::setSelection):
- loader/FrameLoader.cpp:
(WebCore::FrameLoader::gotoAnchor):
- page/ContextMenuController.cpp:
(WebCore::ContextMenuController::contextMenuItemSelected):
- page/Frame.cpp:
(WebCore::Frame::revealSelection):
(WebCore::Frame::revealCaret):
- page/Frame.h:
- rendering/RenderLayer.cpp:
(WebCore::RenderLayer::getRectToExpose):
(WebCore::RenderLayer::autoscroll):
- rendering/RenderLayer.h:
- rendering/ScrollBehavior.cpp: Added.
(WebCore::):
- rendering/ScrollBehavior.h: Added.
(WebCore::):
(WebCore::ScrollAlignment::getVisibleBehavior):
(WebCore::ScrollAlignment::getPartialBehavior):
(WebCore::ScrollAlignment::getHiddenBehavior):
Add the new files to the build systems:
- GNUmakefile.am:
- WebCore.base.exp:
- WebCore.pro:
- WebCore.scons:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- WebCoreSources.bkl:
Add includes that were previously pulled in by way of RenderLayer.h from Frame.h:
- dom/Clipboard.cpp:
- editing/EditorCommand.cpp:
- editing/InsertLineBreakCommand.cpp:
- editing/TypingCommand.cpp:
- html/HTMLFormControlElement.cpp:
- loader/archive/cf/LegacyWebArchive.cpp:
- loader/icon/IconLoader.cpp:
- page/animation/AnimationController.cpp:
- rendering/RenderSlider.cpp:
- rendering/RenderTextControl.cpp:
WebKit/mac:
- Plugins/WebNetscapePluginView.mm:
- WebView/WebFrame.mm:
(-[WebFrame _scrollDOMRangeToVisible:]):
(-[WebFrame _insertParagraphSeparatorInQuotedContent]):
(-[WebFrame _replaceSelectionWithFragment:selectReplacement:smartReplace:matchStyle:]):
- WebView/WebHTMLView.mm:
(-[WebHTMLView jumpToSelection:]):
(-[WebHTMLView centerSelectionInVisibleArea:]):
WebKit/win:
- WebView.cpp:
(WebView::centerSelectionInVisibleArea):
- 8:44 PM Changeset in webkit [41524] by
-
- 9 edits in trunk/WebCore
Push the include of Frame.h out of RenderView.h and down to those files
that need it. This cuts the size of symbols for RenderFoo object files
by around 15% in a debug build.
Reviewed Dan Bernstein.
- bindings/objc/DOM.mm:
- rendering/RenderFileUploadControl.cpp:
- rendering/RenderInline.cpp:
- rendering/RenderObject.cpp:
- rendering/RenderReplaced.cpp:
- rendering/RenderText.cpp:
- rendering/RenderView.cpp:
(WebCore::RenderView::zoomFactor):
- rendering/RenderView.h:
- 8:18 PM Changeset in webkit [41523] by
-
- 12 edits in trunk/WebCore
Remove some unnecessary or redundant includes from files related to the JS bindings.
This cuts the size of the symbols for a debug build by around 3%.
Rubber-stamped by Dan Bernstein.
- bindings/js/JSCustomPositionCallback.cpp:
- bindings/js/JSCustomPositionErrorCallback.cpp:
- bindings/js/JSCustomSQLStatementCallback.cpp:
- bindings/js/JSCustomSQLStatementErrorCallback.cpp:
- bindings/js/JSCustomSQLTransactionCallback.cpp:
- bindings/js/JSCustomSQLTransactionErrorCallback.cpp:
- bindings/js/JSCustomVoidCallback.cpp:
- bindings/js/JSCustomXPathNSResolver.cpp:
- bindings/js/JSDocumentCustom.cpp:
- bindings/js/JSPluginElementFunctions.cpp:
- bindings/js/JSSVGPODTypeWrapper.h:
- 8:17 PM Changeset in webkit [41522] by
-
- 9 edits in trunk
[gtk+] Implement LayoutTestController::setJavaScriptProfilingEnabled
setJavaScriptProfilingEnabled is implemented by enabling the
developer extras using the WebKitWebSettings and adding the
JavaScript Profiling option to the WebKitWebInspector.
- 4:21 PM Changeset in webkit [41521] by
-
- 5 edits in trunk/WebCore
2009-03-08 Cameron Zwarich <cwzwarich@uwaterloo.ca>
Reviewed by Oliver Hunt.
Remove the unused methods previousHistoryItem(), setPreviousHistoryItem()
and provisionalHistoryItem() from FrameLoader.
- WebCore.base.exp:
- WebCore.order:
- loader/FrameLoader.cpp: (WebCore::FrameLoader::frameLoadCompleted): (WebCore::FrameLoader::loadItem):
- loader/FrameLoader.h:
- 12:35 PM Changeset in webkit [41520] by
-
- 3 edits in trunk/WebCore
2009-03-08 Gustavo Noronha Silva <Gustavo Noronha Silva>
Reviewed by Holger Freyther.
Implement proper logging for the GTK+ port, inspired by the one in
Qt. We use the WEBKIT_DEBUG environment variable which was already
being used to decide whether to setup a logger for soup or not.
- platform/gtk/LoggingGtk.cpp: (WebCore::getChannelFromName): (WebCore::InitializeLoggingChannelsIfNecessary):
- platform/network/soup/ResourceHandleSoup.cpp: (WebCore::ensureSessionIsInitialized):
- 6:01 AM Changeset in webkit [41519] by
-
- 2 edits in trunk/JavaScriptCore
Build fix.
Reviewed by NOBODY(Build fix)
- 3:47 AM Changeset in webkit [41518] by
-
- 2 edits in trunk/JavaScriptCore
Bug 24268: RuntimeArray is not a fully implemented JSArray
<https://bugs.webkit.org/show_bug.cgi?id=24268>
Reviewed by Cameron Zwarich.
Don't cast a type to JSArray, just because it reportsArray as a supertype
in the JS type system. Doesn't appear feasible to create a testcase
unfortunately as setting up the failure conditions requires internal access
to JSC not present in DRT.
