⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Mar 15, 2009:

7:04 PM Changeset in webkit [41730] by bolsinga@apple.com
  • 2 edits in trunk/WebCore

2009-03-15 Greg Bolsinga <​bolsinga@apple.com>

Reviewed by David Kilzer.

<rdar://problem/6668875> Normalize Geolocation results

  • platform/mac/GeolocationServiceMac.mm: (-[WebCoreCoreLocationObserver locationManager:didUpdateToLocation:fromLocation:]):
6:02 PM Changeset in webkit [41729] by bolsinga@apple.com
  • 2 edits in trunk/WebCore

2009-03-15 Greg Bolsinga <​bolsinga@apple.com>

Reviewed by David Kilzer.

Update ::toString format as suggested by Darin Adler.

  • page/Geoposition.cpp: (WebCore::Geoposition::toString):
5:31 PM Changeset in webkit [41728] by Simon Fraser
  • 3 edits in trunk/JavaScriptCore

2009-03-15 Simon Fraser <Simon Fraser>

Revert r41718 because it broke DumpRenderTree on Tiger.

  • JavaScriptCorePrefix.h:
  • wtf/Platform.h:
4:55 PM Changeset in webkit [41727] by ddkilzer@apple.com
  • 2 edits in trunk/WebCore

<rdar://problem/6668238> WebCore is registering text encodings needlessly from KURL constructor.

Reviewed by Darin Adler.

Yet another case where we would trigger extended encoding loading needlessly.

  • platform/text/TextEncoding.cpp: (WebCore::TextEncoding::encodingForFormSubmission):
4:41 PM Changeset in webkit [41726] by Simon Fraser
  • 2 edits in trunk/WebCore

2009-03-15 Simon Fraser <Simon Fraser>

Build fix: no review.

  • rendering/style/ContentData.h:
4:32 PM Changeset in webkit [41725] by ddkilzer@apple.com
  • 9 edits in trunk/WebCore

Bug 24542: Improve ContentData encapsulation

<​https://bugs.webkit.org/show_bug.cgi?id=24542>

Reviewed by Simon Fraser.

No tests since there is no change in behavior.

  • rendering/RenderObject.cpp: (WebCore::RenderObject::createObject): Used getter methods instead of data members on ContentData class. Used isImage() convenience method.
  • rendering/RenderObjectChildList.cpp: (WebCore::RenderObjectChildList::updateBeforeAfterContent): Ditto.
  • rendering/style/ContentData.cpp: (WebCore::ContentData::clear): Extracted code into deleteContent() method. (WebCore::ContentData::dataEquivalent): Added. Extracted code from StyleRareNonInheritedData::contentDataEquivalent(). (WebCore::ContentData::deleteContent): Added. Used by setter methods.
  • rendering/style/ContentData.h: Made m_type, m_content and m_next private. (WebCore::ContentData::isCounter): Added. (WebCore::ContentData::isImage): Added. (WebCore::ContentData::isNone): Added. (WebCore::ContentData::isText): Added. (WebCore::ContentData::type): Added. (WebCore::ContentData::dataEquivalent): Added. (WebCore::ContentData::image): Added. (WebCore::ContentData::setImage): Added. (WebCore::ContentData::text): Added. (WebCore::ContentData::setText): Added. (WebCore::ContentData::counter): Added. (WebCore::ContentData::setCounter): Added. (WebCore::ContentData::next): Added. (WebCore::ContentData::setNext): Added.
  • rendering/style/CounterContent.h: (WebCore::operator!=): Removed. (WebCore::operator==): Renamed operator!=() and reversed its logic after extracting code from StyleRareNonInheritedData::contentDataEquivalent() to create ContentData::dataEquivalent().
  • rendering/style/RenderStyle.cpp: (WebCore::RenderStyle::setContent): Used new getters and setters on ContentData class. Changed first argument from a StringImpl* to a PassRefPtr<StrimgImpl>. Used isText() convenience method.
  • rendering/style/RenderStyle.h: (WebCore::RenderStyle::setContent): Updated declaration.
  • rendering/style/StyleRareNonInheritedData.cpp: (WebCore::StyleRareNonInheritedData::contentDataEquivalent): Extracted most logic in while() loop into ContentData::dataEquivalent().
3:39 PM Changeset in webkit [41724] by kov@webkit.org
  • 1 copy in releases/WebKitGTK/webkit-1.1.3

Tagging 1.1.3.

3:26 PM Changeset in webkit [41723] by xan@webkit.org
  • 2 edits in trunk

2009-03-15 Xan Lopez <​xlopez@igalia.com>

Bump version to 1.1.3 for release and fix soversion
calculation (oops). Thanks to Frederik Himpe for pointing this
out.

  • configure.ac:
1:15 PM Changeset in webkit [41722] by xan@webkit.org
  • 2 edits in trunk/PlanetWebKit

2009-03-15 Xan Lopez <​xlopez@igalia.com>

Rubber-stamped by Mark Rowe.

  • config.ini: fix my blog's feed address.
11:51 AM Changeset in webkit [41721] by kov@webkit.org
  • 1 copy in releases/WebKitGTK/webkit-1.1.2

Tagging 1.1.2.

10:40 AM Changeset in webkit [41720] by kov@webkit.org
  • 2 edits in trunk/WebKit/gtk

2009-03-15 Gustavo Noronha Silva <Gustavo Noronha Silva>

Reviewed by Anders Carlsson.

Fix default policy decision to be ignore, on MIME checks, if
WebKit doesn't know how to handle the MIME type. The documentation
is already correct, and this was an oversight when the policy
decision code was first committed. Since 1.1.2 will be the first
release to support download, there is no practical change in
behavior.

  • WebCoreSupport/FrameLoaderClientGtk.cpp: (WebKit::FrameLoaderClient::dispatchDecidePolicyForMIMEType):
10:40 AM Changeset in webkit [41719] by kov@webkit.org
  • 2 edits in trunk/WebCore

2009-03-15 Gustavo Noronha Silva <Gustavo Noronha Silva>

Reviewed by Anders Carlsson.

​https://bugs.webkit.org/show_bug.cgi?id=24602
[Gtk] Searching in thepiratebay.org doesn't work with more than 1 word

Reintroduce the URI into the soup message after having set it in
the KURL, on redirects, to make sure it is properly encoded. This
fixes bad request problems when servers give bad URIs on their
response's Location header.

  • platform/network/soup/ResourceHandleSoup.cpp: (WebCore::restartedCallback):
10:23 AM Changeset in webkit [41718] by kevino@webkit.org
  • 3 edits in trunk/JavaScriptCore

Non-Apple Mac ports build fix. Move defines for the BUILDING_ON_ macros into
Platform.h so that they're defined for all ports building on Mac, and tweak
the definitions of those macros based on Mark Rowe's suggestions to accomodate
cases where the values may not be <= to the .0 release for that version.

8:30 AM Changeset in webkit [41717] by xan@webkit.org
  • 4 edits in trunk

2009-03-15 Xan Lopez <​xlopez@igalia.com>

Bump version and libtool version for release.

  • configure.ac:

WebKit/gtk:

2009-03-15 Xan Lopez <​xlopez@igalia.com>

  • NEWS: update for 1.1.2.
4:26 AM Changeset in webkit [41716] by ap@webkit.org
  • 1 edit in trunk/LayoutTests/editing/selection/5354455-2.html

Committing LayoutTests/editing/selection/5354455-2.html that was supposed to be in previous check-in.

2:22 AM Changeset in webkit [41715] by ap@webkit.org
  • 6 edits
    2 adds in trunk

Reviewed by Darin Adler.

​https://bugs.webkit.org/show_bug.cgi?id=19737
No cursor and paste not enabled right clicking text field/area

Test: fast/events/right-click-focus.html

  • page/EventHandler.cpp: (WebCore::EventHandler::handleMousePressEventSingleClick): (WebCore::EventHandler::handleMousePressEvent): Take normal code path for right clicks (we were taking it for Ctrl-clicks anyway).
1:56 AM Changeset in webkit [41714] by ap@webkit.org
  • 1 edit
    2 moves
    2 adds in trunk/LayoutTests

Suggested by Mark Rowe.

Move results for security/block-test.html to their correct locations. Results for other
platforms will need to be generated.

  • platform/mac-leopard/security/block-test-expected.txt: Removed.
  • platform/mac-tiger/security: Added.
  • platform/mac-tiger/security/block-test-expected.txt: Copied from LayoutTests/security/block-test-expected.txt.
  • platform/mac/security: Added.
  • platform/mac/security/block-test-expected.txt: Copied from LayoutTests/platform/mac-leopard/security/block-test-expected.txt.
  • security/block-test-expected.txt: Removed.
1:42 AM Changeset in webkit [41713] by ap@webkit.org
  • 5 edits
    2 adds in trunk

Reviewed by Adele Peterson.

​https://bugs.webkit.org/show_bug.cgi?id=23949
HTMLSelectElement is in inconsistent state when handling mutation events

Test: fast/forms/mutation-event-recalc.html

  • dom/ContainerNode.cpp: (WebCore::ContainerNode::insertBefore): (WebCore::ContainerNode::appendChild): Call childrenChanged() before dispatching modification events, not after.
  • html/HTMLOptGroupElement.cpp: (WebCore::HTMLOptGroupElement::insertBefore): (WebCore::HTMLOptGroupElement::replaceChild): (WebCore::HTMLOptGroupElement::removeChild): (WebCore::HTMLOptGroupElement::appendChild): (WebCore::HTMLOptGroupElement::removeChildren):
  • html/HTMLSelectElement.cpp: (WebCore::HTMLSelectElement::add): (WebCore::HTMLSelectElement::remove): (WebCore::HTMLSelectElement::insertBefore): (WebCore::HTMLSelectElement::replaceChild): (WebCore::HTMLSelectElement::removeChild): (WebCore::HTMLSelectElement::appendChild): (WebCore::HTMLSelectElement::removeChildren): Remove calls to recalcSelectOptions(). It is too late to recalc now, after mutation events were already dispatched.
1:23 AM Changeset in webkit [41712] by mitz@apple.com
  • 2 edits in trunk/WebKit/mac

Reviewed by Adele Peterson.

  • fix <rdar://problem/6607773> WebKit should support the "Default" paragraph writing direction -- or at least validate the menu item appropriately

Made WebHTMLView validate user interface items with the selector
-makeBaseWritingDirectionNatural: by returning NO and, if the item is
a menu item, setting its state to "off".

Strictly speaking, since -makeBaseWritingDirectionNatural: is never
valid for WebViews, WebHTMLView should not need to respond to it and
validate it, however because other responders respond to all three
-makeBaseWritingDirection*: messages and set the menu item state, having
WebHTMLView do the same makes application developers' lives easier.

  • WebView/WebHTMLView.mm: (-[WebHTMLView validateUserInterfaceItemWithoutDelegate:]): (-[WebHTMLView makeBaseWritingDirectionNatural:]):
1:16 AM Changeset in webkit [41711] by ap@webkit.org
  • 3 edits in trunk/LayoutTests

Add svn:executable property to recently added cgi scripts.

  • http/tests/xmlhttprequest/resources/access-control-basic-options-not-supported.cgi:
  • http/tests/xmlhttprequest/resources/access-control-basic-whitelist-request-headers.cgi:

Mar 14, 2009:

8:23 PM Changeset in webkit [41710] by mrowe@apple.com
  • 1 edit
    2 adds in trunk/LayoutTests

Skip two tests that are failing.

Rubber-stamped by Dan Bernstein.

  • platform/mac-snowleopard/Skipped: Added.
7:55 PM Changeset in webkit [41709] by bolsinga@apple.com
  • 2 edits in trunk/WebCore

2009-03-14 Greg Bolsinga <​bolsinga@apple.com>

<rdar://problem/6683465>

Geolocation has to be able to handle NULL Frames.

Reviewed by Mark Rowe

6:58 PM Changeset in webkit [41708] by bolsinga@apple.com
  • 2 edits in trunk/WebCore

2009-03-14 Greg Bolsinga <​bolsinga@apple.com>

Reviewed by David Kilzer.

Geoposition::toString was missing the Coordinates after the update.

  • page/Geoposition.cpp: (WebCore::Geoposition::toString):
4:44 PM Changeset in webkit [41707] by jmalonzo@webkit.org
  • 2 edits in trunk/WebCore

2009-03-14 Jan Michael Alonzo <​jmalonzo@webkit.org>

Reviewed by Mark Rowe.

[Gtk] Build fix - pass a Coordinate to Geoposition::create
​https://bugs.webkit.org/show_bug.cgi?id=24603

Gtk build fix per r41650
​https://bugs.webkit.org/show_bug.cgi?id=24506
Geolocation in Safari differs from the spec, no Coordinates attribute on Position

Pass a Coordinate to Geoposition::create.

  • platform/gtk/GeolocationServiceGtk.cpp: (WebCore::GeolocationServiceGtk::updatePosition):
4:14 PM Changeset in webkit [41706] by jmalonzo@webkit.org
  • 3 edits in trunk/WebKit/gtk

2009-03-14 Jan Michael Alonzo <​jmalonzo@webkit.org>

Reviewed by Holger Freyther.

[GTK] use of confirm dialog (yes/no) causes segfault
​https://bugs.webkit.org/show_bug.cgi?id=20940

Change the script-confirm marshaller from OBJECT,STRING,BOOLEAN to
OBJECT,STRING,POINTER

  • webkit/webkitwebview.cpp:
  • webkitmarshal.list:
3:02 PM Changeset in webkit [41705] by xan@webkit.org
  • 2 edits in trunk/LayoutTests

2009-03-14 Xan Lopez <​xlopez@igalia.com>

Reviewed by Mark Rowe.

Remove two now working tests from GTK's Skipped list.

  • platform/gtk/Skipped:
1:22 PM Changeset in webkit [41704] by xan@webkit.org
  • 2 edits in trunk

2009-03-14 Xan Lopez <​xlopez@igalia.com>

No review, build fix.

Split clean rules to make distcheck pass.

  • GNUmakefile.am:
5:50 AM Changeset in webkit [41703] by mrowe@apple.com
  • 21 edits
    20 copies
    7 adds in trunk/LayoutTests

Update layout test results to accommodate slight changes in error messages in the latest version of libxml2.

Rubber-stamped by Oliver Hunt.

  • fast/dom/getElementsByClassName/011-expected.txt:
  • fast/parser/external-entities-expected.txt:
  • platform/mac-leopard/fast/dom/getElementsByClassName/011-expected.txt: Copied from LayoutTests/fast/dom/getElementsByClassName/011-expected.txt.
  • platform/mac-leopard/fast/invalid/missing-end-tag-expected.checksum: Copied from LayoutTests/platform/mac/fast/invalid/missing-end-tag-expected.checksum.
  • platform/mac-leopard/fast/invalid/missing-end-tag-expected.png: Copied from LayoutTests/platform/mac/fast/invalid/missing-end-tag-expected.png.
  • platform/mac-leopard/fast/invalid/missing-end-tag-expected.txt: Copied from LayoutTests/platform/mac/fast/invalid/missing-end-tag-expected.txt.
  • platform/mac-leopard/fast/parser/external-entities-expected.txt: Copied from LayoutTests/fast/parser/external-entities-expected.txt.
  • platform/mac-leopard/fast/parser/xhtml-alternate-entities-expected.checksum: Copied from LayoutTests/platform/mac/fast/parser/xhtml-alternate-entities-expected.checksum.
  • platform/mac-leopard/fast/parser/xhtml-alternate-entities-expected.png: Copied from LayoutTests/platform/mac/fast/parser/xhtml-alternate-entities-expected.png.
  • platform/mac-leopard/fast/parser/xhtml-alternate-entities-expected.txt: Copied from LayoutTests/platform/mac/fast/parser/xhtml-alternate-entities-expected.txt.
  • platform/mac-leopard/fast/xsl/xslt-extra-content-at-end-expected.checksum: Copied from LayoutTests/platform/mac/fast/xsl/xslt-extra-content-at-end-expected.checksum.
  • platform/mac-leopard/fast/xsl/xslt-extra-content-at-end-expected.png: Copied from LayoutTests/platform/mac/fast/xsl/xslt-extra-content-at-end-expected.png.
  • platform/mac-leopard/fast/xsl/xslt-extra-content-at-end-expected.txt: Copied from LayoutTests/platform/mac/fast/xsl/xslt-extra-content-at-end-expected.txt.
  • platform/mac-leopard/svg/custom/junk-data-expected.checksum: Copied from LayoutTests/platform/mac/svg/custom/junk-data-expected.checksum.
  • platform/mac-leopard/svg/custom/junk-data-expected.png: Copied from LayoutTests/platform/mac/svg/custom/junk-data-expected.png.
  • platform/mac-leopard/svg/custom/junk-data-expected.txt: Copied from LayoutTests/platform/mac/svg/custom/junk-data-expected.txt.
  • platform/mac-leopard/svg/custom/missing-xlink-expected.checksum: Copied from LayoutTests/platform/mac/svg/custom/missing-xlink-expected.checksum.
  • platform/mac-leopard/svg/custom/missing-xlink-expected.png: Copied from LayoutTests/platform/mac/svg/custom/missing-xlink-expected.png.
  • platform/mac-leopard/svg/custom/missing-xlink-expected.txt: Copied from LayoutTests/platform/mac/svg/custom/missing-xlink-expected.txt.
  • platform/mac-leopard/svg/hixie/error/012-expected.checksum: Copied from LayoutTests/platform/mac/svg/hixie/error/012-expected.checksum.
  • platform/mac-leopard/svg/hixie/error/012-expected.png: Copied from LayoutTests/platform/mac/svg/hixie/error/012-expected.png.
  • platform/mac-leopard/svg/hixie/error/012-expected.txt: Copied from LayoutTests/platform/mac/svg/hixie/error/012-expected.txt.
  • platform/mac/fast/invalid/missing-end-tag-expected.checksum:
  • platform/mac/fast/invalid/missing-end-tag-expected.png:
  • platform/mac/fast/invalid/missing-end-tag-expected.txt:
  • platform/mac/fast/parser/xhtml-alternate-entities-expected.checksum:
  • platform/mac/fast/parser/xhtml-alternate-entities-expected.png:
  • platform/mac/fast/parser/xhtml-alternate-entities-expected.txt:
  • platform/mac/fast/xsl/xslt-extra-content-at-end-expected.checksum:
  • platform/mac/fast/xsl/xslt-extra-content-at-end-expected.png:
  • platform/mac/fast/xsl/xslt-extra-content-at-end-expected.txt:
  • platform/mac/svg/custom/junk-data-expected.checksum:
  • platform/mac/svg/custom/junk-data-expected.png:
  • platform/mac/svg/custom/junk-data-expected.txt:
  • platform/mac/svg/custom/missing-xlink-expected.checksum:
  • platform/mac/svg/custom/missing-xlink-expected.png:
  • platform/mac/svg/custom/missing-xlink-expected.txt:
  • platform/mac/svg/hixie/error/012-expected.checksum:
  • platform/mac/svg/hixie/error/012-expected.png:
  • platform/mac/svg/hixie/error/012-expected.txt:
5:19 AM Changeset in webkit [41702] by mrowe@apple.com
  • 8 edits
    25 copies
    8 moves
    5 adds
    1 delete in trunk

Change the layout test result search policy for Mac OS X to fit better with the idea of
newer OS versions improving on previous OS versions.

Reviewed by Dan Bernstein.

The results for the latest version of Mac OS X are placed in the "mac" directory. The
results for older versions of Mac OS X are structured as a series of overlays. When
running on Leopard, the results in "mac-leopard" are searched before those in "mac".
When running on Tiger, the results in "mac-tiger" are searched before those in
"mac-leopard" and "mac".

  • Scripts/run-webkit-tests:
5:02 AM Changeset in webkit [41701] by ap@webkit.org
  • 3 edits
    6 adds in trunk

Reviewed by Darin Adler.

​https://bugs.webkit.org/show_bug.cgi?id=24545
Make cross-site XHR simple request definition match current spec draft

Tests: http/tests/xmlhttprequest/access-control-basic-post-fail-non-simple-content-type.html

http/tests/xmlhttprequest/access-control-basic-whitelist-request-headers.html

  • loader/CrossOriginAccessControl.cpp: (WebCore::isOnAccessControlSimpleRequestHeaderWhitelist): Added Content-Language. (WebCore::isSimpleCrossOriginAccessRequest): Added HEAD. Restricted content types to those that could be sent via form submission.
4:56 AM Changeset in webkit [41700] by ap@webkit.org
  • 3 edits
    4 adds in trunk

Reviewed by Darin Adler.

​https://bugs.webkit.org/show_bug.cgi?id=15172
object fallback - empty string for first argument of setAttributeNS does not work like null

​https://bugs.webkit.org/show_bug.cgi?id=24548
createElementNS("", name) should create an element in null namespace

Tests: fast/dom/createElementNS-empty-namespace.html

fast/dom/setAttributeNS-empty-namespace.html

  • dom/QualifiedName.h: (WebCore::QualifiedName::QualifiedNameImpl::QualifiedNameImpl): Convert empty namespaces to null.
4:54 AM Changeset in webkit [41699] by xan@webkit.org
  • 2 edits in trunk/PlanetWebKit

2009-03-13 Xan Lopez <​xlopez@igalia.com>

Reviewed by Mark Rowe.

​https://bugs.webkit.org/show_bug.cgi?id=24591
Add my blog to Planet WebKit

Add my blog to the planet.

  • config.ini:
Note: See TracTimeline for information about the timeline view.