⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Mar 19, 2009:

10:57 PM Changeset in webkit [41854] by ggaren@apple.com
  • 2 edits in trunk/JavaScriptCore

2009-03-19 Geoffrey Garen <​ggaren@apple.com>

Reviewed by Oliver Hunt.


Fixed <rdar://problem/6033712> -- a little bit of hardening in the Collector.


SunSpider reports no change. I also verified in the disassembly that
we end up with a single compare to constant.

  • runtime/Collector.cpp: (JSC::Heap::heapAllocate):
9:31 PM Changeset in webkit [41853] by timothy@apple.com
  • 2 edits in trunk/WebKit/mac

Remove #ifndef BUILDING_ON_TIGER around code that schedules runloop modes
for Page, so the new RunLoopTimer in WebCore always gets a default mode.
Fixes the layout test failures on the Tiger build bots.

Reviewed by Mark Rowe.

  • WebView/WebView.mm: (-[WebView _commonInitializationWithFrameName:groupName:usesDocumentViews:]): (-[WebView scheduleInRunLoop:forMode:]): (-[WebView unscheduleFromRunLoop:forMode:]):
9:28 PM Changeset in webkit [41852] by ggaren@apple.com
  • 4 edits
    1 move in trunk

JavaScriptCore:

2009-03-19 Geoffrey Garen <​ggaren@apple.com>

Reviewed by Cameron Zwarich and Oliver Hunt.

Fixed <rdar://problem/6406045> REGRESSION: Stack overflow on PowerPC on
fast/workers/use-machine-stack.html (22531)

Dialed down the re-entry allowance to 64 (from 128).


On a 512K stack, this leaves about 64K for other code on the stack while
JavaScript is running. Not perfect, but it solves our crash on PPC.

Different platforms may want to dial this down even more.

Also, substantially shrunk BytecodeGenerator. Since we allocate one on
the stack in order to throw a stack overflow exception -- well, let's
just say the old code had an appreciation for irony.

SunSpider reports no change.

  • bytecompiler/BytecodeGenerator.h:
  • interpreter/Interpreter.h: (JSC::):

LayoutTests:

2009-03-19 Geoffrey Garen <​ggaren@apple.com>

Reviewed by Cameron Zwarich and Oliver Hunt.

Re-enabled this test, since it no longer crashes when JavaScriptCore is
compiled in non-JIT mode.

  • fast/workers/use-machine-stack.html: Copied from fast/workers/use-machine-stack.html-disabled.
  • fast/workers/use-machine-stack.html-disabled: Removed.
7:04 PM Changeset in webkit [41851] by cwzwarich@webkit.org
  • 3 edits
    3 adds in trunk

2009-03-19 Cameron Zwarich <​cwzwarich@uwaterloo.ca>

Reviewed by Oliver Hunt.

Bug 24350: REGRESSION: Safari 4 breaks SPAW wysiwyg editor multiple instances
<​https://bugs.webkit.org/show_bug.cgi?id=24350>
<rdar://problem/6674182>

The SPAW editor's JavaScript assumes that toString() on a function
constructed with the Function constructor produces a function with
a newline after the opening brace.

JavaScriptCore:

  • runtime/FunctionConstructor.cpp: (JSC::constructFunction): Add a newline after the opening brace of the function's source code.

LayoutTests:

  • fast/js/function-constructor-newline-after-brace-expected.txt: Added.
  • fast/js/function-constructor-newline-after-brace.html: Added.
  • fast/js/resources/function-constructor-newline-after-brace.js: Added.
6:50 PM Changeset in webkit [41850] by mrowe@apple.com
  • 1 edit
    3 moves
    6 adds in trunk/LayoutTests

Fix fast/text/Geeza-Pro-vertical-metrics-adjustment.html on Leopard by moving the results in to the location
that run-webkit-tests currently looks for them.

Reviewed by Stephanie Lewis.

5:52 PM Changeset in webkit [41849] by ggaren@apple.com
  • 5 edits in trunk

JavaScriptCore:

2009-03-19 Cameron Zwarich <​cwzwarich@uwaterloo.ca>

Reviewed by Geoff Garen.

Bug 23771: REGRESSION (r36016): JSObjectHasProperty freezes on global class without kJSClassAttributeNoAutomaticPrototype
<​https://bugs.webkit.org/show_bug.cgi?id=23771>
<rdar://problem/6561016>

  • API/tests/testapi.c: (main): Add a test for this bug.
  • runtime/JSGlobalObject.cpp: (JSC::JSGlobalObject::resetPrototype): Don't set the prototype of the last object in the prototype chain to the object prototype when the object prototype is already the last object in the prototype chain.

LayoutTests:

2009-03-19 Geoffrey Garen <​ggaren@apple.com>

Reviewed by Oliver Hunt.


Fixed <rdar://problem/6279213> Regular expression run-time complexity
limit too low for long inputs (21485)


Added a test for a complex regexp match that should succeed, and one
that should fail.

  • fast/js/regexp-overflow-expected.txt:
  • fast/js/resources/regexp-overflow.js:
5:44 PM Changeset in webkit [41848] by mrowe@apple.com
  • 3 edits
    1 copy
    1 add in trunk/LayoutTests

Update test results for changes in handling of CMYK.

Reviewed by Sam Weinig.

  • fast/canvas/resources/set-colors.js:
  • fast/canvas/set-colors-expected.txt:
  • platform/mac-leopard/fast/canvas/set-colors-expected.txt: Copied from LayoutTests/fast/canvas/set-colors-expected.txt.
5:16 PM Changeset in webkit [41847] by andersca@apple.com
  • 3 edits in trunk/WebCore

2009-03-19 Anders Carlsson <​andersca@apple.com>

Reviewed by Dan Bernstein.

<rdar://problem/6682554> Flash content not being rendered (Shockwave Flash 10.0 r22)


If calling updateWidget for some reason resulted in another widget being added to m_widgetUpdateSet, then
that object would never be updated.


  • page/FrameView.cpp: (WebCore::FrameView::updateWidgets): Factor the widget updating code out into this method. Return true if the update set is empty.


(WebCore::FrameView::performPostLayoutTasks):
Loop over the update set multiple times until all widgets have been updated or until we reach the cap.


  • page/FrameView.h:
5:03 PM Changeset in webkit [41846] by cwzwarich@webkit.org
  • 3 edits in trunk/JavaScriptCore

2009-03-19 Cameron Zwarich <​cwzwarich@uwaterloo.ca>

Reviewed by Geoff Garen.

Bug 23771: REGRESSION (r36016): JSObjectHasProperty freezes on global class without kJSClassAttributeNoAutomaticPrototype
<​https://bugs.webkit.org/show_bug.cgi?id=23771>
<rdar://problem/6561016>

  • API/tests/testapi.c: (main): Add a test for this bug.
  • runtime/JSGlobalObject.cpp: (JSC::JSGlobalObject::resetPrototype): Don't set the prototype of the last object in the prototype chain to the object prototype when the object prototype is already the last object in the prototype chain.
4:45 PM Changeset in webkit [41845] by timothy@apple.com
  • 6 edits
    2 adds in trunk

Make the defered data loading timer honor the Page's scheduled runloop pairs.
Introduces a new RunLoopTimer class that has an API mimicking Timer but
allows it to be scheduled with one or more SchedulePairs.

<rdar://problem/6687342> -[WebView scheduleInRunLoop:forMode:] has no affect on timers

Reviewed by Darin Adler.

  • WebCore.xcodeproj/project.pbxproj: Adds the new RunLoopTimer.{cpp,h} files.
  • loader/MainResourceLoader.cpp: (WebCore::MainResourceLoader::handleDataLoadNow): Use the MainResourceLoaderTimer typedef. (WebCore::MainResourceLoader::startDataLoadTimer): Added. Start the timer and on Mac platforms also schedule with the Page's SchedulePairs. (WebCore::MainResourceLoader::handleDataLoadSoon): Call startDataLoadTimer(). (WebCore::MainResourceLoader::setDefersLoading): Ditto.
  • loader/MainResourceLoader.h:
  • platform/cf/RunLoopTimerCF.cpp: Added. (WebCore::RunLoopTimerBase::~RunLoopTimerBase): (WebCore::timerFired): (WebCore::RunLoopTimerBase::start): (WebCore::RunLoopTimerBase::schedule): (WebCore::RunLoopTimerBase::stop): (WebCore::RunLoopTimerBase::isActive):
  • platform/RunLoopTimer.h: Added. (WebCore::RunLoopTimerBase::RunLoopTimerBase): (WebCore::RunLoopTimerBase::startRepeating): (WebCore::RunLoopTimerBase::startOneShot): (WebCore::RunLoopTimer::RunLoopTimer): (WebCore::RunLoopTimer::fired):
2:08 PM Changeset in webkit [41844] by kov@webkit.org
  • 2 edits in trunk/WebKitTools

2009-03-19 Gustavo Noronha Silva <Gustavo Noronha Silva>

Reviewed by Mark Rowe.

Make determinePassedArchitecture always consume the --32-bit
option, also in non-AppleMacWebkit platforms. Solution pointed out
by Mark Rowe.

  • Scripts/webkitdirs.pm:
1:47 PM Changeset in webkit [41843] by hyatt@apple.com
  • 1 add in trunk/WebKitSite/blog-files/scrollbarpicture.png

Adding scrollbar images for blog post.

1:32 PM Changeset in webkit [41842] by ggaren@apple.com
  • 7 edits in trunk

JavaScriptCore:

2009-03-19 Geoffrey Garen <​ggaren@apple.com>

Reviewed by Sam Weinig.


Fixed <rdar://problem/6603562> REGRESSION (Safari 4): regular expression
pattern size limit lower than Safari 3.2, other browsers, breaks SAP (14873)


Bumped the pattern size limit to 1MB, and standardized it between PCRE
and WREC. (Empirical testing says that we can easily compile a 1MB regular
expression without risking a hang. Other browsers support bigger regular
expressions, but also hang.)


SunSpider reports no change.


I started with a patch posted to Bugzilla by Erik Corry (​erikcorry@google.com).


  • pcre/pcre_internal.h: (put3ByteValue): (get3ByteValue): (put3ByteValueAndAdvance): (putLinkValueAllowZero): (getLinkValueAllowZero): Made PCRE's "LINK_SIZE" (the number of bytes used to record jumps between bytecodes) 3, to accomodate larger potential jumps. Bumped PCRE's "MAX_PATTERN_SIZE" to 1MB. (Technically, at this LINK_SIZE, we can support even larger patterns, but we risk a hang during compilation, and it's not clear that such large patterns are important on the web.)
  • wrec/WREC.cpp: (JSC::WREC::Generator::compileRegExp): Match PCRE's maximum pattern size, to avoid quirks between platforms.

LayoutTests:

2009-03-19 Geoffrey Garen <​ggaren@apple.com>

Reviewed by Sam Weinig.


Made two layout tests less agressive, to accomodate a change I made
for <rdar://problem/6603562> REGRESSION (Safari 4): regular expression
pattern size limit lower than Safari 3.2, other browsers, breaks SAP (14873)

  • fast/js/regexp-charclass-crash-expected.txt:
  • fast/js/regexp-charclass-crash.html: Explicitly limit the number of iterations in the test loop. Otherwise, regular expression engines supporting very long patterns take a very very very long time to run this test.
  • fast/js/resources/regexp-overflow.js: Made the "too big" regexp in this test even bigger, to match our new limit.
12:56 PM Changeset in webkit [41841] by Dimitri Glazkov
  • 3 edits in trunk/WebCore

2009-03-19 Dimitri Glazkov <Dimitri Glazkov>

Reviewed by Darin Fisher.

​https://bugs.webkit.org/show_bug.cgi?id=24702
Upstream miscellaneous bindings changes.

  • bindings/v8/ScheduledAction.cpp: (WebCore::ScheduledAction::execute): Changed to call lower-case evaluate.
  • bindings/v8/ScriptCallStack.h: Added an extra include.
12:14 PM Changeset in webkit [41840] by Simon Fraser
  • 3 edits
    4 adds in trunk

2009-03-19 Simon Fraser <Simon Fraser>

Reviewed by Dave Hyatt

​https://bugs.webkit.org/show_bug.cgi?id=24686

When hit testing a RenderLayer whose parent lives in a preserves-3D hierarchy,
we need to compare the computed z-offset with the depth-test z-offset before
deciding that such a RenderLayer was hit. This fixes an issue, tested by the
3d-point-mapping-overlapping.html test, where the child of a transformed element
is found by hit testing, even when some other element with greater Z overlaps
them both.

Improved the code by adding a utility method, isHitCandidate(), which computes and tests
z-depth when necessary.

Tests: transforms/3d/point-mapping/3d-point-mapping-coplanar.html

transforms/3d/point-mapping/3d-point-mapping-overlapping.html

  • rendering/RenderLayer.cpp: (WebCore::isHitCandidate): (WebCore::RenderLayer::hitTestLayer):
9:43 AM Changeset in webkit [41839] by Dimitri Glazkov
  • 2 edits
    1 add in trunk/WebCore

2009-03-19 Jeremy Moskovich <​jeremy@chromium.org>

Reviewed by Dimitri Glazkov.

​https://bugs.webkit.org/show_bug.cgi?id=24456
Split ColorChromium.cpp into Mac & Windows variants.
Remove Chromium Dependency on platform/graphics/mac/ColorMac.mm since we
ultimately need to take a different approach. For now, createCGColor()
is copied from ColorMac.mm.

No observable change in behavior, so no test.

  • platform/graphics/chromium/ColorChromium.cpp: (WebCore::focusRingColor):
  • platform/graphics/chromium/ColorChromiumMac.mm: Added.
9:36 AM Changeset in webkit [41838] by Dimitri Glazkov
  • 1 edit in trunk/WebCore/ChangeLog

Fix WebCore/ChangeLog entry, add missing reviewer line.

9:35 AM Changeset in webkit [41837] by Dimitri Glazkov
  • 2 edits in trunk/LayoutTests

2009-03-19 Scott Violet <​sky@google.com>

Reviewed by Simon Fraser.

​https://bugs.webkit.org/show_bug.cgi?id=24678
Transitions tests somewhat flakey on Chromium.

Modifies transitions/transition-end-event-helpers.js to only process
results once.

  • transitions/transition-end-event-helpers.js:
9:29 AM Changeset in webkit [41836] by Dimitri Glazkov
  • 1 edit
    1 add in trunk/WebCore

2009-03-19 Pavel Feldman <​pfeldman@chromium.org>

Reviewed by Dimitri Glazkov.

​https://bugs.webkit.org/show_bug.cgi?id=24675
Unforking frontend: add custom InspectorController methods
implementation.

  • bindings/v8/custom/V8InspectorControllerCustom.cpp: Added.
9:26 AM Changeset in webkit [41835] by Dimitri Glazkov
  • 3 edits in trunk/WebCore

2009-03-19 Jay Campan <​jcampan@google.com>

​https://bugs.webkit.org/show_bug.cgi?id=24625
Adding an accessor to the currently selected index in the PopupMenuChromium.
This is required for implementing the deletion of an autocomplete entry in Chromium.

  • platform/chromium/PopupMenuChromium.cpp: (WebCore::PopupContainer::selectedIndex):
  • platform/chromium/PopupMenuChromium.h:
9:09 AM Changeset in webkit [41834] by darin@chromium.org
  • 2 edits in trunk/WebCore

2009-03-19 Evan Stade <​estade@chromium.org>

Reviewed by Dimitri Glazkov.

​https://bugs.webkit.org/show_bug.cgi?id=24526
Improve windows skia text stroking.

Test: LayoutTests/svg/custom/struct-use-09-b.svg

  • platform/graphics/skia/SkiaFontWin.cpp: Close the path representing each font glyph polygon, rather than only closing the path once per letter. This fixes stroking for letters with multiple polygons, such as 'A' or 'D'. (WebCore::getPathForGlyph): (WebCore::skiaDrawText):
9:06 AM Changeset in webkit [41833] by Simon Hausmann
  • 3 edits in trunk/WebKit/qt

Oops, bail out last patch, that was incorrect.

8:59 AM Changeset in webkit [41832] by Simon Hausmann
  • 3 edits in trunk/WebKit/qt

2009-03-19 Laurent Montel <​montel@kde.org>

Reviewed by Simon Hausmann.

Another fix for pedantic compilation in QtWebKit

(patch from qt-copy)

8:16 AM Changeset in webkit [41831] by Simon Hausmann
  • 3 edits in trunk/WebKit/qt

2009-03-19 Ariya Hidayat <​ariya.hidayat@trolltech.com>

Reviewed by Simon Hausmann.

Fixes pedantic compilation in QtWebKit.

There are no semi-colons after namespace declarations.

8:16 AM Changeset in webkit [41830] by Simon Hausmann
  • 2 edits in trunk/WebKit/qt

2009-03-19 David Boddie <​dboddie@trolltech.com>

Reviewed by Simon Hausmann.

Doc: Removed obsolete warning about Flash and other plugins.

8:16 AM Changeset in webkit [41829] by Simon Hausmann
  • 2 edits in trunk/WebKit/qt

2009-03-19 Paul Olav Tvete <​paul.tvete@nokia.com>

Reviewed by Simon Hausmann.

Properly escape tooltip text

ManualTest: ​http://xkcd.com/554/

8:08 AM Changeset in webkit [41828] by Simon Hausmann
  • 6 edits in trunk/WebCore

2009-03-19 Simon Hausmann <​simon.hausmann@nokia.com>

Reviewed by Tor Arne Vestbø.

Fixed support for doing calls from JavaScript into NPAPI Plugins for the Qt port on Windows.

Removed dead code for distinguishing between Widget and PluginView in the Qt port.

1:06 AM Changeset in webkit [41827] by mrowe@apple.com
  • 3 edits in trunk/WebKitTools

Work around <rdar://problem/6698023> by activating fonts from disk.

Reviewed by Oliver Hunt.

  • DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Copy fonts into DumpRenderTree.resources

in the built products directory.

  • DumpRenderTree/mac/DumpRenderTree.mm:

(activateFonts): Activate the fonts from disk.

12:55 AM Changeset in webkit [41826] by cwzwarich@webkit.org
  • 4 edits
    3 adds in trunk

2009-03-19 Cameron Zwarich <​cwzwarich@uwaterloo.ca>

Reviewed by Oliver Hunt.

Bug 24596: ASSERT in JSC::PropertySlot::slotBase @ iGoogle homepage
<​https://bugs.webkit.org/show_bug.cgi?id=24596>
<rdar://problem/6686493>

JSDOMWindow::customGetOwnPropertySlot() does an access check after calling
JSGlobalObject::getOwnPropertySlot(). This causes the PropertySlot to be
set twice, once to the value that is illegal to access, and then to undefined
This causes an assertion failure in property access caching code.

The fix is to do the access check before calling JSGlobalObject::getOwnPropertySlot().

WebCore:

  • bindings/js/JSDOMWindowCustom.h: (WebCore::JSDOMWindow::customGetOwnPropertySlot):

LayoutTests:

  • http/tests/security/cross-frame-access-get-custom-property-cached-expected.txt: Added.
  • http/tests/security/cross-frame-access-get-custom-property-cached.html: Added.
  • http/tests/security/resources/cross-frame-access-get-custom-property-cached-iframe.html: Added.
  • http/tests/security/resources/cross-frame-access.js: (shouldBeUndefined):
12:32 AM Changeset in webkit [41825] by ap@webkit.org
  • 7 edits
    3 adds in trunk

Reviewed by Sam Weinig.

​https://bugs.webkit.org/show_bug.cgi?id=24676
Simple cross-origin requests shouldn't dispatch upload progress events

Test: http/tests/xmlhttprequest/simple-cross-origin-progress-events.html

  • loader/CrossOriginAccessControl.cpp: (WebCore::passesAccessControlCheck): Added a comment explaining the somewhat unexpected behavior of this function.
  • xml/XMLHttpRequestUpload.cpp: (WebCore::XMLHttpRequestUpload::hasListeners):
  • xml/XMLHttpRequestUpload.h: Report whether there are any event listeners registered.
  • xml/XMLHttpRequest.h: Added m_uploadEventsAllowed.
  • xml/XMLHttpRequest.cpp: (WebCore::XMLHttpRequest::createRequest): Set m_uploadEventsAllowed flag. (WebCore::XMLHttpRequest::makeSameOriginRequest): Ditto. (WebCore::XMLHttpRequest::makeCrossOriginAccessRequest): Ditto. (WebCore::XMLHttpRequest::makeSimpleCrossOriginAccessRequest): Set request body - it can be non-empty for POST requests. (WebCore::XMLHttpRequest::makeCrossOriginAccessRequestWithPreflight): Set m_uploadEventsAllowed flag. (WebCore::XMLHttpRequest::handleAsynchronousPreflightResult): Ditto. (WebCore::XMLHttpRequest::abort): Only dispatch upload progress events if allowed. (WebCore::XMLHttpRequest::networkError): Ditto. (WebCore::XMLHttpRequest::abortError): Ditto. (WebCore::XMLHttpRequest::didSendData): Ditto.

Mar 18, 2009:

11:18 PM Changeset in webkit [41824] by darin@chromium.org
  • 2 edits in trunk/WebCore

2009-03-18 Marc-Antoine Ruel <​maruel@chromium.org>

Reviewed by Darin Fisher.

​https://bugs.webkit.org/show_bug.cgi?id=24398
Fix a crash when loading a svg file in Chromium's test_shell and
then reloading the page.

  • history/BackForwardListChromium.cpp: (WebCore::BackForwardList::BackForwardList): (WebCore::BackForwardList::close):
11:04 PM BuildingGtk edited by arthur.webkid@gmail.com
WebKitGTK doesn't depend on curl anymore. (diff)
9:42 PM Changeset in webkit [41823] by adachan@apple.com
  • 2 edits in trunk/JavaScriptCore

Rolling out r41818 since it broke the windows build.
Error: ..\..\runtime\DatePrototype.cpp(30) : fatal error C1083: Cannot open include file: 'langinfo.h': No such file or directory

  • runtime/DatePrototype.cpp: (JSC::formatLocaleDate):
6:54 PM Changeset in webkit [41822] by mrowe@apple.com
  • 2 edits in trunk/LayoutTests

Skip plugins/netscape-throw-exception.html due to <rdar://problem/6530010>.

Reviewed by Sam Weinig.

  • platform/mac-snowleopard/Skipped:
6:29 PM Changeset in webkit [41821] by mrowe@apple.com
  • 1 edit
    1 move in trunk/LayoutTests

Disable pluginDocumentView-deallocated-dataSource.html as it has not tested
what it was designed to test for some time, and is failing on some machines.
Fixing the test is tracked by <​https://bugs.webkit.org/show_bug.cgi?id=24690>.

Rubber-stamped by Dan Bernstein.

  • platform/mac/plugins/pluginDocumentView-deallocated-dataSource.html-disabled: Renamed from LayoutTests/platform/mac/plugins/pluginDocumentView-deallocated-dataSource.html.
5:57 PM Changeset in webkit [41820] by andersca@apple.com
  • 2 edits in trunk/WebKit/mac

2009-03-18 Anders Carlsson <​andersca@apple.com>

Reviewed by Oliver Hunt.

WebKit side of <rdar://problem/6688244>.


Try reinitializing the vendor port if it's invalid.


  • Plugins/Hosted/NetscapePluginHostManager.mm: (WebKit::NetscapePluginHostManager::spawnPluginHost):
5:49 PM Changeset in webkit [41819] by mrowe@apple.com
  • 8 edits in trunk

<rdar://problem/6693300> Don't rely on printf from TestNetscapePlugIn appearing in test results

Reviewed by Dan Bernstein.

Switch from using printf to using the NPAPI to invoke console.log so that plug-in messages appear
in test results even when the plug-in's stdout differs from DumpRenderTree's stdout.

  • DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp:

(log): Invoke console.log via the NPAPI.
(NPP_Destroy): Call log instead of printf.
(NPP_SetWindow): Ditto.
(handleEventCarbon): Ditto.
(handleEventCocoa): Ditto.
(NPP_HandleEvent): Pass the instance in to the event handler.

Update test results for change to address <rdar://problem/6693300>.

  • plugins/mouse-events-expected.txt:
  • plugins/netscape-destroy-plugin-script-objects-expected.txt:
  • plugins/netscape-plugin-setwindow-size-2-expected.txt:
  • plugins/netscape-plugin-setwindow-size-expected.txt:
  • plugins/open-and-close-window-with-plugin-expected.txt:
4:21 PM Changeset in webkit [41818] by kov@webkit.org
  • 2 edits in trunk/JavaScriptCore

2009-03-18 Gustavo Noronha Silva <Gustavo Noronha Silva> and Thadeu Lima de Souza Cascardo <​cascardo@holoscopio.com>

Reviewed by Darin Adler.

​https://bugs.webkit.org/show_bug.cgi?id=24674
Crashes in !PLATFORM(MAC)'s formatLocaleDate, in very specific situations

Make sure strftime never returns 2-digits years to avoid ambiguity and
a crash.

  • runtime/DatePrototype.cpp: (JSC::formatLocaleDate):
4:09 PM Changeset in webkit [41817] by sfalken@apple.com
  • 4 edits in trunk/WebKit/win

Add webViewClosing to private UI delegate.

Reviewed by Adam Roben.

  • Interfaces/IWebUIDelegatePrivate.idl:
  • Interfaces/WebKit.idl:
  • WebView.cpp: (WebView::close):
1:41 PM Changeset in webkit [41816] by eric.carlson@apple.com
  • 2 edits in trunk/WebCore

2009-03-18 Eric Carlson <​eric.carlson@apple.com>

Reviewed by Simon Fraser.

Fix for <rdar://problem/6685235>
<video> element poster cannot be set dynamically if not originally set up in HTML


Allocate the media engine immediately so the plug-in proxy is available for
scripting right away.

  • platform/graphics/MediaPlayer.cpp: (WebCore::MediaPlayer::MediaPlayer):
1:33 PM Changeset in webkit [41815] by Beth Dakin
  • 3 edits in trunk/LayoutTests

2009-03-18 Beth Dakin <Beth Dakin>

Rubber-stamped by Dan Bernstein.

Updating test to reflect our joy.

  • fast/dom/offset-parent-positioned-and-inline-expected.txt:
  • fast/dom/offset-parent-positioned-and-inline.html:
1:30 PM Changeset in webkit [41814] by Beth Dakin
  • 3 edits
    2 adds in trunk

WebCore:

2009-03-18 Beth Dakin <Beth Dakin>

Reviewed by Dave Hyatt.

Fix for <rdar://problem/6636747> REGRESSION (Safari 4 PB-r41326):
Popup menu appears at the wrong location on page at ​http://
www.signonsandiego.com/

This was a regression from ​http://trac.webkit.org/changeset/40769,
which changed the base class of RenderInline to
RenderBoxModelObject rather than RenderBox.

  • rendering/RenderObject.cpp: (WebCore::RenderObject::offsetParent): offsetParent should return a RenderBoxModelObject rather than just a RenderBox, which is more restrictive.

LayoutTests:

2009-03-18 Beth Dakin <Beth Dakin>

Reviewed by Dave Hyatt.

Test for <rdar://problem/6636747> REGRESSION (Safari 4 PB-r41326):
Popup menu appears at the wrong location on page at ​http://
www.signonsandiego.com/

  • fast/dom/offset-parent-positioned-and-inline-expected.txt: Added.
  • fast/dom/offset-parent-positioned-and-inline.html: Added.
1:15 PM Changeset in webkit [41813] by andersca@apple.com
  • 4 edits in trunk

WebCore:

2009-03-18 Anders Carlsson <​andersca@apple.com>

Reviewed by Darin Adler.

<rdar://problem/6504776>
CrashTracer: [USER] 188 crashes in Safari at com.apple.WebCore • WTF::HashTableIterator<WTF::RefPtr<WebCore::ResourceLoader>, ...

Return early in case calling the client ends up spinning the run loop and completing/cancelling the load.


  • loader/NetscapePlugInStreamLoader.cpp: (WebCore::NetscapePlugInStreamLoader::didCancel):

WebKit/mac:

2009-03-18 Anders Carlsson <​andersca@apple.com>

Reviewed by Darin Adler.

<rdar://problem/6504776>
CrashTracer: [USER] 188 crashes in Safari at com.apple.WebCore • WTF::HashTableIterator<WTF::RefPtr<WebCore::ResourceLoader>, ...


If the m_pluginView member was zeroed out as a result of making a call into the plug-in, the pluginFunctionCallDepth would be off
causing the plug-in never to be stopped. Simplify the code by using a RAII object.

  • Plugins/WebBaseNetscapePluginStream.mm: (PluginStopDeferrer::PluginStopDeferrer): (PluginStopDeferrer::~PluginStopDeferrer): (WebNetscapePluginStream::startStream): (WebNetscapePluginStream::wantsAllStreams): (WebNetscapePluginStream::destroyStream):
1:08 PM Changeset in webkit [41812] by levin@chromium.org
  • 1 edit
    1 add in trunk/WebCore

2009-03-18 David Levin <​levin@chromium.org>

Reviewed by Dimitri Glazkov.

​https://bugs.webkit.org/show_bug.cgi?id=24664
Upstreaming v8 collection.h

No change in behavior, so no test.

  • bindings/v8/V8Collection.h: Added.
1:02 PM Changeset in webkit [41811] by weinig@apple.com
  • 5 edits in trunk

WebCore:

2009-03-18 Sam Weinig <​sam@webkit.org>

Reviewed by Simon Fraser.

Fix for ​https://bugs.webkit.org/show_bug.cgi?id=23966
REGRESSION: Custom arrow navigation functionality doesn't work at dropular.net
<rdar://problem/6589657>

Match the CSSOM spec for getClientRects and getBoundingClientRect by
returning a 0x0 rect at the correct top/left position for empty inline
boxes.

  • rendering/RenderInline.cpp: (WebCore::RenderInline::absoluteRects): (WebCore::RenderInline::absoluteQuads):

LayoutTests:

2009-03-18 Sam Weinig <​sam@webkit.org>

Reviewed by Simon Fraser.

Update test results for ​https://bugs.webkit.org/show_bug.cgi?id=23966
REGRESSION: Custom arrow navigation functionality doesn't work at dropular.net
<rdar://problem/6589657>

  • fast/dom/getBoundingClientRect-expected.txt:
  • fast/dom/getClientRects-expected.txt:
11:02 AM Changeset in webkit [41810] by ap@webkit.org
  • 1 edit
    20 adds in trunk/LayoutTests

Reviewed by Darin Adler.

​https://bugs.webkit.org/show_bug.cgi?id=24670
Add tests for XHR progress events during cross-origin requests.

  • http/tests/xmlhttprequest/redirect-cross-origin-2-expected.txt: Added.
  • http/tests/xmlhttprequest/redirect-cross-origin-2.html: Added.
  • http/tests/xmlhttprequest/redirect-cross-origin-expected.txt: Added.
  • http/tests/xmlhttprequest/redirect-cross-origin-post-expected.txt: Added.
  • http/tests/xmlhttprequest/redirect-cross-origin-post-sync-expected.txt: Added.
  • http/tests/xmlhttprequest/redirect-cross-origin-post-sync.html: Added.
  • http/tests/xmlhttprequest/redirect-cross-origin-post.html: Added.
  • http/tests/xmlhttprequest/redirect-cross-origin-sync-double-expected.txt: Added.
  • http/tests/xmlhttprequest/redirect-cross-origin-sync-double.html: Added.
  • http/tests/xmlhttprequest/redirect-cross-origin-sync-expected.txt: Added.
  • http/tests/xmlhttprequest/redirect-cross-origin-sync.html: Added.
  • http/tests/xmlhttprequest/redirect-cross-origin.html: Added.
  • http/tests/xmlhttprequest/simple-cross-origin-denied-events-expected.txt: Added.
  • http/tests/xmlhttprequest/simple-cross-origin-denied-events-post-expected.txt: Added.
  • http/tests/xmlhttprequest/simple-cross-origin-denied-events-post-sync-expected.txt: Added.
  • http/tests/xmlhttprequest/simple-cross-origin-denied-events-post-sync.html: Added.
  • http/tests/xmlhttprequest/simple-cross-origin-denied-events-post.html: Added.
  • http/tests/xmlhttprequest/simple-cross-origin-denied-events-sync-expected.txt: Added.
  • http/tests/xmlhttprequest/simple-cross-origin-denied-events-sync.html: Added.
  • http/tests/xmlhttprequest/simple-cross-origin-denied-events.html: Added.
10:41 AM Changeset in webkit [41809] by levin@chromium.org
  • 2 edits in trunk/WebCore

2009-03-18 David Levin <​levin@chromium.org>

Reviewed by Eric Seidel.

Match the changes done for windows in the bug
​https://bugs.webkit.org/show_bug.cgi?id=24530.

No change in behavior, so no test.

  • rendering/RenderThemeChromiumLinux.cpp: (WebCore::RenderThemeChromiumLinux::extraDefaultStyleSheet):
8:58 AM Changeset in webkit [41808] by krit@webkit.org
  • 2 edits in trunk/WebCore

2009-03-18 Dirk Schulze <​krit@webkit.org>

Reviewed by Holger Freyther.

Added support for SVG's stroked texts to Qt.

[Qt] SVGs stroked text support missing
​https://bugs.webkit.org/show_bug.cgi?id=24262

  • platform/graphics/qt/FontQt.cpp: (WebCore::Font::drawComplexText):
1:15 AM Changeset in webkit [41807] by mrowe@apple.com
  • 2 edits in trunk/WebCore

Fix fast/encoding/char-decoding.html with recent ICU.

Reviewed by Alexey Proskuryakov.

  • platform/text/TextCodecICU.cpp:

(WebCore::TextCodecICU::decode): Look for gb18030 case-insensitively,
as newer versions of ICU use GB18030 as the canonical name.

12:24 AM Changeset in webkit [41806] by oliver@apple.com
  • 6 edits
    1 add in trunk

<rdar://problem/6692138> REGRESSION (Safari 4): Incorrect function return value when using IE "try ... finally" memory leak work-around (24654)
<​https://bugs.webkit.org/show_bug.cgi?id=24654>

Reviewed by Cameron Zwarich.

If the return value for a function is in a local register we need
to copy it before executing any finalisers, otherwise it is possible
for the finaliser to clobber the result.

Note: See TracTimeline for information about the timeline view.