Context Navigation

platform/graphics/win/FontCGWin.cpp: (WebCore::drawGDIGlyphs): Changed glyph stroking to fill and stroke each glyph as a separate path, instead of all glyphs as a single path. This matches what CGContextShowGlyphsWithAdvances() does, and has comparable performance.

6:47 PM Changeset in webkit [41888] by dino@apple.com

2 edits in trunk/WebCore

2009-03-20 Dean Jackson <dino@apple.com>

Reviewed by Simon Fraser

Build fix for ENABLE(3D_RENDERING)

rendering/RenderObject.h: (WebCore::makeMatrixRenderable):

6:29 PM Changeset in webkit [41887] by jmalonzo@webkit.org

4 edits in trunk

2009-03-20 Mike Hommey <glandium@debian.org>

Reviewed by Gavin Barraclough. Landed by Jan Alonzo.

Enable JIT on x86-64
https://bugs.webkit.org/show_bug.cgi?id=24724

Enable JIT on x86-64 gtk+

configure.ac:
JavaScriptCore/GNUmakefile.am:

6:18 PM Changeset in webkit [41886] by jmalonzo@webkit.org

2 edits in trunk/JavaScriptCore

2009-03-20 Mike Hommey <glandium@debian.org>

Reviewed by Mark Rowe. Committed by Jan Alonzo.

Use the proper definition of RETURN_PAIR on !MSVC

The other version is actually a work around for a quirk in the windows
ABI, so checking whether we're under MSVC is more a appropriate check for
it. It also happens this workaround is not 64-bits safe, so we also error
out on x86-64 MSVC.

Thanks Gavin Barraclough.

jit/JITStubs.h:

5:57 PM Changeset in webkit [41885] by adele@apple.com

2 edits in trunk/WebKit/mac

2009-03-20 Adele Peterson <adele@apple.com>

Build fix.

Reviewed by Darin Adler.

WebView/WebFrameView.mm: (-[WebFrameView initWithFrame:]):

5:15 PM Changeset in webkit [41884] by ggaren@apple.com

2 edits in trunk/JavaScriptCore

2009-03-20 Geoffrey Garen <ggaren@apple.com>

Reviewed by Darin Adler.

Fixed a JavaScriptCore crash on the Windows buildbot.

bytecompiler/BytecodeGenerator.h: Reduced the AST recursion limit. Apparently, Windows has small stacks.

4:46 PM Changeset in webkit [41883] by levin@chromium.org

2 edits
1 add in trunk/LayoutTests

2009-03-20 Tony Chang <tony@chromium.org>

Reviewed by Alexey Proskuryakov.

https://bugs.webkit.org/show_bug.cgi?id=24679

Change the layout test from using a data: URL to using a file:///
URL for the iframe. If DRT's frame loader has
AllowLocalLoadsForLocalOnly, then it's not possible to load an image
from disk into the iframe. Since this test is about D&D, not
local load checks, switch to a local file that doesn't have this
problem.

This should fix the test on win DRT as well.

fast/events/resources/standalone-image-drag-to-editable-frame.html: Added.
fast/events/standalone-image-drag-to-editable.html:

4:46 PM Changeset in webkit [41882] by levin@chromium.org

2 edits in trunk/WebCore

2009-03-20 Dave Moore <davemoore@google.com>

Reviewed by Dimitri Glazkov.

https://bugs.webkit.org/show_bug.cgi?id=24705

A bug in the V8 bindings is preventing chromium from setting the href on the
location object...any attempt throws a security error, not just for javascript
protocol

page/Location.idl:

4:46 PM Changeset in webkit [41881] by levin@chromium.org

2 edits in trunk/WebCore

2009-03-20 Craig Schlenter <craig.schlenter@gmail.com>

Reviewed by Dimitri Glazkov.

https://bugs.webkit.org/show_bug.cgi?id=24608

Include stdio.h needed for printf on gcc 4.4.0

platform/KURLGoogle.cpp:

4:46 PM Changeset in webkit [41880] by levin@chromium.org

2 edits in trunk/WebCore

2009-03-20 Mike Belshe <mike@belshe.com>

Reviewed by Darin Fisher.

https://bugs.webkit.org/show_bug.cgi?id=24577

Don't let comments at the end of an event handler
break the event handler.

No change in behavior, so no test.

bindings/v8/V8LazyEventListener.cpp: (WebCore::V8LazyEventListener::getWrappedListenerFunction):

4:45 PM Changeset in webkit [41879] by levin@chromium.org

18 edits in trunk

JavaScriptCore:

2009-03-20 Norbert Leser <norbert.leser@nokia.com>

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=24535

Fixes missing line terminator character (;) after macro call.
It is common practice to add the trailing ";" where macros are substituted
and not where they are defined with #define.
This change is consistent with other macro declarations across webkit,
and it also solves compilation failure with symbian compilers.

runtime/UString.cpp:
wtf/Assertions.h:

WebCore:

2009-03-20 Norbert Leser <norbert.leser@nokia.com>

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=24535

Fixes missing line terminator character (;) after macro call.
It is common practice to add the trailing ";" where macros are substituted
and not where they are defined with #define.
This change is consistent with other macro declarations across webkit,
and it also solves compilation failure with symbian compilers.

No change in behavior, so no test.

bindings/js/JSDOMWindowShell.cpp:
bindings/js/JSEventListener.cpp:
bindings/js/JSImageConstructor.cpp:
bindings/js/JSInspectedObjectWrapper.cpp:
bindings/js/JSInspectorCallbackWrapper.cpp:
bindings/js/JSNamedNodesCollection.cpp:
bindings/js/JSNodeFilterCondition.cpp:
bindings/js/JSOptionConstructor.cpp:
bindings/js/JSQuarantinedObjectWrapper.cpp:
bindings/js/JSRGBColor.cpp:
bindings/js/JSWorkerContextBase.cpp:
bindings/js/JSXMLHttpRequestConstructor.cpp:
bindings/js/JSXSLTProcessorConstructor.cpp:
bindings/scripts/CodeGeneratorJS.pm:

4:45 PM Changeset in webkit [41878] by levin@chromium.org

3 edits in trunk/WebCore

2009-03-20 Mike Belshe <mike@belshe.com>

Reviewed by Dimitri Glazkov and Dave Hyatt.

https://bugs.webkit.org/show_bug.cgi?id=24324

Make the minimum timer configurable for different platforms.

page/DOMTimer.cpp: (WebCore::DOMTimer::DOMTimer): (WebCore::DOMTimer::fired):
page/DOMTimer.h: (WebCore::DOMTimer::minTimerInterval): (WebCore::DOMTimer::setMinTimerInterval):

4:45 PM Changeset in webkit [41877] by levin@chromium.org

2 edits in trunk/WebCore

2009-03-20 Dean McNamee <deanm@chromium.org>

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=22834

Make sure to consistently match new/delete and fastMalloc/fastFree.

css/CSSSelectorList.cpp: (WebCore::CSSSelectorList::adoptSelectorVector): (WebCore::CSSSelectorList::deleteSelectors):

4:41 PM Changeset in webkit [41876] by mitz@apple.com

7 edits
4 adds in trunk

WebCore:

Reviewed by Dave Hyatt.

fix https://bugs.webkit.org/show_bug.cgi?id=23739 <rdar://problem/6556371> REGRESSION (r36513): iframe isn't sized properly upon load

rendering/RenderBlock.cpp: (WebCore::RenderBlock::percentHeightDescendants): Added this accessor.
rendering/RenderBlock.h:
rendering/RenderTableSection.cpp: (WebCore::RenderTableSection::layoutRows): Extended the check for children that flex to include other descendants with percent height which is relative to the cell.

LayoutTests:

Reviewed by Dave Hyatt.

test, updated test and results for https://bugs.webkit.org/show_bug.cgi?id=23739 <rdar://problem/6556371> REGRESSION (r36513): iframe isn't sized properly upon load

fast/replaced/percent-height-in-anonymous-block-in-table.html: Added.
fast/replaced/table-percent-height-expected.txt:
fast/replaced/table-percent-height.html:
platform/mac/fast/replaced/percent-height-in-anonymous-block-in-table-expected.checksum: Added.
platform/mac/fast/replaced/percent-height-in-anonymous-block-in-table-expected.png: Added.
platform/mac/fast/replaced/percent-height-in-anonymous-block-in-table-expected.txt: Added.

4:29 PM Changeset in webkit [41875] by dimich@chromium.org

1 edit
1 add in trunk/LayoutTests

2009-03-20 Dmitry Titov <dimich@chromium.org>

Fix broken LayoutTest/http/tests/workers/text-encoding.html.
Forgot to add a new file with the previous patch.

http/tests/workers/resources/subworker-encoded.php: Added.

4:24 PM Changeset in webkit [41874] by darin@chromium.org

2 edits
1 add
1 delete in trunk/LayoutTests

2009-03-20 Alpha Lam <hclam@chromium.org>

Reviewed by Darin Fisher.

https://bugs.webkit.org/show_bug.cgi?id=24721

The test in this change is just to verify a no crash. Full tree
dump is not necessary, so change to test to dumpAsText and update
the affected test results.

fast/block/float/crash-on-absolute-positioning-expected.txt: Added.
fast/block/float/crash-on-absolute-positioning.html:
platform/mac/fast/block/float/crash-on-absolute-positioning-expected.txt: Removed.

4:03 PM Changeset in webkit [41873] by jmalonzo@webkit.org

2 edits in trunk/WebKit/gtk

2009-03-20 Jan Michael Alonzo <jmalonzo@gmail.com>

Not reviewed. Fix style issues with my previous commit (r41866) as
suggested by Holger in https://bugs.webkit.org/show_bug.cgi?id=24493

tests/testwebhistoryitem.c: (test_webkit_web_history_item_get_data): (test_webkit_web_history_item_alternate_title):

3:56 PM Changeset in webkit [41872] by ggaren@apple.com

3 edits in trunk/JavaScriptCore

2009-03-20 Geoffrey Garen <ggaren@apple.com>

Reviewed by Oliver Hunt.

A little cleanup in the RegisterFile code.

Moved large inline functions out of the class declaration, to make it
more readable.

Switched over to using the roundUpAllocationSize function to avoid
duplicate code and subtle bugs.

Renamed m_maxCommitted to m_commitEnd, to match m_end.

Renamed allocationSize to commitSize because it's the chunk size for
committing memory, not allocating memory.

SunSpider reports no change.

interpreter/RegisterFile.h: (JSC::RegisterFile::RegisterFile): (JSC::RegisterFile::shrink): (JSC::RegisterFile::grow):
jit/ExecutableAllocator.h: (JSC::roundUpAllocationSize):

3:52 PM Changeset in webkit [41871] by dimich@chromium.org

16 edits in trunk

WebCore:

2009-03-20 Dmitry Titov <dimich@chromium.org>

Reviewed by Alexey Proskuryakov.

https://bugs.webkit.org/show_bug.cgi?id=24706
Remove ScriptExecutionContext::encoding() since Workers do not need it.
WorkerContext::encoding() is simply removed, while Document::encoding()
made non-virtual and private. Workers use UTF-8 now except when instructed
otherwise by http header. Also updated test.

dom/Document.h: Made encoding() non-virtual and private.
dom/ScriptExecutionContext.h: removed encoding().

workers/Worker.cpp: (WebCore::Worker::Worker): (WebCore::Worker::notifyFinished):
workers/WorkerContext.cpp: removed encoding() implementation. (WebCore::WorkerContext::WorkerContext): (WebCore::WorkerContext::completeURL):
workers/WorkerContext.h: removed encoding() (WebCore::WorkerContext::create):
workers/WorkerContextProxy.h:
workers/WorkerImportScriptsClient.cpp: (WebCore::WorkerImportScriptsClient::didReceiveData):
workers/WorkerMessagingProxy.cpp: (WebCore::WorkerMessagingProxy::startWorkerContext):
workers/WorkerMessagingProxy.h:
workers/WorkerThread.cpp: (WebCore::WorkerThreadStartupData::create): (WebCore::WorkerThreadStartupData::WorkerThreadStartupData): (WebCore::WorkerThread::create): (WebCore::WorkerThread::WorkerThread): (WebCore::WorkerThread::workerThread):
workers/WorkerThread.h: In all these, removed storing encoding and 'inheriting' it from the parent. Instead, they are all using UTF-8 now.

LayoutTests:

2009-03-20 Dmitry Titov <dimich@chromium.org>

Reviewed by Alexey Proskuryakov.

https://bugs.webkit.org/show_bug.cgi?id=24706
Remove ScriptExecutionContext::encoding() since Workers do not need it.
WorkerContext::encoding() is simply removed, while Document::encoding()
made non-virtual and private. Workers use UTF-8 now except when instructed
otherwise by http header. Updated test.
Also, added test for encoding used by importScripts().

http/tests/workers/resources/subworker-encoded.php: Added.
http/tests/workers/resources/worker-encoded.php:
http/tests/workers/text-encoding-expected.txt:
http/tests/workers/text-encoding.html:

3:40 PM Changeset in webkit [41870] by timothy@apple.com

15 edits in trunk

Change how threading exceptions are checked so they are reported by what round they were added.

WebCore:

2009-03-20 Timothy Hatcher <timothy@apple.com>

Change how threading exceptions are checked so they are reported
by what round they were added. That way WebKit can decided the
behavior per-round based on linked-on-or-after checks.

<rdar://problem/6626741&6648478&6635474&6674079>

Reviewed by Darin Adler.

WebCore.base.exp: Export the new symbols.
bindings/objc/DOMAbstractView.mm: Use the new WebCoreThreadViolationCheckRoundOne macro.
bindings/scripts/CodeGeneratorObjC.pm: Ditto.
platform/ThreadCheck.h:
platform/mac/ThreadCheck.mm: (WebCore::readThreadViolationBehaviorFromUserDefaults): Refactor how the default is read. (WebCore::setDefaultThreadViolationBehavior): Take a round argument. (WebCore::reportThreadViolation): Ditto. (WebCoreReportThreadViolation): Ditto.

WebKit:

2009-03-20 Timothy Hatcher <timothy@apple.com>

Change how threading exceptions are checked so they are reported
by what round they were added. That way WebKit can decided the
behavior per-round based on linked-on-or-after checks.

<rdar://problem/6626741&6648478&6635474&6674079>

Reviewed by Darin Adler.

History/WebBackForwardList.mm: Use the new WebCoreThreadViolationCheckRoundOne macro.
History/WebHistoryItem.mm: Ditto.
Misc/WebIconDatabase.mm: Ditto.

WebView/WebArchive.mm: Use the new WebCoreThreadViolationCheckRoundTwo macro.
WebView/WebResource.mm: Ditto. (+[WebResource _needMailThreadWorkaroundIfCalledOffMainThread]): Check Mail's bundle version to truly decide if it is an old Mail client.
WebView/WebView.mm: Ditto.

Misc/WebKitVersionChecks.h: Add a new linked-on-or-after version define.
WebView/WebFrameView.mm: (-[WebFrameView initWithFrame:]): Set the default thread violation behavior per-round based on difference version checks and the Mail workaround check.

3:25 PM Changeset in webkit [41869] by andersca@apple.com

2 edits in trunk/WebKitTools

2009-03-20 Anders Carlsson <andersca@apple.com>

Reviewed by Darin Adler.

Only release the result NPVariant if the call to NPN_Invoke was successful.

DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp: (testNPRuntime):

1:31 PM Changeset in webkit [41868] by ggaren@apple.com

2 edits in trunk/WebCore

2009-03-20 Geoffrey Garen <ggaren@apple.com>

Reviewed by Sam Weinig.

Fixed up an out-of-date comment.

bindings/js/JSDOMWindowCustom.h: (WebCore::JSDOMWindow::customPut):

1:25 PM Changeset in webkit [41867] by Darin Adler

2 edits in trunk/WebKit/mac

2009-03-20 Darin Adler <Darin Adler>

Reviewed by Timothy Hatcher.

WebView/WebTextIterator.h: Improved comments to point out some of the pitfalls of this SPI.

1:23 PM Changeset in webkit [41866] by jmalonzo@webkit.org

3 edits
1 add in trunk

2009-03-20 Jan Michael Alonzo <jmalonzo@gmail.com>

Reviewed by Holger Freyther.

[GTK] Misc patches for WebKitWebHistoryItem
https://bugs.webkit.org/show_bug.cgi?id=24493

Added build support for build the WebKitWebHistoryItem unit test.

GNUmakefile.am:

2009-03-20 Jan Michael Alonzo <jmalonzo@gmail.com>

Reviewed by Holger Freyther.

[GTK] Misc patches for WebKitWebHistoryItem
https://bugs.webkit.org/show_bug.cgi?id=24493

Add unit test for WebKitWebHistoryItem

tests/testwebhistoryitem.c: Added. (web_history_item_fixture_setup): (web_history_item_fixture_teardown): (test_webkit_web_history_item_get_data): (test_webkit_web_history_item_alternate_title): (main):

12:56 PM Changeset in webkit [41865] by Beth Dakin

4 edits
4 adds in trunk

WebCore:

2009-03-20 Beth Dakin <Beth Dakin>

Reviewed by Dave Hyatt.

Fix for https://bugs.webkit.org/show_bug.cgi?id=20909 REGRESSION
(r35318): A press release at pfizer.com does not display correctly

and corresponding - <rdar://problem/6680073>

rendering/RenderObject.cpp: (WebCore::RenderObject::invalidateContainerPrefWidths):
rendering/RenderObject.h: (WebCore::RenderObject::markContainingBlocksForLayout):

LayoutTests:

2009-03-20 Beth Dakin <Beth Dakin>

Reviewed by Dave Hyatt.

Test for https://bugs.webkit.org/show_bug.cgi?id=20909 REGRESSION
(r35318): A press release at pfizer.com does not display correctly

and corresponding - <rdar://problem/6680073>

http/tests/misc/generated-content-inside-table.html: Added.
platform/mac/http/tests/misc/generated-content-inside-table-expected.checksum: Added.
platform/mac/http/tests/misc/generated-content-inside-table-expected.png: Added.
platform/mac/http/tests/misc/generated-content-inside-table-expected.txt: Added.

12:45 PM Changeset in webkit [41864] by jmalonzo@webkit.org

3 edits
1 copy
1 move in trunk

2009-03-20 Jan Michael Alonzo <jmalonzo@gmail.com>

Reviewed by Holger Freyther.

Separate gtk unit tests
https://bugs.webkit.org/show_bug.cgi?id=24039

Build the unit tests accordingly.

GNUmakefile.am:

2009-03-20 Jan Michael Alonzo <jmalonzo@gmail.com>

Reviewed by Holger Freyther.

Separate gtk unit tests
https://bugs.webkit.org/show_bug.cgi?id=24039

Split the current single-file unit test to make it more
modularized and manageable in the future as more unit tests are
written.

tests/main.c: Removed.
tests/testwebbackforwardlist.c: Copied from WebKit/gtk/tests/main.c. (main):
tests/testwebframe.c: Copied from WebKit/gtk/tests/main.c. (main):

11:45 AM Changeset in webkit [41863] by eric@webkit.org

19 edits in trunk/WebCore

Reviewed by Justin Garcia.

maxDeepOffset is confusing and should be removed
https://bugs.webkit.org/show_bug.cgi?id=24586

Abstract some hard-to-read (but shared) logic into a new renderedAsNonInlineTableOrHR function.
Add first/lastDeepEditingPositionForNode Position creation functions
and deploy them to places we used to call maxDeepOffset.

Rename Position::atStart and atEnd to atStartOfTree atEndOfTree
Add a new Position::atFirst/atLastEditingPositionForNode() and use these
to replace a few more callers for maxDeepOffset()

Rename maxDeepOffset to lastEditingOffsetForNode (so that we mere mortals have some clue what it does)

"Editing positions" are confusing because they have one
of two behaviors, depending on if the container node is ignored
by editing (if editingIgnoresContent(node) returns true) or not.
Positions referring to nodes ignored by editing are
neighbor-relative (they are before or after the node) where as
positions reffering to other nodes are container-relative
(they are between two child nodes of the container, identified
by the offset() member). I will be fixing this confusion in
future patches. These renames hopefully make the current behavior clearer.

dom/Position.cpp: (WebCore::Position::previous): (WebCore::Position::next): (WebCore::Position::atFirstEditingPositionForNode): (WebCore::Position::atLastEditingPositionForNode): (WebCore::Position::atStartOfTree): (WebCore::Position::atEndOfTree): (WebCore::Position::previousCharacterPosition): (WebCore::Position::nextCharacterPosition): (WebCore::Position::upstream): (WebCore::Position::isCandidate): (WebCore::firstDeepEditingPositionForNode): (WebCore::lastDeepEditingPositionForNode):
dom/Position.h:
dom/PositionIterator.cpp: (WebCore::PositionIterator::operator Position): (WebCore::PositionIterator::increment): (WebCore::PositionIterator::decrement): (WebCore::PositionIterator::atEnd): (WebCore::PositionIterator::atEndOfNode):
editing/CompositeEditCommand.cpp: (WebCore::CompositeEditCommand::positionAvoidingSpecialElementBoundary):
editing/DeleteSelectionCommand.cpp: (WebCore::isTableCellEmpty): (WebCore::DeleteSelectionCommand::removeNode): (WebCore::DeleteSelectionCommand::handleGeneralDelete):
editing/Editor.cpp: (WebCore::Editor::advanceToNextMisspelling):
editing/InsertLineBreakCommand.cpp: (WebCore::InsertLineBreakCommand::doApply):
editing/InsertListCommand.cpp: (WebCore::InsertListCommand::doApply):
editing/ReplaceSelectionCommand.cpp: (WebCore::ReplaceSelectionCommand::positionAtEndOfInsertedContent):
editing/TypingCommand.cpp: (WebCore::TypingCommand::forwardDeleteKeyPressed):
editing/VisiblePosition.cpp: (WebCore::VisiblePosition::previous): (WebCore::VisiblePosition::leftVisuallyDistinctCandidate): (WebCore::VisiblePosition::left): (WebCore::VisiblePosition::rightVisuallyDistinctCandidate): (WebCore::VisiblePosition::right):
editing/VisibleSelection.cpp: (WebCore::VisibleSelection::selectionFromContentsOfNode): (WebCore::VisibleSelection::adjustSelectionToAvoidCrossingEditingBoundaries):
editing/htmlediting.cpp: (WebCore::nextVisuallyDistinctCandidate): (WebCore::previousVisuallyDistinctCandidate): (WebCore::firstEditablePositionAfterPositionInRoot): (WebCore::lastEditablePositionBeforePositionInRoot): (WebCore::lastOffsetForEditing): (WebCore::isFirstPositionAfterTable): (WebCore::isLastPositionBeforeTable): (WebCore::positionBeforeNode): (WebCore::positionAfterNode): (WebCore::enclosingEmptyListItem): (WebCore::caretMaxOffset):
editing/htmlediting.h:
editing/visible_units.cpp: (WebCore::renderedAsNonInlineTableOrHR): (WebCore::startOfParagraph): (WebCore::endOfParagraph): (WebCore::startOfEditableContent): (WebCore::endOfEditableContent):
page/AccessibilityObject.cpp: (WebCore::endOfStyleRange):
page/AccessibilityRenderObject.cpp: (WebCore::AccessibilityRenderObject::visiblePositionRange):
rendering/RenderBox.cpp: (WebCore::RenderBox::positionForPoint):

10:32 AM Changeset in webkit [41862] by dimich@chromium.org

3 edits
2 copies
3 adds in trunk/WebCore

2009-03-20 Dmitry Titov <dimich@chromium.org>

Reviewed by Dimitri Glazkov.

https://bugs.webkit.org/show_bug.cgi?id=24689
Add (upstream) V8 bindings for Workers. Mostly style cleaning.

bindings/v8/WorkerContextExecutionProxy.cpp: Added.
bindings/v8/WorkerContextExecutionProxy.h: Added.
bindings/v8/WorkerScriptController.cpp: Added.
bindings/v8/WorkerScriptController.h: Added.
bindings/v8/V8Index.h: Added. This is just a wrapper for v8_index.h, like V8Proxy.h
bindings/v8/V8Proxy.h: Added domObjectMap() function that wraps GetDOMObjectMap().
bindings/v8/V8WorkerContextEventListener.cpp: (WebCore::V8WorkerContextEventListener::callListenerFunction): TrackEvent() renamed trackEvent()

10:27 AM Changeset in webkit [41861] by ariya@webkit.org

3 edits in trunk/WebKit/qt

2009-03-20 Erik L. Bunce <elbunce@xendom.com>

Reviewed by Tor Arne Vestbø.

Fix QWebPage::WebActions action states to more closely match when they are
actually applicable and remove erroneous documentation.

Most WebActions implemented using editor commands now use the Editor::Command::isEnabled() to control their availability.
SelectAll is always enabled (since it's editor command is).
SetTextDirection{} family of WebActions are available when canEdit() is true and not just canEditRichly().

Fix and clarify documentation about the availability of various web actions.

Api/qwebpage.cpp: (QWebPagePrivate::updateAction): (QWebPagePrivate::updateEditorActions):
tests/qwebpage/tst_qwebpage.cpp: (tst_QWebPage::textSelection):

9:39 AM Changeset in webkit [41860] by eric@webkit.org

3 edits in trunk/WebCore

2009-03-20 Stephen White <senorblanco@chromium.org>

Reviewed by Eric Seidel.

Fix for LayoutTests/fast/canvas/canvas-text-alignment.html
on chromium/skia. The problem was that the gradient matrix
for text was being applied twice. Fixed by reverting some of
https://bugs.webkit.org/show_bug.cgi?id=23957, so that skiaDrawText
is no longer responsible for measuring the text and scaling up
the gradient matrix. Instead, the text bounding box is passed
in from SVGPaintServerGradient. I didn't make this change for CG,
since it uses a different method (the gradient is drawn using the
text as a pre-rendered mask).
https://bugs.webkit.org/show_bug.cgi?id=24687

platform/graphics/skia/SkiaFontWin.cpp: (WebCore::skiaDrawText):
svg/graphics/SVGPaintServerGradient.cpp: (WebCore::SVGPaintServerGradient::setup):

7:50 AM Changeset in webkit [41859] by Darin Adler

2 edits in trunk/WebKit/mac

2009-03-20 Darin Adler <Darin Adler>

Reviewed by Adele Peterson.

Use a better technique to handle finding out if something responds to a selector
in WebHTMLView's doCommandBySelector method.

WebView/WebHTMLView.mm: (-[WebHTMLView doCommandBySelector:]): Removed unneeded check for 0 coreFrame; this is already handled by coreCommandBySelector: so doesn't need to be checked twice. Got rid of initial value for eventWasHandled boolean to make it more clear. Use WebResponderChainSink to find out if a command is handled rather than walking the responder chain explicitly. (-[WebResponderChainSink initWithResponderChain:]): Added. (-[WebResponderChainSink detach]): Added. (-[WebResponderChainSink receivedUnhandledCommand]): Added. (-[WebResponderChainSink noResponderFor:]): Added. (-[WebResponderChainSink doCommandBySelector:]): Added.

4:09 AM Changeset in webkit [41858] by timothy@apple.com

1 edit in trunk/WebKit/mac/WebView/WebView.mm

Fix the Tiger build, round two.

3:54 AM Changeset in webkit [41857] by timothy@apple.com

1 edit in trunk/WebKit/mac/WebView/WebView.mm

Fix the Tiger build.

3:07 AM Changeset in webkit [41856] by xan@webkit.org

3 edits in trunk/WebCore

2009-03-20 Xan Lopez <xlopez@igalia.com>

Rubber-stamped by Holger Freyther.

There seems to be some rounding error in cairo (or in how we use
cairo) with some fonts, like DejaVu Sans Mono, which makes cairo
report a height smaller than ascent + descent, which is wrong and
confuses WebCore's layout system. Workaround this while we figure
out what's going on.

platform/graphics/gtk/SimpleFontDataGtk.cpp: (WebCore::SimpleFontData::platformInit):
platform/graphics/gtk/SimpleFontDataPango.cpp: (WebCore::SimpleFontData::platformInit):

1:16 AM Changeset in webkit [41855] by ap@webkit.org

3 edits
2 adds in trunk

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=24122
<rdar://problem/6674179>
REGRESSION: DOM Range extractContents/deleteContents failures seen on Moxiecode tests

Test: fast/dom/Range/deleted-range-endpoints.html

dom/Range.cpp: (WebCore::Range::processContents): Set the final range in accordance to the specification.

Note: See TracTimeline for information about the timeline view.

Download in other formats:

RSS Feed