Context Navigation

← Previous Period
Next Period →

Timeline

Mar 22, 2009:

11:01 PM Changeset in webkit [41905] by oliver@apple.com

4 edits in trunk/JavaScriptCore

Fix exception handling in API

Reviewed by Cameron Zwarich.

We can't just use the ExecState exception slot for returning exceptions
from class introspection functions provided through the API as many JSC
functions will explicitly clear the ExecState exception when returning.

9:31 PM Changeset in webkit [41904] by oliver@apple.com

1 edit in trunk/JavaScriptCore/jit/JITStubs.cpp

Fix instanceof implementation to handle API object overriding hasInstance

Reviewed by Cameron Zwarich.

We can only take the fast paths for instanceof if the object doesn't override
hasInstance, so we have to check for that.

8:46 PM Changeset in webkit [41903] by mitz@apple.com

2 edits in trunk/WebKit/mac

Reviewed by John Sullivan.

fix <rdar://problem/6640741> Messages not displaying after the Safari 4 beta was installed

Mail assumes that if -[WebArchive subresources] is not nil, then it
contains at least one object.

WebView/WebArchive.mm: (-[WebArchive subresources]): Preserve the behavior of returning nil if there are no subresources.

2:12 PM Companies and Organizations that have contributed to WebKit edited by alp@atoker.com

Add Nuanti (diff)

12:50 PM Changeset in webkit [41902] by Simon Fraser

2 edits in trunk/WebCore

2009-03-22 Simon Fraser <Simon Fraser>

Reviewed by Dan Bernstein

https://bugs.webkit.org/show_bug.cgi?id=24665

Image-map code in RenderImage could result in RenderImage::nodeAtPoint()
setting HitTestResult::innerNode(), but returning false, which violates
hit testing rules. Use a temporary HitTestResult so that we only fill in
result when we know we've hit.

rendering/RenderImage.cpp: (WebCore::RenderImage::nodeAtPoint):

12:45 PM Changeset in webkit [41901] by kevino@webkit.org

2 edits in trunk/WebCore

wxGTK build fix. Add missing header.

11:43 AM Changeset in webkit [41900] by Simon Fraser

3 edits
2 adds in trunk

2009-03-22 Simon Fraser <Simon Fraser>

Reviewed by Dan Bernstein

https://bugs.webkit.org/show_bug.cgi?id=24743

Fix hit testing regression from r41840. We need to pass the temporary
HitTestResult when testing sublayers, then only copy to 'result' when
the layer is known to have been hit.

Test: fast/layers/zindex-hit-test.html

rendering/RenderLayer.cpp: (WebCore::RenderLayer::hitTestLayer):

10:35 AM Changeset in webkit [41899] by Simon Fraser

11 edits in trunk/WebCore

2009-03-20 Simon Fraser <Simon Fraser>

Reviewed by Darin Adler

https://bugs.webkit.org/show_bug.cgi?id=24733

Fix hit testing on video controls after full page zoom by fixing wider issue
with event->pageX(), pageY() with zooming. pageX and pageY are "fixed" to be
invariant under zooming (for JavaScript), so we keep an actual page point around
in MouseEvent::absoluteLocation() to avoid the need to factor in zooming everywhere.

dom/MouseRelatedEvent.cpp: (WebCore::MouseRelatedEvent::initCoordinates): (WebCore::MouseRelatedEvent::computePageLocation):
dom/MouseRelatedEvent.h: (WebCore::MouseRelatedEvent::absoluteLocation): (WebCore::MouseRelatedEvent::setAbsoluteLocation): Member var, and getter and setter for absoluteLocation. New method, computePageLocation(), to compute the actual page point, and call it when creating and initting mouse-related events.

dom/Node.cpp: (WebCore::Node::dispatchMouseEvent): (WebCore::Node::dispatchWheelEvent): Keep non-adjusted pageX and pageY around, and call setAbsoluteLocation() on the event to replace a potentially rounded point.

html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::defaultEventHandler): Clean up slider handling code.

html/HTMLSelectElement.cpp: (WebCore::HTMLSelectElement::listBoxDefaultEventHandler): Add FIXME comment for use of offsetX/offsetY.

page/ContextMenuController.cpp: (WebCore::ContextMenuController::handleContextMenuEvent): Use absoluteLocation() when hit testing for context menus.

rendering/RenderFrameSet.cpp: (WebCore::RenderFrameSet::userResize): Use absoluteLocation() when resizing frames.

rendering/RenderMedia.cpp: (WebCore::RenderMedia::forwardEvent): Use absoluteLocation() when hit testing media controls.

rendering/RenderSlider.cpp: (WebCore::HTMLSliderThumbElement::defaultEventHandler): (WebCore::RenderSlider::mouseEventIsInThumb): Use absoluteLocation() when handling slider events.

(WebCore::RenderSlider::forwardEvent):
Factor some code out of HTMLInputElement::defaultEventHandler().

rendering/RenderTextControlSingleLine.cpp: (WebCore::RenderTextControlSingleLine::forwardEvent): Use absoluteLocation() when hit testing search field buttons, which fixees bugs in the search field with zooming.

12:34 AM Changeset in webkit [41898] by levin@chromium.org