Timeline
Mar 25, 2009:
- 7:39 PM Changeset in webkit [41999] by
-
- 2 edits in trunk/JavaScriptCore
Fix exception handling for instanceof in the interpreter.
Reviewed by Geoff Garen
- 7:34 PM Changeset in webkit [41998] by
-
- 2 edits in trunk/JavaScriptCore
2009-03-25 Geoffrey Garen <ggaren@apple.com>
Reviewed by Cameron Zwarich.
Fixed <rdar://problem/6724011> Write to freed memory in JSC::Label::deref
when reloading http://helpme.att.net/speedtest/
- bytecompiler/BytecodeGenerator.h: Reversed the declaration order for m_labelScopes and m_labels to reverse their destruction order. m_labelScopes has references to memory within m_labels, so its destructor needs to run first.
- 7:12 PM Changeset in webkit [41997] by
-
- 3 edits in trunk/WebCore
2009-03-25 Geoffrey Garen <ggaren@apple.com>
Reviewed by Oliver Hunt and Darin Adler.
Fixed <rdar://problem/6603167> Crash in WebKit!JSC::JSGlobalObject::resetPrototype
during Stress test (#3 & #7 WER crashes for Safari 4 Beta)
The problem was that allocation of the global object would, for just a
moment, leave the global object's prototype unprotected from GC. This
bug doesn't apply to non-global DOM objects because their prototypes are
cached and marked by the global object.
No test case because the crashing condition is hard to deterministically
produce in a normal build, and in a Windows Release build with
COLLECT_ON_EVERY_ALLOCATION set to 1, existing tests crash/hang.
- bindings/js/JSDOMWindowShell.cpp: (WebCore::JSDOMWindowShell::setWindow):
- bindings/js/WorkerScriptController.cpp: (WebCore::WorkerScriptController::initScript): Protect the global object's prototype from GC during construction, since the global object does not yet point to it, and therefore won't mark it.
- 6:38 PM Changeset in webkit [41996] by
-
- 9 edits10 adds in trunk
2009-03-25 Dean Jackson <dino@apple.com>
Reviewed by Simon Fraser
When using hardware compositing, some images can be directly
rendered by the hardware - no need to draw them into a separate
context, therefore saving memory.
Only images with certain style properties can be directly
composited - basically anything that is not a simple image requires
the usual rendering path (eg. if the image has borders).
Test: compositing/direct-image-compositing.html
- manual-tests/resources/simple_image.png: Added.
- manual-tests/simple-image-compositing.html: Added.
- platform/graphics/Image.h:
(WebCore::Image::startAnimation):
- move this to public
- rendering/RenderImage.cpp:
(WebCore::RenderImage::imageChanged):
- poke compositing layer if image has changed
(WebCore::RenderImage::notifyFinished):
- let the compositing layer know that it can render the image
- rendering/RenderImage.h:
- rendering/RenderLayer.cpp: (WebCore::RenderLayer::rendererContentChanged):
- rendering/RenderLayer.h:
- rendering/RenderLayerBacking.cpp: (WebCore::RenderLayerBacking::canUseInnerContentLayer): (WebCore::RenderLayerBacking::detectDrawingOptimizations): (WebCore::RenderLayerBacking::rendererContentChanged):
- rendering/RenderLayerBacking.h:
- code to hook up direct compositing of images where possible
- 4:41 PM Changeset in webkit [41995] by
-
- 2 edits in trunk/WebKitTools
Update test result search path for Windows now that it has updated versions of ICU, libxml2, and friends.
Rubber-stamped by Steve Falkenburg.
- Scripts/run-webkit-tests:
- 4:06 PM Changeset in webkit [41994] by
-
- 2 edits in trunk/WebKit/mac
2009-03-25 Anders Carlsson <andersca@apple.com>
Reviewed by Darin Adler.
<rdar://problem/6714964>
CrashTracer: [REGRESSION] 51 crashes in Safari at com.apple.WebKit ⢠WebNetscapePluginStream::deliverData + 775
Don't release m_deliveryData since it's a RetainPtr. Also, use adoptNS instead of releasing newDeliveryData manually.
- Plugins/WebBaseNetscapePluginStream.mm: (WebNetscapePluginStream::deliverData):
- 3:37 PM Changeset in webkit [41993] by
-
- 8 edits in trunk/LayoutTests
2009-03-25 Simon Fraser <Simon Fraser>
Reviewed by Anders Carlsson.
Update layout test results for
https://bugs.webkit.org/show_bug.cgi?id=24809
- fast/css/getComputedStyle/computed-style-expected.txt:
- fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
- platform/mac/fast/css/getComputedStyle/computed-style-expected.txt:
- platform/mac/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
- platform/win/fast/css/getComputedStyle/computed-style-expected.txt:
- platform/win/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
- svg/css/getComputedStyle-basic-expected.txt:
- 3:24 PM Changeset in webkit [41992] by
-
- 2 edits in trunk/WebCore
2009-03-25 David Levin <levin@chromium.org>
Reviewed by Dimitri Glazkov.
Chromium build fix. Fix #include in V8NodeFilterCondition.cpp due to the
rename of V8NodeFilter to V8NodeFilterCondition.
- bindings/v8/V8NodeFilterCondition.cpp:
- 3:15 PM Changeset in webkit [41991] by
-
- 5 edits in trunk/WebCore
Reviewed by Darin Adler.
Remove dead code and style cleanup
https://bugs.webkit.org/show_bug.cgi?id=24684
- html/CanvasStyle.cpp: (WebCore::CanvasStyle::CanvasStyle): Coverty was annoyed that we didn't initialize all of our members. I agree, but I didn't want to paste all 8 members each time, so I just cleaned up the existing constructors and left them.
- page/FocusController.cpp: (WebCore::FocusController::setFocusedNode): "node" was checked just above and is already known to be non-null
- rendering/RenderLayer.cpp: (WebCore::RenderLayer::insertOnlyThisLayer): We were already using parentLayer w/o a NULL check above, so just add an explicit ASSERT and use it w/o NULL check (WebCore::RenderLayer::resize): element is already ASSERTed above, no need to null check it here
- rendering/RenderTableSection.cpp: (WebCore::RenderTableSection::addCell): currentCell.cell was just assigned to the value "cell" which is known to be non-null, no need to null check again.
- 3:14 PM Changeset in webkit [41990] by
-
- 3 edits in trunk/WebCore
Reviewed by Darin Adler.
Move ASSERT(foo) to before where foo-> is used
https://bugs.webkit.org/show_bug.cgi?id=24684
- platform/chromium/PasteboardChromium.cpp: (WebCore::Pasteboard::writeImage): Move ASSERTs to the top of the function, code was using "node" before ASSERT(node), once I moved ASSERT(node) to the top of the function it made sense to move the rest of them there too.
- rendering/SVGRenderSupport.cpp: (WebCore::prepareToRenderSVGContent): move ASSERT(object) to *before* we use "object" :)
- 3:14 PM Changeset in webkit [41989] by
-
- 2 edits in trunk/WebCore
Reviewed by Simon Fraser.
Make TextTokenizer ASSERT that the buffer was freed
https://bugs.webkit.org/show_bug.cgi?id=24684
- loader/TextDocument.cpp: (WebCore::TextTokenizer::TextTokenizer): (WebCore::TextTokenizer::~TextTokenizer): (WebCore::TextTokenizer::finish): Make it clear by adding a ~TextTokenizer that finish() will always be called and the memory never leaked.
- 3:14 PM Changeset in webkit [41988] by
-
- 2 edits in trunk/WebCore
Reviewed by Darin Adler.
Fix case where lBreak.obj->isBR() when lBreak.obj was NULL
https://bugs.webkit.org/show_bug.cgi?id=24684
I don't have a test case where we were taking the wrong path here
However, adding an ASSERT(lBreak.obj) before this usage caused
multiple bidi tests to fail, so lBreak.obj can be null here.
- rendering/bidi.cpp: (WebCore::RenderBlock::findNextLineBreak): lBreak.obj can be null, so we can't call ->isBR() on it unconditionally.
- 3:11 PM Changeset in webkit [41987] by
-
- 3 edits4 adds in trunk
2009-03-25 Simon Fraser <Simon Fraser>
Reviewed by Darin Adler
When the slider range is zero, avoid a divide by zero, which caused the
thumb to be positioned off in the weeds, which broke painting.
Test: media/video-empty-source.html
- rendering/RenderSlider.cpp: (WebCore::SliderRange::proportionFromValue): (WebCore::SliderRange::valueFromProportion): (WebCore::sliderPosition): (WebCore::RenderSlider::setValueForPosition):
- 3:04 PM Changeset in webkit [41986] by
-
- 6 edits in trunk/WebCore
Reviewed by Simon Fraser.
Style cleanup and dead code removal in dom, editing
https://bugs.webkit.org/show_bug.cgi?id=24684
- dom/ContainerNode.cpp: (WebCore::ContainerNode::getUpperLeftCorner): (WebCore::ContainerNode::getLowerRightCorner): (WebCore::ContainerNode::getRect): Coverty was (rightly) confused as to what the hell "o" was being used for and whether or not it would ever be NULL. I added some ASSERTS so that people (and machines) would be less confused about the logic in getUpperLeftCorner/getLowerRightCorner
- dom/Document.cpp: (WebCore::Document::recalcStyle): Remove dead code, this block already checked that change == Force
- editing/ApplyStyleCommand.cpp: (WebCore::ApplyStyleCommand::removeInlineStyle): Coverty correctly identified that traversePreviousNodePostOrder can return NULL, thus prev will be null, and we don't really explicitly handle it (like we probably should) It's OK though, because we end up creating a null position object, which may not have been what we intended, but we certainly don't crash.
- editing/InsertParagraphSeparatorCommand.cpp: (WebCore::InsertParagraphSeparatorCommand::doApply): Remove dead code, insertionPosition.node() is already checked to be non-null above.
- editing/markup.cpp: (WebCore::appendStartMarkup): removed dead code, annotate is already known to be true at this point in the file !annotate was checked above, and break; was called.
- 3:04 PM Changeset in webkit [41985] by
-
- 4 edits in trunk/WebCore
Reviewed by Simon Fraser.
CSS dead code removal and cleanup from Coverty errors
https://bugs.webkit.org/show_bug.cgi?id=24684
- css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::applyProperty): Every other place in the code we check settings() for NULL, so I made these places check too, even though we should never be resolving style against a document which has no frame (which I believe is the only time settings() can be null)
- css/CSSStyleSheet.cpp: (WebCore::CSSStyleSheet::styleSheetChanged): Removing dead code, "root" can never be null here.
- css/SVGCSSStyleSelector.cpp: (WebCore::colorFromSVGColorCSSValue): (WebCore::CSSStyleSelector::applySVGProperty): Extra returns in the old macros caused dead code. Removing the old macros and use modern ones instead. :) Extra null checks to value were not needed. Added an ASSERT at the top of the function to make it clear that value will never be NULL. Added colorFromSVGColorCSSValue to clean up the code a little.
- 3:04 PM Changeset in webkit [41984] by
-
- 3 edits in trunk/WebCore
Reviewed by Simon Fraser.
Font fallback cleanup and added ASSERT for GlyphPageTreeNode
https://bugs.webkit.org/show_bug.cgi?id=24684
- css/CSSFontSelector.cpp: (WebCore::compareFontFaces): Coverty was concerned that it was possible to index off the end of weightFallbackRuleSets I can't read the code well enough to tell, so I tried to make the code clearer and added an ASSERT.
- platform/graphics/GlyphPageTreeNode.cpp: (WebCore::GlyphPageTreeNode::initializePage): Coverty believes we can crash here due to j being larger than GlyphPage::size. I think to is already known to be < GlyphPage::size due to the min() statement above, but not being sure I added an ASSERT.
- 3:04 PM Changeset in webkit [41983] by
-
- 9 edits in trunk/WebCore
Reviewed by Simon Fraser.
Coverty inspired fixes in Animations/Transforms
https://bugs.webkit.org/show_bug.cgi?id=24684
- page/animation/AnimationBase.h: Fix animate() signatures to match so that the virtual methods actually override one another. :)
- page/animation/AnimationController.cpp: (WebCore::AnimationControllerPrivate::removeFromStartTimeResponseWaitList): Attempt to fix this method, prevAnimation was never set to anything but NULL, as far as I can tell the author originally intended to update it at the end of the loop, which is what I changed this code to do.
- page/animation/ImplicitAnimation.cpp: (WebCore::ImplicitAnimation::animate): Make method signature match AnimationBase::animate
- page/animation/ImplicitAnimation.h:
- page/animation/KeyframeAnimation.cpp: (WebCore::KeyframeAnimation::animate): Make method signature match AnimationBase::animate
- page/animation/KeyframeAnimation.h:
- platform/graphics/transforms/PerspectiveTransformOperation.cpp: (WebCore::PerspectiveTransformOperation::blend): if (blendToIdentity) already returned above.
- platform/graphics/transforms/RotateTransformOperation.cpp: (WebCore::RotateTransformOperation::blend): if (blendToIdentity) already returned above.
- 2:31 PM Changeset in webkit [41982] by
-
- 3 edits in trunk/WebCore
2009-03-25 Eli Fidler <eli.fidler@torchmobile.com>
Reviewed by George Staikos.
Fix compiler warnings regarding assignments in if statements.
- 2:25 PM Changeset in webkit [41981] by
-
- 3 edits2 adds in trunk
WebCore:
Reviewed by Dave Hyatt.
- fix <rdar://problem/6472150> repro crash in RenderBlock::rightmostPosition(bool, bool) const at mercotte.fr using menus
Test: fast/inline/continuation-positioned-reparenting.html
- rendering/RenderInline.cpp: (WebCore::RenderInline::splitFlow): When repurposing the existing container as the "pre" block, clear its positioned objects list, because positioned descendants may end up in a different block after the split.
LayoutTests:
Reviewed by Dave Hyatt.
- test for <rdar://problem/6472150> repro crash in RenderBlock::rightmostPosition(bool, bool) const at mercotte.fr using menus
- fast/inline/continuation-positioned-reparenting-expected.txt: Added.
- fast/inline/continuation-positioned-reparenting.html: Added.
- 12:52 PM Changeset in webkit [41980] by
-
- 3 edits4 adds in trunk
2009-03-24 Simon Fraser <Simon Fraser>
Reviewed by Dave Hyatt
Length values in transform operations need to take zoom into account.
Test: fast/transforms/transforms-with-zoom.html
- css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::createTransformOperations):
- 12:36 PM Applications using WebKit edited by
- (diff)
- 12:23 PM Changeset in webkit [41979] by
-
- 9 edits in trunk
WebCore:
2009-03-25 David Hyatt <hyatt@apple.com>
Reviewed by Simon Fraser.
https://bugs.webkit.org/show_bug.cgi?id=24809, background-clip/origin don't use the correct
values. Add support for the new values (while preserving the old values for backwards
compatibility).
Changed some existing test cases to use the new values.
- css/CSSParser.cpp: (WebCore::CSSParser::parseFillProperty):
- css/CSSPrimitiveValueMappings.h: (WebCore::CSSPrimitiveValue::CSSPrimitiveValue): (WebCore::CSSPrimitiveValue::operator EFillBox):
- css/CSSValueKeywords.in:
LayoutTests:
2009-03-25 David Hyatt <hyatt@apple.com>
Reviewed by Simon Fraser.
Change a few test cases to use the new values just to verify that they work.
- fast/backgrounds/size/backgroundSize17.html:
- fast/backgrounds/size/backgroundSize18.html:
- fast/backgrounds/size/backgroundSize19.html:
- fast/gradients/simple-gradients.html:
- 11:18 AM Changeset in webkit [41978] by
-
- 3 edits4 adds in trunk
WebCore:
2009-03-25 Brett Wilson <brettw@dhcp-172-22-71-191.mtv.corp.google.com>
Reviewed by Dimitri Glazkov.
Fix complex text opacity on the Chromium Windows port.
https://bugs.webkit.org/show_bug.cgi?id=24757
Test: fast/text/complex-text-opacity.html
- platform/graphics/chromium/FontChromiumWin.cpp: (WebCore::): (WebCore::TransparencyAwareFontPainter::TransparencyAwareFontPainter::TransparencyAwareFontPainter): (WebCore::TransparencyAwareFontPainter::TransparencyAwareFontPainter::init): (WebCore::TransparencyAwareFontPainter::TransparencyAwareFontPainter::initializeForGDI): (WebCore::TransparencyAwareFontPainter::TransparencyAwareFontPainter::~TransparencyAwareFontPainter): (WebCore::TransparencyAwareFontPainter::TransparencyAwareGlyphPainter::TransparencyAwareGlyphPainter): (WebCore::TransparencyAwareFontPainter::TransparencyAwareGlyphPainter::~TransparencyAwareGlyphPainter): (WebCore::TransparencyAwareFontPainter::TransparencyAwareGlyphPainter::estimateTextBounds): (WebCore::TransparencyAwareFontPainter::TransparencyAwareGlyphPainter::drawGlyphs): (WebCore::TransparencyAwareFontPainter::TransparencyAwareUniscribePainter::hdc): (WebCore::TransparencyAwareFontPainter::TransparencyAwareUniscribePainter::TransparencyAwareUniscribePainter): (WebCore::TransparencyAwareFontPainter::TransparencyAwareUniscribePainter::~TransparencyAwareUniscribePainter): (WebCore::TransparencyAwareFontPainter::TransparencyAwareUniscribePainter::estimateTextBounds): (WebCore::Font::drawGlyphs): (WebCore::Font::drawComplexText):
LayoutTests:
2009-03-25 Brett Wilson <brettw@dhcp-172-22-71-191.mtv.corp.google.com>
Reviewed by Dimitri Glazkov.
Fix complex text opacity on the Chromium Windows port.
https://bugs.webkit.org/show_bug.cgi?id=24757
- fast/text/complex-text-opacity.html: Added.
- platform/mac/fast/text/complex-text-opacity-expected.checksum: Added.
- platform/mac/fast/text/complex-text-opacity-expected.png: Added.
- platform/mac/fast/text/complex-text-opacity-expected.txt: Added.
- 10:30 AM Changeset in webkit [41977] by
-
- 3 edits in trunk/WebKit/mac
Reviewed by Kevin Decker.
<rdar://problem/6453738> call SetWindow when user creates a new tab
CoreGraphics plug-ins now receive an NPP_SetWindow call when moving to a background tab.
Flash is excluded from this change in behavior, as it has historical WebKit-specific code
that isn't compatible with this change.
- Plugins/WebNetscapePluginView.h:
Added an _isFlash ivar.
- Plugins/WebNetscapePluginView.mm: (-[WebNetscapePluginView _createPlugin]):
Set the new _isFlash ivar based on the bundle identifier.
(-[WebNetscapePluginView saveAndSetNewPortStateForUpdate:]):
When using the CG drawing model and in a non-drawable state, set the portState
to NULL and return early.
(-[WebNetscapePluginView updateAndSetWindow]):
When using the CG drawing model, call -setWindowIfNecessary even if the portState is NULL.
Flash is an exception to this, due to its historical behavior.
(-[WebNetscapePluginView setWindowIfNecessary]):
Removed an assertion that was no longer true. The [NSView focus] view
is no longer guaranteed to be 'self' at this point.
Also modified the debug logging for CG plug-ins to include the size of the
window's clipRect, which was useful in verifying the correct behavior of this patch.
- 10:07 AM Changeset in webkit [41976] by
-
- 3 edits4 adds in trunk
WebCore:
2009-03-25 David Hyatt <hyatt@apple.com>
Reviewed by Eric Seidel
Fix for bug 23198, border images should not clip to border radii. The border-image should just ignore
the border-radius, since the assumption is that any desired rounding will be built into the border-image
itself.
Note that I do not agree with this change, but I am matching the spec.
Added fast/borders/border-image-border-radius.html
- rendering/RenderBoxModelObject.cpp: (WebCore::RenderBoxModelObject::paintNinePieceImage):
LayoutTests:
2009-03-25 David Hyatt <hyatt@apple.com>
Reviewed by Eric Seidel
Test case for bug 23198.
- fast/borders/border-image-border-radius.html: Added.
- platform/mac/fast/borders/border-image-border-radius-expected.checksum: Added.
- platform/mac/fast/borders/border-image-border-radius-expected.png: Added.
- platform/mac/fast/borders/border-image-border-radius-expected.txt: Added.
- 8:09 AM Changeset in webkit [41975] by
-
- 2 edits in trunk/WebCore
2009-03-25 Gustavo Noronha Silva <Gustavo Noronha Silva>
Reviewed by Holger Freyther.
https://bugs.webkit.org/show_bug.cgi?id=24750
[GTK] requests download instead of displaying page
Fix the Content-Type headers we get from soup, so that we set a
proper media type on the ResourceResponse.
- platform/network/soup/ResourceHandleSoup.cpp: (WebCore::fillResponseFromMessage):
- 7:49 AM Changeset in webkit [41974] by
-
- 2 edits in trunk/WebCore
2009-03-25 Gustavo Noronha Silva <Gustavo Noronha Silva>
Reviewed by Holger Freyther.
https://bugs.webkit.org/show_bug.cgi?id=24600
[GTK] responses with status code >= 400 should not be given special treatment
Do not special case requests that have HTTP responses >=
- Redirects are handled automatically by libsoup, but the rest of the responses should be treated like any other.
- platform/network/soup/ResourceHandleSoup.cpp: (WebCore::): (WebCore::gotHeadersCallback): (WebCore::gotChunkCallback): (WebCore::finishedCallback):
- 7:36 AM Changeset in webkit [41973] by
-
- 5 edits in trunk/WebCore
2009-03-25 Darin Adler <Darin Adler>
Reviewed by John Sullivan.
Tidy up LegacyWebArchive a bit. And don't include favicons in web archives when
they are being used only for selections, not an entire document.
- WebCore.base.exp: Remove exported function that's not used in WebKit.
- loader/archive/cf/LegacyWebArchive.cpp: (WebCore::LegacyWebArchive::createPropertyListRepresentation): Made a static member function so it can share private things with other member functions. Added some FIXME comments to a branch of code I think is dead. Changed boolean argument into a named one. Renamed to match other similar functions. (WebCore::LegacyWebArchive::createResourceResponseFromPropertyListData): Ditto. (WebCore::LegacyWebArchive::createResource): Ditto. (WebCore::LegacyWebArchive::create): Merged the create and init functions. (WebCore::LegacyWebArchive::rawDataRepresentation): Added some assertions because we should never fail to write (we can fail to read). (WebCore::LegacyWebArchive::createResourceResponseFromMacArchivedData): Made a static member function as above. (WebCore::LegacyWebArchive::createFromSelection): Ditto. (WebCore::LegacyWebArchive::create): Iterate the vector with indices rather than iterators. Only include the favicon if the first node is the document since we don't want to include the favicon when copying and pasting.
- loader/archive/cf/LegacyWebArchive.h: Made one of the create functions private. Made the Mac-specific functions be static member functions. Made other helpers be static member functions. Removed the nit function.
- loader/archive/cf/LegacyWebArchiveMac.mm: (WebCore::LegacyWebArchive::createResourceResponseFromMacArchivedData): Updated comment and made this a static member function. (WebCore::LegacyWebArchive::createPropertyListRepresentation): Ditto. Also made it so we only type cast in one place.
- 7:34 AM Changeset in webkit [41972] by
-
- 12 edits2 adds in trunk
WebCore:
2009-03-25 Darin Adler <Darin Adler>
Reviewed by David Hyatt.
Bug 24740: crash in RenderSlider::setPositionFromValue when calling pause() after setting <video> to display: none
https://bugs.webkit.org/show_bug.cgi?id=24740
rdar://problem/6679873
Bug 12104: Native Slider: When the thumb's height is specified as a percentage, it is not centered properly
https://bugs.webkit.org/show_bug.cgi?id=12104
Test: media/video-display-none-crash.html
The problem here was that RenderSlider was trying to position its thumb in a way that
requires it to call updateLayout inside rendering code. The right way to position a
child renderer is to do layout, so I had to write a layout function. And then fix a few
other small problems shown by the same test case.
- rendering/RenderSlider.cpp: Made defaultTrackLength have internal linkage. Renamed HTMLSliderThumbElement to SliderThumbElement because we only use the HTML prefix for public DOM classes, not elements used as implementation details. Made SliderThumbElement function members private and got rid of unneeded default argument value for shadowParent. (WebCore::SliderRange::SliderRange): Added. Parses precision, max, and min attributes. (WebCore::SliderRange::clampValue): Added. Does standard clamping based on the above. (WebCore::SliderRange::valueFromElement): Added. Reads the value from the element in a way that clamps to the range. (WebCore::sliderPosition): Added. Computes the slider position: a double. (WebCore::SliderThumbElement::SliderThumbElement): Removed unneeded explicit initialization of m_initialClickPoint. (WebCore::SliderThumbElement::defaultEventHandler): Call setValueForPosition instead of calling setCurrentPosition and valueChanged. (WebCore::RenderSlider::RenderSlider): Remove unneeded explicit initialization of m_thumb. (WebCore::RenderSlider::styleDidChange): Remove unneeded second argument to createThumbStyle. (WebCore::RenderSlider::createThumbStyle): Remove unneeded second argument. Get rid of code setting the position to relative and setting the left and top. We now handle positioning in a custom layout function. (WebCore::RenderSlider::layout): Rewrote to handle positioning of the thumb as layout. (WebCore::RenderSlider::updateFromElement): Added code to immediately update the value in the element if it's out of range. This clamping used to be done as a side effect of setPositionFromValue. Also, this has nothing to do with the renderer, so at some point it could be moved into HTMLInputElement. Removed call to setPositionFromValue and instead just rely on the call to setNeedsLayout. Fix the setNeedsLayout call to be a normal setNeedsLayout(true), not a setNeedsLayout(true, false), because we do want this to be propagated to the parent -- it's not called during layout. (WebCore::RenderSlider::setValueForPosition): Refactor to use the new SliderRange class. Also don't call setCurrentPosition; instead just call setNeedsLayout. (WebCore::RenderSlider::currentPosition): Use the actual position of the renderer rather than the style to find the position; that means this needs to be done after layout is done. Also removed unneeded runtime checks and replaced them with assertions, after checking all callers to see they already guarantee this. (WebCore::RenderSlider::trackSize): Removed unneeded runtime checks and replaced them with assertions, after checking all callers to see they already guarantee this. (WebCore::RenderSlider::inDragMode): Added a null check for m_thumb so this won't crash if called early on a brand new RenderSlider.
- rendering/RenderSlider.h: Made all functions private except for forwardEvent and inDragMode. Renamed HTMLSliderThumbElement to SliderThumbElement because we only use the HTML prefix for public DOM classes, not elements used as implementation details. Made the mouseEventIsInThumb function non-virtual. Removed the return value and argument from setPositionFromValue. Removed valueChanged and setCurrentPosition. Removed the oldStyle argument to createThumbStyle (see above). Made SliderThumbElement a friend so it can use some private member functions.
LayoutTests:
2009-03-25 Darin Adler <Darin Adler>
Reviewed by David Hyatt.
Bug 24740: crash in RenderSlider::setPositionFromValue when calling pause() after setting <video> to display: none
https://bugs.webkit.org/show_bug.cgi?id=24740
rdar://problem/6679873
Bug 12104: Native Slider: When the thumb's height is specified as a percentage, it is not centered properly
https://bugs.webkit.org/show_bug.cgi?id=12104
- media/video-display-none-crash-expected.txt: Added.
- media/video-display-none-crash.html: Added.
- platform/mac/fast/forms/box-shadow-override-expected.txt: Updated since a slider's thumb is no longer relative-positioned and hence no longer gets its own layer.
- platform/mac/fast/forms/input-appearance-height-expected.txt: Ditto.
- platform/mac/fast/forms/slider-padding-expected.txt: Ditto.
- platform/mac/fast/forms/slider-thumb-shared-style-expected.txt: Ditto.
- platform/mac/fast/forms/slider-thumb-stylability-expected.txt: Ditto.
- platform/mac/media/audio-controls-rendering-expected.txt: Ditto.
- platform/mac/media/video-controls-rendering-expected.txt: Ditto.
- platform/mac/media/video-display-toggle-expected.txt: Ditto.
- 7:31 AM Changeset in webkit [41971] by
-
- 2 edits in trunk/WebKit/gtk
2009-03-25 Gustavo Noronha Silva <Gustavo Noronha Silva>
Reviewed by Holger Freyther.
https://bugs.webkit.org/show_bug.cgi?id=15793
[GTK] tooltip position doesn't update when hovering consecutive links
Work-around tooltips not updating their location when the elements
are consecutive, by clearing the tooltip when handling
mouseDidMoveOverElement.
- WebCoreSupport/ChromeClientGtk.cpp: (WebKit::ChromeClient::mouseDidMoveOverElement):
- 6:01 AM Changeset in webkit [41970] by
-
- 5 edits in trunk/WebCore
2009-03-25 Eli Fidler <eli.fidler@torchmobile.com>
Reviewed by George Staikos.
Fix ambiguous else cases by adding braces to nested if()s with elses.
- 5:00 AM Changeset in webkit [41969] by
-
- 3 edits in trunk/WebKit/gtk
2009-03-23 Alejandro Garcia Castro <alex@igalia.com>
Reviewed by Holger Freyther.
[Gtk] Current API does not allow us to open target="_blank" links
in new tabs instead of windows
https://bugs.webkit.org/show_bug.cgi?id=23932
Added a signal to the API (new-window-policy-decision-requested)
that allows the browser to decide the policy for the new window
request, if the signal is not handled we open the new window as
usual.
- WebCoreSupport/FrameLoaderClientGtk.cpp: (WebKit::getNavigationAction): (WebKit::FrameLoaderClient::dispatchDecidePolicyForNewWindowAction): (WebKit::FrameLoaderClient::dispatchDecidePolicyForNavigationAction):
- webkit/webkitwebview.cpp:
Mar 24, 2009:
- 9:18 PM Changeset in webkit [41968] by
-
- 2 edits in trunk/WebKitTools
Fix the Tiger build some more.
- 9:06 PM Changeset in webkit [41967] by
-
- 2 edits in trunk/WebKitTools
Fix the Tiger build.
- 8:29 PM Changeset in webkit [41966] by
-
- 4 edits in trunk
Explicitly map NSNotFound to -1 so that the result of-characterIndexForPointX:Y: does not differ between 32- and 64-bit.
Reviewed by Jon "The Most Boring Man in the World" Honeycutt.
- DumpRenderTree/mac/TextInputController.m:
(-[TextInputController characterIndexForPointX:Y:]):
Update test result for change to explicitly map NSNotFound to -1 in textInputController.characterIndexForPoint.
- platform/mac/fast/dom/character-index-for-point-expected.txt:
- 8:13 PM Changeset in webkit [41965] by
-
- 2 edits in trunk/LayoutTests
Skip some more tests that are failing.
Rubber-stamped by Oliver Hunt.
- platform/mac-snowleopard/Skipped:
- 7:47 PM Changeset in webkit [41964] by
-
- 2 edits in trunk/WebCore
2009-03-24 Eli Fidler <eli.fidler@torchmobile.com>
Reviewed by George Staikos.
Move variable into proper platform block to quiet warning.
- 7:14 PM Changeset in webkit [41963] by
-
- 3 edits in trunk/WebCore
2009-03-24 Eric Carlson <eric.carlson@apple.com>
Reviewed by Antti Koivisto.
Fix for <rdar://problem/6719375> Deal with QTKit loadstate changes when playing streaming movies
- WebCore/html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::setNetworkState): Deal with media engine reviving after having network state of NETWORK_NO_SOURCE.
- WebCore/platform/graphics/mac/MediaPlayerPrivateQTKit.mm: (WebCore::MediaPlayerPrivate::updateStates): Reset m_readyState at each state change since some types of movies currently cause QTKit's load state to bounce around. QTMovieLoadStatePlaythroughOK corresponds to HaveFutureData, not HaveEnoughData.
- 5:57 PM Changeset in webkit [41962] by
-
- 7 edits in trunk
WebCore:
2009-03-24 Adele Peterson <adele@apple.com>
Reviewed by Darin Adler.
Fix for https://bugs.webkit.org/show_bug.cgi?id=24707
<rdar://problem/6593021> Deleting with a caret in a blank, quoted line decreases the quoting, but does not delete the line
- editing/TypingCommand.cpp: (WebCore::TypingCommand::deleteKeyPressed): After breaking out of an empty mail blockquote, we still want continue with the deletion so actual content will get deleted, and not just the quote style.
LayoutTests:
2009-03-24 Adele Peterson <adele@apple.com>
Reviewed by Darin Adler.
Updated tests for https://bugs.webkit.org/show_bug.cgi?id=24707
<rdar://problem/6593021> Deleting with a caret in a blank, quoted line decreases the quoting, but does not delete the line
- editing/deleting/2610675-1-expected.txt:
- editing/deleting/2610675-1.html:
- editing/deleting/2610675-2-expected.txt:
- editing/deleting/2610675-2.html:
- 5:30 PM Changeset in webkit [41961] by
-
- 2 edits in trunk/WebCore
2009-03-24 Darin Adler <Darin Adler>
Reviewed by Brady Eidson.
<rdar://problem/6624662> REGRESSION (r39904): can't save certain web pages as web archive (ones without favicons!)
- loader/archive/cf/LegacyWebArchive.cpp: (WebCore::LegacyWebArchive::create): Added a null check.
- 5:02 PM Changeset in webkit [41960] by
-
- 2 edits in trunk/WebCore
2009-03-24 Adam Langley <agl@google.com>
Reviewed by Darin Fisher.
The Skia drawLine function takes subpixel values and attempts to draw
a line with subpixel precision. This is complex and slow for drawing
scrollbars which use only vertical and horizontal lines.
This changes the Chromium Linux scrollbar code to use drawIRect.
- platform/chromium/ScrollbarThemeChromiumLinux.cpp: (WebCore::ScrollbarThemeChromium::invalidateOnMouseEnterExit): (WebCore::drawVertLine): (WebCore::drawHorizLine): (WebCore::drawBox): (WebCore::ScrollbarThemeChromium::paintTrackPiece): (WebCore::ScrollbarThemeChromium::paintThumb):
- 4:36 PM Changeset in webkit [41959] by
-
- 2 edits in trunk/LayoutTests
Skip fast/forms/search-zoomed.html as it currently fails due to <rdar://problem/6718460>.
Rubber-stamped by Sam Weinig.
- platform/mac-snowleopard/Skipped:
- 4:25 PM Changeset in webkit [41958] by
-
- 1 edit in trunk/WebCore/ChangeLog
Fix the list of files touched in r41951 in the Changelog.
- 4:18 PM Changeset in webkit [41957] by
-
- 2 edits in trunk/LayoutTests
Skip some more media tests for now.
- platform/mac-snowleopard/Skipped:
- 4:18 PM Changeset in webkit [41956] by
-
- 2 edits in trunk/WebKitTools
Use a different platform search path for tests and skip lists, so that Tiger doesn't end up
using the Leopard skip list. Tests and skip lists are now looked for in the directory for
the current OS and the generic "mac" directory. Tests and skip lists for newer OS versions are
ignored.
Reviewed by Sam Weinig.
- Scripts/run-webkit-tests:
- 3:30 PM Changeset in webkit [41955] by
-
- 1 edit26 adds in trunk/LayoutTests
2009-03-24 Pamela Greene <pam@chromium.org>
Reviewed by Sam Weinig.
Add tests of font choices and metrics, to isolate those dependencies.
- fonts: Added.
- fonts/cursive.html: Added.
- fonts/default.html: Added.
- fonts/fantasy.html: Added.
- fonts/monospace.html: Added.
- fonts/sans-serif.html: Added.
- fonts/serif.html: Added.
- platform/mac/fonts: Added.
- platform/mac/fonts/cursive-expected.checksum: Added.
- platform/mac/fonts/cursive-expected.png: Added.
- platform/mac/fonts/cursive-expected.txt: Added.
- platform/mac/fonts/default-expected.checksum: Added.
- platform/mac/fonts/default-expected.png: Added.
- platform/mac/fonts/default-expected.txt: Added.
- platform/mac/fonts/fantasy-expected.checksum: Added.
- platform/mac/fonts/fantasy-expected.png: Added.
- platform/mac/fonts/fantasy-expected.txt: Added.
- platform/mac/fonts/monospace-expected.checksum: Added.
- platform/mac/fonts/monospace-expected.png: Added.
- platform/mac/fonts/monospace-expected.txt: Added.
- platform/mac/fonts/sans-serif-expected.checksum: Added.
- platform/mac/fonts/sans-serif-expected.png: Added.
- platform/mac/fonts/sans-serif-expected.txt: Added.
- platform/mac/fonts/serif-expected.checksum: Added.
- platform/mac/fonts/serif-expected.png: Added.
- platform/mac/fonts/serif-expected.txt: Added.
- 3:22 PM Changeset in webkit [41954] by
-
- 2 edits in trunk/JavaScriptCore
2009-03-24 Eli Fidler <eli.fidler@torchmobile.com>
Reviewed by George Staikos.
Correct warnings which in some environments are treated as errors.
- 2:40 PM Changeset in webkit [41953] by
-
- 3 edits3 adds in trunk
Bug 23310: Setting an absolute path (/abs) on an <iframe> with no src doesn't resolve the URL properly
Reviewed by Darin Adler.
WebCore:
Test: fast/frames/iframe-no-src-set-location.html
- dom/Document.cpp: (WebCore::Document::completeURL): If m_baseURL is empty or is about:blank and we have a parent document, use the parent document's URL for the base when completing a new URL.
LayoutTests:
- fast/frames/iframe-no-src-set-location-expected.txt: Added.
- fast/frames/iframe-no-src-set-location.html: Added.
- fast/frames/resources/iframe-no-src-set-location-pass.html: Copied from LayoutTests/fast/dom/Document/early-document-access-expected.txt.
- 2:07 PM Changeset in webkit [41952] by
-
- 3 edits2 adds in trunk
2009-03-24 Simon Fraser <Simon Fraser>
Reviewed by Dave Hyatt
When hit-testing 3d-transformed layers, it doesn't make sense to project the hitTestRect
into the coordinate space of the layer, and doing so can result in pathalogical quads
that break hit testing. In that case, simply use the same bounds as used for painting,
which are the composited bounds for this layer.
Test: transforms/3d/hit-testing/rotated-hit-test.html
- rendering/RenderLayer.cpp: (WebCore::RenderLayer::hitTestLayer):
- 2:03 PM Changeset in webkit [41951] by
-
- 3 edits in trunk/WebCore
2009-03-24 Simon Fraser <Simon Fraser>
Reviewed by Dave Hyatt
When compositing is enabled, painting and hit testing end up using different
clipping roots, because, for painting, every composited layer is a clipping root,
but for hit testing only layers with transforms are. To fix this, we use
temporary clip rects for hit testing, if the page is in compositing mode.
- rendering/RenderLayer.cpp: (WebCore::RenderLayer::hitTestLayer):
- 1:46 PM Changeset in webkit [41950] by
-
- 2 edits in trunk/WebCore
2009-03-24 Simon Fraser <Simon Fraser>
Reviewed by Dan Bernstein
Fix regression with CSS clip rects with non-length values, by reverting to
the original code, but passing the zoom multiplier through convertToLength().
Also make stylistic change in createTransformOperations(), renaming 'inStyle'
to 'style.
Tested by existing tests.
- css/CSSStyleSelector.cpp: (WebCore::convertToLength): (WebCore::CSSStyleSelector::applyProperty): (WebCore::CSSStyleSelector::createTransformOperations):
- 1:29 PM Changeset in webkit [41949] by
-
- 2 edits in trunk/WebKit/win
2009-03-24 Brent Fulgham <bfulgham@webkit.org>
Reviewed by Adam Roben.
https://bugs.webkit.org/show_bug.cgi?id=24779
Conditionalize CFNetwork-specific code in WebView to permit
support for other network backends.
- WebView.cpp: (WebView::setCacheModel): Add CFNETWORK check around CFNetwork specific cache implementation. (updateSharedSettingsFromPreferencesIfNeeded): Add CFNETWORK check around use of CFHTTPCookie code.
- 1:23 PM Changeset in webkit [41948] by
-
- 3 edits4 adds in trunk
WebCore:
2009-03-24 David Hyatt <hyatt@apple.com>
Reviewed by Simon Fraser
https://bugs.webkit.org/show_bug.cgi?id=21789, overflow:hidden elements should clip their foreground contents
to a border-radius.
This patch makes non-self-painting overflow layers and control clips work with border-radius. RenderLayers
that should be clipped by overflow ancestors with border-radius are still broken.
Added fast/clip/overflow-border-radius-clip.html
- rendering/RenderBox.cpp: (WebCore::RenderBox::pushContentsClip):
LayoutTests:
2009-03-24 David Hyatt <hyatt@apple.com>
Reviewed by Simon Fraser
- fast/clip/overflow-border-radius-clip.html: Added.
- platform/mac/fast/clip/overflow-border-radius-clip-expected.checksum: Added.
- platform/mac/fast/clip/overflow-border-radius-clip-expected.png: Added.
- platform/mac/fast/clip/overflow-border-radius-clip-expected.txt: Added.
- 1:05 PM Changeset in webkit [41947] by
-
- 1 edit in trunk/WebCore/rendering/RenderReplaced.cpp
Fix stray ; that snuck in right before landing.
- 12:52 PM Changeset in webkit [41946] by
-
- 2 edits in trunk/JavaScriptCore
Reviewed by Darin Adler.
Explicitly define HAVE_LANGINFO_H on Darwin. Fixes the wx build bot jscore
test failure.
https://bugs.webkit.org/show_bug.cgi?id=24780
- 12:35 PM Changeset in webkit [41945] by
-
- 5 edits4 adds in trunk
WebCore:
2009-03-24 David Hyatt <hyatt@apple.com>
Reviewed by Simon Fraser
https://bugs.webkit.org/show_bug.cgi?id=21789, overflow:hidden elements should clip their foreground contents.
This first patch makes overflow:hidden properly clip the foreground contents of overflow:hidden replaced elements. Common
replaced elements now default to overflow:hidden in the UA stylesheet (this is what the spec specifically recommends be
done).
Added fast/replaced/border-radius-clip.html
- css/html4.css:
- rendering/RenderReplaced.cpp: (WebCore::RenderReplaced::paint):
- rendering/RenderWidget.cpp: (WebCore::RenderWidget::paint):
LayoutTests:
2009-03-24 David Hyatt <hyatt@apple.com>
Reviewed by Simon Fraser
- fast/replaced/border-radius-clip.html: Added.
- platform/mac/fast/replaced/border-radius-clip-expected.checksum: Added.
- platform/mac/fast/replaced/border-radius-clip-expected.png: Added.
- platform/mac/fast/replaced/border-radius-clip-expected.txt: Added.
- 11:25 AM Changeset in webkit [41944] by
-
- 3 edits in trunk/WebCore
2009-03-24 Adele Peterson <adele@apple.com>
RS by Mark Rowe.
Only build these Mail quirks checks in on the Mac.
- dom/Document.cpp: (WebCore::disableRangeMutation):
- html/HTMLElement.cpp: (WebCore::HTMLElement::inEitherTagList):
- 10:55 AM Changeset in webkit [41943] by
-
- 2 edits in trunk/WebCore
2009-03-24 Brent Fulgham <bfulgham@webkit.org>
Build fix, no review.
Remove ResourceLoaderCFNet.cpp from build list for Cairo Releas
and Debug targets.
- WebCore.vcproj/WebCore.vcproj:
- 10:36 AM Changeset in webkit [41942] by
-
- 9 edits in trunk
2009-03-24 Eric Carlson <eric.carlson@apple.com>
Update media tests broken by r41907.
- fast/dom/Window/window-properties-expected.txt:
- http/tests/media/video-play-stall-seek.html:
- http/tests/media/video-play-stall.html:
2009-03-24 Eric Carlson <eric.carlson@apple.com>
Fix layout tests broken by r41907.
- html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::setReadyState): Don't set "was playing" based on the new ready state
- 10:18 AM Changeset in webkit [41941] by
-
- 2 edits in trunk/WebCore
2009-03-24 Dmitry Titov <dimich@chromium.org>
Reviewed by Dimitri Glazkov.
https://bugs.webkit.org/show_bug.cgi?id=24689
Fix Chromium compilation errors.
- bindings/v8/WorkerContextExecutionProxy.cpp: (WebCore::WorkerContextExecutionProxy::FindOrCreateEventListener): (WebCore::WorkerContextExecutionProxy::RemoveEventListener):
- 10:08 AM Changeset in webkit [41940] by
-
- 2 edits in trunk/WebCore
2009-03-24 Yury Semikhatsky <yurys@chromium.org>
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=24759
Add missing methods Element.prototype.removeMatchingStyleClasses and
Node.prototype.enclosingNodeOrSelfWithNodeNameInArray to SourceFrame content
iframe. These methods are called by Element.prototype.removeStyleClass and
Node.prototype.enclosingNodeOrSelfWithNodeName.
- inspector/front-end/SourceFrame.js: (WebInspector.SourceFrame.prototype._loaded):
- 10:03 AM Changeset in webkit [41939] by
-
- 24 edits in trunk/WebCore
2009-03-24 Mark Mentovai <mark@chromium.org>
Reviewed by Mark Rowe.
https://bugs.webkit.org/show_bug.cgi?id=24653
WebKit should be buildable without prefix header injection.
Adds missing #includes and forward declarations as needed.
- editing/SmartReplaceCF.cpp:
- platform/graphics/mac/ColorMac.mm:
- platform/graphics/mac/FontCacheMac.mm:
- platform/graphics/mac/FontCustomPlatformData.h:
- platform/graphics/mac/FontMac.mm:
- platform/graphics/mac/FontMacATSUI.mm:
- platform/graphics/mac/FontPlatformData.h:
- platform/graphics/mac/FontPlatformDataMac.mm:
- platform/graphics/mac/GraphicsContextMac.mm:
- platform/graphics/mac/SimpleFontDataMac.mm:
- platform/mac/FoundationExtras.h:
- platform/mac/LocalCurrentGraphicsContext.h:
- platform/mac/WebCoreSystemInterface.h:
- platform/mac/WebCoreSystemInterface.mm:
- platform/mac/WebCoreTextRenderer.h:
- platform/mac/WebCoreTextRenderer.mm:
- platform/mac/WebFontCache.h:
- platform/mac/WebFontCache.mm:
- platform/text/PlatformString.h:
- platform/text/mac/ShapeArabic.c:
- platform/text/mac/StringMac.mm:
- rendering/RenderThemeChromiumMac.h:
- 9:24 AM Changeset in webkit [41938] by
-
- 4 edits3 adds in trunk
WebCore:
Reviewed by Darin Adler.
- fix <rdar://problem/6107874> by capping the nesting depth of "block-level" elements generated by the parser
Test: fast/parser/block-nesting-cap.html
- html/HTMLParser.cpp: (WebCore::HTMLParser::HTMLParser): (WebCore::HTMLParser::insertNode): (WebCore::HTMLParser::pushBlock): (WebCore::HTMLParser::popOneBlockCommon): (WebCore::HTMLParser::freeBlock):
- html/HTMLParser.h:
LayoutTests:
Reviewed by Darin Adler.
- test for <rdar://problem/6107874>
Test that the nesting depth of "block-level" elements generated by
the parser is capped
- fast/parser/block-nesting-cap-expected.txt: Added.
- fast/parser/block-nesting-cap.html: Added.
- fast/parser/resources/block-nesting-cap.js: Added.
- 12:50 AM Changeset in webkit [41937] by
-
- 2 edits in trunk/WebKit/mac
Reviewed by Oliver Hunt.
- speculative fix for <rdar://problem/6630134> Crash at Editor::compositionRange()
- WebView/WebHTMLView.mm: (-[WebHTMLView markedRange]): Null-check the Frame like most other methods in this class.
