⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Mar 29, 2009:

7:49 PM Changeset in webkit [42097] by Darin Adler
  • 2 edits in trunk/WebCore

2009-03-29 Darin Adler <Darin Adler>

Requested by Antti Koivisto.

  • loader/DocumentLoader.cpp: (WebCore::DocumentLoader::subresource): Tweaked code to be a little clearer and added a better comment.
7:21 PM Changeset in webkit [42096] by Darin Adler
  • 3 edits
    2 adds in trunk

WebCore:

2009-03-29 Darin Adler <Darin Adler>

Reviewed by Dan Bernstein.

Bug 23445: Copying certain hidden text causes a crash
​https://bugs.webkit.org/show_bug.cgi?id=23445
rdar://problem/6512520

Test: editing/pasteboard/copy-display-none.html

  • editing/markup.cpp: (WebCore::createMarkup): Added a check for the case where adjusting the start node moves the start of the selection past the end of the range entirely. If we try to iterate we'll never hit the end of the range and will probably crash iterating the rest of the document.

LayoutTests:

2009-03-29 Darin Adler <Darin Adler>

Reviewed by Dan Bernstein.

Bug 23445: Copying certain hidden text causes a crash
​https://bugs.webkit.org/show_bug.cgi?id=23445
rdar://problem/6512520

  • editing/pasteboard/copy-display-none-expected.txt: Added.
  • editing/pasteboard/copy-display-none.html: Added.
6:59 PM Changeset in webkit [42095] by Darin Adler
  • 3 edits in trunk/WebCore

2009-03-29 Darin Adler <Darin Adler>

Reviewed by Dan Bernstein.

Bug 24672: ASSERTION FAILURE: !m_purgeableData in WebCore::CachedResource::data() saving a WebArchive
​https://bugs.webkit.org/show_bug.cgi?id=24672
rdar://problem/6574263

I couldn't create a test case for this. In fact, the case in the bug doesn't exist any more,
but there is an Apple-internal website I was able to use to reproduce and fix.

  • loader/CachedResource.h: Made makePurgeable public.
  • loader/DocumentLoader.cpp: (WebCore::DocumentLoader::subresource): Call makePurgeable to make the resource non-purgeable so we can get its data if it hasn't yet been purged.
5:06 PM Changeset in webkit [42094] by Darin Adler
  • 2 edits in trunk/WebCore

2009-03-29 Darin Adler <Darin Adler>

Fix build again.

  • loader/EmptyClients.h: Fix typo in name of FormState.h.
4:53 PM Changeset in webkit [42093] by Darin Adler
  • 2 edits in trunk/WebCore

2009-03-29 Darin Adler <Darin Adler>

Try to fix the release build.

  • history/CachedPage.cpp: Make include unconditional, not debug-only.
4:51 PM Changeset in webkit [42092] by bolsinga@apple.com
  • 2 edits in trunk/WebCore

Undo the previous build fix.

4:44 PM Changeset in webkit [42091] by bolsinga@apple.com
  • 2 edits in trunk/WebCore

Fix build break.

4:29 PM Changeset in webkit [42090] by Darin Adler
  • 1 edit in trunk/WebCore/ChangeLog

Fix ChangeLog.

4:29 PM Changeset in webkit [42089] by Darin Adler
  • 3 edits in trunk/WebCore

2009-03-29 Dmitry Titov <​dimich@chromium.org>

Reviewed by Darin Adler.

​https://bugs.webkit.org/show_bug.cgi?id=24926
Fix Chromium build break.

  • bindings/v8/custom/V8DOMWindowCustom.cpp: (WebCore::CALLBACK_FUNC_DECL(DOMWindowShowModalDialog)): renamed 'features' into 'windowFeatures'.
4:26 PM Changeset in webkit [42088] by dimich@chromium.org
  • 2 edits in trunk/WebCore

2009-03-29 Dmitry Titov <​dimich@chromium.org>

Reviewed by Darin Adler.

​https://bugs.webkit.org/show_bug.cgi?id=24926
Fix Chromium build break.

  • bindings/v8/custom/V8DOMWindowCustom.cpp: (WebCore::CALLBACK_FUNC_DECL(DOMWindowShowModalDialog)): renamed 'features' into 'windowFeatures'.
11:09 AM Changeset in webkit [42087] by Darin Adler
  • 2 edits in trunk/WebCore

2009-03-29 Darin Adler <Darin Adler>

Another attempt to fix the Qt build.

  • WebCore.pro: Added CheckedRadioButtons.cpp.
11:00 AM Changeset in webkit [42086] by Darin Adler
  • 3 edits in trunk/WebKit/qt

2009-03-29 Darin Adler <Darin Adler>

Try to fix Qt build.

  • WebCoreSupport/EditorClientQt.cpp: Added include of HTMLElement.h.
  • WebCoreSupport/FrameLoaderClientQt.cpp: Added include of FormState.h. (WebCore::FrameLoaderClientQt::prepareForDataSourceReplacement): Removed unneeded call to detachChildren, which is called by FrameLoader right after this. (WebCore::FrameLoaderClientQt::createFrame): Use loadURLIntoChildFrame as other platforms do in the corresponding functions.
10:31 AM Changeset in webkit [42085] by Darin Adler
  • 2 edits in trunk/WebKitTools

2009-03-29 Darin Adler <Darin Adler>

  • DumpRenderTree/qt/jsobjects.cpp: Rolled out changes to this file. Maybe this will fix Qt building of DumpRenderTree.
10:15 AM Changeset in webkit [42084] by Darin Adler
  • 34 edits
    2 copies in trunk

WebCore:

2009-03-29 Darin Adler <Darin Adler>

Reviewed by Cameron Zwarich.

Bug 24921: remove include of HTMLFormElement.h from Document.h
​https://bugs.webkit.org/show_bug.cgi?id=24921

  • GNUmakefile.am: Added CheckedRadioButtons source files.
  • WebCore.scons: Ditto.
  • WebCore.vcproj/WebCore.vcproj: Ditto.
  • WebCore.xcodeproj/project.pbxproj: Ditto.
  • WebCoreSources.bkl: Ditto.
  • bindings/objc/PublicDOMInterfaces.h: Changed type of parentElement to Element.
  • dom/CheckedRadioButtons.cpp: Copied from WebCore/html/HTMLFormElement.cpp. Removed all the code except for CheckedRadioButtons, and moved that out to be a namespace-level class instead of a member of HTMLFormElement.
  • dom/CheckedRadioButtons.h: Copied from WebCore/html/HTMLFormElement.h. Removed all the code except for CheckedRadioButtons, and moved that out to be a namespace-level class instead of a member of HTMLFormElement.
  • dom/Document.h: Removed unneeded includes, including HTMLFormElement.h. Added include of CheckedRadioButtons.h. Changed uses of CheckedRadioButtons class to use a namespace-level class instead of a member of HTMLFormElement.
  • dom/Node.idl: Changed the type of parentElement from Node to Element for two reasons. 1) Node was incorrect, since parentElement returns an Element. 2) The bindings won't compile any more unless they know parentElement's return value is an Element due to include changes.
  • html/HTMLFormElement.cpp: Moved definitions of the functions in the CheckedRadioButtons class to the new CheckedRadioButtons.cpp.
  • html/HTMLFormElement.h: Moved definition of the CheckedRadioButtons class to the new CheckedRadioButtons.h.
  • html/HTMLInputElement.cpp: (WebCore::checkedRadioButtons): Changed use of CheckedRadioButtons class to use a namespace-level class instead of a member of HTMLFormElement.
  • page/Chrome.cpp: (WebCore::Chrome::createWindow): Tweaked formatting.
  • css/CSSGrammar.y: Added newly-needed include.
  • dom/Range.cpp: Ditto.
  • editing/BreakBlockquoteCommand.cpp: Ditto.
  • editing/CompositeEditCommand.cpp: Ditto.
  • editing/InsertLineBreakCommand.cpp: Ditto.
  • editing/ModifySelectionListLevel.cpp: Ditto.
  • editing/RemoveFormatCommand.cpp: Ditto.
  • editing/TextIterator.cpp: Ditto.
  • editing/VisiblePosition.cpp: Ditto.
  • loader/DocLoader.cpp: Ditto.
  • page/AccessibilityRenderObject.cpp: Ditto.
  • page/Page.cpp: Ditto.
  • rendering/RenderBlock.cpp: Ditto.
  • rendering/RenderLayer.cpp: Ditto.
  • rendering/RenderObject.h: Ditto.
  • storage/LocalStorageArea.cpp: Ditto.
  • storage/SessionStorageArea.cpp: Ditto.

WebKit/mac:

2009-03-29 Darin Adler <Darin Adler>

Reviewed by Cameron Zwarich.

  • Plugins/WebNullPluginView.mm: Added now-needed includes.
  • WebView/WebHTMLRepresentation.mm: Ditto.
  • WebView/WebHTMLView.mm: Ditto.
10:14 AM Changeset in webkit [42083] by Darin Adler
  • 2 edits in trunk/LayoutTests

2009-03-29 Darin Adler <Darin Adler>

Reviewed by Cameron Zwarich.

  • fast/forms/targeted-frame-submission.html: Fixes from review comments.
10:11 AM Changeset in webkit [42082] by Darin Adler
  • 22 edits in trunk

WebKitTools:

2009-03-29 Darin Adler <Darin Adler>

Reviewed by Cameron Zwarich.

Bug 24922: change WorkQueue-based navigation tests to not depend on synchronous form submission
​https://bugs.webkit.org/show_bug.cgi?id=24922

Don't rely on delegate methods to guess whether a queued step starts a load or not, because
script-triggered loads can't be detected that way. Instead have the steps themselves indicate
whether or not a load was triggered.

  • DumpRenderTree/LayoutTestController.cpp: (queueLoadingScriptCallback): Added. Version for scripts that perform loads. (queueNonLoadingScriptCallback): Added. Version for scripts that do not perform loads. (LayoutTestController::staticFunctions): Replaced queueScript with queueLoadingScript and queueNonLoadingScript. (LayoutTestController::queueBackNavigation): Moved here since it's platform-independent now. (LayoutTestController::queueForwardNavigation): Ditto. (LayoutTestController::queueLoadingScript): Replacement for queueScript. Here since it's platform-independent. (LayoutTestController::queueNonLoadingScript): Ditto. (LayoutTestController::queueReload): Moved here since it's platform-independent now.
  • DumpRenderTree/LayoutTestController.h: Ditto.
  • DumpRenderTree/WorkQueue.cpp: (WorkQueue::processWork): Added. Shared by the different platform's work queue implementations.
  • DumpRenderTree/WorkQueue.h: Ditto.
  • DumpRenderTree/WorkQueueItem.h: Changed the invoke function to return true if the item started a load. Removed unused getter functions. Made invoke functions private. Added LoadingScriptItem and NonLoadingScriptItem, making ScriptItem an abstract base.
  • DumpRenderTree/gtk/DumpRenderTree.cpp: (processWork): Use the new WorkQueue::processWork function to implement the new rule.
  • DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: Removed queue functions that are now platform-independent and in LayoutTestController.cpp.
  • DumpRenderTree/gtk/WorkQueueItemGtk.cpp: (LoadItem::invoke): Return true. (ReloadItem::invoke): Ditto. (ScriptItem::invoke): Ditto. (BackForwardItem::invoke): Ditto.
  • DumpRenderTree/mac/FrameLoadDelegate.mm: (-[FrameLoadDelegate processWork:]): Use the new WorkQueue::processWork function to implement the new rule.
  • DumpRenderTree/mac/LayoutTestControllerMac.mm: Removed queue functions that are now platform-independent and in LayoutTestController.cpp.
  • DumpRenderTree/mac/WorkQueueItemMac.mm: (LoadItem::invoke): Return true. (ReloadItem::invoke): Ditto. (ScriptItem::invoke): Ditto. (BackForwardItem::invoke): Ditto.
  • DumpRenderTree/qt/jsobjects.cpp: (LayoutTestController::processWork): Use the new WorkQueue::processWork function to implement the new rule. Removed queue functions that are now platform-independent and in LayoutTestController.cpp.
  • DumpRenderTree/win/FrameLoadDelegate.cpp: (FrameLoadDelegate::processWork): Use the new WorkQueue::processWork function to implement the new rule.
  • DumpRenderTree/win/LayoutTestControllerWin.cpp: Removed queue functions that are now platform-independent and in LayoutTestController.cpp.
  • DumpRenderTree/win/WorkQueueItemWin.cpp: (LoadItem::invoke): Return false when we fail, true when we succeed. (ReloadItem::invoke): Ditto. (ScriptItem::invoke): Ditto. (BackForwardItem::invoke): Ditto.

LayoutTests:

2009-03-29 Darin Adler <Darin Adler>

Reviewed by Cameron Zwarich.

Bug 24922: change WorkQueue-based navigation tests to not depend on synchronous form submission
​https://bugs.webkit.org/show_bug.cgi?id=24922

  • fast/forms/targeted-frame-submission.html: Changed test to wait until the subframe loads before moving on to the next test, using an onload attribute.
  • http/tests/navigation/fallback-anchor-reload.html: Removed use of queueScript here for a script that can instead just be run immedidately.
  • http/tests/navigation/onload-navigation-iframe-timeout.html: Changed test to wait until the subframe loads before moving on to the next test, using an onload attribute.
  • http/tests/navigation/onload-navigation-iframe.html: Ditto.
  • http/tests/navigation/resources/testcode.js: Use queueNonLoadingScript instead of queueScript for scripts that don't involve submitting a form. Use queueLoadingScript for scripts that do involve submitting a form.
8:37 AM Changeset in webkit [42081] by Darin Adler
  • 4 edits
    2 adds in trunk

WebCore:

2009-03-29 Darin Adler <Darin Adler>

Reviewed by Dan Bernstein.

<rdar://problem/6015407> attr parsing should allow only identifiers

Test: fast/css/attr-parsing.html

  • css/CSSParser.cpp: (WebCore::CSSParser::parseContent): Allow only CSS_IDENT, and filter out identifiers that start with "-".
  • css/CSSPrimitiveValue.cpp: (WebCore::CSSPrimitiveValue::cssText): Added a case for CSS_ATTR so the test case works. This has the pleasant side effect of fixing a bug too.

LayoutTests:

2009-03-29 Darin Adler <Darin Adler>

Reviewed by Dan Bernstein.

<rdar://problem/6015407> attr parsing should allow only identifiers

  • fast/css/attr-parsing-expected.txt: Added.
  • fast/css/attr-parsing.html: Added.
8:17 AM Changeset in webkit [42080] by Darin Adler
  • 1 edit
    4 adds in trunk/LayoutTests

2009-03-29 Darin Adler <Darin Adler>

Bug 12104: Native Slider: When the thumb's height is specified as a percentage, it is not centered properly
​https://bugs.webkit.org/show_bug.cgi?id=12104

Landed the test case from this bug. The bug was fixed by the fix for bug 24740 below.

  • fast/forms/range-thumb-height-percentage.html: Added.
  • platform/mac/fast/forms/range-thumb-height-percentage-expected.checksum: Added.
  • platform/mac/fast/forms/range-thumb-height-percentage-expected.png: Added.
  • platform/mac/fast/forms/range-thumb-height-percentage-expected.txt: Added.
2:45 AM Changeset in webkit [42079] by ap@webkit.org
  • 2 edits in trunk/WebCore

<rdar://problem/6492712> Cross-origin redirects are not handled correctly.

Forgot to save the file after applying changes for review comments.

2:16 AM Changeset in webkit [42078] by ap@webkit.org
  • 5 edits
    4 adds in trunk

Reviewed by Darin Adler.

<rdar://problem/6492712> Cross-origin redirects are not handled correctly.

Test: http/tests/xmlhttprequest/redirect-cross-origin-tripmine.html

  • platform/network/cf/ResourceHandleCFNet.cpp: (WebCore::WebCoreSynchronousLoader::WebCoreSynchronousLoader): (WebCore::ResourceHandle::loadResourceSynchronously): (WebCore::WebCoreSynchronousLoader::willSendRequest): (WebCore::WebCoreSynchronousLoader::didReceiveResponse): (WebCore::WebCoreSynchronousLoader::didReceiveData): (WebCore::WebCoreSynchronousLoader::didFinishLoading): (WebCore::WebCoreSynchronousLoader::didFail): (WebCore::WebCoreSynchronousLoader::didReceiveChallenge): (WebCore::WebCoreSynchronousLoader::load): Match Mac behavior more closely - we shouldn't rely on underlying library handling of synchronous requests.
  • loader/DocumentThreadableLoader.cpp: (WebCore::DocumentThreadableLoader::willSendRequest): -[NSURLConnection cancel] doesn't fully cancel the connection if called from willSendRequest delegate method for a redirect.
  • platform/network/mac/ResourceHandleMac.mm: (-[WebCoreSynchronousLoader connection:willSendRequest:redirectResponse:]): Match async behavior more closely.

Mar 28, 2009:

10:27 PM Changeset in webkit [42077] by kevino@webkit.org
  • 2 edits in trunk/WebKitTools

Always use wxGraphicsContext on Mac to ensure path, matrix, etc. support.

5:16 PM Changeset in webkit [42076] by Darin Adler
  • 2 edits in trunk/WebCore

2009-03-28 Darin Adler <Darin Adler>

Reviewed by Mark Rowe.

Bug 24914: empty-string assertion crash when running storage tests
​https://bugs.webkit.org/show_bug.cgi?id=24914

  • storage/Database.cpp: (WebCore::Database::performOpenAndVerify): Don't store empty version strings in the map, since empty strings are per-thread.
2:16 PM Changeset in webkit [42075] by xan@webkit.org
  • 2 edits in trunk/WebKit/gtk

2009-03-28 Xan Lopez <​xlopez@igalia.com>

Reviewed by Mark Rowe.

​https://bugs.webkit.org/show_bug.cgi?id=24790
[GTK] webkitsoupauthdialog.h lacks WEBKIT_API before function

Set the right visibility to the WebKitSoupAuthDialog get_type
function.

  • webkit/webkitsoupauthdialog.h:
1:17 PM Changeset in webkit [42074] by kevino@webkit.org
  • 2 edits in trunk/WebKit/wx

wx build fix. Remove call to now private method.

11:43 AM Changeset in webkit [42073] by dimich@chromium.org
  • 4 edits in trunk/WebCore

2009-03-28 Dmitry Titov <​dimich@chromium.org>

Reviewed by Dimitri Glazkov.

​https://bugs.webkit.org/show_bug.cgi?id=24910
Fixes for Chromium build.

  • bindings/v8/V8LazyEventListener.h: renamed IsInline() into virtualIsInline()
  • bindings/v8/custom/V8CustomEventListener.h: ditto.
  • dom/EventListener.h: used #if USE(JSC) to fix the build on non-JSC platform.
9:59 AM Changeset in webkit [42072] by Dimitri Glazkov
  • 2 edits
    1 delete in trunk/WebCore

2009-03-28 Dimitri Glazkov <Dimitri Glazkov>

Not reviewed, correcting landing error.

​https://bugs.webkit.org/show_bug.cgi?id=24812
Custom bindings should be in v8/custom, not v8.

  • bindings/v8/V8HTMLDocumentCustom.cpp: Removed.
  • bindings/v8/custom/V8HTMLDocumentCustom.cpp: Moved from parent dir.
9:48 AM Changeset in webkit [42071] by Dimitri Glazkov
  • 1 edit
    1 add in trunk/WebCore

2009-03-28 Mike Belshe <​mike@belshe.com>

Reviewed by Dimitri Glazkov.

​https://bugs.webkit.org/show_bug.cgi?id=24616
Add V8 custom bindings for DOMWindow.

  • bindings/v8/custom/V8DOMWindowCustom.cpp: Added.
9:24 AM Changeset in webkit [42070] by Dimitri Glazkov
  • 1 edit
    1 add in trunk/WebCore

2009-03-28 Mike Belshe <​mike@belshe.com>

Reviewed by Dimitri Glazkov.

​https://bugs.webkit.org/show_bug.cgi?id=24812
Add V8 custom bindings for HTMLDocument.

  • bindings/v8/V8HTMLDocumentCustom.cpp: Added.
1:55 AM Changeset in webkit [42069] by jmalonzo@webkit.org
  • 3 edits in trunk/WebKit/gtk

2009-03-28 Jan Michael Alonzo <​jmalonzo@webkit.org>

Gtk build fix. Not reviewed.

FrameLoader::loadURL and FrameLoader::detachChildren went private
per changes in ​http://trac.webkit.org/changeset/42055. Follow
Mac's behaviour and use FrameLoader::loadURLIntoChildFrame for
loadURL and FrameLoader::detachParent for detachChildrem.

  • WebCoreSupport/FrameLoaderClientGtk.cpp: (WebKit::FrameLoaderClient::createFrame):
  • webkit/webkitwebview.cpp:
Note: See TracTimeline for information about the timeline view.