Context Navigation

Integrate gtk-doc into our buildsystem. We are forced to
use recursive make for gtk-doc itself as the to be installed
gtk-doc.make (done by gtkdocize) is not working in a non
recursive environment.

The documentation can only be generated when srcdir == builddir.
In all other cases the generated files will not be found. This
limitation can be found in pango and gtk+ as well. There is no
easy way around. The resulting html documentation will be saved
in the srcdir as well.

docs/GNUmakefile.am: Added.
docs/version.xml.in: Added.
docs/webkitgtk-docs.sgml:

7:37 PM Changeset in webkit [42122] by kevino@webkit.org

7 edits in trunk/WebKit/wx

Reviewed by Kevin Ollivier.

Add events to allow apps to override handling for JS prompts and
window object cleared events.

https://bugs.webkit.org/show_bug.cgi?id=24948

7:29 PM Changeset in webkit [42121] by sfalken@apple.com

2 edits in trunk/WebCore

Don't create CFDataRef with a fixed size.
Fixes synchronous XMLHTTPRequests on Windows.

Reviewed by Ada Chan.

platform/network/cf/ResourceHandleCFNet.cpp: (WebCore::WebCoreSynchronousLoader::didReceiveData):

5:19 PM Changeset in webkit [42120] by Darin Adler

4 edits
2 adds in trunk

WebCore:

2009-03-30 Darin Adler <Darin Adler>

Reviewed by Sam Weinig.

Bug 24594: PolicyDelegate NavigationAction is WebNavigationTypeOther instead of WebNavigationTypeReload
https://bugs.webkit.org/show_bug.cgi?id=24594
rdar://problem/6682110

Test: fast/loader/reload-policy-delegate.html

loader/FrameLoader.cpp: (WebCore::FrameLoader::loadWithDocumentLoader): Set the triggering action here where we know it's the policy loader and can use m_policyLoadType rather than letting it get set inside checkNavigationPolicy.

LayoutTests:

2009-03-30 Darin Adler <Darin Adler>

Reviewed by Sam Weinig.

Bug 24594: PolicyDelegate NavigationAction is WebNavigationTypeOther instead of WebNavigationTypeReload
https://bugs.webkit.org/show_bug.cgi?id=24594
rdar://problem/6682110

fast/frames/resources/iframe-focus.html: Removed bogus but harmless "layoutTestController.loadCount" code.

fast/loader/reload-policy-delegate-expected.txt: Added.
fast/loader/reload-policy-delegate.html: Added.

5:17 PM Changeset in webkit [42119] by Darin Adler

3 edits in trunk/WebKitTools

2009-03-30 Darin Adler <Darin Adler>

Reviewed by Sam Weinig.

Make policy-delegate logging work even for local files by processing the URLs as we
do for other delegates.

DumpRenderTree/mac/PolicyDelegate.mm: (-[PolicyDelegate webView:decidePolicyForNavigationAction:request:frame:decisionListener:]): Use _drt_descriptionSuitableForTestResult on the URL.

DumpRenderTree/win/PolicyDelegate.cpp: (PolicyDelegate::decidePolicyForNavigationAction): Use urlSuitableForTestResult on the URL.

3:49 PM Changeset in webkit [42118] by timothy@apple.com

2 edits in trunk/WebCore

<rdar://problem/5838871> CrashTracer: 1483 crashes Quicklooking
in Finder (painting without up to date layout)

Reviewed by Dan Bernstein.

page/FrameView.cpp: (WebCore::FrameView::paintContents): Add an early return when painting is attempted when layout is needed.

1:14 PM Changeset in webkit [42117] by kov@webkit.org

1 copy in releases/WebKitGTK/webkit-1.1.4

Tagging WebKitGTK+ 1.1.4.

12:59 PM Changeset in webkit [42116] by bolsinga@apple.com

2 edits in trunk/WebCore

2009-03-30 Greg Bolsinga <bolsinga@apple.com>

Reviewed by Simon Fraser.

https://bugs.webkit.org/show_bug.cgi?id=24938

Sort alphabetically.

css/CSSComputedStyleDeclaration.cpp: (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):

11:33 AM Changeset in webkit [42115] by bolsinga@apple.com

2 edits in trunk/WebCore

2009-03-30 Greg Bolsinga <bolsinga@apple.com>

Reviewed by Simon Fraser.

https://bugs.webkit.org/show_bug.cgi?id=24938

Build fixes for building --3d-rendering and --no-svg

rendering/RenderLayerBacking.cpp:

11:27 AM Changeset in webkit [42114] by sfalken@apple.com

2 edits in trunk/WebKitLibraries

2009-03-30 Steve Falkenburg <sfalken@apple.com>

Bump version to 530.

win/tools/scripts/VERSION:

11:21 AM Changeset in webkit [42113] by kov@webkit.org

2 edits in trunk/WebKit/gtk

2009-03-30 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>

Unreviewed. Documenting what changed since the 1.1.3 release, in
the GTK+ port.

NEWS:

11:04 AM Changeset in webkit [42112] by bolsinga@apple.com

10 edits in trunk

2009-03-30 Greg Bolsinga <bolsinga@apple.com>

Reviewed by Simon Fraser.

https://bugs.webkit.org/show_bug.cgi?id=24938

Build fixes when building --no-svg

css/CSSComputedStyleDeclaration.cpp: (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue): Add missing CSS properties
css/CSSCursorImageValue.cpp: (WebCore::CSSCursorImageValue::updateIfSVGCursorIsUsed): Handle unused param
css/CSSParser.cpp: (WebCore::CSSParser::parseValue): Add missing CSS properties
css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::applyProperty): Add missing CSS properties
dom/Node.cpp: (WebCore::updateSVGElementInstancesAfterEventListenerChange): Handle unused param
platform/graphics/Font.cpp: (WebCore::Font::floatWidth): Handle unused param
platform/graphics/SimpleFontData.cpp: (WebCore::SimpleFontData::SimpleFontData): Handle unused param

2009-03-30 Greg Bolsinga <bolsinga@apple.com>

Reviewed by Simon Fraser.

https://bugs.webkit.org/show_bug.cgi?id=24938

Build fixes when building --no-svg

DOMHTMLFrameElementPrivate.h and DOMHTMLIFrameElementPrivate.h are only available with ENABLE_SVG.

MigrateHeaders.make:

10:46 AM Changeset in webkit [42111] by xan@webkit.org

2 edits in trunk

2009-03-30 Xan Lopez <xlopez@igalia.com>

Unreviewed: bump version to 1.1.4 for release.

configure.ac:

10:41 AM Changeset in webkit [42110] by kov@webkit.org

2 edits in trunk/WebKit/gtk

2009-03-30 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>

Unreviewed. Add information on the bug-fix-only 1.1.3 release.

NEWS:

10:37 AM Changeset in webkit [42109] by Adam Roben

3 edits in trunk/WebKitTools

Windows build fix

DumpRenderTree/win/LayoutTestControllerWin.cpp: (LayoutTestController::waitForPolicyDelegate): Added this empty stub.

DumpRenderTree/win/WorkQueueItemWin.cpp: (LoadItem::invoke): (ScriptItem::invoke): Changed to use data members instead of removed member functions.

10:26 AM Changeset in webkit [42108] by Darin Adler

2 edits in trunk/WebCore

2009-03-30 Darin Adler <Darin Adler>

Reviewed by Adam Roben.

Bug 24916: REGRESSION: NavigationAction policy dispatch broken
https://bugs.webkit.org/show_bug.cgi?id=24916

loader/FrameLoader.cpp: (WebCore::FrameLoader::loadURL): Rearrange the code so that the "event" PassRefPtr is not used twice. This also optimizes the case where a frame name is specified, but it's the name of the frame being loaded. Also called release in all the final uses of FormState.

10:22 AM Changeset in webkit [42107] by Darin Adler

24 edits in trunk/WebCore

2009-03-30 Darin Adler <Darin Adler>

Reviewed by Adam Roben.

Bug 24937: NamedNodeMap and NamedAttrMap should not be separate classes
https://bugs.webkit.org/show_bug.cgi?id=24937

Also should fix the Windows COM bindings build.

bindings/scripts/CodeGeneratorJS.pm: Removed special case for NamedNodeMap.
bindings/scripts/CodeGeneratorObjC.pm: Ditto.

dom/NamedAttrMap.h: Renamed class from NamedAttrMap to NamedNodeMap and removed NamedNodeMap base class. Made the NamedNodeMap functions all public and non-virtual. Removed virtualLength.

dom/NamedNodeMap.h: Replaced file with just an include of NamedAttrMap.h. As a follow up we will rename the NamedAttrMap files and remove this file.

bindings/js/JSNamedNodesCollection.cpp: Renamed from NamedAttrMap to NamedNodeMap.
dom/Attr.h: Ditto.
dom/Attribute.h: Ditto.
dom/Document.cpp: (WebCore::Document::importNode): Ditto.
dom/Element.cpp: (WebCore::Element::attributes): Ditto. (WebCore::Element::setAttributeMap): Ditto. (WebCore::Element::createAttributeMap): Ditto. (WebCore::Element::insertedIntoDocument): Ditto. (WebCore::Element::removedFromDocument): Ditto. (WebCore::Element::openTagStartToString): Ditto. (WebCore::Element::removeAttributeNode): Ditto. (WebCore::Element::getAttributeNode): Ditto. (WebCore::Element::getAttributeNodeNS): Ditto. (WebCore::Element::hasAttribute): Ditto. (WebCore::Element::hasAttributeNS): Ditto. (WebCore::Element::normalizeAttributes): Ditto.
dom/Element.h: Ditto.
dom/NamedAttrMap.cpp: (WebCore::NamedNodeMap::detachAttributesFromElement): Ditto. (WebCore::NamedNodeMap::~NamedNodeMap): Ditto. (WebCore::NamedNodeMap::isMappedAttributeMap): Ditto. (WebCore::NamedNodeMap::getNamedItem): Ditto. (WebCore::NamedNodeMap::getNamedItemNS): Ditto. (WebCore::NamedNodeMap::removeNamedItem): Ditto. (WebCore::NamedNodeMap::removeNamedItemNS): Ditto. (WebCore::NamedNodeMap::setNamedItem): Ditto. (WebCore::NamedNodeMap::item): Ditto. (WebCore::NamedNodeMap::getAttributeItem): Ditto. (WebCore::NamedNodeMap::clearAttributes): Ditto. (WebCore::NamedNodeMap::detachFromElement): Ditto. (WebCore::NamedNodeMap::setAttributes): Ditto. (WebCore::NamedNodeMap::addAttribute): Ditto. (WebCore::NamedNodeMap::removeAttribute): Ditto. (WebCore::NamedNodeMap::mapsEquivalent): Ditto.
dom/NamedMappedAttrMap.cpp: (WebCore::NamedMappedAttrMap::clearAttributes): Ditto.
dom/NamedMappedAttrMap.h: (WebCore::NamedMappedAttrMap::NamedMappedAttrMap): Ditto.
dom/Node.cpp: (WebCore::Node::dumpStatistics): Ditto. (WebCore::Node::isEqualNode): Ditto. (WebCore::Node::isDefaultNamespace): Ditto. (WebCore::Node::lookupNamespaceURI): Ditto. (WebCore::Node::lookupNamespacePrefix): Ditto. (WebCore::Node::compareDocumentPosition): Ditto.
dom/Node.h: Ditto.
dom/XMLTokenizerLibxml2.cpp: (WebCore::XMLTokenizer::XMLTokenizer): Ditto.
editing/ApplyStyleCommand.cpp: (WebCore::isSpanWithoutAttributesOrUnstyleStyleSpan): Ditto. (WebCore::isEmptyFontTag): Ditto. (WebCore::areIdenticalElements): Ditto.
editing/markup.cpp: (WebCore::appendStartMarkup): Ditto. (WebCore::completeURLs): Ditto.
html/HTMLParser.cpp: (WebCore::HTMLParser::handleError): Ditto.
rendering/RenderPartObject.cpp: (WebCore::RenderPartObject::updateWidget): Ditto.
svg/SVGAnimatedProperty.h: (WebCore::synchronizeProperty): Ditto.
xml/XPathFunctions.cpp: (WebCore::XPath::FunLang::evaluate): Ditto.
xml/XPathStep.cpp: (WebCore::XPath::Step::nodesInAxis): Ditto.

9:35 AM Changeset in webkit [42106] by kov@webkit.org

2 edits in trunk/WebCore

2009-03-30 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>

Reviewed by Holger Freyther.

https://bugs.webkit.org/show_bug.cgi?id=24750
[GTK] requests download instead of displaying page

Use soup facilities to append parameters to the content type, to
make that more robust;

platform/network/soup/ResourceHandleSoup.cpp: (WebCore::fillResponseFromMessage):

9:24 AM Changeset in webkit [42105] by ddkilzer@apple.com

4 edits in trunk/WebCore

<rdar://problem/6735683> Move SECTORDER_FLAGS from Xcode project to WebCore.xcconfig

Reviewed by Timothy Hatcher, Mark Rowe and Darin Adler.

Configurations/Base.xcconfig: Moved Production definition of SECTORDER_FLAGS to here from Xcode project file.
Configurations/DebugRelease.xcconfig: Override SECTORDER_FLAGS in Base.xcconfig to the empty string since it is not used for Debug and Release configurations.
WebCore.xcodeproj/project.pbxproj: Removed SECTORDER_FLAGS.

8:58 AM Changeset in webkit [42104] by Adam Roben

4 edits in trunk/WebKit/win

Build fixes after recent FrameLoader changes

WebCoreSupport/WebContextMenuClient.cpp: (WebContextMenuClient::searchWithGoogle): Updated to match urlSelected's current signature. We pass true for the userGesture parameter, since the user must have selected this item from the context menu.

WebCoreSupport/WebFrameLoaderClient.cpp: Removed loadURLIntoChildFrame. (WebFrameLoaderClient::createFrame): Changed to call FrameLoader::loadURLIntoChildFrame. This probably should have been done way back around r31281 when that function was added.

WebCoreSupport/WebFrameLoaderClient.h: Removed loadURLIntoChildFrame.

8:58 AM Changeset in webkit [42103] by Adam Roben

2 edits in trunk/WebCore

Windows build fix after recent Node.idl changes

bindings/scripts/CodeGeneratorCOM.pm: Touched this to force sources of classes that derive from Node to rebuild.

8:48 AM Changeset in webkit [42102] by xan@webkit.org

4 edits in trunk/WebKit/gtk

2009-03-30 Xan Lopez <xlopez@igalia.com>

Reviewed by Holger Freyther.

https://bugs.webkit.org/show_bug.cgi?id=24878
[GTK] Use GtkBinding system to handle key events in WebView

Use GtkBinding system for key events in WebKitWebView. Allows the
user to reconfigure the bindings and fixes a bunch of bugs along
the way (we were not checking modifier keys in most actions).

webkit/webkitwebview.cpp: (webkit_web_view_move_cursor):
webkit/webkitwebview.h:
webkitmarshal.list:

8:22 AM Changeset in webkit [42101] by Adam Roben

2 edits in trunk/WebCore

Windows build fix

svg/graphics/SVGImage.cpp: Added a missing #include.

7:49 AM Changeset in webkit [42100] by Dimitri Glazkov

7 edits in trunk/WebCore

2009-03-30 Mads Ager <ager@chromium.org>

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=24879
Add frame accessor to Screen, Console, and BarInfo objects. Add type
accessor to BarInfo objects.

In the V8 JavaScript bindings, we need access to the frame and
type for already created Screen, Console, and BarInfo objects in
order to keep their wrappers alive across GCs.

page/BarInfo.cpp: (WebCore::BarInfo::frame): Added. (WebCore::BarInfo::type): Added.
page/BarInfo.h:
page/Console.cpp: (WebCore::Console::frame): Added.
page/Console.h:
page/Screen.cpp: (WebCore::Screen::frame): Added.
page/Screen.h:

5:21 AM QtWebKitJournal edited by Simon Hausmann

(diff)

2:25 AM Changeset in webkit [42099] by Simon Hausmann

3 edits in trunk/WebKit/qt

Document that setHtml/setContent loads only the html/data immediately, not external objects.
2009-03-30 Simon Hausmann <simon.hausmann@nokia.com>

Rubber-stamped by Tor Arne Vestbø.

Document that setHtml/setContent loads only the html/data immediately, not external objects.

2:13 AM Changeset in webkit [42098] by jmalonzo@webkit.org

2 edits in trunk/WebKitTools

2009-03-30 Jan Michael Alonzo <jmalonzo@webkit.org>

Gtk DRT build fix per changeset
http://trac.webkit.org/changeset/42082. Not reviewed.

DumpRenderTree/gtk/WorkQueueItemGtk.cpp: (LoadItem::invoke): (ScriptItem::invoke):

Mar 29, 2009:

7:49 PM Changeset in webkit [42097] by Darin Adler

2 edits in trunk/WebCore

2009-03-29 Darin Adler <Darin Adler>

Requested by Antti Koivisto.

loader/DocumentLoader.cpp: (WebCore::DocumentLoader::subresource): Tweaked code to be a little clearer and added a better comment.

7:21 PM Changeset in webkit [42096] by Darin Adler

3 edits
2 adds in trunk

WebCore:

2009-03-29 Darin Adler <Darin Adler>

Reviewed by Dan Bernstein.

Bug 23445: Copying certain hidden text causes a crash
https://bugs.webkit.org/show_bug.cgi?id=23445
rdar://problem/6512520

Test: editing/pasteboard/copy-display-none.html

editing/markup.cpp: (WebCore::createMarkup): Added a check for the case where adjusting the start node moves the start of the selection past the end of the range entirely. If we try to iterate we'll never hit the end of the range and will probably crash iterating the rest of the document.

LayoutTests:

2009-03-29 Darin Adler <Darin Adler>

Reviewed by Dan Bernstein.

Bug 23445: Copying certain hidden text causes a crash
https://bugs.webkit.org/show_bug.cgi?id=23445
rdar://problem/6512520

editing/pasteboard/copy-display-none-expected.txt: Added.
editing/pasteboard/copy-display-none.html: Added.

6:59 PM Changeset in webkit [42095] by Darin Adler

3 edits in trunk/WebCore

2009-03-29 Darin Adler <Darin Adler>

Reviewed by Dan Bernstein.

Bug 24672: ASSERTION FAILURE: !m_purgeableData in WebCore::CachedResource::data() saving a WebArchive
https://bugs.webkit.org/show_bug.cgi?id=24672
rdar://problem/6574263

I couldn't create a test case for this. In fact, the case in the bug doesn't exist any more,
but there is an Apple-internal website I was able to use to reproduce and fix.

loader/CachedResource.h: Made makePurgeable public.
loader/DocumentLoader.cpp: (WebCore::DocumentLoader::subresource): Call makePurgeable to make the resource non-purgeable so we can get its data if it hasn't yet been purged.

5:06 PM Changeset in webkit [42094] by Darin Adler

2 edits in trunk/WebCore

2009-03-29 Darin Adler <Darin Adler>

Fix build again.

loader/EmptyClients.h: Fix typo in name of FormState.h.

4:53 PM Changeset in webkit [42093] by Darin Adler

2 edits in trunk/WebCore

2009-03-29 Darin Adler <Darin Adler>

Try to fix the release build.

history/CachedPage.cpp: Make include unconditional, not debug-only.

4:51 PM Changeset in webkit [42092] by bolsinga@apple.com

2 edits in trunk/WebCore

Undo the previous build fix.

4:44 PM Changeset in webkit [42091] by bolsinga@apple.com

2 edits in trunk/WebCore

Fix build break.

4:29 PM Changeset in webkit [42090] by Darin Adler

1 edit in trunk/WebCore/ChangeLog

Fix ChangeLog.

4:29 PM Changeset in webkit [42089] by Darin Adler

3 edits in trunk/WebCore

2009-03-29 Dmitry Titov <dimich@chromium.org>

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=24926
Fix Chromium build break.

bindings/v8/custom/V8DOMWindowCustom.cpp: (WebCore::CALLBACK_FUNC_DECL(DOMWindowShowModalDialog)): renamed 'features' into 'windowFeatures'.

4:26 PM Changeset in webkit [42088] by dimich@chromium.org

2 edits in trunk/WebCore

2009-03-29 Dmitry Titov <dimich@chromium.org>

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=24926
Fix Chromium build break.

bindings/v8/custom/V8DOMWindowCustom.cpp: (WebCore::CALLBACK_FUNC_DECL(DOMWindowShowModalDialog)): renamed 'features' into 'windowFeatures'.

11:09 AM Changeset in webkit [42087] by Darin Adler

2 edits in trunk/WebCore

2009-03-29 Darin Adler <Darin Adler>

Another attempt to fix the Qt build.

WebCore.pro: Added CheckedRadioButtons.cpp.

11:00 AM Changeset in webkit [42086] by Darin Adler

3 edits in trunk/WebKit/qt

2009-03-29 Darin Adler <Darin Adler>

Try to fix Qt build.

WebCoreSupport/EditorClientQt.cpp: Added include of HTMLElement.h.

WebCoreSupport/FrameLoaderClientQt.cpp: Added include of FormState.h. (WebCore::FrameLoaderClientQt::prepareForDataSourceReplacement): Removed unneeded call to detachChildren, which is called by FrameLoader right after this. (WebCore::FrameLoaderClientQt::createFrame): Use loadURLIntoChildFrame as other platforms do in the corresponding functions.

10:31 AM Changeset in webkit [42085] by Darin Adler

2 edits in trunk/WebKitTools

2009-03-29 Darin Adler <Darin Adler>

DumpRenderTree/qt/jsobjects.cpp: Rolled out changes to this file. Maybe this will fix Qt building of DumpRenderTree.

10:15 AM Changeset in webkit [42084] by Darin Adler

34 edits
2 copies in trunk

WebCore:

2009-03-29 Darin Adler <Darin Adler>

Reviewed by Cameron Zwarich.

Bug 24921: remove include of HTMLFormElement.h from Document.h
https://bugs.webkit.org/show_bug.cgi?id=24921

GNUmakefile.am: Added CheckedRadioButtons source files.
WebCore.scons: Ditto.
WebCore.vcproj/WebCore.vcproj: Ditto.
WebCore.xcodeproj/project.pbxproj: Ditto.
WebCoreSources.bkl: Ditto.

bindings/objc/PublicDOMInterfaces.h: Changed type of parentElement to Element.

dom/CheckedRadioButtons.cpp: Copied from WebCore/html/HTMLFormElement.cpp. Removed all the code except for CheckedRadioButtons, and moved that out to be a namespace-level class instead of a member of HTMLFormElement.

dom/CheckedRadioButtons.h: Copied from WebCore/html/HTMLFormElement.h. Removed all the code except for CheckedRadioButtons, and moved that out to be a namespace-level class instead of a member of HTMLFormElement.

dom/Document.h: Removed unneeded includes, including HTMLFormElement.h. Added include of CheckedRadioButtons.h. Changed uses of CheckedRadioButtons class to use a namespace-level class instead of a member of HTMLFormElement.

dom/Node.idl: Changed the type of parentElement from Node to Element for two reasons. 1) Node was incorrect, since parentElement returns an Element. 2) The bindings won't compile any more unless they know parentElement's return value is an Element due to include changes.

html/HTMLFormElement.cpp: Moved definitions of the functions in the CheckedRadioButtons class to the new CheckedRadioButtons.cpp.

html/HTMLFormElement.h: Moved definition of the CheckedRadioButtons class to the new CheckedRadioButtons.h.

html/HTMLInputElement.cpp: (WebCore::checkedRadioButtons): Changed use of CheckedRadioButtons class to use a namespace-level class instead of a member of HTMLFormElement.

page/Chrome.cpp: (WebCore::Chrome::createWindow): Tweaked formatting.

css/CSSGrammar.y: Added newly-needed include.
dom/Range.cpp: Ditto.
editing/BreakBlockquoteCommand.cpp: Ditto.
editing/CompositeEditCommand.cpp: Ditto.
editing/InsertLineBreakCommand.cpp: Ditto.
editing/ModifySelectionListLevel.cpp: Ditto.
editing/RemoveFormatCommand.cpp: Ditto.
editing/TextIterator.cpp: Ditto.
editing/VisiblePosition.cpp: Ditto.
loader/DocLoader.cpp: Ditto.
page/AccessibilityRenderObject.cpp: Ditto.
page/Page.cpp: Ditto.
rendering/RenderBlock.cpp: Ditto.
rendering/RenderLayer.cpp: Ditto.
rendering/RenderObject.h: Ditto.
storage/LocalStorageArea.cpp: Ditto.
storage/SessionStorageArea.cpp: Ditto.

WebKit/mac:

2009-03-29 Darin Adler <Darin Adler>

Reviewed by Cameron Zwarich.

Plugins/WebNullPluginView.mm: Added now-needed includes.
WebView/WebHTMLRepresentation.mm: Ditto.
WebView/WebHTMLView.mm: Ditto.

10:14 AM Changeset in webkit [42083] by Darin Adler

2 edits in trunk/LayoutTests

2009-03-29 Darin Adler <Darin Adler>

Reviewed by Cameron Zwarich.

fast/forms/targeted-frame-submission.html: Fixes from review comments.

10:11 AM Changeset in webkit [42082] by Darin Adler

22 edits in trunk

WebKitTools:

2009-03-29 Darin Adler <Darin Adler>

Reviewed by Cameron Zwarich.

Bug 24922: change WorkQueue-based navigation tests to not depend on synchronous form submission
https://bugs.webkit.org/show_bug.cgi?id=24922

Don't rely on delegate methods to guess whether a queued step starts a load or not, because
script-triggered loads can't be detected that way. Instead have the steps themselves indicate
whether or not a load was triggered.

DumpRenderTree/LayoutTestController.cpp: (queueLoadingScriptCallback): Added. Version for scripts that perform loads. (queueNonLoadingScriptCallback): Added. Version for scripts that do not perform loads. (LayoutTestController::staticFunctions): Replaced queueScript with queueLoadingScript and queueNonLoadingScript. (LayoutTestController::queueBackNavigation): Moved here since it's platform-independent now. (LayoutTestController::queueForwardNavigation): Ditto. (LayoutTestController::queueLoadingScript): Replacement for queueScript. Here since it's platform-independent. (LayoutTestController::queueNonLoadingScript): Ditto. (LayoutTestController::queueReload): Moved here since it's platform-independent now.
DumpRenderTree/LayoutTestController.h: Ditto.

DumpRenderTree/WorkQueue.cpp: (WorkQueue::processWork): Added. Shared by the different platform's work queue implementations.
DumpRenderTree/WorkQueue.h: Ditto.

DumpRenderTree/WorkQueueItem.h: Changed the invoke function to return true if the item started a load. Removed unused getter functions. Made invoke functions private. Added LoadingScriptItem and NonLoadingScriptItem, making ScriptItem an abstract base.

DumpRenderTree/gtk/DumpRenderTree.cpp: (processWork): Use the new WorkQueue::processWork function to implement the new rule.
DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: Removed queue functions that are now platform-independent and in LayoutTestController.cpp.
DumpRenderTree/gtk/WorkQueueItemGtk.cpp: (LoadItem::invoke): Return true. (ReloadItem::invoke): Ditto. (ScriptItem::invoke): Ditto. (BackForwardItem::invoke): Ditto.

DumpRenderTree/mac/FrameLoadDelegate.mm: (-[FrameLoadDelegate processWork:]): Use the new WorkQueue::processWork function to implement the new rule.
DumpRenderTree/mac/LayoutTestControllerMac.mm: Removed queue functions that are now platform-independent and in LayoutTestController.cpp.
DumpRenderTree/mac/WorkQueueItemMac.mm: (LoadItem::invoke): Return true. (ReloadItem::invoke): Ditto. (ScriptItem::invoke): Ditto. (BackForwardItem::invoke): Ditto.

DumpRenderTree/qt/jsobjects.cpp: (LayoutTestController::processWork): Use the new WorkQueue::processWork function to implement the new rule. Removed queue functions that are now platform-independent and in LayoutTestController.cpp.

DumpRenderTree/win/FrameLoadDelegate.cpp: (FrameLoadDelegate::processWork): Use the new WorkQueue::processWork function to implement the new rule.
DumpRenderTree/win/LayoutTestControllerWin.cpp: Removed queue functions that are now platform-independent and in LayoutTestController.cpp.
DumpRenderTree/win/WorkQueueItemWin.cpp: (LoadItem::invoke): Return false when we fail, true when we succeed. (ReloadItem::invoke): Ditto. (ScriptItem::invoke): Ditto. (BackForwardItem::invoke): Ditto.

LayoutTests:

2009-03-29 Darin Adler <Darin Adler>

Reviewed by Cameron Zwarich.

Bug 24922: change WorkQueue-based navigation tests to not depend on synchronous form submission
https://bugs.webkit.org/show_bug.cgi?id=24922

fast/forms/targeted-frame-submission.html: Changed test to wait until the subframe loads before moving on to the next test, using an onload attribute.

http/tests/navigation/fallback-anchor-reload.html: Removed use of queueScript here for a script that can instead just be run immedidately.

http/tests/navigation/onload-navigation-iframe-timeout.html: Changed test to wait until the subframe loads before moving on to the next test, using an onload attribute.
http/tests/navigation/onload-navigation-iframe.html: Ditto.

http/tests/navigation/resources/testcode.js: Use queueNonLoadingScript instead of queueScript for scripts that don't involve submitting a form. Use queueLoadingScript for scripts that do involve submitting a form.

8:37 AM Changeset in webkit [42081] by Darin Adler

4 edits
2 adds in trunk

WebCore:

2009-03-29 Darin Adler <Darin Adler>

Reviewed by Dan Bernstein.

<rdar://problem/6015407> attr parsing should allow only identifiers

Test: fast/css/attr-parsing.html

css/CSSParser.cpp: (WebCore::CSSParser::parseContent): Allow only CSS_IDENT, and filter out identifiers that start with "-".
css/CSSPrimitiveValue.cpp: (WebCore::CSSPrimitiveValue::cssText): Added a case for CSS_ATTR so the test case works. This has the pleasant side effect of fixing a bug too.

LayoutTests:

2009-03-29 Darin Adler <Darin Adler>

Reviewed by Dan Bernstein.

<rdar://problem/6015407> attr parsing should allow only identifiers

fast/css/attr-parsing-expected.txt: Added.
fast/css/attr-parsing.html: Added.

8:17 AM Changeset in webkit [42080] by Darin Adler

1 edit
4 adds in trunk/LayoutTests

2009-03-29 Darin Adler <Darin Adler>

Bug 12104: Native Slider: When the thumb's height is specified as a percentage, it is not centered properly
https://bugs.webkit.org/show_bug.cgi?id=12104

Landed the test case from this bug. The bug was fixed by the fix for bug 24740 below.

fast/forms/range-thumb-height-percentage.html: Added.
platform/mac/fast/forms/range-thumb-height-percentage-expected.checksum: Added.
platform/mac/fast/forms/range-thumb-height-percentage-expected.png: Added.
platform/mac/fast/forms/range-thumb-height-percentage-expected.txt: Added.

2:45 AM Changeset in webkit [42079] by ap@webkit.org

2 edits in trunk/WebCore

<rdar://problem/6492712> Cross-origin redirects are not handled correctly.

Forgot to save the file after applying changes for review comments.

2:16 AM Changeset in webkit [42078] by ap@webkit.org

5 edits
4 adds in trunk

Reviewed by Darin Adler.

<rdar://problem/6492712> Cross-origin redirects are not handled correctly.

Test: http/tests/xmlhttprequest/redirect-cross-origin-tripmine.html

platform/network/cf/ResourceHandleCFNet.cpp: (WebCore::WebCoreSynchronousLoader::WebCoreSynchronousLoader): (WebCore::ResourceHandle::loadResourceSynchronously): (WebCore::WebCoreSynchronousLoader::willSendRequest): (WebCore::WebCoreSynchronousLoader::didReceiveResponse): (WebCore::WebCoreSynchronousLoader::didReceiveData): (WebCore::WebCoreSynchronousLoader::didFinishLoading): (WebCore::WebCoreSynchronousLoader::didFail): (WebCore::WebCoreSynchronousLoader::didReceiveChallenge): (WebCore::WebCoreSynchronousLoader::load): Match Mac behavior more closely - we shouldn't rely on underlying library handling of synchronous requests.

loader/DocumentThreadableLoader.cpp: (WebCore::DocumentThreadableLoader::willSendRequest): -[NSURLConnection cancel] doesn't fully cancel the connection if called from willSendRequest delegate method for a redirect.

platform/network/mac/ResourceHandleMac.mm: (-[WebCoreSynchronousLoader connection:willSendRequest:redirectResponse:]): Match async behavior more closely.

Note: See TracTimeline for information about the timeline view.

Download in other formats:

RSS Feed