Timeline
Apr 6, 2009:
- 4:43 PM Changeset in webkit [42261] by
-
- 5 edits in trunk/WebCore
2009-04-06 Sam Weinig <sam@webkit.org>
Reviewed by Mark Rowe.
Bottleneck dispatching mutation events in a new dispatchMutationEvent
function.
- dom/CharacterData.cpp: (WebCore::CharacterData::dispatchModifiedEvent):
- dom/ContainerNode.cpp: (WebCore::dispatchChildInsertionEvents): (WebCore::dispatchChildRemovalEvents):
- dom/Node.cpp: (WebCore::Node::dispatchSubtreeModifiedEvent): (WebCore::Node::dispatchMutationEvent):
- dom/Node.h:
- 4:11 PM Changeset in webkit [42260] by
-
- 9 edits in trunk/WebCore
2009-04-06 Dimitri Glazkov <Dimitri Glazkov>
Reviewed by Darin Fisher.
https://bugs.webkit.org/show_bug.cgi?id=25059
Remove references to dominantScript, getGenericFontForScript.
- platform/graphics/chromium/FontCacheChromiumWin.cpp: Removed references
to getGenericFontForScript.
(WebCore::FontCache::getLastResortFallbackFont): Removed calls to dominantScript.
- platform/graphics/chromium/FontCacheLinux.cpp: Ditto.
- rendering/RenderThemeChromiumLinux.cpp: (WebCore::defaultGUIFont): Removed Document* arg. (WebCore::RenderThemeChromiumLinux::systemFont): Ditto.
- rendering/RenderThemeChromiumLinux.h: Ditto.
- rendering/RenderThemeChromiumMac.h: Ditto.
- rendering/RenderThemeChromiumMac.mm: Ditto. (WebCore::RenderThemeChromiumMac::systemFont): Ditto.
- rendering/RenderThemeChromiumWin.cpp: (WebCore::defaultGUIFont): Ditto. (WebCore::RenderThemeChromiumWin::systemFont): Ditto.
- rendering/RenderThemeChromiumWin.h: Ditto.
- 4:04 PM Changeset in webkit [42259] by
-
- 4 edits in trunk
Versioning.
- 4:02 PM Changeset in webkit [42258] by
-
- 1 copy in tags/Safari-6530.5
New tag.
- 3:42 PM Changeset in webkit [42257] by
-
- 1 edit1 add in trunk/WebKit/gtk/po
2009-04-06 Christian Dywan <christian@twotoasts.de>
Rubber-stamped by Oliver Hunt.
- de.po: Added German translation for WebKitGTK+.
- 2:56 PM Changeset in webkit [42256] by
-
- 4 edits in trunk/WebCore
2009-04-06 Geoffrey Garen <ggaren@apple.com>
Reviewed by Darin Adler.
Fixed https://bugs.webkit.org/show_bug.cgi?id=21260
Unbounded memory growth when churning elements with anonymous event handler functions
The problem was that a protected event listener's scope chain would end
up with a reference to the Node protecting it, causing a cycle. The
solution is to stop protecting event listeners and rely on marking instead.
This patch converts most Node event listeners to use marking instead of
GC protection.
- bindings/js/JSDOMBinding.cpp: (WebCore::isObservableThroughDOM): (WebCore::markDOMNodesForDocument): Refactored the test for whether a Node needs marking, and added a case for marking the node in order to mark its event listeners.
- bindings/js/JSNodeCustom.cpp: (WebCore::markEventListeners): (WebCore::JSNode::addEventListener): (WebCore::JSNode::removeEventListener): (WebCore::JSNode::mark): Added code to mark a Node's event listeners when marking the Node. Changed code using protected event listeners to use event listeners.
- dom/Node.idl: Changed code using protected event listeners to use event listeners.
- 1:58 PM Changeset in webkit [42255] by
-
- 3 edits in trunk/WebCore
2009-04-06 Sam Weinig <sam@webkit.org>
Reviewed by Darin Adler.
Remove unchecked bool return values for some dispatch event functions.
- dom/Node.cpp: (WebCore::Node::dispatchSubtreeModifiedEvent): (WebCore::Node::dispatchUIEvent): (WebCore::Node::dispatchWebKitAnimationEvent): (WebCore::Node::dispatchWebKitTransitionEvent): (WebCore::Node::dispatchProgressEvent):
- dom/Node.h:
- 1:48 PM Changeset in webkit [42254] by
-
- 3 edits in trunk/WebCore
2009-04-06 Darin Fisher <darin@chromium.org>
Reviewed by Dimitri Glazkov.
https://bugs.webkit.org/show_bug.cgi?id=25058
Fix chromium build bustage caused by r42216
- bindings/scripts/CodeGeneratorJS.pm:
- page/DOMWindow.idl:
- 12:48 PM Changeset in webkit [42253] by
-
- 2 edits in trunk/LayoutTests
2009-04-06 Dimitri Glazkov <Dimitri Glazkov>
Not reviewed because it's stupidly obvious.
Correct the expected result by adding an extra line break.
- fast/dom/HTMLSelectElement/length-not-overridden-expected.txt: Added
an extra line.
- 12:39 PM Changeset in webkit [42252] by
-
- 1 edit1 add in trunk/WebKit/gtk/po
2009-04-06 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
Rubber-stamped by Sam Weinig.
- pt_BR.po: Added Brazilian Portuguese translation for WebKitGTK+.
- 12:39 PM Changeset in webkit [42251] by
-
- 12 edits6 adds in trunk
2009-04-06 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
Rubber-stamped by Sam Weinig.
Added rules to maintain the localization support. We cannot simply
use whatever gettextize gives us because our build system is
non-recursive.
- GNUmakefile.am:
- configure.ac:
WebCore/
2009-04-06 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
Rubber-stamped by Sam Weinig.
https://bugs.webkit.org/show_bug.cgi?id=20575
No localization in WebKitGtk
- platform/gtk/FileChooserGtk.cpp: Remove usage of glib/gi18n.h, since there are not translatable strings.
- platform/gtk/LocalizedStringsGtk.cpp: Use the glib i18n header that is specific for libraries.
WebKit/gtk/
2009-04-06 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
Rubber-stamped by Sam Weinig.
https://bugs.webkit.org/show_bug.cgi?id=20575
No localization in WebKitGtk
Implemented localization support for WebKitGTK+.
- WebCoreSupport/ChromeClientGtk.cpp:
- WebCoreSupport/ContextMenuClientGtk.cpp:
- po/POTFILES: Added.
- po/README: Added.
- po/webkit.pot: Added.
- webkit/webkitdownload.cpp: (_WebKitDownloadPrivate::webkit_download_class_init):
- webkit/webkitprivate.cpp: (webkit_init):
- webkit/webkitwebframe.cpp:
WebKit/gtk/po/
2009-04-06 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
Rubber-stamped by Sam Weinig.
- GNUmakefile.am, POTFILES, webkit.pot: Initial setup of the localization infra-structure.
- 11:41 AM Changeset in webkit [42250] by
-
- 2 edits in trunk/WebCore
Revert r42249 to fix the build.
- 11:23 AM Changeset in webkit [42249] by
-
- 2 edits in trunk/WebCore
2009-04-06 Darin Fisher <darin@chromium.org>
Reviewed by Dimitri Glazkov.
https://bugs.webkit.org/show_bug.cgi?id=25058
Fix chromium build bustage caused by r42216
- page/DOMWindow.idl:
- 11:08 AM Changeset in webkit [42248] by
-
- 3 edits in trunk/WebCore
2009-04-06 Mike Belshe <mike@belshe.com>
Reviewed by Dimitri Glazkov.
https://bugs.webkit.org/show_bug.cgi?id=24978
Use custom implementations of a few Node methods so that
we don't over-aggressively create JS wrappers here.
- bindings/v8/custom/V8NodeCustom.cpp: Added custom implementations.
- dom/Node.idl: Removed JSC-specifier, making impl custom for V8 as well.
- 11:01 AM Changeset in webkit [42247] by
-
- 3 edits2 adds in trunk
WebCore:
2009-04-06 Dave Moore <davemoore@google.com>
Reviewed by Dimitri Glazkov.
https://bugs.webkit.org/show_bug.cgi?id=25031
Make the V8 element collections check for named properties *before*
checking if there are any elements with the same name. Otherwise
it is both incorrect and slow.
Test: fast/dom/HTMLSelectElement/length-not-overridden.html
Both of these interceptors were attempting to find an element in the
collection that had a name or id of the property name before checking
for a JS property with that name.
- bindings/v8/V8Collection.h: (WebCore::collectionNamedPropertyGetter): (WebCore::nodeCollectionNamedPropertyGetter):
LayoutTests:
2009-04-06 Dave Moore <davemoore@google.com>
Reviewed by Dimitri Glazkov.
https://bugs.webkit.org/show_bug.cgi?id=25031
Test for ensuring that named elements don't override properties on collections
- fast/dom/HTMLSelectElement/length-not-overridden-expected.txt: Added.
- fast/dom/HTMLSelectElement/length-not-overridden.html: Added.
- 10:51 AM Changeset in webkit [42246] by
-
- 5 edits4 adds in trunk
2009-04-06 Simon Fraser <Simon Fraser>
Reviewed by Darin Adler
Pull the call to updateGraphicsLayerGeometry() out of updateGraphicsLayers(),
because we need to call it at the end of rebuildCompositingLayerTree() once
we've determined which descendant layers are composited, otherwise
calculateCompositedBounds() can give the wrong answer.
Now that updateLayerCompositingState() doesn't end up calling updateGraphicsLayerGeometry(),
call that explicitly from styleChanged(), if we know a layer update is not pending,
and similarly from updateAfterLayout().
Test: compositing/overflow/overflow-positioning.html
- rendering/RenderLayer.cpp: (WebCore::RenderLayer::styleChanged):
- rendering/RenderLayerBacking.cpp: (WebCore::RenderLayerBacking::updateAfterLayout): (WebCore::RenderLayerBacking::updateGraphicsLayers): (WebCore::RenderLayerBacking::updateGraphicsLayerGeometry):
- rendering/RenderLayerCompositor.cpp: (WebCore::RenderLayerCompositor::rebuildCompositingLayerTree):
- 9:01 AM Changeset in webkit [42245] by
-
- 2 edits in trunk/WebCore
2009-04-06 Mike Belshe <mike@belshe.com>
Reviewed by Alexey Proskuryakov.
Add accessors to AtomicString which take String/const char* arguments
so that we don't accidentally thrash the AtomicString table.
- platform/text/AtomicString.h:
- 8:47 AM Changeset in webkit [42244] by
-
- 7 edits in trunk/WebKit/qt
2009-04-06 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>
Reviewed by Simon Hausmann.
[Qt] Rename DOM API select function to findFirst, findAll, etc.
- 8:37 AM Changeset in webkit [42243] by
-
- 2 edits in trunk/WebKitTools
2009-04-06 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
Rubber-stamped by Tor Arne Vestbø.
Add /Programs to the productDir for GTK+, instead of adding
/JavaScriptCore, when running jsc.
- Scripts/run-sunspider:
- 7:17 AM Changeset in webkit [42242] by
-
- 2 edits in trunk/WebCore
[GTK+] Correct the column and row cursor
Make col and row work in WebCore/manual-tests/cursor.html. The issue
was spotted in the WebKit inspector.
- 5:59 AM Changeset in webkit [42241] by
-
- 2 edits in trunk/WebCore
2009-04-06 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>
Reviewed by Simon Hausmann.
[Qt] Don't show and hide the platformPluginWidget, as it's our QWebView
- 5:50 AM QtWebKitContrib edited by
- (diff)
- 5:50 AM QtWebKitContrib edited by
- (diff)
- 5:49 AM QtWebKitContrib edited by
- (diff)
- 4:58 AM Changeset in webkit [42240] by
-
- 2 edits in trunk/WebKit/gtk
2009-04-05 Xan Lopez <xlopez@igalia.com>
Reviewed by Holger Freyther.
https://bugs.webkit.org/show_bug.cgi?id=25042
destroying webview widget directly causes crash.
Do not connect the WebView to its own screen-changed signal, set a
default handler instead.
- webkit/webkitwebview.cpp:
- 4:57 AM Changeset in webkit [42239] by
-
- 2 edits in trunk/WebKit/gtk
2009-04-05 Xan Lopez <xlopez@igalia.com>
Reviewed by Holger Freyther.
https://bugs.webkit.org/show_bug.cgi?id=25042
destroying webview widget directly causes crash.
GtkWidget::screen-changed can be emitted when a widget is being
destroyed, protect against it.
- webkit/webkitwebview.cpp:
- 4:25 AM Changeset in webkit [42238] by
-
- 9 edits5 adds in trunk
WebCore:
2009-04-06 Simon Hausmann <simon.hausmann@nokia.com>
Reviewed by Tor Arne Vestbø.
Add new files to the Qt build.
Export helper function from the Qt JSC binding, needed in WebKit/qt.
WebKit/qt:
2009-04-06 Simon Hausmann <simon.hausmann@nokia.com>
Ariya Hidayat <ariya.hidayat@nokia.com>
Tor Arne Vestbø <tor.arne.vestbo@nokia.com>
Genevieve Mak <gen@staikos.net>
Reviewed by Tor Arne Vestbø, Simon Hausmann
First revision of new API in the Qt port to access the DOM.
- 4:13 AM Changeset in webkit [42237] by
-
- 3 edits in trunk/WebCore
2009-04-06 Simon Hausmann <simon.hausmann@nokia.com>
Reviewed by Tor Arne Vestbø.
Changed ScriptFunctionCall's last argument from a const char* as the function name to a String.
Internally the function name is stored as a WebCore::String and the Qt port wants to use this
constructor programmatically where the function name is also a WebCore::String.
- 2:51 AM Changeset in webkit [42236] by
-
- 2 edits in trunk/WebCore
2009-04-06 Mike Belshe <mike@belshe.com>
Reviewed by Eric Seidel.
HTMLCanvasElement crash when ImageBuffer creation fails.
https://bugs.webkit.org/show_bug.cgi?id=23212
Check for NULL before using the ImageBuffer as we might
be low on memory and creation may have failed.
Test case creation blocked by:
https://bugs.webkit.org/show_bug.cgi?id=25055
- html/HTMLCanvasElement.cpp: (WebCore::HTMLCanvasElement::createImageBuffer):
Apr 5, 2009:
- 3:48 PM Changeset in webkit [42235] by
-
- 13 edits in trunk/WebCore
2009-04-05 Geoffrey Garen <ggaren@apple.com>
[Originally] Reviewed by Sam Weinig.
Rolled back in r42214 with crashes fixed.
[Removed irrelevant ExecState* parameter from event handler registration code.]
[No change in behavior.]
- bindings/js/JSDOMApplicationCacheCustom.cpp: (WebCore::JSDOMApplicationCache::addEventListener): (WebCore::JSDOMApplicationCache::removeEventListener):
- bindings/js/JSDOMGlobalObject.cpp: (WebCore::JSDOMGlobalObject::findOrCreateJSProtectedEventListener): (WebCore::JSDOMGlobalObject::findJSEventListener): (WebCore::JSDOMGlobalObject::findOrCreateJSEventListener):
- bindings/js/JSDOMGlobalObject.h:
- bindings/js/JSDOMWindowCustom.cpp: (WebCore::JSDOMWindow::addEventListener):
- bindings/js/JSMessagePortCustom.cpp: (WebCore::JSMessagePort::addEventListener): (WebCore::JSMessagePort::removeEventListener):
- bindings/js/JSNodeCustom.cpp: (WebCore::JSNode::addEventListener):
- bindings/js/JSSVGElementInstanceCustom.cpp: (WebCore::JSSVGElementInstance::addEventListener):
- bindings/js/JSWorkerContextCustom.cpp: (WebCore::JSWorkerContext::addEventListener): (WebCore::JSWorkerContext::removeEventListener):
- bindings/js/JSWorkerCustom.cpp: (WebCore::JSWorker::addEventListener): (WebCore::JSWorker::removeEventListener):
- bindings/js/JSXMLHttpRequestCustom.cpp: (WebCore::JSXMLHttpRequest::addEventListener): (WebCore::JSXMLHttpRequest::removeEventListener):
- bindings/js/JSXMLHttpRequestUploadCustom.cpp: (WebCore::JSXMLHttpRequestUpload::addEventListener): (WebCore::JSXMLHttpRequestUpload::removeEventListener):
- bindings/scripts/CodeGeneratorJS.pm:
- 10:26 AM Changeset in webkit [42234] by
-
- 2 edits in trunk/WebCore
2009-04-05 Erik L. Bunce <elbunce@xendom.com>
Reviewed by Simon Hausmann.
Fix an assert failure when dropping an 'empty' text/uri-list on a QWebView.
- 7:56 AM Changeset in webkit [42233] by
-
- 2 edits in trunk/WebCore
Fix the Qt build
- 1:21 AM Changeset in webkit [42232] by
-
- 2 edits in trunk
2009-04-05 Mike Hommey <glandium@debian.org>
Reviewed by Holger Freyther.
Filter out all C++ symbols
https://bugs.webkit.org/show_bug.cgi?id=24960
Considering the public API is all C, we can just filter out all
C++ mangled symbols, which will avoid exporting symbols in some
corner cases such as gcc bugs on specific architectures, etc.
- autotools/symbols.filter:
- 1:16 AM Changeset in webkit [42231] by
-
- 2 edits in trunk/WebKit/gtk
2009-04-05 Jan Michael Alonzo <jmalonzo@webkit.org>
Reviewed by Holger Freyther.
[Gtk] Implement LayoutTestControllerGtk::setPrivateBrowsingEnabled
https://bugs.webkit.org/show_bug.cgi?id=24487
Updated documentation and put more information about the
private-browsing setting for WebKitGtk.
- webkit/webkitwebsettings.cpp: (_WebKitWebSettingsPrivate::webkit_web_settings_class_init):
