Timeline
Apr 13, 2009:
- 11:39 PM Changeset in webkit [42480] by
-
- 3 edits in trunk/JavaScriptCore
Missed code from last patch
- 11:33 PM Changeset in webkit [42479] by
-
- 2 edits in trunk/WebCore
2009-04-13 David Hyatt <hyatt@apple.com>
Reviewed by Cameron Zwarich.
Remove an outdated comment in ScrollView.h
- platform/ScrollView.h:
- 11:24 PM Changeset in webkit [42478] by
-
- 6 edits4 adds in trunk
BUG 25171: It should be possible to manually set the name of an anonymous function
<https://bugs.webkit.org/show_bug.cgi?id=25171>
Submitted by Francisco Tolmasky <francisco@280north.com>
Reviewed by Oliver Hunt.
This change adds the displayName property to functions, which when set overrides the
normal name when appearing in the console.
- 10:30 PM Moving to Git edited by
- trivial fix incorrect 'there' replaced with correct 'their' (diff)
- 10:03 PM Changeset in webkit [42477] by
-
- 2 edits in trunk/WebCore
2009-04-13 Eric Carlson <eric.carlson@apple.com>
Reviewed by Mark Rowe.
QTTrack's -media method always return NULL in 64-bit QTKit, so
MediaPlayerPrivate::disableUnsupportedTracks should use
QTTrackMediaTypeAttribute to get a track's type.
- platform/graphics/mac/MediaPlayerPrivateQTKit.mm: (WebCore::MediaPlayerPrivate::disableUnsupportedTracks):
- 9:52 PM Changeset in webkit [42476] by
-
- 8 edits in trunk/WebCore
2009-04-13 Geoffrey Garen <ggaren@apple.com>
Reviewed by Cameron Zwarich.
More fix for https://bugs.webkit.org/show_bug.cgi?id=21260
Unbounded memory growth when churning elements with anonymous event handler functions
Stop using protected event listeners on the window object.
- bindings/js/JSDOMWindowCustom.cpp: (WebCore::JSDOMWindow::mark): Mark our event listeners, since they're no longer protected.
(WebCore::JSDOMWindow::addEventListener):
(WebCore::JSDOMWindow::removeEventListener): Create unprotected event
listeners, since we mark them now.
- bindings/js/JSEventListener.h: Made some functions public so DOMWindow could call them.
- bindings/js/JSNodeCustom.cpp: Moved markEventListeners to a header, so it could be shared.
- bindings/scripts/CodeGeneratorJS.pm: Generate event listener marking and invalidating code for the DOMWindow.
- dom/RegisteredEventListener.h: (WebCore::markEventListeners): (WebCore::invalidateEventListeners): Added helper functions.
- page/DOMWindow.idl: Make the window's event listener attributes not protected.
- 9:13 PM Changeset in webkit [42475] by
-
- 2 edits in trunk/WebCore
2009-04-13 Eric Carlson <eric.carlson@apple.com>
Reviewed by Mark Rowe.
OS X standalone media documents should not switch from <video> to <embed> when
QTKit load state is QTMovieLoadStateLoading as that happens frequently when a loading
with a slow network connection or when a movie is not saved fast-start.
- platform/graphics/mac/MediaPlayerPrivateQTKit.mm: (WebCore::MediaPlayerPrivate::updateStates): Don't open movie with plug-in when QTKit's loadstate is QTMovieLoadStateLoading, wait until it drops below QTMovieLoadStateError.
- 6:03 PM Changeset in webkit [42474] by
-
- 3 edits in trunk/WebCore
2009-04-13 Dmitry Titov <dimich@chromium.org>
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=24453
REGRESSION: If setTimeout is called on a iframe's window, the DOM changes to
the main document that timer callback makes are not flushed.
- bindings/js/ScheduledAction.cpp: (WebCore::ScheduledAction::execute): Use Document::updateStyleForAllDocuments() instead of document->updateStyleIfNeeded() since timers may affect documents other then their own.
- 5:21 PM Changeset in webkit [42473] by
-
- 2 edits in trunk/WebCore
2009-04-13 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
Reviewed by David Hyatt.
Check document for nullity to avoid crashing on GTK+, when
creating the WebView.
- page/FrameView.cpp: (WebCore::FrameView::needsLayout):
- 5:19 PM Changeset in webkit [42472] by
-
- 2 edits in trunk/WebCore
Forgot to capitalize the "US".
- platform/text/win/TextBreakIteratorInternalICUWin.cpp: (WebCore::currentTextBreakLocaleID):
- 5:10 PM Changeset in webkit [42471] by
-
- 2 edits in trunk/WebCore
<rdar://problem/6564956> URL field double-click selects entire domain, rather than single word or entire URL
Revert back to the old word breaking behavior by using en_US_POSIX locale.
Reviewed by Steve Falkenburg.
- platform/text/win/TextBreakIteratorInternalICUWin.cpp: (WebCore::currentTextBreakLocaleID):
- 4:42 PM Changeset in webkit [42470] by
-
- 3 edits in trunk/WebKit/mac
Reviewed by Darin.
<rdar://problem/6784955> REGRESSION: closing a tab containing a PDF causes world leaks
Simplify the _trackFirstResponder method by just caching the value instead of retaining
a Cocoa object.
- WebView/WebPDFView.h: Eliminated trackedFirstResponder object and replaced it with a firstResponderIsPDFDocumentView boolean.
- WebView/WebPDFView.mm: (-[WebPDFView dealloc]): Removed no longer necessary ASSERT. (-[WebPDFView viewWillMoveToWindow:]): Removed call to release and nil-out trackedFirstResponder, which no longer exists. In the new code all we do now is set firstResponderIsPDFDocumentView to NO. (-[WebPDFView _trackFirstResponder]): Rewrote this method to just cache the value instead of retaining an object.
- 3:36 PM Changeset in webkit [42469] by
-
- 4 edits in trunk/WebKitTools
2009-04-13 Darin Adler <Darin Adler>
Reviewed by Mark Rowe.
- Scripts/check-for-exit-time-destructors: Add ERROR: and WARNING: prefixes to make these scripts work better with the build window in new versions of Xcode.
- Scripts/check-for-global-initializers: Ditto.
- Scripts/check-for-weak-vtables: Ditto.
- 3:18 PM Changeset in webkit [42468] by
-
- 3 edits in trunk/WebCore
2009-04-13 Darin Adler <Darin Adler>
Reviewed by Dan Bernstein.
- platform/cf/BinaryPropertyList.cpp: Added comment.
- platform/cf/BinaryPropertyList.h: Fixed mistakes in comments.
- 3:16 PM Changeset in webkit [42467] by
-
- 8 edits2 adds in trunk
WebCore:
2009-04-13 Darin Adler <Darin Adler>
Reviewed by Dan Bernstein.
Bug 25158: hit testing doesn't work right in some cases involving anonymous blocks
https://bugs.webkit.org/show_bug.cgi?id=25158
rdar://problem/6769693
Test: editing/selection/click-after-nested-block.html
- rendering/RenderBlock.cpp: (WebCore::isChildHitTestCandidate): Added. Helper so the two loops in positionForPoint can share code. (WebCore::RenderBlock::positionForPoint): Removed unneeded special case for first child box. Changed special case for last child box to propertly handle the various types of child box that are not hit test candidates (the same ones already handled by the hit test loop below), adding in a loop so we find the last candidate.
LayoutTests:
2009-04-13 Darin Adler <Darin Adler>
Reviewed by Dan Bernstein.
Bug 25158: hit testing doesn't work right in some cases involving anonymous blocks
https://bugs.webkit.org/show_bug.cgi?id=25158
rdar://problem/6769693
- editing/selection/click-after-nested-block-expected.txt: Added.
- editing/selection/click-after-nested-block.html: Added.
- fast/events/pointer-events-expected.txt: Updated since this is now a plain-text test.
- fast/events/pointer-events.html: Changed this to a plain-text test, because the old results reflected a difference in hit testing behavior that this test was not intended to exercise and it's better to have the test be more cross-platform. Also removed unneeded use of waitUntilDone.
- fast/js/finally-codegen-failure.html: Replaced with standard wrapper created by running the make-js-test-wrappers script. If we want to include type and charset attributes in the script elements, we can change make-js-test-wrappers to do that for all tests at some point.
- fast/js/function-apply-aliased.html: Ditto.
- fast/js/function-call-aliased.html: Ditto.
- 2:44 PM Changeset in webkit [42466] by
-
- 4 edits in trunk
2009-04-13 Geoffrey Garen <ggaren@apple.com>
Reviewed by Sam Weinig.
Disabled another JavaScriptCore test because it fails on Windows but
not Mac, so it makes the bots red.
- tests/mozilla/expected.html:
WebKitTools:
2009-04-13 Geoffrey Garen <ggaren@apple.com>
Reviewed by Sam Weinig.
Disabled another JavaScriptCore test because it fails on Windows but
not Mac, so it makes the bots red.
- Scripts/run-javascriptcore-tests:
- 2:39 PM Changeset in webkit [42465] by
-
- 1 edit in trunk/LayoutTests/platform/mac/accessibility/frame-with-title-expected.txt
Update accessibility layout test from last checkin.
- 2:34 PM Changeset in webkit [42464] by
-
- 9 edits in trunk
Webcore:
2009-04-13 David Hyatt <hyatt@apple.com>
Reviewed by Sam Weinig.
Fix for https://bugs.webkit.org/show_bug.cgi?id=25125. Rework scrolling so that a layout happens first when
it's already needed so that the code doesn't end up making bad decisions based off invalid document sizes.
- WebCore.base.exp:
- page/FrameView.h: (WebCore::FrameView::visibleContentsResized):
- platform/ScrollView.cpp: (WebCore::ScrollView::ScrollView): (WebCore::ScrollView::updateScrollbars):
- platform/ScrollView.h:
WebKit/mac:
2009-04-13 David Hyatt <hyatt@apple.com>
Reviewed by Sam Weinig.
Fix for https://bugs.webkit.org/show_bug.cgi?id=25125. Rework scrolling so that a layout happens first when
it's already needed so that the code doesn't end up making bad decisions based off invalid document sizes.
This patch also eliminates WebHTMLView's separate notion of needing a layout and just consolidates it with
WebCore's notion of needing layout.
- WebView/WebDynamicScrollBarsView.m: (-[WebDynamicScrollBarsView updateScrollers]):
- WebView/WebHTMLView.mm: (-[WebHTMLView _frameOrBoundsChanged]): (-[WebHTMLView initWithFrame:]): (-[WebHTMLView layoutToMinimumPageWidth:maximumPageWidth:adjustingViewSize:]): (-[WebHTMLView setNeedsLayout:]): (-[WebHTMLView _layoutIfNeeded]): (-[WebHTMLView _needsLayout]):
- WebView/WebHTMLViewInternal.h:
- 2:31 PM Changeset in webkit [42463] by
-
- 7 edits in trunk
Windows part 2 of <rdar://5438063> Saving history containing 100,000 entries causes pauses of 2s while browsing
WebCore:
Add SharedBuffer::wrapCFData
This is the CF-equivalent of wrapNSData.
Reviewed by Brady Eidson.
- platform/SharedBuffer.h:
- platform/cf/SharedBufferCF.cpp: (WebCore::SharedBuffer::wrapCFData):
WebKit/win:
Windows part 2 of <rdar://5438063> Saving history containing 100,000
entries causes pauses of 2s while browsing
Reviewed by Brady Eidson.
- Interfaces/IWebHistoryPrivate.idl: Added data, analagous to WebKit/mac's -[WebHistory _data] method.
- WebHistory.cpp: (WebHistory::saveHistoryGuts): Changed to call data() to get the data for saving. (WebHistory::data): Added. Returns the data for saving as an IStream. (WebHistory::data): Added. Returns the data for saving as a CFDataRef.
- WebHistory.h: Added data.
- 2:27 PM Changeset in webkit [42462] by
-
- 2 edits in trunk/LayoutTests
2009-04-13 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
Rubber-stamped by Holger Freyther.
Further massage tests to disable tests that are failingto make the
results more useful.
- platform/gtk/Skipped:
- 2:09 PM Changeset in webkit [42461] by
-
- 4 edits in trunk
2009-04-13 Geoffrey Garen <ggaren@apple.com>
Reviewed by Sam Weinig.
Disabled two JavaScriptCore tests because they fail on Window or Mac but
not both, so they make the bots red.
- tests/mozilla/expected.html: Updated expected results.
WebKitTools:
2009-04-13 Geoffrey Garen <ggaren@apple.com>
Reviewed by Sam Weinig.
Disabled two JavaScriptCore tests because they fail on Window or Mac but
not both, so they make the bots red.
- Scripts/run-javascriptcore-tests:
- 1:57 PM Changeset in webkit [42460] by
-
- 1 edit in trunk/WebCore/page/EventHandler.cpp
Adding a comment to my previous code change.
- 1:55 PM Changeset in webkit [42459] by
-
- 2 edits in trunk/WebKit/mac
2009-04-13 Darin Adler <Darin Adler>
- WebView/WebViewPrivate.h: Updated comments.
- 1:48 PM Changeset in webkit [42458] by
-
- 2 edits in trunk/WebCore
- build fix
- page/EventHandler.cpp: (WebCore::documentPointForWindowPoint):
- 1:46 PM Changeset in webkit [42457] by
-
- 14 edits in trunk
WebCore:
2009-04-13 Antti Koivisto <Antti Koivisto>
Reviewed by Darin Adler.
<rdar://problem/6740294> Increase the connection count per host
Try to use six connections per host if possible.
- WebCore.base.exp:
- loader/loader.cpp: (WebCore::Loader::Loader):
- platform/mac/WebCoreSystemInterface.h:
- platform/mac/WebCoreSystemInterface.mm:
- platform/network/ResourceRequestBase.cpp: (WebCore::initMaximumHTTPConnectionCountPerHost):
- platform/network/ResourceRequestBase.h:
- platform/network/mac/ResourceRequestMac.mm: (WebCore::initMaximumHTTPConnectionCountPerHost):
WebKit/mac:
2009-04-13 Antti Koivisto <Antti Koivisto>
Reviewed by Darin Adler.
<rdar://problem/6740294> Increase the connection count per host
- WebCoreSupport/WebSystemInterface.m: (InitWebCoreSystemInterface):
WebKitLibraries:
2009-04-13 Antti Koivisto <Antti Koivisto>
Reviewed by Darin Adler.
<rdar://problem/6740294> Increase the connection count per host
- WebKitSystemInterface.h:
- libWebKitSystemInterfaceLeopard.a:
- libWebKitSystemInterfaceTiger.a:
- 1:38 PM Changeset in webkit [42456] by
-
- 3 edits2 adds in trunk
WebCore:
2009-04-13 Justin Garcia <justin.garcia@apple.com>
Reviewed by Adele Peterson.
https://bugs.webkit.org/show_bug.cgi?id=25153
Can't place the caret into text field that scrolls the window on focus
We refetch the target node in the shadow node case, and when we do so the window coordinate for the mouse event may
be invalid because of scrolling that the focus handler did. Cache the document point (that we derived from the window
coordinate) and use that any time we refetch.
- page/EventHandler.cpp: (WebCore::documentPointForWindowPoint): (WebCore::EventHandler::handleMousePressEvent): (WebCore::EventHandler::prepareMouseEvent):
LayoutTests:
2009-04-13 Justin Garcia <justin.garcia@apple.com>
Reviewed by Adele Peterson.
<rdar://problem/6748324> REGRESSION (Kirkwood): Can't type in Netflix search field
- fast/forms/25153-expected.txt: Added.
- fast/forms/25153.html: Added.
- 1:29 PM Changeset in webkit [42455] by
-
- 2 edits in trunk/LayoutTests
2009-04-13 Sam Weinig <sam@webkit.org>
Fix bad expected result.
- fast/frames/frame-unload-crash-expected.txt:
- 1:26 PM Changeset in webkit [42454] by
-
- 3 edits in trunk/WebCore
2009-04-13 Sam Weinig <sam@webkit.org>
Reviewed by Geoffrey Garen.
Rename JavaScriptCanOpenWindowsAutomatically to javaScriptCanOpenWindowsAutomatically
to conform to our style guidelines.
- page/DOMWindow.cpp: (WebCore::DOMWindow::allowPopUp):
- page/Settings.h: (WebCore::Settings::javaScriptCanOpenWindowsAutomatically):
- 1:24 PM Changeset in webkit [42453] by
-
- 2 edits in trunk/WebCore
2009-04-13 Geoffrey Garen <ggaren@apple.com>
Mac build fix: Made another header private.
- WebCore.xcodeproj/project.pbxproj:
- 1:20 PM Changeset in webkit [42452] by
-
- 3 edits in trunk/WebCore
2009-04-13 Jian Li <jianli@chromium.org>
Reviewed by Darin Fisher.
https://bugs.webkit.org/show_bug.cgi?id=25121
Upstream changes to handle error messages from V8 when running worker script.
- bindings/v8/WorkerContextExecutionProxy.cpp: (WebCore::reportFatalErrorInV8): (WebCore::handleConsoleMessage): (WebCore::WorkerContextExecutionProxy::WorkerContextExecutionProxy): (WebCore::WorkerContextExecutionProxy::dispose): (WebCore::WorkerContextExecutionProxy::initV8IfNeeded): (WebCore::WorkerContextExecutionProxy::initContextIfNeeded): (WebCore::WorkerContextExecutionProxy::evaluate):
- bindings/v8/WorkerContextExecutionProxy.h:
- 1:18 PM Changeset in webkit [42451] by
-
- 2 edits in trunk/WebKit/mac
2009-04-13 Brady Eidson <beidson@apple.com>
Reviewed by Tim Hatcher
Tweak my last check-in, moving the thread violation check up to the API-level calls so the logging is more
useful to developers/users.
- WebView/WebFrame.mm: (-[WebFrame _loadData:MIMEType:textEncodingName:baseURL:unreachableURL:]): If not on the main thread, only perform the "call on main thead" workaround, as the log/exception raising is now up at the API level. (-[WebFrame loadData:MIMEType:textEncodingName:baseURL:]): Perform a thread violation check here so logging is more meaningful. (-[WebFrame loadHTMLString:baseURL:]): Ditto. (-[WebFrame loadAlternateHTMLString:baseURL:forUnreachableURL:]): Ditto.
- 1:16 PM Changeset in webkit [42450] by
-
- 3 edits in trunk/WebCore
2009-04-13 Geoffrey Garen <ggaren@apple.com>
Build fix: Made setInlineEventListenerForType not inline, since Document
calls it now. Made RegisteredEventListener.h a private header on Mac,
so WebKit can use it.
- page/DOMWindow.cpp: (WebCore::DOMWindow::setInlineEventListenerForType):
- 1:14 PM Changeset in webkit [42449] by
-
- 2 edits in trunk/WebCore
Reviewed by Sam Weinig.
- fix <rdar://problem/6404439> REGRESSION: Overlapping text and other layout issues in View Sample feature of MYOB FIrstEdge v3
- page/Navigator.cpp: (WebCore::shouldHideFourDot): Added "tdqm_loader.js" to the list of JavaScript files this quirk applies to.
- 1:03 PM Changeset in webkit [42448] by
-
- 2 edits in trunk/WebKit/mac
2009-04-13 Brady Eidson <beidson@apple.com>
Reviewed by Kevin Decker
<rdar://problem/6712063> Garmin WebUpdater crashes
- WebView/WebFrame.mm: (-[WebFrame _loadData:MIMEType:textEncodingName:baseURL:unreachableURL:]): If not called on the main thread, add a ThreadViolationCheckRoundTwo() call to either log or raise an exception. In the case where it's only a log, reschedule the _loadData call to occur on the main thread.
- 12:50 PM Changeset in webkit [42447] by
-
- 13 edits in trunk
WebCore:
2009-04-13 Sam Weinig <sam@webkit.org>
Reviewed by Oliver Hunt.
Move open and showModalDialog functions out of JSDOMWindowBase
and into JSDOMWindow by partially generating them.
This slightly changes the behavior of getting window.showModalDialog
when the embedding app does not support it to return undefined regardless
of shadowing. This should not be an issue in a practice, but will be addressed
when we add a generic way to handle runtime specialization of property
access.
- DerivedSources.make: Remove JSDOMWindowBase.lut.h
- WebCore.xcodeproj/project.pbxproj: Ditto.
- bindings/js/JSDOMWindowBase.cpp: (WebCore::): (WebCore::JSDOMWindowBase::getOwnPropertySlot): Move canShowModalDialog check from here to JSDOMWindow::customGetOwnPropertySlot. (WebCore::JSDOMWindowBase::put): Remove dead code.
- bindings/js/JSDOMWindowCustom.cpp: (WebCore::createWindow): (WebCore::JSDOMWindow::open): (WebCore::JSDOMWindow::showModalDialog):
- bindings/js/JSDOMWindowCustom.h: (WebCore::JSDOMWindow::customGetOwnPropertySlot):
- page/DOMWindow.cpp: (WebCore::DOMWindow::parseModalDialogFeatures): Move from JSDOMWindowBase. (WebCore::DOMWindow::allowPopUp): Ditto. (WebCore::DOMWindow::canShowModalDialog): Ditto. (WebCore::DOMWindow::canShowModalDialogNow): Ditto.
- page/DOMWindow.h:
- page/DOMWindow.idl:
LayoutTests:
2009-04-13 Sam Weinig <sam@webkit.org>
Reviewed by Oliver Hunt.
Update tests after moving showModalDialog from JSDOMWindowBase to
JSDOMWindow and slightly changing the behavior when showModalDialog
is not available, as is the case for DumpRenderTree.
- fast/dom/Window/window-function-frame-getter-precedence-expected.txt:
- fast/dom/Window/window-properties-expected.txt:
- platform/mac-leopard/fast/dom/Window/window-properties-expected.txt:
- 12:43 PM Changeset in webkit [42446] by
-
- 13 edits in trunk/WebCore
2009-04-13 Geoffrey Garen <ggaren@apple.com>
Reviewed by Sam Weinig.
Moved storage for window event listeners into the window object.
- bindings/js/JSDOMWindowCustom.cpp: (WebCore::JSDOMWindow::addEventListener): (WebCore::JSDOMWindow::removeEventListener): Add / remove window event listeners to / from the window object.
- dom/Document.cpp: (WebCore::Document::removeAllEventListeners): (WebCore::Document::clear): (WebCore::Document::setWindowInlineEventListenerForTypeAndAttribute): Moved a bunch of code to the DOMWindow class, and left behind a few calls through to DOMWindow, to support legacy clients. (Eventually, these will go away, too.)
- dom/Document.h: ditto.
- dom/Node.cpp: (WebCore::Node::dispatchGenericEvent): (WebCore::Node::dispatchWindowEvent): Dipatch window events on the window object, not the document.
- dom/Node.h:
- dom/RegisteredEventListener.h: Moved RegisteredEventListenerVector declaration, since it's required in more places now.
- history/CachedFrame.cpp: (WebCore::CachedFrame::clear): Updated for rename. Also, remove event listeners before detaching and clearing the document's window pointer, since the the document needs its window pointer in order to tell the window to clear its event listeners.
- loader/FrameLoader.cpp: (WebCore::FrameLoader::stopLoading): (WebCore::FrameLoader::canCachePageContainingThisFrame): (WebCore::FrameLoader::logCanCacheFrameDecision): Updated for rename, and movement of window event listeners into the window.
- loader/ImageDocument.cpp: (WebCore::ImageDocument::createDocumentStructure): Updated for movement of window event listeners into the window.
- page/DOMWindow.cpp: (WebCore::DOMWindow::handleEvent): (WebCore::DOMWindow::addEventListener): (WebCore::DOMWindow::removeEventListener): (WebCore::DOMWindow::removeAllEventListeners): (WebCore::DOMWindow::hasEventListener): (WebCore::DOMWindow::setInlineEventListenerForType): (WebCore::DOMWindow::removeInlineEventListenerForType): (WebCore::DOMWindow::inlineEventListenerForType): (WebCore::DOMWindow::addPendingFrameUnloadEventCount): (WebCore::DOMWindow::removePendingFrameUnloadEventCount): (WebCore::DOMWindow::addPendingFrameBeforeUnloadEventCount): (WebCore::DOMWindow::removePendingFrameBeforeUnloadEventCount):
- page/DOMWindow.h: Moved a bunch of code to the DOMWindow class, from the Document.
- page/Frame.cpp: (WebCore::Frame::shouldClose): Updated for movement of window event listeners into the window.
- 12:05 PM Changeset in webkit [42445] by
-
- 4 edits in trunk/WebCore
2009-04-13 Greg Bolsinga <bolsinga@apple.com>
Reviewed by Sam Weinig.
The Geolocation timer needs to start after the UA has granted permission.
- bindings/js/JSGeolocationCustom.cpp: Use PassRefPtr<PositionOptions> (WebCore::JSGeolocation::getCurrentPosition): (WebCore::JSGeolocation::watchPosition):
- page/Geolocation.cpp: Add a RefPtr<PositionOptions> so it can be used later when the timer is started. Change PositionOptions* to PassRefPtr<PositionOptions> where needed. (WebCore::Geolocation::GeoNotifier::GeoNotifier): (WebCore::Geolocation::GeoNotifier::startTimer): (WebCore::Geolocation::getCurrentPosition): (WebCore::Geolocation::watchPosition): (WebCore::Geolocation::setIsAllowed): Start the timer is the UA allows (WebCore::Geolocation::startTimer): (WebCore::Geolocation::startTimersForOneShots): (WebCore::Geolocation::startTimersForWatchers): (WebCore::Geolocation::startTimers):
- page/Geolocation.h: (WebCore::Geolocation::GeoNotifier::create):
- 11:01 AM Changeset in webkit [42444] by
-
- 3 edits in trunk/WebCore
2009-04-13 Pamela Greene <pam@chromium.org>
Reviewed by Darin Fisher.
Fix Chromium (V8) build by renaming methods to match changes
in http://trac.webkit.org/changeset/42377.
- bindings/v8/ScheduledAction.cpp:
(WebCore::ScheduledAction::execute): updateRendering() -> updateStyleIfNeeded()
- bindings/v8/V8AbstractEventListener.cpp: (WebCore::V8AbstractEventListener::handleEvent): updateDocumentsRendering() -> updateStyleForAllDocuments()
- 10:52 AM Changeset in webkit [42443] by
-
- 2 edits in trunk/WebKitTools
2009-04-13 Darin Adler <Darin Adler>
- Scripts/make-js-test-wrappers: Added another exception.
- 10:47 AM Changeset in webkit [42442] by
-
- 3 edits5 adds in trunk
2009-04-13 Darin Fisher <darin@chromium.org>
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=25136
CRASH in DocumentLoader::removeSubresourceLoader due to null m_frame
Test: fast/frames/frame-unload-crash.html
- loader/DocumentLoader.cpp: (WebCore::DocumentLoader::updateLoading): Added null check of m_frame.
- 10:38 AM Changeset in webkit [42441] by
-
- 6 edits in trunk
WebCore:
2009-04-13 Sam Weinig <sam@webkit.org>
Reviewed by Tim Hatcher.
Put the MessagePort constructor back in ENABLE_CHANNEL_MESSAGING.
- page/DOMWindow.idl:
LayoutTests:
2009-04-13 Sam Weinig <sam@webkit.org>
Reviewed by Tim Hatcher.
Update test results after putting the MessagePort constructor
back in ENABLE_CHANNEL_MESSAGING.
- fast/dom/Window/window-properties-expected.txt:
- fast/js/global-constructors-expected.txt:
- platform/mac-leopard/fast/dom/Window/window-properties-expected.txt:
- 10:24 AM Changeset in webkit [42440] by
-
- 2 edits in trunk/WebCore
2009-04-13 Greg Bolsinga <bolsinga@apple.com>
Fix GTK build break.
- platform/gtk/GeolocationServiceGtk.cpp: (WebCore::GeolocationServiceGtk::updatePosition):
- 10:14 AM Changeset in webkit [42439] by
-
- 2 edits in trunk/WebCore
2009-04-13 David Hyatt <hyatt@apple.com>
Reviewed by Darin Adler and Dan Bernstein.
Assertion in updateStyleForAllDocuments. Make sure to unscheduleStyleRecalc when an object goes into
the page cache. Disallow scheduling of style recalcs on a document that is already in the page cache.
Schedule a style recalc if needed when an object comes out of the page cache.
- dom/Document.cpp: (WebCore::Document::scheduleStyleRecalc): (WebCore::Document::setInPageCache):
- 10:11 AM Changeset in webkit [42438] by
-
- 3 edits in trunk/WebCore
Correctly sort (program) scripts in the Scripts panel popup menu.
Reviewed by Ada Chan.
- inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel.prototype._addScriptToFilesMenu): Refactor the code and sort "(program)" options by the sourceID to maintain some order.
- inspector/front-end/utilities.js: (indexOfObjectInListSortedByFunction): Fix a bug where identical objects would cause an incorrect return value that confuses insertionIndexForObjectInListSortedByFunction. Just set 'first' and break so the correct result will be returned.
- 10:07 AM Changeset in webkit [42437] by
-
- 10 edits1 add in trunk/WebCore
2009-04-13 Greg Bolsinga <bolsinga@apple.com>
Reviewed by Darin Adler.
Add custom code for Coordinates that returns null when required by the
Geolocation spec.
- WebCore.xcodeproj/project.pbxproj:
- bindings/js/JSCoordinatesCustom.cpp: Added. (WebCore::JSCoordinates::altitude): returns null if the value cannot be provided. (WebCore::JSCoordinates::altitudeAccuracy): Ditto (WebCore::JSCoordinates::heading): Ditto (WebCore::JSCoordinates::speed): Ditto
- page/Coordinates.h: (WebCore::Coordinates::create): Add 'canProvide' parameters and values (WebCore::Coordinates::canProvideAltitude): (WebCore::Coordinates::canProvideAltitudeAccuracy): (WebCore::Coordinates::canProvideHeading): (WebCore::Coordinates::canProvideSpeed): (WebCore::Coordinates::Coordinates):
- page/Coordinates.idl: specify custom getters
- platform/mac/GeolocationServiceMac.mm: Set the values correctly if they cannot be provided. (-[WebCoreCoreLocationObserver locationManager:didUpdateToLocation:fromLocation:]):
- 9:27 AM Changeset in webkit [42436] by
-
- 2 edits in trunk/WebKit/gtk
2009-04-13 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
Reviewed by Holger Freyther.
https://bugs.webkit.org/show_bug.cgi?id=22898
[GTK] need proper API for printing
Added simple printing unit tests.
- tests/testwebframe.c: (print_requested_cb): (print_timeout): (test_webkit_web_frame_printing): (main):
- 9:26 AM Changeset in webkit [42435] by
-
- 6 edits in trunk/WebKit/gtk
2009-04-13 Gustavo Noronha Silva <Gustavo Noronha Silva>
Reviewed by Holger Freyther.
https://bugs.webkit.org/show_bug.cgi?id=22898
[GTK] need proper API for printing
Implement proper printing API, using the GTK+ printing API.
- WebCoreSupport/ChromeClientGtk.cpp: (WebKit::ChromeClient::print):
- webkit/webkitprivate.h:
- webkit/webkitwebframe.cpp:
- webkit/webkitwebframe.h:
- webkit/webkitwebview.cpp:
- 9:15 AM Changeset in webkit [42434] by
-
- 2 edits in trunk/LayoutTests
2009-04-13 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
Rubber-stamped by Holger Freyther.
Reworked the skipped tests listing so that it is easier to find
tests that are skipped but pass using diff. Enable all tests that
are passing, and disable failing tests except for a few crashers
and known regressions. This is an effort to make the build slave
output more useful when it is back.
- platform/gtk/Skipped:
- 8:12 AM Changeset in webkit [42433] by
-
- 3 edits4 adds in trunk
WebCore:
2009-04-13 Adele Peterson <adele@apple.com>
Reviewed by Darin Adler.
Fix for <rdar://problem/5510537> Typing return at start of block quote yields empty quoted line
Test: editing/inserting/5510537.html
- editing/BreakBlockquoteCommand.cpp: (WebCore::BreakBlockquoteCommand::doApply): If the break insertion position is at the beginning of the topmost quote, then just insert the <br> before the blockquote. Otherwise, if the break insertion position is at the beginning of any quote, adjust the position so the break comes before the current quote level so we don't end up with an empty line in that quote in addition to the new line we're adding with the <br>.
LayoutTests:
2009-04-13 Adele Peterson <adele@apple.com>
Reviewed by Darin Adler.
Test for <rdar://problem/5510537> Typing return at start of block quote yields empty quoted line
- editing/inserting/5510537.html: Added.
- platform/mac/editing/inserting/5510537-expected.checksum: Added.
- platform/mac/editing/inserting/5510537-expected.png: Added.
- platform/mac/editing/inserting/5510537-expected.txt: Added.
- 7:46 AM Changeset in webkit [42432] by
-
- 2 edits in trunk/WebCore
2009-04-11 Darin Adler <Darin Adler>
Reviewed by Dan Bernstein.
Fix problem when encoding history files with duplicate integer arrays near the end of the file.
This results in an assertion failure, and if assertions are turned off, corrupted output.
When writing an integer array it's important not to add an object reference to the
aggregate buffer. The writing of the array does not depend on the aggregate buffer. But,
more importantly, it's possible this instance integer array is a duplicate and won't be
written out. If so, there's no guarantee there's enough space in the aggregate buffer to
store the object references (the references will be ignored). In some cases the aggregate
buffer can then overrun the data being written; normally this is prevented by the fact that
the data being written will include a copy of the aggregate buffer.
Also removed a bit of unneeded dead code to handle the integer -1.
- platform/cf/BinaryPropertyList.cpp: (WebCore::BinaryPropertyListPlan::BinaryPropertyListPlan): Removed unneeded m_integerNegativeOneObjectReference, since property lists support only non-negative integers. (WebCore::BinaryPropertyListPlan::writeInteger): Removed support for m_integerNegativeOneObjectReference. (WebCore::BinaryPropertyListPlan::integerObjectReference): Ditto. (WebCore::BinaryPropertyListSerializer::writeIntegerWithoutAddingAggregateObjectReference): Added. Factored out most of writeInteger, for use in writeIntegerArray, without calling addAggregateObjectReference. (WebCore::BinaryPropertyListSerializer::writeInteger): Changed to call the new writeIntegerWithoutAddingAggregateObjectReference function. (WebCore::BinaryPropertyListSerializer::writeIntegerArray): Call the new writeIntegerWithoutAddingAggregateObjectReference function and therefore remove the code to save and restore m_currentAggregateBufferByte, which is no longer needed.
- 4:31 AM Changeset in webkit [42431] by
-
- 2 edits in trunk/WebCore
Unreviewed Qt build fix
Apr 12, 2009:
- 5:41 PM Changeset in webkit [42430] by
-
- 8 edits in trunk
WebCore:
2009-04-12 Sam Weinig <sam@webkit.org>
Reviewed by Mark Rowe.
Move the event and crypto attributes and the captureEvents and releaseEvents
functions out of JSDOMWindowBase by partially generating them.
- bindings/js/JSDOMGlobalObject.cpp: (WebCore::JSDOMGlobalObject::currentEvent): Make const.
- bindings/js/JSDOMGlobalObject.h:
- bindings/js/JSDOMWindowBase.cpp:
- bindings/js/JSDOMWindowCustom.cpp: (WebCore::JSDOMWindow::crypto): Not implemented. (WebCore::JSDOMWindow::event): (WebCore::JSDOMWindow::captureEvents): Not implemented. (WebCore::JSDOMWindow::releaseEvents): Ditto.
- page/DOMWindow.idl:
LayoutTests:
2009-04-12 Sam Weinig <sam@webkit.org>
Reviewed by Mark Rowe.
Update test result for new nop window.crypto behavior.
- http/tests/security/cross-frame-access-get-expected.txt:
- 4:42 PM Changeset in webkit [42429] by
-
- 4 edits in trunk/LayoutTests
2009-04-12 Sam Weinig <sam@webkit.org>
Update results.
- fast/dom/Window/window-properties-expected.txt:
- fast/js/global-constructors-expected.txt:
- platform/mac-leopard/fast/dom/Window/window-properties-expected.txt:
- 4:10 PM Changeset in webkit [42428] by
-
- 10 edits in trunk
WebCore:
2009-04-12 Sam Weinig <sam@webkit.org>
Reviewed by Mark Rowe.
Move more attributes out of JSDOMWindowBase by
partially generating them.
- Expose the MessagePort constructor.
- bindings/js/JSDOMGlobalObject.h: (WebCore::getDOMConstructor):
- bindings/js/JSDOMWindowBase.cpp: (setJSDOMWindowBaseEvent):
- bindings/js/JSDOMWindowCustom.cpp: (WebCore::JSDOMWindow::image): (WebCore::JSDOMWindow::option): (WebCore::JSDOMWindow::audio): (WebCore::JSDOMWindow::webKitPoint): (WebCore::JSDOMWindow::webKitCSSMatrix): (WebCore::JSDOMWindow::xMLHttpRequest): (WebCore::JSDOMWindow::xSLTProcessor): (WebCore::JSDOMWindow::messageChannel): (WebCore::JSDOMWindow::worker):
- page/DOMWindow.idl:
LayoutTests:
2009-04-12 Sam Weinig <sam@webkit.org>
Reviewed by Mark Rowe.
Update tests after making MessageChannel completely missing when not
compiling with support for it (and removing it from the tests because
we never compile with support for it right now) and exposing the MessagePort
constructor.
- fast/dom/constructors-cached-expected.txt:
- fast/dom/dom-constructors-expected.txt:
- fast/dom/dom-constructors.html:
- fast/dom/resources/constructors-cached.js:
- platform/mac-leopard/fast/dom/Window/window-properties-expected.txt:
- 10:57 AM Changeset in webkit [42427] by
-
- 2 edits in trunk/WebCore
A resource's filename is not correct after a redirect in the Inspector.
Reviewed by Dan Bernstein.
- inspector/InspectorResource.cpp: (WebCore::InspectorResource::updateScriptObject): Fix a typo in the lastPathComponent property name.
- 9:24 AM Changeset in webkit [42426] by
-
- 3 edits2 adds in trunk
WebCore:
2009-04-12 Adele Peterson <adele@apple.com>
Reviewed by Darin Adler.
Test: editing/inserting/6609479-1.html
Follow-up to <rdar://problem/6609479>.
Before my last change, a Mail blockquote would've been broken up earlier, and you would've been guaranteed that the inserted content
was at the start of a paragraph. Now we need to check for that explicitly, and only merge the start of the inserted content if it is
at the start of a paragraph.
- editing/ReplaceSelectionCommand.cpp: (WebCore::ReplaceSelectionCommand::shouldMergeStart):
LayoutTests:
2009-04-12 Adele Peterson <adele@apple.com>
Reviewed by Darin Adler.
Another test for <rdar://problem/6609479>. This covers inserting HTML in a quoted table.
- editing/inserting/6609479-1-expected.txt: Added.
- editing/inserting/6609479-1.html: Added.
