⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Apr 16, 2009:

11:20 PM Changeset in webkit [42606] by Stephanie Lewis
  • 5 edits in trunk/JavaScriptCore

2009-04-16 Stephanie Lewis <Stephanie Lewis>

Reviewed by Oliver Hunt.

<rdar://problem/6744652> 32-bit to 64-bit: Javascript hash tables double in size

Remove perfect hash optimization which removes 1 MB of overhead on 32-bit and almost 2 MB on 64-bit. Removing the optimization was not a regression on SunSpider and the acid 3 test still passes.

  • create_hash_table:
  • runtime/Lookup.cpp: (JSC::HashTable::createTable): (JSC::HashTable::deleteTable):
  • runtime/Lookup.h: (JSC::HashEntry::initialize): (JSC::HashEntry::next): (JSC::HashTable::entry):
  • runtime/Structure.cpp: (JSC::Structure::getEnumerableNamesFromClassInfoTable):
9:41 PM Changeset in webkit [42605] by oliver@apple.com
  • 3 edits in trunk/JavaScriptCore

Fix subtle error in optimised VM reentry in Array.sort

Reviewed by Gavin Barraclough

Basically to ensure we don't accidentally invalidate the cached callframe
we should be using the cached callframe rather than our own exec state.
While the old behaviour was wrong i have been unable to actually create a
test case where anything actually ends up going wrong.

9:23 PM Changeset in webkit [42604] by Dimitri Glazkov
  • 2 edits in trunk/WebCore

2009-04-16 Eric Roman <​eroman@chromium.org>

Reviewed by Dimitri Glazkov.

​https://bugs.webkit.org/show_bug.cgi?id=25196
Add a missing V8DOMMap include.

  • bindings/v8/WorkerScriptController.cpp: Included V8DOMMap.h.
9:19 PM Changeset in webkit [42603] by Dimitri Glazkov
  • 2 edits in trunk/WebCore

2009-04-16 Dimitri Glazkov <Dimitri Glazkov>

Reviewed by Darin Fisher.

​https://bugs.webkit.org/show_bug.cgi?id=25260
Finish V8 custom bindings for InspectorController.

  • bindings/v8/custom/V8InspectorControllerCustom.cpp: (WebCore::CALLBACK_FUNC_DECL): Added.
8:10 PM Changeset in webkit [42602] by alice.liu@apple.com
  • 2 edits in trunk/WebKit/win

2009-04-16 Alice Liu <​alice.liu@apple.com>

Reviewed by Mark Rowe.

Fix for heavy leakage of WebURLResponses seen during the stress test

  • WebCoreSupport/WebFrameLoaderClient.cpp: (WebFrameLoaderClient::shouldCacheResponse):
6:36 PM Changeset in webkit [42601] by kevino@webkit.org
  • 4 edits in trunk/WebCore

Reviewed by Kevin Ollivier.

Switch to wxGraphicsBitmap when using wxGraphicsContext so that we're not doing unnecessary conversions internally when drawing bitmaps.

​https://bugs.webkit.org/show_bug.cgi?id=25248

6:23 PM Changeset in webkit [42600] by justin.garcia@apple.com
  • 3 edits
    2 adds in trunk

WebCore:

2009-04-16 Justin Garcia <​justin.garcia@apple.com>

Reviewed by Dan Bernstein.

Performing a block style change in an editable root that contains only a br adds a newline
​https://bugs.webkit.org/show_bug.cgi?id=25256

  • editing/CompositeEditCommand.cpp: (WebCore::CompositeEditCommand::moveParagraphContentsToNewBlockIfNecessary): Fix a bad check for an root block that didn't handle a root that contained a placeholder.

LayoutTests:

2009-04-16 Justin Garcia <​justin.garcia@apple.com>

Reviewed by Dan Bernstein.


Performing a block style change in an editable root that contains only a br adds a newline
​https://bugs.webkit.org/show_bug.cgi?id=25256

  • editing/execCommand/25256-expected.txt: Added.
  • editing/execCommand/25256.html: Added.
5:34 PM Changeset in webkit [42599] by eric@webkit.org
  • 18 edits in trunk

Reviewed by Simon Fraser.

Fix computeContainerBoundingBox to respect viewport translations
​https://bugs.webkit.org/show_bug.cgi?id=25254

Previously computeContainerBoundingBox was just adding the viewportTranslation.
Which, although it has a confusing name, only contains the scale and translation
for the viewBox/preserveAspectRatio adjustment. It does not contain the
translation for the x/y offset of the viewport.
localToParentTransform() does contain this offset, so we use that instead
of the previous hacky code.

  • rendering/RenderSVGContainer.h:
  • rendering/RenderSVGViewportContainer.h:
  • rendering/SVGRenderSupport.cpp: (WebCore::computeContainerBoundingBox):
4:27 PM Changeset in webkit [42598] by eric@webkit.org
  • 14 edits in trunk/WebCore

Reviewed by Simon Fraser.

Add a localToParentTransform() method which includes the
full transform between local and parent local coordinates.
​https://bugs.webkit.org/show_bug.cgi?id=25226

Moved m_localTransform up into RenderSVGTransformableContainer
and added a comment to RenderSVGViewportContainer to make it more
clear that it does not have a localTransform().

This patch reveals two more failed design decisions:

  1. Use of RenderBox::absoluteTransform() to mean "absoluteTransform()

including only my localTransform()" callers are probably using it
incorrectly anyway and are just masking bugs in the confused code.

  1. computeContainerBoundingBox does not include viewport translations in

its computed bounding box, so bounding boxes will be off for parents of
inner <svg> elements. I'll fix this an updated the results in a separate change.

No functional changes, thus no tests.

  • rendering/RenderObject.cpp: (WebCore::RenderObject::localToParentTransform): (WebCore::RenderObject::absoluteTransform):
  • rendering/RenderObject.h:
  • rendering/RenderSVGContainer.cpp: (WebCore::RenderSVGContainer::layout):
  • rendering/RenderSVGContainer.h: (WebCore::RenderSVGContainer::viewportTransform):
  • rendering/RenderSVGHiddenContainer.cpp:
  • rendering/RenderSVGHiddenContainer.h: (WebCore::RenderSVGHiddenContainer::absoluteTransform):
  • rendering/RenderSVGRoot.cpp: (WebCore::RenderSVGRoot::localToParentTransform): (WebCore::RenderSVGRoot::absoluteTransform):
  • rendering/RenderSVGRoot.h:
  • rendering/RenderSVGTransformableContainer.cpp: (WebCore::RenderSVGTransformableContainer::localToParentTransform): (WebCore::RenderSVGTransformableContainer::localTransform):
  • rendering/RenderSVGTransformableContainer.h:
  • rendering/RenderSVGViewportContainer.cpp: (WebCore::RenderSVGViewportContainer::localToParentTransform): (WebCore::RenderSVGViewportContainer::absoluteTransform):
  • rendering/RenderSVGViewportContainer.h:
  • rendering/SVGRenderSupport.cpp: (WebCore::computeContainerBoundingBox):
3:29 PM Changeset in webkit [42597] by darin@chromium.org
  • 3 edits in trunk/WebCore

2009-04-16 Adam Langley <​agl@google.com>

Reviewed by Darin Fisher.

Fix Chromium's rendering of <option> elements inside of <optgroups>.

​https://bugs.webkit.org/show_bug.cgi?id=25244

Test (will included as a manual test by ​https://bugs.webkit.org/show_bug.cgi?id=24900):

<select>

<optgroup label="Should be bold">

<option>Should not be bold</option>

</optgroup>

</select>

  • css/themeWin.css: adding comments
  • platform/chromium/PopupMenuChromium.cpp: (WebCore::PopupListBox::getRowFont): use menuStyle() rather than the item's style
3:25 PM Changeset in webkit [42596] by zecke@webkit.org
  • 3 edits in trunk/WebKit/qt

2009-04-16 Holger Hans Peter Freyther <​zecke@selfish.org>

Rubber-stamped by Simon Hausmann.

Make the operator== and operator!= non inline to
allow looking at the d-pointer in the future.

  • Api/qwebelement.cpp: (QWebElement::operator==): (QWebElement::operator!=):
  • Api/qwebelement.h:
3:17 PM Changeset in webkit [42595] by xan@webkit.org
  • 2 edits in trunk/WebKit/win

2009-04-16 Xan Lopez <​xlopez@igalia.com>

Unreviewed build fix.

  • WebView.cpp:
3:13 PM Changeset in webkit [42594] by ggaren@apple.com
  • 2 edits in trunk/WebKitTools

2009-04-16 Geoffrey Garen <​ggaren@apple.com>

Build fix: updated check-for-global-initializers to account for code motion.

  • Scripts/check-for-global-initializers:
3:12 PM Changeset in webkit [42593] by darin@chromium.org
  • 2 edits in trunk/WebCore

2009-04-16 Eric Roman <​eroman@chromium.org>

Reviewed by Alexey Proskuryakov.

​https://bugs.webkit.org/show_bug.cgi?id=25218

Make DOMWindow::inlineEventListenerForType not have the "inline"
keyword. As this method gets used outside of DOMWindow.

  • page/DOMWindow.cpp: (WebCore::DOMWindow::inlineEventListenerForType):
3:02 PM Changeset in webkit [42592] by bolsinga@apple.com
  • 2 edits in trunk/WebCore

2009-04-16 Greg Bolsinga <​bolsinga@apple.com>

Reviewed by Antti Koivisto.

Fix <rdar://problem/6766969>


When deferred repaints are enabled and being reset and there is a active
timer, stop the timer and do the deferred repaints immediately.

  • page/FrameView.cpp: (WebCore::FrameView::resetDeferredRepaintDelay):
3:01 PM Changeset in webkit [42591] by christian@webkit.org
  • 2 edits in trunk/WebKit/gtk

2009-04-16 Christian Dywan <​christian@twotoasts.de>

Reviewed by Holger Freyther.

​http://bugs.webkit.org/show_bug.cgi?id=25042
destroying webview widget directly causes crash.

  • tests/testwebframe.c: (test_webkit_web_frame_create_destroy): Add a test case for destroying a web view shortly after packing it in a window.
2:53 PM Changeset in webkit [42590] by xan@webkit.org
  • 50 edits in trunk

WebCore:

2009-04-16 Xan Lopez <​xlopez@igalia.com>

Reviewed by Sam Weinig.

​https://bugs.webkit.org/show_bug.cgi?id=25241
Remove superfluous NotImplemented.h includes.

  • html/CanvasRenderingContext2D.cpp:
  • html/CanvasStyle.cpp:
  • page/AccessibilityRenderObject.cpp:
  • platform/chromium/ScrollbarThemeChromiumLinux.cpp:
  • platform/graphics/GraphicsContext.cpp:
  • platform/graphics/cairo/ImageBufferCairo.cpp:
  • platform/graphics/cairo/PathCairo.cpp:
  • platform/graphics/chromium/SimpleFontDataLinux.cpp:
  • platform/graphics/gtk/FontGtk.cpp:
  • platform/graphics/gtk/IconGtk.cpp:
  • platform/graphics/qt/IconQt.cpp:
  • platform/graphics/qt/ImageQt.cpp:
  • platform/graphics/qt/ImageSourceQt.cpp:
  • platform/graphics/skia/ImageBufferSkia.cpp:
  • platform/graphics/skia/ImageSkia.cpp:
  • platform/graphics/win/ColorSafari.cpp:
  • platform/graphics/win/FontWin.cpp:
  • platform/graphics/win/GraphicsContextCGWin.cpp:
  • platform/graphics/win/GraphicsContextCairoWin.cpp:
  • platform/graphics/win/SimpleFontDataCairoWin.cpp:
  • platform/graphics/wx/ImageWx.cpp:
  • platform/graphics/wx/TransformationMatrixWx.cpp:
  • platform/gtk/PlatformScreenGtk.cpp:
  • platform/gtk/PopupMenuGtk.cpp:
  • platform/gtk/ScrollViewGtk.cpp:
  • platform/gtk/ScrollbarGtk.cpp:
  • platform/network/cf/ResourceHandleCFNet.cpp:
  • platform/posix/FileSystemPOSIX.cpp:
  • platform/qt/DragDataQt.cpp:
  • platform/qt/FileSystemQt.cpp:
  • platform/qt/Localizations.cpp:
  • platform/qt/PopupMenuQt.cpp:
  • platform/win/EditorWin.cpp:
  • platform/win/PasteboardWin.cpp:
  • platform/wx/KeyboardEventWx.cpp:
  • platform/wx/PopupMenuWx.cpp:
  • platform/wx/SharedTimerWx.cpp:
  • plugins/gtk/PluginViewGtk.cpp:
  • plugins/mac/PluginPackageMac.cpp:
  • plugins/qt/PluginPackageQt.cpp:
  • plugins/win/PluginViewWin.cpp:
  • rendering/RenderThemeChromiumLinux.cpp:
  • svg/graphics/SVGImage.cpp:

WebKit/gtk:

2009-04-16 Xan Lopez <​xlopez@igalia.com>

Reviewed by Sam Weinig.

​https://bugs.webkit.org/show_bug.cgi?id=25241
Remove superfluous NotImplemented.h includes.

  • webkit/webkitprivate.cpp:

WebKit/win:

2009-04-16 Xan Lopez <​xlopez@igalia.com>

Reviewed by Sam Weinig.

​https://bugs.webkit.org/show_bug.cgi?id=25241
Remove superfluous NotImplemented.h includes

  • WebDownloadCFNet.cpp:
  • WebURLAuthenticationChallengeSender.cpp:
  • WebView.cpp:
2:19 PM Changeset in webkit [42589] by ggaren@apple.com
  • 12 edits in trunk/WebCore

2009-04-16 Geoffrey Garen <​ggaren@apple.com>

Reviewed by Sam Weinig.

More fix for ​https://bugs.webkit.org/show_bug.cgi?id=21260
Unbounded memory growth when churning elements with anonymous event handler functions


Some cleanup in event handling code.

  • bindings/js/JSDOMGlobalObject.cpp:
  • bindings/js/JSDOMGlobalObject.h: Removed findJSProtectedEventListener and findJSProtectedEventListener because they are now unused.
  • bindings/js/JSEventListener.cpp:
  • bindings/js/JSEventListener.h: (WebCore::JSEventListener::clearGlobalObject):
  • bindings/js/JSLazyEventListener.cpp: (WebCore::JSLazyEventListener::JSLazyEventListener): (WebCore::JSLazyEventListener::~JSLazyEventListener): (WebCore::JSLazyEventListener::globalObject):
  • bindings/js/JSLazyEventListener.h: (WebCore::JSLazyEventListener::clearGlobalObject): Nixed JSProtectedEventListener, and merged it with JSLazyEventListener, the only remaining event listener that still GC-protects its function and global object.
  • bindings/js/ScriptController.cpp: (WebCore::ScriptController::ScriptController):
  • bindings/js/ScriptController.h: (WebCore::ScriptController::setEventHandlerLineNumber): (WebCore::ScriptController::eventHandlerLineNumber): Renamed handlerLineno => handlerLineNumber, because anything less would be uncivilized. Removed createInlineEventListener because it mostly did irrelevent work, so it just got in the way of understanding how event handler creation works.
  • dom/Document.cpp: (WebCore::Document::createEventListener):
  • dom/XMLTokenizerLibxml2.cpp: (WebCore::XMLTokenizer::startElementNs):
  • html/HTMLTokenizer.cpp: (WebCore::HTMLTokenizer::processToken): Ditto.
2:19 PM Changeset in webkit [42588] by justin.garcia@apple.com
  • 1 add in trunk/LayoutTests/platform/mac/fast/forms/caret-rtl-expected.png

Checking in pixel results for a recently added test.

1:58 PM Changeset in webkit [42587] by Beth Dakin
  • 1 edit in trunk/WebCore/ChangeLog

2009-04-16 Beth Dakin <Beth Dakin>

Reviewed by Dave Hyatt.

Fix for ​https://bugs.webkit.org/show_bug.cgi?id=20765 Website
crashes on load due to messy HTML in search form
-and corresponding-
<rdar://problem/6210633>

Before this patch, <form>s were allowed to sit inside tables
without being wrapped by anonymous table parts. There was also a
concept that such a form could be "demoted" and would not be
allowed to have any children. This patch has the HTML parser mark
form elements that have been demoted as such, and then the demoted
forms are not given renderers. I also removed the code that allowed
forms to sit in tables without anonymous table sections. So now any
forms that do manage to get a renderer inside a table will also be
wrapped with appropriate table parts.

  • html/HTMLFormElement.cpp: (WebCore::HTMLFormElement::HTMLFormElement): (WebCore::HTMLFormElement::rendererIsNeeded):
  • html/HTMLFormElement.h: (WebCore::HTMLFormElement::setDemoted): (WebCore::HTMLFormElement::isDemoted):
  • html/HTMLParser.cpp: (WebCore::HTMLParser::insertNode):
  • rendering/RenderTable.cpp: (WebCore::RenderTable::addChild):
  • rendering/RenderTableRow.cpp: (WebCore::RenderTableRow::addChild):
  • rendering/RenderTableSection.cpp: (WebCore::RenderTableSection::addChild):
1:48 PM Changeset in webkit [42586] by Beth Dakin
  • 25 edits
    8 adds in trunk

WebCore:

2009-04-16 Beth Dakin <Beth Dakin>

Reviewed by Dave Hyatt.

Fix for ​https://bugs.webkit.org/show_bug.cgi?id=20765 Website
crashes on load due to messy HTML in search form
-and corresponding-
<rdar://problem/6210633>

Before this patch, <form>s were allowed to sit inside tables
without being wrapped by anonymous table parts. There was also a
concept that such a from could be "demoted" and would not be
allowed to have any children. This patch has the HTML parser mark
form elements that have been demoted as such, and then the demoted
forms are not given renderers. I also removed the code that allowed
forms to sit in tables without anonymous table sections. So now any
forms that do manage to get a renderer inside a table will also be
wrapped with appropriate table parts.

  • html/HTMLFormElement.cpp: (WebCore::HTMLFormElement::HTMLFormElement): (WebCore::HTMLFormElement::rendererIsNeeded):
  • html/HTMLFormElement.h: (WebCore::HTMLFormElement::setDemoted): (WebCore::HTMLFormElement::isDemoted):
  • html/HTMLParser.cpp: (WebCore::HTMLParser::insertNode):
  • rendering/RenderTable.cpp: (WebCore::RenderTable::addChild):
  • rendering/RenderTableRow.cpp: (WebCore::RenderTableRow::addChild):
  • rendering/RenderTableSection.cpp: (WebCore::RenderTableSection::addChild):

LayoutTests:

2009-04-16 Beth Dakin <Beth Dakin>

Reviewed by Dave Hyatt.

Tests for ​https://bugs.webkit.org/show_bug.cgi?id=20765 Website
crashes on load due to messy HTML in search form
-and corresponding-
<rdar://problem/6210633>

New tests:

  • fast/forms/form-added-to-table.html: Added.
  • fast/forms/form-in-malformed-markup.html: Added.
  • platform/mac/fast/forms/form-added-to-table-expected.checksum: Added.
  • platform/mac/fast/forms/form-added-to-table-expected.png: Added.
  • platform/mac/fast/forms/form-added-to-table-expected.txt: Added.
  • platform/mac/fast/forms/form-in-malformed-markup-expected.checksum: Added.
  • platform/mac/fast/forms/form-in-malformed-markup-expected.png: Added.
  • platform/mac/fast/forms/form-in-malformed-markup-expected.txt: Added.

Tests with new results:

  • platform/mac/fast/forms/formmove3-expected.txt:
  • platform/mac/fast/forms/preserveFormDuringResidualStyle-expected.txt:
  • platform/mac/fast/invalid/table-residual-style-crash-expected.txt:
  • platform/mac/fast/table/fixed-table-non-cell-in-row-expected.txt:
  • platform/mac/fast/table/inline-form-assert-expected.txt:
  • platform/mac/fast/table/insert-cell-before-form-expected.txt:
  • platform/mac/fast/table/insert-row-before-form-expected.txt:
  • platform/mac/tables/mozilla/bugs/bug1318-expected.txt:
  • platform/mac/tables/mozilla/bugs/bug2516-expected.txt:
  • platform/mac/tables/mozilla/bugs/bug30559-expected.txt:
  • platform/mac/tables/mozilla/bugs/bug32447-expected.txt:
  • platform/mac/tables/mozilla/bugs/bug34538-expected.txt:
  • platform/mac/tables/mozilla/bugs/bug4527-expected.txt:
  • platform/mac/tables/mozilla/bugs/bug78162-expected.txt:
  • platform/mac/tables/mozilla/bugs/bug96334-expected.txt:
  • platform/mac/tables/mozilla/bugs/bug96343-expected.txt:
  • platform/mac/tables/mozilla_expected_failures/bugs/bug1725-expected.txt:
1:02 PM Changeset in webkit [42585] by darin@chromium.org
  • 3 edits
    3 adds in trunk

2009-04-16 Xiaomei Ji <​xji@chromium.org>

Reviewed by Simon Fraser.

Fix ​https://bugs.webkit.org/show_bug.cgi?id=24527
caret does not paint the first time you focus on a 0px right padding RTL div

Test: fast/forms/caret-rtl.html

  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::localCaretRect): When calculating x-axis if alignment is alignRight, we need to subtract the caretWidth so that the caret at IntRect(x, y, caretWidth, height) is inside the block.
11:41 AM Changeset in webkit [42584] by justin.garcia@apple.com
  • 1 add
    1 delete in trunk/LayoutTests

Moving this test to platform/mac, it's mac only.

11:11 AM Changeset in webkit [42583] by justin.garcia@apple.com
  • 4 edits
    4 adds in trunk

WebCore:

2009-04-16 Justin Garcia <​justin.garcia@apple.com>

Reviewed by Simon Fraser.

​https://bugs.webkit.org/show_bug.cgi?id=25228
SelectionController::absoluteCaretBounds returns an inflated caret (the caret repaint rect)


Return the bounds of the transformed caret, not the transformed repaint rect for the caret (which is inflated).

  • editing/SelectionController.cpp: (WebCore::SelectionController::localCaretRect): (WebCore::SelectionController::absoluteBoundsForLocalRect): (WebCore::SelectionController::caretRepaintRect): (WebCore::SelectionController::recomputeCaretRect):
  • editing/SelectionController.h:

LayoutTests:

2009-04-16 Justin Garcia <​justin.garcia@apple.com>

Reviewed by Simon Fraser.


​https://bugs.webkit.org/show_bug.cgi?id=25228
SelectionController::absoluteCaretBounds returns an inflated caret (the caret repaint rect)

  • editing/selection/25228.html: Added.
  • platform/mac/editing/selection/25228-expected.checksum: Added.
  • platform/mac/editing/selection/25228-expected.png: Added.
  • platform/mac/editing/selection/25228-expected.txt: Added.
11:11 AM Changeset in webkit [42582] by kov@webkit.org
  • 2 edits in trunk/WebKitTools

2009-04-16 Zan Dobersek <​zandobersek@gmail.com>

Reviewed by Adam Roben.

Compare test's response mime type and dump test as text properly.

  • DumpRenderTree/gtk/DumpRenderTree.cpp: (dump):
11:00 AM Changeset in webkit [42581] by eric.carlson@apple.com
  • 2 edits in trunk/WebCore

2009-04-16 Pierre d'Herbemont <​pdherbemont@apple.com>

Reviewed by Simon Fraser.

​https://bugs.webkit.org/show_bug.cgi?id=25187
Bug 25187: <video> may not be rendered upon certain racy conditions

Always create the video renderer when the load state reaches QTMovieLoadStateLoaded
and the element is visible, not only when the movie has just been opened.

  • platform/graphics/mac/MediaPlayerPrivateQTKit.mm: (WebCore::MediaPlayerPrivate::updateStates): Make sure we do not make false assumption on the state changes order. Create the renderer if none is present, when movie is loaded instead.
10:24 AM Changeset in webkit [42580] by eric@webkit.org
  • 5 edits in trunk/WebCore

Reviewed by Geoffrey Garen.

Add filterBoundingBox() to RenderSVGModelObject to share a tiny bit of code

RenderSVGModelObject has much more interesting code it can share,
but I'm just trying to get the commits out of my local branch and into
the repository in any order I can. :) This one was small.

This will be used by the unified RenderSVGModelObject
clippedOverflowRectForRepaint patch coming soon.

  • rendering/RenderPath.cpp: (WebCore::RenderPath::clippedOverflowRectForRepaint):
  • rendering/RenderSVGContainer.cpp: (WebCore::RenderSVGContainer::clippedOverflowRectForRepaint):
  • rendering/RenderSVGModelObject.cpp: (WebCore::RenderSVGModelObject::filterBoundingBox):
  • rendering/RenderSVGModelObject.h:
10:11 AM Changeset in webkit [42579] by ggaren@apple.com
  • 7 edits in trunk/WebCore

2009-04-16 Geoffrey Garen <​ggaren@apple.com>

Reviewed by Eric Seidel and Adam Roben.

More fix for ​https://bugs.webkit.org/show_bug.cgi?id=21260
Unbounded memory growth when churning elements with anonymous event handler functions


Simplified some EventHandler creation code.


Removed a pile of code whose sole purpose was to allow SVG event handlers
to supply a parameter named "evt" instead of the normal "event", and
replaced it with a single parameter to JSLazyEventListener's constructor
specifying the parameter name to use.

  • bindings/js/JSDOMWindowBase.h:
  • bindings/js/JSLazyEventListener.cpp: (WebCore::JSLazyEventListener::JSLazyEventListener): (WebCore::JSLazyEventListener::parseCode):
  • bindings/js/JSLazyEventListener.h: (WebCore::JSLazyEventListener::create):
  • bindings/js/ScriptController.cpp: (WebCore::ScriptController::createInlineEventListener):
  • bindings/js/ScriptController.h:
  • dom/Document.cpp: (WebCore::Document::createEventListener):
10:09 AM Changeset in webkit [42578] by eric@webkit.org
  • 28 edits in trunk/WebCore

Reviewed by David Hyatt.

Split out objectBoundingBox and repaintRectInLocalCoordinates from relativeBBox
in preparation for simplifying (and fixing) repaint logic in the SVG rendering tree.
​https://bugs.webkit.org/show_bug.cgi?id=25224

objectBoundingBox() matches the SVG 1.1 concept of a "bounding box"

repaintRectInLocalCoordinates() should return the a rect covering all painted content.
However, repaintRectInLocalCoordinates() still only returns the "stroke bounding box"
in this patch. In a future patch, repaintRectInLocalCoordinates will be fixed to return
a rect covering all painted content. In order to avoid changing several hundred layout test results, I've left
the behavior as-is for now. The returned rect is used by various repaintRectInLocalCoordinates
implementations and sometimes adjusted to include all painted content, but not always, and
the places where the adjustments are made are sometimes wrong. Again, will be fixed in
an upcoming patch.

This patch discovered a bug in Font::drawTextUsingSVGFont, which is probably causing
bounding-box relative gradients on SVGFont glyphs to not paint correctly.
I chose not to try and fix the bug in this patch and instead left a FIXME.

This patch also discovered that at least tspan.getBBox() is broken. This
along with the foreignObject.getBBox() change will be tested (and fixed) in a
later patch. ​https://bugs.webkit.org/show_bug.cgi?id=25225

No change in behavior (besides the above mentioned foreignObject.getBBox()), thus no tests.

  • rendering/RenderForeignObject.cpp: (WebCore::RenderForeignObject::objectBoundingBox): this is a behavior improvement for getBBox() test case coming in a later patch (WebCore::RenderForeignObject::repaintRectInLocalCoordinates): only really used for layout test results, might some day be used for repaint.
  • rendering/RenderForeignObject.h:
  • rendering/RenderObject.cpp: (WebCore::RenderObject::objectBoundingBox): new methods, ASSERT if used but not implemented. (WebCore::RenderObject::repaintRectInLocalCoordinates):
  • rendering/RenderObject.h:
  • rendering/RenderPath.cpp: (WebCore::RenderPath::objectBoundingBox): (WebCore::RenderPath::repaintRectInLocalCoordinates): (WebCore::RenderPath::clippedOverflowRectForRepaint): (WebCore::RenderPath::lineHeight): (WebCore::RenderPath::baselinePosition): (WebCore::RenderPath::paint): (WebCore::RenderPath::addFocusRingRects):
  • rendering/RenderPath.h:
  • rendering/RenderSVGContainer.cpp: (WebCore::RenderSVGContainer::paint): (WebCore::RenderSVGContainer::objectBoundingBox): (WebCore::RenderSVGContainer::repaintRectInLocalCoordinates):
  • rendering/RenderSVGContainer.h:
  • rendering/RenderSVGGradientStop.h: (WebCore::RenderSVGGradientStop::objectBoundingBox): (WebCore::RenderSVGGradientStop::repaintRectInLocalCoordinates):
  • rendering/RenderSVGHiddenContainer.cpp: (WebCore::RenderSVGHiddenContainer::objectBoundingBox): (WebCore::RenderSVGHiddenContainer::repaintRectInLocalCoordinates):
  • rendering/RenderSVGHiddenContainer.h:
  • rendering/RenderSVGImage.cpp: (WebCore::RenderSVGImage::objectBoundingBox): (WebCore::RenderSVGImage::repaintRectInLocalCoordinates): (WebCore::RenderSVGImage::calculateAbsoluteBounds): (WebCore::RenderSVGImage::addFocusRingRects):
  • rendering/RenderSVGImage.h:
  • rendering/RenderSVGRoot.cpp: (WebCore::RenderSVGRoot::paint): (WebCore::RenderSVGRoot::objectBoundingBox): (WebCore::RenderSVGRoot::repaintRectInLocalCoordinates):
  • rendering/RenderSVGRoot.h:
  • rendering/RenderSVGTSpan.h: (WebCore::RenderSVGTSpan::objectBoundingBox): (WebCore::RenderSVGTSpan::repaintRectInLocalCoordinates):
  • rendering/RenderSVGText.cpp: (WebCore::RenderSVGText::clippedOverflowRectForRepaint): (WebCore::RenderSVGText::absoluteRects): (WebCore::RenderSVGText::absoluteQuads): (WebCore::RenderSVGText::objectBoundingBox): (WebCore::RenderSVGText::repaintRectInLocalCoordinates):
  • rendering/RenderSVGText.h:
  • rendering/RenderSVGViewportContainer.cpp: (WebCore::RenderSVGViewportContainer::viewportTransform):
  • rendering/SVGRenderSupport.cpp: (WebCore::computeContainerBoundingBox):
  • rendering/SVGRenderSupport.h:
  • rendering/SVGRenderTreeAsText.cpp: (WebCore::operator<<):
  • svg/SVGFont.cpp: (WebCore::Font::drawTextUsingSVGFont):
  • svg/SVGLocatable.cpp: (WebCore::SVGLocatable::getBBox):
  • svg/SVGPatternElement.cpp: (WebCore::SVGPatternElement::buildPattern):
  • svg/graphics/SVGPaintServerGradient.cpp: (WebCore::createMaskAndSwapContextForTextGradient): (WebCore::clipToTextMask): (WebCore::SVGPaintServerGradient::setup):
  • svg/graphics/SVGPaintServerPattern.cpp: (WebCore::SVGPaintServerPattern::setup):
8:42 AM Changeset in webkit [42577] by mitz@apple.com
  • 3 edits
    4 adds in trunk

WebCore:

Reviewed by Darin Adler.

  • fix <rdar://problem/6032139> Table cell widths calculated incorrectly on table that uses table-layout:fixed, colspans, and a mix of percentage and pixel widths

Test: fast/table/fixed-granular-cols.html

The incorrect widths resulted from incorrect handling of the case where
the <col> elements are more granular than the table cells.

  • rendering/FixedTableLayout.cpp: (WebCore::FixedTableLayout::calcWidthArray): When processing <col> elements, append effective columns or split existing effective columns as needed.

LayoutTests:

Reviewed by Darin Adler.

  • test for <rdar://problem/6032139> Table cell widths calculated incorrectly on table that uses table-layout:fixed, colspans, and a mix of percentage and pixel widths
  • fast/table/fixed-granular-cols.html: Added.
  • platform/mac/fast/table/fixed-granular-cols-expected.checksum: Added.
  • platform/mac/fast/table/fixed-granular-cols-expected.png: Added.
  • platform/mac/fast/table/fixed-granular-cols-expected.txt: Added.
8:40 AM Changeset in webkit [42576] by Adam Roben
  • 2 edits in trunk/WebKitTools

Skip yet another JavaScriptCore test that sometimes fails on Windows

See Bug 25160: Various ecma/Date tests sometimes fail on Windows (but
not Mac)
<​https://bugs.webkit.org/show_bug.cgi?id=25160>

  • Scripts/run-javascriptcore-tests: Skip ecma/Date/15.9.2.2-6.js.
5:01 AM Changeset in webkit [42575] by oliver@apple.com
  • 2 edits in trunk/JavaScriptCore

Optimise op_resolve_base

Reviewed by Gavin Barraclough.

If we can statically find a property we are trying to resolve
the base of, the base is guaranteed to be the global object.

4:36 AM Changeset in webkit [42574] by oliver@apple.com
  • 3 edits in trunk/JavaScriptCore

Improve performance of read-write-modify operators

Reviewed by Gavin Barraclough

Implement cross scope optimisation for read-write-modify
operators, to avoid unnecessary calls to property resolve
helper functions.

3:10 AM Changeset in webkit [42573] by oliver@apple.com
  • 2 edits in trunk/JavaScriptCore

Improve performance of remaining array enumeration functions

Reviewed by Gavin Barraclough

Make use of function entry cache for remaining Array enumeration functions.

12:54 AM Changeset in webkit [42572] by ap@webkit.org
  • 5 edits in trunk/WebCore

<rdar://problem/6795285> Infinite recursion in ResourceHandle::receivedRequestToContinueWithoutCredential

Rolled out <​http://trac.webkit.org/projects/webkit/changeset/42536> - the two instances of
authentication challenge are different, after all. Added a FIXME comment about a possible
future improvement.

  • platform/network/ResourceHandle.cpp: (WebCore::ResourceHandle::clearAuthentication):
  • platform/network/ResourceHandleInternal.h: (WebCore::ResourceHandleInternal::ResourceHandleInternal):
  • platform/network/cf/ResourceHandleCFNet.cpp: (WebCore::ResourceHandle::didReceiveAuthenticationChallenge): (WebCore::ResourceHandle::receivedCredential): (WebCore::ResourceHandle::receivedRequestToContinueWithoutCredential): (WebCore::ResourceHandle::receivedCancellation):
  • platform/network/mac/ResourceHandleMac.mm: (WebCore::ResourceHandle::didReceiveAuthenticationChallenge): (WebCore::ResourceHandle::didCancelAuthenticationChallenge): (WebCore::ResourceHandle::receivedCredential): (WebCore::ResourceHandle::receivedRequestToContinueWithoutCredential): (WebCore::ResourceHandle::receivedCancellation):
12:24 AM Changeset in webkit [42571] by oliver@apple.com
  • 2 edits in trunk/JavaScriptCore

Improve performance of Array.sort

Reviewed by Gavin Barraclough.

Cache the VM entry for Array.sort when using a JS comparison function.

Apr 15, 2009:

9:07 PM Changeset in webkit [42570] by oliver@apple.com
  • 5 edits
    3 adds in trunk

Bug 25229: Need support for Array.prototype.reduceRight
<​https://bugs.webkit.org/show_bug.cgi?id=25229>

Reviewed by Gavin Barraclough.

Implement Array.reduceRight

8:51 PM Changeset in webkit [42569] by ggaren@apple.com
  • 5 edits in trunk/WebCore

2009-04-15 Geoffrey Garen <​ggaren@apple.com>

Reviewed by Sam Weinig.


More fix for ​https://bugs.webkit.org/show_bug.cgi?id=21260
Unbounded memory growth when churning elements with anonymous event handler functions

Also fixed <rdar://problem/6792909> WebInspector crashes when reloading
a page with breakpoints set


  • bindings/js/JSEventListener.cpp: (WebCore::JSEventListener::clearJSFunctionInline): (WebCore::JSEventListener::markJSFunction):
  • bindings/js/JSEventListener.h: Actually clear our function and global object pointers when our client instructs us to. (Oops!) Also, mark our global object while we still intend to use it.
  • bindings/js/JSSVGElementInstanceCustom.cpp: (WebCore::JSSVGElementInstance::mark): (WebCore::toJS):
  • bindings/scripts/CodeGeneratorJS.pm:
  • svg/SVGElementInstance.idl: For every SVGElementInstance wrapper, ensure that the corresponding element also has a wrapper, to keep its event listeners alive.
8:33 PM Changeset in webkit [42568] by Dimitri Glazkov
  • 4 edits
    6 copies
    3 adds in trunk/WebCore

2009-04-15 Dimitri Glazkov <Dimitri Glazkov>

Reviewed by Darin Fisher.

​https://bugs.webkit.org/show_bug.cgi?id=25201
Add ScriptFunctionCall/ScriptObject for V8.

  • bindings/v8/ScriptFunctionCall.cpp: Added.
  • bindings/v8/ScriptFunctionCall.h: Added.
  • bindings/v8/ScriptObject.cpp: Added.
  • bindings/v8/ScriptObject.h: Added.
  • bindings/v8/ScriptObjectQuarantine.cpp: Added.
  • bindings/v8/ScriptObjectQuarantine.h: Added.
  • bindings/v8/ScriptScope.cpp: Added.
  • bindings/v8/ScriptScope.h: Added.
  • bindings/v8/ScriptState.h: (WebCore::ScriptState::ScriptState): Added new constructors. (WebCore::ScriptState::frame): Added Frame ptr accessor.
  • bindings/v8/ScriptString.h: (WebCore::ScriptString::ScriptString): Added default constructor.
  • bindings/v8/ScriptValue.h: (WebCore::ScriptValue::isEqual): Added.
7:12 PM Changeset in webkit [42567] by oliver@apple.com
  • 3 edits
    3 adds in trunk

Bug 25227: Array.filter triggers an assertion when the target array shrinks while being filtered
<​https://bugs.webkit.org/show_bug.cgi?id=25227>

Reviewed by Gavin Barraclough.

We correct this simply by making the fast array path fall back on the slow path if
we ever discover the fast access is unsafe.

5:49 PM Changeset in webkit [42566] by kov@webkit.org
  • 2 edits in trunk/WebCore

2009-04-15 Gustavo Noronha Silva <​gustavo.noronha@collabora.co.uk>

Unreviewed build fix. Add RenderSVGModelObject.* to GTK+'s build.

  • GNUmakefile.am:
5:02 PM Changeset in webkit [42565] by sfalken@apple.com
  • 2 edits in trunk/WebKitTools

Redo last build fix in a more straightforward way.

  • DumpRenderTree/win/DumpRenderTree.cpp: (sharedCFURLCache):
4:46 PM Changeset in webkit [42564] by sfalken@apple.com
  • 2 edits in trunk/WebKitTools

Fix Windows build of DumpRenderTree.

  • DumpRenderTree/win/DumpRenderTree.cpp: (sharedCFURLCache): (main):
4:35 PM Changeset in webkit [42563] by oliver@apple.com
  • 3 edits
    3 adds in trunk

Bug 25159: Support Array.prototype.reduce
<​https://bugs.webkit.org/show_bug.cgi?id=25159>

Reviewed by Gavin Barraclough

Implement Array.prototype.reduce

3:46 PM Changeset in webkit [42562] by kevino@webkit.org
  • 2 edits in trunk/WebKit/wx

Reviewed by Kevin Ollivier.

Implement support for wxWebViewNewWindowEvent.

​https://bugs.webkit.org/show_bug.cgi?id=19043

3:32 PM Changeset in webkit [42561] by eric@webkit.org
  • 11 edits
    2 adds in trunk/WebCore

Reviewed by Simon Fraser.

Add minimal RenderSVGModelObject and make RenderPath and RenderSVGContainer use it.
​https://bugs.webkit.org/show_bug.cgi?id=25221

RenderSVGModelObject is the base rendering class for things which live
in the SVG rendering tree. Not all SVG renders are RenderSVGModelObjects yet.

More patches coming. This is just adding the class, future patches
will pull more logic out of RenderPath and RenderSVGContainer into RenderSVGModelObject.

  • WebCore.pro:
  • WebCore.scons:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • rendering/RenderPath.cpp: (WebCore::RenderPath::RenderPath):
  • rendering/RenderPath.h:
  • rendering/RenderSVGContainer.cpp: (WebCore::RenderSVGContainer::RenderSVGContainer):
  • rendering/RenderSVGContainer.h:
  • rendering/RenderSVGModelObject.cpp: Added. (WebCore::RenderSVGModelObject::RenderSVGModelObject):
  • rendering/RenderSVGModelObject.h: Added. (WebCore::RenderSVGModelObject::requiresLayer):
  • rendering/RenderTreeAsText.cpp:
  • rendering/SVGRenderTreeAsText.cpp:
3:22 PM Changeset in webkit [42560] by justin.garcia@apple.com
  • 2 edits in trunk/LayoutTests/platform/win

Fixed an expected result and added a test to the Skipped list while I investigate why its expected results didn't change.

2:32 PM Changeset in webkit [42559] by sfalken@apple.com
  • 3 edits in trunk/WebCore

<rdar://problem/6785760> WebCore should use a maximum of 6 connections per host, not 4

Reviewed by Adam Roben.

  • platform/network/ResourceRequestBase.cpp:
  • platform/network/cf/ResourceRequestCFNet.cpp: (WebCore::initializeMaximumHTTPConnectionCountPerHost):
2:30 PM Changeset in webkit [42558] by sfalken@apple.com
  • 4 edits in trunk/WebKitLibraries

Updated WebKitSystemInterface for Windows.
Changes needed for <rdar://problem/6785760>

  • win/include/WebKitSystemInterface/WebKitSystemInterface.h:
  • win/lib/WebKitSystemInterface.lib:
  • win/lib/WebKitSystemInterface_debug.lib:
1:28 PM Changeset in webkit [42557] by weinig@apple.com
  • 3 edits in trunk/WebCore

2009-04-15 Sam Weinig <​sam@webkit.org>

Reviewed by Mark Rowe.

Add special casing to bindings generator so that custom functions
starting with xml or xslt conform to WebKit style guidelines.

  • bindings/js/JSDOMWindowCustom.cpp: (WebCore::JSDOMWindow::xmlHttpRequest): (WebCore::JSDOMWindow::xsltProcessor):
  • bindings/scripts/CodeGenerator.pm:
1:25 PM Changeset in webkit [42556] by Adam Roben
  • 2 edits in trunk/WebKitTools

Skip yet another JavaScriptCore test that sometimes fails on Windows

See Bug 25160: Various ecma/Date tests sometimes fail on Windows (but
not Mac)
<​https://bugs.webkit.org/show_bug.cgi?id=25160>

  • Scripts/run-javascriptcore-tests: Skip ecma/Date/15.9.2.2-2.js (who didn't see it coming?).
1:24 PM Changeset in webkit [42555] by eric@webkit.org
  • 3 edits in trunk/WebCore

Reviewed by Simon Fraser.

Remove more dead code from RenderSVGHiddenContainer.

lineHeight and baselinePosition used to be on RenderSVGContainer
(of which this is a subclass) because RenderSVGContainer used
to be a RenderBox and always the renderer for <svg>
Now <svg> uses RenderSVGRoot when needing a RenderBox (inside HTML)
and RenderSVGViewportContainer (when inside SVG content)
so there is no need for RenderSVGHiddenContainer to have these HTML-specific methods.

  • rendering/RenderSVGHiddenContainer.cpp:
  • rendering/RenderSVGHiddenContainer.h:
1:01 PM Changeset in webkit [42554] by eric@webkit.org
  • 6 edits in trunk/WebCore

Reviewed by Simon Fraser.

Remove unneeded (broken) code from SVG renderers
​https://bugs.webkit.org/show_bug.cgi?id=25214

Mostly due to my historical confusions about the render tree
and some methods not being removed after classes were split.

RenderSVGRoot is an RenderBox and should just use all the
standard RenderBox methods for inspector and repaint rects.

RenderSVGContainer is *not* a RenderBox (any more) and thus
doesn't need lineHeight or width/height or calcBounds.

RenderSVGViewportContainer had some broken code which tried
to see if the click was inside the container at all, but it
was using width/height metrics based off of the containing
block (from calcWidth) which is wrong (since its real
width/height are from its containing viewport not containing block).

  • rendering/RenderSVGContainer.cpp: (WebCore::RenderSVGContainer::RenderSVGContainer): (WebCore::RenderSVGContainer::layout):
  • rendering/RenderSVGContainer.h:
  • rendering/RenderSVGRoot.cpp:
  • rendering/RenderSVGRoot.h:
  • rendering/RenderSVGViewportContainer.cpp: (WebCore::RenderSVGViewportContainer::layout): (WebCore::RenderSVGViewportContainer::nodeAtPoint):
12:42 PM Changeset in webkit [42553] by justin.garcia@apple.com
  • 2 edits in trunk/LayoutTests

Updated expected result for a text dragging test that pastes text on Windows but not on Mac (which is expected).

12:33 PM Changeset in webkit [42552] by eric@webkit.org
  • 2 edits in trunk/WebCore

Reviewed by Simon Fraser and Sam Weinig.

​https://bugs.webkit.org/show_bug.cgi?id=25217
Simplify nearestViewportElement and farthestViewportElement using isViewportElement and a for loop
Add ASSERT(element) to all these functions since they should never be passed a null element.

  • svg/SVGLocatable.cpp: (WebCore::isViewportElement): (WebCore::SVGLocatable::nearestViewportElement): (WebCore::SVGLocatable::farthestViewportElement): (WebCore::SVGLocatable::getBBox): (WebCore::SVGLocatable::getCTM): (WebCore::SVGLocatable::getScreenCTM):
11:41 AM Changeset in webkit [42551] by weinig@apple.com
  • 2 edits in trunk/WebCore

2009-04-15 Sam Weinig <​sam@webkit.org>

Reviewed by Anders Carlsson.

Remove support for the ObjCIvar extended attribute from the Objective-C
bindings generator. It is not used anymore.

  • bindings/scripts/CodeGeneratorObjC.pm:
11:30 AM Changeset in webkit [42550] by eric.carlson@apple.com
  • 2 edits in trunk/LayoutTests

2009-04-15 Eric Carlson <​eric.carlson@apple.com>

Fix incorrect expected result.

  • http/tests/security/local-video-source-from-remote-expected.txt:
11:22 AM Changeset in webkit [42549] by justin.garcia@apple.com
  • 15 edits in trunk

WebCore:

2009-04-15 Justin Garcia <​justin.garcia@apple.com>

Reviewed by Dan Bernstein.

​https://bugs.webkit.org/show_bug.cgi?id=25204
Create a fast path for ReplaceSelectionCommand that merges text nodes


During simple pastes, where we're just pasting a text node into a run of text, we would split the current
text and insert the new node in between. This is slow and we hit this bug:

​https://bugs.webkit.org/show_bug.cgi?id=6148

in the layout and rendering code where adjacent text nodes don't shape correctly in Arabic.


This change creates a fast path for ReplaceSelectionCommand that inserts text directly into the
text node that holds the selection (very similar to the fast path we wrote for InsertTextCommand).

  • editing/ReplaceSelectionCommand.cpp: (WebCore::ReplaceSelectionCommand::doApply): (WebCore::ReplaceSelectionCommand::performTrivialReplace):
  • editing/ReplaceSelectionCommand.h:
  • editing/TextIterator.cpp:

LayoutTests:

2009-04-15 Justin Garcia <​justin.garcia@apple.com>

Reviewed by Dan Bernstein.


​https://bugs.webkit.org/show_bug.cgi?id=25204
Create a fast path for ReplaceSelectionCommand that merges text nodes


Simplified DOM/Render trees:

  • editing/pasteboard/4840662-expected.txt:
  • platform/mac/editing/pasteboard/bad-placeholder-expected.txt:
  • platform/mac/editing/pasteboard/paste-match-style-001-expected.txt:
  • platform/mac/editing/pasteboard/paste-text-019-expected.txt:
  • platform/mac/editing/pasteboard/paste-xml-expected.txt:

Removed redundant styles that were generated during nesting prevention that is no longer needed:

  • platform/mac/editing/pasteboard/4076267-2-expected.txt:
  • platform/mac/editing/pasteboard/5156401-1-expected.txt:


No longer incorrectly uncollapsing unrendered whitespace:

  • editing/pasteboard/paste-into-anchor-text-expected.txt:
  • platform/mac/editing/pasteboard/5387578-expected.txt:


No longer invalidating the old selected DOM range during a paste:

  • editing/pasteboard/copy-in-password-field-expected.txt:
11:18 AM Changeset in webkit [42548] by darin@chromium.org
  • 4 edits
    2 adds in trunk/WebCore

2009-04-15 Adam Langley <​agl@google.com>

Reviewed by Darin Fisher.

Move VDMX parsing into the Chromium Linux port.

​https://bugs.webkit.org/show_bug.cgi?id=25116

VDMX tables are optional tables in TrueType fonts which contain the
exact pixel height of a given font at a given pel size. In order to
match Windows font metrics we have to use these numbers.

Previously, the parsing was performed in Skia. As part of the merge
with upstream Skia, an interface for getting table data from a font
has been added to Skia and we're moving the parsing into WebKit.

This does not change any layout tests.

  • platform/graphics/chromium/FontPlatformDataLinux.cpp: (WebCore::FontPlatformData::uniqueID):
  • platform/graphics/chromium/FontPlatformDataLinux.h:
  • platform/graphics/chromium/FontTrueTypeLinux.cpp: Added.
  • platform/graphics/chromium/FontTrueTypeLinux.h: Added.
  • platform/graphics/chromium/SimpleFontDataLinux.cpp: (WebCore::SimpleFontData::platformInit): (WebCore::SimpleFontData::platformWidthForGlyph):
11:15 AM Changeset in webkit [42547] by darin@chromium.org
  • 2 edits in trunk/WebCore

2009-04-15 Stephen White <​senorblanco@chromium.org>

Reviewed by Dimitri Glazkov.

​https://bugs.webkit.org/show_bug.cgi?id=25180

Restore stroked outlines to PlatformContextSkia::drawRect().
These were removed inadvertently in r41805, aka
​https://bugs.webkit.org/show_bug.cgi?id=24662.
SkRect is { left, top, right, bottom }, not { left, top, width, height }.

  • platform/graphics/skia/PlatformContextSkia.cpp: (PlatformContextSkia::drawRect):
11:14 AM Changeset in webkit [42546] by mitz@apple.com
  • 3 edits
    4 adds in trunk

WebCore:

Reviewed by Dave Hyatt.

  • fix <rdar://problem/6777374> Generated content with display: run-in causes a crash

Test: fast/runin/generated.html

  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::handleRunInChild): Check if the run-in block is generated, and if so, make the RenderInline anonymous instead of passing a 0 node to the RenderInline constructor. If the run-in itself is generated, do move :before and :after children from the block into the inline, as they will not be regenerated. Changed nested ifs into early returns.

LayoutTests:

Reviewed by Dave Hyatt.

  • test for <rdar://problem/6777374> Generated content with display: run-in causes a crash
  • fast/runin/generated.html: Added.
  • platform/mac/fast/runin/generated-expected.checksum: Added.
  • platform/mac/fast/runin/generated-expected.png: Added.
  • platform/mac/fast/runin/generated-expected.txt: Added.
11:13 AM Changeset in webkit [42545] by darin@chromium.org
  • 2 edits in trunk/WebCore

2009-04-15 Eric Roman <​eroman@chromium.org>

Reviewed by Geoffrey Garen.

​https://bugs.webkit.org/show_bug.cgi?id=25192

Expose DOMWindow::removeInlineEventListenerForType and
DOMWindow::inlineEventListenerForType as public.

  • page/DOMWindow.h:
11:06 AM Changeset in webkit [42544] by darin@chromium.org
  • 2 edits in trunk/WebCore

2009-04-14 Eric Roman <​eroman@chromium.org>

Reviewed by Darin Adler.

​https://bugs.webkit.org/show_bug.cgi?id=25198

Wrap RegisteredEventListener's markEventListeners and invalidateEventListeners
in a USE(JSC), since it doesn't compile with V8 bindings.

  • dom/RegisteredEventListener.h:
10:26 AM Changeset in webkit [42543] by eric.carlson@apple.com
  • 3 edits
    1 add
    1 delete in trunk/LayoutTests

2009-04-15 Eric Carlson <​eric.carlson@apple.com>

Reviewed by Alexey Proskuryakov.

Use a media file inside of LayoutTests/http/ so a cgi isn't necessary to load
it. Fixes a test failure introduced in r42533.

  • http/tests/resources/silence.mpg: Added.
  • http/tests/security/local-video-source-from-remote-expected.txt:
  • http/tests/security/local-video-source-from-remote.html: change the remote url, update a comment.
  • http/tests/security/resources/load-media.cgi: Removed.
10:20 AM Changeset in webkit [42542] by darin@chromium.org
  • 2 edits in trunk/WebCore

2009-04-15 Eric Roman <​eroman@chromium.org>

Reviewed by Darin Adler.

​https://bugs.webkit.org/show_bug.cgi?id=25194

Fix a caller of Settings::javaScriptCanOpenWindowsAutomatically() to
use the new name.

  • bindings/v8/custom/V8DOMWindowCustom.cpp:
8:25 AM Changeset in webkit [42541] by ap@webkit.org
  • 2 edits in trunk/WebKitSite

Reviewed by Darin Adler.

​https://bugs.webkit.org/show_bug.cgi?id=25186
There is no XSLT component in bugzilla

  • projects/xslt/index.html: Changed to search by bug title.
8:09 AM Changeset in webkit [42540] by ariya@webkit.org
  • 4 edits in trunk/WebKit/qt

2009-04-15 Antonio Gomes <​antonio.gomes@openbossa.org>

Reviewed by Ariya Hidayat.

Rename extend() method in QWebElementSelection to append().

  • Api/qwebelement.cpp: (QWebElementSelection::append):
  • Api/qwebelement.h:
  • tests/qwebelement/tst_qwebelement.cpp: (tst_QWebElement::appendSelection):
6:42 AM Changeset in webkit [42539] by Simon Hausmann
  • 2 edits in trunk/WebKit/qt

2009-04-15 Antonio Gomes <​antonio.gomes@openbossa.org>

Reviewed by Simon Hausmann.

Fixed nit/typo in QWebElement documentation.

6:24 AM WebKitFeatures edited by sascha@brawer.ch
Fixed broken links to www.css3.info (diff)
4:56 AM QtWebKitTodo edited by ariya@webkit.org
(diff)
4:50 AM QtWebKitTodo edited by elbunce@xendom.com
(diff)
4:48 AM QtWebKitTodo edited by elbunce@xendom.com
(diff)
12:31 AM Changeset in webkit [42538] by oliver@apple.com
  • 6 edits
    1 copy in trunk/JavaScriptCore

Move CallFrameClosure from inside the Interpreter class to its own file.

Reviewed by NOBODY(Build fix)

12:13 AM Changeset in webkit [42537] by oliver@apple.com
  • 10 edits
    2 adds in trunk

Bug 25202: Improve performance of repeated callbacks into the VM

Reviewed by Cameron Zwarich

Add the concept of a CachedCall to native code for use in Array
prototype and similar functions where a single callback function
is called repeatedly with the same number of arguments.

Used Array.prototype.filter as the test function and got a 50% win
over a naive non-caching specialised version. This makes the native
implementation of Array.prototype.filter faster than the JS one once
more.

Note: See TracTimeline for information about the timeline view.