⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Apr 25, 2009:

9:35 PM Changeset in webkit [42874] by kov@webkit.org
  • 2 edits in trunk/LayoutTests

2009-04-25 Gustavo Noronha Silva <Gustavo Noronha Silva>

Go back to disabling accessibility tests as a whole, since we have
no real way of checking them, and no accessibilityController
implementation.

  • platform/gtk/Skipped:
9:25 PM Changeset in webkit [42873] by kov@webkit.org
  • 2 edits in trunk/LayoutTests

2009-04-25 Gustavo Noronha Silva <Gustavo Noronha Silva>

Disable tests that need eventSender, not yet implemented in our
DumpRenderTree.

  • platform/gtk/Skipped:
9:11 PM Changeset in webkit [42872] by Simon Fraser
  • 6 edits
    2 adds in trunk

2009-04-24 Simon Fraser <Simon Fraser>

Reviewed by Darin Adler

​https://bugs.webkit.org/show_bug.cgi?id=25390

Fix point mapping and hit testing through transforms and perspective
with ENABLE_3D_RENDERING. Previously the code did the more efficient
move(), rather than getTransformFromContainer(), when the object had
no transform. However, this skipped the application of perspective
when the immediate child of the perspective element had no transform
itself.

Test: transforms/3d/point-mapping/3d-point-mapping-3.html

  • rendering/RenderBox.cpp: (WebCore::RenderBox::mapLocalToContainer): (WebCore::RenderBox::mapAbsoluteToLocalPoint):
  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::createLocalTransformState): Call shouldUseTransformFromContainer() to determine if we need to go through the more expensive getTransformFromContainer() code path.
  • rendering/RenderObject.h:
  • rendering/RenderObject.cpp: (WebCore::RenderObject::shouldUseTransformFromContainer): New method that indicates whether we need use getTransformFromContainer() when mapping points through renderers, and hit testing.
4:30 PM Changeset in webkit [42871] by beidson@apple.com
  • 2 edits in trunk/WebKit/mac

2009-04-25 Brady Eidson <​beidson@apple.com>

Reviewed by Sam Weinig

Some *obvious* style cleanup in my last patch.

  • History/WebBackForwardList.mm: (bumperCarBackForwardHackNeeded):
4:24 PM Changeset in webkit [42870] by beidson@apple.com
  • 3 edits in trunk/WebKit/mac

2009-04-25 Brady Eidson <​beidson@apple.com>

Reviewed by Oliver Hunt

<rdar://problem/6817607> BumperCar 2.2 crashes going back (invalid WebHistoryItem)

BumperCar was holding a pointer to a WebHistoryItem they never retain, then later
tried to go to it. In some cases it would be dealloc'ed first.
When WebHistoryItems were pure Objective-C they probably got away with this more often.
With the WebCore/Obj-C mixed WebHistoryItems it's more likely to crash.

  • History/WebBackForwardList.mm: (bumperCarBackForwardHackNeeded): (-[WebBackForwardList backListWithLimit:]): If this is BumperCar, hang on to the NSArray of WebHistoryItems until the next time this method is called. (-[WebBackForwardList forwardListWithLimit:]): Ditto.
  • Misc/WebKitVersionChecks.h: Added WEBKIT_FIRST_VERSION_WITHOUT_BUMPERCAR_BACK_FORWARD_QUIRK.
12:00 PM Changeset in webkit [42869] by adele@apple.com
  • 3 edits
    4 adds in trunk

WebCore:

2009-04-25 Adele Peterson <​adele@apple.com>

Reviewed by Oliver Hunt.

Fix for <rdar://problem/6712771> REGRESSION(34681): Text is no longer underlined after delete
​https://bugs.webkit.org/show_bug.cgi?id=25396

Test: editing/deleting/delete-br-013.html

  • editing/CompositeEditCommand.cpp: (WebCore::CompositeEditCommand::moveParagraphs): Only preserve an empty paragraph's style when moving paragraphs around if the selection is still in an empty paragraph after the move occurs. This was causing the empty paragraph's style to overwrite the previous paragraph's style during a delete of an empty paragraph.

LayoutTests:

2009-04-25 Adele Peterson <​adele@apple.com>

Reviewed by Oliver Hunt.

Test for <rdar://problem/6712771> REGRESSION(34681): Text is no longer underlined after delete
​https://bugs.webkit.org/show_bug.cgi?id=25396

  • editing/deleting/delete-br-013.html: Added.
  • platform/mac/editing/deleting/delete-br-013-expected.checksum: Added.
  • platform/mac/editing/deleting/delete-br-013-expected.png: Added.
  • platform/mac/editing/deleting/delete-br-013-expected.txt: Added.
10:48 AM Changeset in webkit [42868] by eric.carlson@apple.com
  • 8 edits in trunk/WebCore

2009-04-25 Eric Carlson <​eric.carlson@apple.com>

Reviewed by Darin Adler.

<rdar://problem/6808171> REGRESSION (3-4): Standalone media documents don't
properly display non-linear media

If a media engine claims it can support the MIME type, WebCore now creates a <video>
element for document mode media files instead of an <embed> element. Because WebCore's
QuickTime backed media players do not support every kind of media the QuickTime plug-in
supports, and because it is not always possible to tell what type of media is in a file
without opening and parsing it, some types of media that used to be displayed properly
by a plug-in are no longer supported properly. To fix this, if the media engine
sees that it can not completely support a media file it now informs the media
document, which replaces the <video> element with an <embed>.


r42301 landed support for OSX. This patch modifies those changes slighly and adds support
for Windows.

  • loader/MediaDocument.cpp: (WebCore::MediaDocument::MediaDocument): Initialize m_replaceMediaElementTimer. (WebCore::MediaDocument::mediaElementSawUnsupportedTracks): Don't replace the <video> element immediately. (WebCore::MediaDocument::replaceMediaElementTimerFired): Renamed from replaceVideoWithEmbed. Set body margin-width and margin-height to 0 as that is what a PluginDocument uses.
  • loader/MediaDocument.h:
  • platform/graphics/mac/MediaPlayerPrivateQTKit.mm: (WebCore::MediaPlayerPrivate::loadStateChanged): Don't do anything if m_hasUnsupportedTracks. (WebCore::MediaPlayerPrivate::rateChanged): Ditto. (WebCore::MediaPlayerPrivate::timeChanged): Ditto. (WebCore::MediaPlayerPrivate::didEnd): Ditto. (WebCore::MediaPlayerPrivate::repaint): Ditto. (WebCore::MediaPlayerPrivate::paint): Ditto. (WebCore::MediaPlayerPrivate::sawUnsupportedTracks): Set m_hasUnsupportedTracks before callback.
  • platform/graphics/win/MediaPlayerPrivateQuickTimeWin.cpp: (WebCore::MediaPlayerPrivate::MediaPlayerPrivate): Initialize m_totalTrackCount and m_hasUnsupportedTracks. (WebCore::MediaPlayerPrivate::updateStates): Call sawUnsupportedTracks if the movie has unsupported media type(s) or if it fails completely. (WebCore::MediaPlayerPrivate::sawUnsupportedTracks): New, disable the movie object and tell the media player client we won't play this movie correctly. (WebCore::MediaPlayerPrivate::didEnd): Don't do anything if m_hasUnsupportedTracks. (WebCore::MediaPlayerPrivate::setSize): Ditto. (WebCore::MediaPlayerPrivate::setVisible): Ditto. (WebCore::MediaPlayerPrivate::paint): Ditto. (WebCore::MediaPlayerPrivate::movieEnded): Ditto. (WebCore::MediaPlayerPrivate::movieLoadStateChanged): Ditto. (WebCore::MediaPlayerPrivate::movieTimeChanged): Ditto. (WebCore::MediaPlayerPrivate::movieNewImageAvailable): Ditto.
  • platform/graphics/win/MediaPlayerPrivateQuickTimeWin.h:
  • platform/graphics/win/QTMovieWin.cpp: (QTMovieWinPrivate::task): Stop the task timer if we were disabled during the load state change callback. (QTMovieWinPrivate::drawingComplete): Don't do anything if disabled. (QTMovieWin::QTMovieWin): Initialize m_disabled. (QTMovieWin::disableUnsupportedTracks): Return total number of tracks. (QTMovieWin::setDisabled): New, set m_disabled flag.
  • platform/graphics/win/QTMovieWin.h:
7:02 AM Changeset in webkit [42867] by kov@webkit.org
  • 5 edits in trunk/WebKit/gtk

2009-04-25 Gustavo Noronha Silva <​gustavo.noronha@collabora.co.uk>

Reviewed by Xan Lopez.

​https://bugs.webkit.org/show_bug.cgi?id=24786
WebKitDownload sometimes suggests peculiar filenames

Refactor the emission of the download-requested signal so that we
have less code duplication.

  • WebCoreSupport/ContextMenuClientGtk.cpp: (WebKit::ContextMenuClient::downloadURL):
  • WebCoreSupport/FrameLoaderClientGtk.cpp: (WebKit::FrameLoaderClient::startDownload):
  • webkit/webkitprivate.h:
  • webkit/webkitwebview.cpp:
2:19 AM Changeset in webkit [42866] by jmalonzo@webkit.org
  • 6 edits
    2 adds in trunk

2009-04-25 Jan Michael Alonzo <​jmalonzo@webkit.org>

Reviewed by Xan Lopez.

[GTK] Error reporting
​https://bugs.webkit.org/show_bug.cgi?id=18344

Fix the SOUP resource handle to report SOUP_HTTP_ERROR for Soup
errors and G_IO_ERROR for gio errors.

  • platform/network/soup/ResourceHandleSoup.cpp: (WebCore::finishedCallback): (WebCore::ResourceHandle::startHttp): (WebCore::ResourceHandle::start): (WebCore::readCallback): (WebCore::openCallback): (WebCore::queryInfoCallback): (WebCore::ResourceHandle::startGio):

2009-04-25 Jan Michael Alonzo <​jmalonzo@webkit.org>

Reviewed by Xan Lopez.

[GTK] Error reporting
​https://bugs.webkit.org/show_bug.cgi?id=18344

Update FrameLoad errors to use WebKitErrors.

  • WebCoreSupport/FrameLoaderClientGtk.cpp: (WebKit::FrameLoaderClient::cancelledError): (WebKit::FrameLoaderClient::blockedError): (WebKit::FrameLoaderClient::cannotShowURLError): (WebKit::FrameLoaderClient::interruptForPolicyChangeError): (WebKit::FrameLoaderClient::cannotShowMIMETypeError): (WebKit::FrameLoaderClient::fileDoesNotExistError): (WebKit::FrameLoaderClient::pluginWillHandleLoadError): (WebKit::FrameLoaderClient::shouldFallBack):
  • webkit/webkiterror.h: Added.
  • webkit/webkiterror.cpp: Added.

2009-04-25 Jan Michael Alonzo <​jmalonzo@webkit.org>

Reviewed by Xan Lopez.

[GTK] Error reporting
​https://bugs.webkit.org/show_bug.cgi?id=18344

Add webkiterror to the build.

  • GNUmakefile.am:
2:19 AM Changeset in webkit [42865] by jmalonzo@webkit.org
  • 4 edits
    2 adds in trunk

2009-04-25 Jan Michael Alonzo <​jmalonzo@webkit.org>

Reviewed by Xan Lopez.

[GTK] Error reporting
​https://bugs.webkit.org/show_bug.cgi?id=18344

Add the default error page for installation.

  • GNUmakefile.am:

2009-04-25 Jan Michael Alonzo <​jmalonzo@webkit.org>

Reviewed by Xan Lopez.

Display a default error page for load errors.

  • WebCoreSupport/FrameLoaderClientGtk.cpp: (WebKit::FrameLoaderClient::dispatchDidFailLoad):
  • resources/error.html: Added.
2:19 AM Changeset in webkit [42864] by jmalonzo@webkit.org
  • 5 edits in trunk/WebKit/gtk

2009-04-25 Jan Michael Alonzo <​jmalonzo@webkit.org>

Reviewed by Xan Lopez.

[GTK] Error reporting
​https://bugs.webkit.org/show_bug.cgi?id=18344

Add a WebKitWebFrame API to load alternate content for unreachable URLs.
Also add a new signal "load-error" for handling load errors.

  • WebCoreSupport/FrameLoaderClientGtk.cpp: (WebKit::FrameLoaderClient::postProgressFinishedNotification): (WebKit::FrameLoaderClient::dispatchDidFailLoading): (WebKit::FrameLoaderClient::dispatchDidFailProvisionalLoad): (WebKit::FrameLoaderClient::dispatchDidFailLoad):
  • webkit/webkitwebframe.cpp:
  • webkit/webkitwebframe.h:
  • webkit/webkitwebview.cpp:
2:04 AM Changeset in webkit [42863] by oliver@apple.com
  • 2 edits in trunk/JavaScriptCore

Build fix.

1:44 AM Changeset in webkit [42862] by jmalonzo@webkit.org
  • 3 edits in trunk/JavaScriptCore

2009-04-25 Jan Michael Alonzo <​jmalonzo@webkit.org>

Reviewed by Oliver Hunt.

Gtk build fix - check if we have MADV_FREE before using it.

  • interpreter/RegisterFile.cpp: (JSC::RegisterFile::releaseExcessCapacity):
  • wtf/Platform.h:

Apr 24, 2009:

9:03 PM Changeset in webkit [42861] by kov@webkit.org
  • 2 edits in trunk/WebCore

2009-04-25 Gustavo Noronha Silva <​gustavo.noronha@collabora.co.uk>

Reviewed by Mark Rowe.

Only set the new URL once for the request. Doing it a second time
after the call to willSendRequest was causing crashes when
redirected requests got cancelled.

  • platform/network/soup/ResourceHandleSoup.cpp: (WebCore::restartedCallback):
8:44 PM Changeset in webkit [42860] by kevino@webkit.org
  • 8 edits in trunk

wx build fix. Switching JSCore from a static lib to a dynamic lib to match the Apple build and fix symbol exports.

8:19 PM Changeset in webkit [42859] by kevino@webkit.org
  • 2 edits in trunk/WebCore

wx build fix. Adding ScriptEventListener.cpp.

5:27 PM Changeset in webkit [42858] by jmalonzo@webkit.org
  • 2 edits
    1 move in trunk/JavaScriptCore

2009-04-24 Laszlo Gombos <Laszlo Gombos>

Rubber-stamped by Mark Rowe.

​https://bugs.webkit.org/show_bug.cgi?id=25337
Move ThreadingQt.cpp under the qt directory.

5:18 PM Changeset in webkit [42857] by jmalonzo@webkit.org
  • 2 edits
    1 move in trunk/JavaScriptCore

2009-04-24 Laszlo Gombos <Laszlo Gombos>

Rubber-stamped by Mark Rowe.

​https://bugs.webkit.org/show_bug.cgi?id=25338
Move ThreadingGtk.cpp under the gtk directory.

  • GNUmakefile.am:
  • wtf/ThreadingGtk.cpp: Removed.
  • wtf/gtk/ThreadingGtk.cpp: Copied from JavaScriptCore/wtf/ThreadingGtk.cpp.
5:05 PM Changeset in webkit [42856] by jmalonzo@webkit.org
  • 2 edits in trunk/WebKit/gtk

2009-04-24 Jan Michael Alonzo <​jmalonzo@webkit.org>

Rubber-stamped by Gustavo Noronha.

Fix braces to comply with style guidelines.

  • WebCoreSupport/PasteboardHelperGtk.cpp: (WebKit::PasteboardHelperGtk::getClipboard): (WebKit::PasteboardHelperGtk::getCopyTargetList): (WebKit::PasteboardHelperGtk::getPasteTargetList):
5:05 PM Changeset in webkit [42855] by jmalonzo@webkit.org
  • 6 edits in trunk

2009-04-24 Sergio García-Cuevas <​sergio_gcg@telefonica.net>

Reviewed by Gustavo Noronha.

​https://bugs.webkit.org/show_bug.cgi?id=17267
[GTK] Primary selection/clipboard support

Copy the link location to the primary selection as well as the
clipboard selection when using the "copy link selection" context
menu entry.

  • platform/gtk/PasteboardGtk.cpp: (WebCore::Pasteboard::writeURL):
  • platform/gtk/PasteboardHelper.h:

2009-04-24 Sergio García-Cuevas <​sergio_gcg@telefonica.net>

Reviewed by Gustavo Noronha.

​https://bugs.webkit.org/show_bug.cgi?id=17267
[GTK] Primary selection/clipboard support

Add a method for getting the primary selection.

  • WebCoreSupport/PasteboardHelperGtk.cpp: (WebKit::PasteboardHelperGtk::getPrimary):
  • WebCoreSupport/PasteboardHelperGtk.h:
4:54 PM Changeset in webkit [42854] by eric@webkit.org
  • 7 edits in trunk

Reviewed by Simon Fraser.

​https://bugs.webkit.org/show_bug.cgi?id=25383
Changing SVG size via JS does not update CSS width/height

Add an ugly hack to fix CSS width/height updates from JS.

We can't easily call setAttribute when width/height changes
as that would cause infinite recursion (as we'd try to set
the animation storage from the attributes)

For now, when we get notification that JS changed width/height
we copy what parseMappedAttribute does and update the CSS values as well.

A better fix for this would be:
​https://bugs.webkit.org/show_bug.cgi?id=25383

  • svg/SVGSVGElement.cpp: (WebCore::updateCSSForAttribute): (WebCore::SVGSVGElement::svgAttributeChanged):
4:51 PM Changeset in webkit [42853] by barraclough@apple.com
  • 6 edits in trunk/JavaScriptCore

2009-04-24 Gavin Barraclough <​barraclough@apple.com>

Reviewed by Sam "Wesley" Weinig.

Improve performance to YARR interpreter.
(From about 3x slower than PCRE on regex-dna to about 30% slower).

  • yarr/RegexCompiler.cpp: (JSC::Yarr::RegexPatternConstructor::setupAlternativeOffsets):
  • yarr/RegexInterpreter.cpp: (JSC::Yarr::Interpreter::checkCharacter): (JSC::Yarr::Interpreter::checkCasedCharacter): (JSC::Yarr::Interpreter::backtrackPatternCharacter): (JSC::Yarr::Interpreter::backtrackPatternCasedCharacter): (JSC::Yarr::Interpreter::matchParentheticalAssertionBegin): (JSC::Yarr::Interpreter::matchParentheticalAssertionEnd): (JSC::Yarr::Interpreter::backtrackParentheticalAssertionBegin): (JSC::Yarr::Interpreter::backtrackParentheticalAssertionEnd): (JSC::Yarr::Interpreter::matchDisjunction): (JSC::Yarr::Interpreter::interpret): (JSC::Yarr::ByteCompiler::atomPatternCharacter): (JSC::Yarr::ByteCompiler::atomParenthesesSubpatternBegin): (JSC::Yarr::ByteCompiler::atomParentheticalAssertionBegin): (JSC::Yarr::ByteCompiler::closeAlternative): (JSC::Yarr::ByteCompiler::closeBodyAlternative): (JSC::Yarr::ByteCompiler::atomParenthesesEnd): (JSC::Yarr::ByteCompiler::regexBegin): (JSC::Yarr::ByteCompiler::regexEnd): (JSC::Yarr::ByteCompiler::alterantiveBodyDisjunction): (JSC::Yarr::ByteCompiler::alterantiveDisjunction): (JSC::Yarr::ByteCompiler::emitDisjunction):
  • yarr/RegexInterpreter.h: (JSC::Yarr::ByteTerm::): (JSC::Yarr::ByteTerm::ByteTerm): (JSC::Yarr::ByteTerm::BodyAlternativeBegin): (JSC::Yarr::ByteTerm::BodyAlternativeDisjunction): (JSC::Yarr::ByteTerm::BodyAlternativeEnd): (JSC::Yarr::ByteTerm::AlternativeBegin): (JSC::Yarr::ByteTerm::AlternativeDisjunction): (JSC::Yarr::ByteTerm::AlternativeEnd): (JSC::Yarr::ByteTerm::SubpatternBegin): (JSC::Yarr::ByteTerm::SubpatternEnd):
  • yarr/RegexJIT.cpp: (JSC::Yarr::RegexGenerator::generateParentheticalAssertion):
  • yarr/RegexPattern.h:
4:41 PM Changeset in webkit [42852] by kmccullough@apple.com
  • 2 edits in trunk/WebCore

2009-04-24 Kevin McCullough <​kmccullough@apple.com>

Reviewed by Dan Bernstein.

We should not show the deletion UI for blockquotes in mail but they do
show now that we only check for one visible border.

  • editing/DeleteButtonController.cpp: (WebCore::isDeletableElement):
4:28 PM Changeset in webkit [42851] by mrowe@apple.com
  • 2 edits in trunk/JavaScriptCore

2009-04-24 Rob Raguet-Schofield <​ragfield@gmail.com>

Rubber-stamped by Mark Rowe.

  • wtf/CurrentTime.h: Fix a typo in a comment.
4:05 PM Changeset in webkit [42850] by mitz@apple.com
  • 2 edits in trunk/WebCore
  • address Hyatt's review comments on the last patch
  • rendering/RenderLayer.cpp: (WebCore::performOverlapTests): (WebCore::RenderLayer::paintLayer):
4:00 PM Changeset in webkit [42849] by mitz@apple.com
  • 10 edits
    1 add in trunk/WebCore

Reviewed by Dave Hyatt.

  • WebCore.xcodeproj/project.pbxproj: Added OverlapTestRequestClient.h.
  • page/FrameView.cpp: (WebCore::FrameView::reset): Initialize m_isOverlapped. (WebCore::FrameView::useSlowRepaints): Also check m_isOverlapped. (WebCore::FrameView::removeSlowRepaintObject): Use useSlowRepaints() so overlapping is taken into account. (WebCore::FrameView::setIsOverlapped): Added. Sets m_isOverlapped and enables or disables copy-on-scroll accordingly.
  • page/FrameView.h: Added setIsOverlapped() and m_isOverlapped.
  • rendering/OverlapTestRequestClient.h: Added. During foreground painting, an OverlapTestRequestClient can make a request to test if any subsequently- painted layers overlap a rect. The test result is delivered to the requestClient via setOverlapTestResult(). (WebCore::OverlapTestRequestClient::~OverlapTestRequestClient):
  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::paint): Pass an OverlapTestRequestMap to paintLayer(). When done painting, inform any remaining requestClients that they are not overlapped.

(WebCore::RenderLayer::paintLayer): Take an OverlapTestRequestMap and
pass it down to child and reflection layers. Inform requestClients if this
layer overlaps their requested rects.

  • rendering/RenderLayer.h:
  • rendering/RenderObject.h: (WebCore::RenderObject::PaintInfo::PaintInfo): Added an OverlapTestRequestMap member.
  • rendering/RenderReplica.cpp: (WebCore::RenderReplica::paint): For now, pass a 0 OverlapTestRequestMap to paintLayer().
  • rendering/RenderWidget.cpp: (WebCore::RenderWidget::paint): For FrameViews, request an overlap test with the frame. (WebCore::RenderWidget::setOverlapTestResult): Call FrameView::setIsOverlapped() with the result of the overlap test.
  • rendering/RenderWidget.h: Made RenderWidget an OverlapTestRequestClient.
3:52 PM Changeset in webkit [42848] by Simon Fraser
  • 3 edits in trunk/LayoutTests

2009-04-24 Pierre d'Herbemont <​pdherbemont@apple.com>

Reviewed by Simon Fraser

​https://bugs.webkit.org/show_bug.cgi?id=25380

Fixed a race condition on the first 'played' attribute test start.

Previously we were starting nearly right away to play, and probably
before receiving the 'canplay' event. Now we ensure we'll wait for
that 'canplay' event before attempting to play.

  • media/video-played-expected.txt: Updated
  • media/video-played.html:
3:45 PM Changeset in webkit [42847] by ggaren@apple.com
  • 2 edits in trunk/LayoutTests

2009-04-24 Geoffrey Garen <​ggaren@apple.com>

Rubber stamped by Eric Seidel.


Updated test to turn the buildbot green after Eric's last check-in.

  • platform/mac/svg/W3C-SVG-1.1/animate-elem-36-t-expected.txt:
3:30 PM Changeset in webkit [42846] by hyatt@apple.com
  • 22 edits
    2 deletes in trunk/WebCore

2009-04-24 David Hyatt <​hyatt@apple.com>

Reviewed by Simon Fraser, Dan Bernstein.

Speed up the PLT by devirtualizing the height() function on InlineBox. virtualizing it in order to make the height() computation dynamic caused
a ~0.5% slowdown. This patch does the following to get the speed back:


(a) Devirtualizes isText and forces inline box creators to set the bit as needed. This actually resulted in simplified code, since ListMarkerBox could
then be removed.
(b) Reduces the height() call count. In some cases the code was repeatedly calling height(), which used to be fine when the function was just an inline
member variable access. The call sites have been patched to cut down on extra height() calls now that it is more expensive.
(c) Devirtualize height() except on SVG boxes. For all non-SVG, the height() function on InlineBox handles the computation. For SVG boxes, a new bit has
been set on InlineBoxes (isSVG()) that indicates that the virtual svgBoxHeight() function should be called to retrieve the height instead.

  • GNUmakefile.am:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • WebCoreSources.bkl:
  • rendering/InlineBox.cpp: (WebCore::InlineBox::height):
  • rendering/InlineBox.h: (WebCore::InlineBox::InlineBox): (WebCore::InlineBox::isSVG): (WebCore::InlineBox::setIsSVG): (WebCore::InlineBox::isText): (WebCore::InlineBox::setIsText): (WebCore::InlineBox::svgBoxHeight):
  • rendering/InlineFlowBox.cpp: (WebCore::InlineFlowBox::placeBoxesVertically): (WebCore::InlineFlowBox::paintBoxDecorations): (WebCore::InlineFlowBox::paintMask):
  • rendering/InlineFlowBox.h:
  • rendering/InlineTextBox.cpp:
  • rendering/InlineTextBox.h:
  • rendering/ListMarkerBox.cpp: Removed.
  • rendering/ListMarkerBox.h: Removed.
  • rendering/RenderListMarker.cpp: (WebCore::RenderListMarker::createInlineBox):
  • rendering/RenderSVGInline.cpp: (WebCore::RenderSVGInline::createFlowBox):
  • rendering/RenderSVGInlineText.cpp: (WebCore::RenderSVGInlineText::createTextBox):
  • rendering/RenderSVGText.cpp: (WebCore::RenderSVGText::createRootBox):
  • rendering/RenderText.cpp: (WebCore::RenderText::createInlineTextBox):
  • rendering/RootInlineBox.cpp:
  • rendering/RootInlineBox.h:
  • rendering/SVGInlineFlowBox.h: (WebCore::SVGInlineFlowBox::svgBoxHeight):
  • rendering/SVGInlineTextBox.h: (WebCore::SVGInlineTextBox::svgBoxHeight):
  • rendering/SVGRootInlineBox.h: (WebCore::SVGRootInlineBox::svgBoxHeight):
3:25 PM Changeset in webkit [42845] by eric@webkit.org
  • 2 edits in trunk/WebKitTools

Reviewed by Adam Roben.

Add PrettyPatch support to run-webkit-tests

  • Scripts/run-webkit-tests:
3:09 PM Changeset in webkit [42844] by oliver@apple.com
  • 2 edits in trunk/JavaScriptCore

Build fix

3:00 PM Changeset in webkit [42843] by Dimitri Glazkov
  • 24 edits
    4 adds in trunk/WebCore

2009-04-24 Dimitri Glazkov <Dimitri Glazkov>

Reviewed by Eric Seidel.

​https://bugs.webkit.org/show_bug.cgi?id=25370
Introduce ScriptEventListener to refactor away direct references to
JSLazyEventListener in WebCore code.

  • GNUmakefile.am: Added ScriptEventListener to project.
  • WebCore.pro: Ditto.
  • WebCore.vcproj/WebCore.vcproj: Ditto.
  • WebCore.xcodeproj/project.pbxproj: Ditto.
  • bindings/js/JSDOMGlobalObject.cpp: Removed unused JSLazyEventListener include.
  • bindings/js/JSLazyEventListener.cpp: Moved createAttributeEventListener helpers

to ScriptEventListener.

  • bindings/js/JSLazyEventListener.h: Ditto.
  • bindings/js/ScriptController.cpp: Removed unused JSLazyEventListener include.
  • bindings/js/ScriptEventListener.cpp: Added.
  • bindings/js/ScriptEventListener.h: Added.
  • bindings/v8/ScriptEventListener.cpp: Added.
  • bindings/v8/ScriptEventListener.h: Added.
  • dom/Document.cpp: Renamed JSLazyEventListener include to ScriptEventListener.
  • html/HTMLBodyElement.cpp: Ditto.
  • html/HTMLButtonElement.cpp: Ditto.
  • html/HTMLElement.cpp: Ditto.
  • html/HTMLFormElement.cpp: Ditto.
  • html/HTMLFrameElementBase.cpp: Ditto.
  • html/HTMLFrameSetElement.cpp: Ditto.
  • html/HTMLImageElement.cpp: Ditto.
  • html/HTMLInputElement.cpp: Ditto.
  • html/HTMLObjectElement.cpp: Ditto.
  • html/HTMLScriptElement.cpp: Ditto.
  • html/HTMLSelectElement.cpp: Ditto.
  • html/HTMLTextAreaElement.cpp: Ditto.
  • svg/SVGElement.cpp: Ditto.
  • svg/SVGSVGElement.cpp: Ditto.
2:53 PM Changeset in webkit [42842] by oliver@apple.com
  • 3 edits in trunk/JavaScriptCore

<rdar://problem/6050421> JavaScript register file should remap to release physical pages accumulated during deep recursion

Reviewed by Geoff Garen

We now track the maximum extent of the RegisterFile, and when we reach the final
return from JS (so the stack portion of the registerfile becomes empty) we see
if that extent is greater than maxExcessCapacity. If it is we use madvise or
VirtualFree to release the physical pages that were backing the excess.

2:52 PM Changeset in webkit [42841] by Darin Adler
  • 2 edits in trunk/WebCore

2009-04-24 Darin Adler <Darin Adler>

Reviewed by Sam Weinig.

Bug 25355: Crash when Creating New Tab or New Window when set to open Same Page
​https://bugs.webkit.org/show_bug.cgi?id=25355
rdar://problem/6823543

  • loader/FrameLoader.cpp: (WebCore::FrameLoader::loadItem): Added a null check.
2:34 PM Changeset in webkit [42840] by eric@webkit.org
  • 44 edits in trunk

Reviewed by Simon Fraser.

Fix RenderSVGImage to dump with full bounds and style information.
​https://bugs.webkit.org/show_bug.cgi?id=25377

No functional changes, we're just now including more info in render tree dumps.

  • rendering/RenderObject.h: (WebCore::RenderObject::isSVGImage):
  • rendering/RenderSVGImage.h: (WebCore::RenderSVGImage::isSVGImage):
  • rendering/RenderTreeAsText.cpp: (WebCore::write):
  • rendering/SVGRenderTreeAsText.cpp: (WebCore::operator<<): (WebCore::write):
  • rendering/SVGRenderTreeAsText.h:
2:30 PM Changeset in webkit [42839] by andersca@apple.com
  • 2 edits in trunk/WebKit/mac

2009-04-24 Anders Carlsson <​andersca@apple.com>

Reviewed by Darin Adler.

Fix <rdar://problem/6761635>.


Make sure to keep an extra reference to the instance proxy in case the plug-in host crashes while
we're waiting for a reply.


  • Plugins/Hosted/NetscapePluginInstanceProxy.mm: (WebKit::NetscapePluginInstanceProxy::destroy):
2:18 PM Changeset in webkit [42838] by levin@chromium.org
  • 7 edits in trunk/WebCore

2009-04-24 David Levin <​levin@chromium.org>

Reviewed by NOBODY (chromium build fix).

Rename "isInline" => "isAttribute" in v8 bindings (jsc was done in r42699).

  • bindings/v8/V8AbstractEventListener.cpp: (WebCore::V8AbstractEventListener::V8AbstractEventListener): (WebCore::V8AbstractEventListener::invokeEventHandler):
  • bindings/v8/V8AbstractEventListener.h:
  • bindings/v8/V8EventListenerList.cpp: (WebCore::V8EventListenerList::add): (WebCore::V8EventListenerList::remove): (WebCore::V8EventListenerList::clear):
  • bindings/v8/V8LazyEventListener.h: (WebCore::V8LazyEventListener::virtualisAttribute):
  • bindings/v8/custom/V8CustomEventListener.cpp: (WebCore::V8EventListener::V8EventListener):
  • bindings/v8/custom/V8CustomEventListener.h: (WebCore::V8EventListener::create): (WebCore::V8EventListener::virtualisAttribute):
2:16 PM Changeset in webkit [42837] by xan@webkit.org
  • 2 edits in trunk/WebKit/gtk

2009-04-24 Johan Bilien <​jobi@via.ecp.fr>

Reviewed by Xan Lopez.

​https://bugs.webkit.org/show_bug.cgi?id=25373
Popup menu has the wrong size when popped up near the edge
of the screen

  • webkit/webkitwebview.cpp: (webkit_web_view_forward_context_menu_event): Let GTK place the popup menu instead of trying to do better and failing
1:48 PM Changeset in webkit [42836] by Simon Fraser
  • 19 edits in trunk/LayoutTests

2009-04-24 Pierre d'Herbemont <​pdherbemont@apple.com>

Reviewed by Simon Fraser

<rdar://problem/6805928> Re-export layout test MPEG-4 file to remove unusual edit

Use better mp4 test file for media tests. The original mp4 file had an unusual
edit (non-zero start time) which is not supported by all media engines. The new
movie should also give more useful pixel test results.

  • media/content/test.mp4: Update the movie.
  • media/progress-event-total-expected.txt: Update test results to match movie duration and content changes.
  • media/progress-event-total.html: Ditto.
  • media/video-currentTime-set-expected.txt: Ditto.
  • media/video-loop-expected.txt: Ditto.
  • platform/mac/media/video-aspect-ratio-expected.checksum: Ditto.
  • platform/mac/media/video-aspect-ratio-expected.png: Ditto.
  • platform/mac/media/video-controls-rendering-expected.checksum: Ditto.
  • platform/mac/media/video-controls-rendering-expected.png: Ditto.
  • platform/mac/media/video-display-toggle-expected.checksum: Ditto.
  • platform/mac/media/video-display-toggle-expected.png: Ditto.
  • platform/mac/media/video-empty-source-expected.checksum: Ditto.
  • platform/mac/media/video-layer-crash-expected.checksum: Ditto.
  • platform/mac/media/video-layer-crash-expected.png: Ditto.
  • platform/mac/media/video-transformed-expected.checksum: Ditto.
  • platform/mac/media/video-transformed-expected.png: Ditto.
  • platform/mac/media/video-zoom-expected.checksum: Ditto.
  • platform/mac/media/video-zoom-expected.png: Ditto.
1:08 PM Changeset in webkit [42835] by sfalken@apple.com
  • 2 edits in trunk/WebKitTools

Fix nightly for Windows x64 users.
Installed browser location is written to a slightly different registry key in that case.


  • FindSafari/FindSafari.cpp: (getInstalledWebKitDirectory):
12:13 PM Changeset in webkit [42834] by kmccullough@apple.com
  • 1 edit
    2 adds in trunk/LayoutTests

2009-04-24 Kevin McCullough <​kmccullough@apple.com>

When I moved the files I forgot to update the location of the image!

  • platform/mac/editing/deleting/deletionUI-differing-background-expected.txt: Added.
  • platform/mac/editing/deleting/deletionUI-differing-background.html: Added.
11:43 AM Changeset in webkit [42833] by Dimitri Glazkov
  • 2 edits in trunk/WebCore

2009-04-24 Nate Chapin <​japhet@google.com>

Reviewed by Dimitri Glazkov.

​https://bugs.webkit.org/show_bug.cgi?id=25343
Fix Chromium/Skia bug where -webkit-box-shadow with 0,0 offset
ignores blur.

  • WebCore\platform\graphics\skia\GraphicsContextSkia.cpp (WebCore::GraphicsContext::setPlatformShadow): Add check against blur before clearing looper.
11:41 AM Changeset in webkit [42832] by kmccullough@apple.com
  • 1 edit
    3 deletes in trunk/LayoutTests

2009-04-24 Kevin McCullough <​kmccullough@apple.com>

  • Build fix. Removed this test until I can figure out why it's failing.
  • platform/mac-leopard/editing/deleting/deletionUI-differing-background-expected.txt: Removed.
  • platform/mac/editing/deleting/deletionUI-differing-background-expected.txt: Removed.
  • platform/mac/editing/deleting/deletionUI-differing-background.html: Removed.
11:40 AM Changeset in webkit [42831] by Dimitri Glazkov
  • 3 edits
    2 adds in trunk

WebCore:

2009-04-24 Eric Roman <​eroman@chromium.org>

Reviewed by Darin Adler.

Initialize TextIterator::m_textLength to 0.

This assures that TextIterator::length() will return 0 for cases when TextIterator's constructor returns early (because there is nothing to iterate over in the range).

<​https://bugs.webkit.org/show_bug.cgi?id=25335>

Test: editing/selection/doubleclick-whitespace-img-crash.html

  • editing/TextIterator.cpp: (WebCore::TextIterator::TextIterator):

LayoutTests:

2009-04-24 Eric Roman <​eroman@chromium.org>

Reviewed by Darin Adler.

Add a test for <​https://bugs.webkit.org/show_bug.cgi?id=25335>.

To pass, this test must not access invalid memory when run (won't necessarily manifest as a crash for failures).

  • editing/selection/doubleclick-whitespace-img-crash-expected.txt: Added.
  • editing/selection/doubleclick-whitespace-img-crash.html: Added.
11:38 AM Changeset in webkit [42830] by Simon Fraser
  • 3 edits in trunk/WebKitLibraries

2009-04-24 Simon Fraser <Simon Fraser>

Source changes reviewed by Darin Adler

​https://bugs.webkit.org/show_bug.cgi?id=22242

Update WebKitSystemInterface for Mac with fixes for video controller drawing.

  • libWebKitSystemInterfaceLeopard.a:
  • libWebKitSystemInterfaceTiger.a:
11:36 AM Changeset in webkit [42829] by Dimitri Glazkov
  • 1 edit
    1 add in trunk/WebCore

2009-04-24 Fumitoshi Ukai <​ukai@google.com>

Reviewed by Dimitri Glazkov.

​https://bugs.webkit.org/show_bug.cgi?id=25329
Add indexed access method in v8 binding of ClientRectList.

  • bindings/v8/custom/V8ClientRectListCustom.cpp: Added.
11:32 AM Changeset in webkit [42828] by Dimitri Glazkov
  • 4 edits
    3 adds in trunk

WebCore:

2009-04-24 Fumitoshi Ukai <​ukai@google.com>

Reviewed by Dimitri Glazkov.

​https://bugs.webkit.org/show_bug.cgi?id=25257
Use null for unspecified event listener attributes of XMLHttpRequest
and XMLHttpRequestUpload in v8 binding.

cf. ​http://www.whatwg.org/specs/web-apps/current-work/#event-handler-attributes
An event handler attribute, unless otherwise specified, can either
have the value null or be set to a Function object.
Initially, an event handler attribute must be set to null.

Test: fast/xmlhttprequest/xmlhttprequest-default-attributes.html

  • bindings/v8/custom/V8XMLHttpRequestCustom.cpp: (WebCore::ACCESSOR_GETTER): Changed to use v8::Null().
  • bindings/v8/custom/V8XMLHttpRequestUploadCustom.cpp: (WebCore::ACCESSOR_GETTER): Ditto.

LayoutTests:

2009-04-24 Fumitoshi Ukai <​ukai@google.com>

Reviewed by Dimitri Glazkov.

​https://bugs.webkit.org/show_bug.cgi?id=25257
Verify XMLHttpRequest has correct attribute value by default.

  • fast/xmlhttprequest/resources/xmlhttprequest-default-attributes.js: Added.
  • fast/xmlhttprequest/xmlhttprequest-default-attributes-expected.txt: Added.
  • fast/xmlhttprequest/xmlhttprequest-default-attributes.html: Added.
11:02 AM Changeset in webkit [42827] by christian@webkit.org
  • 2 edits in trunk/WebKit/gtk

2009-04-24 Christian Dywan <​christian@twotoasts.de>

Rubber-stamped by Gustavo Noronha.

  • webkit/webkitwebsettings.cpp: (_WebKitWebSettingsPrivate::webkit_web_settings_class_init): Reword the description of the enable-spell-checking property and correct the mentioning of the default language used.
10:42 AM Changeset in webkit [42826] by kmccullough@apple.com
  • 1 edit
    3 adds in trunk/LayoutTests

2009-04-24 Kevin McCullough <​kmccullough@apple.com>

Speculative fix for leopard build-bot until I have a fix on leopard.

  • platform/mac-leopard/editing: Added.
  • platform/mac-leopard/editing/deleting: Added.
  • platform/mac-leopard/editing/deleting/deletionUI-differing-background-expected.txt: Added.
9:38 AM Changeset in webkit [42825] by Darin Adler
  • 2 edits in trunk/WebCore

2009-04-24 Darin Adler <Darin Adler>

Reviewed by Adam Roben.

<rdar://problem/6663836> CrashTracer: crashes in Safari at com.apple.WebCore • WebCore::reportException + 1513

  • bindings/js/JSDOMBinding.cpp: (WebCore::reportException): Added a null check.
9:13 AM Changeset in webkit [42824] by beidson@apple.com
  • 2 edits in trunk/WebKit/mac

2009-04-24 Brady Eidson <​beidson@apple.com>

Reviewed by Dan Bernstein

Currently working on a bug where a WebHistoryItem was being used after being dealloc'ed.
I added this assertion to help catch the case as soon as it happens instead of random
issues downstream. Figured it's worth checking in by itself.

  • History/WebHistoryItem.mm: (core): ASSERT that the WebCore::HistoryItem inside this WebHistoryItem is supposed to have this WebHistoryItem as a wrapper.
9:10 AM Changeset in webkit [42823] by Simon Fraser
  • 4 edits
    4 adds in trunk

2009-04-24 Simon Fraser <Simon Fraser>

Reviewed by Darin Adler

​https://bugs.webkit.org/show_bug.cgi?id=23219

Add support for transtions and animations of background-position, -webkit-background-size,
-webkit-mask-position and -webkit-mask-size.

Tests: transitions/background-transitions.html

transitions/mask-transitions.html

  • page/animation/AnimationBase.cpp: (WebCore::blendFunc): Add a blend func for LengthSize.

(WebCore::ensurePropertyMap):
Add wrappers for the new properties.

(WebCore::addShorthandProperties):
Add a shorthand property for CSSPropertyBackgroundPosition to map to
CSSPropertyBackgroundPositionX and CSSPropertyBackgroundPositionY,
add CSSPropertyWebkitMask for CSSPropertyWebkitMaskPosition, and add
CSSPropertyWebkitMaskPosition for CSSPropertyWebkitMaskPositionX and
CSSPropertyWebkitMaskPositionY.

  • rendering/style/RenderStyle.h: (WebCore::InheritedFlags::setBackgroundXPosition): (WebCore::InheritedFlags::setBackgroundYPosition): (WebCore::InheritedFlags::setBackgroundSize): (WebCore::InheritedFlags::setMaskXPosition): (WebCore::InheritedFlags::setMaskYPosition): (WebCore::InheritedFlags::setMaskSize): Add setters for the properties that can be animated now.
8:55 AM Changeset in webkit [42822] by adele@apple.com
  • 7 edits in trunk/LayoutTests

2009-04-24 Adele Peterson <​adele@apple.com>

Reviewed by Dan Bernstein.

Updating these pixel results to the generated results on Leopard.

  • platform/mac/editing/inserting/5510537-expected.checksum:
  • platform/mac/editing/inserting/5510537-expected.png:
  • platform/mac/editing/inserting/6703873-expected.checksum:
  • platform/mac/editing/inserting/6703873-expected.png:
  • platform/mac/editing/selection/select-all-iframe-expected.checksum:
  • platform/mac/editing/selection/select-all-iframe-expected.png:
8:39 AM Changeset in webkit [42821] by adele@apple.com
  • 7 edits
    4 adds in trunk

WebCore:

2009-04-24 Adele Peterson <​adele@apple.com>

Reviewed by Darin Adler.

Fix for <rdar://problem/5089327> Newline gets stripped when pasting whole lines in certain markup

Test: editing/pasteboard/paste-blockquote-after-blockquote.html

When we have matching quote levels, its ok to merge the starts of the inserted and existing blocks more frequently.
But we should only merge here if the selection start was inside a mail blockquote. This prevents against removing a
blockquote from newly pasted quoted content that was pasted into an unquoted position. If that unquoted position happens
to be right after another blockquote, we don't want to merge and risk stripping a valid block (and newline) from the pasted content.

  • editing/ReplaceSelectionCommand.cpp: (WebCore::ReplaceSelectionCommand::shouldMergeStart): Also added an early return to always return false when we're already moving paragraphs. (WebCore::ReplaceSelectionCommand::doApply): Removed redundant check for when we're moving paragraphs.
  • editing/ReplaceSelectionCommand.h:

LayoutTests:

2009-04-24 Adele Peterson <​adele@apple.com>

Reviewed by Darin Adler.

Test for <rdar://problem/5089327> Newline gets stripped when pasting whole lines in certain markup

  • editing/pasteboard/paste-blockquote-after-blockquote.html: Added.
  • platform/mac/editing/pasteboard/paste-blockquote-after-blockquote-expected.checksum: Added.
  • platform/mac/editing/pasteboard/paste-blockquote-after-blockquote-expected.png: Added.
  • platform/mac/editing/pasteboard/paste-blockquote-after-blockquote-expected.txt: Added.
6:16 AM Changeset in webkit [42820] by kov@webkit.org
  • 2 edits in trunk/WebKit/gtk

2009-04-24 Diego Escalante Urrelo <​diegoe@gnome.org>

Reviewed by Gustavo Noronha.

​https://bugs.webkit.org/show_bug.cgi?id=15616
[GTK] Add spell checking

Implement EditorClient::ignoreWordInSpellDocument,
EditorClient::learnWord and EditorClient::getGuessesForWord. This
enables the corresponding user actions.

  • WebCoreSupport/EditorClientGtk.cpp: (WebKit::EditorClient::ignoreWordInSpellDocument): (WebKit::EditorClient::learnWord): (WebKit::EditorClient::getGuessesForWord):
6:16 AM Changeset in webkit [42819] by kov@webkit.org
  • 2 edits in trunk/WebKit/gtk

2009-04-24 Diego Escalante Urrelo <​diegoe@gnome.org>

Reviewed by Gustavo Noronha.

​https://bugs.webkit.org/show_bug.cgi?id=15616
[GTK] Add spell checking

Implement EditorClient::checkSpellingOfString; enabling spell checking
to actually happen, this is the basis for other spelling functions.

  • WebCoreSupport/EditorClientGtk.cpp: (WebKit::EditorClient::checkSpellingOfString):
6:16 AM Changeset in webkit [42818] by kov@webkit.org
  • 6 edits in trunk

2009-04-24 Diego Escalante Urrelo <​diegoe@gnome.org>

Reviewed by Gustavo Noronha.

​https://bugs.webkit.org/show_bug.cgi?id=15616
[GTK] Add spell checking

Add enchant support for spell-checking-languages property to work
properly.

  • GNUmakefile.am:
  • configure.ac:

WebKit/gtk

2009-04-24 Diego Escalante Urrelo <​diegoe@gnome.org>

Reviewed by Gustavo Noronha.

​https://bugs.webkit.org/show_bug.cgi?id=15616
[GTK] Add spell checking

Add spell-checking-languages property to WebKitWebSettings.

  • webkit/webkitprivate.h:
  • webkit/webkitwebsettings.cpp: (_WebKitWebSettingsPrivate::): (_WebKitWebSettingsPrivate::webkit_web_settings_class_init): (_WebKitWebSettingsPrivate::webkit_web_settings_init): (_WebKitWebSettingsPrivate::webkit_web_settings_finalize): (_WebKitWebSettingsPrivate::webkit_web_settings_set_property): (_WebKitWebSettingsPrivate::webkit_web_settings_get_property): (_WebKitWebSettingsPrivate::webkit_web_settings_copy): (_WebKitWebSettingsPrivate::webkit_web_settings_get_spell_languages):
6:16 AM Changeset in webkit [42817] by kov@webkit.org
  • 3 edits in trunk/WebKit/gtk

2009-04-24 Diego Escalante Urrelo <​diegoe@gnome.org>

Reviewed by Gustavo Noronha.

​https://bugs.webkit.org/show_bug.cgi?id=15616
[GTK] Add spell checking

Add enable-spell-checking property to WebKitWebSettings and implement
EditorClient::isContinuousSpellCheckingEnabled and
EditorClient::toggleContinuousSpellChecking to allow the UI to
enable check as you type spell checking.

  • WebCoreSupport/EditorClientGtk.cpp: (WebKit::EditorClient::isContinuousSpellCheckingEnabled): (WebKit::EditorClient::toggleContinuousSpellChecking):
  • webkit/webkitwebsettings.cpp: (_WebKitWebSettingsPrivate::): (_WebKitWebSettingsPrivate::webkit_web_settings_class_init): (_WebKitWebSettingsPrivate::webkit_web_settings_set_property): (_WebKitWebSettingsPrivate::webkit_web_settings_get_property): (_WebKitWebSettingsPrivate::webkit_web_settings_copy):
4:12 AM Changeset in webkit [42816] by ariya@webkit.org
  • 1 edit
    1 add in trunk/LayoutTests

2009-04-24 Ariya Hidayat <​ariya.hidayat@nokia.com>

Reviewed by Simon Hausmann.

Added Qt-specific expected result for color conversion.

This is to compensate the lack of color profile in Qt to do
color conversion, hence CMYK 0,0,0,1 always give pure black (#000)
instead of very dark black.

  • platform/qt/fast/canvas/set-colors-expected.txt: Added.
4:08 AM Changeset in webkit [42815] by Simon Hausmann
  • 2 edits in trunk/WebKit/qt

2009-04-24 Simon Hausmann <​simon.hausmann@nokia.com>

Rubber-stamped by Ariya Hidayat.

Fix qdoc warning about link to QAction::isEnabled.

3:30 AM Changeset in webkit [42814] by Simon Hausmann
  • 5 edits
    13 adds in trunk

2009-04-24 Simon Hausmann <​simon.hausmann@nokia.com>

Reviewed by Ariya Hidayat.

Added support for generating API docs in the Qt build using "make docs"

Added code snippets and overview from the Qt sources references in the API docs.

1:24 AM QtWebKitJournal edited by Simon Hausmann
(diff)
Note: See TracTimeline for information about the timeline view.