⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Apr 26, 2009:

10:58 PM Changeset in webkit [42885] by xan@webkit.org
  • 2 edits in trunk/WebKit/gtk

2009-04-26 Xan Lopez <​xlopez@igalia.com>

Reviewed by Mark Rowe.

Plug memory leak.

  • WebCoreSupport/FrameLoaderClientGtk.cpp: (WebKit::FrameLoaderClient::dispatchDidFailLoad):
10:17 PM Changeset in webkit [42884] by barraclough@apple.com
  • 2 edits in trunk/JavaScriptCore

2009-04-26 Gavin Barraclough <​barraclough@apple.com>

Reviewed by Weinig Sam.

Fix for ​https://bugs.webkit.org/show_bug.cgi?id=25416
"Cached prototype accesses unsafely hoist property storage load above structure checks."


Do not hoist the load of the pointer to the property storage array.

No performance impact.

  • jit/JITPropertyAccess.cpp: (JSC::JIT::privateCompileGetByIdProto): (JSC::JIT::privateCompileGetByIdProtoList):
9:32 PM Changeset in webkit [42883] by barraclough@apple.com
  • 2 edits in trunk/JavaScriptCore

2009-04-26 Gavin Barraclough <​barraclough@apple.com>

Reviewed by Geoffrey "Gaffe or energy?" Garen.

Randomize address requested by ExecutableAllocatorFixedVMPool.

  • jit/ExecutableAllocatorFixedVMPool.cpp: (JSC::FixedVMPoolAllocator::FixedVMPoolAllocator):
5:03 PM Changeset in webkit [42882] by weinig@apple.com
  • 10 edits
    3 adds in trunk

WebCore:

2009-04-26 Sam Weinig <​sam@webkit.org>

Reviewed by Dan Bernstein.

Fix for ​https://bugs.webkit.org/show_bug.cgi?id=25412
The Window object should be an EventTarget

Test: fast/dom/Window/dispatchEvent.html

  • bindings/js/JSEventTarget.cpp: (WebCore::toJS): Add DOMWindow case. (WebCore::toEventTarget): Ditto.
  • dom/EventTarget.cpp: (WebCore::EventTarget::toDOMWindow): Added.
  • dom/EventTarget.h:
  • page/DOMWindow.cpp: (WebCore::DOMWindow::scriptExecutionContext): Added. Returns the document. (WebCore::DOMWindow::dispatchEvent): Added.
  • page/DOMWindow.h: (WebCore::DOMWindow::toDOMWindow): (WebCore::DOMWindow::refEventTarget): (WebCore::DOMWindow::derefEventTarget):
  • page/DOMWindow.idl:

LayoutTests:

2009-04-26 Sam Weinig <​sam@webkit.org>

Reviewed by Dan Bernstein.

Tests for ​https://bugs.webkit.org/show_bug.cgi?id=25412
The Window object should be an EventTarget

  • fast/dom/Window/dispatchEvent-expected.txt: Added.
  • fast/dom/Window/dispatchEvent.html: Added.
  • fast/dom/Window/resources/dispatchEvent.js: Added.
  • fast/dom/Window/window-properties-expected.txt
  • platform/mac-leopard/fast/dom/Window/window-properties-expected.txt:
2:09 PM Changeset in webkit [42881] by weinig@apple.com
  • 2 edits
    2 deletes in trunk

JavaScriptCore:

2009-04-26 Sam Weinig <​sam@webkit.org>

Reviewed by Eric Seidel.

Remove scons-based build system.

WebCore:

2009-04-26 Sam Weinig <​sam@webkit.org>

Reviewed by Eric Seidel.

Remove scons-based build system.

  • WebCore.scons: Removed.
11:11 AM Changeset in webkit [42880] by kov@webkit.org
  • 2 edits in trunk/WebKitTools

2009-04-26 Gustavo Noronha Silva <Gustavo Noronha Silva>

Reviewed by Xan Lopez.

Resolve relative URLs when queueing loads. This fixes
post-goback-same-url.html timing out.

  • DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: (LayoutTestController::queueLoad):
10:23 AM Changeset in webkit [42879] by xan@webkit.org
  • 5 edits in trunk/WebKit/gtk

2009-04-26 Xan Lopez <​xlopez@igalia.com>

Reviewed by Gustavo Noronha.

​https://bugs.webkit.org/show_bug.cgi?id=25391
G_SIGNAL_ACTION flag in WebKitWebView signals

Most of the signals in WebKitGTK+ have the G_SIGNAL_ACTION flag,
but I don't think this makes sense. The flag is meant for those
signals that can be emitted by the user to trigger some action in
the view, as if it were a normal API, which is not the case for
most of them.

  • webkit/webkitdownload.cpp: (_WebKitDownloadPrivate::webkit_download_class_init):
  • webkit/webkitwebframe.cpp:
  • webkit/webkitwebinspector.cpp: (_WebKitWebInspectorPrivate::webkit_web_inspector_class_init):
  • webkit/webkitwebview.cpp:
10:11 AM Changeset in webkit [42878] by xan@webkit.org
  • 2 edits in trunk/WebKit/gtk

2009-04-26 Xan Lopez <​xlopez@igalia.com>

Unreviewed, actually apply the right patch.

  • webkit/webkitwebview.cpp: (webkit_web_view_move_cursor):
10:05 AM Changeset in webkit [42877] by xan@webkit.org
  • 2 edits in trunk/WebKit/gtk

2009-04-26 Xan Lopez <​xlopez@igalia.com>

Reviewed by Gustavo Noronha.

Pass a variable to hold the return value of the 'move-cursor'
signal, otherwise a crash can happen.

  • webkit/webkitwebview.cpp: (webkit_web_view_move_cursor):
7:25 AM Changeset in webkit [42876] by Darin Adler
  • 2 edits in trunk/WebCore

2009-04-26 Darin Adler <Darin Adler>

Suggested by Darin Fisher.

Improve the fix for bug 25355: Crash when Creating New Tab or New Window when set to open Same Page
​https://bugs.webkit.org/show_bug.cgi?id=25355
rdar://problem/6823543

  • loader/FrameLoader.cpp: (WebCore::FrameLoader::loadItem): Allow shouldScroll to be true even if m_currentHistoryItem is 0. Not sure if when this case can really arise in practice, but it's good to match the original logic more closely.
12:02 AM QtWebKitTodo edited by Simon Hausmann
(diff)
12:01 AM Changeset in webkit [42875] by krit@webkit.org
  • 2 edits in trunk/WebCore

2009-04-25 Dirk Schulze <​krit@webkit.org>

Reviewed by Oliver Hunt.

A width or height of zero for the destination or source rect of an
image causes a not invertible pattern matrix.
This crahes newer versions of Cairo and give some graphic gliches in
Canvas.
With this patch we check if there is something to draw and return if not.

  • platform/graphics/cairo/ImageCairo.cpp: (WebCore::BitmapImage::draw):

Apr 25, 2009:

9:35 PM Changeset in webkit [42874] by kov@webkit.org
  • 2 edits in trunk/LayoutTests

2009-04-25 Gustavo Noronha Silva <Gustavo Noronha Silva>

Go back to disabling accessibility tests as a whole, since we have
no real way of checking them, and no accessibilityController
implementation.

  • platform/gtk/Skipped:
9:25 PM Changeset in webkit [42873] by kov@webkit.org
  • 2 edits in trunk/LayoutTests

2009-04-25 Gustavo Noronha Silva <Gustavo Noronha Silva>

Disable tests that need eventSender, not yet implemented in our
DumpRenderTree.

  • platform/gtk/Skipped:
9:11 PM Changeset in webkit [42872] by Simon Fraser
  • 6 edits
    2 adds in trunk

2009-04-24 Simon Fraser <Simon Fraser>

Reviewed by Darin Adler

​https://bugs.webkit.org/show_bug.cgi?id=25390

Fix point mapping and hit testing through transforms and perspective
with ENABLE_3D_RENDERING. Previously the code did the more efficient
move(), rather than getTransformFromContainer(), when the object had
no transform. However, this skipped the application of perspective
when the immediate child of the perspective element had no transform
itself.

Test: transforms/3d/point-mapping/3d-point-mapping-3.html

  • rendering/RenderBox.cpp: (WebCore::RenderBox::mapLocalToContainer): (WebCore::RenderBox::mapAbsoluteToLocalPoint):
  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::createLocalTransformState): Call shouldUseTransformFromContainer() to determine if we need to go through the more expensive getTransformFromContainer() code path.
  • rendering/RenderObject.h:
  • rendering/RenderObject.cpp: (WebCore::RenderObject::shouldUseTransformFromContainer): New method that indicates whether we need use getTransformFromContainer() when mapping points through renderers, and hit testing.
4:30 PM Changeset in webkit [42871] by beidson@apple.com
  • 2 edits in trunk/WebKit/mac

2009-04-25 Brady Eidson <​beidson@apple.com>

Reviewed by Sam Weinig

Some *obvious* style cleanup in my last patch.

  • History/WebBackForwardList.mm: (bumperCarBackForwardHackNeeded):
4:24 PM Changeset in webkit [42870] by beidson@apple.com
  • 3 edits in trunk/WebKit/mac

2009-04-25 Brady Eidson <​beidson@apple.com>

Reviewed by Oliver Hunt

<rdar://problem/6817607> BumperCar 2.2 crashes going back (invalid WebHistoryItem)

BumperCar was holding a pointer to a WebHistoryItem they never retain, then later
tried to go to it. In some cases it would be dealloc'ed first.
When WebHistoryItems were pure Objective-C they probably got away with this more often.
With the WebCore/Obj-C mixed WebHistoryItems it's more likely to crash.

  • History/WebBackForwardList.mm: (bumperCarBackForwardHackNeeded): (-[WebBackForwardList backListWithLimit:]): If this is BumperCar, hang on to the NSArray of WebHistoryItems until the next time this method is called. (-[WebBackForwardList forwardListWithLimit:]): Ditto.
  • Misc/WebKitVersionChecks.h: Added WEBKIT_FIRST_VERSION_WITHOUT_BUMPERCAR_BACK_FORWARD_QUIRK.
12:00 PM Changeset in webkit [42869] by adele@apple.com
  • 3 edits
    4 adds in trunk

WebCore:

2009-04-25 Adele Peterson <​adele@apple.com>

Reviewed by Oliver Hunt.

Fix for <rdar://problem/6712771> REGRESSION(34681): Text is no longer underlined after delete
​https://bugs.webkit.org/show_bug.cgi?id=25396

Test: editing/deleting/delete-br-013.html

  • editing/CompositeEditCommand.cpp: (WebCore::CompositeEditCommand::moveParagraphs): Only preserve an empty paragraph's style when moving paragraphs around if the selection is still in an empty paragraph after the move occurs. This was causing the empty paragraph's style to overwrite the previous paragraph's style during a delete of an empty paragraph.

LayoutTests:

2009-04-25 Adele Peterson <​adele@apple.com>

Reviewed by Oliver Hunt.

Test for <rdar://problem/6712771> REGRESSION(34681): Text is no longer underlined after delete
​https://bugs.webkit.org/show_bug.cgi?id=25396

  • editing/deleting/delete-br-013.html: Added.
  • platform/mac/editing/deleting/delete-br-013-expected.checksum: Added.
  • platform/mac/editing/deleting/delete-br-013-expected.png: Added.
  • platform/mac/editing/deleting/delete-br-013-expected.txt: Added.
10:48 AM Changeset in webkit [42868] by eric.carlson@apple.com
  • 8 edits in trunk/WebCore

2009-04-25 Eric Carlson <​eric.carlson@apple.com>

Reviewed by Darin Adler.

<rdar://problem/6808171> REGRESSION (3-4): Standalone media documents don't
properly display non-linear media

If a media engine claims it can support the MIME type, WebCore now creates a <video>
element for document mode media files instead of an <embed> element. Because WebCore's
QuickTime backed media players do not support every kind of media the QuickTime plug-in
supports, and because it is not always possible to tell what type of media is in a file
without opening and parsing it, some types of media that used to be displayed properly
by a plug-in are no longer supported properly. To fix this, if the media engine
sees that it can not completely support a media file it now informs the media
document, which replaces the <video> element with an <embed>.


r42301 landed support for OSX. This patch modifies those changes slighly and adds support
for Windows.

  • loader/MediaDocument.cpp: (WebCore::MediaDocument::MediaDocument): Initialize m_replaceMediaElementTimer. (WebCore::MediaDocument::mediaElementSawUnsupportedTracks): Don't replace the <video> element immediately. (WebCore::MediaDocument::replaceMediaElementTimerFired): Renamed from replaceVideoWithEmbed. Set body margin-width and margin-height to 0 as that is what a PluginDocument uses.
  • loader/MediaDocument.h:
  • platform/graphics/mac/MediaPlayerPrivateQTKit.mm: (WebCore::MediaPlayerPrivate::loadStateChanged): Don't do anything if m_hasUnsupportedTracks. (WebCore::MediaPlayerPrivate::rateChanged): Ditto. (WebCore::MediaPlayerPrivate::timeChanged): Ditto. (WebCore::MediaPlayerPrivate::didEnd): Ditto. (WebCore::MediaPlayerPrivate::repaint): Ditto. (WebCore::MediaPlayerPrivate::paint): Ditto. (WebCore::MediaPlayerPrivate::sawUnsupportedTracks): Set m_hasUnsupportedTracks before callback.
  • platform/graphics/win/MediaPlayerPrivateQuickTimeWin.cpp: (WebCore::MediaPlayerPrivate::MediaPlayerPrivate): Initialize m_totalTrackCount and m_hasUnsupportedTracks. (WebCore::MediaPlayerPrivate::updateStates): Call sawUnsupportedTracks if the movie has unsupported media type(s) or if it fails completely. (WebCore::MediaPlayerPrivate::sawUnsupportedTracks): New, disable the movie object and tell the media player client we won't play this movie correctly. (WebCore::MediaPlayerPrivate::didEnd): Don't do anything if m_hasUnsupportedTracks. (WebCore::MediaPlayerPrivate::setSize): Ditto. (WebCore::MediaPlayerPrivate::setVisible): Ditto. (WebCore::MediaPlayerPrivate::paint): Ditto. (WebCore::MediaPlayerPrivate::movieEnded): Ditto. (WebCore::MediaPlayerPrivate::movieLoadStateChanged): Ditto. (WebCore::MediaPlayerPrivate::movieTimeChanged): Ditto. (WebCore::MediaPlayerPrivate::movieNewImageAvailable): Ditto.
  • platform/graphics/win/MediaPlayerPrivateQuickTimeWin.h:
  • platform/graphics/win/QTMovieWin.cpp: (QTMovieWinPrivate::task): Stop the task timer if we were disabled during the load state change callback. (QTMovieWinPrivate::drawingComplete): Don't do anything if disabled. (QTMovieWin::QTMovieWin): Initialize m_disabled. (QTMovieWin::disableUnsupportedTracks): Return total number of tracks. (QTMovieWin::setDisabled): New, set m_disabled flag.
  • platform/graphics/win/QTMovieWin.h:
7:02 AM Changeset in webkit [42867] by kov@webkit.org
  • 5 edits in trunk/WebKit/gtk

2009-04-25 Gustavo Noronha Silva <​gustavo.noronha@collabora.co.uk>

Reviewed by Xan Lopez.

​https://bugs.webkit.org/show_bug.cgi?id=24786
WebKitDownload sometimes suggests peculiar filenames

Refactor the emission of the download-requested signal so that we
have less code duplication.

  • WebCoreSupport/ContextMenuClientGtk.cpp: (WebKit::ContextMenuClient::downloadURL):
  • WebCoreSupport/FrameLoaderClientGtk.cpp: (WebKit::FrameLoaderClient::startDownload):
  • webkit/webkitprivate.h:
  • webkit/webkitwebview.cpp:
2:19 AM Changeset in webkit [42866] by jmalonzo@webkit.org
  • 6 edits
    2 adds in trunk

2009-04-25 Jan Michael Alonzo <​jmalonzo@webkit.org>

Reviewed by Xan Lopez.

[GTK] Error reporting
​https://bugs.webkit.org/show_bug.cgi?id=18344

Fix the SOUP resource handle to report SOUP_HTTP_ERROR for Soup
errors and G_IO_ERROR for gio errors.

  • platform/network/soup/ResourceHandleSoup.cpp: (WebCore::finishedCallback): (WebCore::ResourceHandle::startHttp): (WebCore::ResourceHandle::start): (WebCore::readCallback): (WebCore::openCallback): (WebCore::queryInfoCallback): (WebCore::ResourceHandle::startGio):

2009-04-25 Jan Michael Alonzo <​jmalonzo@webkit.org>

Reviewed by Xan Lopez.

[GTK] Error reporting
​https://bugs.webkit.org/show_bug.cgi?id=18344

Update FrameLoad errors to use WebKitErrors.

  • WebCoreSupport/FrameLoaderClientGtk.cpp: (WebKit::FrameLoaderClient::cancelledError): (WebKit::FrameLoaderClient::blockedError): (WebKit::FrameLoaderClient::cannotShowURLError): (WebKit::FrameLoaderClient::interruptForPolicyChangeError): (WebKit::FrameLoaderClient::cannotShowMIMETypeError): (WebKit::FrameLoaderClient::fileDoesNotExistError): (WebKit::FrameLoaderClient::pluginWillHandleLoadError): (WebKit::FrameLoaderClient::shouldFallBack):
  • webkit/webkiterror.h: Added.
  • webkit/webkiterror.cpp: Added.

2009-04-25 Jan Michael Alonzo <​jmalonzo@webkit.org>

Reviewed by Xan Lopez.

[GTK] Error reporting
​https://bugs.webkit.org/show_bug.cgi?id=18344

Add webkiterror to the build.

  • GNUmakefile.am:
2:19 AM Changeset in webkit [42865] by jmalonzo@webkit.org
  • 4 edits
    2 adds in trunk

2009-04-25 Jan Michael Alonzo <​jmalonzo@webkit.org>

Reviewed by Xan Lopez.

[GTK] Error reporting
​https://bugs.webkit.org/show_bug.cgi?id=18344

Add the default error page for installation.

  • GNUmakefile.am:

2009-04-25 Jan Michael Alonzo <​jmalonzo@webkit.org>

Reviewed by Xan Lopez.

Display a default error page for load errors.

  • WebCoreSupport/FrameLoaderClientGtk.cpp: (WebKit::FrameLoaderClient::dispatchDidFailLoad):
  • resources/error.html: Added.
2:19 AM Changeset in webkit [42864] by jmalonzo@webkit.org
  • 5 edits in trunk/WebKit/gtk

2009-04-25 Jan Michael Alonzo <​jmalonzo@webkit.org>

Reviewed by Xan Lopez.

[GTK] Error reporting
​https://bugs.webkit.org/show_bug.cgi?id=18344

Add a WebKitWebFrame API to load alternate content for unreachable URLs.
Also add a new signal "load-error" for handling load errors.

  • WebCoreSupport/FrameLoaderClientGtk.cpp: (WebKit::FrameLoaderClient::postProgressFinishedNotification): (WebKit::FrameLoaderClient::dispatchDidFailLoading): (WebKit::FrameLoaderClient::dispatchDidFailProvisionalLoad): (WebKit::FrameLoaderClient::dispatchDidFailLoad):
  • webkit/webkitwebframe.cpp:
  • webkit/webkitwebframe.h:
  • webkit/webkitwebview.cpp:
2:04 AM Changeset in webkit [42863] by oliver@apple.com
  • 2 edits in trunk/JavaScriptCore

Build fix.

1:44 AM Changeset in webkit [42862] by jmalonzo@webkit.org
  • 3 edits in trunk/JavaScriptCore

2009-04-25 Jan Michael Alonzo <​jmalonzo@webkit.org>

Reviewed by Oliver Hunt.

Gtk build fix - check if we have MADV_FREE before using it.

  • interpreter/RegisterFile.cpp: (JSC::RegisterFile::releaseExcessCapacity):
  • wtf/Platform.h:
Note: See TracTimeline for information about the timeline view.