Timeline
Apr 28, 2009:
- 11:49 PM QtWebKitContrib edited by
- (diff)
- 11:38 PM Changeset in webkit [42993] by
-
- 2 edits in trunk/WebCore
Fix the Qt build
- 11:31 PM Changeset in webkit [42992] by
-
- 2 edits in trunk/LayoutTests
Fix the test for <https://bugs.webkit.org/show_bug.cgi?id=25420> - I broke it when
experimenting with other aspects of the issue, so it didn't check what it should have checked.
- http/tests/xmlhttprequest/detaching-frame-2.html:
- 11:19 PM Changeset in webkit [42991] by
-
- 2 edits in trunk/JavaScriptGlue
2009-04-28 Geoffrey Garen <ggaren@apple.com>
Rubber stamped by Beth Dakin.
Missed one.
- UserObjectImp.cpp: (UserObjectImp::callAsFunction):
- 11:08 PM Changeset in webkit [42990] by
-
- 2 edits in trunk/WebCore
2009-04-28 Geoffrey Garen <ggaren@apple.com>
Rubber stamped by Beth Dakin.
Missed one.
- bindings/scripts/CodeGeneratorJS.pm:
- 11:07 PM Changeset in webkit [42989] by
-
- 88 edits in trunk
2009-04-28 Geoffrey Garen <ggaren@apple.com>
Rubber stamped by Beth Dakin.
Removed scaffolding supporting dynamically converting between 32bit and
64bit value representations.
- API/JSCallbackConstructor.cpp: (JSC::constructJSCallback):
- API/JSCallbackFunction.cpp: (JSC::JSCallbackFunction::call):
- API/JSCallbackObjectFunctions.h: (JSC::::construct): (JSC::::call):
- bytecode/CodeBlock.cpp: (JSC::CodeBlock::dump):
- bytecode/CodeBlock.h: (JSC::CodeBlock::getConstant):
- bytecompiler/BytecodeGenerator.cpp: (JSC::BytecodeGenerator::emitEqualityOp):
- interpreter/CallFrame.cpp: (JSC::CallFrame::thisValue):
- interpreter/Interpreter.cpp: (JSC::Interpreter::callEval): (JSC::Interpreter::throwException): (JSC::Interpreter::createExceptionScope): (JSC::Interpreter::privateExecute): (JSC::Interpreter::retrieveArguments):
- interpreter/Register.h: (JSC::Register::): (JSC::Register::Register): (JSC::Register::jsValue): (JSC::Register::marked): (JSC::Register::mark): (JSC::Register::i): (JSC::Register::activation): (JSC::Register::arguments): (JSC::Register::callFrame): (JSC::Register::codeBlock): (JSC::Register::function): (JSC::Register::propertyNameIterator): (JSC::Register::scopeChain): (JSC::Register::vPC):
- jit/JITStubs.cpp: (JSC::JITStubs::cti_op_call_NotJSFunction): (JSC::JITStubs::cti_op_load_varargs): (JSC::JITStubs::cti_op_call_eval):
- jsc.cpp: (functionPrint): (functionDebug): (functionRun): (functionLoad):
- runtime/ArgList.h: (JSC::ArgList::at):
- runtime/Arguments.cpp: (JSC::Arguments::copyToRegisters): (JSC::Arguments::fillArgList): (JSC::Arguments::getOwnPropertySlot):
- runtime/ArrayConstructor.cpp: (JSC::constructArrayWithSizeQuirk):
- runtime/ArrayPrototype.cpp: (JSC::arrayProtoFuncJoin): (JSC::arrayProtoFuncConcat): (JSC::arrayProtoFuncPush): (JSC::arrayProtoFuncSlice): (JSC::arrayProtoFuncSort): (JSC::arrayProtoFuncSplice): (JSC::arrayProtoFuncUnShift): (JSC::arrayProtoFuncFilter): (JSC::arrayProtoFuncMap): (JSC::arrayProtoFuncEvery): (JSC::arrayProtoFuncForEach): (JSC::arrayProtoFuncSome): (JSC::arrayProtoFuncReduce): (JSC::arrayProtoFuncReduceRight): (JSC::arrayProtoFuncIndexOf): (JSC::arrayProtoFuncLastIndexOf):
- runtime/BooleanConstructor.cpp: (JSC::constructBoolean): (JSC::callBooleanConstructor):
- runtime/DateConstructor.cpp: (JSC::constructDate): (JSC::dateParse): (JSC::dateUTC):
- runtime/DatePrototype.cpp: (JSC::formatLocaleDate): (JSC::fillStructuresUsingTimeArgs): (JSC::fillStructuresUsingDateArgs): (JSC::dateProtoFuncSetTime): (JSC::dateProtoFuncSetYear):
- runtime/ErrorConstructor.cpp: (JSC::constructError):
- runtime/FunctionConstructor.cpp: (JSC::constructFunction):
- runtime/FunctionPrototype.cpp: (JSC::functionProtoFuncApply): (JSC::functionProtoFuncCall):
- runtime/JSArray.cpp: (JSC::JSArray::JSArray): (JSC::constructArray):
- runtime/JSArray.h:
- runtime/JSGlobalObjectFunctions.cpp: (JSC::encode): (JSC::decode): (JSC::globalFuncEval): (JSC::globalFuncParseInt): (JSC::globalFuncParseFloat): (JSC::globalFuncIsNaN): (JSC::globalFuncIsFinite): (JSC::globalFuncEscape): (JSC::globalFuncUnescape): (JSC::globalFuncJSCPrint):
- runtime/MathObject.cpp: (JSC::mathProtoFuncAbs): (JSC::mathProtoFuncACos): (JSC::mathProtoFuncASin): (JSC::mathProtoFuncATan): (JSC::mathProtoFuncATan2): (JSC::mathProtoFuncCeil): (JSC::mathProtoFuncCos): (JSC::mathProtoFuncExp): (JSC::mathProtoFuncFloor): (JSC::mathProtoFuncLog): (JSC::mathProtoFuncMax): (JSC::mathProtoFuncMin): (JSC::mathProtoFuncPow): (JSC::mathProtoFuncRound): (JSC::mathProtoFuncSin): (JSC::mathProtoFuncSqrt): (JSC::mathProtoFuncTan):
- runtime/NativeErrorConstructor.cpp: (JSC::NativeErrorConstructor::construct):
- runtime/NumberConstructor.cpp: (JSC::constructWithNumberConstructor): (JSC::callNumberConstructor):
- runtime/NumberPrototype.cpp: (JSC::numberProtoFuncToString): (JSC::numberProtoFuncToFixed): (JSC::numberProtoFuncToExponential): (JSC::numberProtoFuncToPrecision):
- runtime/ObjectConstructor.cpp: (JSC::constructObject):
- runtime/ObjectPrototype.cpp: (JSC::objectProtoFuncHasOwnProperty): (JSC::objectProtoFuncIsPrototypeOf): (JSC::objectProtoFuncDefineGetter): (JSC::objectProtoFuncDefineSetter): (JSC::objectProtoFuncLookupGetter): (JSC::objectProtoFuncLookupSetter): (JSC::objectProtoFuncPropertyIsEnumerable):
- runtime/PropertySlot.h: (JSC::PropertySlot::getValue):
- runtime/RegExpConstructor.cpp: (JSC::constructRegExp):
- runtime/RegExpObject.cpp: (JSC::RegExpObject::match):
- runtime/RegExpPrototype.cpp: (JSC::regExpProtoFuncCompile):
- runtime/StringConstructor.cpp: (JSC::stringFromCharCodeSlowCase): (JSC::stringFromCharCode): (JSC::constructWithStringConstructor): (JSC::callStringConstructor):
- runtime/StringPrototype.cpp: (JSC::stringProtoFuncReplace): (JSC::stringProtoFuncCharAt): (JSC::stringProtoFuncCharCodeAt): (JSC::stringProtoFuncConcat): (JSC::stringProtoFuncIndexOf): (JSC::stringProtoFuncLastIndexOf): (JSC::stringProtoFuncMatch): (JSC::stringProtoFuncSearch): (JSC::stringProtoFuncSlice): (JSC::stringProtoFuncSplit): (JSC::stringProtoFuncSubstr): (JSC::stringProtoFuncSubstring): (JSC::stringProtoFuncLocaleCompare): (JSC::stringProtoFuncFontcolor): (JSC::stringProtoFuncFontsize): (JSC::stringProtoFuncAnchor): (JSC::stringProtoFuncLink):
WebCore:
2009-04-28 Geoffrey Garen <ggaren@apple.com>
Rubber stamped by Beth Dakin.
Removed scaffolding supporting dynamically converting between 32bit and
64bit value representations.
- bindings/js/JSAudioConstructor.cpp: (WebCore::constructAudio):
- bindings/js/JSCanvasRenderingContext2DCustom.cpp: (WebCore::JSCanvasRenderingContext2D::setFillColor): (WebCore::JSCanvasRenderingContext2D::setStrokeColor): (WebCore::JSCanvasRenderingContext2D::strokeRect): (WebCore::JSCanvasRenderingContext2D::drawImage): (WebCore::JSCanvasRenderingContext2D::drawImageFromRect): (WebCore::JSCanvasRenderingContext2D::setShadow): (WebCore::JSCanvasRenderingContext2D::createPattern): (WebCore::JSCanvasRenderingContext2D::putImageData): (WebCore::JSCanvasRenderingContext2D::fillText): (WebCore::JSCanvasRenderingContext2D::strokeText):
- bindings/js/JSClipboardCustom.cpp: (WebCore::JSClipboard::clearData): (WebCore::JSClipboard::getData): (WebCore::JSClipboard::setData): (WebCore::JSClipboard::setDragImage):
- bindings/js/JSDOMApplicationCacheCustom.cpp: (WebCore::JSDOMApplicationCache::hasItem): (WebCore::JSDOMApplicationCache::add): (WebCore::JSDOMApplicationCache::remove): (WebCore::JSDOMApplicationCache::addEventListener): (WebCore::JSDOMApplicationCache::removeEventListener):
- bindings/js/JSDOMStringListCustom.cpp: (WebCore::JSDOMStringList::item):
- bindings/js/JSDOMWindowCustom.cpp: (WebCore::JSDOMWindow::open): (WebCore::JSDOMWindow::showModalDialog): (WebCore::JSDOMWindow::postMessage): (WebCore::JSDOMWindow::setTimeout): (WebCore::JSDOMWindow::setInterval): (WebCore::JSDOMWindow::atob): (WebCore::JSDOMWindow::btoa): (WebCore::JSDOMWindow::addEventListener): (WebCore::JSDOMWindow::removeEventListener):
- bindings/js/JSDatabaseCustom.cpp: (WebCore::JSDatabase::changeVersion): (WebCore::JSDatabase::transaction):
- bindings/js/JSElementCustom.cpp: (WebCore::JSElement::setAttribute): (WebCore::JSElement::setAttributeNode): (WebCore::JSElement::setAttributeNS): (WebCore::JSElement::setAttributeNodeNS):
- bindings/js/JSGeolocationCustom.cpp: (WebCore::JSGeolocation::getCurrentPosition): (WebCore::JSGeolocation::watchPosition):
- bindings/js/JSHTMLCollectionCustom.cpp: (WebCore::callHTMLCollection): (WebCore::JSHTMLCollection::item): (WebCore::JSHTMLCollection::namedItem):
- bindings/js/JSHTMLDocumentCustom.cpp: (WebCore::documentWrite):
- bindings/js/JSHTMLInputElementCustom.cpp: (WebCore::JSHTMLInputElement::setSelectionRange):
- bindings/js/JSHTMLOptionsCollectionCustom.cpp: (WebCore::JSHTMLOptionsCollection::add):
- bindings/js/JSHTMLSelectElementCustom.cpp: (WebCore::JSHTMLSelectElement::remove):
- bindings/js/JSImageConstructor.cpp: (WebCore::constructImage):
- bindings/js/JSInspectorControllerCustom.cpp: (WebCore::JSInspectorController::highlightDOMNode): (WebCore::JSInspectorController::addResourceSourceToFrame): (WebCore::JSInspectorController::addSourceToFrame): (WebCore::JSInspectorController::getResourceDocumentNode): (WebCore::JSInspectorController::search): (WebCore::JSInspectorController::databaseTableNames): (WebCore::JSInspectorController::setting): (WebCore::JSInspectorController::setSetting): (WebCore::JSInspectorController::wrapCallback):
- bindings/js/JSJavaScriptCallFrameCustom.cpp: (WebCore::JSJavaScriptCallFrame::evaluate):
- bindings/js/JSLocationCustom.cpp: (WebCore::JSLocation::replace): (WebCore::JSLocation::assign):
- bindings/js/JSMessagePortCustom.cpp: (WebCore::JSMessagePort::startConversation): (WebCore::JSMessagePort::addEventListener): (WebCore::JSMessagePort::removeEventListener):
- bindings/js/JSNodeCustom.cpp: (WebCore::JSNode::insertBefore): (WebCore::JSNode::replaceChild): (WebCore::JSNode::removeChild): (WebCore::JSNode::appendChild): (WebCore::JSNode::addEventListener): (WebCore::JSNode::removeEventListener):
- bindings/js/JSNodeFilterCustom.cpp: (WebCore::JSNodeFilter::acceptNode):
- bindings/js/JSNodeListCustom.cpp: (WebCore::callNodeList):
- bindings/js/JSOptionConstructor.cpp: (WebCore::constructHTMLOptionElement):
- bindings/js/JSQuarantinedObjectWrapper.cpp: (WebCore::JSQuarantinedObjectWrapper::construct): (WebCore::JSQuarantinedObjectWrapper::call):
- bindings/js/JSSQLResultSetRowListCustom.cpp: (WebCore::JSSQLResultSetRowList::item):
- bindings/js/JSSQLTransactionCustom.cpp: (WebCore::JSSQLTransaction::executeSql):
- bindings/js/JSSVGElementInstanceCustom.cpp: (WebCore::JSSVGElementInstance::addEventListener): (WebCore::JSSVGElementInstance::removeEventListener):
- bindings/js/JSSVGLengthCustom.cpp: (WebCore::JSSVGLength::convertToSpecifiedUnits):
- bindings/js/JSSVGMatrixCustom.cpp: (WebCore::JSSVGMatrix::rotateFromVector):
- bindings/js/JSSVGPathSegListCustom.cpp: (WebCore::JSSVGPathSegList::initialize): (WebCore::JSSVGPathSegList::getItem): (WebCore::JSSVGPathSegList::insertItemBefore): (WebCore::JSSVGPathSegList::replaceItem): (WebCore::JSSVGPathSegList::removeItem): (WebCore::JSSVGPathSegList::appendItem):
- bindings/js/JSSVGPointListCustom.cpp: (WebCore::JSSVGPointList::initialize): (WebCore::JSSVGPointList::getItem): (WebCore::JSSVGPointList::insertItemBefore): (WebCore::JSSVGPointList::replaceItem): (WebCore::JSSVGPointList::removeItem): (WebCore::JSSVGPointList::appendItem):
- bindings/js/JSSVGTransformListCustom.cpp: (WebCore::JSSVGTransformList::initialize): (WebCore::JSSVGTransformList::getItem): (WebCore::JSSVGTransformList::insertItemBefore): (WebCore::JSSVGTransformList::replaceItem): (WebCore::JSSVGTransformList::removeItem): (WebCore::JSSVGTransformList::appendItem):
- bindings/js/JSWebKitCSSMatrixConstructor.cpp: (WebCore::constructWebKitCSSMatrix):
- bindings/js/JSWebKitPointConstructor.cpp: (WebCore::constructWebKitPoint):
- bindings/js/JSWorkerConstructor.cpp: (WebCore::constructWorker):
- bindings/js/JSWorkerContextCustom.cpp: (WebCore::JSWorkerContext::importScripts): (WebCore::JSWorkerContext::addEventListener): (WebCore::JSWorkerContext::removeEventListener): (WebCore::JSWorkerContext::setTimeout): (WebCore::JSWorkerContext::setInterval):
- bindings/js/JSWorkerCustom.cpp: (WebCore::JSWorker::addEventListener): (WebCore::JSWorker::removeEventListener):
- bindings/js/JSXMLHttpRequestCustom.cpp: (WebCore::JSXMLHttpRequest::open): (WebCore::JSXMLHttpRequest::setRequestHeader): (WebCore::JSXMLHttpRequest::send): (WebCore::JSXMLHttpRequest::getResponseHeader): (WebCore::JSXMLHttpRequest::overrideMimeType): (WebCore::JSXMLHttpRequest::addEventListener): (WebCore::JSXMLHttpRequest::removeEventListener):
- bindings/js/JSXMLHttpRequestUploadCustom.cpp: (WebCore::JSXMLHttpRequestUpload::addEventListener): (WebCore::JSXMLHttpRequestUpload::removeEventListener):
- bindings/js/JSXSLTProcessorCustom.cpp: (WebCore::JSXSLTProcessor::importStylesheet): (WebCore::JSXSLTProcessor::transformToFragment): (WebCore::JSXSLTProcessor::transformToDocument): (WebCore::JSXSLTProcessor::setParameter): (WebCore::JSXSLTProcessor::getParameter): (WebCore::JSXSLTProcessor::removeParameter):
- bindings/js/ScheduledAction.cpp: (WebCore::ScheduledAction::create): (WebCore::ScheduledAction::ScheduledAction):
- bindings/js/ScheduledAction.h:
- bindings/js/ScriptCallFrame.cpp: (WebCore::ScriptCallFrame::ScriptCallFrame):
- bindings/js/ScriptCallFrame.h:
- bindings/js/ScriptCallStack.cpp: (WebCore::ScriptCallStack::ScriptCallStack): (WebCore::ScriptCallStack::initialize):
- bridge/c/c_instance.cpp: (JSC::Bindings::CInstance::invokeMethod): (JSC::Bindings::CInstance::invokeDefaultMethod): (JSC::Bindings::CInstance::invokeConstruct):
- bridge/jni/jni_instance.cpp: (JavaInstance::invokeMethod):
- bridge/objc/objc_instance.mm: (ObjcInstance::invokeMethod): (ObjcInstance::invokeDefaultMethod):
WebKit/mac:
2009-04-28 Geoffrey Garen <ggaren@apple.com>
Rubber stamped by Beth Dakin.
Removed scaffolding supporting dynamically converting between 32bit and
64bit value representations.
- Plugins/Hosted/NetscapePluginInstanceProxy.mm: (WebKit::NetscapePluginInstanceProxy::marshalValues):
- 10:56 PM Changeset in webkit [42988] by
-
- 2 edits in trunk/JavaScriptCore
A little more hardening for UString
Reviewed by Maciej Stachowiak.
Revised fix for <rdar://problem/5861045> in r42644.
- runtime/UString.cpp: (JSC::newCapacityWithOverflowCheck): Added. (JSC::concatenate): Used newCapacityWithOverflowCheck(). (JSC::UString::append): Ditto.
- 10:52 PM Changeset in webkit [42987] by
-
- 9 edits in trunk
2009-04-28 David Carson <dacarson@apple.com>
Reviewed by David Hyatt.
Restore alignment to device pixel boundaries.
https://bugs.webkit.org/show_bug.cgi?id=25458
Adjust the adjusted destination rect to be device pixel aligned.
- platform/graphics/cg/ImageCG.cpp: (WebCore::BitmapImage::draw):
2009-04-28 David Carson <dacarson@apple.com>
Reviewed by David Kilzer.
Restore alignment to device pixel boundaries.
https://bugs.webkit.org/show_bug.cgi?id=25458
Updated test results with progressions.
- platform/mac/svg/W3C-SVG-1.1/render-groups-03-t-expected.checksum:
- platform/mac/svg/W3C-SVG-1.1/render-groups-03-t-expected.png: Yin-yang image shifted slightly to pixel boundaries.
- platform/mac/svg/custom/focus-ring-expected.checksum:
- platform/mac/svg/custom/focus-ring-expected.png: Focus rings drawn around rotated "focus text" and checkered images shifted slightly to pixel boundaries.
- platform/mac/svg/custom/image-small-width-height-expected.checksum:
- platform/mac/svg/custom/image-small-width-height-expected.png: Checkered images shifted slightly to pixel boundaries.
- 10:49 PM Changeset in webkit [42986] by
-
- 1 edit10 adds in trunk/LayoutTests
Added missing pixel test results.
- platform/mac/fast/css-generated-content/beforeAfter-interdocument-expected.checksum: Added.
- platform/mac/fast/css-generated-content/beforeAfter-interdocument-expected.png: Added.
- platform/mac/fast/table/cell-coalescing-expected.checksum: Added.
- platform/mac/fast/table/cell-coalescing-expected.png: Added.
- platform/mac/webarchive/adopt-attribute-styled-body-webarchive-expected.checksum: Added.
- platform/mac/webarchive/adopt-attribute-styled-body-webarchive-expected.png: Added.
- platform/mac/webarchive/adopt-attribute-styled-node-webarchive-expected.checksum: Added.
- platform/mac/webarchive/adopt-attribute-styled-node-webarchive-expected.png: Added.
- platform/mac/webarchive/adopt-inline-styled-node-webarchive-expected.checksum: Added.
- platform/mac/webarchive/adopt-inline-styled-node-webarchive-expected.png: Added.
- 10:39 PM Changeset in webkit [42985] by
-
- 5 edits in trunk/WebCore
2009-04-28 Sam Weinig <sam@webkit.org>
Reviewed by Anders Carlsson.
Move unimplemented captureEvents and releaseEvents from JSDOMWindow
to DOMWindow.
- bindings/js/JSDOMWindowCustom.cpp:
- page/DOMWindow.cpp: (WebCore::DOMWindow::captureEvents): (WebCore::DOMWindow::releaseEvents):
- page/DOMWindow.h:
- page/DOMWindow.idl:
- 10:30 PM Changeset in webkit [42984] by
-
- 2 edits in trunk
Correcting ChangeLogs - Sam talked to me about the patch, but it was Darin who reviewed it!
- 10:25 PM Changeset in webkit [42983] by
-
- 9 edits3 adds in trunk
Reviewed by Sam Weinig.
https://bugs.webkit.org/show_bug.cgi?id=25420
<rdar://problem/6829570> REGRESSION: XMLHttpRequest allows loading from another origin
Test: http/tests/xmlhttprequest/detaching-frame-2.html
This was caused by faulty DOMWindow::document(), which could return a new document from
the window's frame after navigation.
- bindings/js/JSDOMWindowCustom.h: (WebCore::JSDOMWindowBase::allowsAccessFromPrivate): Removed an obsolete check that allowed access when document was null. Contrary to what a comment said, that can happen for a window that is no longer in frame, not to one whose document is not constructed yet.
- bindings/js/JSXMLHttpRequestConstructor.cpp: (WebCore::constructXMLHttpRequest): Bail out if context was not found. This currently happens due to a shortcoming in DOMWindow::document() - when it is fixed, the XMLHttpRequest object in included regression test will be constructed successfully, but won't be sent, because its context will be frameless.
- page/DOMWindow.cpp: (WebCore::DOMWindow::document): Check that the window in frame hasn't been replaced yet. Added FIXME comments about how this may be better fixed in the future.
- bindings/js/JSAudioConstructor.cpp: (WebCore::JSAudioConstructor::document): (WebCore::constructAudio):
- bindings/js/JSImageConstructor.cpp: (WebCore::JSImageConstructor::document): (WebCore::constructImage):
- bindings/js/JSMessageChannelConstructor.cpp: (WebCore::JSMessageChannelConstructor::construct):
- bindings/js/JSOptionConstructor.cpp: (WebCore::JSOptionConstructor::document): (WebCore::constructHTMLOptionElement): Make matching changes to other constructors that hold a reference to global object.
- 9:54 PM Changeset in webkit [42982] by
-
- 2 edits in trunk/JavaScriptCore
Bring back r42969, this time with correct codegen
Reviewed by Gavin Barraclough.
Add logic to the codegen for right shift to avoid jumping to a helper function
when shifting a small floating point value.
- 9:22 PM Changeset in webkit [42981] by
-
- 1 copy in releases/WebKitGTK/webkit-1.1.6
Tagging 1.1.6.
- 9:02 PM Changeset in webkit [42980] by
-
- 6 edits in trunk
wxMSW build fix. Switch JSCore build back to static.
- 8:03 PM Changeset in webkit [42979] by
-
- 2 edits in trunk/WebKitTools
2009-04-28 Pierre d'Herbemont <pdherbemont@apple.com>
Reviewed by David Kilzer.
Make sure "--pixel --add-platform-exceptions" produces platform
specific pixel test results.
- Scripts/run-webkit-tests: Support "--pixel --add-platform-exceptions"
- 6:24 PM Changeset in webkit [42978] by
-
- 2 edits in trunk/JavaScriptCore
Roll out r42969, due to hangs in build bot.
- 6:00 PM Changeset in webkit [42977] by
-
- 1 edit5 adds in trunk/LayoutTests
Reviewed by Simon Fraser.
Add a couple table hit tests
https://bugs.webkit.org/show_bug.cgi?id=21892
- svg/hittest/svg-inside-display-table-expected.txt: Added.
- svg/hittest/svg-inside-display-table.xhtml: Added.
- svg/hittest/svg-inside-table-expected.txt: Added.
- svg/hittest/svg-inside-table.xhtml: Added.
- 5:38 PM Changeset in webkit [42976] by
-
- 3 edits in trunk/JavaScriptCore
Improve performance of string indexing
Reviewed by Geoff Garen
Add a cti_get_by_val_string function to specialise indexing into a string object.
This gives us a slight performance win on a number of string tests.
- 5:29 PM Changeset in webkit [42975] by
-
- 3 edits in trunk
2009-04-28 Pierre d'Herbemont <pdherbemont@apple.com>
Reviewed by Simon Fraser.
<rdar://problem/6834830>
Make sure we cover the two possible values reported by event.total that are playback engine
specific.
- media/progress-event-total-expected.txt: Match the new test.
- media/progress-event-total.html: Test the two values.
- 5:17 PM Changeset in webkit [42974] by
-
- 7 edits in trunk/WebCore
Rename -[DOMRange lineBoxRects] to -[DOMRange textRects] and change how it
collects the individual rects, making sure to only include RenderText.
<rdar://problem/6810061>
Reviewed by Sam Weinig.
- bindings/objc/DOM.mm: (-[DOMNode textRects]): Added. Make a Range and call textRects. (-[DOMNode lineBoxRects]): Call textRects method. (-[DOMRange textRects]): Call Range::textRects. (-[DOMRange lineBoxRects]): Call textRects method.
- bindings/objc/DOMPrivate.h: Add the new methods and a comment about lineBoxRects being deprecated.
- dom/Range.cpp: (WebCore::Range::boundingBox): Call textRects (renamed from addLineBoxRects). (WebCore::Range::textRects): Renamed from addLineBoxRects. Iterate over the nodes instead of the RenderObjects to correctly account for offsets. Also only call absoluteRectsForRange on RenderText.
- dom/Range.h: Renamed addLineBoxRects to textRects.
- page/Frame.cpp: (WebCore::Frame::selectionTextRects): Call textRects (renamed from addLineBoxRects).
- rendering/RenderObject.cpp: (WebCore::RenderObject::absoluteRectsForRange): Remove if conditions that made this function very specific for the lineBoxRects API. These functions are still used by the InspectorController, and this change improves what the Inspector shows. (WebCore::RenderObject::absoluteQuadsForRange): Ditto.
- 5:11 PM Changeset in webkit [42973] by
-
- 26 edits in trunk/WebCore
Remove the topLevel boolean argument from absolute{Rects,Quads}.
This argument was default to true and no one ever passed false.
Reviewed by Sam Weinig.
- rendering/RenderBlock.cpp: (WebCore::RenderBlock::absoluteRects): (WebCore::RenderBlock::absoluteQuads):
- rendering/RenderBlock.h:
- rendering/RenderBox.cpp: (WebCore::RenderBox::absoluteRects): (WebCore::RenderBox::absoluteQuads):
- rendering/RenderBox.h:
- rendering/RenderInline.cpp: (WebCore::RenderInline::absoluteRects): (WebCore::RenderInline::absoluteQuads):
- rendering/RenderInline.h:
- rendering/RenderObject.h: (WebCore::RenderObject::absoluteRects): (WebCore::RenderObject::absoluteQuads):
- rendering/RenderSVGHiddenContainer.cpp: (WebCore::RenderSVGHiddenContainer::absoluteRects): (WebCore::RenderSVGHiddenContainer::absoluteQuads):
- rendering/RenderSVGHiddenContainer.h:
- rendering/RenderSVGImage.cpp: (WebCore::RenderSVGImage::absoluteRects): (WebCore::RenderSVGImage::absoluteQuads):
- rendering/RenderSVGImage.h:
- rendering/RenderSVGInlineText.cpp: (WebCore::RenderSVGInlineText::absoluteRects): (WebCore::RenderSVGInlineText::absoluteQuads):
- rendering/RenderSVGInlineText.h:
- rendering/RenderSVGModelObject.cpp: (WebCore::RenderSVGModelObject::absoluteRects): (WebCore::RenderSVGModelObject::absoluteQuads):
- rendering/RenderSVGModelObject.h:
- rendering/RenderSVGTSpan.cpp: (WebCore::RenderSVGTSpan::absoluteRects): (WebCore::RenderSVGTSpan::absoluteQuads):
- rendering/RenderSVGTSpan.h:
- rendering/RenderSVGText.cpp: (WebCore::RenderSVGText::absoluteRects): (WebCore::RenderSVGText::absoluteQuads):
- rendering/RenderSVGText.h:
- rendering/RenderSVGTextPath.cpp: (WebCore::RenderSVGTextPath::absoluteQuads):
- rendering/RenderSVGTextPath.h:
- rendering/RenderText.cpp: (WebCore::RenderText::absoluteRects):
- rendering/RenderText.h:
- rendering/RenderView.cpp: (WebCore::RenderView::absoluteRects): (WebCore::RenderView::absoluteQuads):
- rendering/RenderView.h:
- 4:50 PM Changeset in webkit [42972] by
-
- 5 edits2 adds in trunk/WebCore
2009-04-28 Eric Carlson <eric.carlson@apple.com>
Reviewed by Simon Fraser.
<rdar://problem/6794691> Media documents and <video controls> never show controls on Windows
RenderThemeWin doesn't implement the media element controller rendering methods, so media
controls stopped rendering when we switched from RenderThemeSafari. Rather than having copies
of the code in both places, the logic is in a new class that is called from both.
- WebCore.vcproj/WebCore.vcproj: Add RenderMediaControls.cpp.
- rendering/RenderMediaControls.cpp: Added. (WebCore::determineState): Translate renderer state to ThemeControlState. (WebCore::RenderMediaControls::adjustMediaSliderThumbSize): Adjust slider thumb. (WebCore::parentMediaElement): Return the HTMLMediaElement parent of a controller element. (WebCore::RenderMediaControls::paintMediaControlsPart): Paint a media controller part.
- rendering/RenderMediaControls.h: Added.
- rendering/RenderThemeSafari.cpp: (WebCore::RenderThemeSafari::paintSliderTrack): Remove the MediaSliderPart case, it is never called for the media slider. (WebCore::RenderThemeSafari::adjustSliderThumbSize): Call RenderMediaControls function. (WebCore::RenderThemeSafari::paintMediaFullscreenButton): Ditto. (WebCore::RenderThemeSafari::paintMediaMuteButton): Ditto. (WebCore::RenderThemeSafari::paintMediaPlayButton): Ditto. (WebCore::RenderThemeSafari::paintMediaSeekBackButton): Ditto. (WebCore::RenderThemeSafari::paintMediaSeekForwardButton): Ditto. (WebCore::RenderThemeSafari::paintMediaSliderTrack): Ditto. (WebCore::RenderThemeSafari::paintMediaSliderThumb): Ditto.
- rendering/RenderThemeWin.cpp: (WebCore::RenderThemeWin::adjustSliderThumbSize): Ditto. (WebCore::RenderThemeWin::paintMediaFullscreenButton): Ditto. (WebCore::RenderThemeWin::paintMediaMuteButton): Ditto. (WebCore::RenderThemeWin::paintMediaPlayButton): Ditto. (WebCore::RenderThemeWin::paintMediaSeekBackButton): Ditto. (WebCore::RenderThemeWin::paintMediaSeekForwardButton): Ditto. (WebCore::RenderThemeWin::paintMediaSliderTrack): Ditto. (WebCore::RenderThemeWin::paintMediaSliderThumb): Ditto.
- rendering/RenderThemeWin.h:
- 4:12 PM Changeset in webkit [42971] by
-
- 2 edits in trunk/WebCore
2009-04-28 Beth Dakin <Beth Dakin>
Reviewed by Sam Weinig.
Fix for <rdar://problem/6419515> REGRESSION (r31037): Positioned
images with % height are collapsed when printing
- rendering/RenderBox.cpp: (WebCore::RenderBox::calcHeight): Make sure we don't ignore printing here!
- 3:36 PM Changeset in webkit [42970] by
-
- 2 edits in trunk/JavaScriptCore
2009-04-28 Xan Lopez <xlopez@igalia.com>
Unreviewed: fix distcheck build, add (even more) missing files to list.
- GNUmakefile.am:
- 3:22 PM Changeset in webkit [42969] by
-
- 2 edits in trunk/JavaScriptCore
Improve performance of right shifts of large or otherwise floating point values.
Reviewed by Geoff Garen.
Add logic to the codegen for right shift to avoid jumping to a helper function
when shifting a small floating point value.
- 3:17 PM Changeset in webkit [42968] by
-
- 4 edits4 adds in trunk
WebCore:
2009-04-28 Adele Peterson <adele@apple.com>
Reviewed by Darin Adler.
Fix for <rdar://problem/6617298> Typing delete on an unquoted blank line unquotes the preceding, quoted blank line
Test: editing/deleting/type-delete-after-quote.html
When a selection is deleted that contains a whole number paragraphs plus a line break, we refrain from merging paragraphs after the delete,
since it is unclear to most users that such a selection actually ends at the start of the next paragraph. However, when a user hits delete
with a caret selection, they actually do expect the start of that paragraph to be merged into the paragraph before it. We can tell that
we're in this state because the TypingCommand creates the selection to delete but it doesn't change the endingSelection. So we can tell
that if we started with a caret selection, then we're not in this special case where we have to protect the user from unexpected behavior
from deleting a range they selected.
- editing/DeleteSelectionCommand.cpp: (WebCore::DeleteSelectionCommand::initializePositionData):
LayoutTests:
2009-04-28 Adele Peterson <adele@apple.com>
Reviewed by Darin Adler.
Test for <rdar://problem/6617298> Typing delete on an unquoted blank line unquotes the preceding, quoted blank line
- editing/deleting/type-delete-after-quote.html: Added.
- platform/mac/editing/deleting/delete-4038408-fix-expected.txt: This expected result change reflects a change in how the editing is done, but the document structure remains the same, and there are no visible changes to the result.
- platform/mac/editing/deleting/type-delete-after-quote-expected.checksum: Added.
- platform/mac/editing/deleting/type-delete-after-quote-expected.png: Added.
- platform/mac/editing/deleting/type-delete-after-quote-expected.txt: Added.
- 3:15 PM Changeset in webkit [42967] by
-
- 2 edits in trunk/JavaScriptCore
2009-04-28 Xan Lopez <xlopez@igalia.com>
Unreviewed: fix distcheck build, add (more) missing files to list.
- GNUmakefile.am:
- 3:12 PM Changeset in webkit [42966] by
-
- 1 edit4 adds in trunk/LayoutTests
Reviewed by Simon Fraser.
Add text gradient test to cover
https://bugs.webkit.org/show_bug.cgi?id=25403
- platform/mac/svg/text/text-gradient-positioning-expected.checksum: Added.
- platform/mac/svg/text/text-gradient-positioning-expected.png: Added.
- platform/mac/svg/text/text-gradient-positioning-expected.txt: Added.
- svg/text/text-gradient-positioning.svg: Added.
- 3:09 PM Changeset in webkit [42965] by
-
- 8 edits in trunk/WebKit/mac
2009-04-28 Anders Carlsson <andersca@apple.com>
Reviewed by Kevin Decker and Darin Adler.
Fix <rdar://problem/6836132>.
- Plugins/Hosted/NetscapePluginHostProxy.mm: (WKPCCheckIfAllowedToLoadURL): Call the instance proxy.
(WKPCCancelCheckIfAllowedToLoadURL):
Ditto.
- Plugins/Hosted/NetscapePluginInstanceProxy.h:
- Plugins/Hosted/NetscapePluginInstanceProxy.mm: (WebKit::NetscapePluginInstanceProxy::NetscapePluginInstanceProxy): Initialize the check ID counter.
(WebKit::NetscapePluginInstanceProxy::checkIfAllowedToLoadURL):
Create a WebPluginContainerCheck, add it to the map, and start it.
(WebKit::NetscapePluginInstanceProxy::cancelCheckIfAllowedToLoadURL):
Remove the check from the map.
(WebKit::NetscapePluginInstanceProxy::checkIfAllowedToLoadURLResult):
Call the WKPH MIG callback.
- Plugins/Hosted/WebHostedNetscapePluginView.h:
- Plugins/Hosted/WebHostedNetscapePluginView.mm: (-[WebHostedNetscapePluginView _webPluginContainerCancelCheckIfAllowedToLoadRequest:]): Call the instance proxy.
(-[WebHostedNetscapePluginView _containerCheckResult:contextInfo:]):
Ditto.
- Plugins/Hosted/WebKitPluginClient.defs:
- Plugins/Hosted/WebKitPluginHost.defs: Add MIG declarations.
- 2:59 PM Changeset in webkit [42964] by
-
- 1 edit4 adds in trunk/LayoutTests
Reviewed by David Hyatt.
Add text repaint test to cover
https://bugs.webkit.org/show_bug.cgi?id=16188
- platform/mac/svg/text/text-repaint-rects-expected.checksum: Added.
- platform/mac/svg/text/text-repaint-rects-expected.png: Added.
- platform/mac/svg/text/text-repaint-rects-expected.txt: Added.
- svg/text/text-repaint-rects.xhtml: Added.
- 2:38 PM Changeset in webkit [42963] by
-
- 4 edits in trunk
WebCore:
2009-04-28 Xan Lopez <xlopez@igalia.com>
Unreviewed: fix distcheck build, add missing header to file list.
- GNUmakefile.am:
2009-04-28 Xan Lopez <xlopez@igalia.com>
Unreviewed: fix distcheck build, add missing header to file list.
- GNUmakefile.am:
- 2:27 PM Changeset in webkit [42962] by
-
- 3 edits in trunk/WebKit/gtk
2009-04-28 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
Unreviewed. Update gtk-doc control and base sgml files for 1.1.6.
- docs/webkitgtk-docs.sgml:
- docs/webkitgtk-sections.txt:
- 1:59 PM Changeset in webkit [42961] by
-
- 19 edits in trunk
Reviewed by Sam Weinig.
Fix foreignObject transform order
https://bugs.webkit.org/show_bug.cgi?id=25433
Transforms were being applied in the wrong order.
When mapping from local to parent, first apply the viewport transform
then map from the viewport box to the parent box.
- rendering/RenderForeignObject.cpp: (WebCore::RenderForeignObject::localToParentTransform):
- 1:56 PM Changeset in webkit [42960] by
-
- 20 edits in trunk/WebCore
Reviewed by Simon Fraser.
Simplify nodeAtPoint for SVG
https://bugs.webkit.org/show_bug.cgi?id=25432
Added a new nodeAtFloatPoint method which takes a FloatPoint
instead of the *super confusing* x/y tx/ty pairs that HTML uses.
Mostly this is just lots of minus-lines as the new code is *much* simpler.
I made all the SVG renderers use the new nodeAtFloatPoint and ASSERT_NOT_REACHED
for the nodeAtPoint HTML/CSS int x/y version.
Eventually the rest of CSS/HTML render objects will follow suit
and move to nodeAtFloatPoint (possibly renamed back to nodeAtPoint), but changing them
over was well outside the scope of this change.
SVG hit testing is not actually floating point precise yet, since its still
passed in an integer x/y. Certain transform hit-test edge cases are likely fixed
by moving to FloatPoint here, but I didn't try to find one.
This should not cause functional changes for common-case hit testing, thus
no tests changed, nor should new tests be needed.
- rendering/RenderForeignObject.cpp: (WebCore::RenderForeignObject::translationForAttributes): (WebCore::RenderForeignObject::paint): (WebCore::RenderForeignObject::computeRectForRepaint): (WebCore::RenderForeignObject::localToParentTransform): (WebCore::RenderForeignObject::layout): (WebCore::RenderForeignObject::nodeAtFloatPoint):
- rendering/RenderForeignObject.h:
- rendering/RenderObject.cpp: (WebCore::RenderObject::nodeAtFloatPoint):
- rendering/RenderObject.h:
- rendering/RenderPath.cpp: (WebCore::RenderPath::nodeAtFloatPoint):
- rendering/RenderPath.h:
- rendering/RenderSVGContainer.cpp: (WebCore::RenderSVGContainer::nodeAtFloatPoint):
- rendering/RenderSVGContainer.h: (WebCore::RenderSVGContainer::pointIsInsideViewportClip):
- rendering/RenderSVGHiddenContainer.cpp: (WebCore::RenderSVGHiddenContainer::nodeAtFloatPoint):
- rendering/RenderSVGHiddenContainer.h:
- rendering/RenderSVGImage.cpp: (WebCore::RenderSVGImage::paint): (WebCore::RenderSVGImage::nodeAtFloatPoint):
- rendering/RenderSVGImage.h: (WebCore::RenderSVGImage::localToParentTransform): (WebCore::RenderSVGImage::localTransform):
- rendering/RenderSVGModelObject.cpp: (WebCore::RenderSVGModelObject::nodeAtFloatPoint):
- rendering/RenderSVGModelObject.h:
- rendering/RenderSVGRoot.cpp: (WebCore::RenderSVGRoot::nodeAtFloatPoint):
- rendering/RenderSVGText.cpp: (WebCore::RenderSVGText::nodeAtFloatPoint):
- rendering/RenderSVGText.h:
- rendering/RenderSVGViewportContainer.cpp: (WebCore::RenderSVGViewportContainer::pointIsInsideViewportClip):
- rendering/RenderSVGViewportContainer.h:
- 1:42 PM Changeset in webkit [42959] by
-
- 2 edits in trunk/WebCore
2009-04-28 Eric Carlson <eric.carlson@apple.com>
- fix the Tiger build
- platform/graphics/mac/MediaPlayerPrivateQTKit.mm: (WebCore::MediaPlayerPrivate::cacheMovieScale):
- 1:30 PM Changeset in webkit [42958] by
-
- 8 edits in trunk/WebCore
2009-04-28 Sam Weinig <sam@webkit.org>
Reviewed by Beth Dakin.
Consolidate ScheduleAction creation into ScheduledAction::create.
Autogenerate JSWorkerContext.clearTimeout and clearInterval.
- bindings/js/JSDOMWindowCustom.cpp: (WebCore::JSDOMWindow::setTimeout): (WebCore::JSDOMWindow::setInterval):
- bindings/js/JSWorkerContextCustom.cpp: (WebCore::JSWorkerContext::setTimeout): (WebCore::JSWorkerContext::setInterval):
- bindings/js/ScheduledAction.cpp: (WebCore::ScheduledAction::create): (WebCore::ScheduledAction::ScheduledAction): (WebCore::ScheduledAction::execute):
- bindings/js/ScheduledAction.h:
- workers/WorkerContext.cpp: (WebCore::DOMWindow::setTimeout): (WebCore::DOMWindow::clearTimeout): (WebCore::DOMWindow::setInterval): (WebCore::DOMWindow::clearInterval):
- workers/WorkerContext.h:
- workers/WorkerContext.idl:
- 1:22 PM Changeset in webkit [42957] by
-
- 3 edits1 add in trunk/WebKitTools
Fix link warnings building TestNetscapePlugin on Windows due to mismatched
DLL name vs. LIBRARY directive name.
Reviewed by Jon Honeycutt.
- DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.def:
- DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.vcproj:
- DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin_debug.def: Added.
- 1:21 PM Changeset in webkit [42956] by
-
- 2 edits in trunk/WebKit/gtk
2009-04-28 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
Reviewed by Xan Lopez.
Updated with news for the 1.1.6 release.
- NEWS:
- 1:14 PM Changeset in webkit [42955] by
-
- 7 edits10 adds in trunk
WebCore:
2009-04-28 Brady Eidson <beidson@apple.com>
Reviewed by Darin Adler
<rdar://problem/6643219> Crashes after moving nodes between documents with Safari 4 Beta installed
When moving Nodes between documents we weren't properly updating style declarations. Certain operations, such
as creating webarchives, would tickle this bug.
Tests: webarchive/adopt-attribute-styled-body-webarchive.html
webarchive/adopt-attribute-styled-node-webarchive.html
webarchive/adopt-inline-styled-node-webarchive.html
- dom/Node.cpp: Add a debug-only mechanism to insure that anyone who overrides (did/will)MoveToNewOwnerDocument calls their parent-class implementation after they've done their own work. (WebCore::setWillMoveToNewOwnerDocumentWasCalled): (WebCore::setDidMoveToNewOwnerDocumentWasCalled): (WebCore::Node::setDocument): (WebCore::Node::willMoveToNewOwnerDocument): (WebCore::Node::didMoveToNewOwnerDocument):
- dom/StyledElement.cpp: (WebCore::StyledElement::attributeChanged): Add a comment explaining why we don't need to walk the nameAttrMap to update style declarations. (WebCore::StyledElement::didMoveToNewOwnerDocument): Update the parent pointer for the inline style declaration.
- dom/StyledElement.h:
- html/HTMLBodyElement.cpp: (WebCore::HTMLBodyElement::didMoveToNewOwnerDocument): Update the parent pointer for the link declaration.
- html/HTMLBodyElement.h:
LayoutTests:
2009-04-28 Brady Eidson <beidson@apple.com>
Reviewed by Darin Adler
<rdar://problem/6643219> Crashes after moving nodes between documents with Safari 4 Beta installed
- webarchive/adopt-attribute-styled-body-webarchive-expected.webarchive: Added.
- webarchive/adopt-attribute-styled-body-webarchive.html: Added.
- webarchive/resources/adopt-attribute-styled-body-iframe.html: Added.
- webarchive/resources/adopt-attribute-styled-body-second-window.html: Added.
- webarchive/adopt-attribute-styled-node-webarchive-expected.webarchive: Added.
- webarchive/adopt-attribute-styled-node-webarchive.html: Added.
- webarchive/resources/adopt-attribute-styled-node-second-window.html: Added.
- webarchive/adopt-inline-styled-node-webarchive-expected.webarchive: Added.
- webarchive/adopt-inline-styled-node-webarchive.html: Added.
- webarchive/resources/adopt-inline-styled-node-second-window.html: Added.
- 1:12 PM Changeset in webkit [42954] by
-
- 2 edits in tags/Safari-6530.7.1/WebCore
Merge r42945.
- 12:48 PM Changeset in webkit [42953] by
-
- 3 edits in trunk/WebKitTools
Fix warnings about PRODUCTION and ARCHIVE_BUILD on Windows builds
of ImageDiff and DumpRenderTree.
Rubber stamped by Adam Roben.
- DumpRenderTree/win/DumpRenderTree.vcproj:
- DumpRenderTree/win/ImageDiff.vcproj:
- 12:46 PM Changeset in webkit [42952] by
-
- 2 edits in trunk/WebCore
2009-04-28 Eric Carlson <eric.carlson@apple.com>
Reviewed by Darin Adler.
<rdar://problem/6834876> Don't use BlockExceptions macros until QTKit supports
QTMoviePreferredTransformAttribute
- platform/graphics/mac/MediaPlayerPrivateQTKit.mm: (WebCore::MediaPlayerPrivate::cacheMovieScale): use @try and @catch instead of BEGIN_BLOCK_OBJC_EXCEPTIONS and END_BLOCK_OBJC_EXCEPTIONS for builds of QTKit that throw an exception on QTMovieCurrentSizeAttribute but don't support QTMoviePreferredTransformAttribute
- 12:43 PM Changeset in webkit [42951] by
-
- 2 edits in trunk/WebCore
2009-04-28 Darin Adler <Darin Adler>
Reviewed by Sam Weinig.
- rendering/RenderText.cpp: (WebCore::RenderText::RenderText): Streamline code path to avoid a bit of reference count churn and remove a strange unneeeded PassRefPtr typecast. Also added a comment. (WebCore::RenderText::setTextInternal): Ditto.
- 12:37 PM Changeset in webkit [42950] by
-
- 21 edits in trunk
Reviewed by Simon Fraser.
Simplify how SVG containers paint
https://bugs.webkit.org/show_bug.cgi?id=25431
Moved filterBoundingBox() from RenderSVGModelObject to SVGRenderSupport to share with other classes.
Gave RenderSVGText a modern clippedOverflowRectForRepaint and computeRectForRepaint.
RenderSVGText now applies transforms at paint() time instead of during chunk draw time
this should be much more efficient.
Fixed the order in which RenderSVGViewportContainer applied
transforms and clips. We now clip to the viewport first and apply
all transforms at once. Also since the viewport logic is now only
inside RenderSVGViewportContainer (instead of inside RenderSVGContainer)
we always know we have a viewport. We now use only viewportSize instead of
viewport() since RenderSVGViewportContainers can't have x/y offsets.
We now correctly transform the PaintInfo::rect (damage rect) when applying transforms.
This allowed us to apply the transform during text paint() instead of at chunk paint
time. Previously we had to apply the transform during chunk paint time because
RenderBlock (superclass of RenderSVGBlock) would check intersection with the damageRect
before telling any of the inlines to draw. Now that we adjust the damage rect correctly
we pass the intersection check correctly! (This probably fixed some <text> redraw bugs
but since I still have a bunch of those to fix, I've not tried to write additional tests
to cover these potential fixes yet.)
SVGRootInlineBox no longer needs to deal with transforms at chunk paint time, yay!
- rendering/RenderPath.cpp: (WebCore::RenderPath::repaintRectInLocalCoordinates): (WebCore::RenderPath::paint):
- rendering/RenderSVGContainer.cpp: (WebCore::RenderSVGContainer::paint): (WebCore::RenderSVGContainer::repaintRectInLocalCoordinates):
- rendering/RenderSVGContainer.h: (WebCore::RenderSVGContainer::applyViewportClip):
- rendering/RenderSVGImage.cpp: (WebCore::RenderSVGImage::layout): (WebCore::RenderSVGImage::repaintRectInLocalCoordinates): (WebCore::RenderSVGImage::clippedOverflowRectForRepaint): (WebCore::RenderSVGImage::computeRectForRepaint):
- rendering/RenderSVGImage.h:
- rendering/RenderSVGModelObject.cpp:
- rendering/RenderSVGModelObject.h:
- rendering/RenderSVGRoot.cpp: (WebCore::RenderSVGRoot::layout): (WebCore::RenderSVGRoot::selfWillPaint): (WebCore::RenderSVGRoot::paint): (WebCore::RenderSVGRoot::viewportSize): (WebCore::RenderSVGRoot::calcViewport): (WebCore::RenderSVGRoot::localToBorderBoxTransform): (WebCore::RenderSVGRoot::parentOriginToBorderBox): (WebCore::RenderSVGRoot::borderOriginToContentBox): (WebCore::RenderSVGRoot::localToRepaintContainerTransform): (WebCore::RenderSVGRoot::localToParentTransform): (WebCore::RenderSVGRoot::computeRectForRepaint): (WebCore::RenderSVGRoot::nodeAtPoint):
- rendering/RenderSVGRoot.h:
- rendering/RenderSVGText.cpp: (WebCore::RenderSVGText::clippedOverflowRectForRepaint): (WebCore::RenderSVGText::computeRectForRepaint): (WebCore::RenderSVGText::paint): (WebCore::RenderSVGText::repaintRectInLocalCoordinates):
- rendering/RenderSVGText.h: (WebCore::RenderSVGText::localToParentTransform): (WebCore::RenderSVGText::localTransform):
- rendering/RenderSVGViewportContainer.cpp: (WebCore::RenderSVGViewportContainer::applyViewportClip):
- rendering/RenderSVGViewportContainer.h:
- rendering/SVGRenderSupport.cpp: (WebCore::filterBoundingBoxForRenderer): (WebCore::applyTransformToPaintInfo):
- rendering/SVGRenderSupport.h:
- rendering/SVGRootInlineBox.cpp: (WebCore::SVGRootInlineBoxPaintWalker::chunkStartCallback): (WebCore::SVGRootInlineBox::paint):
- 12:37 PM Changeset in webkit [42949] by
-
- 3 edits2 adds in trunk
Bug 25453: AX: fall back to PLACEHOLDER attr if form element is not labeled
https://bugs.webkit.org/show_bug.cgi?id=25453
- 12:33 PM Changeset in webkit [42948] by
-
- 4 edits in tags/Safari-6530.7.1
Versioning.
- 12:16 PM Changeset in webkit [42947] by
-
- 1 copy in tags/Safari-6530.7.1
New tag.
- 12:14 PM Changeset in webkit [42946] by
-
- 9 edits2 adds in trunk
Bug 25452: AX: Don't create addition space AXStaticText element for every bold or link tag
https://bugs.webkit.org/show_bug.cgi?id=25452
- 11:57 AM Changeset in webkit [42945] by
-
- 2 edits in trunk/WebCore
Work around <rdar://problem/6833240> by relying on static initialization to zero the entire struct.
This removes the need for us to explicitly initialize all of the members, which have a tendency
to change in meaning and number between versions of libxml2.
Reviewed by Sam Weinig.
- dom/XMLTokenizerLibxml2.cpp:
(WebCore::):
(WebCore::sharedXHTMLEntity):
(WebCore::getXHTMLEntity):
- 11:56 AM Changeset in webkit [42944] by
-
- 2 edits in trunk/WebKitLibraries
Fix extraneous warning about AnalyzeWithLargeStack not being defined in Windows builds.
Indirected definition through a UserMacro.
Reviewed by Mark Rowe.
- win/tools/vsprops/common.vsprops:
- 11:52 AM Changeset in webkit [42943] by
-
- 2 edits in trunk/WebCore
Fix linker warning by specifying /NODEFAULTLIB:LIBCMT for QTMovieWin.
Reviewed by Mark Rowe.
- WebCore.vcproj/QTMovieWin.vcproj:
- 11:32 AM Changeset in webkit [42942] by
-
- 3 edits2 adds in trunk
Bug 25449: AX: Respect the alt tag of ARIA button as AXDescription
https://bugs.webkit.org/show_bug.cgi?id=25449
- 11:29 AM Changeset in webkit [42941] by
-
- 2 edits in trunk/WebKitLibraries
Fix extraneous warning about PRODUCTION not being defined in Windows builds.
Indirected definition for PRODUCTION through a UserMacro.
Reviewed by Mark Rowe.
- win/tools/vsprops/common.vsprops:
- 11:16 AM Changeset in webkit [42940] by
-
- 2 edits in trunk/WebCore
Reviewed by John Sullivan.
- formatting cleanup
- rendering/RenderBox.cpp: (WebCore::RenderBox::calcHeight): Corrected indentation and added braces around a multi-line "else" clause.
- 11:05 AM Changeset in webkit [42939] by
-
- 4 edits in trunk
2009-04-28 Eric Carlson <eric.carlson@apple.com>
Reviewed by Adam Roben
<rdar://problem/6769968> media/video-size-intrinsic-scale.html fails on Windows
https://bugs.webkit.org/show_bug.cgi?id=25094
Display movies saved with a non-identity matrix at the correct size.
- platform/graphics/win/QTMovieWin.cpp: (QTMovieWinPrivate::QTMovieWinPrivate): Initialize m_widthScaleFactor and m_heightScaleFactor. (QTMovieWinPrivate::cacheMovieScale): New, calculate difference between initial size and natural size so naturalSize() accounts for non-identity movie matrix. (QTMovieWinPrivate::task):Call cacheMovieScale when load state reaches kMovieLoadStateLoaded for the first time. kMovieLoadState -> QTMovieLoadState. (QTMovieWinPrivate::drawingComplete): kMovieLoadState -> QTMovieLoadState. (QTMovieWinPrivate::createGWorld): Don't bother creating gworld until load state reaches kMovieLoadStateLoaded because we do not try to draw it before that point. (QTMovieWinPrivate::setSize): Do not change movie box before reaching kMovieLoadStateLoaded because we need to get the movie's initial size in cacheMovieScale. (QTMovieWin::getNaturalSize): Multiply width and height by initial scale.
2009-04-28 Eric Carlson <eric.carlson@apple.com>
Reviewed by Adam Roben
<rdar://problem/6769968> media/video-size-intrinsic-scale.html fails on Windows
https://bugs.webkit.org/show_bug.cgi?id=25094
- platform/win/Skipped: Re-enable video-size-intrinsic-scale.html.
- 10:43 AM Changeset in webkit [42938] by
-
- 7 edits in trunk/WebCore
2009-04-28 Sam Weinig <sam@webkit.org>
Reviewed by Dan Bernstein.
Move timer code from JSDOMWindow to DOMWindow. clearTimeout and
clearInterval can now be autogenerated.
- bindings/js/JSDOMWindowBase.cpp:
- bindings/js/JSDOMWindowBase.h:
- bindings/js/JSDOMWindowCustom.cpp: (WebCore::createScheduledAction): (WebCore::JSDOMWindow::setTimeout): (WebCore::JSDOMWindow::setInterval):
- page/DOMWindow.cpp: (WebCore::DOMWindow::setTimeout): (WebCore::DOMWindow::clearTimeout): (WebCore::DOMWindow::setInterval): (WebCore::DOMWindow::clearInterval):
- page/DOMWindow.h:
- page/DOMWindow.idl:
- 10:06 AM Changeset in webkit [42937] by
-
- 2 edits in trunk/WebCore
Reviewed by Kevin Ollivier.
Small optimization, don't get the widget's handle twice in one method.
https://bugs.webkit.org/show_bug.cgi?id=25446
- 9:46 AM Changeset in webkit [42936] by
-
- 3 edits in trunk/WebKit/mac
Reviewed by John Sullivan.
- fix <rdar://problem/6786360> Make PDF an insertable pasteboard type
- WebCoreSupport/WebPasteboardHelper.mm: (WebPasteboardHelper::insertablePasteboardTypes):
- WebView/WebHTMLView.mm: (-[WebHTMLView _documentFragmentFromPasteboard:inContext:allowPlainText:]): (+[WebHTMLView _insertablePasteboardTypes]): (-[WebHTMLView _documentFragmentFromPasteboard:forType:inContext:subresources:]):
- 9:32 AM QtWebKitJournal edited by
- (diff)
- 9:31 AM Changeset in webkit [42935] by
-
- 2 edits in trunk/WebCore
Reviewed by Kevin Ollivier.
ScrollView copy and paste typo fix.
https://bugs.webkit.org/show_bug.cgi?id=25445
- 9:29 AM QtWebKitTodo edited by
- (diff)
- 9:28 AM QtWebKitJournal edited by
- (diff)
- 9:27 AM Changeset in webkit [42934] by
-
- 6 edits in trunk/WebKit/qt
2009-04-28 Simon Hausmann <simon.hausmann@nokia.com>
Reviewed by Tor Arne Vestbø.
QWebElement API changes after another round of API review:
- Fix argument names of findAll/findFirst
- Split up toXml into innerXml and outerXml
- Removed confusing toggleClass overload
- Fixed casing of namespaceUri to follow QXmlStreamReader
- Removed tagName from firstChild/nextSibling/etc.
- Renamed append/prepend/insertAfter/insertBefore to [append|prepend][Inside|Outside]
- Renamed wrapWith() back to wrap()
- Made clone() const
- Renamed remove() to takeFromDocument(), added removeFromDocument()
- Renamed clear() to removeChildren()
- Renamed scriptsFunctions/callScriptFunction to functions()/callFunction()
- Renamed scriptProperty to scriptableProperty
- 9:25 AM QtWebKitTodo edited by
- (diff)
- 9:09 AM Changeset in webkit [42933] by
-
- 2 edits in trunk
2009-04-28 Xan Lopez <xlopez@igalia.com>
Unreviewed: bump versions in preparation for 1.1.6 release.
- configure.ac:
- 9:06 AM Changeset in webkit [42932] by
-
- 2 edits in trunk/WebKit/gtk
2009-04-28 Xan Lopez <xlopez@igalia.com>
Reviewed by Gustavo Noronha.
Leave a bit of space from the previous page when advacing a whole
page. This matches the behavior of our scrollbar scrolling code
and is just nicer in general.
- webkit/webkitwebview.cpp:
- 8:55 AM Changeset in webkit [42931] by
-
- 5 edits in trunk/WebKit/wx
Reviewed by Kevin Ollivier.
Add a function for resetting the zoom factor to 1.0.
https://bugs.webkit.org/show_bug.cgi?id=25447
- 7:01 AM Changeset in webkit [42930] by
-
- 2 edits in trunk/WebCore
2009-04-28 John Sullivan <sullivan@apple.com>
<rdar://problem/6820221> REGRESSION: 2-byte character names of images are displayed as %-encoded ASCII
Reviewed by Adam Roben
- loader/ImageDocument.cpp: (WebCore::ImageTokenizer::finish): decode the filename before processing it as part of the image name that's passed to the client
- 6:51 AM Changeset in webkit [42929] by
-
- 5 edits in trunk/WebKit/qt
2009-04-28 Simon Hausmann <simon.hausmann@nokia.com>
Reviewed by Tor Arne Vestbø.
Fix some qdoc warnings.
- 6:36 AM QtWebKitTodo edited by
- (diff)
- 6:35 AM QtWebKitTodo edited by
- (diff)
- 2:59 AM Changeset in webkit [42928] by
-
- 2 edits in trunk/WebCore
2009-04-28 Maciej Stachowiak <mjs@apple.com>
Not reviewed, build fix.
- fix initialization order to match declaration order to fix release build
- page/Settings.cpp: (WebCore::Settings::Settings):
- 1:55 AM Changeset in webkit [42927] by
-
- 2 edits in trunk/WebKit/gtk
2009-04-28 Xan Lopez <xlopez@igalia.com>
Unreviewed: committed a few bits by mistake, remove them.
- WebCoreSupport/EditorClientGtk.cpp: (WebKit::handleEditingKeyboardEvent):
- 1:45 AM Changeset in webkit [42926] by
-
- 2 edits in trunk/WebKit/gtk
2009-04-28 Xan Lopez <xlopez@igalia.com>
Reviewed by Gustavo Noronha.
https://bugs.webkit.org/show_bug.cgi?id=16135
[GTK] Support caret browsing
Refactor keyboard event handling to work properly under caret
browsing mode. Most of the code comes from the Windows port.
- WebCoreSupport/EditorClientGtk.cpp: (WebKit::): (WebKit::interpretKeyEvent): (WebKit::handleEditingKeyboardEvent): (WebKit::EditorClient::handleKeyboardEvent):
- 1:44 AM Changeset in webkit [42925] by
-
- 3 edits in trunk/WebKit/gtk
2009-04-28 Xan Lopez <xlopez@igalia.com>
Reviewed by Gustavo Noronha.
https://bugs.webkit.org/show_bug.cgi?id=16135
[GTK] Support caret browsing
Based on a patch by Alp Toker.
Add enable-caret-browsing setting to WebKitWebView.
- webkit/webkitwebsettings.cpp: (_WebKitWebSettingsPrivate::): (_WebKitWebSettingsPrivate::webkit_web_settings_class_init): (_WebKitWebSettingsPrivate::webkit_web_settings_set_property): (_WebKitWebSettingsPrivate::webkit_web_settings_get_property): (_WebKitWebSettingsPrivate::webkit_web_settings_copy):
- webkit/webkitwebview.cpp:
- 1:44 AM Changeset in webkit [42924] by
-
- 7 edits in trunk/WebCore
2009-04-28 Xan Lopez <xlopez@igalia.com>
Reviewed by Justin Garcia.
https://bugs.webkit.org/show_bug.cgi?id=16135
[GTK] Support caret browsing
Based on a patch by Alp Toker.
Implement basic support for caret browsing, active only when the
corresponding setting is enabled.
- page/EventHandler.cpp: (WebCore::EventHandler::handleMouseReleaseEvent):
- page/FocusController.cpp: (WebCore::FocusController::advanceFocus): (WebCore::clearSelectionIfNeeded): (WebCore::FocusController::setFocusedNode):
- page/Frame.cpp: (WebCore::Frame::setFocusedNodeIfNeeded): (WebCore::Frame::setSelectionFromNone): (WebCore::Frame::respondToChangedSelection):
- page/Settings.cpp: (WebCore::Settings::Settings):
- page/Settings.h:
- rendering/RenderBlock.cpp: (WebCore::RenderBlock::paintCaret):
- 1:08 AM Changeset in webkit [42923] by
-
- 2 edits in trunk/JavaScriptCore
2009-04-28 Gavin Barraclough <barraclough@apple.com>
Rubber stamped by Maciej "Henry Morgan" Stachowiak.
Enable YARR.
(Again.)
- wtf/Platform.h:
- 12:10 AM Changeset in webkit [42922] by
-
- 2 edits in trunk/JavaScriptCore
2009-04-27 Gavin Barraclough <barraclough@apple.com>
Reviewed by Maciej Stachowiak.
Tweak a loop condition to keep GCC happy,
some GCCs seem to be having issues with this. :-/
- bytecompiler/BytecodeGenerator.cpp: (JSC::BytecodeGenerator::breakTarget):
- wtf/Platform.h:
Apr 27, 2009:
- 11:05 PM Changeset in webkit [42921] by
-
- 1 edit1 move in trunk/LayoutTests
2009-04-27 Sam Weinig <sam@webkit.org>
Reviewed by Mark Rowe.
Disable test intermittent failing test.
- svg/custom/filter-source-alpha.svg: Removed.
- svg/custom/filter-source-alpha.svg-disabled: Copied from svg/custom/filter-source-alpha.svg.
- 10:14 PM Changeset in webkit [42920] by
-
- 3 edits5 adds in trunk/LayoutTests
2009-04-27 Pierre d'Herbemont <pdherbemont@apple.com>
Reviewed by Simon Fraser
Fix video-played.html layout test.
We implement playForMillisecs() which makes sure the video
will have been playing for a minimum time.
Note, this does not ensure a strict synchronization between the time
asked and the media playback. But given that media playback is the
slow part we just need to compensate for the delay involved by playback.
(And not the other way around.)
Moreover, we split the test in 3 in order to be more gentle which
slower machines that may tend to timeout more easily on those tests.
- media/video-played-collapse-expected.txt: Added.
- media/video-played-collapse.html: Added.
- media/video-played-expected.txt:
- media/video-played-reset-expected.txt: Added.
- media/video-played-reset.html: Added.
- media/video-played.html:
- Split tests in multiple files.
- Makes sure we always play as much as requested by using playForMillisecs();
- media/video-played.js: Added. (testRanges): (nextTest): (pause): (canplay): (willCreateNewRange): (startPlayingInNewRange): (startPlaying): (secToMilli): (milliToSecs): (playForMillisecs.callPauseIfTimeIsReached): (playForMillisecs): (videoPlayedMain):
- 8:39 PM Changeset in webkit [42919] by
-
- 2 edits in trunk/WebCore
2009-04-27 Eric Roman <eroman@chromium.org>
Reviewed by Darin Fisher.
Fix a compile breakage.
<https://bugs.webkit.org/show_bug.cgi?id=25384>
- bindings/v8/custom/V8DOMWindowCustom.cpp: (WebCore::CALLBACK_FUNC_DECL):
- 6:01 PM Changeset in webkit [42918] by
-
- 3 edits in trunk/WebCore
2009-04-27 Eric Carlson <eric.carlson@apple.com>
Reviewed by Darin Adler.
<rdar://problem/6822344> Use of QTMovieCurrentSizeAttribute generates exception and will crash
QTMovieCurrentSizeAttribute generates an exception with some versions of QTKit, so calculate a
multiplier to scale from natural size to current size when a movie is opened and use that to
return the correct value from the naturalSize() method.
- platform/graphics/mac/MediaPlayerPrivateQTKit.h:
- platform/graphics/mac/MediaPlayerPrivateQTKit.mm: (WebCore::MediaPlayerPrivate::MediaPlayerPrivate): Initialize m_scaleFactor. (WebCore::MediaPlayerPrivate::naturalSize): Return naturalSize transformed by initial scale. (WebCore::MediaPlayerPrivate::cacheMovieScale): New, calculate difference between initial size and natural size so naturalSize() accounts for non-identity movie matrix. (WebCore::MediaPlayerPrivate::updateStates): Call cacheMovieScale when load state reaches QTMovieLoadStateLoaded for the first time.
- 5:54 PM Changeset in webkit [42917] by
-
- 3 edits4 adds in trunk
WebCore:
2009-04-27 Beth Dakin <Beth Dakin>
Reviewed by Dave Hyatt.
Fix for <rdar://problem/6709057> REGRESSION (4PB-TOT): http://www.winway.com/main3/support/faq.aspx selector doesn't look right or work
The problem here is that we had a self-painting layer nested inside
a non-self-painting layer. We ended up ignoring the self-painting
layer both during painting and hit-testing. This patch corrects
that.
- rendering/RenderLayer.cpp: (WebCore::RenderLayer::paintLayer): (WebCore::RenderLayer::hitTestLayer):
LayoutTests:
2009-04-27 Beth Dakin <Beth Dakin>
Reviewed by Dave Hyatt.
Test for <rdar://problem/6709057> REGRESSION (4PB-TOT): http://www.winway.com/main3/support/faq.aspx selector doesn't look right or work
- fast/css/nested-layers-with-hover.html: Added.
- platform/mac/fast/css/nested-layers-with-hover-expected.checksum: Added.
- platform/mac/fast/css/nested-layers-with-hover-expected.png: Added.
- platform/mac/fast/css/nested-layers-with-hover-expected.txt: Added.
- 5:23 PM Changeset in webkit [42916] by
-
- 2 edits in trunk/WebCore
If it has been set to allow any HTTPS certificates for this host, set
kCFStreamSSLAllowsExpiredCertificates to true to allow expired
certificate, and set kCFStreamSSLValidatesCertificateChain false to skip
certificate chain validation. (<rdar://problem/6382059>)
Reviewed by John Sullivan.
- platform/network/cf/ResourceHandleCFNet.cpp: (WebCore::makeFinalRequest):
- 5:12 PM Changeset in webkit [42915] by
-
- 1 edit4 adds in trunk/LayoutTests
2009-04-23 Simon Fraser <Simon Fraser>
Add pixel test for zoomed video with controls, with and without a transform.
- media/video-zoom-controls.html: Added.
- platform/mac/media/video-zoom-controls-expected.checksum: Added.
- platform/mac/media/video-zoom-controls-expected.png: Added.
- platform/mac/media/video-zoom-controls-expected.txt: Added.
- 5:08 PM Changeset in webkit [42914] by
-
- 4 edits in trunk
2009-04-27 Simon Fraser <Simon Fraser>
Reviewed by Adele Peterson
<rdar://problem/6822225> Full page zooming of <video> element in the browser window doesn't work well
Fix a 'size changed' notification thrash that caused standalone video elements
to continually resize after full page zooming, by using the movie's natual size (which is independent
of zooming), rather than its current size (which is not).
Note that this regresses <https://bugs.webkit.org/show_bug.cgi?id=25029>, so we have to
disable the media/video-size-intrinsic-scale.html test. However, we have to stop using
QTMovieCurrentSizeAttribute anyway; this will be addressed, and the test re-enabled via
<rdar://problem/6822344>.
- platform/graphics/mac/MediaPlayerPrivateQTKit.mm: (WebCore::MediaPlayerPrivate::naturalSize):
- 4:58 PM Changeset in webkit [42913] by
-
- 3 edits in trunk/WebCore
2009-04-27 Simon Fraser <Simon Fraser>
Reviewed by Darin Adler
<rdar://problem/6642221> REGRESSION: With the Movie widget, movie trailer fails to
load if movie had been previously viewed
Fix the Dashboard quirk for display:none plug-ins by moving the code from HTMLObjectElement
to HTMLEmebedElement. It has to be in HTMLEmbedElement because the content we care about uses <embed>.
- html/HTMLEmbedElement.cpp: (WebCore::HTMLEmbedElement::rendererIsNeeded):
- html/HTMLObjectElement.cpp: (WebCore::HTMLObjectElement::rendererIsNeeded):
- 4:33 PM Changeset in webkit [42912] by
-
- 14 edits in trunk/WebCore
2009-04-27 Sam Weinig <sam@webkit.org>
Reviewed by Geoffrey Garen.
Move more window event related code into DOMWindow.
- dom/Document.cpp: (WebCore::Document::implicitClose): (WebCore::Document::setWindowAttributeEventListener): (WebCore::Document::dispatchWindowEvent): (WebCore::Document::dispatchLoadEvent):
- dom/Document.h:
- dom/Element.cpp:
- dom/Element.h:
- dom/Node.cpp:
- dom/Node.h:
- html/HTMLBodyElement.cpp: (WebCore::HTMLBodyElement::parseMappedAttribute):
- html/HTMLFrameSetElement.cpp: (WebCore::HTMLFrameSetElement::parseMappedAttribute):
- loader/FrameLoader.cpp: (WebCore::FrameLoader::stopLoading):
- page/DOMWindow.cpp: (WebCore::DOMWindow::dispatchAllPendingUnloadEvents): (WebCore::DOMWindow::postMessageTimerFired): (WebCore::DOMWindow::dispatchEvent): (WebCore::DOMWindow::dispatchEventWithDocumentAsTarget): (WebCore::DOMWindow::dispatchLoadEvent): (WebCore::DOMWindow::dispatchUnloadEvent): (WebCore::DOMWindow::dispatchBeforeUnloadEvent):
- page/DOMWindow.h:
- page/Frame.cpp: (WebCore::Frame::shouldClose):
- svg/SVGSVGElement.cpp: (WebCore::SVGSVGElement::parseMappedAttribute):
- 4:14 PM Changeset in webkit [42911] by
-
- 25 edits in trunk
WebCore:
2009-04-27 Douglas R. Davidson <ddavidso@apple.com>
Implement the editing mechanisms and add context menu items for
<rdar://problem/6724106> WebViews need to implement text checking
Reviewed by Justin Garcia.
- editing/Editor.cpp:
- editing/Editor.h:
- editing/TypingCommand.cpp:
- loader/EmptyClients.h:
- page/ContextMenuController.cpp:
- page/EditorClient.h:
- page/mac/WebCoreViewFactory.h:
- platform/ContextMenu.cpp:
- platform/ContextMenuItem.h:
- platform/LocalizedStrings.h:
- platform/mac/LocalizedStringsMac.mm:
WebKit:
2009-04-27 Douglas R. Davidson <ddavidso@apple.com>
Add localizable strings for
<rdar://problem/6724106> WebViews need to implement text checking
Reviewed by Justin Garcia.
- English.lproj/Localizable.strings:
WebKit/mac:
2009-04-27 Douglas R. Davidson <ddavidso@apple.com>
Add the various switches and context menu items needed for
<rdar://problem/6724106> WebViews need to implement text checking
and adopt updatePanels in place of old SPI _updateGrammar.
Reviewed by Justin Garcia.
- WebCoreSupport/WebContextMenuClient.mm: (fixMenusReceivedFromOldClients):
- WebCoreSupport/WebEditorClient.h:
- WebCoreSupport/WebEditorClient.mm: (WebEditorClient::uppercaseWord): (WebEditorClient::lowercaseWord): (WebEditorClient::capitalizeWord): (WebEditorClient::showSubstitutionsPanel): (WebEditorClient::substitutionsPanelIsShowing): (WebEditorClient::toggleSmartInsertDelete): (WebEditorClient::isAutomaticQuoteSubstitutionEnabled): (WebEditorClient::toggleAutomaticQuoteSubstitution): (WebEditorClient::isAutomaticLinkDetectionEnabled): (WebEditorClient::toggleAutomaticLinkDetection): (WebEditorClient::isAutomaticDashSubstitutionEnabled): (WebEditorClient::toggleAutomaticDashSubstitution): (WebEditorClient::isAutomaticTextReplacementEnabled): (WebEditorClient::toggleAutomaticTextReplacement): (WebEditorClient::isAutomaticSpellingCorrectionEnabled): (WebEditorClient::toggleAutomaticSpellingCorrection): (WebEditorClient::checkTextOfParagraph):
- WebCoreSupport/WebViewFactory.mm: (-[WebViewFactory contextMenuItemTagShowColors]): (-[WebViewFactory contextMenuItemTagCorrectSpellingAutomatically]): (-[WebViewFactory contextMenuItemTagSubstitutionsMenu]): (-[WebViewFactory contextMenuItemTagShowSubstitutions:]): (-[WebViewFactory contextMenuItemTagSmartCopyPaste]): (-[WebViewFactory contextMenuItemTagSmartQuotes]): (-[WebViewFactory contextMenuItemTagSmartDashes]): (-[WebViewFactory contextMenuItemTagSmartLinks]): (-[WebViewFactory contextMenuItemTagTextReplacement]): (-[WebViewFactory contextMenuItemTagTransformationsMenu]): (-[WebViewFactory contextMenuItemTagMakeUpperCase]): (-[WebViewFactory contextMenuItemTagMakeLowerCase]): (-[WebViewFactory contextMenuItemTagCapitalize]):
- WebView/WebHTMLView.mm: (-[WebHTMLView validateUserInterfaceItemWithoutDelegate:]): (-[WebHTMLView isAutomaticQuoteSubstitutionEnabled]): (-[WebHTMLView setAutomaticQuoteSubstitutionEnabled:]): (-[WebHTMLView toggleAutomaticQuoteSubstitution:]): (-[WebHTMLView isAutomaticLinkDetectionEnabled]): (-[WebHTMLView setAutomaticLinkDetectionEnabled:]): (-[WebHTMLView toggleAutomaticLinkDetection:]): (-[WebHTMLView isAutomaticDashSubstitutionEnabled]): (-[WebHTMLView setAutomaticDashSubstitutionEnabled:]): (-[WebHTMLView toggleAutomaticDashSubstitution:]): (-[WebHTMLView isAutomaticTextReplacementEnabled]): (-[WebHTMLView setAutomaticTextReplacementEnabled:]): (-[WebHTMLView toggleAutomaticTextReplacement:]): (-[WebHTMLView isAutomaticSpellingCorrectionEnabled]): (-[WebHTMLView setAutomaticSpellingCorrectionEnabled:]): (-[WebHTMLView toggleAutomaticSpellingCorrection:]):
- WebView/WebHTMLViewInternal.h:
- WebView/WebPreferenceKeysPrivate.h:
- WebView/WebUIDelegatePrivate.h:
- WebView/WebView.mm: (-[WebViewPrivate init]): (-[WebView validateUserInterfaceItemWithoutDelegate:]): (-[WebView setGrammarCheckingEnabled:]): (-[WebView isAutomaticQuoteSubstitutionEnabled]): (-[WebView isAutomaticLinkDetectionEnabled]): (-[WebView isAutomaticDashSubstitutionEnabled]): (-[WebView isAutomaticTextReplacementEnabled]): (-[WebView isAutomaticSpellingCorrectionEnabled]): (-[WebView setAutomaticQuoteSubstitutionEnabled:]): (-[WebView toggleAutomaticQuoteSubstitution:]): (-[WebView setAutomaticLinkDetectionEnabled:]): (-[WebView toggleAutomaticLinkDetection:]): (-[WebView setAutomaticDashSubstitutionEnabled:]): (-[WebView toggleAutomaticDashSubstitution:]): (-[WebView setAutomaticTextReplacementEnabled:]): (-[WebView toggleAutomaticTextReplacement:]): (-[WebView setAutomaticSpellingCorrectionEnabled:]): (-[WebView toggleAutomaticSpellingCorrection:]):
- WebView/WebViewPrivate.h:
- 4:12 PM Changeset in webkit [42910] by
-
- 2 edits in trunk/WebCore
2009-04-27 Sam Weinig <sam@webkit.org>
Reviewed by Geoffrey Garen.
Fix for <rdar://problem/6772944> REGRESSION (r42223): PLT 2% slower, i-Bench 3% slower
Be slightly less eager in collecting after page close/navigation by increasing
the time before collection from 0 seconds to .5 seconds.
3% speedup on the PLT.
- bindings/js/GCController.cpp: (WebCore::GCController::garbageCollectSoon):
- 4:06 PM Changeset in webkit [42909] by
-
- 10 edits2 adds in trunk
Consolidate runtime application checks for Apple Mail and Safari
Reviewed by Mark Rowe and Darin Adler.
WebCore:
- WebCore.base.exp: Added exports.
- WebCore.xcodeproj/project.pbxproj: Added RuntimeApplicationChecks.{h|mm} source files to the project.
- page/mac/EventHandlerMac.mm: (WebCore::EventHandler::needsKeyboardEventDisambiguationQuirks): Removed local checkedSafari and isSafari variables and switched to use applicationIsSafari().
- platform/mac/RuntimeApplicationChecks.h: Added.
- platform/mac/RuntimeApplicationChecks.mm: Added. (WebCore::applicationIsAppleMail): Runtime application check for Apple Mail. (WebCore::applicationIsSafari): Runtime application check for Safari.
WebKit:
- WebCoreSupport/WebContextMenuClient.mm: (isAppleMail): Removed. (fixMenusToSendToOldClients): Switched to use applicationIsAppleMail().
- WebView/WebFrame.mm: (-[WebFrame reload]): Switched to use applicationIsSafari().
- WebView/WebPDFView.mm: (-[WebPDFView menuForEvent:]): Ditto.
- WebView/WebResource.mm: (+[WebResource _needMailThreadWorkaroundIfCalledOffMainThread]): Switched to use applicationIsAppleMail().
- WebView/WebView.mm: (runningLeopardMail): Ditto. (runningTigerMail): Ditto. (-[WebView _needsKeyboardEventDisambiguationQuirks]): Switched to use applicationIsSafari().
- 3:34 PM Changeset in webkit [42908] by
-
- 2 edits in trunk/WebCore
Bug 25374: AX: No AXValue change sent when text is auto-inserted
https://bugs.webkit.org/show_bug.cgi?id=25374
Updated to fix regression test failures
- 2:56 PM Changeset in webkit [42907] by
-
- 2 edits in trunk/WebCore
2009-04-16 Xan Lopez <xlopez@igalia.com>
Reviewed by Gustavo Noronha.
https://bugs.webkit.org/show_bug.cgi?id=21546
[GTK] ATK accessibility enhancements
Based on a patch by Alp Toker.
Cover more WebCore role -> ATK role conversions.
- page/gtk/AccessibilityObjectWrapperAtk.cpp:
- 2:40 PM Changeset in webkit [42906] by
-
- 2 edits in trunk/WebCore
2009-04-18 Xan Lopez <xlopez@igalia.com>
Reviewed by Gustavo Noronha.
https://bugs.webkit.org/show_bug.cgi?id=21546
[GTK] ATK accessibility enhancements
Do not call ATK setters in the getters, just return the
value. Among other things calling the setter will emit the notify
signal, which is wrong.
- page/gtk/AccessibilityObjectWrapperAtk.cpp:
- 2:33 PM Changeset in webkit [42905] by
-
- 2 edits in trunk/WebCore
2009-04-16 Xan Lopez <xlopez@igalia.com>
Reviewed by Gustavo Noronha.
https://bugs.webkit.org/show_bug.cgi?id=21546
[GTK] ATK accessibility enhancements
Based on a patch by Alp Toker.
Implement AtkImage interface.
- page/gtk/AccessibilityObjectWrapperAtk.cpp:
- 2:25 PM Changeset in webkit [42904] by
-
- 2 edits in trunk/WebCore
2009-04-27 Gustavo Noronha Silva <Gustavo Noronha Silva>
Unreviewed debug build fix.
- platform/gtk/gtk2drawing.c: (moz_gtk_toggle_paint):
- 1:12 PM Changeset in webkit [42903] by
-
- 3 edits in trunk/WebCore
2009-04-27 Dimitri Glazkov <Dimitri Glazkov>
Build fix.
https://bugs.webkit.org/show_bug.cgi?id=25382
Remove direct reference to CallFrame.h include to pacify Win build.
- bindings/js/JSDOMBinding.h: Removed ScriptState.h include.
- bindings/js/ScriptState.h: Replaced CallFrame.h with JSDOMBinding.h
- 12:49 PM Changeset in webkit [42902] by
-
- 2 edits in trunk/WebCore
Bug 25374: AX: No AXValue change sent when text is auto-inserted
https://bugs.webkit.org/show_bug.cgi?id=25374
- 12:46 PM Changeset in webkit [42901] by
-
- 10 edits in trunk/WebCore
2009-04-27 Dimitri Glazkov <Dimitri Glazkov>
Reviewed by Eric Seidel.
https://bugs.webkit.org/show_bug.cgi?id=25382
Move scriptStateFromNode to ScriptState.
- bindings/js/JSDOMBinding.cpp: Moved scriptStateFromNode to ScriptState.
- bindings/js/JSDOMBinding.h: Ditto.
- bindings/js/ScriptState.cpp: (WebCore::scriptStateFromNode): Added.
- bindings/js/ScriptState.h: Ditto.
- bindings/v8/ScriptState.cpp: (WebCore::scriptStateFromNode): Added.
- bindings/v8/ScriptState.h: Ditto.
- dom/NodeFilter.h: Removed JSDOMBinding header include.
- dom/NodeIterator.h: Ditto.
- dom/TreeWalker.h: Ditto.
- 12:44 PM Changeset in webkit [42900] by
-
- 4 edits in trunk
Bug 25428: 5 crashes in DumpRenderTree at com.apple.WebCore • -[AccessibilityObjectWrapper accessibilityAttributeValue:] + 830
https://bugs.webkit.org/show_bug.cgi?id=25428
- 12:33 PM Changeset in webkit [42899] by
-
- 2 edits in trunk/WebKitExamplePlugins
2009-04-27 Anders Carlsson <andersca@apple.com>
Reviewed by Adam Roben.
Update the example plug-in for new changes to the Cocoa event model.
- NetscapeCocoaPlugin/main.m: (handleDraw): (handleMouseEvent): (NPP_HandleEvent):
- 11:54 AM Changeset in webkit [42898] by
-
- 2 edits in trunk/WebKit/mac
Fix the Tiger build.
- Plugins/WebNetscapePluginView.mm: The base class of WebNetscapePluginView.mm, WebBaseNetscapePluginView, already implemented the two methods below. But the Tiger compiler didn't know that. (-[WebNetscapePluginView webView]): (-[WebNetscapePluginView webFrame]):
- 10:50 AM Changeset in webkit [42897] by
-
- 10 edits2 adds in trunk/WebKit
Reviewed by Anders Carlsson.
<rdar://problem/6352982>
- Plugins/WebBaseNetscapePluginView.mm: Removed checkIfAllowedToLoadURL:frame:callbackFunc, cancelCheckIfAllowedToLoadURL, and _webPluginContainerCancelCheckIfAllowedToLoadRequest from the base class. These methods now exist in the subclass WebNetscapePluginView.
Added WebNetscapeContainerCheckContextInfo, which is used as a "contextInfo" object in
-[WebNetscapePluginView checkIfAllowedToLoadURL:frame:callbackFunc:]
- Plugins/WebNetscapeContainerCheckContextInfo.h: Added.
- Plugins/WebNetscapeContainerCheckContextInfo.mm: Added. (-[WebNetscapeContainerCheckContextInfo initWithCheckRequestID:callbackFunc:]): Added desiginated initializer. (-[WebNetscapeContainerCheckContextInfo checkRequestID]): Added. Returns the checkRequestID. (-[WebNetscapeContainerCheckContextInfo callback]): Added. Returns the callback.
- Plugins/WebNetscapePluginView.h: Added two new ivars: _containerChecksInProgress and _currentContainerCheckRequestID.
- Plugins/WebNetscapePluginView.mm: #import both WebPluginContainerCheck.h and WebNetscapeContainerCheckContextInfo.h
(-[WebNetscapePluginView checkIfAllowedToLoadURL:frame:callbackFunc:]): Added. This is the implementation of WKN_CheckIfAllowedToLoadURL.
Here, we increment the request ID and start the container check.
(-[WebNetscapePluginView _containerCheckResult:contextInfo:]): Added. This is a callback method for WebPluginContainerCheck.
It's where we actually call into the plug-in and provide the allow-or-deny result.
(-[WebNetscapePluginView cancelCheckIfAllowedToLoadURL:]): Added. This is the implementation of WKN_CancelCheckIfAllowedToLoadURL.
Here we lookup the check, cancel it, and remove it from _containerChecksInProgress.
(-[WebNetscapePluginView _webPluginContainerCancelCheckIfAllowedToLoadRequest:]): Added. WebPluginContainerCheck automatically calls
this method after invoking our _containerCheckResult: selector. It works this way because calling -[WebPluginContainerCheck cancel] allows
it to do it's teardown process.
(-[WebNetscapePluginView fini]): Release _containerChecksInProgress ivar.
- Plugins/WebPluginContainerCheck.h: Removed initWithRequest: method from header; no client was using this method directly.
- Plugins/WebPluginContainerCheck.mm: (+[WebPluginContainerCheck checkWithRequest:target:resultObject:selector:controller:contextInfo:]): Added optional contextInfo parameter. (-[WebPluginContainerCheck _continueWithPolicy:]): If there's a contextInfo object, pass it as a parameter to resultSelector. (-[WebPluginContainerCheck cancel]): Release _contextInfo ivar. (-[WebPluginContainerCheck contextInfo]): Added new method. Returns the contextInfo object, if one so exists.
- Plugins/WebPluginController.mm: (-[WebPluginController _webPluginContainerCheckIfAllowedToLoadRequest:inFrame:resultObject:selector:]): Pass nil for contextInfo. WebKit-style plug-ins do not need additional context information.
- 9:57 AM Changeset in webkit [42896] by
-
- 6 edits in trunk/WebCore
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=25399
<rdar://problem/6633943> REGRESSION: Many crashes reported accessing Lexis/Nexis database,
beneath WebCore::Cache::evict
The crash happened because a cached resource handle was removed from a document's cached
resources map twice recursively, so a destructor was called for a value in a deleted bucket.
The first call was from Cache::evict, and when destroying CachedResourceHandle destroyed
CachedResource, DocLoader::removeCachedResource() was called again, with HashMap being in
an inconsistent state.
I couldn't fully reconstruct the loading sequence to make a test.
- loader/Cache.cpp: (WebCore::Cache::revalidateResource): Assert that the resource being revalidated is in cache (it makes no sense to revalidate one that isn't). (WebCore::Cache::evict): Don't remove the resource from document's map. Removing a resource from the cache in no way implies that documents no longer use the old version. This fixes the crash, and also fixes many cases of resource content being unavailable in Web Inspector.
- loader/CachedResource.h: (WebCore::CachedResource::setInCache): When bringing a revalidated resource back to cache, reset m_isBeingRevalidated to maintain the invariant of resources being revalidated never being in cache. This fixes another assertion I saw on LexisNexis search: in rare cases, switchClientsToRevalidatedResource() results in the same resource being requested again, but we were only enforcing CachedResource invariants after calling this function. (WebCore::CachedResource::unregisterHandle): Assert that the counter doesn't underflow.
- loader/DocLoader.cpp: (WebCore::DocLoader::removeCachedResource): Assert that the passed resource is removed, not some other resource that happens to have the same URL (this used to fail on LexisNexis search before this patch).
- loader/ImageDocument.cpp: (WebCore::ImageTokenizer::write): Replaced ASSERT_NOT_REACHED with notImplemented(). This method can be legally called via document.write(), and should work. LexisNexis takes this code path, but apparently has a fallback for Safari, so it doesn't affect site functionality.
- loader/CachedResource.cpp: (WebCore::CachedResource::clearResourceToRevalidate): Don't assert that m_resourceToRevalidate is being revalidated - this may no longer be true, because we now reset this member in CachedResource::setInCache().
- 9:24 AM Changeset in webkit [42895] by
-
- 6 edits in trunk/WebCore
Reviewed by Sam Weinig.
- make BidiContext a RefCounted class, starting with a refcount of 1, and share the root BidiContexts.
- platform/graphics/GraphicsContext.cpp: (WebCore::GraphicsContext::drawBidiText): Use BidiContext::create().
- platform/text/BidiContext.cpp: (WebCore::BidiContext::create): Added. For the four "root" contexts, returns a reference to a shared static BidiContext.
- platform/text/BidiContext.h: (WebCore::BidiContext::BidiContext):
- platform/text/BidiResolver.h: (WebCore::::commitExplicitEmbedding): Use BidiContext::create().
- rendering/bidi.cpp: (WebCore::RenderBlock::determineStartPosition): Ditto.
- 8:23 AM Changeset in webkit [42894] by
-
- 3 edits in trunk/WebCore
2009-04-27 Jan Michael Alonzo <jmalonzo@webkit.org>
Rubber-stamped by Gustavo Noronha.
Build fix for r42893: change GDK_exclaim to GDK_exclam
- platform/chromium/KeyCodeConversionGtk.cpp: (WebCore::windowsKeyCodeForKeyEvent):
- platform/gtk/KeyEventGtk.cpp: (WebCore::windowsKeyCodeForKeyEvent):
- 8:08 AM Changeset in webkit [42893] by
-
- 3 edits in trunk/WebCore
2009-04-27 Fumitoshi Ukai <ukai@google.com>
Reviewed by Xan Lopez.
Fix wrong key code conversion.
Missing conversion for GDK_exlaim ('!').
Parens are opposite: GDK_parenleft is open paren '('
and GDK_parenright is close paren ')'.
https://bugs.webkit.org/show_bug.cgi?id=25367
- platform/chromium/KeyCodeConversionGtk.cpp: (WebCore::windowsKeyCodeForKeyEvent):
- platform/gtk/KeyEventGtk.cpp: (WebCore::windowsKeyCodeForKeyEvent):
- 8:08 AM Changeset in webkit [42892] by
-
- 3 edits in trunk/WebCore
2009-04-27 Jan Michael Alonzo <jmalonzo@webkit.org>
Reviewed by Gustavo Noronha.
[Gtk] gtkdrawing update
https://bugs.webkit.org/show_bug.cgi?id=25408
Update to the 25 Apr 2009 version of gtk2drawing.c and
gtkdrawing.h from Mozilla (http://hg.mozilla.org/mozilla-central)
- platform/gtk/gtk2drawing.c: (setup_widget_prototype): (moz_gtk_get_combo_box_entry_arrow): (ensure_toolbar_widget): (ensure_tree_header_cell_widget): (moz_gtk_init): (moz_gtk_button_get_inner_border): (moz_gtk_toggle_paint): (moz_gtk_caret_paint): (moz_gtk_entry_paint): (moz_gtk_tree_header_cell_paint): (moz_gtk_combo_box_paint): (moz_gtk_toolbar_separator_paint): (moz_gtk_menu_separator_paint): (moz_gtk_get_widget_border): (moz_gtk_get_tab_scroll_arrow_size): (moz_gtk_get_toolbar_separator_width): (moz_gtk_get_menu_separator_height): (moz_gtk_widget_paint): (moz_gtk_shutdown):
- platform/gtk/gtkdrawing.h:
- 8:08 AM Changeset in webkit [42891] by
-
- 2 edits in trunk/WebKitTools
2009-04-27 Jan Michael Alonzo <jmalonzo@webkit.org>
Reviewed by Gustavo Noronha.
[GTK] Make layout tests / jsc tests usable without build-webkit
https://bugs.webkit.org/show_bug.cgi?id=21784
This requires WEBKITOUTPUTDIR to be set to the build directory.
Set the location of the product dir to the location pointed to by
WEBKITOUTPUTDIR.
- Scripts/webkitdirs.pm:
- 7:54 AM Changeset in webkit [42890] by
-
- 2 edits in trunk/WebKitTools
2009-04-27 Gustavo Noronha Silva <Gustavo Noronha Silva>
Reviewed by Adam Roben.
Use libsoup's facilities to resolve relative URLs, instead, since
it is a more robust method.
- DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: (LayoutTestController::queueLoad):
- 7:53 AM Changeset in webkit [42889] by
-
- 2 edits in trunk/WebKit/gtk
2009-04-27 Gustavo Noronha Silva <Gustavo Noronha Silva>
Reviewed by Xan Lopez.
https://bugs.webkit.org/show_bug.cgi?id=25409
[GTK] incorrectly fallsback on cancellation
Check whether we should fallback also on didFailLoad, so that we
don't get error pages showing up in parts of the content of some
sites because of, for instance, location changes.
- WebCoreSupport/FrameLoaderClientGtk.cpp: (WebKit::FrameLoaderClient::dispatchDidFailLoad):
- 7:53 AM Changeset in webkit [42888] by
-
- 2 edits in trunk/WebKit/gtk
2009-04-27 Gustavo Noronha Silva <Gustavo Noronha Silva>
Reviewed by Xan Lopez.
https://bugs.webkit.org/show_bug.cgi?id=25409
[GTK] incorrectly fallsback on cancellation
Correctly handle cancellation and frame loading interruption
caused by policy change. This also fixes
fast/frames/location-change.html.
- WebCoreSupport/FrameLoaderClientGtk.cpp: (WebKit::FrameLoaderClient::shouldFallBack):
- 6:55 AM Changeset in webkit [42887] by
-
- 2 edits in trunk/WebCore
2009-04-27 Ariya Hidayat <ariya.hidayat@nokia.com>
Reviewed by Tor Arne Vestbø.
[Qt] Widget painting should follow the layout direction (LTR, RTL)
of the element style, not the application layout direction.
- platform/qt/RenderThemeQt.cpp: (WebCore::RenderThemeQt::applyTheme):
- 6:27 AM Changeset in webkit [42886] by
-
- 3 edits in trunk/JavaScriptCore
Windows Debug build fix
Not sure why the buildbots weren't affected by this problem.
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj: Let VS re-order the file list, and added JavaScriptCore[_debug].def to the project. This was not necessary for the fix, but made making the fix easier.
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore_debug.def: Removed a function that no longer exists.
