⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Apr 29, 2009:

11:47 PM Changeset in webkit [43046] by weinig@apple.com
  • 6 edits
    2 adds in trunk

WebCore:

2009-04-29 Sam Weinig <​sam@webkit.org>

Reviewed by Oliver Hunt.

Fix for ​https://bugs.webkit.org/show_bug.cgi?id=25440
setTimeout should stringify non-string/non-function first arguments

Test: fast/dom/Window/setTimeout-string-argument.html

  • bindings/js/JSDOMWindowCustom.cpp: (WebCore::JSDOMWindow::setTimeout): (WebCore::JSDOMWindow::setInterval):
  • bindings/js/JSWorkerContextCustom.cpp: (WebCore::JSWorkerContext::setTimeout): (WebCore::JSWorkerContext::setInterval):
  • bindings/js/ScheduledAction.cpp: (WebCore::ScheduledAction::create):
  • bindings/js/ScheduledAction.h:

LayoutTests:

2009-04-29 Sam Weinig <​sam@webkit.org>

Reviewed by Oliver Hunt.

Test for ​https://bugs.webkit.org/show_bug.cgi?id=25440
setTimeout should stringify non-string/non-function first arguments

  • fast/dom/Window/setTimeout-string-argument-expected.txt: Added.
  • fast/dom/Window/setTimeout-string-argument.html: Added.
8:38 PM Changeset in webkit [43045] by mrowe@apple.com
  • 3 edits in trunk/WebKit/mac

More build fixing after r43037.

  • Plugins/Hosted/NetscapePluginInstanceProxy.h:
  • Plugins/Hosted/NetscapePluginInstanceProxy.mm:

(WebKit::NetscapePluginInstanceProxy::invoke):
(WebKit::NetscapePluginInstanceProxy::invokeDefault):
(WebKit::NetscapePluginInstanceProxy::construct):
(WebKit::NetscapePluginInstanceProxy::demarshalValues):

8:03 PM Changeset in webkit [43044] by mitz@apple.com
  • 13 edits
    2 adds in trunk

WebCore:

Reviewed by Simon Fraser.

  • WebCore part of <rdar://problem/6609509> Select All and then Delete should put Mail editing back into the same state as a new message

Test: editing/deleting/in-visibly-empty-root.html

  • WebCore.base.exp: Exported VisibleSelection::isAll(bool).
  • editing/SelectionController.h: (WebCore::SelectionController::isAll): Added. Calls through to VisibleSelection.
  • editing/TypingCommand.cpp: (WebCore::TypingCommand::makeEditableRootEmpty): Added. Removes all children of the root editable element the selection is in, other than a placeholder. Returns true iff it did anything. (WebCore::TypingCommand::deleteKeyPressed): When there is only a single visible position in the root editable element, but it has children other than a placeholder, remove those children.
  • editing/TypingCommand.h:
  • editing/VisiblePosition.h: Added a StayInEditableContent enum and a FIXME.
  • editing/VisibleSelection.cpp: (WebCore::VisibleSelection::isAll): Added. Returns whether the selection encompasses all visible positions, either in the document or in the editable root.
  • editing/VisibleSelection.h:

WebKit/mac:

Reviewed by Simon Fraser.

  • WebKit part of <rdar://problem/6609509> Select All and then Delete should put Mail editing back into the same state as a new message
  • WebView/WebView.mm: (-[WebView _selectionIsCaret]): Added. (-[WebView _selectionIsAll]): Added. Returns whether the selection encompasses the entire document.
  • WebView/WebViewPrivate.h:

LayoutTests:

Reviewed by Simon Fraser.

  • test and updated results for <rdar://problem/6609509> Select All and then Delete should put Mail editing back into the same state as a new message
  • editing/deleting/in-visibly-empty-root-expected.txt: Added.
  • editing/deleting/in-visibly-empty-root.html: Added.
  • platform/mac/editing/deleting/delete-at-start-or-end-expected.txt:
7:19 PM Changeset in webkit [43043] by weinig@apple.com
  • 3 edits in trunk/JavaScriptCore

2009-04-29 Sam Weinig <​sam@webkit.org>

Another attempt to fix the windows build.

7:12 PM Changeset in webkit [43042] by weinig@apple.com
  • 2 edits in trunk/WebCore

2009-04-29 Sam Weinig <​sam@webkit.org>

Fix style nit.

  • editing/visible_units.cpp: (WebCore::getLeafBoxesInLogicalOrder):
7:10 PM Changeset in webkit [43041] by weinig@apple.com
  • 3 edits in trunk/JavaScriptCore

2009-04-29 Sam Weinig <​sam@webkit.org>

Try and fix the windows build.

7:02 PM Changeset in webkit [43040] by hyatt@apple.com
  • 2 edits in trunk/WebCore

2009-04-29 David Hyatt <​hyatt@apple.com>

Reviewed by Dan Bernstein.

For now just drop the deferred layout on the floor, since it causes an infinite hang in mail. Even
trying to schedule a relayout for later leaves you in a state where you hit the needsLayout painting
assertions.

Basically what Mail is doing is crazy, and we can't support it other than to just drop the last layout
and not do it (which is basically what was happening before).

  • page/FrameView.cpp: (WebCore::FrameView::setContentsSize): (WebCore::FrameView::needsLayout):
6:35 PM Changeset in webkit [43039] by justin.garcia@apple.com
  • 7 edits in trunk

WebCore:

2009-04-29 Douglas Davidson <​ddavidso@apple.com>

Reviewed by Justin Garcia.

<rdar://problem/6836921> Mail exhibits issues with text checking, e.g. menu items not always validated correctly


Updates to the text checking code to enable text checking even if spellchecking is turned off
and fix an off-by-one error in selection handling.

  • editing/Editor.cpp: (WebCore::Editor::markMisspellingsAfterTypingToPosition): (WebCore::Editor::markAllMisspellingsAndBadGrammarInRanges): (WebCore::Editor::markMisspellingsAndBadGrammar):
  • editing/Editor.h:
  • editing/TypingCommand.cpp: (WebCore::TypingCommand::markMisspellingsAfterTyping):

WebKit/mac:

2009-04-29 Douglas Davidson <​ddavidso@apple.com>

Reviewed by Justin Garcia.


<rdar://problem/6836921> Mail exhibits issues with text checking, e.g. menu items not always validated correctly

  • WebView/WebHTMLView.mm: (-[WebHTMLView validateUserInterfaceItemWithoutDelegate:]): (-[WebHTMLView orderFrontSubstitutionsPanel:]):
  • WebView/WebView.mm: (-[WebView validateUserInterfaceItemWithoutDelegate:]):
6:34 PM Changeset in webkit [43038] by barraclough@apple.com
  • 2 edits in trunk/JavaScriptCore

2009-04-29 Gavin Barraclough <​barraclough@apple.com>

Reviewed by Oliver "Peg-Leg" Hunt.

Coallesce input checking and reduce futzing with the index position
between alternatives and iterations of the main loop of a regex,
when run in YARR.

Consider the following regex: /foo|bar/


Prior to this patch, this will be implemented something like this pseudo-code description:


loop:

check_for_available_input(3) this increments the index by 3, for the first alterantive.

if (available) { test "foo" }

decrement_index(3)
check_for_available_input(3) this increments the index by 3, for the second alterantive.

if (available) { test "bar" }

decrement_index(3)
check_for_available_input(1) can we loop again?

if (available) { goto loop }

With these changes it will look more like this:

check_for_available_input(3) this increments the index by 3, for the first alterantive.
if (!available) { goto fail }

loop:

test "foo"
test "bar"
check_for_available_input(1) can we loop again?

if (available) { goto loop }

fail:

This gives about a 5% gain on v8-regex, no change on Sunspider.

  • yarr/RegexJIT.cpp: (JSC::Yarr::RegexGenerator::TermGenerationState::linkAlternativeBacktracksTo): (JSC::Yarr::RegexGenerator::generateDisjunction):
6:21 PM Changeset in webkit [43037] by oliver@apple.com
  • 46 edits in trunk

Clean up ArgList to be a trivial type

Reviewed by Gavin Barraclough

Separate out old ArgList logic to handle buffering and marking arguments
into a distinct MarkedArgumentBuffer type. ArgList becomes a trivial
struct of a pointer and length.

6:16 PM Changeset in webkit [43036] by eric@webkit.org
  • 2 edits in trunk/WebCore

No review, build fix only.

Fix m_offset uses added while I wasn't looking.

  • editing/visible_units.cpp: (WebCore::logicalStartPositionForLine): (WebCore::logicalEndPositionForLine):
6:09 PM Changeset in webkit [43035] by eric@webkit.org
  • 31 edits in trunk

Reviewed by Darin Adler.

Make m_offset private and change all callers to use deprecatedEditingOffset().
​https://bugs.webkit.org/show_bug.cgi?id=25472

Per Darin's suggestion, this was just a simple search replace
of .m_offset with .deprecatedEditingOffset().

There was one change in InsertParagraphSeparatorCommand::doApply to use
Position::moveToOffset(0) instead of .m_offset = 0;

  • dom/Position.cpp: (WebCore::Position::rendersInDifferentPosition): (WebCore::Position::leadingWhitespacePosition):
  • dom/Position.h: (WebCore::Position::deprecatedEditingOffset): (WebCore::Position::moveToOffset): (WebCore::operator==):
  • dom/PositionIterator.h: (WebCore::PositionIterator::PositionIterator):
  • dom/Range.cpp: (WebCore::Range::create): (WebCore::Range::compareBoundaryPoints):
  • editing/ApplyStyleCommand.cpp: (WebCore::ApplyStyleCommand::applyRelativeFontStyleChange): (WebCore::ApplyStyleCommand::applyInlineStyleToRange): (WebCore::ApplyStyleCommand::removeInlineStyle): (WebCore::ApplyStyleCommand::nodeFullySelected): (WebCore::ApplyStyleCommand::nodeFullyUnselected): (WebCore::ApplyStyleCommand::splitTextAtStartIfNeeded): (WebCore::ApplyStyleCommand::splitTextAtEndIfNeeded): (WebCore::ApplyStyleCommand::splitTextElementAtStartIfNeeded): (WebCore::ApplyStyleCommand::splitTextElementAtEndIfNeeded): (WebCore::ApplyStyleCommand::mergeStartWithPreviousIfIdentical): (WebCore::ApplyStyleCommand::mergeEndWithNextIfIdentical): (WebCore::ApplyStyleCommand::joinChildTextNodes):
  • editing/BreakBlockquoteCommand.cpp: (WebCore::BreakBlockquoteCommand::doApply):
  • editing/CompositeEditCommand.cpp: (WebCore::CompositeEditCommand::insertNodeAt): (WebCore::CompositeEditCommand::positionOutsideTabSpan): (WebCore::CompositeEditCommand::rebalanceWhitespaceAt): (WebCore::CompositeEditCommand::prepareWhitespaceAtPositionForSplit): (WebCore::CompositeEditCommand::deleteInsignificantText): (WebCore::CompositeEditCommand::moveParagraphs): (WebCore::CompositeEditCommand::breakOutOfEmptyMailBlockquotedParagraph):
  • editing/DeleteSelectionCommand.cpp: (WebCore::updatePositionForNodeRemoval): (WebCore::updatePositionForTextRemoval): (WebCore::DeleteSelectionCommand::handleGeneralDelete): (WebCore::DeleteSelectionCommand::fixupWhitespace):
  • editing/Editor.cpp: (WebCore::Editor::setComposition): (WebCore::Editor::advanceToNextMisspelling): (WebCore::Editor::getCompositionSelection):
  • editing/InsertLineBreakCommand.cpp: (WebCore::InsertLineBreakCommand::doApply):
  • editing/InsertParagraphSeparatorCommand.cpp: (WebCore::InsertParagraphSeparatorCommand::doApply):
  • editing/InsertTextCommand.cpp: (WebCore::InsertTextCommand::performTrivialReplace): (WebCore::InsertTextCommand::input): (WebCore::InsertTextCommand::insertTab):
  • editing/MoveSelectionCommand.cpp: (WebCore::MoveSelectionCommand::doApply):
  • editing/ReplaceSelectionCommand.cpp: (WebCore::ReplaceSelectionCommand::doApply):
  • editing/SelectionController.cpp: (WebCore::SelectionController::debugRenderer):
  • editing/TextIterator.cpp: (WebCore::TextIterator::rangeFromLocationAndLength):
  • editing/TypingCommand.cpp: (WebCore::TypingCommand::deleteKeyPressed): (WebCore::TypingCommand::forwardDeleteKeyPressed):
  • editing/VisiblePosition.cpp: (WebCore::VisiblePosition::characterAfter): (WebCore::VisiblePosition::debugPosition): (WebCore::makeRange): (WebCore::setStart): (WebCore::setEnd):
  • editing/VisibleSelection.cpp: (WebCore::VisibleSelection::toNormalizedRange): (WebCore::makeSearchRange): (WebCore::VisibleSelection::debugPosition): (WebCore::VisibleSelection::showTreeForThis):
  • editing/htmlediting.cpp: (WebCore::comparePositions): (WebCore::rangeCompliantEquivalent):
  • editing/visible_units.cpp: (WebCore::previousBoundary): (WebCore::nextBoundary): (WebCore::startPositionForLine): (WebCore::startOfLine): (WebCore::endPositionForLine): (WebCore::nextLinePosition): (WebCore::startOfParagraph): (WebCore::endOfParagraph): (WebCore::logicalStartPositionForLine): (WebCore::logicalEndPositionForLine):
  • page/AccessibilityObject.cpp: (WebCore::updateAXLineStartForVisiblePosition):
  • page/AccessibilityRenderObject.cpp: (WebCore::AccessibilityRenderObject::indexForVisiblePosition):
  • page/DOMSelection.cpp: (WebCore::DOMSelection::anchorOffset): (WebCore::DOMSelection::focusOffset): (WebCore::DOMSelection::baseOffset): (WebCore::DOMSelection::extentOffset):
  • page/EventHandler.cpp: (WebCore::EventHandler::handleMousePressEventSingleClick):
  • page/Frame.cpp: (WebCore::Frame::selectionLayoutChanged):
  • page/mac/AccessibilityObjectWrapper.mm: (textMarkerForVisiblePosition): (visiblePositionForTextMarker):
  • rendering/RenderTextControl.cpp: (WebCore::RenderTextControl::indexForVisiblePosition):
  • rendering/RenderTreeAsText.cpp: (WebCore::writeSelection):
6:07 PM Changeset in webkit [43034] by eric@webkit.org
  • 2 edits
    1 add
    4 deletes in trunk/LayoutTests

Reviewed by Oliver Hunt.

Re-write image-clipped-hit.svg to be dumpAsText() (and clean up the code to be less insane)

  • platform/mac/svg/custom/image-clipped-hit-expected.checksum: Removed.
  • platform/mac/svg/custom/image-clipped-hit-expected.png: Removed.
  • platform/mac/svg/custom/image-clipped-hit-expected.txt: Removed.
  • platform/qt/svg/custom/image-clipped-hit-expected.txt: Removed.
  • svg/custom/image-clipped-hit.svg:
5:51 PM Changeset in webkit [43033] by kov@webkit.org
  • 2 edits in trunk/LayoutTests

2009-04-29 Gustavo Noronha Silva <​gustavo.noronha@collabora.co.uk>

Second try at making the bot green.

  • platform/gtk/Skipped:
5:48 PM Changeset in webkit [43032] by mitz@apple.com
  • 7 edits
    2 adds in trunk

WebCore:

2009-04-29 Xiaomei Ji <​xji@chromium.org>

Reviewed by Dan Bernstein.

Fix ​https://bugs.webkit.org/show_bug.cgi?id=24168
RTL: Home/End key does not behave correctly in mixed bidi text in RTL document

Test: editing/selection/home-end.html

  • editing/SelectionController.cpp: (WebCore::SelectionController::modifyExtendingForward): Change calling endOfLine() to logicalEndOfLine() when granularity is LineBoundary. (WebCore::SelectionController::modifyMovingForward): Change calling endOfLine() to logicalEndOfLine() when granularity is LineBoundary (WebCore::SelectionController::modifyExtendingBackward): Change calling startOfLine() to logicalStartOfLine() when granularity is LineBoundary. (WebCore::SelectionController::modifyMovingBackward): Change calling startOfLine() to logicalStartOfLine() when granularity is LineBoundary.
  • editing/visible_units.cpp: (WebCore::getLeafBoxesInLogicalOrder): Added. Reconstruct leaf boxes in logical order. (WebCore::getLogicalStartBoxAndNode): Added. (WebCore::getLogicalEndBoxAndNode): Added. (WebCore::logicalStartPositionForLine): Added. Similar to startPositionForLine. (WebCore::logicalStartOfLine): Added. Similar to startOfLine. (WebCore::logicalEndPositionForLine): Added. Similar to endPositionForLine. (WebCore::inSameLogicalLine): Added. (WebCore::logicalEndOfLine): Added. Similar to endOfLine.
  • editing/visible_units.h:

LayoutTests:

2009-04-29 Xiaomei Ji <​xji@chromium.org>

Reviewed by Dan Bernstein.

Fix ​https://bugs.webkit.org/show_bug.cgi?id=24168
RTL: Home/End key does not behave correctly in mixed bidi text in RTL document

  • editing/selection/extend-selection-expected.txt: Added result for extend in lineBoundary.
  • editing/selection/extend-selection.html: Added test cases and script for extend in lineBoundary.
  • editing/selection/home-end-expected.txt: Added.
  • editing/selection/home-end.html: Added.
5:24 PM Changeset in webkit [43031] by ojan@chromium.org
  • 5 edits in trunk/LayoutTests

2009-04-29 Ojan Vafai <​ojan@chromium.org>

Reviewed by NOBODY (OOPS!).

Fix this test to only use a setTimeout in IE.
It doesn't need a timeout in WebKit and the
timeout requires using waitUntilDone/notifyDone,
which doesn't play nicely with JS tests.

See ​https://bugs.webkit.org/show_bug.cgi?id=25471

  • fast/forms/resources/textarea-metrics.js: (assertTextareaMetrics):
  • fast/forms/textarea-metrics-expected.txt:
  • platform/win/fast/forms/textarea-metrics-expected.txt:
  • platform/win/Skipped:
4:52 PM Changeset in webkit [43030] by ojan@chromium.org
  • 1 edit
    1 move
    1 add in trunk/LayoutTests

Ojan Vafai <​ojan@chromium.org>

Reviewed by Eric Seidel.

Put this file in the right place to fix the bot failure.

  • platform/mac-tiger/fast/forms/text-control-intrinsic-widths-expected.txt: Renamed from LayoutTests/platform/mac-tiger/text-control-intrinsic-widths-expected.txt.
4:50 PM Changeset in webkit [43029] by ojan@chromium.org
  • 2 edits in trunk/LayoutTests

2009-04-29 Ojan Vafai <​ojan@chromium.org>

Reviewed by Eric Seidel.

Skip fast/forms/textarea-metrics.html. It's printing the TEST PASSED
before the test is finished. There's a race with any JS tests that
use setTimeout. Fortunately, this test doesn't need the setTimeout,
so it's easy to fix.

See ​https://bugs.webkit.org/show_bug.cgi?id=25471

  • platform/win/Skipped:
4:34 PM Changeset in webkit [43028] by eric@webkit.org
  • 7 edits
    2 deletes in trunk

2009-04-29 Eric Seidel <​eric@webkit.org>

No review, rolling out a patch.

Revert ​http://trac.webkit.org/changeset/43019

New tests failed because I removed the tabs from them
when landing (since we avoid tabs in WebKit files).
I couldn't tell if the new results were correct with
spaces or not.

  • editing/SelectionController.cpp: (WebCore::SelectionController::modifyExtendingForward): (WebCore::SelectionController::modifyMovingForward): (WebCore::SelectionController::modifyExtendingBackward): (WebCore::SelectionController::modifyMovingBackward):
  • editing/visible_units.cpp:
  • editing/visible_units.h:
4:27 PM Changeset in webkit [43027] by eric@webkit.org
  • 7 edits
    2 deletes in trunk

2009-04-29 Eric Seidel <​eric@webkit.org>

No review, rolling out a patch.

Revert 43020 as it caused accessibility/lists.html to fail
and no one is around to tell me if it's a progression or not.

  • page/AccessibilityObject.h: (WebCore::):
  • page/AccessibilityRenderObject.cpp: (WebCore::AccessibilityRenderObject::roleValue): (WebCore::AccessibilityRenderObject::canSetFocusAttribute):
  • page/mac/AccessibilityObjectWrapper.mm: (RoleEntry::):
4:21 PM Changeset in webkit [43026] by hyatt@apple.com
  • 3 edits in trunk/WebCore

2009-04-29 David Hyatt <​hyatt@apple.com>

Reviewed by Dan Bernstein.

Fix for <rdar://problem/6828164>, Mail hits the !root->needsLayout() assert because it re-marks the FrameView for layout
when the FrameView is resized. This bug was exposed by the elimination of the separate WebKit layout
flag on Mac.


FrameView now defers setNeedsLayouts during size changes. Once all of the size changes are finished (including re-entrant ones
from WebDynamicScrollbarsView and ScrollView::updateScrollbars) we then do a layout if necessary.

  • page/FrameView.cpp: (WebCore::FrameView::FrameView): (WebCore::FrameView::setContentsSize): (WebCore::FrameView::layout): (WebCore::FrameView::needsLayout): (WebCore::FrameView::setNeedsLayout):
  • page/FrameView.h:
4:20 PM Changeset in webkit [43025] by hyatt@apple.com
  • 2 edits in trunk/WebKit/mac

2009-04-29 David Hyatt <​hyatt@apple.com>

Reviewed by Dan Bernstein.

Fix a bug in the bounds checking for setNeedsLayout dirtying when a WebView's size changes. The superview
of the WebView was being incorrectly checked instead of the WebView itself.

  • WebView/WebView.mm: (-[WebView _boundsChanged]):
4:09 PM Changeset in webkit [43024] by ojan@chromium.org
  • 1 edit in trunk/LayoutTests/ChangeLog

Fix ChangeLog description.

4:04 PM Changeset in webkit [43023] by ojan@chromium.org
  • 1 edit
    1 add in trunk/LayoutTests

2009-04-29 Ojan Vafai <​ojan@chromium.org>

Reviewed by Eric Seidel.

Add expected results for failing tests.

3:48 PM Changeset in webkit [43022] by eric@webkit.org
  • 3 edits in trunk/WebCore

2009-04-29 Antony Sargent <​asargent@chromium.org>

Reviewed by Dimitri Glazkov and Eric Seidel.

Use AtomicString to speed up window and document interceptors.
​https://bugs.webkit.org/show_bug.cgi?id=25275

  • bindings/v8/custom/V8DOMWindowCustom.cpp: (WebCore::NAMED_PROPERTY_GETTER):
  • bindings/v8/custom/V8HTMLDocumentCustom.cpp: (WebCore::NAMED_PROPERTY_DELETER): (WebCore::NAMED_PROPERTY_GETTER):
3:28 PM Changeset in webkit [43021] by mrowe@apple.com
  • 2 edits in trunk/WebKitTools

Update build.webkit.org configuration for the addition of the new GTK buildbot.

  • BuildSlaveSupport/build.webkit.org-config/config.json:
3:22 PM Changeset in webkit [43020] by eric@webkit.org
  • 7 edits
    2 adds in trunk

2009-04-29 Sankar Aditya Tanguturi <​sankaraditya@gmail.com>

Reviewed by Jon Honeycutt.

Add a new accessibility role for list items. Part of
​http://bugs.webkit.org/show_id.cgi?id=20013

  • win/AccessibleBase.cpp: (MSAARole): Return ROLE_SYSTEM_LISTITEM for list item role.
3:16 PM Changeset in webkit [43019] by eric@webkit.org
  • 7 edits
    2 adds in trunk

2009-04-29 Xiaomei Ji <​xji@chromium.org>

Reviewed by Dan Bernstein.

Fix ​https://bugs.webkit.org/show_bug.cgi?id=24168
RTL: Home/End key does not behave correctly in mixed bidi text in RTL document

Test: editing/selection/home-end.html

  • editing/SelectionController.cpp: (WebCore::SelectionController::modifyExtendingForward): Change calling endOfLine() to logicalEndOfLine() when granularity is LineBoundary. (WebCore::SelectionController::modifyMovingForward): Change calling endOfLine() to logicalEndOfLine() when granularity is LineBoundary (WebCore::SelectionController::modifyExtendingBackward): Change calling startOfLine() to logicalStartOfLine() when granularity is LineBoundary. (WebCore::SelectionController::modifyMovingBackward): Change calling startOfLine() to logicalStartOfLine() when granularity is LineBoundary.
  • editing/visible_units.cpp: (WebCore::getLeafBoxesInLogicalOrder): Added. Reconstruct leaf boxes in logical order. (WebCore::getLogicalStartBoxAndNode): Added. (WebCore::getLogicalEndBoxAndNode): Added. (WebCore::logicalStartPositionForLine): Added. Similar to startPositionForLine. (WebCore::logicalStartOfLine): Added. Similar to startOfLine. (WebCore::logicalEndPositionForLine): Added. Similar to endPositionForLine. (WebCore::inSameLogicalLine): Added. (WebCore::logicalEndOfLine): Added. Similar to endOfLine.
  • editing/visible_units.h:
3:14 PM Changeset in webkit [43018] by eric@webkit.org
  • 4 edits
    3 adds in trunk

2009-04-29 Sankar Aditya Tanguturi <​sankaraditya@gmail.com>

Reviewed by Adele Peterson.

​https://bugs.webkit.org/show_bug.cgi?id=23583
Populate role attribute for document objects correctly
on Windows platform.

  • AccessibleDocument.cpp: (AccessibleDocument::role): Return ROLE_SYSTEM_DOCUMENT for document objects on windows. (Matching Firefox).
  • AccessibleDocument.h: Add the role function prototype in header file.
3:11 PM Changeset in webkit [43017] by mrowe@apple.com
  • 2 edits in trunk/WebKitTools

Ignore the --use-remote-links-to-tests option for GTK as it leads to
perl errors being spewed at the end of run-webkit-tests.

  • Scripts/run-webkit-tests:
2:54 PM Changeset in webkit [43016] by mrowe@apple.com
  • 2 edits in trunk/WebKitTools

Implement test-result-archive for GTK.

  • BuildSlaveSupport/test-result-archive:
2:38 PM Changeset in webkit [43015] by eric@webkit.org
  • 4 edits
    4 adds in trunk/WebKit/qt

2009-03-27 Benjamin C Meyer <​benjamin.meyer@torchmobile.com>

Reviewed by Simon Hausmann.

Update the page actions when a finishing loading even if the frame is
not the top frame such as when browsing inside of a website with frames.
​https://bugs.webkit.org/show_bug.cgi?id=24890

  • WebCoreSupport/FrameLoaderClientQt.cpp: (WebCore::FrameLoaderClientQt::dispatchDidFinishLoad):
  • tests/qwebpage/frametest/frame_a.html: Added.
  • tests/qwebpage/frametest/index.html: Added.
  • tests/qwebpage/tst_qwebpage.cpp: (tst_QWebPage::backActionUpdate):
2:31 PM Changeset in webkit [43014] by eric@webkit.org
  • 6 edits in trunk

2009-04-29 Mike Belshe <​mike@belshe.com>

Reviewed by Eric Seidel.

Update location while page is loading.
​https://bugs.webkit.org/show_bug.cgi?id=21597

Tested by:

  • fast/dom/location-new-window-no-crash
  • fast/dom/Window/window-open-pending-url
  • page/Location.cpp:
2:28 PM Changeset in webkit [43013] by kov@webkit.org
  • 2 edits in trunk/LayoutTests

2009-04-29 Gustavo Noronha Silva <​gustavo.noronha@collabora.co.uk>

Rubber-stamped by Mark Rowe.

Disable failing tests to make the bot green for its new debut, so
that we can more easily track regressions.

  • platform/gtk/Skipped:
2:25 PM Changeset in webkit [43012] by eric@webkit.org
  • 1 edit
    3 adds in trunk/WebCore

2009-04-29 Feng Qian <​feng@chromium.org>

Reviewed by Darin Adler.

Add Android port files to WebCore/platform.
​https://bugs.webkit.org/show_bug.cgi?id=23296

  • platform/android: Added.
  • platform/android/ClipboardAndroid.cpp: Added.
  • platform/android/ClipboardAndroid.h: Added.
2:23 PM Changeset in webkit [43011] by eric@webkit.org
  • 1 edit
    4 adds in trunk/WebCore

2009-04-29 Feng Qian <​feng@chromium.org>

Reviewed by Darin Adler.

Add Android-specific files to the WebCore/page directory.
​https://bugs.webkit.org/show_bug.cgi?id=23295

  • page/android: Added.
  • page/android/DragControllerAndroid.cpp: Added.
  • page/android/EventHandlerAndroid.cpp: Added.
  • page/android/InspectorControllerAndroid.cpp: Added.
2:00 PM Changeset in webkit [43010] by eric@webkit.org
  • 7 edits
    2 adds in trunk/WebCore

2009-04-29 Pavel Feldman <​pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Extract PageGroupLoadDeferrer from Chrome.cpp

  • GNUmakefile.am: added PageGroupLoadDeferrer
  • WebCore.pro: ditto
  • WebCore.scons: ditto
  • WebCore.vcproj/WebCore.vcproj: ditto
  • WebCore.xcodeproj/project.pbxproj: ditto
  • WebCoreSources.bkl: ditto
  • page/Chrome.cpp: PageGroupLoadDeferrer impl moved to a separate class.
  • page/PageGroupLoadDeferrer.cpp: Added. (WebCore::PageGroupLoadDeferrer::PageGroupLoadDeferrer): (WebCore::PageGroupLoadDeferrer::~PageGroupLoadDeferrer):
  • page/PageGroupLoadDeferrer.h: Added.
1:55 PM Changeset in webkit [43009] by kdecker@apple.com
  • 8 edits in trunk/WebKit/mac

Reviewed by Anders Carlson.

Allow WKN_CheckIfAllowedToLoadURL() to take an optional void* context parameter.


  • Plugins/WebNetscapeContainerCheckContextInfo.h:
  • Plugins/WebNetscapeContainerCheckContextInfo.mm: (-[WebNetscapeContainerCheckContextInfo initWithCheckRequestID:callbackFunc:context:]): (-[WebNetscapeContainerCheckContextInfo callback]): (-[WebNetscapeContainerCheckContextInfo context]):
  • Plugins/WebNetscapeContainerCheckPrivate.h:
  • Plugins/WebNetscapeContainerCheckPrivate.mm: (browserContainerCheckFuncs):
  • Plugins/WebNetscapePluginView.h:
  • Plugins/WebNetscapePluginView.mm: (-[WebNetscapePluginView checkIfAllowedToLoadURL:frame:callbackFunc:context:]): (-[WebNetscapePluginView _containerCheckResult:contextInfo:]):
  • Plugins/npapi.mm: (WKN_CheckIfAllowedToLoadURL):
1:43 PM Changeset in webkit [43008] by eric@webkit.org
  • 2 edits in trunk/JavaScriptCore

2009-04-29 Laszlo Gombos <Laszlo Gombos>

Reviewed by Sam Weinig.

​https://bugs.webkit.org/show_bug.cgi?id=25334

Fix Qt build when ENABLE_JIT is explicitly set to 1
to overrule defaults.

1:31 PM Changeset in webkit [43007] by ojan@chromium.org
  • 558 edits
    1 copy
    191 adds in trunk

Reviewed by Dan Bernstein.

Make textarea and text input metrics more closely match IEs.

This involves:
-set text input width to size*avgCharWidth + maxCharWidth - avgCharWidth
-set textarea width to cols*avgCharWidth
-Make default CSS match IEs
-Correctly initializing m_avgCharWidth and m_maxCharWidth for each platform and SVG.

Those values for textarea and inputs were derived by doing a ton of manual
testing of IE's width values for various textareas and fonts. On Windows we match
IE exactly except for a couple fonts of the ~12 tested.

To get the average and max character width of a font, we do the following
for each platform:
-Win: TextMetrics expose avgCharWidth and maxCharWidth
-SVG: avgCharWidth = width of an '0', fallback on width of a space glyph, then m_xHeight

maxCharWidth = width of a 'W' for roman fonts, fallback on m_ascent

-Linux: avgCharWidth = width of an '0', fallback on m_xHeight

maxCharWidth = max of avgCharWidth and m_ascent

-Mac: Calculate the avgCharWidth and grab the maxCharWidth off the font.

If either one is non-positive, then calculate the value using the Linux approach.

Tests: fast/forms/text-control-intrinsic-widths.html

fast/forms/textarea-metrics.html
svg/custom/svg-fonts-in-text-controls.html

  • css/html4.css:
  • css/themeWin.css:
  • platform/graphics/SimpleFontData.cpp: (WebCore::SimpleFontData::SimpleFontData): (WebCore::SimpleFontData::initCharWidths):
  • platform/graphics/SimpleFontData.h: (WebCore::SimpleFontData::maxCharWidth): (WebCore::SimpleFontData::avgCharWidth):
  • platform/graphics/chromium/SimpleFontDataChromiumWin.cpp: (WebCore::SimpleFontData::platformCharWidthInit):
  • platform/graphics/chromium/SimpleFontDataLinux.cpp: (WebCore::SimpleFontData::platformCharWidthInit):
  • platform/graphics/gtk/SimpleFontDataGtk.cpp: (WebCore::SimpleFontData::platformCharWidthInit):
  • platform/graphics/gtk/SimpleFontDataPango.cpp: (WebCore::SimpleFontData::platformCharWidthInit):
  • platform/graphics/mac/SimpleFontDataMac.mm: (WebCore::SimpleFontData::platformCharWidthInit):
  • platform/graphics/qt/SimpleFontDataQt.cpp: (WebCore::SimpleFontData::platformCharWidthInit):
  • platform/graphics/win/SimpleFontDataCGWin.cpp: (WebCore::SimpleFontData::platformCharWidthInit):
  • platform/graphics/win/SimpleFontDataCairoWin.cpp: (WebCore::SimpleFontData::platformInit): (WebCore::SimpleFontData::platformCharWidthInit):
  • platform/graphics/win/SimpleFontDataWin.cpp: (WebCore::SimpleFontData::initGDIFont):
  • platform/graphics/wx/SimpleFontDataWx.cpp: (WebCore::SimpleFontData::platformCharWidthInit):
  • rendering/RenderTextControl.cpp: (WebCore::RenderTextControl::calcPrefWidths):
  • rendering/RenderTextControlMultiLine.cpp: (WebCore::RenderTextControlMultiLine::createInnerTextStyle):
  • rendering/RenderTextControlSingleLine.cpp: (WebCore::RenderTextControlSingleLine::preferredContentWidth):
1:25 PM Changeset in webkit [43006] by oliver@apple.com
  • 5 edits in trunk

Crash in profiler due to incorrect assuming displayName would be a string.

Reviewed by Steve Falkenburg

Fixed by adding a type guard.

1:23 PM Changeset in webkit [43005] by beidson@apple.com
  • 2 edits in trunk/WebCore

2009-04-29 Brady Eidson <​beidson@apple.com>

Reviewed by Darin Adler.

  • bindings/objc/DOMCSS.mm: (kitClass): Added CSS_INITIAL to the switch statement, and changed to use the WebCore type and not the binding type.
1:21 PM Changeset in webkit [43004] by eric@webkit.org
  • 2 edits in trunk/WebCore

2009-04-29 John Abd-El-Malek <​jam@google.com>

Reviewed by Dimitri Glazkov.

Reverted my previous change to add resetChromiumPluginCache().
​https://bugs.webkit.org/show_bug.cgi?id=25318

  • plugins/chromium/PluginDataChromium.cpp:
1:21 PM Changeset in webkit [43003] by beidson@apple.com
  • 2 edits in trunk/WebCore

2009-04-29 Brady Eidson <​beidson@apple.com>

Reviewed by Darin Adler

<rdar://problem/6573742> - Problem dragging standalone images from Safari to Mail

Roll out trac.webkit.org/changeset/35867 which fixed <rdar://problem/6153432>

Cloned <rdar://problem/6153432> to <rdar://problem/6839881> to find a better fix for that Tiger Mail bug.

  • loader/DocumentLoader.cpp: (WebCore::DocumentLoader::subresource): Remove the preload referenced check.
1:14 PM Changeset in webkit [43002] by eric@webkit.org
  • 3 edits in trunk/WebCore

2009-04-29 Alpha Lam <​hclam@chromium.org>

Reviewed by Dimitri Glazkov.

​https://bugs.webkit.org/show_bug.cgi?id=25430

Provide style sheet for UI controls of media elements for Chromium port.

  • rendering/RenderThemeChromiumWin.cpp: (WebCore::RenderThemeChromiumWin::extraMediaControlsStyleSheet):
1:12 PM Changeset in webkit [43001] by eric@webkit.org
  • 3 edits
    1 add in trunk/WebCore

2009-04-29 John Abd-El-Malek <​jam@chromium.org>

Reviewed by Darin Adler.

Expose sudden termination to Chromium port.
​https://bugs.webkit.org/show_bug.cgi?id=25457

  • platform/SuddenTermination.h:
  • platform/chromium/ChromiumBridge.h:
  • platform/chromium/SuddenTerminationChromium.cpp: Added. (WebCore::disableSuddenTermination): (WebCore::enableSuddenTermination):
1:00 PM Changeset in webkit [43000] by weinig@apple.com
  • 2 edits in trunk/WebCore

2009-04-29 Sam Weinig <​sam@webkit.org>

Reviewed by Dimitri Glazkov.

Remove unused EventListeners.

  • page/DOMWindow.idl:
11:38 AM Changeset in webkit [42999] by hyatt@apple.com
  • 2 edits in trunk/WebKit/mac

2009-04-29 David Hyatt <​hyatt@apple.com>

Reviewed by John Sullivan.

Fix for <rdar://problem/6835573>, Find Banner turns invisible when WebView is resized. Make sure
not to resize the interior views of a WebView in response to its bounds changing when not using
viewless WebKit. Auto-resizing rules were already in place to handle size adjustments for us.
Just mark as needing layout and do nothing else.

This does mean viewless WebKit is broken with the Find Banner, and that will likely require a
Safari change (using a new API that will enable clients to define the edges of the content area as offsets
from the sides of the WebView).

  • WebView/WebView.mm: (-[WebView _boundsChanged]):
10:41 AM Changeset in webkit [42998] by eric.carlson@apple.com
  • 2 edits in trunk/LayoutTests

2009-04-29 Eric Carlson <​eric.carlson@apple.com>

Disable media/video-zoom-controls.html on Windows for now.

  • platform/win/Skipped: add media/video-zoom-controls.html.
10:38 AM Changeset in webkit [42997] by timothy@apple.com
  • 2 edits in trunk/WebCore

Reveal current execution line once SourceFrame content is loaded.

​https://bugs.webkit.org/show_bug.cgi?id=25448

Reviewed by Timothy Hatcher.

  • inspector/front-end/SourceFrame.js: (WebInspector.SourceFrame.prototype._loaded):
10:27 AM Changeset in webkit [42996] by ariya@webkit.org
  • 4 edits in trunk

WebCore:

2009-04-29 Ariya Hidayat <​ariya.hidayat@nokia.com>

Reviewed by Simon Fraser.

[Qt] Initialize GraphicsContext's and ImageBuffer's QPainter to match
the default values of canvas attributes.

  • platform/graphics/qt/ImageBufferQt.cpp: (WebCore::ImageBufferData::ImageBufferData):

LayoutTests:

2009-04-29 Ariya Hidayat <​ariya.hidayat@nokia.com>

Reviewed by Simon Fraser.

Updated expected results after Qt's GraphicsContext fixes.

  • platform/qt/fast/canvas/set-colors-expected.txt:
7:56 AM QtWebKitTodo edited by ariya@webkit.org
(diff)
6:55 AM Changeset in webkit [42995] by ariya@webkit.org
  • 4 edits in trunk/WebKit/qt

2009-04-29 Ariya Hidayat <​ariya.hidayat@nokia.com>

Reviewed by Simon Hausmann.

Implement QWebElement::evaluateScript.

  • Api/qwebelement.cpp: (setupScriptContext): (QWebElement::evaluateScript):
  • Api/qwebelement.h:
  • tests/qwebelement/tst_qwebelement.cpp: (tst_QWebElement::evaluateScript):
6:46 AM Changeset in webkit [42994] by Simon Hausmann
  • 7 edits in trunk/WebKit/qt

2009-04-29 Simon Hausmann <​simon.hausmann@nokia.com>

Reviewed by Ariya Hidayat.

Replaced QWebElementCollection with QList<QWebElement>.

3:20 AM QtWebKitTodo edited by vestbo@webkit.org
(diff)
3:09 AM QtWebKitTodo edited by vestbo@webkit.org
(diff)

Apr 28, 2009:

11:49 PM QtWebKitContrib edited by Simon Hausmann
(diff)
11:38 PM Changeset in webkit [42993] by Simon Hausmann
  • 2 edits in trunk/WebCore

Fix the Qt build

11:31 PM Changeset in webkit [42992] by ap@webkit.org
  • 2 edits in trunk/LayoutTests

Fix the test for <​https://bugs.webkit.org/show_bug.cgi?id=25420> - I broke it when
experimenting with other aspects of the issue, so it didn't check what it should have checked.

  • http/tests/xmlhttprequest/detaching-frame-2.html:
11:19 PM Changeset in webkit [42991] by ggaren@apple.com
  • 2 edits in trunk/JavaScriptGlue

2009-04-28 Geoffrey Garen <​ggaren@apple.com>

Rubber stamped by Beth Dakin.


Missed one.

  • UserObjectImp.cpp: (UserObjectImp::callAsFunction):
11:08 PM Changeset in webkit [42990] by ggaren@apple.com
  • 2 edits in trunk/WebCore

2009-04-28 Geoffrey Garen <​ggaren@apple.com>

Rubber stamped by Beth Dakin.


Missed one.

  • bindings/scripts/CodeGeneratorJS.pm:
11:07 PM Changeset in webkit [42989] by ggaren@apple.com
  • 88 edits in trunk

JavaScriptCore:

2009-04-28 Geoffrey Garen <​ggaren@apple.com>

Rubber stamped by Beth Dakin.


Removed scaffolding supporting dynamically converting between 32bit and
64bit value representations.

  • API/JSCallbackConstructor.cpp: (JSC::constructJSCallback):
  • API/JSCallbackFunction.cpp: (JSC::JSCallbackFunction::call):
  • API/JSCallbackObjectFunctions.h: (JSC::::construct): (JSC::::call):
  • bytecode/CodeBlock.cpp: (JSC::CodeBlock::dump):
  • bytecode/CodeBlock.h: (JSC::CodeBlock::getConstant):
  • bytecompiler/BytecodeGenerator.cpp: (JSC::BytecodeGenerator::emitEqualityOp):
  • interpreter/CallFrame.cpp: (JSC::CallFrame::thisValue):
  • interpreter/Interpreter.cpp: (JSC::Interpreter::callEval): (JSC::Interpreter::throwException): (JSC::Interpreter::createExceptionScope): (JSC::Interpreter::privateExecute): (JSC::Interpreter::retrieveArguments):
  • interpreter/Register.h: (JSC::Register::): (JSC::Register::Register): (JSC::Register::jsValue): (JSC::Register::marked): (JSC::Register::mark): (JSC::Register::i): (JSC::Register::activation): (JSC::Register::arguments): (JSC::Register::callFrame): (JSC::Register::codeBlock): (JSC::Register::function): (JSC::Register::propertyNameIterator): (JSC::Register::scopeChain): (JSC::Register::vPC):
  • jit/JITStubs.cpp: (JSC::JITStubs::cti_op_call_NotJSFunction): (JSC::JITStubs::cti_op_load_varargs): (JSC::JITStubs::cti_op_call_eval):
  • jsc.cpp: (functionPrint): (functionDebug): (functionRun): (functionLoad):
  • runtime/ArgList.h: (JSC::ArgList::at):
  • runtime/Arguments.cpp: (JSC::Arguments::copyToRegisters): (JSC::Arguments::fillArgList): (JSC::Arguments::getOwnPropertySlot):
  • runtime/ArrayConstructor.cpp: (JSC::constructArrayWithSizeQuirk):
  • runtime/ArrayPrototype.cpp: (JSC::arrayProtoFuncJoin): (JSC::arrayProtoFuncConcat): (JSC::arrayProtoFuncPush): (JSC::arrayProtoFuncSlice): (JSC::arrayProtoFuncSort): (JSC::arrayProtoFuncSplice): (JSC::arrayProtoFuncUnShift): (JSC::arrayProtoFuncFilter): (JSC::arrayProtoFuncMap): (JSC::arrayProtoFuncEvery): (JSC::arrayProtoFuncForEach): (JSC::arrayProtoFuncSome): (JSC::arrayProtoFuncReduce): (JSC::arrayProtoFuncReduceRight): (JSC::arrayProtoFuncIndexOf): (JSC::arrayProtoFuncLastIndexOf):
  • runtime/BooleanConstructor.cpp: (JSC::constructBoolean): (JSC::callBooleanConstructor):
  • runtime/DateConstructor.cpp: (JSC::constructDate): (JSC::dateParse): (JSC::dateUTC):
  • runtime/DatePrototype.cpp: (JSC::formatLocaleDate): (JSC::fillStructuresUsingTimeArgs): (JSC::fillStructuresUsingDateArgs): (JSC::dateProtoFuncSetTime): (JSC::dateProtoFuncSetYear):
  • runtime/ErrorConstructor.cpp: (JSC::constructError):
  • runtime/FunctionConstructor.cpp: (JSC::constructFunction):
  • runtime/FunctionPrototype.cpp: (JSC::functionProtoFuncApply): (JSC::functionProtoFuncCall):
  • runtime/JSArray.cpp: (JSC::JSArray::JSArray): (JSC::constructArray):
  • runtime/JSArray.h:
  • runtime/JSGlobalObjectFunctions.cpp: (JSC::encode): (JSC::decode): (JSC::globalFuncEval): (JSC::globalFuncParseInt): (JSC::globalFuncParseFloat): (JSC::globalFuncIsNaN): (JSC::globalFuncIsFinite): (JSC::globalFuncEscape): (JSC::globalFuncUnescape): (JSC::globalFuncJSCPrint):
  • runtime/MathObject.cpp: (JSC::mathProtoFuncAbs): (JSC::mathProtoFuncACos): (JSC::mathProtoFuncASin): (JSC::mathProtoFuncATan): (JSC::mathProtoFuncATan2): (JSC::mathProtoFuncCeil): (JSC::mathProtoFuncCos): (JSC::mathProtoFuncExp): (JSC::mathProtoFuncFloor): (JSC::mathProtoFuncLog): (JSC::mathProtoFuncMax): (JSC::mathProtoFuncMin): (JSC::mathProtoFuncPow): (JSC::mathProtoFuncRound): (JSC::mathProtoFuncSin): (JSC::mathProtoFuncSqrt): (JSC::mathProtoFuncTan):
  • runtime/NativeErrorConstructor.cpp: (JSC::NativeErrorConstructor::construct):
  • runtime/NumberConstructor.cpp: (JSC::constructWithNumberConstructor): (JSC::callNumberConstructor):
  • runtime/NumberPrototype.cpp: (JSC::numberProtoFuncToString): (JSC::numberProtoFuncToFixed): (JSC::numberProtoFuncToExponential): (JSC::numberProtoFuncToPrecision):
  • runtime/ObjectConstructor.cpp: (JSC::constructObject):
  • runtime/ObjectPrototype.cpp: (JSC::objectProtoFuncHasOwnProperty): (JSC::objectProtoFuncIsPrototypeOf): (JSC::objectProtoFuncDefineGetter): (JSC::objectProtoFuncDefineSetter): (JSC::objectProtoFuncLookupGetter): (JSC::objectProtoFuncLookupSetter): (JSC::objectProtoFuncPropertyIsEnumerable):
  • runtime/PropertySlot.h: (JSC::PropertySlot::getValue):
  • runtime/RegExpConstructor.cpp: (JSC::constructRegExp):
  • runtime/RegExpObject.cpp: (JSC::RegExpObject::match):
  • runtime/RegExpPrototype.cpp: (JSC::regExpProtoFuncCompile):
  • runtime/StringConstructor.cpp: (JSC::stringFromCharCodeSlowCase): (JSC::stringFromCharCode): (JSC::constructWithStringConstructor): (JSC::callStringConstructor):
  • runtime/StringPrototype.cpp: (JSC::stringProtoFuncReplace): (JSC::stringProtoFuncCharAt): (JSC::stringProtoFuncCharCodeAt): (JSC::stringProtoFuncConcat): (JSC::stringProtoFuncIndexOf): (JSC::stringProtoFuncLastIndexOf): (JSC::stringProtoFuncMatch): (JSC::stringProtoFuncSearch): (JSC::stringProtoFuncSlice): (JSC::stringProtoFuncSplit): (JSC::stringProtoFuncSubstr): (JSC::stringProtoFuncSubstring): (JSC::stringProtoFuncLocaleCompare): (JSC::stringProtoFuncFontcolor): (JSC::stringProtoFuncFontsize): (JSC::stringProtoFuncAnchor): (JSC::stringProtoFuncLink):

WebCore:

2009-04-28 Geoffrey Garen <​ggaren@apple.com>

Rubber stamped by Beth Dakin.


Removed scaffolding supporting dynamically converting between 32bit and
64bit value representations.

  • bindings/js/JSAudioConstructor.cpp: (WebCore::constructAudio):
  • bindings/js/JSCanvasRenderingContext2DCustom.cpp: (WebCore::JSCanvasRenderingContext2D::setFillColor): (WebCore::JSCanvasRenderingContext2D::setStrokeColor): (WebCore::JSCanvasRenderingContext2D::strokeRect): (WebCore::JSCanvasRenderingContext2D::drawImage): (WebCore::JSCanvasRenderingContext2D::drawImageFromRect): (WebCore::JSCanvasRenderingContext2D::setShadow): (WebCore::JSCanvasRenderingContext2D::createPattern): (WebCore::JSCanvasRenderingContext2D::putImageData): (WebCore::JSCanvasRenderingContext2D::fillText): (WebCore::JSCanvasRenderingContext2D::strokeText):
  • bindings/js/JSClipboardCustom.cpp: (WebCore::JSClipboard::clearData): (WebCore::JSClipboard::getData): (WebCore::JSClipboard::setData): (WebCore::JSClipboard::setDragImage):
  • bindings/js/JSDOMApplicationCacheCustom.cpp: (WebCore::JSDOMApplicationCache::hasItem): (WebCore::JSDOMApplicationCache::add): (WebCore::JSDOMApplicationCache::remove): (WebCore::JSDOMApplicationCache::addEventListener): (WebCore::JSDOMApplicationCache::removeEventListener):
  • bindings/js/JSDOMStringListCustom.cpp: (WebCore::JSDOMStringList::item):
  • bindings/js/JSDOMWindowCustom.cpp: (WebCore::JSDOMWindow::open): (WebCore::JSDOMWindow::showModalDialog): (WebCore::JSDOMWindow::postMessage): (WebCore::JSDOMWindow::setTimeout): (WebCore::JSDOMWindow::setInterval): (WebCore::JSDOMWindow::atob): (WebCore::JSDOMWindow::btoa): (WebCore::JSDOMWindow::addEventListener): (WebCore::JSDOMWindow::removeEventListener):
  • bindings/js/JSDatabaseCustom.cpp: (WebCore::JSDatabase::changeVersion): (WebCore::JSDatabase::transaction):
  • bindings/js/JSElementCustom.cpp: (WebCore::JSElement::setAttribute): (WebCore::JSElement::setAttributeNode): (WebCore::JSElement::setAttributeNS): (WebCore::JSElement::setAttributeNodeNS):
  • bindings/js/JSGeolocationCustom.cpp: (WebCore::JSGeolocation::getCurrentPosition): (WebCore::JSGeolocation::watchPosition):
  • bindings/js/JSHTMLCollectionCustom.cpp: (WebCore::callHTMLCollection): (WebCore::JSHTMLCollection::item): (WebCore::JSHTMLCollection::namedItem):
  • bindings/js/JSHTMLDocumentCustom.cpp: (WebCore::documentWrite):
  • bindings/js/JSHTMLInputElementCustom.cpp: (WebCore::JSHTMLInputElement::setSelectionRange):
  • bindings/js/JSHTMLOptionsCollectionCustom.cpp: (WebCore::JSHTMLOptionsCollection::add):
  • bindings/js/JSHTMLSelectElementCustom.cpp: (WebCore::JSHTMLSelectElement::remove):
  • bindings/js/JSImageConstructor.cpp: (WebCore::constructImage):
  • bindings/js/JSInspectorControllerCustom.cpp: (WebCore::JSInspectorController::highlightDOMNode): (WebCore::JSInspectorController::addResourceSourceToFrame): (WebCore::JSInspectorController::addSourceToFrame): (WebCore::JSInspectorController::getResourceDocumentNode): (WebCore::JSInspectorController::search): (WebCore::JSInspectorController::databaseTableNames): (WebCore::JSInspectorController::setting): (WebCore::JSInspectorController::setSetting): (WebCore::JSInspectorController::wrapCallback):
  • bindings/js/JSJavaScriptCallFrameCustom.cpp: (WebCore::JSJavaScriptCallFrame::evaluate):
  • bindings/js/JSLocationCustom.cpp: (WebCore::JSLocation::replace): (WebCore::JSLocation::assign):
  • bindings/js/JSMessagePortCustom.cpp: (WebCore::JSMessagePort::startConversation): (WebCore::JSMessagePort::addEventListener): (WebCore::JSMessagePort::removeEventListener):
  • bindings/js/JSNodeCustom.cpp: (WebCore::JSNode::insertBefore): (WebCore::JSNode::replaceChild): (WebCore::JSNode::removeChild): (WebCore::JSNode::appendChild): (WebCore::JSNode::addEventListener): (WebCore::JSNode::removeEventListener):
  • bindings/js/JSNodeFilterCustom.cpp: (WebCore::JSNodeFilter::acceptNode):
  • bindings/js/JSNodeListCustom.cpp: (WebCore::callNodeList):
  • bindings/js/JSOptionConstructor.cpp: (WebCore::constructHTMLOptionElement):
  • bindings/js/JSQuarantinedObjectWrapper.cpp: (WebCore::JSQuarantinedObjectWrapper::construct): (WebCore::JSQuarantinedObjectWrapper::call):
  • bindings/js/JSSQLResultSetRowListCustom.cpp: (WebCore::JSSQLResultSetRowList::item):
  • bindings/js/JSSQLTransactionCustom.cpp: (WebCore::JSSQLTransaction::executeSql):
  • bindings/js/JSSVGElementInstanceCustom.cpp: (WebCore::JSSVGElementInstance::addEventListener): (WebCore::JSSVGElementInstance::removeEventListener):
  • bindings/js/JSSVGLengthCustom.cpp: (WebCore::JSSVGLength::convertToSpecifiedUnits):
  • bindings/js/JSSVGMatrixCustom.cpp: (WebCore::JSSVGMatrix::rotateFromVector):
  • bindings/js/JSSVGPathSegListCustom.cpp: (WebCore::JSSVGPathSegList::initialize): (WebCore::JSSVGPathSegList::getItem): (WebCore::JSSVGPathSegList::insertItemBefore): (WebCore::JSSVGPathSegList::replaceItem): (WebCore::JSSVGPathSegList::removeItem): (WebCore::JSSVGPathSegList::appendItem):
  • bindings/js/JSSVGPointListCustom.cpp: (WebCore::JSSVGPointList::initialize): (WebCore::JSSVGPointList::getItem): (WebCore::JSSVGPointList::insertItemBefore): (WebCore::JSSVGPointList::replaceItem): (WebCore::JSSVGPointList::removeItem): (WebCore::JSSVGPointList::appendItem):
  • bindings/js/JSSVGTransformListCustom.cpp: (WebCore::JSSVGTransformList::initialize): (WebCore::JSSVGTransformList::getItem): (WebCore::JSSVGTransformList::insertItemBefore): (WebCore::JSSVGTransformList::replaceItem): (WebCore::JSSVGTransformList::removeItem): (WebCore::JSSVGTransformList::appendItem):
  • bindings/js/JSWebKitCSSMatrixConstructor.cpp: (WebCore::constructWebKitCSSMatrix):
  • bindings/js/JSWebKitPointConstructor.cpp: (WebCore::constructWebKitPoint):
  • bindings/js/JSWorkerConstructor.cpp: (WebCore::constructWorker):
  • bindings/js/JSWorkerContextCustom.cpp: (WebCore::JSWorkerContext::importScripts): (WebCore::JSWorkerContext::addEventListener): (WebCore::JSWorkerContext::removeEventListener): (WebCore::JSWorkerContext::setTimeout): (WebCore::JSWorkerContext::setInterval):
  • bindings/js/JSWorkerCustom.cpp: (WebCore::JSWorker::addEventListener): (WebCore::JSWorker::removeEventListener):
  • bindings/js/JSXMLHttpRequestCustom.cpp: (WebCore::JSXMLHttpRequest::open): (WebCore::JSXMLHttpRequest::setRequestHeader): (WebCore::JSXMLHttpRequest::send): (WebCore::JSXMLHttpRequest::getResponseHeader): (WebCore::JSXMLHttpRequest::overrideMimeType): (WebCore::JSXMLHttpRequest::addEventListener): (WebCore::JSXMLHttpRequest::removeEventListener):
  • bindings/js/JSXMLHttpRequestUploadCustom.cpp: (WebCore::JSXMLHttpRequestUpload::addEventListener): (WebCore::JSXMLHttpRequestUpload::removeEventListener):
  • bindings/js/JSXSLTProcessorCustom.cpp: (WebCore::JSXSLTProcessor::importStylesheet): (WebCore::JSXSLTProcessor::transformToFragment): (WebCore::JSXSLTProcessor::transformToDocument): (WebCore::JSXSLTProcessor::setParameter): (WebCore::JSXSLTProcessor::getParameter): (WebCore::JSXSLTProcessor::removeParameter):
  • bindings/js/ScheduledAction.cpp: (WebCore::ScheduledAction::create): (WebCore::ScheduledAction::ScheduledAction):
  • bindings/js/ScheduledAction.h:
  • bindings/js/ScriptCallFrame.cpp: (WebCore::ScriptCallFrame::ScriptCallFrame):
  • bindings/js/ScriptCallFrame.h:
  • bindings/js/ScriptCallStack.cpp: (WebCore::ScriptCallStack::ScriptCallStack): (WebCore::ScriptCallStack::initialize):
  • bridge/c/c_instance.cpp: (JSC::Bindings::CInstance::invokeMethod): (JSC::Bindings::CInstance::invokeDefaultMethod): (JSC::Bindings::CInstance::invokeConstruct):
  • bridge/jni/jni_instance.cpp: (JavaInstance::invokeMethod):
  • bridge/objc/objc_instance.mm: (ObjcInstance::invokeMethod): (ObjcInstance::invokeDefaultMethod):

WebKit/mac:

2009-04-28 Geoffrey Garen <​ggaren@apple.com>

Rubber stamped by Beth Dakin.


Removed scaffolding supporting dynamically converting between 32bit and
64bit value representations.

  • Plugins/Hosted/NetscapePluginInstanceProxy.mm: (WebKit::NetscapePluginInstanceProxy::marshalValues):
10:56 PM Changeset in webkit [42988] by ddkilzer@apple.com
  • 2 edits in trunk/JavaScriptCore

A little more hardening for UString

Reviewed by Maciej Stachowiak.

Revised fix for <rdar://problem/5861045> in r42644.

  • runtime/UString.cpp: (JSC::newCapacityWithOverflowCheck): Added. (JSC::concatenate): Used newCapacityWithOverflowCheck(). (JSC::UString::append): Ditto.
10:52 PM Changeset in webkit [42987] by ddkilzer@apple.com
  • 9 edits in trunk

2009-04-28 David Carson <​dacarson@apple.com>

Reviewed by David Hyatt.

Restore alignment to device pixel boundaries.
​https://bugs.webkit.org/show_bug.cgi?id=25458

Adjust the adjusted destination rect to be device pixel aligned.

  • platform/graphics/cg/ImageCG.cpp: (WebCore::BitmapImage::draw):

2009-04-28 David Carson <​dacarson@apple.com>

Reviewed by David Kilzer.

Restore alignment to device pixel boundaries.
​https://bugs.webkit.org/show_bug.cgi?id=25458

Updated test results with progressions.

  • platform/mac/svg/W3C-SVG-1.1/render-groups-03-t-expected.checksum:
  • platform/mac/svg/W3C-SVG-1.1/render-groups-03-t-expected.png: Yin-yang image shifted slightly to pixel boundaries.
  • platform/mac/svg/custom/focus-ring-expected.checksum:
  • platform/mac/svg/custom/focus-ring-expected.png: Focus rings drawn around rotated "focus text" and checkered images shifted slightly to pixel boundaries.
  • platform/mac/svg/custom/image-small-width-height-expected.checksum:
  • platform/mac/svg/custom/image-small-width-height-expected.png: Checkered images shifted slightly to pixel boundaries.
10:49 PM Changeset in webkit [42986] by ddkilzer@apple.com
  • 1 edit
    10 adds in trunk/LayoutTests

Added missing pixel test results.

  • platform/mac/fast/css-generated-content/beforeAfter-interdocument-expected.checksum: Added.
  • platform/mac/fast/css-generated-content/beforeAfter-interdocument-expected.png: Added.
  • platform/mac/fast/table/cell-coalescing-expected.checksum: Added.
  • platform/mac/fast/table/cell-coalescing-expected.png: Added.
  • platform/mac/webarchive/adopt-attribute-styled-body-webarchive-expected.checksum: Added.
  • platform/mac/webarchive/adopt-attribute-styled-body-webarchive-expected.png: Added.
  • platform/mac/webarchive/adopt-attribute-styled-node-webarchive-expected.checksum: Added.
  • platform/mac/webarchive/adopt-attribute-styled-node-webarchive-expected.png: Added.
  • platform/mac/webarchive/adopt-inline-styled-node-webarchive-expected.checksum: Added.
  • platform/mac/webarchive/adopt-inline-styled-node-webarchive-expected.png: Added.
10:39 PM Changeset in webkit [42985] by weinig@apple.com
  • 5 edits in trunk/WebCore

2009-04-28 Sam Weinig <​sam@webkit.org>

Reviewed by Anders Carlsson.

Move unimplemented captureEvents and releaseEvents from JSDOMWindow
to DOMWindow.

  • bindings/js/JSDOMWindowCustom.cpp:
  • page/DOMWindow.cpp: (WebCore::DOMWindow::captureEvents): (WebCore::DOMWindow::releaseEvents):
  • page/DOMWindow.h:
  • page/DOMWindow.idl:
10:30 PM Changeset in webkit [42984] by ap@webkit.org
  • 2 edits in trunk

Correcting ChangeLogs - Sam talked to me about the patch, but it was Darin who reviewed it!

10:25 PM Changeset in webkit [42983] by ap@webkit.org
  • 9 edits
    3 adds in trunk

Reviewed by Sam Weinig.

​https://bugs.webkit.org/show_bug.cgi?id=25420
<rdar://problem/6829570> REGRESSION: XMLHttpRequest allows loading from another origin

Test: http/tests/xmlhttprequest/detaching-frame-2.html

This was caused by faulty DOMWindow::document(), which could return a new document from
the window's frame after navigation.

  • bindings/js/JSDOMWindowCustom.h: (WebCore::JSDOMWindowBase::allowsAccessFromPrivate): Removed an obsolete check that allowed access when document was null. Contrary to what a comment said, that can happen for a window that is no longer in frame, not to one whose document is not constructed yet.
  • bindings/js/JSXMLHttpRequestConstructor.cpp: (WebCore::constructXMLHttpRequest): Bail out if context was not found. This currently happens due to a shortcoming in DOMWindow::document() - when it is fixed, the XMLHttpRequest object in included regression test will be constructed successfully, but won't be sent, because its context will be frameless.
  • page/DOMWindow.cpp: (WebCore::DOMWindow::document): Check that the window in frame hasn't been replaced yet. Added FIXME comments about how this may be better fixed in the future.
  • bindings/js/JSAudioConstructor.cpp: (WebCore::JSAudioConstructor::document): (WebCore::constructAudio):
  • bindings/js/JSImageConstructor.cpp: (WebCore::JSImageConstructor::document): (WebCore::constructImage):
  • bindings/js/JSMessageChannelConstructor.cpp: (WebCore::JSMessageChannelConstructor::construct):
  • bindings/js/JSOptionConstructor.cpp: (WebCore::JSOptionConstructor::document): (WebCore::constructHTMLOptionElement): Make matching changes to other constructors that hold a reference to global object.
9:54 PM Changeset in webkit [42982] by oliver@apple.com
  • 2 edits in trunk/JavaScriptCore

Bring back r42969, this time with correct codegen

Reviewed by Gavin Barraclough.

Add logic to the codegen for right shift to avoid jumping to a helper function
when shifting a small floating point value.

9:22 PM Changeset in webkit [42981] by kov@webkit.org
  • 1 copy in releases/WebKitGTK/webkit-1.1.6

Tagging 1.1.6.

9:02 PM Changeset in webkit [42980] by kevino@webkit.org
  • 6 edits in trunk

wxMSW build fix. Switch JSCore build back to static.

8:03 PM Changeset in webkit [42979] by ddkilzer@apple.com
  • 2 edits in trunk/WebKitTools

2009-04-28 Pierre d'Herbemont <​pdherbemont@apple.com>

Reviewed by David Kilzer.

​https://bugs.webkit.org/show_bug.cgi?id=25462

Make sure "--pixel --add-platform-exceptions" produces platform
specific pixel test results.

  • Scripts/run-webkit-tests: Support "--pixel --add-platform-exceptions"
6:24 PM Changeset in webkit [42978] by oliver@apple.com
  • 2 edits in trunk/JavaScriptCore

Roll out r42969, due to hangs in build bot.

6:00 PM Changeset in webkit [42977] by eric@webkit.org
  • 1 edit
    5 adds in trunk/LayoutTests

Reviewed by Simon Fraser.

Add a couple table hit tests
​https://bugs.webkit.org/show_bug.cgi?id=21892

  • svg/hittest/svg-inside-display-table-expected.txt: Added.
  • svg/hittest/svg-inside-display-table.xhtml: Added.
  • svg/hittest/svg-inside-table-expected.txt: Added.
  • svg/hittest/svg-inside-table.xhtml: Added.
5:38 PM Changeset in webkit [42976] by oliver@apple.com
  • 3 edits in trunk/JavaScriptCore

Improve performance of string indexing

Reviewed by Geoff Garen

Add a cti_get_by_val_string function to specialise indexing into a string object.
This gives us a slight performance win on a number of string tests.

5:29 PM Changeset in webkit [42975] by eric.carlson@apple.com
  • 3 edits in trunk

2009-04-28 Pierre d'Herbemont <​pdherbemont@apple.com>

Reviewed by Simon Fraser.

<rdar://problem/6834830>

Make sure we cover the two possible values reported by event.total that are playback engine
specific.

  • media/progress-event-total-expected.txt: Match the new test.
  • media/progress-event-total.html: Test the two values.
5:17 PM Changeset in webkit [42974] by timothy@apple.com
  • 7 edits in trunk/WebCore

Rename -[DOMRange lineBoxRects] to -[DOMRange textRects] and change how it
collects the individual rects, making sure to only include RenderText.

<rdar://problem/6810061>

Reviewed by Sam Weinig.

  • bindings/objc/DOM.mm: (-[DOMNode textRects]): Added. Make a Range and call textRects. (-[DOMNode lineBoxRects]): Call textRects method. (-[DOMRange textRects]): Call Range::textRects. (-[DOMRange lineBoxRects]): Call textRects method.
  • bindings/objc/DOMPrivate.h: Add the new methods and a comment about lineBoxRects being deprecated.
  • dom/Range.cpp: (WebCore::Range::boundingBox): Call textRects (renamed from addLineBoxRects). (WebCore::Range::textRects): Renamed from addLineBoxRects. Iterate over the nodes instead of the RenderObjects to correctly account for offsets. Also only call absoluteRectsForRange on RenderText.
  • dom/Range.h: Renamed addLineBoxRects to textRects.
  • page/Frame.cpp: (WebCore::Frame::selectionTextRects): Call textRects (renamed from addLineBoxRects).
  • rendering/RenderObject.cpp: (WebCore::RenderObject::absoluteRectsForRange): Remove if conditions that made this function very specific for the lineBoxRects API. These functions are still used by the InspectorController, and this change improves what the Inspector shows. (WebCore::RenderObject::absoluteQuadsForRange): Ditto.
5:11 PM Changeset in webkit [42973] by timothy@apple.com
  • 26 edits in trunk/WebCore

Remove the topLevel boolean argument from absolute{Rects,Quads}.
This argument was default to true and no one ever passed false.

Reviewed by Sam Weinig.

  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::absoluteRects): (WebCore::RenderBlock::absoluteQuads):
  • rendering/RenderBlock.h:
  • rendering/RenderBox.cpp: (WebCore::RenderBox::absoluteRects): (WebCore::RenderBox::absoluteQuads):
  • rendering/RenderBox.h:
  • rendering/RenderInline.cpp: (WebCore::RenderInline::absoluteRects): (WebCore::RenderInline::absoluteQuads):
  • rendering/RenderInline.h:
  • rendering/RenderObject.h: (WebCore::RenderObject::absoluteRects): (WebCore::RenderObject::absoluteQuads):
  • rendering/RenderSVGHiddenContainer.cpp: (WebCore::RenderSVGHiddenContainer::absoluteRects): (WebCore::RenderSVGHiddenContainer::absoluteQuads):
  • rendering/RenderSVGHiddenContainer.h:
  • rendering/RenderSVGImage.cpp: (WebCore::RenderSVGImage::absoluteRects): (WebCore::RenderSVGImage::absoluteQuads):
  • rendering/RenderSVGImage.h:
  • rendering/RenderSVGInlineText.cpp: (WebCore::RenderSVGInlineText::absoluteRects): (WebCore::RenderSVGInlineText::absoluteQuads):
  • rendering/RenderSVGInlineText.h:
  • rendering/RenderSVGModelObject.cpp: (WebCore::RenderSVGModelObject::absoluteRects): (WebCore::RenderSVGModelObject::absoluteQuads):
  • rendering/RenderSVGModelObject.h:
  • rendering/RenderSVGTSpan.cpp: (WebCore::RenderSVGTSpan::absoluteRects): (WebCore::RenderSVGTSpan::absoluteQuads):
  • rendering/RenderSVGTSpan.h:
  • rendering/RenderSVGText.cpp: (WebCore::RenderSVGText::absoluteRects): (WebCore::RenderSVGText::absoluteQuads):
  • rendering/RenderSVGText.h:
  • rendering/RenderSVGTextPath.cpp: (WebCore::RenderSVGTextPath::absoluteQuads):
  • rendering/RenderSVGTextPath.h:
  • rendering/RenderText.cpp: (WebCore::RenderText::absoluteRects):
  • rendering/RenderText.h:
  • rendering/RenderView.cpp: (WebCore::RenderView::absoluteRects): (WebCore::RenderView::absoluteQuads):
  • rendering/RenderView.h:
4:50 PM Changeset in webkit [42972] by eric.carlson@apple.com
  • 5 edits
    2 adds in trunk/WebCore

2009-04-28 Eric Carlson <​eric.carlson@apple.com>

Reviewed by Simon Fraser.

<rdar://problem/6794691> Media documents and <video controls> never show controls on Windows

RenderThemeWin doesn't implement the media element controller rendering methods, so media
controls stopped rendering when we switched from RenderThemeSafari. Rather than having copies
of the code in both places, the logic is in a new class that is called from both.

  • WebCore.vcproj/WebCore.vcproj: Add RenderMediaControls.cpp.
  • rendering/RenderMediaControls.cpp: Added. (WebCore::determineState): Translate renderer state to ThemeControlState. (WebCore::RenderMediaControls::adjustMediaSliderThumbSize): Adjust slider thumb. (WebCore::parentMediaElement): Return the HTMLMediaElement parent of a controller element. (WebCore::RenderMediaControls::paintMediaControlsPart): Paint a media controller part.
  • rendering/RenderMediaControls.h: Added.
  • rendering/RenderThemeSafari.cpp: (WebCore::RenderThemeSafari::paintSliderTrack): Remove the MediaSliderPart case, it is never called for the media slider. (WebCore::RenderThemeSafari::adjustSliderThumbSize): Call RenderMediaControls function. (WebCore::RenderThemeSafari::paintMediaFullscreenButton): Ditto. (WebCore::RenderThemeSafari::paintMediaMuteButton): Ditto. (WebCore::RenderThemeSafari::paintMediaPlayButton): Ditto. (WebCore::RenderThemeSafari::paintMediaSeekBackButton): Ditto. (WebCore::RenderThemeSafari::paintMediaSeekForwardButton): Ditto. (WebCore::RenderThemeSafari::paintMediaSliderTrack): Ditto. (WebCore::RenderThemeSafari::paintMediaSliderThumb): Ditto.
  • rendering/RenderThemeWin.cpp: (WebCore::RenderThemeWin::adjustSliderThumbSize): Ditto. (WebCore::RenderThemeWin::paintMediaFullscreenButton): Ditto. (WebCore::RenderThemeWin::paintMediaMuteButton): Ditto. (WebCore::RenderThemeWin::paintMediaPlayButton): Ditto. (WebCore::RenderThemeWin::paintMediaSeekBackButton): Ditto. (WebCore::RenderThemeWin::paintMediaSeekForwardButton): Ditto. (WebCore::RenderThemeWin::paintMediaSliderTrack): Ditto. (WebCore::RenderThemeWin::paintMediaSliderThumb): Ditto.
  • rendering/RenderThemeWin.h:
4:12 PM Changeset in webkit [42971] by Beth Dakin
  • 2 edits in trunk/WebCore

2009-04-28 Beth Dakin <Beth Dakin>

Reviewed by Sam Weinig.

Fix for <rdar://problem/6419515> REGRESSION (r31037): Positioned
images with % height are collapsed when printing

  • rendering/RenderBox.cpp: (WebCore::RenderBox::calcHeight): Make sure we don't ignore printing here!
3:36 PM Changeset in webkit [42970] by xan@webkit.org
  • 2 edits in trunk/JavaScriptCore

2009-04-28 Xan Lopez <​xlopez@igalia.com>

Unreviewed: fix distcheck build, add (even more) missing files to list.

  • GNUmakefile.am:
3:22 PM Changeset in webkit [42969] by oliver@apple.com
  • 2 edits in trunk/JavaScriptCore

Improve performance of right shifts of large or otherwise floating point values.

Reviewed by Geoff Garen.

Add logic to the codegen for right shift to avoid jumping to a helper function
when shifting a small floating point value.

3:17 PM Changeset in webkit [42968] by adele@apple.com
  • 4 edits
    4 adds in trunk

WebCore:

2009-04-28 Adele Peterson <​adele@apple.com>

Reviewed by Darin Adler.

Fix for <rdar://problem/6617298> Typing delete on an unquoted blank line unquotes the preceding, quoted blank line

Test: editing/deleting/type-delete-after-quote.html

When a selection is deleted that contains a whole number paragraphs plus a line break, we refrain from merging paragraphs after the delete,
since it is unclear to most users that such a selection actually ends at the start of the next paragraph. However, when a user hits delete
with a caret selection, they actually do expect the start of that paragraph to be merged into the paragraph before it. We can tell that
we're in this state because the TypingCommand creates the selection to delete but it doesn't change the endingSelection. So we can tell
that if we started with a caret selection, then we're not in this special case where we have to protect the user from unexpected behavior
from deleting a range they selected.

  • editing/DeleteSelectionCommand.cpp: (WebCore::DeleteSelectionCommand::initializePositionData):

LayoutTests:

2009-04-28 Adele Peterson <​adele@apple.com>

Reviewed by Darin Adler.

Test for <rdar://problem/6617298> Typing delete on an unquoted blank line unquotes the preceding, quoted blank line

  • editing/deleting/type-delete-after-quote.html: Added.
  • platform/mac/editing/deleting/delete-4038408-fix-expected.txt: This expected result change reflects a change in how the editing is done, but the document structure remains the same, and there are no visible changes to the result.
  • platform/mac/editing/deleting/type-delete-after-quote-expected.checksum: Added.
  • platform/mac/editing/deleting/type-delete-after-quote-expected.png: Added.
  • platform/mac/editing/deleting/type-delete-after-quote-expected.txt: Added.
3:15 PM Changeset in webkit [42967] by xan@webkit.org
  • 2 edits in trunk/JavaScriptCore

2009-04-28 Xan Lopez <​xlopez@igalia.com>

Unreviewed: fix distcheck build, add (more) missing files to list.

  • GNUmakefile.am:
3:12 PM Changeset in webkit [42966] by eric@webkit.org
  • 1 edit
    4 adds in trunk/LayoutTests

Reviewed by Simon Fraser.

Add text gradient test to cover
​https://bugs.webkit.org/show_bug.cgi?id=25403

  • platform/mac/svg/text/text-gradient-positioning-expected.checksum: Added.
  • platform/mac/svg/text/text-gradient-positioning-expected.png: Added.
  • platform/mac/svg/text/text-gradient-positioning-expected.txt: Added.
  • svg/text/text-gradient-positioning.svg: Added.
3:09 PM Changeset in webkit [42965] by andersca@apple.com
  • 8 edits in trunk/WebKit/mac

2009-04-28 Anders Carlsson <​andersca@apple.com>

Reviewed by Kevin Decker and Darin Adler.

Fix <rdar://problem/6836132>.


  • Plugins/Hosted/NetscapePluginHostProxy.mm: (WKPCCheckIfAllowedToLoadURL): Call the instance proxy.


(WKPCCancelCheckIfAllowedToLoadURL):
Ditto.


  • Plugins/Hosted/NetscapePluginInstanceProxy.h:
  • Plugins/Hosted/NetscapePluginInstanceProxy.mm: (WebKit::NetscapePluginInstanceProxy::NetscapePluginInstanceProxy): Initialize the check ID counter.


(WebKit::NetscapePluginInstanceProxy::checkIfAllowedToLoadURL):
Create a WebPluginContainerCheck, add it to the map, and start it.


(WebKit::NetscapePluginInstanceProxy::cancelCheckIfAllowedToLoadURL):
Remove the check from the map.


(WebKit::NetscapePluginInstanceProxy::checkIfAllowedToLoadURLResult):
Call the WKPH MIG callback.


  • Plugins/Hosted/WebHostedNetscapePluginView.h:
  • Plugins/Hosted/WebHostedNetscapePluginView.mm: (-[WebHostedNetscapePluginView _webPluginContainerCancelCheckIfAllowedToLoadRequest:]): Call the instance proxy.


(-[WebHostedNetscapePluginView _containerCheckResult:contextInfo:]):
Ditto.


  • Plugins/Hosted/WebKitPluginClient.defs:
  • Plugins/Hosted/WebKitPluginHost.defs: Add MIG declarations.
2:59 PM Changeset in webkit [42964] by eric@webkit.org
  • 1 edit
    4 adds in trunk/LayoutTests

Reviewed by David Hyatt.

Add text repaint test to cover
​https://bugs.webkit.org/show_bug.cgi?id=16188

  • platform/mac/svg/text/text-repaint-rects-expected.checksum: Added.
  • platform/mac/svg/text/text-repaint-rects-expected.png: Added.
  • platform/mac/svg/text/text-repaint-rects-expected.txt: Added.
  • svg/text/text-repaint-rects.xhtml: Added.
2:38 PM Changeset in webkit [42963] by xan@webkit.org
  • 4 edits in trunk

WebCore:

2009-04-28 Xan Lopez <​xlopez@igalia.com>

Unreviewed: fix distcheck build, add missing header to file list.

  • GNUmakefile.am:

JavaScriptCore:

2009-04-28 Xan Lopez <​xlopez@igalia.com>

Unreviewed: fix distcheck build, add missing header to file list.

  • GNUmakefile.am:
2:27 PM Changeset in webkit [42962] by kov@webkit.org
  • 3 edits in trunk/WebKit/gtk

2009-04-28 Gustavo Noronha Silva <​gustavo.noronha@collabora.co.uk>

Unreviewed. Update gtk-doc control and base sgml files for 1.1.6.

  • docs/webkitgtk-docs.sgml:
  • docs/webkitgtk-sections.txt:
1:59 PM Changeset in webkit [42961] by eric@webkit.org
  • 19 edits in trunk

Reviewed by Sam Weinig.

Fix foreignObject transform order
​https://bugs.webkit.org/show_bug.cgi?id=25433

Transforms were being applied in the wrong order.
When mapping from local to parent, first apply the viewport transform
then map from the viewport box to the parent box.

  • rendering/RenderForeignObject.cpp: (WebCore::RenderForeignObject::localToParentTransform):
1:56 PM Changeset in webkit [42960] by eric@webkit.org
  • 20 edits in trunk/WebCore

Reviewed by Simon Fraser.

Simplify nodeAtPoint for SVG
​https://bugs.webkit.org/show_bug.cgi?id=25432

Added a new nodeAtFloatPoint method which takes a FloatPoint
instead of the *super confusing* x/y tx/ty pairs that HTML uses.
Mostly this is just lots of minus-lines as the new code is *much* simpler.

I made all the SVG renderers use the new nodeAtFloatPoint and ASSERT_NOT_REACHED
for the nodeAtPoint HTML/CSS int x/y version.

Eventually the rest of CSS/HTML render objects will follow suit
and move to nodeAtFloatPoint (possibly renamed back to nodeAtPoint), but changing them
over was well outside the scope of this change.

SVG hit testing is not actually floating point precise yet, since its still
passed in an integer x/y. Certain transform hit-test edge cases are likely fixed
by moving to FloatPoint here, but I didn't try to find one.

This should not cause functional changes for common-case hit testing, thus
no tests changed, nor should new tests be needed.

  • rendering/RenderForeignObject.cpp: (WebCore::RenderForeignObject::translationForAttributes): (WebCore::RenderForeignObject::paint): (WebCore::RenderForeignObject::computeRectForRepaint): (WebCore::RenderForeignObject::localToParentTransform): (WebCore::RenderForeignObject::layout): (WebCore::RenderForeignObject::nodeAtFloatPoint):
  • rendering/RenderForeignObject.h:
  • rendering/RenderObject.cpp: (WebCore::RenderObject::nodeAtFloatPoint):
  • rendering/RenderObject.h:
  • rendering/RenderPath.cpp: (WebCore::RenderPath::nodeAtFloatPoint):
  • rendering/RenderPath.h:
  • rendering/RenderSVGContainer.cpp: (WebCore::RenderSVGContainer::nodeAtFloatPoint):
  • rendering/RenderSVGContainer.h: (WebCore::RenderSVGContainer::pointIsInsideViewportClip):
  • rendering/RenderSVGHiddenContainer.cpp: (WebCore::RenderSVGHiddenContainer::nodeAtFloatPoint):
  • rendering/RenderSVGHiddenContainer.h:
  • rendering/RenderSVGImage.cpp: (WebCore::RenderSVGImage::paint): (WebCore::RenderSVGImage::nodeAtFloatPoint):
  • rendering/RenderSVGImage.h: (WebCore::RenderSVGImage::localToParentTransform): (WebCore::RenderSVGImage::localTransform):
  • rendering/RenderSVGModelObject.cpp: (WebCore::RenderSVGModelObject::nodeAtFloatPoint):
  • rendering/RenderSVGModelObject.h:
  • rendering/RenderSVGRoot.cpp: (WebCore::RenderSVGRoot::nodeAtFloatPoint):
  • rendering/RenderSVGText.cpp: (WebCore::RenderSVGText::nodeAtFloatPoint):
  • rendering/RenderSVGText.h:
  • rendering/RenderSVGViewportContainer.cpp: (WebCore::RenderSVGViewportContainer::pointIsInsideViewportClip):
  • rendering/RenderSVGViewportContainer.h:
1:42 PM Changeset in webkit [42959] by eric.carlson@apple.com
  • 2 edits in trunk/WebCore

2009-04-28 Eric Carlson <​eric.carlson@apple.com>

  • fix the Tiger build
  • platform/graphics/mac/MediaPlayerPrivateQTKit.mm: (WebCore::MediaPlayerPrivate::cacheMovieScale):
1:30 PM Changeset in webkit [42958] by weinig@apple.com
  • 8 edits in trunk/WebCore

2009-04-28 Sam Weinig <​sam@webkit.org>

Reviewed by Beth Dakin.

Consolidate ScheduleAction creation into ScheduledAction::create.
Autogenerate JSWorkerContext.clearTimeout and clearInterval.

  • bindings/js/JSDOMWindowCustom.cpp: (WebCore::JSDOMWindow::setTimeout): (WebCore::JSDOMWindow::setInterval):
  • bindings/js/JSWorkerContextCustom.cpp: (WebCore::JSWorkerContext::setTimeout): (WebCore::JSWorkerContext::setInterval):
  • bindings/js/ScheduledAction.cpp: (WebCore::ScheduledAction::create): (WebCore::ScheduledAction::ScheduledAction): (WebCore::ScheduledAction::execute):
  • bindings/js/ScheduledAction.h:
  • workers/WorkerContext.cpp: (WebCore::DOMWindow::setTimeout): (WebCore::DOMWindow::clearTimeout): (WebCore::DOMWindow::setInterval): (WebCore::DOMWindow::clearInterval):
  • workers/WorkerContext.h:
  • workers/WorkerContext.idl:
1:22 PM Changeset in webkit [42957] by sfalken@apple.com
  • 3 edits
    1 add in trunk/WebKitTools

Fix link warnings building TestNetscapePlugin on Windows due to mismatched
DLL name vs. LIBRARY directive name.


Reviewed by Jon Honeycutt.

  • DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.def:
  • DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.vcproj:
  • DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin_debug.def: Added.
1:21 PM Changeset in webkit [42956] by kov@webkit.org
  • 2 edits in trunk/WebKit/gtk

2009-04-28 Gustavo Noronha Silva <​gustavo.noronha@collabora.co.uk>

Reviewed by Xan Lopez.

Updated with news for the 1.1.6 release.

  • NEWS:
1:14 PM Changeset in webkit [42955] by beidson@apple.com
  • 7 edits
    10 adds in trunk

WebCore:

2009-04-28 Brady Eidson <​beidson@apple.com>

Reviewed by Darin Adler

<rdar://problem/6643219> Crashes after moving nodes between documents with Safari 4 Beta installed

When moving Nodes between documents we weren't properly updating style declarations. Certain operations, such
as creating webarchives, would tickle this bug.

Tests: webarchive/adopt-attribute-styled-body-webarchive.html

webarchive/adopt-attribute-styled-node-webarchive.html
webarchive/adopt-inline-styled-node-webarchive.html

  • dom/Node.cpp: Add a debug-only mechanism to insure that anyone who overrides (did/will)MoveToNewOwnerDocument calls their parent-class implementation after they've done their own work. (WebCore::setWillMoveToNewOwnerDocumentWasCalled): (WebCore::setDidMoveToNewOwnerDocumentWasCalled): (WebCore::Node::setDocument): (WebCore::Node::willMoveToNewOwnerDocument): (WebCore::Node::didMoveToNewOwnerDocument):
  • dom/StyledElement.cpp: (WebCore::StyledElement::attributeChanged): Add a comment explaining why we don't need to walk the nameAttrMap to update style declarations. (WebCore::StyledElement::didMoveToNewOwnerDocument): Update the parent pointer for the inline style declaration.
  • dom/StyledElement.h:
  • html/HTMLBodyElement.cpp: (WebCore::HTMLBodyElement::didMoveToNewOwnerDocument): Update the parent pointer for the link declaration.
  • html/HTMLBodyElement.h:

LayoutTests:

2009-04-28 Brady Eidson <​beidson@apple.com>

Reviewed by Darin Adler

<rdar://problem/6643219> Crashes after moving nodes between documents with Safari 4 Beta installed

  • webarchive/adopt-attribute-styled-body-webarchive-expected.webarchive: Added.
  • webarchive/adopt-attribute-styled-body-webarchive.html: Added.
  • webarchive/resources/adopt-attribute-styled-body-iframe.html: Added.
  • webarchive/resources/adopt-attribute-styled-body-second-window.html: Added.
  • webarchive/adopt-attribute-styled-node-webarchive-expected.webarchive: Added.
  • webarchive/adopt-attribute-styled-node-webarchive.html: Added.
  • webarchive/resources/adopt-attribute-styled-node-second-window.html: Added.
  • webarchive/adopt-inline-styled-node-webarchive-expected.webarchive: Added.
  • webarchive/adopt-inline-styled-node-webarchive.html: Added.
  • webarchive/resources/adopt-inline-styled-node-second-window.html: Added.
1:12 PM Changeset in webkit [42954] by mrowe@apple.com
  • 2 edits in tags/Safari-6530.7.1/WebCore

Merge r42945.

12:48 PM Changeset in webkit [42953] by sfalken@apple.com
  • 3 edits in trunk/WebKitTools

Fix warnings about PRODUCTION and ARCHIVE_BUILD on Windows builds
of ImageDiff and DumpRenderTree.


Rubber stamped by Adam Roben.

  • DumpRenderTree/win/DumpRenderTree.vcproj:
  • DumpRenderTree/win/ImageDiff.vcproj:
12:46 PM Changeset in webkit [42952] by eric.carlson@apple.com
  • 2 edits in trunk/WebCore

2009-04-28 Eric Carlson <​eric.carlson@apple.com>

Reviewed by Darin Adler.


<rdar://problem/6834876> Don't use BlockExceptions macros until QTKit supports
QTMoviePreferredTransformAttribute

  • platform/graphics/mac/MediaPlayerPrivateQTKit.mm: (WebCore::MediaPlayerPrivate::cacheMovieScale): use @try and @catch instead of BEGIN_BLOCK_OBJC_EXCEPTIONS and END_BLOCK_OBJC_EXCEPTIONS for builds of QTKit that throw an exception on QTMovieCurrentSizeAttribute but don't support QTMoviePreferredTransformAttribute
12:43 PM Changeset in webkit [42951] by Darin Adler
  • 2 edits in trunk/WebCore

2009-04-28 Darin Adler <Darin Adler>

Reviewed by Sam Weinig.

  • rendering/RenderText.cpp: (WebCore::RenderText::RenderText): Streamline code path to avoid a bit of reference count churn and remove a strange unneeeded PassRefPtr typecast. Also added a comment. (WebCore::RenderText::setTextInternal): Ditto.
12:37 PM Changeset in webkit [42950] by eric@webkit.org
  • 21 edits in trunk

Reviewed by Simon Fraser.

Simplify how SVG containers paint
​https://bugs.webkit.org/show_bug.cgi?id=25431

Moved filterBoundingBox() from RenderSVGModelObject to SVGRenderSupport to share with other classes.
Gave RenderSVGText a modern clippedOverflowRectForRepaint and computeRectForRepaint.
RenderSVGText now applies transforms at paint() time instead of during chunk draw time
this should be much more efficient.

Fixed the order in which RenderSVGViewportContainer applied
transforms and clips. We now clip to the viewport first and apply
all transforms at once. Also since the viewport logic is now only
inside RenderSVGViewportContainer (instead of inside RenderSVGContainer)
we always know we have a viewport. We now use only viewportSize instead of
viewport() since RenderSVGViewportContainers can't have x/y offsets.

We now correctly transform the PaintInfo::rect (damage rect) when applying transforms.
This allowed us to apply the transform during text paint() instead of at chunk paint
time. Previously we had to apply the transform during chunk paint time because
RenderBlock (superclass of RenderSVGBlock) would check intersection with the damageRect
before telling any of the inlines to draw. Now that we adjust the damage rect correctly
we pass the intersection check correctly! (This probably fixed some <text> redraw bugs
but since I still have a bunch of those to fix, I've not tried to write additional tests
to cover these potential fixes yet.)

SVGRootInlineBox no longer needs to deal with transforms at chunk paint time, yay!

  • rendering/RenderPath.cpp: (WebCore::RenderPath::repaintRectInLocalCoordinates): (WebCore::RenderPath::paint):
  • rendering/RenderSVGContainer.cpp: (WebCore::RenderSVGContainer::paint): (WebCore::RenderSVGContainer::repaintRectInLocalCoordinates):
  • rendering/RenderSVGContainer.h: (WebCore::RenderSVGContainer::applyViewportClip):
  • rendering/RenderSVGImage.cpp: (WebCore::RenderSVGImage::layout): (WebCore::RenderSVGImage::repaintRectInLocalCoordinates): (WebCore::RenderSVGImage::clippedOverflowRectForRepaint): (WebCore::RenderSVGImage::computeRectForRepaint):
  • rendering/RenderSVGImage.h:
  • rendering/RenderSVGModelObject.cpp:
  • rendering/RenderSVGModelObject.h:
  • rendering/RenderSVGRoot.cpp: (WebCore::RenderSVGRoot::layout): (WebCore::RenderSVGRoot::selfWillPaint): (WebCore::RenderSVGRoot::paint): (WebCore::RenderSVGRoot::viewportSize): (WebCore::RenderSVGRoot::calcViewport): (WebCore::RenderSVGRoot::localToBorderBoxTransform): (WebCore::RenderSVGRoot::parentOriginToBorderBox): (WebCore::RenderSVGRoot::borderOriginToContentBox): (WebCore::RenderSVGRoot::localToRepaintContainerTransform): (WebCore::RenderSVGRoot::localToParentTransform): (WebCore::RenderSVGRoot::computeRectForRepaint): (WebCore::RenderSVGRoot::nodeAtPoint):
  • rendering/RenderSVGRoot.h:
  • rendering/RenderSVGText.cpp: (WebCore::RenderSVGText::clippedOverflowRectForRepaint): (WebCore::RenderSVGText::computeRectForRepaint): (WebCore::RenderSVGText::paint): (WebCore::RenderSVGText::repaintRectInLocalCoordinates):
  • rendering/RenderSVGText.h: (WebCore::RenderSVGText::localToParentTransform): (WebCore::RenderSVGText::localTransform):
  • rendering/RenderSVGViewportContainer.cpp: (WebCore::RenderSVGViewportContainer::applyViewportClip):
  • rendering/RenderSVGViewportContainer.h:
  • rendering/SVGRenderSupport.cpp: (WebCore::filterBoundingBoxForRenderer): (WebCore::applyTransformToPaintInfo):
  • rendering/SVGRenderSupport.h:
  • rendering/SVGRootInlineBox.cpp: (WebCore::SVGRootInlineBoxPaintWalker::chunkStartCallback): (WebCore::SVGRootInlineBox::paint):
12:37 PM Changeset in webkit [42949] by Chris Fleizach
  • 3 edits
    2 adds in trunk

Bug 25453: AX: fall back to PLACEHOLDER attr if form element is not labeled
​https://bugs.webkit.org/show_bug.cgi?id=25453

12:33 PM Changeset in webkit [42948] by mrowe@apple.com
  • 4 edits in tags/Safari-6530.7.1

Versioning.

12:16 PM Changeset in webkit [42947] by mrowe@apple.com
  • 1 copy in tags/Safari-6530.7.1

New tag.

12:14 PM Changeset in webkit [42946] by Chris Fleizach
  • 9 edits
    2 adds in trunk

Bug 25452: AX: Don't create addition space AXStaticText element for every bold or link tag
​https://bugs.webkit.org/show_bug.cgi?id=25452

11:57 AM Changeset in webkit [42945] by mrowe@apple.com
  • 2 edits in trunk/WebCore

Work around <rdar://problem/6833240> by relying on static initialization to zero the entire struct.
This removes the need for us to explicitly initialize all of the members, which have a tendency
to change in meaning and number between versions of libxml2.

Reviewed by Sam Weinig.

  • dom/XMLTokenizerLibxml2.cpp:

(WebCore::):
(WebCore::sharedXHTMLEntity):
(WebCore::getXHTMLEntity):

11:56 AM Changeset in webkit [42944] by sfalken@apple.com
  • 2 edits in trunk/WebKitLibraries

Fix extraneous warning about AnalyzeWithLargeStack not being defined in Windows builds.
Indirected definition through a UserMacro.


Reviewed by Mark Rowe.

  • win/tools/vsprops/common.vsprops:
11:52 AM Changeset in webkit [42943] by sfalken@apple.com
  • 2 edits in trunk/WebCore

Fix linker warning by specifying /NODEFAULTLIB:LIBCMT for QTMovieWin.


Reviewed by Mark Rowe.

  • WebCore.vcproj/QTMovieWin.vcproj:
11:32 AM Changeset in webkit [42942] by Chris Fleizach
  • 3 edits
    2 adds in trunk

Bug 25449: AX: Respect the alt tag of ARIA button as AXDescription
​https://bugs.webkit.org/show_bug.cgi?id=25449

11:29 AM Changeset in webkit [42941] by sfalken@apple.com
  • 2 edits in trunk/WebKitLibraries

Fix extraneous warning about PRODUCTION not being defined in Windows builds.
Indirected definition for PRODUCTION through a UserMacro.


Reviewed by Mark Rowe.

  • win/tools/vsprops/common.vsprops:
11:16 AM Changeset in webkit [42940] by mitz@apple.com
  • 2 edits in trunk/WebCore

Reviewed by John Sullivan.

  • formatting cleanup
  • rendering/RenderBox.cpp: (WebCore::RenderBox::calcHeight): Corrected indentation and added braces around a multi-line "else" clause.
11:05 AM Changeset in webkit [42939] by eric.carlson@apple.com
  • 4 edits in trunk

2009-04-28 Eric Carlson <​eric.carlson@apple.com>

Reviewed by Adam Roben


<rdar://problem/6769968> media/video-size-intrinsic-scale.html fails on Windows
​https://bugs.webkit.org/show_bug.cgi?id=25094


Display movies saved with a non-identity matrix at the correct size.

  • platform/graphics/win/QTMovieWin.cpp: (QTMovieWinPrivate::QTMovieWinPrivate): Initialize m_widthScaleFactor and m_heightScaleFactor. (QTMovieWinPrivate::cacheMovieScale): New, calculate difference between initial size and natural size so naturalSize() accounts for non-identity movie matrix. (QTMovieWinPrivate::task):Call cacheMovieScale when load state reaches kMovieLoadStateLoaded for the first time. kMovieLoadState -> QTMovieLoadState. (QTMovieWinPrivate::drawingComplete): kMovieLoadState -> QTMovieLoadState. (QTMovieWinPrivate::createGWorld): Don't bother creating gworld until load state reaches kMovieLoadStateLoaded because we do not try to draw it before that point. (QTMovieWinPrivate::setSize): Do not change movie box before reaching kMovieLoadStateLoaded because we need to get the movie's initial size in cacheMovieScale. (QTMovieWin::getNaturalSize): Multiply width and height by initial scale.

2009-04-28 Eric Carlson <​eric.carlson@apple.com>

Reviewed by Adam Roben

<rdar://problem/6769968> media/video-size-intrinsic-scale.html fails on Windows
​https://bugs.webkit.org/show_bug.cgi?id=25094

  • platform/win/Skipped: Re-enable video-size-intrinsic-scale.html.
10:43 AM Changeset in webkit [42938] by weinig@apple.com
  • 7 edits in trunk/WebCore

2009-04-28 Sam Weinig <​sam@webkit.org>

Reviewed by Dan Bernstein.

Move timer code from JSDOMWindow to DOMWindow. clearTimeout and
clearInterval can now be autogenerated.

  • bindings/js/JSDOMWindowBase.cpp:
  • bindings/js/JSDOMWindowBase.h:
  • bindings/js/JSDOMWindowCustom.cpp: (WebCore::createScheduledAction): (WebCore::JSDOMWindow::setTimeout): (WebCore::JSDOMWindow::setInterval):
  • page/DOMWindow.cpp: (WebCore::DOMWindow::setTimeout): (WebCore::DOMWindow::clearTimeout): (WebCore::DOMWindow::setInterval): (WebCore::DOMWindow::clearInterval):
  • page/DOMWindow.h:
  • page/DOMWindow.idl:
10:06 AM Changeset in webkit [42937] by kevino@webkit.org
  • 2 edits in trunk/WebCore

Reviewed by Kevin Ollivier.

Small optimization, don't get the widget's handle twice in one method.

​https://bugs.webkit.org/show_bug.cgi?id=25446

9:46 AM Changeset in webkit [42936] by mitz@apple.com
  • 3 edits in trunk/WebKit/mac

Reviewed by John Sullivan.

  • fix <rdar://problem/6786360> Make PDF an insertable pasteboard type
  • WebCoreSupport/WebPasteboardHelper.mm: (WebPasteboardHelper::insertablePasteboardTypes):
  • WebView/WebHTMLView.mm: (-[WebHTMLView _documentFragmentFromPasteboard:inContext:allowPlainText:]): (+[WebHTMLView _insertablePasteboardTypes]): (-[WebHTMLView _documentFragmentFromPasteboard:forType:inContext:subresources:]):
9:32 AM QtWebKitJournal edited by Simon Hausmann
(diff)
9:31 AM Changeset in webkit [42935] by kevino@webkit.org
  • 2 edits in trunk/WebCore

Reviewed by Kevin Ollivier.

ScrollView copy and paste typo fix.

​https://bugs.webkit.org/show_bug.cgi?id=25445

9:29 AM QtWebKitTodo edited by Simon Hausmann
(diff)
9:28 AM QtWebKitJournal edited by Simon Hausmann
(diff)
9:27 AM Changeset in webkit [42934] by Simon Hausmann
  • 6 edits in trunk/WebKit/qt

2009-04-28 Simon Hausmann <​simon.hausmann@nokia.com>

Reviewed by Tor Arne Vestbø.

QWebElement API changes after another round of API review:

  • Fix argument names of findAll/findFirst
  • Split up toXml into innerXml and outerXml
  • Removed confusing toggleClass overload
  • Fixed casing of namespaceUri to follow QXmlStreamReader
  • Removed tagName from firstChild/nextSibling/etc.
  • Renamed append/prepend/insertAfter/insertBefore to [append|prepend][Inside|Outside]
  • Renamed wrapWith() back to wrap()
  • Made clone() const
  • Renamed remove() to takeFromDocument(), added removeFromDocument()
  • Renamed clear() to removeChildren()
  • Renamed scriptsFunctions/callScriptFunction to functions()/callFunction()
  • Renamed scriptProperty to scriptableProperty
9:25 AM QtWebKitTodo edited by Simon Hausmann
(diff)
9:09 AM Changeset in webkit [42933] by xan@webkit.org
  • 2 edits in trunk

2009-04-28 Xan Lopez <​xlopez@igalia.com>

Unreviewed: bump versions in preparation for 1.1.6 release.

  • configure.ac:
9:06 AM Changeset in webkit [42932] by xan@webkit.org
  • 2 edits in trunk/WebKit/gtk

2009-04-28 Xan Lopez <​xlopez@igalia.com>

Reviewed by Gustavo Noronha.

Leave a bit of space from the previous page when advacing a whole
page. This matches the behavior of our scrollbar scrolling code
and is just nicer in general.

  • webkit/webkitwebview.cpp:
8:55 AM Changeset in webkit [42931] by kevino@webkit.org
  • 5 edits in trunk/WebKit/wx

Reviewed by Kevin Ollivier.

Add a function for resetting the zoom factor to 1.0.

​https://bugs.webkit.org/show_bug.cgi?id=25447

7:01 AM Changeset in webkit [42930] by sullivan@apple.com
  • 2 edits in trunk/WebCore

2009-04-28 John Sullivan <​sullivan@apple.com>

<rdar://problem/6820221> REGRESSION: 2-byte character names of images are displayed as %-encoded ASCII

Reviewed by Adam Roben

  • loader/ImageDocument.cpp: (WebCore::ImageTokenizer::finish): decode the filename before processing it as part of the image name that's passed to the client
6:51 AM Changeset in webkit [42929] by Simon Hausmann
  • 5 edits in trunk/WebKit/qt

2009-04-28 Simon Hausmann <​simon.hausmann@nokia.com>

Reviewed by Tor Arne Vestbø.

Fix some qdoc warnings.

6:36 AM QtWebKitTodo edited by Simon Hausmann
(diff)
6:35 AM QtWebKitTodo edited by Simon Hausmann
(diff)
6:18 AM api_changes.txt attached to QtWebKitTodo by Simon Hausmann
Diff of the suggested API changes after another round of review
2:59 AM Changeset in webkit [42928] by mjs@apple.com
  • 2 edits in trunk/WebCore

2009-04-28 Maciej Stachowiak <​mjs@apple.com>

Not reviewed, build fix.

  • fix initialization order to match declaration order to fix release build
  • page/Settings.cpp: (WebCore::Settings::Settings):
1:55 AM Changeset in webkit [42927] by xan@webkit.org
  • 2 edits in trunk/WebKit/gtk

2009-04-28 Xan Lopez <​xlopez@igalia.com>

Unreviewed: committed a few bits by mistake, remove them.

  • WebCoreSupport/EditorClientGtk.cpp: (WebKit::handleEditingKeyboardEvent):
1:45 AM Changeset in webkit [42926] by xan@webkit.org
  • 2 edits in trunk/WebKit/gtk

2009-04-28 Xan Lopez <​xlopez@igalia.com>

Reviewed by Gustavo Noronha.

​https://bugs.webkit.org/show_bug.cgi?id=16135
[GTK] Support caret browsing

Refactor keyboard event handling to work properly under caret
browsing mode. Most of the code comes from the Windows port.

  • WebCoreSupport/EditorClientGtk.cpp: (WebKit::): (WebKit::interpretKeyEvent): (WebKit::handleEditingKeyboardEvent): (WebKit::EditorClient::handleKeyboardEvent):
1:44 AM Changeset in webkit [42925] by xan@webkit.org
  • 3 edits in trunk/WebKit/gtk

2009-04-28 Xan Lopez <​xlopez@igalia.com>

Reviewed by Gustavo Noronha.

​https://bugs.webkit.org/show_bug.cgi?id=16135
[GTK] Support caret browsing

Based on a patch by Alp Toker.

Add enable-caret-browsing setting to WebKitWebView.

  • webkit/webkitwebsettings.cpp: (_WebKitWebSettingsPrivate::): (_WebKitWebSettingsPrivate::webkit_web_settings_class_init): (_WebKitWebSettingsPrivate::webkit_web_settings_set_property): (_WebKitWebSettingsPrivate::webkit_web_settings_get_property): (_WebKitWebSettingsPrivate::webkit_web_settings_copy):
  • webkit/webkitwebview.cpp:
1:44 AM Changeset in webkit [42924] by xan@webkit.org
  • 7 edits in trunk/WebCore

2009-04-28 Xan Lopez <​xlopez@igalia.com>

Reviewed by Justin Garcia.

​https://bugs.webkit.org/show_bug.cgi?id=16135
[GTK] Support caret browsing

Based on a patch by Alp Toker.

Implement basic support for caret browsing, active only when the
corresponding setting is enabled.

  • page/EventHandler.cpp: (WebCore::EventHandler::handleMouseReleaseEvent):
  • page/FocusController.cpp: (WebCore::FocusController::advanceFocus): (WebCore::clearSelectionIfNeeded): (WebCore::FocusController::setFocusedNode):
  • page/Frame.cpp: (WebCore::Frame::setFocusedNodeIfNeeded): (WebCore::Frame::setSelectionFromNone): (WebCore::Frame::respondToChangedSelection):
  • page/Settings.cpp: (WebCore::Settings::Settings):
  • page/Settings.h:
  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::paintCaret):
1:08 AM Changeset in webkit [42923] by barraclough@apple.com
  • 2 edits in trunk/JavaScriptCore

2009-04-28 Gavin Barraclough <​barraclough@apple.com>

Rubber stamped by Maciej "Henry Morgan" Stachowiak.

Enable YARR.
(Again.)

  • wtf/Platform.h:
12:10 AM Changeset in webkit [42922] by barraclough@apple.com
  • 2 edits in trunk/JavaScriptCore

2009-04-27 Gavin Barraclough <​barraclough@apple.com>

Reviewed by Maciej Stachowiak.

Tweak a loop condition to keep GCC happy,
some GCCs seem to be having issues with this. :-/

  • bytecompiler/BytecodeGenerator.cpp: (JSC::BytecodeGenerator::breakTarget):
  • wtf/Platform.h:
Note: See TracTimeline for information about the timeline view.