⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



May 4, 2009:

11:01 PM Changeset in webkit [43206] by weinig@apple.com
  • 4 edits in branches/nitro-extreme/JavaScriptCore

2009-05-04 Sam Weinig <​sam@webkit.org>

Make CallFrame dumping more useful by dumping a description and
all 64 bits of registers.

  • interpreter/Interpreter.cpp: (JSC::Interpreter::dumpRegisters):
  • runtime/JSValue.cpp: (JSC::JSValue::description):
  • runtime/JSValue.h:
10:37 PM Changeset in webkit [43205] by mjs@apple.com
  • 2 edits in trunk/JavaScriptCore

2009-05-04 Maciej Stachowiak <​mjs@apple.com>

Rubber stamped by Gavin.

  • inline Vector::resize for a ~1.5% speedup on string-tagcloud
  • wtf/Vector.h: (WTF::Vector::resize): Inline
9:46 PM Changeset in webkit [43204] by ggaren@apple.com
  • 2 edits in branches/nitro-extreme/JavaScriptCore

2009-05-04 Geoffrey Garen <​ggaren@apple.com>

Reviewed by Mark Rowe.


PPC fix.

  • runtime/JSValue.h: (JSC::JSValue::): endian little hate i.
9:45 PM Changeset in webkit [43203] by zecke@webkit.org
  • 2 edits in trunk/LayoutTests

2009-05-04 Holger Hans Peter Freyther <​zecke@selfish.org>

Disabling accessibility/canvas.html due the lack of a
an AccessibilityController implementation in DRT.

  • platform/gtk/Skipped:
9:06 PM Changeset in webkit [43202] by weinig@apple.com
  • 2 edits in branches/nitro-extreme/JavaScriptCore

2009-05-04 Sam Weinig <​sam@webkit.org>

Reviewed by Geoffrey Garen.

Fix regression in fast/js/exception-sequencing-binops.html caused by
evaluating the arguments passed to fmod in the wrong order.

All LayoutTests now pass.

  • interpreter/Interpreter.cpp: (JSC::Interpreter::privateExecute):
6:47 PM Changeset in webkit [43201] by ggaren@apple.com
  • 4 edits in branches/nitro-extreme/JavaScriptCore

2009-05-04 Geoffrey Garen <​ggaren@apple.com>

Reviewed by Sam Weinig.


Fixed some number bugs. 3x speedup, since this patch restores all our
int-based optimizations.

  • interpreter/Interpreter.cpp: (JSC::Interpreter::privateExecute): Make sure negate of 0 yields -0.
  • runtime/JSValue.cpp: (JSC::JSValue::description): Fixed some typos in debug logging code. (Missing "else" before "if".)
  • runtime/JSValue.h: (JSC::JSValue::JSValue): Convert doubles to int if possible, as we do on trunk.
6:18 PM Changeset in webkit [43200] by beidson@apple.com
  • 3 edits in trunk/WebCore

2009-05-04 Brady Eidson <​beidson@apple.com>

Reviewed by Sam 'The Belly' Weinig

<rdar://problem/6828894> - Facebook photo uploader applet broken on Leopard only

In r41568 we started adding a default codebase attribute to <applet> tags if they didn't specify one
themselves. Leopard's Java plug-in mishandles this case and fails to load code for the applet.

The spirit of r41568 can be maintained by removing the "default codebase" piece and only performing
the canLoad() check if a codebase was actually set on the applet tag.

  • html/HTMLAppletElement.cpp: (WebCore::HTMLAppletElement::createRenderer): Don't create a default codebase attribute.
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::createJavaAppletWidget): Only perform the canLoad() check if the codebase was set.
6:04 PM Changeset in webkit [43199] by weinig@apple.com
  • 9 edits
    1 add
    1 delete in branches/nitro-extreme

JavaScriptCore:

2009-05-04 Sam Weinig <​sam@webkit.org>

Make WebCore compile with the new JS number representation.

WebCore:

2009-05-04 Sam Weinig <​sam@webkit.org>

Make WebCore compile with the new JS number representation.

  • ForwardingHeaders/runtime/JSAPIValueWrapper.h: Added.
  • ForwardingHeaders/runtime/JSNumberCell.h: Removed.
  • bindings/js/ScriptEventListener.cpp:
  • bindings/scripts/CodeGeneratorJS.pm:
  • bridge/c/c_instance.cpp:
6:00 PM Changeset in webkit [43198] by Adam Roben
  • 3 edits in trunk/WebCore

Windows build fix

  • html/HTMLCollection.h:
  • html/HTMLFormElement.h: Declare CollectionCache as a struct, not a class, to match its definition.
5:39 PM Changeset in webkit [43197] by Chris Fleizach
  • 3 edits
    2 adds in trunk

Bug 25557: REGRESSION: Canvas elements are ignored instead of being exposed as AXImage
​https://bugs.webkit.org/show_bug.cgi?id=25557

5:25 PM Changeset in webkit [43196] by beidson@apple.com
  • 1 edit in trunk/WebCore/ChangeLog

2009-05-04 Brady Eidson <​beidson@apple.com>

Fix an ancient Changelog entry where Sam Weinig flat out lied and confused my exploration of a bug.

  • ChangeLog
5:20 PM Changeset in webkit [43195] by eric@webkit.org
  • 3 edits
    2 adds in trunk

2009-05-04 Kai Brüning <​kai@granus.net>

Reviewed by Eric Seidel.

​https://bugs.webkit.org/show_bug.cgi?id=24883
24883: Bad success test in parseXMLDocumentFragment in XMLTokenizerLibxml2.cpp

Fixed test whether all the chunk has been processed to correctly count utf8 bytes.

Test: fast/innerHTML/innerHTML-nbsp.xhtml

  • dom/XMLTokenizerLibxml2.cpp: (WebCore::parseXMLDocumentFragment):
3:37 PM Changeset in webkit [43194] by weinig@apple.com
  • 2 edits in branches/nitro-extreme/JavaScriptCore

2009-05-04 Sam Weinig <​sam@webkit.org>

Re-enable Yarr! It still works.

  • wtf/Platform.h:
3:29 PM Changeset in webkit [43193] by weinig@apple.com
  • 33 edits
    2 moves in branches/nitro-extreme/JavaScriptCore

2009-05-04 Sam Weinig <​sam@webkit.org>

Land initial commit of new number representation for 32 bit platforms.

1:11 PM Changeset in webkit [43192] by Darin Adler
  • 2 edits in trunk/LayoutTests

2009-05-04 Darin Adler <Darin Adler>

  • platform/gtk/Skipped: Disable a test that's timing out.
1:08 PM Changeset in webkit [43191] by Darin Adler
  • 2 edits in trunk/WebKit/win

2009-05-04 Darin Adler <Darin Adler>

First try at fixing the Windows build.

  • DOMHTMLClasses.cpp: Added include of HTMLCollection.h.
12:38 PM Changeset in webkit [43190] by kov@webkit.org
  • 2 edits
    2 deletes in trunk/LayoutTests

2009-05-04 Gustavo Noronha Silva <​gustavo.noronha@collabora.co.uk>

Disabling new tests, as they are failing because of font
configuration mismatch between my machine and the bot.

  • platform/gtk/Skipped:
  • platform/gtk/editing/spelling/spellcheck-attribute-expected.txt: Removed.
  • platform/gtk/svg/text/foreignObject-repaint-expected.txt: Removed.
12:13 PM Changeset in webkit [43189] by andersca@apple.com
  • 2 edits in trunk/WebKit/mac

2009-05-04 Anders Carlsson <​andersca@apple.com>

Reviewed by Kevin Decker.

Fix <rdar://problem/6797644>.


Make sure to send a reply even when an instance proxy can't be found.


  • Plugins/Hosted/NetscapePluginHostProxy.mm: (WKPCEvaluate): (WKPCInvoke): (WKPCInvokeDefault): (WKPCGetProperty): (WKPCHasProperty): (WKPCHasMethod): (WKPCEnumerate):
11:12 AM Changeset in webkit [43188] by kov@webkit.org
  • 3 edits
    6 adds in trunk

LayoutTests:

2009-05-04 Gustavo Noronha Silva <​gustavo.noronha@collabora.co.uk>

Reviewed by Alexey Proskuryakov.

Add results for two new tests, for the GTK+ port.

  • platform/gtk/editing/spelling/spellcheck-attribute-expected.txt: Added.
  • platform/gtk/svg/text/foreignObject-repaint-expected.txt: Added.

WebKitTools:

2009-05-04 Gustavo Noronha Silva <​gustavo.noronha@collabora.co.uk>

Reviewed by Alexey Proskuryakov.

Enable spell-checking in DumpRenderTree.

  • DumpRenderTree/gtk/DumpRenderTree.cpp: (resetWebViewToConsistentStateBeforeTesting):
11:00 AM Changeset in webkit [43187] by Darin Adler
  • 137 edits
    3 copies in trunk

WebCore:

2009-05-04 Darin Adler <Darin Adler>

Reviewed by Eric Seidel.

Bug 24924: remove Document.h include of Attr.h and HTMLCollection.h,
and NamedMappedAttrMap.h include of MappedAttribute.h
​https://bugs.webkit.org/show_bug.cgi?id=24924

Make compiles faster, and debugging info smaller.

  • GNUmakefile.am: Added new source files.
  • WebCore.pro: Ditto.
  • WebCore.scons: Ditto.
  • WebCore.vcproj/WebCore.vcproj: Ditto.
  • WebCore.xcodeproj/project.pbxproj: Ditto.
  • WebCoreSources.bkl: Ditto.
  • bindings/js/JSHTMLCollectionCustom.cpp: (WebCore::toJS): Updated for new collection type names.
  • dom/Document.cpp: (WebCore::Document::createAttribute): Added. No longer inline. (WebCore::Document::images): Updated for new collection type names. (WebCore::Document::applets): Ditto. (WebCore::Document::embeds): Ditto. (WebCore::Document::plugins): Ditto. (WebCore::Document::objects): Ditto. (WebCore::Document::scripts): Ditto. (WebCore::Document::links): Ditto. (WebCore::Document::forms): Ditto. (WebCore::Document::anchors): Ditto. (WebCore::Document::all): Ditto. (WebCore::Document::windowNamedItems): Ditto. (WebCore::Document::documentNamedItems): Ditto. (WebCore::Document::nameCollectionInfo): Ditto.
  • dom/Document.h: Changed around includes and forward declarations. Updated for changes to collection types.
  • dom/NamedMappedAttrMap.h: Removed include of MappedAttribute.h.
  • html/CollectionCache.cpp: Copied from WebCore/html/HTMLCollection.cpp. Contains the class that used to be HTMLCollection::CollectionInfo.
  • html/CollectionCache.h: Copied from WebCore/html/HTMLCollection.h. Ditto.
  • html/CollectionType.h: Copied from WebCore/html/HTMLCollection.h. Has the enum that used to be HTMLCollection::Type.
  • html/HTMLCollection.cpp: (WebCore::HTMLCollection::HTMLCollection): Update for collection type change. (WebCore::HTMLCollection::create): Ditto. (WebCore::HTMLCollection::resetCollectionInfo): Ditto. (WebCore::HTMLCollection::itemAfter): Ditto.
  • html/HTMLCollection.h: Ditto.
  • html/HTMLElement.cpp: (WebCore::HTMLElement::children): Updated for new collection type names.
  • html/HTMLFormCollection.cpp: (WebCore::HTMLFormCollection::formCollectionInfo): Ditto. (WebCore::HTMLFormCollection::HTMLFormCollection): Ditto.
  • html/HTMLFormCollection.h: Ditto.
  • html/HTMLFormElement.h: Ditto.
  • html/HTMLMapElement.cpp: (WebCore::HTMLMapElement::areas): Ditto.
  • html/HTMLNameCollection.cpp: (WebCore::HTMLNameCollection::HTMLNameCollection): Ditto.
  • html/HTMLNameCollection.h: (WebCore::HTMLNameCollection::create): Ditto.
  • html/HTMLSelectElement.h: (WebCore::HTMLSelectElement::collectionInfo): Ditto.
  • html/HTMLTableElement.cpp: (WebCore::HTMLTableElement::tBodies):Ditto.
  • html/HTMLTableRowElement.cpp: (WebCore::HTMLTableRowElement::cells):Ditto.
  • html/HTMLTableRowsCollection.cpp: (WebCore::HTMLTableRowsCollection::HTMLTableRowsCollection): Ditto.
  • html/HTMLTableSectionElement.cpp: (WebCore::HTMLTableSectionElement::rows): Ditto.
  • bindings/js/JSDOMWindowBase.cpp: Added newly-needed includes.
  • bindings/js/JSHTMLFrameSetElementCustom.cpp: Ditto.
  • css/CSSStyleSelector.cpp: Ditto.
  • dom/Element.cpp: Ditto.
  • dom/InputElement.cpp: Ditto.
  • dom/NamedAttrMap.cpp: Ditto.
  • dom/NamedMappedAttrMap.cpp: Ditto.
  • dom/Node.cpp: Ditto.
  • dom/StyledElement.cpp: Ditto.
  • dom/StyledElement.h: Ditto.
  • editing/ApplyStyleCommand.cpp: Ditto.
  • editing/DeleteSelectionCommand.cpp: Ditto.
  • editing/Editor.cpp: Ditto.
  • editing/EditorCommand.cpp: Ditto.
  • editing/InsertParagraphSeparatorCommand.cpp: Ditto.
  • editing/ReplaceSelectionCommand.cpp: Ditto.
  • editing/markup.cpp: Ditto.
  • html/CanvasRenderingContext2D.cpp: Ditto.
  • html/HTMLAnchorElement.cpp: Ditto.
  • html/HTMLAppletElement.cpp: Ditto.
  • html/HTMLAreaElement.cpp: Ditto.
  • html/HTMLBRElement.cpp: Ditto.
  • html/HTMLBaseElement.cpp: Ditto.
  • html/HTMLBodyElement.cpp: Ditto.
  • html/HTMLButtonElement.cpp: Ditto.
  • html/HTMLCanvasElement.cpp: Ditto.
  • html/HTMLDivElement.cpp: Ditto.
  • html/HTMLEmbedElement.cpp: Ditto.
  • html/HTMLFontElement.cpp: Ditto.
  • html/HTMLFormControlElement.cpp: Ditto.
  • html/HTMLFormElement.cpp: Ditto.
  • html/HTMLFrameElement.cpp: Ditto.
  • html/HTMLFrameElementBase.cpp: Ditto.
  • html/HTMLFrameSetElement.cpp: Ditto.
  • html/HTMLHRElement.cpp: Ditto.
  • html/HTMLIFrameElement.cpp: Ditto.
  • html/HTMLImageElement.cpp: Ditto.
  • html/HTMLInputElement.cpp: Ditto.
  • html/HTMLIsIndexElement.cpp: Ditto.
  • html/HTMLKeygenElement.cpp: Ditto.
  • html/HTMLLIElement.cpp: Ditto.
  • html/HTMLLinkElement.cpp: Ditto.
  • html/HTMLMarqueeElement.cpp: Ditto.
  • html/HTMLMetaElement.cpp: Ditto.
  • html/HTMLOListElement.cpp: Ditto.
  • html/HTMLObjectElement.cpp: Ditto.
  • html/HTMLOptionElement.cpp: Ditto.
  • html/HTMLParagraphElement.cpp: Ditto.
  • html/HTMLParamElement.cpp: Ditto.
  • html/HTMLPlugInElement.cpp: Ditto.
  • html/HTMLPreElement.cpp: Ditto.
  • html/HTMLScriptElement.cpp: Ditto.
  • html/HTMLSelectElement.cpp: Ditto.
  • html/HTMLStyleElement.cpp: Ditto.
  • html/HTMLTableCaptionElement.cpp: Ditto.
  • html/HTMLTableCellElement.cpp: Ditto.
  • html/HTMLTableColElement.cpp: Ditto.
  • html/HTMLTablePartElement.cpp: Ditto.
  • html/HTMLTextAreaElement.cpp: Ditto.
  • html/HTMLTokenizer.cpp: Ditto.
  • html/HTMLUListElement.cpp: Ditto.
  • html/HTMLVideoElement.cpp: Ditto.
  • html/HTMLViewSourceDocument.cpp: Ditto.
  • loader/ImageDocument.cpp: Ditto.
  • page/Frame.cpp: Ditto.
  • rendering/RenderTreeAsText.cpp: Ditto.
  • svg/SVGAElement.cpp: Ditto.
  • svg/SVGAnimateMotionElement.cpp: Ditto.
  • svg/SVGAnimateTransformElement.cpp: Ditto.
  • svg/SVGAnimationElement.cpp: Ditto.
  • svg/SVGCircleElement.cpp: Ditto.
  • svg/SVGClipPathElement.cpp: Ditto.
  • svg/SVGCursorElement.cpp: Ditto.
  • svg/SVGElement.cpp: Ditto.
  • svg/SVGEllipseElement.cpp: Ditto.
  • svg/SVGExternalResourcesRequired.cpp: Ditto.
  • svg/SVGFitToViewBox.cpp: Ditto.
  • svg/SVGFontFaceElement.cpp: Ditto.
  • svg/SVGFontFaceUriElement.cpp: Ditto.
  • svg/SVGForeignObjectElement.cpp: Ditto.
  • svg/SVGGlyphElement.cpp: Ditto.
  • svg/SVGGradientElement.cpp: Ditto.
  • svg/SVGImageElement.cpp: Ditto.
  • svg/SVGLangSpace.cpp: Ditto.
  • svg/SVGLineElement.cpp: Ditto.
  • svg/SVGLinearGradientElement.cpp: Ditto.
  • svg/SVGMarkerElement.cpp: Ditto.
  • svg/SVGMaskElement.cpp: Ditto.
  • svg/SVGPathElement.cpp: Ditto.
  • svg/SVGPatternElement.cpp: Ditto.
  • svg/SVGPolyElement.cpp: Ditto.
  • svg/SVGRadialGradientElement.cpp: Ditto.
  • svg/SVGRectElement.cpp: Ditto.
  • svg/SVGSVGElement.cpp: Ditto.
  • svg/SVGScriptElement.cpp: Ditto.
  • svg/SVGStopElement.cpp: Ditto.
  • svg/SVGStyleElement.cpp: Ditto.
  • svg/SVGStyledElement.cpp: Ditto.
  • svg/SVGStyledTransformableElement.cpp: Ditto.
  • svg/SVGTests.cpp: Ditto.
  • svg/SVGTextContentElement.cpp: Ditto.
  • svg/SVGTextElement.cpp: Ditto.
  • svg/SVGTextPathElement.cpp: Ditto.
  • svg/SVGTextPositioningElement.cpp: Ditto.
  • svg/SVGURIReference.cpp: Ditto.
  • svg/SVGUseElement.cpp: Ditto.
  • svg/SVGViewElement.cpp: Ditto.
  • svg/animation/SVGSMILElement.cpp: Ditto.
  • xml/XPathStep.cpp: Ditto.

WebKit/mac:

2009-05-04 Darin Adler <Darin Adler>

Reviewed by Eric Seidel.

Bug 24924: remove Document.h include of Attr.h and HTMLCollection.h,
and NamedMappedAttrMap.h include of MappedAttribute.h
​https://bugs.webkit.org/show_bug.cgi?id=24924

  • WebView/WebFrame.mm: Added include of CSSMutableStyleDeclaration.h and ScriptValue.h.
10:57 AM Changeset in webkit [43186] by kevino@webkit.org
  • 8 edits
    7 adds in trunk

Initial DRT implementation for wx.

10:50 AM Changeset in webkit [43185] by pkasting@chromium.org
  • 2 edits in trunk/WebCore

2009-05-04 Pavel Feldman <​pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Do not instantiate hidden WebInspector panels. Otherwise they are hitting unimplemented InspectorController methods.
​https://bugs.webkit.org/show_bug.cgi?id=25520

10:02 AM Changeset in webkit [43184] by Darin Adler
  • 3 edits in trunk/LayoutTests

2009-05-04 Darin Adler <Darin Adler>

Reviewed by Adam Roben.

  • media/video-size-intrinsic-scale-expected.txt: Changed to match test.
  • media/video-size-intrinsic-scale.html: Removed doubled "Movie" word.
9:20 AM Changeset in webkit [43183] by beidson@apple.com
  • 2 edits in trunk/WebCore

2009-05-04 Brady Eidson <​beidson@apple.com>

Reviewed by Darin Adler.

<rdar://problem/6839881> With "Mail Contents of This Page" in Safari images don't appear in the Tiger Mail compose window

DocumentLoader::subresource() is the implementation for the WebKit API [WebDataSource subresourceForURL:] and has
particularly sticky behavior.

If the DocumentLoader represents a WebArchive, this method should return ArchiveResources from that archive. However, we
prefer CachedResources over ArchiveResources because they might represent fresher data than what was originally loaded
from the WebArchive.

In some instances, CachedResources are created and associated with the DocumentLoader but not immediately run through the
loading delegate machinery. This was always a possibility, but the Preload Scanner made this significantly more likely.

When this happens and someone asks the WebDataSource for a subresource, it would prefer the CachedResource over an
ArchiveResource it has even if the CachedResource hasn't been loaded yet. The CachedResource has nil data, so no
WebResource is returned, and the client thinks the subresource doesn't exist even though it does.

This broke Tiger Mail and probably various other WebKit applications but has a fairly straightforward fix.

  • loader/DocumentLoader.cpp: (WebCore::DocumentLoader::subresource): If there is a CachedResource but it hasn't been loaded yet, fallback to the ArchiveResource.
8:56 AM Changeset in webkit [43182] by eric.carlson@apple.com
  • 6 edits
    1 add in trunk

2009-05-04 Eric Carlson <​eric.carlson@apple.com>

Reviewed by Adam Roben.


​https://bugs.webkit.org/show_bug.cgi?id=25545
Bug 25545: HTMLMediaElement: display anamorphic video correctly


Tell QuickTime to use clean aperture mode so movies with non-square pixels are sized
and displayed correctly.

  • platform/graphics/mac/MediaPlayerPrivateQTKit.mm: (WebCore::MediaPlayerPrivate::createQTMovie): Ask QuickTime to use clean aperture mode.
  • platform/graphics/win/QTMovieWin.cpp: (QTMovieWin::load): Ditto. Add ASSERT to ensure that static movie property array isn't filled beyond capacity.

2009-05-04 Eric Carlson <​eric.carlson@apple.com>

Reviewed by Adam Roben.

​https://bugs.webkit.org/show_bug.cgi?id=25545
Bug 25545: HTMLMediaElement: display anamorphic video correctly


Added 720x576i PAL anamorphic movie, extended video-size-intrinsic-scale
test to check that it is sized correctly.

  • media/content/720x576i-anamorphic.mov: Added.
  • media/video-size-intrinsic-scale-expected.txt:
  • media/video-size-intrinsic-scale.html:
8:38 AM Changeset in webkit [43181] by mrowe@apple.com
  • 2 edits in trunk/WebCore

Fix <​https://bugs.webkit.org/show_bug.cgi?id=25332>.
Bug 25332: Plug-in inserted in to DOM of PluginDocument fails to load

Reviewed by Darin Adler.

Only the first plug-in in a PluginDocument can use the main resource data. For all
subsequent plug-ins, such as the plug-in that ClickToFlash inserts when swapping itself
out for the real Flash plug-in, we need to load the resource data in the same manner
as for other embedded plug-ins.

  • loader/FrameLoader.cpp:

(WebCore::FrameLoader::loadPlugin):

8:25 AM Changeset in webkit [43180] by Simon Hausmann
  • 2 edits in trunk/WebCore

2009-05-04 Simon Hausmann <​simon.hausmann@nokia.com>

Rubber-stamped by Ariya Hidayat.

Update the qrc file for the Web Inspector in the Qt build
with missing files.

12:17 AM Changeset in webkit [43179] by eric@webkit.org
  • 7 edits in trunk/WebCore

Reviewed by George Staikos.

Move absoluteRects and absoluteQuads into RenderSVGInline and remove absoluteTransform() usage
​https://bugs.webkit.org/show_bug.cgi?id=25532

  • rendering/RenderSVGInline.cpp: (WebCore::RenderSVGInline::absoluteRects): (WebCore::RenderSVGInline::absoluteQuads):
  • rendering/RenderSVGInline.h:
  • rendering/RenderSVGTSpan.cpp:
  • rendering/RenderSVGTSpan.h:
  • rendering/RenderSVGTextPath.cpp:
  • rendering/RenderSVGTextPath.h:
12:17 AM Changeset in webkit [43178] by eric@webkit.org
  • 2 edits in trunk/WebCore

Reviewed by George Staikos.

Move RenderSVGText off of localToAbsolute()
​https://bugs.webkit.org/show_bug.cgi?id=25532

  • rendering/RenderSVGText.cpp: (WebCore::RenderSVGText::absoluteRects): (WebCore::RenderSVGText::absoluteQuads):
12:16 AM Changeset in webkit [43177] by eric@webkit.org
  • 11 edits in trunk

Reviewed by George Staikos.

Remove broken absoluteTransform() code from RenderSVGInlineText
​https://bugs.webkit.org/show_bug.cgi?id=25532

This improved SVG text focus rings.
This also improved SVG.getScreenCTM() results.

SVGSVGElement::getScreenCTM was passing "true" for the second argument in
localToAbsolute, which is "fixed" it meant to pass "true" for the
third argument (useTransforms). That change alone caused no layout test changes, however
before I fixed this, it was hitting ASSERT(!fixed) in RenderSVGRoot::mapLocalToContainer

mapLocalToContainer implementations really should be shared,
but I'll do that in a later patch.

  • rendering/RenderSVGInlineText.cpp: (WebCore::RenderSVGInlineText::styleDidChange): (WebCore::RenderSVGInlineText::absoluteQuads): (WebCore::RenderSVGInlineText::computeRepaintRectForRange): (WebCore::RenderSVGInlineText::computeRepaintQuadForRange):
  • rendering/RenderSVGInlineText.h:
  • rendering/RenderSVGRoot.cpp: (WebCore::RenderSVGRoot::mapLocalToContainer):
  • rendering/RenderSVGRoot.h:
  • rendering/RenderSVGText.cpp: (WebCore::RenderSVGText::mapLocalToContainer):
  • rendering/RenderSVGText.h:
  • svg/SVGSVGElement.cpp: (WebCore::SVGSVGElement::getScreenCTM):
12:15 AM Changeset in webkit [43176] by eric@webkit.org
  • 3 edits in trunk/WebCore

Reviewed by George Staikos.

Remove dead code from RenderPath
​https://bugs.webkit.org/show_bug.cgi?id=25532

  • rendering/RenderPath.cpp:
  • rendering/RenderPath.h:
12:15 AM Changeset in webkit [43175] by eric@webkit.org
  • 5 edits in trunk/WebCore

Reviewed by George Staikos.

Share layout code between RenderSVGViewportContainer and RenderSVGContainer
​https://bugs.webkit.org/show_bug.cgi?id=25532

  • rendering/RenderSVGContainer.cpp: (WebCore::RenderSVGContainer::layout):
  • rendering/RenderSVGContainer.h: (WebCore::RenderSVGContainer::calcViewport):
  • rendering/RenderSVGViewportContainer.cpp: (WebCore::RenderSVGViewportContainer::applyViewportClip):
  • rendering/RenderSVGViewportContainer.h:
12:15 AM Changeset in webkit [43174] by eric@webkit.org
  • 4 edits in trunk/WebCore

Reviewed by George Staikos.

Remove redundant disableLayoutState() calls
​https://bugs.webkit.org/show_bug.cgi?id=25532

  • rendering/RenderForeignObject.cpp: (WebCore::RenderForeignObject::layout):
  • rendering/RenderSVGContainer.cpp: (WebCore::RenderSVGContainer::layout):
  • rendering/RenderSVGViewportContainer.cpp: (WebCore::RenderSVGViewportContainer::layout):
12:14 AM Changeset in webkit [43173] by eric@webkit.org
  • 2 edits
    4 adds in trunk

Reviewed by George Staikos.

Simplify RenderForeignObject::paint and fix a repaint bug.
Paint now calls applyTransformToPaintInfo which correctly transforms the damage rect.
​https://bugs.webkit.org/show_bug.cgi?id=16939

  • rendering/RenderForeignObject.cpp: (WebCore::RenderForeignObject::paint):

May 3, 2009:

11:46 PM Changeset in webkit [43172] by sfalken@apple.com
  • 2 edits in tags/Safari-6530.8.2/JavaScriptCore

Merged r43169.

11:39 PM Changeset in webkit [43171] by eric@webkit.org
  • 1 edit
    2 adds in trunk/LayoutTests

No review, just adding missing results.

Add Win results for editing/spelling/spellcheck-attribute
Pixel results are still missing, but I have no easy way
to add them, and the bots aren't generating them currently.

  • platform/win/editing/spelling/spellcheck-attribute-expected.txt: Added.
11:37 PM Changeset in webkit [43170] by sfalken@apple.com
  • 1 copy in tags/Safari-6530.8.2

New tag.

11:36 PM Changeset in webkit [43169] by sfalken@apple.com
  • 2 edits in trunk/JavaScriptCore

Windows build fix.

11:05 PM Changeset in webkit [43168] by eric@webkit.org
  • 4 edits
    4 adds in trunk

2009-05-03 Hironori Bono <​hbono@chromium.org>

Reviewed by Eric Seidel.

Test: editing/spelling/spellcheck-attribute.html

Bug 14552: Add a way to disable spell checking for specific element
​https://bugs.webkit.org/show_bug.cgi?id=14552

For compatibility with Firefox, this code ascends the DOM tree when an element does
not have its "spellcheck" attribute.

  • editing/Editor.cpp: (WebCore::markMisspellingsOrBadGrammar): Retrieve the value of the "spellcheck" attribute of an element before calling a spell checker or a grammar checker.
  • html/HTMLAttributeNames.in: Add a "spellcheck" attribute.
7:00 PM Changeset in webkit [43167] by kov@webkit.org
  • 2 edits in trunk/LayoutTests

2009-05-03 Gustavo Noronha Silva <Gustavo Noronha Silva>

Three more failing tests caused by the disabling of the others.

  • platform/gtk/Skipped:
6:38 PM Changeset in webkit [43166] by kov@webkit.org
  • 2 edits in trunk/LayoutTests

2009-05-03 Gustavo Noronha Silva <Gustavo Noronha Silva>

Disable more tests that fail on the bot, and those which fail when
we disable some. Hopefully this finishes our massage to the
skipped list and we can go back to working on fixing tests now.

  • platform/gtk/Skipped:
5:42 PM Changeset in webkit [43165] by mrowe@apple.com
  • 4 edits in trunk/JavaScriptCore

Fix the 64-bit build.

  • API/APICast.h:

(toJS):
(toRef):

  • runtime/JSNumberCell.cpp:

(JSC::jsAPIMangledNumber):

  • runtime/JSNumberCell.h:
4:25 PM Changeset in webkit [43164] by eric@webkit.org
  • 3 edits in trunk/LayoutTests

Reviewed by Sam Weinig.

Dump more metrics from svgsvgelement-ctm test.
(And break up the first SVG into two SVGs for easier reading of the metrics)

  • svg/custom/svgsvgelement-ctm-expected.txt:
  • svg/custom/svgsvgelement-ctm.xhtml:
2:57 PM QtWebKitJournal edited by Simon Hausmann
(diff)
2:54 PM QtWebKitTodo edited by Simon Hausmann
(diff)
2:44 PM Changeset in webkit [43163] by kov@webkit.org
  • 2 edits in trunk/LayoutTests

2009-05-03 Gustavo Noronha Silva <Gustavo Noronha Silva>

Some tests are still failing on the bot, despite working
locally. Disabling for now.

  • platform/gtk/Skipped:
2:41 PM Changeset in webkit [43162] by weinig@apple.com
  • 1 copy in branches/nitro-extreme

New branch

2:32 PM Changeset in webkit [43161] by kov@webkit.org
  • 2 edits in trunk/LayoutTests

2009-05-03 Zan Dobersek <​zandobersek@gmail.com>

Reviewed by Gustavo Noronha.

Enable more tests that succeed and style up the list a bit.

  • platform/gtk/Skipped:
2:02 PM Changeset in webkit [43160] by weinig@apple.com
  • 18 edits in trunk

JavaScriptCore:

2009-05-02 Sam Weinig <​sam@webkit.org>

Roll JSC API number marshaling back in one last time (I hope).

WebCore:

2009-05-03 Sam Weinig <​sam@webkit.org>

Roll JSC API number marshaling back in one last time (I hope).

1:59 PM Changeset in webkit [43159] by weinig@apple.com
  • 2 edits in trunk/WebKitTools

2009-05-03 Sam Weinig <​sam@webkit.org>

Reviewed by Geoffrey Garen.

Don't pass an exception parameter if we don't care about the value.

  • DumpRenderTree/win/EventSender.cpp: (keyDownCallback):
12:56 PM Changeset in webkit [43158] by weinig@apple.com
  • 18 edits in trunk

JavaScriptCore:

2009-05-03 Sam Weinig <​sam@webkit.org>

Roll JSC API number marshaling back out. It still breaks windows.

WebCore:

2009-05-03 Sam Weinig <​sam@webkit.org>

Roll JSC API number marshaling back out. It still breaks windows.

12:27 PM Changeset in webkit [43157] by weinig@apple.com
  • 18 edits in trunk

JavaScriptCore:

2009-05-02 Sam Weinig <​sam@webkit.org>

Roll JSC API number marshaling back in.

WebCore:

2009-05-02 Sam Weinig <​sam@webkit.org>

Roll JSC API number marshaling back in.

9:49 AM Changeset in webkit [43156] by Darin Adler
  • 9 edits in trunk/JavaScriptCore

2009-05-02 Darin Adler <Darin Adler>

Reviewed by Maciej Stachowiak.

Bug 25519: streamline lexer by handling BOMs differently
​https://bugs.webkit.org/show_bug.cgi?id=25519

Roughly 1% faster SunSpider.

  • parser/Grammar.y: Tweak formatting a bit.
  • parser/Lexer.cpp: (JSC::Lexer::Lexer): Remove unnnecessary initialization of data members that are set up by setCode. (JSC::Lexer::currentOffset): Added. Used where the old code would look at m_currentOffset. (JSC::Lexer::shift1): Replaces the old shift function. No longer does anything to handle BOM characters. (JSC::Lexer::shift2): Ditto. (JSC::Lexer::shift3): Ditto. (JSC::Lexer::shift4): Ditto. (JSC::Lexer::setCode): Updated for name change from yylineno to m_line. Removed now-unused m_eatNextIdentifier, m_stackToken, and m_restrKeyword. Replaced m_skipLF and m_skipCR with m_skipLineEnd. Replaced the old m_length with m_codeEnd and m_currentOffset with m_codeStart. Added code to scan for a BOM character and call copyCodeWithoutBOMs() if we find any. (JSC::Lexer::copyCodeWithoutBOMs): Added. (JSC::Lexer::nextLine): Updated for name change from yylineno to m_line. (JSC::Lexer::makeIdentifier): Moved up higher in the file. (JSC::Lexer::matchPunctuator): Moved up higher in the file and changed to use a switch statement instead of just if statements. (JSC::Lexer::isLineTerminator): Moved up higher in the file and changed to have fewer branches. (JSC::Lexer::lastTokenWasRestrKeyword): Added. This replaces the old m_restrKeyword boolean. (JSC::Lexer::isIdentStart): Moved up higher in the file. Changed to use fewer branches in the ASCII but not identifier case. (JSC::Lexer::isIdentPart): Ditto. (JSC::Lexer::singleEscape): Moved up higher in the file. (JSC::Lexer::convertOctal): Moved up higher in the file. (JSC::Lexer::convertHex): Moved up higher in the file. Changed to use toASCIIHexValue instead of rolling our own here. (JSC::Lexer::convertUnicode): Ditto. (JSC::Lexer::record8): Moved up higher in the file. (JSC::Lexer::record16): Moved up higher in the file. (JSC::Lexer::lex): Changed type of stringType to int. Replaced m_skipLF and m_skipCR with m_skipLineEnd, which requires fewer branches in the main lexer loop. Use currentOffset instead of m_currentOffset. Removed unneeded m_stackToken. Use isASCIIDigit instead of isDecimalDigit. Split out the two cases for InIdentifierOrKeyword and InIdentifier. Added special case tight loops for identifiers and other simple states. Removed a branch from the code that sets m_atLineStart to false using goto. Streamlined the number-handling code so we don't check for the same types twice for non-numeric cases and don't add a null to m_buffer8 when it's not being used. Removed m_eatNextIdentifier, which wasn't working anyway, and m_restrKeyword, which is redundant with m_lastToken. Set the m_delimited flag without using a branch. (JSC::Lexer::scanRegExp): Tweaked style a bit. (JSC::Lexer::clear): Clear m_codeWithoutBOMs so we don't use memory after parsing. Clear out UString objects in the more conventional way. (JSC::Lexer::sourceCode): Made this no-longer inline since it has more work to do in the case where we stripped BOMs.
  • parser/Lexer.h: Renamed yylineno to m_lineNumber. Removed convertHex function, which is the same as toASCIIHexValue. Removed isHexDigit function, which is the same as isASCIIHedDigit. Replaced shift with four separate shift functions. Removed isWhiteSpace function that passes m_current, instead just passing m_current explicitly. Removed isOctalDigit, which is the same as isASCIIOctalDigit. Eliminated unused arguments from matchPunctuator. Added copyCoodeWithoutBOMs and currentOffset. Moved the makeIdentifier function out of the header. Added lastTokenWasRestrKeyword function. Added new constants for m_skipLineEnd. Removed unused yycolumn, m_restrKeyword, m_skipLF, m_skipCR, m_eatNextIdentifier, m_stackToken, m_position, m_length, m_currentOffset, m_nextOffset1, m_nextOffset2, m_nextOffset3. Added m_skipLineEnd, m_codeStart, m_codeEnd, and m_codeWithoutBOMs.
  • parser/SourceProvider.h: Added hasBOMs function. In the future this can be used to tell the lexer about strings known not to have BOMs.
  • runtime/JSGlobalObjectFunctions.cpp: (JSC::globalFuncUnescape): Changed to use isASCIIHexDigit.
  • wtf/ASCIICType.h: Added using statements to match the design of the other WTF headers.
Note: See TracTimeline for information about the timeline view.