⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



May 11, 2009:

11:45 PM Changeset in webkit [43557] by ggaren@apple.com
  • 3 edits in branches/nitro-extreme/JavaScriptCore

2009-05-07 Sam Weinig <​sam@webkit.org>

Reviewed by Geoffrey Garen.

Add some new MacroAssembler and assembler functions that will be needed shortly.

  • assembler/MacroAssemblerX86Common.h: (JSC::MacroAssemblerX86Common::add32): (JSC::MacroAssemblerX86Common::and32): (JSC::MacroAssemblerX86Common::mul32): (JSC::MacroAssemblerX86Common::neg32): (JSC::MacroAssemblerX86Common::or32): (JSC::MacroAssemblerX86Common::sub32): (JSC::MacroAssemblerX86Common::xor32): (JSC::MacroAssemblerX86Common::branchAdd32): (JSC::MacroAssemblerX86Common::branchMul32): (JSC::MacroAssemblerX86Common::branchSub32):
  • assembler/X86Assembler.h: (JSC::X86Assembler::): (JSC::X86Assembler::addl_rm): (JSC::X86Assembler::andl_mr): (JSC::X86Assembler::andl_rm): (JSC::X86Assembler::andl_im): (JSC::X86Assembler::negl_r): (JSC::X86Assembler::notl_r): (JSC::X86Assembler::orl_rm): (JSC::X86Assembler::orl_im): (JSC::X86Assembler::subl_rm): (JSC::X86Assembler::xorl_mr): (JSC::X86Assembler::xorl_rm): (JSC::X86Assembler::xorl_im): (JSC::X86Assembler::imull_mr):
11:41 PM Changeset in webkit [43556] by ggaren@apple.com
  • 5 edits in branches/nitro-extreme/JavaScriptCore

2009-05-11 Sam Weinig <​sam@webkit.org>

Reviewed by Cameron Zwarich.

Remove the NumberHeap.

  • JavaScriptCore.exp:
  • runtime/Collector.cpp: (JSC::Heap::Heap): (JSC::Heap::destroy): (JSC::Heap::recordExtraCost): (JSC::Heap::heapAllocate): (JSC::Heap::markConservatively): (JSC::Heap::sweep): (JSC::Heap::collect): (JSC::Heap::objectCount): (JSC::Heap::statistics): (JSC::typeName): (JSC::Heap::isBusy):
  • runtime/Collector.h: (JSC::Heap::globalData):
  • runtime/JSCell.h:
11:35 PM Changeset in webkit [43555] by beidson@apple.com
  • 1 edit in trunk/LayoutTests/ChangeLog

Update my ChangeLog entry to make Mark Rowe happy. Mark Rowe - who is supposed to be on vacation. Mark Rowe - who probably didn't even get to watch House tonight. Oh, I see - that's why he's grumpy.

11:33 PM Changeset in webkit [43554] by ggaren@apple.com
  • 38 edits
    1 copy
    3 deletes in branches/nitro-extreme

JavaScriptCore:

2009-05-11 Geoffrey Garen <​ggaren@apple.com>

Reviewed by Sam Weinig.

Land initial commit of new number representation for 32 bit platforms,
with JIT disabled.

  • API/APICast.h: (toJS): (toRef):
  • API/JSCallbackObjectFunctions.h: (JSC::::hasInstance): (JSC::::toNumber): (JSC::::toString):
  • API/tests/testapi.c: (EvilExceptionObject_convertToType):
  • AllInOneFile.cpp:
  • JavaScriptCore.exp:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • bytecode/CodeBlock.cpp: (JSC::valueToSourceString):
  • bytecompiler/BytecodeGenerator.cpp: (JSC::BytecodeGenerator::emitLoad): (JSC::BytecodeGenerator::emitUnexpectedLoad): (JSC::keyForImmediateSwitch):
  • bytecompiler/BytecodeGenerator.h:
  • interpreter/Interpreter.cpp: (JSC::Interpreter::dumpRegisters): (JSC::Interpreter::privateExecute):
  • parser/Nodes.cpp: (JSC::ArrayNode::emitBytecode): (JSC::processClauseList):
  • runtime/ArgList.h:
  • runtime/Collector.h: (JSC::sizeof):
  • runtime/DateMath.cpp:
  • runtime/ExceptionHelpers.h:
  • runtime/InitializeThreading.cpp:
  • runtime/JSArray.cpp: (JSC::JSArray::JSArray):
  • runtime/JSCell.cpp:
  • runtime/JSCell.h: (JSC::JSCell::isAPIValueWrapper): (JSC::JSValue::isString): (JSC::JSValue::isGetterSetter): (JSC::JSValue::isObject): (JSC::JSValue::getString): (JSC::JSValue::getObject): (JSC::JSValue::getCallData): (JSC::JSValue::getConstructData): (JSC::JSValue::getUInt32): (JSC::JSValue::marked): (JSC::JSValue::toPrimitive): (JSC::JSValue::getPrimitiveNumber): (JSC::JSValue::toBoolean): (JSC::JSValue::toNumber): (JSC::JSValue::toString): (JSC::JSValue::needsThisConversion): (JSC::JSValue::toThisString): (JSC::JSValue::getJSNumber): (JSC::JSValue::toObject): (JSC::JSValue::toThisObject):
  • runtime/JSGlobalData.cpp: (JSC::JSGlobalData::JSGlobalData):
  • runtime/JSGlobalData.h:
  • runtime/JSGlobalObject.h: (JSC::Structure::prototypeForLookup):
  • runtime/JSGlobalObjectFunctions.cpp: (JSC::globalFuncParseInt):
  • runtime/JSImmediate.h:
  • runtime/JSNumberCell.cpp: Removed.
  • runtime/JSNumberCell.h: Removed.
  • runtime/JSObject.h: (JSC::JSValue::get): (JSC::JSValue::put):
  • runtime/JSString.h: (JSC::JSValue::toThisJSString):
  • runtime/JSValue.cpp: (JSC::JSValue::toInteger): (JSC::JSValue::toIntegerPreserveNaN): (JSC::JSValue::toObjectSlowCase): (JSC::JSValue::toThisObjectSlowCase): (JSC::JSValue::synthesizeObject): (JSC::JSValue::synthesizePrototype): (JSC::JSValue::description): (JSC::nonInlineNaN):
  • runtime/JSValue.h: (JSC::JSValue::): (JSC::EncodedJSValueHashTraits::emptyValue): (JSC::jsNaN): (JSC::operator==): (JSC::operator!=): (JSC::toInt32): (JSC::toUInt32): (JSC::JSValue::encode): (JSC::JSValue::decode): (JSC::JSValue::JSValue): (JSC::JSValue::operator bool): (JSC::JSValue::operator==): (JSC::JSValue::operator!=): (JSC::JSValue::isUndefined): (JSC::JSValue::isNull): (JSC::JSValue::isUndefinedOrNull): (JSC::JSValue::isCell): (JSC::JSValue::isInt32): (JSC::JSValue::isUInt32): (JSC::JSValue::isDouble): (JSC::JSValue::isTrue): (JSC::JSValue::isFalse): (JSC::JSValue::tag): (JSC::JSValue::asInt32): (JSC::JSValue::asUInt32): (JSC::JSValue::asDouble): (JSC::JSValue::asCell): (JSC::JSValue::isNumber): (JSC::JSValue::isBoolean): (JSC::JSValue::getBoolean): (JSC::JSValue::uncheckedGetNumber): (JSC::JSValue::toJSNumber): (JSC::JSValue::getNumber): (JSC::JSValue::toInt32): (JSC::JSValue::toUInt32):
  • runtime/Operations.h: (JSC::JSValue::equal): (JSC::JSValue::equalSlowCaseInline): (JSC::JSValue::strictEqual): (JSC::JSValue::strictEqualSlowCaseInline): (JSC::jsLess): (JSC::jsLessEq): (JSC::jsAdd):
  • runtime/PropertySlot.h:
  • runtime/StringPrototype.cpp: (JSC::stringProtoFuncCharAt): (JSC::stringProtoFuncCharCodeAt): (JSC::stringProtoFuncIndexOf):
  • wtf/Platform.h:

WebCore:

2009-05-11 Geoffrey Garen <​ggaren@apple.com>

Reviewed by Sam Weinig.

Make WebCore compile with the new JS number representation.

  • ForwardingHeaders/runtime/JSAPIValueWrapper.h: Added.
  • ForwardingHeaders/runtime/JSNumberCell.h: Removed.
  • bindings/js/ScriptEventListener.cpp:
  • bindings/scripts/CodeGeneratorJS.pm:
  • bridge/c/c_instance.cpp:
11:21 PM Changeset in webkit [43553] by barraclough@apple.com
  • 4 edits in trunk/JavaScriptCore

2009-05-11 Gavin Barraclough <​barraclough@apple.com>

Reviewed by Oliver Hunt.

Enable use of SamplingFlags directly from JIT code.

  • bytecode/SamplingTool.h:
  • jit/JIT.h: (JSC::JIT::sampleCodeBlock): (JSC::JIT::sampleInstruction):
  • jit/JITInlineMethods.h: (JSC::JIT::setSamplingFlag): (JSC::JIT::clearSamplingFlag):
10:49 PM Changeset in webkit [43552] by beidson@apple.com
  • 1 edit
    3 copies
    1 add in trunk/LayoutTests

2009-05-11 Brady Eidson <​beidson@apple.com>

Add a third copy of this test to make Tiger bots happy.

  • platform/mac-tiger/fast/images: Added.
  • platform/mac-tiger/fast/images/favicon-as-image-expected.checksum: Copied from platform/mac/fast/images/favicon-as-image-expected.checksum.
  • platform/mac-tiger/fast/images/favicon-as-image-expected.png: Copied from platform/mac/fast/images/favicon-as-image-expected.png.
  • platform/mac-tiger/fast/images/favicon-as-image-expected.txt: Copied from platform/mac/fast/images/favicon-as-image-expected.txt.
10:31 PM Changeset in webkit [43551] by barraclough@apple.com
  • 6 edits
    3 adds in trunk

JavaScriptCore:

2009-05-11 Gavin Barraclough <​barraclough@apple.com>

Reviewed by Cameron Zwarich.

Implement JIT generation for instanceof for non-objects (always returns false).
Also fixes the sequencing of the prototype and value isObject checks, to no match the spec.

0.5% progression on v8 tests overall, due to 3.5% on early-boyer.

  • jit/JIT.cpp: (JSC::JIT::privateCompileMainPass): (JSC::JIT::privateCompileSlowCases):
  • runtime/JSObject.cpp: (JSC::JSObject::hasInstance):
  • runtime/TypeInfo.h: (JSC::TypeInfo::TypeInfo):

LayoutTests:

2009-05-11 Gavin Barraclough <​barraclough@apple.com>

Reviewed by Oliver Hunt.

Add a layout test for instanceof.

  • fast/js/instance-of-immediates-expected.txt: Added.
  • fast/js/instance-of-immediates.html: Added.
  • fast/js/resources/instance-of-immediates.js: Added. (testInstanceOf): (): (testSet):
10:07 PM Changeset in webkit [43550] by zecke@webkit.org
  • 2 edits in trunk/WebCore

2009-05-11 Yael Aharon <​yael.aharon@nokia.com>

Reviewed by Holger Freyther.

Change Qt port to match the mac and windows ports, and unregister plugins when plugins are stopped.
Not doing that can cause assersion failure.
​https://bugs.webkit.org/show_bug.cgi?id=25702

  • plugins/qt/PluginViewQt.cpp: (WebCore::PluginView::stop):
10:02 PM Changeset in webkit [43549] by zecke@webkit.org
  • 2 edits in trunk/WebCore

2009-05-11 Laszlo Gombos <Laszlo Gombos>

Reviewed by Holger Freyther.

Bug 25714: [Qt] Decouple HTML5 Database support from the
SQLite/generic database support in the Qt port

<​https://bugs.webkit.org/show_bug.cgi?id=25714>

  • WebCore.pro:
9:37 PM Changeset in webkit [43548] by weinig@apple.com
  • 1 copy in branches/nitro-extreme

Create a new nitro-extreme branch

9:35 PM Changeset in webkit [43547] by weinig@apple.com
  • 1 move in branches/nitro-extreme-old

Move asside nitro-extreme branch

9:34 PM Changeset in webkit [43546] by weinig@apple.com
  • 1 delete in branches/nitro-extreme-rebase-1

Remove branch created in error

9:32 PM Changeset in webkit [43545] by weinig@apple.com
  • 1 copy in branches/nitro-extreme-rebase-1

Create new branch for rebasing

9:28 PM Changeset in webkit [43544] by mitz@apple.com
  • 44 edits in trunk/LayoutTests

Updated the svn:mime-type property of recently-updated PNG files to image/png

9:20 PM Changeset in webkit [43543] by ggaren@apple.com
  • 6 edits in trunk/JavaScriptCore

2009-05-11 Geoffrey Garen <​ggaren@apple.com>

Reviewed by Sam Weinig.


A little more JIT refactoring.


Rearranged code to more clearly indicate what's conditionally compiled
and why. Now, all shared code is at the top of our JIT files, and all
#if'd code is at the bottom. #if'd code is delineated by large comments.


Moved functions that relate to the JIT but don't explicitly do codegen
into JIT.cpp. Refactored SSE2 check to store its result as a data member
in the JIT.

  • jit/JIT.cpp: (JSC::isSSE2Present): (JSC::JIT::JIT): (JSC::JIT::unlinkCall): (JSC::JIT::linkCall):
  • jit/JIT.h: (JSC::JIT::isSSE2Present):
  • jit/JITArithmetic.cpp: (JSC::JIT::emit_op_mod): (JSC::JIT::emitSlow_op_mod):
  • jit/JITCall.cpp: (JSC::JIT::compileOpCallVarargs): (JSC::JIT::compileOpCallVarargsSlowCase):
9:18 PM Changeset in webkit [43542] by beidson@apple.com
  • 3 edits
    5 copies
    4 adds in trunk/LayoutTests

2009-05-11 Brady Eidson <​beidson@apple.com>

Reviewed by David Kilzer.

<rdar://problem/6876226> - Cleanup the fast/images/favicon situation a bit.

First off, copy fast/images/favicon-as-image.html over to http/tests/misc so it covers the original test case on all Mac platforms.
Second, add Leopard-specific results for the original test.
Then, remove it from the Leopard skipped list.
Finally, add it to the SnowLeopard skipped list (<rdar://problem/6877633> covers re-enabling it when we're no longer blocked).

  • http/tests/misc/favicon-as-image.html: Copied from fast/images/favicon-as-image.html.
  • http/tests/misc/resources/favicon.ico: Copied from fast/images/resources/favicon.ico.
  • platform/mac/http/tests/misc/favicon-as-image-expected.checksum: Added.
  • platform/mac/http/tests/misc/favicon-as-image-expected.png: Added.
  • platform/mac/http/tests/misc/favicon-as-image-expected.txt: Added.
  • platform/mac-leopard/fast/images: Added.
  • platform/mac-leopard/fast/images/favicon-as-image-expected.checksum: Copied from platform/mac/fast/images/favicon-as-image-expected.checksum.
  • platform/mac-leopard/fast/images/favicon-as-image-expected.png: Copied from platform/mac/fast/images/favicon-as-image-expected.png.
  • platform/mac-leopard/fast/images/favicon-as-image-expected.txt: Copied from platform/mac/fast/images/favicon-as-image-expected.txt.
  • platform/mac-leopard/Skipped:
  • platform/mac-snowleopard/Skipped:
8:25 PM Changeset in webkit [43541] by zecke@webkit.org
  • 2 edits in trunk/JavaScriptCore

[Qt] Build fix. Build JITOpcodes.cpp to resolve linking errors

7:31 PM Changeset in webkit [43540] by zecke@webkit.org
  • 2 edits in trunk/LayoutTests

[GTK] Disable layouttest that requires an AccessibilityController

DRT/GTK+ lacks an AccessibilityController do not run the
accessibility/onclick-handlers.thtml test.

  • platform/gtk/Skipped:
6:52 PM Changeset in webkit [43539] by weinig@apple.com
  • 2 edits in trunk/JavaScriptCore

2009-05-11 Sam Weinig <​sam@webkit.org>

Reviewed by Geoffrey Garen.

More re-factoring of JIT code generation. Use a macro to
forward the main switch-statement cases to the helper functions.

  • jit/JIT.cpp: (JSC::JIT::privateCompileMainPass): (JSC::JIT::privateCompileSlowCases):
6:50 PM Changeset in webkit [43538] by Chris Fleizach
  • 3 edits
    2 adds in trunk

Bug 25713: AX: Control Elements not identified in HTML content
​https://bugs.webkit.org/show_bug.cgi?id=25713

6:40 PM Changeset in webkit [43537] by weinig@apple.com
  • 4 edits in trunk/JavaScriptCore

2009-05-11 Sam Weinig <​sam@webkit.org>

Reviewed by Geoffrey Garen.

More re-factoring of JIT code generation to move opcode generation
to helper functions outside the main switch-statement and gave those
helper functions standardized names. This patch covers the remaining
slow cases.

  • jit/JIT.cpp:
  • jit/JIT.h:
  • jit/JITOpcodes.cpp:
6:33 PM Changeset in webkit [43536] by ggaren@apple.com
  • 2 edits in trunk/JavaScriptCore

2009-05-11 Geoffrey Garen <​ggaren@apple.com>

Build fix.

  • GNUmakefile.am: Added JITOpcodes.cpp and JITStubCall.h to the project.
6:30 PM Changeset in webkit [43535] by ggaren@apple.com
  • 2 edits in trunk/JavaScriptCore

2009-05-11 Geoffrey Garen <​ggaren@apple.com>

Build fix.

  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj: Added JITOpcodes.cpp and JITStubCall.h to the project.
6:26 PM Changeset in webkit [43534] by ggaren@apple.com
  • 9 edits
    1 copy in trunk/JavaScriptCore

2009-05-11 Geoffrey Garen <​ggaren@apple.com>

Reviewed by Sam Weinig.


Some JIT refactoring.


Moved JITStubCall* into its own header.


Modified JITStubCall to ASSERT that its return value is handled correctly.
Also, replaced function template with explicit instantiations to resolve
some confusion.


Replaced all uses of emit{Get,Put}CTIArgument with explicit peeks, pokes,
and calls to killLastResultRegister().

  • JavaScriptCore.xcodeproj/project.pbxproj:
  • jit/JIT.cpp: (JSC::JIT::privateCompileMainPass): (JSC::JIT::privateCompile):
  • jit/JIT.h:
  • jit/JITArithmetic.cpp:
  • jit/JITCall.cpp:
  • jit/JITInlineMethods.h: (JSC::JIT::restoreArgumentReference):
  • jit/JITPropertyAccess.cpp:
  • jit/JITStubCall.h: Copied from jit/JIT.h. (JSC::JITStubCall::JITStubCall): (JSC::JITStubCall::addArgument): (JSC::JITStubCall::call): (JSC::JITStubCall::):
6:25 PM Changeset in webkit [43533] by Darin Adler
  • 4 edits in trunk

WebCore:

2009-05-11 Darin Adler <Darin Adler>

Reviewed by Dan Bernstein.

<rdar://problem/6276843> REGRESSION: TextIterator generates
an extra newline for ranges that start outside of body

  • editing/TextIterator.cpp: (WebCore::TextIterator::shouldRepresentNodeOffsetZero): Check startPos for null, not just currPos.

LayoutTests:

2009-05-11 Darin Adler <Darin Adler>

Reviewed by Dan Bernstein.

<rdar://problem/6276843> REGRESSION: TextIterator generates
an extra newline for ranges that start outside of body

  • editing/text-iterator/basic-iteration-expected.txt: Expect success, not failure.
6:09 PM Changeset in webkit [43532] by Chris Fleizach
  • 2 edits in trunk/WebCore

Bug 25700: Regression:WebKit:cmd-left and cmd-right use to go to the beginning and end of a line in Mail
​https://bugs.webkit.org/show_bug.cgi?id=25700

6:06 PM Changeset in webkit [43531] by weinig@apple.com
  • 6 edits
    1 copy in trunk/JavaScriptCore

2009-05-11 Sam Weinig <​sam@webkit.org>

Reviewed by Geoffrey Garen.

Start re-factoring JIT code generation to move op_code generation
to helper functions outside the main switch-statement and gave those
helper functions standardized names. This patch only covers the main
pass and all the arithmetic opcodes in the slow path.

  • JavaScriptCore.xcodeproj/project.pbxproj:
  • jit/JIT.cpp: (JSC::JIT::privateCompileMainPass): (JSC::JIT::privateCompileSlowCases):
  • jit/JIT.h:
  • jit/JITArithmetic.cpp:
  • jit/JITOpcodes.cpp: Copied from jit/JIT.cpp.
  • jit/JITPropertyAccess.cpp:
5:48 PM Changeset in webkit [43530] by christian@webkit.org
  • 2 edits in trunk/WebKit/gtk

2009-05-11 Christian Dywan <​christian@twotoasts.de>

Reviewed by Gustavo Noronha.

​https://bugs.webkit.org/show_bug.cgi?id=25697
[GTK] Warnings building WebKit/gtk/tests/testwebframe.c

  • tests/testwebframe.c: (test_webkit_web_frame_create_destroy): Declare webView as a GtkWidget* to fix pointer type incompatibility warnings.
5:28 PM Changeset in webkit [43529] by kov@webkit.org
  • 2 edits
    2 adds in trunk/LayoutTests

2009-05-11 Gustavo Noronha Silva <​gustavo.noronha@collabora.co.uk>

Enable the new passing test, and skip two new failing tests.

  • platform/gtk/Skipped:
  • platform/gtk/fast/css/compare-content-style-expected.txt: Added.
5:14 PM Changeset in webkit [43528] by ddkilzer@apple.com
  • 54 edits in trunk/WebCore

Bug 25087: Test for ENABLE_FOO macros consistently in IDL files

<​https://bugs.webkit.org/show_bug.cgi?id=25087>

Reviewed by Timothy Hatcher.

Change tests for ENABLE macros to check for both existence and
value:

Negative: #if !defined(ENABLE_FOO)
!ENABLE_FOO
  • Positive: #if defined(ENABLE_FOO) && ENABLE_FOO
  • css/CSSCharsetRule.idl:
  • css/CSSPrimitiveValue.idl:
  • css/RGBColor.idl:
  • dom/Attr.idl:
  • dom/DOMCoreException.idl:
  • dom/DOMImplementation.idl:
  • dom/Document.idl:
  • dom/Element.idl:
  • dom/Event.idl:
  • dom/EventException.idl:
  • dom/KeyboardEvent.idl:
  • dom/MessagePort.idl:
  • dom/MouseEvent.idl:
  • dom/Node.idl:
  • dom/ProcessingInstruction.idl:
  • dom/Range.idl:
  • dom/RangeException.idl:
  • dom/WheelEvent.idl:
  • html/CanvasPixelArray.idl:
  • html/HTMLAnchorElement.idl:
  • html/HTMLAppletElement.idl:
  • html/HTMLAreaElement.idl:
  • html/HTMLBaseFontElement.idl:
  • html/HTMLCanvasElement.idl:
  • html/HTMLDocument.idl:
  • html/HTMLElement.idl:
  • html/HTMLEmbedElement.idl:
  • html/HTMLFrameElement.idl:
  • html/HTMLIFrameElement.idl:
  • html/HTMLImageElement.idl:
  • html/HTMLInputElement.idl:
  • html/HTMLLinkElement.idl:
  • html/HTMLObjectElement.idl:
  • html/HTMLOptionElement.idl:
  • html/HTMLOptionsCollection.idl:
  • html/HTMLSelectElement.idl:
  • html/HTMLStyleElement.idl:
  • html/ImageData.idl:
  • inspector/InspectorController.idl:
  • loader/appcache/DOMApplicationCache.idl:
  • page/Console.idl:
  • page/Coordinates.idl:
  • page/DOMSelection.idl:
  • page/DOMWindow.idl:
  • page/Geoposition.idl:
  • page/History.idl:
  • page/Location.idl:
  • page/Navigator.idl:
  • svg/SVGElementInstance.idl:
  • svg/SVGException.idl:
  • workers/WorkerContext.idl:
  • xml/XMLHttpRequestException.idl:
  • xml/XPathException.idl:
5:03 PM Changeset in webkit [43527] by Darin Adler
  • 2 edits in trunk

Added missing bug titles and URLs.

5:01 PM Changeset in webkit [43526] by Darin Adler
  • 11 edits in trunk

WebCore:

2009-05-11 Norbert Leser <​norbert.leser@nokia.com>

Reviewed by Darin Adler.

class/struct mix-up in forward declarations

  • inspector/InspectorResource.h:
  • loader/CachedFont.h:
  • loader/appcache/ApplicationCache.h:
  • rendering/RenderBlock.h:
  • rendering/RootInlineBox.h:
  • rendering/SVGInlineTextBox.h:
  • svg/SVGGlyphElement.h:
  • svg/SVGHKernElement.h:

WebKit/qt:

2009-05-11 Norbert Leser <​norbert.leser@nokia.com>

Reviewed by Darin Adler.

class/struct mix-up in forward declarations

  • Api/qwebpage.h:
4:57 PM Changeset in webkit [43525] by sfalken@apple.com
  • 93 edits in tags/Safari-6530.9.1/JavaScriptCore

Merge r43520.

4:57 PM Changeset in webkit [43524] by sfalken@apple.com
  • 2 edits
    2 copies in tags/Safari-6530.9.1/SunSpider

Merge r43519.

4:54 PM Changeset in webkit [43523] by Darin Adler
  • 2 edits in trunk/WebCore

2009-05-11 Norbert Leser <​norbert.leser@nokia.com>

Reviewed by Darin Adler.

The Symbian tools can't compile and link this without this include.
It's not clear why this is different from other toolsets or why it affects
only this header file, but adding the include for now.

  • editing/RemoveCSSPropertyCommand.h: Added include of CSSMutableStyleDeclaration.h.
4:35 PM Changeset in webkit [43522] by alice.liu@apple.com
  • 5 edits
    3 adds in trunk

WebCore:

2009-05-11 Alice Liu <​alice.liu@apple.com>

Reviewed by Dan Bernstein.

​https://bugs.webkit.org/show_bug.cgi?id=25701
REGRESSION(r38788 & r42020): styled searchfields look wrong on Windows, affects Facebook

Test: fast/forms/search-styled.html

  • css/themeWin.css: Remove the overriding of -webkit-appearance for searchfields. This will cause background images to not be honored when styling searchfields
  • rendering/RenderThemeWin.cpp: (WebCore::RenderThemeWin::adjustSearchFieldStyle):
  • rendering/RenderThemeWin.h: Re-instate final adjustments to searchfield styling that were removed in r42020

LayoutTests:

2009-05-11 Alice Liu <​alice.liu@apple.com>

Reviewed by Dan Bernstein.

​https://bugs.webkit.org/show_bug.cgi?id=25701
REGRESSION(r38788 & r42020): styled searchfields look wrong on Windows, affects Facebook

  • fast/forms/search-styled.html: Added.
  • platform/mac/fast/forms/search-styled-expected.txt: Added.
  • platform/win/fast/forms/search-styled-expected.txt: Added.
4:33 PM Changeset in webkit [43521] by sfalken@apple.com
  • 1 copy in tags/Safari-6530.9.1

New tag.

4:02 PM Changeset in webkit [43520] by sfalken@apple.com
  • 7 edits in trunk/JavaScriptCore

Re-add experimental PGO configs.


Reviewed by Adam Roben.

3:54 PM Changeset in webkit [43519] by sfalken@apple.com
  • 1 edit
    2 adds in trunk/SunSpider

Include SunSpider tests in production builds.


Reviewed by Adam Roben.

  • SunSpider.make: Added.
  • xcopy.excludes: Added.
3:00 PM Changeset in webkit [43518] by beidson@apple.com
  • 2 edits in trunk/WebCore

2009-05-11 Brady Eidson <​beidson@apple.com>

Fix Windows build

  • platform/network/cf/ResourceHandleCFNet.cpp: (WebCore::createCFURLResponseWithDefaultMIMEType):
3:00 PM Changeset in webkit [43517] by Dimitri Glazkov
  • 2 edits in trunk/WebCore

2009-05-11 Nate Chapin <​japhet@google.com>

Reviewed by Dimitri Glazkov.

​https://bugs.webkit.org/show_bug.cgi?id=25626
Update V8ElementCustom.cpp to match the current API of Node.

  • bindings/v8/custom/V8ElementCustom.cpp: (WebCore::ACCESSOR_SETTER): Changed a couple of method names to match current names. (WebCore::ACCESSOR_GETTER): Changed a method name to match current name.
2:49 PM Changeset in webkit [43516] by weinig@apple.com
  • 4 edits in trunk/JavaScriptCore

2009-05-11 Sam Weinig <​sam@webkit.org>

Reviewed by Geoffrey "1" Garen.

Rip out the !USE(CTI_REPATCH_PIC) code. It was untested and unused.

  • jit/JIT.h: (JSC::JIT::compileGetByIdChainList): (JSC::JIT::compileGetByIdChain): (JSC::JIT::compileCTIMachineTrampolines):
  • jit/JITPropertyAccess.cpp: (JSC::JIT::privateCompileGetByIdProto): (JSC::JIT::privateCompileGetByIdChainList): (JSC::JIT::privateCompileGetByIdChain):
  • jit/JITStubs.cpp: (JSC::JITStubs::tryCachePutByID): (JSC::JITStubs::tryCacheGetByID):
2:49 PM Changeset in webkit [43515] by beidson@apple.com
  • 2 edits in trunk/WebCore

2009-05-11 Brady Eidson <​beidson@apple.com>

Fix Windows build

  • platform/network/cf/ResourceHandleCFNet.cpp: (WebCore::createCFURLResponseWithDefaultMIMEType): (WebCore::WebCoreSynchronousLoader::load):
2:36 PM Changeset in webkit [43514] by beidson@apple.com
  • 2 edits in trunk/WebCore

2009-05-11 Brady Eidson <​beidson@apple.com>

Fix Windows build

  • platform/network/cf/ResourceHandleCFNet.cpp: (WebCore::createCFURLResponseWithDefaultMIMEType):
2:35 PM Changeset in webkit [43513] by Dimitri Glazkov
  • 2 edits in trunk/WebCore

2009-05-11 Nate Chapin <​japhet@google.com>

Reviewed by Dimitri Glazkov.

V8CustomBinding.cpp is missing a header file

​https://bugs.webkit.org/show_bug.cgi?id=25644

  • bindings/v8/custom/V8CustomBinding.cpp: Added #include "V8Proxy.h".
2:30 PM Changeset in webkit [43512] by Dimitri Glazkov
  • 4 edits in trunk/WebCore

2009-05-11 Aaron Boodman <​aa@chromium.org>

Reviewed by Darin Fisher.

​https://bugs.webkit.org/show_bug.cgi?id=25634
Change V8Proxy::retrieveActiveFrame() call sites to V8Proxy::retrieveFrameForEnteredContext().

Also, change instances of ScriptController::retrieveActiveFrame() to
V8::retrieveFrameForEnteredContext() for consistency.

See ​http://codereview.chromium.org/113085 for the corresponding Chromium change.

  • bindings/v8/custom/V8DOMWindowCustom.cpp: (WebCore::V8Custom::WindowSetLocation):
  • bindings/v8/custom/V8HTMLDocumentCustom.cpp: (WebCore::CALLBACK_FUNC_DECL):
  • bindings/v8/custom/V8LocationCustom.cpp: (WebCore::navigateIfAllowed): (WebCore::ACCESSOR_SETTER): (WebCore::CALLBACK_FUNC_DECL):
2:06 PM Changeset in webkit [43511] by beidson@apple.com
  • 10 edits in trunk

WebCore:

2009-05-11 Brady Eidson <​beidson@apple.com>

Reviewed by Darin Adler.

<rdar://problem/5972751> Local image files (BMP, ico) can be misidentified as HTML.

First part of the fix - Disable content sniffing for file resources which never should've been happening anyways.
Second part of the fix - If the networking layer doesn't give us back a MIME type default to "application/octet-stream".

  • platform/MIMETypeRegistry.cpp: (WebCore::defaultMIMEType): "application/octet-stream"
  • platform/MIMETypeRegistry.h:
  • platform/network/ResourceHandle.cpp: (WebCore::ResourceHandle::create): If content sniffing is true, double check with "shouldContentSniffRequest()" which might override it to false. (WebCore::ResourceHandle::shouldContentSniffURL): Return false for ​file:// urls, true for everything else.
  • platform/network/ResourceHandle.h:
  • platform/network/cf/ResourceHandleCFNet.cpp: (WebCore::createCFURLResponseWithDefaultMIMEType): Create a copy of the CFURLRequest with the default MIME type instead of null. (WebCore::didReceiveResponse): If the MIME type for the response is null, create a copy with the default MIME type. (WebCore::WebCoreSynchronousLoader::load): Use shouldContentSniffRequest() to make synchronous loads have the same sniffing policy as asynchronous loads. Also, correct a null MIME type by creating a copy with the default type.
  • platform/network/mac/ResourceHandleMac.mm: (WebCore::ResourceHandle::loadResourceSynchronously): Use shouldContentSniffRequest() to make synchronous loads have the same sniffing policy as asynchronous loads. (-[WebCoreResourceHandleAsDelegate connection:didReceiveResponse:]): Set up the [NSURLResponse MIMEType] swizzling if it hasn't been set up yet. (_web_NSURLResponse_MIMEType): Either return the actual MIME type of the response, or the default MIME type if it's nil.
  • xml/XMLHttpRequest.cpp: (WebCore::XMLHttpRequest::loadRequestAsynchronously): Remove the workaround added in r29370 as it will now be covered by the new mechanism.

LayoutTests:

2009-05-11 Brady Eidson <​beidson@apple.com>

Reviewed by Darin Adler.

  • platform/mac-leopard/Skipped: Skip fast/images/favicon-as-image.html until we can come up with a better solution to its new failure.
1:37 PM Changeset in webkit [43510] by dimich@chromium.org
  • 2 edits in trunk/JavaScriptCore

2009-05-11 Dmitry Titov <​dimich@chromium.org>

GTK build fix - the deprecated waitForThreadCompletion is not needed on GTK.

  • wtf/ThreadingPthreads.cpp: added #ifdef PLATFORM(DARWIN) around waitForThreadCompletion().
1:34 PM Changeset in webkit [43509] by ddkilzer@apple.com
  • 3 edits in trunk/WebCore

Fix typo "APPLICATION_CAHE_DYNAMIC_ENTRIES" to "APPLICATION_CACHE_DYNAMIC_ENTRIES"

This was added in r39816 to disable dynamic entries. They are
still disabled after fixing the typo since this feature define
is never set anywhere.

  • bindings/js/JSDOMApplicationCacheCustom.cpp:
  • loader/appcache/DOMApplicationCache.idl:
1:28 PM Changeset in webkit [43508] by Adam Roben
  • 2 edits in trunk/JavaScriptCore

Build fix for newer versions of GCC

  • wtf/ThreadingPthreads.cpp: Added a declaration of waitForThreadCompletion before its definition to silence a warning.
12:49 PM Changeset in webkit [43507] by dimich@chromium.org
  • 23 edits in trunk

JavaScriptCore:

2009-05-11 Dmitry Titov <​dimich@chromium.org>

Reviewed by Alexey Proskuryakov and Adam Roben.

​https://bugs.webkit.org/show_bug.cgi?id=25348
Change WTF::ThreadIdentifier to be an actual (but wrapped) thread id, remove ThreadMap.

  • wtf/Threading.h: (WTF::ThreadIdentifier::ThreadIdentifier): (WTF::ThreadIdentifier::isValid): (WTF::ThreadIdentifier::invalidate): (WTF::ThreadIdentifier::platformId): ThreadIdentifier is now a class, containing a PlatformThreadIdentifier and methods that are used across the code on thread ids: construction, comparisons, check for 'valid' state etc. '0' is used as invalid id, which happens to just work with all platform-specific thread id implementations.

All the following files repeatedly reflect the new ThreadIdentifier for each platform.
We remove ThreadMap and threadMapMutex from all of them, remove the functions that
populated/searched/cleared the map and add platform-specific comparison operators
for ThreadIdentifier.

There are specific temporary workarounds for Safari 4 beta on OSX and Win32 since the
public build uses WTF threading functions with old type of ThreadingIdentifier.
The next time Safari 4 is rebuilt, it will 'automatically' pick up the new type and new
functions so the deprecated ones can be removed.

  • wtf/gtk/ThreadingGtk.cpp: (WTF::ThreadIdentifier::operator==): (WTF::ThreadIdentifier::operator!=): (WTF::initializeThreading): (WTF::createThreadInternal): (WTF::waitForThreadCompletion): (WTF::currentThread):
  • wtf/ThreadingNone.cpp: (WTF::ThreadIdentifier::operator==): (WTF::ThreadIdentifier::operator!=):
  • wtf/ThreadingPthreads.cpp: (WTF::ThreadIdentifier::operator==): (WTF::ThreadIdentifier::operator!=): (WTF::initializeThreading): (WTF::createThreadInternal): (WTF::waitForThreadCompletion): (WTF::detachThread): (WTF::currentThread): (WTF::waitForThreadCompletion): This is a workaround for Safari 4 beta on Mac. Safari 4 is linked against old definition of ThreadIdentifier so it treats it as uint32_t. This 'old' variant of waitForThreadCompletion takes uint32_t and has the old decorated name, so Safari can load it from JavaScriptCore library. The other functions (CurrentThread() etc) happen to match their previous decorated names and, while they return pthread_t now, it is a pointer which round-trips through a uint32_t. This function will be removed as soon as Safari 4 will release next public build.
  • wtf/qt/ThreadingQt.cpp: (WTF::ThreadIdentifier::operator==): (WTF::ThreadIdentifier::operator!=): (WTF::initializeThreading): (WTF::createThreadInternal): (WTF::waitForThreadCompletion): (WTF::currentThread):
  • wtf/ThreadingWin.cpp: (WTF::ThreadIdentifier::operator==): (WTF::ThreadIdentifier::operator!=): (WTF::initializeThreading): (WTF::createThreadInternal): All the platforms (except Windows) used a sequential counter as a thread ID and mapped it into platform ID. Windows was using native thread id and mapped it into thread handle. Since we can always obtain a thread handle by thread id, createThread now closes the handle. (WTF::waitForThreadCompletion): obtains another one using OpenThread(id) API. If can not obtain a handle, it means the thread already exited. (WTF::detachThread): (WTF::currentThread): (WTF::detachThreadDeprecated): old function, renamed (for Win Safari 4 beta which uses it for now). (WTF::waitForThreadCompletionDeprecated): same. (WTF::currentThreadDeprecated): same. (WTF::createThreadDeprecated): same.
  • bytecode/SamplingTool.h:
  • bytecode/SamplingTool.cpp: Use DEFINE_STATIC_LOCAL for a static ThreadIdentifier variable, to avoid static constructor.
  • JavaScriptCore.exp: export lists - updated decorated names of the WTF threading functions since they now take a different type as a parameter.
  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def: ditto for Windows, plus added "deprecated" functions that take old parameter type - turns out public beta of Safari 4 uses those, so they need to be kept along for a while.
  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore_debug.def: ditto.

WebCore:

2009-05-11 Dmitry Titov <​dimich@chromium.org>

Reviewed by Alexey Proskuryakov and Adam Roben.

​https://bugs.webkit.org/show_bug.cgi?id=25348
Change WTF::ThreadIdentifier to be an actual (but wrapped) thread id, remove ThreadMap.

Most of the change is in WTF.
Unless noted, all the following files changed to use the new ThreadIdentifier::isValid()
method instead of just doing 'if(m_threadID)' kind of checks, since ThreadIdentifier
is now a class rather then an integer.
Also, there is no need to initialize threadID in constructors to 0 now.

  • dom/XMLTokenizerLibxml2.cpp: (WebCore::libxmlLoaderThread): use DEFINE_STATIC_LOCAL and accessor function for static thread id, since now ThreadIdentifier needs construction and we avoid having global initializers. (WebCore::matchFunc): use the new accessor function. (WebCore::openFunc): ditto. (WebCore::createStringParser): ditto. (WebCore::createMemoryParser): ditto.
  • loader/icon/IconDatabase.cpp: (WebCore::IconDatabase::open):
  • platform/sql/SQLiteDatabase.cpp: (WebCore::SQLiteDatabase::SQLiteDatabase): (WebCore::SQLiteDatabase::close):
  • storage/DatabaseThread.cpp: (WebCore::DatabaseThread::start): (WebCore::DatabaseThread::databaseThread): remove m_threadID from debug output.
  • storage/LocalStorageThread.cpp: (WebCore::LocalStorageThread::start): (WebCore::LocalStorageThread::scheduleImport): (WebCore::LocalStorageThread::scheduleSync): (WebCore::LocalStorageThread::terminate):
  • workers/WorkerThread.cpp: (WebCore::WorkerThread::start): (WebCore::WorkerThread::WorkerThread): (WebCore::WorkerThread::start):

WebKit/win:

2009-05-11 Dmitry Titov <​dimich@chromium.org>

Reviewed by Alexey Proskuryakov and Adam Roben.

​https://bugs.webkit.org/show_bug.cgi?id=25348
Change WTF::ThreadIdentifier to be an actual (but wrapped) thread id, remove ThreadMap.

Most of the change is in WTF and WebCore.

  • WebKit.vcproj/WebKit.def: replaced decorated names of WTF threading functions with new ones. Also, aliased the old implementations so the public Safari 4 beta can load the old WTF functions which it uses. Next time Safari 4 builds, it will pick up new functions and the deprecated ones can be removed.
  • WebKit.vcproj/WebKit_debug.def: same.
11:54 AM Changeset in webkit [43506] by Darin Adler
  • 4 edits
    3 adds in trunk

JavaScriptCore:

2009-05-11 Darin Adler <Darin Adler>

Reviewed by Oliver Hunt.

Bug 25560: REGRESSION (r34821): "string value".proto gets the wrong object.
​https://bugs.webkit.org/show_bug.cgi?id=25560
rdar://problem/6861069

I missed this case back a year ago when I sped up handling
of JavaScript wrappers. Easy to fix.

  • runtime/JSObject.h: (JSC::JSValue::get): Return the prototype itself if the property name is proto.
  • runtime/JSString.cpp: (JSC::JSString::getOwnPropertySlot): Ditto.

LayoutTests:

2009-05-11 Darin Adler <Darin Adler>

Reviewed by Oliver Hunt.

Bug 25560: REGRESSION (r34821): "string value".proto gets the wrong object.
​https://bugs.webkit.org/show_bug.cgi?id=25560
rdar://problem/6861069

  • fast/js/prototypes-expected.txt: Added.
  • fast/js/prototypes.html: Added.
  • fast/js/resources/prototypes.js: Added.
11:37 AM S60Reindeer edited by aozoren@gmail.com
BUG REPORT? (diff)
11:05 AM Changeset in webkit [43505] by oliver@apple.com
  • 4 edits in trunk/JavaScriptCore

Rename emitGetFromCallFrameHeader to emitGetFromCallFrameHeaderPtr

Reviewed by Maciej Stachowiak

10:41 AM Changeset in webkit [43504] by weinig@apple.com
  • 80 edits in branches/nitro-extreme/JavaScriptCore

2009-05-11 Sam Weinig <​sam@webkit.org>

Roll out improperly merged strcat code.

10:28 AM Changeset in webkit [43503] by beidson@apple.com
  • 3 edits
    1 delete in trunk/WebCore

2009-05-11 Brady Eidson <​beidson@apple.com>

Reviewed by Darin Adler.

Remove unused header that declared one function which was never defined anywhere.

  • WebCore.vcproj/WebCore.vcproj:
  • platform/network/cf/ResourceResponseCFNet.cpp: Change to include ResourceResponse.h (which really means platform/network/cf/ResourceResponse.h)
  • platform/network/cf/ResourceResponseCFNet.h: Removed.
10:24 AM Changeset in webkit [43502] by weinig@apple.com
  • 57 edits
    1 delete in branches/nitro-extreme/JavaScriptCore

2009-05-11 Sam Weinig <​sam@webkit.org>

Roll out improperly merged native function thunk code.

10:06 AM Changeset in webkit [43501] by ddkilzer@apple.com
  • 2 edits in trunk/LayoutTests

Added webarchive/test-link-rel-icon.html to gtk Skipped list

  • platform/gtk/Skipped: Added webarchive/test-link-rel-icon.html.
10:00 AM Changeset in webkit [43500] by Dimitri Glazkov
  • 2 edits in trunk/WebCore

2009-05-11 Dimitri Glazkov <Dimitri Glazkov>

Reviewed by Timothy Hatcher.

​https://bugs.webkit.org/show_bug.cgi?id=25213
Fix assert during Inspector destruction.

  • inspector/InspectorController.cpp: (WebCore::InspectorController::inspectedPageDestroyed): Moved closing

inspector above removing InspectorController object to fix JS errors,
added clearing inspector page ptr.

9:44 AM Changeset in webkit [43499] by ddkilzer@apple.com
  • 2 edits
    1 add
    1 delete in trunk/LayoutTests

Bug 23331: LayoutTests/webarchive/test-link-rel-icon.html fails in different ways on buildbots

<​https://bugs.webkit.org/show_bug.cgi?id=23331>

Reviewed by Brady Eidson.

  • webarchive/test-link-rel-icon-expected.webarchive: Updated results after removing workaround in the test.
  • webarchive/test-link-rel-icon.html: Copied from webarchive/test-link-rel-icon.html-disabled. Removed workaround for Bug 21026 / <rdar://problem/6240826>.
  • webarchive/test-link-rel-icon.html-disabled: Removed.
9:41 AM EFLWebKit edited by kenneth.christiansen@gmail.com
(diff)
9:41 AM EFLWebKit edited by kenneth.christiansen@gmail.com
(diff)
9:41 AM EFLWebKit created by kenneth.christiansen@gmail.com
9:35 AM WikiStart edited by kenneth.christiansen@gmail.com
(diff)
9:22 AM Changeset in webkit [43498] by zecke@webkit.org
  • 2 edits in trunk/JavaScriptCore

[Qt] Build fix, build ParserArena.cpp

9:22 AM Changeset in webkit [43497] by zecke@webkit.org
  • 4 edits in trunk

WebCore
2009-05-11 Laszlo Gombos <Laszlo Gombos>

Reviewed by Holger Freyther.

[Qt] Make sure that public APIs are properly exported on all Qt platforms
​https://bugs.webkit.org/show_bug.cgi?id=25601

  • WebCore.pro: Define QT_MAKEDLL for all non-static builds, not just for win

WebKitTools
2009-05-11 Laszlo Gombos <Laszlo Gombos>

Reviewed by Holger Freyther.

[Qt] Make sure that public APIs are properly exported on all Qt platforms
​https://bugs.webkit.org/show_bug.cgi?id=25601

  • Scripts/webkitdirs.pm: Remove QT_SHARED define from Qt builds, define QT_MAKEDLL in WebCore.pro instead
9:22 AM Changeset in webkit [43496] by zecke@webkit.org
  • 4 edits in trunk/WebKit/qt

2009-05-11 Laszlo Gombos <Laszlo Gombos>

Reviewed by Holger Freyther.

Fix Qt build when ENABLE_DATABASE is turned off

​https://bugs.webkit.org/show_bug.cgi?id=25587

  • Api/qwebdatabase.cpp: (QWebDatabase::displayName): (QWebDatabase::expectedSize): (QWebDatabase::size): (QWebDatabase::fileName): (QWebDatabase::removeDatabase):
  • Api/qwebdatabase_p.h:
  • Api/qwebsecurityorigin.cpp: (QWebSecurityOrigin::allOrigins): (QWebSecurityOrigin::databases):
9:22 AM Changeset in webkit [43495] by zecke@webkit.org
  • 2 edits in trunk/JavaScriptCore

2009-05-11 Norbert Leser <​norbert.leser@nokia.com>

Reviewed by Darin Adler.

​https://bugs.webkit.org/show_bug.cgi?id=24536

Symbian compilers cannot resolve WTF::PassRefPtr<JSC::Profile>
unless Profile.h is included.

  • profiler/ProfileGenerator.h:
9:21 AM Changeset in webkit [43494] by zecke@webkit.org
  • 5 edits in trunk

JavaScriptCore
2009-05-11 Csaba Osztrogonac <​oszi@inf.u-szeged.hu>

Reviewed by Holger Freyther.

​https://bugs.webkit.org/show_bug.cgi?id=24284

  • JavaScriptCore.pri: coding style modified
  • jsc.pro: duplicated values removed from INCLUDEPATH, DEFINES

WebCore
2009-05-11 Csaba Osztrogonac <​oszi@inf.u-szeged.hu>

Reviewed by Holger Freyther.

​https://bugs.webkit.org/show_bug.cgi?id=24284

  • WebCore.pro: duplicated values removed from INCLUDEPATH
9:21 AM Changeset in webkit [43493] by zecke@webkit.org
  • 3 edits in trunk/WebCore

2009-05-11 Laszlo Gombos <Laszlo Gombos>

Reviewed by Eric Seidel.

Build fix Symbian; clean Up WebKit/Qt if ENABLE_NETSCAPE_PLUGIN_API=0
​https://bugs.webkit.org/show_bug.cgi?id=24688

  • WebCore.pro: Use platform independent plugin stubs if ENABLE_NETSCAPE_PLUGIN_API=0
  • platform/qt/TemporaryLinkStubs.cpp: Remove stub functions for plugins
9:10 AM Changeset in webkit [43492] by Darin Adler
  • 2 edits in trunk/LayoutTests

2009-05-11 Darin Adler <Darin Adler>

Reviewed by Dan Bernstein.

Fix failure seen on most of the buildbots.

  • fast/forms/text-control-intrinsic-widths-expected.txt: Rolled back to the version before Hyatt's recent intrinsic margin check-in. According to Dan, that should not have had any effect on this test, so these results reflect some other sort of difference on Hyatt's computer.
8:17 AM Changeset in webkit [43491] by kov@webkit.org
  • 2 edits in trunk/JavaScriptCore

2009-05-11 Gustavo Noronha Silva <​gustavo.noronha@collabora.co.uk>

Reviewed by NOBODY (build fix).

Also add ParserArena, in addition to AllInOne, for release builds,
since adding it to AllInOne breaks Mac.

  • GNUmakefile.am:
7:55 AM Changeset in webkit [43490] by kov@webkit.org
  • 2 edits in trunk/JavaScriptCore

2009-05-11 Gustavo Noronha Silva <​gustavo.noronha@collabora.co.uk>

Unreviewed build fix. Adding ParserArena to the autotools build.

  • GNUmakefile.am:
7:50 AM Changeset in webkit [43489] by Adam Roben
  • 3 edits in trunk/JavaScriptCore

More Windows build fixes after r43479

  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore_debug.def: Export ParserArena::reset.
7:36 AM Changeset in webkit [43488] by Adam Roben
  • 3 edits in trunk/JavaScriptCore

Windows build fixes after r43479

  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj: Added ParserArena to the project.
  • parser/NodeConstructors.h: Added a missing include. (JSC::ParserArenaDeletable::operator new): Marked these as inline.
6:57 AM Changeset in webkit [43487] by kov@webkit.org
  • 1 edit
    1 add in trunk/WebKit/gtk/po

2009-05-11 Anton Shestakov <​engored@ya.ru>

Rubber-stamped by Gustavo Noronha.

New Russian translation.

  • ru.po: Added.
3:55 AM Changeset in webkit [43486] by jmalonzo@webkit.org
  • 5 edits in trunk/JavaScriptCore

Revert "2009-05-11 Jan Michael Alonzo <​jmalonzo@webkit.org>"

This reverts commit r43485 as it fails the mac bots.

3:34 AM Changeset in webkit [43485] by jmalonzo@webkit.org
  • 5 edits in trunk/JavaScriptCore

2009-05-11 Jan Michael Alonzo <​jmalonzo@webkit.org>

Reviewed by NOBODY (BuildFix).

Add ParserArena to AllInOneFile as well as gtk, qt and wx build
scripts.

  • AllInOneFile.cpp:
  • GNUmakefile.am:
  • JavaScriptCore.pri:
  • JavaScriptCoreSources.bkl:
12:06 AM Changeset in webkit [43484] by ggaren@apple.com
  • 2 edits in branches/nitro-extreme/JavaScriptCore

2009-05-10 Geoffrey Garen <​ggaren@apple.com>

Reviewed by Sam Weinig.


Added unary slow cases.


Fixed a macro-related bug that cased unary postfix ops always to be
noops in codegen.

  • jit/JIT.cpp: (JSC::JIT::privateCompileMainPass): (JSC::JIT::privateCompileSlowCases):

May 10, 2009:

11:37 PM Changeset in webkit [43483] by weinig@apple.com
  • 2 edits in branches/nitro-extreme/JavaScriptCore

2009-05-10 Sam Weinig <​sam@webkit.org>

Reviewed by Geoffrey Garen.

Add op_codes that have Stub only implementations.

  • jit/JIT.cpp: (JSC::JIT::privateCompileMainPass):
11:22 PM Changeset in webkit [43482] by ggaren@apple.com
  • 5 edits in branches/nitro-extreme/JavaScriptCore

2009-05-10 Geoffrey Garen <​ggaren@apple.com>

Reviewed by Sam Weinig.


Fixed some bugs in slow case generation and implemented our first two
slow cases: op_convert_this and op_add.

  • jit/JIT.cpp: (JSC::JIT::emitLoad): (JSC::JIT::emitLoadReturnValue): (JSC::JIT::emitStore): (JSC::JIT::emitStoreReturnValue): (JSC::JIT::privateCompileMainPass): Renamed *VirtualRegister => *. Added emitLoadReturnValue for loading the return value of a stub function into a virtual register.

(JSC::JIT::privateCompileSlowCases):
(JSC::JIT::privateCompile): Added slow cases for op_convert_this and
op_add. Restored slow case generation hook.

  • jit/JIT.h: (JSC::JITStubCall::JITStubCall): (JSC::JITStubCall::addArgument): (JSC::JITStubCall::call): Removed two-return value JITStub call, since it's unused. Fixed a typo in return type tracking that caused an assertion failure.
  • jit/JITStubs.cpp: (JSC::):
  • jit/JITStubs.h: Fixed an error in JITStackFrame layout on 32bit: the reserved space is the size of a pointer, not the size of a JSValue.
11:06 PM Changeset in webkit [43481] by mjs@apple.com
  • 3 edits in trunk/JavaScriptCore

2009-05-10 Maciej Stachowiak <​mjs@apple.com>

Reviewed by Geoff Garen.


Accound for the 64-bit instruction prefix when rewriting mov to lea on 64-bit.


  • jit/JIT.h:
  • jit/JITPropertyAccess.cpp: (JSC::JIT::patchGetByIdSelf): (JSC::JIT::patchPutByIdReplace):
9:49 PM Changeset in webkit [43480] by ggaren@apple.com
  • 2 edits in branches/nitro-extreme/JavaScriptCore

2009-05-10 Geoffrey Garen <​ggaren@apple.com>

Removed some code that was removed from TOT.

  • jit/JIT.h:
9:30 PM Changeset in webkit [43479] by Darin Adler
  • 13 edits
    2 adds in trunk/JavaScriptCore

2009-05-10 Darin Adler <Darin Adler>

Reviewed by Cameron Zwarich.

Bug 25674: syntax tree nodes should use arena allocation
​https://bugs.webkit.org/show_bug.cgi?id=25674

Part two: Remove reference counting from most nodes.

  • JavaScriptCore.xcodeproj/project.pbxproj: Added ParserArena.h and .cpp.
  • parser/Grammar.y: Replaced uses of ParserRefCountedData with uses of ParserArenaData. Took out now-nonfunctional code that tries to manually release declaration list. Changed the new calls that create FuncDeclNode and FuncExprNode so that they use the proper version of operator new for the reference-counted idiom, not the deletion idiom.
  • parser/NodeConstructors.h: (JSC::ParserArenaDeletable::operator new): Added. (JSC::ParserArenaRefCounted::ParserArenaRefCounted): Added. (JSC::Node::Node): Removed ParserRefCounted initializer. (JSC::ElementNode::ElementNode): Ditto. (JSC::PropertyNode::PropertyNode): Ditto. (JSC::ArgumentsNode::ArgumentsNode): Ditto. (JSC::SourceElements::SourceElements): Ditto. (JSC::ParameterNode::ParameterNode): Ditto. (JSC::FuncExprNode::FuncExprNode): Added ParserArenaRefCounted initializer. (JSC::FuncDeclNode::FuncDeclNode): Ditto. (JSC::CaseClauseNode::CaseClauseNode): Removed ParserRefCounted initializer. (JSC::ClauseListNode::ClauseListNode): Ditto. (JSC::CaseBlockNode::CaseBlockNode): Ditto.
  • parser/NodeInfo.h: Replaced uses of ParserRefCountedData with uses of ParserArenaData.
  • parser/Nodes.cpp: (JSC::ScopeNode::ScopeNode): Added ParserArenaRefCounted initializer. (JSC::ProgramNode::create): Use the proper version of operator new for the reference-counted idiom, not the deletion idiom. Use the arena contains function instead of the vecctor find function. (JSC::EvalNode::create): Use the proper version of operator new for the reference-counted idiom, not the deletion idiom. Use the arena reset function instead of the vector shrink function. (JSC::FunctionBodyNode::createNativeThunk): Use the proper version of operator new for the reference-counted idiom, not the deletion idiom. (JSC::FunctionBodyNode::create): More of the same.
  • parser/Nodes.h: Added ParserArenaDeletable and ParserArenaRefCounted to replace ParserRefCounted. Fixed inheritance so only the classes that need reference counting inherit from ParserArenaRefCounted.
  • parser/Parser.cpp: (JSC::Parser::parse): Set m_sourceElements to 0 since it now starts uninitialized. Just set it to 0 again in the failure case, since it's now just a raw pointer, not an owning one. (JSC::Parser::reparseInPlace): Removed now-unneeded get() function. (JSC::Parser::didFinishParsing): Replaced uses of ParserRefCountedData with uses of ParserArenaData.
  • parser/Parser.h: Less RefPtr, more arena.
  • parser/ParserArena.cpp: Added.
  • parser/ParserArena.h: Added.
  • runtime/JSGlobalData.cpp: (JSC::JSGlobalData::~JSGlobalData): Removed arena-related code, since it's now in the Parser. (JSC::JSGlobalData::createLeaked): Removed unneeded #ifndef. (JSC::JSGlobalData::createNativeThunk): Tweaked #if a bit.
  • runtime/JSGlobalData.h: Removed parserArena, which is now in Parser.
  • wtf/RefCounted.h: Added deletionHasBegun function, for use in assertions to catch deletion not done by the deref function.
5:48 PM Changeset in webkit [43478] by ddkilzer@apple.com
  • 3 edits in trunk/JavaScriptCore

Part 2: Try to fix the Windows build by adding a symbol which is really just a re-mangling of a changed method signature

5:43 PM Changeset in webkit [43477] by mitz@apple.com
  • 3 edits
    2 adds in trunk

WebCore:

Reviewed by Darin Adler.

  • fix a crash when deactivating a document that had adopted a <form> element

Test: fast/dom/HTMLFormElement/document-deactivation-callback-crash.html

  • html/HTMLFormElement.cpp: (WebCore::HTMLFormElement::didMoveToNewOwnerDocument): Corrected the logic here: <form> elements should be registered for document activation callbacks if and only if autocomplete is off.

LayoutTests:

Reviewed by Darin Adler.

  • test for a crash when deactivating a document that had adopted a <form> element
  • fast/dom/HTMLFormElement/document-deactivation-callback-crash-expected.txt: Added.
  • fast/dom/HTMLFormElement/document-deactivation-callback-crash.html: Added.
5:36 PM Changeset in webkit [43476] by ddkilzer@apple.com
  • 3 edits in trunk/JavaScriptCore

Try to fix the Windows build by removing an unknown symbol

5:27 PM Changeset in webkit [43475] by ddkilzer@apple.com
  • 2 edits in trunk/JavaScriptCore

Touch Nodes.cpp to try to fix Windows build

  • parser/Nodes.cpp: Removed whitespace.
5:03 PM Changeset in webkit [43474] by ddkilzer@apple.com
  • 1 edit
    2 adds in trunk/LayoutTests

Test for Bug 23741: StyleRareNonInheritedData::operator==() should not compare ContentData objects by pointer

Rubber-stamped by Geoff Garen.

Original test by Simon Fraser.

  • fast/css/compare-content-style.html: Added.
  • platform/mac/fast/css/compare-content-style-expected.txt: Added.
4:33 PM Changeset in webkit [43473] by weinig@apple.com
  • 3 edits in branches/nitro-extreme/JavaScriptCore

2009-05-10 Sam Weinig <​sam@webkit.org>

Reviewed by Cameron Zwarich.

Be a little more consistent with how we arrange parameters for functions
that operate on virtual registers.

  • jit/JIT.cpp: (JSC::JIT::emitStoreConstant): (JSC::JIT::privateCompileMainPass):
  • jit/JIT.h:
3:46 PM Changeset in webkit [43472] by Darin Adler
  • 2 edits in trunk/JavaScriptCore

2009-05-10 Darin Adler <Darin Adler>

Reviewed by Maciej Stachowiak.

Quick fix for failures seen on buildbot. Maciej plans a better fix later.

  • wtf/dtoa.cpp: Change the hardcoded number of 32-bit words in a BigInt from 32 to 64. Parsing "1e500", for example, requires more than 32 words.
3:32 PM Changeset in webkit [43471] by Darin Adler
  • 13 edits in trunk/JavaScriptCore

2009-05-10 Darin Adler <Darin Adler>

Reviewed by Sam Weinig.

Bug 25674: syntax tree nodes should use arena allocation
Part one: Change lifetimes so we won't have to use reference
counting so much, but don't eliminate the reference counts
entirely yet.

  • bytecompiler/BytecodeGenerator.cpp: (JSC::BytecodeGenerator::BytecodeGenerator): Update for use of raw pointers instead of RefPtr. (JSC::BytecodeGenerator::emitCall): Ditto. (JSC::BytecodeGenerator::emitConstruct): Ditto.
  • parser/Grammar.y: Update node creating code to use new (JSGlobalData*) instead of the plain new. At the moment this is just a hook for future arena allocation; it's inline and JSGlobalData* is not used.
  • parser/NodeConstructors.h: Updated for name change of parserObjects to parserArena. Also added explicit initialization for raw pointers that used to be RefPtr. Also removed some uses of get() that aren't needed now that the pointers are raw pointers. Also eliminated m_parameter from FuncExprNode and FuncDeclNode. Also changed node-creating code to use new (JSGlobalData*) as above.
  • parser/Nodes.cpp: Eliminated NodeReleaser and all use of it. (JSC::ParserRefCounted::ParserRefCounted): Updated for name change of parserObjects to parserArena. (JSC::SourceElements::append): Use raw pointers. (JSC::ArrayNode::emitBytecode): Ditto. (JSC::ArrayNode::isSimpleArray): Ditto. (JSC::ArrayNode::toArgumentList): Ditto. (JSC::ObjectLiteralNode::emitBytecode): Ditto. (JSC::PropertyListNode::emitBytecode): Ditto. (JSC::BracketAccessorNode::emitBytecode): Ditto. (JSC::DotAccessorNode::emitBytecode): Ditto. (JSC::ArgumentListNode::emitBytecode): Ditto. (JSC::NewExprNode::emitBytecode): Ditto. (JSC::EvalFunctionCallNode::emitBytecode): Ditto. (JSC::FunctionCallValueNode::emitBytecode): Ditto. (JSC::FunctionCallResolveNode::emitBytecode): Ditto. (JSC::FunctionCallBracketNode::emitBytecode): Ditto. (JSC::FunctionCallDotNode::emitBytecode): Ditto. (JSC::CallFunctionCallDotNode::emitBytecode): Ditto. (JSC::ApplyFunctionCallDotNode::emitBytecode): Ditto. (JSC::PostfixBracketNode::emitBytecode): Ditto. (JSC::PostfixDotNode::emitBytecode): Ditto. (JSC::DeleteBracketNode::emitBytecode): Ditto. (JSC::DeleteDotNode::emitBytecode): Ditto. (JSC::DeleteValueNode::emitBytecode): Ditto. (JSC::VoidNode::emitBytecode): Ditto. (JSC::TypeOfValueNode::emitBytecode): Ditto. (JSC::PrefixBracketNode::emitBytecode): Ditto. (JSC::PrefixDotNode::emitBytecode): Ditto. (JSC::UnaryOpNode::emitBytecode): Ditto. (JSC::BinaryOpNode::emitStrcat): Ditto. (JSC::BinaryOpNode::emitBytecode): Ditto. (JSC::EqualNode::emitBytecode): Ditto. (JSC::StrictEqualNode::emitBytecode): Ditto. (JSC::ReverseBinaryOpNode::emitBytecode): Ditto. (JSC::ThrowableBinaryOpNode::emitBytecode): Ditto. (JSC::InstanceOfNode::emitBytecode): Ditto. (JSC::LogicalOpNode::emitBytecode): Ditto. (JSC::ConditionalNode::emitBytecode): Ditto. (JSC::ReadModifyResolveNode::emitBytecode): Ditto. (JSC::AssignResolveNode::emitBytecode): Ditto. (JSC::AssignDotNode::emitBytecode): Ditto. (JSC::ReadModifyDotNode::emitBytecode): Ditto. (JSC::AssignBracketNode::emitBytecode): Ditto. (JSC::ReadModifyBracketNode::emitBytecode): Ditto. (JSC::CommaNode::emitBytecode): Ditto. (JSC::ConstDeclNode::emitCodeSingle): Ditto. (JSC::ConstDeclNode::emitBytecode): Ditto. (JSC::ConstStatementNode::emitBytecode): Ditto. (JSC::statementListEmitCode): Ditto. (JSC::BlockNode::emitBytecode): Ditto. (JSC::ExprStatementNode::emitBytecode): Ditto. (JSC::VarStatementNode::emitBytecode): Ditto. (JSC::IfNode::emitBytecode): Ditto. (JSC::IfElseNode::emitBytecode): Ditto. (JSC::DoWhileNode::emitBytecode): Ditto. (JSC::WhileNode::emitBytecode): Ditto. (JSC::ForNode::emitBytecode): Ditto. (JSC::ForInNode::emitBytecode): Ditto. (JSC::ReturnNode::emitBytecode): Ditto. (JSC::WithNode::emitBytecode): Ditto. (JSC::CaseBlockNode::tryOptimizedSwitch): Ditto. (JSC::CaseBlockNode::emitBytecodeForBlock): Ditto. (JSC::SwitchNode::emitBytecode): Ditto. (JSC::LabelNode::emitBytecode): Ditto. (JSC::ThrowNode::emitBytecode): Ditto. (JSC::TryNode::emitBytecode): Ditto. (JSC::ScopeNodeData::ScopeNodeData): Use swap to transfer ownership of the arena, varStack and functionStack. (JSC::ScopeNode::ScopeNode): Pass in the arena when creating the ScopeNodeData. (JSC::ProgramNode::ProgramNode): Made this inline since it's used in only one place. (JSC::ProgramNode::create): Changed this to return a PassRefPtr since we plan to have the scope nodes be outside the arena, so they will need some kind of ownership transfer (maybe auto_ptr instead of PassRefPtr in the future, though). Remove the node from the newly-created arena to avoid a circular reference. Later we'll keep the node out of the arena by using a different operator new, but for now it's the ParserRefCounted constructor that puts the node into the arena, and there's no way to bypass that. (JSC::EvalNode::EvalNode): Ditto. (JSC::EvalNode::create): Ditto. (JSC::FunctionBodyNode::FunctionBodyNode): Ditto. (JSC::FunctionBodyNode::createNativeThunk): Moved the code that reseets the arena here instead of the caller. (JSC::FunctionBodyNode::create): Same change as the other create functions above. (JSC::FunctionBodyNode::emitBytecode): Use raw pointers.
  • parser/Nodes.h: Removed NodeReleaser. Changed FunctionStack to use raw pointers. Removed the releaseNodes function. Added an override of operator new that takes a JSGlobalData* to prepare for future arena use. Use raw pointers instead of RefPtr everywhere possible.
  • parser/Parser.cpp: (JSC::Parser::reparseInPlace): Pass the arena in.
  • parser/Parser.h: (JSC::Parser::parse): Updated for name change of parserObjects to parserArena. (JSC::Parser::reparse): Ditto.
  • runtime/FunctionConstructor.cpp: (JSC::extractFunctionBody): Ditto.
  • runtime/JSGlobalData.cpp: (JSC::JSGlobalData::~JSGlobalData): Ditto. (JSC::JSGlobalData::createNativeThunk): Moved arena manipulation into the FunctionBodyNode::createNativeThunk function.
  • runtime/JSGlobalData.h: Tweaked formatting and renamed parserObjects to parserArena.
  • wtf/NotFound.h: Added the usual "using WTF" to this header to match the rest of WTF.
2:28 PM Changeset in webkit [43470] by weinig@apple.com
  • 2 edits in branches/nitro-extreme/JavaScriptCore

2009-05-10 Sam Weinig <​sam@webkit.org>

Reviewed by Geoffrey Garen.

Fix typo. op_loop should not be using the fact that it and op_end are the
same length.

  • jit/JIT.cpp: (JSC::JIT::privateCompileMainPass):
2:00 PM Changeset in webkit [43469] by weinig@apple.com
  • 4 edits in branches/nitro-extreme/JavaScriptCore

2009-05-10 Sam Weinig <​sam@webkit.org>

Build fix.

  • jit/JIT.cpp: (JSC::JIT::privateCompileMainPass):
  • parser/Nodes.h:
  • runtime/Operations.h: (JSC::concatenateStrings):
1:53 PM Changeset in webkit [43468] by weinig@apple.com
  • 2 edits in branches/nitro-extreme/JavaScriptCore

2009-05-10 Sam Weinig <​sam@webkit.org>

Fix typo in a comment.

  • jit/JIT.cpp: (JSC::JIT::privateCompileMainPass):
1:45 PM Changeset in webkit [43467] by weinig@apple.com
  • 13 edits in branches/nitro-extreme/JavaScriptCore

2009-05-10 Sam Weinig <​sam@webkit.org>

Merge string concatenation from r43331.

  • bytecode/CodeBlock.cpp: (JSC::CodeBlock::dump):
  • bytecode/Opcode.h:
  • bytecompiler/BytecodeGenerator.cpp: (JSC::BytecodeGenerator::emitStrcat): (JSC::BytecodeGenerator::emitToPrimitive):
  • bytecompiler/BytecodeGenerator.h:
  • interpreter/Interpreter.cpp: (JSC::Interpreter::privateExecute):
  • jit/JITStubs.cpp: (JSC::JITStubs::cti_op_strcat):
  • parser/Nodes.cpp: (JSC::BinaryOpNode::emitStrcat): (JSC::BinaryOpNode::emitBytecode):
  • parser/Nodes.h: (JSC::ExpressionNode::): (JSC::DeleteBracketNode::):
  • parser/ResultType.h: (JSC::ResultType::definitelyIsString): (JSC::ResultType::forAdd):
  • runtime/Operations.h: (JSC::concatenateStrings):
  • runtime/UString.cpp: (JSC::UString::appendNumeric):
  • runtime/UString.h: (JSC::UString::Rep::createEmptyBuffer): (JSC::UString::BaseString::BaseString):
1:32 PM Changeset in webkit [43466] by weinig@apple.com
  • 40 edits in branches/nitro-extreme

JavaScriptCore:

2009-05-10 Sam Weinig <​sam@webkit.org>

Merge more native function thunk code from r43372

  • API/JSCallbackFunction.h:
  • API/JSCallbackObject.h:
  • interpreter/CallFrame.h: (JSC::ExecState::argumentCount):
  • jsc.cpp: (functionPrint): (functionDebug): (functionGC): (functionVersion): (functionRun): (functionLoad): (functionSetSamplingFlags): (functionClearSamplingFlags): (functionReadline): (functionQuit):
  • runtime/ArrayConstructor.cpp: (JSC::callArrayConstructor):
  • runtime/ArrayPrototype.cpp: (JSC::arrayProtoFuncToString): (JSC::arrayProtoFuncToLocaleString): (JSC::arrayProtoFuncJoin): (JSC::arrayProtoFuncConcat): (JSC::arrayProtoFuncPop): (JSC::arrayProtoFuncPush): (JSC::arrayProtoFuncReverse): (JSC::arrayProtoFuncShift): (JSC::arrayProtoFuncSlice): (JSC::arrayProtoFuncSort): (JSC::arrayProtoFuncSplice): (JSC::arrayProtoFuncUnShift): (JSC::arrayProtoFuncFilter): (JSC::arrayProtoFuncMap): (JSC::arrayProtoFuncEvery): (JSC::arrayProtoFuncForEach): (JSC::arrayProtoFuncSome): (JSC::arrayProtoFuncReduce): (JSC::arrayProtoFuncReduceRight): (JSC::arrayProtoFuncIndexOf): (JSC::arrayProtoFuncLastIndexOf):
  • runtime/BooleanConstructor.cpp: (JSC::callBooleanConstructor):
  • runtime/BooleanPrototype.cpp: (JSC::booleanProtoFuncToString): (JSC::booleanProtoFuncValueOf):
  • runtime/CallData.h:
  • runtime/DateConstructor.cpp: (JSC::callDate): (JSC::dateParse): (JSC::dateNow): (JSC::dateUTC):
  • runtime/DatePrototype.cpp: (JSC::dateProtoFuncToString): (JSC::dateProtoFuncToUTCString): (JSC::dateProtoFuncToDateString): (JSC::dateProtoFuncToTimeString): (JSC::dateProtoFuncToLocaleString): (JSC::dateProtoFuncToLocaleDateString): (JSC::dateProtoFuncToLocaleTimeString): (JSC::dateProtoFuncGetTime): (JSC::dateProtoFuncGetFullYear): (JSC::dateProtoFuncGetUTCFullYear): (JSC::dateProtoFuncToGMTString): (JSC::dateProtoFuncGetMonth): (JSC::dateProtoFuncGetUTCMonth): (JSC::dateProtoFuncGetDate): (JSC::dateProtoFuncGetUTCDate): (JSC::dateProtoFuncGetDay): (JSC::dateProtoFuncGetUTCDay): (JSC::dateProtoFuncGetHours): (JSC::dateProtoFuncGetUTCHours): (JSC::dateProtoFuncGetMinutes): (JSC::dateProtoFuncGetUTCMinutes): (JSC::dateProtoFuncGetSeconds): (JSC::dateProtoFuncGetUTCSeconds): (JSC::dateProtoFuncGetMilliSeconds): (JSC::dateProtoFuncGetUTCMilliseconds): (JSC::dateProtoFuncGetTimezoneOffset): (JSC::dateProtoFuncSetTime): (JSC::dateProtoFuncSetMilliSeconds): (JSC::dateProtoFuncSetUTCMilliseconds): (JSC::dateProtoFuncSetSeconds): (JSC::dateProtoFuncSetUTCSeconds): (JSC::dateProtoFuncSetMinutes): (JSC::dateProtoFuncSetUTCMinutes): (JSC::dateProtoFuncSetHours): (JSC::dateProtoFuncSetUTCHours): (JSC::dateProtoFuncSetDate): (JSC::dateProtoFuncSetUTCDate): (JSC::dateProtoFuncSetMonth): (JSC::dateProtoFuncSetUTCMonth): (JSC::dateProtoFuncSetFullYear): (JSC::dateProtoFuncSetUTCFullYear): (JSC::dateProtoFuncSetYear): (JSC::dateProtoFuncGetYear):
  • runtime/ErrorConstructor.cpp: (JSC::callErrorConstructor):
  • runtime/ErrorPrototype.cpp: (JSC::errorProtoFuncToString):
  • runtime/FunctionConstructor.cpp: (JSC::callFunctionConstructor):
  • runtime/FunctionPrototype.cpp: (JSC::callFunctionPrototype): (JSC::functionProtoFuncToString): (JSC::functionProtoFuncApply): (JSC::functionProtoFuncCall):
  • runtime/JSFunction.h: (JSC::JSFunction::nativeFunction): (JSC::JSFunction::setScopeChain):
  • runtime/JSGlobalObjectFunctions.cpp: (JSC::globalFuncEval): (JSC::globalFuncParseInt): (JSC::globalFuncParseFloat): (JSC::globalFuncIsNaN): (JSC::globalFuncIsFinite): (JSC::globalFuncDecodeURI): (JSC::globalFuncDecodeURIComponent): (JSC::globalFuncEncodeURI): (JSC::globalFuncEncodeURIComponent): (JSC::globalFuncEscape): (JSC::globalFuncUnescape): (JSC::globalFuncJSCPrint):
  • runtime/JSGlobalObjectFunctions.h:
  • runtime/MathObject.cpp: (JSC::mathProtoFuncAbs): (JSC::mathProtoFuncACos): (JSC::mathProtoFuncASin): (JSC::mathProtoFuncATan): (JSC::mathProtoFuncATan2): (JSC::mathProtoFuncCeil): (JSC::mathProtoFuncCos): (JSC::mathProtoFuncExp): (JSC::mathProtoFuncFloor): (JSC::mathProtoFuncLog): (JSC::mathProtoFuncMax): (JSC::mathProtoFuncMin): (JSC::mathProtoFuncPow): (JSC::mathProtoFuncRandom): (JSC::mathProtoFuncRound): (JSC::mathProtoFuncSin): (JSC::mathProtoFuncSqrt): (JSC::mathProtoFuncTan):
  • runtime/NativeErrorConstructor.cpp: (JSC::callNativeErrorConstructor):
  • runtime/NumberConstructor.cpp: (JSC::callNumberConstructor):
  • runtime/NumberPrototype.cpp: (JSC::numberProtoFuncToString): (JSC::numberProtoFuncToLocaleString): (JSC::numberProtoFuncValueOf): (JSC::numberProtoFuncToFixed): (JSC::numberProtoFuncToExponential): (JSC::numberProtoFuncToPrecision):
  • runtime/ObjectConstructor.cpp: (JSC::callObjectConstructor):
  • runtime/ObjectPrototype.cpp: (JSC::objectProtoFuncValueOf): (JSC::objectProtoFuncHasOwnProperty): (JSC::objectProtoFuncIsPrototypeOf): (JSC::objectProtoFuncDefineGetter): (JSC::objectProtoFuncDefineSetter): (JSC::objectProtoFuncLookupGetter): (JSC::objectProtoFuncLookupSetter): (JSC::objectProtoFuncPropertyIsEnumerable): (JSC::objectProtoFuncToLocaleString): (JSC::objectProtoFuncToString):
  • runtime/ObjectPrototype.h:
  • runtime/RegExpConstructor.cpp: (JSC::callRegExpConstructor):
  • runtime/RegExpObject.cpp: (JSC::callRegExpObject):
  • runtime/RegExpPrototype.cpp: (JSC::regExpProtoFuncTest): (JSC::regExpProtoFuncExec): (JSC::regExpProtoFuncCompile): (JSC::regExpProtoFuncToString):
  • runtime/StringConstructor.cpp: (JSC::stringFromCharCode): (JSC::callStringConstructor):
  • runtime/StringPrototype.cpp: (JSC::stringProtoFuncReplace): (JSC::stringProtoFuncToString): (JSC::stringProtoFuncCharAt): (JSC::stringProtoFuncCharCodeAt): (JSC::stringProtoFuncConcat): (JSC::stringProtoFuncIndexOf): (JSC::stringProtoFuncLastIndexOf): (JSC::stringProtoFuncMatch): (JSC::stringProtoFuncSearch): (JSC::stringProtoFuncSlice): (JSC::stringProtoFuncSplit): (JSC::stringProtoFuncSubstr): (JSC::stringProtoFuncSubstring): (JSC::stringProtoFuncToLowerCase): (JSC::stringProtoFuncToUpperCase): (JSC::stringProtoFuncLocaleCompare): (JSC::stringProtoFuncBig): (JSC::stringProtoFuncSmall): (JSC::stringProtoFuncBlink): (JSC::stringProtoFuncBold): (JSC::stringProtoFuncFixed): (JSC::stringProtoFuncItalics): (JSC::stringProtoFuncStrike): (JSC::stringProtoFuncSub): (JSC::stringProtoFuncSup): (JSC::stringProtoFuncFontcolor): (JSC::stringProtoFuncFontsize): (JSC::stringProtoFuncAnchor): (JSC::stringProtoFuncLink):
  • wtf/Platform.h:

WebCore:

2009-05-10 Sam Weinig <​sam@webkit.org>

Merge more native function thunk code from r43372

  • bindings/js/JSHTMLCollectionCustom.cpp: (WebCore::callHTMLCollection):
  • bindings/js/JSNodeListCustom.cpp: (WebCore::callNodeList):
  • bindings/js/JSPluginElementFunctions.cpp: (WebCore::callPlugin):
  • bindings/js/JSQuarantinedObjectWrapper.h:
  • bindings/scripts/CodeGeneratorJS.pm:
  • bridge/runtime_method.cpp: (JSC::callRuntimeMethod):
  • bridge/runtime_object.cpp: (JSC::callRuntimeObject):
1:21 PM Changeset in webkit [43465] by weinig@apple.com
  • 39 edits
    3 adds in branches/nitro-extreme

JavaScriptCore:

2009-05-10 Sam Weinig <​sam@webkit.org>

Merge native function thunk code from r43220.

  • JavaScriptCore.exp:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • assembler/MacroAssemblerX86Common.h: (JSC::MacroAssemblerX86Common::call):
  • assembler/MacroAssemblerX86_64.h: (JSC::MacroAssemblerX86_64::addPtr):
  • assembler/X86Assembler.h: (JSC::X86Assembler::leaq_mr): (JSC::X86Assembler::call_m):
  • interpreter/Interpreter.cpp: (JSC::Interpreter::execute): (JSC::Interpreter::prepareForRepeatCall):
  • jit/JIT.cpp: (JSC::JIT::linkCall):
  • jit/JIT.h: (JSC::JIT::compileCTIMachineTrampolines):
  • jit/JITCall.cpp: (JSC::JIT::linkCall): (JSC::JIT::compileOpCallInitializeCallFrame): (JSC::JIT::compileOpCall):
  • jit/JITCode.h: (JSC::JITCode::operator bool):
  • jit/JITInlineMethods.h: (JSC::JIT::emitGetFromCallFrameHeader): (JSC::JIT::emitGetFromCallFrameHeader32):
  • jit/JITStubs.cpp: (JSC::JITStubs::cti_op_call_JSFunction): (JSC::JITStubs::cti_vm_dontLazyLinkCall): (JSC::JITStubs::cti_vm_lazyLinkCall): (JSC::JITStubs::cti_op_construct_JSConstruct):
  • jit/JITStubs.h: (JSC::JITStubs::ctiNativeCallThunk):
  • jsc.cpp: (GlobalObject::GlobalObject):
  • parser/Nodes.cpp: (JSC::FunctionBodyNode::FunctionBodyNode): (JSC::FunctionBodyNode::createNativeThunk): (JSC::FunctionBodyNode::generateJITCode):
  • parser/Nodes.h: (JSC::FunctionBodyNode::): (JSC::FunctionBodyNode::generatedJITCode): (JSC::FunctionBodyNode::jitCode):
  • profiler/Profiler.cpp: (JSC::Profiler::createCallIdentifier):
  • runtime/ArgList.h:
  • runtime/ArrayPrototype.cpp: (JSC::isNumericCompareFunction):
  • runtime/BooleanPrototype.cpp: (JSC::BooleanPrototype::BooleanPrototype):
  • runtime/DateConstructor.cpp: (JSC::DateConstructor::DateConstructor):
  • runtime/ErrorPrototype.cpp: (JSC::ErrorPrototype::ErrorPrototype):
  • runtime/FunctionPrototype.cpp: (JSC::FunctionPrototype::addFunctionProperties): (JSC::functionProtoFuncToString):
  • runtime/FunctionPrototype.h:
  • runtime/JSFunction.cpp: (JSC::JSFunction::JSFunction): (JSC::JSFunction::~JSFunction): (JSC::JSFunction::mark): (JSC::JSFunction::getCallData): (JSC::JSFunction::call): (JSC::JSFunction::argumentsGetter): (JSC::JSFunction::callerGetter): (JSC::JSFunction::lengthGetter): (JSC::JSFunction::getOwnPropertySlot): (JSC::JSFunction::put): (JSC::JSFunction::deleteProperty): (JSC::JSFunction::getConstructData): (JSC::JSFunction::construct):
  • runtime/JSFunction.h: (JSC::JSFunction::JSFunction): (JSC::JSFunction::setScope): (JSC::JSFunction::scope): (JSC::JSFunction::isHostFunction): (JSC::JSFunction::scopeChain): (JSC::JSFunction::clearScopeChain): (JSC::JSFunction::setScopeChain): (JSC::JSFunction::nativeFunction): (JSC::JSFunction::setNativeFunction):
  • runtime/JSGlobalData.cpp: (JSC::JSGlobalData::JSGlobalData): (JSC::JSGlobalData::~JSGlobalData): (JSC::JSGlobalData::createNativeThunk):
  • runtime/JSGlobalData.h: (JSC::JSGlobalData::nativeFunctionThunk):
  • runtime/JSGlobalObject.cpp: (JSC::JSGlobalObject::reset):
  • runtime/JSGlobalObject.h:
  • runtime/Lookup.cpp: (JSC::setUpStaticFunctionSlot):
  • runtime/Lookup.h:
  • runtime/NativeFunctionWrapper.h: Added.
  • runtime/NumberPrototype.cpp: (JSC::NumberPrototype::NumberPrototype):
  • runtime/ObjectPrototype.cpp: (JSC::ObjectPrototype::ObjectPrototype):
  • runtime/RegExpPrototype.cpp: (JSC::RegExpPrototype::RegExpPrototype):
  • runtime/StringConstructor.cpp: (JSC::StringConstructor::StringConstructor):

WebCore:

2009-05-10 Sam Weinig <​sam@webkit.org>

Merge native function thunk code from r43220.

  • ForwardingHeaders/jit: Added.
  • ForwardingHeaders/jit/JITCode.h: Added.
  • inspector/JavaScriptDebugServer.cpp: (WebCore::JavaScriptDebugServer::recompileAllJSFunctions):
12:02 PM Changeset in webkit [43464] by ggaren@apple.com
  • 7 edits in branches/nitro-extreme/JavaScriptCore

2009-05-10 Geoffrey Garen <​ggaren@apple.com>

Reviewed by Cameron Zwarich.


Got JITStubs more or less working, and implemented emitTimeoutCheck(),
our first JITStub call.


Modified the magic constants in our trampolines to match the new layout
of JITStackFrame.


Added JITStubs back into the project / build.


Merged some stuff from JIT.h / JIT.cpp on trunk, with tweaks for the branch.

Brought the stubs up to par with the interpreter / new value representation.


Commented out a bunch of stub code that we haven't fully merged from TOT
yet (strcat, host function call changes). (Sam will merge and re-enable these
today.)


  • JavaScriptCore.xcodeproj/project.pbxproj:
  • jit/JIT.cpp: (JSC::JIT::emitTimeoutCheck): (JSC::JIT::restoreArgumentReference): (JSC::JIT::restoreArgumentReferenceForTrampoline): (JSC::JIT::privateCompileMainPass):
  • jit/JIT.h: (JSC::JITStubCall::JITStubCall): (JSC::JITStubCall::addArgument): (JSC::JITStubCall::call): (JSC::JITStubCall::): (JSC::CallEvalJITStub::CallEvalJITStub):
  • jit/JITStubs.cpp: (JSC::JITStubs::JITStubs): (JSC::JITStubs::cti_op_add): (JSC::JITStubs::cti_op_pre_inc): (JSC::JITStubs::cti_op_mul): (JSC::JITStubs::cti_op_call_JSFunction): (JSC::JITStubs::cti_vm_dontLazyLinkCall): (JSC::JITStubs::cti_vm_lazyLinkCall): (JSC::JITStubs::cti_op_construct_JSConstruct): (JSC::JITStubs::cti_op_get_by_val): (JSC::JITStubs::cti_op_get_by_val_string): (JSC::JITStubs::cti_op_get_by_val_byte_array): (JSC::JITStubs::cti_op_sub): (JSC::JITStubs::cti_op_put_by_val): (JSC::JITStubs::cti_op_put_by_val_array): (JSC::JITStubs::cti_op_put_by_val_byte_array): (JSC::JITStubs::cti_op_negate): (JSC::JITStubs::cti_op_div): (JSC::JITStubs::cti_op_pre_dec): (JSC::JITStubs::cti_op_post_inc): (JSC::JITStubs::cti_op_eq): (JSC::JITStubs::cti_op_lshift): (JSC::JITStubs::cti_op_bitand): (JSC::JITStubs::cti_op_rshift): (JSC::JITStubs::cti_op_bitnot): (JSC::JITStubs::cti_op_mod): (JSC::JITStubs::cti_op_neq): (JSC::JITStubs::cti_op_post_dec): (JSC::JITStubs::cti_op_urshift): (JSC::JITStubs::cti_op_bitxor): (JSC::JITStubs::cti_op_bitor): (JSC::JITStubs::cti_op_strcat): (JSC::JITStubs::cti_op_switch_imm):
  • jit/JITStubs.h: (JSC::JITStubs::ctiVirtualCall):
  • runtime/JSValue.h: (JSC::JSValue::payload):
11:49 AM Changeset in webkit [43463] by Dimitri Glazkov
  • 2 edits in trunk/JavaScriptCore

2009-05-10 Dimitri Glazkov <Dimitri Glazkov>

Reviewed by Geoffrey Garen.

​https://bugs.webkit.org/show_bug.cgi?id=25670
Remove no longer valid chunk of code from dtoa.

  • wtf/dtoa.cpp: (WTF::dtoa): Removed invalid code.
10:53 AM Changeset in webkit [43462] by ap@webkit.org
  • 3 edits in trunk/WebCore

Reviewed by Dan Bernstein.

<rdar://problem/6867598> REGRESSION (r42483): Have to enter credentials twice when trying
to view protected MobileMe video

Add a temporary workaround.

  • platform/network/ResourceHandleInternal.h: (WebCore::ResourceHandleInternal::ResourceHandleInternal): Added an m_useSiteSpecificQuirks boolean (Mac-only). A Frame pointer is only available when starting a request, so we need to store this data for later use.
  • platform/network/mac/ResourceHandleMac.mm: (WebCore::ResourceHandle::start): Initialize m_useSiteSpecificQuirks. (WebCore::ResourceHandle::receivedCredential): Use per-session credentials with gallery.me.com.
10:32 AM Changeset in webkit [43461] by ap@webkit.org
  • 3 edits in trunk/JavaScriptCore

Reviewed by Geoff Garen.

"Class const *" is the same as "const Class*", use the latter syntax consistently.

See <​http://www.parashift.com/c++-faq-lite/const-correctness.html#faq-18.9>.

  • pcre/pcre_compile.cpp: (calculateCompiledPatternLength):
  • runtime/JSObject.h: (JSC::JSObject::offsetForLocation): (JSC::JSObject::locationForOffset):
10:01 AM Changeset in webkit [43460] by ap@webkit.org
  • 9 edits
    1 move in trunk

Reviewed by Dan Bernstein.

<rdar://problem/6870383> Have to enter credentials twice when downloading from a protected page

Use credentials from WebCore storage when downloading.

9:57 AM Changeset in webkit [43459] by ap@webkit.org
  • 4 edits in trunk/WebCore

Reviewed by Dan Bernstein.

Match newer XMLHttpRequest draft and make withCredential setter raise an exception when
called at a wrong time.

No test, because we are waiting for a newer version of system frameworks to test the attribute.

  • xml/XMLHttpRequest.cpp: (WebCore::XMLHttpRequest::setWithCredentials):
  • xml/XMLHttpRequest.h:
  • xml/XMLHttpRequest.idl: Raise INVALID_STATE_ERR if the state is not OPENED, or if the send() flag is true.
9:26 AM Changeset in webkit [43458] by mitz@apple.com
  • 5 edits
    4 adds in trunk

WebCore:

Reviewed by Dave Kilzer.

Test: fast/layers/self-painting-outline.html

  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::paintLayer): Paint the layer's own outline only if it is a self-painting layer.

LayoutTests:

Reviewed by Dave Kilzer.

  • fast/layers/self-painting-outline.html: Added.
  • platform/mac/fast/overflow/overflow-focus-ring-expected.checksum: Updated.
  • platform/mac/fast/overflow/overflow-focus-ring-expected.png: Updated.
  • platform/mac/fast/layers/self-painting-outline-expected.checksum: Added.
  • platform/mac/fast/layers/self-painting-outline-expected.png: Added.
  • platform/mac/fast/layers/self-painting-outline-expected.txt: Added.
4:32 AM Changeset in webkit [43457] by mjs@apple.com
  • 5 edits in trunk/JavaScriptCore

2009-05-10 Maciej Stachowiak <​mjs@apple.com>

Reviewed by Alexey Proskuryakov.


  • speedup dtoa/strtod


Added a bunch of inlining, and replaced malloc with stack allocation.


0.5% SunSpider speedup (7% on string-tagcloud).

  • runtime/NumberPrototype.cpp: (JSC::integerPartNoExp): (JSC::numberProtoFuncToExponential):
  • runtime/UString.cpp: (JSC::concatenate): (JSC::UString::from):
  • wtf/dtoa.cpp: (WTF::BigInt::BigInt): (WTF::BigInt::operator=): (WTF::Balloc): (WTF::Bfree): (WTF::multadd): (WTF::s2b): (WTF::i2b): (WTF::mult): (WTF::pow5mult): (WTF::lshift): (WTF::cmp): (WTF::diff): (WTF::b2d): (WTF::d2b): (WTF::ratio): (WTF::strtod): (WTF::quorem): (WTF::freedtoa): (WTF::dtoa):
  • wtf/dtoa.h:
Note: See TracTimeline for information about the timeline view.