⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



May 13, 2009:

11:25 PM Changeset in webkit [43687] by ggaren@apple.com
  • 2 edits in branches/nitro-extreme/JavaScriptCore

2009-05-13 Geoffrey Garen <​ggaren@apple.com>

Reviewed by Sam Weinig.


Fixed some bugs in host function calls.


testapi now passes!

  • jit/JIT.cpp: Changed some registers around to avoid overwriting edx:eax, which is how JSValues are now returned. Also changed the code that passes thisValue to pass the full 64bits of the value. Also added an #error compiler directive to other platform builds, since the JSValue return signature probably won't return in edx:eax on those platforms, and we'll have to investigate a solution.
10:44 PM Changeset in webkit [43686] by Simon Fraser
  • 3 edits in trunk/LayoutTests

2009-05-13 Simon Fraser <Simon Fraser>

No review.

Fix pixel result after test was changed in r43664.

  • platform/mac/fast/css/text-overflow-ellipsis-expected.checksum:
  • platform/mac/fast/css/text-overflow-ellipsis-expected.png:
10:12 PM Changeset in webkit [43685] by ggaren@apple.com
  • 2 edits in branches/nitro-extreme/JavaScriptCore

2009-05-13 Geoffrey Garen <​ggaren@apple.com>

Reviewed by Sam Weinig.


Removed parameters from functions that are intended never to use their
parameters.

  • jit/JITPropertyAccess.cpp: (JSC::JIT::emitSlow_op_get_by_val): (JSC::JIT::emitSlow_op_put_by_val):
9:39 PM Changeset in webkit [43684] by ggaren@apple.com
  • 3 edits in branches/nitro-extreme/JavaScriptCore

2009-05-13 Geoffrey Garen <​ggaren@apple.com>

Reviewed by Sam Weinig.


Ported op_instance_of from TOT. It's basically the same, but some register
stuff changed to memory stuff.

  • jit/JITInlineMethods.h: (JSC::JIT::emitPutJITStubArgFromVirtualRegister): (JSC::JIT::emitStore): Changed to use helper functions.
  • jit/JITOpcodes.cpp: (JSC::JIT::emit_op_instanceof): (JSC::JIT::emitSlow_op_instanceof): Ported from TOT.
9:00 PM Changeset in webkit [43683] by ggaren@apple.com
  • 2 edits in branches/nitro-extreme/JavaScriptCore

2009-05-13 Geoffrey Garen <​ggaren@apple.com>

Reviewed by Gavin Barraclough.


Added a comment to explain an exception-handling subtelty that we found
hard to remember when reviewing my last patch.

  • jit/JITOpcodes.cpp: (JSC::JIT::emit_op_catch):
8:52 PM Changeset in webkit [43682] by ggaren@apple.com
  • 2 edits in branches/nitro-extreme/JavaScriptCore

2009-05-13 Geoffrey Garen <​ggaren@apple.com>

Reviewed by Sam Weinig.


Implemented try/catch.

  • jit/JITOpcodes.cpp: (JSC::JIT::emit_op_throw): Updated to use JITStackFrame abstraction. (JSC::JIT::emit_op_catch): Filled out.
7:38 PM Changeset in webkit [43681] by andersca@apple.com
  • 2 edits in trunk/WebCore

2009-05-13 Anders Carlsson <​andersca@apple.com>

Fix build.

  • WebCore.NPAPI.exp:
7:21 PM Changeset in webkit [43680] by weinig@apple.com
  • 2 edits in branches/nitro-extreme/JavaScriptCore

2009-05-13 Sam Weinig <​sam@webkit.org>

Reviewed by Geoffrey Garen.

Implemented op_loop_if_true, op_jfalse, op_jtrue, op_jeq_null and op_jneq_null

  • jit/JITOpcodes.cpp: (JSC::JIT::emitSlow_op_instanceof): Moved from below to be next to its fast brother.

(JSC::JIT::emit_op_loop_if_true): Similar to the old version
in that it tries to do the integer case first and reduce the
number of jumps you might need to take.
(JSC::JIT::emitSlow_op_loop_if_true):

(JSC::JIT::emit_op_jfalse): Very similar to op_loop_if_true, only
the inverse and without a timeout check.
(JSC::JIT::emitSlow_op_jfalse):

(JSC::JIT::emit_op_jtrue): Very similar to op_loop_if_true except
without the timeout check.
(JSC::JIT::emitSlow_op_jtrue):

(JSC::JIT::emit_op_jeq_null): Very similar to the implementation
of op_eq, except it takes jumps instead of copying the condition
to a dst.
(JSC::JIT::emit_op_jneq_null): Ditto but for op_neq.

7:06 PM Changeset in webkit [43679] by ggaren@apple.com
  • 3 edits in branches/nitro-extreme/JavaScriptCore

2009-05-13 Geoffrey Garen <​ggaren@apple.com>

Reviewed by Sam Weinig.


Implemented op_call_varargs.

  • jit/JITCall.cpp: (JSC::JIT::compileOpCallVarargsSetupArgs): (JSC::JIT::compileOpCallVarargs): (JSC::JIT::emit_op_call): (JSC::JIT::emit_op_call_eval): (JSC::JIT::emit_op_load_varargs): (JSC::JIT::emit_op_call_varargs): (JSC::JIT::emit_op_construct):
  • jit/JITOpcodes.cpp: (JSC::JIT::emit_op_jneq_ptr):
6:44 PM Changeset in webkit [43678] by eric@webkit.org
  • 5 edits in trunk/WebCore

Reviewed by Oliver Hunt.

Fix invalid memory write seen in HTMLCanvasElement by Valgrind
​https://bugs.webkit.org/show_bug.cgi?id=25759

I can't think of any way to catch this with a layout test, so no test.

  • css/CSSCanvasValue.cpp: (WebCore::CSSCanvasValue::canvasDestroyed):
  • css/CSSCanvasValue.h:
  • html/HTMLCanvasElement.cpp: (WebCore::HTMLCanvasElement::~HTMLCanvasElement):
  • html/HTMLCanvasElement.h:
6:14 PM Changeset in webkit [43677] by Beth Dakin
  • 33 edits
    32 adds
    96 deletes in trunk/LayoutTests

2009-05-13 Beth Dakin <Beth Dakin>

Rubber-stamped by Oliver Hunt.

Change a bunch of http tests to dumpAsText(). They are currently
failing on the Windown Build Bot because of textarea metrics
changes, and we have decided that these tests are most valuable as
text test anyway.

  • http/tests/navigation/anchor-basic-expected.txt: Added.
  • http/tests/navigation/anchor-basic.html:
  • http/tests/navigation/anchor-goback-expected.txt: Added.
  • http/tests/navigation/anchor-goback.html:
  • http/tests/navigation/anchor-subframeload-expected.txt: Added.
  • http/tests/navigation/anchor-subframeload.html:
  • http/tests/navigation/javascriptlink-basic-expected.txt: Added.
  • http/tests/navigation/javascriptlink-basic.html:
  • http/tests/navigation/javascriptlink-goback-expected.txt: Added.
  • http/tests/navigation/javascriptlink-goback.html:
  • http/tests/navigation/javascriptlink-subframeload-expected.txt: Added.
  • http/tests/navigation/javascriptlink-subframeload.html:
  • http/tests/navigation/metaredirect-basic-expected.txt: Added.
  • http/tests/navigation/metaredirect-basic.html:
  • http/tests/navigation/metaredirect-frames-expected.txt: Added.
  • http/tests/navigation/metaredirect-frames.html:
  • http/tests/navigation/metaredirect-goback-expected.txt: Added.
  • http/tests/navigation/metaredirect-goback.html:
  • http/tests/navigation/metaredirect-subframeload-expected.txt: Added.
  • http/tests/navigation/metaredirect-subframeload.html:
  • http/tests/navigation/post-goback2-expected.txt: Added.
  • http/tests/navigation/post-goback2.html:
  • http/tests/navigation/postredirect-goback2-expected.txt: Added.
  • http/tests/navigation/postredirect-goback2.html:
  • http/tests/navigation/redirect302-basic-expected.txt: Added.
  • http/tests/navigation/redirect302-basic.html:
  • http/tests/navigation/redirect302-frames-expected.txt: Added.
  • http/tests/navigation/redirect302-frames.html:
  • http/tests/navigation/redirect302-goback-expected.txt: Added.
  • http/tests/navigation/redirect302-goback.html:
  • http/tests/navigation/redirect302-subframeload-expected.txt: Added.
  • http/tests/navigation/redirect302-subframeload.html:
  • http/tests/navigation/relativeanchor-basic-expected.txt: Added.
  • http/tests/navigation/relativeanchor-basic.html:
  • http/tests/navigation/relativeanchor-frames-expected.txt: Added.
  • http/tests/navigation/relativeanchor-frames.html:
  • http/tests/navigation/relativeanchor-goback-expected.txt: Added.
  • http/tests/navigation/relativeanchor-goback.html:
  • http/tests/navigation/slowmetaredirect-basic-expected.txt: Added.
  • http/tests/navigation/slowmetaredirect-basic.html:
  • http/tests/navigation/slowtimerredirect-basic-expected.txt: Added.
  • http/tests/navigation/slowtimerredirect-basic.html:
  • http/tests/navigation/success200-basic-expected.txt: Added.
  • http/tests/navigation/success200-basic.html:
  • http/tests/navigation/success200-frames-expected.txt: Added.
  • http/tests/navigation/success200-frames-loadsame-expected.txt: Added.
  • http/tests/navigation/success200-frames-loadsame.html:
  • http/tests/navigation/success200-frames.html:
  • http/tests/navigation/success200-goback-expected.txt: Added.
  • http/tests/navigation/success200-goback.html:
  • http/tests/navigation/success200-loadsame-expected.txt: Added.
  • http/tests/navigation/success200-loadsame.html:
  • http/tests/navigation/success200-reload-expected.txt: Added.
  • http/tests/navigation/success200-reload.html:
  • http/tests/navigation/success200-subframeload-expected.txt: Added.
  • http/tests/navigation/success200-subframeload.html:
  • http/tests/navigation/timerredirect-basic-expected.txt: Added.
  • http/tests/navigation/timerredirect-basic.html:
  • http/tests/navigation/timerredirect-frames-expected.txt: Added.
  • http/tests/navigation/timerredirect-frames.html:
  • http/tests/navigation/timerredirect-goback-expected.txt: Added.
  • http/tests/navigation/timerredirect-goback.html:
  • http/tests/navigation/timerredirect-subframeload-expected.txt: Added.
  • http/tests/navigation/timerredirect-subframeload.html:
  • platform/mac/http/tests/navigation/anchor-basic-expected.checksum: Removed.
  • platform/mac/http/tests/navigation/anchor-basic-expected.png: Removed.
  • platform/mac/http/tests/navigation/anchor-basic-expected.txt: Removed.
  • platform/mac/http/tests/navigation/anchor-goback-expected.checksum: Removed.
  • platform/mac/http/tests/navigation/anchor-goback-expected.png: Removed.
  • platform/mac/http/tests/navigation/anchor-goback-expected.txt: Removed.
  • platform/mac/http/tests/navigation/anchor-subframeload-expected.checksum: Removed.
  • platform/mac/http/tests/navigation/anchor-subframeload-expected.png: Removed.
  • platform/mac/http/tests/navigation/anchor-subframeload-expected.txt: Removed.
  • platform/mac/http/tests/navigation/javascriptlink-basic-expected.checksum: Removed.
  • platform/mac/http/tests/navigation/javascriptlink-basic-expected.png: Removed.
  • platform/mac/http/tests/navigation/javascriptlink-basic-expected.txt: Removed.
  • platform/mac/http/tests/navigation/javascriptlink-goback-expected.checksum: Removed.
  • platform/mac/http/tests/navigation/javascriptlink-goback-expected.png: Removed.
  • platform/mac/http/tests/navigation/javascriptlink-goback-expected.txt: Removed.
  • platform/mac/http/tests/navigation/javascriptlink-subframeload-expected.checksum: Removed.
  • platform/mac/http/tests/navigation/javascriptlink-subframeload-expected.png: Removed.
  • platform/mac/http/tests/navigation/javascriptlink-subframeload-expected.txt: Removed.
  • platform/mac/http/tests/navigation/metaredirect-basic-expected.checksum: Removed.
  • platform/mac/http/tests/navigation/metaredirect-basic-expected.png: Removed.
  • platform/mac/http/tests/navigation/metaredirect-basic-expected.txt: Removed.
  • platform/mac/http/tests/navigation/metaredirect-frames-expected.checksum: Removed.
  • platform/mac/http/tests/navigation/metaredirect-frames-expected.png: Removed.
  • platform/mac/http/tests/navigation/metaredirect-frames-expected.txt: Removed.
  • platform/mac/http/tests/navigation/metaredirect-goback-expected.checksum: Removed.
  • platform/mac/http/tests/navigation/metaredirect-goback-expected.png: Removed.
  • platform/mac/http/tests/navigation/metaredirect-goback-expected.txt: Removed.
  • platform/mac/http/tests/navigation/metaredirect-subframeload-expected.checksum: Removed.
  • platform/mac/http/tests/navigation/metaredirect-subframeload-expected.png: Removed.
  • platform/mac/http/tests/navigation/metaredirect-subframeload-expected.txt: Removed.
  • platform/mac/http/tests/navigation/post-goback2-expected.checksum: Removed.
  • platform/mac/http/tests/navigation/post-goback2-expected.png: Removed.
  • platform/mac/http/tests/navigation/post-goback2-expected.txt: Removed.
  • platform/mac/http/tests/navigation/postredirect-goback2-expected.checksum: Removed.
  • platform/mac/http/tests/navigation/postredirect-goback2-expected.png: Removed.
  • platform/mac/http/tests/navigation/postredirect-goback2-expected.txt: Removed.
  • platform/mac/http/tests/navigation/redirect302-basic-expected.checksum: Removed.
  • platform/mac/http/tests/navigation/redirect302-basic-expected.png: Removed.
  • platform/mac/http/tests/navigation/redirect302-basic-expected.txt: Removed.
  • platform/mac/http/tests/navigation/redirect302-frames-expected.checksum: Removed.
  • platform/mac/http/tests/navigation/redirect302-frames-expected.png: Removed.
  • platform/mac/http/tests/navigation/redirect302-frames-expected.txt: Removed.
  • platform/mac/http/tests/navigation/redirect302-goback-expected.checksum: Removed.
  • platform/mac/http/tests/navigation/redirect302-goback-expected.png: Removed.
  • platform/mac/http/tests/navigation/redirect302-goback-expected.txt: Removed.
  • platform/mac/http/tests/navigation/redirect302-subframeload-expected.checksum: Removed.
  • platform/mac/http/tests/navigation/redirect302-subframeload-expected.png: Removed.
  • platform/mac/http/tests/navigation/redirect302-subframeload-expected.txt: Removed.
  • platform/mac/http/tests/navigation/relativeanchor-basic-expected.checksum: Removed.
  • platform/mac/http/tests/navigation/relativeanchor-basic-expected.png: Removed.
  • platform/mac/http/tests/navigation/relativeanchor-basic-expected.txt: Removed.
  • platform/mac/http/tests/navigation/relativeanchor-frames-expected.checksum: Removed.
  • platform/mac/http/tests/navigation/relativeanchor-frames-expected.png: Removed.
  • platform/mac/http/tests/navigation/relativeanchor-frames-expected.txt: Removed.
  • platform/mac/http/tests/navigation/relativeanchor-goback-expected.checksum: Removed.
  • platform/mac/http/tests/navigation/relativeanchor-goback-expected.png: Removed.
  • platform/mac/http/tests/navigation/relativeanchor-goback-expected.txt: Removed.
  • platform/mac/http/tests/navigation/slowmetaredirect-basic-expected.checksum: Removed.
  • platform/mac/http/tests/navigation/slowmetaredirect-basic-expected.png: Removed.
  • platform/mac/http/tests/navigation/slowmetaredirect-basic-expected.txt: Removed.
  • platform/mac/http/tests/navigation/slowtimerredirect-basic-expected.checksum: Removed.
  • platform/mac/http/tests/navigation/slowtimerredirect-basic-expected.png: Removed.
  • platform/mac/http/tests/navigation/slowtimerredirect-basic-expected.txt: Removed.
  • platform/mac/http/tests/navigation/success200-basic-expected.checksum: Removed.
  • platform/mac/http/tests/navigation/success200-basic-expected.png: Removed.
  • platform/mac/http/tests/navigation/success200-basic-expected.txt: Removed.
  • platform/mac/http/tests/navigation/success200-frames-expected.checksum: Removed.
  • platform/mac/http/tests/navigation/success200-frames-expected.png: Removed.
  • platform/mac/http/tests/navigation/success200-frames-expected.txt: Removed.
  • platform/mac/http/tests/navigation/success200-frames-loadsame-expected.checksum: Removed.
  • platform/mac/http/tests/navigation/success200-frames-loadsame-expected.png: Removed.
  • platform/mac/http/tests/navigation/success200-frames-loadsame-expected.txt: Removed.
  • platform/mac/http/tests/navigation/success200-goback-expected.checksum: Removed.
  • platform/mac/http/tests/navigation/success200-goback-expected.png: Removed.
  • platform/mac/http/tests/navigation/success200-goback-expected.txt: Removed.
  • platform/mac/http/tests/navigation/success200-loadsame-expected.checksum: Removed.
  • platform/mac/http/tests/navigation/success200-loadsame-expected.png: Removed.
  • platform/mac/http/tests/navigation/success200-loadsame-expected.txt: Removed.
  • platform/mac/http/tests/navigation/success200-reload-expected.checksum: Removed.
  • platform/mac/http/tests/navigation/success200-reload-expected.png: Removed.
  • platform/mac/http/tests/navigation/success200-reload-expected.txt: Removed.
  • platform/mac/http/tests/navigation/success200-subframeload-expected.checksum: Removed.
  • platform/mac/http/tests/navigation/success200-subframeload-expected.png: Removed.
  • platform/mac/http/tests/navigation/success200-subframeload-expected.txt: Removed.
  • platform/mac/http/tests/navigation/timerredirect-basic-expected.checksum: Removed.
  • platform/mac/http/tests/navigation/timerredirect-basic-expected.png: Removed.
  • platform/mac/http/tests/navigation/timerredirect-basic-expected.txt: Removed.
  • platform/mac/http/tests/navigation/timerredirect-frames-expected.checksum: Removed.
  • platform/mac/http/tests/navigation/timerredirect-frames-expected.png: Removed.
  • platform/mac/http/tests/navigation/timerredirect-frames-expected.txt: Removed.
  • platform/mac/http/tests/navigation/timerredirect-goback-expected.checksum: Removed.
  • platform/mac/http/tests/navigation/timerredirect-goback-expected.png: Removed.
  • platform/mac/http/tests/navigation/timerredirect-goback-expected.txt: Removed.
  • platform/mac/http/tests/navigation/timerredirect-subframeload-expected.checksum: Removed.
  • platform/mac/http/tests/navigation/timerredirect-subframeload-expected.png: Removed.
  • platform/mac/http/tests/navigation/timerredirect-subframeload-expected.txt: Removed.
6:10 PM Changeset in webkit [43676] by andersca@apple.com
  • 12 edits in trunk/WebKit/mac

2009-05-13 Anders Carlsson <​andersca@apple.com>

Reviewed by Sam Weinig.

WebKit side of <rdar://problem/6884476>.


  • Plugins/Hosted/NetscapePluginHostProxy.mm: (WKPCGetLocation): Forward this to the plug-in instance proxy.


  • Plugins/Hosted/NetscapePluginInstanceProxy.h:
  • Plugins/Hosted/NetscapePluginInstanceProxy.mm: (WebKit::NetscapePluginInstanceProxy::getLocation): Ask the plug-in view for the location.


  • Plugins/Hosted/WebKitPluginClient.defs: Add MIG definition.


  • Plugins/WebBaseNetscapePluginView.h:
  • Plugins/WebBaseNetscapePluginView.mm: (-[WebBaseNetscapePluginView locationStringForTarget:]): Return the URL for a given frame.


  • Plugins/WebNetscapeContainerCheckPrivate.h: Bump version. Add new declaration to the vtable.


  • Plugins/WebNetscapeContainerCheckPrivate.mm: (browserContainerCheckFuncs): Add new declaration to the vtable.


  • Plugins/WebNetscapePluginView.h:
  • Plugins/WebNetscapePluginView.mm: (-[WebNetscapePluginView locationForTarget:]): Call the base class method.


  • Plugins/npapi.mm: (WKN_GetLocation): Forward this to the plug-in view.
6:02 PM Changeset in webkit [43675] by Darin Adler
  • 3 edits in trunk/WebKit/mac

2009-05-13 Douglas R. Davidson <​ddavidso@apple.com>

Reviewed by Darin Adler.

<rdar://problem/6871587> Smart Copy/Paste setting should persist as continuous
spell checking setting does

  • WebView/WebPreferenceKeysPrivate.h: Added WebSmartInsertDeleteEnabled.
  • WebView/WebView.mm: (-[WebViewPrivate init]): Initialize based on WebSmartInsertDeleteEnabled default. (-[WebView _commonInitializationWithFrameName:groupName:usesDocumentViews:]): Removed code that initialized here. (-[WebView setSmartInsertDeleteEnabled:]): Set default here was with continuous spell checking setting.
5:50 PM Changeset in webkit [43674] by ggaren@apple.com
  • 1 edit in branches/nitro-extreme/JavaScriptCore/ChangeLog

ChangeLog reverse-o

5:49 PM Changeset in webkit [43673] by ggaren@apple.com
  • 3 edits in branches/nitro-extreme/JavaScriptCore

2009-05-13 Sam Weinig <​sam@webkit.org>

Reviewed by Gavin Barraclough.

Implemented op_not. (Gavin did most of the work!)

  • jit/JITOpcodes.cpp: (JSC::JIT::emit_op_not): (JSC::JIT::emitSlow_op_not):
5:44 PM Changeset in webkit [43672] by mitz@apple.com
  • 3 edits
    2 adds in trunk

WebCore:

Reviewed by Anders Carlsson.

  • fix <rdar://problem/5483015> Replies in Mail are drawn first without the user style sheet and then redrawn with the style sheet

Test: platform/mac/fast/loader/user-stylesheet-fast-path.html

  • page/mac/FrameMac.mm: (WebCore::Frame::setUserStyleSheetLocation): For data URLs with base64-encoded UTF-8 data, just decode the style sheet here an apply it synchronously instead of invoking an asynchronous loader.

LayoutTests:

Reviewed by Anders Carlsson.

  • test for <rdar://problem/5483015> Replies in Mail are drawn first without the user style sheet and then redrawn with the style sheet
  • platform/mac/fast/loader/user-stylesheet-fast-path-expected.txt: Added.
  • platform/mac/fast/loader/user-stylesheet-fast-path.html: Added.
5:11 PM Changeset in webkit [43671] by weinig@apple.com
  • 2 edits in branches/nitro-extreme/JavaScriptCore

2009-05-13 Sam Weinig <​sam@webkit.org>

Reviewed by Gavin Barraclough.

Implemented op_not. (Gavin did most of the work!)

  • jit/JITOpcodes.cpp: (JSC::JIT::emit_op_not): (JSC::JIT::emitSlow_op_not):
4:50 PM Changeset in webkit [43670] by Chris Fleizach
  • 2 edits in trunk/WebCore

Bug 25755: Implement ARIA grid role
​https://bugs.webkit.org/show_bug.cgi?id=25755

Fix windows build bustage

4:44 PM Changeset in webkit [43669] by Chris Fleizach
  • 24 edits
    9 adds in trunk

Bug 25755: Implement ARIA grid role
​https://bugs.webkit.org/show_bug.cgi?id=25755

4:22 PM Changeset in webkit [43668] by ggaren@apple.com
  • 4 edits in branches/nitro-extreme/JavaScriptCore

2009-05-13 Geoffrey Garen <​ggaren@apple.com>

Reviewed by Sam Weinig.


Implemented op_global_resolve.

  • jit/JITOpcodes.cpp: (JSC::JIT::emit_op_loop_if_less): (JSC::JIT::emit_op_loop_if_lesseq): Added back accidentally removed early returns.

(JSC::JIT::emit_op_resolve_global):

  • jit/JITStubs.cpp: (JSC::JITStubs::cti_op_resolve_global): Pretty similar to the old code, but we need two reads and a TimesEight step in order to account for the 64bit value size.
  • jit/JITStubs.h: (JSC::): Slightly tweaked this code to specialize for a JSGlobalObject*, to avoid having to pass an irrelevant tag pointer to the stub.
4:08 PM Changeset in webkit [43667] by barraclough@apple.com
  • 2 edits in trunk/JavaScriptCore

2009-05-13 Gavin Barraclough <​barraclough@apple.com>

Reviewed by Oliver Hunt.

Fix <rdar://problem/6882919> REGRESSION: page at Metroauto site crashes in cti_op_loop_if_less (25730)

op_loop_if_less (imm < op) was loading op into regT1, but in the slow path spills regT0.
This leads to bad happen.

  • jit/JITOpcodes.cpp: (JSC::JIT::emit_op_loop_if_less): (JSC::JIT::emitSlow_op_loop_if_less):
3:44 PM Changeset in webkit [43666] by levin@chromium.org
  • 1 edit
    1 move in trunk/WebCore

2009-05-13 David Levin <​levin@chromium.org>

Reviewed by Dimitri Glazkov.

Bug 25763: Need to move v8 custom binding to the custom directory.
​https://bugs.webkit.org/show_bug.cgi?id=25763

No test due to no change in behavior.

  • bindings/v8/custom/V8CanvasPixelArrayCustom.cpp: Renamed from WebCore/bindings/v8/V8CanvasPixelArrayCustom.cpp.
3:39 PM Changeset in webkit [43665] by Dimitri Glazkov
  • 2 edits in trunk/WebCore

2009-05-13 Nate Chapin <​japhet@google.com>

Reviewed by Dimitri Glazkov.

Fix LayoutTests/fast/dom/Element/attr-param-typechecking.html crashing with V8.
​https://bugs.webkit.org/show_bug.cgi?id=25758

  • bindings/v8/custom/V8ElementCustom.cpp: (WebCore::CALLBACK_FUNC_DECL): return the result of throwError() if it is called.
3:30 PM Changeset in webkit [43664] by Dimitri Glazkov
  • 14 edits
    8 adds in trunk

WebCore:

2009-05-13 Jeremy Moskovich <​jeremy@chromium.org>

Reviewed by Dave Hyatt.

Fix a number of bugs relating to RTL and text-overflow:ellipsis.
Also refactor the relevant code to make it a little clearer.

This CL fixes 3 fundamental issues:

  • Corrects behavior if the truncated InlineTextBox's directionality is different from the overall flow direction - bug 25135.
  • Make decoration drawing in InlineFlowbox RTL-aware - bug 24206.
  • Full truncation on InlineBoxes in RTL flow - bug 24186
  • Add tests for the above + reorder/cleanup tests for easier interpretation of outcome.

The code for placing ellipsis has been refactored to use
left/right notation rather than a single variable whose meaning
could differ based on flow directionality.

To support differing inline directionality vs flow directionality,
different variables are now used in InlineTextBox::placeEllipsisBox to
track the two.

The drawing mode for underlines in standards mode now correctly handles
RTL truncation and relevant test where added.

​https://bugs.webkit.org/show_bug.cgi?id=24186
​https://bugs.webkit.org/show_bug.cgi?id=25135
​https://bugs.webkit.org/show_bug.cgi?id=24206

Tests: fast/css/text-overflow-ellipsis-bidi.html

fast/css/text-overflow-ellipsis-strict.html

  • rendering/InlineBox.cpp: (WebCore::InlineBox::placeEllipsisBox):
  • rendering/InlineBox.h:
  • rendering/InlineFlowBox.cpp: (WebCore::InlineFlowBox::paintTextDecorations): (WebCore::InlineFlowBox::placeEllipsisBox):
  • rendering/InlineFlowBox.h:
  • rendering/InlineTextBox.cpp: (WebCore::InlineTextBox::placeEllipsisBox): (WebCore::InlineTextBox::paint):
  • rendering/InlineTextBox.h:
  • rendering/RenderFlexibleBox.cpp: (WebCore::RenderFlexibleBox::layoutVerticalBox):
  • rendering/RootInlineBox.cpp: (WebCore::RootInlineBox::placeEllipsis): (WebCore::RootInlineBox::placeEllipsisBox):
  • rendering/RootInlineBox.h:
  • rendering/bidi.cpp: (WebCore::RenderBlock::checkLinesForTextOverflow):

LayoutTests:

2009-05-13 Jeremy Moskovich <​jeremy@chromium.org>

Reviewed by Dave Hyatt.

Fix a number of bugs relating to RTL and text-overflow:ellipsis.
Also refactor the relevant code to make it a little clearer.

This CL fixes 3 fundamental issues:

  • Corrects behavior if the truncated InlineTextBox's directionality is different from the overall flow direction - bug 25135.
  • Make decoration drawing in InlineFlowbox RTL-aware - bug 24206.
  • Full truncation on InlineBoxes in RTL flow - bug 24186
  • Add tests for the above + reorder/cleanup tests for easier interpretation of outcome.

The code for placing ellipsis has been refactored to use
left/right notation rather than a single variable whose meaning
could differ based on flow directionality.

To support differing inline directionality vs flow directionality,
different variables are now used in InlineTextBox::placeEllipsisBox to
track the two.

The drawing mode for underlines in standards mode now correctly handles
RTL truncation and relevant test where added.

​https://bugs.webkit.org/show_bug.cgi?id=24186
​https://bugs.webkit.org/show_bug.cgi?id=25135
​https://bugs.webkit.org/show_bug.cgi?id=24206

  • fast/css/text-overflow-ellipsis-bidi.html: Added.
  • fast/css/text-overflow-ellipsis-strict.html: Added.
  • fast/css/text-overflow-ellipsis.html:
  • platform/mac/fast/css/text-overflow-ellipsis-bidi-expected.checksum: Added.
  • platform/mac/fast/css/text-overflow-ellipsis-bidi-expected.png: Added.
  • platform/mac/fast/css/text-overflow-ellipsis-bidi-expected.txt: Added.
  • platform/mac/fast/css/text-overflow-ellipsis-expected.txt:
  • platform/mac/fast/css/text-overflow-ellipsis-strict-expected.checksum: Added.
  • platform/mac/fast/css/text-overflow-ellipsis-strict-expected.png: Added.
  • platform/mac/fast/css/text-overflow-ellipsis-strict-expected.txt: Added.
3:09 PM Changeset in webkit [43663] by dimich@chromium.org
  • 23 edits in trunk

JavaScriptCore:

2009-05-13 Dmitry Titov <​dimich@chromium.org>

Rubber-stamped by Mark Rowe.

​https://bugs.webkit.org/show_bug.cgi?id=25746
Revert ​http://trac.webkit.org/changeset/43507 which caused crash in PPC nightlies with Safari 4.

  • JavaScriptCore.exp:
  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore_debug.def:
  • bytecode/SamplingTool.cpp: (JSC::SamplingThread::start): (JSC::SamplingThread::stop):
  • bytecode/SamplingTool.h:
  • wtf/CrossThreadRefCounted.h: (WTF::CrossThreadRefCounted::CrossThreadRefCounted): (WTF::::ref): (WTF::::deref):
  • wtf/Threading.h:
  • wtf/ThreadingNone.cpp:
  • wtf/ThreadingPthreads.cpp: (WTF::threadMapMutex): (WTF::initializeThreading): (WTF::threadMap): (WTF::identifierByPthreadHandle): (WTF::establishIdentifierForPthreadHandle): (WTF::pthreadHandleForIdentifier): (WTF::clearPthreadHandleForIdentifier): (WTF::createThreadInternal): (WTF::waitForThreadCompletion): (WTF::detachThread): (WTF::currentThread):
  • wtf/ThreadingWin.cpp: (WTF::threadMapMutex): (WTF::initializeThreading): (WTF::threadMap): (WTF::storeThreadHandleByIdentifier): (WTF::threadHandleForIdentifier): (WTF::clearThreadHandleForIdentifier): (WTF::createThreadInternal): (WTF::waitForThreadCompletion): (WTF::detachThread): (WTF::currentThread):
  • wtf/gtk/ThreadingGtk.cpp: (WTF::threadMapMutex): (WTF::initializeThreading): (WTF::threadMap): (WTF::identifierByGthreadHandle): (WTF::establishIdentifierForThread): (WTF::threadForIdentifier): (WTF::clearThreadForIdentifier): (WTF::createThreadInternal): (WTF::waitForThreadCompletion): (WTF::currentThread):
  • wtf/qt/ThreadingQt.cpp: (WTF::threadMapMutex): (WTF::threadMap): (WTF::identifierByQthreadHandle): (WTF::establishIdentifierForThread): (WTF::clearThreadForIdentifier): (WTF::threadForIdentifier): (WTF::initializeThreading): (WTF::createThreadInternal): (WTF::waitForThreadCompletion): (WTF::currentThread):

WebCore:

2009-05-13 Dmitry Titov <​dimich@chromium.org>

Rubber-stamped by Mark Rowe.

​https://bugs.webkit.org/show_bug.cgi?id=25746
Revert ​http://trac.webkit.org/changeset/43507 which caused crash in PPC nightlies with Safari 4.

  • dom/XMLTokenizerLibxml2.cpp: (WebCore::matchFunc): (WebCore::openFunc): (WebCore::createStringParser): (WebCore::createMemoryParser):
  • loader/icon/IconDatabase.cpp: (WebCore::IconDatabase::open):
  • platform/sql/SQLiteDatabase.cpp: (WebCore::SQLiteDatabase::SQLiteDatabase): (WebCore::SQLiteDatabase::close):
  • storage/DatabaseThread.cpp: (WebCore::DatabaseThread::DatabaseThread): (WebCore::DatabaseThread::start): (WebCore::DatabaseThread::databaseThread):
  • storage/LocalStorageThread.cpp: (WebCore::LocalStorageThread::LocalStorageThread): (WebCore::LocalStorageThread::start): (WebCore::LocalStorageThread::localStorageThread): (WebCore::LocalStorageThread::scheduleImport): (WebCore::LocalStorageThread::scheduleSync): (WebCore::LocalStorageThread::terminate):
  • workers/WorkerThread.cpp: (WebCore::WorkerThread::WorkerThread): (WebCore::WorkerThread::start):

WebKit/win:

2009-05-13 Dmitry Titov <​dimich@chromium.org>

Rubber-stamped by Mark Rowe.

​https://bugs.webkit.org/show_bug.cgi?id=25746
Revert ​http://trac.webkit.org/changeset/43507 which caused crash in PPC nightlies with Safari 4.

  • WebKit.vcproj/WebKit.def:
  • WebKit.vcproj/WebKit_debug.def:
2:55 PM Changeset in webkit [43662] by hyatt@apple.com
  • 3 edits
    4 adds in trunk

WebCore:

2009-05-13 David Hyatt <​hyatt@apple.com>

Reviewed by Beth Dakin.

Fix for <rdar://problem/6872894> REGRESSION (r41896-42143): First letter cut off in styled select menus


Make sure to do rounded clipping for overflow and controls relative to the border box and not to the overflow/control clip rect
(which is typically clipped to the padding or content box). Doing so was causing rounded clips to be incorrectly applied to padding and
content.


Added fast/overflow/border-radius-clipping.html

  • rendering/RenderBox.cpp: (WebCore::RenderBox::pushContentsClip):

LayoutTests:

2009-05-13 David Hyatt <​hyatt@apple.com>

Reviewed by Beth Dakin.

Add layout test for <rdar://problem/6872894> REGRESSION (r41896-42143): First letter cut off in styled select menus.

  • fast/overflow/border-radius-clipping.html: Added.
  • platform/mac/fast/overflow/border-radius-clipping-expected.checksum: Added.
  • platform/mac/fast/overflow/border-radius-clipping-expected.png: Added.
  • platform/mac/fast/overflow/border-radius-clipping-expected.txt: Added.
2:53 PM Changeset in webkit [43661] by Darin Adler
  • 52 edits in trunk

JavaScriptCore:

2009-05-13 Darin Adler <Darin Adler>

Revert the parser arena change. It was a slowdown, not a speedup.
Better luck next time (I'll break it up into pieces).

WebCore:

2009-05-13 Darin Adler <Darin Adler>

Revert the parser arena change. It was a slowdown, not a speedup.
Better luck next time (I'll break it up into pieces).

WebKit/mac:

2009-05-13 Darin Adler <Darin Adler>

Revert the parser arena change. It was a slowdown, not a speedup.
Better luck next time (I'll break it up into pieces).

2:25 PM Changeset in webkit [43660] by weinig@apple.com
  • 2 edits in branches/nitro-extreme/JavaScriptCore

2009-05-13 Sam Weinig <​sam@webkit.org>

Reviewed by Geoffrey Garen.

Implemented op_to_jsnumber.

  • jit/JITOpcodes.cpp: (JSC::JIT::emit_op_to_jsnumber): (JSC::JIT::emitSlow_op_to_jsnumber):
2:12 PM Changeset in webkit [43659] by kov@webkit.org
  • 1 copy in releases/WebKitGTK/webkit-1.1.7

Tagging 1.1.7.

2:08 PM Changeset in webkit [43658] by alice.liu@apple.com
  • 1 edit in trunk/LayoutTests/platform/mac/fast/forms/search-styled-expected.txt

uploading new results. when I added this test, i committed outdated results.

1:56 PM Changeset in webkit [43657] by hyatt@apple.com
  • 5 edits
    4 adds in trunk

WebCore:

2009-05-13 David Hyatt <​hyatt@apple.com>

Reviewed by Beth Dakin and Darin Adler.

Fix for <rdar://problem/6869687> REGRESSION (r41203): Facebook friend suggestions disappear on update.


Make sure that renderers are marked for layout if a style change causes them to switch from having a self-painting layer
to a non-self-painting layer (and vice versa).


Move misplaced layer repainting code that was in RenderBox up into RenderBoxModelObject so that inlines with layers
repaint properly on opacity changes, etc.

Added fast/repaint/opacity-change-on-overflow-float.html.

  • rendering/RenderBox.cpp: (WebCore::RenderBox::styleWillChange):
  • rendering/RenderBoxModelObject.cpp: (WebCore::RenderBoxModelObject::styleWillChange): (WebCore::RenderBoxModelObject::styleDidChange):
  • rendering/RenderBoxModelObject.h:

LayoutTests:

2009-05-13 David Hyatt <​hyatt@apple.com>

Reviewed by Beth Dakin and Darin Adler.

Add a repaint test for <rdar://problem/6869687> REGRESSION (r41203): Facebook friend suggestions disappear on update.

  • fast/repaint/opacity-change-on-overflow-float.html: Added.
  • platform/mac/fast/repaint/opacity-change-on-overflow-float-expected.checksum: Added.
  • platform/mac/fast/repaint/opacity-change-on-overflow-float-expected.png: Added.
  • platform/mac/fast/repaint/opacity-change-on-overflow-float-expected.txt: Added.
1:49 PM Changeset in webkit [43656] by weinig@apple.com
  • 2 edits in branches/nitro-extreme/JavaScriptCore

2009-05-13 Sam Weinig <​sam@webkit.org>

Reviewed by Geoffrey Garen.

Implemented op_convert_this.

  • jit/JITOpcodes.cpp: (JSC::JIT::emit_op_convert_this): (JSC::JIT::emitSlow_op_convert_this):
1:46 PM Changeset in webkit [43655] by kov@webkit.org
  • 2 edits in trunk/LayoutTests

2009-05-13 Gustavo Noronha Silva <​gustavo.noronha@collabora.co.uk>

Disable new tests. We are not going to be adding more new test
results for now, for we want to better sort out things such as
fixed DPI, and easily reproducible font configuration.

  • platform/gtk/Skipped:
1:38 PM Changeset in webkit [43654] by Darin Adler
  • 2 edits in trunk/JavaScriptCore

2009-05-13 Darin Adler <Darin Adler>

Tiger build fix.

  • parser/Grammar.y: Add back empty code blocks, needed by older versions of bison on certain rules.
1:31 PM Changeset in webkit [43653] by ggaren@apple.com
  • 8 edits in branches/nitro-extreme/JavaScriptCore

2009-05-13 Geoffrey Garen <​ggaren@apple.com>

Reviewed by Sam Weinig.


Got basic JS function and constructor calls working.

  • jit/JIT.cpp: (JSC::JIT::privateCompileCTIMachineTrampolines):
  • jit/JIT.h:
  • jit/JITCall.cpp: (JSC::JIT::compileOpCallSetupArgs): (JSC::JIT::compileOpCallVarargsSetupArgs): (JSC::JIT::compileOpConstructSetupArgs): (JSC::JIT::emit_op_ret): (JSC::JIT::emit_op_construct_verify): (JSC::JIT::emitSlow_op_construct_verify): (JSC::JIT::emitSlow_op_call): (JSC::JIT::emitSlow_op_call_eval): (JSC::JIT::emitSlow_op_call_varargs): (JSC::JIT::emitSlow_op_construct): (JSC::JIT::compileOpCall): Filled out these cases, with call_eval #if'd out.
  • jit/JITInlineMethods.h: (JSC::JIT::emitPutJITStubArgFromVirtualRegister): (JSC::JIT::emitLoad): Restored some legacy "*CTIArg*" functions, since I wanted to avoid the complexity of revamping the API here while trying to bring it up. Eventually, we should re-remove all of these functions.

(JSC::JIT::recordJumpTarget): Removed unnecessary macro cruft. You will
not silence me, Sam Weinig! The world will know that you are a crufty,
crufty, crufty programmer!!!

  • jit/JITOpcodes.cpp:
  • jit/JITStubs.cpp: (JSC::):
  • jit/JITStubs.h: Changed up some offsets in the JITStackFrame class, since and off-by-one error was causing stack misalignment.
12:40 PM Changeset in webkit [43652] by Dimitri Glazkov
  • 2 edits in trunk/WebCore

2009-05-13 Dimitri Glazkov <Dimitri Glazkov>

Not reviewed, build fix.

Move an include, needed by Debugger under the corresponding guard.

  • inspector/InspectorController.cpp: Moved parser/SourceCode under JAVASCRIPT_DEBUGGER

guard.

12:38 PM Changeset in webkit [43651] by weinig@apple.com
  • 4 edits in branches/nitro-extreme/JavaScriptCore

2009-05-13 Sam Weinig <​sam@webkit.org>

Reviewed by Geoffrey Garen.

Implement op_eq_null and op_neq_null.

  • assembler/MacroAssemblerX86Common.h: (JSC::MacroAssemblerX86Common::set8): (JSC::MacroAssemblerX86Common::setTest8):
  • jit/JITOpcodes.cpp: (JSC::JIT::emit_op_stricteq): (JSC::JIT::emitSlow_op_stricteq): (JSC::JIT::emit_op_nstricteq): (JSC::JIT::emitSlow_op_nstricteq): (JSC::JIT::emit_op_eq_null): (JSC::JIT::emit_op_neq_null):
  • jsc.cpp:
12:15 PM Changeset in webkit [43650] by levin@chromium.org
  • 3 edits
    3 adds in trunk

WebCore:

2009-05-13 David Levin <​levin@chromium.org>

Reviewed by Darin Adler.

Bug 25394: REGRESSION: crash in DocumentLoader::addResponse due to bad |this| pointer
​https://bugs.webkit.org/show_bug.cgi?id=25394

Test: http/tests/xmlhttprequest/frame-unload-abort-crash.html

  • loader/SubresourceLoader.cpp: (WebCore::SubresourceLoader::create): Add another check to subresource loader to avoid doing any loads in frames when the loaders are being stopped.

LayoutTests:

2009-05-13 David Levin <​levin@chromium.org>

Reviewed by Darin Adler.

Bug 25394: REGRESSION: crash in DocumentLoader::addResponse due to bad |this| pointer
​https://bugs.webkit.org/show_bug.cgi?id=25394

Request a subresource load for an IMG after 'unload' and before the next
page load completes to expose the crash.

  • http/tests/xmlhttprequest/frame-unload-abort-crash-expected.txt: Added.
  • http/tests/xmlhttprequest/frame-unload-abort-crash.html: Added.
  • http/tests/xmlhttprequest/resources/xmlhttprequest-in-unload.html: Added.
12:13 PM Changeset in webkit [43649] by kov@webkit.org
  • 2 edits in trunk/WebCore

2009-05-13 Stephan Haller <​nomad@froevel.de>

Reviewed by Gustavo Noronha.

Wrong handling of file upload if no file selected
​https://bugs.webkit.org/show_bug.cgi?id=25649

Fixed returned path if path is empty

  • WebCore/platform/gtk/FileSystemGtk.cpp:
12:08 PM Changeset in webkit [43648] by sfalken@apple.com
  • 2 edits in trunk/JavaScriptCore

Windows build fix.

11:42 AM Changeset in webkit [43647] by Adam Roben
  • 10 edits in trunk/JavaScriptCore

Windows build fixes after r43642

  • debugger/Debugger.cpp:
  • runtime/ArrayConstructor.cpp:
  • runtime/JSArray.cpp:
  • runtime/RegExp.cpp:
  • runtime/RegExpConstructor.cpp:
  • runtime/RegExpPrototype.cpp:
  • runtime/StringPrototype.cpp: Added missing #includes.
11:33 AM Changeset in webkit [43646] by mitz@apple.com
  • 5 edits
    8 adds in trunk

WebCore:

Reviewed by Dave Hyatt.

  • fix <rdar://problem/6805567> REGRESSION (r42348): Notes flicker white when loading

Tests: fast/frames/content-opacity-1.html

fast/frames/content-opacity-2.html

  • page/FrameView.cpp: (WebCore::FrameView::reset): Reset m_contentIsOpaque to false. (WebCore::FrameView::useSlowRepaints): Use slow repaints if the content is not known to be opaque. (WebCore::FrameView::setContentIsOpaque): Added. Sets m_contentIsOpaque and enables or disables fast repaints accordingly.
  • page/FrameView.h:
  • rendering/RenderBoxModelObject.cpp: (WebCore::RenderBoxModelObject::paintFillLayerExtended): Removed the document()->haveStylesheetsLoaded() condition in determining whether the root is opaque. This is what was causing the bug, as iframes were considered to be opaque, and thus painted an opaque white background, whenever they were pending a style sheet load. Changed to call FrameView::setContentIsOpaqe() instead of setUseSlowRepaints(), which allows the frame to go back to fast repaints if the content becomes opaque. Corrected the check for background color opacity: any alpha value other than 255--not just zero--is not opaque.

LayoutTests:

Reviewed by Dave Hyatt.

  • tests for <rdar://problem/6805567> REGRESSION (r42348): Notes flicker white when loading
  • fast/frames/content-opacity-1.html: Added.
  • fast/frames/content-opacity-2.html: Added.
  • platform/mac/fast/frames/content-opacity-1-expected.checksum: Added.
  • platform/mac/fast/frames/content-opacity-1-expected.png: Added.
  • platform/mac/fast/frames/content-opacity-1-expected.txt: Added.
  • platform/mac/fast/frames/content-opacity-2-expected.checksum: Added.
  • platform/mac/fast/frames/content-opacity-2-expected.png: Added.
  • platform/mac/fast/frames/content-opacity-2-expected.txt: Added.
11:30 AM Changeset in webkit [43645] by ariya@webkit.org
  • 2 edits in trunk/WebCore

2009-05-13 Ariya Hidayat <​ariya.hidayat@nokia.com>

Reviewed by Sam Weinig.

[Qt] Fix "lighther" composition mode.
QPainter::CompositionMode_Plus is the right match.

  • platform/graphics/qt/GraphicsContextQt.cpp: (WebCore::toQtCompositionMode):
11:19 AM Changeset in webkit [43644] by xan@webkit.org
  • 2 edits in trunk/WebKit/gtk

2009-05-13 Xan Lopez <​xlopez@igalia.com>

Reviewed by Gustavo Noronha.

Do not handle KeyEvents with Ctrl or Alt modifiers that we
otherwise know nothing about. Otherwise shortcuts defined in the
WebView will never be executed.

  • WebCoreSupport/EditorClientGtk.cpp: (WebKit::handleEditingKeyboardEvent):
11:15 AM Changeset in webkit [43643] by Darin Adler
  • 1 edit in trunk/JavaScriptCore/ChangeLog

Darn, Cameron caught it but I forgot to fix it.

11:14 AM Changeset in webkit [43642] by Darin Adler
  • 43 edits in trunk

JavaScriptCore:

2009-05-13 Darin Adler <Darin Adler>

Reviewed by Cameron Zwarich.

Bug 25674: syntax tree nodes should use arena allocation
​https://bugs.webkit.org/show_bug.cgi?id=25674

Step 3: Add some actual arena allocation. About 1% SunSpider speedup.

  • bytecompiler/BytecodeGenerator.cpp: (JSC::BytecodeGenerator::BytecodeGenerator): Updated since VarStack contains const Identifier* now. (JSC::BytecodeGenerator::emitPushNewScope): Updated to take a const Identifier&.
  • bytecompiler/BytecodeGenerator.h: Ditto
  • bytecompiler/SegmentedVector.h: Added isEmpty.
  • debugger/Debugger.cpp: (JSC::Debugger::recompileAllJSFunctions): Moved this function here from WebCore so WebCore doesn't need the details of FunctionBodyNode.
  • debugger/Debugger.h: Ditto.
  • interpreter/Interpreter.cpp: (JSC::Interpreter::execute): Updated since VarStack contains const Identifier* now.
  • jit/JITStubs.cpp: (JSC::JITStubs::cti_vm_lazyLinkCall): Call isHostFunction on the body rather than on the function object, since we can't easily have inlined access to the FunctionBodyNode in JSFunction.h since WebCore needs access to that header. (JSC::JITStubs::cti_op_construct_JSConstruct): Ditto.
  • profiler/Profiler.cpp: (JSC::Profiler::createCallIdentifier): Ditto.
  • parser/Grammar.y: Use JSGlobalData* to pass the global data pointer around whenever possible instead of using void*. Changed SET_EXCEPTION_LOCATION from a macro to an inline function. Marked the structure-creating functions inline. Changed the VarStack to use identifier pointers instead of actual identifiers. This takes advantage of the fact that all identifier pointers come from the arena and avoids referenc count churn. Changed Identifier* to const Identifier* to make sure we don't modify any by accident. Used identifiers for regular expression strings too, using the new scanRegExp that has out parameters instead of the old one that relied on side effects in the Lexer. Move the creation of numeric identifiers out of this file and into the PropertyNode constructor.
  • parser/Lexer.cpp: (JSC::Lexer::setCode): Pass in ParserArena, used for identifiers. (JSC::Lexer::makeIdentifier): Changed return type to const Identifier* and changed to call ParserArena. (JSC::Lexer::scanRegExp): Added out arguments that are const Identifier* as well as a prefix character argument so we can handle the /= case without a string append. (JSC::Lexer::skipRegExp): Added. Skips a regular expression without allocating Identifier objects. (JSC::Lexer::clear): Removed the code to manage m_identifiers, m_pattern, and m_flags, and added code to set m_arena to 0.
  • parser/Lexer.h: Updated for changes above.
  • parser/NodeConstructors.h: (JSC::ParserArenaFreeable::operator new): Added. Calls allocateFreeable on the arena. (JSC::ParserArenaDeletable::operator new): Changed to call the allocateDeletable function on the arena instead of deleteWithArena. (JSC::RegExpNode::RegExpNode): Changed arguments to Identifier instead of UString since these come from the parser which makes identifiers. (JSC::PropertyNode::PropertyNode): Added new constructor that makes numeric identifiers. Some day we might want to optimize this for integers so it doesn't create a string for each one. (JSC::ContinueNode::ContinueNode): Initialize m_ident to nullIdentifier since it's now a const Identifier& so it can't be left uninitialized. (JSC::BreakNode::BreakNode): Ditto. (JSC::CaseClauseNode::CaseClauseNode): Updated to use SourceElements* to keep track of the statements rather than a separate statement vector. (JSC::BlockNode::BlockNode): Ditto. (JSC::ForInNode::ForInNode): Initialize m_ident to nullIdentifier.
  • parser/Nodes.cpp: Moved the comment explaining emitBytecode in here. It seemed strangely out of place in the header. (JSC::ThrowableExpressionData::emitThrowError): Added an overload for UString as well as Identifier. (JSC::SourceElements::singleStatement): Added. (JSC::SourceElements::lastStatement): Added. (JSC::RegExpNode::emitBytecode): Updated since the pattern and flags are now Identifier instead of UString. Also changed the throwError code to use the substitution mechanism instead of doing a string append. (JSC::SourceElements::emitBytecode): Added. Replaces the old statementListEmitCode function, since we now keep the SourceElements objects around. (JSC::BlockNode::lastStatement): Added. (JSC::BlockNode::emitBytecode): Changed to use emitBytecode instead of statementListEmitCode. (JSC::CaseClauseNode::emitBytecode): Added. (JSC::CaseBlockNode::emitBytecodeForBlock): Changed to use emitBytecode instead of statementListEmitCode. (JSC::ScopeNodeData::ScopeNodeData): Changed to store the SourceElements* instead of using releaseContentsIntoVector. (JSC::ScopeNode::emitStatementsBytecode): Added. (JSC::ScopeNode::singleStatement): Added. (JSC::ProgramNode::emitBytecode): Call emitStatementsBytecode instead of statementListEmitCode. (JSC::EvalNode::emitBytecode): Ditto. (JSC::EvalNode::generateBytecode): Removed code to clear the children vector. This optimization is no longer possible since everything is in a single arena. (JSC::FunctionBodyNode::emitBytecode): Call emitStatementsBytecode insetad of statementListEmitCode and check for the return node using the new functions.
  • parser/Nodes.h: Changed VarStack to store const Identifier* instead of Identifier and rely on the arena to control lifetime. Added a new ParserArenaFreeable class. Made ParserArenaDeletable inherit from FastAllocBase instead of having its own operator new. Base the Node class on ParserArenaFreeable. Changed the various Node classes to use const Identifier& instead of Identifier to avoid the need to call their destructors and allow them to function as "freeable" in the arena. Removed extraneous JSC_FAST_CALL on definitions of inline functions. Changed ElementNode, PropertyNode, ArgumentsNode, ParameterNode, CaseClauseNode, ClauseListNode, and CaseBlockNode to use ParserArenaFreeable as a base class since they do not descend from Node. Eliminated the StatementVector type and instead have various classes use SourceElements* instead of StatementVector. This prevents those classes from having th use ParserArenaDeletable to make sure the vector destructor is called.
  • parser/Parser.cpp: (JSC::Parser::parse): Pass the arena to the lexer.
  • parser/Parser.h: Added an include of ParserArena.h, which is no longer included by Nodes.h.
  • parser/ParserArena.cpp: (JSC::ParserArena::ParserArena): Added. Initializes the new members, m_freeableMemory, m_freeablePoolEnd, and m_identifiers. (JSC::ParserArena::freeablePool): Added. Computes the pool pointer, since we store only the current pointer and the end of pool pointer. (JSC::ParserArena::deallocateObjects): Added. Contains the common memory-deallocation logic used by both the destructor and the reset function. (JSC::ParserArena::~ParserArena): Changed to call deallocateObjects. (JSC::ParserArena::reset): Ditto. Also added code to zero out the new structures, and switched to use clear() instead of shrink(0) since we don't really reuse arenas. (JSC::ParserArena::makeNumericIdentifier): Added. (JSC::ParserArena::allocateFreeablePool): Added. Used when the pool is empty. (JSC::ParserArena::isEmpty): Added. No longer inline, which is fine since this is used only for assertions at the moment.
  • parser/ParserArena.h: Added an actual arena of "freeable" objects, ones that don't need destructors to be called. Also added the segmented vector of identifiers that used to be in the Lexer.
  • runtime/FunctionConstructor.cpp: (JSC::extractFunctionBody): Use singleStatement function rather than getting at a StatementVector.
  • runtime/FunctionPrototype.cpp: (JSC::functionProtoFuncToString): Call isHostFunction on the body rather than the function object.
  • runtime/JSFunction.cpp: (JSC::JSFunction::JSFunction): Moved the structure version of this in here from the header. It's not hot enough that it needs to be inlined. (JSC::JSFunction::isHostFunction): Moved this in here from the header. It's now a helper to be used only within the class. (JSC::JSFunction::setBody): Moved this in here. It's not hot enough that it needs to be inlined, and we want to be able to compile the header without the definition of FunctionBodyNode.
  • runtime/JSFunction.h: Eliminated the include of "Nodes.h". This was exposing too much JavaScriptCore dependency to WebCore. Because of this change and some changes made to WebCore, we could now export a lot fewer headers from JavaScriptCore, but I have not done that yet in this check-in. Made a couple functions non-inline. Removes some isHostFunction() assertions.


  • wtf/FastAllocBase.h: Added the conventional using statements we use in WTF so we can use identifiers from the WTF namespace without explicit namespace qualification or namespace directive. This is the usual WTF style, although it's unconventional in the C++ world. We use the namespace primarily for link-time disambiguation, not compile-time.
  • wtf/FastMalloc.cpp: Fixed an incorrect comment.

WebCore:

2009-05-13 Darin Adler <Darin Adler>

Reviewed by Cameron Zwarich.

Bug 25674: syntax tree nodes should use arena allocation
​https://bugs.webkit.org/show_bug.cgi?id=25674

  • bindings/js/JSDOMBinding.h: Removed include of JSFunction.h. We don't want the entire DOM binding to depend on that file.
  • bindings/js/JSAudioConstructor.cpp: Added include of Error.h. Before we inherited this automatically because JDDOMBinding.h included JSFunction.h, but that was excessive.
  • bindings/js/JSDOMWindowCustom.cpp: Ditto.
  • bindings/js/JSHTMLInputElementCustom.cpp: Ditto.
  • bindings/js/JSImageConstructor.cpp: Ditto.
  • bindings/js/JSLazyEventListener.cpp: Ditto, but for JSFunction.h.
  • bindings/js/JSMessageChannelConstructor.cpp: Ditto.
  • bindings/js/JSOptionConstructor.cpp: Ditto.
  • bindings/js/JSWorkerConstructor.cpp: Ditto.
  • bindings/js/JSXMLHttpRequestConstructor.cpp: Ditto.
  • bridge/jni/jni_jsobject.mm: Ditto, but for SourceCode.h.
  • inspector/InspectorController.cpp: Ditto.
  • inspector/JavaScriptDebugServer.cpp: (WebCore::JavaScriptDebugServer::recompileAllJSFunctions): Moved mose of this function into the base class in JavaScriptCore, so the details of compilation don't have to be exposed.

WebKit/mac:

2009-05-13 Darin Adler <Darin Adler>

Reviewed by Cameron Zwarich.

Bug 25674: syntax tree nodes should use arena allocation
​https://bugs.webkit.org/show_bug.cgi?id=25674

  • Plugins/Hosted/NetscapePluginInstanceProxy.mm: Updated includes. New ones needed due to reducing includes of JSDOMBinding.h.
  • WebView/WebScriptDebugger.mm: Ditto.
11:05 AM Changeset in webkit [43641] by xan@webkit.org
  • 1 edit in trunk/JavaScriptCore/ChangeLog

Forgot to add ChangeLog.

11:03 AM Changeset in webkit [43640] by xan@webkit.org
  • 1 edit in trunk/JavaScriptCore/GNUmakefile.am

2009-05-13 Xan Lopez <​xlopez@igalia.com>

Unreviewed build fix: add JITStubCall.h to files list.

  • GNUmakefile.am:
11:02 AM Changeset in webkit [43639] by Darin Adler
  • 17 edits in trunk

WebCore:

2009-05-13 Douglas R. Davidson <​ddavidso@apple.com>

Reviewed by Darin Adler.

<rdar://problem/6879145>
Generate a contextual menu item allowing autocorrections to
easily be changed back. Refrain from re-correcting items
that have already been autocorrected once.

  • dom/DocumentMarker.h:
  • editing/Editor.cpp: (WebCore::Editor::markAllMisspellingsAndBadGrammarInRanges): (WebCore::Editor::changeBackToReplacedString):
  • editing/Editor.h:
  • page/ContextMenuController.cpp: (WebCore::ContextMenuController::contextMenuItemSelected):
  • page/mac/WebCoreViewFactory.h:
  • platform/ContextMenu.cpp: (WebCore::ContextMenu::populate): (WebCore::ContextMenu::checkOrEnableIfNeeded):
  • platform/ContextMenuItem.h:
  • platform/LocalizedStrings.h:
  • platform/mac/LocalizedStringsMac.mm: (WebCore::contextMenuItemTagChangeBack):
  • rendering/HitTestResult.cpp: (WebCore::HitTestResult::replacedString):
  • rendering/HitTestResult.h:
  • rendering/InlineTextBox.cpp: (WebCore::InlineTextBox::computeRectForReplacementMarker): (WebCore::InlineTextBox::paintDocumentMarkers):
  • rendering/InlineTextBox.h:

WebKit/mac:

2009-05-13 Douglas R. Davidson <​ddavidso@apple.com>

Reviewed by Darin Adler.

<rdar://problem/6879145>
Generate a contextual menu item allowing autocorrections to
easily be changed back. Refrain from re-correcting items
that have already been autocorrected once.

  • WebCoreSupport/WebViewFactory.mm: (-[WebViewFactory contextMenuItemTagChangeBack:]):
  • WebView/WebUIDelegatePrivate.h:
10:56 AM Changeset in webkit [43638] by ariya@webkit.org
  • 2 edits in trunk/WebKit/qt

2009-05-13 Yael Aharon <​yael.aharon@nokia.com>

Reviewed by Ariya Hidayat.

Move emitting the signal QWebFrame::urlChanged to FrameLoaderClientQt::dispatchDidCommitLoad().
This is to ensure that urlChanged() is emitted even if the frame has no title.

  • WebCoreSupport/FrameLoaderClientQt.cpp: (WebCore::FrameLoaderClientQt::dispatchDidReceiveTitle): (WebCore::FrameLoaderClientQt::dispatchDidCommitLoad):
10:13 AM Changeset in webkit [43637] by ariya@webkit.org
  • 2 edits in trunk/JavaScriptCore

2009-05-13 Ariya Hidayat <​ariya.hidayat@nokia.com>

Unreviewed build fix, as suggested by Yael Aharon <​yael.aharon@nokia.com>.

  • wtf/qt/ThreadingQt.cpp: (WTF::waitForThreadCompletion): renamed IsValid to isValid.
9:35 AM Changeset in webkit [43636] by ddkilzer@apple.com
  • 2 edits in trunk/WebKitTools

Fix resolve-ChangeLogs when used with Subversion

Reviewed by Darin Adler.

Fixes the following issue when run on a Subversion repository:

$ ./WebKitTools/Scripts/resolve-ChangeLogs
ERROR: --continue may only be used with a git repository

  • Scripts/resolve-ChangeLogs: Check for the boolean value of $gitRebaseContinue, not whether it's defined, when validating command-line switches.
9:21 AM Changeset in webkit [43635] by kov@webkit.org
  • 2 edits in trunk/WebKit/gtk

2009-05-13 Gustavo Noronha Silva <​gustavo.noronha@collabora.co.uk>

Add information about the SVG index bounds check committed in
r43590.

  • NEWS:
9:19 AM Changeset in webkit [43634] by zecke@webkit.org
  • 2 edits in trunk/WebCore

[GTK] Fix Gtk+/X11 build on OSX

Including the CoreFoundation header here and X11 headers
later will result in different definitions for Boolean. The
CoreFoundation include does not seem to be necessary here
and my mac build was successfull without it. I will remove
it for now. If the build bots disagree this will be replaced
by a #if PLATFORM(CF).

9:19 AM Changeset in webkit [43633] by zecke@webkit.org
  • 2 edits in trunk/WebCore

[GTK] Move the #ifdef around for a buildfix for Gtk+ on OSX

When building Gtk+ on OSX we ended up declaring
setNPWindowIfNeeded twice. Fix that by moving
the #if PLATFORM(GTK) up and using elif instead of
else.

9:15 AM Changeset in webkit [43632] by kov@webkit.org
  • 1 edit in trunk/WebKit/gtk/NEWS

Small typo fix superseed -> supersede

9:08 AM Changeset in webkit [43631] by ap@webkit.org
  • 1 edit
    2 adds in trunk/LayoutTests

Reviewed by Darin Adler.

​https://bugs.webkit.org/show_bug.cgi?id=25749
Add a test for non-same origin appcache manifest URL

  • http/tests/appcache/different-origin-manifest-expected.txt: Added.
  • http/tests/appcache/different-origin-manifest.html: Added.
9:08 AM Changeset in webkit [43630] by kov@webkit.org
  • 2 edits in trunk/WebKit/gtk

2009-05-13 Gustavo Noronha Silva <​gustavo.noronha@collabora.co.uk>

Reviewed by Xan Lopez.

Note changes since 1.1.6.

  • NEWS:
8:25 AM Changeset in webkit [43629] by kov@webkit.org
  • 3 edits in trunk/WebKit/gtk

2009-05-13 Gustavo Noronha Silva <​gustavo.noronha@collabora.co.uk>

Unreviewed. Updated control file, and main file for the 1.1.7
release.

  • docs/webkitgtk-docs.sgml:
  • docs/webkitgtk-sections.txt:
7:54 AM Changeset in webkit [43628] by xan@webkit.org
  • 2 edits in trunk

2009-05-13 Xan Lopez <​xlopez@igalia.com>

Unreviewed: bump versions in preparation for 1.1.7 release.

  • configure.ac:
7:49 AM Changeset in webkit [43627] by xan@webkit.org
  • 1 edit
    1 add in trunk/WebKit/gtk/po

2009-05-13 Luca Ferretti <​elle.uca@libero.it>

Rubber-stamped by Xan Lopez.

New Italian translation.

  • it.po: Added.
7:22 AM Changeset in webkit [43626] by jmalonzo@webkit.org
  • 2 edits in trunk/JavaScriptCore

Revert "2009-05-12 Jan Michael Alonzo <​jmalonzo@webkit.org>"

This reverts commit Revert r43562 - [Gtk] WTF_USE_JSC is already defined in
WebCore/config.h.

  • wtf/Platform.h:
7:20 AM Changeset in webkit [43625] by ariya@webkit.org
  • 2 edits in trunk/WebKit/qt

2009-05-13 Kenneth Rohde Christiansen <​kenneth.christiansen@openbossa.org>

Rubberstamped by Ariya Hidayat.

Fix coding style: Add {} to contents of if, containing a for loop.

7:04 AM Changeset in webkit [43624] by xan@webkit.org
  • 8 edits in trunk

WebCore:

2009-05-13 Holger Hans Peter Freyther <​zecke@selfish.org>

Reviewed by Xan Lopez.

​https://bugs.webkit.org/show_bug.cgi?id=25685
[GTK] Middle click paste form the pasteboard

The kit wants to paste from at least two different
clipboards. By introducing getCurrentTarget to the
PasteboardHelper interface we can make this decision
in the kit.
Use the new method in PasteboardGtk to get the right
GdkClipboard for the paste operation.

  • platform/gtk/PasteboardGtk.cpp: (WebCore::Pasteboard::documentFragment): (WebCore::Pasteboard::plainText):
  • platform/gtk/PasteboardHelper.h:

WebKit/gtk:

2009-05-11 Holger Hans Peter Freyther <​zecke@selfish.org>

Reviewed by Xan Lopez.

​https://bugs.webkit.org/show_bug.cgi?id=25685
[GTK] Middle click paste form the pasteboard

For paste from middle button (button==2) we want to use
the GDK_PRIMARY_SELECTION. Implement the new getCurrentTarget
method in PasteboardHelperGtk by asking the WebView which
clipboard to use.

  • WebCoreSupport/PasteboardHelperGtk.cpp: (WebKit::PasteboardHelperGtk::getCurrentTarget):
  • WebCoreSupport/PasteboardHelperGtk.h:
  • webkit/webkitprivate.h:
  • webkit/webkitwebview.cpp: (webkit_web_view_button_press_event): (webkit_web_view_use_primary_for_paste):
6:49 AM Changeset in webkit [43623] by xan@webkit.org
  • 2 edits in trunk

2009-05-13 Xan Lopez <​xlopez@igalia.com>

Rubber-stamped by Gustavo Noronha.

Revert commit r43563, since it breaks WebKitGTK+ when compiled
with gcc 4.4.

  • GNUmakefile.am:
6:34 AM Changeset in webkit [43622] by eric.carlson@apple.com
  • 3 edits in trunk/WebCore

2009-05-13 Eric Carlson <​eric.carlson@apple.com>

Reviewed by Darin Adler.

<rdar://problem/6438177> QTMoviePreferredTransformAttribute only supported on SnowLeopard
<rdar://problem/6872468> QTMovieOpenForPlaybackAttribute only supported on SnowLeopard

QTMoviePreferredTransformAttribute and QTMovieOpenForPlaybackAttribute are not supported
on Tiger or Leopard.

  • html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::setNetworkState): Remove invalid ASSERT.
  • platform/graphics/mac/MediaPlayerPrivateQTKit.mm: (WebCore::MediaPlayerPrivate::createQTMovie): Only request QTMoviePreferredTransformAttribute when !BUILDING_ON_TIGER and !BUILDING_ON_LEOPARD. (WebCore::MediaPlayerPrivate::cacheMovieScale): Only ask for QTMovieOpenForPlaybackAttribute when !BUILDING_ON_TIGER and !BUILDING_ON_LEOPARD,
5:12 AM Changeset in webkit [43621] by ariya@webkit.org
  • 3 edits in trunk/WebKit/qt

2009-05-12 Antonio Gomes <​antonio.gomes@openbossa.org>

Reviewed by Ariya Hidayat.

Fixed a possible crash @styleProperty when there is no embedded/external CSS set.

  • Api/qwebelement.cpp: (QWebElement::styleProperty):
  • tests/qwebelement/tst_qwebelement.cpp: (tst_QWebElement::style):
5:07 AM Changeset in webkit [43620] by ariya@webkit.org
  • 3 edits
    3 adds in trunk/WebKit/qt

2009-05-12 Antonio Gomes <​antonio.gomes@openbossa.org>

Reviewed by Ariya Hidayat.

Added external CSS test cases to QWebElement::styleProperty() method.

Also some ::styleProperty() tests cleanup.

  • tests/qwebelement/tst_qwebelement.cpp: (tst_QWebElement::style):
2:10 AM Changeset in webkit [43619] by barraclough@apple.com
  • 14 edits in trunk/JavaScriptCore

2009-05-12 Gavin Barraclough <​barraclough@apple.com>

Reviewed by Oliver Hunt.

Add SamplingCounter tool to provide a simple mechanism for counting events in JSC
(enabled using ENABLE(SAMPLING_COUNTERS)). To count events within a single function
use the class 'SamplingCounter', where the counter may be incremented from multiple
functions 'GlobalSamplingCounter' may be convenient; all other counters (stack or
heap allocated, rather than statically declared) should use the DeletableSamplingCounter.
Further description of these classes is provided alongside their definition in
SamplingTool.h.

Counters may be incremented from c++ by calling the 'count()' method on the counter,
or may be incremented by JIT code by using the 'emitCount()' method within the JIT.

This patch also fixes CODEBLOCK_SAMPLING, which was missing a null pointer check.

  • JavaScriptCore.exp:
  • assembler/MacroAssemblerX86.h: (JSC::MacroAssemblerX86::addWithCarry32): (JSC::MacroAssemblerX86::and32): (JSC::MacroAssemblerX86::or32):
  • assembler/MacroAssemblerX86Common.h: (JSC::MacroAssemblerX86Common::and32): (JSC::MacroAssemblerX86Common::or32):
  • assembler/MacroAssemblerX86_64.h: (JSC::MacroAssemblerX86_64::and32): (JSC::MacroAssemblerX86_64::or32): (JSC::MacroAssemblerX86_64::addPtr):
  • assembler/X86Assembler.h: (JSC::X86Assembler::): (JSC::X86Assembler::adcl_im): (JSC::X86Assembler::addq_im): (JSC::X86Assembler::andl_im): (JSC::X86Assembler::orl_im):
  • bytecode/SamplingTool.cpp: (JSC::AbstractSamplingCounter::dump):
  • bytecode/SamplingTool.h: (JSC::AbstractSamplingCounter::count): (JSC::GlobalSamplingCounter::name): (JSC::SamplingCounter::SamplingCounter):
  • jit/JIT.h:
  • jit/JITCall.cpp: (JSC::):
  • jit/JITInlineMethods.h: (JSC::JIT::setSamplingFlag): (JSC::JIT::clearSamplingFlag): (JSC::JIT::emitCount):
  • jsc.cpp: (runWithScripts):
  • parser/Nodes.cpp: (JSC::ScopeNode::ScopeNode):
  • wtf/Platform.h:
12:11 AM Changeset in webkit [43618] by sfalken@apple.com
  • 3 edits in tags/Safari-6530.9.3/JavaScriptCore

Merged r43616.

12:06 AM Changeset in webkit [43617] by sfalken@apple.com
  • 1 copy in tags/Safari-6530.9.3

New tag.

12:05 AM Changeset in webkit [43616] by sfalken@apple.com
  • 2 edits in trunk/JavaScriptCore

Windows build fix.

May 12, 2009:

11:00 PM Changeset in webkit [43615] by sfalken@apple.com
  • 3 edits in tags/Safari-6530.9.2/SunSpider

Merge r43607.

10:58 PM Changeset in webkit [43614] by weinig@apple.com
  • 3 edits in branches/nitro-extreme/JavaScriptCore

2009-05-12 Sam Weinig <​sam@webkit.org>

Reviewed by Geoffrey Garen.

Implement op_new_error.

  • jit/JITOpcodes.cpp: (JSC::JIT::emit_op_new_error):
  • jit/JITStubCall.h: (JSC::JITStubCall::addArgument): Add a version of addArgument that takes a constant JSValue.
10:58 PM Changeset in webkit [43613] by sfalken@apple.com
  • 3 edits in tags/Safari-6530.9.2/JavaScriptCore

Merged r43611.

10:47 PM Changeset in webkit [43612] by sfalken@apple.com
  • 1 copy in tags/Safari-6530.9.2

New tag.

10:46 PM Changeset in webkit [43611] by sfalken@apple.com
  • 2 edits in trunk/JavaScriptCore

Windows build fix.

10:35 PM Changeset in webkit [43610] by weinig@apple.com
  • 3 edits in branches/nitro-extreme/JavaScriptCore

2009-05-12 Sam Weinig <​sam@webkit.org>

Reviewed by Geoffrey Garen.

Remove now unused emitGetVariableObjectRegister and emitPutVariableObjectRegister.

  • jit/JIT.cpp:
  • jit/JIT.h:
10:32 PM Changeset in webkit [43609] by weinig@apple.com
  • 2 edits in branches/nitro-extreme/JavaScriptCore

2009-05-12 Sam Weinig <​sam@webkit.org>

Reviewed by Geoffrey Garen.

Implement op_to_primitive and op_next_pname.

  • jit/JITOpcodes.cpp: (JSC::JIT::emitSlow_op_construct_verify): (JSC::JIT::emit_op_to_primitive): (JSC::JIT::emitSlow_op_to_primitive): (JSC::JIT::emitSlow_op_loop_if_true): (JSC::JIT::emit_op_jtrue): (JSC::JIT::emit_op_next_pname):
9:46 PM Changeset in webkit [43608] by eric@webkit.org
  • 3 edits
    4 adds in trunk

2009-05-12 Roland Steiner <​rolandsteiner@google.com>

Reviewed by Eric Seidel.

Bug 25738: Skia: CSS border style not cleared for SVG object
​https://bugs.webkit.org/show_bug.cgi?id=25738

If no dashing is set, this change reverts to solid stroke
(previously the code bailed and left the old setting, whatever it was)

Test case listed in above bug entry.
(Additional complications due to each platform rendering dotted lines differently -
c.f. ​https://bugs.webkit.org/show_bug.cgi?id=25737)

  • platform/graphics/skia/GraphicsContextSkia.cpp: (WebCore::GraphicsContext::setLineDash):
9:36 PM Changeset in webkit [43607] by sfalken@apple.com
  • 2 edits in trunk/SunSpider

Build fix.

  • SunSpider.make:
8:53 PM Changeset in webkit [43606] by oliver@apple.com
  • 5 edits in trunk

<rdar://problem/6881457> Crash occurs at JSC::Interpreter::execute() when loading ​http://www.sears.com

Reviewed by Gavin Barraclough

We created the arguments objects before an op_push_scope but not
before op_push_new_scope, this meant a null arguments object could
be resolved inside catch blocks.

8:38 PM Changeset in webkit [43605] by eric@webkit.org
  • 9 edits
    3 adds in trunk

2009-05-11 Erik Arvidsson <​arv@chromium.org>

Reviewed by Eric Seidel.

Bug 21903: Adds DOM bindings for the placeholder property of the
HTMLInputElement.
​https://bugs.webkit.org/show_bug.cgi?id=21903

Test: fast/forms/placeholder-dom-property.html

  • dom/InputElement.cpp: (WebCore::InputElement::updatePlaceholderVisibility):
  • dom/InputElement.h:
  • html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::placeholder): (WebCore::HTMLInputElement::setPlaceholder):
  • html/HTMLInputElement.h:
  • html/HTMLInputElement.idl:
  • rendering/RenderTextControlSingleLine.cpp: (WebCore::RenderTextControlSingleLine::updateFromElement):
  • wml/WMLInputElement.h: (WebCore::WMLInputElement::placeholder): (WebCore::WMLInputElement::setPlaceholder):
8:13 PM Changeset in webkit [43604] by abarth@webkit.org
  • 3 edits
    6 adds in trunk

WebCore:

2009-05-12 Adam Barth <​abarth@webkit.org>

Reviewed by Dimitri Glazkov.

​https://bugs.webkit.org/show_bug.cgi?id=25706

Change V8 bindings to match JSC bindings with respect to using
the lexical or dynamic global object.

Tests: http/tests/security/aboutBlank/security-context-grandchildren-lexical.html

http/tests/security/aboutBlank/security-context-grandchildren-write-lexical.html
http/tests/security/aboutBlank/security-context-grandchildren-writeln-lexical.html

  • bindings/v8/custom/V8HTMLDocumentCustom.cpp: (WebCore::CALLBACK_FUNC_DECL):

LayoutTests:

2009-05-12 Adam Barth <​abarth@webkit.org>

Reviewed by Dimitri Glazkov.

Test that we use the lexical global object in document.open,
document.write, and document.writeln.

  • http/tests/security/aboutBlank/security-context-grandchildren-lexical-expected.txt: Added.
  • http/tests/security/aboutBlank/security-context-grandchildren-lexical.html: Added.
  • http/tests/security/aboutBlank/security-context-grandchildren-write-lexical-expected.txt: Added.
  • http/tests/security/aboutBlank/security-context-grandchildren-write-lexical.html: Added.
  • http/tests/security/aboutBlank/security-context-grandchildren-writeln-lexical-expected.txt: Added.
  • http/tests/security/aboutBlank/security-context-grandchildren-writeln-lexical.html: Added.

WebCore:

2009-05-12 Adam Barth <​abarth@webkit.org>

Reviewed by Dimitri Glazkov.

​https://bugs.webkit.org/show_bug.cgi?id=25706

Change V8 bindings to match JSC bindings with respect to using
the lexical or dynamic global object.

Tests: http/tests/security/aboutBlank/security-context-grandchildren-lexical.html

http/tests/security/aboutBlank/security-context-grandchildren-write-lexical.html
http/tests/security/aboutBlank/security-context-grandchildren-writeln-lexical.html

  • bindings/v8/custom/V8HTMLDocumentCustom.cpp: (WebCore::CALLBACK_FUNC_DECL):

LayoutTests:

2009-05-12 Adam Barth <​abarth@webkit.org>

Reviewed by Dimitri Glazkov.

Test that we use the lexical global object in document.open,
document.write, and document.writeln.

  • http/tests/security/aboutBlank/security-context-grandchildren-lexical-expected.txt: Added.
  • http/tests/security/aboutBlank/security-context-grandchildren-lexical.html: Added.
  • http/tests/security/aboutBlank/security-context-grandchildren-write-lexical-expected.txt: Added.
  • http/tests/security/aboutBlank/security-context-grandchildren-write-lexical.html: Added.
  • http/tests/security/aboutBlank/security-context-grandchildren-writeln-lexical-expected.txt: Added.
  • http/tests/security/aboutBlank/security-context-grandchildren-writeln-lexical.html: Added.

WebCore:

2009-05-12 Adam Barth <​abarth@webkit.org>

Reviewed by Dimitri Glazkov.

​https://bugs.webkit.org/show_bug.cgi?id=25706

Change V8 bindings to match JSC bindings with respect to using
the lexical or dynamic global object.

Tests: http/tests/security/aboutBlank/security-context-grandchildren-lexical.html

http/tests/security/aboutBlank/security-context-grandchildren-write-lexical.html
http/tests/security/aboutBlank/security-context-grandchildren-writeln-lexical.html

  • bindings/v8/custom/V8HTMLDocumentCustom.cpp: (WebCore::CALLBACK_FUNC_DECL):

LayoutTests:

2009-05-12 Adam Barth <​abarth@webkit.org>

Reviewed by Dimitri Glazkov.

Test that we use the lexical global object in document.open,
document.write, and document.writeln.

  • http/tests/security/aboutBlank/security-context-grandchildren-lexical-expected.txt: Added.
  • http/tests/security/aboutBlank/security-context-grandchildren-lexical.html: Added.
  • http/tests/security/aboutBlank/security-context-grandchildren-write-lexical-expected.txt: Added.
  • http/tests/security/aboutBlank/security-context-grandchildren-write-lexical.html: Added.
  • http/tests/security/aboutBlank/security-context-grandchildren-writeln-lexical-expected.txt: Added.
  • http/tests/security/aboutBlank/security-context-grandchildren-writeln-lexical.html: Added.

WebCore:

2009-05-12 Adam Barth <​abarth@webkit.org>

Reviewed by Dimitri Glazkov.

​https://bugs.webkit.org/show_bug.cgi?id=25706

Change V8 bindings to match JSC bindings with respect to using
the lexical or dynamic global object.

Tests: http/tests/security/aboutBlank/security-context-grandchildren-lexical.html

http/tests/security/aboutBlank/security-context-grandchildren-write-lexical.html
http/tests/security/aboutBlank/security-context-grandchildren-writeln-lexical.html

  • bindings/v8/custom/V8HTMLDocumentCustom.cpp: (WebCore::CALLBACK_FUNC_DECL):

LayoutTests:

2009-05-12 Adam Barth <​abarth@webkit.org>

Reviewed by Dimitri Glazkov.

Test that we use the lexical global object in document.open,
document.write, and document.writeln.

  • http/tests/security/aboutBlank/security-context-grandchildren-lexical-expected.txt: Added.
  • http/tests/security/aboutBlank/security-context-grandchildren-lexical.html: Added.
  • http/tests/security/aboutBlank/security-context-grandchildren-write-lexical-expected.txt: Added.
  • http/tests/security/aboutBlank/security-context-grandchildren-write-lexical.html: Added.
  • http/tests/security/aboutBlank/security-context-grandchildren-writeln-lexical-expected.txt: Added.
  • http/tests/security/aboutBlank/security-context-grandchildren-writeln-lexical.html: Added.

WebCore:

2009-05-12 Adam Barth <​abarth@webkit.org>

Reviewed by Dimitri Glazkov.

​https://bugs.webkit.org/show_bug.cgi?id=25706

Change V8 bindings to match JSC bindings with respect to using
the lexical or dynamic global object.

Tests: http/tests/security/aboutBlank/security-context-grandchildren-lexical.html

http/tests/security/aboutBlank/security-context-grandchildren-write-lexical.html
http/tests/security/aboutBlank/security-context-grandchildren-writeln-lexical.html

  • bindings/v8/custom/V8HTMLDocumentCustom.cpp: (WebCore::CALLBACK_FUNC_DECL):

LayoutTests:

2009-05-12 Adam Barth <​abarth@webkit.org>

Reviewed by Dimitri Glazkov.

Test that we use the lexical global object in document.open,
document.write, and document.writeln.

  • http/tests/security/aboutBlank/security-context-grandchildren-lexical-expected.txt: Added.
  • http/tests/security/aboutBlank/security-context-grandchildren-lexical.html: Added.
  • http/tests/security/aboutBlank/security-context-grandchildren-write-lexical-expected.txt: Added.
  • http/tests/security/aboutBlank/security-context-grandchildren-write-lexical.html: Added.
  • http/tests/security/aboutBlank/security-context-grandchildren-writeln-lexical-expected.txt: Added.
  • http/tests/security/aboutBlank/security-context-grandchildren-writeln-lexical.html: Added.

WebCore:

2009-05-12 Adam Barth <​abarth@webkit.org>

Reviewed by Dimitri Glazkov.

​https://bugs.webkit.org/show_bug.cgi?id=25706

Change V8 bindings to match JSC bindings with respect to using
the lexical or dynamic global object.

Tests: http/tests/security/aboutBlank/security-context-grandchildren-lexical.html

http/tests/security/aboutBlank/security-context-grandchildren-write-lexical.html
http/tests/security/aboutBlank/security-context-grandchildren-writeln-lexical.html

  • bindings/v8/custom/V8HTMLDocumentCustom.cpp: (WebCore::CALLBACK_FUNC_DECL):

LayoutTests:

2009-05-12 Adam Barth <​abarth@webkit.org>

Reviewed by Dimitri Glazkov.

Test that we use the lexical global object in document.open,
document.write, and document.writeln.

  • http/tests/security/aboutBlank/security-context-grandchildren-lexical-expected.txt: Added.
  • http/tests/security/aboutBlank/security-context-grandchildren-lexical.html: Added.
  • http/tests/security/aboutBlank/security-context-grandchildren-write-lexical-expected.txt: Added.
  • http/tests/security/aboutBlank/security-context-grandchildren-write-lexical.html: Added.
  • http/tests/security/aboutBlank/security-context-grandchildren-writeln-lexical-expected.txt: Added.
  • http/tests/security/aboutBlank/security-context-grandchildren-writeln-lexical.html: Added.

WebCore:

2009-05-12 Adam Barth <​abarth@webkit.org>

Reviewed by Dimitri Glazkov.

​https://bugs.webkit.org/show_bug.cgi?id=25706

Change V8 bindings to match JSC bindings with respect to using
the lexical or dynamic global object.

Tests: http/tests/security/aboutBlank/security-context-grandchildren-lexical.html

http/tests/security/aboutBlank/security-context-grandchildren-write-lexical.html
http/tests/security/aboutBlank/security-context-grandchildren-writeln-lexical.html

  • bindings/v8/custom/V8HTMLDocumentCustom.cpp: (WebCore::CALLBACK_FUNC_DECL):

LayoutTests:

2009-05-12 Adam Barth <​abarth@webkit.org>

Reviewed by Dimitri Glazkov.

Test that we use the lexical global object in document.open,
document.write, and document.writeln.

  • http/tests/security/aboutBlank/security-context-grandchildren-lexical-expected.txt: Added.
  • http/tests/security/aboutBlank/security-context-grandchildren-lexical.html: Added.
  • http/tests/security/aboutBlank/security-context-grandchildren-write-lexical-expected.txt: Added.
  • http/tests/security/aboutBlank/security-context-grandchildren-write-lexical.html: Added.
  • http/tests/security/aboutBlank/security-context-grandchildren-writeln-lexical-expected.txt: Added.
  • http/tests/security/aboutBlank/security-context-grandchildren-writeln-lexical.html: Added.

WebCore:

2009-05-12 Adam Barth <​abarth@webkit.org>

Reviewed by Dimitri Glazkov.

​https://bugs.webkit.org/show_bug.cgi?id=25706

Change V8 bindings to match JSC bindings with respect to using
the lexical or dynamic global object.

Tests: http/tests/security/aboutBlank/security-context-grandchildren-lexical.html

http/tests/security/aboutBlank/security-context-grandchildren-write-lexical.html
http/tests/security/aboutBlank/security-context-grandchildren-writeln-lexical.html

  • bindings/v8/custom/V8HTMLDocumentCustom.cpp: (WebCore::CALLBACK_FUNC_DECL):

LayoutTests:

2009-05-12 Adam Barth <​abarth@webkit.org>

Reviewed by Dimitri Glazkov.

Test that we use the lexical global object in document.open,
document.write, and document.writeln.

  • http/tests/security/aboutBlank/security-context-grandchildren-lexical-expected.txt: Added.
  • http/tests/security/aboutBlank/security-context-grandchildren-lexical.html: Added.
  • http/tests/security/aboutBlank/security-context-grandchildren-write-lexical-expected.txt: Added.
  • http/tests/security/aboutBlank/security-context-grandchildren-write-lexical.html: Added.
  • http/tests/security/aboutBlank/security-context-grandchildren-writeln-lexical-expected.txt: Added.
  • http/tests/security/aboutBlank/security-context-grandchildren-writeln-lexical.html: Added.

WebCore:

2009-05-12 Adam Barth <​abarth@webkit.org>

Reviewed by Dimitri Glazkov.

​https://bugs.webkit.org/show_bug.cgi?id=25706

Change V8 bindings to match JSC bindings with respect to using
the lexical or dynamic global object.

Tests: http/tests/security/aboutBlank/security-context-grandchildren-lexical.html

http/tests/security/aboutBlank/security-context-grandchildren-write-lexical.html
http/tests/security/aboutBlank/security-context-grandchildren-writeln-lexical.html

  • bindings/v8/custom/V8HTMLDocumentCustom.cpp: (WebCore::CALLBACK_FUNC_DECL):

LayoutTests:

2009-05-12 Adam Barth <​abarth@webkit.org>

Reviewed by Dimitri Glazkov.

Test that we use the lexical global object in document.open,
document.write, and document.writeln.

  • http/tests/security/aboutBlank/security-context-grandchildren-lexical-expected.txt: Added.
  • http/tests/security/aboutBlank/security-context-grandchildren-lexical.html: Added.
  • http/tests/security/aboutBlank/security-context-grandchildren-write-lexical-expected.txt: Added.
  • http/tests/security/aboutBlank/security-context-grandchildren-write-lexical.html: Added.
  • http/tests/security/aboutBlank/security-context-grandchildren-writeln-lexical-expected.txt: Added.
  • http/tests/security/aboutBlank/security-context-grandchildren-writeln-lexical.html: Added.

WebCore:

2009-05-12 Adam Barth <​abarth@webkit.org>

Reviewed by Dimitri Glazkov.

​https://bugs.webkit.org/show_bug.cgi?id=25706

Change V8 bindings to match JSC bindings with respect to using
the lexical or dynamic global object.

Tests: http/tests/security/aboutBlank/security-context-grandchildren-lexical.html

http/tests/security/aboutBlank/security-context-grandchildren-write-lexical.html
http/tests/security/aboutBlank/security-context-grandchildren-writeln-lexical.html

  • bindings/v8/custom/V8HTMLDocumentCustom.cpp: (WebCore::CALLBACK_FUNC_DECL):

LayoutTests:

2009-05-12 Adam Barth <​abarth@webkit.org>

Reviewed by Dimitri Glazkov.

Test that we use the lexical global object in document.open,
document.write, and document.writeln.

  • http/tests/security/aboutBlank/security-context-grandchildren-lexical-expected.txt: Added.
  • http/tests/security/aboutBlank/security-context-grandchildren-lexical.html: Added.
  • http/tests/security/aboutBlank/security-context-grandchildren-write-lexical-expected.txt: Added.
  • http/tests/security/aboutBlank/security-context-grandchildren-write-lexical.html: Added.
  • http/tests/security/aboutBlank/security-context-grandchildren-writeln-lexical-expected.txt: Added.
  • http/tests/security/aboutBlank/security-context-grandchildren-writeln-lexical.html: Added.

WebCore:

2009-05-12 Adam Barth <​abarth@webkit.org>

Reviewed by Dimitri Glazkov.

​https://bugs.webkit.org/show_bug.cgi?id=25706

Change V8 bindings to match JSC bindings with respect to using
the lexical or dynamic global object.

Tests: http/tests/security/aboutBlank/security-context-grandchildren-lexical.html

http/tests/security/aboutBlank/security-context-grandchildren-write-lexical.html
http/tests/security/aboutBlank/security-context-grandchildren-writeln-lexical.html

  • bindings/v8/custom/V8HTMLDocumentCustom.cpp: (WebCore::CALLBACK_FUNC_DECL):

LayoutTests:

2009-05-12 Adam Barth <​abarth@webkit.org>

Reviewed by Dimitri Glazkov.

Test that we use the lexical global object in document.open,
document.write, and document.writeln.

  • http/tests/security/aboutBlank/security-context-grandchildren-lexical-expected.txt: Added.
  • http/tests/security/aboutBlank/security-context-grandchildren-lexical.html: Added.
  • http/tests/security/aboutBlank/security-context-grandchildren-write-lexical-expected.txt: Added.
  • http/tests/security/aboutBlank/security-context-grandchildren-write-lexical.html: Added.
  • http/tests/security/aboutBlank/security-context-grandchildren-writeln-lexical-expected.txt: Added.
  • http/tests/security/aboutBlank/security-context-grandchildren-writeln-lexical.html: Added.

WebCore:

2009-05-12 Adam Barth <​abarth@webkit.org>

Reviewed by Dimitri Glazkov.

​https://bugs.webkit.org/show_bug.cgi?id=25706

Change V8 bindings to match JSC bindings with respect to using
the lexical or dynamic global object.

Tests: http/tests/security/aboutBlank/security-context-grandchildren-lexical.html

http/tests/security/aboutBlank/security-context-grandchildren-write-lexical.html
http/tests/security/aboutBlank/security-context-grandchildren-writeln-lexical.html

  • bindings/v8/custom/V8HTMLDocumentCustom.cpp: (WebCore::CALLBACK_FUNC_DECL):

LayoutTests:

2009-05-12 Adam Barth <​abarth@webkit.org>

Reviewed by Dimitri Glazkov.

Test that we use the lexical global object in document.open,
document.write, and document.writeln.

  • http/tests/security/aboutBlank/security-context-grandchildren-lexical-expected.txt: Added.
  • http/tests/security/aboutBlank/security-context-grandchildren-lexical.html: Added.
  • http/tests/security/aboutBlank/security-context-grandchildren-write-lexical-expected.txt: Added.
  • http/tests/security/aboutBlank/security-context-grandchildren-write-lexical.html: Added.
  • http/tests/security/aboutBlank/security-context-grandchildren-writeln-lexical-expected.txt: Added.
  • http/tests/security/aboutBlank/security-context-grandchildren-writeln-lexical.html: Added.

WebCore:

2009-05-12 Adam Barth <​abarth@webkit.org>

Reviewed by Dimitri Glazkov.

​https://bugs.webkit.org/show_bug.cgi?id=25706

Change V8 bindings to match JSC bindings with respect to using
the lexical or dynamic global object.

Tests: http/tests/security/aboutBlank/security-context-grandchildren-lexical.html

http/tests/security/aboutBlank/security-context-grandchildren-write-lexical.html
http/tests/security/aboutBlank/security-context-grandchildren-writeln-lexical.html

  • bindings/v8/custom/V8HTMLDocumentCustom.cpp: (WebCore::CALLBACK_FUNC_DECL):

LayoutTests:

2009-05-12 Adam Barth <​abarth@webkit.org>

Reviewed by Dimitri Glazkov.

Test that we use the lexical global object in document.open,
document.write, and document.writeln.

  • http/tests/security/aboutBlank/security-context-grandchildren-lexical-expected.txt: Added.
  • http/tests/security/aboutBlank/security-context-grandchildren-lexical.html: Added.
  • http/tests/security/aboutBlank/security-context-grandchildren-write-lexical-expected.txt: Added.
  • http/tests/security/aboutBlank/security-context-grandchildren-write-lexical.html: Added.
  • http/tests/security/aboutBlank/security-context-grandchildren-writeln-lexical-expected.txt: Added.
  • http/tests/security/aboutBlank/security-context-grandchildren-writeln-lexical.html: Added.

WebCore:

2009-05-12 Adam Barth <​abarth@webkit.org>

Reviewed by Dimitri Glazkov.

​https://bugs.webkit.org/show_bug.cgi?id=25706

Change V8 bindings to match JSC bindings with respect to using
the lexical or dynamic global object.

Tests: http/tests/security/aboutBlank/security-context-grandchildren-lexical.html

http/tests/security/aboutBlank/security-context-grandchildren-write-lexical.html
http/tests/security/aboutBlank/security-context-grandchildren-writeln-lexical.html

  • bindings/v8/custom/V8HTMLDocumentCustom.cpp: (WebCore::CALLBACK_FUNC_DECL):

LayoutTests:

2009-05-12 Adam Barth <​abarth@webkit.org>

Reviewed by Dimitri Glazkov.

Test that we use the lexical global object in document.open,
document.write, and document.writeln.

  • http/tests/security/aboutBlank/security-context-grandchildren-lexical-expected.txt: Added.
  • http/tests/security/aboutBlank/security-context-grandchildren-lexical.html: Added.
  • http/tests/security/aboutBlank/security-context-grandchildren-write-lexical-expected.txt: Added.
  • http/tests/security/aboutBlank/security-context-grandchildren-write-lexical.html: Added.
  • http/tests/security/aboutBlank/security-context-grandchildren-writeln-lexical-expected.txt: Added.
  • http/tests/security/aboutBlank/security-context-grandchildren-writeln-lexical.html: Added.

WebCore:

2009-05-12 Adam Barth <​abarth@webkit.org>

Reviewed by Dimitri Glazkov.

​https://bugs.webkit.org/show_bug.cgi?id=25706

Change V8 bindings to match JSC bindings with respect to using
the lexical or dynamic global object.

Tests: http/tests/security/aboutBlank/security-context-grandchildren-lexical.html

http/tests/security/aboutBlank/security-context-grandchildren-write-lexical.html
http/tests/security/aboutBlank/security-context-grandchildren-writeln-lexical.html

  • bindings/v8/custom/V8HTMLDocumentCustom.cpp: (WebCore::CALLBACK_FUNC_DECL):

LayoutTests:

2009-05-12 Adam Barth <​abarth@webkit.org>

Reviewed by Dimitri Glazkov.

Test that we use the lexical global object in document.open,
document.write, and document.writeln.

  • http/tests/security/aboutBlank/security-context-grandchildren-lexical-expected.txt: Added.
  • http/tests/security/aboutBlank/security-context-grandchildren-lexical.html: Added.
  • http/tests/security/aboutBlank/security-context-grandchildren-write-lexical-expected.txt: Added.
  • http/tests/security/aboutBlank/security-context-grandchildren-write-lexical.html: Added.
  • http/tests/security/aboutBlank/security-context-grandchildren-writeln-lexical-expected.txt: Added.
  • http/tests/security/aboutBlank/security-context-grandchildren-writeln-lexical.html: Added.

WebCore:

2009-05-12 Adam Barth <​abarth@webkit.org>

Reviewed by Dimitri Glazkov.

​https://bugs.webkit.org/show_bug.cgi?id=25706

Change V8 bindings to match JSC bindings with respect to using
the lexical or dynamic global object.

Tests: http/tests/security/aboutBlank/security-context-grandchildren-lexical.html

http/tests/security/aboutBlank/security-context-grandchildren-write-lexical.html
http/tests/security/aboutBlank/security-context-grandchildren-writeln-lexical.html

  • bindings/v8/custom/V8HTMLDocumentCustom.cpp: (WebCore::CALLBACK_FUNC_DECL):

LayoutTests:

2009-05-12 Adam Barth <​abarth@webkit.org>

Reviewed by Dimitri Glazkov.

Test that we use the lexical global object in document.open,
document.write, and document.writeln.

  • http/tests/security/aboutBlank/security-context-grandchildren-lexical-expected.txt: Added.
  • http/tests/security/aboutBlank/security-context-grandchildren-lexical.html: Added.
  • http/tests/security/aboutBlank/security-context-grandchildren-write-lexical-expected.txt: Added.
  • http/tests/security/aboutBlank/security-context-grandchildren-write-lexical.html: Added.
  • http/tests/security/aboutBlank/security-context-grandchildren-writeln-lexical-expected.txt: Added.
  • http/tests/security/aboutBlank/security-context-grandchildren-writeln-lexical.html: Added.

WebCore:

2009-05-12 Adam Barth <​abarth@webkit.org>

Reviewed by Dimitri Glazkov.

​https://bugs.webkit.org/show_bug.cgi?id=25706

Change V8 bindings to match JSC bindings with respect to using
the lexical or dynamic global object.

Tests: http/tests/security/aboutBlank/security-context-grandchildren-lexical.html

http/tests/security/aboutBlank/security-context-grandchildren-write-lexical.html
http/tests/security/aboutBlank/security-context-grandchildren-writeln-lexical.html

  • bindings/v8/custom/V8HTMLDocumentCustom.cpp: (WebCore::CALLBACK_FUNC_DECL):

LayoutTests:

2009-05-12 Adam Barth <​abarth@webkit.org>

Reviewed by Dimitri Glazkov.

Test that we use the lexical global object in document.open,
document.write, and document.writeln.

  • http/tests/security/aboutBlank/security-context-grandchildren-lexical-expected.txt: Added.
  • http/tests/security/aboutBlank/security-context-grandchildren-lexical.html: Added.
  • http/tests/security/aboutBlank/security-context-grandchildren-write-lexical-expected.txt: Added.
  • http/tests/security/aboutBlank/security-context-grandchildren-write-lexical.html: Added.
  • http/tests/security/aboutBlank/security-context-grandchildren-writeln-lexical-expected.txt: Added.
  • http/tests/security/aboutBlank/security-context-grandchildren-writeln-lexical.html: Added.

WebCore:

2009-05-12 Adam Barth <​abarth@webkit.org>

Reviewed by Dimitri Glazkov.

​https://bugs.webkit.org/show_bug.cgi?id=25706

Change V8 bindings to match JSC bindings with respect to using
the lexical or dynamic global object.

Tests: http/tests/security/aboutBlank/security-context-grandchildren-lexical.html

http/tests/security/aboutBlank/security-context-grandchildren-write-lexical.html
http/tests/security/aboutBlank/security-context-grandchildren-writeln-lexical.html

  • bindings/v8/custom/V8HTMLDocumentCustom.cpp: (WebCore::CALLBACK_FUNC_DECL):

LayoutTests:

2009-05-12 Adam Barth <​abarth@webkit.org>

Reviewed by Dimitri Glazkov.

Test that we use the lexical global object in document.open,
document.write, and document.writeln.

  • http/tests/security/aboutBlank/security-context-grandchildren-lexical-expected.txt: Added.
  • http/tests/security/aboutBlank/security-context-grandchildren-lexical.html: Added.
  • http/tests/security/aboutBlank/security-context-grandchildren-write-lexical-expected.txt: Added.
  • http/tests/security/aboutBlank/security-context-grandchildren-write-lexical.html: Added.
  • http/tests/security/aboutBlank/security-context-grandchildren-writeln-lexical-expected.txt: Added.
  • http/tests/security/aboutBlank/security-context-grandchildren-writeln-lexical.html: Added.

WebCore:

2009-05-12 Adam Barth <​abarth@webkit.org>

Reviewed by Dimitri Glazkov.

​https://bugs.webkit.org/show_bug.cgi?id=25706

Change V8 bindings to match JSC bindings with respect to using
the lexical or dynamic global object.

Tests: http/tests/security/aboutBlank/security-context-grandchildren-lexical.html

http/tests/security/aboutBlank/security-context-grandchildren-write-lexical.html
http/tests/security/aboutBlank/security-context-grandchildren-writeln-lexical.html

  • bindings/v8/custom/V8HTMLDocumentCustom.cpp: (WebCore::CALLBACK_FUNC_DECL):

LayoutTests:

2009-05-12 Adam Barth <​abarth@webkit.org>

Reviewed by Dimitri Glazkov.

Test that we use the lexical global object in document.open,
document.write, and document.writeln.

  • http/tests/security/aboutBlank/security-context-grandchildren-lexical-expected.txt: Added.
  • http/tests/security/aboutBlank/security-context-grandchildren-lexical.html: Added.
  • http/tests/security/aboutBlank/security-context-grandchildren-write-lexical-expected.txt: Added.
  • http/tests/security/aboutBlank/security-context-grandchildren-write-lexical.html: Added.
  • http/tests/security/aboutBlank/security-context-grandchildren-writeln-lexical-expected.txt: Added.
  • http/tests/security/aboutBlank/security-context-grandchildren-writeln-lexical.html: Added.

WebCore:

2009-05-12 Adam Barth <​abarth@webkit.org>

Reviewed by Dimitri Glazkov.

​https://bugs.webkit.org/show_bug.cgi?id=25706

Change V8 bindings to match JSC bindings with respect to using
the lexical or dynamic global object.

Tests: http/tests/security/aboutBlank/security-context-grandchildren-lexical.html

http/tests/security/aboutBlank/security-context-grandchildren-write-lexical.html
http/tests/security/aboutBlank/security-context-grandchildren-writeln-lexical.html

  • bindings/v8/custom/V8HTMLDocumentCustom.cpp: (WebCore::CALLBACK_FUNC_DECL):

LayoutTests:

2009-05-12 Adam Barth <​abarth@webkit.org>

Reviewed by Dimitri Glazkov.

Test that we use the lexical global object in document.open,
document.write, and document.writeln.

  • http/tests/security/aboutBlank/security-context-grandchildren-lexical-expected.txt: Added.
  • http/tests/security/aboutBlank/security-context-grandchildren-lexical.html: Added.
  • http/tests/security/aboutBlank/security-context-grandchildren-write-lexical-expected.txt: Added.
  • http/tests/security/aboutBlank/security-context-grandchildren-write-lexical.html: Added.
  • http/tests/security/aboutBlank/security-context-grandchildren-writeln-lexical-expected.txt: Added.
  • http/tests/security/aboutBlank/security-context-grandchildren-writeln-lexical.html: Added.

WebCore:

2009-05-12 Adam Barth <​abarth@webkit.org>

Reviewed by Dimitri Glazkov.

​https://bugs.webkit.org/show_bug.cgi?id=25706

Change V8 bindings to match JSC bindings with respect to using
the lexical or dynamic global object.

Tests: http/tests/security/aboutBlank/security-context-grandchildren-lexical.html

http/tests/security/aboutBlank/security-context-grandchildren-write-lexical.html
http/tests/security/aboutBlank/security-context-grandchildren-writeln-lexical.html

  • bindings/v8/custom/V8HTMLDocumentCustom.cpp: (WebCore::CALLBACK_FUNC_DECL):

LayoutTests:

2009-05-12 Adam Barth <​abarth@webkit.org>

Reviewed by Dimitri Glazkov.

Test that we use the lexical global object in document.open,
document.write, and document.writeln.

  • http/tests/security/aboutBlank/security-context-grandchildren-lexical-expected.txt: Added.
  • http/tests/security/aboutBlank/security-context-grandchildren-lexical.html: Added.
  • http/tests/security/aboutBlank/security-context-grandchildren-write-lexical-expected.txt: Added.
  • http/tests/security/aboutBlank/security-context-grandchildren-write-lexical.html: Added.
  • http/tests/security/aboutBlank/security-context-grandchildren-writeln-lexical-expected.txt: Added.
  • http/tests/security/aboutBlank/security-context-grandchildren-writeln-lexical.html: Added.

WebCore:

2009-05-12 Adam Barth <​abarth@webkit.org>

Reviewed by Dimitri Glazkov.

​https://bugs.webkit.org/show_bug.cgi?id=25706

Change V8 bindings to match JSC bindings with respect to using
the lexical or dynamic global object.

Tests: http/tests/security/aboutBlank/security-context-grandchildren-lexical.html

http/tests/security/aboutBlank/security-context-grandchildren-write-lexical.html
http/tests/security/aboutBlank/security-context-grandchildren-writeln-lexical.html

  • bindings/v8/custom/V8HTMLDocumentCustom.cpp: (WebCore::CALLBACK_FUNC_DECL):

LayoutTests:

2009-05-12 Adam Barth <​abarth@webkit.org>

Reviewed by Dimitri Glazkov.

Test that we use the lexical global object in document.open,
document.write, and document.writeln.

  • http/tests/security/aboutBlank/security-context-grandchildren-lexical-expected.txt: Added.
  • http/tests/security/aboutBlank/security-context-grandchildren-lexical.html: Added.
  • http/tests/security/aboutBlank/security-context-grandchildren-write-lexical-expected.txt: Added.
  • http/tests/security/aboutBlank/security-context-grandchildren-write-lexical.html: Added.
  • http/tests/security/aboutBlank/security-context-grandchildren-writeln-lexical-expected.txt: Added.
  • http/tests/security/aboutBlank/security-context-grandchildren-writeln-lexical.html: Added.

WebCore:

2009-05-12 Adam Barth <​abarth@webkit.org>

Reviewed by Dimitri Glazkov.

​https://bugs.webkit.org/show_bug.cgi?id=25706

Change V8 bindings to match JSC bindings with respect to using
the lexical or dynamic global object.

Tests: http/tests/security/aboutBlank/security-context-grandchildren-lexical.html

http/tests/security/aboutBlank/security-context-grandchildren-write-lexical.html
http/tests/security/aboutBlank/security-context-grandchildren-writeln-lexical.html

  • bindings/v8/custom/V8HTMLDocumentCustom.cpp: (WebCore::CALLBACK_FUNC_DECL):

LayoutTests:

2009-05-12 Adam Barth <​abarth@webkit.org>

Reviewed by Dimitri Glazkov.

Test that we use the lexical global object in document.open,
document.write, and document.writeln.

  • http/tests/security/aboutBlank/security-context-grandchildren-lexical-expected.txt: Added.
  • http/tests/security/aboutBlank/security-context-grandchildren-lexical.html: Added.
  • http/tests/security/aboutBlank/security-context-grandchildren-write-lexical-expected.txt: Added.
  • http/tests/security/aboutBlank/security-context-grandchildren-write-lexical.html: Added.
  • http/tests/security/aboutBlank/security-context-grandchildren-writeln-lexical-expected.txt: Added.
  • http/tests/security/aboutBlank/security-context-grandchildren-writeln-lexical.html: Added.

WebCore:

2009-05-12 Adam Barth <​abarth@webkit.org>

Reviewed by Dimitri Glazkov.

​https://bugs.webkit.org/show_bug.cgi?id=25706

Change V8 bindings to match JSC bindings with respect to using
the lexical or dynamic global object.

Tests: http/tests/security/aboutBlank/security-context-grandchildren-lexical.html

http/tests/security/aboutBlank/security-context-grandchildren-write-lexical.html
http/tests/security/aboutBlank/security-context-grandchildren-writeln-lexical.html

  • bindings/v8/custom/V8HTMLDocumentCustom.cpp: (WebCore::CALLBACK_FUNC_DECL):

LayoutTests:

2009-05-12 Adam Barth <​abarth@webkit.org>

Reviewed by Dimitri Glazkov.

Test that we use the lexical global object in document.open,
document.write, and document.writeln.

  • http/tests/security/aboutBlank/security-context-grandchildren-lexical-expected.txt: Added.
  • http/tests/security/aboutBlank/security-context-grandchildren-lexical.html: Added.
  • http/tests/security/aboutBlank/security-context-grandchildren-write-lexical-expected.txt: Added.
  • http/tests/security/aboutBlank/security-context-grandchildren-write-lexical.html: Added.
  • http/tests/security/aboutBlank/security-context-grandchildren-writeln-lexical-expected.txt: Added.
  • http/tests/security/aboutBlank/security-context-grandchildren-writeln-lexical.html: Added.

WebCore:

2009-05-12 Adam Barth <​abarth@webkit.org>

Reviewed by Dimitri Glazkov.

​https://bugs.webkit.org/show_bug.cgi?id=25706

Change V8 bindings to match JSC bindings with respect to using
the lexical or dynamic global object.

Tests: http/tests/security/aboutBlank/security-context-grandchildren-lexical.html

http/tests/security/aboutBlank/security-context-grandchildren-write-lexical.html
http/tests/security/aboutBlank/security-context-grandchildren-writeln-lexical.html

  • bindings/v8/custom/V8HTMLDocumentCustom.cpp: (WebCore::CALLBACK_FUNC_DECL):

LayoutTests:

2009-05-12 Adam Barth <​abarth@webkit.org>

Reviewed by Dimitri Glazkov.

Test that we use the lexical global object in document.open,
document.write, and document.writeln.

  • http/tests/security/aboutBlank/security-context-grandchildren-lexical-expected.txt: Added.
  • http/tests/security/aboutBlank/security-context-grandchildren-lexical.html: Added.
  • http/tests/security/aboutBlank/security-context-grandchildren-write-lexical-expected.txt: Added.
  • http/tests/security/aboutBlank/security-context-grandchildren-write-lexical.html: Added.
  • http/tests/security/aboutBlank/security-context-grandchildren-writeln-lexical-expected.txt: Added.
  • http/tests/security/aboutBlank/security-context-grandchildren-writeln-lexical.html: Added.

WebCore:

2009-05-12 Adam Barth <​abarth@webkit.org>

Reviewed by Dimitri Glazkov.

​https://bugs.webkit.org/show_bug.cgi?id=25706

Change V8 bindings to match JSC bindings with respect to using
the lexical or dynamic global object.

Tests: http/tests/security/aboutBlank/security-context-grandchildren-lexical.html

http/tests/security/aboutBlank/security-context-grandchildren-write-lexical.html
http/tests/security/aboutBlank/security-context-grandchildren-writeln-lexical.html

  • bindings/v8/custom/V8HTMLDocumentCustom.cpp: (WebCore::CALLBACK_FUNC_DECL):

LayoutTests:

2009-05-12 Adam Barth <​abarth@webkit.org>

Reviewed by Dimitri Glazkov.

Test that we use the lexical global object in document.open,
document.write, and document.writeln.

  • http/tests/security/aboutBlank/security-context-grandchildren-lexical-expected.txt: Added.
  • http/tests/security/aboutBlank/security-context-grandchildren-lexical.html: Added.
  • http/tests/security/aboutBlank/security-context-grandchildren-write-lexical-expected.txt: Added.
  • http/tests/security/aboutBlank/security-context-grandchildren-write-lexical.html: Added.
  • http/tests/security/aboutBlank/security-context-grandchildren-writeln-lexical-expected.txt: Added.
  • http/tests/security/aboutBlank/security-context-grandchildren-writeln-lexical.html: Added.

WebCore:

2009-05-12 Adam Barth <​abarth@webkit.org>

Reviewed by Dimitri Glazkov.

​https://bugs.webkit.org/show_bug.cgi?id=25706

Change V8 bindings to match JSC bindings with respect to using
the lexical or dynamic global object.

Tests: http/tests/security/aboutBlank/security-context-grandchildren-lexical.html

http/tests/security/aboutBlank/security-context-grandchildren-write-lexical.html
http/tests/security/aboutBlank/security-context-grandchildren-writeln-lexical.html

  • bindings/v8/custom/V8HTMLDocumentCustom.cpp: (WebCore::CALLBACK_FUNC_DECL):

LayoutTests:

2009-05-12 Adam Barth <​abarth@webkit.org>

Reviewed by Dimitri Glazkov.

Test that we use the lexical global object in document.open,
document.write, and document.writeln.

  • http/tests/security/aboutBlank/security-context-grandchildren-lexical-expected.txt: Added.
  • http/tests/security/aboutBlank/security-context-grandchildren-lexical.html: Added.
  • http/tests/security/aboutBlank/security-context-grandchildren-write-lexical-expected.txt: Added.
  • http/tests/security/aboutBlank/security-context-grandchildren-write-lexical.html: Added.
  • http/tests/security/aboutBlank/security-context-grandchildren-writeln-lexical-expected.txt: Added.
  • http/tests/security/aboutBlank/security-context-grandchildren-writeln-lexical.html: Added.

WebCore:

2009-05-12 Adam Barth <​abarth@webkit.org>

Reviewed by Dimitri Glazkov.

​https://bugs.webkit.org/show_bug.cgi?id=25706

Change V8 bindings to match JSC bindings with respect to using
the lexical or dynamic global object.

Tests: http/tests/security/aboutBlank/security-context-grandchildren-lexical.html

http/tests/security/aboutBlank/security-context-grandchildren-write-lexical.html
http/tests/security/aboutBlank/security-context-grandchildren-writeln-lexical.html

  • bindings/v8/custom/V8HTMLDocumentCustom.cpp: (WebCore::CALLBACK_FUNC_DECL):

LayoutTests:

2009-05-12 Adam Barth <​abarth@webkit.org>

Reviewed by Dimitri Glazkov.

Test that we use the lexical global object in document.open,
document.write, and document.writeln.

  • http/tests/security/aboutBlank/security-context-grandchildren-lexical-expected.txt: Added.
  • http/tests/security/aboutBlank/security-context-grandchildren-lexical.html: Added.
  • http/tests/security/aboutBlank/security-context-grandchildren-write-lexical-expected.txt: Added.
  • http/tests/security/aboutBlank/security-context-grandchildren-write-lexical.html: Added.
  • http/tests/security/aboutBlank/security-context-grandchildren-writeln-lexical-expected.txt: Added.
  • http/tests/security/aboutBlank/security-context-grandchildren-writeln-lexical.html: Added.

WebCore:

2009-05-12 Adam Barth <​abarth@webkit.org>

Reviewed by Dimitri Glazkov.

​https://bugs.webkit.org/show_bug.cgi?id=25706

Change V8 bindings to match JSC bindings with respect to using
the lexical or dynamic global object.

Tests: http/tests/security/aboutBlank/security-context-grandchildren-lexical.html

http/tests/security/aboutBlank/security-context-grandchildren-write-lexical.html
http/tests/security/aboutBlank/security-context-grandchildren-writeln-lexical.html

  • bindings/v8/custom/V8HTMLDocumentCustom.cpp: (WebCore::CALLBACK_FUNC_DECL):

LayoutTests:

2009-05-12 Adam Barth <​abarth@webkit.org>

Reviewed by Dimitri Glazkov.

Test that we use the lexical global object in document.open,
document.write, and document.writeln.

  • http/tests/security/aboutBlank/security-context-grandchildren-lexical-expected.txt: Added.
  • http/tests/security/aboutBlank/security-context-grandchildren-lexical.html: Added.
  • http/tests/security/aboutBlank/security-context-grandchildren-write-lexical-expected.txt: Added.
  • http/tests/security/aboutBlank/security-context-grandchildren-write-lexical.html: Added.
  • http/tests/security/aboutBlank/security-context-grandchildren-writeln-lexical-expected.txt: Added.
  • http/tests/security/aboutBlank/security-context-grandchildren-writeln-lexical.html: Added.

WebCore:

2009-05-12 Adam Barth <​abarth@webkit.org>

Reviewed by Dimitri Glazkov.

​https://bugs.webkit.org/show_bug.cgi?id=25706

Change V8 bindings to match JSC bindings with respect to using
the lexical or dynamic global object.

Tests: http/tests/security/aboutBlank/security-context-grandchildren-lexical.html

http/tests/security/aboutBlank/security-context-grandchildren-write-lexical.html
http/tests/security/aboutBlank/security-context-grandchildren-writeln-lexical.html

  • bindings/v8/custom/V8HTMLDocumentCustom.cpp: (WebCore::CALLBACK_FUNC_DECL):

LayoutTests:

2009-05-12 Adam Barth <​abarth@webkit.org>

Reviewed by Dimitri Glazkov.

Test that we use the lexical global object in document.open,
document.write, and document.writeln.

  • http/tests/security/aboutBlank/security-context-grandchildren-lexical-expected.txt: Added.
  • http/tests/security/aboutBlank/security-context-grandchildren-lexical.html: Added.
  • http/tests/security/aboutBlank/security-context-grandchildren-write-lexical-expected.txt: Added.
  • http/tests/security/aboutBlank/security-context-grandchildren-write-lexical.html: Added.
  • http/tests/security/aboutBlank/security-context-grandchildren-writeln-lexical-expected.txt: Added.
  • http/tests/security/aboutBlank/security-context-grandchildren-writeln-lexical.html: Added.

WebCore:

2009-05-12 Adam Barth <​abarth@webkit.org>

Reviewed by Dimitri Glazkov.

​https://bugs.webkit.org/show_bug.cgi?id=25706

Change V8 bindings to match JSC bindings with respect to using
the lexical or dynamic global object.

Tests: http/tests/security/aboutBlank/security-context-grandchildren-lexical.html

http/tests/security/aboutBlank/security-context-grandchildren-write-lexical.html
http/tests/security/aboutBlank/security-context-grandchildren-writeln-lexical.html

  • bindings/v8/custom/V8HTMLDocumentCustom.cpp: (WebCore::CALLBACK_FUNC_DECL):

LayoutTests:

2009-05-12 Adam Barth <​abarth@webkit.org>

Reviewed by Dimitri Glazkov.

Test that we use the lexical global object in document.open,
document.write, and document.writeln.

  • http/tests/security/aboutBlank/security-context-grandchildren-lexical-expected.txt: Added.
  • http/tests/security/aboutBlank/security-context-grandchildren-lexical.html: Added.
  • http/tests/security/aboutBlank/security-context-grandchildren-write-lexical-expected.txt: Added.
  • http/tests/security/aboutBlank/security-context-grandchildren-write-lexical.html: Added.
  • http/tests/security/aboutBlank/security-context-grandchildren-writeln-lexical-expected.txt: Added.
  • http/tests/security/aboutBlank/security-context-grandchildren-writeln-lexical.html: Added.

WebCore:

2009-05-12 Adam Barth <​abarth@webkit.org>

Reviewed by Dimitri Glazkov.

​https://bugs.webkit.org/show_bug.cgi?id=25706

Change V8 bindings to match JSC bindings with respect to using
the lexical or dynamic global object.

Tests: http/tests/security/aboutBlank/security-context-grandchildren-lexical.html

http/tests/security/aboutBlank/security-context-grandchildren-write-lexical.html
http/tests/security/aboutBlank/security-context-grandchildren-writeln-lexical.html

  • bindings/v8/custom/V8HTMLDocumentCustom.cpp: (WebCore::CALLBACK_FUNC_DECL):

LayoutTests:

2009-05-12 Adam Barth <​abarth@webkit.org>

Reviewed by Dimitri Glazkov.

Test that we use the lexical global object in document.open,
document.write, and document.writeln.

  • http/tests/security/aboutBlank/security-context-grandchildren-lexical-expected.txt: Added.
  • http/tests/security/aboutBlank/security-context-grandchildren-lexical.html: Added.
  • http/tests/security/aboutBlank/security-context-grandchildren-write-lexical-expected.txt: Added.
  • http/tests/security/aboutBlank/security-context-grandchildren-write-lexical.html: Added.
  • http/tests/security/aboutBlank/security-context-grandchildren-writeln-lexical-expected.txt: Added.
  • http/tests/security/aboutBlank/security-context-grandchildren-writeln-lexical.html: Added.

WebCore:

2009-05-12 Adam Barth <​abarth@webkit.org>

Reviewed by Dimitri Glazkov.

​https://bugs.webkit.org/show_bug.cgi?id=25706

Change V8 bindings to match JSC bindings with respect to using
the lexical or dynamic global object.

Tests: http/tests/security/aboutBlank/security-context-grandchildren-lexical.html

http/tests/security/aboutBlank/security-context-grandchildren-write-lexical.html
http/tests/security/aboutBlank/security-context-grandchildren-writeln-lexical.html

  • bindings/v8/custom/V8HTMLDocumentCustom.cpp: (WebCore::CALLBACK_FUNC_DECL):

LayoutTests:

2009-05-12 Adam Barth <​abarth@webkit.org>

Reviewed by Dimitri Glazkov.

Test that we use the lexical global object in document.open,
document.write, and document.writeln.

  • http/tests/security/aboutBlank/security-context-grandchildren-lexical-expected.txt: Added.
  • http/tests/security/aboutBlank/security-context-grandchildren-lexical.html: Added.
  • http/tests/security/aboutBlank/security-context-grandchildren-write-lexical-expected.txt: Added.
  • http/tests/security/aboutBlank/security-context-grandchildren-write-lexical.html: Added.
  • http/tests/security/aboutBlank/security-context-grandchildren-writeln-lexical-expected.txt: Added.
  • http/tests/security/aboutBlank/security-context-grandchildren-writeln-lexical.html: Added.

WebCore:

2009-05-12 Adam Barth <​abarth@webkit.org>

Reviewed by Dimitri Glazkov.

​https://bugs.webkit.org/show_bug.cgi?id=25706

Change V8 bindings to match JSC bindings with respect to using
the lexical or dynamic global object.

Tests: http/tests/security/aboutBlank/security-context-grandchildren-lexical.html

http/tests/security/aboutBlank/security-context-grandchildren-write-lexical.html
http/tests/security/aboutBlank/security-context-grandchildren-writeln-lexical.html

  • bindings/v8/custom/V8HTMLDocumentCustom.cpp: (WebCore::CALLBACK_FUNC_DECL):

LayoutTests:

2009-05-12 Adam Barth <​abarth@webkit.org>

Reviewed by Dimitri Glazkov.

Test that we use the lexical global object in document.open,
document.write, and document.writeln.

  • http/tests/security/aboutBlank/security-context-grandchildren-lexical-expected.txt: Added.
  • http/tests/security/aboutBlank/security-context-grandchildren-lexical.html: Added.
  • http/tests/security/aboutBlank/security-context-grandchildren-write-lexical-expected.txt: Added.
  • http/tests/security/aboutBlank/security-context-grandchildren-write-lexical.html: Added.
  • http/tests/security/aboutBlank/security-context-grandchildren-writeln-lexical-expected.txt: Added.
  • http/tests/security/aboutBlank/security-context-grandchildren-writeln-lexical.html: Added.

WebCore:

2009-05-12 Adam Barth <​abarth@webkit.org>

Reviewed by Dimitri Glazkov.

​https://bugs.webkit.org/show_bug.cgi?id=25706

Change V8 bindings to match JSC bindings with respect to using
the lexical or dynamic global object.

Tests: http/tests/security/aboutBlank/security-context-grandchildren-lexical.html

http/tests/security/aboutBlank/security-context-grandchildren-write-lexical.html
http/tests/security/aboutBlank/security-context-grandchildren-writeln-lexical.html

  • bindings/v8/custom/V8HTMLDocumentCustom.cpp: (WebCore::CALLBACK_FUNC_DECL):

LayoutTests:

2009-05-12 Adam Barth <​abarth@webkit.org>

Reviewed by Dimitri Glazkov.

Test that we use the lexical global object in document.open,
document.write, and document.writeln.

  • http/tests/security/aboutBlank/security-context-grandchildren-lexical-expected.txt: Added.
  • http/tests/security/aboutBlank/security-context-grandchildren-lexical.html: Added.
  • http/tests/security/aboutBlank/security-context-grandchildren-write-lexical-expected.txt: Added.
  • http/tests/security/aboutBlank/security-context-grandchildren-write-lexical.html: Added.
  • http/tests/security/aboutBlank/security-context-grandchildren-writeln-lexical-expected.txt: Added.
  • http/tests/security/aboutBlank/security-context-grandchildren-writeln-lexical.html: Added.

WebCore:

2009-05-12 Adam Barth <​abarth@webkit.org>

Reviewed by Dimitri Glazkov.

​https://bugs.webkit.org/show_bug.cgi?id=25706

Change V8 bindings to match JSC bindings with respect to using
the lexical or dynamic global object.

Tests: http/tests/security/aboutBlank/security-context-grandchildren-lexical.html

http/tests/security/aboutBlank/security-context-grandchildren-write-lexical.html
http/tests/security/aboutBlank/security-context-grandchildren-writeln-lexical.html

  • bindings/v8/custom/V8HTMLDocumentCustom.cpp: (WebCore::CALLBACK_FUNC_DECL):

LayoutTests:

2009-05-12 Adam Barth <​abarth@webkit.org>

Reviewed by Dimitri Glazkov.

Test that we use the lexical global object in document.open,
document.write, and document.writeln.

  • http/tests/security/aboutBlank/security-context-grandchildren-lexical-expected.txt: Added.
  • http/tests/security/aboutBlank/security-context-grandchildren-lexical.html: Added.
  • http/tests/security/aboutBlank/security-context-grandchildren-write-lexical-expected.txt: Added.
  • http/tests/security/aboutBlank/security-context-grandchildren-write-lexical.html: Added.
  • http/tests/security/aboutBlank/security-context-grandchildren-writeln-lexical-expected.txt: Added.
  • http/tests/security/aboutBlank/security-context-grandchildren-writeln-lexical.html: Added.

WebCore:

2009-05-12 Adam Barth <​abarth@webkit.org>

Reviewed by Dimitri Glazkov.

​https://bugs.webkit.org/show_bug.cgi?id=25706

Change V8 bindings to match JSC bindings with respect to using
the lexical or dynamic global object.

Tests: http/tests/security/aboutBlank/security-context-grandchildren-lexical.html

http/tests/security/aboutBlank/security-context-grandchildren-write-lexical.html
http/tests/security/aboutBlank/security-context-grandchildren-writeln-lexical.html

  • bindings/v8/custom/V8HTMLDocumentCustom.cpp: (WebCore::CALLBACK_FUNC_DECL):

LayoutTests:

2009-05-12 Adam Barth <​abarth@webkit.org>

Reviewed by Dimitri Glazkov.

Test that we use the lexical global object in document.open,
document.write, and document.writeln.

  • http/tests/security/aboutBlank/security-context-grandchildren-lexical-expected.txt: Added.
  • http/tests/security/aboutBlank/security-context-grandchildren-lexical.html: Added.
  • http/tests/security/aboutBlank/security-context-grandchildren-write-lexical-expected.txt: Added.
  • http/tests/security/aboutBlank/security-context-grandchildren-write-lexical.html: Added.
  • http/tests/security/aboutBlank/security-context-grandchildren-writeln-lexical-expected.txt: Added.
  • http/tests/security/aboutBlank/security-context-grandchildren-writeln-lexical.html: Added.

WebCore:

2009-05-12 Adam Barth <​abarth@webkit.org>

Reviewed by Dimitri Glazkov.

​https://bugs.webkit.org/show_bug.cgi?id=25706

Change V8 bindings to match JSC bindings with respect to using
the lexical or dynamic global object.

Tests: http/tests/security/aboutBlank/security-context-grandchildren-lexical.html

http/tests/security/aboutBlank/security-context-grandchildren-write-lexical.html
http/tests/security/aboutBlank/security-context-grandchildren-writeln-lexical.html

  • bindings/v8/custom/V8HTMLDocumentCustom.cpp: (WebCore::CALLBACK_FUNC_DECL):

LayoutTests:

2009-05-12 Adam Barth <​abarth@webkit.org>

Reviewed by Dimitri Glazkov.

Test that we use the lexical global object in document.open,
document.write, and document.writeln.

  • http/tests/security/aboutBlank/security-context-grandchildren-lexical-expected.txt: Added.
  • http/tests/security/aboutBlank/security-context-grandchildren-lexical.html: Added.
  • http/tests/security/aboutBlank/security-context-grandchildren-write-lexical-expected.txt: Added.
  • http/tests/security/aboutBlank/security-context-grandchildren-write-lexical.html: Added.
  • http/tests/security/aboutBlank/security-context-grandchildren-writeln-lexical-expected.txt: Added.
  • http/tests/security/aboutBlank/security-context-grandchildren-writeln-lexical.html: Added.

WebCore:

2009-05-12 Adam Barth <​abarth@webkit.org>

Reviewed by Dimitri Glazkov.

​https://bugs.webkit.org/show_bug.cgi?id=25706

Change V8 bindings to match JSC bindings with respect to using
the lexical or dynamic global object.

Tests: http/tests/security/aboutBlank/security-context-grandchildren-lexical.html

http/tests/security/aboutBlank/security-context-grandchildren-write-lexical.html
http/tests/security/aboutBlank/security-context-grandchildren-writeln-lexical.html

  • bindings/v8/custom/V8HTMLDocumentCustom.cpp: (WebCore::CALLBACK_FUNC_DECL):

LayoutTests:

2009-05-12 Adam Barth <​abarth@webkit.org>

Reviewed by Dimitri Glazkov.

Test that we use the lexical global object in document.open,
document.write, and document.writeln.

  • http/tests/security/aboutBlank/security-context-grandchildren-lexical-expected.txt: Added.
  • http/tests/security/aboutBlank/security-context-grandchildren-lexical.html: Added.
  • http/tests/security/aboutBlank/security-context-grandchildren-write-lexical-expected.txt: Added.
  • http/tests/security/aboutBlank/security-context-grandchildren-write-lexical.html: Added.
  • http/tests/security/aboutBlank/security-context-grandchildren-writeln-lexical-expected.txt: Added.
  • http/tests/security/aboutBlank/security-context-grandchildren-writeln-lexical.html: Added.

WebCore:

2009-05-12 Adam Barth <​abarth@webkit.org>

Reviewed by Dimitri Glazkov.

​https://bugs.webkit.org/show_bug.cgi?id=25706

Change V8 bindings to match JSC bindings with respect to using
the lexical or dynamic global object.

Tests: http/tests/security/aboutBlank/security-context-grandchildren-lexical.html

http/tests/security/aboutBlank/security-context-grandchildren-write-lexical.html
http/tests/security/aboutBlank/security-context-grandchildren-writeln-lexical.html

  • bindings/v8/custom/V8HTMLDocumentCustom.cpp: (WebCore::CALLBACK_FUNC_DECL):

LayoutTests:

2009-05-12 Adam Barth <​abarth@webkit.org>

Reviewed by Dimitri Glazkov.

Test that we use the lexical global object in document.open,
document.write, and document.writeln.

  • http/tests/security/aboutBlank/security-context-grandchildren-lexical-expected.txt: Added.
  • http/tests/security/aboutBlank/security-context-grandchildren-lexical.html: Added.
  • http/tests/security/aboutBlank/security-context-grandchildren-write-lexical-expected.txt: Added.
  • http/tests/security/aboutBlank/security-context-grandchildren-write-lexical.html: Added.
  • http/tests/security/aboutBlank/security-context-grandchildren-writeln-lexical-expected.txt: Added.
  • http/tests/security/aboutBlank/security-context-grandchildren-writeln-lexical.html: Added.

WebCore:

2009-05-12 Adam Barth <​abarth@webkit.org>

Reviewed by Dimitri Glazkov.

​https://bugs.webkit.org/show_bug.cgi?id=25706

Change V8 bindings to match JSC bindings with respect to using
the lexical or dynamic global object.

Tests: http/tests/security/aboutBlank/security-context-grandchildren-lexical.html

http/tests/security/aboutBlank/security-context-grandchildren-write-lexical.html
http/tests/security/aboutBlank/security-context-grandchildren-writeln-lexical.html

  • bindings/v8/custom/V8HTMLDocumentCustom.cpp: (WebCore::CALLBACK_FUNC_DECL):

LayoutTests:

2009-05-12 Adam Barth <​abarth@webkit.org>

Reviewed by Dimitri Glazkov.

Test that we use the lexical global object in document.open,
document.write, and document.writeln.

  • http/tests/security/aboutBlank/security-context-grandchildren-lexical-expected.txt: Added.
  • http/tests/security/aboutBlank/security-context-grandchildren-lexical.html: Added.
  • http/tests/security/aboutBlank/security-context-grandchildren-write-lexical-expected.txt: Added.
  • http/tests/security/aboutBlank/security-context-grandchildren-write-lexical.html: Added.
  • http/tests/security/aboutBlank/security-context-grandchildren-writeln-lexical-expected.txt: Added.
  • http/tests/security/aboutBlank/security-context-grandchildren-writeln-lexical.html: Added.

WebCore:

2009-05-12 Adam Barth <​abarth@webkit.org>

Reviewed by Dimitri Glazkov.

​https://bugs.webkit.org/show_bug.cgi?id=25706

Change V8 bindings to match JSC bindings with respect to using
the lexical or dynamic global object.

Tests: http/tests/security/aboutBlank/security-context-grandchildren-lexical.html

http/tests/security/aboutBlank/security-context-grandchildren-write-lexical.html
http/tests/security/aboutBlank/security-context-grandchildren-writeln-lexical.html

  • bindings/v8/custom/V8HTMLDocumentCustom.cpp: (WebCore::CALLBACK_FUNC_DECL):

LayoutTests:

2009-05-12 Adam Barth <​abarth@webkit.org>

Reviewed by Dimitri Glazkov.

Test that we use the lexical global object in document.open,
document.write, and document.writeln.

  • http/tests/security/aboutBlank/security-context-grandchildren-lexical-expected.txt: Added.
  • http/tests/security/aboutBlank/security-context-grandchildren-lexical.html: Added.
  • http/tests/security/aboutBlank/security-context-grandchildren-write-lexical-expected.txt: Added.
  • http/tests/security/aboutBlank/security-context-grandchildren-write-lexical.html: Added.
  • http/tests/security/aboutBlank/security-context-grandchildren-writeln-lexical-expected.txt: Added.
  • http/tests/security/aboutBlank/security-context-grandchildren-writeln-lexical.html: Added.

WebCore:

2009-05-12 Adam Barth <​abarth@webkit.org>

Reviewed by Dimitri Glazkov.

​https://bugs.webkit.org/show_bug.cgi?id=25706

Change V8 bindings to match JSC bindings with respect to using
the lexical or dynamic global object.

Tests: http/tests/security/aboutBlank/security-context-grandchildren-lexical.html

http/tests/security/aboutBlank/security-context-grandchildren-write-lexical.html
http/tests/security/aboutBlank/security-context-grandchildren-writeln-lexical.html

  • bindings/v8/custom/V8HTMLDocumentCustom.cpp: (WebCore::CALLBACK_FUNC_DECL):

LayoutTests:

2009-05-12 Adam Barth <​abarth@webkit.org>

Reviewed by Dimitri Glazkov.

Test that we use the lexical global object in document.open,
document.write, and document.writeln.

  • http/tests/security/aboutBlank/security-context-grandchildren-lexical-expected.txt: Added.
  • http/tests/security/aboutBlank/security-context-grandchildren-lexical.html: Added.
  • http/tests/security/aboutBlank/security-context-grandchildren-write-lexical-expected.txt: Added.
  • http/tests/security/aboutBlank/security-context-grandchildren-write-lexical.html: Added.
  • http/tests/security/aboutBlank/security-context-grandchildren-writeln-lexical-expected.txt: Added.
  • http/tests/security/aboutBlank/security-context-grandchildren-writeln-lexical.html: Added.

WebCore:

2009-05-12 Adam Barth <​abarth@webkit.org>

Reviewed by Dimitri Glazkov.

​https://bugs.webkit.org/show_bug.cgi?id=25706

Change V8 bindings to match JSC bindings with respect to using
the lexical or dynamic global object.

Tests: http/tests/security/aboutBlank/security-context-grandchildren-lexical.html

http/tests/security/aboutBlank/security-context-grandchildren-write-lexical.html
http/tests/security/aboutBlank/security-context-grandchildren-writeln-lexical.html

  • bindings/v8/custom/V8HTMLDocumentCustom.cpp: (WebCore::CALLBACK_FUNC_DECL):

LayoutTests:

2009-05-12 Adam Barth <​abarth@webkit.org>

Reviewed by Dimitri Glazkov.

Test that we use the lexical global object in document.open,
document.write, and document.writeln.

  • http/tests/security/aboutBlank/security-context-grandchildren-lexical-expected.txt: Added.
  • http/tests/security/aboutBlank/security-context-grandchildren-lexical.html: Added.
  • http/tests/security/aboutBlank/security-context-grandchildren-write-lexical-expected.txt: Added.
  • http/tests/security/aboutBlank/security-context-grandchildren-write-lexical.html: Added.
  • http/tests/security/aboutBlank/security-context-grandchildren-writeln-lexical-expected.txt: Added.
  • http/tests/security/aboutBlank/security-context-grandchildren-writeln-lexical.html: Added.

WebCore:

2009-05-12 Adam Barth <​abarth@webkit.org>

Reviewed by Dimitri Glazkov.

​https://bugs.webkit.org/show_bug.cgi?id=25706

Change V8 bindings to match JSC bindings with respect to using
the lexical or dynamic global object.

Tests: http/tests/security/aboutBlank/security-context-grandchildren-lexical.html

http/tests/security/aboutBlank/security-context-grandchildren-write-lexical.html
http/tests/security/aboutBlank/security-context-grandchildren-writeln-lexical.html

  • bindings/v8/custom/V8HTMLDocumentCustom.cpp: (WebCore::CALLBACK_FUNC_DECL):

LayoutTests:

2009-05-12 Adam Barth <​abarth@webkit.org>

Reviewed by Dimitri Glazkov.

Test that we use the lexical global object in document.open,
document.write, and document.writeln.

  • http/tests/security/aboutBlank/security-context-grandchildren-lexical-expected.txt: Added.
  • http/tests/security/aboutBlank/security-context-grandchildren-lexical.html: Added.
  • http/tests/security/aboutBlank/security-context-grandchildren-write-lexical-expected.txt: Added.
  • http/tests/security/aboutBlank/security-context-grandchildren-write-lexical.html: Added.
  • http/tests/security/aboutBlank/security-context-grandchildren-writeln-lexical-expected.txt: Added.
  • http/tests/security/aboutBlank/security-context-grandchildren-writeln-lexical.html: Added.

WebCore:

2009-05-12 Adam Barth <​abarth@webkit.org>

Reviewed by Dimitri Glazkov.

​https://bugs.webkit.org/show_bug.cgi?id=25706

Change V8 bindings to match JSC bindings with respect to using
the lexical or dynamic global object.

Tests: http/tests/security/aboutBlank/security-context-grandchildren-lexical.html

http/tests/security/aboutBlank/security-context-grandchildren-write-lexical.html
http/tests/security/aboutBlank/security-context-grandchildren-writeln-lexical.html

  • bindings/v8/custom/V8HTMLDocumentCustom.cpp: (WebCore::CALLBACK_FUNC_DECL):

LayoutTests:

2009-05-12 Adam Barth <​abarth@webkit.org>

Reviewed by Dimitri Glazkov.

Test that we use the lexical global object in document.open,
document.write, and document.writeln.

  • http/tests/security/aboutBlank/security-context-grandchildren-lexical-expected.txt: Added.
  • http/tests/security/aboutBlank/security-context-grandchildren-lexical.html: Added.
  • http/tests/security/aboutBlank/security-context-grandchildren-write-lexical-expected.txt: Added.
  • http/tests/security/aboutBlank/security-context-grandchildren-write-lexical.html: Added.
  • http/tests/security/aboutBlank/security-context-grandchildren-writeln-lexical-expected.txt: Added.
  • http/tests/security/aboutBlank/security-context-grandchildren-writeln-lexical.html: Added.

WebCore:

2009-05-12 Adam Barth <​abarth@webkit.org>

Reviewed by Dimitri Glazkov.

​https://bugs.webkit.org/show_bug.cgi?id=25706

Change V8 bindings to match JSC bindings with respect to using
the lexical or dynamic global object.

Tests: http/tests/security/aboutBlank/security-context-grandchildren-lexical.html

http/tests/security/aboutBlank/security-context-grandchildren-write-lexical.html
http/tests/security/aboutBlank/security-context-grandchildren-writeln-lexical.html

  • bindings/v8/custom/V8HTMLDocumentCustom.cpp: (WebCore::CALLBACK_FUNC_DECL):

LayoutTests:

2009-05-12 Adam Barth <​abarth@webkit.org>

Reviewed by Dimitri Glazkov.

Test that we use the lexical global object in document.open,
document.write, and document.writeln.

  • http/tests/security/aboutBlank/security-context-grandchildren-lexical-expected.txt: Added.
  • http/tests/security/aboutBlank/security-context-grandchildren-lexical.html: Added.
  • http/tests/security/aboutBlank/security-context-grandchildren-write-lexical-expected.txt: Added.
  • http/tests/security/aboutBlank/security-context-grandchildren-write-lexical.html: Added.
  • http/tests/security/aboutBlank/security-context-grandchildren-writeln-lexical-expected.txt: Added.
  • http/tests/security/aboutBlank/security-context-grandchildren-writeln-lexical.html: Added.

WebCore:

2009-05-12 Adam Barth <​abarth@webkit.org>

Reviewed by Dimitri Glazkov.

​https://bugs.webkit.org/show_bug.cgi?id=25706

Change V8 bindings to match JSC bindings with respect to using
the lexical or dynamic global object.

Tests: http/tests/security/aboutBlank/security-context-grandchildren-lexical.html

http/tests/security/aboutBlank/security-context-grandchildren-write-lexical.html
http/tests/security/aboutBlank/security-context-grandchildren-writeln-lexical.html

  • bindings/v8/custom/V8HTMLDocumentCustom.cpp: (WebCore::CALLBACK_FUNC_DECL):

LayoutTests:

2009-05-12 Adam Barth <​abarth@webkit.org>

Reviewed by Dimitri Glazkov.

Test that we use the lexical global object in document.open,
document.write, and document.writeln.

  • http/tests/security/aboutBlank/security-context-grandchildren-lexical-expected.txt: Added.
  • http/tests/security/aboutBlank/security-context-grandchildren-lexical.html: Added.
  • http/tests/security/aboutBlank/security-context-grandchildren-write-lexical-expected.txt: Added.
  • http/tests/security/aboutBlank/security-context-grandchildren-write-lexical.html: Added.
  • http/tests/security/aboutBlank/security-context-grandchildren-writeln-lexical-expected.txt: Added.
  • http/tests/security/aboutBlank/security-context-grandchildren-writeln-lexical.html: Added.
7:39 PM Changeset in webkit [43603] by oliver@apple.com
  • 4 edits in trunk/JavaScriptCore

<rdar://problem/6879881> Crash occurs at JSC::JSActivation::mark() when loading ​http://www.monster.com; ​http://www.cnet.com
<​https://bugs.webkit.org/show_bug.cgi?id=25736> Crash loading www.google.dk/ig (and other igoogle's as well)

Reviewed by Gavin Barraclough.

Following on from the lazy arguments creation patch, it's now
possible for an activation to to have a null register in the callframe
so we can't just blindly mark the local registers in an activation,
and must null check first instead.

6:38 PM Changeset in webkit [43602] by weinig@apple.com
  • 4 edits in branches/nitro-extreme/JavaScriptCore

2009-05-12 Sam Weinig <​sam@webkit.org>

Reviewed by Geoffrey Garen.

Add op_get_global_var, op_put_global_var, emit_op_get_scoped_var, emit_op_put_scoped_var and
op_unexpected_load.

  • jit/JIT.h:
  • jit/JITInlineMethods.h: (JSC::JIT::tagFor): (JSC::JIT::payloadFor): (JSC::JIT::emitLoad): (JSC::JIT::emitStore): (JSC::JIT::emitLoadReturnValue):
  • jit/JITOpcodes.cpp: (JSC::JIT::emit_op_get_global_var): (JSC::JIT::emit_op_put_global_var): (JSC::JIT::emit_op_get_scoped_var): (JSC::JIT::emit_op_put_scoped_var): (JSC::JIT::emit_op_unexpected_load):
5:31 PM Changeset in webkit [43601] by ddkilzer@apple.com
  • 2 edits in trunk/WebKitTools

Bug 21418: resolve-ChangeLogs should have a --continue option which does git rebase --continue

<​https://bugs.webkit.org/show_bug.cgi?id=21418>

Reviewed by Darin Adler.

Scripts/resolve-ChangeLogs: Added -ccontinue switch that

runs "git rebase --continue" before exiting the script.
(hasGitUnmergedFiles): Added. Returns true if there are
unmerged files in the git repository.

5:31 PM Changeset in webkit [43600] by barraclough@apple.com
  • 3 edits in trunk/JavaScriptCore

2009-05-12 Gavin Barraclough <​barraclough@apple.com>

Rubber stamped by Geoff Garen.

WTF_USE_CTI_REPATCH_PIC is no longer used, remove.

  • jit/JIT.h:
  • jit/JITStubCall.h:
5:27 PM Changeset in webkit [43599] by barraclough@apple.com
  • 2 edits in trunk/JavaScriptCore

2009-05-12 Gavin Barraclough <​barraclough@apple.com>

Reviewed by Maciej Stachowiak.

We've run into some problems where changing the size of the class JIT leads to
performance fluctuations. Try forcing alignment in an attempt to stabalize this.

  • jit/JIT.h:
5:20 PM Changeset in webkit [43598] by ggaren@apple.com
  • 3 edits in branches/nitro-extreme/JavaScriptCore

2009-05-12 Geoffrey Garen <​ggaren@apple.com>

Reviewed by Sam Weinig.

Added overflow handling to op_sub.

  • jit/JIT.h:
  • jit/JITArithmetic.cpp: (JSC::JIT::emitSlow_op_sub): (JSC::JIT::emitSlowSub32InPlaceLeft):
5:06 PM Changeset in webkit [43597] by Simon Fraser
  • 2 edits in trunk/LayoutTests

2009-05-12 Simon Fraser <Simon Fraser>

No review.

media/video-size-intrinsic-scale.html fails on Tiger, so add it to the skipped
list.

  • platform/mac-tiger/Skipped:
4:52 PM Changeset in webkit [43596] by weinig@apple.com
  • 3 edits in branches/nitro-extreme/JavaScriptCore

2009-05-12 Sam Weinig <​sam@webkit.org>

Reviewed by Geoffrey Garen.

Remove a function call by folding op_get_by_id and op_put_by_id into
their respective compile functions.

  • jit/JIT.h:
  • jit/JITPropertyAccess.cpp: (JSC::JIT::emit_op_get_by_id): (JSC::JIT::emitSlow_op_get_by_id): (JSC::JIT::emit_op_put_by_id): (JSC::JIT::emitSlow_op_put_by_id):
4:30 PM Changeset in webkit [43595] by weinig@apple.com
  • 2 edits in branches/nitro-extreme/JavaScriptCore

2009-05-12 Sam Weinig <​sam@webkit.org>

Reviewed by Geoffrey Garen.

Make JITStubCall work in 64bit by making the stack index
step dependent on the size of void*.

  • jit/JITStubCall.h: (JSC::JITStubCall::JITStubCall): (JSC::JITStubCall::addArgument):
4:28 PM Changeset in webkit [43594] by andersca@apple.com
  • 2 edits in trunk/WebKit/mac

2009-05-12 Anders Carlsson <​andersca@apple.com>

Reviewed by Dan Bernstein.

Fix <rdar://problem/6878105>.


When instantiating the QT plug-in under Dashboard, force "kiosk mode".


  • Plugins/WebBaseNetscapePluginView.mm: (-[WebBaseNetscapePluginView initWithFrame:pluginPackage:URL:baseURL:MIMEType:attributeKeys:attributeValues:loadManually:element:WebCore::]):
4:16 PM Changeset in webkit [43593] by weinig@apple.com
  • 4 edits in branches/nitro-extreme/JavaScriptCore

2009-05-12 Sam Weinig <​sam@webkit.org>

Reviewed by Geoffrey Garen.

Implement simple version of property access opcodes
which just call a stub functions.

  • jit/JITOpcodes.cpp:
  • jit/JITPropertyAccess.cpp: (JSC::JIT::emitSlow_op_put_by_id): (JSC::JIT::emitSlow_op_get_by_id): (JSC::JIT::emit_op_get_by_val): (JSC::JIT::emitSlow_op_get_by_val): (JSC::JIT::emit_op_put_by_val): (JSC::JIT::emitSlow_op_put_by_val): (JSC::JIT::emit_op_put_by_index): (JSC::JIT::emit_op_put_getter): (JSC::JIT::emit_op_put_setter): (JSC::JIT::emit_op_del_by_id): (JSC::JIT::compileGetByIdHotPath): (JSC::JIT::compilePutByIdHotPath):
  • jit/JITStubCall.h: (JSC::JITStubCall::addArgument):
  • jsc.cpp:
4:14 PM Changeset in webkit [43592] by Simon Fraser
  • 21 edits
    16 copies
    3 adds
    2 deletes in trunk/LayoutTests

2009-05-12 Simon Fraser <Simon Fraser>

Reviewed by Dan Bernstein

<rdar://problem/6497461> Many media layout tests failing on SnowLeopard.

Turn media tests back on for SnowLeopard, and generate new pixel results. Put override
results in platform/mac-leopard when necessary.

media/video-size-intrinsic-scale.html fails and is still skipped: <rdar://problem/6877291>

  • platform/mac-leopard/media/audio-controls-rendering-expected.checksum: Added.
  • platform/mac-leopard/media/audio-controls-rendering-expected.png: Added.
  • platform/mac-leopard/media/video-aspect-ratio-expected.checksum: Added.
  • platform/mac-leopard/media/video-aspect-ratio-expected.png: Added.
  • platform/mac-leopard/media/video-controls-rendering-expected.checksum: Added.
  • platform/mac-leopard/media/video-controls-rendering-expected.png: Added.
  • platform/mac-leopard/media/video-display-toggle-expected.checksum: Added.
  • platform/mac-leopard/media/video-display-toggle-expected.png: Added.
  • platform/mac-leopard/media/video-empty-source-expected.checksum: Added.
  • platform/mac-leopard/media/video-empty-source-expected.png: Added.
  • platform/mac-leopard/media/video-layer-crash-expected.checksum: Added.
  • platform/mac-leopard/media/video-layer-crash-expected.png: Added.
  • platform/mac-leopard/media/video-transformed-expected.checksum: Added.
  • platform/mac-leopard/media/video-transformed-expected.png: Added.
  • platform/mac-leopard/media/video-zoom-controls-expected.checksum: Added.
  • platform/mac-leopard/media/video-zoom-controls-expected.png: Added.
  • platform/mac-leopard/media/video-zoom-expected.checksum: Added.
  • platform/mac-leopard/media/video-zoom-expected.png: Added.
  • platform/mac-snowleopard/Skipped:
  • platform/mac/Skipped:
  • platform/mac/media/audio-controls-rendering-expected.checksum:
  • platform/mac/media/audio-controls-rendering-expected.png:
  • platform/mac/media/video-aspect-ratio-expected.checksum:
  • platform/mac/media/video-aspect-ratio-expected.png:
  • platform/mac/media/video-controls-rendering-expected.checksum:
  • platform/mac/media/video-controls-rendering-expected.png:
  • platform/mac/media/video-controls-visible-audio-only-expected.checksum: Removed.
  • platform/mac/media/video-controls-visible-audio-only-expected.png: Removed.
  • platform/mac/media/video-display-toggle-expected.checksum:
  • platform/mac/media/video-display-toggle-expected.png:
  • platform/mac/media/video-empty-source-expected.checksum:
  • platform/mac/media/video-empty-source-expected.png:
  • platform/mac/media/video-layer-crash-expected.checksum:
  • platform/mac/media/video-layer-crash-expected.png:
  • platform/mac/media/video-transformed-expected.checksum:
  • platform/mac/media/video-transformed-expected.png:
  • platform/mac/media/video-zoom-controls-expected.checksum:
  • platform/mac/media/video-zoom-controls-expected.png:
  • platform/mac/media/video-zoom-expected.checksum:
  • platform/mac/media/video-zoom-expected.png:
4:02 PM Changeset in webkit [43591] by kevino@webkit.org
  • 2 edits in trunk/JavaScriptCore

wx build fix. Add ParserArena.cpp to the build.

3:23 PM Changeset in webkit [43590] by oliver@apple.com
  • 3 edits
    2 adds in trunk

<rdar://problem/6702386> Incorrect bound check in SVGList::insertItemBefore

Reviewed by Darin Adler.

SVGList::insertItemBefore would not perform a bounds check on the
index it was provided, potentially leading to a buffer overflow.

3:18 PM Changeset in webkit [43589] by ggaren@apple.com
  • 2 edits in branches/nitro-extreme/JavaScriptCore

2009-05-12 Geoffrey Garen <​ggaren@apple.com>

Reviewed by Sam Weinig.


Added work-around for XCode debugging echo problem.

  • jsc.cpp: (runInteractive):
3:17 PM Changeset in webkit [43588] by ggaren@apple.com
  • 3 edits in branches/nitro-extreme/JavaScriptCore

2009-05-12 Geoffrey Garen <​ggaren@apple.com>

Reviewed by Sam Weinig.


Added overflow handling to op_add.

  • jit/JIT.h:
  • jit/JITArithmetic.cpp: (JSC::JIT::emitSlow_op_add): (JSC::JIT::emitSlowAdd32InPlace):
2:54 PM Changeset in webkit [43587] by Dimitri Glazkov
  • 2 edits in trunk/WebCore

2009-05-12 Paul Godavari <​paul@chromium.org>

Reviewed by Dimitri Glazkov.

Bug 25708: Cannot choose menu items in popups with many entries in Chromium
​https://bugs.webkit.org/show_bug.cgi?id=25708

This change sets the window size for popups on Mac to include all items
in the menu. This is required for hit testing on Mac, where we use native
controls to manage the popups and don't want to artificially limit the
valid hit testing region to a limited scroll window.

  • platform/chromium/PopupMenuChromium.cpp: (WebCore::PopupListBox::layout):
2:07 PM Changeset in webkit [43586] by weinig@apple.com
  • 2 edits in branches/nitro-extreme/JavaScriptCore

2009-05-12 Sam Weinig <​sam@webkit.org>

Reviewed by Geoffrey Garen.

Add slow cases for op_jnless or emit_op_jnlesseq.

  • jit/JITArithmetic.cpp: (JSC::JIT::emitSlow_op_jnless): (JSC::JIT::emitSlow_op_jnlesseq):
2:03 PM Changeset in webkit [43585] by weinig@apple.com
  • 3 edits in branches/nitro-extreme/JavaScriptCore

2009-05-12 Sam Weinig <​sam@webkit.org>

Reviewed by Geoffrey Garen.

Add implementations for op_jnless, emit_op_jnlesseq, op_loop_if_less and op_loop_if_lesseq.
No slow cases for op_jnless or emit_op_jnlesseq yet.

  • jit/JITArithmetic.cpp: (JSC::JIT::emit_op_jnless): (JSC::JIT::emitSlow_op_jnless): (JSC::JIT::emit_op_jnlesseq): (JSC::JIT::emitSlow_op_jnlesseq):
  • jit/JITOpcodes.cpp: (JSC::JIT::emit_op_loop_if_less): (JSC::JIT::emitSlow_op_loop_if_less): (JSC::JIT::emit_op_loop_if_lesseq): (JSC::JIT::emitSlow_op_loop_if_lesseq):
1:36 PM Changeset in webkit [43584] by Dimitri Glazkov
  • 4 edits in trunk/WebCore

2009-05-12 Stephen White <​senorblanco@chromium.org>

Reviewed by Dimitri Glazkov.

Fixes to build with latest skia: SkTypeface::Create() is now
SkTypeface::CreateFromName(); computeBounds() has been reworked
as getBounds(). The changes are placed behind an #ifdef for now,
so that we can roll back the skia version in Chromium if necessary
without having to roll back this change.

​https://bugs.webkit.org/show_bug.cgi?id=25705

  • platform/graphics/chromium/FontCacheLinux.cpp: (WebCore::FontCache::createFontPlatformData):
  • platform/graphics/skia/PathSkia.cpp: (WebCore::Path::boundingRect): (WebCore::boundingBoxForCurrentStroke):
  • platform/graphics/skia/SkiaUtils.cpp: (WebCore::SkPathContainsPoint):
1:27 PM Changeset in webkit [43583] by oliver@apple.com
  • 2 edits in trunk/JavaScriptCore

Unsigned underflow on 64bit cannot be treated as a negative number

Reviewed by Geoff Garen

This code included some placeswhere we deliberately create negative offsets
from unsigned values, on 32bit this is "safe", but in 64bit builds much
badness occurs. Solution is to use signed types as nature intended.

1:22 PM Changeset in webkit [43582] by weinig@apple.com
  • 4 edits in branches/nitro-extreme/JavaScriptCore

2009-05-12 Sam Weinig <​sam@webkit.org>

Reviewed by Geoffrey Garen.

Turn the RECORD_JUMP_TARGET macro into an inline function.

  • jit/JIT.h:
  • jit/JITInlineMethods.h: (JSC::JIT::recordJumpTarget):
  • jit/JITOpcodes.cpp: (JSC::JIT::emit_op_jmp): (JSC::JIT::emit_op_jsr): (JSC::JIT::emit_op_jmp_scopes):
1:21 PM Changeset in webkit [43581] by weinig@apple.com
  • 2 edits in branches/nitro-extreme/JavaScriptCore

2009-05-12 Sam Weinig <​sam@webkit.org>

Add MacroAssemblerX86Common::set8 to fix the build.

  • assembler/MacroAssemblerX86Common.h: (JSC::MacroAssemblerX86Common::set8):
1:16 PM Changeset in webkit [43580] by mitz@apple.com
  • 2 edits in trunk/WebKit/mac

Reviewed by Darin Adler.

  • declare a forgotten method
  • DOM/WebDOMOperationsPrivate.h: Declare -[DOMNode markupString] in the WebDOMNodeOperationsPendingPublic category.
1:15 PM Changeset in webkit [43579] by ggaren@apple.com
  • 2 edits in branches/nitro-extreme/JavaScriptCore

2009-05-12 Geoffrey Garen <​ggaren@apple.com>

Reviewed by Sam Weinig.


Added overflow recovery for pre_inc and pre_dec.


Turned some short-circuit code into early returns, as is the WebKit style.

  • jit/JITArithmetic.cpp: (JSC::JIT::emit_op_post_inc): (JSC::JIT::emitSlow_op_post_inc): (JSC::JIT::emit_op_post_dec): (JSC::JIT::emitSlow_op_post_dec): (JSC::JIT::emitSlow_op_pre_inc): (JSC::JIT::emitSlow_op_pre_dec):
1:08 PM Changeset in webkit [43578] by weinig@apple.com
  • 2 edits in branches/nitro-extreme/JavaScriptCore

2009-05-12 Sam Weinig <​sam@webkit.org>

Reviewed by Geoffrey Garen.

Implement op_jmp, op_loop, op_eq and op_neq.

  • jit/JITOpcodes.cpp: (JSC::JIT::emit_op_jmp): (JSC::JIT::emit_op_loop): (JSC::JIT::emit_op_eq): (JSC::JIT::emitSlow_op_eq): (JSC::JIT::emit_op_neq): (JSC::JIT::emitSlow_op_neq): (JSC::JIT::emit_op_enter): (JSC::JIT::emit_op_enter_with_activation):
12:57 PM Changeset in webkit [43577] by weinig@apple.com
  • 2 edits in branches/nitro-extreme/JavaScriptCore

2009-05-12 Sam Weinig <​sam@webkit.org>

Reviewed by Geoffrey Garen.

Implement the slow cases for arithmetic opcodes.

  • jit/JITArithmetic.cpp: (JSC::JIT::emitSlow_op_lshift): (JSC::JIT::emitSlow_op_rshift): (JSC::JIT::emitSlow_op_bitand): (JSC::JIT::emitSlow_op_bitor): (JSC::JIT::emitSlow_op_bitxor): (JSC::JIT::emitSlow_op_bitnot): (JSC::JIT::emitSlow_op_sub): (JSC::JIT::emitSlow_op_mul): (JSC::JIT::emitSlow_op_mod): (JSC::JIT::emit_op_mod):
12:34 PM Changeset in webkit [43576] by weinig@apple.com
  • 4 edits in branches/nitro-extreme/JavaScriptCore

2009-05-12 Sam Weinig <​sam@webkit.org>

Reviewed by Geoffrey Garen.

Implement op_bitnot.

  • assembler/MacroAssemblerX86Common.h: (JSC::MacroAssemblerX86Common::not32):
  • assembler/X86Assembler.h: (JSC::X86Assembler::notl_m):
  • jit/JITArithmetic.cpp: (JSC::JIT::emit_op_bitnot):
12:26 PM Changeset in webkit [43575] by weinig@apple.com
  • 4 edits in branches/nitro-extreme/JavaScriptCore

2009-05-12 Sam Weinig <​sam@webkit.org>

Reviewed by Geoffrey Garen.

Add arithmetic opcode implementations from the old nitro-extreme branch.

  • jit/JIT.h:
  • jit/JITArithmetic.cpp: (JSC::JIT::emit_op_jnless): (JSC::JIT::emitSlow_op_jnless): (JSC::JIT::emit_op_jnlesseq): (JSC::JIT::emitSlow_op_jnlesseq): (JSC::JIT::emit_op_lshift): (JSC::JIT::emitSlow_op_lshift): (JSC::JIT::emit_op_rshift): (JSC::JIT::emitSlow_op_rshift): (JSC::JIT::emit_op_bitand): (JSC::JIT::emitBitAnd32Constant): (JSC::JIT::emitBitAnd32InPlace): (JSC::JIT::emit_op_bitor): (JSC::JIT::emitSlow_op_bitor): (JSC::JIT::emitBitOr32Constant): (JSC::JIT::emitBitOr32InPlace): (JSC::JIT::emit_op_bitxor): (JSC::JIT::emitSlow_op_bitxor): (JSC::JIT::emitBitXor32Constant): (JSC::JIT::emitBitXor32InPlace): (JSC::JIT::emit_op_bitnot): (JSC::JIT::emitSlow_op_bitnot): (JSC::JIT::emit_op_post_inc): (JSC::JIT::emitSlow_op_post_inc): (JSC::JIT::emit_op_post_dec): (JSC::JIT::emitSlow_op_post_dec): (JSC::JIT::emit_op_pre_inc): (JSC::JIT::emitSlow_op_pre_inc): (JSC::JIT::emit_op_pre_dec): (JSC::JIT::emitSlow_op_pre_dec): (JSC::JIT::emit_op_add): (JSC::JIT::emitAdd32Constant): (JSC::JIT::emitAdd32InPlace): (JSC::JIT::emitSlow_op_add): (JSC::JIT::emit_op_sub): (JSC::JIT::emitSlow_op_sub): (JSC::JIT::emitSub32ConstantLeft): (JSC::JIT::emitSub32ConstantRight): (JSC::JIT::emitSub32InPlaceLeft): (JSC::JIT::emitSub32InPlaceRight): (JSC::JIT::emit_op_mul): (JSC::JIT::emitSlow_op_mul): (JSC::JIT::emitMul32Constant): (JSC::JIT::emitMul32InPlace): (JSC::JIT::emit_op_mod): (JSC::JIT::emitSlow_op_mod):
  • jit/JITOpcodes.cpp:
11:44 AM Changeset in webkit [43574] by Dimitri Glazkov
  • 2 edits in trunk/WebCore

2009-05-12 Nate Chapin <​japhet@google.com>

Reviewed by Dimitri Glazkov.

​https://bugs.webkit.org/show_bug.cgi?id=25732
Update V8ElementCustom.cpp to match the current API of V8Proxy.

(WebCore::ACCESSOR_SETTER): Change retrieveActiveFrame() to retrieveFrameForEnteredContext().

11:26 AM Changeset in webkit [43573] by ggaren@apple.com
  • 4 edits
    2 adds in branches/nitro-extreme/JavaScriptCore

2009-05-12 Geoffrey Garen <​ggaren@apple.com>

Removed JIT_OPTIMIZE_ARITHMETIC setting, since it was all about 32bit
value representations.


Added JSAPIValueWrapper to the repository.

  • jit/JIT.h:
  • jit/JITArithmetic.cpp:
  • runtime/JSAPIValueWrapper.cpp: Added. (JSC::JSAPIValueWrapper::toPrimitive): (JSC::JSAPIValueWrapper::getPrimitiveNumber): (JSC::JSAPIValueWrapper::toBoolean): (JSC::JSAPIValueWrapper::toNumber): (JSC::JSAPIValueWrapper::toString): (JSC::JSAPIValueWrapper::toObject):
  • runtime/JSAPIValueWrapper.h: Added. (JSC::JSAPIValueWrapper::value): (JSC::JSAPIValueWrapper::isAPIValueWrapper): (JSC::JSAPIValueWrapper::JSAPIValueWrapper): (JSC::jsAPIValueWrapper):
  • wtf/Platform.h:
11:13 AM Changeset in webkit [43572] by ariya@webkit.org
  • 2 edits in trunk/WebKit/qt

2009-05-12 Kenneth Rohde Christiansen <​kenneth.christiansen@openbossa.org>

Reviewed by Ariya Hidayat.

Many methods were not considering the case of the element not having
siblings or children when inserting nodes, and thus broke in some
situations. This patch fixes that.

11:02 AM Changeset in webkit [43571] by ariya@webkit.org
  • 4 edits in trunk/WebKit/qt

2009-05-08 Kenneth Rohde Christiansen <​kenneth.christiansen@openbossa.org>

Reviewed by Ariya Hidayat.

Make is possible to mark a style property as important while setting
it. Also support the normal CSS property syntax "!important", while
accepting spaces between the ! and the important keyword.

10:56 AM Changeset in webkit [43570] by ariya@webkit.org
  • 4 edits in trunk/WebKit/qt

2009-05-08 Kenneth Rohde Christiansen <​kenneth.christiansen@openbossa.org>

Reviewed by Ariya Hidayat.

Working with Antonio Gomes.

Add support for finding the style property actually applied to the element.

10:16 AM Changeset in webkit [43569] by sfalken@apple.com
  • 2 edits in trunk/WebKit/win

Build fix for Windows nightlies.
Change link order to work around CFNetwork bug.

  • WebKit.vcproj/WebKit.vcproj:
9:21 AM Changeset in webkit [43568] by ap@webkit.org
  • 3 edits
    2 adds in trunk

Reviewed by Darin Adler.

​https://bugs.webkit.org/show_bug.cgi?id=25694
HTMLParser::createHead() ASSERT: Creating an element, calling document.open() and writing
to the document NULL ptr

Test: fast/parser/implicit-head-in-fragment-crash.html

  • html/HTMLParser.cpp: (WebCore::HTMLParser::bodyCreateErrorCheck): Do not try to implicitly create <head> when parsing a fragment.
8:58 AM Changeset in webkit [43567] by ariya@webkit.org
  • 1 edit
    1 add in trunk/LayoutTests

2009-05-12 Ariya Hidayat <​ariya.hidayat@nokia.com>

Reviewed by Dimitri Glazkov.

Added Qt-specific expected result for toDataURL test, since Qt
does not support saving pixmaps to GIF.

  • platform/qt/fast/canvas/toDataURL-supportedTypes-expected.txt: Added.
8:54 AM Changeset in webkit [43566] by Dimitri Glazkov
  • 2 edits in trunk/WebCore

2009-05-12 Soren Gjesse <​sgjesse@chromium.org>

Reviewed by Dimitri Glazkov.

​https://bugs.webkit.org/show_bug.cgi?id=25687
Missing check for valid function in V8 bindings for toString function for event listeners.

  • bindings/v8/V8LazyEventListener.cpp: (WebCore::V8LazyEventListener::getWrappedListenerFunction): Added empty handle checks.
5:42 AM Changeset in webkit [43565] by ariya@webkit.org
  • 2 edits
    1 add in trunk/LayoutTests

2009-05-12 Ariya Hidayat <​ariya.hidayat@nokia.com>

Rubber-stamped by Simon Hausmann.

Added Qt-specific expected result for Canvas getImageData's test.

​https://bugs.webkit.org/show_bug.cgi?id=22150

Since Qt is internally using premultiplied ARGB32 for doing
alpha-blending painting, reading the color back will not
necessarily give the same exact color.

  • platform/qt/Skipped: Excluded canvas-getImageData.
  • platform/qt/fast/canvas/canvas-getImageData-expected.txt: Added.
5:06 AM Changeset in webkit [43564] by jmalonzo@webkit.org
  • 2 edits in trunk/WebKit/gtk

2009-05-12 Jan Michael Alonzo <​jmalonzo@webkit.org>

Reviewed by Holger Freyther.

[Gtk] Various autotools build refactoring and fixes
​https://bugs.webkit.org/show_bug.cgi?id=25286

Add glib-2.0 to the list of required package.

  • webkit.pc.in:
5:06 AM Changeset in webkit [43563] by jmalonzo@webkit.org
  • 2 edits in trunk

2009-05-12 Jan Michael Alonzo <​jmalonzo@webkit.org>

Reviewed by Holger Freyther.

[Gtk] Various autotools build refactoring and fixes
​https://bugs.webkit.org/show_bug.cgi?id=25286

Refactor use of CFLAGS, CXXFLAGS, LIBADD and LDFLAGS.

  • GNUmakefile.am:
5:05 AM Changeset in webkit [43562] by jmalonzo@webkit.org
  • 2 edits in trunk/JavaScriptCore

2009-05-12 Jan Michael Alonzo <​jmalonzo@webkit.org>

Reviewed by Holger Freyther.

[Gtk] Various autotools build refactoring and fixes
​https://bugs.webkit.org/show_bug.cgi?id=25286

Define WTF_USE_JSC for the Gtk port.

  • wtf/Platform.h:
3:35 AM Changeset in webkit [43561] by mjs@apple.com
  • 2 edits in trunk/JavaScriptCore

2009-05-12 Maciej Stachowiak <​mjs@apple.com>

Reviewed by Oliver Hunt.


  • allow all of strictEqual to be inlined into cti_op_stricteq once again


We had this optimization once but accidentally lost it at some point.

  • runtime/Operations.h: (JSC::JSValue::strictEqualSlowCaseInline): (JSC::JSValue::strictEqual):
2:18 AM Changeset in webkit [43560] by barraclough@apple.com
  • 8 edits in trunk

JavaScriptCore:

2009-05-12 Gavin Barraclough <​barraclough@apple.com>

Reviewed by Oliver Hunt.

instanceof should throw if the constructor being tested does not implement
'HasInstance" (i.e. is a function). Instead we were returning false.

  • interpreter/Interpreter.cpp: (JSC::isInvalidParamForIn): (JSC::isInvalidParamForInstanceOf): (JSC::Interpreter::privateExecute):
  • jit/JITStubs.cpp: (JSC::JITStubs::cti_op_instanceof):
  • tests/mozilla/ecma_2/instanceof/instanceof-003.js:

Fix broken test case.

  • tests/mozilla/ecma_2/instanceof/regress-7635.js:

Remove broken test case (was an exact duplicate of a test in instanceof-003.js).

LayoutTests:

2009-05-12 Gavin Barraclough <​barraclough@apple.com>

Reviewed by Oliver Hunt.

Test was checked in with one test case disabled since it exposed an existing bug;
enable it now.

  • fast/js/instance-of-immediates-expected.txt:
  • fast/js/resources/instance-of-immediates.js:
1:58 AM Changeset in webkit [43559] by oliver@apple.com
  • 11 edits in trunk/JavaScriptCore

Improve function call forwarding performance

Reviewed by Gavin Barraclough

Make creation of the Arguments object occur lazily, so it
is not necessarily created for every function that references
it. Then add logic to Function.apply to allow it to avoid
allocating the Arguments object at all. Helps a lot with
the function forwarding/binding logic in jQuery, Prototype,
and numerous other JS libraries.

1:58 AM Changeset in webkit [43558] by ggaren@apple.com
  • 17 edits in branches/nitro-extreme/JavaScriptCore

2009-05-12 Geoffrey Garen <​ggaren@apple.com>

Turned on the JIT and got it building and running the most trivial of
programs.


All configurable optimizations are turned off, and a few opcodes are ad
hoc #if'd out.


So far, I've only merged op_mov and op_end, but some stub-reliant
opcodes work as-is from TOT.


  • bytecode/CodeBlock.cpp: (JSC::CodeBlock::~CodeBlock):
  • bytecode/CodeBlock.h:
  • jit/JIT.cpp: (JSC::JIT::compileOpStrictEq):
  • jit/JIT.h:
  • jit/JITArithmetic.cpp: (JSC::JIT::emit_op_lshift): (JSC::JIT::emitSlow_op_lshift): (JSC::JIT::emit_op_rshift): (JSC::JIT::emitSlow_op_rshift): (JSC::JIT::emit_op_jnless): (JSC::JIT::emitSlow_op_jnless): (JSC::JIT::emit_op_jnlesseq): (JSC::JIT::emitSlow_op_jnlesseq): (JSC::JIT::emit_op_bitand): (JSC::JIT::emitSlow_op_bitand): (JSC::JIT::emit_op_post_inc): (JSC::JIT::emitSlow_op_post_inc): (JSC::JIT::emit_op_post_dec): (JSC::JIT::emitSlow_op_post_dec): (JSC::JIT::emit_op_pre_inc): (JSC::JIT::emitSlow_op_pre_inc): (JSC::JIT::emit_op_pre_dec): (JSC::JIT::emitSlow_op_pre_dec): (JSC::JIT::emit_op_mod): (JSC::JIT::emitSlow_op_mod): (JSC::JIT::emit_op_add): (JSC::JIT::emit_op_mul): (JSC::JIT::emit_op_sub): (JSC::JIT::compileBinaryArithOpSlowCase): (JSC::JIT::emitSlow_op_add): (JSC::JIT::emitSlow_op_mul):
  • jit/JITCall.cpp: (JSC::JIT::compileOpCallInitializeCallFrame): (JSC::JIT::compileOpConstructSetupArgs): (JSC::JIT::compileOpCallVarargs): (JSC::JIT::compileOpCall): (JSC::JIT::compileOpCallSlowCase):
  • jit/JITInlineMethods.h: (JSC::JIT::getConstantOperandImmediateInt): (JSC::JIT::isOperandConstantImmediateInt): (JSC::JIT::emitInitRegister): (JSC::JIT::addSlowCase): (JSC::JIT::addJump): (JSC::JIT::emitJumpSlowToHot): (JSC::JIT::tagFor): (JSC::JIT::payloadFor): (JSC::JIT::emitLoad): (JSC::JIT::emitLoadReturnValue): (JSC::JIT::emitStore): (JSC::JIT::emitStoreReturnValue):
  • jit/JITOpcodes.cpp: (JSC::JIT::emit_op_mov): (JSC::JIT::emit_op_end): (JSC::JIT::emit_op_jmp): (JSC::JIT::emit_op_loop): (JSC::JIT::emit_op_loop_if_less): (JSC::JIT::emit_op_loop_if_lesseq): (JSC::JIT::emit_op_instanceof): (JSC::JIT::emit_op_get_global_var): (JSC::JIT::emit_op_put_global_var): (JSC::JIT::emit_op_get_scoped_var): (JSC::JIT::emit_op_put_scoped_var): (JSC::JIT::emit_op_tear_off_activation): (JSC::JIT::emit_op_ret): (JSC::JIT::emit_op_construct_verify): (JSC::JIT::emit_op_to_primitive): (JSC::JIT::emit_op_loop_if_true): (JSC::JIT::emit_op_resolve_global): (JSC::JIT::emit_op_not): (JSC::JIT::emit_op_jfalse): (JSC::JIT::emit_op_jeq_null): (JSC::JIT::emit_op_jneq_null): (JSC::JIT::emit_op_jneq_ptr): (JSC::JIT::emit_op_unexpected_load): (JSC::JIT::emit_op_eq): (JSC::JIT::emit_op_bitnot): (JSC::JIT::emit_op_jtrue): (JSC::JIT::emit_op_neq): (JSC::JIT::emit_op_bitxor): (JSC::JIT::emit_op_bitor): (JSC::JIT::emit_op_throw): (JSC::JIT::emit_op_next_pname): (JSC::JIT::emit_op_push_scope): (JSC::JIT::emit_op_to_jsnumber): (JSC::JIT::emit_op_push_new_scope): (JSC::JIT::emit_op_catch): (JSC::JIT::emit_op_switch_imm): (JSC::JIT::emit_op_switch_char): (JSC::JIT::emit_op_switch_string): (JSC::JIT::emit_op_new_error): (JSC::JIT::emit_op_eq_null): (JSC::JIT::emit_op_neq_null): (JSC::JIT::emit_op_convert_this): (JSC::JIT::emit_op_profile_will_call): (JSC::JIT::emit_op_profile_did_call): (JSC::JIT::emitSlow_op_construct_verify): (JSC::JIT::emitSlow_op_get_by_val): (JSC::JIT::emitSlow_op_loop_if_less): (JSC::JIT::emitSlow_op_loop_if_lesseq): (JSC::JIT::emitSlow_op_put_by_val): (JSC::JIT::emitSlow_op_not): (JSC::JIT::emitSlow_op_instanceof):
  • jit/JITPropertyAccess.cpp: (JSC::JIT::emit_op_get_by_val): (JSC::JIT::emit_op_put_by_val): (JSC::JIT::emit_op_put_by_index): (JSC::JIT::emit_op_put_getter): (JSC::JIT::emit_op_put_setter): (JSC::JIT::emit_op_del_by_id): (JSC::JIT::compileGetByIdHotPath): (JSC::JIT::compilePutByIdHotPath):
  • jit/JITStubCall.h: (JSC::JITStubCall::JITStubCall): (JSC::JITStubCall::addArgument): (JSC::JITStubCall::call): (JSC::JITStubCall::): (JSC::CallEvalJITStub::CallEvalJITStub):
  • jit/JITStubs.cpp: (JSC::): (JSC::JITStubs::cti_op_add): (JSC::JITStubs::cti_op_pre_inc): (JSC::JITStubs::cti_op_mul): (JSC::JITStubs::cti_op_get_by_val): (JSC::JITStubs::cti_op_get_by_val_string): (JSC::JITStubs::cti_op_get_by_val_byte_array): (JSC::JITStubs::cti_op_sub): (JSC::JITStubs::cti_op_put_by_val): (JSC::JITStubs::cti_op_put_by_val_array): (JSC::JITStubs::cti_op_put_by_val_byte_array): (JSC::JITStubs::cti_op_negate): (JSC::JITStubs::cti_op_div): (JSC::JITStubs::cti_op_pre_dec): (JSC::JITStubs::cti_op_post_inc): (JSC::JITStubs::cti_op_eq): (JSC::JITStubs::cti_op_lshift): (JSC::JITStubs::cti_op_bitand): (JSC::JITStubs::cti_op_rshift): (JSC::JITStubs::cti_op_bitnot): (JSC::JITStubs::cti_op_mod): (JSC::JITStubs::cti_op_neq): (JSC::JITStubs::cti_op_post_dec): (JSC::JITStubs::cti_op_urshift): (JSC::JITStubs::cti_op_bitxor): (JSC::JITStubs::cti_op_bitor): (JSC::JITStubs::cti_op_switch_imm):
  • jit/JITStubs.h:
  • runtime/JSArray.cpp: (JSC::JSArray::JSArray):
  • runtime/JSFunction.cpp: (JSC::JSFunction::~JSFunction):
  • runtime/JSValue.h: (JSC::JSValue::payload):
  • wtf/Platform.h:
Note: See TracTimeline for information about the timeline view.