⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



May 16, 2009:

8:44 PM Changeset in webkit [43808] by mrowe@apple.com
  • 4 edits in trunk/WebCore

2009-05-16 Dave Moore <​davemoore@google.com>

Reviewed by Darin Adler.

Allow Strings to be created with one malloc node with no copying
​https://bugs.webkit.org/show_bug.cgi?id=25779

Add new methods to String and StringImpl, refactoring existing
methods in StringImpl to use new createUninitialized() method.

  • platform/text/PlatformString.h: (WebCore::String::createUninitialized):
  • platform/text/StringImpl.cpp: (WebCore::StringImpl::createUninitialized): (WebCore::StringImpl::create):
  • platform/text/StringImpl.h:
8:38 PM Changeset in webkit [43807] by mrowe@apple.com
  • 2 edits in trunk/WebCore

<rdar://problem/6827041> WebCore should stop throwing away the CGImageSourceRef to
dramatically improve animated GIF decoding performance

Reviewed by Darin Adler.

Recent versions of ImageIO discard previously decoded image frames if the client
application no longer holds references to them, so there's no need to throw away
the decoder unless we're explicitly asked to destroy all of the frames.

This drops peak CPU usage when displaying <​http://www.aintitcool.com/files/HoD2.gif>
from over 90% to below 3%.

  • platform/graphics/cg/ImageSourceCG.cpp:

(WebCore::ImageSource::clear):

2:51 PM Changeset in webkit [43806] by andersca@apple.com
  • 4 edits in trunk/WebKit

WebKit:

2009-05-16 Anders Carlsson <​andersca@apple.com>

Reviewed by Sam Weinig and Dan Bernstein.

Fix <rdar://problem/6889644>.


  • English.lproj/Localizable.strings:

WebKit/mac:

2009-05-16 Anders Carlsson <​andersca@apple.com>

Reviewed by Sam Weinig and Dan Bernstein.

Fix <rdar://problem/6889644>


  • Plugins/Hosted/NetscapePluginHostManager.mm: (WebKit::NetscapePluginHostManager::spawnPluginHost):
1:21 PM Changeset in webkit [43805] by mitz@apple.com
  • 9 edits in trunk/LayoutTests/platform/mac

Set the svn:mime-type property of recently-added PNG files to image/png

1:06 PM Changeset in webkit [43804] by mitz@apple.com
  • 2 edits in trunk/WebKit/mac
  • revert an accidental change from r43802.
  • WebInspector/WebInspector.mm:
12:58 PM Changeset in webkit [43803] by andersca@apple.com
  • 2 edits in trunk/WebKit/mac

2009-05-16 Anders Carlsson <​andersca@apple.com>

Reviewed by Dan Bernstein.

<rdar://problem/6895347> Mouse wheeling in the QuickTime plug-in (incorrectly) scrolls the page


Fix logic. The plug-in returns true if it handled the event.


  • Plugins/WebNetscapePluginView.mm: (-[WebNetscapePluginView sendEvent:isDrawRect:]):
12:56 PM Changeset in webkit [43802] by mitz@apple.com
  • 7 edits
    2 adds in trunk

WebCore:

Reviewed by Alexey Proskuryakov.

  • fix <rdar://problem/6873305> Two distinct characters are not displayed correctly with 2 of the font selections from the stickies widget

Test: platform/mac/editing/pasteboard/text-precomposed.html

Ensure that "text/plain" data retrieved from the clipboard is always
precomposed. This makes Clipboard::getData() and
Pasteboard::documentFragment() consistent with Pasteboard::plainText()
and -[WebHTMLView _documentFragmentFromPasteboard:forType:inContext:subresources:].

  • platform/mac/ClipboardMac.mm: (WebCore::ClipboardMac::getData):
  • platform/mac/PasteboardMac.mm: (WebCore::Pasteboard::documentFragment):

WebKit/mac:

Reviewed by Alexey Proskuryakov.

  • fix <rdar://problem/6873305> Two distinct characters are not displayed correctly with 2 of the font selections from the stickies widget
  • WebView/WebHTMLView.mm: (-[WebHTMLView _plainTextFromPasteboard:]): Return precomposed text. This is consistent with -_documentFragmentFromPasteboard:forType:inContext:subresources:.

LayoutTests:

Reviewed by Alexey Proskuryakov.

  • test for <rdar://problem/6873305> Two distinct characters are not displayed correctly with 2 of the font selections from the stickies widget
  • platform/mac/editing/pasteboard/text-precomposed-expected.txt: Added.
  • platform/mac/editing/pasteboard/text-precomposed.html: Added.
2:11 AM Changeset in webkit [43801] by zecke@webkit.org
  • 4 edits in trunk

[GTK] Merge r41819 into Gtk to log through the JS console

​https://bugs.webkit.org/show_bug.cgi?id=25787

Copy over the log routine from the OSX TestNetscapePlugin to
the copy of Gtk.

2:10 AM Changeset in webkit [43800] by zecke@webkit.org
  • 4 edits in trunk

[GTK] Merge r39877 into Gtk+ to pass plugins/npruntime.html

WebKitTools:
2009-05-11 Holger Hans Peter Freyther <​zecke@selfish.org>

Reviewed by Jan Michael Alonzo.

​https://bugs.webkit.org/show_bug.cgi?id=25787

Forward port r39877 from main.c of OSX to TestNetscapePlugin
of Gtk.

  • DumpRenderTree/gtk/TestNetscapePlugin/TestNetscapePlugin.cpp: (webkit_test_plugin_new_instance):

LayoutTests:
2009-05-11 Holger Hans Peter Freyther <​zecke@selfish.org>

Reviewed by Jan Michael Alonzo.

​https://bugs.webkit.org/show_bug.cgi?id=25787

Enable plugins/npruntime.html

  • platform/gtk/Skipped:
12:56 AM Changeset in webkit [43799] by mrowe@apple.com
  • 2 edits in trunk/WebCore

Build fix.

  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::valueForFamily): Declare valueForFamily as static.

May 15, 2009:

11:57 PM Changeset in webkit [43798] by Darin Adler
  • 5 edits in trunk/LayoutTests

2009-05-15 Darin Adler <Darin Adler>

Fix some failures from recent changes.

  • platform/gtk/Skipped: Added recently-added test to the "no expected results" section.
  • platform/win/fast/css/getComputedStyle/computed-style-expected.txt: Updated.
  • platform/win/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt: Ditto.
  • svg/css/getComputedStyle-basic-expected.txt: Ditto.
11:06 PM Changeset in webkit [43797] by Darin Adler
  • 7 edits
    2 adds in trunk

WebCore:

2009-05-15 Darin Adler <Darin Adler>

Reviewed by Dan Bernstein.

<rdar://problem/6883872> REGRESSION (r43243): computed style for font-family is returning
only the generic font, if any generic font is in the family list

Test: fast/css/getComputedStyle/computed-style-font-family.html

  • css/CSSComputedStyleDeclaration.cpp: Sorted computedProperties alphabetically. Added CSSPropertyClip and CSSPropertyWordBreak. (WebCore::identifierForFamily): Added. Maps internal font family names to identifiers. (WebCore::valueForFamily): Added. Creates either an identifier or a string as appropriate. (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue): Implemented the font-family property as specified in the CSS standard. Fixed clip to return "auto" when there is no clip set instead of nothing at all. Gave inheritableProperties and numInheritableProperties internal linkage since there was no reason for them to have external linkage.

LayoutTests:

2009-05-15 Darin Adler <Darin Adler>

Reviewed by Dan Bernstein.

<rdar://problem/6883872> REGRESSION (r43243): computed style for font-family is returning
only the generic font, if any generic font is in the family list

  • fast/css/getComputedStyle/computed-style-font-family-expected.txt: Added.
  • fast/css/getComputedStyle/computed-style-font-family.html: Added.
  • fast/css/getComputedStyle/computed-style.html: Updated array of properties to dump that are not visible when iterating the computed style object. Removed pointless unused array of unimplemented properties.
  • fast/css/getComputedStyle/computed-style-without-renderer.html: Ditto.
  • platform/mac/fast/css/getComputedStyle/computed-style-expected.txt: Updated.
  • platform/mac/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt: Ditto.
7:17 PM Changeset in webkit [43796] by kov@webkit.org
  • 2 edits in trunk/WebKit/gtk

2009-05-15 Gustavo Noronha Silva <Gustavo Noronha Silva>

Reviewed by Jan Alonzo.

Plug memory leak.

  • webkit/webkitwebsettings.cpp: (free_spell_checking_language): (webkit_web_settings_finalize): (webkit_web_settings_set_property):
6:06 PM Changeset in webkit [43795] by abarth@webkit.org
  • 5 edits
    2 adds in trunk

WebCore:

2009-05-15 Adam Barth <​abarth@webkit.org>

Reviewed by Oliver Hunt.

​https://bugs.webkit.org/show_bug.cgi?id=25741

Append instead of throwing when insertItemBefore gets an out-of-bound
index.

Test: svg/dom/svglist-insertItemBefore-appends.html

  • svg/SVGList.h: (WebCore::SVGList::insertItemBefore):

LayoutTests:

2009-05-15 Adam Barth <​abarth@webkit.org>

Reviewed by Oliver Hunt.

​https://bugs.webkit.org/show_bug.cgi?id=25741

Test that insertBeforeItem behaves properly for out of bounds indices.

  • svg/dom/svglist-exception-on-out-bounds-error-expected.txt:
  • svg/dom/svglist-exception-on-out-bounds-error.html:
  • svg/dom/svglist-insertItemBefore-appends-expected.txt: Added.
  • svg/dom/svglist-insertItemBefore-appends.html: Added.
5:33 PM Changeset in webkit [43794] by kevino@webkit.org
  • 2 edits in trunk/WebKitTools

wx build fix. Don't parse args using getopt since it isn't available on Windows.

5:31 PM Changeset in webkit [43793] by Simon Fraser
  • 3 edits
    4 adds in trunk

2009-05-15 Simon Fraser <Simon Fraser>

Reviewed by Darin Adler

​https://bugs.webkit.org/show_bug.cgi?id=25829

Fix -webkit-background-clip:text when the renderer had a non (0,0) x, y offset.

Test: fast/backgrounds/background-clip-text.html

  • rendering/RenderBoxModelObject.cpp: (WebCore::RenderBoxModelObject::paintFillLayerExtended):
5:06 PM Changeset in webkit [43792] by mitz@apple.com
  • 3 edits
    2 adds in trunk

WebCore:

Reviewed by Sam Weinig.

  • fix <rdar://problem/6888244> REGRESSION: Using the Up or Down keyboard arrows, I can't navigate caret between To Do items in a Note message

Test: editing/selection/move-by-line-004.html

  • editing/visible_units.cpp: (WebCore::enclosingNodeWithNonInlineRenderer): Added this helper function. (WebCore::previousLinePosition): When advancing to the next candidate node, stop when leaving the closest ancestor of the original node that is not an inline. The code, incorrectly, was trying to exit the closest ancestor of that type which was editable, and therefore missing other blocks in the same editable root. (WebCore::nextLinePosition): Ditto.

LayoutTests:

Reviewed by Sam Weinig.

  • test for <rdar://problem/6888244> REGRESSION: Using the Up or Down keyboard arrows, I can't navigate caret between To Do items in a Note message
  • editing/selection/move-by-line-004-expected.txt: Added.
  • editing/selection/move-by-line-004.html: Added.
4:50 PM Changeset in webkit [43791] by jmalonzo@webkit.org
  • 5 edits in trunk

2009-05-15 Fridrich Strba <​fridrich.strba@bluewin.ch>

Reviewed by Jan Alonzo.

Converting filename to uri by concatenating strings is broken
on Windows. So, don't do it for that platform.

  • platform/network/soup/ResourceHandleSoup.cpp: (WebCore::ResourceHandle::startGio):

2009-05-15 Fridrich Strba <​fridrich.strba@bluewin.ch>

Reviewed by Jan Alonzo.

Converting filename to uri by concatenating strings is broken
on Windows. Use proper glib conversion functions.

  • webkit/webkitwebview.cpp: (webkit_web_view_open):
  • tests/testdownload.c: (test_webkit_download_create):
4:49 PM Changeset in webkit [43790] by andersca@apple.com
  • 3 edits in trunk/WebKit/mac

2009-05-15 Anders Carlsson <​andersca@apple.com>

Reviewed by Dan Bernstein.

Fix <rdar://problem/6875398>.


  • Plugins/Hosted/NetscapePluginHostManager.mm: (WebKit::NetscapePluginHostManager::instantiatePlugin): If we failed to instantiate the plug-in, call cleanup() so that any streams created by the plug-in from its NPP_New callback are destroyed.


  • Plugins/Hosted/NetscapePluginInstanceProxy.h: Make cleanup() public.
3:40 PM Changeset in webkit [43789] by barraclough@apple.com
  • 3 edits in trunk/JavaScriptCore

2009-05-15 Gavin Barraclough <​barraclough@apple.com>

Reviewed by Oliver Hunt.

Looking like MSVC doesn't like static variables in inline methods?
Make the state of the SSE2 check a static variable on the class
MacroAssemblerX86Common as a speculative build fix for Windows.

  • assembler/MacroAssemblerX86Common.h: (JSC::MacroAssemblerX86Common::convertInt32ToDouble): (JSC::MacroAssemblerX86Common::branchDouble): (JSC::MacroAssemblerX86Common::branchTruncateDoubleToInt32): (JSC::MacroAssemblerX86Common::isSSE2Present): (JSC::MacroAssemblerX86Common::):
  • jit/JIT.cpp:
3:28 PM Changeset in webkit [43788] by kov@webkit.org
  • 2 edits in trunk/LayoutTests

2009-05-15 Gustavo Noronha Silva <Gustavo Noronha Silva>

Disable new tests.

  • platform/gtk/Skipped:
3:27 PM Changeset in webkit [43787] by Dimitri Glazkov
  • 3 edits
    2 adds in trunk/WebCore

2009-05-15 Nate Chapin <​japhet@google.com>

Reviewed by Dimitri Glazkov.

Upstream V8 bindings for HTMLOptionsCollection and HTMLSelectElementCollection.
​https://bugs.webkit.org/show_bug.cgi?id=25739

  • bindings/v8/V8Collection.cpp: Added. (WebCore::toOptionsCollectionSetter): Moved from v8_custom.cpp.
  • bindings/v8/V8Collection.h: Added prototype for toOptionsCollectionSetter().
  • bindings/v8/custom/V8HTMLOptionsCollectionCustom.cpp: (WebCore::INDEXED_PROPERTY_SETTER): Moved from v8_custom.cpp.
  • bindings/v8/custom/V8HTMLSelectElementCollectionCustom.cpp: Added. (WebCore::NAMED_PROPERTY_GETTER): Moved from v8_custom.cpp. (WebCore::INDEXED_PROPERTY_SETTER): Moved from v8_custom.cpp.
3:22 PM Changeset in webkit [43786] by ddkilzer@apple.com
  • 2 edits in trunk/WebCore

<rdar://problem/6649936> Add *.exp export files to WebCore Xcode project

Reviewed by Darin Adler and Timothy Hatcher.

  • WebCore.xcodeproj/project.pbxproj: Added Exports group, moved WebCore.base.exp into the group, and added 10 other *.exp files in WebCore.
3:15 PM Changeset in webkit [43785] by Adam Roben
  • 2 edits in trunk/JavaScriptCore

Add some assembler headers to JavaScriptCore.vcproj

This is just a convenience for Windows developers.

3:03 PM Changeset in webkit [43784] by Dimitri Glazkov
  • 2 edits in trunk/WebCore

2009-05-15 Dimitri Glazkov <Dimitri Glazkov>

Unreviewed, build fix.

​https://bugs.webkit.org/show_bug.cgi?id=25826
Change type to only have custom getter in JCS.

  • html/HTMLInputElement.idl: Changed CustomGetter attribute to JSCCustomGetter.
2:54 PM Changeset in webkit [43783] by Antti Koivisto
  • 5 edits in trunk/WebCore

2009-05-15 Antti Koivisto <Antti Koivisto>

Reviewed by Dave Kilzer.

Add a settings entry to en/disable web font support
​https://bugs.webkit.org/show_bug.cgi?id=25239

  • css/CSSFontSelector.cpp: (WebCore::CSSFontSelector::addFontFaceRule):
2:28 PM Changeset in webkit [43782] by weinig@apple.com
  • 2 edits in branches/nitro-extreme/JavaScriptCore

2009-05-15 Sam Weinig <​sam@webkit.org>

Reviewed by Geoffrey Garen.

Implemented fast path for op_put_by_val when putting to arrays.

  • jit/JITPropertyAccess.cpp: (JSC::JIT::emit_op_put_by_val): (JSC::JIT::emitSlow_op_put_by_val):
2:11 PM Changeset in webkit [43781] by barraclough@apple.com
  • 10 edits in trunk/JavaScriptCore

2009-05-15 Gavin Barraclough <​barraclough@apple.com>

Reviewed by Oliver Hunt.

Add FP support to the MacroAssembler, port JITArithmetic over to make use of this. Also add
API to determine whether FP support is available 'MacroAssembler::supportsFloatingPoint()',
FP is presently only supported on SSE2 platforms, not x87. On platforms where a suitable
hardware FPU is not available 'supportsFloatingPoint()' may simply return false, and all
other methods ASSERT_NOT_REACHED().

  • assembler/AbstractMacroAssembler.h:
  • assembler/MacroAssemblerX86.h: (JSC::MacroAssemblerX86::MacroAssemblerX86): (JSC::MacroAssemblerX86::branch32): (JSC::MacroAssemblerX86::branchPtrWithPatch): (JSC::MacroAssemblerX86::supportsFloatingPoint):
  • assembler/MacroAssemblerX86Common.h: (JSC::MacroAssemblerX86Common::): (JSC::MacroAssemblerX86Common::loadDouble): (JSC::MacroAssemblerX86Common::storeDouble): (JSC::MacroAssemblerX86Common::addDouble): (JSC::MacroAssemblerX86Common::subDouble): (JSC::MacroAssemblerX86Common::mulDouble): (JSC::MacroAssemblerX86Common::convertInt32ToDouble): (JSC::MacroAssemblerX86Common::branchDouble): (JSC::MacroAssemblerX86Common::branchTruncateDoubleToInt32): (JSC::MacroAssemblerX86Common::branch32): (JSC::MacroAssemblerX86Common::branch16): (JSC::MacroAssemblerX86Common::branchTest32): (JSC::MacroAssemblerX86Common::branchAdd32): (JSC::MacroAssemblerX86Common::branchMul32): (JSC::MacroAssemblerX86Common::branchSub32): (JSC::MacroAssemblerX86Common::set32): (JSC::MacroAssemblerX86Common::setTest32): (JSC::MacroAssemblerX86Common::x86Condition): (JSC::MacroAssemblerX86Common::isSSE2Present):
  • assembler/MacroAssemblerX86_64.h: (JSC::MacroAssemblerX86_64::movePtrToDouble): (JSC::MacroAssemblerX86_64::moveDoubleToPtr): (JSC::MacroAssemblerX86_64::setPtr): (JSC::MacroAssemblerX86_64::branchPtr): (JSC::MacroAssemblerX86_64::branchTestPtr): (JSC::MacroAssemblerX86_64::branchAddPtr): (JSC::MacroAssemblerX86_64::branchSubPtr): (JSC::MacroAssemblerX86_64::supportsFloatingPoint):
  • assembler/X86Assembler.h:
  • jit/JIT.cpp: (JSC::JIT::JIT):
  • jit/JIT.h:
  • jit/JITArithmetic.cpp: (JSC::JIT::emit_op_rshift): (JSC::JIT::emitSlow_op_rshift): (JSC::JIT::emitSlow_op_jnless): (JSC::JIT::emitSlow_op_jnlesseq): (JSC::JIT::compileBinaryArithOp): (JSC::JIT::compileBinaryArithOpSlowCase): (JSC::JIT::emit_op_add): (JSC::JIT::emitSlow_op_add): (JSC::JIT::emit_op_mul): (JSC::JIT::emitSlow_op_mul):
  • jit/JITPropertyAccess.cpp: (JSC::JIT::privateCompilePutByIdTransition):
1:43 PM Changeset in webkit [43780] by weinig@apple.com
  • 3 edits in trunk/WebCore

2009-05-15 Sam Weinig <​sam@webkit.org>

Reviewed by Steve Falkenburg.

Remove dead youtube site specific hack that was commented out.

  • bindings/js/JSNavigatorCustom.cpp:
  • page/Navigator.idl:
1:09 PM Changeset in webkit [43779] by weinig@apple.com
  • 3 edits in trunk/WebCore

2009-05-15 Sam Weinig <​sam@webkit.org>

Reviewed by Beth Dakin.

Fix for ​https://bugs.webkit.org/show_bug.cgi?id=25826
<rdar://problem/6884742>
REGRESSION: In Gmail's Edit Link dialog, I can't type in the Link To: field (due to <input type=url> support)

Added a site specific quirk for mail.google.com which returns "text" when getting the type of an <input type=url>

  • bindings/js/JSHTMLInputElementCustom.cpp: (WebCore::needsGmailQuirk): (WebCore::JSHTMLInputElement::type):
  • html/HTMLInputElement.idl:
12:40 PM Changeset in webkit [43778] by Dimitri Glazkov
  • 2 edits in trunk/WebCore

2009-05-14 Dimitri Glazkov <Dimitri Glazkov>

Reviewed by Eric Seidel.

​https://bugs.webkit.org/show_bug.cgi?id=25810
Upstream V8 DOM Wrapper map declarations.

No behavior change, so no tests.

  • bindings/v8/V8DOMMap.h: (WebCore::WeakReferenceMap::WeakReferenceMap): Added. (WebCore::WeakReferenceMap::~WeakReferenceMap): Added. (WebCore::WeakReferenceMap::get): Added. (WebCore::WeakReferenceMap::set): Added. (WebCore::WeakReferenceMap::forget): Added. (WebCore::WeakReferenceMap::contains): Added. (WebCore::WeakReferenceMap::impl): Added. (WebCore::DOMWrapperMap::DOMWrapperMap): Added.
12:10 PM Changeset in webkit [43777] by Simon Fraser
  • 5 edits in trunk/WebCore

2009-05-13 Simon Fraser <Simon Fraser>

Reviewed by Dave Hyatt

​https://bugs.webkit.org/show_bug.cgi?id=25773

Rename GraphicsLayer::graphicsContextsFlipped() to
GraphicsLayer::compositingCoordinatesOrientation() in order to clarify the usage.

Clean up code around the GraphicsLayer "contents" layer that makes use of this
flag, by removing the setHasContentsLayer() method, and just using setContentsLayer(),
which can then always do the flipping if necessary.

Only affects ACCELERATED_COMPOSITING builds.

  • platform/graphics/GraphicsLayer.h: (WebCore::GraphicsLayer::):
  • platform/graphics/mac/GraphicsLayerCA.h: (WebCore::GraphicsLayerCA::contentsLayer):
  • platform/graphics/mac/GraphicsLayerCA.mm: (WebCore::GraphicsLayer::compositingCoordinatesOrientation): (WebCore::GraphicsLayerCA::setBackgroundColor): (WebCore::GraphicsLayerCA::clearBackgroundColor): (WebCore::GraphicsLayerCA::setContentsToImage): (WebCore::GraphicsLayerCA::clearContents): (WebCore::GraphicsLayerCA::swapFromOrToTiledLayer): (WebCore::GraphicsLayerCA::setContentsLayer):
  • rendering/RenderLayerCompositor.cpp: (WebCore::RenderLayerCompositor::ensureRootPlatformLayer):
12:00 PM Changeset in webkit [43776] by ggaren@apple.com
  • 3 edits in branches/nitro-extreme/JavaScriptCore

2009-05-15 Geoffrey Garen <​ggaren@apple.com> (Mostly by Sam)

Reviewed by Sam Weinig.


Implemented fast path for op_get_by_val when accessing array.

  • jit/JIT.cpp:
  • jit/JITPropertyAccess.cpp: (JSC::JIT::emit_op_get_by_val): (JSC::JIT::emitSlow_op_get_by_val):
11:17 AM Changeset in webkit [43775] by cmarrin@apple.com
  • 2 edits in trunk/WebCore

​https://bugs.webkit.org/show_bug.cgi?id=25765

Avoid calling setNeedsStyleRecalc() when we are
putting an animated page in the cache. This avoids
the assert and subsequent problems with a dirty
page going into the cache.

11:13 AM Changeset in webkit [43774] by Adam Roben
  • 8 edits in trunk

2009-05-15 Francisco Tolmasky <​francisco@280north.com>

BUG 25467: JavaScript debugger should use function.displayName as the function's name in the call stack
<​https://bugs.webkit.org/show_bug.cgi?id=25467>

Reviewed by Adam Roben.

JavaScriptCore:

  • JavaScriptCore.exp: Added calculatedFunctionName
  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore_debug.def: Added calculatedFunctionName
  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def: Added calculatedFunctionName
  • debugger/DebuggerCallFrame.cpp: Added calculatedFunctionName to match existing one in ProfileNode. (JSC::DebuggerCallFrame::calculatedFunctionName):
  • debugger/DebuggerCallFrame.h: Added calculatedFunctionName to match existing one in ProfileNode.

WebCore:

  • inspector/JavaScriptCallFrame.cpp: (WebCore::JavaScriptCallFrame::functionName): Use calculatedFunctionName which takes into account displayName
inspector/front-end/CallStackSidebarPane.js: Remove "
anonymous function" since it is handled internally just like in profiles

(WebInspector.CallStackSidebarPane.prototype.update):

10:59 AM Changeset in webkit [43773] by Darin Adler
  • 2 edits in trunk/WebKit/mac

2009-05-15 Darin Adler <Darin Adler>

Reviewed by Anders Carlsson.

<rdar://problem/6889823> hash table iterator used after hash table modified in
ProxyInstance::fieldNamed() when viewing movie trailer

  • Plugins/Hosted/ProxyInstance.mm: (WebKit::ProxyInstance::methodsNamed): Move add call after the waitForReply call. Anders says that by the time we return someone else might have done the same add for us. (WebKit::ProxyInstance::fieldNamed): Ditto.
10:41 AM Changeset in webkit [43772] by andersca@apple.com
  • 12 edits in trunk/WebKit/mac

2009-05-15 Anders Carlsson <​andersca@apple.com>

Reviewed by Darin Adler.

<rdar://problem/6892055>
Replace WKN_GetLocation with WKN_ResolveURL (WKN_GetLocation was confusing and did not take the base URL into account)


  • Plugins/Hosted/NetscapePluginHostProxy.mm: (WKPCResolveURL): New MIG callback.


  • Plugins/Hosted/NetscapePluginInstanceProxy.h:
  • Plugins/Hosted/NetscapePluginInstanceProxy.mm: (WebKit::NetscapePluginInstanceProxy::resolveURL): Use FrameLoader::complete URL here.


  • Plugins/Hosted/WebKitPluginClient.defs: Add new MIG definition.


  • Plugins/WebBaseNetscapePluginView.h:
  • Plugins/WebBaseNetscapePluginView.mm: (-[WebBaseNetscapePluginView resolvedURLStringForURL:target:]):
  • Plugins/WebNetscapeContainerCheckPrivate.h:
  • Plugins/WebNetscapeContainerCheckPrivate.mm: (browserContainerCheckFuncs):
  • Plugins/WebNetscapePluginView.h:
  • Plugins/WebNetscapePluginView.mm: (-[WebNetscapePluginView resolveURL:forTarget:]):
  • Plugins/npapi.mm: (WKN_ResolveURL):
10:27 AM Changeset in webkit [43771] by mitz@apple.com
  • 2 edits in trunk/WebKit/mac

Reviewed by Darin Adler.

  • fix <rdar://problem/6892052> WebTextIterator should not “emit characters between all visible positions”
  • WebView/WebTextIterator.mm: (-[WebTextIterator initWithRange:]): Changed to construct a TextIterator with emitCharactersBetweenAllVisiblePositions set to false.
9:45 AM Changeset in webkit [43770] by ap@webkit.org
  • 3 edits in trunk/WebCore

Windows build fix (and a matching Mac change, to avoid unnecessarily diverging the implementations).

  • platform/network/cf/ResourceHandleCFNet.cpp: (WebCore::ResourceHandle::start):
  • platform/network/mac/ResourceHandleMac.mm: (WebCore::ResourceHandle::start): Check strings with isEmpty(), not relying on any implicit conversions.
9:06 AM Changeset in webkit [43769] by ap@webkit.org
  • 4 edits in trunk/WebCore

Reviewed by Darin Adler, Brady Eidson and Eric Carlson.

<rdar://problem/6875643> REGRESSION: Unable to download file with FTP URL that includes
username and password (Lightwave 9.6 for Mac from Newtek site)

CFNetwork only invokes didReceiveAuthenticationChallenge for HTTP requests. Credentials
for other protocols (including FTP) should be included as part of the URL.

  • platform/network/cf/ResourceHandleCFNet.cpp: (WebCore::ResourceHandle::start): (WebCore::WebCoreSynchronousLoader::load):
  • platform/network/mac/ResourceHandleMac.mm: (WebCore::ResourceHandle::start): (+[WebCoreSynchronousLoader loadRequest:allowStoredCredentials:returningResponse:error:]): Put credentials in URL for non-HTTP requests.
  • xml/XMLHttpRequest.cpp: (WebCore::XMLHttpRequest::makeSimpleCrossOriginAccessRequest): Bail out quickly if the URL is non-HTTP. Cross-origin requests require specific HTTP headers to be received, so they cannot work with other protocols.
8:33 AM Changeset in webkit [43768] by Simon Fraser
  • 2 edits in trunk/BugsSite

2009-05-15 Simon Fraser <Simon Fraser>

Carrying forwards Darin Adler's rubber stamp

Make the comment field wider too.

  • skins/custom/global.css:
8:16 AM Changeset in webkit [43767] by Simon Fraser
  • 3 edits in trunk/BugsSite

2009-05-14 Simon Fraser <Simon Fraser>

Reviewed by Darin Adler

Make the URL, Summary and Keyword fields wider to mitigate the
effects of ​https://bugs.webkit.org/show_bug.cgi?id=25566 and make
things generally better.

  • skins/custom/global.css:
  • template/en/custom/bug/edit.html.tmpl:
5:43 AM Changeset in webkit [43766] by jmalonzo@webkit.org
  • 2 edits in trunk

2009-05-15 Fridrich Strba <​fridrich.strba@bluewin.ch>

Reviewed by Jan Alonzo.

Use AC_CANONICAL_HOST instead of AC_CANONICAL_SYSTEM, since
the JIT compiler is not a cross-compiler

  • configure.ac:
4:53 AM Changeset in webkit [43765] by mrowe@apple.com
  • 2 edits in trunk/WebKit/mac

Look for libWebKitSystemInterface.a in a more reasonable location.

Reviewed by Dave Kilzer.

  • Configurations/DebugRelease.xcconfig:
4:47 AM Changeset in webkit [43764] by ariya@webkit.org
  • 3 edits in trunk/WebCore

2009-05-15 Ariya Hidayat <​ariya.hidayat@nokia.com>

Reviewed by Holger Freyther.

[Qt] In the image decoder, remove the raw image data represented as QImage
once the image is converted to QPixmap and inserted in the pixmap cache.
This effectively reduces the heap usage when running on graphics system
other than raster (i.e the case where QImage != QPixmap).

  • platform/graphics/qt/ImageDecoderQt.cpp: (WebCore::ImageDecoderQt::imageAtIndex): Nullified the image on purpose.
  • platform/graphics/qt/ImageDecoderQt.h: Made m_imageList mutable.
4:46 AM Changeset in webkit [43763] by ariya@webkit.org
  • 3 edits in trunk/WebCore

2009-05-15 Ariya Hidayat <​ariya.hidayat@nokia.com>

Reviewed by Holger Freyther.

[Qt] Refactor alpha channel detection the image decoder.
Sets the boolean flag as soon as the image is being read.

  • platform/graphics/qt/ImageDecoderQt.cpp: (WebCore::ImageDecoderQt::ImageDecoderQt): Initialized m_hasAlphaChannel. (WebCore::ImageDecoderQt::setData): Set the flag when appropriate. (WebCore::ImageDecoderQt::supportsAlpha): Simplified. (WebCore::ImageDecoderQt::reset): Resetted the flag.
  • platform/graphics/qt/ImageDecoderQt.h: Added m_hasAlphaChannel.
1:34 AM Changeset in webkit [43762] by eric@webkit.org
  • 3 edits in trunk/LayoutTests

Mark Rowe says skipping tests doesn't need review. :)

Add new tests from r43759 to windows and tiger skipped lists until bug 25816 can be resolved.
​https://bugs.webkit.org/show_bug.cgi?id=25816

Original bug: ​http://bugs.webkit.org/show_bug.cgi?id=25464

  • platform/win/Skipped:
  • platform/mac-tiger/Skipped:
1:08 AM Changeset in webkit [43761] by eric@webkit.org
  • 16 edits in trunk/WebCore

2009-05-15 Laszlo Gombos <Laszlo Gombos>

Reviewed by Darin Adler.

Finish support for disabling the JavaScript Debugger and Profiler
at compile time in WebCore
​https://bugs.webkit.org/show_bug.cgi?id=24917

  • bindings/js/JSInspectorControllerCustom.cpp: ENABLE_JAVASCRIPT_DEBUGGER guard
  • bindings/js/JSJavaScriptCallFrameCustom.cpp: Ditto.
  • inspector/JavaScriptCallFrame.cpp: Ditto.
  • inspector/JavaScriptCallFrame.h: Ditto.
  • inspector/JavaScriptCallFrame.idl: Ditto.
  • inspector/JavaScriptDebugListener.h: Ditto.
  • inspector/JavaScriptDebugServer.cpp: Ditto.
  • inspector/JavaScriptDebugServer.h: Ditto.
  • inspector/JavaScriptProfile.cpp: Ditto.
  • inspector/JavaScriptProfile.h: Ditto.
  • inspector/JavaScriptProfileNode.cpp: Ditto.
  • inspector/JavaScriptProfileNode.h: Ditto.
  • page/Console.cpp: Use guard ENABLE(JAVASCRIPT_DEBUGGER) instead of USE(JSC)
  • page/Console.h: Ditto.
  • page/Console.idl: Use guard ENABLE(JAVASCRIPT_DEBUGGER) instead of !defined(V8_BINDING)
12:55 AM Changeset in webkit [43760] by eric@webkit.org
  • 6 edits in trunk

2009-05-15 Jan Michael Alonzo <​jmalonzo@webkit.org>

Reviewed by Holger Freyther.

[GTK] Implement layoutTestController.waitForPolicyDelegate
​https://bugs.webkit.org/show_bug.cgi?id=25036

Connect to 'navigation-policy-decision-requested' and handle
waitForPolicy in the callback.

  • DumpRenderTree/gtk/DumpRenderTree.cpp: (invalidateAnyPreviousWaitToDumpWatchdog): (webViewNavigationPolicyDecisionRequested): (main):
  • DumpRenderTree/gtk/DumpRenderTreeGtk.h:
  • DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: (LayoutTestController::notifyDone): (LayoutTestController::waitForPolicyDelegate):
12:49 AM Changeset in webkit [43759] by eric@webkit.org
  • 3 edits
    8 adds in trunk

2009-05-15 Jungshik Shin <​jshin@chromium.org>

Reviewed by Dimitri Glazkov

​http://bugs.webkit.org/show_bug.cgi?id=25464

Improve the font fallback for characters belonging to 'common' scripts
in ChromiumWin port. Make characters like Danda, Double Danda (punctuation
marks in North Indian scripts) and currency signs (e.g. Thai Baht)
rendered correctly in Chromium on Win.

Tests: fast/text/international/danda-space.html

fast/text/international/thai-baht-space.html

  • platform/graphics/chromium/FontUtilsChromiumWin.cpp: (WebCore::FontMap::getScriptBasedOnUnicodeBlock): (WebCore::FontMap::getScript): (WebCore::getFallbackFamily):
12:06 AM Changeset in webkit [43758] by eric@webkit.org
  • 2 edits in trunk/WebCore

2009-05-15 Laszlo Gombos <Laszlo Gombos>

Reviewed by Holger Freyther.

​https://bugs.webkit.org/show_bug.cgi?id=25731
[Qt] Cleanup - move files exclusive to XPATH and XSLT under the
appropriate build section

  • WebCore.pro:
12:02 AM Changeset in webkit [43757] by abarth@webkit.org
  • 1 edit in trunk/WebCore/bindings/v8/custom/V8HTMLDocumentCustom.cpp

Partial revert of 43604. Turns out we need some V8 magic for this to work right.

12:02 AM Changeset in webkit [43756] by eric@webkit.org
  • 2 edits in trunk/WebCore

2009-05-14 Evan Martin <​evan@chromium.org>

Reviewed by Eric Seidel and Darin Fisher.

Fix a font-related leak in Chromium's Skia backend found by Valgrind.
​https://bugs.webkit.org/show_bug.cgi?id=25760

  • platform/graphics/chromium/FontCacheLinux.cpp: (WebCore::FontCache::getFontDataForCharacters): Use caches instead of "new" on every call.
Note: See TracTimeline for information about the timeline view.