Context Navigation

<rdar://problem/6893775> Page with screen-only stylesheet with overflow and height
transitions has bad layout and overlapping garbled text when printing

manual-tests/print-with-height-transition-in-screen-stylesheet.html: Added.

page/animation/AnimationController.cpp: (WebCore::AnimationController::updateAnimations): Don't run transitions when printing.

12:12 PM Changeset in webkit [43814] by Darin Adler

2 edits
1 add in trunk/WebCore

2009-05-17 Darin Adler <Darin Adler>

Reviewed by Simon Fraser.

<rdar://problem/6870241> REGRESSION: Programmatically selected popup menu item not shown

html/HTMLSelectElement.cpp: (WebCore::HTMLSelectElement::setSelectedIndex): Added a call to updateFromElement and also a type check on the selected index to avoid a bad cast to HTMLOptionElement.

manual-tests/select-option-in-onload.html: Added.

11:34 AM Changeset in webkit [43813] by Simon Fraser

2 edits in trunk/WebCore

2009-05-17 Simon Fraser <Simon Fraser>

Reviewed by Anders Carlsson

Rename local variables for readability.

rendering/RenderBoxModelObject.cpp: (WebCore::RenderBoxModelObject::paintBorder):

10:50 AM Changeset in webkit [43812] by Darin Adler

2 edits in trunk/LayoutTests

2009-05-17 Darin Adler <Darin Adler>

platform/gtk/Skipped: Disable another media test that seems to be failing at least intermittently.

10:47 AM Changeset in webkit [43811] by Darin Adler

4 edits in trunk/WebCore

2009-05-17 Darin Adler <Darin Adler>

Reviewed by Mark Rowe.

Bug 25840: fix some warnings seen on the GTK bot
https://bugs.webkit.org/show_bug.cgi?id=25840

platform/ScrollView.cpp: (WebCore::ScrollView::platformScrollbarModes): Initialize results here. This is really just to quiet warnings. I think this code is unreachable. Someone could put ASSERT_NOT_REACHED() in here too at some point.

plugins/PluginStream.cpp: (WebCore::PluginStream::startStream): Use proper printf format for int here, %d, not %lu. This could cause a real problem when compiled 64-bit, so it's good to fix.

rendering/RenderTextControl.cpp: (WebCore::getNextSoftBreak): Initialize breakOffset to 0 here. This is really just to quiet the warning, but still seems like a good idea.

9:50 AM Changeset in webkit [43810] by Darin Adler

3 edits in trunk/WebCore

2009-05-17 Chris Fleizach <Chris Fleizach>

Reviewed by Darin Adler.

Bug 25769: Fix accessibility warnings on GTK
https://bugs.webkit.org/show_bug.cgi?id=25769

page/AccessibilityTable.cpp: (WebCore::AccessibilityTable::columnCount): Get rid of excess const. (WebCore::AccessibilityTable::rowCount): Ditto.
page/AccessibilityTable.h: Ditto.

9:47 AM Changeset in webkit [43809] by Darin Adler

3 edits
2 adds in trunk

WebCore:

2009-05-17 Kai Brüning <kai@granus.net>

Reviewed by Darin Adler.

bug 25822: DOM normalize does not remove empty text node between element nodes
https://bugs.webkit.org/show_bug.cgi?id=25822

Test: fast/dom/Node/normalize.html

dom/Node.cpp: (WebCore::Node::normalize): Changed to remove any empty text nodes.

LayoutTests:

2009-05-17 Kai Brüning <kai@granus.net>

Reviewed by Darin Adler.

Test case for bug 25822: DOM normalize does not remove empty text node between element nodes
https://bugs.webkit.org/show_bug.cgi?id=25822

The test case strives to test the whole functionality of Node's normalize().

fast/dom/Node/normalize-expected.txt: Added.
fast/dom/Node/normalize.html: Added.

May 16, 2009:

8:44 PM Changeset in webkit [43808] by mrowe@apple.com

4 edits in trunk/WebCore

2009-05-16 Dave Moore <davemoore@google.com>

Reviewed by Darin Adler.

Allow Strings to be created with one malloc node with no copying
https://bugs.webkit.org/show_bug.cgi?id=25779

Add new methods to String and StringImpl, refactoring existing
methods in StringImpl to use new createUninitialized() method.

platform/text/PlatformString.h: (WebCore::String::createUninitialized):
platform/text/StringImpl.cpp: (WebCore::StringImpl::createUninitialized): (WebCore::StringImpl::create):
platform/text/StringImpl.h:

8:38 PM Changeset in webkit [43807] by mrowe@apple.com

2 edits in trunk/WebCore

<rdar://problem/6827041> WebCore should stop throwing away the CGImageSourceRef to
dramatically improve animated GIF decoding performance

Reviewed by Darin Adler.

Recent versions of ImageIO discard previously decoded image frames if the client
application no longer holds references to them, so there's no need to throw away
the decoder unless we're explicitly asked to destroy all of the frames.

This drops peak CPU usage when displaying <http://www.aintitcool.com/files/HoD2.gif>
from over 90% to below 3%.

platform/graphics/cg/ImageSourceCG.cpp:

(WebCore::ImageSource::clear):

2:51 PM Changeset in webkit [43806] by andersca@apple.com

4 edits in trunk/WebKit

WebKit:

2009-05-16 Anders Carlsson <andersca@apple.com>

Reviewed by Sam Weinig and Dan Bernstein.

Fix <rdar://problem/6889644>.

English.lproj/Localizable.strings:

WebKit/mac:

2009-05-16 Anders Carlsson <andersca@apple.com>

Reviewed by Sam Weinig and Dan Bernstein.

Fix <rdar://problem/6889644>

Plugins/Hosted/NetscapePluginHostManager.mm: (WebKit::NetscapePluginHostManager::spawnPluginHost):

1:21 PM Changeset in webkit [43805] by mitz@apple.com

9 edits in trunk/LayoutTests/platform/mac

Set the svn:mime-type property of recently-added PNG files to image/png

1:06 PM Changeset in webkit [43804] by mitz@apple.com

2 edits in trunk/WebKit/mac

revert an accidental change from r43802.

WebInspector/WebInspector.mm:

12:58 PM Changeset in webkit [43803] by andersca@apple.com

2 edits in trunk/WebKit/mac

2009-05-16 Anders Carlsson <andersca@apple.com>

Reviewed by Dan Bernstein.

<rdar://problem/6895347> Mouse wheeling in the QuickTime plug-in (incorrectly) scrolls the page

Fix logic. The plug-in returns true if it handled the event.

Plugins/WebNetscapePluginView.mm: (-[WebNetscapePluginView sendEvent:isDrawRect:]):

12:56 PM Changeset in webkit [43802] by mitz@apple.com

7 edits
2 adds in trunk

WebCore:

Reviewed by Alexey Proskuryakov.

fix <rdar://problem/6873305> Two distinct characters are not displayed correctly with 2 of the font selections from the stickies widget

Test: platform/mac/editing/pasteboard/text-precomposed.html

Ensure that "text/plain" data retrieved from the clipboard is always
precomposed. This makes Clipboard::getData() and
Pasteboard::documentFragment() consistent with Pasteboard::plainText()
and -[WebHTMLView _documentFragmentFromPasteboard:forType:inContext:subresources:].

platform/mac/ClipboardMac.mm: (WebCore::ClipboardMac::getData):
platform/mac/PasteboardMac.mm: (WebCore::Pasteboard::documentFragment):

WebKit/mac:

Reviewed by Alexey Proskuryakov.

fix <rdar://problem/6873305> Two distinct characters are not displayed correctly with 2 of the font selections from the stickies widget

WebView/WebHTMLView.mm: (-[WebHTMLView _plainTextFromPasteboard:]): Return precomposed text. This is consistent with -_documentFragmentFromPasteboard:forType:inContext:subresources:.

LayoutTests: