Context Navigation

It turns out the CurrentContext wasn't currect either because it gave
us the frame for the write() function itself. We actually want the
*calling* context.

bindings/v8/custom/V8HTMLDocumentCustom.cpp: (WebCore::CALLBACK_FUNC_DECL):

7:52 PM Changeset in webkit [43957] by kov@webkit.org

2 edits in trunk/LayoutTests

2009-05-20 Gustavo Noronha Silva <Gustavo Noronha Silva>

Skipping a new test.

platform/gtk/Skipped:

7:45 PM Changeset in webkit [43956] by kov@webkit.org

2 edits in trunk/LayoutTests

2009-05-20 Gustavo Noronha Silva <Gustavo Noronha Silva>

Skipping test that fails intermitently.

platform/gtk/Skipped:

7:43 PM Changeset in webkit [43955] by zecke@webkit.org

4 edits
1 add in trunk/WebCore

[GTK] Implement Image::loadPlatformResource.

Install the four resources we are using. For the icons
where an icon name is specified by freedeskop.org try to
map the WebCore name to that name and fallback to the
internal icon. For everything else use the internal icon
name. Remove the temporary link stub as this is not
required any more.

7:42 PM Changeset in webkit [43954] by zecke@webkit.org

2 edits in trunk/WebCore

[GTK] Gtk+ wants to have a themable urlIcon too.

https://bugs.webkit.org/show_bug.cgi?id=19357

7:41 PM Changeset in webkit [43953] by kov@webkit.org

1 edit
2 adds in trunk/LayoutTests

2009-05-20 Gustavo Noronha Silva <Gustavo Noronha Silva>

Rubber-stamped by Mark Rowe.

Add GTK+-specific results for canvas-composite-alpha. This test
has 'failing' cases that pass on GTK+/cairo.

platform/gtk/fast/canvas/canvas-composite-alpha-expected.txt: Added.

7:28 PM Changeset in webkit [43952] by ggaren@apple.com

2 edits in branches/nitro-extreme/JavaScriptCore

2009-05-20 Geoffrey Garen <ggaren@apple.com>

Reviewed by Sam Weinig.

Added support for inline subtraction of doubles.

jit/JITArithmetic.cpp: (JSC::JIT::emit_op_sub): (JSC::JIT::emitSlow_op_sub): (JSC::JIT::emitSlowSub32InPlaceLeft): (JSC::JIT::emitBinaryDoubleOp):

7:22 PM Changeset in webkit [43951] by Stephanie Lewis

6 edits in trunk

2009-05-20 Stephanie Lewis <Stephanie Lewis>

Update the order files. <rdar://problem/6881750> Generate new order files.

JavaScriptCore.order:

WebCore.order:
- WebKit.order:

7:19 PM Changeset in webkit [43950] by weinig@apple.com

9 edits in branches/nitro-extreme/JavaScriptCore

2009-05-20 Sam Weinig <sam@webkit.org>

Reviewed by Geoffrey Garen.

Added support for inline division.

assembler/X86Assembler.h: (JSC::X86Assembler::): (JSC::X86Assembler::divsd_rr): (JSC::X86Assembler::divsd_mr):
bytecode/CodeBlock.cpp: (JSC::CodeBlock::dump):
bytecode/Opcode.h:
bytecompiler/BytecodeGenerator.cpp: (JSC::BytecodeGenerator::emitBinaryOp):
interpreter/Interpreter.cpp: (JSC::Interpreter::privateExecute):
jit/JIT.cpp: (JSC::JIT::privateCompileMainPass): (JSC::JIT::privateCompileSlowCases):
jit/JIT.h:
jit/JITArithmetic.cpp: (JSC::JIT::emitBinaryDoubleOp): (JSC::JIT::emit_op_div): (JSC::JIT::emitSlow_op_div):

7:14 PM Changeset in webkit [43949] by mrowe@apple.com

3 edits in trunk/WebCore

Fix some assertion failures in plug-in tests on the Windows debug build bot.

Reviewed by Gavin Barraclough.

plugins/PluginStream.cpp:

(WebCore::PluginStream::startStream): Switch to using protocolIsJavaScript.

plugins/PluginView.cpp:

(WebCore::scriptStringIfJavaScriptURL): Ditto.

6:31 PM Changeset in webkit [43948] by ggaren@apple.com

2 edits in branches/nitro-extreme/JavaScriptCore

2009-05-20 Geoffrey Garen <ggaren@apple.com>

Reviewed by Sam Weinig.

Added support for inline addition of doubles.

jit/JITArithmetic.cpp: (JSC::JIT::emit_op_add): (JSC::JIT::emitSlow_op_add): (JSC::JIT::emitSlowAdd32InPlace): (JSC::JIT::emitBinaryDoubleOp): (JSC::JIT::emit_op_mul): (JSC::JIT::emitSlow_op_mul):

5:16 PM Changeset in webkit [43947] by ggaren@apple.com

3 edits in branches/nitro-extreme/JavaScriptCore

2009-05-20 Geoffrey Garen <ggaren@apple.com>

Reviewed by Sam Weinig.

Factored inline double operations into a helper function, so that we
can reuse this code for other math operations.

jit/JIT.h:
jit/JITArithmetic.cpp: (JSC::JIT::emitBinaryDoubleOp): (JSC::JIT::emit_op_mul):
jit/JITCall.cpp: (JSC::JIT::compileOpCallInitializeCallFrame):

4:58 PM Changeset in webkit [43946] by beidson@apple.com

4 edits in trunk

WebCore:

2009-05-20 Brady Eidson <beidson@apple.com>

Reviewed by Darin Adler.

More protocolInHTTPFamily() cleanup.

xml/XMLHttpRequest.cpp: (WebCore::XMLHttpRequest::send):

WebKit/win:

2009-05-20 Brady Eidson <beidson@apple.com>

Reviewed by Darin Adler.

More protocolInHTTPFamily() cleanup.

WebHistory.cpp: (WebHistory::visitedURL):

4:57 PM Changeset in webkit [43945] by ggaren@apple.com

5 edits in branches/nitro-extreme/JavaScriptCore

2009-05-20 Geoffrey Garen <ggaren@apple.com>

Reviewed by Sam Weinig.

Added support for inline multiplication of doubles.

assembler/X86Assembler.h: (JSC::X86Assembler::cvtsi2sd_mr): New function, useful for loading an int32 into a double register.

jit/JITArithmetic.cpp: (JSC::JIT::emit_op_mul): (JSC::JIT::emitSlow_op_mul): Filled out these cases for double arithmetic.

jit/JIT.h:
jit/JITInlineMethods.h: (JSC::JIT::addressFor): New function, useful for addressing a JSValue's full 64bits as a double.

4:57 PM Changeset in webkit [43944] by mrowe@apple.com

3 edits in trunk/WebKitSite

Prevent search engines from getting creative in their descriptions of webkit.org content.

Rubber-stamped by Eric Seidel.

blog/wp-content/themes/webkit/header.php:
header.inc:

4:37 PM Changeset in webkit [43943] by christian@webkit.org

2 edits in trunk/WebCore

2009-05-21 Christian Dywan <christian@twotoasts.de>

Reviewed by Jan Alonzo.

platform/network/soup/ResourceHandleSoup.cpp: (WebCore::parseDataUrl): Always use Glib Base64 decoding.

4:36 PM Changeset in webkit [43942] by weinig@apple.com

2 edits in trunk/WebCore

2009-05-20 Sam Weinig <sam@webkit.org>

Reviewed by Oliver Hunt.

Fix for <rdar://problem/6905475>
Office 2008: Entourage: Crash when you switch to "My Day" view

The host function callback callObjCFallbackObject was not annotated
with JSC_HOST_CALL which meant that when it was called by the JIT, which
expects the JSC_HOST_CALL calling convention, the arguments are not in the
expected places.

bridge/objc/objc_runtime.mm: (JSC::Bindings::callObjCFallbackObject): Added missing JSC_HOST_CALL annotation on callObjCFallbackObject.

4:32 PM Changeset in webkit [43941] by levin@chromium.org

2 edits in trunk/WebCore

2009-05-20 David Levin <levin@chromium.org>

Not Reviewed, build fix.

Need to disable this assert while the chormium code is fixed for it.

platform/KURLGoogle.cpp: (WebCore::KURL::protocolIs):

4:13 PM Changeset in webkit [43940] by ddkilzer@apple.com

1 edit in trunk/LayoutTests/ChangeLog

Added bugs.webkit.org URL

4:09 PM Changeset in webkit [43939] by ddkilzer@apple.com

2 edits
3 adds in trunk/LayoutTests

Test for <rdar://problem/5666078> Cookie parsing terminates at the first semicolon, ignoring quotes (16699)

Reviewed by Brady Eidson.

http/tests/cookies/double-quoted-value-with-semi-colon-expected.txt: Added.
http/tests/cookies/double-quoted-value-with-semi-colon.html: Added.
http/tests/cookies/resources/double-quoted-value-with-semi-colon.js: Added.
platform/mac-tiger/Skipped: Added double-quoted-value-with-semi-colon.html since CFNetwork on Tiger stops parsing cookie values when it sees a semi-colon, even inside double quotes.

4:01 PM Changeset in webkit [43938] by levin@chromium.org

2 edits in trunk/WebCore

2009-05-20 David Levin <levin@chromium.org>

Not Reviewed, build fix.

Change KURLGoogle.cpp to mirror the KURL.cpp changes done in
http://trac.webkit.org/changeset/43929. Fix assert placement.

platform/KURLGoogle.cpp: (WebCore::KURL::protocolIs): (WebCore::protocolIs):

3:35 PM Changeset in webkit [43937] by beidson@apple.com

2 edits in trunk/WebKit/mac

2009-05-20 Brady Eidson <beidson@apple.com>

Reviewed by Darin Adler.

<rdar://problem/6905336> REGRESSION: "Clear History" does not save empty history to disk

History/WebHistory.mm: (-[WebHistoryPrivate data]): If there are no entries, return an empty NSData instead of nil.

3:26 PM Changeset in webkit [43936] by levin@chromium.org

2 edits in trunk/WebCore

2009-05-20 Nate Chapin <japhet@google.com>

Reviewed by Dimitri Glazkov.

Upstream V8 bindings for V8DomWindow.
https://bugs.webkit.org/show_bug.cgi?id=25869

bindings/v8/custom/V8DOMWindowCustom.cpp: (WebCore::V8Custom::WindowSetTimeoutImpl): Moved from v8_custom.cpp. (WebCore::isAscii): Moved from v8_custom.cpp. (WebCore::convertBase64): Moved from v8_custom.cpp. (WebCore::CALLBACK_FUNC_DECL): Moved from v8_custom.cpp. (WebCore::eventNameFromAttributeName): Moved from v8_custom.cpp. (WebCore::ACCESSOR_SETTER): Moved from v8_custom.cpp. (WebCore::ACCESSOR_GETTER): Moved from v8_custom.cpp. (WebCore::NAMED_ACCESS_CHECK): Moved from v8_custom.cpp. (WebCore::INDEXED_ACCESS_CHECK): Moved from v8_custom.cpp.

3:18 PM Changeset in webkit [43935] by christian@webkit.org

2 edits in trunk/WebCore

2009-05-21 Christian Dywan <christian@twotoasts.de>

Rubberstamped by Gustavo Noronha.

platform/network/curl/ResourceHandleManager.cpp: (WebCore::parseDataUrl): Remove Gtk/ Glib Base64 decoding.

3:04 PM Changeset in webkit [43934] by christian@webkit.org

2 edits
2 deletes in trunk/WebCore

2009-05-20 Christian Dywan <christian@twotoasts.de>

Reviewed by Gustavo Noronha.

GNUmakefile.am:
platform/gtk/guriescape.c:
platform/gtk/guriescape.h: Remove copies of g_uri_escape_string and g_uri_unescape_string now that we require Glib 2.16.

1:55 PM Changeset in webkit [43933] by levin@chromium.org

2 edits in trunk/WebCore

2009-05-20 David Levin <levin@chromium.org>

Not Reviewed, build fix.

Change KURLGoogle.cpp to mirror changes done in
http://trac.webkit.org/changeset/43929.

platform/KURLGoogle.cpp: (WebCore::protocolIsJavaScript): (WebCore::protocolIs):

12:53 PM Changeset in webkit [43932] by beidson@apple.com

5 edits in trunk/WebCore

2009-05-20 Brady Eidson <beidson@apple.com>

Rubberstamped by Sam Weinig

At all call sites that check if a KURL has either the http or https protocol,
use the KURL::protocolInHTTPFamily() accessor, instead.

loader/FrameLoader.cpp: (WebCore::FrameLoader::iconURL): (WebCore::FrameLoader::didOpenURL): (WebCore::FrameLoader::open):

loader/appcache/ApplicationCache.cpp: (WebCore::ApplicationCache::requestIsHTTPOrHTTPSGet):

loader/loader.cpp: (WebCore::Loader::load):

xml/XMLHttpRequest.cpp: (WebCore::XMLHttpRequest::send):

12:39 PM Changeset in webkit [43931] by andersca@apple.com

2 edits in trunk/WebKit/mac

2009-05-20 Anders Carlsson <andersca@apple.com>

Reviewed by Darin Adler and Kevin Decker.

WebKit side of <rdar://problem/6895072>

Pass the localization as a launch property.

Plugins/Hosted/NetscapePluginHostManager.mm: (WebKit::NetscapePluginHostManager::spawnPluginHost):

12:36 PM Changeset in webkit [43930] by beidson@apple.com

1 edit in trunk/WebCore/ChangeLog

Fix ChangeLog typo

12:31 PM Changeset in webkit [43929] by beidson@apple.com

13 edits
2 adds in trunk

WebCore:

2009-05-20 Brady Eidson <beidson@apple.com>

Reviewed by Darin Adler.

Fix <rdar://problem/6904941> and https://bugs.webkit.org/show_bug.cgi?id=25300

KURL parsing changes back in r30243 and r30815 made javascript urls that use the form
"javascript://" be detected as invalid hierarchical URLs. When a KURL is marked as
invalid, you can no longer ask it a question such as "is your protocol javascript?"
Therefore FrameLoader wouldn't recognize them as javascript URLs and instead try to
navigated to them.

URL parsing rules aside, such URLs are in use in the wild (Microsoft's Virtual Earth
being a high profile example) and actually represent valid javascript.

Whenever checking for javascript urls, the new protocolIsJavaScript() should be used
as it functions on a String which doesn't have to pass KURLs parsing rules.

Test: fast/loader/javascript-url-hierarchical-execution.html

bindings/js/JSAttrCustom.cpp: (WebCore::JSAttr::setValue): Use protocolIsJavaScript().
bindings/js/JSDOMWindowCustom.cpp: (WebCore::JSDOMWindow::setLocation): Ditto. (WebCore::createWindow): Ditto. (WebCore::JSDOMWindow::open): Ditto.
bindings/js/JSElementCustom.cpp: (WebCore::allowSettingSrcToJavascriptURL): Ditto.
bindings/js/JSHTMLFrameElementCustom.cpp: (WebCore::allowSettingJavascriptURL): Ditto.
bindings/js/JSHTMLIFrameElementCustom.cpp: (WebCore::JSHTMLIFrameElement::setSrc): Ditto.
bindings/js/JSLocationCustom.cpp: (WebCore::navigateIfAllowed): Ditto. (WebCore::JSLocation::reload): Ditto.
editing/markup.cpp: (WebCore::appendQuotedURLAttributeValue): Ditto.
html/HTMLAnchorElement.cpp: (WebCore::HTMLAnchorElement::parseMappedAttribute): Ditto.
loader/FrameLoader.cpp: (WebCore::FrameLoader::requestFrame): Ditto. (WebCore::FrameLoader::submitForm): Ditto. (WebCore::FrameLoader::executeIfJavaScriptURL): Ditto.

platform/KURL.cpp: (WebCore::KURL::init): Use protocolIsJavaScript(). (WebCore::KURL::protocolIs): ASSERT that the protocol being asked about is not javascript.

Such checks should go through protocolIsJavaScript() instead.

(WebCore::encodeRelativeString): Use protocolIsJavaScript().
(WebCore::protocolIsJavaScript):

platform/KURL.h:

LayoutTests:

2009-05-20 Brady Eidson <beidson@apple.com>

Reviewed by Darin Adler.

Fix <rdar://problem/6904941> and https://bugs.webkit.org/show_bug.cgi?id=25300

fast/loader/javascript-url-hierarchical-execution-expected.txt: Added.
fast/loader/javascript-url-hierarchical-execution.html: Added.

12:30 PM Changeset in webkit [43928] by mrowe@apple.com

4 edits in branches/WWDC-2009-branch

Versioning.

12:29 PM Changeset in webkit [43927] by mrowe@apple.com

1 copy in tags/Safari-6530.11

New tag.

12:27 PM Changeset in webkit [43926] by mrowe@apple.com

4 edits in trunk

Versioning.

12:21 PM Changeset in webkit [43925] by mrowe@apple.com

2 edits in branches/WWDC-2009-branch/JavaScriptCore

Merge r43886.

12:21 PM Changeset in webkit [43924] by mrowe@apple.com

3 edits in branches/WWDC-2009-branch/JavaScriptCore

Merge r43885.

10:35 AM Changeset in webkit [43923] by zecke@webkit.org

6 edits
2 adds in trunk

[plugins] PluginPackage*.cpp for Gtk+/Qt misassigned hasproperty and hasmethod

https://bugs.webkit.org/show_bug.cgi?id=24510

PluginPackageGtk.cpp and PluginPackageQt.cpp assigned _NPN_HasMethod
to hasproperty and _NPN_HasProperty to hashmethod. This commit is fixing
it. It is also adding test code to PluginObject.cpp and it will invoke
this code from a new test.

10:31 AM Changeset in webkit [43922] by weinig@apple.com

6 edits in trunk/WebCore

2009-05-20 Sam Weinig <sam@webkit.org>

Reviewed by Timothy Hatcher.

Make absoluteRectsForRange and absoluteQuadsForRange non-virtual
and only exist on RenderText.

dom/Range.cpp: (WebCore::Range::textRects):
inspector/InspectorController.cpp: (WebCore::InspectorController::drawNodeHighlight): Use absoluteQuads instead of absoluteQuadsForRange since no range is being specifiec.
rendering/RenderObject.cpp:
rendering/RenderObject.h:
rendering/RenderText.h:

10:05 AM Changeset in webkit [43921] by mitz@apple.com

2 edits in trunk/WebKit/mac

fix the build after r43918

WebCoreSupport/WebChromeClient.h: (WebChromeClient::setCursor):

9:59 AM Changeset in webkit [43920] by xan@webkit.org

4 edits in trunk/WebCore

2009-05-20 Xan Lopez <xlopez@igalia.com>

Reviewed by Gustavo Noronha.

Implement AtkObject::focus-event and
AtkObject::state-changed:focused signal emission.

Adds a new handleFocusedUIElementChangedWithRenderers, only in the
GTK port, called at the same point than
handleFocusedUIElementChanged but with two parameters, the old and
the newly focused RenderObjects. We need this, since the ATK
signals require us to pass the objects involved in the focus
change as arguments.

accessibility/AXObjectCache.h:
accessibility/gtk/AXObjectCacheAtk.cpp: (WebCore::AXObjectCache::handleFocusedUIElementChangedWithRenderers):
dom/Document.cpp: (WebCore::Document::setFocusedNode):

9:23 AM Changeset in webkit [43919] by ariya@webkit.org

4 edits
3 adds in trunk/WebKit/qt

2009-05-20 Ariya Hidayat <ariya.hidayat@nokia.com>

Reviewed by Simon Hausmann and Holger Freyther.

[Qt] Add renderHints property to QWebView.

Api/qwebview.cpp: (QWebViewPrivate::QWebViewPrivate): (QWebView::renderHints): (QWebView::setRenderHints): (QWebView::setRenderHint): (QWebView::paintEvent):
Api/qwebview.h:
tests/qwebview/qwebview.pro: Added.
tests/qwebview/tst_qwebview.cpp: Added. (tst_QWebView::tst_QWebView): (tst_QWebView::~tst_QWebView): (tst_QWebView::init): (tst_QWebView::cleanup): (tst_QWebView::renderHints):
tests/tests.pro:

9:04 AM Changeset in webkit [43918] by zecke@webkit.org

15 edits in trunk

[architecture] Make ChromeClient a interface again

https://bugs.webkit.org/show_bug.cgi?id=25834

With recent additions to ChromeClient.h empty defaults were
added. This is bad for porters as these changes go unnoticed
and at runtime no notImplemented warning is logged and grepping
for notImplemented will not show anything. Change this Client
to be like the other Clients again and always have pure virtuals
(but for stuff inside #ifdef PLATFORM(MAC)).

Update the various WebKit/* implementations to compile again.

8:34 AM Changeset in webkit [43917] by Simon Hausmann

2 edits in trunk/WebKit/qt

2009-05-19 Kenneth Rohde Christiansen <kenneth.christiansen@openbossa.org>

Reviewed by Simon Hausmann.

Fix a plugin bug in the WebKit code, similar to the one in WebCore.

The problem is when a non visible QtPluginWidget would show it self
in a sibling frame. The problem was due to our clipping. In Qt,
if setMask is set with an empty QRegion, no clipping will
be performed, so in that case we hide the PluginContainer

8:34 AM Changeset in webkit [43916] by Simon Hausmann

2 edits
2 adds in trunk/WebCore

2009-05-19 Kenneth Rohde Christiansen <kenneth.christiansen@openbossa.org>

Reviewed by Simon Hausmann.

Fix a bug where a non visible plugin would show it self in a
sibling frame. The problem was due to our clipping. In Qt,
if setMask is set with an empty QRegion, no clipping will
be performed, so in that case we hide the PluginContainer

Added manual test.

8:32 AM Changeset in webkit [43915] by Simon Hausmann

2 edits in trunk/WebCore

2009-05-19 Kenneth Rohde Christiansen <kenneth.christiansen@openbossa.org>

Reviewed by Simon Hausmann.

Do not call the parent implementation (Widget::) in show() and hide()
of the PluginViewQt, as it always changes the visible state of the
platformWidget (equal to the platformPluginWidget in the Qt port),
thus ignoring the isParentVisible() test.

8:26 AM Changeset in webkit [43914] by Simon Hausmann

2 edits in trunk/JavaScriptCore

2009-05-19 Kenneth Rohde Christiansen <kenneth.christiansen@openbossa.org>

Reviewed by Simon Hausmann.

Replace WREC with YARR + YARR_JIT for the Qt port. This is only
used when compiled with JIT support for now, so it is a drop-in
replacement for the WREC usage. Still including the wrec headers
as they are being referred from RegExp.h, though the contents of
that header it protected by "#if ENABLE(WREC)".

8:08 AM Changeset in webkit [43913] by staikos@webkit.org

5 edits in trunk/WebCore

2009-05-20 Yichao Yin <yichao.yin@torchmobile.com.cn>

Reviewed by George Staikos.

https://bugs.webkit.org/show_bug.cgi?id=23452
Change the implementation of HTMLNoScriptElement to avoid the pain of
adding virtual function for XHTMLMP support

Includes changes suggested by Simon Fraser.

8:06 AM Changeset in webkit [43912] by Darin Adler

2 edits in trunk/WebKit/mac

2009-05-20 Darin Adler <Darin Adler>

Reviewed by John Sullivan.

<rdar://problem/4023899> Shift-Tab skips key views in toolbar in Safari, although Tab
iterates through them properly

WebView/WebView.mm: (-[WebView previousValidKeyView]): Work around a bug in -[NSView previousValidKeyView].

8:00 AM Changeset in webkit [43911] by kevino@webkit.org

2 edits in trunk/WebCore

CURL backend build fix. Make sure URL is always set.

7:54 AM Changeset in webkit [43910] by ariya@webkit.org

2 edits in trunk/WebCore

2009-05-20 Yongjun Zhang <yongjun.zhang@nokia.com>

Reviewed by George Staikos.

Fix Qt WebKit build break in Mac OS.

platform/FileSystem.h:

7:51 AM Changeset in webkit [43909] by kov@webkit.org

2 edits in trunk/WebCore

2009-05-20 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>

Rubber-stamped by Eric Seidel.

Enable code that was commented out waiting for a way to get a
GdkPixbuf from an image, effectively enabling copying images to
the clipboard.

platform/gtk/PasteboardGtk.cpp: (WebCore::Pasteboard::writeImage):

7:33 AM Changeset in webkit [43908] by xan@webkit.org

2 edits in trunk/WebCore

2009-05-20 Xan Lopez <xlopez@igalia.com>

Reviewed by Jan Alonzo.

https://bugs.webkit.org/show_bug.cgi?id=25414
[GTK] ROLE_PANEL should not be used for paragraphs and list items.

Implement Atk list item role for list items.

accessibility/gtk/AccessibilityObjectWrapperAtk.cpp: (webkit_accessible_get_role):

7:33 AM Changeset in webkit [43907] by xan@webkit.org

2 edits in trunk/WebCore

2009-05-20 Xan Lopez <xlopez@igalia.com>

Reviewed by Jan Alonzo.

https://bugs.webkit.org/show_bug.cgi?id=25414
[GTK] ROLE_PANEL should not be used for paragraphs and list items.

Implement Atk paragraph role for paragraph elements.

accessibility/gtk/AccessibilityObjectWrapperAtk.cpp: (webkit_accessible_get_role):

5:42 AM Changeset in webkit [43906] by eric@webkit.org

2 edits in trunk

2009-05-20 Eric Seidel <eric@webkit.org>

Fix bug URL in ChangeLogs in r43903.
https://bugs.webkit.org/show_bug.cgi?id=25742

5:37 AM Changeset in webkit [43905] by eric@webkit.org

1 edit in trunk/LayoutTests/ChangeLog

2009-05-20 Eric Seidel <eric@webkit.org>

No review, build fix only.

Add files I missed in r43903.

Takeshi's patch was right, I just failed to add the files when landing.

platform/mac/fast/forms/search-styled-expected.checksum: Added.
platform/mac/fast/forms/search-styled-expected.png: Added.

5:37 AM Changeset in webkit [43904] by eric@webkit.org

2 adds in trunk/LayoutTests/platform/mac/fast/forms

Add files I missed in r43903

5:33 AM Changeset in webkit [43903] by eric@webkit.org

6 edits in trunk

2009-05-20 Takeshi Yoshino <tyoshino@google.com>

Reviewed by Eric Seidel.

Bug 24539: Fix RenderThemeChromiumWin::paintTextFieldInternal() not to hide background image.
https://bugs.webkit.org/show_bug.cgi?id=24539

Fix RenderThemeChromiumWin::paintTextFieldInternal().

We shouldn't paint the content area of text fields when o->style() has
background image or transparent background color. paintTextFieldInternal() is
used for painting inner area of HTML option elements by Chromium.

When we pass fillContentArea = true to ChromiumBridge::paintTextField, it hides
the background image rendered by RenderBoxModelObject. So, we should set
fillContentArea = false in such case.

Besides, when background-color:transparent is specified for CSS property,
o->style().backgroundColor returns black color with alpha channel == 0. But
since ThemeEngine for Windows behind ChromiumBridge::paintTextField cannot
recognize alpha channel, it fills the rect with black. I made workaround to set
fillContentArea = false when alpha channel == 0 to avoid this.

And more, I'd like to fallback the color passed to ChromiumBridge to white when
o->style()->backgroundColor() is invalid.

rendering/RenderThemeChromiumWin.cpp: (WebCore::RenderThemeChromiumWin::paintTextFieldInternal):

5:26 AM Changeset in webkit [43902] by eric@webkit.org

3 edits
2 adds in trunk

2009-05-20 Shinichiro Hamaji <hamaji@google.com>

Reviewed by Eric Seidel.

https://bugs.webkit.org/show_bug.cgi?id=25417
Map CompositeCopy to Skia's kSrc_Mode composite operation.

Test: fast/canvas/canvas-composite-alpha.html

platform/graphics/skia/SkiaUtils.cpp: (WebCore::):

4:38 AM Changeset in webkit [43901] by xan@webkit.org

2 edits in trunk/JavaScriptCore

2009-05-20 Xan Lopez <xlopez@igalia.com>

Reviewed by Eric Seidel.

Fix GTK debug build.

The function dumpDisjunction, compiled with debug enabled, uses
printf, which needs stdio.h to be included.

yarr/RegexInterpreter.cpp:

4:30 AM Changeset in webkit [43900] by jmalonzo@webkit.org

2 edits in trunk/WebCore

2009-05-20 Jan Michael Alonzo <jmalonzo@webkit.org>

Rubber-stamped by Xan Lopez.

Remove misplaced extern "C"

accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:

4:16 AM Changeset in webkit [43899] by jmalonzo@webkit.org

2 edits in trunk/WebCore

2009-05-20 Jan Michael Alonzo <jmalonzo@webkit.org>

Reviewed by Xan Lopez.

[GTK] Expose password field with role of PASSWORD_TEXT
https://bugs.webkit.org/show_bug.cgi?id=25682

Check if input type is a password field and return
ATK_ROLE_PASSWORD_TEXT if it is.

accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:

3:09 AM Changeset in webkit [43898] by ariya@webkit.org

2 edits in trunk/WebCore

2009-05-20 Laszlo Gombos <Laszlo Gombos>

Reviewed by George Staikos.

BUG 25845: [Qt] Fix QtWebKit pkgconfig dependencies
<https://bugs.webkit.org/show_bug.cgi?id=25845>

WebCore.pro: Remove QtDBus; remove QtXml if Qt >= 4.4

3:08 AM Changeset in webkit [43897] by eric@webkit.org

3 edits
1 delete in trunk/LayoutTests

2009-05-20 Eric Seidel <eric@webkit.org>

Build fix only, no review.

Remove dragging subtest from 43890 which used ? char

? is a reserved char on Windows. After removing both the ü and now the ? this
subtest is now useless, so I'm removing it entirely.

editing/pasteboard/file-input-files-access-expected.txt:
editing/pasteboard/resources/File With Spaces! For Dragging?.gif: Removed.
editing/pasteboard/resources/file-input-files-access.js: (runTest):

2:58 AM Changeset in webkit [43896] by ariya@webkit.org

7 edits in trunk

2009-05-20 Laszlo Gombos <Laszlo Gombos>

Reviewed by George Staikos.

BUG 25843: [Qt] Remove qt-port build flag
<https://bugs.webkit.org/show_bug.cgi?id=25843>

bridge/testbindings.pro:

JavaScriptCore.pro:

DumpRenderTree/qt/DumpRenderTree.pro:
Scripts/webkitdirs.pm:

2:49 AM Changeset in webkit [43895] by eric@webkit.org

3 edits
1 move in trunk/LayoutTests

2009-05-20 Eric Seidel <eric@webkit.org>

Build fix only, no review.

Fix windows and tiger builds after r43890

Commit r43890 caused:
svn: Can't convert string from 'UTF-8' to native encoding:
svn: LayoutTests/editing/pasteboard/resources/File With Spaces! For Dra?\204?\136gging?.gif
On both the windows and tiger buildbots. According to:
http://svnbook.red-bean.com/en/1.2/svn.advanced.l10n.html
this is intentional behavior, and due to the fact that the default
LC_CTYPE for Tiger and Windows makes Subversion think the filesystems
do not support utf8.

The fix would be to execute:
export LC_CTYPE=en_US.UTF-8
On all affected machines. But since that's not going to happen,
I'm removing the utf8 chars from this filename.

This makes the drag-drop test weaker, but I see no other option.

editing/pasteboard/resources/File With Spaces! For Dragging?.gif: Renamed from "LayoutTests/editing/pasteboard/resources/File With Spaces! For Dra\314\210gging?.gif".
editing/pasteboard/resources/file-input-files-access.js: (moveMouseToCenterOfElement): use the unused argument (runTest): fix to use the ansii name

2:02 AM Changeset in webkit [43894] by ariya@webkit.org

2 edits in trunk/WebCore

2009-05-20 Laszlo Gombos <Laszlo Gombos>

Reviewed by George Staikos.

https://bugs.webkit.org/show_bug.cgi?id=25824

[Qt] Cleanup - move files exclusive to JAVASCRIPT_DEBUGGER
and WORKERS under the appropriate build section

WebCore.pro:

1:40 AM Changeset in webkit [43893] by ariya@webkit.org

2 edits in trunk/WebCore

2009-05-20 Ariya Hidayat <ariya.hidayat@nokia.com>

Unreviewed Qt build fix, after r43892.

platform/graphics/qt/ImageQt.cpp: included ImageObservser.h

1:22 AM Changeset in webkit [43892] by Simon Hausmann

2 edits in trunk/WebCore

2009-05-20 Yongjun Zhang <yongjun.zhang@nokia.com>

Reviewed by Simon Hausmann.

https://bugs.webkit.org/show_bug.cgi?id=25856
[Qt] notify an image has been drawn, to help Cache purge alive decoded data.

12:32 AM Changeset in webkit [43891] by Darin Adler

1 edit
1 delete in trunk/LayoutTests

2009-05-20 Darin Adler <Darin Adler>

Removed stray file left after some check-ins earlier today.

fast/tokenizer/preload-scanner-entities.html-disabled: Removed.

12:32 AM Changeset in webkit [43890] by eric@webkit.org

11 edits
8 adds
4 deletes in trunk

2009-05-18 Eric Seidel <eric@webkit.org>

Reviewed by Oliver Hunt.

Remove layoutTestController.addFileToPasteboardOnDrag and add eventSender.beginDragWithFiles
https://bugs.webkit.org/show_bug.cgi?id=25852

This allows us to now test multi-file file drags in DumpRenderTree per:
https://bugs.webkit.org/show_bug.cgi?id=25862

I removed the existing tests using addFileToPasteboardOnDrag()
and replaced them with a new test (editing/pasteboard/file-input-files-access)
which covers several more drag-drop cases.

I added a DumpRenderTreeFileDraggingSource class to avoid
the hack of if (!draggingSource) in [DumpRenderTreeDraggingInfo draggingSourceOperationMask]

New Test: editing/pasteboard/file-input-files-access.html

DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
DumpRenderTree/DumpRenderTreeFileDraggingSource.h: Added.
DumpRenderTree/DumpRenderTreeFileDraggingSource.m: Added. (-[DumpRenderTreeFileDraggingSource draggingSourceOperationMaskForLocal:]):
DumpRenderTree/LayoutTestController.cpp: (LayoutTestController::LayoutTestController): (LayoutTestController::staticValues): removed addFileToPasteboardOnDrag support (LayoutTestController::staticFunctions): removed addFileToPasteboardOnDrag support
DumpRenderTree/LayoutTestController.h:
DumpRenderTree/mac/DumpRenderTree.mm: (runTest): ASSERT that draggingInfo has been cleared
DumpRenderTree/mac/EventSendingController.mm: (+[EventSendingController isSelectorExcludedFromWebScript:]): Sorted selectors. (+[EventSendingController webScriptNameForSelector:]): Sorted selectors. (-[EventSendingController beginDragWithFiles:]): (-[EventSendingController mouseMoveToX:Y:]): (-[EventSendingController keyDown:withModifiers:]): (-[EventSendingController fireKeyboardEventsToElement:]): removed spurious { }
DumpRenderTree/mac/UIDelegate.mm: (-[UIDelegate webView:dragImage:at:offset:event:pasteboard:source:slideBack:forView:]): removed addFileToPasteboardOnDrag support

12:24 AM Changeset in webkit [43889] by levin@chromium.org

7 edits in trunk/WebCore

2009-05-20 David Levin <levin@chromium.org>

Reviewed by NOBODY, layout tests fix.

https://bugs.webkit.org/show_bug.cgi?id=23727
This reverts commit r43888.

Once that change was checked in many of the fast/flexbox0*.html
tests (and others) started failing.

WebCore.pro:
css/CSSParser.cpp: (WebCore::CSSParser::parseValue):
css/CSSPropertyNames.in:
css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::applyProperty):
css/CSSValueKeywords.in:
rendering/RenderMarquee.cpp: (WebCore::RenderMarquee::updateMarqueePosition): (WebCore::RenderMarquee::timerFired):

May 19, 2009:

9:32 PM Changeset in webkit [43888] by staikos@webkit.org

7 edits in trunk/WebCore

2009-05-19 Yichao Yin <yichao.yin@torchmobile.com.cn>

Reviewed by George Staikos.

Add WCSS marquee extension support to Webkit
refer to the specification: WAP-239-WCSS-20011026-a.pdf

Since WCSS is the companion of XHTML Mobile Profile (XHTML MP),
this change depends on https://bugs.webkit.org/show_bug.cgi?id=23452

https://bugs.webkit.org/show_bug.cgi?id=23727

8:49 PM Changeset in webkit [43887] by staikos@webkit.org

5 edits
5 adds in trunk/LayoutTests

2009-05-19 Yichao Yin <yichao.yin@torchmobile.com.cn>

Reviewed by George Staikos.

Add tests for WCSS marquee extension support
https://bugs.webkit.org/show_bug.cgi?id=23727

8:31 PM Changeset in webkit [43886] by ggaren@apple.com

2 edits in trunk/JavaScriptCore

2009-05-19 Geoffrey Garen <ggaren@apple.com>

Windows build fix.

interpreter/RegisterFile.cpp: (JSC::RegisterFile::releaseExcessCapacity): Copy-paste typo.

8:25 PM Changeset in webkit [43885] by ggaren@apple.com

3 edits in trunk/JavaScriptCore

2009-05-19 Geoffrey Garen <ggaren@apple.com>

Reviewed by Sam Weinig.

Fixed <rdar://problem/6885680> CrashTracer: [USER] 1 crash in Install
Mac OS X at <unknown binary> • 0x9274241c

(Original patch by Joe Sokol and Ronnie Misra.)

SunSpider says 1.004x faster.

interpreter/RegisterFile.cpp: (JSC::RegisterFile::releaseExcessCapacity): Instead of doing complicated math that sometimes used to overflow, just release the full range of the register file.

interpreter/RegisterFile.h: (JSC::isPageAligned): (JSC::RegisterFile::RegisterFile): Added ASSERTs to verify that it's safe to release the full range of the register file.

(JSC::RegisterFile::shrink): No need to releaseExcessCapacity() if the
new end is not smaller than the old end. (Also, doing so used to cause
numeric overflow, unmapping basically the whole process from memory.)

8:02 PM Changeset in webkit [43884] by eric@webkit.org

2 edits in trunk/BugsSite

2009-05-19 Eric Seidel <eric@webkit.org>

Reviewed by Adam Roben.

Make PrettyPatch understand quoted filenames in git diffs.
https://bugs.webkit.org/show_bug.cgi?id=25881

PrettyPatch/PrettyPatch.rb:

7:33 PM Changeset in webkit [43883] by weinig@apple.com

5 edits in branches/nitro-extreme/JavaScriptCore

2009-05-19 Sam Weinig <sam@webkit.org>

Reviewed by Geoffrey Garen.

Implement and enable optimized calls.

jit/JIT.cpp: (JSC::JIT::privateCompileCTIMachineTrampolines): Add ENABLE(JIT_OPTIMIZE_CALL) guards around the the optimize call only trampolines (virtualCallPreLink and virtualCallLink). Update the trampolines to account for the new JSValue representation. (JSC::JIT::unlinkCall): Use NULL instead of JSValue noValue.

jit/JITCall.cpp: (JSC::JIT::compileOpCall): Update to account for the new JSValue representation (JSC::JIT::compileOpCallSlowCase): Ditto.

jit/JITStubs.h: Remove incorrect !ENABLE(JIT_OPTIMIZE_CALL) guard.

wtf/Platform.h: Enable ENABLE_JIT_OPTIMIZE_CALL.

7:02 PM Changeset in webkit [43882] by staikos@webkit.org

5 edits in trunk/WebCore

2009-05-19 Yichao Yin <yichao.yin@torchmobile.com.cn>

Reviewed by George Staikos.

Add XHTMLMP support to Webkit
Update the configure files for building XHTMLMP-enabled WebKit on different platform
https://bugs.webkit.org/show_bug.cgi?id=23452

6:18 PM Changeset in webkit [43881] by oliver@apple.com

3 edits in trunk/JavaScriptCore

<rdar://problem/6888393> REGRESSION: Start Debugging JavaScript crashes browser (nightly builds only?)
<https://bugs.webkit.org/show_bug.cgi?id=25717>

RS=Mark Rowe.

Remove JSC_FAST_CALL as it wasn't gaining us anything, and was
resulting in weird bugs in the nightly builds.

5:44 PM Changeset in webkit [43880] by Antti Koivisto

2 edits
1 add
1 delete in trunk

WebCore:

2009-05-19 Antti Koivisto <Antti Koivisto>

I can't figure out how to make this not timing dependent, making it manual test instead.

manual-tests/preload-scanner-entities.html: Added.

LayoutTests:

2009-05-19 Antti Koivisto <Antti Koivisto>

I can't figure out how to make this not timing dependent, making it manual test instead.

fast/tokenizer/preload-scanner-entities-expected.txt: Removed.
fast/tokenizer/preload-scanner-entities.html: Removed.

5:43 PM Changeset in webkit [43879] by Darin Adler

1 edit
1 move in trunk/LayoutTests

2009-05-19 Darin Adler <Darin Adler>

Renamed test failing on many buildbots to disable it.
Antti can move it back once he gets it working more consistently.

fast/tokenizer/preload-scanner-entities.html: Removed.
fast/tokenizer/preload-scanner-entities.html-disabled: Copied from fast/tokenizer/preload-scanner-entities.html.

4:41 PM Changeset in webkit [43878] by beidson@apple.com

4 edits in trunk/WebCore

2009-05-19 Brady Eidson <beidson@apple.com>

Reviewed by Antti Koivisto.

<rdar://problem/6886382> REGRESSION (Safari 4PB -> ToT): HTTP cache revalidation broken.

This was caused in http://trac.webkit.org/changeset/41425, which fixed an image caching bug
in QuickLooks (rdar://problem/6619630).

We need to respect the DocumentLoader's request cache policy when deciding the cache policy
for subresources, but the check (originally removed in r39304 and added back in in the same
place in r41424) needs to be tweaked and relocated a bit.

loader/FrameLoader.cpp: (WebCore::FrameLoader::subresourceCachePolicy): Renamed from cachePolicy(). Move checking the DocumentLoader's request to a more appropriate place. Add code to handle the recently added FIXME regarding POSTs. Add a new FIXME describing a great way to make this code cleaner in the future.
loader/FrameLoader.h:

loader/DocLoader.cpp: (WebCore::DocLoader::cachePolicy): Calls the newly renamed subresourceCachePolicy().

3:31 PM Changeset in webkit [43877] by Chris Fleizach

5 edits
2 adds in trunk

Bug 25872: aria-labeledby appends all siblings instead of all children to aria name
https://bugs.webkit.org/show_bug.cgi?id=25872

2:57 PM Changeset in webkit [43876] by Antti Koivisto

3 edits
2 adds in trunk

WebCore:

2009-05-19 Antti Koivisto <Antti Koivisto>

Reviewed by Darin Adler).

<rdar://problem/6902674> REGRESSION: Query parameters are sometimes incorrect in URL (23135)

Push characters back in correct order when entity parsing fails after 3 characters.

Test: fast/tokenizer/preload-scanner-entities.html

html/PreloadScanner.cpp: (WebCore::PreloadScanner::consumeEntity):

LayoutTests:

2009-05-19 Antti Koivisto <Antti Koivisto>

Reviewed by Darin Adler.

<rdar://problem/6902674> REGRESSION: Query parameters are sometimes incorrect in URL (23135)

fast/tokenizer/preload-scanner-entities-expected.txt: Added.
fast/tokenizer/preload-scanner-entities.html: Added.

2:53 PM Changeset in webkit [43875] by weinig@apple.com

12 edits in branches/nitro-extreme/JavaScriptCore

2009-05-19 Sam Weinig <sam@webkit.org>

Reviewed by Geoffrey Garen.

Implement and enable optimized property access.

assembler/AbstractMacroAssembler.h: Fix comment.
jit/JIT.cpp: (JSC::JIT::privateCompileCTIMachineTrampolines): Remove array length trampoline and implement the string length trampoline.
jit/JIT.h: Add new constants for patch offsets.
jit/JITInlineMethods.h: Remove FIELD_OFFSET which is now in StdLibExtras.h.
jit/JITPropertyAccess.cpp: (JSC::JIT::emit_op_get_by_id): (JSC::JIT::emitSlow_op_get_by_id): (JSC::JIT::emit_op_put_by_id): (JSC::JIT::emitSlow_op_put_by_id): (JSC::JIT::compilePutDirectOffset): (JSC::JIT::compileGetDirectOffset): (JSC::JIT::privateCompilePutByIdTransition): (JSC::JIT::patchGetByIdSelf): (JSC::JIT::patchPutByIdReplace): (JSC::JIT::privateCompilePatchGetArrayLength): (JSC::JIT::privateCompileGetByIdProto): (JSC::JIT::privateCompileGetByIdSelfList): (JSC::JIT::privateCompileGetByIdProtoList): (JSC::JIT::privateCompileGetByIdChainList): (JSC::JIT::privateCompileGetByIdChain):
jit/JITStubCall.h: (JSC::JITStubCall::addArgument): Add version of addArgument that takes two registers for the tag and payload.
jit/JITStubs.cpp: (JSC::JITStubs::JITStubs): Remove array length trampoline pointer. (JSC::JITStubs::cti_op_get_by_id_self_fail):
jit/JITStubs.h:
runtime/JSObject.h: (JSC::JSObject::JSObject): Move m_inheritorID below the property storage to align it to a 16 byte boundary.
wtf/Platform.h: Enable ENABLE_JIT_OPTIMIZE_PROPERTY_ACCESS
wtf/StdLibExtras.h: Move FIELD_OFFSET here.

2:13 PM Changeset in webkit [43874] by Dimitri Glazkov

2 edits in trunk/WebCore

2009-05-19 Paul Godavari <paul@chromium.org>

Reviewed by Dimitri Glazkov.

Fix a crash in Mac Chromium when displaying an HTML select element
with no items.
https://bugs.webkit.org/show_bug.cgi?id=25874

platform/chromium/PopupMenuChromium.cpp: (WebCore::PopupContainer::showExternal):

1:54 PM Changeset in webkit [43873] by kevino@webkit.org

3 edits in trunk/WebKitTools

wxMSW build fixes for DRT.

1:53 PM Changeset in webkit [43872] by darin@chromium.org

1 edit in trunk/WebCore/ChangeLog

Restore mistaken deletion of an entry in ChangeLog

1:51 PM Changeset in webkit [43871] by darin@chromium.org

2 edits in trunk/WebCore

2009-05-19 Nate Chapin <japhet@google.com>

Reviewed by Darin Fisher.

Upstream V8 bindings for CanvasRenderingContext2D.
https://bugs.webkit.org/show_bug.cgi?id=25858

bindings/v8/custom/V8CanvasRenderingContext2DCustom.cpp: Moved bindings from v8_custom.cpp.

1:46 PM Changeset in webkit [43870] by mrowe@apple.com

2 edits in trunk/WebCore

2009-05-19 Jessie Berlin <jberlin@apple.com>

Reviewed by Mark Rowe.

Windows Build Fix.

WebCore.vcproj/WebCore.vcproj: Copy accessibility headers from WebCore.

12:18 PM Changeset in webkit [43869] by timothy@apple.com

5 edits in trunk

Add a new private API method that will dispatch pending loads that have been scheduled because of recent DOM additions or style changes.

<rdar://problem/6889218> REGRESSION: Some iChat transcript resources are not loaded because willSendRequest doesn't happen immediately

WebCore:

2009-05-19 Timothy Hatcher <timothy@apple.com>

<rdar://problem/6889218> REGRESSION: Some iChat transcript resources are not
loaded because willSendRequest doesn't happen immediately

Reviewed by Antti Koivisto.

WebCore.base.exp: Export Loader::servePendingRequests().

WebKit/mac:

2009-05-19 Timothy Hatcher <timothy@apple.com>

Add a new private API method that will dispatch pending loads that have been scheduled
because of recent DOM additions or style changes.

<rdar://problem/6889218> REGRESSION: Some iChat transcript resources are not
loaded because willSendRequest doesn't happen immediately

Reviewed by Antti Koivisto.

WebView/WebView.mm: (-[WebView _dispatchPendingLoadRequests]): Call Loader::servePendingRequests().
WebView/WebViewPrivate.h: Added _dispatchPendingLoadRequests.

12:08 PM Changeset in webkit [43868] by levin@chromium.org

2 edits in trunk/WebCore

2009-05-19 David Levin <levin@chromium.org>

Reviewed by Dimitri Glazkov.

Bug 25859: Need to upstream ScriptController.* for v8.
https://bugs.webkit.org/show_bug.cgi?id=25859

Fixing the header file (which I accidentally made identical to the cpp file).

bindings/v8/ScriptController.h:

11:54 AM Changeset in webkit [43867] by ap@webkit.org

1 edit in trunk/WebCore/ChangeLog

Adding a Radar URL.

11:14 AM Changeset in webkit [43866] by ap@webkit.org

3 edits in trunk/WebCore

Reviewed by Darin Adler and Brady Eidson.

REGRESSION (r42446?): UA Profiler in http://stevesouders.com/ua/ stalls

The problem was that Document::removeAllEventListeners() was called for a wrong document
when a CachedFrame was destroyed.

Cannot be tested automatically, because DRT doesn't have a b/f cache.

dom/Document.cpp: (WebCore::Document::domWindow): Make sure that this doesn't return an unrelated window even if document's m_frame pointer is stale.

history/CachedFrame.cpp: (WebCore::CachedFrame::clear): Added a FIXME about strange behavior.

10:53 AM Changeset in webkit [43865] by staikos@webkit.org

5 edits
6 adds in trunk/LayoutTests

2009-05-19 Yichao Yin <yichao.yin@torchmobile.com.cn>

Reviewed by George Staikos.

Add the XHTML MP tests but put them in skipped since they are not active
by default on any platforms.
https://bugs.webkit.org/show_bug.cgi?id=23452

9:58 AM Changeset in webkit [43864] by Dimitri Glazkov

16 edits
2 adds in trunk/WebCore

2009-05-19 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Split InspectorController into InspectorController and InspectorFrontend. Latter encapsulates all frontend interaction and is the only entity allowed to make ScriptFunctionCalls. The further plan is to serialize these script function calls.

https://bugs.webkit.org/show_bug.cgi?id=25419

GNUmakefile.am:
WebCore.pro:
WebCore.vcproj/WebCore.vcproj:
WebCore.xcodeproj/project.pbxproj:
WebCoreSources.bkl:
inspector/ConsoleMessage.cpp: (WebCore::ConsoleMessage::addToConsole):
inspector/ConsoleMessage.h:
inspector/InspectorController.cpp: (WebCore::InspectorController::~InspectorController): (WebCore::InspectorController::inspect): (WebCore::InspectorController::focusNode): (WebCore::InspectorController::setWindowVisible): (WebCore::InspectorController::addConsoleMessage): (WebCore::InspectorController::setAttachedWindow): (WebCore::InspectorController::inspectedWindowScriptObjectCleared): (WebCore::InspectorController::scriptObjectReady): (WebCore::InspectorController::showPanel): (WebCore::InspectorController::close): (WebCore::InspectorController::populateScriptObjects): (WebCore::InspectorController::resetScriptObjects): (WebCore::InspectorController::pruneResources): (WebCore::InspectorController::didCommitLoad): (WebCore::InspectorController::didLoadResourceFromMemoryCache): (WebCore::InspectorController::identifierForInitialRequest): (WebCore::InspectorController::willSendRequest): (WebCore::InspectorController::didReceiveResponse): (WebCore::InspectorController::didReceiveContentLength): (WebCore::InspectorController::didFinishLoading): (WebCore::InspectorController::didFailLoading): (WebCore::InspectorController::resourceRetrievedByXMLHttpRequest): (WebCore::InspectorController::scriptImported): (WebCore::InspectorController::didOpenDatabase): (WebCore::InspectorController::didUseDOMStorage): (WebCore::InspectorController::addScriptProfile): (WebCore::InspectorController::toggleRecordButton): (WebCore::InspectorController::enableProfiler): (WebCore::InspectorController::disableProfiler): (WebCore::InspectorController::enableDebugger): (WebCore::InspectorController::disableDebugger): (WebCore::InspectorController::didParseSource): (WebCore::InspectorController::failedToParseSource): (WebCore::InspectorController::didPause): (WebCore::InspectorController::didContinue):
inspector/InspectorController.h:
inspector/InspectorDOMStorageResource.cpp: (WebCore::InspectorDOMStorageResource::bind):
inspector/InspectorDOMStorageResource.h:
inspector/InspectorDatabaseResource.cpp: (WebCore::InspectorDatabaseResource::bind):
inspector/InspectorDatabaseResource.h:
inspector/InspectorFrontend.cpp: Added. (WebCore::callSimpleFunction): (WebCore::InspectorFrontend::InspectorFrontend): (WebCore::InspectorFrontend::~InspectorFrontend): (WebCore::InspectorFrontend::newJSONObject): (WebCore::InspectorFrontend::addMessageToConsole): (WebCore::InspectorFrontend::addResource): (WebCore::InspectorFrontend::updateResource): (WebCore::InspectorFrontend::removeResource): (WebCore::InspectorFrontend::updateFocusedNode): (WebCore::InspectorFrontend::setAttachedWindow): (WebCore::InspectorFrontend::inspectedWindowScriptObjectCleared): (WebCore::InspectorFrontend::showPanel): (WebCore::InspectorFrontend::populateInterface): (WebCore::InspectorFrontend::reset): (WebCore::InspectorFrontend::debuggerWasEnabled): (WebCore::InspectorFrontend::debuggerWasDisabled): (WebCore::InspectorFrontend::profilerWasEnabled): (WebCore::InspectorFrontend::profilerWasDisabled): (WebCore::InspectorFrontend::parsedScriptSource): (WebCore::InspectorFrontend::failedToParseScriptSource): (WebCore::InspectorFrontend::addProfile): (WebCore::InspectorFrontend::setRecordingProfile): (WebCore::InspectorFrontend::pausedScript): (WebCore::InspectorFrontend::resumedScript): (WebCore::InspectorFrontend::addDatabase): (WebCore::InspectorFrontend::addDOMStorage):
inspector/InspectorFrontend.h: Added.
inspector/InspectorResource.cpp: (WebCore::InspectorResource::createScriptObject): (WebCore::InspectorResource::updateScriptObject): (WebCore::InspectorResource::releaseScriptObject):
inspector/InspectorResource.h:

9:50 AM Changeset in webkit [43863] by mrowe@apple.com

9 moves in branches/old

Clean up some old, unused branches.

9:47 AM Changeset in webkit [43862] by mrowe@apple.com

1 copy in branches/WWDC-2009-branch

New branch.

9:45 AM Changeset in webkit [43861] by Dimitri Glazkov

10 edits
1 copy
1 add in trunk/WebCore

2009-05-19 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Introduce JSONObject that wraps ScriptObject and ScriptState* for further serialization

https://bugs.webkit.org/show_bug.cgi?id=25419

GNUmakefile.am:
WebCore.pro:
WebCore.vcproj/WebCore.vcproj:
WebCore.xcodeproj/project.pbxproj:
WebCoreSources.bkl:
inspector/ConsoleMessage.cpp: (WebCore::ConsoleMessage::addToConsole):
inspector/InspectorDOMStorageResource.cpp: (WebCore::InspectorDOMStorageResource::bind):
inspector/InspectorDatabaseResource.cpp: (WebCore::InspectorDatabaseResource::bind):
inspector/InspectorResource.cpp: (WebCore::populateHeadersObject): (WebCore::InspectorResource::createScriptObject): (WebCore::InspectorResource::updateScriptObject):
inspector/JSONObject.cpp: Added. (WebCore::JSONObject::JSONObject): (WebCore::JSONObject::set): (WebCore::JSONObject::scriptObject): (WebCore::JSONObject::createNew):
inspector/JSONObject.h: Added.

9:36 AM Changeset in webkit [43860] by staikos@webkit.org

1 edit in trunk/WebCore/ChangeLog

Correct two changelog entries to show the bug report

9:08 AM Changeset in webkit [43859] by Dimitri Glazkov

11 edits in trunk/WebCore

2009-05-19 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Refactor InpectorController so that it does not instantiate resource/console/database/domresource javascript objects. Move instantiation into the javascript.

https://bugs.webkit.org/show_bug.cgi?id=25419

inspector/ConsoleMessage.cpp: (WebCore::ConsoleMessage::addToConsole):
inspector/InspectorController.cpp: (WebCore::InspectorController::didReceiveResponse): (WebCore::InspectorController::didReceiveContentLength): (WebCore::InspectorController::didFinishLoading): (WebCore::InspectorController::didFailLoading): (WebCore::InspectorController::resourceRetrievedByXMLHttpRequest): (WebCore::InspectorController::scriptImported):
inspector/InspectorDOMStorageResource.cpp: (WebCore::InspectorDOMStorageResource::InspectorDOMStorageResource): (WebCore::InspectorDOMStorageResource::bind): (WebCore::InspectorDOMStorageResource::unbind):
inspector/InspectorDOMStorageResource.h:
inspector/InspectorDatabaseResource.cpp: (WebCore::InspectorDatabaseResource::InspectorDatabaseResource): (WebCore::InspectorDatabaseResource::bind): (WebCore::InspectorDatabaseResource::unbind):
inspector/InspectorDatabaseResource.h:
inspector/InspectorResource.cpp: (WebCore::InspectorResource::InspectorResource): (WebCore::populateHeadersObject): (WebCore::InspectorResource::createScriptObject): (WebCore::InspectorResource::updateScriptObject): (WebCore::InspectorResource::releaseScriptObject):
inspector/InspectorResource.h:
inspector/front-end/Console.js: (WebInspector.ConsoleMessage):
inspector/front-end/inspector.js: (WebInspector.addResource): (WebInspector.updateResource): (WebInspector.removeResource): (WebInspector.addDatabase): (WebInspector.addDOMStorage): (WebInspector.reset): (WebInspector.addMessageToConsole):

8:11 AM Changeset in webkit [43858] by ariya@webkit.org

4 edits in trunk/WebCore

2009-05-19 Kenneth Rohde Christiansen <kenneth.christiansen@openbossa.org>

Reviewed by Ariya Hidayat.

The Qt port has code that disables scrolling optimizations
when the root contains native windows, such as windowed plugins.

This code broke when detaching iframes containing windowed
plugins.

Each ScrollView now knows how many native windows it and its
children contain, and when it is detached, that number is
substracted from its old parents.

4:45 AM Changeset in webkit [43857] by xan@webkit.org

2 edits in trunk/WebKit/gtk

2009-05-19 Xan Lopez <xlopez@igalia.com>

Reviewed by Jan Alonzo.

Do not try to free enchant broker and dictionary if they do not
exist, those functions aren't NULL-safe.

webkit/webkitwebsettings.cpp: (free_spell_checking_language):

1:01 AM Changeset in webkit [43856] by mjs@apple.com

4 edits in trunk/JavaScriptCore

2009-05-19 Maciej Stachowiak <mjs@apple.com>

Reviewed by Gavin Barraclough.

speed up string comparison, especially for short strings

~1% on SunSpider

JavaScriptCore.exp:
runtime/UString.cpp:
runtime/UString.h: (JSC::operator==): Inline UString's operator==, since it is called from hot places in the runtime. Also, specialize 2-char strings in a similar way to 1-char, since we're taking the hit of a switch anyway.

Note: See TracTimeline for information about the timeline view.

Download in other formats:

RSS Feed