⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



May 25, 2009:

11:20 PM Changeset in webkit [44147] by ap@webkit.org
  • 3 edits in trunk/WebCore

Reviewed by Darin Adler.

<rdar://problem/6918671> REGRESSION (r41700): Crashes in debug DumpRenderTree at RefCountedBase::ref().

  • dom/QualifiedName.cpp: (WebCore::QualifiedName::QualifiedName):
  • dom/QualifiedName.h: (WebCore::QualifiedName::QualifiedNameImpl::QualifiedNameImpl): Adjust empty namespace before QNameComponentsTranslator black magic, not after.
11:03 PM Changeset in webkit [44146] by ggaren@apple.com
  • 3 edits
    3 adds in branches/nitro-extreme

JavaScriptCore:

2009-05-25 Geoffrey Garen <​ggaren@apple.com>

Reviewed by Maciej Stachowiak.


Fixed a regression when comparing to NaN.

  • jit/JITArithmetic.cpp: (JSC::JIT::emitBinaryDoubleOp): For op_jnless and op_jnless_eq, do the comparison in reverse order, and jump if the result is below or below-or-equal. This ensures that we do jump in the case of NaN.

LayoutTests:

2009-05-25 Geoffrey Garen <​ggaren@apple.com>

Reviewed by Maciej Stachowiak.


Added test for NaN comparisons.


  • fast/js/nan-expected.txt: Added.
  • fast/js/nan.html: Added.
  • fast/js/resources/nan.js: Added. ():
9:21 PM Changeset in webkit [44145] by levin@chromium.org
  • 8 edits
    5 adds in trunk

JavaScriptCore:

2009-05-25 David Levin <​levin@chromium.org>

Reviewed by Maciej Stachowiak and Oliver Hunt.

​https://bugs.webkit.org/show_bug.cgi?id=25126
Allow the buffer underlying UString to be shared.

In order to not grow the underlying size of any structure,
there is a union in the Rep string which holds

+ m_sharedBuffer -- a pointer to the shared ref counted buffer

if the class is BaseString and the buffer is being shared OR

+ m_baseString -- the BaseString if the class is only UString::Rep

but not a UString::BaseString

Ideally, m_sharedBuffer would be a RefPtr, but it cannot be because
it is in a union.

No change in sunspider perf.

  • JavaScriptCore.vcproj/WTF/WTF.vcproj:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • runtime/UString.cpp: (JSC::UString::Rep::share): (JSC::UString::Rep::destroy): (JSC::UString::BaseString::sharedBuffer): (JSC::UString::BaseString::setSharedBuffer): (JSC::UString::BaseString::slowIsBufferReadOnly): (JSC::expandCapacity): (JSC::UString::Rep::reserveCapacity): (JSC::UString::expandPreCapacity): (JSC::concatenate): (JSC::UString::append):
  • runtime/UString.h: (JSC::UString::Rep::Rep): (JSC::UString::Rep::): (JSC::UString::BaseString::isShared): (JSC::UString::BaseString::isBufferReadOnly): (JSC::UString::Rep::baseString):
  • wtf/CrossThreadRefCounted.h: (WTF::CrossThreadRefCounted::isShared):
  • wtf/OwnFastMallocPtr.h: Added. (WTF::OwnFastMallocPtr::OwnFastMallocPtr): (WTF::OwnFastMallocPtr::~OwnFastMallocPtr): (WTF::OwnFastMallocPtr::get): (WTF::OwnFastMallocPtr::release):

JavaScriptGlue:

2009-05-25 David Levin <​levin@chromium.org>

Reviewed by Maciej Stachowiak and Oliver Hunt.

​https://bugs.webkit.org/show_bug.cgi?id=25126

Added forwarding headers.

  • ForwardingHeaders/wtf/CrossThreadRefCounted.h: Added.
  • ForwardingHeaders/wtf/OwnFastMallocPtr.h: Added.

WebCore:

2009-05-25 David Levin <​levin@chromium.org>

Reviewed by Maciej Stachowiak and Oliver Hunt.

Added forwarding headers.

  • ForwardingHeaders/wtf/CrossThreadRefCounted.h: Added.
  • ForwardingHeaders/wtf/OwnFastMallocPtr.h: Added.
9:00 PM Changeset in webkit [44144] by ggaren@apple.com
  • 2 edits in branches/nitro-extreme/JavaScriptCore

2009-05-25 Geoffrey Garen <​ggaren@apple.com>

Reviewed by Oliver Hunt.


SunSpider says no change.


Fixed regressions in fast/js/var-declarations-shadowing.html and
fast/js/equality.html, caused by recent == and != optimizations.

  • jit/JITStubs.cpp: (JSC::JITStubs::cti_op_eq): Don't treat "compare to string" as always numeric or string comparison. If the second operand is an object, you need to ToPrimitive it, and start all over again. Also, I wrote out each of the possible cases explicitly, to cut down on redundant branching.
5:20 PM Changeset in webkit [44143] by oliver@apple.com
  • 2 edits in trunk/JavaScriptCore

Re-add interpreter logic to jit-enabled builds as GCC mysteriously regresses without it

Reviewed by Maciej Stachowiak

5:08 PM Changeset in webkit [44142] by weinig@apple.com
  • 2 edits in branches/nitro-extreme/JavaScriptCore

2009-05-25 Sam Weinig <​sam@webkit.org>

Reviewed by Mark Rowe.

Fix bug in fast/js/constant-folding.html where we were not negating
-0 properly.

  • jit/JITArithmetic.cpp: (JSC::JIT::emit_op_negate):
4:52 PM Changeset in webkit [44141] by mrowe@apple.com
  • 15 edits in branches/WWDC-2009-branch

Merge r44136.

4:52 PM Changeset in webkit [44140] by mrowe@apple.com
  • 2 edits in branches/WWDC-2009-branch/WebKit/mac

Merge r44132.

4:52 PM Changeset in webkit [44139] by mrowe@apple.com
  • 3 edits
    2 adds in branches/WWDC-2009-branch

Merge r44075.

4:52 PM Changeset in webkit [44138] by mrowe@apple.com
  • 2 edits in branches/WWDC-2009-branch/WebKit/mac

Merge r44069.

4:51 PM Changeset in webkit [44137] by mrowe@apple.com
  • 2 edits in branches/WWDC-2009-branch/WebCore

Merge r44066.

3:48 PM Changeset in webkit [44136] by andersca@apple.com
  • 15 edits in trunk

WebCore:

2009-05-25 Anders Carlsson <​andersca@apple.com>

Reviewed by Sam Weinig.

  • WebCore side of <rdar://problem/6914001>.

Add a new m_allowPopupsFromPlugin flag.


  • bindings/js/ScriptController.cpp: (WebCore::ScriptController::ScriptController): (WebCore::ScriptController::processingUserGesture):
  • bindings/js/ScriptController.h: (WebCore::ScriptController::setAllowPopupsFromPlugin): (WebCore::ScriptController::allowPopupsFromPlugin):

WebKit/mac:

2009-05-25 Anders Carlsson <​andersca@apple.com>

Reviewed by Sam Weinig.

  • WebKit side of <rdar://problem/6914001>.
  • Plugins/Hosted/NetscapePluginHostManager.h:
  • Plugins/Hosted/NetscapePluginHostManager.mm: (WebKit::NetscapePluginHostManager::didCreateWindow): Iterate over all plug-in hosts. If one is in full-screen mode, make sure to activate the WebKit app instead.


  • Plugins/Hosted/NetscapePluginHostProxy.h: (WebKit::NetscapePluginHostProxy::isMenuBarVisible): Add getter.


  • Plugins/Hosted/NetscapePluginHostProxy.mm: (WKPCEvaluate): Add allowPopups flag.


  • Plugins/Hosted/NetscapePluginInstanceProxy.h:
  • Plugins/Hosted/NetscapePluginInstanceProxy.mm: (WebKit::NetscapePluginInstanceProxy::PluginRequest::PluginRequest): (WebKit::NetscapePluginInstanceProxy::PluginRequest::allowPopups): (WebKit::NetscapePluginInstanceProxy::loadURL): (WebKit::NetscapePluginInstanceProxy::evaluateJavaScript): (WebKit::NetscapePluginInstanceProxy::loadRequest): (WebKit::NetscapePluginInstanceProxy::evaluate): Use "allowPopups" instead of "userGesture".


  • Plugins/Hosted/WebKitPluginClient.defs: Add allowPopups argument to Evaluate.


  • Plugins/Hosted/WebKitPluginHostTypes.h: Use "allowPopups" instead of "userGesture".
  • WebCoreSupport/WebChromeClient.mm: (WebChromeClient::createWindow): Call didCreateWindow here.


  • WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::dispatchCreatePage): Ditto.
2:33 PM Changeset in webkit [44135] by abarth@webkit.org
  • 10 edits
    8 adds in trunk

WebCore:

2009-05-25 Adam Barth <​abarth@webkit.org>

Reviewed by Sam Weinig.

​https://bugs.webkit.org/show_bug.cgi?id=26006

Sort out our use of dynamicGlobalObject and lexicalGlobalObject for
window.location. The correct use appears to be as follows:

1) Use dynamicGlobalObject to find the user gesture.
2) Use dynamicGlobalObject to complete URLs.
3) Use lexicalGlobalObject to find the referrer.
4) Use lexicalGlobalObject for the frame navigation checks.
5) Use lexicalGlobalObject for the XSS checks.

Tests: http/tests/security/frameNavigation/context-for-location-assign.html

http/tests/security/frameNavigation/context-for-location-href.html
http/tests/security/frameNavigation/context-for-location.html

  • bindings/js/JSDOMBinding.cpp: (WebCore::shouldAllowNavigation): (WebCore::toLexicalFrame): (WebCore::processingUserGesture): (WebCore::completeURL):
  • bindings/js/JSDOMBinding.h:
  • bindings/js/JSDOMWindowCustom.cpp: (WebCore::JSDOMWindow::setLocation):
  • bindings/js/JSLocationCustom.cpp: (WebCore::navigateIfAllowed): (WebCore::JSLocation::setHref): (WebCore::JSLocation::replace): (WebCore::JSLocation::reload): (WebCore::JSLocation::assign): (WebCore::JSLocation::toString): (WebCore::JSLocationPrototype::customPut):
  • bindings/v8/V8Utilities.cpp: (WebCore::processingUserGesture): (WebCore::shouldAllowNavigation): (WebCore::completeURL): (WebCore::navigateIfAllowed):
  • bindings/v8/V8Utilities.h:
  • bindings/v8/custom/V8DOMWindowCustom.cpp: (WebCore::V8Custom::WindowSetLocation):
  • bindings/v8/custom/V8LocationCustom.cpp: (WebCore::ACCESSOR_SETTER): (WebCore::CALLBACK_FUNC_DECL):

LayoutTests:

2009-05-25 Adam Barth <​abarth@webkit.og>

Reviewed by Sam Weinig.

​https://bugs.webkit.org/show_bug.cgi?id=26006

Test our use of dynamicGlobalObject and lexicalGlobalObject for
window.location.

  • http/tests/security/frameNavigation/context-for-location-assign-expected.txt: Added.
  • http/tests/security/frameNavigation/context-for-location-assign.html: Added.
  • http/tests/security/frameNavigation/context-for-location-expected.txt: Added.
  • http/tests/security/frameNavigation/context-for-location-href-expected.txt: Added.
  • http/tests/security/frameNavigation/context-for-location-href.html: Added.
  • http/tests/security/frameNavigation/context-for-location.html: Added.
  • http/tests/security/frameNavigation/resources/middle-frame-for-location.html: Added.
  • http/tests/security/frameNavigation/resources/target-for-location.html: Added.
2:11 PM Changeset in webkit [44134] by abarth@webkit.org
  • 2 edits in trunk/LayoutTests/http/tests/security/postMessage

Unreviewed attempt to fix flaky origin-follows-lexical-scope test. (Test only fails on buildbot.)

12:33 PM Changeset in webkit [44133] by abarth@webkit.org
  • 4 edits
    1 add in trunk/LayoutTests

2009-05-25 Adam Barth <​abarth@webkit.org>

Reviewed by Sam Weinig.

​https://bugs.webkit.org/show_bug.cgi?id=26011

Try to make test less flaky.

  • http/tests/security/postMessage/origin-follows-lexical-scope-expected.txt:
  • http/tests/security/postMessage/origin-follows-lexical-scope.html:
  • http/tests/security/postMessage/resources/middle-frame-for-lexical.html:
  • http/tests/security/postMessage/resources/post-message-listener-with-ready.html: Added.
11:48 AM Changeset in webkit [44132] by andersca@apple.com
  • 2 edits in trunk/WebKit/mac

2009-05-25 Anders Carlsson <​andersca@apple.com>

Reviewed by Sam Weinig.

  • Fix <rdar://problem/6915849>.


Release the placeholder window after -[NSApplication runModalForWindow] returns.


  • Plugins/Hosted/NetscapePluginHostProxy.mm: (WebKit::NetscapePluginHostProxy::beginModal): (WebKit::NetscapePluginHostProxy::endModal):
8:41 AM Changeset in webkit [44131] by xan@webkit.org
  • 2 edits in trunk/JavaScriptCore

2009-05-25 Fridrich Strba <​fridrich.strba@bluewin.ch>

Reviewed by Maciej Stachowiak.

The functions written in assembly need to have a leading
underscore on Windows too.

  • jit/JITStubs.cpp:
8:41 AM Changeset in webkit [44130] by xan@webkit.org
  • 3 edits in trunk/WebCore

2009-05-25 Fridrich Strba <​fridrich.strba@bluewin.ch>

Reviewed by Maciej Stachowiak.

With Windows compilers older then MSVC 2005, the functions
gmtime_s and localtime_s don't exist. The gmtime and localtime are
on Windows always thread safe. So use them in the cases where
gmtime_s and localtime_s are not present.

  • loader/FTPDirectoryDocument.cpp:
  • loader/FTPDirectoryParser.cpp:
5:55 AM Changeset in webkit [44129] by Simon Hausmann
  • 2 edits in trunk/WebCore

2009-05-25 Holger Hans Peter Freyther <​zecke@selfish.org>

Reviewed by Simon Hausmann.

Follow up on r44120. PluginPackageMac.cpp is used
by Qt on Mac and contained a copy of the m_browserFunc
assignments and ::equal, ::hash and ::compareFileVersion.
Change it to use the ones from PluginPackage.cpp as well.

5:39 AM Changeset in webkit [44128] by Simon Hausmann
  • 3 edits in trunk/WebCore

2009-05-25 Simon Hausmann <​simon.hausmann@nokia.com>

Reviewed by Tor Arne Vestbø.

​https://bugs.webkit.org/show_bug.cgi?id=25612

Support conditionals in the tag factories, by placing
feature #ifdefs around the individual factory functions
and the registration.

Made the Audio and Video elements conditional in the tag factories

4:45 AM Changeset in webkit [44127] by Simon Hausmann
  • 2 edits in trunk/WebCore

2009-05-25 Simon Hausmann <​simon.hausmann@nokia.com>

Fix the Gtk build when video is disabled.

4:35 AM Changeset in webkit [44126] by Simon Hausmann
  • 2 edits in trunk/WebCore

2009-05-25 Simon Hausmann <​simon.hausmann@nokia.com>

Fix the Qt build when video is disabled.

  • WebCore.pro: Always generate the IDL files for the media elements. They contain proper ENABLE(VIDEO) #ifdefs.
1:36 AM Changeset in webkit [44125] by abarth@webkit.org
  • 1 edit in trunk/WebCore/ChangeLog

Fix ChangeLog typo.

1:29 AM Changeset in webkit [44124] by abarth@webkit.org
  • 4 edits
    3 adds in trunk

WebCore:

2009-05-25 Adam Barth <​abarth@webkit.org>

Reviewed by Maciej Stachowiak.

​https://bugs.webkit.org/show_bug.cgi?id=26004

The origin for postMessage should follow lexical scope, not dynamic
scope. Yes, this is a super-obscure conner case.

Test: http/tests/security/postMessage/origin-follows-lexical-scope.html

  • bindings/js/JSDOMWindowCustom.cpp: (WebCore::JSDOMWindow::postMessage):
  • bindings/v8/custom/V8DOMWindowCustom.cpp: (WebCore::CALLBACK_FUNC_DECL):

LayoutTests:

2009-05-25 Adam Barth <​abarth@webkit.org>

Reviewed by Maciej Stachowiak.

​https://bugs.webkit.org/show_bug.cgi?id=26004

Test that the origin for postMessage follows the lexical scope.

  • http/tests/security/postMessage/origin-follows-lexical-scope-expected.txt: Added.
  • http/tests/security/postMessage/origin-follows-lexical-scope.html: Added.
  • http/tests/security/postMessage/resources/middle-frame-for-lexical.html: Added.

May 24, 2009:

11:27 PM Changeset in webkit [44123] by darin@chromium.org
  • 2 edits in trunk/WebCore

2009-05-24 Darin Fisher <​darin@chromium.org>

Reviewed by Mark Rowe.

Fix build bustage related to PassOwnPtr changes.

​https://bugs.webkit.org/show_bug.cgi?id=25999

  • platform/graphics/chromium/TransparencyWin.cpp:
10:20 PM Changeset in webkit [44122] by mitz@apple.com
  • 2 edits in trunk/WebKit/mac
  • revert an accidental change from r43964.
  • WebView/WebView.mm: (+[WebView _setShouldUseFontSmoothing:]):
8:29 PM Changeset in webkit [44121] by zecke@webkit.org
  • 2 edits in trunk/WebCore

2009-05-24 Holger Hans Peter Freyther <​zecke@selfish.org>

Reviewed by Maciej Stachowiak.

​https://bugs.webkit.org/show_bug.cgi?id=25988

Minor cleanup in PluginPackage::hash. Let the compiler
figure out the size of the array. Do not have it in the
definition and specially not the in the call to
StringImpl::hash.

  • plugins/PluginPackage.cpp: (WebCore::PluginPackage::hash):
8:29 PM Changeset in webkit [44120] by zecke@webkit.org
  • 6 edits in trunk/WebCore

2009-05-24 Holger Hans Peter Freyther <​zecke@selfish.org>

Reviewed by Maciej Stachowiak.

​https://bugs.webkit.org/show_bug.cgi?id=25988

Move ::hash, ::equal and ::compareFileVersion from
the duplicated copies in PluginPackageQt.cpp and
PluginPackageGtk to PluginPackage.cpp. We need to #ifdef
this for the PluginPackageWin version. Use the new style
ENABLE() for this feature/policy and enable it in the Gtk+
and Qt buildsystem.

  • GNUmakefile.am:
  • WebCore.pro:
  • plugins/PluginPackage.cpp: (WebCore::PluginPackage::hash): (WebCore::PluginPackage::equal): (WebCore::PluginPackage::compareFileVersion):
  • plugins/gtk/PluginPackageGtk.cpp:
  • plugins/qt/PluginPackageQt.cpp:
8:28 PM Changeset in webkit [44119] by zecke@webkit.org
  • 6 edits in trunk/WebCore

2009-05-24 Holger Hans Peter Freyther <​zecke@selfish.org>

Reviewed by Maciej Stachowiak.

​https://bugs.webkit.org/show_bug.cgi?id=25988

So far the initialization of the browserfuncs struct
is done in PluginPackageQt, PluginPackageGtk and
PluginPackageWin there is no need for this duplication.

The PluginPackageWin version got copied to PluginPackage

  • plugins/PluginPackage.cpp: (WebCore::PluginPackage::initializeBrowserFuncs):
  • plugins/PluginPackage.h:
  • plugins/gtk/PluginPackageGtk.cpp: (WebCore::PluginPackage::load):
  • plugins/qt/PluginPackageQt.cpp: (WebCore::PluginPackage::load):
  • plugins/win/PluginPackageWin.cpp: (WebCore::PluginPackage::load):
3:43 PM Changeset in webkit [44118] by krit@webkit.org
  • 5 edits
    5 adds in trunk/WebCore

2009-05-24 Dirk Schulze <​krit@webkit.org>

Reviewed by Nikolas Zimmermann.

WebKit needs cross-platform filter system
​https://bugs.webkit.org/show_bug.cgi?id=19991

Added standard input for filter system.

No testcases were added. Filter system is still off.

  • GNUmakefile.am:
  • WebCore.pro:
  • WebCore.xcodeproj/project.pbxproj:
  • platform/graphics/filters/SourceAlpha.cpp: Added. (WebCore::SourceAlpha::create): (WebCore::SourceAlpha::effectName): (WebCore::SourceAlpha::apply): (WebCore::SourceAlpha::dump):
  • platform/graphics/filters/SourceAlpha.h: Added. (WebCore::SourceAlpha::SourceAlpha):
  • platform/graphics/filters/SourceGraphic.cpp: Added. (WebCore::SourceGraphic::create): (WebCore::SourceGraphic::effectName): (WebCore::SourceGraphic::apply): (WebCore::SourceGraphic::dump):
  • platform/graphics/filters/SourceGraphic.h: Added. (WebCore::SourceGraphic::SourceGraphic):
  • svg/FilterBuilder.cpp: Added. (WebCore::FilterBuilder::FilterBuilder): (WebCore::FilterBuilder::add): (WebCore::FilterBuilder::getEffectById): (WebCore::FilterBuilder::clearEffects):
  • svg/FilterBuilder.h:
12:35 PM QtWebKitContrib edited by Simon Hausmann
(diff)
11:13 AM Changeset in webkit [44117] by sfalken@apple.com
  • 2 edits in trunk/JavaScriptCore

2009-05-24 Steve Falkenburg <​sfalken@apple.com>

Build fix for experimental PGO Windows target.


11:10 AM Changeset in webkit [44116] by Simon Hausmann
  • 3 edits in trunk/WebCore

2009-05-24 Simon Hausmann <​simon.hausmann@nokia.com>

Reviewed by Maciej Stachowiak.

​https://bugs.webkit.org/show_bug.cgi?id=25612

Add support conditionals in the JSC bindings generator code for attributes,
by placing feature #ifdefs around the setters/getters.

Made the audio and video element specific DOM attributes conditional
in the generated code, by moving the #ifdefs from the IDL files into
the generated code. This allows for re-using the same generated code
with or without ENABLE(VIDEO).

9:34 AM Changeset in webkit [44115] by Darin Adler
  • 2 edits in trunk/WebKit/mac

2009-05-24 Darin Adler <Darin Adler>

Reviewed by Dan Bernstein and Tim Hatcher.

<rdar://problem/6913045> New console message spewed by automator CLI after installing JetstreamLeo40B21a

  • Misc/WebNSObjectExtras.mm: (-[WebMainThreadInvoker initWithTarget:]): Tweaked argument name. (-[WebMainThreadInvoker forwardInvocation:]): Removed call to retainArguments. This was unneeded and in the case of a newly created but not yet fully initialized NSView object it caused the abovementioned bug. (-[WebMainThreadInvoker handleException:]): Tweaked argument name. Added assertion. (-[NSInvocation _webkit_invokeAndHandleException:]): Tweaked name of local variable that holds the exception.
8:34 AM Changeset in webkit [44114] by Darin Adler
  • 2 edits in trunk/WebKit

2009-05-24 Darin Adler <Darin Adler>

  • StringsNotToBeLocalized.txt: Updated for recent changes. Got rid of most full-file exceptions.
12:48 AM Changeset in webkit [44113] by xan@webkit.org
  • 2 edits in trunk/WebKit/gtk

2009-05-24 Xan Lopez <​xlopez@igalia.com>

Reviewed by Mark Rowe.

​https://bugs.webkit.org/show_bug.cgi?id=25987
[GTK] Clarify WebKitWebView::download-requested documentation

Explain a bit why this signal is not emitted by default and offer
a common solution/setup for that issue.

  • webkit/webkitwebview.cpp: (webkit_web_view_class_init):
Note: See TracTimeline for information about the timeline view.