⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



May 26, 2009:

11:53 PM Changeset in webkit [44181] by weinig@apple.com
  • 7 edits in trunk

WebCore:

2009-05-26 Sam Weinig <​sam@webkit.org>

Reviewed by Brady Eidson.

Fix for <rdar://problem/6916371>
iWeb 'Announce' button does nothing after publishing to MobileMe

Add ability to force content sniffing for all urls (including file: urls)

  • WebCore.base.exp:
  • platform/network/ResourceHandle.cpp: (WebCore::ResourceHandle::shouldContentSniffURL): (WebCore::ResourceHandle::forceContentSniffing):
  • platform/network/ResourceHandle.h:

WebKit/mac:

2009-05-26 Sam Weinig <​sam@webkit.org>

Reviewed by Brady Eidson.

Fix for <rdar://problem/6916371>
iWeb 'Announce' button does nothing after publishing to MobileMe

Add linked-on-or-after check to allow older WebKit apps to use the
old behavior of sniffing everything (including file: urls)

  • Misc/WebKitVersionChecks.h:
  • WebView/WebView.mm: (-[WebView _commonInitializationWithFrameName:groupName:usesDocumentViews:]):
11:35 PM Changeset in webkit [44180] by zecke@webkit.org
  • 5 edits
    1 add in trunk/WebKit/qt

2009-05-26 Benjamin C Meyer <​benjamin.meyer@torchmobile.com>

Reviewed by Holger Freyther.

​https://bugs.webkit.org/show_bug.cgi?id=25823

Add an API to generate a QUrl out of a string correcting for errors and missing information.
See the API documentation for more details about the function.

Autotests: included

  • Api/qwebview.cpp: (QWebView::guessUrlFromString):
  • Api/qwebview.h:
  • QtLauncher/main.cpp: (MainWindow::MainWindow): (MainWindow::changeLocation):
  • tests/qwebview/.gitignore: Added.
  • tests/qwebview/qwebview.pro:
  • tests/qwebview/tst_qwebview.cpp: (tst_QWebView::initTestCase): (tst_QWebView::cleanupTestCase): (tst_QWebView::init): (tst_QWebView::cleanup): (tst_QWebView::guessUrlFromString_data): (tst_QWebView::guessUrlFromString):
11:35 PM Changeset in webkit [44179] by zecke@webkit.org
  • 2 edits in trunk/WebCore

2009-05-26 Laszlo Gombos <Laszlo Gombos>

Reviewed by Holger Freyther.

​https://bugs.webkit.org/show_bug.cgi?id=25996

[Qt] Dead-code stripping for unix

  • WebCore.pro: Turn on GCC dead-code stripping flags for Unix
11:25 PM Changeset in webkit [44178] by Beth Dakin
  • 8 edits in branches/WWDC-2009-branch/WebCore

2009-05-26 Beth Dakin <Beth Dakin>

Rubber-stamped by Dan Bernstein and Darin Adler.

Fix for <rdar://problem/6922919> Revert back to Safari 3 text
control metrics calculations

We're rolling this change out of the branch because we think it
needs more bake time.

  • css/html4.css:
  • platform/graphics/SimpleFontData.cpp: (WebCore::SimpleFontData::SimpleFontData):
  • platform/graphics/SimpleFontData.h: (WebCore::SimpleFontData::lineGap):
  • platform/graphics/mac/SimpleFontDataMac.mm:
  • rendering/RenderTextControl.cpp: (WebCore::RenderTextControl::calcPrefWidths):
  • rendering/RenderTextControlMultiLine.cpp: (WebCore::RenderTextControlMultiLine::createInnerTextStyle):
  • rendering/RenderTextControlSingleLine.cpp: (WebCore::RenderTextControlSingleLine::preferredContentWidth):
10:25 PM Changeset in webkit [44177] by zecke@webkit.org
  • 6 edits in trunk/WebCore

[GTK] Send onscroll events for the main FrameView

2009-05-10 Holger Hans Peter Freyther <​zecke@selfish.org>

Reviewed by Dave Hyatt.

​https://bugs.webkit.org/show_bug.cgi?id=25646

[GTK] Send onscroll events for the main FrameView

WebKit/GTK+ is currently not sending any onscroll
events for a frame with external adjustments. This is
due the fact that the value-changed signal of the GtkAdjustment
is handled by WebCore::ScrollView directly and is not going through
the WebCore::Scrollbar -> WebCore::ScrollbarClient ->
WebCore::FrameView::valueChanged -> WebCore::ScrollView::valueChanged
path.

Fix the above problem by wrapping the GtkAdjustment we get
assigned from GTK+ in a ScrollbarGtk that will not have any
visual appearance. Remove code from ScrollView that knows
about adjustments and create a special case for
WebCore::ScrollView::createScrollbar that will create such
a special WebCore::ScrollbarGtk.

  • platform/ScrollView.cpp: Remove adjustment code (WebCore::ScrollView::setHasHorizontalScrollbar): (WebCore::ScrollView::setHasVerticalScrollbar): (WebCore::ScrollView::updateScrollbars): (WebCore::ScrollView::wheelEvent):
  • platform/ScrollView.h: Remove adjustment code
  • platform/gtk/ScrollViewGtk.cpp: (WebCore::ScrollView::platformDestroy): (WebCore::ScrollView::createScrollbar): (WebCore::ScrollView::setGtkAdjustments):
  • platform/gtk/ScrollbarGtk.cpp: (ScrollbarGtk::createScrollbar): Special case. (ScrollbarGtk::ScrollbarGtk): New ctor and work on the adjustment (ScrollbarGtk::~ScrollbarGtk): Disconnect signal (ScrollbarGtk::frameRectsChanged): Do nothing when we lack a platformWidget
  • platform/gtk/ScrollbarGtk.h:
10:20 PM Changeset in webkit [44176] by cwzwarich@webkit.org
  • 2 edits in trunk/WebCore

2009-05-26 Cameron Zwarich <​zwarich@apple.com>

Reviewed by Maciej Stachowiak.

Bug 26035: Make ImageSource::frameHasAlphaAtIndex() return false for JPEGs with CG
<​https://bugs.webkit.org/show_bug.cgi?id=26035>
<rdar://problem/6924087>

  • platform/graphics/cg/ImageSourceCG.cpp: (WebCore::ImageSource::frameHasAlphaAtIndex): return false if the image is JPEG, there is no image type, or m_decoder is null.
9:30 PM Changeset in webkit [44175] by zecke@webkit.org
  • 2 edits in trunk/WebCore

Fix build breakage of JPEGImageDecoder.cpp by including stdio.h again.

2009-05-26 Holger Hans Peter Freyther <​zecke@selfish.org>

Unreviewed build fix for the JPEGImageDecoder.

Revision 44167 removed stdio.h from the included headers and
this will lead to an error that FILE is not known inside the
jpeglib.h Put back the stdio.h include.

  • platform/image-decoders/jpeg/JPEGImageDecoder.cpp:
8:22 PM Changeset in webkit [44174] by oliver@apple.com
  • 6 edits
    3 adds in trunk

<rdar://problem/6924033> REGRESSION: Assertion failure due to forward references

Reviewed by Gavin Barraclough.

Add a pattern type for forward references to ensure that we don't confuse the
quantifier alternatives assertion.

7:54 PM Changeset in webkit [44173] by staikos@webkit.org
  • 2 edits in trunk/WebCore

2009-05-26 Yichao Yin <​yichao.yin@torchmobile.com.cn>

Reviewed by Maciej Stachowiak.

Fix the crash issue while running layout tests after enabled XHTMLMP
​https://bugs.webkit.org/show_bug.cgi?id=26017

7:47 PM Changeset in webkit [44172] by Stephanie Lewis
  • 2 edits in trunk/WebKit/mac

2009-05-26 Stephanie Lewis <Stephanie Lewis>

Reviewed by Ada Chan and Oliver Hunt.

Remove WebView observers in during fast teardown.
<rdar://problem/6922619> REGRESSION (Tiger-only?): After restoring windows from the previous session, a crash occurs while attempting to quit Safari

  • WebView/WebView.mm: (-[WebView _closeWithFastTeardown]):
7:47 PM Changeset in webkit [44171] by barraclough@apple.com
  • 6 edits in trunk/JavaScriptCore

2009-05-26 Gavin Barraclough <​barraclough@apple.com>

Reviewed by Oliver Hunt.

Fix for: <rdar://problem/6918095> REGRESSION: jQuery load() issue (25981),
and also an ASSERT failure on ​http://ihasahotdog.com/.

When overwriting a property on a dictionary with a cached specific value,
clear the cache if new value being written is different.

Export the new symbols.

  • jit/JITStubs.cpp: (JSC::JITStubs::cti_op_get_by_id_method_check_second):

Close dictionary prototypes upon caching a method access, as would happen when caching
a regular get_by_id.

  • runtime/JSObject.h: (JSC::JSObject::propertyStorage): (JSC::JSObject::locationForOffset):

Make these methods private.

(JSC::JSObject::putDirectInternal):

When overwriting a property on a dictionary with a cached specific value,
clear the cache if new value being written is different.

  • runtime/Structure.cpp: (JSC::Structure::despecifyDictionaryFunction):

Reset the specific value field for a given property in a dictionary.

(JSC::Structure::despecifyFunctionTransition):

Rename of 'changeFunctionTransition' (this was already internally refered to as a despecification).

  • runtime/Structure.h:

Declare new method.

5:45 PM Changeset in webkit [44170] by andersca@apple.com
  • 11 edits in trunk

WebCore:

2009-05-26 Anders Carlsson <​andersca@apple.com>

Reviewed by Dan Bernstein.

<rdar://problem/6901751>
REGRESSION (r35515): Tiger crash painting the selection on registration page of car2go.com


Don't use the WKCGContextIsSafeToClip function; it wasn't working correctly. Instead, just disable
the improved selection drawing on Tiger.


  • WebCore.Tiger.exp:
  • platform/graphics/cg/GraphicsContextCG.cpp: (WebCore::GraphicsContext::fillPath): (WebCore::GraphicsContext::strokePath): (WebCore::GraphicsContext::fillRect): (WebCore::GraphicsContext::clip): (WebCore::GraphicsContext::clipOut): (WebCore::GraphicsContext::clipOutEllipseInRect): (WebCore::GraphicsContext::clipPath): (WebCore::GraphicsContext::addInnerRoundedRectClip): (WebCore::GraphicsContext::strokeRect):
  • platform/mac/WebCoreSystemInterface.h:
  • platform/mac/WebCoreSystemInterface.mm:
  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::fillSelectionGaps):

WebKit/mac:

2009-05-26 Anders Carlsson <​andersca@apple.com>

Reviewed by Dan Bernstein.

<rdar://problem/6901751>
REGRESSION (r35515): Tiger crash painting the selection on registration page of car2go.com

Remove WKCGContextIsSafeToClip.

  • WebCoreSupport/WebSystemInterface.m: (InitWebCoreSystemInterface):

WebKitLibraries:

2009-05-26 Anders Carlsson <​andersca@apple.com>

Reviewed by Dan Bernstein.

<rdar://problem/6901751>
REGRESSION (r35515): Tiger crash painting the selection on registration page of car2go.com

Remove WKCGContextIsSafeToClip.


  • WebKitSystemInterface.h:
  • libWebKitSystemInterfaceTiger.a:
5:33 PM Changeset in webkit [44169] by barraclough@apple.com
  • 2 edits in trunk/JavaScriptCore

2009-05-26 Gavin Barraclough <​barraclough@apple.com>

Reviewed by Oliver "pieces of eight" Hunt.

When reseting RegexPattern class, should fully reset the class, not just bits of it.
In particular, we delete the cached character classes (for wordchars, etc), but do
not reset the set of pointers to the cached classes. In the case of a repeated parse
due to an illegal back-reference we will continue to use the deleted character class.

  • yarr/RegexPattern.h: (JSC::Yarr::RegexPattern::reset):
5:29 PM Changeset in webkit [44168] by bfulgham@webkit.org
  • 3 edits in trunk/SunSpider

2009-05-26 Olivier DOLE <​odole@pleyo.com>

Reviewed by Maciej.

Store sunspider test suite results in a specific directory for each
different type of benchmark (sunspider, V8 or ubench).

  • sunspider:
  • sunspider-compare-results:
5:20 PM Changeset in webkit [44167] by bfulgham@webkit.org
  • 22 edits in trunk/WebCore

2009-05-26 Peter Kasting <​pkasting@google.com>

Reviewed by Eric Seidel.

​https://bugs.webkit.org/show_bug.cgi?id=25709 part two
Mostly cosmetic changes, mainly to get image decoders for Cairo build to
comply with WebKit style guidelines:

  • Fix header guard names
  • Fix initializer list wrapping
  • Fix class/function "{" wrapping
  • Fix wrapping of long boolean expressions
  • Fix whitespace around operators
  • Eliminate whitespace on otherwise-blank lines
  • No {} on single-line conditional arms
  • Use 0 instead of NULL
  • Don't #include "config.h" in headers

Also a few non-cosmetic changes:

  • Remove unneeded #ifdef protecting the contents of these files. The platforms listed don't match who uses these files anymore (even without considering Skia), and platforms which don't use them at all (like CG) aren't harmed by the files, since they don't have equivalently-named classes. It's simpler to just ditch these.
  • Convert a use of Vector<>& into SharedBuffer*, since that's how the data is really stored anyway.
  • Use size() instead of m_size, for consistency with Skia code, and future-proofing (if a particular decoder wants to specialize this).
  • Move an ASSERT that was slightly more aggressive than necessary.
  • Change variable names/types for clarity/accuracy and to match Skia.
  • Remove unnecessary macro magic to work around a problem which no longer exists in the third-party JPEG headers.
  • Stop silencing a portability warning about setjmp (the vcproj/vsprops are the right place for this)
  • In Skia code, don't explicitly check |m_failed| before calling isSizeAvailable(), which itself checks |m_failed|.
  • platform/image-decoders/ImageDecoder.h: Fix header guards, "{" wrapping. (WebCore::RGBA32Buffer::): (WebCore::RGBA32Buffer::RGBA32Buffer): Fix initializer list wrapping. (WebCore::ImageDecoder::ImageDecoder): Fix initializer list wrapping.
  • platform/image-decoders/bmp/BMPImageDecoder.cpp: Remove unneeded #ifdef.
  • platform/image-decoders/bmp/BMPImageDecoder.h: Fix header guards, "{" wrapping.
  • platform/image-decoders/gif/GIFImageDecoder.cpp: Remove unneeded #ifdef, fix "{" wrapping. (WebCore::GIFImageDecoderPrivate::GIFImageDecoderPrivate): Use an initializer instead of a block-level statement. (WebCore::GIFImageDecoderPrivate::decode): Expect a SharedBuffer. (WebCore::GIFImageDecoderPrivate::getColorMap): (WebCore::GIFImageDecoder::GIFImageDecoder): Fix initializer list wrapping. (WebCore::GIFImageDecoder::frameCount): Add comment. (WebCore::GIFImageDecoder::frameBufferAtIndex): Explicitly cast, fix whitespace around operators. (WebCore::GIFImageDecoder::decode): Pass a SharedBuffer. (WebCore::GIFImageDecoder::initFrameBuffer): Use size() instead of m_size, move ASSERT, fix boolean wrapping, fix indenting. (WebCore::GIFImageDecoder::prepEmptyFrameBuffer): Use size() instead of m_size. (WebCore::GIFImageDecoder::haveDecodedRow): Use size() instead of m_size, eliminate unneeded whitespace, change variable name. (WebCore::GIFImageDecoder::frameComplete): Use size() instead of m_size, no {} on single-line conditional arms, fix boolean wrapping.
  • platform/image-decoders/gif/GIFImageDecoder.h: Fix header guards, "{" wrapping.
  • platform/image-decoders/gif/GIFImageReader.cpp: Remove unneeded #ifdef. (GIFImageReader::read):
  • platform/image-decoders/gif/GIFImageReader.h: Fix header guards, change variable type.
  • platform/image-decoders/ico/ICOImageDecoder.cpp: Remove unneeded #ifdef.
  • platform/image-decoders/ico/ICOImageDecoder.h: Fix header guards, "{" wrapping.
  • platform/image-decoders/jpeg/JPEGImageDecoder.cpp: Remove unneeded #ifdef, macro magic, silencing of warning. (WebCore::JPEGImageDecoder::outputScanlines): Use size() instead of m_size, change variable name.
  • platform/image-decoders/jpeg/JPEGImageDecoder.h: Fix header guards, "{" wrapping.
  • platform/image-decoders/png/PNGImageDecoder.cpp: Remove unneeded #ifdef, silencing of warning, change variable type. (WebCore::PNGImageReader::PNGImageReader): Fix initializer list wrapping. (WebCore::PNGImageReader::close): Add comment, zero another member for consistency. (WebCore::PNGImageDecoder::PNGImageDecoder): Fix indenting. (WebCore::PNGImageDecoder::decodingFailed): Define in .cpp, not .h. (WebCore::PNGImageDecoder::rowAvailable):
  • platform/image-decoders/png/PNGImageDecoder.h: Fix header guards, "{" wrapping.
  • platform/image-decoders/skia/GIFImageDecoder.cpp: (WebCore::GIFImageDecoder::isSizeAvailable): Don't check m_failed unnecessarily. (WebCore::GIFImageDecoder::frameBufferAtIndex): Fix whitespace around operators.
  • platform/image-decoders/skia/GIFImageReader.h: "unsigned" is sufficient to convey "unsigned int".
  • platform/image-decoders/skia/ImageDecoder.h: Remove unnecessary #includes. (WebCore::ImageDecoder::ImageDecoder): Fix initializer list wrapping.
  • platform/image-decoders/skia/JPEGImageDecoder.cpp: (WebCore::JPEGImageReader::JPEGImageReader): Use 0 instead of NULL. (WebCore::JPEGImageDecoder::isSizeAvailable): Don't check m_failed unnecessarily.
  • platform/image-decoders/skia/PNGImageDecoder.cpp: (WebCore::PNGImageReader::PNGImageReader): Fix initializer list wrapping. (WebCore::PNGImageDecoder::PNGImageDecoder): Fix indenting. (WebCore::PNGImageDecoder::isSizeAvailable): Don't check m_failed unnecessarily. (WebCore::rowAvailable):
  • platform/image-decoders/skia/XBMImageDecoder.h: Don't #include config.h.
  • platform/image-decoders/xbm/XBMImageDecoder.cpp: Remove unneeded #ifdef.
  • platform/image-decoders/xbm/XBMImageDecoder.h: Fix header guards, "{" wrapping.
5:13 PM Changeset in webkit [44166] by mrowe@apple.com
  • 1 edit in trunk/WebKitLibraries/win/tools/scripts/VERSION

Versioning.

4:57 PM Changeset in webkit [44165] by ggaren@apple.com
  • 2 edits in branches/nitro-extreme/JavaScriptCore

2009-05-26 Geoffrey Garen <​ggaren@apple.com>

Reviewed by Oliver Hunt.


Fixed a regression caused by my recent fix for NaN.

  • jit/JITArithmetic.cpp: (JSC::JIT::emitBinaryDoubleOp): Actually do the comparison in reverse order, like the ChangeLog said we would, bokay?
4:57 PM Changeset in webkit [44164] by mitz@apple.com
  • 2 edits in trunk/WebKit/mac

Reviewed by Darin Adler.

  • fix <rdar://problem/6922371> REGRESSION (r43973): Can't type first character with an umlaut, circumflex, or accent in Mail or in a wiki
  • WebView/WebHTMLView.mm: (isTextInput): Moved here. (isInPasswordField): Moved here. (-[WebHTMLView becomeFirstResponder]): Update the exposeInputContext flag and let NSApplication update the input manager with the new input context if necessary. (-[WebHTMLView _updateSelectionForInputManager]): Changed to use the NSApp global instead of +[NSApplication sharedApplication].
4:06 PM Changeset in webkit [44163] by bfulgham@webkit.org
  • 2 edits in trunk/JavaScriptCore

2009-05-26 Brent Fulgham <​bfulgham@webkit.org>

Build fix to correct r44161.

  • wtf/FastAllocBase.h:
3:58 PM Changeset in webkit [44162] by jianli@chromium.org
  • 3 edits in trunk/WebCore

2009-05-26 Jian Li <​jianli@chromium.org>

Reviewed by Dimitri Glazkov.

​https://bugs.webkit.org/show_bug.cgi?id=25944
Remove the uses of V8 Locker in worker execution code. No additional test is needed.
The normal WebKit layout tests should cover it. However, layout tests that start
multiple workers will fail to pass due to test shell limitation in Chromium. To cover
this, UI tests will be added (​http://code.google.com/p/chromium/issues/detail?id=12554).

  • bindings/v8/V8WorkerContextEventListener.cpp: (WebCore::V8WorkerContextEventListener::handleEvent):
  • bindings/v8/WorkerContextExecutionProxy.cpp: (WebCore::WorkerContextExecutionProxy::dispose): (WebCore::WorkerContextExecutionProxy::initV8IfNeeded): (WebCore::WorkerContextExecutionProxy::evaluate): (WebCore::WorkerContextExecutionProxy::findOrCreateEventListenerHelper): (WebCore::WorkerContextExecutionProxy::RemoveEventListener):
3:25 PM Changeset in webkit [44161] by bfulgham@webkit.org
  • 2 edits in trunk/JavaScriptCore

2009-05-26 Zoltan Horvath <​horvath.zoltan.6@stud.u-szeged.hu>

Reviewed by Maciej Stachowiak.

Inherite HashTable from FastAllocBase, because it has been instantiated by
'new' in JavaScriptCore/runtime/JSGlobalData.cpp.

  • wtf/HashTable.h:
  • wtf/FastAllocBase.h: Remove 'wtf' path from TypeTraits.h to allow use outside of wtf.
2:41 PM Changeset in webkit [44160] by dimich@chromium.org
  • 4 edits in trunk/WebCore

2009-05-26 Dmitry Titov <​dimich@chromium.org>

Reviewed by Dimitri Glazkov.

​https://bugs.webkit.org/show_bug.cgi?id=25974
Enable timers in Chromuim workers.

  • bindings/v8/ScheduledAction.cpp: (WebCore::ScheduledAction::execute): Added function which can execute a callback using WorkerContext.
  • bindings/v8/ScheduledAction.h: (WebCore::ScheduledAction::ScheduledAction): added url parameter to capture the worker's location.
  • bindings/v8/custom/V8WorkerContextCustom.cpp: (WebCore::SetTimeoutOrInterval): replaced NotImplemented with code to create ScheduledAction and DOMTimer. Also, removed declarations for clearTimeout/clearInterval callbacks since they are now directly generated from IDL.
2:19 PM Changeset in webkit [44159] by abarth@webkit.org
  • 1 edit
    2 deletes in trunk/LayoutTests

2009-05-26 Adam Barth <​abarth@webkit.org>

​https://bugs.webkit.org/show_bug.cgi?id=26011

Unreviewed change to disable flaky test as requested by Sam Weinig.

  • http/tests/security/postMessage/origin-follows-lexical-scope-expected.txt: Removed.
  • http/tests/security/postMessage/origin-follows-lexical-scope.html: Removed.
1:43 PM Changeset in webkit [44158] by mrowe@apple.com
  • 2 edits in trunk/WebKit/mac

Fix the Tiger build.

  • Misc/WebNSObjectExtras.mm:

(-[NSInvocation _webkit_invokeAndHandleException:]): Rename the local variable so that
it doesn't conflict with a member variable on Tiger.

1:28 PM Changeset in webkit [44157] by Dimitri Glazkov
  • 3 edits in trunk/WebCore

2009-05-26 Dimitri Glazkov <Dimitri Glazkov>

Unreviewed, build fix.

​https://bugs.webkit.org/show_bug.cgi?id=23649
Update V8 bindings to match SQLTransactionErrorCallback change.

  • bindings/v8/custom/V8CustomSQLTransactionErrorCallback.cpp: (WebCore::V8CustomSQLTransactionErrorCallback::handleEvent): Changed to return void.
  • bindings/v8/custom/V8CustomSQLTransactionErrorCallback.h: Ditto.
1:05 PM Changeset in webkit [44156] by krit@webkit.org
  • 4 edits
    2 adds
    2 deletes in trunk/WebCore

2009-05-26 Dirk Schulze <​krit@webkit.org>

Reviewed by Nikolas Zimmermann.

Move FilterEffect to platform/graphics/filters. First step to get an
SVG independent filter system.

  • GNUmakefile.am:
  • WebCore.pro:
  • WebCore.xcodeproj/project.pbxproj:
  • platform/graphics/filters/FilterEffect.cpp: Added. (WebCore::FilterEffect::FilterEffect): (WebCore::FilterEffect::~FilterEffect): (WebCore::FilterEffect::externalRepresentation):
  • platform/graphics/filters/FilterEffect.h: Added. (WebCore::FilterEffect::xBoundingBoxMode): (WebCore::FilterEffect::setXBoundingBoxMode): (WebCore::FilterEffect::yBoundingBoxMode): (WebCore::FilterEffect::setYBoundingBoxMode): (WebCore::FilterEffect::widthBoundingBoxMode): (WebCore::FilterEffect::setWidthBoundingBoxMode): (WebCore::FilterEffect::heightBoundingBoxMode): (WebCore::FilterEffect::setHeightBoundingBoxMode): (WebCore::FilterEffect::subRegion): (WebCore::FilterEffect::setSubRegion): (WebCore::FilterEffect::resultImage): (WebCore::FilterEffect::setEffectBuffer):
  • svg/FilterEffect.cpp: Removed.
  • svg/FilterEffect.h: Removed.
12:37 PM Changeset in webkit [44155] by Dimitri Glazkov
  • 7 edits
    2 adds in trunk

WebCore:

2009-05-26 Dimitri Glazkov <Dimitri Glazkov>

Reviewed by Maciej Stachowiak.

​https://bugs.webkit.org/show_bug.cgi?id=23649
Update SQLTransactionErrorCallback to not return a value per changes in
HTML5 spec.

Test: storage/transaction-error-callback.html

  • bindings/js/JSCustomSQLTransactionErrorCallback.cpp: (WebCore::JSCustomSQLTransactionErrorCallback::handleEvent):
  • bindings/js/JSCustomSQLTransactionErrorCallback.h:
  • storage/SQLTransaction.cpp: (WebCore::SQLTransaction::SQLTransaction): (WebCore::SQLTransaction::postflightAndCommit): (WebCore::SQLTransaction::handleTransactionError): (WebCore::SQLTransaction::deliverTransactionErrorCallback): (WebCore::SQLTransaction::cleanupAfterTransactionErrorCallback):
  • storage/SQLTransaction.h:
  • storage/SQLTransactionErrorCallback.h:

LayouTests:

2009-05-26 Dimitri Glazkov <Dimitri Glazkov>

Reviewed by Maciej Stachowiak.

​https://bugs.webkit.org/show_bug.cgi?id=23649
Add layout test for various cases of SQLTransactionErrorCallback
invocation.

  • storage/transaction-error-callback-expected.txt: Added.
  • storage/transaction-error-callback.html: Added.
11:29 AM Changeset in webkit [44154] by Darin Adler
  • 2 edits in trunk/WebKit/mac

2009-05-26 Darin Adler <Darin Adler>

Reviewed by Mark Rowe.

<rdar://problem/6921835> REGRESSION (r44115): Crash in Leopard Mail viewing message

Fix case where we autorelease an object on the main thread that we are returning
to another thread when using our _webkit_invokeOnMainThread method.

  • Misc/WebNSObjectExtras.mm: (returnTypeIsObject): Added. (-[WebMainThreadInvoker forwardInvocation:]): Autorelease the object on the calling thread, balancing a retain done on the main thread. (-[NSInvocation _webkit_invokeAndHandleException:]): Retain the object on the main thread.
11:26 AM Changeset in webkit [44153] by hyatt@apple.com
  • 2 edits in trunk/WebKit/mac

2009-05-26 David Hyatt <​hyatt@apple.com>

Back out the workaround for Mail crashing. Darin is working on the real fix.

  • Misc/WebNSObjectExtras.mm: (-[WebMainThreadInvoker forwardInvocation:]):
11:16 AM Changeset in webkit [44152] by hyatt@apple.com
  • 7 edits
    8 adds in trunk

WebCore:

2009-05-26 David Hyatt <​hyatt@apple.com>

Reviewed by Darin Adler.

Fix for ​https://bugs.webkit.org/show_bug.cgi?id=25969

Detect the case where we can fit without scrollbars when the view shrinks, so that we don't mistakenly
continue to show scrollbars.

Added two tests in fast/dynamic.

  • platform/ScrollView.cpp: (WebCore::ScrollView::updateScrollbars):

WebKit/mac:

2009-05-26 David Hyatt <​hyatt@apple.com>

Reviewed by Darin Adler.

Fix for ​https://bugs.webkit.org/show_bug.cgi?id=25969.

Stop using notifications for boundsChanged, since the notifications are being sent too late.
Since subviews get resized before parents do, the notification comes in telling the WebHTMLView
that its size has changed *before* we've done setNeedsLayout in the WebView size change callback.

Become more like the Windows platform and just do the bounds changed immediately as our size is
being altered by subclassing setFrameSize in WebView.

Also patch WebDynamicScrollbarsView to detect the case where neither axis is really spilling out
past the viewport, so that in shrinking situations we figure out that we don't need scrollbars
any more.

  • WebView/WebDynamicScrollBarsView.m: (-[WebDynamicScrollBarsView updateScrollers]):
  • WebView/WebView.mm: (-[WebView _boundsChangedToNewSize:]): (-[WebView setFrameSize:]): (-[WebView viewWillMoveToWindow:]): (-[WebView viewDidMoveToWindow]):

LayoutTests:

2009-05-26 David Hyatt <​hyatt@apple.com>

Reviewed by Darin Adler.

Fix for bug 25969, scrollbars remain after document shrinks. Add a couple of layout tests
written by Dan that show various problems with scrollbars following resizes.

  • fast/dynamic/window-resize-scrollbars-test.html: Added.
  • fast/dynamic/window-scrollbars-test.html: Added.
  • platform/mac/fast/dynamic/window-resize-scrollbars-test-expected.checksum: Added.
  • platform/mac/fast/dynamic/window-resize-scrollbars-test-expected.png: Added.
  • platform/mac/fast/dynamic/window-resize-scrollbars-test-expected.txt: Added.
  • platform/mac/fast/dynamic/window-scrollbars-test-expected.checksum: Added.
  • platform/mac/fast/dynamic/window-scrollbars-test-expected.png: Added.
  • platform/mac/fast/dynamic/window-scrollbars-test-expected.txt: Added.
10:49 AM Changeset in webkit [44151] by Chris Fleizach
  • 8 edits
    6 moves in trunk/WebCore

Bug 25801: change AccessibilityAria -> AccessibilityARIA
​https://bugs.webkit.org/show_bug.cgi?id=25801

9:00 AM Changeset in webkit [44150] by Dimitri Glazkov
  • 2 edits in trunk/WebCore

2009-05-26 Stephen White <​senorblanco@chromium.org>

Reviewed by Dimitri Glazkov.

​https://bugs.webkit.org/show_bug.cgi?id=26012

Fix the Skia path to normalize the given source rect when
drawing patterns, so it accepts negative width/height (as CG does).
Fixes Chromium bug ​http://www.crbug.com/6167.

  • platform/graphics/skia/ImageSkia.cpp: (WebCore::Image::drawPattern):
5:23 AM Changeset in webkit [44149] by ap@webkit.org
  • 6 edits in trunk/WebCore

2009-05-26 Pavel Feldman <​pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Serialize calls to WebInspector. This is the first step where method
calls are being serialized to arrays (not yet JSON stringified ones) and
are being dispatched on the client. This change also allows client to override
InspectorFrontend, so that the serialized calls can be made on a given object
instead of in-process WebInspector global. This will be the main control flow
when InspectorController is decoupled from the in-process frontend.

​https://bugs.webkit.org/show_bug.cgi?id=26010

  • inspector/InspectorController.cpp: (WebCore::InspectorController::scriptObjectReady): (WebCore::InspectorController::overrideFrontendObject): (WebCore::InspectorController::show): (WebCore::InspectorController::populateScriptObjects):
  • inspector/InspectorController.h:
  • inspector/InspectorFrontend.cpp: (WebCore::InspectorFrontend::addMessageToConsole): (WebCore::InspectorFrontend::addResource): (WebCore::InspectorFrontend::updateResource): (WebCore::InspectorFrontend::removeResource): (WebCore::InspectorFrontend::updateFocusedNode): (WebCore::InspectorFrontend::setAttachedWindow): (WebCore::InspectorFrontend::inspectedWindowScriptObjectCleared): (WebCore::InspectorFrontend::showPanel): (WebCore::InspectorFrontend::populateInterface): (WebCore::InspectorFrontend::reset): (WebCore::InspectorFrontend::debuggerWasEnabled): (WebCore::InspectorFrontend::debuggerWasDisabled): (WebCore::InspectorFrontend::profilerWasEnabled): (WebCore::InspectorFrontend::profilerWasDisabled): (WebCore::InspectorFrontend::parsedScriptSource): (WebCore::InspectorFrontend::failedToParseScriptSource): (WebCore::InspectorFrontend::addProfile): (WebCore::InspectorFrontend::setRecordingProfile): (WebCore::InspectorFrontend::pausedScript): (WebCore::InspectorFrontend::resumedScript): (WebCore::InspectorFrontend::addDatabase): (WebCore::InspectorFrontend::addDOMStorage): (WebCore::InspectorFrontend::newFunctionCall): (WebCore::InspectorFrontend::callSimpleFunction):
  • inspector/InspectorFrontend.h:
  • inspector/front-end/inspector.js: (WebInspector.dispatch):
12:30 AM Changeset in webkit [44148] by ggaren@apple.com
  • 3 edits
    3 adds in branches/nitro-extreme

JavaScriptCore:

2009-05-26 Geoffrey Garen <​ggaren@apple.com>

Reviewed by Sam Weinig and Oliver Hunt.


Fixed two edge cases in %:


  • Don't do -2147483648 % x as a fast case, since you might do -2147483648 % -1, which will signal a hardware exception due to overflow.
  • In the case of a zero remainder, be sure to store negative zero if the dividend was zero.


SunSpider reports no change.

  • jit/JITArithmetic.cpp: (JSC::JIT::emit_op_mod): (JSC::JIT::emitSlow_op_mod):

LayoutTests:

2009-05-25 Geoffrey Garen <​ggaren@apple.com>

Reviewed by Sam Weinig and Oliver Hunt.


Added test for arithmetic edge cases.


  • fast/js/arithmetic-expected.txt: Added.
  • fast/js/arithmetic.html: Added.
  • fast/js/resources/arithmetic.js: Added.

May 25, 2009:

11:20 PM Changeset in webkit [44147] by ap@webkit.org
  • 3 edits in trunk/WebCore

Reviewed by Darin Adler.

<rdar://problem/6918671> REGRESSION (r41700): Crashes in debug DumpRenderTree at RefCountedBase::ref().

  • dom/QualifiedName.cpp: (WebCore::QualifiedName::QualifiedName):
  • dom/QualifiedName.h: (WebCore::QualifiedName::QualifiedNameImpl::QualifiedNameImpl): Adjust empty namespace before QNameComponentsTranslator black magic, not after.
11:03 PM Changeset in webkit [44146] by ggaren@apple.com
  • 3 edits
    3 adds in branches/nitro-extreme

JavaScriptCore:

2009-05-25 Geoffrey Garen <​ggaren@apple.com>

Reviewed by Maciej Stachowiak.


Fixed a regression when comparing to NaN.

  • jit/JITArithmetic.cpp: (JSC::JIT::emitBinaryDoubleOp): For op_jnless and op_jnless_eq, do the comparison in reverse order, and jump if the result is below or below-or-equal. This ensures that we do jump in the case of NaN.

LayoutTests:

2009-05-25 Geoffrey Garen <​ggaren@apple.com>

Reviewed by Maciej Stachowiak.


Added test for NaN comparisons.


  • fast/js/nan-expected.txt: Added.
  • fast/js/nan.html: Added.
  • fast/js/resources/nan.js: Added. ():
9:21 PM Changeset in webkit [44145] by levin@chromium.org
  • 8 edits
    5 adds in trunk

JavaScriptCore:

2009-05-25 David Levin <​levin@chromium.org>

Reviewed by Maciej Stachowiak and Oliver Hunt.

​https://bugs.webkit.org/show_bug.cgi?id=25126
Allow the buffer underlying UString to be shared.

In order to not grow the underlying size of any structure,
there is a union in the Rep string which holds

+ m_sharedBuffer -- a pointer to the shared ref counted buffer

if the class is BaseString and the buffer is being shared OR

+ m_baseString -- the BaseString if the class is only UString::Rep

but not a UString::BaseString

Ideally, m_sharedBuffer would be a RefPtr, but it cannot be because
it is in a union.

No change in sunspider perf.

  • JavaScriptCore.vcproj/WTF/WTF.vcproj:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • runtime/UString.cpp: (JSC::UString::Rep::share): (JSC::UString::Rep::destroy): (JSC::UString::BaseString::sharedBuffer): (JSC::UString::BaseString::setSharedBuffer): (JSC::UString::BaseString::slowIsBufferReadOnly): (JSC::expandCapacity): (JSC::UString::Rep::reserveCapacity): (JSC::UString::expandPreCapacity): (JSC::concatenate): (JSC::UString::append):
  • runtime/UString.h: (JSC::UString::Rep::Rep): (JSC::UString::Rep::): (JSC::UString::BaseString::isShared): (JSC::UString::BaseString::isBufferReadOnly): (JSC::UString::Rep::baseString):
  • wtf/CrossThreadRefCounted.h: (WTF::CrossThreadRefCounted::isShared):
  • wtf/OwnFastMallocPtr.h: Added. (WTF::OwnFastMallocPtr::OwnFastMallocPtr): (WTF::OwnFastMallocPtr::~OwnFastMallocPtr): (WTF::OwnFastMallocPtr::get): (WTF::OwnFastMallocPtr::release):

JavaScriptGlue:

2009-05-25 David Levin <​levin@chromium.org>

Reviewed by Maciej Stachowiak and Oliver Hunt.

​https://bugs.webkit.org/show_bug.cgi?id=25126

Added forwarding headers.

  • ForwardingHeaders/wtf/CrossThreadRefCounted.h: Added.
  • ForwardingHeaders/wtf/OwnFastMallocPtr.h: Added.

WebCore:

2009-05-25 David Levin <​levin@chromium.org>

Reviewed by Maciej Stachowiak and Oliver Hunt.

Added forwarding headers.

  • ForwardingHeaders/wtf/CrossThreadRefCounted.h: Added.
  • ForwardingHeaders/wtf/OwnFastMallocPtr.h: Added.
9:00 PM Changeset in webkit [44144] by ggaren@apple.com
  • 2 edits in branches/nitro-extreme/JavaScriptCore

2009-05-25 Geoffrey Garen <​ggaren@apple.com>

Reviewed by Oliver Hunt.


SunSpider says no change.


Fixed regressions in fast/js/var-declarations-shadowing.html and
fast/js/equality.html, caused by recent == and != optimizations.

  • jit/JITStubs.cpp: (JSC::JITStubs::cti_op_eq): Don't treat "compare to string" as always numeric or string comparison. If the second operand is an object, you need to ToPrimitive it, and start all over again. Also, I wrote out each of the possible cases explicitly, to cut down on redundant branching.
5:20 PM Changeset in webkit [44143] by oliver@apple.com
  • 2 edits in trunk/JavaScriptCore

Re-add interpreter logic to jit-enabled builds as GCC mysteriously regresses without it

Reviewed by Maciej Stachowiak

5:08 PM Changeset in webkit [44142] by weinig@apple.com
  • 2 edits in branches/nitro-extreme/JavaScriptCore

2009-05-25 Sam Weinig <​sam@webkit.org>

Reviewed by Mark Rowe.

Fix bug in fast/js/constant-folding.html where we were not negating
-0 properly.

  • jit/JITArithmetic.cpp: (JSC::JIT::emit_op_negate):
4:52 PM Changeset in webkit [44141] by mrowe@apple.com
  • 15 edits in branches/WWDC-2009-branch

Merge r44136.

4:52 PM Changeset in webkit [44140] by mrowe@apple.com
  • 2 edits in branches/WWDC-2009-branch/WebKit/mac

Merge r44132.

4:52 PM Changeset in webkit [44139] by mrowe@apple.com
  • 3 edits
    2 adds in branches/WWDC-2009-branch

Merge r44075.

4:52 PM Changeset in webkit [44138] by mrowe@apple.com
  • 2 edits in branches/WWDC-2009-branch/WebKit/mac

Merge r44069.

4:51 PM Changeset in webkit [44137] by mrowe@apple.com
  • 2 edits in branches/WWDC-2009-branch/WebCore

Merge r44066.

3:48 PM Changeset in webkit [44136] by andersca@apple.com
  • 15 edits in trunk

WebCore:

2009-05-25 Anders Carlsson <​andersca@apple.com>

Reviewed by Sam Weinig.

  • WebCore side of <rdar://problem/6914001>.

Add a new m_allowPopupsFromPlugin flag.


  • bindings/js/ScriptController.cpp: (WebCore::ScriptController::ScriptController): (WebCore::ScriptController::processingUserGesture):
  • bindings/js/ScriptController.h: (WebCore::ScriptController::setAllowPopupsFromPlugin): (WebCore::ScriptController::allowPopupsFromPlugin):

WebKit/mac:

2009-05-25 Anders Carlsson <​andersca@apple.com>

Reviewed by Sam Weinig.

  • WebKit side of <rdar://problem/6914001>.
  • Plugins/Hosted/NetscapePluginHostManager.h:
  • Plugins/Hosted/NetscapePluginHostManager.mm: (WebKit::NetscapePluginHostManager::didCreateWindow): Iterate over all plug-in hosts. If one is in full-screen mode, make sure to activate the WebKit app instead.


  • Plugins/Hosted/NetscapePluginHostProxy.h: (WebKit::NetscapePluginHostProxy::isMenuBarVisible): Add getter.


  • Plugins/Hosted/NetscapePluginHostProxy.mm: (WKPCEvaluate): Add allowPopups flag.


  • Plugins/Hosted/NetscapePluginInstanceProxy.h:
  • Plugins/Hosted/NetscapePluginInstanceProxy.mm: (WebKit::NetscapePluginInstanceProxy::PluginRequest::PluginRequest): (WebKit::NetscapePluginInstanceProxy::PluginRequest::allowPopups): (WebKit::NetscapePluginInstanceProxy::loadURL): (WebKit::NetscapePluginInstanceProxy::evaluateJavaScript): (WebKit::NetscapePluginInstanceProxy::loadRequest): (WebKit::NetscapePluginInstanceProxy::evaluate): Use "allowPopups" instead of "userGesture".


  • Plugins/Hosted/WebKitPluginClient.defs: Add allowPopups argument to Evaluate.


  • Plugins/Hosted/WebKitPluginHostTypes.h: Use "allowPopups" instead of "userGesture".
  • WebCoreSupport/WebChromeClient.mm: (WebChromeClient::createWindow): Call didCreateWindow here.


  • WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::dispatchCreatePage): Ditto.
2:33 PM Changeset in webkit [44135] by abarth@webkit.org
  • 10 edits
    8 adds in trunk

WebCore:

2009-05-25 Adam Barth <​abarth@webkit.org>

Reviewed by Sam Weinig.

​https://bugs.webkit.org/show_bug.cgi?id=26006

Sort out our use of dynamicGlobalObject and lexicalGlobalObject for
window.location. The correct use appears to be as follows:

1) Use dynamicGlobalObject to find the user gesture.
2) Use dynamicGlobalObject to complete URLs.
3) Use lexicalGlobalObject to find the referrer.
4) Use lexicalGlobalObject for the frame navigation checks.
5) Use lexicalGlobalObject for the XSS checks.

Tests: http/tests/security/frameNavigation/context-for-location-assign.html

http/tests/security/frameNavigation/context-for-location-href.html
http/tests/security/frameNavigation/context-for-location.html

  • bindings/js/JSDOMBinding.cpp: (WebCore::shouldAllowNavigation): (WebCore::toLexicalFrame): (WebCore::processingUserGesture): (WebCore::completeURL):
  • bindings/js/JSDOMBinding.h:
  • bindings/js/JSDOMWindowCustom.cpp: (WebCore::JSDOMWindow::setLocation):
  • bindings/js/JSLocationCustom.cpp: (WebCore::navigateIfAllowed): (WebCore::JSLocation::setHref): (WebCore::JSLocation::replace): (WebCore::JSLocation::reload): (WebCore::JSLocation::assign): (WebCore::JSLocation::toString): (WebCore::JSLocationPrototype::customPut):
  • bindings/v8/V8Utilities.cpp: (WebCore::processingUserGesture): (WebCore::shouldAllowNavigation): (WebCore::completeURL): (WebCore::navigateIfAllowed):
  • bindings/v8/V8Utilities.h:
  • bindings/v8/custom/V8DOMWindowCustom.cpp: (WebCore::V8Custom::WindowSetLocation):
  • bindings/v8/custom/V8LocationCustom.cpp: (WebCore::ACCESSOR_SETTER): (WebCore::CALLBACK_FUNC_DECL):

LayoutTests:

2009-05-25 Adam Barth <​abarth@webkit.og>

Reviewed by Sam Weinig.

​https://bugs.webkit.org/show_bug.cgi?id=26006

Test our use of dynamicGlobalObject and lexicalGlobalObject for
window.location.

  • http/tests/security/frameNavigation/context-for-location-assign-expected.txt: Added.
  • http/tests/security/frameNavigation/context-for-location-assign.html: Added.
  • http/tests/security/frameNavigation/context-for-location-expected.txt: Added.
  • http/tests/security/frameNavigation/context-for-location-href-expected.txt: Added.
  • http/tests/security/frameNavigation/context-for-location-href.html: Added.
  • http/tests/security/frameNavigation/context-for-location.html: Added.
  • http/tests/security/frameNavigation/resources/middle-frame-for-location.html: Added.
  • http/tests/security/frameNavigation/resources/target-for-location.html: Added.
2:11 PM Changeset in webkit [44134] by abarth@webkit.org
  • 2 edits in trunk/LayoutTests/http/tests/security/postMessage

Unreviewed attempt to fix flaky origin-follows-lexical-scope test. (Test only fails on buildbot.)

12:33 PM Changeset in webkit [44133] by abarth@webkit.org
  • 4 edits
    1 add in trunk/LayoutTests

2009-05-25 Adam Barth <​abarth@webkit.org>

Reviewed by Sam Weinig.

​https://bugs.webkit.org/show_bug.cgi?id=26011

Try to make test less flaky.

  • http/tests/security/postMessage/origin-follows-lexical-scope-expected.txt:
  • http/tests/security/postMessage/origin-follows-lexical-scope.html:
  • http/tests/security/postMessage/resources/middle-frame-for-lexical.html:
  • http/tests/security/postMessage/resources/post-message-listener-with-ready.html: Added.
11:48 AM Changeset in webkit [44132] by andersca@apple.com
  • 2 edits in trunk/WebKit/mac

2009-05-25 Anders Carlsson <​andersca@apple.com>

Reviewed by Sam Weinig.

  • Fix <rdar://problem/6915849>.


Release the placeholder window after -[NSApplication runModalForWindow] returns.


  • Plugins/Hosted/NetscapePluginHostProxy.mm: (WebKit::NetscapePluginHostProxy::beginModal): (WebKit::NetscapePluginHostProxy::endModal):
8:41 AM Changeset in webkit [44131] by xan@webkit.org
  • 2 edits in trunk/JavaScriptCore

2009-05-25 Fridrich Strba <​fridrich.strba@bluewin.ch>

Reviewed by Maciej Stachowiak.

The functions written in assembly need to have a leading
underscore on Windows too.

  • jit/JITStubs.cpp:
8:41 AM Changeset in webkit [44130] by xan@webkit.org
  • 3 edits in trunk/WebCore

2009-05-25 Fridrich Strba <​fridrich.strba@bluewin.ch>

Reviewed by Maciej Stachowiak.

With Windows compilers older then MSVC 2005, the functions
gmtime_s and localtime_s don't exist. The gmtime and localtime are
on Windows always thread safe. So use them in the cases where
gmtime_s and localtime_s are not present.

  • loader/FTPDirectoryDocument.cpp:
  • loader/FTPDirectoryParser.cpp:
5:55 AM Changeset in webkit [44129] by Simon Hausmann
  • 2 edits in trunk/WebCore

2009-05-25 Holger Hans Peter Freyther <​zecke@selfish.org>

Reviewed by Simon Hausmann.

Follow up on r44120. PluginPackageMac.cpp is used
by Qt on Mac and contained a copy of the m_browserFunc
assignments and ::equal, ::hash and ::compareFileVersion.
Change it to use the ones from PluginPackage.cpp as well.

5:39 AM Changeset in webkit [44128] by Simon Hausmann
  • 3 edits in trunk/WebCore

2009-05-25 Simon Hausmann <​simon.hausmann@nokia.com>

Reviewed by Tor Arne Vestbø.

​https://bugs.webkit.org/show_bug.cgi?id=25612

Support conditionals in the tag factories, by placing
feature #ifdefs around the individual factory functions
and the registration.

Made the Audio and Video elements conditional in the tag factories

4:45 AM Changeset in webkit [44127] by Simon Hausmann
  • 2 edits in trunk/WebCore

2009-05-25 Simon Hausmann <​simon.hausmann@nokia.com>

Fix the Gtk build when video is disabled.

4:35 AM Changeset in webkit [44126] by Simon Hausmann
  • 2 edits in trunk/WebCore

2009-05-25 Simon Hausmann <​simon.hausmann@nokia.com>

Fix the Qt build when video is disabled.

  • WebCore.pro: Always generate the IDL files for the media elements. They contain proper ENABLE(VIDEO) #ifdefs.
1:36 AM Changeset in webkit [44125] by abarth@webkit.org
  • 1 edit in trunk/WebCore/ChangeLog

Fix ChangeLog typo.

1:29 AM Changeset in webkit [44124] by abarth@webkit.org
  • 4 edits
    3 adds in trunk

WebCore:

2009-05-25 Adam Barth <​abarth@webkit.org>

Reviewed by Maciej Stachowiak.

​https://bugs.webkit.org/show_bug.cgi?id=26004

The origin for postMessage should follow lexical scope, not dynamic
scope. Yes, this is a super-obscure conner case.

Test: http/tests/security/postMessage/origin-follows-lexical-scope.html

  • bindings/js/JSDOMWindowCustom.cpp: (WebCore::JSDOMWindow::postMessage):
  • bindings/v8/custom/V8DOMWindowCustom.cpp: (WebCore::CALLBACK_FUNC_DECL):

LayoutTests:

2009-05-25 Adam Barth <​abarth@webkit.org>

Reviewed by Maciej Stachowiak.

​https://bugs.webkit.org/show_bug.cgi?id=26004

Test that the origin for postMessage follows the lexical scope.

  • http/tests/security/postMessage/origin-follows-lexical-scope-expected.txt: Added.
  • http/tests/security/postMessage/origin-follows-lexical-scope.html: Added.
  • http/tests/security/postMessage/resources/middle-frame-for-lexical.html: Added.
Note: See TracTimeline for information about the timeline view.