⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



May 28, 2009:

5:45 PM Changeset in webkit [44261] by mrowe@apple.com
  • 4 edits in branches/WWDC-2009-branch

Versioning.

5:40 PM Changeset in webkit [44260] by mrowe@apple.com
  • 1 copy in tags/Safari-6530.14

New tag.

5:34 PM Changeset in webkit [44259] by mrowe@apple.com
  • 7 edits
    4 adds in branches/WWDC-2009-branch

Merge r44218.

5:34 PM Changeset in webkit [44258] by mrowe@apple.com
  • 2 edits in branches/WWDC-2009-branch/WebCore

Merge r44241.

5:34 PM Changeset in webkit [44257] by mrowe@apple.com
  • 4 edits in branches/WWDC-2009-branch

Merge r44216.

4:44 PM Changeset in webkit [44256] by dimich@chromium.org
  • 2 edits in trunk/WebCore

2009-05-28 Dmitry Titov <​dimich@chromium.org>

Reviewed by Dimitri Glazkov.

​https://bugs.webkit.org/show_bug.cgi?id=26068
V8: Remove the remaining b8::Locker usage in worker code.
This completes the fix for ​https://bugs.webkit.org/show_bug.cgi?id=25944,
since the patches for enabling timers and that bug have "crossed in the queue".
Existing LayoutTests/fast/workers/worker-timeout.html covers this fix (will start work in Chromium).

  • bindings/v8/ScheduledAction.cpp: (WebCore::ScheduledAction::execute):
3:38 PM Changeset in webkit [44255] by mrowe@apple.com
  • 4 edits in trunk/WebKit/mac

Build fix. Move off a deprecated NSFileManager method.

Rubber-stamped by Dan Bernstein.

  • Misc/WebNSFileManagerExtras.h:
  • Misc/WebNSFileManagerExtras.m:

(-[NSFileManager destinationOfSymbolicLinkAtPath:error:]): Implement a new-in-Leopard method for Tiger to use.
(-[NSFileManager attributesOfItemAtPath:error:]): Ditto.

  • Plugins/WebNetscapePluginPackage.mm:

(-[WebNetscapePluginPackage _initWithPath:]): Use the new non-deprecated methods.

3:18 PM Changeset in webkit [44254] by kov@webkit.org
  • 2 edits in trunk/WebCore

2009-05-28 Gustavo Noronha Silva <​gustavo.noronha@collabora.co.uk>

Reviewed by Xan Lopez.

Simplify the Accept-Encoding header we are sending out, for it
seems some servers do not enjoy parsing the full, explicit
version.

  • platform/network/soup/ResourceHandleSoup.cpp: (WebCore::ResourceHandle::startHttp):
3:10 PM Changeset in webkit [44253] by krit@webkit.org
  • 186 edits in trunk

2009-05-28 Dirk Schulze <​krit@webkit.org>

Reviewed by Nikolas Zimmermann.

Added a new build flag --filters. This replaces the old --svg-filters and enables
other parts of WebKit to use some basic filters of platform/graphics/filters if needed.
This patch also fixes a bug in dom/DOMImplementation.cpp where we used SVG_FILTER. This flag
doesn't exist and was replaced by FILTERS as well as all SVG_FILTERS occurrences.
Filters are not working yet. This patch is just a preperation. Filters are deactivated by
default.

  • Configurations/FeatureDefines.xcconfig:
  • DerivedSources.make:
  • GNUmakefile.am:
  • WebCore.pro:
  • bindings/objc/DOM.mm: (WebCore::createElementClassMap):
  • dom/DOMImplementation.cpp: (WebCore::isSVG10Feature): (WebCore::isSVG11Feature):
  • page/DOMWindow.idl:
  • platform/graphics/filters/FEBlend.cpp:
  • platform/graphics/filters/FEBlend.h:
  • platform/graphics/filters/FEColorMatrix.cpp:
  • platform/graphics/filters/FEColorMatrix.h:
  • platform/graphics/filters/FEComponentTransfer.cpp:
  • platform/graphics/filters/FEComponentTransfer.h:
  • platform/graphics/filters/FEComposite.cpp:
  • platform/graphics/filters/FEComposite.h:
  • platform/graphics/filters/FilterEffect.cpp:
  • platform/graphics/filters/FilterEffect.h:
  • platform/graphics/filters/SourceAlpha.cpp:
  • platform/graphics/filters/SourceAlpha.h:
  • platform/graphics/filters/SourceGraphic.cpp:
  • platform/graphics/filters/SourceGraphic.h:
  • rendering/RenderSVGContainer.cpp: (WebCore::RenderSVGContainer::selfWillPaint):
  • rendering/RenderSVGModelObject.cpp:
  • rendering/RenderSVGRoot.cpp: (WebCore::RenderSVGRoot::selfWillPaint):
  • rendering/SVGRenderSupport.cpp: (WebCore::SVGRenderBase::prepareToRenderSVGContent): (WebCore::SVGRenderBase::finishRenderSVGContent): (WebCore::SVGRenderBase::filterBoundingBoxForRenderer):
  • svg/Filter.cpp:
  • svg/Filter.h:
  • svg/FilterBuilder.cpp:
  • svg/FilterBuilder.h:
  • svg/SVGComponentTransferFunctionElement.cpp:
  • svg/SVGComponentTransferFunctionElement.h:
  • svg/SVGComponentTransferFunctionElement.idl:
  • svg/SVGFEBlendElement.cpp:
  • svg/SVGFEBlendElement.h:
  • svg/SVGFEBlendElement.idl:
  • svg/SVGFEColorMatrixElement.cpp:
  • svg/SVGFEColorMatrixElement.h:
  • svg/SVGFEColorMatrixElement.idl:
  • svg/SVGFEComponentTransferElement.cpp:
  • svg/SVGFEComponentTransferElement.h:
  • svg/SVGFEComponentTransferElement.idl:
  • svg/SVGFECompositeElement.cpp:
  • svg/SVGFECompositeElement.h:
  • svg/SVGFECompositeElement.idl:
  • svg/SVGFEDiffuseLightingElement.cpp:
  • svg/SVGFEDiffuseLightingElement.h:
  • svg/SVGFEDiffuseLightingElement.idl:
  • svg/SVGFEDisplacementMapElement.cpp:
  • svg/SVGFEDisplacementMapElement.h:
  • svg/SVGFEDisplacementMapElement.idl:
  • svg/SVGFEDistantLightElement.cpp:
  • svg/SVGFEDistantLightElement.h:
  • svg/SVGFEDistantLightElement.idl:
  • svg/SVGFEFloodElement.cpp:
  • svg/SVGFEFloodElement.h:
  • svg/SVGFEFloodElement.idl:
  • svg/SVGFEFuncAElement.cpp:
  • svg/SVGFEFuncAElement.h:
  • svg/SVGFEFuncAElement.idl:
  • svg/SVGFEFuncBElement.cpp:
  • svg/SVGFEFuncBElement.h:
  • svg/SVGFEFuncBElement.idl:
  • svg/SVGFEFuncGElement.cpp:
  • svg/SVGFEFuncGElement.h:
  • svg/SVGFEFuncGElement.idl:
  • svg/SVGFEFuncRElement.cpp:
  • svg/SVGFEFuncRElement.h:
  • svg/SVGFEFuncRElement.idl:
  • svg/SVGFEGaussianBlurElement.cpp:
  • svg/SVGFEGaussianBlurElement.h:
  • svg/SVGFEGaussianBlurElement.idl:
  • svg/SVGFEImageElement.cpp:
  • svg/SVGFEImageElement.h:
  • svg/SVGFEImageElement.idl:
  • svg/SVGFELightElement.cpp:
  • svg/SVGFELightElement.h:
  • svg/SVGFEMergeElement.cpp:
  • svg/SVGFEMergeElement.h:
  • svg/SVGFEMergeElement.idl:
  • svg/SVGFEMergeNodeElement.cpp:
  • svg/SVGFEMergeNodeElement.h:
  • svg/SVGFEMergeNodeElement.idl:
  • svg/SVGFEOffsetElement.cpp:
  • svg/SVGFEOffsetElement.h:
  • svg/SVGFEOffsetElement.idl:
  • svg/SVGFEPointLightElement.cpp:
  • svg/SVGFEPointLightElement.h:
  • svg/SVGFEPointLightElement.idl:
  • svg/SVGFESpecularLightingElement.cpp:
  • svg/SVGFESpecularLightingElement.h:
  • svg/SVGFESpecularLightingElement.idl:
  • svg/SVGFESpotLightElement.cpp:
  • svg/SVGFESpotLightElement.h:
  • svg/SVGFESpotLightElement.idl:
  • svg/SVGFETileElement.cpp:
  • svg/SVGFETileElement.h:
  • svg/SVGFETileElement.idl:
  • svg/SVGFETurbulenceElement.cpp:
  • svg/SVGFETurbulenceElement.h:
  • svg/SVGFETurbulenceElement.idl:
  • svg/SVGFilterElement.cpp:
  • svg/SVGFilterElement.h:
  • svg/SVGFilterElement.idl:
  • svg/SVGFilterPrimitiveStandardAttributes.cpp:
  • svg/SVGFilterPrimitiveStandardAttributes.h:
  • svg/graphics/SVGResourceFilter.cpp:
  • svg/graphics/SVGResourceFilter.h:
  • svg/graphics/cairo/SVGResourceFilterCairo.cpp:
  • svg/graphics/cg/SVGResourceFilterCg.cpp:
  • svg/graphics/cg/SVGResourceFilterCg.mm:
  • svg/graphics/filters/SVGDistantLightSource.h:
  • svg/graphics/filters/SVGFEConvolveMatrix.cpp:
  • svg/graphics/filters/SVGFEConvolveMatrix.h:
  • svg/graphics/filters/SVGFEDiffuseLighting.cpp:
  • svg/graphics/filters/SVGFEDiffuseLighting.h:
  • svg/graphics/filters/SVGFEDisplacementMap.cpp:
  • svg/graphics/filters/SVGFEDisplacementMap.h:
  • svg/graphics/filters/SVGFEFlood.cpp:
  • svg/graphics/filters/SVGFEFlood.h:
  • svg/graphics/filters/SVGFEGaussianBlur.cpp:
  • svg/graphics/filters/SVGFEGaussianBlur.h:
  • svg/graphics/filters/SVGFEImage.cpp:
  • svg/graphics/filters/SVGFEImage.h:
  • svg/graphics/filters/SVGFEMerge.cpp:
  • svg/graphics/filters/SVGFEMerge.h:
  • svg/graphics/filters/SVGFEMorphology.cpp:
  • svg/graphics/filters/SVGFEMorphology.h:
  • svg/graphics/filters/SVGFEOffset.cpp:
  • svg/graphics/filters/SVGFEOffset.h:
  • svg/graphics/filters/SVGFESpecularLighting.cpp:
  • svg/graphics/filters/SVGFESpecularLighting.h:
  • svg/graphics/filters/SVGFETile.cpp:
  • svg/graphics/filters/SVGFETile.h:
  • svg/graphics/filters/SVGFETurbulence.cpp:
  • svg/graphics/filters/SVGFETurbulence.h:
  • svg/graphics/filters/SVGFilterEffect.cpp:
  • svg/graphics/filters/SVGFilterEffect.h:
  • svg/graphics/filters/SVGLightSource.cpp:
  • svg/graphics/filters/SVGLightSource.h:
  • svg/graphics/filters/SVGPointLightSource.h:
  • svg/graphics/filters/SVGSpotLightSource.h:
  • svg/graphics/filters/cg/SVGFEHelpersCg.h:
  • svg/graphics/filters/cg/SVGFEHelpersCg.mm:
  • svg/graphics/filters/cg/SVGFilterEffectCg.mm:
  • svg/graphics/filters/cg/WKArithmeticFilter.h:
  • svg/graphics/filters/cg/WKArithmeticFilter.m:
  • svg/graphics/filters/cg/WKComponentMergeFilter.h:
  • svg/graphics/filters/cg/WKComponentMergeFilter.m:
  • svg/graphics/filters/cg/WKDiffuseLightingFilter.h:
  • svg/graphics/filters/cg/WKDiffuseLightingFilter.m:
  • svg/graphics/filters/cg/WKDiscreteTransferFilter.h:
  • svg/graphics/filters/cg/WKDiscreteTransferFilter.m:
  • svg/graphics/filters/cg/WKDisplacementMapFilter.h
  • svg/graphics/filters/cg/WKDisplacementMapFilter.m:
  • svg/graphics/filters/cg/WKDistantLightFilter.h:
  • svg/graphics/filters/cg/WKDistantLightFilter.m:
  • svg/graphics/filters/cg/WKGammaTransferFilter.h:
  • svg/graphics/filters/cg/WKGammaTransferFilter.m:
  • svg/graphics/filters/cg/WKIdentityTransferFilter.h:
  • svg/graphics/filters/cg/WKIdentityTransferFilter.m:
  • svg/graphics/filters/cg/WKLinearTransferFilter.h:
  • svg/graphics/filters/cg/WKLinearTransferFilter.m:
  • svg/graphics/filters/cg/WKNormalMapFilter.h:
  • svg/graphics/filters/cg/WKNormalMapFilter.m:
  • svg/graphics/filters/cg/WKPointLightFilter.h:
  • svg/graphics/filters/cg/WKPointLightFilter.m:
  • svg/graphics/filters/cg/WKSpecularLightingFilter.h:
  • svg/graphics/filters/cg/WKSpecularLightingFilter.m:
  • svg/graphics/filters/cg/WKSpotLightFilter.h:
  • svg/graphics/filters/cg/WKSpotLightFilter.m:
  • svg/graphics/filters/cg/WKTableTransferFilter.h:
  • svg/graphics/filters/cg/WKTableTransferFilter.m:
  • svg/graphics/mac/SVGResourceFilterPlatformDataMac.h:
  • svg/graphics/mac/SVGResourceFilterPlatformDataMac.mm:
  • svg/graphics/qt/SVGResourceFilterQt.cpp:
  • svg/graphics/skia/SVGResourceFilterSkia.cpp:
  • svg/svgtags.in:

*WebKit/mac/
2009-05-28 Dirk Schulze <​krit@webkit.org>

Reviewed by Nikolas Zimmermann.

Added new build flag --filters. More details in WebCore/ChangeLog.

  • Configurations/FeatureDefines.xcconfig:

*.
2009-05-28 Dirk Schulze <​krit@webkit.org>

Reviewed by Nikolas Zimmermann.

Enable the new build flag --filters for Gtk. More details in WebCore/ChangeLog.

  • configure.ac:

*JavaScriptCore/
2009-05-28 Dirk Schulze <​krit@webkit.org>

Reviewed by Nikolas Zimmermann.

Added new build flag --filters for Mac. More details in WebCore/ChangeLog.

  • Configurations/FeatureDefines.xcconfig:

*WebKitTools
2009-05-28 Dirk Schulze <​krit@webkit.org>

Reviewed by Nikolas Zimmermann.

Added new build flag --filters. More details in WebCore/ChangeLog.

  • Scripts/build-webkit:
2:05 PM Changeset in webkit [44252] by brettw@chromium.org
  • 2 edits in trunk/WebCore

2009-05-28 Brett Wilson <​brettw@chromium.org>

Unreviewed, build fix.

​https://bugs.webkit.org/show_bug.cgi?id=26067

Add casts for scale function to make more explicit what is happening
and fix a compiler warning.

  • platform/graphics/IntSize.h: (WebCore::IntSize::scale):
1:56 PM Changeset in webkit [44251] by mrowe@apple.com
  • 2 edits in trunk/WebKit

Symlink WebKitPluginHost.app in to place if needed.

Rubber-stamped by Anders Carlsson.

  • WebKit.xcodeproj/project.pbxproj:
12:37 PM Changeset in webkit [44250] by kov@webkit.org
  • 1 copy in releases/WebKitGTK/webkit-1.1.8

Tagging 1.1.8.

12:27 PM Changeset in webkit [44249] by weinig@apple.com
  • 4 edits in trunk/WebCore

2009-05-28 Sam Weinig <​sam@webkit.org>

Reviewed by Darin Adler.

Remove the returnValueSlot concept from JSDOMWindowBase. Now that windows
are not cleared on navigation it is no longer necessary.

  • bindings/js/JSDOMWindowBase.cpp: (WebCore::JSDOMWindowBase::JSDOMWindowBaseData::JSDOMWindowBaseData): (WebCore::JSDOMWindowBase::willRemoveFromWindowShell):
  • bindings/js/JSDOMWindowBase.h:
  • bindings/js/JSDOMWindowCustom.cpp: (WebCore::JSDOMWindow::showModalDialog):
11:35 AM Changeset in webkit [44248] by kov@webkit.org
  • 2 edits in trunk/WebKit/gtk

2009-05-28 Gustavo Noronha Silva <​gustavo.noronha@collabora.co.uk>

Reviewed by Xan Lopez.

​https://bugs.webkit.org/show_bug.cgi?id=26048
navigation-policy-decision-requested documentation incomplete

Fix documentation for all policy decision request signals, to
mention that an actual decision is expected when you return TRUE,
meaning that you handled the signal.

  • webkit/webkitwebview.cpp: (webkit_web_view_class_init):
11:33 AM Changeset in webkit [44247] by xan@webkit.org
  • 2 edits in trunk/WebKit/gtk

2009-05-28 Xan Lopez <​xlopez@igalia.com>

Reviewed by Gustavo Noronha.

Mention the implementation of the new AtkText methods.

  • NEWS:
11:20 AM Changeset in webkit [44246] by xan@webkit.org
  • 5 edits
    1 add in trunk

2009-05-12 Xan Lopez <​xlopez@igalia.com>

Reviewed by Jan Alonzo and Gustavo Noronha.

​https://bugs.webkit.org/show_bug.cgi?id=25415
[GTK][ATK] Please implement support for get_text_at_offset

Add new test file for ATK.

  • GNUmakefile.am:

WebCore:

2009-05-12 Xan Lopez <​xlopez@igalia.com>

Reviewed by Jan Alonzo and Gustavo Noronha.

​https://bugs.webkit.org/show_bug.cgi?id=25415
[GTK][ATK] Please implement support for get_text_at_offset

Implement atk_text_get_text_{at,after,before}_offset.

  • accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:

WebKit/gtk:

2009-05-12 Xan Lopez <​xlopez@igalia.com>

Reviewed by Jan Alonzo and Gustavo Noronha.

​https://bugs.webkit.org/show_bug.cgi?id=25415
[GTK][ATK] Please implement support for get_text_at_offset

New test file for ATK functionality.

  • tests/testatk.c: Added. (bail_out): (test_get_text_function): (test_webkit_atk_get_text_at_offset): (main):
11:04 AM Changeset in webkit [44245] by Nikolas Zimmermann
  • 5 edits in trunk/WebCore

Rubber-stamped by Darin Adler.
Remove unnecessary destructor from InputElementData/OptionElementData.

10:50 AM Changeset in webkit [44244] by sfalken@apple.com
  • 3 edits in tags/Safari-6530.13.1/WebCore

Merge r44233.

10:49 AM Changeset in webkit [44243] by Nikolas Zimmermann
  • 9 edits in trunk/WebCore

Reviewed by Darin Adler.
Fixes: ​https://bugs.webkit.org/show_bug.cgi?id=26062

Refactor code from all virtual methods in HTMLSelectElement (that are also needed for WMLSelectElement)
in the recently introduced SelectElement abstract base class. Follow the same design sheme that InputElement uses.

10:48 AM Changeset in webkit [44242] by kov@webkit.org
  • 2 edits in trunk

2009-05-28 Gustavo Noronha Silva <​gustavo.noronha@collabora.co.uk>

Rubber-stamped by Xan Lopez.

Fix webkitgtk_cleanfiles to clean gtk-doc-related files in the
correct directory, so that we pass make distcheck.

  • GNUmakefile.am:
10:46 AM Changeset in webkit [44241] by Adam Roben
  • 2 edits in trunk/WebCore

Don't try to use the new combobox parts on Vista in Classic mode

Fixes:
<rdar://problem/6929277> REGRESSION (r42289+r42350): Windows Classic
theme: drop down lists in Preferences get a line/square
<rdar://problem/6929298> REGRESSION (r42289): Windows Classic: drop
down lists are black with a circle on many sites

Reviewed by Steve Falkenburg.

  • rendering/RenderThemeWin.cpp: (WebCore::RenderThemeWin::paintMenuList): Only use the new combobox parts when we have a theme (i.e., when we're not in Classic mode). When we don't have a theme, fall back to the pre-r42289 code.
10:36 AM Changeset in webkit [44240] by sfalken@apple.com
  • 1 copy in tags/Safari-6530.13.1

New tag.

10:35 AM Changeset in webkit [44239] by sfalken@apple.com
  • 1 delete in tags/Safari-6530.13.1

Delete incorrect tag.

10:34 AM Changeset in webkit [44238] by sfalken@apple.com
  • 1 copy in tags/Safari-6530.13.1

New tag.

10:29 AM Changeset in webkit [44237] by pkasting@chromium.org
  • 2 edits in trunk/WebCore

2009-05-27 Peter Kasting <​pkasting@google.com>

Reviewed by Simon Fraser.

​https://bugs.webkit.org/show_bug.cgi?id=25659
Avoid calling frameCount() unnecessarily (which could lead to extra
GIF decoding).

  • platform/graphics/BitmapImage.cpp: (WebCore::BitmapImage::destroyDecodedDataIfNecessary):
9:58 AM Changeset in webkit [44236] by kov@webkit.org
  • 2 edits in trunk/WebKit/gtk

2009-05-28 Gustavo Noronha Silva <​gustavo.noronha@collabora.co.uk>

Reviewed by Xan Lopez.

Document changes worth noting for 1.1.8.

  • NEWS:
9:55 AM Changeset in webkit [44235] by bfulgham@webkit.org
  • 16 edits
    6 adds in trunk

WebCore:

2009-05-28 Simon Fraser <Simon Fraser>

Reviewed by Oliver Hunt.


​https://bugs.webkit.org/show_bug.cgi?id=8736

Tests: fast/borders/border-radius-constraints.html

fast/borders/border-radius-split-inline.html


When the sum of the corner radii on a side exceed the length of the side,
reduce the radii according to CSS 3 rules.


Add RenderStyle::getBorderRadiiForRect() to fetch corner radii, applying
the constraints. Use that for painting borders, box-shadow, clipping replaced
elements

  • platform/graphics/IntSize.h: (WebCore::IntSize::scale): Add a scale method that scales by a float (using C rounding rules, like IntRect::scale()).
  • platform/graphics/Path.cpp: Make the QUARTER const static.
  • rendering/RenderBox.cpp: (WebCore::RenderBox::pushContentsClip): Use getBorderRadiiForRect to fetch border radii.
  • rendering/RenderBoxModelObject.cpp: (WebCore::RenderBoxModelObject::paintFillLayerExtended): Use getBorderRadiiForRect to fetch border radii.

(WebCore::RenderBoxModelObject::paintBorder):
Use getBorderRadiiForRect to fetch border radii, and fix a bug when drawing
borders for split inlines, which used to apply the radii for each segment,
and no longer does.

(WebCore::RenderBoxModelObject::paintBoxShadow):
Use getBorderRadiiForRect to fetch border radii.

  • rendering/RenderReplaced.cpp: (WebCore::RenderReplaced::paint): Use getBorderRadiiForRect to fetch border radii for clipping.
  • rendering/RenderWidget.cpp: (WebCore::RenderWidget::paint): Use getBorderRadiiForRect to fetch border radii for clipping.
  • rendering/style/RenderStyle.h:
  • rendering/style/RenderStyle.cpp: (WebCore::RenderStyle::getBorderRadiiForRect): New bottleneck method to fetch corner radiil given a rect, applying the constraint rules.

LayoutTests:

2009-05-28 Simon Fraser <Simon Fraser>

Reviewed by Oliver Hunt.


​https://bugs.webkit.org/show_bug.cgi?id=8736

  • fast/borders/border-radius-constraints.html: Added.
  • platform/mac/fast/borders/border-radius-constraints-expected.checksum: Added.
  • platform/mac/fast/borders/border-radius-constraints-expected.png: Added.
  • platform/mac/fast/borders/border-radius-constraints-expected.txt: Added.


Test that corner radii are constrained according to CSS3 rules.

  • fast/borders/border-radius-huge-assert.html:
  • platform/mac/fast/borders/border-radius-huge-assert-expected.checksum:
  • platform/mac/fast/borders/border-radius-huge-assert-expected.png:
  • platform/mac/fast/borders/border-radius-huge-assert-expected.txt:


Now that we constrain border-radius, update the text of the test, and the
expected result.


  • fast/borders/border-radius-split-inline.html: Added.
  • platform/mac/fast/borders/border-radius-split-inline-expected.checksum: Added.
  • platform/mac/fast/borders/border-radius-split-inline-expected.png: Added.
  • platform/mac/fast/borders/border-radius-split-inline-expected.txt: Added.


New test for border-radius on a split inline.


  • fast/box-shadow/border-radius-big.html:
  • platform/mac/fast/box-shadow/border-radius-big-expected.checksum:
  • platform/mac/fast/box-shadow/border-radius-big-expected.png:
  • platform/mac/fast/box-shadow/border-radius-big-expected.txt:

Now that we constrain border-radius, update the text of the test, and the
expected result.

9:50 AM Changeset in webkit [44234] by bfulgham@webkit.org
  • 2 edits in trunk/WebKitTools

2009-05-28 Olivier DOLE <​odole@pleyo.com>

Reviewed by Maciej.

Add options to sunspider-compare-results to know which test suite to
compare (see bug #15941).

  • Scripts/sunspider-compare-results:
9:46 AM Changeset in webkit [44233] by mitz@apple.com
  • 3 edits in branches/WWDC-2009-branch/WebCore

Windows build fix after r44178

9:23 AM Changeset in webkit [44232] by ap@webkit.org
  • 9 edits
    2 adds in trunk

Reviewed by Darin Adler.

​https://bugs.webkit.org/show_bug.cgi?id=26005
Optimization for XPath * does not preserve context size

Test: fast/xpath/position.html

Fixed the bug by removing the incorrect optimization, and made enough micro-optimizations to
get a performance progression on my tests.

  • xml/XPathPath.h: Removed broken optimizeStepPair().
  • xml/XPathPath.cpp: (WebCore::XPath::LocationPath::evaluate): Style fix. (WebCore::XPath::LocationPath::appendStep): Don't call optimizeStepPair(). (WebCore::XPath::LocationPath::insertFirstStep): Ditto. (WebCore::XPath::Path::Path): Style fix.
  • xml/XPathStep.cpp: (WebCore::XPath::primaryNodeType): Turned this member function into a static inline helper. (WebCore::XPath::nodeMatches): Ditto. Don't check for namespace axis, which is unsupported (and might never be). (WebCore::XPath::Step::nodesInAxis): Updated for the new nodeMatches() signature.
  • xml/XPathStep.h: (WebCore::XPath::Step::NodeTest::data): (WebCore::XPath::Step::NodeTest::namespaceURI): Made these data members AtomicString to avoid repeated conversions. This is the biggest performance win here.
  • xml/XPathUtil.cpp: (WebCore::XPath::stringValue): Reserve some capacity upfront.
9:20 AM Changeset in webkit [44231] by Dimitri Glazkov
  • 2 edits in trunk/WebCore

2009-05-28 Stephen White <​senorblanco@chromium.org>

Reviewed by Dimitri Glazkov.

When creating a linear or radial gradient with a single stop
at offset 1.0, the Skia layer was allocating 3 stops, but only
filling 2, leaving one uninitialized. Only 2 stops are necessary
in this case, at offsets (0.0, 1.0).

​http://bugs.webkit.org/show_bug.cgi?id=26063

Covered by: LayoutTests/svg/W3C-SVG-1.1/pservers-grad-16-b.svg

LayoutTests/svg/custom/gradient-stop-corner-cases.svg
LayoutTests/svg/custom/js-late-gradient-and-object-creation.svg

  • platform/graphics/skia/GradientSkia.cpp: (WebCore::totalStopsNeeded):
9:14 AM Changeset in webkit [44230] by Dimitri Glazkov
  • 8 edits in trunk/WebCore

2009-05-28 Yury Semikhatsky <​yurys@chromium.org>

Reviewed by Timothy Hatcher.

​https://bugs.webkit.org/show_bug.cgi?id=26041
Allow adding resource source to WebInspector.SourceFrame asynchronously.

Provide common implementation for InspectorController::addResourceSourceToFrame and
InspectorController::addSourceToFrame methods.

  • bindings/js/JSInspectorControllerCustom.cpp:
  • bindings/v8/custom/V8InspectorControllerCustom.cpp:
  • inspector/InspectorController.cpp: (WebCore::InspectorController::addResourceSourceToFrame):
  • inspector/InspectorController.h:
  • inspector/InspectorController.idl:
  • inspector/front-end/SourceFrame.js: (WebInspector.SourceFrame.prototype.revealLine): (WebInspector.SourceFrame.prototype.highlightLine): (WebInspector.SourceFrame.prototype._loaded): (WebInspector.SourceFrame.prototype._isContentLoaded):
  • inspector/front-end/SourceView.js: (WebInspector.SourceView.prototype.setupSourceFrameIfNeeded): (WebInspector.SourceView.prototype._contentLoaded):
8:45 AM Changeset in webkit [44229] by xan@webkit.org
  • 2 edits in trunk

2009-05-28 Xan Lopez <​xlopez@igalia.com>

Bump version numbers in preparation for 1.1.8 release.

  • configure.ac:
7:52 AM Changeset in webkit [44228] by xan@webkit.org
  • 6 edits in trunk/WebKit/gtk

2009-05-27 Xan Lopez <​xlopez@igalia.com>

Reviewed by Gustavo Noronha.

​https://bugs.webkit.org/show_bug.cgi?id=26039
[GTK] WebKitWebHistoryItem lifetime fixes

Modify the management of history items by the BackForward list.

Having the objects add themselves to a hash table with an extra
reference made impossible for the cleanup code in the dispose
method to be ever called in normal conditions, since dispose is
called before getting rid of the last reference, which the objects
were making to themselves. Get rid of this extra reference and
move the responsibility of the cleanup to the BackForward list
itself, which effectively owns the WebKitWebHistoryItems now.

Also, update the tests to reflect this change.

  • tests/testwebbackforwardlist.c: (test_webkit_web_history_item_lifetime): (test_webkit_web_back_forward_list_order): (test_webkit_web_back_forward_list_add_item):
  • tests/testwebhistoryitem.c: (web_history_item_fixture_setup): (web_history_item_fixture_teardown):
  • webkit/webkitprivate.h:
  • webkit/webkitwebbackforwardlist.cpp: (webkit_web_back_forward_list_dispose): (webkit_web_back_forward_list_class_init):
  • webkit/webkitwebhistoryitem.cpp: (webkit_history_items): (webkit_history_item_add): (webkit_web_history_item_dispose): (WebKit::kit):
7:52 AM Changeset in webkit [44227] by xan@webkit.org
  • 2 edits in trunk/WebKit/gtk

2009-05-26 Xan Lopez <​xlopez@igalia.com>

Reviewed by Jan Alonzo.

​https://bugs.webkit.org/show_bug.cgi?id=26039
[GTK] WebKitWebHistoryItem lifetime fixes

Delete the BackForwardList before the Page, otherwise the references
to the WebKitWebHistoryItems will be gone.

  • webkit/webkitwebview.cpp: (webkit_web_view_dispose):
5:04 AM Changeset in webkit [44226] by zecke@webkit.org
  • 2 edits in trunk/WebCore

2009-05-28 Holger Hans Peter Freyther <​zecke@selfish.org>

Reviewed by Xan Lopez.

After r44177 we had a problem when increasing the size
of the window the scrollbars stayed and were not hidden.
This was due WebCore giving up on the Scrollbar as it became
unnecessary but the GtkAdjustment remained unchanged.
So from the point of view of the GtkScrolledWindow scrolling
was still necessary and the GtkScrollbar kept being displayed.

Solve the issue by resetting the GtkAdjustment in the
destructor of ScrollbarGtk.

  • platform/gtk/ScrollbarGtk.cpp: (ScrollbarGtk::~ScrollbarGtk):
1:04 AM Changeset in webkit [44225] by abarth@webkit.org
  • 7 edits
    2 adds in trunk

WebCore:

2009-05-28 Adam Barth <​abarth@webkit.org>

Reviewed by Darin Adler.

Clean up window.open()'s use of lexical and dynamic scope.

(Added one unreviewed tweak: use dynamicFrame instead of lexicalFrame
for DOMWindow::allowPopUp.)

Test: http/tests/security/frameNavigation/context-for-window-open.html

  • bindings/js/JSDOMBinding.cpp: (WebCore::toDynamicFrame): (WebCore::processingUserGesture): (WebCore::completeURL):
  • bindings/js/JSDOMBinding.h:
  • bindings/js/JSDOMWindowCustom.cpp: (WebCore::createWindow): (WebCore::JSDOMWindow::open): (WebCore::JSDOMWindow::showModalDialog):
  • bindings/v8/custom/V8DOMWindowCustom.cpp: (WebCore::CALLBACK_FUNC_DECL): (WebCore::createWindow):

LayoutTests:

2009-05-28 Adam Barth <​abarth@webkit.org>

Reviewed by Darin Adler.

Test whether lexical or dynamic scope is used for window.open().

  • http/tests/security/frameNavigation/context-for-window-open-expected.txt: Added.
  • http/tests/security/frameNavigation/context-for-window-open.html: Added.
  • http/tests/security/frameNavigation/resources/middle-frame-for-location.html:
12:31 AM Changeset in webkit [44224] by abarth@webkit.org
  • 886 edits
    2 deletes in trunk

Revert 44221.

May 27, 2009:

11:36 PM Changeset in webkit [44223] by mrowe@apple.com
  • 1 edit in trunk/WebKitLibraries/libWebKitSystemInterfaceSnowLeopard.a

Fix MIME type.

11:31 PM Changeset in webkit [44222] by mrowe@apple.com
  • 5 edits
    1 add in trunk

Update build-webkit to handle a new version of WebKitSystemInterface.

Rubber-stamped by Dan Bernstein.

  • Scripts/build-webkit:

Update WebKitSystemInterface.

  • libWebKitSystemInterfaceLeopard.a:
  • libWebKitSystemInterfaceSnowLeopard.a: Added.
  • libWebKitSystemInterfaceTiger.a:
11:25 PM Changeset in webkit [44221] by abarth@webkit.org
  • 7 edits
    2 adds in trunk

WebCore:

2009-05-27 Adam Barth <​abarth@webkit.org>

Reviewed by Darin Adler.

Clean up window.open()'s use of lexical and dynamic scope.

Test: http/tests/security/frameNavigation/context-for-window-open.html

  • bindings/js/JSDOMBinding.cpp: (WebCore::toDynamicFrame): (WebCore::processingUserGesture): (WebCore::completeURL):
  • bindings/js/JSDOMBinding.h:
  • bindings/js/JSDOMWindowCustom.cpp: (WebCore::createWindow): (WebCore::JSDOMWindow::open): (WebCore::JSDOMWindow::showModalDialog):
  • bindings/v8/custom/V8DOMWindowCustom.cpp: (WebCore::CALLBACK_FUNC_DECL): (WebCore::createWindow):

LayoutTests:

2009-05-27 Adam Barth <​abarth@webkit.org>

Reviewed by Darin Adler.

Test whether lexical or dynamic scope is used for window.open().

  • http/tests/security/frameNavigation/context-for-window-open-expected.txt: Added.
  • http/tests/security/frameNavigation/context-for-window-open.html: Added.
  • http/tests/security/frameNavigation/resources/middle-frame-for-location.html:
11:02 PM Changeset in webkit [44220] by ap@webkit.org
  • 2 edits in trunk/WebCore

Reviewed by Oliver Hunt.

​https://bugs.webkit.org/show_bug.cgi?id=26056
XPath string() function can be very slow

  • xml/XPathUtil.cpp: (WebCore::XPath::stringValue): Use an intermediate Vector when appending.
10:30 PM Changeset in webkit [44219] by mjs@apple.com
  • 2 edits in trunk/WebKitSite

2009-05-27 Maciej Stachowiak <​mjs@apple.com>

Not reviewed, demo content.


  • Add doctype to Calendar demo.
  • demos/calendar/Calendar.html:
10:25 PM Changeset in webkit [44218] by mitz@apple.com
  • 7 edits
    4 adds in trunk

WebCore:

Reviewed by Sam Weinig.

  • fix <rdar://problem/6927761> <isindex> placeholder text is unstylable and initially not visible

Test: fast/forms/isindex-placeholder.html

  • css/html4.css: Added a default style for <isindex> placeholder text.
  • html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::parseMappedAttribute): Changed to call the new protected function updatePlaceholderVisibility().
  • html/HTMLInputElement.h: (WebCore::HTMLInputElement::updatePlaceholderVisibility): Added this protected function to allow HTMLIsIndexElement::parseMappedAttribute() to invoke InputElement::updatePlaceholderVisibility().
  • html/HTMLIsIndexElement.cpp: (WebCore::HTMLIsIndexElement::parseMappedAttribute): Call updatePlaceholderVisibility() when parsing the placeholder attribute.
  • rendering/RenderTextControlSingleLine.cpp: (WebCore::RenderTextControlSingleLine::createInnerTextStyle): If there is no placeholder pseudo-element style, use the normal style.

LayoutTests:

Reviewed by Sam Weinig.

  • test for <rdar://problem/6927761> <isindex> placeholder text is unstylable and initially not visible
  • fast/forms/isindex-placeholder.html: Added.
  • platform/mac/fast/forms/isindex-placeholder-expected.checksum: Added.
  • platform/mac/fast/forms/isindex-placeholder-expected.png: Added.
  • platform/mac/fast/forms/isindex-placeholder-expected.txt: Added.
10:06 PM Changeset in webkit [44217] by weinig@apple.com
  • 7 edits in trunk/WebCore

2009-05-27 Sam Weinig <​sam@webkit.org>

Reviewed by Maciej Stachowiak.

More cleanup of DOMWindow related functions.

  • bindings/js/JSDOMWindowBase.cpp: (WebCore::JSDOMWindowBase::willRemoveFromWindowShell): Renamed from JSDOMWindowBase::clear()
  • bindings/js/JSDOMWindowBase.h:
  • bindings/js/JSDOMWindowCustom.cpp: (WebCore::JSDOMWindow::showModalDialog): Update Comment.
  • bindings/js/JSDOMWindowShell.cpp:
  • bindings/js/JSDOMWindowShell.h: Remove JSDOMWindowShell::clear(). It was unused.
  • bindings/js/ScriptController.cpp: (WebCore::ScriptController::clearWindowShell):
8:36 PM Changeset in webkit [44216] by oliver@apple.com
  • 4 edits in trunk

<rdar://problem/6928025> Stack overflow in JSC::stringProtoFuncReplace() running jsFunFuzz

Reviewed by Mark Rowe

Add an additional exception check for stack overflow in String.replace

8:17 PM Changeset in webkit [44215] by weinig@apple.com
  • 7 edits in trunk/WebCore

2009-05-27 Sam Weinig <​sam@webkit.org>

Reviewed by David Hyatt.

Miscellaneous cleanup of DOMWindow related functions.

  • bindings/js/JSDOMGlobalObject.cpp: (WebCore::JSDOMGlobalObject::~JSDOMGlobalObject): Fix poorly named variables.
  • bindings/js/JSDOMWindowBase.cpp: (WebCore::JSDOMWindowBase::supportsProfiling): Don't jump through hoops checking for null frames if the build does not support profiling. (WebCore::JSDOMWindowBase::clear): Use setCurrentEvent(0) instead of calling clearHelperObjectProperties(). It is clearer.
  • bindings/js/JSDOMWindowBase.h: Removed now unused clearHelperObjectProperties() function, empty disconnectFrame() function, and the empty destructor.
  • bindings/js/JSDOMWindowShell.cpp:
  • bindings/js/JSDOMWindowShell.h: Remove disconnectFrame() which only called JSDOMWindowBase::disconnectFrame(), which is a no-op.
  • page/Frame.cpp: (WebCore::Frame::~Frame): (WebCore::Frame::pageDestroyed): Remove calls to JSDOMWindowShell::disconnectFrame() which only called JSDOMWindowBase::disconnectFrame(), which is a no-op.
6:50 PM Changeset in webkit [44214] by mrowe@apple.com
  • 4 edits in branches/WWDC-2009-branch

Versioning.

6:49 PM Changeset in webkit [44213] by mrowe@apple.com
  • 1 copy in tags/Safari-6530.13

New tag.

5:28 PM Changeset in webkit [44212] by mrowe@apple.com
  • 2 edits in branches/WWDC-2009-branch/WebKit/mac

Merge r44194.

5:27 PM Changeset in webkit [44211] by mrowe@apple.com
  • 2 edits in branches/WWDC-2009-branch/WebCore

Merge r44189.

5:27 PM Changeset in webkit [44210] by mrowe@apple.com
  • 7 edits in branches/WWDC-2009-branch

Merge r44181.

5:27 PM Changeset in webkit [44209] by mrowe@apple.com
  • 6 edits
    3 adds in branches/WWDC-2009-branch

Merge r44174.

5:27 PM Changeset in webkit [44208] by mrowe@apple.com
  • 2 edits in branches/WWDC-2009-branch/WebKit/mac

Merge r44172.

5:27 PM Changeset in webkit [44207] by mrowe@apple.com
  • 11 edits in branches/WWDC-2009-branch

Merge r44170.

5:27 PM Changeset in webkit [44206] by mrowe@apple.com
  • 2 edits in branches/WWDC-2009-branch/JavaScriptCore

Merge r44169.

5:27 PM Changeset in webkit [44205] by mrowe@apple.com
  • 2 edits in branches/WWDC-2009-branch/WebKit/mac

Merge r44164.

5:27 PM Changeset in webkit [44204] by mrowe@apple.com
  • 2 edits in branches/WWDC-2009-branch/WebKit/mac

Merge r44122.

5:13 PM Changeset in webkit [44203] by kov@webkit.org
  • 2 edits in trunk/WebKit/gtk

2009-05-27 Gustavo Noronha Silva <Gustavo Noronha Silva>

Reviewed by Xan Lopez.

Add comment to clarify why scrolling is done as it is and not with
gdk_window_scroll.

  • WebCoreSupport/ChromeClientGtk.cpp: (WebKit::ChromeClient::scroll):
3:16 PM Changeset in webkit [44202] by Dimitri Glazkov
  • 2 edits in trunk/WebCore

2009-05-27 Dimitri Glazkov <Dimitri Glazkov>

Unreviewed, build fix.

​https://bugs.webkit.org/show_bug.cgi?id=25974
Remove extra qualifiers from the ScheduledAction decl.

  • bindings/v8/ScheduledAction.h: Removed extraneous class qualifiers.
2:23 PM Changeset in webkit [44201] by kov@webkit.org
  • 2 edits in trunk/WebCore

2009-05-27 Gustavo Noronha Silva <​gustavo.noronha@collabora.co.uk>

Unreviewed make distcheck fix. One more missing file.

  • GNUmakefile.am:
2:09 PM Changeset in webkit [44200] by Simon Hausmann
  • 2 edits in trunk/WebCore

2009-05-27 Antonio Gomes <​antonio.gomes@openbossa.org>

Reviewed by Simon Hausmann.

[Qt] Fixed trunk build on Linux after r44126.

1:46 PM Changeset in webkit [44199] by eric.carlson@apple.com
  • 2 edits in trunk/WebCore

2009-05-27 Eric Carlson <​eric.carlson@apple.com>

Reviewed by Oliver Hunt.

<rdar://problem/6926046> REGRESSION (r43972): ​http://www.youtube.com/html5 crashes on open

  • platform/graphics/MediaPlayer.cpp: (WebCore::MediaPlayer::load): Don't look for a media engine based on an empty MIME type.
1:04 PM Changeset in webkit [44198] by mjs@apple.com
  • 1 edit
    18 adds in trunk/WebKitSite

2009-05-27 Maciej Stachowiak <​mjs@apple.com>

Not reviewed, demo content.


  • add Calendar demo.
  • demos/calendar: Added.
  • demos/calendar/Boom.aiff: Added.
  • demos/calendar/Calendar.css: Added.
  • demos/calendar/Calendar.html: Added.
  • demos/calendar/Calendar.js: Added.
  • demos/calendar/Calendar.manifest: Added.
  • demos/calendar/CalendarApp.icns: Added.
  • demos/calendar/Images: Added.
  • demos/calendar/Images/AirPort4.png: Added.
  • demos/calendar/Images/AirPortError.png: Added.
  • demos/calendar/Images/disclosureTriangleSmallDown.png: Added.
  • demos/calendar/Images/disclosureTriangleSmallRight.png: Added.
  • demos/calendar/Images/statusbarBackground.png: Added.
  • demos/calendar/Images/statusbarResizerVertical.png: Added.
  • demos/calendar/LocationImage.js: Added.
  • demos/calendar/Utilities.js: Added.
  • demos/calendar/favicon.ico: Added.
  • demos/calendar/mime.types: Added.
12:20 PM Changeset in webkit [44197] by kov@webkit.org
  • 2 edits in trunk/JavaScriptCore

2009-05-27 Gustavo Noronha Silva <​gustavo.noronha@collabora.co.uk>

Unreviewed (make distcheck) build fix; adding missing headers.

  • GNUmakefile.am:
12:14 PM Changeset in webkit [44196] by jberlin@apple.com
  • 3 edits in trunk/JavaScriptCore

2009-05-27 Jessie Berlin <​jberlin@apple.com>

Reviewed by aroben


Fix the Windows build.

12:03 PM Changeset in webkit [44195] by levin@chromium.org
  • 3 edits in trunk/WebCore

2009-05-27 David Levin <​levin@chromium.org>

Reviewed by Maciej Stachowiak.

Bug 26029: FrameLoader::canLoad should allow calls with just a security origin
​https://bugs.webkit.org/show_bug.cgi?id=26029

No functional changes, so no tests.

  • loader/FrameLoader.cpp: (WebCore::FrameLoader::canLoad):
  • loader/FrameLoader.h:
11:01 AM Changeset in webkit [44194] by ap@webkit.org
  • 2 edits in trunk/WebKit/mac

Reviewed by Darin Adler.

​https://bugs.webkit.org/show_bug.cgi?id=26009
<rdar://problem/6925656> REGRESSION (r43973): Problems While Working With OpenVanilla

  • WebView/WebHTMLView.mm: (-[WebHTMLView _updateSelectionForInputManager]): Don't call updateWindows if the selection is None. This routinely happens during editing, and it doesn't mean that we left an editable area (in which case the selection changes to a non-editable one).
10:57 AM Changeset in webkit [44193] by kov@webkit.org
  • 2 edits in trunk/WebCore

2009-05-27 Gustavo Noronha Silva <​gustavo.noronha@collabora.co.uk>

Unreviewed build fix.

Remove file that does not exist from the build.

  • GNUmakefile.am:
10:33 AM Changeset in webkit [44192] by Nikolas Zimmermann
  • 3 edits in trunk/WebCore

Reviewed by Darin Adler.

Remove two unneeded protected constructors, these classes have pure-virtual functions, and can't be constructed anyway.

10:27 AM Changeset in webkit [44191] by kov@webkit.org
  • 2 edits in trunk/WebKit/gtk

2009-05-27 Gustavo Noronha Silva <​gustavo.noronha@collabora.co.uk>

Unreviewed. Adding new symbols index for 1.1.8.

  • docs/webkitgtk-docs.sgml:
10:21 AM Changeset in webkit [44190] by ap@webkit.org
  • 3 edits
    2 adds in trunk

Reviewed by Darin Adler.

​https://bugs.webkit.org/show_bug.cgi?id=17725
XPath should be case insensitive for HTML

Test: fast/xpath/node-name-case-sensitivity.html

  • xml/XPathStep.cpp: (WebCore::XPath::Step::nodeMatches): Made node name check case insensitive for HTML elements in HTML documents.
10:00 AM Changeset in webkit [44189] by sullivan@apple.com
  • 2 edits in trunk/WebCore

2009-05-27 John Sullivan <​sullivan@apple.com>

fixed <rdar://problem/6925482> repro crash in WebCore::DragController::dragExited dropping
bookmarks (at least) over Top Sites (at least)

Reviewed by Kevin Decker

  • page/DragController.cpp: (WebCore::DragController::dragExited): nil check m_documentUnderMouse and take the "local file" case if it's nil
7:02 AM Changeset in webkit [44188] by kov@webkit.org
  • 4 edits in trunk

WebCore and JavaScriptCore

2009-05-27 Fridrich Strba <​fridrich.strba@bluewin.ch>

Reviewed by Gustavo Noronha.

When building on Windows, consider Windows specific files.

  • GNUmakefile.am:
5:25 AM Changeset in webkit [44187] by Nikolas Zimmermann
  • 5 edits in trunk/WebCore

Reviewed by George Staikos.

Fixes: ​https://bugs.webkit.org/show_bug.cgi?id=26031

InputElementData is too heavy, save storing two pointers by passing them
directly to the static helper functions (the only place which needs them).

5:23 AM Changeset in webkit [44186] by Nikolas Zimmermann
  • 5 edits in trunk/WebCore

Reviewed by George Staikos.

Fixes: ​https://bugs.webkit.org/show_bug.cgi?id=26033

OptionElementData saves an Element pointer, which is unnessary.
Just pass it to the static function calls directly.

5:17 AM Changeset in webkit [44185] by kov@webkit.org
  • 2 edits in trunk/LayoutTests

2009-05-27 Gustavo Noronha Silva <​gustavo.noronha@collabora.co.uk>

Disabling new tests to make the bot green.

  • platform/gtk/Skipped:
5:04 AM Changeset in webkit [44184] by kov@webkit.org
  • 6 edits in trunk

2009-05-27 Fridrich Strba <​fridrich.strba@bluewin.ch>

Reviewed by Maciej Stachowiak.

When building with MinGW, don't use the declspec(dl{import,export})
decorations and rely on the linker to use its nifty auto-import feature.
It is extremely hard to get the decorations right with MinGW in general
and impossible in WebKit, where the resulting shared library is linking
together some static libraries.

3:21 AM Changeset in webkit [44183] by zecke@webkit.org
  • 9 edits
    2 adds in trunk

JavaScripCore:
2009-05-26 Holger Hans Peter Freyther <​zecke@selfish.org>

Reviewed by Xan Lopez.

​https://bugs.webkit.org/show_bug.cgi?id=25613

Be able to use GOwnPtr for GHashTable as well. The assumption
is that the hash table has been created with g_hash_table_new_full
and has proper destruction functions.

  • wtf/GOwnPtr.cpp: (WTF::GHashTable):
  • wtf/GOwnPtr.h:

WebCore:
2009-05-26 Holger Hans Peter Freyther <​zecke@selfish.org>

Reviewed by Xan Lopez.

​https://bugs.webkit.org/show_bug.cgi?id=25613

Add a WebCore::Widget that can embed GtkWidget with and
without a GdkWindow. This can be used to embed any GtkWidget.

Some bits are directly copied from the Scrollbar implementation
but can not be easily shared here.

  • GNUmakefile.am:
  • platform/gtk/GtkPluginWidget.cpp: Added. (WebCore::GtkPluginWidget::GtkPluginWidget): (WebCore::GtkPluginWidget::invalidateRect): (WebCore::GtkPluginWidget::frameRectsChanged): (WebCore::GtkPluginWidget::paint):
  • platform/gtk/GtkPluginWidget.h: Added.

WebKit:
2009-05-26 Holger Hans Peter Freyther <​zecke@selfish.org>

Reviewed by Xan Lopez.

​https://bugs.webkit.org/show_bug.cgi?id=25613

Add a new signal called "create-plugin-widget" and emit it from
within the FrameLoaderClientGtk::createPlugin method. If a
GtkWidget gets returned it will be embedded as a WebCore::Widget
using the new GtkPluginWidget.

  • WebCoreSupport/FrameLoaderClientGtk.cpp: (WebKit::FrameLoaderClient::createPlugin):
  • webkit/webkitwebview.cpp: (webkit_signal_accumulator_object_handled): (webkit_web_view_class_init):
  • webkitmarshal.list:
3:21 AM Changeset in webkit [44182] by zecke@webkit.org
  • 2 edits in trunk/WebCore

2009-05-26 Holger Hans Peter Freyther <​zecke@selfish.org>

Reviewed by Gustavo Noronha.

​https://bugs.webkit.org/show_bug.cgi?id=25613

Implement Widget::setIsSelected for Gtk+ by searching
for a property of the name "webkit-widget-is-selected" and if
such property exists we are going to set it. We expect
the property to take a boolean.

  • platform/gtk/WidgetGtk.cpp: (WebCore::Widget::setIsSelected):
Note: See TracTimeline for information about the timeline view.