⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



May 29, 2009:

6:38 PM Changeset in webkit [44283] by Nikolas Zimmermann
  • 22 edits
    6 adds in trunk

Reviewed by George Staikos.

Fixes: ​https://bugs.webkit.org/show_bug.cgi?id=26072

Add support for the last missing WML element: <select>. This patch adds WMLSelectElement, providing
the same functionality HTMLSelectElement has. The WML specific features will follow soon.

Add simple testcase covering <select> element rendering: fast/wml/select.wml

3:55 PM Changeset in webkit [44282] by jmalonzo@webkit.org
  • 2 edits in trunk/WebKit/gtk

2009-05-29 Jan Michael Alonzo <​jmalonzo@webkit.org>

Reviewed by Gustavo Noronha.

Fixed compile warning when comparing the different navigation types

  • webkit/webkitwebnavigationaction.cpp: (webkit_web_navigation_action_class_init):
3:42 PM Changeset in webkit [44281] by levin@chromium.org
  • 2 edits in trunk/WebCore

2009-05-29 David Levin <​levin@chromium.org>

Reviewed by NOBODY (build fix for windows).

​http://trac.webkit.org/changeset/44279 left in a "Vector<WCHAR> localeNameBuf"
that it was trying to replace. Resulting in this variable being defined twice (and
the second time incorrectly).

  • platform/win/Language.cpp: (WebCore::localeInfo):
3:02 PM Changeset in webkit [44280] by levin@chromium.org
  • 2 edits in trunk/WebCore

2009-05-29 Takeshi Yoshino <​tyoshino@google.com>

Reviewed by Darin Alder.

​https://bugs.webkit.org/show_bug.cgi?id=26018

Fix behavior of the Element View of the Web Inspector for double
clicking the element outline tree.

Double clicking the element outline tree should
1) on attribute: enter attribute editing mode
2) on text: enter text editing mode
3) otherwise: change root node to the parent element of double clicked

element.

Now, 3) is broken. For example, clicking <html> clears the element
outline view.

rootDOMNode should be updated to this.representedObject.parentNode, not
this.parent.representedObject which is parent inside the element
outline tree itself.

  • inspector/front-end/ElementsTreeOutline.js: (WebInspector.ElementsTreeElement.prototype.ondblclick):
3:02 PM Changeset in webkit [44279] by levin@chromium.org
  • 9 edits in trunk/WebCore

2009-05-29 David Moore <​davemoore@google.com>

Reviewed by Darin Alder.

​https://bugs.webkit.org/show_bug.cgi?id=26001
Change many of the uses of String::adopt() to String::createUninitialized().
This allows those strings to use an inlined buffer for their characters.

  • dom/StyleElement.cpp: Loop over nodes to precompute length of string and then write the characters into the allocated inline buffer (WebCore::StyleElement::process):
  • dom/Text.cpp: Loop over nodes to precompute length of string and then write the characters into the allocated inline buffer (WebCore::Text::wholeText): (WebCore::Text::rendererIsNeeded): (WebCore::Text::createRenderer): (WebCore::Text::createWithLengthLimit): (WebCore::Text::formatForDebugger):
  • platform/text/String.cpp: (WebCore::String::append): (WebCore::String::insert): (WebCore::String::truncate): (WebCore::String::remove):
  • platform/text/StringBuilder.cpp: (WebCore::StringBuilder::toString):
  • platform/text/StringImpl.cpp: (WebCore::StringImpl::lower): (WebCore::StringImpl::upper): (WebCore::StringImpl::secure): (WebCore::StringImpl::foldCase): (WebCore::StringImpl::replace):
  • platform/text/TextCodecLatin1.cpp: (WebCore::TextCodecLatin1::decode):
  • platform/text/TextCodecUserDefined.cpp: (WebCore::TextCodecUserDefined::decode):
  • platform/win/Language.cpp: (WebCore::localeInfo):
3:02 PM Changeset in webkit [44278] by levin@chromium.org
  • 3 edits
    4 adds in trunk

WebCore:

2009-05-29 Takeshi Yoshino <​tyoshino@google.com>

Reviewed by Darin Alder.

Bug 25911: Apply href in base elements to anchors shown on the source viewer
​https://bugs.webkit.org/show_bug.cgi?id=25911

In rendering HTML sources, parse base elements to apply the base URI to
anchors shown on the source viewer.

This issue was originally reported to the Chromium issue tracker.
​http://code.google.com/p/chromium/issues/detail?id=2418

Test: fast/frames/viewsource-link-on-href-value.html

  • html/HTMLViewSourceDocument.cpp: (WebCore::HTMLViewSourceDocument::addViewSourceToken):

LayoutTests:

2009-05-29 Takeshi Yoshino <​tyoshino@google.com>

Reviewed by Darin Alder.

Bug 25911: Apply href in base elements to anchors shown on the source viewer
​https://bugs.webkit.org/show_bug.cgi?id=25911

In rendering HTML sources, parse base elements to apply the base URI to
anchors shown on the source viewer.

Add tests to verify this change.

This issue was originally reported to the Chromium issue tracker.
​http://code.google.com/p/chromium/issues/detail?id=2418

  • fast/frames/resources/viewsource-frame-3.html: Added.
  • fast/frames/resources/viewsource-frame-4.html: Added.
  • fast/frames/viewsource-link-on-href-value-expected.txt: Added.
  • fast/frames/viewsource-link-on-href-value.html: Added.
3:02 PM Changeset in webkit [44277] by levin@chromium.org
  • 3 edits
    2 adds in trunk

WebCore:

2009-05-29 Rob Buis <​rwlbuis@gmail.com>

Reviewed by David Hyatt.

​https://bugs.webkit.org/show_bug.cgi?id=22429
document.styleSheets collection ignores media=presentation

Ensure that stylesheets though <link> show up in document.styleSheets regardless of media attribute.

Test: fast/css/sheet-collection-link.html

  • html/HTMLLinkElement.cpp: (WebCore::HTMLLinkElement::process):

LayoutTests:

2009-05-29 Rob Buis <​rwlbuis@gmail.com>

Reviewed by David Hyatt.

Testcase for:
​https://bugs.webkit.org/show_bug.cgi?id=22429
document.styleSheets collection ignores media=presentation

  • fast/css/sheet-collection-link.html: Added.
  • fast/css/sheet-collection-link-expected.txt: Added.
3:02 PM Changeset in webkit [44276] by levin@chromium.org
  • 4 edits in trunk/WebCore

2009-05-29 Itai Danan <​idanan@chromium.org>

Reviewed by Jon Honeycutt.

Bug 24791: Should have a preference to disable auto scrolling
​https://bugs.webkit.org/show_bug.cgi?id=24791

To understand why this is required see the discussion in
issue 24722 (​https://bugs.webkit.org/show_bug.cgi?id=24722).

The code review was done in ​https://bugs.webkit.org/show_bug.cgi?id=21794.

  • page/EventHandler.cpp: (WebCore::EventHandler::handleMousePressEvent): Use autoscroll behavior flag to determine if autoscroll needs to be released on this event. (WebCore::EventHandler::handleMouseReleaseEvent): Use autoscroll behavior flag to determine if autoscroll needs to be released on this event (reverse logic of for Press event).
  • page/Settings.cpp: (WebCore::Settings::Settings): Initialize autoscroll behavior setting.
  • page/Settings.h: (WebCore::Settings::setUsesStickyPanScroll): Autoscroll behavior setting setter. (WebCore::Settings::usesStickyPanScroll): Autoscroll behavior setting getter.
2:58 PM Changeset in webkit [44275] by jianli@chromium.org
  • 3 edits
    3 adds in trunk

WebCore:

2009-05-29 Jian Li <​jianli@chromium.org>

Reviewed by Dimitri Glazkov.

​https://bugs.webkit.org/show_bug.cgi?id=26069
Fix a crash in custom V8 bindings code for XMLHttpRequest.

Test: fast/xmlhttprequest/xmlhttprequest-open-after-iframe-onload-remove-self.html

  • bindings/v8/custom/V8XMLHttpRequestCustom.cpp: (WebCore::CALLBACK_FUNC_DECL):

LayoutTests:

2009-05-29 Jian Li <​jianli@chromium.org>

Reviewed by Dimitri Glazkov.

​https://bugs.webkit.org/show_bug.cgi?id=26069
Test for the above bug.

  • fast/xmlhttprequest/resources/xmlhttprequest-open-after-iframe-onload-remove-self-child.html: Added.
  • fast/xmlhttprequest/xmlhttprequest-open-after-iframe-onload-remove-self-expected.txt: Added.
  • fast/xmlhttprequest/xmlhttprequest-open-after-iframe-onload-remove-self.html: Added.
2:38 PM Changeset in webkit [44274] by bfulgham@webkit.org
  • 2 edits in trunk/WebCore

2009-05-29 David Levin <​levin@chromium.org>

Reviewed by Darin Adler.

Bug 26074: SQLTransaction::executeSQL does an unnecessary call to String::copy.
​https://bugs.webkit.org/show_bug.cgi?id=26074

The constructor for SQLStatement already does a copy for this string.

  • storage/SQLTransaction.cpp: (WebCore::SQLTransaction::executeSQL):
1:53 PM Changeset in webkit [44273] by Adam Roben
  • 2 edits in trunk/WebKit/win

Implement WebFrame::startDownload

Fixes the WebKit side of Bug 25729: Alt-clicking a link doesn't start
a download <​https://bugs.webkit.org/show_bug.cgi?id=25729>. Fixing
this all the way will require a change in Safari.

Reviewed by Darin Adler.

  • WebFrame.cpp: (WebFrame::startDownload): Call through to WebView::downloadURL.
1:51 PM Changeset in webkit [44272] by Darin Adler
  • 3 edits in trunk/WebCore

2009-05-29 Darin Adler <Darin Adler>

Fix build; the new Cairo code compiled on Windows only.

  • platform/graphics/gtk/FontPlatformData.h: Added syntheticBold and syntheticOblique functions as in the Windows version to make it easier to use this cross-platform. Later we can make data members private as in the Windows version.
  • platform/graphics/mac/FontPlatformData.h: Ditto.
1:48 PM Changeset in webkit [44271] by Adam Roben
  • 4 edits in trunk/WebKit/win

Move WebContextMenuClient's downloading code to WebView

This will allow other code to trigger downloads using this code, and
matches Mac.

Reviewed by Darin Adler.

  • WebCoreSupport/WebContextMenuClient.cpp: (WebContextMenuClient::downloadURL): Moved code from here...
  • WebView.cpp: (WebView::downloadURL): ...to here. Also tightened up the code a little bit and removed an unnecessary LOG_ERROR.
  • WebView.h: Added downloadURL.
1:41 PM Changeset in webkit [44270] by Adam Roben
  • 7 edits in trunk

Roll out r44269

It contained some changes I didn't mean to have landed, and squashed
some distinct patches into a single commit.

1:33 PM Changeset in webkit [44269] by bfulgham@webkit.org
  • 7 edits in trunk

WebCore:

2009-05-29 Adam Roben <Adam Roben>

Make sure PlatformMouseEvent::modifierFlags contains MK_ALT when the
Alt key is pressed

First part of fixing Bug 25729: Alt-clicking a link doesn't start a
download
<​https://bugs.webkit.org/show_bug.cgi?id=25729>

Reviewed by Darin Adler.

No test possible.

  • platform/win/PlatformMouseEventWin.cpp: (WebCore::PlatformMouseEvent::PlatformMouseEvent): Add MK_ALT to the modifier flags when the Alt key is pressed.

WebKit/win:

2009-05-29 Adam Roben <Adam Roben>

Implement WebFrame::startDownload

Fixes Bug 25729: Alt-clicking a link doesn't start a download
<​https://bugs.webkit.org/show_bug.cgi?id=25729>

Reviewed by Darin Adler.

  • WebFrame.cpp: (WebFrame::startDownload): Call through to WebView::downloadURL.
12:53 PM Changeset in webkit [44268] by bfulgham@webkit.org
  • 6 edits in trunk/WebCore

2009-05-29 Alexander Macdonald <​alexmac@adobe.com>

Reviewed by Darin Adler.

Added support for synthetic bold/oblique font rendering
on platforms that use cairo.

  • platform/graphics/SimpleFontData.h:
  • platform/graphics/cairo/FontCairo.cpp: (WebCore::Font::drawGlyphs):
  • platform/graphics/gtk/SimpleFontDataGtk.cpp: (WebCore::SimpleFontData::platformInit):
  • platform/graphics/gtk/SimpleFontDataPango.cpp: (WebCore::SimpleFontData::platformInit):
  • platform/graphics/win/SimpleFontDataCairoWin.cpp: (WebCore::SimpleFontData::platformInit):
11:49 AM Changeset in webkit [44267] by bfulgham@webkit.org
  • 2 edits in trunk/WebKit/win

2009-05-29 Brent Fulgham <​bfulgham@webkit.org>

Reviewed by Darin Adler.

Correct Windows Cairo build error caused by @r42767.
​http://bugs.webkit.org/show_bug.cgi?id=26082.

  • WebError.cpp: (WebError::localizedDescription):
11:32 AM Changeset in webkit [44266] by Chris Fleizach
  • 13 edits in trunk/WebCore

Bug 26024: AX: possible to fail assertion because AXPostNotification calls accessibilityIsIgnored
​https://bugs.webkit.org/show_bug.cgi?id=26024

9:55 AM Changeset in webkit [44265] by bfulgham@webkit.org
  • 2 edits in trunk/WebCore

2009-05-29 Brent Fulgham <​bfulgham@webkit.org>

Reviewed by Adam Roben.

Build fix for Windows Cairo target.
​https://bugs.webkit.org/show_bug.cgi?id=25972

Compiler mistakenly selects SMILTime min/max instead of STL version,
resulting in a build error. This change makes the meaning of the
min/max explicit and avoids the problem.

  • html/TimeRanges.h: (WebCore::TimeRanges::Range::unionWithOverlappingOrContiguousRange):
8:56 AM Changeset in webkit [44264] by xan@webkit.org
  • 2 edits in trunk/WebKit/gtk

2009-05-29 Xan Lopez <​xlopez@igalia.com>

Reviewed by Gustavo Noronha.

​https://bugs.webkit.org/show_bug.cgi?id=26075
[GTK] Refactor key scrolling code

After the scrolling changes in r44177 we can now use the
FrameView::scroll method like the other ports, keeping the magic
constants for the scrolling amounts inside WebCore proper.

  • webkit/webkitwebview.cpp: (webkit_web_view_real_move_cursor):
7:48 AM Changeset in webkit [44263] by kov@webkit.org
  • 12 edits
    2 adds in trunk

2009-05-29 Gustavo Noronha Silva <Gustavo Noronha Silva>

Reviewed by Jan Alonzo.

Add a test-case for our HTTP backend, currently checking the
ref-counting of the SoupMessage.

  • GNUmakefile.am:

WebCore:

2009-05-29 Gustavo Noronha Silva <Gustavo Noronha Silva>

Reviewed by Jan Alonzo.

Make SoupMessage a member of ResourceRequest, instead of creating
it in startHttp. Implement updating of ResourceRequest from
SoupMessage, and vice versa.

  • GNUmakefile.am:
  • platform/network/soup/ResourceHandleSoup.cpp: (WebCore::ResourceHandle::~ResourceHandle): (WebCore::gotHeadersCallback): (WebCore::ResourceHandle::startHttp):
  • platform/network/soup/ResourceRequest.h: (WebCore::ResourceRequest::ResourceRequest): (WebCore::ResourceRequest::~ResourceRequest):
  • platform/network/soup/ResourceRequestSoup.cpp: Added. (WTF::SoupURI): (WebCore::ResourceRequest::soupMessage): (WebCore::ResourceRequest::ResourceRequest): (WebCore::ResourceRequest::doUpdateResourceRequest): (WebCore::ResourceRequest::doUpdatePlatformRequest):

WebKit/gtk:

2009-05-29 Gustavo Noronha Silva <Gustavo Noronha Silva>

Reviewed by Jan Alonzo.

Make NetworkRequest carry a reference of the SoupMessage used by
ResourceRequest, and use that to create new ResourceRequests where
needed, so that no information is lost while passing around
NetworkRequest objects.

  • WebCoreSupport/FrameLoaderClientGtk.cpp: (WebKit::FrameLoaderClient::dispatchDecidePolicyForMIMEType): (WebKit::FrameLoaderClient::dispatchDecidePolicyForNavigationAction): (WebKit::FrameLoaderClient::startDownload):
  • webkit/webkitdownload.cpp: (webkit_download_start):
  • webkit/webkitnetworkrequest.cpp: (webkit_network_request_finalize): (webkit_network_request_new_with_core_request): (webkit_network_request_new): (webkit_network_request_get_message):
  • webkit/webkitprivate.h:
  • webkit/webkitwebframe.cpp: (webkit_web_frame_load_request):
4:10 AM Changeset in webkit [44262] by oliver@apple.com
  • 2 edits in trunk/LayoutTests

Fix error in test case i accidentally introduced.

May 28, 2009:

5:45 PM Changeset in webkit [44261] by mrowe@apple.com
  • 4 edits in branches/WWDC-2009-branch

Versioning.

5:40 PM Changeset in webkit [44260] by mrowe@apple.com
  • 1 copy in tags/Safari-6530.14

New tag.

5:34 PM Changeset in webkit [44259] by mrowe@apple.com
  • 7 edits
    4 adds in branches/WWDC-2009-branch

Merge r44218.

5:34 PM Changeset in webkit [44258] by mrowe@apple.com
  • 2 edits in branches/WWDC-2009-branch/WebCore

Merge r44241.

5:34 PM Changeset in webkit [44257] by mrowe@apple.com
  • 4 edits in branches/WWDC-2009-branch

Merge r44216.

4:44 PM Changeset in webkit [44256] by dimich@chromium.org
  • 2 edits in trunk/WebCore

2009-05-28 Dmitry Titov <​dimich@chromium.org>

Reviewed by Dimitri Glazkov.

​https://bugs.webkit.org/show_bug.cgi?id=26068
V8: Remove the remaining b8::Locker usage in worker code.
This completes the fix for ​https://bugs.webkit.org/show_bug.cgi?id=25944,
since the patches for enabling timers and that bug have "crossed in the queue".
Existing LayoutTests/fast/workers/worker-timeout.html covers this fix (will start work in Chromium).

  • bindings/v8/ScheduledAction.cpp: (WebCore::ScheduledAction::execute):
3:38 PM Changeset in webkit [44255] by mrowe@apple.com
  • 4 edits in trunk/WebKit/mac

Build fix. Move off a deprecated NSFileManager method.

Rubber-stamped by Dan Bernstein.

  • Misc/WebNSFileManagerExtras.h:
  • Misc/WebNSFileManagerExtras.m:

(-[NSFileManager destinationOfSymbolicLinkAtPath:error:]): Implement a new-in-Leopard method for Tiger to use.
(-[NSFileManager attributesOfItemAtPath:error:]): Ditto.

  • Plugins/WebNetscapePluginPackage.mm:

(-[WebNetscapePluginPackage _initWithPath:]): Use the new non-deprecated methods.

3:18 PM Changeset in webkit [44254] by kov@webkit.org
  • 2 edits in trunk/WebCore

2009-05-28 Gustavo Noronha Silva <​gustavo.noronha@collabora.co.uk>

Reviewed by Xan Lopez.

Simplify the Accept-Encoding header we are sending out, for it
seems some servers do not enjoy parsing the full, explicit
version.

  • platform/network/soup/ResourceHandleSoup.cpp: (WebCore::ResourceHandle::startHttp):
3:10 PM Changeset in webkit [44253] by krit@webkit.org
  • 186 edits in trunk

2009-05-28 Dirk Schulze <​krit@webkit.org>

Reviewed by Nikolas Zimmermann.

Added a new build flag --filters. This replaces the old --svg-filters and enables
other parts of WebKit to use some basic filters of platform/graphics/filters if needed.
This patch also fixes a bug in dom/DOMImplementation.cpp where we used SVG_FILTER. This flag
doesn't exist and was replaced by FILTERS as well as all SVG_FILTERS occurrences.
Filters are not working yet. This patch is just a preperation. Filters are deactivated by
default.

  • Configurations/FeatureDefines.xcconfig:
  • DerivedSources.make:
  • GNUmakefile.am:
  • WebCore.pro:
  • bindings/objc/DOM.mm: (WebCore::createElementClassMap):
  • dom/DOMImplementation.cpp: (WebCore::isSVG10Feature): (WebCore::isSVG11Feature):
  • page/DOMWindow.idl:
  • platform/graphics/filters/FEBlend.cpp:
  • platform/graphics/filters/FEBlend.h:
  • platform/graphics/filters/FEColorMatrix.cpp:
  • platform/graphics/filters/FEColorMatrix.h:
  • platform/graphics/filters/FEComponentTransfer.cpp:
  • platform/graphics/filters/FEComponentTransfer.h:
  • platform/graphics/filters/FEComposite.cpp:
  • platform/graphics/filters/FEComposite.h:
  • platform/graphics/filters/FilterEffect.cpp:
  • platform/graphics/filters/FilterEffect.h:
  • platform/graphics/filters/SourceAlpha.cpp:
  • platform/graphics/filters/SourceAlpha.h:
  • platform/graphics/filters/SourceGraphic.cpp:
  • platform/graphics/filters/SourceGraphic.h:
  • rendering/RenderSVGContainer.cpp: (WebCore::RenderSVGContainer::selfWillPaint):
  • rendering/RenderSVGModelObject.cpp:
  • rendering/RenderSVGRoot.cpp: (WebCore::RenderSVGRoot::selfWillPaint):
  • rendering/SVGRenderSupport.cpp: (WebCore::SVGRenderBase::prepareToRenderSVGContent): (WebCore::SVGRenderBase::finishRenderSVGContent): (WebCore::SVGRenderBase::filterBoundingBoxForRenderer):
  • svg/Filter.cpp:
  • svg/Filter.h:
  • svg/FilterBuilder.cpp:
  • svg/FilterBuilder.h:
  • svg/SVGComponentTransferFunctionElement.cpp:
  • svg/SVGComponentTransferFunctionElement.h:
  • svg/SVGComponentTransferFunctionElement.idl:
  • svg/SVGFEBlendElement.cpp:
  • svg/SVGFEBlendElement.h:
  • svg/SVGFEBlendElement.idl:
  • svg/SVGFEColorMatrixElement.cpp:
  • svg/SVGFEColorMatrixElement.h:
  • svg/SVGFEColorMatrixElement.idl:
  • svg/SVGFEComponentTransferElement.cpp:
  • svg/SVGFEComponentTransferElement.h:
  • svg/SVGFEComponentTransferElement.idl:
  • svg/SVGFECompositeElement.cpp:
  • svg/SVGFECompositeElement.h:
  • svg/SVGFECompositeElement.idl:
  • svg/SVGFEDiffuseLightingElement.cpp:
  • svg/SVGFEDiffuseLightingElement.h:
  • svg/SVGFEDiffuseLightingElement.idl:
  • svg/SVGFEDisplacementMapElement.cpp:
  • svg/SVGFEDisplacementMapElement.h:
  • svg/SVGFEDisplacementMapElement.idl:
  • svg/SVGFEDistantLightElement.cpp:
  • svg/SVGFEDistantLightElement.h:
  • svg/SVGFEDistantLightElement.idl:
  • svg/SVGFEFloodElement.cpp:
  • svg/SVGFEFloodElement.h:
  • svg/SVGFEFloodElement.idl:
  • svg/SVGFEFuncAElement.cpp:
  • svg/SVGFEFuncAElement.h:
  • svg/SVGFEFuncAElement.idl:
  • svg/SVGFEFuncBElement.cpp:
  • svg/SVGFEFuncBElement.h:
  • svg/SVGFEFuncBElement.idl:
  • svg/SVGFEFuncGElement.cpp:
  • svg/SVGFEFuncGElement.h:
  • svg/SVGFEFuncGElement.idl:
  • svg/SVGFEFuncRElement.cpp:
  • svg/SVGFEFuncRElement.h:
  • svg/SVGFEFuncRElement.idl:
  • svg/SVGFEGaussianBlurElement.cpp:
  • svg/SVGFEGaussianBlurElement.h:
  • svg/SVGFEGaussianBlurElement.idl:
  • svg/SVGFEImageElement.cpp:
  • svg/SVGFEImageElement.h:
  • svg/SVGFEImageElement.idl:
  • svg/SVGFELightElement.cpp:
  • svg/SVGFELightElement.h:
  • svg/SVGFEMergeElement.cpp:
  • svg/SVGFEMergeElement.h:
  • svg/SVGFEMergeElement.idl:
  • svg/SVGFEMergeNodeElement.cpp:
  • svg/SVGFEMergeNodeElement.h:
  • svg/SVGFEMergeNodeElement.idl:
  • svg/SVGFEOffsetElement.cpp:
  • svg/SVGFEOffsetElement.h:
  • svg/SVGFEOffsetElement.idl:
  • svg/SVGFEPointLightElement.cpp:
  • svg/SVGFEPointLightElement.h:
  • svg/SVGFEPointLightElement.idl:
  • svg/SVGFESpecularLightingElement.cpp:
  • svg/SVGFESpecularLightingElement.h:
  • svg/SVGFESpecularLightingElement.idl:
  • svg/SVGFESpotLightElement.cpp:
  • svg/SVGFESpotLightElement.h:
  • svg/SVGFESpotLightElement.idl:
  • svg/SVGFETileElement.cpp:
  • svg/SVGFETileElement.h:
  • svg/SVGFETileElement.idl:
  • svg/SVGFETurbulenceElement.cpp:
  • svg/SVGFETurbulenceElement.h:
  • svg/SVGFETurbulenceElement.idl:
  • svg/SVGFilterElement.cpp:
  • svg/SVGFilterElement.h:
  • svg/SVGFilterElement.idl:
  • svg/SVGFilterPrimitiveStandardAttributes.cpp:
  • svg/SVGFilterPrimitiveStandardAttributes.h:
  • svg/graphics/SVGResourceFilter.cpp:
  • svg/graphics/SVGResourceFilter.h:
  • svg/graphics/cairo/SVGResourceFilterCairo.cpp:
  • svg/graphics/cg/SVGResourceFilterCg.cpp:
  • svg/graphics/cg/SVGResourceFilterCg.mm:
  • svg/graphics/filters/SVGDistantLightSource.h:
  • svg/graphics/filters/SVGFEConvolveMatrix.cpp:
  • svg/graphics/filters/SVGFEConvolveMatrix.h:
  • svg/graphics/filters/SVGFEDiffuseLighting.cpp:
  • svg/graphics/filters/SVGFEDiffuseLighting.h:
  • svg/graphics/filters/SVGFEDisplacementMap.cpp:
  • svg/graphics/filters/SVGFEDisplacementMap.h:
  • svg/graphics/filters/SVGFEFlood.cpp:
  • svg/graphics/filters/SVGFEFlood.h:
  • svg/graphics/filters/SVGFEGaussianBlur.cpp:
  • svg/graphics/filters/SVGFEGaussianBlur.h:
  • svg/graphics/filters/SVGFEImage.cpp:
  • svg/graphics/filters/SVGFEImage.h:
  • svg/graphics/filters/SVGFEMerge.cpp:
  • svg/graphics/filters/SVGFEMerge.h:
  • svg/graphics/filters/SVGFEMorphology.cpp:
  • svg/graphics/filters/SVGFEMorphology.h:
  • svg/graphics/filters/SVGFEOffset.cpp:
  • svg/graphics/filters/SVGFEOffset.h:
  • svg/graphics/filters/SVGFESpecularLighting.cpp:
  • svg/graphics/filters/SVGFESpecularLighting.h:
  • svg/graphics/filters/SVGFETile.cpp:
  • svg/graphics/filters/SVGFETile.h:
  • svg/graphics/filters/SVGFETurbulence.cpp:
  • svg/graphics/filters/SVGFETurbulence.h:
  • svg/graphics/filters/SVGFilterEffect.cpp:
  • svg/graphics/filters/SVGFilterEffect.h:
  • svg/graphics/filters/SVGLightSource.cpp:
  • svg/graphics/filters/SVGLightSource.h:
  • svg/graphics/filters/SVGPointLightSource.h:
  • svg/graphics/filters/SVGSpotLightSource.h:
  • svg/graphics/filters/cg/SVGFEHelpersCg.h:
  • svg/graphics/filters/cg/SVGFEHelpersCg.mm:
  • svg/graphics/filters/cg/SVGFilterEffectCg.mm:
  • svg/graphics/filters/cg/WKArithmeticFilter.h:
  • svg/graphics/filters/cg/WKArithmeticFilter.m:
  • svg/graphics/filters/cg/WKComponentMergeFilter.h:
  • svg/graphics/filters/cg/WKComponentMergeFilter.m:
  • svg/graphics/filters/cg/WKDiffuseLightingFilter.h:
  • svg/graphics/filters/cg/WKDiffuseLightingFilter.m:
  • svg/graphics/filters/cg/WKDiscreteTransferFilter.h:
  • svg/graphics/filters/cg/WKDiscreteTransferFilter.m:
  • svg/graphics/filters/cg/WKDisplacementMapFilter.h
  • svg/graphics/filters/cg/WKDisplacementMapFilter.m:
  • svg/graphics/filters/cg/WKDistantLightFilter.h:
  • svg/graphics/filters/cg/WKDistantLightFilter.m:
  • svg/graphics/filters/cg/WKGammaTransferFilter.h:
  • svg/graphics/filters/cg/WKGammaTransferFilter.m:
  • svg/graphics/filters/cg/WKIdentityTransferFilter.h:
  • svg/graphics/filters/cg/WKIdentityTransferFilter.m:
  • svg/graphics/filters/cg/WKLinearTransferFilter.h:
  • svg/graphics/filters/cg/WKLinearTransferFilter.m:
  • svg/graphics/filters/cg/WKNormalMapFilter.h:
  • svg/graphics/filters/cg/WKNormalMapFilter.m:
  • svg/graphics/filters/cg/WKPointLightFilter.h:
  • svg/graphics/filters/cg/WKPointLightFilter.m:
  • svg/graphics/filters/cg/WKSpecularLightingFilter.h:
  • svg/graphics/filters/cg/WKSpecularLightingFilter.m:
  • svg/graphics/filters/cg/WKSpotLightFilter.h:
  • svg/graphics/filters/cg/WKSpotLightFilter.m:
  • svg/graphics/filters/cg/WKTableTransferFilter.h:
  • svg/graphics/filters/cg/WKTableTransferFilter.m:
  • svg/graphics/mac/SVGResourceFilterPlatformDataMac.h:
  • svg/graphics/mac/SVGResourceFilterPlatformDataMac.mm:
  • svg/graphics/qt/SVGResourceFilterQt.cpp:
  • svg/graphics/skia/SVGResourceFilterSkia.cpp:
  • svg/svgtags.in:

*WebKit/mac/
2009-05-28 Dirk Schulze <​krit@webkit.org>

Reviewed by Nikolas Zimmermann.

Added new build flag --filters. More details in WebCore/ChangeLog.

  • Configurations/FeatureDefines.xcconfig:

*.
2009-05-28 Dirk Schulze <​krit@webkit.org>

Reviewed by Nikolas Zimmermann.

Enable the new build flag --filters for Gtk. More details in WebCore/ChangeLog.

  • configure.ac:

*JavaScriptCore/
2009-05-28 Dirk Schulze <​krit@webkit.org>

Reviewed by Nikolas Zimmermann.

Added new build flag --filters for Mac. More details in WebCore/ChangeLog.

  • Configurations/FeatureDefines.xcconfig:

*WebKitTools
2009-05-28 Dirk Schulze <​krit@webkit.org>

Reviewed by Nikolas Zimmermann.

Added new build flag --filters. More details in WebCore/ChangeLog.

  • Scripts/build-webkit:
2:05 PM Changeset in webkit [44252] by brettw@chromium.org
  • 2 edits in trunk/WebCore

2009-05-28 Brett Wilson <​brettw@chromium.org>

Unreviewed, build fix.

​https://bugs.webkit.org/show_bug.cgi?id=26067

Add casts for scale function to make more explicit what is happening
and fix a compiler warning.

  • platform/graphics/IntSize.h: (WebCore::IntSize::scale):
1:56 PM Changeset in webkit [44251] by mrowe@apple.com
  • 2 edits in trunk/WebKit

Symlink WebKitPluginHost.app in to place if needed.

Rubber-stamped by Anders Carlsson.

  • WebKit.xcodeproj/project.pbxproj:
12:37 PM Changeset in webkit [44250] by kov@webkit.org
  • 1 copy in releases/WebKitGTK/webkit-1.1.8

Tagging 1.1.8.

12:27 PM Changeset in webkit [44249] by weinig@apple.com
  • 4 edits in trunk/WebCore

2009-05-28 Sam Weinig <​sam@webkit.org>

Reviewed by Darin Adler.

Remove the returnValueSlot concept from JSDOMWindowBase. Now that windows
are not cleared on navigation it is no longer necessary.

  • bindings/js/JSDOMWindowBase.cpp: (WebCore::JSDOMWindowBase::JSDOMWindowBaseData::JSDOMWindowBaseData): (WebCore::JSDOMWindowBase::willRemoveFromWindowShell):
  • bindings/js/JSDOMWindowBase.h:
  • bindings/js/JSDOMWindowCustom.cpp: (WebCore::JSDOMWindow::showModalDialog):
11:35 AM Changeset in webkit [44248] by kov@webkit.org
  • 2 edits in trunk/WebKit/gtk

2009-05-28 Gustavo Noronha Silva <​gustavo.noronha@collabora.co.uk>

Reviewed by Xan Lopez.

​https://bugs.webkit.org/show_bug.cgi?id=26048
navigation-policy-decision-requested documentation incomplete

Fix documentation for all policy decision request signals, to
mention that an actual decision is expected when you return TRUE,
meaning that you handled the signal.

  • webkit/webkitwebview.cpp: (webkit_web_view_class_init):
11:33 AM Changeset in webkit [44247] by xan@webkit.org
  • 2 edits in trunk/WebKit/gtk

2009-05-28 Xan Lopez <​xlopez@igalia.com>

Reviewed by Gustavo Noronha.

Mention the implementation of the new AtkText methods.

  • NEWS:
11:20 AM Changeset in webkit [44246] by xan@webkit.org
  • 5 edits
    1 add in trunk

2009-05-12 Xan Lopez <​xlopez@igalia.com>

Reviewed by Jan Alonzo and Gustavo Noronha.

​https://bugs.webkit.org/show_bug.cgi?id=25415
[GTK][ATK] Please implement support for get_text_at_offset

Add new test file for ATK.

  • GNUmakefile.am:

WebCore:

2009-05-12 Xan Lopez <​xlopez@igalia.com>

Reviewed by Jan Alonzo and Gustavo Noronha.

​https://bugs.webkit.org/show_bug.cgi?id=25415
[GTK][ATK] Please implement support for get_text_at_offset

Implement atk_text_get_text_{at,after,before}_offset.

  • accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:

WebKit/gtk:

2009-05-12 Xan Lopez <​xlopez@igalia.com>

Reviewed by Jan Alonzo and Gustavo Noronha.

​https://bugs.webkit.org/show_bug.cgi?id=25415
[GTK][ATK] Please implement support for get_text_at_offset

New test file for ATK functionality.

  • tests/testatk.c: Added. (bail_out): (test_get_text_function): (test_webkit_atk_get_text_at_offset): (main):
11:04 AM Changeset in webkit [44245] by Nikolas Zimmermann
  • 5 edits in trunk/WebCore

Rubber-stamped by Darin Adler.
Remove unnecessary destructor from InputElementData/OptionElementData.

10:50 AM Changeset in webkit [44244] by sfalken@apple.com
  • 3 edits in tags/Safari-6530.13.1/WebCore

Merge r44233.

10:49 AM Changeset in webkit [44243] by Nikolas Zimmermann
  • 9 edits in trunk/WebCore

Reviewed by Darin Adler.
Fixes: ​https://bugs.webkit.org/show_bug.cgi?id=26062

Refactor code from all virtual methods in HTMLSelectElement (that are also needed for WMLSelectElement)
in the recently introduced SelectElement abstract base class. Follow the same design sheme that InputElement uses.

10:48 AM Changeset in webkit [44242] by kov@webkit.org
  • 2 edits in trunk

2009-05-28 Gustavo Noronha Silva <​gustavo.noronha@collabora.co.uk>

Rubber-stamped by Xan Lopez.

Fix webkitgtk_cleanfiles to clean gtk-doc-related files in the
correct directory, so that we pass make distcheck.

  • GNUmakefile.am:
10:46 AM Changeset in webkit [44241] by Adam Roben
  • 2 edits in trunk/WebCore

Don't try to use the new combobox parts on Vista in Classic mode

Fixes:
<rdar://problem/6929277> REGRESSION (r42289+r42350): Windows Classic
theme: drop down lists in Preferences get a line/square
<rdar://problem/6929298> REGRESSION (r42289): Windows Classic: drop
down lists are black with a circle on many sites

Reviewed by Steve Falkenburg.

  • rendering/RenderThemeWin.cpp: (WebCore::RenderThemeWin::paintMenuList): Only use the new combobox parts when we have a theme (i.e., when we're not in Classic mode). When we don't have a theme, fall back to the pre-r42289 code.
10:36 AM Changeset in webkit [44240] by sfalken@apple.com
  • 1 copy in tags/Safari-6530.13.1

New tag.

10:35 AM Changeset in webkit [44239] by sfalken@apple.com
  • 1 delete in tags/Safari-6530.13.1

Delete incorrect tag.

10:34 AM Changeset in webkit [44238] by sfalken@apple.com
  • 1 copy in tags/Safari-6530.13.1

New tag.

10:29 AM Changeset in webkit [44237] by pkasting@chromium.org
  • 2 edits in trunk/WebCore

2009-05-27 Peter Kasting <​pkasting@google.com>

Reviewed by Simon Fraser.

​https://bugs.webkit.org/show_bug.cgi?id=25659
Avoid calling frameCount() unnecessarily (which could lead to extra
GIF decoding).

  • platform/graphics/BitmapImage.cpp: (WebCore::BitmapImage::destroyDecodedDataIfNecessary):
9:58 AM Changeset in webkit [44236] by kov@webkit.org
  • 2 edits in trunk/WebKit/gtk

2009-05-28 Gustavo Noronha Silva <​gustavo.noronha@collabora.co.uk>

Reviewed by Xan Lopez.

Document changes worth noting for 1.1.8.

  • NEWS:
9:55 AM Changeset in webkit [44235] by bfulgham@webkit.org
  • 16 edits
    6 adds in trunk

WebCore:

2009-05-28 Simon Fraser <Simon Fraser>

Reviewed by Oliver Hunt.


​https://bugs.webkit.org/show_bug.cgi?id=8736

Tests: fast/borders/border-radius-constraints.html

fast/borders/border-radius-split-inline.html


When the sum of the corner radii on a side exceed the length of the side,
reduce the radii according to CSS 3 rules.


Add RenderStyle::getBorderRadiiForRect() to fetch corner radii, applying
the constraints. Use that for painting borders, box-shadow, clipping replaced
elements

  • platform/graphics/IntSize.h: (WebCore::IntSize::scale): Add a scale method that scales by a float (using C rounding rules, like IntRect::scale()).
  • platform/graphics/Path.cpp: Make the QUARTER const static.
  • rendering/RenderBox.cpp: (WebCore::RenderBox::pushContentsClip): Use getBorderRadiiForRect to fetch border radii.
  • rendering/RenderBoxModelObject.cpp: (WebCore::RenderBoxModelObject::paintFillLayerExtended): Use getBorderRadiiForRect to fetch border radii.

(WebCore::RenderBoxModelObject::paintBorder):
Use getBorderRadiiForRect to fetch border radii, and fix a bug when drawing
borders for split inlines, which used to apply the radii for each segment,
and no longer does.

(WebCore::RenderBoxModelObject::paintBoxShadow):
Use getBorderRadiiForRect to fetch border radii.

  • rendering/RenderReplaced.cpp: (WebCore::RenderReplaced::paint): Use getBorderRadiiForRect to fetch border radii for clipping.
  • rendering/RenderWidget.cpp: (WebCore::RenderWidget::paint): Use getBorderRadiiForRect to fetch border radii for clipping.
  • rendering/style/RenderStyle.h:
  • rendering/style/RenderStyle.cpp: (WebCore::RenderStyle::getBorderRadiiForRect): New bottleneck method to fetch corner radiil given a rect, applying the constraint rules.

LayoutTests:

2009-05-28 Simon Fraser <Simon Fraser>

Reviewed by Oliver Hunt.


​https://bugs.webkit.org/show_bug.cgi?id=8736

  • fast/borders/border-radius-constraints.html: Added.
  • platform/mac/fast/borders/border-radius-constraints-expected.checksum: Added.
  • platform/mac/fast/borders/border-radius-constraints-expected.png: Added.
  • platform/mac/fast/borders/border-radius-constraints-expected.txt: Added.


Test that corner radii are constrained according to CSS3 rules.

  • fast/borders/border-radius-huge-assert.html:
  • platform/mac/fast/borders/border-radius-huge-assert-expected.checksum:
  • platform/mac/fast/borders/border-radius-huge-assert-expected.png:
  • platform/mac/fast/borders/border-radius-huge-assert-expected.txt:


Now that we constrain border-radius, update the text of the test, and the
expected result.


  • fast/borders/border-radius-split-inline.html: Added.
  • platform/mac/fast/borders/border-radius-split-inline-expected.checksum: Added.
  • platform/mac/fast/borders/border-radius-split-inline-expected.png: Added.
  • platform/mac/fast/borders/border-radius-split-inline-expected.txt: Added.


New test for border-radius on a split inline.


  • fast/box-shadow/border-radius-big.html:
  • platform/mac/fast/box-shadow/border-radius-big-expected.checksum:
  • platform/mac/fast/box-shadow/border-radius-big-expected.png:
  • platform/mac/fast/box-shadow/border-radius-big-expected.txt:

Now that we constrain border-radius, update the text of the test, and the
expected result.

9:50 AM Changeset in webkit [44234] by bfulgham@webkit.org
  • 2 edits in trunk/WebKitTools

2009-05-28 Olivier DOLE <​odole@pleyo.com>

Reviewed by Maciej.

Add options to sunspider-compare-results to know which test suite to
compare (see bug #15941).

  • Scripts/sunspider-compare-results:
9:46 AM Changeset in webkit [44233] by mitz@apple.com
  • 3 edits in branches/WWDC-2009-branch/WebCore

Windows build fix after r44178

9:23 AM Changeset in webkit [44232] by ap@webkit.org
  • 9 edits
    2 adds in trunk

Reviewed by Darin Adler.

​https://bugs.webkit.org/show_bug.cgi?id=26005
Optimization for XPath * does not preserve context size

Test: fast/xpath/position.html

Fixed the bug by removing the incorrect optimization, and made enough micro-optimizations to
get a performance progression on my tests.

  • xml/XPathPath.h: Removed broken optimizeStepPair().
  • xml/XPathPath.cpp: (WebCore::XPath::LocationPath::evaluate): Style fix. (WebCore::XPath::LocationPath::appendStep): Don't call optimizeStepPair(). (WebCore::XPath::LocationPath::insertFirstStep): Ditto. (WebCore::XPath::Path::Path): Style fix.
  • xml/XPathStep.cpp: (WebCore::XPath::primaryNodeType): Turned this member function into a static inline helper. (WebCore::XPath::nodeMatches): Ditto. Don't check for namespace axis, which is unsupported (and might never be). (WebCore::XPath::Step::nodesInAxis): Updated for the new nodeMatches() signature.
  • xml/XPathStep.h: (WebCore::XPath::Step::NodeTest::data): (WebCore::XPath::Step::NodeTest::namespaceURI): Made these data members AtomicString to avoid repeated conversions. This is the biggest performance win here.
  • xml/XPathUtil.cpp: (WebCore::XPath::stringValue): Reserve some capacity upfront.
9:20 AM Changeset in webkit [44231] by Dimitri Glazkov
  • 2 edits in trunk/WebCore

2009-05-28 Stephen White <​senorblanco@chromium.org>

Reviewed by Dimitri Glazkov.

When creating a linear or radial gradient with a single stop
at offset 1.0, the Skia layer was allocating 3 stops, but only
filling 2, leaving one uninitialized. Only 2 stops are necessary
in this case, at offsets (0.0, 1.0).

​http://bugs.webkit.org/show_bug.cgi?id=26063

Covered by: LayoutTests/svg/W3C-SVG-1.1/pservers-grad-16-b.svg

LayoutTests/svg/custom/gradient-stop-corner-cases.svg
LayoutTests/svg/custom/js-late-gradient-and-object-creation.svg

  • platform/graphics/skia/GradientSkia.cpp: (WebCore::totalStopsNeeded):
9:14 AM Changeset in webkit [44230] by Dimitri Glazkov
  • 8 edits in trunk/WebCore

2009-05-28 Yury Semikhatsky <​yurys@chromium.org>

Reviewed by Timothy Hatcher.

​https://bugs.webkit.org/show_bug.cgi?id=26041
Allow adding resource source to WebInspector.SourceFrame asynchronously.

Provide common implementation for InspectorController::addResourceSourceToFrame and
InspectorController::addSourceToFrame methods.

  • bindings/js/JSInspectorControllerCustom.cpp:
  • bindings/v8/custom/V8InspectorControllerCustom.cpp:
  • inspector/InspectorController.cpp: (WebCore::InspectorController::addResourceSourceToFrame):
  • inspector/InspectorController.h:
  • inspector/InspectorController.idl:
  • inspector/front-end/SourceFrame.js: (WebInspector.SourceFrame.prototype.revealLine): (WebInspector.SourceFrame.prototype.highlightLine): (WebInspector.SourceFrame.prototype._loaded): (WebInspector.SourceFrame.prototype._isContentLoaded):
  • inspector/front-end/SourceView.js: (WebInspector.SourceView.prototype.setupSourceFrameIfNeeded): (WebInspector.SourceView.prototype._contentLoaded):
8:45 AM Changeset in webkit [44229] by xan@webkit.org
  • 2 edits in trunk

2009-05-28 Xan Lopez <​xlopez@igalia.com>

Bump version numbers in preparation for 1.1.8 release.

  • configure.ac:
7:52 AM Changeset in webkit [44228] by xan@webkit.org
  • 6 edits in trunk/WebKit/gtk

2009-05-27 Xan Lopez <​xlopez@igalia.com>

Reviewed by Gustavo Noronha.

​https://bugs.webkit.org/show_bug.cgi?id=26039
[GTK] WebKitWebHistoryItem lifetime fixes

Modify the management of history items by the BackForward list.

Having the objects add themselves to a hash table with an extra
reference made impossible for the cleanup code in the dispose
method to be ever called in normal conditions, since dispose is
called before getting rid of the last reference, which the objects
were making to themselves. Get rid of this extra reference and
move the responsibility of the cleanup to the BackForward list
itself, which effectively owns the WebKitWebHistoryItems now.

Also, update the tests to reflect this change.

  • tests/testwebbackforwardlist.c: (test_webkit_web_history_item_lifetime): (test_webkit_web_back_forward_list_order): (test_webkit_web_back_forward_list_add_item):
  • tests/testwebhistoryitem.c: (web_history_item_fixture_setup): (web_history_item_fixture_teardown):
  • webkit/webkitprivate.h:
  • webkit/webkitwebbackforwardlist.cpp: (webkit_web_back_forward_list_dispose): (webkit_web_back_forward_list_class_init):
  • webkit/webkitwebhistoryitem.cpp: (webkit_history_items): (webkit_history_item_add): (webkit_web_history_item_dispose): (WebKit::kit):
7:52 AM Changeset in webkit [44227] by xan@webkit.org
  • 2 edits in trunk/WebKit/gtk

2009-05-26 Xan Lopez <​xlopez@igalia.com>

Reviewed by Jan Alonzo.

​https://bugs.webkit.org/show_bug.cgi?id=26039
[GTK] WebKitWebHistoryItem lifetime fixes

Delete the BackForwardList before the Page, otherwise the references
to the WebKitWebHistoryItems will be gone.

  • webkit/webkitwebview.cpp: (webkit_web_view_dispose):
5:04 AM Changeset in webkit [44226] by zecke@webkit.org
  • 2 edits in trunk/WebCore

2009-05-28 Holger Hans Peter Freyther <​zecke@selfish.org>

Reviewed by Xan Lopez.

After r44177 we had a problem when increasing the size
of the window the scrollbars stayed and were not hidden.
This was due WebCore giving up on the Scrollbar as it became
unnecessary but the GtkAdjustment remained unchanged.
So from the point of view of the GtkScrolledWindow scrolling
was still necessary and the GtkScrollbar kept being displayed.

Solve the issue by resetting the GtkAdjustment in the
destructor of ScrollbarGtk.

  • platform/gtk/ScrollbarGtk.cpp: (ScrollbarGtk::~ScrollbarGtk):
1:04 AM Changeset in webkit [44225] by abarth@webkit.org
  • 7 edits
    2 adds in trunk

WebCore:

2009-05-28 Adam Barth <​abarth@webkit.org>

Reviewed by Darin Adler.

Clean up window.open()'s use of lexical and dynamic scope.

(Added one unreviewed tweak: use dynamicFrame instead of lexicalFrame
for DOMWindow::allowPopUp.)

Test: http/tests/security/frameNavigation/context-for-window-open.html

  • bindings/js/JSDOMBinding.cpp: (WebCore::toDynamicFrame): (WebCore::processingUserGesture): (WebCore::completeURL):
  • bindings/js/JSDOMBinding.h:
  • bindings/js/JSDOMWindowCustom.cpp: (WebCore::createWindow): (WebCore::JSDOMWindow::open): (WebCore::JSDOMWindow::showModalDialog):
  • bindings/v8/custom/V8DOMWindowCustom.cpp: (WebCore::CALLBACK_FUNC_DECL): (WebCore::createWindow):

LayoutTests:

2009-05-28 Adam Barth <​abarth@webkit.org>

Reviewed by Darin Adler.

Test whether lexical or dynamic scope is used for window.open().

  • http/tests/security/frameNavigation/context-for-window-open-expected.txt: Added.
  • http/tests/security/frameNavigation/context-for-window-open.html: Added.
  • http/tests/security/frameNavigation/resources/middle-frame-for-location.html:
12:31 AM Changeset in webkit [44224] by abarth@webkit.org
  • 886 edits
    2 deletes in trunk

Revert 44221.

Note: See TracTimeline for information about the timeline view.