⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



May 30, 2009:

8:26 PM Changeset in webkit [44295] by kevino@webkit.org
  • 2 edits in trunk/WebCore

Build fix for platforms without plugins support.

7:32 PM Changeset in webkit [44294] by Nikolas Zimmermann
  • 2 edits in trunk/WebCore

Reviewed by Darin Adler.

Fixes: ​https://bugs.webkit.org/show_bug.cgi?id=25979

Fix regression, local WML files won't load anymore, as the mimetype isn't correctly detected.
Bug filed at <rdar://problem/6917571> to cover this CFNetwork limitation.

5:58 PM Changeset in webkit [44293] by weinig@apple.com
  • 17 edits in trunk

WebCore:

2009-05-29 Sam Weinig <​sam@webkit.org>

Reviewed by Anders Carlsson.

Fix for ​https://bugs.webkit.org/show_bug.cgi?id=26091
Make storage events match the current spec.

  • Storage event listeners are added to the window.
  • Storage events are dispatched to the window.

Updated existing tests.

  • dom/Document.cpp: (WebCore::Document::dispatchWindowEvent):
  • dom/Document.h:
  • dom/Node.cpp:
  • dom/Node.h:
  • html/HTMLBodyElement.cpp: (WebCore::HTMLBodyElement::parseMappedAttribute):
  • storage/LocalStorageArea.cpp: (WebCore::LocalStorageArea::dispatchStorageEvent):
  • storage/SessionStorageArea.cpp: (WebCore::SessionStorageArea::dispatchStorageEvent):

LayoutTests:

2009-05-29 Sam Weinig <​sam@webkit.org>

Reviewed by Anders Carlsson.

Fix for ​https://bugs.webkit.org/show_bug.cgi?id=26091
Make storage events match the current spec.

  • Storage event listeners are added to the window.
  • Storage events are dispatched to the window.
  • storage/domstorage/localstorage/iframe-events.html:
  • storage/domstorage/localstorage/index-get-and-set.html:
  • storage/domstorage/localstorage/resources/iframe-events-second.html:
  • storage/domstorage/localstorage/simple-events.html:
  • storage/domstorage/sessionstorage/iframe-events.html:
  • storage/domstorage/sessionstorage/index-get-and-set.html:
  • storage/domstorage/sessionstorage/resources/iframe-events-second.html:
  • storage/domstorage/sessionstorage/simple-events.html:
4:27 PM Changeset in webkit [44292] by Darin Adler
  • 7 edits in trunk

WebCore:

2009-05-30 Darin Adler <Darin Adler>

Reviewed by Adele Peterson.

Bug 26097: REGRESSION (r44283): Tab key doesn't work when focus is on a <select> element

Test: fast/forms/focus-control-to-page.html

  • dom/SelectElement.h: Made destructor protected. Tweaked a bit.
  • html/HTMLSelectElement.cpp: Removed unneeded includes. (WebCore::HTMLSelectElement::remove): Removed unneeded range check of the result of optionToListIndex. (WebCore::HTMLSelectElement::parseMappedAttribute): Removed code to set the unused attribute, m_minwidth. (WebCore::HTMLSelectElement::defaultEventHandler): The actual bug fix. Call through to the base class defaultEventHandler if the event hasn't been handled yet.
  • html/HTMLSelectElement.h: Removed unneeded includes. Made a lot more functions private. Removed unused minWidth function and m_minwidth data member.

LayoutTests:

2009-05-30 Darin Adler <Darin Adler>

Reviewed by Adele Peterson.

Bug 26097: REGRESSION (r44283): Tab key doesn't work when focus is on a <select> element

  • fast/forms/focus-control-to-page-expected.txt: Updated.
  • fast/forms/focus-control-to-page.html: Added test of <select>, <textarea>, and <input type="password">, and made sure we can tab both in and out of each type.
4:20 PM Changeset in webkit [44291] by bfulgham@webkit.org
  • 2 edits
    1 move
    1 delete in trunk/WebCore

2009-05-30 Fridrich Strba <​fridrich.strba@bluewin.ch>

Reviewed by Holger Freyther.

The two KeyboardCodes.h files are basically identical and the
qt one is properly #ifdef-ed for different win32 systems. Share
them between Qt and Gtk implementations.

  • GNUmakefile.am:
  • platform/KeyboardCodes.h: Copied from WebCore/platform/qt/KeyboardCodes.h.
  • platform/gtk/KeyboardCodes.h: Removed.
  • platform/qt/KeyboardCodes.h: Removed.
3:58 PM Changeset in webkit [44290] by ddkilzer@apple.com
  • 2 edits in trunk/WebKit/mac

Add JSLock to -[WebScriptCallFrame scopeChain]

Reviewed by Darin Adler.

In Debug builds of WebKit, Dashcode launching MobileSafari could
cause the ASSERT(JSLock::lockCount() > 0) assertion to fire in
JSC::Heap::heapAllocate() because the JSLock wasn't taken.

  • WebView/WebScriptDebugDelegate.mm: (-[WebScriptCallFrame scopeChain]): Take JSLock before calling into JavaScriptCore.
3:38 PM Changeset in webkit [44289] by bfulgham@webkit.org
  • 1 edit
    4 adds in trunk/LayoutTests

2009-05-30 Jeremy Orlow <​jorlow@chromium.org>

Reviewed by Sam Weinig.

LocalStorage and SessionStorage's implicit setters do not correctly
handle null. The custom JS bindings should convert to strings
unconditionally and not try to handle null specially.
​https://bugs.webkit.org/show_bug.cgi?id=25970

  • storage/domstorage/localstorage/string-conversion-expected.txt: Added.
  • storage/domstorage/localstorage/string-conversion.html: Added.
  • storage/domstorage/sessionstorage/string-conversion-expected.txt: Added.
  • storage/domstorage/sessionstorage/string-conversion.html: Added.
3:38 PM Changeset in webkit [44288] by bfulgham@webkit.org
  • 2 edits in trunk/WebCore

2009-05-30 Jeremy Orlow <​jorlow@chromium.org>

Reviewed by Sam Weinig.

LocalStorage and SessionStorage's implicit setters do not correctly
handle null. The custom JS bindings should convert to strings
unconditionally and not try to handle null specially.
​https://bugs.webkit.org/show_bug.cgi?id=25970

Tests: storage/domstorage/localstorage/string-conversion.html

storage/domstorage/sessionstorage/string-conversion.html

  • bindings/js/JSStorageCustom.cpp: (WebCore::JSStorage::customPut):
1:35 PM Changeset in webkit [44287] by mitz@apple.com
  • 3 edits
    4 adds in trunk

WebCore:

Reviewed by Darin Adler.

  • fix <rdar://problem/6935192> REGRESSION (Safari 3-TOT): Scroll bars in key window draw as inactive if the WebView is not active

Test: platform/mac/scrollbars/key-window-not-first-responder.html

  • platform/mac/ScrollbarThemeMac.mm: (WebCore::ScrollbarThemeMac::paint): Use the window's key state instead of the WebView's first responder state to switch between active and inactive state.

LayoutTests:

Reviewed by Darin Adler.

  • test for <rdar://problem/6935192> REGRESSION (Safari 3-TOT): Scroll bars in key window draw as inactive if the WebView is not active
  • platform/mac/scrollbars/key-window-not-first-responder-expected.checksum: Added.
  • platform/mac/scrollbars/key-window-not-first-responder-expected.png: Added.
  • platform/mac/scrollbars/key-window-not-first-responder-expected.txt: Added.
  • platform/mac/scrollbars/key-window-not-first-responder.html: Added.
1:27 PM Changeset in webkit [44286] by Darin Adler
  • 2 edits in trunk/JavaScriptCore

2009-05-30 Darin Adler <Darin Adler>

Reviewed by Sam Weinig.

<rdar://problem/6935193> REGRESSION (r42734): Celtic Kane JavaScript benchmark does not run:
"Maximum call stack size exceeded"

  • runtime/ArrayPrototype.cpp: (JSC::arrayProtoFuncToString): Use the same recursion limit as the other recursion checks. We need a limit of at least 100 to run the benchmark above. (JSC::arrayProtoFuncToLocaleString): Ditto. (JSC::arrayProtoFuncJoin): Ditto.
10:50 AM Changeset in webkit [44285] by mitz@apple.com
  • 3 edits
    4 adds in trunk

WebCore:

Reviewed by Simon Fraser.

Test: fast/backgrounds/body-generated-image-propagated-to-root.html

  • rendering/RenderBoxModelObject.cpp: (WebCore::RenderBoxModelObject::paintFillLayerExtended): Check if this is the root element painting a background layer propagated from the body, and if it is, use the body's renderer as the client to StyleImage::image().

LayoutTests:

Reviewed by Simon Fraser.

  • fast/backgrounds/body-generated-image-propagated-to-root.html: Added.
  • platform/mac/fast/backgrounds/body-generated-image-propagated-to-root-expected.checksum: Added.
  • platform/mac/fast/backgrounds/body-generated-image-propagated-to-root-expected.png: Added.
  • platform/mac/fast/backgrounds/body-generated-image-propagated-to-root-expected.txt: Added.
9:50 AM Changeset in webkit [44284] by zecke@webkit.org
  • 2 edits in trunk/WebCore

2009-05-30 Holger Hans Peter Freyther <​zecke@selfish.org>

Unreviewed build fix for AXObjectCache.

For !HAVE(ACCESSIBILITY) postNotification was defined twice. Move
that into the #ifdef.

  • accessibility/AXObjectCache.cpp:

May 29, 2009:

6:38 PM Changeset in webkit [44283] by Nikolas Zimmermann
  • 22 edits
    6 adds in trunk

Reviewed by George Staikos.

Fixes: ​https://bugs.webkit.org/show_bug.cgi?id=26072

Add support for the last missing WML element: <select>. This patch adds WMLSelectElement, providing
the same functionality HTMLSelectElement has. The WML specific features will follow soon.

Add simple testcase covering <select> element rendering: fast/wml/select.wml

3:55 PM Changeset in webkit [44282] by jmalonzo@webkit.org
  • 2 edits in trunk/WebKit/gtk

2009-05-29 Jan Michael Alonzo <​jmalonzo@webkit.org>

Reviewed by Gustavo Noronha.

Fixed compile warning when comparing the different navigation types

  • webkit/webkitwebnavigationaction.cpp: (webkit_web_navigation_action_class_init):
3:42 PM Changeset in webkit [44281] by levin@chromium.org
  • 2 edits in trunk/WebCore

2009-05-29 David Levin <​levin@chromium.org>

Reviewed by NOBODY (build fix for windows).

​http://trac.webkit.org/changeset/44279 left in a "Vector<WCHAR> localeNameBuf"
that it was trying to replace. Resulting in this variable being defined twice (and
the second time incorrectly).

  • platform/win/Language.cpp: (WebCore::localeInfo):
3:02 PM Changeset in webkit [44280] by levin@chromium.org
  • 2 edits in trunk/WebCore

2009-05-29 Takeshi Yoshino <​tyoshino@google.com>

Reviewed by Darin Alder.

​https://bugs.webkit.org/show_bug.cgi?id=26018

Fix behavior of the Element View of the Web Inspector for double
clicking the element outline tree.

Double clicking the element outline tree should
1) on attribute: enter attribute editing mode
2) on text: enter text editing mode
3) otherwise: change root node to the parent element of double clicked

element.

Now, 3) is broken. For example, clicking <html> clears the element
outline view.

rootDOMNode should be updated to this.representedObject.parentNode, not
this.parent.representedObject which is parent inside the element
outline tree itself.

  • inspector/front-end/ElementsTreeOutline.js: (WebInspector.ElementsTreeElement.prototype.ondblclick):
3:02 PM Changeset in webkit [44279] by levin@chromium.org
  • 9 edits in trunk/WebCore

2009-05-29 David Moore <​davemoore@google.com>

Reviewed by Darin Alder.

​https://bugs.webkit.org/show_bug.cgi?id=26001
Change many of the uses of String::adopt() to String::createUninitialized().
This allows those strings to use an inlined buffer for their characters.

  • dom/StyleElement.cpp: Loop over nodes to precompute length of string and then write the characters into the allocated inline buffer (WebCore::StyleElement::process):
  • dom/Text.cpp: Loop over nodes to precompute length of string and then write the characters into the allocated inline buffer (WebCore::Text::wholeText): (WebCore::Text::rendererIsNeeded): (WebCore::Text::createRenderer): (WebCore::Text::createWithLengthLimit): (WebCore::Text::formatForDebugger):
  • platform/text/String.cpp: (WebCore::String::append): (WebCore::String::insert): (WebCore::String::truncate): (WebCore::String::remove):
  • platform/text/StringBuilder.cpp: (WebCore::StringBuilder::toString):
  • platform/text/StringImpl.cpp: (WebCore::StringImpl::lower): (WebCore::StringImpl::upper): (WebCore::StringImpl::secure): (WebCore::StringImpl::foldCase): (WebCore::StringImpl::replace):
  • platform/text/TextCodecLatin1.cpp: (WebCore::TextCodecLatin1::decode):
  • platform/text/TextCodecUserDefined.cpp: (WebCore::TextCodecUserDefined::decode):
  • platform/win/Language.cpp: (WebCore::localeInfo):
3:02 PM Changeset in webkit [44278] by levin@chromium.org
  • 3 edits
    4 adds in trunk

WebCore:

2009-05-29 Takeshi Yoshino <​tyoshino@google.com>

Reviewed by Darin Alder.

Bug 25911: Apply href in base elements to anchors shown on the source viewer
​https://bugs.webkit.org/show_bug.cgi?id=25911

In rendering HTML sources, parse base elements to apply the base URI to
anchors shown on the source viewer.

This issue was originally reported to the Chromium issue tracker.
​http://code.google.com/p/chromium/issues/detail?id=2418

Test: fast/frames/viewsource-link-on-href-value.html

  • html/HTMLViewSourceDocument.cpp: (WebCore::HTMLViewSourceDocument::addViewSourceToken):

LayoutTests:

2009-05-29 Takeshi Yoshino <​tyoshino@google.com>

Reviewed by Darin Alder.

Bug 25911: Apply href in base elements to anchors shown on the source viewer
​https://bugs.webkit.org/show_bug.cgi?id=25911

In rendering HTML sources, parse base elements to apply the base URI to
anchors shown on the source viewer.

Add tests to verify this change.

This issue was originally reported to the Chromium issue tracker.
​http://code.google.com/p/chromium/issues/detail?id=2418

  • fast/frames/resources/viewsource-frame-3.html: Added.
  • fast/frames/resources/viewsource-frame-4.html: Added.
  • fast/frames/viewsource-link-on-href-value-expected.txt: Added.
  • fast/frames/viewsource-link-on-href-value.html: Added.
3:02 PM Changeset in webkit [44277] by levin@chromium.org
  • 3 edits
    2 adds in trunk

WebCore:

2009-05-29 Rob Buis <​rwlbuis@gmail.com>

Reviewed by David Hyatt.

​https://bugs.webkit.org/show_bug.cgi?id=22429
document.styleSheets collection ignores media=presentation

Ensure that stylesheets though <link> show up in document.styleSheets regardless of media attribute.

Test: fast/css/sheet-collection-link.html

  • html/HTMLLinkElement.cpp: (WebCore::HTMLLinkElement::process):

LayoutTests:

2009-05-29 Rob Buis <​rwlbuis@gmail.com>

Reviewed by David Hyatt.

Testcase for:
​https://bugs.webkit.org/show_bug.cgi?id=22429
document.styleSheets collection ignores media=presentation

  • fast/css/sheet-collection-link.html: Added.
  • fast/css/sheet-collection-link-expected.txt: Added.
3:02 PM Changeset in webkit [44276] by levin@chromium.org
  • 4 edits in trunk/WebCore

2009-05-29 Itai Danan <​idanan@chromium.org>

Reviewed by Jon Honeycutt.

Bug 24791: Should have a preference to disable auto scrolling
​https://bugs.webkit.org/show_bug.cgi?id=24791

To understand why this is required see the discussion in
issue 24722 (​https://bugs.webkit.org/show_bug.cgi?id=24722).

The code review was done in ​https://bugs.webkit.org/show_bug.cgi?id=21794.

  • page/EventHandler.cpp: (WebCore::EventHandler::handleMousePressEvent): Use autoscroll behavior flag to determine if autoscroll needs to be released on this event. (WebCore::EventHandler::handleMouseReleaseEvent): Use autoscroll behavior flag to determine if autoscroll needs to be released on this event (reverse logic of for Press event).
  • page/Settings.cpp: (WebCore::Settings::Settings): Initialize autoscroll behavior setting.
  • page/Settings.h: (WebCore::Settings::setUsesStickyPanScroll): Autoscroll behavior setting setter. (WebCore::Settings::usesStickyPanScroll): Autoscroll behavior setting getter.
2:58 PM Changeset in webkit [44275] by jianli@chromium.org
  • 3 edits
    3 adds in trunk

WebCore:

2009-05-29 Jian Li <​jianli@chromium.org>

Reviewed by Dimitri Glazkov.

​https://bugs.webkit.org/show_bug.cgi?id=26069
Fix a crash in custom V8 bindings code for XMLHttpRequest.

Test: fast/xmlhttprequest/xmlhttprequest-open-after-iframe-onload-remove-self.html

  • bindings/v8/custom/V8XMLHttpRequestCustom.cpp: (WebCore::CALLBACK_FUNC_DECL):

LayoutTests:

2009-05-29 Jian Li <​jianli@chromium.org>

Reviewed by Dimitri Glazkov.

​https://bugs.webkit.org/show_bug.cgi?id=26069
Test for the above bug.

  • fast/xmlhttprequest/resources/xmlhttprequest-open-after-iframe-onload-remove-self-child.html: Added.
  • fast/xmlhttprequest/xmlhttprequest-open-after-iframe-onload-remove-self-expected.txt: Added.
  • fast/xmlhttprequest/xmlhttprequest-open-after-iframe-onload-remove-self.html: Added.
2:38 PM Changeset in webkit [44274] by bfulgham@webkit.org
  • 2 edits in trunk/WebCore

2009-05-29 David Levin <​levin@chromium.org>

Reviewed by Darin Adler.

Bug 26074: SQLTransaction::executeSQL does an unnecessary call to String::copy.
​https://bugs.webkit.org/show_bug.cgi?id=26074

The constructor for SQLStatement already does a copy for this string.

  • storage/SQLTransaction.cpp: (WebCore::SQLTransaction::executeSQL):
1:53 PM Changeset in webkit [44273] by Adam Roben
  • 2 edits in trunk/WebKit/win

Implement WebFrame::startDownload

Fixes the WebKit side of Bug 25729: Alt-clicking a link doesn't start
a download <​https://bugs.webkit.org/show_bug.cgi?id=25729>. Fixing
this all the way will require a change in Safari.

Reviewed by Darin Adler.

  • WebFrame.cpp: (WebFrame::startDownload): Call through to WebView::downloadURL.
1:51 PM Changeset in webkit [44272] by Darin Adler
  • 3 edits in trunk/WebCore

2009-05-29 Darin Adler <Darin Adler>

Fix build; the new Cairo code compiled on Windows only.

  • platform/graphics/gtk/FontPlatformData.h: Added syntheticBold and syntheticOblique functions as in the Windows version to make it easier to use this cross-platform. Later we can make data members private as in the Windows version.
  • platform/graphics/mac/FontPlatformData.h: Ditto.
1:48 PM Changeset in webkit [44271] by Adam Roben
  • 4 edits in trunk/WebKit/win

Move WebContextMenuClient's downloading code to WebView

This will allow other code to trigger downloads using this code, and
matches Mac.

Reviewed by Darin Adler.

  • WebCoreSupport/WebContextMenuClient.cpp: (WebContextMenuClient::downloadURL): Moved code from here...
  • WebView.cpp: (WebView::downloadURL): ...to here. Also tightened up the code a little bit and removed an unnecessary LOG_ERROR.
  • WebView.h: Added downloadURL.
1:41 PM Changeset in webkit [44270] by Adam Roben
  • 7 edits in trunk

Roll out r44269

It contained some changes I didn't mean to have landed, and squashed
some distinct patches into a single commit.

1:33 PM Changeset in webkit [44269] by bfulgham@webkit.org
  • 7 edits in trunk

WebCore:

2009-05-29 Adam Roben <Adam Roben>

Make sure PlatformMouseEvent::modifierFlags contains MK_ALT when the
Alt key is pressed

First part of fixing Bug 25729: Alt-clicking a link doesn't start a
download
<​https://bugs.webkit.org/show_bug.cgi?id=25729>

Reviewed by Darin Adler.

No test possible.

  • platform/win/PlatformMouseEventWin.cpp: (WebCore::PlatformMouseEvent::PlatformMouseEvent): Add MK_ALT to the modifier flags when the Alt key is pressed.

WebKit/win:

2009-05-29 Adam Roben <Adam Roben>

Implement WebFrame::startDownload

Fixes Bug 25729: Alt-clicking a link doesn't start a download
<​https://bugs.webkit.org/show_bug.cgi?id=25729>

Reviewed by Darin Adler.

  • WebFrame.cpp: (WebFrame::startDownload): Call through to WebView::downloadURL.
12:53 PM Changeset in webkit [44268] by bfulgham@webkit.org
  • 6 edits in trunk/WebCore

2009-05-29 Alexander Macdonald <​alexmac@adobe.com>

Reviewed by Darin Adler.

Added support for synthetic bold/oblique font rendering
on platforms that use cairo.

  • platform/graphics/SimpleFontData.h:
  • platform/graphics/cairo/FontCairo.cpp: (WebCore::Font::drawGlyphs):
  • platform/graphics/gtk/SimpleFontDataGtk.cpp: (WebCore::SimpleFontData::platformInit):
  • platform/graphics/gtk/SimpleFontDataPango.cpp: (WebCore::SimpleFontData::platformInit):
  • platform/graphics/win/SimpleFontDataCairoWin.cpp: (WebCore::SimpleFontData::platformInit):
11:49 AM Changeset in webkit [44267] by bfulgham@webkit.org
  • 2 edits in trunk/WebKit/win

2009-05-29 Brent Fulgham <​bfulgham@webkit.org>

Reviewed by Darin Adler.

Correct Windows Cairo build error caused by @r42767.
​http://bugs.webkit.org/show_bug.cgi?id=26082.

  • WebError.cpp: (WebError::localizedDescription):
11:32 AM Changeset in webkit [44266] by Chris Fleizach
  • 13 edits in trunk/WebCore

Bug 26024: AX: possible to fail assertion because AXPostNotification calls accessibilityIsIgnored
​https://bugs.webkit.org/show_bug.cgi?id=26024

9:55 AM Changeset in webkit [44265] by bfulgham@webkit.org
  • 2 edits in trunk/WebCore

2009-05-29 Brent Fulgham <​bfulgham@webkit.org>

Reviewed by Adam Roben.

Build fix for Windows Cairo target.
​https://bugs.webkit.org/show_bug.cgi?id=25972

Compiler mistakenly selects SMILTime min/max instead of STL version,
resulting in a build error. This change makes the meaning of the
min/max explicit and avoids the problem.

  • html/TimeRanges.h: (WebCore::TimeRanges::Range::unionWithOverlappingOrContiguousRange):
8:56 AM Changeset in webkit [44264] by xan@webkit.org
  • 2 edits in trunk/WebKit/gtk

2009-05-29 Xan Lopez <​xlopez@igalia.com>

Reviewed by Gustavo Noronha.

​https://bugs.webkit.org/show_bug.cgi?id=26075
[GTK] Refactor key scrolling code

After the scrolling changes in r44177 we can now use the
FrameView::scroll method like the other ports, keeping the magic
constants for the scrolling amounts inside WebCore proper.

  • webkit/webkitwebview.cpp: (webkit_web_view_real_move_cursor):
7:48 AM Changeset in webkit [44263] by kov@webkit.org
  • 12 edits
    2 adds in trunk

2009-05-29 Gustavo Noronha Silva <Gustavo Noronha Silva>

Reviewed by Jan Alonzo.

Add a test-case for our HTTP backend, currently checking the
ref-counting of the SoupMessage.

  • GNUmakefile.am:

WebCore:

2009-05-29 Gustavo Noronha Silva <Gustavo Noronha Silva>

Reviewed by Jan Alonzo.

Make SoupMessage a member of ResourceRequest, instead of creating
it in startHttp. Implement updating of ResourceRequest from
SoupMessage, and vice versa.

  • GNUmakefile.am:
  • platform/network/soup/ResourceHandleSoup.cpp: (WebCore::ResourceHandle::~ResourceHandle): (WebCore::gotHeadersCallback): (WebCore::ResourceHandle::startHttp):
  • platform/network/soup/ResourceRequest.h: (WebCore::ResourceRequest::ResourceRequest): (WebCore::ResourceRequest::~ResourceRequest):
  • platform/network/soup/ResourceRequestSoup.cpp: Added. (WTF::SoupURI): (WebCore::ResourceRequest::soupMessage): (WebCore::ResourceRequest::ResourceRequest): (WebCore::ResourceRequest::doUpdateResourceRequest): (WebCore::ResourceRequest::doUpdatePlatformRequest):

WebKit/gtk:

2009-05-29 Gustavo Noronha Silva <Gustavo Noronha Silva>

Reviewed by Jan Alonzo.

Make NetworkRequest carry a reference of the SoupMessage used by
ResourceRequest, and use that to create new ResourceRequests where
needed, so that no information is lost while passing around
NetworkRequest objects.

  • WebCoreSupport/FrameLoaderClientGtk.cpp: (WebKit::FrameLoaderClient::dispatchDecidePolicyForMIMEType): (WebKit::FrameLoaderClient::dispatchDecidePolicyForNavigationAction): (WebKit::FrameLoaderClient::startDownload):
  • webkit/webkitdownload.cpp: (webkit_download_start):
  • webkit/webkitnetworkrequest.cpp: (webkit_network_request_finalize): (webkit_network_request_new_with_core_request): (webkit_network_request_new): (webkit_network_request_get_message):
  • webkit/webkitprivate.h:
  • webkit/webkitwebframe.cpp: (webkit_web_frame_load_request):
4:10 AM Changeset in webkit [44262] by oliver@apple.com
  • 2 edits in trunk/LayoutTests

Fix error in test case i accidentally introduced.

Note: See TracTimeline for information about the timeline view.