Context Navigation

← Previous Period
Next Period →

Timeline

Jun 3, 2009:

8:32 PM Changeset in webkit [44409] by weinig@apple.com

5 edits
2 copies in trunk/WebKit

WebKit:

2009-06-03 Sam Weinig <sam@webkit.org>

Reviewed by Mark Rowe.

Added WebDelegateImplementationCaching.h/mm

WebKit.xcodeproj/project.pbxproj:

WebKit/mac:

2009-06-03 Sam Weinig <sam@webkit.org>

Reviewed by Mark Rowe.

Move delegate implementation caching logic into its own files.

WebView/WebDelegateImplementationCaching.h: Copied from mac/WebView/WebViewInternal.h.
WebView/WebDelegateImplementationCaching.mm: Copied from mac/WebView/WebView.mm. (WebViewGetResourceLoadDelegateImplementations): (WebViewGetFrameLoadDelegateImplementations): (WebViewGetScriptDebugDelegateImplementations):
WebView/WebView.mm:
WebView/WebViewInternal.h:

8:30 PM Changeset in webkit [44408] by mitz@apple.com

4 edits in trunk/WebCore

Reviewed by Sam Weinig.

add some assertions that Font methods are used on the main thread

platform/graphics/Font.cpp: (WebCore::Font::setShouldUseSmoothing):
platform/graphics/Font.h: (WebCore::Font::primaryFont):
platform/graphics/FontFastPath.cpp: (WebCore::Font::glyphDataForCharacter):

7:39 PM Changeset in webkit [44407] by weinig@apple.com

5 edits
1 add in trunk/WebKit

WebKit:

2009-06-03 Sam Weinig <sam@webkit.org>

Reviewed by Mark Rowe.

Add WebViewInternal.mm.

WebKit.xcodeproj/project.pbxproj:

WebKit/mac:

2009-06-03 Sam Weinig <sam@webkit.org>

Reviewed by Mark Rowe.

Move WebViewPrivate structure to WebViewInternal.h/mm.

WebView/WebView.mm:
WebView/WebViewInternal.h:
WebView/WebViewInternal.mm: Added. (+[WebViewPrivate initialize]): (-[WebViewPrivate init]): (-[WebViewPrivate dealloc]): (-[WebViewPrivate finalize]):

6:13 PM Changeset in webkit [44406] by weinig@apple.com

2 edits in trunk/WebKit/mac

2009-06-03 Sam Weinig <sam@webkit.org>

Reviewed by Darin Adler.

Small cleanup in WebView.

Move global data initialization to WebView's initialization method.
Move _clearViewUpdateRunLoopObserver from WebViewPrivate to WebView (FileInternal)

WebView/WebView.mm: (-[WebViewPrivate init]): Remove global initializers. (-[WebViewPrivate dealloc]): Cleanup whitespace. (-[WebViewPrivate finalize]): Ditto. (-[WebView _close]): Call [self _clearViewUpdateRunLoopObserver] instead of [_private _clearViewUpdateRunLoopObserver] (+[WebView initialize]): Move global initializers here. (-[WebView _clearViewUpdateRunLoopObserver]): Moved from WebViewPrivate. (viewUpdateRunLoopObserverCallBack): Call [self _clearViewUpdateRunLoopObserver] instead of [_private _clearViewUpdateRunLoopObserver]

5:11 PM Changeset in webkit [44405] by mitz@apple.com

2 edits in trunk/WebCore

Windows build fix

Rolled out apparently-accidental changes to config.h from r44398. These
were not part of the patch as reviewed.

config.h:

5:07 PM Changeset in webkit [44404] by dimich@chromium.org

3 edits in trunk/WebCore

2009-06-03 Dmitry Titov <dimich@chromium.org>

Not reviewed, Chromium build fix.

https://bugs.webkit.org/show_bug.cgi?id=26177
Reverting 'private' to 'protected' on 2 classes.
Chromium glue layer (not yet in Webkit tree) relies on ability to derive
Chromium-specific platform classes and access the data members.
See bug for more details.

platform/PlatformMouseEvent.h:
platform/PlatformWheelEvent.h:

4:37 PM Changeset in webkit [44403] by cmarrin@apple.com

3 edits
1 add in trunk/WebCore

Reviewed by Simon Fraser <simonfr@apple.com>.

Fixed https://bugs.webkit.org/show_bug.cgi?id=26162

This corrects an error when destroying an animation
or transition where endAnimation was never getting
called and therefore the hardware animation was never
getting removed.

This includes a manual-test since it's really impossible
to make a meaningful automatic test for an animation
bug like this.

This has no effect unless accelerated compositing is
enabled.

4:12 PM Changeset in webkit [44402] by kevino@webkit.org

2 edits in trunk/WebKit/wx

wx build fix, remove no longer needed function call.

4:08 PM Changeset in webkit [44401] by agl@chromium.org

3 edits in trunk/WebCore

2009-06-03 Adam Langley <agl@google.com>

Reviewed by Eric Seidel.

Make the scrollbar thumb size twice the width for Chromium Linux. This
matches Firefox on Linux.

This will need layout test pixel results to be rebaselined in the
Chromium tree.

http://code.google.com/p/chromium/issues/detail?id=12602
https://bugs.webkit.org/show_bug.cgi?id=26176

platform/chromium/ScrollbarThemeChromiumLinux.cpp: (WebCore::ScrollbarThemeChromiumLinux::minimumThumbLength):
platform/chromium/ScrollbarThemeChromiumLinux.h:

3:46 PM Changeset in webkit [44400] by agl@chromium.org

5 edits
1 copy
1 add in trunk/WebCore

2009-06-03 Adam Langley <agl@google.com>

Reviewed by Eric Seidel.

Change Chromium scrollbar theme code to use different classes on
Windows and Linux rather than suppling symbols. The ScrollbarTheme
class is already using virtual dispatch, so there's no reason not to.

This should not affect any layout tests.

https://bugs.webkit.org/show_bug.cgi?id=26174

platform/chromium/ScrollbarThemeChromium.cpp:
platform/chromium/ScrollbarThemeChromium.h:
platform/chromium/ScrollbarThemeChromiumLinux.cpp: (WebCore::ScrollbarTheme::nativeTheme): (WebCore::ScrollbarThemeChromiumLinux::scrollbarThickness): (WebCore::ScrollbarThemeChromiumLinux::paintTrackPiece): (WebCore::ScrollbarThemeChromiumLinux::paintButton): (WebCore::ScrollbarThemeChromiumLinux::paintThumb): (WebCore::ScrollbarThemeChromiumLinux::buttonSize):
platform/chromium/ScrollbarThemeChromiumLinux.h: Added.
platform/chromium/ScrollbarThemeChromiumWin.cpp: (WebCore::ScrollbarTheme::nativeTheme): (WebCore::ScrollbarThemeChromiumWin::scrollbarThickness): (WebCore::ScrollbarThemeChromiumWin::invalidateOnMouseEnterExit): (WebCore::ScrollbarThemeChromiumWin::shouldSnapBackToDragOrigin): (WebCore::ScrollbarThemeChromiumWin::paintTrackPiece): (WebCore::ScrollbarThemeChromiumWin::paintButton): (WebCore::ScrollbarThemeChromiumWin::paintThumb): (WebCore::ScrollbarThemeChromiumWin::getThemeState): (WebCore::ScrollbarThemeChromiumWin::getThemeArrowState): (WebCore::ScrollbarThemeChromiumWin::getClassicThemeState): (WebCore::ScrollbarThemeChromiumWin::buttonSize):
platform/chromium/ScrollbarThemeChromiumWin.h: Added.

3:45 PM Changeset in webkit [44399] by bfulgham@webkit.org

2 edits in trunk/WebKit/win

2009-06-03 Brent Fulgham <bfulgham@webkit.org>

Build fix for Windows Cairo.

WebKit.vcproj/WebKit.vcproj: Remove unneeded giflib.lib link command.

3:32 PM Changeset in webkit [44398] by bfulgham@webkit.org

10 edits in trunk/WebCore

2009-06-03 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Enabling debugger requires that Scripts panel is already attached to the
render tree. The reason is that recompile events result in script sources
being added into the source frames. Prior to the global options introduced,
debugger was enabled from the Scripts panel, so that it was guaranteed to
exist. The InspectorController::enableDebugger API calls with no inspector
frontend showing were failing though.

https://bugs.webkit.org/show_bug.cgi?id=26145

WebCore.base.exp:
inspector/InspectorController.cpp: (WebCore::InspectorController::setWindowVisible): (WebCore::InspectorController::scriptObjectReady): (WebCore::InspectorController::enableDebuggerFromFrontend): (WebCore::InspectorController::enableDebugger):
inspector/InspectorController.h:
inspector/InspectorController.idl:
inspector/InspectorFrontend.cpp: (WebCore::InspectorFrontend::attachDebuggerWhenShown):
inspector/InspectorFrontend.h:
inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel.prototype.show): (WebInspector.ScriptsPanel.prototype.attachDebuggerWhenShown):
inspector/front-end/inspector.js: (WebInspector.attachDebuggerWhenShown):

3:31 PM Changeset in webkit [44397] by weinig@apple.com

6 edits in branches/nitro-extreme/JavaScriptCore

2009-06-03 Sam Weinig <sam@webkit.org>

Reviewed by Geoffrey Garen.

Add back known this value optimization by abstracting
slow case if not JSCell jumps.

jit/JIT.h:
jit/JITCall.cpp: (JSC::JIT::compileOpCallVarargs): (JSC::JIT::compileOpCallVarargsSlowCase): (JSC::JIT::compileOpCall): (JSC::JIT::compileOpCallSlowCase):
jit/JITInlineMethods.h: (JSC::JIT::emitJumpSlowCaseIfNotJSCell): (JSC::JIT::linkSlowCaseIfNotJSCell):
jit/JITOpcodes.cpp: (JSC::JIT::emit_op_instanceof): (JSC::JIT::emitSlow_op_instanceof):
jit/JITPropertyAccess.cpp: (JSC::JIT::emit_op_get_by_val): (JSC::JIT::emitSlow_op_get_by_val): (JSC::JIT::emit_op_put_by_val): (JSC::JIT::emitSlow_op_put_by_val): (JSC::JIT::emit_op_get_by_id): (JSC::JIT::emitSlow_op_get_by_id): (JSC::JIT::emit_op_put_by_id): (JSC::JIT::emitSlow_op_put_by_id):

3:10 PM Changeset in webkit [44396] by mitz@apple.com

2 edits in trunk/WebCore

Reviewed by Anders Carlsson.

fix a regression from the previous patch

platform/graphics/Font.cpp: Initialize shouldUseFontSmoothing to true.

3:03 PM Changeset in webkit [44395] by mitz@apple.com

13 edits
2 deletes in trunk

WebCore:

Reviewed by Anders Carlsson.

eliminate WebCoreTextRenderer

WebCore.base.exp: Updated.
WebCore.xcodeproj/project.pbxproj: Removed WebCoreTextRenderer.{h,mm}

and promoted WebFontCache.h to private.

platform/graphics/Font.cpp: (WebCore::Font::setShouldUseSmoothing): Added this static setter for

a new file-static boolean.

(WebCore::Font::shouldUseSmoothing): Added this static getter.

platform/graphics/Font.h: Decleared setShouldUseSmoothing() and

shouldUseSmoothing().

platform/graphics/mac/FontMac.mm: (WebCore::Font::drawGlyphs): Use Font::shouldUseSmoothing() instead of WebCoreShouldUseFontSmoothing().
platform/graphics/mac/WebLayer.mm: Removed unneeded #import.
platform/mac/WebCoreTextRenderer.h: Removed.
platform/mac/WebCoreTextRenderer.mm: Removed.

WebKit:

Reviewed by Anders Carlsson.

WebKit project part of eliminating WebCoreTextRenderer

WebKit.xcodeproj/project.pbxproj: Changed WebKitNSStringExtras.m to

compile as Objective-C++.

WebKit/mac:

Reviewed by Anders Carlsson.

WebKit part of eliminating WebCoreTextRenderer

Misc/WebKitNSStringExtras.m: (webkit_CGCeiling): Added. (-[NSString _web_drawAtPoint:font:textColor:]): Replaced the malloc()ed

string buffer with a Vector. Moved code from
WebCoreDrawTextAtPoint() to here.

(-[NSString _web_drawDoubledAtPoint:withTopColor:bottomColor:font:]):
(-[NSString _web_widthWithFont:]): Replaced the malloc()ed string buffer

with a Vector. Moved code from WebCoreTextFloatWidth() to here.

WebView/WebHTMLView.mm: (-[WebHTMLView _addToStyle:fontA:fontB:]): Replaced call to

WebCoreFindFont() with use of
+[WebFontCache fontWithFamily:traits:weight:size:].

WebView/WebView.mm: (+[WebView _setAlwaysUsesComplexTextCodePath:]): Changed to call

Font::setCodePath() directly.

(+[WebView _setShouldUseFontSmoothing:]): Changed to call

Font::setShouldUseSmoothing().

(+[WebView _shouldUseFontSmoothing]): Changed to call

Font::shouldUseSmoothing().

2:11 PM Changeset in webkit [44394] by mrowe@apple.com

4 edits in branches/WWDC-2009-branch

Versioning.

2:09 PM Changeset in webkit [44393] by mrowe@apple.com

1 copy in tags/Safari-6530.15

New tag.

2:05 PM Changeset in webkit [44392] by mrowe@apple.com

2 edits in branches/WWDC-2009-branch/JavaScriptCore

Merge r44356.

1:32 PM Changeset in webkit [44391] by levin@chromium.org

2 edits in trunk/WebCore

2009-06-03 David Levin <levin@chromium.org>

Reviewed by Dimitri Glazkov.

v8's ScriptController::evaluate should protect the Frame like the jsc version.
https://bugs.webkit.org/show_bug.cgi?id=26172

This change is simply copying protections done for Frame in the method
WebCore::ScriptController::evaluate in the file js/ScriptController.cpp.

bindings/v8/ScriptController.cpp: (WebCore::ScriptController::evaluate):

1:17 PM Changeset in webkit [44390] by mitz@apple.com

3 edits in trunk/WebKit/mac

Rubber-stamped by Mark Rowe.

remove a private method that was used only by Safari 3.0.

WebView/WebView.mm: Removed +_minimumRequiredSafariBuildNumber.
WebView/WebViewPrivate.h: Ditto.

11:24 AM Changeset in webkit [44389] by mitz@apple.com

3 edits in trunk/WebCore

Reviewed by John Sullivan.

fix <rdar://problem/6841120> Use CTFontManager notifications instead of ATS notifications

platform/graphics/FontCache.h: Made it an error to destroy a FontCache instance.
platform/graphics/mac/FontCacheMac.mm: (WebCore::fontCacheRegisteredFontsChangedNotificationCallback): Added this notification callback for the kCTFontManagerRegisteredFontsChangedNotification, which calls invalidate(). (WebCore::FontCache::platformInit): Register for kCTFontManagerRegisteredFontsChangedNotification.

11:10 AM Changeset in webkit [44388] by mitz@apple.com

2 edits in trunk/WebKit/mac

build fix

WebView/WebHTMLView.mm:

10:07 AM Changeset in webkit [44387] by kevino@webkit.org

2 edits in trunk/WebCore

Reviewed by Kevin Ollivier.

Use CGContextShowGlyphsWithAdvances to get more accurate text rendering on Mac.

https://bugs.webkit.org/show_bug.cgi?id=26161

9:43 AM Changeset in webkit [44386] by Dimitri Glazkov

2 edits in trunk/WebCore

2009-06-03 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Reorder ResourcesPanel components initialization to unfreeze resource list scroller.

https://bugs.webkit.org/show_bug.cgi?id=26159

inspector/front-end/ResourcesPanel.js: (WebInspector.ResourcesPanel):

9:41 AM Changeset in webkit [44385] by Dimitri Glazkov

3 edits in trunk/WebCore

2009-06-03 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Fix for crash (preceded by assertion) in InspectorController::didCommitLoad when reloading or navigating with the Inspector open.
Fix for Inspector's Elements panel being empty when Inspector first appears.

https://bugs.webkit.org/show_bug.cgi?id=26134
https://bugs.webkit.org/show_bug.cgi?id=26135

inspector/InspectorController.cpp: (WebCore::InspectorController::scriptObjectReady): (WebCore::InspectorController::didLoadResourceFromMemoryCache): (WebCore::InspectorController::identifierForInitialRequest): (WebCore::InspectorController::ensureResourceTrackingSettingsLoaded):
inspector/InspectorController.h:

9:35 AM Changeset in webkit [44384] by mitz@apple.com

3 edits in trunk/WebKit/mac

Reviewed by Anders Carlsson.

build fix

WebView/WebHTMLView.mm:
WebView/WebView.mm:

8:29 AM Changeset in webkit [44383] by Adam Roben

2 edits in trunk/WebCore

Windows build fix after r44379

svg/graphics/SVGImage.cpp: Move EmptyClients.h back down below the other #includes to fix a compiler warning on Windows.

7:22 AM Changeset in webkit [44382] by Simon Hausmann

2 edits in trunk/WebCore

2009-06-02 Kenneth Rohde Christiansen <kenneth.christiansen@openbossa.org>

Reviewed by Simon Hausmann.

Add workaround for crash in Linux Flash Player when hosted by
another toolkit than GTK+. Bug fixed at the Flash Player bugzilla,
issue (FP-2140).

7:21 AM Changeset in webkit [44381] by Simon Hausmann

5 edits
1 add in trunk/WebCore

2009-06-01 Kenneth Rohde Christiansen <kenneth.christiansen@openbossa.org>

Reviewed by Simon Hausmann.

Refactor the Qt plugin code to use NPP_SetWindow correctly,
to make resizing of plugins work.

Attention was paid to make sure that the windowed plugins scroll
synchronized with the page view. A manual test has been added.

12:33 AM Changeset in webkit [44380] by ap@webkit.org

2 edits in trunk/LayoutTests

Rubber-stamped by Mark Rowe.

Fix appcache/fallback.html test broken by network simulator changes made for a preloading test.

http/tests/resources/network-simulator.php: Tell PHP that a variable is global.

Jun 2, 2009:

10:37 PM Changeset in webkit [44379] by Darin Adler

41 edits in trunk

WebCore:

2009-06-02 Darin Adler <Darin Adler>

Reviewed by David Hyatt.

Bug 26112: viewless WebKit -- make events work
https://bugs.webkit.org/show_bug.cgi?id=26112

The main fix here is to make mouse and wheel event coordinates in the coordinate
system of the top level NSView rather than the NSWindow when in the viewless mode.
This is the design Hyatt chose, but the event part of it wasn't done yet.

Also fix FrameView to do normal reference counting instead of a strange model with
an explicit deref near creation time.

WebCore.base.exp: Updated.

page/EventHandler.cpp: (WebCore::EventHandler::eventLoopHandleMouseUp): Moved this function into the file to reduce conditionals in the header. (WebCore::EventHandler::eventLoopHandleMouseDragged): Ditto.

page/EventHandler.h: Reduced includes. Fixed formatting of Objective-C types. Made currentNSEvent a static member function. Added sendContextMenuEvent and eventMayStartDrag functions that takes NSEvent * so the conversion to PlatformMouseEvent can be done here rather than in WebKit. Reduced #if by making eventLoopHandleMouseUp and eventLoopHandleMouseDragged unconditional.

page/Frame.cpp: (WebCore::Frame::setView): Made this take a PassRefPtr since it takes ownership. (WebCore::Frame::createView): Changed to use RefPtr and FrameView::create and remove the explicit deref.

page/Frame.h: Changed setView to take a PassRefPtr.

page/FrameTree.cpp: Added newly-needed include.

page/FrameView.cpp: (WebCore::FrameView::FrameView): Got rid of one of the two constructors, and removed the initialization of m_refCount and call to show from the reamining one. (WebCore::FrameView::create): Added two create functions that do what the two constructors did before, except that they return a PassRefPtr to make sure the reference counting is handled correctly. (WebCore::FrameView::~FrameView): Removed assertion from when FrameView implemented its own reference counting.

page/FrameView.h: Inherit from RefCounted for reference counting. Made the constructor private and added create functions. Got rid of the hand-implemented reference counting in this class.

page/mac/EventHandlerMac.mm: (WebCore::currentNSEventSlot): Renamed currentEvent to currentNSEventSlot to make it more clear how it relates to currentNSEvent. (WebCore::EventHandler::currentNSEvent): Updated. (WebCore::CurrentEventScope::CurrentEventScope): Added. Use to set/reset the current event in a foolproof way. (WebCore::CurrentEventScope::~CurrentEventScope): Ditto. (WebCore::EventHandler::wheelEvent): Use CurrentEventScope. Pass the platform window in when constructing the PlatformWheelEvent. (WebCore::EventHandler::keyEvent): Use CurrentEventScope. (WebCore::lastEventIsMouseUp): Use currentNSEvent. (WebCore::EventHandler::passMouseDownEventToWidget): Ditto. (WebCore::EventHandler::eventLoopHandleMouseDragged): Ditto. (WebCore::EventHandler::eventLoopHandleMouseUp): Ditto. (WebCore::EventHandler::passSubframeEventToSubframe): Use currentPlatformMouseEvent to get a mouse event that has the appropriate platform window passed to create it. (WebCore::EventHandler::passWheelEventToWidget): Ditto. (WebCore::EventHandler::mouseDown): Ditto. (WebCore::EventHandler::mouseDragged): Ditto. (WebCore::EventHandler::mouseUp): Ditto. (WebCore::EventHandler::mouseMoved): Ditto. (WebCore::EventHandler::currentPlatformMouseEvent): Added. Passes the platform window that's now needed to create a PlatformMouseEvent. (WebCore::EventHandler::sendContextMenuEvent): Added. (WebCore::EventHandler::eventMayStartDrag): Added.

platform/HostWindow.h: Removed unneeded includes and constructor definition.

platform/PlatformMouseEvent.h: Sorted things in alphabetical order. Changed Mac constructor to take a windowView as well as the event. This is needed in viewless mode, since the "window" is actually an NSView, so the event has to know which view to compute the coordinates with. Made the same change to pointForEvent.
platform/PlatformWheelEvent.h: Ditto.

platform/mac/PlatformMouseEventMac.mm: (WebCore::pointForEvent): Convert point from window coordinates to view coordinates if a windowView is passed in. This is used in viewless mode. (WebCore::PlatformMouseEvent::PlatformMouseEvent): Ditto.
platform/mac/WheelEventMac.mm: (WebCore::PlatformWheelEvent::PlatformWheelEvent): Ditto.

platform/mac/WidgetMac.mm: (WebCore::Widget::convertFromContainingWindow): Fixed case where there is no platform widget and no parent. Before it would yield unpredictable results because of dispatching to a nil object and returning a structure. Now it returns the point without changing coordinates at all, which is what we need for this case in viewless mode.

rendering/RenderApplet.cpp: Removed unneeded includes. (WebCore::RenderApplet::intrinsicSize): Use widget function. (WebCore::RenderApplet::createWidgetIfNecessary): Ditto.

rendering/RenderApplet.h: Make more things private. Get rid of unneeded explicit destructor.

rendering/RenderFrame.cpp: Removed unneeded includes. (WebCore::RenderFrame::edgeInfo): Updated to use node function so header doesn't have to define element function. (WebCore::RenderFrame::viewCleared): Ditto. Also changed to use widget function.

rendering/RenderFrame.h: Removed unneeded includes. Made some things private. Got rid of element function.

rendering/RenderPart.cpp: Removed unneeded includes. (WebCore::RenderPart::~RenderPart): Changed to use clearWidget function. (WebCore::RenderPart::setWidget): Changed to use widget function. (WebCore::RenderPart::deleteWidget): Changed to use passed-in widget. This is now only called by the clearWidget function.

rendering/RenderPart.h: Removed unneeded forward declarations. Made more functions private. Updated deleteWidget to take widget argument.

rendering/RenderPartObject.cpp: (WebCore::RenderPartObject::~RenderPartObject): use frameView function instead of getting at m_view directly. (WebCore::RenderPartObject::updateWidget): Ditto. (WebCore::RenderPartObject::layout): Ditto. Same for widget and m_widget. (WebCore::RenderPartObject::viewCleared): Ditto.

rendering/RenderPartObject.h: Made some functions private.

rendering/RenderWidget.cpp: (WebCore::RenderWidget::RenderWidget): Initialize m_frameView with construction syntax instead of assignment. (WebCore::RenderWidget::destroy): Updated for name change of m_view to m_frameView. (WebCore::RenderWidget::~RenderWidget): Use clearWidget to delete the widget. (WebCore::RenderWidget::setWidget): Use clearWidget. (WebCore::RenderWidget::paint): Updated for name change of m_view to m_frameView. (WebCore::RenderWidget::deleteWidget): Changed to use passed-in widget.

rendering/RenderWidget.h: Made many functions protected, others private and made all data members private.

svg/animation/SMILTime.h: Removed unhelpful max and min functions. These just do what std::max and std::min will already do automatically for this type, so they are not helpful.

svg/graphics/SVGImage.cpp: (WebCore::SVGImage::SVGImage): Removed unneeded initial values for types that initialize to zero without anything explicit. (WebCore::SVGImage::~SVGImage): Update since m_frame and m_frameView are no longer stored. (WebCore::SVGImage::setContainerSize): Ditto. (WebCore::SVGImage::usesContainerSize): Ditto. (WebCore::SVGImage::size): Ditto. (WebCore::SVGImage::hasRelativeWidth): Ditto. (WebCore::SVGImage::hasRelativeHeight): Ditto. (WebCore::SVGImage::draw): Ditto. (WebCore::SVGImage::nativeImageForCurrentFrame): Ditto. (WebCore::SVGImage::dataChanged): Ditto.

svg/graphics/SVGImage.h: Removed unneeded includes and unneeded data members m_document, m_frame, m_frameView, and m_minSize.

WebKit/mac:

2009-06-02 Darin Adler <Darin Adler>

Reviewed by David Hyatt.

Bug 26112: viewless WebKit -- make events work
https://bugs.webkit.org/show_bug.cgi?id=26112

One change here is to make the -[WebFrame frameView] function assert if ever called
in viewless mode, and fix many callers that would trip that assertion.

A major change is to put some methods and data in WebView that are currently in
WebHTMLView, used only in viewless mode. A next step will be to use the WebView
methods whenever possible, even when not in the viewless mode.

Also fix FrameView to do normal reference counting instead of a strange model with
an explicit deref near creation time.

WebCoreSupport/WebChromeClient.mm: (WebChromeClient::scrollRectIntoView): Add code to start in the appropriate place when dealing with viewless mode. This gets triggered when visiting the Google home page. (WebChromeClient::setToolTip): Changed to call WebView instead of WebHTMLView. (WebChromeClient::print): Changed to use a new selector that doesn't require a WebFrameView if present. Also don't even try to use the old selector in viewless mode.

WebCoreSupport/WebEditorClient.mm: (WebEditorClient::respondToChangedSelection): Changed to call WebView instead of WebHTMLView.

WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::transitionToCommittedForNewPage): Added more code paths for viewless mode to skip things we can't do in that mode, with appropriate FIXME. Use Frame::create and RefPtr and eliminate the strange reference counting of FrameView.

WebView/WebDataSource.mm: (-[WebDataSource _receivedData:]): Added a _usesDocumentViews guard around code that's specific to document views.

WebView/WebFrame.mm: (-[WebFrame _updateBackgroundAndUpdatesWhileOffscreen]): Added a _usesDocumentViews guard around code that's specific to document views. (-[WebFrame _hasSelection]): Added an implementation for viewless mode. (-[WebFrame _clearSelection]): Assert we're not in viewless mode; it doesn't really make sense to clear the selection in only one frame in viewless mode. Later we can decide what to do. (-[WebFrame _dragSourceMovedTo:]): Assert we're not in viewless mode; the dragging code for viewless mode shouldn't have to involve the WebFrame object at all. (-[WebFrame _dragSourceEndedAt:operation:]): Ditto. (-[WebFrame frameView]): Assert we're not in viewless mode. This assertion fires often, but it's a great pointer to code that needs to be changed.

WebView/WebHTMLView.mm: (-[WebHTMLView hitTest:]): Tweaked a comment. (-[WebHTMLView _updateMouseoverWithEvent:]): Fixed a bug where the fake event for moving the mouse out of the old view ended up overwriting the event for moving the mouse within the new view. (-[WebHTMLView mouseDown:]): Got rid of explicit conversion of event to PlatformMouseEvent in call to sendContextMenuEvent; that's no longer possible without passing another argument, and it's now handled in EventHandler.

WebView/WebTextCompletionController.h: Copied from WebKit/mac/WebView/WebHTMLView.mm. Removed everything except for the WebTextCompletionController class.
WebView/WebTextCompletionController.mm: Copied from WebKit/mac/WebView/WebHTMLView.mm. Ditto.

WebView/WebUIDelegatePrivate.h: Added webView:printFrame: method.

WebView/WebView.mm: Moved includes and fields in from WebHTMLView. (-[WebView _usesDocumentViews]): Updated for name change from useDocumentViews to usesDocumentViews. (-[WebView _commonInitializationWithFrameName:groupName:usesDocumentViews:]): Ditto. (-[WebView drawSingleRect:]): Ditto. (-[WebView isFlipped]): Ditto. (-[WebView setFrameSize:]): Ditto. Also changed to use _mainCoreFrame method. (-[WebView _viewWillDrawInternal]): Ditto. (-[WebView viewWillDraw]): Ditto. (-[WebView drawRect:]): Ditto. (-[WebView _close]): Added code to nil out the lastMouseoverView global. (-[WebView _dashboardRegions]): Use _mainCoreFrame. (-[WebView setProhibitsMainFrameScrolling:]): Ditto. (-[WebView _setInViewSourceMode:]): Ditto. (-[WebView _inViewSourceMode]): Ditto. (-[WebView _attachScriptDebuggerToAllFrames]): Ditto. (-[WebView _detachScriptDebuggerFromAllFrames]): Ditto. (-[WebView textIteratorForRect:]): Ditto. (-[WebView _executeCoreCommandByName:value:]): Ditto. (-[WebView addWindowObserversForWindow:]): Ditto. (-[WebView removeWindowObservers]): Ditto. (-[WebView _updateFocusedAndActiveState]): Ditto. (-[WebView _updateFocusedAndActiveStateForFrame:]): Turned into a class method. Added code to handle the viewless case without calling frameView. (-[WebView _windowDidBecomeKey:]): Updated for name change from useDocumentViews to usesDocumentViews. (-[WebView _windowDidResignKey:]): Ditto. (-[WebView _windowWillOrderOnScreen:]): Ditto. (-[WebView mainFrame]): Tweaked. (-[WebView selectedFrame]): Added a conditional to avoid trying to get at the frame view in viewless case. (-[WebView _setZoomMultiplier:isTextOnly:]): Use _mainCoreFrame. (-[WebView setCustomTextEncodingName:]): Ditto. (-[WebView windowScriptObject]): Ditto. (-[WebView setHostWindow:]): Ditto. Also put some code that's needed only for document views inside _private->usesDocumentViews. (-[WebView _hitTest:dragTypes:]): Tweaked. (-[WebView acceptsFirstResponder]): Added case for viewless mode along with a FIXME, since it's not complete. (-[WebView becomeFirstResponder]): Ditto. (-[WebView _webcore_effectiveFirstResponder]): Put the body of this inside a usesDocumentView check, because we don't need the first responder forwarding in viewless mode. (-[WebView setNextKeyView:]): Ditto. (-[WebView mouseDown:]): Added. Copied from WebHTMLView. FIXME in here suggests that we make WebHTMLView share this one soon, which I think is practical. (-[WebView mouseUp:]): Ditto. (-[WebView setHoverFeedbackSuspended:]): Added a code path for viewless mode. (-[WebView shouldClose]): Use _mainCoreFrame. (-[WebView aeDescByEvaluatingJavaScriptFromString:]): Ditto. (-[WebView setEditable:]): Ditto. (-[WebView _frameViewAtWindowPoint:]): Added an assertion that we're not in viewless mode since this method makes no sense in that mode. (-[WebView _setMouseDownEvent:]): Added. Copied from WebHTMLView. I plan to eliminate the one in WebHTMLView soon. (-[WebView _cancelUpdateMouseoverTimer]): Ditto. (-[WebView _stopAutoscrollTimer]): Ditto. (+[WebView _updateMouseoverWithEvent:]): Ditto. (-[WebView _updateMouseoverWithFakeEvent]): Ditto. (-[WebView _setToolTip:]): Added. Calls through to the WebHTMLView version. (-[WebView _selectionChanged]): Ditto. (-[WebView _mainCoreFrame]): Added. (-[WebView _needsOneShotDrawingSynchronization]): Moved into the WebInternal category. (-[WebView _setNeedsOneShotDrawingSynchronization:]): Ditto. (-[WebView _startedAcceleratedCompositingForFrame:]): Ditto. (-[WebView _stoppedAcceleratedCompositingForFrame:]): Ditto. (viewUpdateRunLoopObserverCallBack): Ditto. (-[WebView _scheduleViewUpdate]): Ditto.

WebView/WebViewInternal.h: Made most of the file not compile at all when included from non-C++ source files, elminating some excess declarations and typedefs. Moved more methods into the real internal category. Added new methods _setMouseDownEvent, _cancelUpdateMouseoverTimer, _stopAutoscrollTimer, _updateMouseoverWithFakeEvent, _selectionChanged, and _setToolTip:.

WebKit/wx:

2009-06-02 Darin Adler <Darin Adler>

Reviewed by David Hyatt.

WebKitSupport/FrameLoaderClientWx.cpp: (WebCore::FrameLoaderClientWx::transitionToCommittedForNewPage): Use FrameView::create and RefPtr instead of the old "crazy" reference counting.

8:15 PM Changeset in webkit [44378] by agl@chromium.org

4 edits in trunk/WebCore

2009-06-02 Adam Langley <agl@google.com>

Reviewed by Eric Seidel.

The previous code was assuming that we'll be painting buttons on the scrollbar
which isn't true on Linux. To reproduce, resize a page with scrollbars until
they are less than two widths high.

This will need pixel test baselines to be updated in the Chromium tree.

platform/chromium/ScrollbarThemeChromium.cpp: move this function...
platform/chromium/ScrollbarThemeChromiumWin.cpp: (WebCore::ScrollbarThemeChromium::trackRect): ... to here
platform/chromium/ScrollbarThemeChromiumLinux.cpp: (WebCore::ScrollbarThemeChromium::trackRect): add an alternative which doesn't remove the track when the scrollbar is less than two widths high.

7:57 PM Changeset in webkit [44377] by jberlin@apple.com

2 edits in trunk/WebKitTools

2009-06-02 Jessie Berlin <jberlin@apple.com>

Reviewed by Mark Rowe.

Add "replace" behavior so that it shows the addition part of the
replacement of the file first, and then shows the changes.

Future: Add in showing the removal part of the replacement.

Scripts/svn-create-patch:

7:01 PM Changeset in webkit [44376] by mrowe@apple.com

8 edits in trunk

Remove workaround that was added to address <rdar://problem/5488678> as it no longer affects our Tiger builds.

Reviewed by Anders Carlsson.

Configurations/Base.xcconfig:

5:19 PM Changeset in webkit [44375] by eric@webkit.org

3 edits
2 adds in trunk

2009-06-02 Eric Seidel <eric@webkit.org>

Reviewed by Maciej Stachowiak.

Insert*List on an stand-alone image in a content editable region ASSERTS
ASSERTION FAILED: isStartOfParagraph(startOfParagraphToMove)
https://bugs.webkit.org/show_bug.cgi?id=19066

Attempt to fix this by noticing that we inserted the list inside
the selection which includes the image, and re-adjust the selection
to not include the list before trying to move the image into
the list item.

Test: editing/execCommand/list-wrapping-image-crash.html

editing/InsertListCommand.cpp: (WebCore::InsertListCommand::doApply):

4:09 PM Changeset in webkit [44374] by eric@webkit.org

3 edits in trunk/WebCore

2009-06-02 Eric Seidel <eric@webkit.org>

Reviewed by Darin Adler.

Rename PositionIterator members in hope of futher clarity
https://bugs.webkit.org/show_bug.cgi?id=24854

Rename m_parent to m_anchorNode (since although it's always the parent
of the previous m_child member, it is not always the parent of the effective position)
Rename m_child to m_nodeAfterPositionInAnchor to make clear that it's the node
directly following the position. This member is often NULL, but is always
a child of m_parent, now m_anchorNode if set.
Rename m_offset to m_offsetInAnchor (since it's interpreted relative to m_anchorNode)

dom/PositionIterator.cpp: (WebCore::PositionIterator::operator Position): (WebCore::PositionIterator::increment): (WebCore::PositionIterator::decrement): (WebCore::PositionIterator::atStart): (WebCore::PositionIterator::atEnd): (WebCore::PositionIterator::atStartOfNode): (WebCore::PositionIterator::atEndOfNode): (WebCore::PositionIterator::isCandidate):
dom/PositionIterator.h: (WebCore::PositionIterator::PositionIterator): (WebCore::PositionIterator::node): (WebCore::PositionIterator::offsetInLeafNode):

3:08 PM Changeset in webkit [44373] by jianli@chromium.org

1 edit in trunk/WebCore/ChangeLog

Fix the incorrect bug link in WebCore/ChangeLog for r44366.

2:46 PM Changeset in webkit [44372] by ap@webkit.org

2 edits in trunk/LayoutTests

Land correct results for a test I just added (forgot to regenerate them after adding new
test cases).

fast/xpath/py-dom-xpath/expressions-expected.txt:

2:43 PM Changeset in webkit [44371] by pkasting@chromium.org

4 edits in trunk/WebCore

Revert r44276.

2:42 PM Changeset in webkit [44370] by cmarrin@apple.com

1 edit
4 moves in trunk/LayoutTests

Moved CSSMatrix tests into LayoutTests/transforms so both 2D and 3D versions get tested in all cases, as per discussion with Maciej

2:33 PM Changeset in webkit [44369] by eric@webkit.org

5 edits in trunk

2009-06-02 Julien Chaffraix <jchaffraix@webkit.org>

Reviewed by Eric Seidel.

Bug 17167: Failures in fast/dom/Node/initial-values.html

This partly solve a compatibility issue with other browsers. It will also
make us more consistent while handling XHTML element.

The issue is that when we create an XHTML element inside an HTML document
(as it is the case when calling createElementNS), we default to the HTML
behaviour in nodeName. As we cannot test if an HTMLElement is an XHTML
element, our fix is to check whether it has a prefix and then default
to XML behaviour for nodeName.

html/HTMLElement.cpp: (WebCore::HTMLElement::nodeName): Add a prefix check before returning the uppercase tagName (HTML behaviour).

2:31 PM Changeset in webkit [44368] by eric@webkit.org

3 edits in trunk/WebCore

2009-06-02 Eric Seidel <eric@webkit.org>

Reviewed by Maciej Stachowiak.

Add a compareBoundaryPoints which takes RangeBoundaryPoints
https://bugs.webkit.org/show_bug.cgi?id=25500

I noticed the need for this function when removing compareBoundaryPoints(Position, Position)
This patch is almost entirely minus lines.

No functional changes, thus no tests.

dom/Range.cpp: (WebCore::Range::setStart): (WebCore::Range::setEnd): (WebCore::Range::compareBoundaryPoints): (WebCore::Range::boundaryPointsValid):
dom/Range.h:

2:31 PM Changeset in webkit [44367] by eric@webkit.org

11 edits in trunk/WebCore

2009-06-02 Eric Seidel <eric@webkit.org>

Reviewed by Maciej Stachowiak.

Remove Range::compareBoundaryPoints(Position, Position) per Darin's suggestion in bug 25056
https://bugs.webkit.org/show_bug.cgi?id=25500

Darin indicated the Range should deal only with primitive DOM node/offset
pairs, and that Position (which is a more robust editing construct) should have
its own comparison functions and that Range.h should not mention Position at all.

Turns out that Position already has a comparePositions() function (which knows
how to additionally handled positions in shadow trees). So I've just changed
all callers of compareBoundaryPoints(Position, Position) to use the existing
comparePositions() function. I've also added a comparePositions which takes
VisiblePositions for convenience.

dom/Range.cpp:
dom/Range.h:
editing/ApplyStyleCommand.cpp: (WebCore::ApplyStyleCommand::updateStartEnd): (WebCore::ApplyStyleCommand::applyBlockStyle): (WebCore::ApplyStyleCommand::applyRelativeFontStyleChange): (WebCore::ApplyStyleCommand::applyInlineStyle): (WebCore::ApplyStyleCommand::applyInlineStyleToRange): (WebCore::ApplyStyleCommand::removeInlineStyle): (WebCore::ApplyStyleCommand::nodeFullySelected): (WebCore::ApplyStyleCommand::nodeFullyUnselected):
editing/CompositeEditCommand.cpp: (WebCore::CompositeEditCommand::deleteInsignificantText): (WebCore::CompositeEditCommand::moveParagraphContentsToNewBlockIfNecessary): (WebCore::CompositeEditCommand::moveParagraphs):
editing/DeleteSelectionCommand.cpp: (WebCore::DeleteSelectionCommand::initializeStartEnd): (WebCore::DeleteSelectionCommand::handleGeneralDelete): (WebCore::DeleteSelectionCommand::mergeParagraphs):
editing/SelectionController.cpp: (WebCore::SelectionController::nodeWillBeRemoved):
editing/VisibleSelection.cpp: (WebCore::VisibleSelection::toNormalizedRange):
editing/htmlediting.cpp: (WebCore::comparePositions):
editing/htmlediting.h:
page/EventHandler.cpp: (WebCore::EventHandler::handleMousePressEventSingleClick):

2:09 PM Changeset in webkit [44366] by jianli@chromium.org

4 edits in trunk/WebCore

2009-06-02 Albert J. Wong <ajwong@chromium.org>

Reviewed by Dimitri Glazkov.

https://bugs.webkit.org/show_bug.cgi?id=25595
Upstream v8_utility.h functions into V8Utilities.h. This patch has
some transitional code to make upstreaming easier. This code will
be deleted in a few days.

bindings/v8/ScriptFunctionCall.cpp: (WebCore::ScriptFunctionCall::construct): NewInstance -> newInstance.
bindings/v8/V8Utilities.h: (WebCore::AllowAllocation::AllowAllocation): Function added. (WebCore::AllowAllocation::~AllowAllocation): Function added. (WebCore::SafeAllocation::NewInstance): Function added.
bindings/v8/WorkerContextExecutionProxy.cpp: (WebCore::WorkerContextExecutionProxy::initContextIfNeeded): NewInstance -> newInstance. (WebCore::WorkerContextExecutionProxy::toV8): NewInstance -> newInstance.

1:59 PM Changeset in webkit [44365] by andersca@apple.com

4 edits in trunk/WebKitLibraries

2009-06-02 Anders Carlsson <andersca@apple.com>

Rubber-stamped by Mark Rowe.

Update WebKitSystemInterface.

libWebKitSystemInterfaceLeopard.a:
libWebKitSystemInterfaceSnowLeopard.a:
libWebKitSystemInterfaceTiger.a:

1:25 PM Changeset in webkit [44364] by mitz@apple.com

2 edits in trunk/WebCore

Reviewed by John Sullivan.

fix <rdar://problem/6940747> Search field’s focus ring is outset

rendering/RenderThemeWin.cpp: (WebCore::RenderThemeWin::adjustSearchFieldStyle): Set the focused search field outline offset to -2.

12:01 PM Changeset in webkit [44363] by bfulgham@webkit.org

4 edits in trunk/WebKitTools

2009-06-02 Brent Fulgham <bfulgham@webkit.org>

Reviewed by Adam Roben.

Update WinLauncher for WebKitCreateInstance.
https://bugs.webkit.org/show_bug.cgi?id=26136

WinLauncher/WinLauncher.cpp: Revise implementation to use WebKitCreateInstance (rather than CoCreateInstance).
WinLauncher/WinLauncher.h: Modify include path for WebKit.h to match DumpRenderTree style.
WinLauncher/WinLauncher.vcproj: Remove unnecessary WebKit.tlb and EmbeddedIDL flags from build.

11:10 AM Changeset in webkit [44362] by weinig@apple.com

2 edits in trunk/WebCore

2009-06-02 Sam Weinig <sam@webkit.org>

Reviewed by Alexey Proskuryakov.

Add list of unimplemented event handlers to DOMWindow.

page/DOMWindow.idl:

10:59 AM Changeset in webkit [44361] by ap@webkit.org

11 edits
17 adds in trunk

Reviewed by Sam Weinig.

https://bugs.webkit.org/show_bug.cgi?id=26133
Adapt and import py-dom-xpath tests

Tests: fast/xpath/py-dom-xpath/abbreviations.html

fast/xpath/py-dom-xpath/axes.html
fast/xpath/py-dom-xpath/data.html
fast/xpath/py-dom-xpath/expressions.html
fast/xpath/py-dom-xpath/functions.html
fast/xpath/py-dom-xpath/nodetests.html
fast/xpath/py-dom-xpath/paths.html
fast/xpath/py-dom-xpath/predicates.html

Fix bugs found with this test suite:

name and local-name were incorrect for processing instructions (XPath expanded-name doesn't match DOM exactly);
name, local-name and namespace functions should crash on attribute nodes;
attemps to make node sets from other types were not detected as errors.

No performance impact.

xml/XPathExpressionNode.h: Track type conversion errors that happen during evaluation. An error won't stop evaluation, but an exception will be raised afterwards. We could also detect conversion errors at compile time, but not if we're going to support XPath variables (which is unnecessary for XPathEvaluator, but will be necessary if we decide to make our own XSLT one day).

xml/XPathExpression.cpp: (WebCore::XPathExpression::evaluate): Check whether a type conversion exception occurred during evaluation, and raise an excpetion if it did.

xml/XPathFunctions.cpp: (WebCore::XPath::expandedNameLocalPart): (WebCore::XPath::expandedName): XPath name(), local-name() and namespace-uri() functions are defined in terms of expanded-name, which doesn't match anything available via DOM exactly. Calculate the expanded name properly. (WebCore::XPath::FunNamespaceURI::evaluate): This function could crash if used with an attribute node, because it released what was possibly the only reference to attribute node before using it. Changed the function to avoid such situation. (WebCore::XPath::FunLocalName::evaluate): Ditto. Also, used the new expandedNameLocalPart() to work properly with processing instruction nodes. (WebCore::XPath::FunName::evaluate): Ditto (using expandedName()). (WebCore::XPath::FunCount::evaluate): Signal an error if the argument is not a node-set (by using toNodeSet unconditionally, which will raise an error, and return an empty set).

xml/XPathPath.cpp: (WebCore::XPath::Filter::evaluate): Signal an error if the expression evaluation result is not a node-set.

xml/XPathPath.h: (WebCore::XPath::Filter::resultType): A Filter's result is actually always a node-set (this is not so for FilterExpr production in the spec, but is for us, because we don't naively map BNF productions to classes).

xml/XPathPredicate.cpp: (WebCore::XPath::Union::evaluate): Signal an error if either side is not a node-set.

xml/XPathStep.cpp: Removed an unnecesary include.

xml/XPathValue.cpp: (WebCore::XPath::Value::toNodeSet): Signal an error if conversion fails. (WebCore::XPath::Value::modifiableNodeSet): Ditto. (WebCore::XPath::Value::toNumber): Don't allow inputs that don't match XPath Number production (in particular, those using exponential notation).

10:33 AM Changeset in webkit [44360] by weinig@apple.com

6 edits in trunk

WebCore:

2009-06-01 Sam Weinig <sam@webkit.org>

Reviewed by Brady Eidson.

Part of https://bugs.webkit.org/show_bug.cgi?id=26100
Add missing event handler properties to the DOMWindow

Added oncontextmenu, oninput, and onmessage event handlers to
the DOMWindow. Aditionally, the onloadstart, onprogress, onstalled,
and onsuspend event handlers were implemented but not added to
DOMWindow.idl.

page/DOMWindow.cpp: (WebCore::DOMWindow::oninput): (WebCore::DOMWindow::setOninput): (WebCore::DOMWindow::onmessage): (WebCore::DOMWindow::setOnmessage): (WebCore::DOMWindow::oncontextmenu): (WebCore::DOMWindow::setOncontextmenu):
page/DOMWindow.h:
page/DOMWindow.idl:

LayoutTests:

2009-06-01 Sam Weinig <sam@webkit.org>

Reviewed by Brady Eidson.

Part of https://bugs.webkit.org/show_bug.cgi?id=26100
Add missing event handler properties to the DOMWindow

Added oncontextmenu, oninput, and onmessage event handlers to
the DOMWindow. Aditionally, the onloadstart, onprogress, onstalled,
and onsuspend event handlers were implemented but not added to
DOMWindow.idl.

fast/dom/Window/window-properties-expected.txt:

9:57 AM Changeset in webkit [44359] by xan@webkit.org

2 edits in trunk/JavaScriptCore

2009-06-02 Xan Lopez <xlopez@igalia.com>

Reviewed by Sam Weinig.

Use C-style comments in Platform.h so it can be included from C
files.

wtf/Platform.h:

7:54 AM Changeset in webkit [44358] by vestbo@webkit.org

2 edits in trunk/WebKitTools

2009-06-02 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>

Rubber-stamped by Adam Roben.

[Qt] Fix Perl warning about uninitialized value (passedConfiguration())

6:54 AM Changeset in webkit [44357] by vestbo@webkit.org

4 edits in trunk

2009-06-02 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>

Rubber-stamped by Simon Hausmann.

Use File::Spec->tmpdir instead of hardcoded paths for tempfile() dir

This fixes the Windows-build if the user does not have a /tmp directory.

2:34 AM Changeset in webkit [44356] by barraclough@apple.com

2 edits in trunk/JavaScriptCore

2009-06-02 Gavin Barraclough <barraclough@apple.com>

Reviewed by Oliver ">>" Hunt.

emitSlow_op_rshift is linking the wrong number of slow cases, if !supportsFloatingPoint().
Fixerate, and refactor/comment the code a little to make it clearer what is going on.

jit/JITArithmetic.cpp: (JSC::JIT::emit_op_rshift): (JSC::JIT::emitSlow_op_rshift):

2:17 AM Changeset in webkit [44355] by abarth@webkit.org

3 edits
2 deletes in trunk

Revert 44354. Test does not pass.

1:37 AM Changeset in webkit [44354] by abarth@webkit.org

3 edits
3 adds in trunk

WebCore:

2009-06-02 Grace Kloba <klobag@gmail.com>

Reviewed by Darin Adler. Landed by Adam Barth.

https://bugs.webkit.org/show_bug.cgi?id=26016

As HTMLKeygenElement is derived from HTMLSelectElement, HTMLOptionElement::ownerSelectElement() needs to check both selectTag and keygenTag.
Test: fast/dom/HTMLKeygenElement/keygen-option-select.html

html/HTMLOptionElement.cpp: (WebCore::HTMLOptionElement::ownerSelectElement):

LayoutTests:

2009-06-02 Grace Kloba <klobag@gmail.com>

Reviewed by Darin Adler. Landed by Adam Barth.

https://bugs.webkit.org/show_bug.cgi?id=26016

As HTMLKeygenElement is derived from HTMLSelectElement, HTMLOptionElement::ownerSelectElement() needs to check both selectTag and keygenTag. Added layout test to make sure set selected on option will affect keygen element.

fast/dom/HTMLKeygenElement: Added.
fast/dom/HTMLKeygenElement/keygen-option-select-expected.txt: Added.
fast/dom/HTMLKeygenElement/keygen-option-select.html: Added.

1:32 AM Changeset in webkit [44353] by abarth@webkit.org

1 edit in trunk/WebCore/ChangeLog

Add link to bug.

1:30 AM Changeset in webkit [44352] by abarth@webkit.org

8 edits
2 deletes in trunk

Revert 44351.

12:56 AM Changeset in webkit [44351] by abarth@webkit.org

8 edits
2 adds in trunk

WebCore:

2009-06-01 Ben Murdoch <benm@google.com>

Reviewed by Darin Adler. Landed by Adam Barth.

https://bugs.webkit.org/show_bug.cgi?id=25710

Fix a bug that causes database transactions to fail if a history navigation to a hash fragment of the same document is made while resources (e.g. an XHR) are loading.

Test: storage/hash-change-with-xhr.html

loader/DocumentLoader.cpp: (WebCore::DocumentLoader::stopLoading):
loader/DocumentLoader.h:
loader/FrameLoader.cpp: (WebCore::FrameLoader::stopLoading): (WebCore::FrameLoader::stopAllLoaders):
loader/FrameLoader.h:
loader/FrameLoaderTypes.h: (WebCore::):
page/Page.cpp: (WebCore::Page::goToItem):

LayoutTests:

2009-06-02 Ben Murdoch <benm@google.com>

Reviewed by Darin Alder. Landed by Adam Barth.

https://bugs.webkit.org/show_bug.cgi?id=25710

Fix a bug that causes database transactions to fail if a history navigation to a hash fragment of the same document is made while resources (e.g. an XHR) are loading.